projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
ofproto: Generalize facet_put__() so that it is more useful.
[openvswitch]
/
lib
/
unixctl.c
diff --git
a/lib/unixctl.c
b/lib/unixctl.c
index 43a174ccb657f19c2d77f3420ca485a3fc7f0157..6e0b19ff6fe0dd4a4de41b4c3f4c1a491a199ad7 100644
(file)
--- a/
lib/unixctl.c
+++ b/
lib/unixctl.c
@@
-34,17
+34,22
@@
#include "poll-loop.h"
#include "shash.h"
#include "socket-util.h"
#include "poll-loop.h"
#include "shash.h"
#include "socket-util.h"
+#include "svec.h"
#include "util.h"
#include "util.h"
+#include "vlog.h"
#ifndef SCM_CREDENTIALS
#include <time.h>
#endif
#ifndef SCM_CREDENTIALS
#include <time.h>
#endif
-#define THIS_MODULE VLM_unixctl
-#include "vlog.h"
+VLOG_DEFINE_THIS_MODULE(unixctl);
+
+COVERAGE_DEFINE(unixctl_received);
+COVERAGE_DEFINE(unixctl_replied);
\f
struct unixctl_command {
\f
struct unixctl_command {
- void (*cb)(struct unixctl_conn *, const char *args);
+ unixctl_cb_func *cb;
+ void *aux;
};
struct unixctl_conn {
};
struct unixctl_conn {
@@
-76,22
+81,34
@@
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 5);
static struct shash commands = SHASH_INITIALIZER(&commands);
static void
static struct shash commands = SHASH_INITIALIZER(&commands);
static void
-unixctl_help(struct unixctl_conn *conn, const char *args OVS_UNUSED)
+unixctl_help(struct unixctl_conn *conn, const char *args OVS_UNUSED,
+ void *aux OVS_UNUSED)
{
struct ds ds = DS_EMPTY_INITIALIZER;
struct shash_node *node;
{
struct ds ds = DS_EMPTY_INITIALIZER;
struct shash_node *node;
+ struct svec names;
+ const char *name;
+ size_t i;
ds_put_cstr(&ds, "The available commands are:\n");
ds_put_cstr(&ds, "The available commands are:\n");
+
+ svec_init(&names);
SHASH_FOR_EACH (node, &commands) {
SHASH_FOR_EACH (node, &commands) {
-
ds_put_format(&ds, "\t%s\n"
, node->name);
+
svec_add(&names
, node->name);
}
}
+ svec_sort(&names);
+
+ SVEC_FOR_EACH (i, name, &names) {
+ ds_put_format(&ds, "\t%s\n", name);
+ }
+ svec_destroy(&names);
+
unixctl_command_reply(conn, 214, ds_cstr(&ds));
ds_destroy(&ds);
}
void
unixctl_command_reply(conn, 214, ds_cstr(&ds));
ds_destroy(&ds);
}
void
-unixctl_command_register(const char *name,
- void (*cb)(struct unixctl_conn *, const char *args))
+unixctl_command_register(const char *name, unixctl_cb_func *cb, void *aux)
{
struct unixctl_command *command;
{
struct unixctl_command *command;
@@
-99,6
+116,7
@@
unixctl_command_register(const char *name,
|| shash_find_data(&commands, name) == cb);
command = xmalloc(sizeof *command);
command->cb = cb;
|| shash_find_data(&commands, name) == cb);
command = xmalloc(sizeof *command);
command->cb = cb;
+ command->aux = aux;
shash_add(&commands, name, command);
}
shash_add(&commands, name, command);
}
@@
-159,6
+177,9
@@
unixctl_command_reply(struct unixctl_conn *conn,
*
* - NULL, in which case <rundir>/<program>.<pid>.ctl is used.
*
*
* - NULL, in which case <rundir>/<program>.<pid>.ctl is used.
*
+ * - "none", in which case the function will return successfully but
+ * no socket will actually be created.
+ *
* - A name that does not start with '/', in which case it is put in
* <rundir>.
*
* - A name that does not start with '/', in which case it is put in
* <rundir>.
*
@@
-171,26
+192,28
@@
unixctl_command_reply(struct unixctl_conn *conn,
* "ovs-appctl --target=<program>" will fail.)
*
* Returns 0 if successful, otherwise a positive errno value. If successful,
* "ovs-appctl --target=<program>" will fail.)
*
* Returns 0 if successful, otherwise a positive errno value. If successful,
- * sets '*serverp' to the new unixctl_server, otherwise to NULL. */
+ * sets '*serverp' to the new unixctl_server (or to NULL if 'path' was "none"),
+ * otherwise to NULL. */
int
unixctl_server_create(const char *path, struct unixctl_server **serverp)
{
struct unixctl_server *server;
int error;
int
unixctl_server_create(const char *path, struct unixctl_server **serverp)
{
struct unixctl_server *server;
int error;
- unixctl_command_register("help", unixctl_help);
+ if (path && !strcmp(path, "none")) {
+ *serverp = NULL;
+ return 0;
+ }
+
+ unixctl_command_register("help", unixctl_help, NULL);
server = xmalloc(sizeof *server);
list_init(&server->conns);
if (path) {
server = xmalloc(sizeof *server);
list_init(&server->conns);
if (path) {
- if (path[0] == '/') {
- server->path = xstrdup(path);
- } else {
- server->path = xasprintf("%s/%s", ovs_rundir, path);
- }
+ server->path = abs_file_name(ovs_rundir(), path);
} else {
} else {
- server->path = xasprintf("%s/%s.%ld.ctl", ovs_rundir,
+ server->path = xasprintf("%s/%s.%ld.ctl", ovs_rundir
()
,
program_name, (long int) getpid());
}
program_name, (long int) getpid());
}
@@
-198,22
+221,21
@@
unixctl_server_create(const char *path, struct unixctl_server **serverp)
NULL);
if (server->fd < 0) {
error = -server->fd;
NULL);
if (server->fd < 0) {
error = -server->fd;
-
fprintf(stderr, "Could not initialize control socket %s (%s)\n
",
-
server->path, strerror(error)
);
+
ovs_error(error, "could not initialize control socket %s
",
+
server->path
);
goto error;
}
if (chmod(server->path, S_IRUSR | S_IWUSR) < 0) {
error = errno;
goto error;
}
if (chmod(server->path, S_IRUSR | S_IWUSR) < 0) {
error = errno;
- fprintf(stderr, "Failed to chmod control socket %s (%s)\n",
- server->path, strerror(error));
+ ovs_error(error, "failed to chmod control socket %s", server->path);
goto error;
}
if (listen(server->fd, 10) < 0) {
error = errno;
goto error;
}
if (listen(server->fd, 10) < 0) {
error = errno;
-
fprintf(stderr, "Failed to listen on control socket %s (%s)\n
",
-
server->path, strerror(error)
);
+
ovs_error(error, "Failed to listen on control socket %s
",
+
server->path
);
goto error;
}
goto error;
}
@@
-282,7
+304,7
@@
process_command(struct unixctl_conn *conn, char *s)
command = shash_find_data(&commands, name);
if (command) {
command = shash_find_data(&commands, name);
if (command) {
- command->cb(conn, args);
+ command->cb(conn, args
, command->aux
);
} else {
char *msg = xasprintf("\"%s\" is not a valid command", name);
unixctl_command_reply(conn, 400, msg);
} else {
char *msg = xasprintf("\"%s\" is not a valid command", name);
unixctl_command_reply(conn, 400, msg);
@@
-390,6
+412,10
@@
unixctl_server_run(struct unixctl_server *server)
struct unixctl_conn *conn, *next;
int i;
struct unixctl_conn *conn, *next;
int i;
+ if (!server) {
+ return;
+ }
+
for (i = 0; i < 10; i++) {
int fd = accept(server->fd, NULL, NULL);
if (fd < 0) {
for (i = 0; i < 10; i++) {
int fd = accept(server->fd, NULL, NULL);
if (fd < 0) {
@@
-401,8
+427,7
@@
unixctl_server_run(struct unixctl_server *server)
new_connection(server, fd);
}
new_connection(server, fd);
}
- LIST_FOR_EACH_SAFE (conn, next,
- struct unixctl_conn, node, &server->conns) {
+ LIST_FOR_EACH_SAFE (conn, next, node, &server->conns) {
int error = run_connection(conn);
if (error && error != EAGAIN) {
kill_connection(conn);
int error = run_connection(conn);
if (error && error != EAGAIN) {
kill_connection(conn);
@@
-415,8
+440,12
@@
unixctl_server_wait(struct unixctl_server *server)
{
struct unixctl_conn *conn;
{
struct unixctl_conn *conn;
+ if (!server) {
+ return;
+ }
+
poll_fd_wait(server->fd, POLLIN);
poll_fd_wait(server->fd, POLLIN);
- LIST_FOR_EACH (conn,
struct unixctl_conn,
node, &server->conns) {
+ LIST_FOR_EACH (conn, node, &server->conns) {
if (conn->state == S_RECV) {
poll_fd_wait(conn->fd, POLLIN);
} else if (conn->state == S_SEND) {
if (conn->state == S_RECV) {
poll_fd_wait(conn->fd, POLLIN);
} else if (conn->state == S_SEND) {
@@
-432,8
+461,7
@@
unixctl_server_destroy(struct unixctl_server *server)
if (server) {
struct unixctl_conn *conn, *next;
if (server) {
struct unixctl_conn *conn, *next;
- LIST_FOR_EACH_SAFE (conn, next,
- struct unixctl_conn, node, &server->conns) {
+ LIST_FOR_EACH_SAFE (conn, next, node, &server->conns) {
kill_connection(conn);
}
kill_connection(conn);
}
@@
-446,7
+474,7
@@
unixctl_server_destroy(struct unixctl_server *server)
\f
/* Connects to a Vlog server socket. 'path' should be the name of a Vlog
* server socket. If it does not start with '/', it will be prefixed with
\f
/* Connects to a Vlog server socket. 'path' should be the name of a Vlog
* server socket. If it does not start with '/', it will be prefixed with
- *
ovs_rundir (e.g. /var/run
).
+ *
the rundir (e.g. /usr/local/var/run/openvswitch
).
*
* Returns 0 if successful, otherwise a positive errno value. If successful,
* sets '*clientp' to the new unixctl_client, otherwise to NULL. */
*
* Returns 0 if successful, otherwise a positive errno value. If successful,
* sets '*clientp' to the new unixctl_client, otherwise to NULL. */
@@
-460,11
+488,7
@@
unixctl_client_create(const char *path, struct unixctl_client **clientp)
/* Determine location. */
client = xmalloc(sizeof *client);
/* Determine location. */
client = xmalloc(sizeof *client);
- if (path[0] == '/') {
- client->connect_path = xstrdup(path);
- } else {
- client->connect_path = xasprintf("%s/%s", ovs_rundir, path);
- }
+ client->connect_path = abs_file_name(ovs_rundir(), path);
client->bind_path = xasprintf("/tmp/vlog.%ld.%d",
(long int) getpid(), counter++);
client->bind_path = xasprintf("/tmp/vlog.%ld.%d",
(long int) getpid(), counter++);