projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
datapath: Check for backported dev_get_by_index_rcu().
[openvswitch]
/
lib
/
process.c
diff --git
a/lib/process.c
b/lib/process.c
index af867ef4e01f5f349c650487089c5327aa3f4149..8263437c136ce2c86d94937ae96cd6a006f24791 100644
(file)
--- a/
lib/process.c
+++ b/
lib/process.c
@@
-1,5
+1,5
@@
/*
/*
- * Copyright (c) 2008, 2009, 2010 Nicira Networks.
+ * Copyright (c) 2008, 2009, 2010
, 2011
Nicira Networks.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@
-32,10
+32,15
@@
#include "poll-loop.h"
#include "socket-util.h"
#include "util.h"
#include "poll-loop.h"
#include "socket-util.h"
#include "util.h"
-
-#define THIS_MODULE VLM_process
#include "vlog.h"
#include "vlog.h"
+VLOG_DEFINE_THIS_MODULE(process);
+
+COVERAGE_DEFINE(process_run);
+COVERAGE_DEFINE(process_run_capture);
+COVERAGE_DEFINE(process_sigchld);
+COVERAGE_DEFINE(process_start);
+
struct process {
struct list node;
char *name;
struct process {
struct list node;
char *name;
@@
-190,6
+195,7
@@
process_start(char **argv,
struct process **pp)
{
sigset_t oldsigs;
struct process **pp)
{
sigset_t oldsigs;
+ int nullfd;
pid_t pid;
int error;
pid_t pid;
int error;
@@
-200,6
+206,15
@@
process_start(char **argv,
return error;
}
return error;
}
+ if (n_null_fds) {
+ nullfd = get_null_fd();
+ if (nullfd < 0) {
+ return -nullfd;
+ }
+ } else {
+ nullfd = -1;
+ }
+
block_sigchld(&oldsigs);
pid = fork();
if (pid < 0) {
block_sigchld(&oldsigs);
pid = fork();
if (pid < 0) {
@@
-220,15
+235,17
@@
process_start(char **argv,
unblock_sigchld(&oldsigs);
for (fd = 0; fd < fd_max; fd++) {
if (is_member(fd, null_fds, n_null_fds)) {
unblock_sigchld(&oldsigs);
for (fd = 0; fd < fd_max; fd++) {
if (is_member(fd, null_fds, n_null_fds)) {
- /* We can't use get_null_fd() here because we might have
- * already closed its fd. */
- int nullfd = open("/dev/null", O_RDWR);
dup2(nullfd, fd);
dup2(nullfd, fd);
- close(nullfd);
-
} else if (fd >= 3
&& !is_member(fd, keep_fds, n_keep_fds)) {
+ } else if (fd >= 3 && fd != nullfd
+
&& !is_member(fd, keep_fds, n_keep_fds)) {
close(fd);
}
}
close(fd);
}
}
+ if (nullfd >= 0
+ && !is_member(nullfd, keep_fds, n_keep_fds)
+ && !is_member(nullfd, null_fds, n_null_fds)) {
+ close(nullfd);
+ }
execvp(argv[0], argv);
fprintf(stderr, "execvp(\"%s\") failed: %s\n",
argv[0], strerror(errno));
execvp(argv[0], argv);
fprintf(stderr, "execvp(\"%s\") failed: %s\n",
argv[0], strerror(errno));
@@
-517,7
+534,7
@@
process_run_capture(char **argv, char **stdout_log, char **stderr_log,
block_sigchld(&oldsigs);
pid = fork();
if (pid < 0) {
block_sigchld(&oldsigs);
pid = fork();
if (pid < 0) {
-
int
error = errno;
+ error = errno;
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(error));
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(error));
@@
-590,7
+607,7
@@
sigchld_handler(int signr OVS_UNUSED)
struct process *p;
COVERAGE_INC(process_sigchld);
struct process *p;
COVERAGE_INC(process_sigchld);
- LIST_FOR_EACH (p,
struct process,
node, &all_processes) {
+ LIST_FOR_EACH (p, node, &all_processes) {
if (!p->exited) {
int retval, status;
do {
if (!p->exited) {
int retval, status;
do {