projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
datapath: Avoid calling flow_hash() twice for the same key.
[openvswitch]
/
lib
/
process.c
diff --git
a/lib/process.c
b/lib/process.c
index 1f6b00fc99191a67ae50158a32cc6cc27b59d1c9..6e9ea8eca0ed8ff3839236bc0f20dc81e91aa149 100644
(file)
--- a/
lib/process.c
+++ b/
lib/process.c
@@
-32,10
+32,15
@@
#include "poll-loop.h"
#include "socket-util.h"
#include "util.h"
#include "poll-loop.h"
#include "socket-util.h"
#include "util.h"
-
-#define THIS_MODULE VLM_process
#include "vlog.h"
#include "vlog.h"
+VLOG_DEFINE_THIS_MODULE(process);
+
+COVERAGE_DEFINE(process_run);
+COVERAGE_DEFINE(process_run_capture);
+COVERAGE_DEFINE(process_sigchld);
+COVERAGE_DEFINE(process_start);
+
struct process {
struct list node;
char *name;
struct process {
struct list node;
char *name;
@@
-103,7
+108,7
@@
process_escape_args(char **argv)
if (argp != argv) {
ds_put_char(&ds, ' ');
}
if (argp != argv) {
ds_put_char(&ds, ' ');
}
- if (arg[strcspn(arg, " \t\r\n\v\\")]) {
+ if (arg[strcspn(arg, " \t\r\n\v\\
\'\"
")]) {
ds_put_char(&ds, '"');
for (p = arg; *p; p++) {
if (*p == '\\' || *p == '\"') {
ds_put_char(&ds, '"');
for (p = arg; *p; p++) {
if (*p == '\\' || *p == '\"') {
@@
-161,7
+166,7
@@
process_register(const char *name, pid_t pid)
assert(sigchld_is_blocked());
assert(sigchld_is_blocked());
- p = x
calloc(1,
sizeof *p);
+ p = x
zalloc(
sizeof *p);
p->pid = pid;
slash = strrchr(name, '/');
p->name = xstrdup(slash ? slash + 1 : name);
p->pid = pid;
slash = strrchr(name, '/');
p->name = xstrdup(slash ? slash + 1 : name);
@@
-201,17
+206,14
@@
process_start(char **argv,
}
block_sigchld(&oldsigs);
}
block_sigchld(&oldsigs);
- fatal_signal_block();
pid = fork();
if (pid < 0) {
pid = fork();
if (pid < 0) {
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(errno));
return errno;
} else if (pid) {
/* Running in parent process. */
*pp = process_register(argv[0], pid);
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(errno));
return errno;
} else if (pid) {
/* Running in parent process. */
*pp = process_register(argv[0], pid);
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
return 0;
} else {
unblock_sigchld(&oldsigs);
return 0;
} else {
@@
-220,7
+222,6
@@
process_start(char **argv,
int fd;
fatal_signal_fork();
int fd;
fatal_signal_fork();
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
for (fd = 0; fd < fd_max; fd++) {
if (is_member(fd, null_fds, n_null_fds)) {
unblock_sigchld(&oldsigs);
for (fd = 0; fd < fd_max; fd++) {
if (is_member(fd, null_fds, n_null_fds)) {
@@
-289,7
+290,7
@@
process_exited(struct process *p)
return true;
} else {
char buf[_POSIX_PIPE_BUF];
return true;
} else {
char buf[_POSIX_PIPE_BUF];
-
read(fds[0], buf, sizeof buf
);
+
ignore(read(fds[0], buf, sizeof buf)
);
return false;
}
}
return false;
}
}
@@
-419,15
+420,13
@@
stream_open(struct stream *s)
static void
stream_read(struct stream *s)
{
static void
stream_read(struct stream *s)
{
- int error = 0;
-
if (s->fds[0] < 0) {
return;
}
if (s->fds[0] < 0) {
return;
}
- error = 0;
for (;;) {
char buffer[512];
for (;;) {
char buffer[512];
+ int error;
size_t n;
error = read_fully(s->fds[0], buffer, sizeof buffer, &n);
size_t n;
error = read_fully(s->fds[0], buffer, sizeof buffer, &n);
@@
-521,12
+520,10
@@
process_run_capture(char **argv, char **stdout_log, char **stderr_log,
}
block_sigchld(&oldsigs);
}
block_sigchld(&oldsigs);
- fatal_signal_block();
pid = fork();
if (pid < 0) {
pid = fork();
if (pid < 0) {
-
int
error = errno;
+ error = errno;
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(error));
unblock_sigchld(&oldsigs);
VLOG_WARN("fork failed: %s", strerror(error));
@@
-539,7
+536,6
@@
process_run_capture(char **argv, char **stdout_log, char **stderr_log,
struct process *p;
p = process_register(argv[0], pid);
struct process *p;
p = process_register(argv[0], pid);
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
close(s_stdout.fds[1]);
unblock_sigchld(&oldsigs);
close(s_stdout.fds[1]);
@@
-575,7
+571,6
@@
process_run_capture(char **argv, char **stdout_log, char **stderr_log,
int i;
fatal_signal_fork();
int i;
fatal_signal_fork();
- fatal_signal_unblock();
unblock_sigchld(&oldsigs);
dup2(get_null_fd(), 0);
unblock_sigchld(&oldsigs);
dup2(get_null_fd(), 0);
@@
-600,7
+595,7
@@
sigchld_handler(int signr OVS_UNUSED)
struct process *p;
COVERAGE_INC(process_sigchld);
struct process *p;
COVERAGE_INC(process_sigchld);
- LIST_FOR_EACH (p,
struct process,
node, &all_processes) {
+ LIST_FOR_EACH (p, node, &all_processes) {
if (!p->exited) {
int retval, status;
do {
if (!p->exited) {
int retval, status;
do {
@@
-617,7
+612,7
@@
sigchld_handler(int signr OVS_UNUSED)
}
}
}
}
}
}
-
write(fds[1], "", 1
);
+
ignore(write(fds[1], "", 1)
);
}
static bool
}
static bool