projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
util: Avoid uninitialized pointer complaints from Coverity.
[openvswitch]
/
lib
/
netdev-provider.h
diff --git
a/lib/netdev-provider.h
b/lib/netdev-provider.h
index 58d51d7b70ea3a9ea694a65cf2995d952c0aed72..be51c48a541f8d94d3847edc7dbf79c8a159efa3 100644
(file)
--- a/
lib/netdev-provider.h
+++ b/
lib/netdev-provider.h
@@
-1,5
+1,5
@@
/*
/*
- * Copyright (c) 2009, 2010 Nicira Networks.
+ * Copyright (c) 2009, 2010
, 2011
Nicira Networks.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@
-29,11
+29,6
@@
extern "C" {
#endif
extern "C" {
#endif
-struct arg {
- char *key;
- char *value;
-};
-
/* A network device (e.g. an Ethernet device).
*
* This structure should be treated as opaque by network device
/* A network device (e.g. an Ethernet device).
*
* This structure should be treated as opaque by network device
@@
-44,11
+39,11
@@
struct netdev_dev {
this device. */
int ref_cnt; /* Times this devices was opened. */
struct shash_node *node; /* Pointer to element in global map. */
this device. */
int ref_cnt; /* Times this devices was opened. */
struct shash_node *node; /* Pointer to element in global map. */
- struct arg *args; /* Argument list from last config. */
- int n_args; /* Number of arguments in 'args'. */
+ struct shash args; /* Argument list from last config. */
};
void netdev_dev_init(struct netdev_dev *, const char *name,
};
void netdev_dev_init(struct netdev_dev *, const char *name,
+ const struct shash *args,
const struct netdev_class *);
void netdev_dev_uninit(struct netdev_dev *, bool destroy);
const char *netdev_dev_get_type(const struct netdev_dev *);
const struct netdev_class *);
void netdev_dev_uninit(struct netdev_dev *, bool destroy);
const char *netdev_dev_get_type(const struct netdev_dev *);
@@
-143,12
+138,12
@@
struct netdev_class {
* called. */
void (*destroy)(struct netdev_dev *netdev_dev);
* called. */
void (*destroy)(struct netdev_dev *netdev_dev);
- /*
Reconfigures the device 'netdev_dev' with
'args'.
+ /*
Changes the device 'netdev_dev''s configuration to
'args'.
*
* If this netdev class does not support reconfiguring a netdev
* device, this may be a null pointer.
*/
*
* If this netdev class does not support reconfiguring a netdev
* device, this may be a null pointer.
*/
- int (*
reconfigure
)(struct netdev_dev *netdev_dev, const struct shash *args);
+ int (*
set_config
)(struct netdev_dev *netdev_dev, const struct shash *args);
/* Attempts to open a network device. On success, sets 'netdevp'
* to the new network device.
/* Attempts to open a network device. On success, sets 'netdevp'
* to the new network device.
@@
-242,7
+237,10
@@
struct netdev_class {
*
* The MTU is the maximum size of transmitted (and received) packets, in
* bytes, not including the hardware header; thus, this is typically 1500
*
* The MTU is the maximum size of transmitted (and received) packets, in
* bytes, not including the hardware header; thus, this is typically 1500
- * bytes for Ethernet devices.*/
+ * bytes for Ethernet devices.
+ *
+ * If 'netdev' does not have an MTU (e.g. as some tunnels do not), then
+ * this function should set '*mtup' to INT_MAX. */
int (*get_mtu)(const struct netdev *netdev, int *mtup);
/* Returns the ifindex of 'netdev', if successful, as a positive number.
int (*get_mtu)(const struct netdev *netdev, int *mtup);
/* Returns the ifindex of 'netdev', if successful, as a positive number.