projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
stp: Fix memory leak.
[openvswitch]
/
lib
/
dpif-netdev.c
diff --git
a/lib/dpif-netdev.c
b/lib/dpif-netdev.c
index 8bd9648de2dbeefd35fe72fbc2bc415a41d7eda3..e9fb216feff3eb3083b4f837353c095d41e678bd 100644
(file)
--- a/
lib/dpif-netdev.c
+++ b/
lib/dpif-netdev.c
@@
-1,5
+1,5
@@
/*
/*
- * Copyright (c) 2009 Nicira Networks.
+ * Copyright (c) 2009
, 2010
Nicira Networks.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@
-196,7
+196,7
@@
create_dpif_netdev(struct dp_netdev *dp)
dp->open_cnt++;
dp->open_cnt++;
- dpname = xasprintf("
netdev:
dp%d", dp->dp_idx);
+ dpname = xasprintf("dp%d", dp->dp_idx);
dpif = xmalloc(sizeof *dpif);
dpif_init(&dpif->dpif, &dpif_netdev_class, dpname, dp->dp_idx, dp->dp_idx);
dpif->dp = dp;
dpif = xmalloc(sizeof *dpif);
dpif_init(&dpif->dpif, &dpif_netdev_class, dpname, dp->dp_idx, dp->dp_idx);
dpif->dp = dp;
@@
-237,7
+237,7
@@
create_dp_netdev(const char *name, int dp_idx, struct dpif **dpifp)
error = do_add_port(dp, name, ODP_PORT_INTERNAL, ODPP_LOCAL);
if (error) {
dp_netdev_free(dp);
error = do_add_port(dp, name, ODP_PORT_INTERNAL, ODPP_LOCAL);
if (error) {
dp_netdev_free(dp);
- return
error
;
+ return
ENODEV
;
}
*dpifp = create_dpif_netdev(dp);
}
*dpifp = create_dpif_netdev(dp);
@@
-245,20
+245,20
@@
create_dp_netdev(const char *name, int dp_idx, struct dpif **dpifp)
}
static int
}
static int
-dpif_netdev_open(const char *name
UNUSED, char *suffix
, bool create,
+dpif_netdev_open(const char *name
, const char *type UNUSED
, bool create,
struct dpif **dpifp)
{
if (create) {
struct dpif **dpifp)
{
if (create) {
- if (find_dp_netdev(
suffix
)) {
+ if (find_dp_netdev(
name
)) {
return EEXIST;
} else {
return EEXIST;
} else {
- int dp_idx = name_to_dp_idx(
suffix
);
+ int dp_idx = name_to_dp_idx(
name
);
if (dp_idx >= 0) {
if (dp_idx >= 0) {
- return create_dp_netdev(
suffix
, dp_idx, dpifp);
+ return create_dp_netdev(
name
, dp_idx, dpifp);
} else {
/* Scan for unused dp_idx number. */
for (dp_idx = 0; dp_idx < N_DP_NETDEVS; dp_idx++) {
} else {
/* Scan for unused dp_idx number. */
for (dp_idx = 0; dp_idx < N_DP_NETDEVS; dp_idx++) {
- int error = create_dp_netdev(
suffix
, dp_idx, dpifp);
+ int error = create_dp_netdev(
name
, dp_idx, dpifp);
if (error != EBUSY) {
return error;
}
if (error != EBUSY) {
return error;
}
@@
-269,7
+269,7
@@
dpif_netdev_open(const char *name UNUSED, char *suffix, bool create,
}
}
} else {
}
}
} else {
- struct dp_netdev *dp = find_dp_netdev(
suffix
);
+ struct dp_netdev *dp = find_dp_netdev(
name
);
if (dp) {
*dpifp = create_dpif_netdev(dp);
return 0;
if (dp) {
*dpifp = create_dpif_netdev(dp);
return 0;
@@
-363,6
+363,7
@@
do_add_port(struct dp_netdev *dp, const char *devname, uint16_t flags,
{
bool internal = (flags & ODP_PORT_INTERNAL) != 0;
struct dp_netdev_port *port;
{
bool internal = (flags & ODP_PORT_INTERNAL) != 0;
struct dp_netdev_port *port;
+ struct netdev_options netdev_options;
struct netdev *netdev;
int mtu;
int error;
struct netdev *netdev;
int mtu;
int error;
@@
-370,13
+371,17
@@
do_add_port(struct dp_netdev *dp, const char *devname, uint16_t flags,
/* XXX reject devices already in some dp_netdev. */
/* Open and validate network device. */
/* XXX reject devices already in some dp_netdev. */
/* Open and validate network device. */
- if (!internal) {
- error = netdev_open(devname, NETDEV_ETH_TYPE_ANY, &netdev);
+ memset(&netdev_options, 0, sizeof netdev_options);
+ netdev_options.name = devname;
+ netdev_options.ethertype = NETDEV_ETH_TYPE_ANY;
+ netdev_options.may_create = true;
+ if (internal) {
+ netdev_options.type = "tap";
} else {
} else {
- char *tapname = xasprintf("tap:%s", devname);
- error = netdev_open(tapname, NETDEV_ETH_TYPE_ANY, &netdev);
- free(tapname);
+ netdev_options.may_open = true;
}
}
+
+ error = netdev_open(&netdev_options, &netdev);
if (error) {
return error;
}
if (error) {
return error;
}
@@
-468,6
+473,7
@@
static int
do_del_port(struct dp_netdev *dp, uint16_t port_no)
{
struct dp_netdev_port *port;
do_del_port(struct dp_netdev *dp, uint16_t port_no)
{
struct dp_netdev_port *port;
+ char *name;
int error;
error = get_port_by_number(dp, port_no, &port);
int error;
error = get_port_by_number(dp, port_no, &port);
@@
-480,7
+486,10
@@
do_del_port(struct dp_netdev *dp, uint16_t port_no)
dp->n_ports--;
dp->serial++;
dp->n_ports--;
dp->serial++;
+ name = xstrdup(netdev_get_name(port->netdev));
netdev_close(port->netdev);
netdev_close(port->netdev);
+
+ free(name);
free(port);
return 0;
free(port);
return 0;
@@
-665,7
+674,7
@@
dp_netdev_lookup_flow(const struct dp_netdev *dp, const flow_t *key)
}
static void
}
static void
-answer_flow_query(
const struct dp_netdev_flow *flow
,
+answer_flow_query(
struct dp_netdev_flow *flow, uint32_t query_flags
,
struct odp_flow *odp_flow)
{
if (flow) {
struct odp_flow *odp_flow)
{
if (flow) {
@@
-683,6
+692,11
@@
answer_flow_query(const struct dp_netdev_flow *flow,
n * sizeof *odp_flow->actions);
odp_flow->n_actions = flow->n_actions;
}
n * sizeof *odp_flow->actions);
odp_flow->n_actions = flow->n_actions;
}
+
+ if (query_flags & ODPFF_ZERO_TCP_FLAGS) {
+ flow->tcp_ctl = 0;
+ }
+
} else {
odp_flow->stats.error = ENOENT;
}
} else {
odp_flow->stats.error = ENOENT;
}
@@
-696,7
+710,8
@@
dpif_netdev_flow_get(const struct dpif *dpif, struct odp_flow flows[], int n)
for (i = 0; i < n; i++) {
struct odp_flow *odp_flow = &flows[i];
for (i = 0; i < n; i++) {
struct odp_flow *odp_flow = &flows[i];
- answer_flow_query(dp_netdev_lookup_flow(dp, &odp_flow->key), odp_flow);
+ answer_flow_query(dp_netdev_lookup_flow(dp, &odp_flow->key),
+ odp_flow->flags, odp_flow);
}
return 0;
}
}
return 0;
}
@@
-852,7
+867,7
@@
dpif_netdev_flow_del(struct dpif *dpif, struct odp_flow *odp_flow)
flow = dp_netdev_lookup_flow(dp, &odp_flow->key);
if (flow) {
flow = dp_netdev_lookup_flow(dp, &odp_flow->key);
if (flow) {
- answer_flow_query(flow, odp_flow);
+ answer_flow_query(flow,
0,
odp_flow);
dp_netdev_free_flow(dp, flow);
return 0;
} else {
dp_netdev_free_flow(dp, flow);
return 0;
} else {
@@
-872,7
+887,7
@@
dpif_netdev_flow_list(const struct dpif *dpif, struct odp_flow flows[], int n)
if (i >= n) {
break;
}
if (i >= n) {
break;
}
- answer_flow_query(flow, &flows[i++]);
+ answer_flow_query(flow,
0,
&flows[i++]);
}
return hmap_count(&dp->flow_table);
}
}
return hmap_count(&dp->flow_table);
}
@@
-1288,7
+1303,6
@@
dp_netdev_execute_actions(struct dp_netdev *dp,
}
const struct dpif_class dpif_netdev_class = {
}
const struct dpif_class dpif_netdev_class = {
- "netdev",
"netdev",
dp_netdev_run,
dp_netdev_wait,
"netdev",
dp_netdev_run,
dp_netdev_wait,