projects
/
openvswitch
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
ofp-util: Add macros for composing error codes.
[openvswitch]
/
CodingStyle
diff --git
a/CodingStyle
b/CodingStyle
index 126b45a89b7cb9ccc021043a44718e36c672fcec..2ee189faf0f4bfe4b2734aeebce182392ef41943 100644
(file)
--- a/
CodingStyle
+++ b/
CodingStyle
@@
-156,6
+156,12
@@
parameters and their corresponding size parameters should be paired.
...
}
...
}
+Functions that destroy an instance of a dynamically-allocated type
+should accept and ignore a null pointer argument. Code that calls
+such a function (including the C standard library function free())
+should omit a null-pointer check. We find that this usually makes
+code easier to read.
+
FUNCTION PROTOTYPES
FUNCTION PROTOTYPES
@@
-168,7
+174,7
@@
prototype:
Omit parameter names from function prototypes when the names do not
give useful information, e.g.:
Omit parameter names from function prototypes when the names do not
give useful information, e.g.:
- int netdev_get_mtu(const struct netdev *);
+ int netdev_get_mtu(const struct netdev *
, int *mtup
);
STATEMENTS
STATEMENTS
@@
-412,13
+418,8
@@
Exception 1: Put a space after (but not before) the "sizeof" keyword.
Exception 2: Put a space between the () used in a cast and the
expression whose type is cast: (void *) 0.
Exception 2: Put a space between the () used in a cast and the
expression whose type is cast: (void *) 0.
- Break long lines before binary operators and the ternary operators ?
-and :, rather than after them, e.g.
-
- if (first_long_condition() || second_long_condition()
- || third_long_condition())
-
-and
+ Break long lines before the ternary operators ? and :, rather than
+after them, e.g.
return (out_port != VIGP_CONTROL_PATH
? alpheus_output_port(dp, skb, out_port)
return (out_port != VIGP_CONTROL_PATH
? alpheus_output_port(dp, skb, out_port)
@@
-430,7
+431,9
@@
and
precedence makes it necessary, or unless the operands are themselves
expressions that use && and ||. Thus:
precedence makes it necessary, or unless the operands are themselves
expressions that use && and ||. Thus:
- if (!isdigit(s[0]) || !isdigit(s[1]) || !isdigit(s[2])) {
+ if (!isdigit((unsigned char)s[0])
+ || !isdigit((unsigned char)s[1])
+ || !isdigit((unsigned char)s[2])) {
printf("string %s does not start with 3-digit code\n", s);
}
printf("string %s does not start with 3-digit code\n", s);
}