1 /* Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
18 #include "byte-order.h"
21 #include <arpa/inet.h>
24 #include <sys/socket.h>
26 #include <openflow/openflow.h>
31 #include <sys/socket.h>
32 #include <sys/types.h>
36 #include "classifier.h"
41 #include "dynamic-string.h"
48 #include "mac-learning.h"
52 #include "ofp-print.h"
54 #include "ofproto/netflow.h"
55 #include "ofproto/ofproto.h"
56 #include "ovsdb-data.h"
58 #include "poll-loop.h"
62 #include "socket-util.h"
63 #include "stream-ssl.h"
65 #include "system-stats.h"
70 #include "vswitchd/vswitch-idl.h"
71 #include "xenserver.h"
73 #include "sflow_api.h"
75 VLOG_DEFINE_THIS_MODULE(bridge);
77 COVERAGE_DEFINE(bridge_flush);
78 COVERAGE_DEFINE(bridge_process_flow);
79 COVERAGE_DEFINE(bridge_process_cfm);
80 COVERAGE_DEFINE(bridge_process_lacp);
81 COVERAGE_DEFINE(bridge_reconfigure);
82 COVERAGE_DEFINE(bridge_lacp_update);
90 struct dst builtin[32];
95 static void dst_set_init(struct dst_set *);
96 static void dst_set_add(struct dst_set *, const struct dst *);
97 static void dst_set_free(struct dst_set *);
100 /* These members are always valid. */
101 struct port *port; /* Containing port. */
102 size_t port_ifidx; /* Index within containing port. */
103 char *name; /* Host network device name. */
104 tag_type tag; /* Tag associated with this interface. */
105 long long delay_expires; /* Time after which 'enabled' may change. */
107 /* These members are valid only after bridge_reconfigure() causes them to
109 struct hmap_node dp_ifidx_node; /* In struct bridge's "ifaces" hmap. */
110 int dp_ifidx; /* Index within kernel datapath. */
111 struct netdev *netdev; /* Network device. */
112 bool enabled; /* May be chosen for flows? */
113 bool up; /* Is the interface up? */
114 const char *type; /* Usually same as cfg->type. */
115 struct cfm *cfm; /* Connectivity Fault Management */
116 const struct ovsrec_interface *cfg;
118 /* LACP information. */
119 uint16_t lacp_priority; /* LACP port priority. */
122 #define BOND_MASK 0xff
124 int iface_idx; /* Index of assigned iface, or -1 if none. */
125 uint64_t tx_bytes; /* Count of bytes recently transmitted. */
126 tag_type iface_tag; /* Tag associated with iface_idx. */
130 BM_TCP, /* Transport Layer Load Balance. */
131 BM_SLB, /* Source Load Balance. */
132 BM_AB /* Active Backup. */
135 #define MAX_MIRRORS 32
136 typedef uint32_t mirror_mask_t;
137 #define MIRROR_MASK_C(X) UINT32_C(X)
138 BUILD_ASSERT_DECL(sizeof(mirror_mask_t) * CHAR_BIT >= MAX_MIRRORS);
140 struct bridge *bridge;
143 struct uuid uuid; /* UUID of this "mirror" record in database. */
145 /* Selection criteria. */
146 struct shash src_ports; /* Name is port name; data is always NULL. */
147 struct shash dst_ports; /* Name is port name; data is always NULL. */
152 struct port *out_port;
156 #define FLOOD_PORT ((struct port *) 1) /* The 'flood' output port. */
158 struct bridge *bridge;
160 int vlan; /* -1=trunk port, else a 12-bit VLAN ID. */
161 unsigned long *trunks; /* Bitmap of trunked VLANs, if 'vlan' == -1.
162 * NULL if all VLANs are trunked. */
163 const struct ovsrec_port *cfg;
167 struct netdev_monitor *monitor; /* Tracks carrier. NULL if miimon. */
168 long long int miimon_interval; /* Miimon status refresh interval. */
169 long long int miimon_next_update; /* Time of next miimon update. */
171 /* An ordinary bridge port has 1 interface.
172 * A bridge port for bonding has at least 2 interfaces. */
173 struct iface **ifaces;
174 size_t n_ifaces, allocated_ifaces;
177 enum bond_mode bond_mode; /* Type of the bond. BM_SLB is the default. */
178 int active_iface; /* Ifidx on which bcasts accepted, or -1. */
179 tag_type active_iface_tag; /* Tag for bcast flows. */
180 tag_type no_ifaces_tag; /* Tag for flows when all ifaces disabled. */
181 int updelay, downdelay; /* Delay before iface goes up/down, in ms. */
182 bool bond_fake_iface; /* Fake a bond interface for legacy compat? */
183 long long int bond_next_fake_iface_update; /* Time of next update. */
185 /* LACP information. */
186 struct lacp *lacp; /* LACP object. NULL if LACP is disabled. */
187 bool lacp_active; /* True if LACP is active */
188 bool lacp_fast; /* True if LACP is in fast mode. */
189 uint16_t lacp_priority; /* LACP system priority. */
191 /* SLB specific bonding info. */
192 struct bond_entry *bond_hash; /* An array of (BOND_MASK + 1) elements. */
193 int bond_rebalance_interval; /* Interval between rebalances, in ms. */
194 long long int bond_next_rebalance; /* Next rebalancing time. */
196 /* Port mirroring info. */
197 mirror_mask_t src_mirrors; /* Mirrors triggered when packet received. */
198 mirror_mask_t dst_mirrors; /* Mirrors triggered when packet sent. */
199 bool is_mirror_output_port; /* Does port mirroring send frames here? */
203 struct list node; /* Node in global list of bridges. */
204 char *name; /* User-specified arbitrary name. */
205 struct mac_learning *ml; /* MAC learning table. */
206 uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
207 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
208 const struct ovsrec_bridge *cfg;
210 /* OpenFlow switch processing. */
211 struct ofproto *ofproto; /* OpenFlow switch. */
213 /* Kernel datapath information. */
214 struct dpif *dpif; /* Datapath. */
215 struct hmap ifaces; /* Contains "struct iface"s. */
219 size_t n_ports, allocated_ports;
220 struct shash iface_by_name; /* "struct iface"s indexed by name. */
221 struct shash port_by_name; /* "struct port"s indexed by name. */
224 bool has_bonded_ports;
229 /* Port mirroring. */
230 struct mirror *mirrors[MAX_MIRRORS];
233 /* List of all bridges. */
234 static struct list all_bridges = LIST_INITIALIZER(&all_bridges);
236 /* OVSDB IDL used to obtain configuration. */
237 static struct ovsdb_idl *idl;
239 /* Each time this timer expires, the bridge fetches systems and interface
240 * statistics and pushes them into the database. */
241 #define STATS_INTERVAL (5 * 1000) /* In milliseconds. */
242 static long long int stats_timer = LLONG_MIN;
244 static struct bridge *bridge_create(const struct ovsrec_bridge *br_cfg);
245 static void bridge_destroy(struct bridge *);
246 static struct bridge *bridge_lookup(const char *name);
247 static unixctl_cb_func bridge_unixctl_dump_flows;
248 static unixctl_cb_func bridge_unixctl_reconnect;
249 static int bridge_run_one(struct bridge *);
250 static size_t bridge_get_controllers(const struct bridge *br,
251 struct ovsrec_controller ***controllersp);
252 static void bridge_reconfigure_one(struct bridge *);
253 static void bridge_reconfigure_remotes(struct bridge *,
254 const struct sockaddr_in *managers,
256 static void bridge_get_all_ifaces(const struct bridge *, struct shash *ifaces);
257 static void bridge_fetch_dp_ifaces(struct bridge *);
258 static void bridge_flush(struct bridge *);
259 static void bridge_pick_local_hw_addr(struct bridge *,
260 uint8_t ea[ETH_ADDR_LEN],
261 struct iface **hw_addr_iface);
262 static uint64_t bridge_pick_datapath_id(struct bridge *,
263 const uint8_t bridge_ea[ETH_ADDR_LEN],
264 struct iface *hw_addr_iface);
265 static struct iface *bridge_get_local_iface(struct bridge *);
266 static uint64_t dpid_from_hash(const void *, size_t nbytes);
268 static unixctl_cb_func bridge_unixctl_fdb_show;
269 static unixctl_cb_func qos_unixctl_show;
271 static void bond_init(void);
272 static void bond_run(struct port *);
273 static void bond_wait(struct port *);
274 static void bond_rebalance_port(struct port *);
275 static void bond_send_learning_packets(struct port *);
276 static void bond_enable_slave(struct iface *iface, bool enable);
278 static void port_run(struct port *);
279 static void port_wait(struct port *);
280 static struct port *port_create(struct bridge *, const char *name);
281 static void port_reconfigure(struct port *, const struct ovsrec_port *);
282 static void port_del_ifaces(struct port *, const struct ovsrec_port *);
283 static void port_destroy(struct port *);
284 static struct port *port_lookup(const struct bridge *, const char *name);
285 static struct iface *port_lookup_iface(const struct port *, const char *name);
286 static struct port *port_from_dp_ifidx(const struct bridge *,
288 static void port_update_bonding(struct port *);
289 static void port_update_lacp(struct port *);
291 static void mirror_create(struct bridge *, struct ovsrec_mirror *);
292 static void mirror_destroy(struct mirror *);
293 static void mirror_reconfigure(struct bridge *);
294 static void mirror_reconfigure_one(struct mirror *, struct ovsrec_mirror *);
295 static bool vlan_is_mirrored(const struct mirror *, int vlan);
297 static struct iface *iface_create(struct port *port,
298 const struct ovsrec_interface *if_cfg);
299 static void iface_destroy(struct iface *);
300 static struct iface *iface_lookup(const struct bridge *, const char *name);
301 static struct iface *iface_find(const char *name);
302 static struct iface *iface_from_dp_ifidx(const struct bridge *,
304 static void iface_set_mac(struct iface *);
305 static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
306 static void iface_update_qos(struct iface *, const struct ovsrec_qos *);
307 static void iface_update_cfm(struct iface *);
308 static void iface_refresh_cfm_stats(struct iface *iface);
309 static void iface_update_carrier(struct iface *);
310 static bool iface_get_carrier(const struct iface *);
312 static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
314 static void shash_to_ovs_idl_map(struct shash *,
315 char ***keys, char ***values, size_t *n);
317 /* Hooks into ofproto processing. */
318 static struct ofhooks bridge_ofhooks;
320 /* Public functions. */
322 /* Initializes the bridge module, configuring it to obtain its configuration
323 * from an OVSDB server accessed over 'remote', which should be a string in a
324 * form acceptable to ovsdb_idl_create(). */
326 bridge_init(const char *remote)
328 /* Create connection to database. */
329 idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
331 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
332 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
333 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
335 ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
337 ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
338 ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
340 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
341 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
342 ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
344 /* Register unixctl commands. */
345 unixctl_command_register("fdb/show", bridge_unixctl_fdb_show, NULL);
346 unixctl_command_register("qos/show", qos_unixctl_show, NULL);
347 unixctl_command_register("bridge/dump-flows", bridge_unixctl_dump_flows,
349 unixctl_command_register("bridge/reconnect", bridge_unixctl_reconnect,
358 struct bridge *br, *next_br;
360 LIST_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
363 ovsdb_idl_destroy(idl);
366 /* Performs configuration that is only necessary once at ovs-vswitchd startup,
367 * but for which the ovs-vswitchd configuration 'cfg' is required. */
369 bridge_configure_once(const struct ovsrec_open_vswitch *cfg)
371 static bool already_configured_once;
372 struct svec bridge_names;
373 struct svec dpif_names, dpif_types;
376 /* Only do this once per ovs-vswitchd run. */
377 if (already_configured_once) {
380 already_configured_once = true;
382 stats_timer = time_msec() + STATS_INTERVAL;
384 /* Get all the configured bridges' names from 'cfg' into 'bridge_names'. */
385 svec_init(&bridge_names);
386 for (i = 0; i < cfg->n_bridges; i++) {
387 svec_add(&bridge_names, cfg->bridges[i]->name);
389 svec_sort(&bridge_names);
391 /* Iterate over all system dpifs and delete any of them that do not appear
393 svec_init(&dpif_names);
394 svec_init(&dpif_types);
395 dp_enumerate_types(&dpif_types);
396 for (i = 0; i < dpif_types.n; i++) {
399 dp_enumerate_names(dpif_types.names[i], &dpif_names);
401 /* Delete each dpif whose name is not in 'bridge_names'. */
402 for (j = 0; j < dpif_names.n; j++) {
403 if (!svec_contains(&bridge_names, dpif_names.names[j])) {
407 retval = dpif_open(dpif_names.names[j], dpif_types.names[i],
416 svec_destroy(&bridge_names);
417 svec_destroy(&dpif_names);
418 svec_destroy(&dpif_types);
421 /* Callback for iterate_and_prune_ifaces(). */
423 check_iface(struct bridge *br, struct iface *iface, void *aux OVS_UNUSED)
425 if (!iface->netdev) {
426 /* We already reported a related error, don't bother duplicating it. */
430 if (iface->dp_ifidx < 0) {
431 VLOG_ERR("%s interface not in %s, dropping",
432 iface->name, dpif_name(br->dpif));
436 VLOG_DBG("%s has interface %s on port %d", dpif_name(br->dpif),
437 iface->name, iface->dp_ifidx);
441 /* Callback for iterate_and_prune_ifaces(). */
443 set_iface_properties(struct bridge *br OVS_UNUSED, struct iface *iface,
444 void *aux OVS_UNUSED)
446 /* Set policing attributes. */
447 netdev_set_policing(iface->netdev,
448 iface->cfg->ingress_policing_rate,
449 iface->cfg->ingress_policing_burst);
451 /* Set MAC address of internal interfaces other than the local
453 if (iface->dp_ifidx != ODPP_LOCAL && !strcmp(iface->type, "internal")) {
454 iface_set_mac(iface);
460 /* Calls 'cb' for each interfaces in 'br', passing along the 'aux' argument.
461 * Deletes from 'br' all the interfaces for which 'cb' returns false, and then
462 * deletes from 'br' any ports that no longer have any interfaces. */
464 iterate_and_prune_ifaces(struct bridge *br,
465 bool (*cb)(struct bridge *, struct iface *,
471 for (i = 0; i < br->n_ports; ) {
472 struct port *port = br->ports[i];
473 for (j = 0; j < port->n_ifaces; ) {
474 struct iface *iface = port->ifaces[j];
475 if (cb(br, iface, aux)) {
478 iface_set_ofport(iface->cfg, -1);
479 iface_destroy(iface);
483 if (port->n_ifaces) {
486 VLOG_WARN("%s port has no interfaces, dropping", port->name);
492 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
493 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
494 * responsible for freeing '*managersp' (with free()).
496 * You may be asking yourself "why does ovs-vswitchd care?", because
497 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
498 * should not be and in fact is not directly involved in that. But
499 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
500 * it has to tell in-band control where the managers are to enable that.
501 * (Thus, only managers connected in-band are collected.)
504 collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
505 struct sockaddr_in **managersp, size_t *n_managersp)
507 struct sockaddr_in *managers = NULL;
508 size_t n_managers = 0;
509 struct shash targets;
512 /* Collect all of the potential targets from the "targets" columns of the
513 * rows pointed to by "manager_options", excluding any that are
515 shash_init(&targets);
516 for (i = 0; i < ovs_cfg->n_manager_options; i++) {
517 struct ovsrec_manager *m = ovs_cfg->manager_options[i];
519 if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
520 shash_find_and_delete(&targets, m->target);
522 shash_add_once(&targets, m->target, NULL);
526 /* Now extract the targets' IP addresses. */
527 if (!shash_is_empty(&targets)) {
528 struct shash_node *node;
530 managers = xmalloc(shash_count(&targets) * sizeof *managers);
531 SHASH_FOR_EACH (node, &targets) {
532 const char *target = node->name;
533 struct sockaddr_in *sin = &managers[n_managers];
535 if ((!strncmp(target, "tcp:", 4)
536 && inet_parse_active(target + 4, JSONRPC_TCP_PORT, sin)) ||
537 (!strncmp(target, "ssl:", 4)
538 && inet_parse_active(target + 4, JSONRPC_SSL_PORT, sin))) {
543 shash_destroy(&targets);
545 *managersp = managers;
546 *n_managersp = n_managers;
550 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
552 struct shash old_br, new_br;
553 struct shash_node *node;
554 struct bridge *br, *next;
555 struct sockaddr_in *managers;
558 int sflow_bridge_number;
560 COVERAGE_INC(bridge_reconfigure);
562 collect_in_band_managers(ovs_cfg, &managers, &n_managers);
564 /* Collect old and new bridges. */
567 LIST_FOR_EACH (br, node, &all_bridges) {
568 shash_add(&old_br, br->name, br);
570 for (i = 0; i < ovs_cfg->n_bridges; i++) {
571 const struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
572 if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
573 VLOG_WARN("more than one bridge named %s", br_cfg->name);
577 /* Get rid of deleted bridges and add new bridges. */
578 LIST_FOR_EACH_SAFE (br, next, node, &all_bridges) {
579 struct ovsrec_bridge *br_cfg = shash_find_data(&new_br, br->name);
586 SHASH_FOR_EACH (node, &new_br) {
587 const char *br_name = node->name;
588 const struct ovsrec_bridge *br_cfg = node->data;
589 br = shash_find_data(&old_br, br_name);
591 /* If the bridge datapath type has changed, we need to tear it
592 * down and recreate. */
593 if (strcmp(br->cfg->datapath_type, br_cfg->datapath_type)) {
595 bridge_create(br_cfg);
598 bridge_create(br_cfg);
601 shash_destroy(&old_br);
602 shash_destroy(&new_br);
604 /* Reconfigure all bridges. */
605 LIST_FOR_EACH (br, node, &all_bridges) {
606 bridge_reconfigure_one(br);
609 /* Add and delete ports on all datapaths.
611 * The kernel will reject any attempt to add a given port to a datapath if
612 * that port already belongs to a different datapath, so we must do all
613 * port deletions before any port additions. */
614 LIST_FOR_EACH (br, node, &all_bridges) {
615 struct dpif_port_dump dump;
616 struct shash want_ifaces;
617 struct dpif_port dpif_port;
619 bridge_get_all_ifaces(br, &want_ifaces);
620 DPIF_PORT_FOR_EACH (&dpif_port, &dump, br->dpif) {
621 if (!shash_find(&want_ifaces, dpif_port.name)
622 && strcmp(dpif_port.name, br->name)) {
623 int retval = dpif_port_del(br->dpif, dpif_port.port_no);
625 VLOG_WARN("failed to remove %s interface from %s: %s",
626 dpif_port.name, dpif_name(br->dpif),
631 shash_destroy(&want_ifaces);
633 LIST_FOR_EACH (br, node, &all_bridges) {
634 struct shash cur_ifaces, want_ifaces;
635 struct dpif_port_dump dump;
636 struct dpif_port dpif_port;
638 /* Get the set of interfaces currently in this datapath. */
639 shash_init(&cur_ifaces);
640 DPIF_PORT_FOR_EACH (&dpif_port, &dump, br->dpif) {
641 struct dpif_port *port_info = xmalloc(sizeof *port_info);
642 dpif_port_clone(port_info, &dpif_port);
643 shash_add(&cur_ifaces, dpif_port.name, port_info);
646 /* Get the set of interfaces we want on this datapath. */
647 bridge_get_all_ifaces(br, &want_ifaces);
649 hmap_clear(&br->ifaces);
650 SHASH_FOR_EACH (node, &want_ifaces) {
651 const char *if_name = node->name;
652 struct iface *iface = node->data;
653 struct dpif_port *dpif_port;
657 type = iface ? iface->type : "internal";
658 dpif_port = shash_find_data(&cur_ifaces, if_name);
660 /* If we have a port or a netdev already, and it's not the type we
661 * want, then delete the port (if any) and close the netdev (if
663 if ((dpif_port && strcmp(dpif_port->type, type))
664 || (iface && iface->netdev
665 && strcmp(type, netdev_get_type(iface->netdev)))) {
667 error = ofproto_port_del(br->ofproto, dpif_port->port_no);
674 netdev_close(iface->netdev);
675 iface->netdev = NULL;
679 /* If the port doesn't exist or we don't have the netdev open,
680 * we need to do more work. */
681 if (!dpif_port || (iface && !iface->netdev)) {
682 struct netdev_options options;
683 struct netdev *netdev;
686 /* First open the network device. */
687 options.name = if_name;
689 options.args = &args;
690 options.ethertype = NETDEV_ETH_TYPE_NONE;
694 shash_from_ovs_idl_map(iface->cfg->key_options,
695 iface->cfg->value_options,
696 iface->cfg->n_options, &args);
698 error = netdev_open(&options, &netdev);
699 shash_destroy(&args);
702 VLOG_WARN("could not open network device %s (%s)",
703 if_name, strerror(error));
707 /* Then add the port if we haven't already. */
709 error = dpif_port_add(br->dpif, netdev, NULL);
711 netdev_close(netdev);
712 if (error == EFBIG) {
713 VLOG_ERR("ran out of valid port numbers on %s",
714 dpif_name(br->dpif));
717 VLOG_WARN("failed to add %s interface to %s: %s",
718 if_name, dpif_name(br->dpif),
725 /* Update 'iface'. */
727 iface->netdev = netdev;
728 iface->enabled = iface_get_carrier(iface);
729 iface->up = iface->enabled;
731 } else if (iface && iface->netdev) {
735 shash_from_ovs_idl_map(iface->cfg->key_options,
736 iface->cfg->value_options,
737 iface->cfg->n_options, &args);
738 netdev_set_config(iface->netdev, &args);
739 shash_destroy(&args);
742 shash_destroy(&want_ifaces);
744 SHASH_FOR_EACH (node, &cur_ifaces) {
745 struct dpif_port *port_info = node->data;
746 dpif_port_destroy(port_info);
749 shash_destroy(&cur_ifaces);
751 sflow_bridge_number = 0;
752 LIST_FOR_EACH (br, node, &all_bridges) {
755 struct iface *local_iface;
756 struct iface *hw_addr_iface;
759 bridge_fetch_dp_ifaces(br);
761 iterate_and_prune_ifaces(br, check_iface, NULL);
763 /* Pick local port hardware address, datapath ID. */
764 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
765 local_iface = bridge_get_local_iface(br);
767 int error = netdev_set_etheraddr(local_iface->netdev, ea);
769 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
770 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
771 "Ethernet address: %s",
772 br->name, strerror(error));
775 memcpy(br->ea, ea, ETH_ADDR_LEN);
777 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
778 ofproto_set_datapath_id(br->ofproto, dpid);
780 dpid_string = xasprintf("%016"PRIx64, dpid);
781 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
784 /* Set NetFlow configuration on this bridge. */
785 if (br->cfg->netflow) {
786 struct ovsrec_netflow *nf_cfg = br->cfg->netflow;
787 struct netflow_options opts;
789 memset(&opts, 0, sizeof opts);
791 dpif_get_netflow_ids(br->dpif, &opts.engine_type, &opts.engine_id);
792 if (nf_cfg->engine_type) {
793 opts.engine_type = *nf_cfg->engine_type;
795 if (nf_cfg->engine_id) {
796 opts.engine_id = *nf_cfg->engine_id;
799 opts.active_timeout = nf_cfg->active_timeout;
800 if (!opts.active_timeout) {
801 opts.active_timeout = -1;
802 } else if (opts.active_timeout < 0) {
803 VLOG_WARN("bridge %s: active timeout interval set to negative "
804 "value, using default instead (%d seconds)", br->name,
805 NF_ACTIVE_TIMEOUT_DEFAULT);
806 opts.active_timeout = -1;
809 opts.add_id_to_iface = nf_cfg->add_id_to_interface;
810 if (opts.add_id_to_iface) {
811 if (opts.engine_id > 0x7f) {
812 VLOG_WARN("bridge %s: netflow port mangling may conflict "
813 "with another vswitch, choose an engine id less "
814 "than 128", br->name);
816 if (br->n_ports > 508) {
817 VLOG_WARN("bridge %s: netflow port mangling will conflict "
818 "with another port when more than 508 ports are "
823 opts.collectors.n = nf_cfg->n_targets;
824 opts.collectors.names = nf_cfg->targets;
825 if (ofproto_set_netflow(br->ofproto, &opts)) {
826 VLOG_ERR("bridge %s: problem setting netflow collectors",
830 ofproto_set_netflow(br->ofproto, NULL);
833 /* Set sFlow configuration on this bridge. */
834 if (br->cfg->sflow) {
835 const struct ovsrec_sflow *sflow_cfg = br->cfg->sflow;
836 struct ovsrec_controller **controllers;
837 struct ofproto_sflow_options oso;
838 size_t n_controllers;
840 memset(&oso, 0, sizeof oso);
842 oso.targets.n = sflow_cfg->n_targets;
843 oso.targets.names = sflow_cfg->targets;
845 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
846 if (sflow_cfg->sampling) {
847 oso.sampling_rate = *sflow_cfg->sampling;
850 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
851 if (sflow_cfg->polling) {
852 oso.polling_interval = *sflow_cfg->polling;
855 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
856 if (sflow_cfg->header) {
857 oso.header_len = *sflow_cfg->header;
860 oso.sub_id = sflow_bridge_number++;
861 oso.agent_device = sflow_cfg->agent;
863 oso.control_ip = NULL;
864 n_controllers = bridge_get_controllers(br, &controllers);
865 for (i = 0; i < n_controllers; i++) {
866 if (controllers[i]->local_ip) {
867 oso.control_ip = controllers[i]->local_ip;
871 ofproto_set_sflow(br->ofproto, &oso);
873 /* Do not destroy oso.targets because it is owned by sflow_cfg. */
875 ofproto_set_sflow(br->ofproto, NULL);
878 /* Update the controller and related settings. It would be more
879 * straightforward to call this from bridge_reconfigure_one(), but we
880 * can't do it there for two reasons. First, and most importantly, at
881 * that point we don't know the dp_ifidx of any interfaces that have
882 * been added to the bridge (because we haven't actually added them to
883 * the datapath). Second, at that point we haven't set the datapath ID
884 * yet; when a controller is configured, resetting the datapath ID will
885 * immediately disconnect from the controller, so it's better to set
886 * the datapath ID before the controller. */
887 bridge_reconfigure_remotes(br, managers, n_managers);
889 LIST_FOR_EACH (br, node, &all_bridges) {
890 for (i = 0; i < br->n_ports; i++) {
891 struct port *port = br->ports[i];
895 for (j = 0; j < port->n_ifaces; j++) {
896 netdev_monitor_add(port->monitor, port->ifaces[j]->netdev);
899 port->miimon_next_update = 0;
902 port_update_lacp(port);
903 port_update_bonding(port);
905 for (j = 0; j < port->n_ifaces; j++) {
906 iface_update_qos(port->ifaces[j], port->cfg->qos);
910 LIST_FOR_EACH (br, node, &all_bridges) {
911 iterate_and_prune_ifaces(br, set_iface_properties, NULL);
914 LIST_FOR_EACH (br, node, &all_bridges) {
916 HMAP_FOR_EACH (iface, dp_ifidx_node, &br->ifaces) {
917 iface_update_cfm(iface);
923 /* ovs-vswitchd has completed initialization, so allow the process that
924 * forked us to exit successfully. */
925 daemonize_complete();
929 get_ovsrec_key_value(const struct ovsdb_idl_row *row,
930 const struct ovsdb_idl_column *column,
933 const struct ovsdb_datum *datum;
934 union ovsdb_atom atom;
937 datum = ovsdb_idl_get(row, column, OVSDB_TYPE_STRING, OVSDB_TYPE_STRING);
938 atom.string = (char *) key;
939 idx = ovsdb_datum_find_key(datum, &atom, OVSDB_TYPE_STRING);
940 return idx == UINT_MAX ? NULL : datum->values[idx].string;
944 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
946 return get_ovsrec_key_value(&br_cfg->header_,
947 &ovsrec_bridge_col_other_config, key);
951 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
952 struct iface **hw_addr_iface)
958 *hw_addr_iface = NULL;
960 /* Did the user request a particular MAC? */
961 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
962 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
963 if (eth_addr_is_multicast(ea)) {
964 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
965 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
966 } else if (eth_addr_is_zero(ea)) {
967 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
973 /* Otherwise choose the minimum non-local MAC address among all of the
975 memset(ea, 0xff, ETH_ADDR_LEN);
976 for (i = 0; i < br->n_ports; i++) {
977 struct port *port = br->ports[i];
978 uint8_t iface_ea[ETH_ADDR_LEN];
981 /* Mirror output ports don't participate. */
982 if (port->is_mirror_output_port) {
986 /* Choose the MAC address to represent the port. */
987 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
988 /* Find the interface with this Ethernet address (if any) so that
989 * we can provide the correct devname to the caller. */
991 for (j = 0; j < port->n_ifaces; j++) {
992 struct iface *candidate = port->ifaces[j];
993 uint8_t candidate_ea[ETH_ADDR_LEN];
994 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
995 && eth_addr_equals(iface_ea, candidate_ea)) {
1000 /* Choose the interface whose MAC address will represent the port.
1001 * The Linux kernel bonding code always chooses the MAC address of
1002 * the first slave added to a bond, and the Fedora networking
1003 * scripts always add slaves to a bond in alphabetical order, so
1004 * for compatibility we choose the interface with the name that is
1005 * first in alphabetical order. */
1006 iface = port->ifaces[0];
1007 for (j = 1; j < port->n_ifaces; j++) {
1008 struct iface *candidate = port->ifaces[j];
1009 if (strcmp(candidate->name, iface->name) < 0) {
1014 /* The local port doesn't count (since we're trying to choose its
1015 * MAC address anyway). */
1016 if (iface->dp_ifidx == ODPP_LOCAL) {
1021 error = netdev_get_etheraddr(iface->netdev, iface_ea);
1023 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1024 VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
1025 iface->name, strerror(error));
1030 /* Compare against our current choice. */
1031 if (!eth_addr_is_multicast(iface_ea) &&
1032 !eth_addr_is_local(iface_ea) &&
1033 !eth_addr_is_reserved(iface_ea) &&
1034 !eth_addr_is_zero(iface_ea) &&
1035 eth_addr_compare_3way(iface_ea, ea) < 0)
1037 memcpy(ea, iface_ea, ETH_ADDR_LEN);
1038 *hw_addr_iface = iface;
1041 if (eth_addr_is_multicast(ea)) {
1042 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
1043 *hw_addr_iface = NULL;
1044 VLOG_WARN("bridge %s: using default bridge Ethernet "
1045 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1047 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
1048 br->name, ETH_ADDR_ARGS(ea));
1052 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
1053 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
1054 * an interface on 'br', then that interface must be passed in as
1055 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
1056 * 'hw_addr_iface' must be passed in as a null pointer. */
1058 bridge_pick_datapath_id(struct bridge *br,
1059 const uint8_t bridge_ea[ETH_ADDR_LEN],
1060 struct iface *hw_addr_iface)
1063 * The procedure for choosing a bridge MAC address will, in the most
1064 * ordinary case, also choose a unique MAC that we can use as a datapath
1065 * ID. In some special cases, though, multiple bridges will end up with
1066 * the same MAC address. This is OK for the bridges, but it will confuse
1067 * the OpenFlow controller, because each datapath needs a unique datapath
1070 * Datapath IDs must be unique. It is also very desirable that they be
1071 * stable from one run to the next, so that policy set on a datapath
1074 const char *datapath_id;
1077 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
1078 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
1082 if (hw_addr_iface) {
1084 if (!netdev_get_vlan_vid(hw_addr_iface->netdev, &vlan)) {
1086 * A bridge whose MAC address is taken from a VLAN network device
1087 * (that is, a network device created with vconfig(8) or similar
1088 * tool) will have the same MAC address as a bridge on the VLAN
1089 * device's physical network device.
1091 * Handle this case by hashing the physical network device MAC
1092 * along with the VLAN identifier.
1094 uint8_t buf[ETH_ADDR_LEN + 2];
1095 memcpy(buf, bridge_ea, ETH_ADDR_LEN);
1096 buf[ETH_ADDR_LEN] = vlan >> 8;
1097 buf[ETH_ADDR_LEN + 1] = vlan;
1098 return dpid_from_hash(buf, sizeof buf);
1101 * Assume that this bridge's MAC address is unique, since it
1102 * doesn't fit any of the cases we handle specially.
1107 * A purely internal bridge, that is, one that has no non-virtual
1108 * network devices on it at all, is more difficult because it has no
1109 * natural unique identifier at all.
1111 * When the host is a XenServer, we handle this case by hashing the
1112 * host's UUID with the name of the bridge. Names of bridges are
1113 * persistent across XenServer reboots, although they can be reused if
1114 * an internal network is destroyed and then a new one is later
1115 * created, so this is fairly effective.
1117 * When the host is not a XenServer, we punt by using a random MAC
1118 * address on each run.
1120 const char *host_uuid = xenserver_get_host_uuid();
1122 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1123 dpid = dpid_from_hash(combined, strlen(combined));
1129 return eth_addr_to_uint64(bridge_ea);
1133 dpid_from_hash(const void *data, size_t n)
1135 uint8_t hash[SHA1_DIGEST_SIZE];
1137 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1138 sha1_bytes(data, n, hash);
1139 eth_addr_mark_random(hash);
1140 return eth_addr_to_uint64(hash);
1144 iface_refresh_status(struct iface *iface)
1148 enum netdev_flags flags;
1157 if (!netdev_get_status(iface->netdev, &sh)) {
1159 char **keys, **values;
1161 shash_to_ovs_idl_map(&sh, &keys, &values, &n);
1162 ovsrec_interface_set_status(iface->cfg, keys, values, n);
1167 ovsrec_interface_set_status(iface->cfg, NULL, NULL, 0);
1170 shash_destroy_free_data(&sh);
1172 error = netdev_get_flags(iface->netdev, &flags);
1174 ovsrec_interface_set_admin_state(iface->cfg, flags & NETDEV_UP ? "up" : "down");
1177 ovsrec_interface_set_admin_state(iface->cfg, NULL);
1180 error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1182 ovsrec_interface_set_duplex(iface->cfg,
1183 netdev_features_is_full_duplex(current)
1185 /* warning: uint64_t -> int64_t conversion */
1186 bps = netdev_features_to_bps(current);
1187 ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
1190 ovsrec_interface_set_duplex(iface->cfg, NULL);
1191 ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
1195 ovsrec_interface_set_link_state(iface->cfg,
1196 iface_get_carrier(iface) ? "up" : "down");
1198 error = netdev_get_mtu(iface->netdev, &mtu);
1199 if (!error && mtu != INT_MAX) {
1201 ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
1204 ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
1209 iface_refresh_cfm_stats(struct iface *iface)
1213 const struct ovsrec_monitor *mon;
1215 mon = iface->cfg->monitor;
1222 for (i = 0; i < mon->n_remote_mps; i++) {
1223 const struct ovsrec_maintenance_point *mp;
1224 const struct remote_mp *rmp;
1226 mp = mon->remote_mps[i];
1227 rmp = cfm_get_remote_mp(cfm, mp->mpid);
1229 ovsrec_maintenance_point_set_fault(mp, &rmp->fault, 1);
1232 if (hmap_is_empty(&cfm->x_remote_mps)) {
1233 ovsrec_monitor_set_unexpected_remote_mpids(mon, NULL, 0);
1236 struct remote_mp *rmp;
1237 int64_t *x_remote_mps;
1239 length = hmap_count(&cfm->x_remote_mps);
1240 x_remote_mps = xzalloc(length * sizeof *x_remote_mps);
1243 HMAP_FOR_EACH (rmp, node, &cfm->x_remote_mps) {
1244 x_remote_mps[i++] = rmp->mpid;
1247 ovsrec_monitor_set_unexpected_remote_mpids(mon, x_remote_mps, length);
1251 if (hmap_is_empty(&cfm->x_remote_maids)) {
1252 ovsrec_monitor_set_unexpected_remote_maids(mon, NULL, 0);
1255 char **x_remote_maids;
1256 struct remote_maid *rmaid;
1258 length = hmap_count(&cfm->x_remote_maids);
1259 x_remote_maids = xzalloc(length * sizeof *x_remote_maids);
1262 HMAP_FOR_EACH (rmaid, node, &cfm->x_remote_maids) {
1265 x_remote_maids[i] = xzalloc(CCM_MAID_LEN * 2 + 1);
1267 for (j = 0; j < CCM_MAID_LEN; j++) {
1268 snprintf(&x_remote_maids[i][j * 2], 3, "%02hhx",
1273 ovsrec_monitor_set_unexpected_remote_maids(mon, x_remote_maids, length);
1275 for (i = 0; i < length; i++) {
1276 free(x_remote_maids[i]);
1278 free(x_remote_maids);
1281 ovsrec_monitor_set_fault(mon, &cfm->fault, 1);
1285 iface_refresh_stats(struct iface *iface)
1291 static const struct iface_stat iface_stats[] = {
1292 { "rx_packets", offsetof(struct netdev_stats, rx_packets) },
1293 { "tx_packets", offsetof(struct netdev_stats, tx_packets) },
1294 { "rx_bytes", offsetof(struct netdev_stats, rx_bytes) },
1295 { "tx_bytes", offsetof(struct netdev_stats, tx_bytes) },
1296 { "rx_dropped", offsetof(struct netdev_stats, rx_dropped) },
1297 { "tx_dropped", offsetof(struct netdev_stats, tx_dropped) },
1298 { "rx_errors", offsetof(struct netdev_stats, rx_errors) },
1299 { "tx_errors", offsetof(struct netdev_stats, tx_errors) },
1300 { "rx_frame_err", offsetof(struct netdev_stats, rx_frame_errors) },
1301 { "rx_over_err", offsetof(struct netdev_stats, rx_over_errors) },
1302 { "rx_crc_err", offsetof(struct netdev_stats, rx_crc_errors) },
1303 { "collisions", offsetof(struct netdev_stats, collisions) },
1305 enum { N_STATS = ARRAY_SIZE(iface_stats) };
1306 const struct iface_stat *s;
1308 char *keys[N_STATS];
1309 int64_t values[N_STATS];
1312 struct netdev_stats stats;
1314 /* Intentionally ignore return value, since errors will set 'stats' to
1315 * all-1s, and we will deal with that correctly below. */
1316 netdev_get_stats(iface->netdev, &stats);
1319 for (s = iface_stats; s < &iface_stats[N_STATS]; s++) {
1320 uint64_t value = *(uint64_t *) (((char *) &stats) + s->offset);
1321 if (value != UINT64_MAX) {
1328 ovsrec_interface_set_statistics(iface->cfg, keys, values, n);
1332 refresh_system_stats(const struct ovsrec_open_vswitch *cfg)
1334 struct ovsdb_datum datum;
1338 get_system_stats(&stats);
1340 ovsdb_datum_from_shash(&datum, &stats);
1341 ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
1345 static inline const char *
1346 nx_role_to_str(enum nx_role role)
1351 case NX_ROLE_MASTER:
1356 return "*** INVALID ROLE ***";
1361 bridge_refresh_controller_status(const struct bridge *br)
1364 const struct ovsrec_controller *cfg;
1366 ofproto_get_ofproto_controller_info(br->ofproto, &info);
1368 OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
1369 struct ofproto_controller_info *cinfo =
1370 shash_find_data(&info, cfg->target);
1373 ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
1374 ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
1375 ovsrec_controller_set_status(cfg, (char **) cinfo->pairs.keys,
1376 (char **) cinfo->pairs.values,
1379 ovsrec_controller_set_is_connected(cfg, false);
1380 ovsrec_controller_set_role(cfg, NULL);
1381 ovsrec_controller_set_status(cfg, NULL, NULL, 0);
1385 ofproto_free_ofproto_controller_info(&info);
1391 const struct ovsrec_open_vswitch *cfg;
1393 bool datapath_destroyed;
1394 bool database_changed;
1397 /* Let each bridge do the work that it needs to do. */
1398 datapath_destroyed = false;
1399 LIST_FOR_EACH (br, node, &all_bridges) {
1400 int error = bridge_run_one(br);
1402 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1403 VLOG_ERR_RL(&rl, "bridge %s: datapath was destroyed externally, "
1404 "forcing reconfiguration", br->name);
1405 datapath_destroyed = true;
1409 /* (Re)configure if necessary. */
1410 database_changed = ovsdb_idl_run(idl);
1411 cfg = ovsrec_open_vswitch_first(idl);
1413 /* Re-configure SSL. We do this on every trip through the main loop,
1414 * instead of just when the database changes, because the contents of the
1415 * key and certificate files can change without the database changing.
1417 * We do this before bridge_reconfigure() because that function might
1418 * initiate SSL connections and thus requires SSL to be configured. */
1419 if (cfg && cfg->ssl) {
1420 const struct ovsrec_ssl *ssl = cfg->ssl;
1422 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
1423 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
1426 if (database_changed || datapath_destroyed) {
1428 struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
1430 bridge_configure_once(cfg);
1431 bridge_reconfigure(cfg);
1433 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
1434 ovsdb_idl_txn_commit(txn);
1435 ovsdb_idl_txn_destroy(txn); /* XXX */
1437 /* We still need to reconfigure to avoid dangling pointers to
1438 * now-destroyed ovsrec structures inside bridge data. */
1439 static const struct ovsrec_open_vswitch null_cfg;
1441 bridge_reconfigure(&null_cfg);
1445 /* Refresh system and interface stats if necessary. */
1446 if (time_msec() >= stats_timer) {
1448 struct ovsdb_idl_txn *txn;
1450 txn = ovsdb_idl_txn_create(idl);
1451 LIST_FOR_EACH (br, node, &all_bridges) {
1454 for (i = 0; i < br->n_ports; i++) {
1455 struct port *port = br->ports[i];
1458 for (j = 0; j < port->n_ifaces; j++) {
1459 struct iface *iface = port->ifaces[j];
1460 iface_refresh_stats(iface);
1461 iface_refresh_cfm_stats(iface);
1462 iface_refresh_status(iface);
1465 bridge_refresh_controller_status(br);
1467 refresh_system_stats(cfg);
1468 ovsdb_idl_txn_commit(txn);
1469 ovsdb_idl_txn_destroy(txn); /* XXX */
1472 stats_timer = time_msec() + STATS_INTERVAL;
1481 LIST_FOR_EACH (br, node, &all_bridges) {
1484 ofproto_wait(br->ofproto);
1485 if (ofproto_has_primary_controller(br->ofproto)) {
1489 mac_learning_wait(br->ml);
1491 for (i = 0; i < br->n_ports; i++) {
1492 port_wait(br->ports[i]);
1495 ovsdb_idl_wait(idl);
1496 poll_timer_wait_until(stats_timer);
1499 /* Forces 'br' to revalidate all of its flows. This is appropriate when 'br''s
1500 * configuration changes. */
1502 bridge_flush(struct bridge *br)
1504 COVERAGE_INC(bridge_flush);
1506 mac_learning_flush(br->ml);
1509 /* Returns the 'br' interface for the ODPP_LOCAL port, or null if 'br' has no
1510 * such interface. */
1511 static struct iface *
1512 bridge_get_local_iface(struct bridge *br)
1516 for (i = 0; i < br->n_ports; i++) {
1517 struct port *port = br->ports[i];
1518 for (j = 0; j < port->n_ifaces; j++) {
1519 struct iface *iface = port->ifaces[j];
1520 if (iface->dp_ifidx == ODPP_LOCAL) {
1529 /* Bridge unixctl user interface functions. */
1531 bridge_unixctl_fdb_show(struct unixctl_conn *conn,
1532 const char *args, void *aux OVS_UNUSED)
1534 struct ds ds = DS_EMPTY_INITIALIZER;
1535 const struct bridge *br;
1536 const struct mac_entry *e;
1538 br = bridge_lookup(args);
1540 unixctl_command_reply(conn, 501, "no such bridge");
1544 ds_put_cstr(&ds, " port VLAN MAC Age\n");
1545 LIST_FOR_EACH (e, lru_node, &br->ml->lrus) {
1546 if (e->port < 0 || e->port >= br->n_ports) {
1549 ds_put_format(&ds, "%5d %4d "ETH_ADDR_FMT" %3d\n",
1550 br->ports[e->port]->ifaces[0]->dp_ifidx,
1551 e->vlan, ETH_ADDR_ARGS(e->mac), mac_entry_age(e));
1553 unixctl_command_reply(conn, 200, ds_cstr(&ds));
1557 /* QoS unixctl user interface functions. */
1559 struct qos_unixctl_show_cbdata {
1561 struct iface *iface;
1565 qos_unixctl_show_cb(unsigned int queue_id,
1566 const struct shash *details,
1569 struct qos_unixctl_show_cbdata *data = aux;
1570 struct ds *ds = data->ds;
1571 struct iface *iface = data->iface;
1572 struct netdev_queue_stats stats;
1573 struct shash_node *node;
1576 ds_put_cstr(ds, "\n");
1578 ds_put_format(ds, "Queue %u:\n", queue_id);
1580 ds_put_cstr(ds, "Default:\n");
1583 SHASH_FOR_EACH (node, details) {
1584 ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
1587 error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
1589 if (stats.tx_packets != UINT64_MAX) {
1590 ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
1593 if (stats.tx_bytes != UINT64_MAX) {
1594 ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
1597 if (stats.tx_errors != UINT64_MAX) {
1598 ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
1601 ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
1602 queue_id, strerror(error));
1607 qos_unixctl_show(struct unixctl_conn *conn,
1608 const char *args, void *aux OVS_UNUSED)
1610 struct ds ds = DS_EMPTY_INITIALIZER;
1611 struct shash sh = SHASH_INITIALIZER(&sh);
1612 struct iface *iface;
1614 struct shash_node *node;
1615 struct qos_unixctl_show_cbdata data;
1618 iface = iface_find(args);
1620 unixctl_command_reply(conn, 501, "no such interface");
1624 netdev_get_qos(iface->netdev, &type, &sh);
1626 if (*type != '\0') {
1627 ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
1629 SHASH_FOR_EACH (node, &sh) {
1630 ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
1635 error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
1638 ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
1640 unixctl_command_reply(conn, 200, ds_cstr(&ds));
1642 ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
1643 unixctl_command_reply(conn, 501, ds_cstr(&ds));
1646 shash_destroy_free_data(&sh);
1650 /* Bridge reconfiguration functions. */
1651 static struct bridge *
1652 bridge_create(const struct ovsrec_bridge *br_cfg)
1657 assert(!bridge_lookup(br_cfg->name));
1658 br = xzalloc(sizeof *br);
1660 error = dpif_create_and_open(br_cfg->name, br_cfg->datapath_type,
1666 dpif_flow_flush(br->dpif);
1668 error = ofproto_create(br_cfg->name, br_cfg->datapath_type, &bridge_ofhooks,
1671 VLOG_ERR("failed to create switch %s: %s", br_cfg->name,
1673 dpif_delete(br->dpif);
1674 dpif_close(br->dpif);
1679 br->name = xstrdup(br_cfg->name);
1681 br->ml = mac_learning_create();
1682 eth_addr_nicira_random(br->default_ea);
1684 hmap_init(&br->ifaces);
1686 shash_init(&br->port_by_name);
1687 shash_init(&br->iface_by_name);
1691 list_push_back(&all_bridges, &br->node);
1693 VLOG_INFO("created bridge %s on %s", br->name, dpif_name(br->dpif));
1699 bridge_destroy(struct bridge *br)
1704 while (br->n_ports > 0) {
1705 port_destroy(br->ports[br->n_ports - 1]);
1707 list_remove(&br->node);
1708 error = dpif_delete(br->dpif);
1709 if (error && error != ENOENT) {
1710 VLOG_ERR("failed to delete %s: %s",
1711 dpif_name(br->dpif), strerror(error));
1713 dpif_close(br->dpif);
1714 ofproto_destroy(br->ofproto);
1715 mac_learning_destroy(br->ml);
1716 hmap_destroy(&br->ifaces);
1717 shash_destroy(&br->port_by_name);
1718 shash_destroy(&br->iface_by_name);
1725 static struct bridge *
1726 bridge_lookup(const char *name)
1730 LIST_FOR_EACH (br, node, &all_bridges) {
1731 if (!strcmp(br->name, name)) {
1738 /* Handle requests for a listing of all flows known by the OpenFlow
1739 * stack, including those normally hidden. */
1741 bridge_unixctl_dump_flows(struct unixctl_conn *conn,
1742 const char *args, void *aux OVS_UNUSED)
1747 br = bridge_lookup(args);
1749 unixctl_command_reply(conn, 501, "Unknown bridge");
1754 ofproto_get_all_flows(br->ofproto, &results);
1756 unixctl_command_reply(conn, 200, ds_cstr(&results));
1757 ds_destroy(&results);
1760 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
1761 * connections and reconnect. If BRIDGE is not specified, then all bridges
1762 * drop their controller connections and reconnect. */
1764 bridge_unixctl_reconnect(struct unixctl_conn *conn,
1765 const char *args, void *aux OVS_UNUSED)
1768 if (args[0] != '\0') {
1769 br = bridge_lookup(args);
1771 unixctl_command_reply(conn, 501, "Unknown bridge");
1774 ofproto_reconnect_controllers(br->ofproto);
1776 LIST_FOR_EACH (br, node, &all_bridges) {
1777 ofproto_reconnect_controllers(br->ofproto);
1780 unixctl_command_reply(conn, 200, NULL);
1784 bridge_run_one(struct bridge *br)
1789 error = ofproto_run1(br->ofproto);
1794 mac_learning_run(br->ml, ofproto_get_revalidate_set(br->ofproto));
1796 for (i = 0; i < br->n_ports; i++) {
1797 port_run(br->ports[i]);
1800 error = ofproto_run2(br->ofproto, br->flush);
1807 bridge_get_controllers(const struct bridge *br,
1808 struct ovsrec_controller ***controllersp)
1810 struct ovsrec_controller **controllers;
1811 size_t n_controllers;
1813 controllers = br->cfg->controller;
1814 n_controllers = br->cfg->n_controller;
1816 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
1822 *controllersp = controllers;
1824 return n_controllers;
1828 bridge_reconfigure_one(struct bridge *br)
1830 struct shash old_ports, new_ports;
1831 struct svec snoops, old_snoops;
1832 struct shash_node *node;
1833 enum ofproto_fail_mode fail_mode;
1836 /* Collect old ports. */
1837 shash_init(&old_ports);
1838 for (i = 0; i < br->n_ports; i++) {
1839 shash_add(&old_ports, br->ports[i]->name, br->ports[i]);
1842 /* Collect new ports. */
1843 shash_init(&new_ports);
1844 for (i = 0; i < br->cfg->n_ports; i++) {
1845 const char *name = br->cfg->ports[i]->name;
1846 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
1847 VLOG_WARN("bridge %s: %s specified twice as bridge port",
1852 /* If we have a controller, then we need a local port. Complain if the
1853 * user didn't specify one.
1855 * XXX perhaps we should synthesize a port ourselves in this case. */
1856 if (bridge_get_controllers(br, NULL)) {
1857 char local_name[IF_NAMESIZE];
1860 error = dpif_port_get_name(br->dpif, ODPP_LOCAL,
1861 local_name, sizeof local_name);
1862 if (!error && !shash_find(&new_ports, local_name)) {
1863 VLOG_WARN("bridge %s: controller specified but no local port "
1864 "(port named %s) defined",
1865 br->name, local_name);
1869 /* Get rid of deleted ports.
1870 * Get rid of deleted interfaces on ports that still exist. */
1871 SHASH_FOR_EACH (node, &old_ports) {
1872 struct port *port = node->data;
1873 const struct ovsrec_port *port_cfg;
1875 port_cfg = shash_find_data(&new_ports, node->name);
1879 port_del_ifaces(port, port_cfg);
1883 /* Create new ports.
1884 * Add new interfaces to existing ports.
1885 * Reconfigure existing ports. */
1886 SHASH_FOR_EACH (node, &new_ports) {
1887 struct port *port = shash_find_data(&old_ports, node->name);
1889 port = port_create(br, node->name);
1892 port_reconfigure(port, node->data);
1893 if (!port->n_ifaces) {
1894 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
1895 br->name, port->name);
1899 shash_destroy(&old_ports);
1900 shash_destroy(&new_ports);
1902 /* Set the fail-mode */
1903 fail_mode = !br->cfg->fail_mode
1904 || !strcmp(br->cfg->fail_mode, "standalone")
1905 ? OFPROTO_FAIL_STANDALONE
1906 : OFPROTO_FAIL_SECURE;
1907 if (ofproto_get_fail_mode(br->ofproto) != fail_mode
1908 && !ofproto_has_primary_controller(br->ofproto)) {
1909 ofproto_flush_flows(br->ofproto);
1911 ofproto_set_fail_mode(br->ofproto, fail_mode);
1913 /* Delete all flows if we're switching from connected to standalone or vice
1914 * versa. (XXX Should we delete all flows if we are switching from one
1915 * controller to another?) */
1917 /* Configure OpenFlow controller connection snooping. */
1919 svec_add_nocopy(&snoops, xasprintf("punix:%s/%s.snoop",
1920 ovs_rundir(), br->name));
1921 svec_init(&old_snoops);
1922 ofproto_get_snoops(br->ofproto, &old_snoops);
1923 if (!svec_equal(&snoops, &old_snoops)) {
1924 ofproto_set_snoops(br->ofproto, &snoops);
1926 svec_destroy(&snoops);
1927 svec_destroy(&old_snoops);
1929 mirror_reconfigure(br);
1932 /* Initializes 'oc' appropriately as a management service controller for
1935 * The caller must free oc->target when it is no longer needed. */
1937 bridge_ofproto_controller_for_mgmt(const struct bridge *br,
1938 struct ofproto_controller *oc)
1940 oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
1941 oc->max_backoff = 0;
1942 oc->probe_interval = 60;
1943 oc->band = OFPROTO_OUT_OF_BAND;
1945 oc->burst_limit = 0;
1948 /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
1950 bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
1951 struct ofproto_controller *oc)
1953 oc->target = c->target;
1954 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
1955 oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
1956 oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
1957 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
1958 oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
1959 oc->burst_limit = (c->controller_burst_limit
1960 ? *c->controller_burst_limit : 0);
1963 /* Configures the IP stack for 'br''s local interface properly according to the
1964 * configuration in 'c'. */
1966 bridge_configure_local_iface_netdev(struct bridge *br,
1967 struct ovsrec_controller *c)
1969 struct netdev *netdev;
1970 struct in_addr mask, gateway;
1972 struct iface *local_iface;
1975 /* If there's no local interface or no IP address, give up. */
1976 local_iface = bridge_get_local_iface(br);
1977 if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
1981 /* Bring up the local interface. */
1982 netdev = local_iface->netdev;
1983 netdev_turn_flags_on(netdev, NETDEV_UP, true);
1985 /* Configure the IP address and netmask. */
1986 if (!c->local_netmask
1987 || !inet_aton(c->local_netmask, &mask)
1989 mask.s_addr = guess_netmask(ip.s_addr);
1991 if (!netdev_set_in4(netdev, ip, mask)) {
1992 VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
1993 br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
1996 /* Configure the default gateway. */
1997 if (c->local_gateway
1998 && inet_aton(c->local_gateway, &gateway)
1999 && gateway.s_addr) {
2000 if (!netdev_add_router(netdev, gateway)) {
2001 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
2002 br->name, IP_ARGS(&gateway.s_addr));
2008 bridge_reconfigure_remotes(struct bridge *br,
2009 const struct sockaddr_in *managers,
2012 const char *disable_ib_str, *queue_id_str;
2013 bool disable_in_band = false;
2016 struct ovsrec_controller **controllers;
2017 size_t n_controllers;
2020 struct ofproto_controller *ocs;
2024 /* Check if we should disable in-band control on this bridge. */
2025 disable_ib_str = bridge_get_other_config(br->cfg, "disable-in-band");
2026 if (disable_ib_str && !strcmp(disable_ib_str, "true")) {
2027 disable_in_band = true;
2030 /* Set OpenFlow queue ID for in-band control. */
2031 queue_id_str = bridge_get_other_config(br->cfg, "in-band-queue");
2032 queue_id = queue_id_str ? strtol(queue_id_str, NULL, 10) : -1;
2033 ofproto_set_in_band_queue(br->ofproto, queue_id);
2035 if (disable_in_band) {
2036 ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
2038 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
2040 had_primary = ofproto_has_primary_controller(br->ofproto);
2042 n_controllers = bridge_get_controllers(br, &controllers);
2044 ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
2047 bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
2048 for (i = 0; i < n_controllers; i++) {
2049 struct ovsrec_controller *c = controllers[i];
2051 if (!strncmp(c->target, "punix:", 6)
2052 || !strncmp(c->target, "unix:", 5)) {
2053 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2055 /* Prevent remote ovsdb-server users from accessing arbitrary Unix
2056 * domain sockets and overwriting arbitrary local files. */
2057 VLOG_ERR_RL(&rl, "%s: not adding Unix domain socket controller "
2058 "\"%s\" due to possibility for remote exploit",
2059 dpif_name(br->dpif), c->target);
2063 bridge_configure_local_iface_netdev(br, c);
2064 bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
2065 if (disable_in_band) {
2066 ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
2071 ofproto_set_controllers(br->ofproto, ocs, n_ocs);
2072 free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
2075 if (had_primary != ofproto_has_primary_controller(br->ofproto)) {
2076 ofproto_flush_flows(br->ofproto);
2079 /* If there are no controllers and the bridge is in standalone
2080 * mode, set up a flow that matches every packet and directs
2081 * them to OFPP_NORMAL (which goes to us). Otherwise, the
2082 * switch is in secure mode and we won't pass any traffic until
2083 * a controller has been defined and it tells us to do so. */
2085 && ofproto_get_fail_mode(br->ofproto) == OFPROTO_FAIL_STANDALONE) {
2086 union ofp_action action;
2087 struct cls_rule rule;
2089 memset(&action, 0, sizeof action);
2090 action.type = htons(OFPAT_OUTPUT);
2091 action.output.len = htons(sizeof action);
2092 action.output.port = htons(OFPP_NORMAL);
2093 cls_rule_init_catchall(&rule, 0);
2094 ofproto_add_flow(br->ofproto, &rule, &action, 1);
2099 bridge_get_all_ifaces(const struct bridge *br, struct shash *ifaces)
2104 for (i = 0; i < br->n_ports; i++) {
2105 struct port *port = br->ports[i];
2106 for (j = 0; j < port->n_ifaces; j++) {
2107 struct iface *iface = port->ifaces[j];
2108 shash_add_once(ifaces, iface->name, iface);
2110 if (port->n_ifaces > 1 && port->cfg->bond_fake_iface) {
2111 shash_add_once(ifaces, port->name, NULL);
2116 /* For robustness, in case the administrator moves around datapath ports behind
2117 * our back, we re-check all the datapath port numbers here.
2119 * This function will set the 'dp_ifidx' members of interfaces that have
2120 * disappeared to -1, so only call this function from a context where those
2121 * 'struct iface's will be removed from the bridge. Otherwise, the -1
2122 * 'dp_ifidx'es will cause trouble later when we try to send them to the
2123 * datapath, which doesn't support UINT16_MAX+1 ports. */
2125 bridge_fetch_dp_ifaces(struct bridge *br)
2127 struct dpif_port_dump dump;
2128 struct dpif_port dpif_port;
2131 /* Reset all interface numbers. */
2132 for (i = 0; i < br->n_ports; i++) {
2133 struct port *port = br->ports[i];
2134 for (j = 0; j < port->n_ifaces; j++) {
2135 struct iface *iface = port->ifaces[j];
2136 iface->dp_ifidx = -1;
2139 hmap_clear(&br->ifaces);
2141 DPIF_PORT_FOR_EACH (&dpif_port, &dump, br->dpif) {
2142 struct iface *iface = iface_lookup(br, dpif_port.name);
2144 if (iface->dp_ifidx >= 0) {
2145 VLOG_WARN("%s reported interface %s twice",
2146 dpif_name(br->dpif), dpif_port.name);
2147 } else if (iface_from_dp_ifidx(br, dpif_port.port_no)) {
2148 VLOG_WARN("%s reported interface %"PRIu16" twice",
2149 dpif_name(br->dpif), dpif_port.port_no);
2151 iface->dp_ifidx = dpif_port.port_no;
2152 hmap_insert(&br->ifaces, &iface->dp_ifidx_node,
2153 hash_int(iface->dp_ifidx, 0));
2156 iface_set_ofport(iface->cfg,
2157 (iface->dp_ifidx >= 0
2158 ? odp_port_to_ofp_port(iface->dp_ifidx)
2164 /* Bridge packet processing functions. */
2167 bond_is_tcp_hash(const struct port *port)
2169 return port->bond_mode == BM_TCP && lacp_negotiated(port->lacp);
2173 bond_hash_src(const uint8_t mac[ETH_ADDR_LEN], uint16_t vlan)
2175 return hash_bytes(mac, ETH_ADDR_LEN, vlan) & BOND_MASK;
2178 static int bond_hash_tcp(const struct flow *flow, uint16_t vlan)
2180 struct flow hash_flow;
2182 memcpy(&hash_flow, flow, sizeof hash_flow);
2183 hash_flow.vlan_tci = 0;
2185 /* The symmetric quality of this hash function is not required, but
2186 * flow_hash_symmetric_l4 already exists, and is sufficient for our
2187 * purposes, so we use it out of convenience. */
2188 return flow_hash_symmetric_l4(&hash_flow, vlan) & BOND_MASK;
2191 static struct bond_entry *
2192 lookup_bond_entry(const struct port *port, const struct flow *flow,
2195 assert(port->bond_mode != BM_AB);
2197 if (bond_is_tcp_hash(port)) {
2198 return &port->bond_hash[bond_hash_tcp(flow, vlan)];
2200 return &port->bond_hash[bond_hash_src(flow->dl_src, vlan)];
2205 bond_choose_iface(const struct port *port)
2207 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
2208 size_t i, best_down_slave = -1;
2209 long long next_delay_expiration = LLONG_MAX;
2211 for (i = 0; i < port->n_ifaces; i++) {
2212 struct iface *iface = port->ifaces[i];
2214 if (iface->enabled) {
2216 } else if (iface->delay_expires < next_delay_expiration
2217 && lacp_slave_may_enable(port->lacp, iface)) {
2218 best_down_slave = i;
2219 next_delay_expiration = iface->delay_expires;
2223 if (best_down_slave != -1) {
2224 struct iface *iface = port->ifaces[best_down_slave];
2226 VLOG_INFO_RL(&rl, "interface %s: skipping remaining %lli ms updelay "
2227 "since no other interface is up", iface->name,
2228 iface->delay_expires - time_msec());
2229 bond_enable_slave(iface, true);
2232 return best_down_slave;
2236 choose_output_iface(const struct port *port, const struct flow *flow,
2237 uint16_t vlan, uint16_t *dp_ifidx, tag_type *tags)
2239 struct iface *iface;
2241 assert(port->n_ifaces);
2242 if (port->n_ifaces == 1) {
2243 iface = port->ifaces[0];
2244 } else if (port->bond_mode == BM_AB) {
2245 if (port->active_iface < 0) {
2246 *tags |= port->no_ifaces_tag;
2249 iface = port->ifaces[port->active_iface];
2251 struct bond_entry *e = lookup_bond_entry(port, flow, vlan);
2252 if (e->iface_idx < 0 || e->iface_idx >= port->n_ifaces
2253 || !port->ifaces[e->iface_idx]->enabled) {
2254 /* XXX select interface properly. The current interface selection
2255 * is only good for testing the rebalancing code. */
2256 e->iface_idx = bond_choose_iface(port);
2257 if (e->iface_idx < 0) {
2258 *tags |= port->no_ifaces_tag;
2261 e->iface_tag = tag_create_random();
2263 *tags |= e->iface_tag;
2264 iface = port->ifaces[e->iface_idx];
2266 *dp_ifidx = iface->dp_ifidx;
2267 *tags |= iface->tag; /* Currently only used for bonding. */
2272 bond_link_status_update(struct iface *iface)
2274 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
2275 struct port *port = iface->port;
2276 bool up = iface->up && lacp_slave_may_enable(port->lacp, iface);
2277 int updelay, downdelay;
2279 updelay = port->updelay;
2280 downdelay = port->downdelay;
2282 if (lacp_negotiated(port->lacp)) {
2287 if ((up == iface->enabled) == (iface->delay_expires == LLONG_MAX)) {
2288 /* Nothing to do. */
2291 VLOG_INFO_RL(&rl, "interface %s: link state %s",
2292 iface->name, up ? "up" : "down");
2293 if (up == iface->enabled) {
2294 iface->delay_expires = LLONG_MAX;
2295 VLOG_INFO_RL(&rl, "interface %s: will not be %s",
2296 iface->name, up ? "disabled" : "enabled");
2297 } else if (up && port->active_iface < 0) {
2298 bond_enable_slave(iface, true);
2300 VLOG_INFO_RL(&rl, "interface %s: skipping %d ms updelay since no "
2301 "other interface is up", iface->name, updelay);
2304 int delay = up ? updelay : downdelay;
2305 iface->delay_expires = time_msec() + delay;
2308 "interface %s: will be %s if it stays %s for %d ms",
2310 up ? "enabled" : "disabled",
2318 bond_choose_active_iface(struct port *port)
2320 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
2322 port->active_iface = bond_choose_iface(port);
2323 port->active_iface_tag = tag_create_random();
2324 if (port->active_iface >= 0) {
2325 VLOG_INFO_RL(&rl, "port %s: active interface is now %s",
2326 port->name, port->ifaces[port->active_iface]->name);
2328 VLOG_WARN_RL(&rl, "port %s: all ports disabled, no active interface",
2334 bond_enable_slave(struct iface *iface, bool enable)
2336 struct port *port = iface->port;
2337 struct bridge *br = port->bridge;
2339 /* This acts as a recursion check. If the act of disabling a slave
2340 * causes a different slave to be enabled, the flag will allow us to
2341 * skip redundant work when we reenter this function. It must be
2342 * cleared on exit to keep things safe with multiple bonds. */
2343 static bool moving_active_iface = false;
2345 iface->delay_expires = LLONG_MAX;
2346 if (enable == iface->enabled) {
2350 iface->enabled = enable;
2351 if (!iface->enabled) {
2352 VLOG_WARN("interface %s: disabled", iface->name);
2353 ofproto_revalidate(br->ofproto, iface->tag);
2354 if (iface->port_ifidx == port->active_iface) {
2355 ofproto_revalidate(br->ofproto,
2356 port->active_iface_tag);
2358 /* Disabling a slave can lead to another slave being immediately
2359 * enabled if there will be no active slaves but one is waiting
2360 * on an updelay. In this case we do not need to run most of the
2361 * code for the newly enabled slave since there was no period
2362 * without an active slave and it is redundant with the disabling
2364 moving_active_iface = true;
2365 bond_choose_active_iface(port);
2367 bond_send_learning_packets(port);
2369 VLOG_WARN("interface %s: enabled", iface->name);
2370 if (port->active_iface < 0 && !moving_active_iface) {
2371 ofproto_revalidate(br->ofproto, port->no_ifaces_tag);
2372 bond_choose_active_iface(port);
2373 bond_send_learning_packets(port);
2375 iface->tag = tag_create_random();
2378 moving_active_iface = false;
2381 /* Attempts to make the sum of the bond slaves' statistics appear on the fake
2382 * bond interface. */
2384 bond_update_fake_iface_stats(struct port *port)
2386 struct netdev_stats bond_stats;
2387 struct netdev *bond_dev;
2390 memset(&bond_stats, 0, sizeof bond_stats);
2392 for (i = 0; i < port->n_ifaces; i++) {
2393 struct netdev_stats slave_stats;
2395 if (!netdev_get_stats(port->ifaces[i]->netdev, &slave_stats)) {
2396 /* XXX: We swap the stats here because they are swapped back when
2397 * reported by the internal device. The reason for this is
2398 * internal devices normally represent packets going into the system
2399 * but when used as fake bond device they represent packets leaving
2400 * the system. We really should do this in the internal device
2401 * itself because changing it here reverses the counts from the
2402 * perspective of the switch. However, the internal device doesn't
2403 * know what type of device it represents so we have to do it here
2405 bond_stats.tx_packets += slave_stats.rx_packets;
2406 bond_stats.tx_bytes += slave_stats.rx_bytes;
2407 bond_stats.rx_packets += slave_stats.tx_packets;
2408 bond_stats.rx_bytes += slave_stats.tx_bytes;
2412 if (!netdev_open_default(port->name, &bond_dev)) {
2413 netdev_set_stats(bond_dev, &bond_stats);
2414 netdev_close(bond_dev);
2419 bond_run(struct port *port)
2423 if (port->n_ifaces < 2) {
2427 for (i = 0; i < port->n_ifaces; i++) {
2428 bond_link_status_update(port->ifaces[i]);
2431 for (i = 0; i < port->n_ifaces; i++) {
2432 struct iface *iface = port->ifaces[i];
2433 if (time_msec() >= iface->delay_expires) {
2434 bond_enable_slave(iface, !iface->enabled);
2438 if (port->bond_fake_iface
2439 && time_msec() >= port->bond_next_fake_iface_update) {
2440 bond_update_fake_iface_stats(port);
2441 port->bond_next_fake_iface_update = time_msec() + 1000;
2446 bond_wait(struct port *port)
2450 if (port->n_ifaces < 2) {
2454 for (i = 0; i < port->n_ifaces; i++) {
2455 struct iface *iface = port->ifaces[i];
2456 if (iface->delay_expires != LLONG_MAX) {
2457 poll_timer_wait_until(iface->delay_expires);
2461 if (port->bond_fake_iface) {
2462 poll_timer_wait_until(port->bond_next_fake_iface_update);
2467 set_dst(struct dst *dst, const struct flow *flow,
2468 const struct port *in_port, const struct port *out_port,
2471 dst->vlan = (out_port->vlan >= 0 ? OFP_VLAN_NONE
2472 : in_port->vlan >= 0 ? in_port->vlan
2473 : flow->vlan_tci == 0 ? OFP_VLAN_NONE
2474 : vlan_tci_to_vid(flow->vlan_tci));
2475 return choose_output_iface(out_port, flow, dst->vlan,
2476 &dst->dp_ifidx, tags);
2480 swap_dst(struct dst *p, struct dst *q)
2482 struct dst tmp = *p;
2487 /* Moves all the dsts with vlan == 'vlan' to the front of the 'n_dsts' in
2488 * 'dsts'. (This may help performance by reducing the number of VLAN changes
2489 * that we push to the datapath. We could in fact fully sort the array by
2490 * vlan, but in most cases there are at most two different vlan tags so that's
2491 * possibly overkill.) */
2493 partition_dsts(struct dst_set *set, int vlan)
2495 struct dst *first = set->dsts;
2496 struct dst *last = set->dsts + set->n;
2498 while (first != last) {
2500 * - All dsts < first have vlan == 'vlan'.
2501 * - All dsts >= last have vlan != 'vlan'.
2502 * - first < last. */
2503 while (first->vlan == vlan) {
2504 if (++first == last) {
2509 /* Same invariants, plus one additional:
2510 * - first->vlan != vlan.
2512 while (last[-1].vlan != vlan) {
2513 if (--last == first) {
2518 /* Same invariants, plus one additional:
2519 * - last[-1].vlan == vlan.*/
2520 swap_dst(first++, --last);
2525 mirror_mask_ffs(mirror_mask_t mask)
2527 BUILD_ASSERT_DECL(sizeof(unsigned int) >= sizeof(mask));
2532 dst_set_init(struct dst_set *set)
2534 set->dsts = set->builtin;
2536 set->allocated = ARRAY_SIZE(set->builtin);
2540 dst_set_add(struct dst_set *set, const struct dst *dst)
2542 if (set->n >= set->allocated) {
2543 size_t new_allocated;
2544 struct dst *new_dsts;
2546 new_allocated = set->allocated * 2;
2547 new_dsts = xmalloc(new_allocated * sizeof *new_dsts);
2548 memcpy(new_dsts, set->dsts, set->n * sizeof *new_dsts);
2552 set->dsts = new_dsts;
2553 set->allocated = new_allocated;
2555 set->dsts[set->n++] = *dst;
2559 dst_set_free(struct dst_set *set)
2561 if (set->dsts != set->builtin) {
2567 dst_is_duplicate(const struct dst_set *set, const struct dst *test)
2570 for (i = 0; i < set->n; i++) {
2571 if (set->dsts[i].vlan == test->vlan
2572 && set->dsts[i].dp_ifidx == test->dp_ifidx) {
2580 port_trunks_vlan(const struct port *port, uint16_t vlan)
2582 return (port->vlan < 0
2583 && (!port->trunks || bitmap_is_set(port->trunks, vlan)));
2587 port_includes_vlan(const struct port *port, uint16_t vlan)
2589 return vlan == port->vlan || port_trunks_vlan(port, vlan);
2593 port_is_floodable(const struct port *port)
2597 for (i = 0; i < port->n_ifaces; i++) {
2598 if (!ofproto_port_is_floodable(port->bridge->ofproto,
2599 port->ifaces[i]->dp_ifidx)) {
2607 compose_dsts(const struct bridge *br, const struct flow *flow, uint16_t vlan,
2608 const struct port *in_port, const struct port *out_port,
2609 struct dst_set *set, tag_type *tags, uint16_t *nf_output_iface)
2611 mirror_mask_t mirrors = in_port->src_mirrors;
2616 flow_vlan = vlan_tci_to_vid(flow->vlan_tci);
2617 if (flow_vlan == 0) {
2618 flow_vlan = OFP_VLAN_NONE;
2621 if (out_port == FLOOD_PORT) {
2622 for (i = 0; i < br->n_ports; i++) {
2623 struct port *port = br->ports[i];
2625 && port_is_floodable(port)
2626 && port_includes_vlan(port, vlan)
2627 && !port->is_mirror_output_port
2628 && set_dst(&dst, flow, in_port, port, tags)) {
2629 mirrors |= port->dst_mirrors;
2630 dst_set_add(set, &dst);
2633 *nf_output_iface = NF_OUT_FLOOD;
2634 } else if (out_port && set_dst(&dst, flow, in_port, out_port, tags)) {
2635 dst_set_add(set, &dst);
2636 *nf_output_iface = dst.dp_ifidx;
2637 mirrors |= out_port->dst_mirrors;
2641 struct mirror *m = br->mirrors[mirror_mask_ffs(mirrors) - 1];
2642 if (!m->n_vlans || vlan_is_mirrored(m, vlan)) {
2644 if (set_dst(&dst, flow, in_port, m->out_port, tags)
2645 && !dst_is_duplicate(set, &dst)) {
2646 dst_set_add(set, &dst);
2649 for (i = 0; i < br->n_ports; i++) {
2650 struct port *port = br->ports[i];
2651 if (port_includes_vlan(port, m->out_vlan)
2652 && set_dst(&dst, flow, in_port, port, tags))
2654 if (port->vlan < 0) {
2655 dst.vlan = m->out_vlan;
2657 if (dst_is_duplicate(set, &dst)) {
2661 /* Use the vlan tag on the original flow instead of
2662 * the one passed in the vlan parameter. This ensures
2663 * that we compare the vlan from before any implicit
2664 * tagging tags place. This is necessary because
2665 * dst->vlan is the final vlan, after removing implicit
2667 if (port == in_port && dst.vlan == flow_vlan) {
2668 /* Don't send out input port on same VLAN. */
2671 dst_set_add(set, &dst);
2676 mirrors &= mirrors - 1;
2679 partition_dsts(set, flow_vlan);
2682 static void OVS_UNUSED
2683 print_dsts(const struct dst_set *set)
2687 for (i = 0; i < set->n; i++) {
2688 const struct dst *dst = &set->dsts[i];
2690 printf(">p%"PRIu16, dst->dp_ifidx);
2691 if (dst->vlan != OFP_VLAN_NONE) {
2692 printf("v%"PRIu16, dst->vlan);
2698 compose_actions(struct bridge *br, const struct flow *flow, uint16_t vlan,
2699 const struct port *in_port, const struct port *out_port,
2700 tag_type *tags, struct ofpbuf *actions,
2701 uint16_t *nf_output_iface)
2708 compose_dsts(br, flow, vlan, in_port, out_port, &set, tags,
2711 cur_vlan = vlan_tci_to_vid(flow->vlan_tci);
2712 if (cur_vlan == 0) {
2713 cur_vlan = OFP_VLAN_NONE;
2715 for (i = 0; i < set.n; i++) {
2716 const struct dst *dst = &set.dsts[i];
2717 if (dst->vlan != cur_vlan) {
2718 if (dst->vlan == OFP_VLAN_NONE) {
2719 nl_msg_put_flag(actions, ODP_ACTION_ATTR_STRIP_VLAN);
2722 tci = htons(dst->vlan & VLAN_VID_MASK);
2723 tci |= flow->vlan_tci & htons(VLAN_PCP_MASK);
2724 nl_msg_put_be16(actions, ODP_ACTION_ATTR_SET_DL_TCI, tci);
2726 cur_vlan = dst->vlan;
2728 nl_msg_put_u32(actions, ODP_ACTION_ATTR_OUTPUT, dst->dp_ifidx);
2733 /* Returns the effective vlan of a packet, taking into account both the
2734 * 802.1Q header and implicitly tagged ports. A value of 0 indicates that
2735 * the packet is untagged and -1 indicates it has an invalid header and
2736 * should be dropped. */
2737 static int flow_get_vlan(struct bridge *br, const struct flow *flow,
2738 struct port *in_port, bool have_packet)
2740 int vlan = vlan_tci_to_vid(flow->vlan_tci);
2741 if (in_port->vlan >= 0) {
2743 /* XXX support double tagging? */
2745 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2746 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %d tagged "
2747 "packet received on port %s configured with "
2748 "implicit VLAN %"PRIu16,
2749 br->name, vlan, in_port->name, in_port->vlan);
2753 vlan = in_port->vlan;
2755 if (!port_includes_vlan(in_port, vlan)) {
2757 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2758 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %d tagged "
2759 "packet received on port %s not configured for "
2761 br->name, vlan, in_port->name, vlan);
2770 /* A VM broadcasts a gratuitous ARP to indicate that it has resumed after
2771 * migration. Older Citrix-patched Linux DomU used gratuitous ARP replies to
2772 * indicate this; newer upstream kernels use gratuitous ARP requests. */
2774 is_gratuitous_arp(const struct flow *flow)
2776 return (flow->dl_type == htons(ETH_TYPE_ARP)
2777 && eth_addr_is_broadcast(flow->dl_dst)
2778 && (flow->nw_proto == ARP_OP_REPLY
2779 || (flow->nw_proto == ARP_OP_REQUEST
2780 && flow->nw_src == flow->nw_dst)));
2784 update_learning_table(struct bridge *br, const struct flow *flow, int vlan,
2785 struct port *in_port)
2787 enum grat_arp_lock_type lock_type;
2790 /* We don't want to learn from gratuitous ARP packets that are reflected
2791 * back over bond slaves so we lock the learning table. */
2792 lock_type = !is_gratuitous_arp(flow) ? GRAT_ARP_LOCK_NONE :
2793 (in_port->n_ifaces == 1) ? GRAT_ARP_LOCK_SET :
2794 GRAT_ARP_LOCK_CHECK;
2796 rev_tag = mac_learning_learn(br->ml, flow->dl_src, vlan, in_port->port_idx,
2799 /* The log messages here could actually be useful in debugging,
2800 * so keep the rate limit relatively high. */
2801 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(30,
2803 VLOG_DBG_RL(&rl, "bridge %s: learned that "ETH_ADDR_FMT" is "
2804 "on port %s in VLAN %d",
2805 br->name, ETH_ADDR_ARGS(flow->dl_src),
2806 in_port->name, vlan);
2807 ofproto_revalidate(br->ofproto, rev_tag);
2811 /* Determines whether packets in 'flow' within 'br' should be forwarded or
2812 * dropped. Returns true if they may be forwarded, false if they should be
2815 * If 'have_packet' is true, it indicates that the caller is processing a
2816 * received packet. If 'have_packet' is false, then the caller is just
2817 * revalidating an existing flow because configuration has changed. Either
2818 * way, 'have_packet' only affects logging (there is no point in logging errors
2819 * during revalidation).
2821 * Sets '*in_portp' to the input port. This will be a null pointer if
2822 * flow->in_port does not designate a known input port (in which case
2823 * is_admissible() returns false).
2825 * When returning true, sets '*vlanp' to the effective VLAN of the input
2826 * packet, as returned by flow_get_vlan().
2828 * May also add tags to '*tags', although the current implementation only does
2829 * so in one special case.
2832 is_admissible(struct bridge *br, const struct flow *flow, bool have_packet,
2833 tag_type *tags, int *vlanp, struct port **in_portp)
2835 struct iface *in_iface;
2836 struct port *in_port;
2839 /* Find the interface and port structure for the received packet. */
2840 in_iface = iface_from_dp_ifidx(br, flow->in_port);
2842 /* No interface? Something fishy... */
2844 /* Odd. A few possible reasons here:
2846 * - We deleted an interface but there are still a few packets
2847 * queued up from it.
2849 * - Someone externally added an interface (e.g. with "ovs-dpctl
2850 * add-if") that we don't know about.
2852 * - Packet arrived on the local port but the local port is not
2853 * one of our bridge ports.
2855 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2857 VLOG_WARN_RL(&rl, "bridge %s: received packet on unknown "
2858 "interface %"PRIu16, br->name, flow->in_port);
2864 *in_portp = in_port = in_iface->port;
2865 *vlanp = vlan = flow_get_vlan(br, flow, in_port, have_packet);
2870 /* Drop frames for reserved multicast addresses. */
2871 if (eth_addr_is_reserved(flow->dl_dst)) {
2875 /* Drop frames on ports reserved for mirroring. */
2876 if (in_port->is_mirror_output_port) {
2878 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2879 VLOG_WARN_RL(&rl, "bridge %s: dropping packet received on port "
2880 "%s, which is reserved exclusively for mirroring",
2881 br->name, in_port->name);
2886 /* When using LACP, do not accept packets from disabled interfaces. */
2887 if (lacp_negotiated(in_port->lacp) && !in_iface->enabled) {
2891 /* Packets received on non-LACP bonds need special attention to avoid
2893 if (in_port->n_ifaces > 1 && !lacp_negotiated(in_port->lacp)) {
2895 bool is_grat_arp_locked;
2897 if (eth_addr_is_multicast(flow->dl_dst)) {
2898 *tags |= in_port->active_iface_tag;
2899 if (in_port->active_iface != in_iface->port_ifidx) {
2900 /* Drop all multicast packets on inactive slaves. */
2905 /* Drop all packets for which we have learned a different input
2906 * port, because we probably sent the packet on one slave and got
2907 * it back on the other. Gratuitous ARP packets are an exception
2908 * to this rule: the host has moved to another switch. The exception
2909 * to the exception is if we locked the learning table to avoid
2910 * reflections on bond slaves. If this is the case, just drop the
2912 src_idx = mac_learning_lookup(br->ml, flow->dl_src, vlan,
2913 &is_grat_arp_locked);
2914 if (src_idx != -1 && src_idx != in_port->port_idx &&
2915 (!is_gratuitous_arp(flow) || is_grat_arp_locked)) {
2923 /* If the composed actions may be applied to any packet in the given 'flow',
2924 * returns true. Otherwise, the actions should only be applied to 'packet', or
2925 * not at all, if 'packet' was NULL. */
2927 process_flow(struct bridge *br, const struct flow *flow,
2928 const struct ofpbuf *packet, struct ofpbuf *actions,
2929 tag_type *tags, uint16_t *nf_output_iface)
2931 struct port *in_port;
2932 struct port *out_port;
2936 /* Check whether we should drop packets in this flow. */
2937 if (!is_admissible(br, flow, packet != NULL, tags, &vlan, &in_port)) {
2942 /* Learn source MAC (but don't try to learn from revalidation). */
2944 update_learning_table(br, flow, vlan, in_port);
2947 /* Determine output port. */
2948 out_port_idx = mac_learning_lookup_tag(br->ml, flow->dl_dst, vlan, tags,
2950 if (out_port_idx >= 0 && out_port_idx < br->n_ports) {
2951 out_port = br->ports[out_port_idx];
2952 } else if (!packet && !eth_addr_is_multicast(flow->dl_dst)) {
2953 /* If we are revalidating but don't have a learning entry then
2954 * eject the flow. Installing a flow that floods packets opens
2955 * up a window of time where we could learn from a packet reflected
2956 * on a bond and blackhole packets before the learning table is
2957 * updated to reflect the correct port. */
2960 out_port = FLOOD_PORT;
2963 /* Don't send packets out their input ports. */
2964 if (in_port == out_port) {
2970 compose_actions(br, flow, vlan, in_port, out_port, tags, actions,
2978 bridge_normal_ofhook_cb(const struct flow *flow, const struct ofpbuf *packet,
2979 struct ofpbuf *actions, tag_type *tags,
2980 uint16_t *nf_output_iface, void *br_)
2982 struct bridge *br = br_;
2984 COVERAGE_INC(bridge_process_flow);
2985 return process_flow(br, flow, packet, actions, tags, nf_output_iface);
2989 bridge_special_ofhook_cb(const struct flow *flow,
2990 const struct ofpbuf *packet, void *br_)
2992 struct iface *iface;
2993 struct bridge *br = br_;
2995 iface = iface_from_dp_ifidx(br, flow->in_port);
2997 if (cfm_should_process_flow(flow)) {
2999 if (iface && packet && iface->cfm) {
3000 COVERAGE_INC(bridge_process_cfm);
3001 cfm_process_heartbeat(iface->cfm, packet);
3004 } else if (flow->dl_type == htons(ETH_TYPE_LACP)) {
3006 if (iface && iface->port->lacp && packet) {
3007 const struct lacp_pdu *pdu = parse_lacp_packet(packet);
3010 COVERAGE_INC(bridge_process_lacp);
3011 lacp_process_pdu(iface->port->lacp, iface, pdu);
3021 bridge_account_flow_ofhook_cb(const struct flow *flow, tag_type tags,
3022 const struct nlattr *actions,
3024 uint64_t n_bytes, void *br_)
3026 struct bridge *br = br_;
3027 const struct nlattr *a;
3028 struct port *in_port;
3033 /* Feed information from the active flows back into the learning table to
3034 * ensure that table is always in sync with what is actually flowing
3035 * through the datapath.
3037 * We test that 'tags' is nonzero to ensure that only flows that include an
3038 * OFPP_NORMAL action are used for learning. This works because
3039 * bridge_normal_ofhook_cb() always sets a nonzero tag value. */
3040 if (tags && is_admissible(br, flow, false, &dummy, &vlan, &in_port)) {
3041 update_learning_table(br, flow, vlan, in_port);
3044 /* Account for bond slave utilization. */
3045 if (!br->has_bonded_ports) {
3048 NL_ATTR_FOR_EACH_UNSAFE (a, left, actions, actions_len) {
3049 if (nl_attr_type(a) == ODP_ACTION_ATTR_OUTPUT) {
3050 struct port *out_port = port_from_dp_ifidx(br, nl_attr_get_u32(a));
3051 if (out_port && out_port->n_ifaces >= 2 &&
3052 out_port->bond_mode != BM_AB) {
3053 uint16_t vlan = (flow->vlan_tci
3054 ? vlan_tci_to_vid(flow->vlan_tci)
3056 struct bond_entry *e = lookup_bond_entry(out_port, flow, vlan);
3057 e->tx_bytes += n_bytes;
3064 bridge_account_checkpoint_ofhook_cb(void *br_)
3066 struct bridge *br = br_;
3070 if (!br->has_bonded_ports) {
3075 for (i = 0; i < br->n_ports; i++) {
3076 struct port *port = br->ports[i];
3077 if (port->n_ifaces > 1 && port->bond_mode != BM_AB
3078 && now >= port->bond_next_rebalance) {
3079 port->bond_next_rebalance = now + port->bond_rebalance_interval;
3080 bond_rebalance_port(port);
3085 static struct ofhooks bridge_ofhooks = {
3086 bridge_normal_ofhook_cb,
3087 bridge_special_ofhook_cb,
3088 bridge_account_flow_ofhook_cb,
3089 bridge_account_checkpoint_ofhook_cb,
3092 /* Bonding functions. */
3094 /* Statistics for a single interface on a bonded port, used for load-based
3095 * bond rebalancing. */
3096 struct slave_balance {
3097 struct iface *iface; /* The interface. */
3098 uint64_t tx_bytes; /* Sum of hashes[*]->tx_bytes. */
3100 /* All the "bond_entry"s that are assigned to this interface, in order of
3101 * increasing tx_bytes. */
3102 struct bond_entry **hashes;
3107 bond_mode_to_string(enum bond_mode bm) {
3108 static char *bm_slb = "balance-slb";
3109 static char *bm_ab = "active-backup";
3110 static char *bm_tcp = "balance-tcp";
3113 case BM_SLB: return bm_slb;
3114 case BM_AB: return bm_ab;
3115 case BM_TCP: return bm_tcp;
3122 /* Sorts pointers to pointers to bond_entries in ascending order by the
3123 * interface to which they are assigned, and within a single interface in
3124 * ascending order of bytes transmitted. */
3126 compare_bond_entries(const void *a_, const void *b_)
3128 const struct bond_entry *const *ap = a_;
3129 const struct bond_entry *const *bp = b_;
3130 const struct bond_entry *a = *ap;
3131 const struct bond_entry *b = *bp;
3132 if (a->iface_idx != b->iface_idx) {
3133 return a->iface_idx > b->iface_idx ? 1 : -1;
3134 } else if (a->tx_bytes != b->tx_bytes) {
3135 return a->tx_bytes > b->tx_bytes ? 1 : -1;
3141 /* Sorts slave_balances so that enabled ports come first, and otherwise in
3142 * *descending* order by number of bytes transmitted. */
3144 compare_slave_balance(const void *a_, const void *b_)
3146 const struct slave_balance *a = a_;
3147 const struct slave_balance *b = b_;
3148 if (a->iface->enabled != b->iface->enabled) {
3149 return a->iface->enabled ? -1 : 1;
3150 } else if (a->tx_bytes != b->tx_bytes) {
3151 return a->tx_bytes > b->tx_bytes ? -1 : 1;
3158 swap_bals(struct slave_balance *a, struct slave_balance *b)
3160 struct slave_balance tmp = *a;
3165 /* Restores the 'n_bals' slave_balance structures in 'bals' to sorted order
3166 * given that 'p' (and only 'p') might be in the wrong location.
3168 * This function invalidates 'p', since it might now be in a different memory
3171 resort_bals(struct slave_balance *p,
3172 struct slave_balance bals[], size_t n_bals)
3175 for (; p > bals && p->tx_bytes > p[-1].tx_bytes; p--) {
3176 swap_bals(p, p - 1);
3178 for (; p < &bals[n_bals - 1] && p->tx_bytes < p[1].tx_bytes; p++) {
3179 swap_bals(p, p + 1);
3185 log_bals(const struct slave_balance *bals, size_t n_bals, struct port *port)
3187 if (VLOG_IS_DBG_ENABLED()) {
3188 struct ds ds = DS_EMPTY_INITIALIZER;
3189 const struct slave_balance *b;
3191 for (b = bals; b < bals + n_bals; b++) {
3195 ds_put_char(&ds, ',');
3197 ds_put_format(&ds, " %s %"PRIu64"kB",
3198 b->iface->name, b->tx_bytes / 1024);
3200 if (!b->iface->enabled) {
3201 ds_put_cstr(&ds, " (disabled)");
3203 if (b->n_hashes > 0) {
3204 ds_put_cstr(&ds, " (");
3205 for (i = 0; i < b->n_hashes; i++) {
3206 const struct bond_entry *e = b->hashes[i];
3208 ds_put_cstr(&ds, " + ");
3210 ds_put_format(&ds, "h%td: %"PRIu64"kB",
3211 e - port->bond_hash, e->tx_bytes / 1024);
3213 ds_put_cstr(&ds, ")");
3216 VLOG_DBG("bond %s:%s", port->name, ds_cstr(&ds));
3221 /* Shifts 'hash' from 'from' to 'to' within 'port'. */
3223 bond_shift_load(struct slave_balance *from, struct slave_balance *to,
3226 struct bond_entry *hash = from->hashes[hash_idx];
3227 struct port *port = from->iface->port;
3228 uint64_t delta = hash->tx_bytes;
3230 assert(port->bond_mode != BM_AB);
3232 VLOG_INFO("bond %s: shift %"PRIu64"kB of load (with hash %td) "
3233 "from %s to %s (now carrying %"PRIu64"kB and "
3234 "%"PRIu64"kB load, respectively)",
3235 port->name, delta / 1024, hash - port->bond_hash,
3236 from->iface->name, to->iface->name,
3237 (from->tx_bytes - delta) / 1024,
3238 (to->tx_bytes + delta) / 1024);
3240 /* Delete element from from->hashes.
3242 * We don't bother to add the element to to->hashes because not only would
3243 * it require more work, the only purpose it would be to allow that hash to
3244 * be migrated to another slave in this rebalancing run, and there is no
3245 * point in doing that. */
3246 if (hash_idx == 0) {
3249 memmove(from->hashes + hash_idx, from->hashes + hash_idx + 1,
3250 (from->n_hashes - (hash_idx + 1)) * sizeof *from->hashes);
3254 /* Shift load away from 'from' to 'to'. */
3255 from->tx_bytes -= delta;
3256 to->tx_bytes += delta;
3258 /* Arrange for flows to be revalidated. */
3259 ofproto_revalidate(port->bridge->ofproto, hash->iface_tag);
3260 hash->iface_idx = to->iface->port_ifidx;
3261 hash->iface_tag = tag_create_random();
3265 bond_rebalance_port(struct port *port)
3267 struct slave_balance *bals;
3269 struct bond_entry *hashes[BOND_MASK + 1];
3270 struct slave_balance *b, *from, *to;
3271 struct bond_entry *e;
3274 assert(port->bond_mode != BM_AB);
3276 /* Sets up 'bals' to describe each of the port's interfaces, sorted in
3277 * descending order of tx_bytes, so that bals[0] represents the most
3278 * heavily loaded slave and bals[n_bals - 1] represents the least heavily
3281 * The code is a bit tricky: to avoid dynamically allocating a 'hashes'
3282 * array for each slave_balance structure, we sort our local array of
3283 * hashes in order by slave, so that all of the hashes for a given slave
3284 * become contiguous in memory, and then we point each 'hashes' members of
3285 * a slave_balance structure to the start of a contiguous group. */
3286 n_bals = port->n_ifaces;
3287 bals = xmalloc(n_bals * sizeof *bals);
3288 for (b = bals; b < &bals[n_bals]; b++) {
3289 b->iface = port->ifaces[b - bals];
3294 for (i = 0; i <= BOND_MASK; i++) {
3295 hashes[i] = &port->bond_hash[i];
3297 qsort(hashes, BOND_MASK + 1, sizeof *hashes, compare_bond_entries);
3298 for (i = 0; i <= BOND_MASK; i++) {
3300 if (e->iface_idx >= 0 && e->iface_idx < port->n_ifaces) {
3301 b = &bals[e->iface_idx];
3302 b->tx_bytes += e->tx_bytes;
3304 b->hashes = &hashes[i];
3309 qsort(bals, n_bals, sizeof *bals, compare_slave_balance);
3310 log_bals(bals, n_bals, port);
3312 /* Discard slaves that aren't enabled (which were sorted to the back of the
3313 * array earlier). */
3314 while (!bals[n_bals - 1].iface->enabled) {
3321 /* Shift load from the most-loaded slaves to the least-loaded slaves. */
3322 to = &bals[n_bals - 1];
3323 for (from = bals; from < to; ) {
3324 uint64_t overload = from->tx_bytes - to->tx_bytes;
3325 if (overload < to->tx_bytes >> 5 || overload < 100000) {
3326 /* The extra load on 'from' (and all less-loaded slaves), compared
3327 * to that of 'to' (the least-loaded slave), is less than ~3%, or
3328 * it is less than ~1Mbps. No point in rebalancing. */
3330 } else if (from->n_hashes == 1) {
3331 /* 'from' only carries a single MAC hash, so we can't shift any
3332 * load away from it, even though we want to. */
3335 /* 'from' is carrying significantly more load than 'to', and that
3336 * load is split across at least two different hashes. Pick a hash
3337 * to migrate to 'to' (the least-loaded slave), given that doing so
3338 * must decrease the ratio of the load on the two slaves by at
3341 * The sort order we use means that we prefer to shift away the
3342 * smallest hashes instead of the biggest ones. There is little
3343 * reason behind this decision; we could use the opposite sort
3344 * order to shift away big hashes ahead of small ones. */
3347 for (i = 0; i < from->n_hashes; i++) {
3348 double old_ratio, new_ratio;
3349 uint64_t delta = from->hashes[i]->tx_bytes;
3351 if (delta == 0 || from->tx_bytes - delta == 0) {
3352 /* Pointless move. */
3356 order_swapped = from->tx_bytes - delta < to->tx_bytes + delta;
3358 if (to->tx_bytes == 0) {
3359 /* Nothing on the new slave, move it. */
3363 old_ratio = (double)from->tx_bytes / to->tx_bytes;
3364 new_ratio = (double)(from->tx_bytes - delta) /
3365 (to->tx_bytes + delta);
3367 if (new_ratio == 0) {
3368 /* Should already be covered but check to prevent division
3373 if (new_ratio < 1) {
3374 new_ratio = 1 / new_ratio;
3377 if (old_ratio - new_ratio > 0.1) {
3378 /* Would decrease the ratio, move it. */
3382 if (i < from->n_hashes) {
3383 bond_shift_load(from, to, i);
3385 /* If the result of the migration changed the relative order of
3386 * 'from' and 'to' swap them back to maintain invariants. */
3387 if (order_swapped) {
3388 swap_bals(from, to);
3391 /* Re-sort 'bals'. Note that this may make 'from' and 'to'
3392 * point to different slave_balance structures. It is only
3393 * valid to do these two operations in a row at all because we
3394 * know that 'from' will not move past 'to' and vice versa. */
3395 resort_bals(from, bals, n_bals);
3396 resort_bals(to, bals, n_bals);
3403 /* Implement exponentially weighted moving average. A weight of 1/2 causes
3404 * historical data to decay to <1% in 7 rebalancing runs. */
3405 for (e = &port->bond_hash[0]; e <= &port->bond_hash[BOND_MASK]; e++) {
3414 bond_send_learning_packets(struct port *port)
3416 struct bridge *br = port->bridge;
3417 struct mac_entry *e;
3418 struct ofpbuf packet;
3419 int error, n_packets, n_errors;
3421 if (!port->n_ifaces || port->active_iface < 0 || bond_is_tcp_hash(port)) {
3425 ofpbuf_init(&packet, 128);
3426 error = n_packets = n_errors = 0;
3427 LIST_FOR_EACH (e, lru_node, &br->ml->lrus) {
3433 if (e->port == port->port_idx) {
3437 compose_benign_packet(&packet, "Open vSwitch Bond Failover", 0xf177,
3439 flow_extract(&packet, 0, ODPP_NONE, &flow);
3441 if (!choose_output_iface(port, &flow, e->vlan, &dp_ifidx, &tags)) {
3447 retval = ofproto_send_packet(br->ofproto, dp_ifidx, e->vlan, &packet);
3453 ofpbuf_uninit(&packet);
3456 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
3457 VLOG_WARN_RL(&rl, "bond %s: %d errors sending %d gratuitous learning "
3458 "packets, last error was: %s",
3459 port->name, n_errors, n_packets, strerror(error));
3461 VLOG_DBG("bond %s: sent %d gratuitous learning packets",
3462 port->name, n_packets);
3466 /* Bonding unixctl user interface functions. */
3469 bond_unixctl_list(struct unixctl_conn *conn,
3470 const char *args OVS_UNUSED, void *aux OVS_UNUSED)
3472 struct ds ds = DS_EMPTY_INITIALIZER;
3473 const struct bridge *br;
3475 ds_put_cstr(&ds, "bridge\tbond\ttype\tslaves\n");
3477 LIST_FOR_EACH (br, node, &all_bridges) {
3480 for (i = 0; i < br->n_ports; i++) {
3481 const struct port *port = br->ports[i];
3482 if (port->n_ifaces > 1) {
3485 ds_put_format(&ds, "%s\t%s\t%s\t", br->name, port->name,
3486 bond_mode_to_string(port->bond_mode));
3487 for (j = 0; j < port->n_ifaces; j++) {
3488 const struct iface *iface = port->ifaces[j];
3490 ds_put_cstr(&ds, ", ");
3492 ds_put_cstr(&ds, iface->name);
3494 ds_put_char(&ds, '\n');
3498 unixctl_command_reply(conn, 200, ds_cstr(&ds));
3502 static struct port *
3503 bond_find(const char *name)
3505 const struct bridge *br;
3507 LIST_FOR_EACH (br, node, &all_bridges) {
3510 for (i = 0; i < br->n_ports; i++) {
3511 struct port *port = br->ports[i];
3512 if (!strcmp(port->name, name) && port->n_ifaces > 1) {
3521 bond_unixctl_show(struct unixctl_conn *conn,
3522 const char *args, void *aux OVS_UNUSED)
3524 struct ds ds = DS_EMPTY_INITIALIZER;
3525 const struct port *port;
3528 port = bond_find(args);
3530 unixctl_command_reply(conn, 501, "no such bond");
3534 ds_put_format(&ds, "bond_mode: %s\n",
3535 bond_mode_to_string(port->bond_mode));
3538 ds_put_format(&ds, "lacp: %s\n",
3539 port->lacp_active ? "active" : "passive");
3541 ds_put_cstr(&ds, "lacp: off\n");
3544 if (port->bond_mode != BM_AB) {
3545 ds_put_format(&ds, "bond-hash-algorithm: %s\n",
3546 bond_is_tcp_hash(port) ? "balance-tcp" : "balance-slb");
3550 ds_put_format(&ds, "bond-detect-mode: %s\n",
3551 port->monitor ? "carrier" : "miimon");
3553 if (!port->monitor) {
3554 ds_put_format(&ds, "bond-miimon-interval: %lld\n",
3555 port->miimon_interval);
3558 ds_put_format(&ds, "updelay: %d ms\n", port->updelay);
3559 ds_put_format(&ds, "downdelay: %d ms\n", port->downdelay);
3561 if (port->bond_mode != BM_AB) {
3562 ds_put_format(&ds, "next rebalance: %lld ms\n",
3563 port->bond_next_rebalance - time_msec());
3566 for (j = 0; j < port->n_ifaces; j++) {
3567 const struct iface *iface = port->ifaces[j];
3568 struct bond_entry *be;
3572 ds_put_format(&ds, "\nslave %s: %s\n",
3573 iface->name, iface->enabled ? "enabled" : "disabled");
3574 if (j == port->active_iface) {
3575 ds_put_cstr(&ds, "\tactive slave\n");
3577 if (iface->delay_expires != LLONG_MAX) {
3578 ds_put_format(&ds, "\t%s expires in %lld ms\n",
3579 iface->enabled ? "downdelay" : "updelay",
3580 iface->delay_expires - time_msec());
3583 if (port->bond_mode == BM_AB) {
3588 memset(&flow, 0, sizeof flow);
3589 for (be = port->bond_hash; be <= &port->bond_hash[BOND_MASK]; be++) {
3590 int hash = be - port->bond_hash;
3591 struct mac_entry *me;
3593 if (be->iface_idx != j) {
3597 ds_put_format(&ds, "\thash %d: %"PRIu64" kB load\n",
3598 hash, be->tx_bytes / 1024);
3600 if (port->bond_mode != BM_SLB) {
3605 LIST_FOR_EACH (me, lru_node, &port->bridge->ml->lrus) {
3609 memcpy(flow.dl_src, me->mac, ETH_ADDR_LEN);
3610 if (bond_hash_src(me->mac, me->vlan) == hash
3611 && me->port != port->port_idx
3612 && choose_output_iface(port, &flow, me->vlan,
3614 && dp_ifidx == iface->dp_ifidx)
3616 ds_put_format(&ds, "\t\t"ETH_ADDR_FMT"\n",
3617 ETH_ADDR_ARGS(me->mac));
3622 unixctl_command_reply(conn, 200, ds_cstr(&ds));
3627 bond_unixctl_migrate(struct unixctl_conn *conn, const char *args_,
3628 void *aux OVS_UNUSED)
3630 char *args = (char *) args_;
3631 char *save_ptr = NULL;
3632 char *bond_s, *hash_s, *slave_s;
3634 struct iface *iface;
3635 struct bond_entry *entry;
3638 bond_s = strtok_r(args, " ", &save_ptr);
3639 hash_s = strtok_r(NULL, " ", &save_ptr);
3640 slave_s = strtok_r(NULL, " ", &save_ptr);
3642 unixctl_command_reply(conn, 501,
3643 "usage: bond/migrate BOND HASH SLAVE");
3647 port = bond_find(bond_s);
3649 unixctl_command_reply(conn, 501, "no such bond");
3653 if (port->bond_mode != BM_SLB) {
3654 unixctl_command_reply(conn, 501, "not an SLB bond");
3658 if (strspn(hash_s, "0123456789") == strlen(hash_s)) {
3659 hash = atoi(hash_s) & BOND_MASK;
3661 unixctl_command_reply(conn, 501, "bad hash");
3665 iface = port_lookup_iface(port, slave_s);
3667 unixctl_command_reply(conn, 501, "no such slave");
3671 if (!iface->enabled) {
3672 unixctl_command_reply(conn, 501, "cannot migrate to disabled slave");
3676 entry = &port->bond_hash[hash];
3677 ofproto_revalidate(port->bridge->ofproto, entry->iface_tag);
3678 entry->iface_idx = iface->port_ifidx;
3679 entry->iface_tag = tag_create_random();
3680 unixctl_command_reply(conn, 200, "migrated");
3684 bond_unixctl_set_active_slave(struct unixctl_conn *conn, const char *args_,
3685 void *aux OVS_UNUSED)
3687 char *args = (char *) args_;
3688 char *save_ptr = NULL;
3689 char *bond_s, *slave_s;
3691 struct iface *iface;
3693 bond_s = strtok_r(args, " ", &save_ptr);
3694 slave_s = strtok_r(NULL, " ", &save_ptr);
3696 unixctl_command_reply(conn, 501,
3697 "usage: bond/set-active-slave BOND SLAVE");
3701 port = bond_find(bond_s);
3703 unixctl_command_reply(conn, 501, "no such bond");
3707 iface = port_lookup_iface(port, slave_s);
3709 unixctl_command_reply(conn, 501, "no such slave");
3713 if (!iface->enabled) {
3714 unixctl_command_reply(conn, 501, "cannot make disabled slave active");
3718 if (port->active_iface != iface->port_ifidx) {
3719 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
3720 port->active_iface = iface->port_ifidx;
3721 port->active_iface_tag = tag_create_random();
3722 VLOG_INFO("port %s: active interface is now %s",
3723 port->name, iface->name);
3724 bond_send_learning_packets(port);
3725 unixctl_command_reply(conn, 200, "done");
3727 unixctl_command_reply(conn, 200, "no change");
3732 enable_slave(struct unixctl_conn *conn, const char *args_, bool enable)
3734 char *args = (char *) args_;
3735 char *save_ptr = NULL;
3736 char *bond_s, *slave_s;
3738 struct iface *iface;
3740 bond_s = strtok_r(args, " ", &save_ptr);
3741 slave_s = strtok_r(NULL, " ", &save_ptr);
3743 unixctl_command_reply(conn, 501,
3744 "usage: bond/enable/disable-slave BOND SLAVE");
3748 port = bond_find(bond_s);
3750 unixctl_command_reply(conn, 501, "no such bond");
3754 iface = port_lookup_iface(port, slave_s);
3756 unixctl_command_reply(conn, 501, "no such slave");
3760 bond_enable_slave(iface, enable);
3761 unixctl_command_reply(conn, 501, enable ? "enabled" : "disabled");
3765 bond_unixctl_enable_slave(struct unixctl_conn *conn, const char *args,
3766 void *aux OVS_UNUSED)
3768 enable_slave(conn, args, true);
3772 bond_unixctl_disable_slave(struct unixctl_conn *conn, const char *args,
3773 void *aux OVS_UNUSED)
3775 enable_slave(conn, args, false);
3779 bond_unixctl_hash(struct unixctl_conn *conn, const char *args_,
3780 void *aux OVS_UNUSED)
3782 char *args = (char *) args_;
3783 uint8_t mac[ETH_ADDR_LEN];
3787 char *mac_s, *vlan_s;
3788 char *save_ptr = NULL;
3790 mac_s = strtok_r(args, " ", &save_ptr);
3791 vlan_s = strtok_r(NULL, " ", &save_ptr);
3794 if (sscanf(vlan_s, "%u", &vlan) != 1) {
3795 unixctl_command_reply(conn, 501, "invalid vlan");
3799 vlan = OFP_VLAN_NONE;
3802 if (sscanf(mac_s, ETH_ADDR_SCAN_FMT, ETH_ADDR_SCAN_ARGS(mac))
3803 == ETH_ADDR_SCAN_COUNT) {
3804 hash = bond_hash_src(mac, vlan);
3806 hash_cstr = xasprintf("%u", hash);
3807 unixctl_command_reply(conn, 200, hash_cstr);
3810 unixctl_command_reply(conn, 501, "invalid mac");
3817 unixctl_command_register("bond/list", bond_unixctl_list, NULL);
3818 unixctl_command_register("bond/show", bond_unixctl_show, NULL);
3819 unixctl_command_register("bond/migrate", bond_unixctl_migrate, NULL);
3820 unixctl_command_register("bond/set-active-slave",
3821 bond_unixctl_set_active_slave, NULL);
3822 unixctl_command_register("bond/enable-slave", bond_unixctl_enable_slave,
3824 unixctl_command_register("bond/disable-slave", bond_unixctl_disable_slave,
3826 unixctl_command_register("bond/hash", bond_unixctl_hash, NULL);
3829 /* Port functions. */
3832 lacp_send_pdu_cb(void *aux, const struct lacp_pdu *pdu)
3834 struct iface *iface = aux;
3835 uint8_t ea[ETH_ADDR_LEN];
3838 error = netdev_get_etheraddr(iface->netdev, ea);
3840 struct ofpbuf packet;
3842 ofpbuf_init(&packet, ETH_HEADER_LEN + LACP_PDU_LEN);
3843 compose_lacp_packet(&packet, ea, pdu);
3844 ofproto_send_packet(iface->port->bridge->ofproto,
3845 iface->dp_ifidx, 0, &packet);
3846 ofpbuf_uninit(&packet);
3848 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 10);
3849 VLOG_ERR_RL(&rl, "iface %s: failed to obtain Ethernet address "
3850 "(%s)", iface->name, strerror(error));
3855 port_run(struct port *port)
3859 if (port->monitor) {
3862 /* Track carrier going up and down on interfaces. */
3863 while (!netdev_monitor_poll(port->monitor, &devname)) {
3864 struct iface *iface;
3866 iface = port_lookup_iface(port, devname);
3868 iface_update_carrier(iface);
3872 } else if (time_msec() >= port->miimon_next_update) {
3874 for (i = 0; i < port->n_ifaces; i++) {
3875 struct iface *iface = port->ifaces[i];
3876 iface_update_carrier(iface);
3878 port->miimon_next_update = time_msec() + port->miimon_interval;
3882 for (i = 0; i < port->n_ifaces; i++) {
3883 struct iface *iface = port->ifaces[i];
3884 lacp_slave_enable(port->lacp, iface, iface->enabled);
3887 lacp_run(port->lacp, lacp_send_pdu_cb);
3892 for (i = 0; i < port->n_ifaces; i++) {
3893 struct iface *iface = port->ifaces[i];
3896 struct ofpbuf *packet = cfm_run(iface->cfm);
3898 ofproto_send_packet(port->bridge->ofproto, iface->dp_ifidx,
3900 ofpbuf_uninit(packet);
3908 port_wait(struct port *port)
3912 if (port->monitor) {
3913 netdev_monitor_poll_wait(port->monitor);
3915 poll_timer_wait_until(port->miimon_next_update);
3919 lacp_wait(port->lacp);
3924 for (i = 0; i < port->n_ifaces; i++) {
3925 struct iface *iface = port->ifaces[i];
3927 cfm_wait(iface->cfm);
3932 static struct port *
3933 port_create(struct bridge *br, const char *name)
3937 port = xzalloc(sizeof *port);
3939 port->port_idx = br->n_ports;
3941 port->trunks = NULL;
3942 port->name = xstrdup(name);
3943 port->active_iface = -1;
3945 if (br->n_ports >= br->allocated_ports) {
3946 br->ports = x2nrealloc(br->ports, &br->allocated_ports,
3949 br->ports[br->n_ports++] = port;
3950 shash_add_assert(&br->port_by_name, port->name, port);
3952 VLOG_INFO("created port %s on bridge %s", port->name, br->name);
3959 get_port_other_config(const struct ovsrec_port *port, const char *key,
3960 const char *default_value)
3964 value = get_ovsrec_key_value(&port->header_, &ovsrec_port_col_other_config,
3966 return value ? value : default_value;
3970 get_interface_other_config(const struct ovsrec_interface *iface,
3971 const char *key, const char *default_value)
3975 value = get_ovsrec_key_value(&iface->header_,
3976 &ovsrec_interface_col_other_config, key);
3977 return value ? value : default_value;
3981 port_del_ifaces(struct port *port, const struct ovsrec_port *cfg)
3983 struct shash new_ifaces;
3986 /* Collect list of new interfaces. */
3987 shash_init(&new_ifaces);
3988 for (i = 0; i < cfg->n_interfaces; i++) {
3989 const char *name = cfg->interfaces[i]->name;
3990 shash_add_once(&new_ifaces, name, NULL);
3993 /* Get rid of deleted interfaces. */
3994 for (i = 0; i < port->n_ifaces; ) {
3995 if (!shash_find(&new_ifaces, cfg->interfaces[i]->name)) {
3996 iface_destroy(port->ifaces[i]);
4002 shash_destroy(&new_ifaces);
4006 port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
4008 const char *detect_mode;
4009 struct shash new_ifaces;
4010 long long int next_rebalance, miimon_next_update, lacp_priority;
4011 unsigned long *trunks;
4017 /* Update settings. */
4018 port->updelay = cfg->bond_updelay;
4019 if (port->updelay < 0) {
4022 port->downdelay = cfg->bond_downdelay;
4023 if (port->downdelay < 0) {
4024 port->downdelay = 0;
4026 port->bond_rebalance_interval = atoi(
4027 get_port_other_config(cfg, "bond-rebalance-interval", "10000"));
4028 if (port->bond_rebalance_interval < 1000) {
4029 port->bond_rebalance_interval = 1000;
4031 next_rebalance = time_msec() + port->bond_rebalance_interval;
4032 if (port->bond_next_rebalance > next_rebalance) {
4033 port->bond_next_rebalance = next_rebalance;
4036 detect_mode = get_port_other_config(cfg, "bond-detect-mode",
4039 netdev_monitor_destroy(port->monitor);
4040 port->monitor = NULL;
4042 if (strcmp(detect_mode, "miimon")) {
4043 port->monitor = netdev_monitor_create();
4045 if (strcmp(detect_mode, "carrier")) {
4046 VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
4047 "defaulting to carrier", port->name, detect_mode);
4051 port->miimon_interval = atoi(
4052 get_port_other_config(cfg, "bond-miimon-interval", "200"));
4053 if (port->miimon_interval < 100) {
4054 port->miimon_interval = 100;
4056 miimon_next_update = time_msec() + port->miimon_interval;
4057 if (port->miimon_next_update > miimon_next_update) {
4058 port->miimon_next_update = miimon_next_update;
4061 if (!port->cfg->bond_mode ||
4062 !strcmp(port->cfg->bond_mode, bond_mode_to_string(BM_SLB))) {
4063 port->bond_mode = BM_SLB;
4064 } else if (!strcmp(port->cfg->bond_mode, bond_mode_to_string(BM_AB))) {
4065 port->bond_mode = BM_AB;
4066 } else if (!strcmp(port->cfg->bond_mode, bond_mode_to_string(BM_TCP))) {
4067 port->bond_mode = BM_TCP;
4069 port->bond_mode = BM_SLB;
4070 VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
4071 port->name, port->cfg->bond_mode,
4072 bond_mode_to_string(port->bond_mode));
4075 /* Add new interfaces and update 'cfg' member of existing ones. */
4076 shash_init(&new_ifaces);
4077 for (i = 0; i < cfg->n_interfaces; i++) {
4078 const struct ovsrec_interface *if_cfg = cfg->interfaces[i];
4079 struct iface *iface;
4081 if (!shash_add_once(&new_ifaces, if_cfg->name, NULL)) {
4082 VLOG_WARN("port %s: %s specified twice as port interface",
4083 port->name, if_cfg->name);
4084 iface_set_ofport(if_cfg, -1);
4088 iface = iface_lookup(port->bridge, if_cfg->name);
4090 if (iface->port != port) {
4091 VLOG_ERR("bridge %s: %s interface is on multiple ports, "
4093 port->bridge->name, if_cfg->name, iface->port->name);
4096 iface->cfg = if_cfg;
4098 iface = iface_create(port, if_cfg);
4101 /* Determine interface type. The local port always has type
4102 * "internal". Other ports take their type from the database and
4103 * default to "system" if none is specified. */
4104 iface->type = (!strcmp(if_cfg->name, port->bridge->name) ? "internal"
4105 : if_cfg->type[0] ? if_cfg->type
4109 atoi(get_interface_other_config(if_cfg, "lacp-port-priority",
4112 if (lacp_priority <= 0 || lacp_priority > UINT16_MAX) {
4113 iface->lacp_priority = UINT16_MAX;
4115 iface->lacp_priority = lacp_priority;
4118 shash_destroy(&new_ifaces);
4120 port->lacp_fast = !strcmp(get_port_other_config(cfg, "lacp-time", "slow"),
4124 atoi(get_port_other_config(cfg, "lacp-system-priority", "0"));
4126 if (lacp_priority <= 0 || lacp_priority > UINT16_MAX) {
4127 /* Prefer bondable links if unspecified. */
4128 port->lacp_priority = port->n_ifaces > 1 ? UINT16_MAX - 1 : UINT16_MAX;
4130 port->lacp_priority = lacp_priority;
4133 if (!port->cfg->lacp) {
4134 /* XXX when LACP implementation has been sufficiently tested, enable by
4135 * default and make active on bonded ports. */
4136 lacp_destroy(port->lacp);
4138 } else if (!strcmp(port->cfg->lacp, "off")) {
4139 lacp_destroy(port->lacp);
4141 } else if (!strcmp(port->cfg->lacp, "active")) {
4143 port->lacp = lacp_create();
4145 port->lacp_active = true;
4146 } else if (!strcmp(port->cfg->lacp, "passive")) {
4148 port->lacp = lacp_create();
4150 port->lacp_active = false;
4152 VLOG_WARN("port %s: unknown LACP mode %s",
4153 port->name, port->cfg->lacp);
4154 lacp_destroy(port->lacp);
4161 if (port->n_ifaces < 2) {
4163 if (vlan >= 0 && vlan <= 4095) {
4164 VLOG_DBG("port %s: assigning VLAN tag %d", port->name, vlan);
4169 /* It's possible that bonded, VLAN-tagged ports make sense. Maybe
4170 * they even work as-is. But they have not been tested. */
4171 VLOG_WARN("port %s: VLAN tags not supported on bonded ports",
4175 if (port->vlan != vlan) {
4177 bridge_flush(port->bridge);
4180 /* Get trunked VLANs. */
4182 if (vlan < 0 && cfg->n_trunks) {
4185 trunks = bitmap_allocate(4096);
4187 for (i = 0; i < cfg->n_trunks; i++) {
4188 int trunk = cfg->trunks[i];
4190 bitmap_set1(trunks, trunk);
4196 VLOG_ERR("port %s: invalid values for %zu trunk VLANs",
4197 port->name, cfg->n_trunks);
4199 if (n_errors == cfg->n_trunks) {
4200 VLOG_ERR("port %s: no valid trunks, trunking all VLANs",
4202 bitmap_free(trunks);
4205 } else if (vlan >= 0 && cfg->n_trunks) {
4206 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
4210 ? port->trunks != NULL
4211 : port->trunks == NULL || !bitmap_equal(trunks, port->trunks, 4096)) {
4212 bridge_flush(port->bridge);
4214 bitmap_free(port->trunks);
4215 port->trunks = trunks;
4219 port_destroy(struct port *port)
4222 struct bridge *br = port->bridge;
4226 for (i = 0; i < MAX_MIRRORS; i++) {
4227 struct mirror *m = br->mirrors[i];
4228 if (m && m->out_port == port) {
4233 while (port->n_ifaces > 0) {
4234 iface_destroy(port->ifaces[port->n_ifaces - 1]);
4237 shash_find_and_delete_assert(&br->port_by_name, port->name);
4239 del = br->ports[port->port_idx] = br->ports[--br->n_ports];
4240 del->port_idx = port->port_idx;
4242 VLOG_INFO("destroyed port %s on bridge %s", port->name, br->name);
4244 netdev_monitor_destroy(port->monitor);
4246 bitmap_free(port->trunks);
4253 static struct port *
4254 port_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
4256 struct iface *iface = iface_from_dp_ifidx(br, dp_ifidx);
4257 return iface ? iface->port : NULL;
4260 static struct port *
4261 port_lookup(const struct bridge *br, const char *name)
4263 return shash_find_data(&br->port_by_name, name);
4266 static struct iface *
4267 port_lookup_iface(const struct port *port, const char *name)
4269 struct iface *iface = iface_lookup(port->bridge, name);
4270 return iface && iface->port == port ? iface : NULL;
4274 port_update_lacp(struct port *port)
4279 lacp_configure(port->lacp, port->name,
4280 port->bridge->ea, port->lacp_priority,
4281 port->lacp_active, port->lacp_fast);
4283 for (i = 0; i < port->n_ifaces; i++) {
4284 struct iface *iface = port->ifaces[i];
4285 lacp_slave_register(port->lacp, iface, iface->name,
4286 iface->dp_ifidx, iface->lacp_priority);
4292 port_update_bonding(struct port *port)
4294 if (port->n_ifaces < 2) {
4295 /* Not a bonded port. */
4296 free(port->bond_hash);
4297 port->bond_hash = NULL;
4298 port->bond_fake_iface = false;
4299 port->active_iface = -1;
4300 port->no_ifaces_tag = 0;
4304 if (port->bond_mode != BM_AB && !port->bond_hash) {
4305 port->bond_hash = xcalloc(BOND_MASK + 1, sizeof *port->bond_hash);
4306 for (i = 0; i <= BOND_MASK; i++) {
4307 struct bond_entry *e = &port->bond_hash[i];
4311 port->bond_next_rebalance
4312 = time_msec() + port->bond_rebalance_interval;
4313 } else if (port->bond_mode == BM_AB) {
4314 free(port->bond_hash);
4315 port->bond_hash = NULL;
4318 if (!port->no_ifaces_tag) {
4319 port->no_ifaces_tag = tag_create_random();
4322 if (port->active_iface < 0) {
4323 bond_choose_active_iface(port);
4326 port->bond_fake_iface = port->cfg->bond_fake_iface;
4327 if (port->bond_fake_iface) {
4328 port->bond_next_fake_iface_update = time_msec();
4334 /* Interface functions. */
4336 static struct iface *
4337 iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
4339 struct bridge *br = port->bridge;
4340 struct iface *iface;
4341 char *name = if_cfg->name;
4343 iface = xzalloc(sizeof *iface);
4345 iface->port_ifidx = port->n_ifaces;
4346 iface->name = xstrdup(name);
4347 iface->dp_ifidx = -1;
4348 iface->tag = tag_create_random();
4349 iface->delay_expires = LLONG_MAX;
4350 iface->netdev = NULL;
4351 iface->cfg = if_cfg;
4353 shash_add_assert(&br->iface_by_name, iface->name, iface);
4355 if (port->n_ifaces >= port->allocated_ifaces) {
4356 port->ifaces = x2nrealloc(port->ifaces, &port->allocated_ifaces,
4357 sizeof *port->ifaces);
4359 port->ifaces[port->n_ifaces++] = iface;
4360 if (port->n_ifaces > 1) {
4361 br->has_bonded_ports = true;
4364 VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
4372 iface_destroy(struct iface *iface)
4375 struct port *port = iface->port;
4376 struct bridge *br = port->bridge;
4377 bool del_active = port->active_iface == iface->port_ifidx;
4380 if (iface->port->lacp) {
4381 lacp_slave_unregister(iface->port->lacp, iface);
4384 if (port->monitor && iface->netdev) {
4385 netdev_monitor_remove(port->monitor, iface->netdev);
4388 shash_find_and_delete_assert(&br->iface_by_name, iface->name);
4390 if (iface->dp_ifidx >= 0) {
4391 hmap_remove(&br->ifaces, &iface->dp_ifidx_node);
4394 del = port->ifaces[iface->port_ifidx] = port->ifaces[--port->n_ifaces];
4395 del->port_ifidx = iface->port_ifidx;
4397 netdev_close(iface->netdev);
4400 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
4401 bond_choose_active_iface(port);
4402 bond_send_learning_packets(port);
4405 cfm_destroy(iface->cfm);
4410 bridge_flush(port->bridge);
4414 static struct iface *
4415 iface_lookup(const struct bridge *br, const char *name)
4417 return shash_find_data(&br->iface_by_name, name);
4420 static struct iface *
4421 iface_find(const char *name)
4423 const struct bridge *br;
4425 LIST_FOR_EACH (br, node, &all_bridges) {
4426 struct iface *iface = iface_lookup(br, name);
4435 static struct iface *
4436 iface_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
4438 struct iface *iface;
4440 HMAP_FOR_EACH_IN_BUCKET (iface, dp_ifidx_node,
4441 hash_int(dp_ifidx, 0), &br->ifaces) {
4442 if (iface->dp_ifidx == dp_ifidx) {
4449 /* Set Ethernet address of 'iface', if one is specified in the configuration
4452 iface_set_mac(struct iface *iface)
4454 uint8_t ea[ETH_ADDR_LEN];
4456 if (iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
4457 if (eth_addr_is_multicast(ea)) {
4458 VLOG_ERR("interface %s: cannot set MAC to multicast address",
4460 } else if (iface->dp_ifidx == ODPP_LOCAL) {
4461 VLOG_ERR("ignoring iface.%s.mac; use bridge.%s.mac instead",
4462 iface->name, iface->name);
4464 int error = netdev_set_etheraddr(iface->netdev, ea);
4466 VLOG_ERR("interface %s: setting MAC failed (%s)",
4467 iface->name, strerror(error));
4473 /* Sets the ofport column of 'if_cfg' to 'ofport'. */
4475 iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
4478 ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
4482 /* Adds the 'n' key-value pairs in 'keys' in 'values' to 'shash'.
4484 * The value strings in '*shash' are taken directly from values[], not copied,
4485 * so the caller should not modify or free them. */
4487 shash_from_ovs_idl_map(char **keys, char **values, size_t n,
4488 struct shash *shash)
4493 for (i = 0; i < n; i++) {
4494 shash_add(shash, keys[i], values[i]);
4498 /* Creates 'keys' and 'values' arrays from 'shash'.
4500 * Sets 'keys' and 'values' to heap allocated arrays representing the key-value
4501 * pairs in 'shash'. The caller takes ownership of 'keys' and 'values'. They
4502 * are populated with with strings taken directly from 'shash' and thus have
4503 * the same ownership of the key-value pairs in shash.
4506 shash_to_ovs_idl_map(struct shash *shash,
4507 char ***keys, char ***values, size_t *n)
4511 struct shash_node *sn;
4513 count = shash_count(shash);
4515 k = xmalloc(count * sizeof *k);
4516 v = xmalloc(count * sizeof *v);
4519 SHASH_FOR_EACH(sn, shash) {
4530 struct iface_delete_queues_cbdata {
4531 struct netdev *netdev;
4532 const struct ovsdb_datum *queues;
4536 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
4538 union ovsdb_atom atom;
4540 atom.integer = target;
4541 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
4545 iface_delete_queues(unsigned int queue_id,
4546 const struct shash *details OVS_UNUSED, void *cbdata_)
4548 struct iface_delete_queues_cbdata *cbdata = cbdata_;
4550 if (!queue_ids_include(cbdata->queues, queue_id)) {
4551 netdev_delete_queue(cbdata->netdev, queue_id);
4556 iface_update_carrier(struct iface *iface)
4558 bool carrier = iface_get_carrier(iface);
4559 if (carrier == iface->up) {
4563 iface->up = carrier;
4564 if (iface->port->lacp) {
4565 lacp_slave_carrier_changed(iface->port->lacp, iface);
4570 iface_update_qos(struct iface *iface, const struct ovsrec_qos *qos)
4572 if (!qos || qos->type[0] == '\0') {
4573 netdev_set_qos(iface->netdev, NULL, NULL);
4575 struct iface_delete_queues_cbdata cbdata;
4576 struct shash details;
4579 /* Configure top-level Qos for 'iface'. */
4580 shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
4581 qos->n_other_config, &details);
4582 netdev_set_qos(iface->netdev, qos->type, &details);
4583 shash_destroy(&details);
4585 /* Deconfigure queues that were deleted. */
4586 cbdata.netdev = iface->netdev;
4587 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
4589 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
4591 /* Configure queues for 'iface'. */
4592 for (i = 0; i < qos->n_queues; i++) {
4593 const struct ovsrec_queue *queue = qos->value_queues[i];
4594 unsigned int queue_id = qos->key_queues[i];
4596 shash_from_ovs_idl_map(queue->key_other_config,
4597 queue->value_other_config,
4598 queue->n_other_config, &details);
4599 netdev_set_queue(iface->netdev, queue_id, &details);
4600 shash_destroy(&details);
4606 iface_update_cfm(struct iface *iface)
4610 uint16_t *remote_mps;
4611 struct ovsrec_monitor *mon;
4612 uint8_t ea[ETH_ADDR_LEN], maid[CCM_MAID_LEN];
4614 mon = iface->cfg->monitor;
4617 cfm_destroy(iface->cfm);
4622 if (netdev_get_etheraddr(iface->netdev, ea)) {
4623 VLOG_WARN("interface %s: Failed to get ethernet address. "
4624 "Skipping Monitor.", iface->name);
4628 if (!cfm_generate_maid(mon->md_name, mon->ma_name, maid)) {
4629 VLOG_WARN("interface %s: Failed to generate MAID.", iface->name);
4634 iface->cfm = cfm_create();
4638 cfm->mpid = mon->mpid;
4639 cfm->interval = mon->interval ? *mon->interval : 1000;
4641 memcpy(cfm->eth_src, ea, sizeof cfm->eth_src);
4642 memcpy(cfm->maid, maid, sizeof cfm->maid);
4644 remote_mps = xzalloc(mon->n_remote_mps * sizeof *remote_mps);
4645 for(i = 0; i < mon->n_remote_mps; i++) {
4646 remote_mps[i] = mon->remote_mps[i]->mpid;
4648 cfm_update_remote_mps(cfm, remote_mps, mon->n_remote_mps);
4651 if (!cfm_configure(iface->cfm)) {
4652 cfm_destroy(iface->cfm);
4657 /* Read carrier or miimon status directly from 'iface''s netdev, according to
4658 * how 'iface''s port is configured.
4660 * Returns true if 'iface' is up, false otherwise. */
4662 iface_get_carrier(const struct iface *iface)
4664 return (iface->port->monitor
4665 ? netdev_get_carrier(iface->netdev)
4666 : netdev_get_miimon(iface->netdev));
4669 /* Port mirroring. */
4671 static struct mirror *
4672 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
4676 for (i = 0; i < MAX_MIRRORS; i++) {
4677 struct mirror *m = br->mirrors[i];
4678 if (m && uuid_equals(uuid, &m->uuid)) {
4686 mirror_reconfigure(struct bridge *br)
4688 unsigned long *rspan_vlans;
4691 /* Get rid of deleted mirrors. */
4692 for (i = 0; i < MAX_MIRRORS; i++) {
4693 struct mirror *m = br->mirrors[i];
4695 const struct ovsdb_datum *mc;
4696 union ovsdb_atom atom;
4698 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
4699 atom.uuid = br->mirrors[i]->uuid;
4700 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
4706 /* Add new mirrors and reconfigure existing ones. */
4707 for (i = 0; i < br->cfg->n_mirrors; i++) {
4708 struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
4709 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
4711 mirror_reconfigure_one(m, cfg);
4713 mirror_create(br, cfg);
4717 /* Update port reserved status. */
4718 for (i = 0; i < br->n_ports; i++) {
4719 br->ports[i]->is_mirror_output_port = false;
4721 for (i = 0; i < MAX_MIRRORS; i++) {
4722 struct mirror *m = br->mirrors[i];
4723 if (m && m->out_port) {
4724 m->out_port->is_mirror_output_port = true;
4728 /* Update flooded vlans (for RSPAN). */
4730 if (br->cfg->n_flood_vlans) {
4731 rspan_vlans = bitmap_allocate(4096);
4733 for (i = 0; i < br->cfg->n_flood_vlans; i++) {
4734 int64_t vlan = br->cfg->flood_vlans[i];
4735 if (vlan >= 0 && vlan < 4096) {
4736 bitmap_set1(rspan_vlans, vlan);
4737 VLOG_INFO("bridge %s: disabling learning on vlan %"PRId64,
4740 VLOG_ERR("bridge %s: invalid value %"PRId64 "for flood VLAN",
4745 if (mac_learning_set_flood_vlans(br->ml, rspan_vlans)) {
4751 mirror_create(struct bridge *br, struct ovsrec_mirror *cfg)
4756 for (i = 0; ; i++) {
4757 if (i >= MAX_MIRRORS) {
4758 VLOG_WARN("bridge %s: maximum of %d port mirrors reached, "
4759 "cannot create %s", br->name, MAX_MIRRORS, cfg->name);
4762 if (!br->mirrors[i]) {
4767 VLOG_INFO("created port mirror %s on bridge %s", cfg->name, br->name);
4770 br->mirrors[i] = m = xzalloc(sizeof *m);
4773 m->name = xstrdup(cfg->name);
4774 shash_init(&m->src_ports);
4775 shash_init(&m->dst_ports);
4781 mirror_reconfigure_one(m, cfg);
4785 mirror_destroy(struct mirror *m)
4788 struct bridge *br = m->bridge;
4791 for (i = 0; i < br->n_ports; i++) {
4792 br->ports[i]->src_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
4793 br->ports[i]->dst_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
4796 shash_destroy(&m->src_ports);
4797 shash_destroy(&m->dst_ports);
4800 m->bridge->mirrors[m->idx] = NULL;
4809 mirror_collect_ports(struct mirror *m, struct ovsrec_port **ports, int n_ports,
4810 struct shash *names)
4814 for (i = 0; i < n_ports; i++) {
4815 const char *name = ports[i]->name;
4816 if (port_lookup(m->bridge, name)) {
4817 shash_add_once(names, name, NULL);
4819 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
4820 "port %s", m->bridge->name, m->name, name);
4826 mirror_collect_vlans(struct mirror *m, const struct ovsrec_mirror *cfg,
4832 *vlans = xmalloc(sizeof **vlans * cfg->n_select_vlan);
4834 for (i = 0; i < cfg->n_select_vlan; i++) {
4835 int64_t vlan = cfg->select_vlan[i];
4836 if (vlan < 0 || vlan > 4095) {
4837 VLOG_WARN("bridge %s: mirror %s selects invalid VLAN %"PRId64,
4838 m->bridge->name, m->name, vlan);
4840 (*vlans)[n_vlans++] = vlan;
4847 vlan_is_mirrored(const struct mirror *m, int vlan)
4851 for (i = 0; i < m->n_vlans; i++) {
4852 if (m->vlans[i] == vlan) {
4860 port_trunks_any_mirrored_vlan(const struct mirror *m, const struct port *p)
4864 for (i = 0; i < m->n_vlans; i++) {
4865 if (port_trunks_vlan(p, m->vlans[i])) {
4873 mirror_reconfigure_one(struct mirror *m, struct ovsrec_mirror *cfg)
4875 struct shash src_ports, dst_ports;
4876 mirror_mask_t mirror_bit;
4877 struct port *out_port;
4884 if (strcmp(cfg->name, m->name)) {
4886 m->name = xstrdup(cfg->name);
4889 /* Get output port. */
4890 if (cfg->output_port) {
4891 out_port = port_lookup(m->bridge, cfg->output_port->name);
4893 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
4894 m->bridge->name, m->name);
4900 if (cfg->output_vlan) {
4901 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
4902 "output vlan; ignoring output vlan",
4903 m->bridge->name, m->name);
4905 } else if (cfg->output_vlan) {
4907 out_vlan = *cfg->output_vlan;
4909 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
4910 m->bridge->name, m->name);
4915 shash_init(&src_ports);
4916 shash_init(&dst_ports);
4917 if (cfg->select_all) {
4918 for (i = 0; i < m->bridge->n_ports; i++) {
4919 const char *name = m->bridge->ports[i]->name;
4920 shash_add_once(&src_ports, name, NULL);
4921 shash_add_once(&dst_ports, name, NULL);
4926 /* Get ports, and drop duplicates and ports that don't exist. */
4927 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
4929 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
4932 /* Get all the vlans, and drop duplicate and invalid vlans. */
4933 n_vlans = mirror_collect_vlans(m, cfg, &vlans);
4936 /* Update mirror data. */
4937 if (!shash_equal_keys(&m->src_ports, &src_ports)
4938 || !shash_equal_keys(&m->dst_ports, &dst_ports)
4939 || m->n_vlans != n_vlans
4940 || memcmp(m->vlans, vlans, sizeof *vlans * n_vlans)
4941 || m->out_port != out_port
4942 || m->out_vlan != out_vlan) {
4943 bridge_flush(m->bridge);
4945 shash_swap(&m->src_ports, &src_ports);
4946 shash_swap(&m->dst_ports, &dst_ports);
4949 m->n_vlans = n_vlans;
4950 m->out_port = out_port;
4951 m->out_vlan = out_vlan;
4954 mirror_bit = MIRROR_MASK_C(1) << m->idx;
4955 for (i = 0; i < m->bridge->n_ports; i++) {
4956 struct port *port = m->bridge->ports[i];
4958 if (shash_find(&m->src_ports, port->name)
4961 ? port_trunks_any_mirrored_vlan(m, port)
4962 : vlan_is_mirrored(m, port->vlan)))) {
4963 port->src_mirrors |= mirror_bit;
4965 port->src_mirrors &= ~mirror_bit;
4968 if (shash_find(&m->dst_ports, port->name)) {
4969 port->dst_mirrors |= mirror_bit;
4971 port->dst_mirrors &= ~mirror_bit;
4976 shash_destroy(&src_ports);
4977 shash_destroy(&dst_ports);