1 /* Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
28 #include "dynamic-string.h"
35 #include "ofp-print.h"
37 #include "ofproto/ofproto.h"
38 #include "poll-loop.h"
41 #include "socket-util.h"
42 #include "stream-ssl.h"
44 #include "system-stats.h"
48 #include "vswitchd/vswitch-idl.h"
49 #include "xenserver.h"
51 #include "sflow_api.h"
52 #include "vlan-bitmap.h"
54 VLOG_DEFINE_THIS_MODULE(bridge);
56 COVERAGE_DEFINE(bridge_reconfigure);
59 /* These members are always valid. */
60 struct list port_elem; /* Element in struct port's "ifaces" list. */
61 struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
62 struct port *port; /* Containing port. */
63 char *name; /* Host network device name. */
64 tag_type tag; /* Tag associated with this interface. */
66 /* These members are valid only after bridge_reconfigure() causes them to
68 struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
69 int ofp_port; /* OpenFlow port number, -1 if unknown. */
70 struct netdev *netdev; /* Network device. */
71 const char *type; /* Usually same as cfg->type. */
72 const struct ovsrec_interface *cfg;
76 struct uuid uuid; /* UUID of this "mirror" record in database. */
77 struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
78 struct bridge *bridge;
83 struct bridge *bridge;
84 struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
87 const struct ovsrec_port *cfg;
89 /* An ordinary bridge port has 1 interface.
90 * A bridge port for bonding has at least 2 interfaces. */
91 struct list ifaces; /* List of "struct iface"s. */
95 struct hmap_node node; /* In 'all_bridges'. */
96 char *name; /* User-specified arbitrary name. */
97 char *type; /* Datapath type. */
98 uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
99 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
100 const struct ovsrec_bridge *cfg;
102 /* OpenFlow switch processing. */
103 struct ofproto *ofproto; /* OpenFlow switch. */
106 struct hmap ports; /* "struct port"s indexed by name. */
107 struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
108 struct hmap iface_by_name; /* "struct iface"s indexed by name. */
110 /* Port mirroring. */
111 struct hmap mirrors; /* "struct mirror" indexed by UUID. */
113 /* Synthetic local port if necessary. */
114 struct ovsrec_port synth_local_port;
115 struct ovsrec_interface synth_local_iface;
116 struct ovsrec_interface *synth_local_ifacep;
119 /* All bridges, indexed by name. */
120 static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
122 /* OVSDB IDL used to obtain configuration. */
123 static struct ovsdb_idl *idl;
125 /* Each time this timer expires, the bridge fetches systems and interface
126 * statistics and pushes them into the database. */
127 #define STATS_INTERVAL (5 * 1000) /* In milliseconds. */
128 static long long int stats_timer = LLONG_MIN;
130 /* Stores the time after which rate limited statistics may be written to the
131 * database. Only updated when changes to the database require rate limiting.
133 #define DB_LIMIT_INTERVAL (1 * 1000) /* In milliseconds. */
134 static long long int db_limiter = LLONG_MIN;
136 static void add_del_bridges(const struct ovsrec_open_vswitch *);
137 static void bridge_del_ofprotos(void);
138 static bool bridge_add_ofprotos(struct bridge *);
139 static void bridge_create(const struct ovsrec_bridge *);
140 static void bridge_destroy(struct bridge *);
141 static struct bridge *bridge_lookup(const char *name);
142 static unixctl_cb_func bridge_unixctl_dump_flows;
143 static unixctl_cb_func bridge_unixctl_reconnect;
144 static size_t bridge_get_controllers(const struct bridge *br,
145 struct ovsrec_controller ***controllersp);
146 static void bridge_add_del_ports(struct bridge *);
147 static void bridge_add_ofproto_ports(struct bridge *);
148 static void bridge_del_ofproto_ports(struct bridge *);
149 static void bridge_refresh_ofp_port(struct bridge *);
150 static void bridge_configure_datapath_id(struct bridge *);
151 static void bridge_configure_flow_eviction_threshold(struct bridge *);
152 static void bridge_configure_netflow(struct bridge *);
153 static void bridge_configure_forward_bpdu(struct bridge *);
154 static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
155 static void bridge_configure_stp(struct bridge *);
156 static void bridge_configure_remotes(struct bridge *,
157 const struct sockaddr_in *managers,
159 static void bridge_pick_local_hw_addr(struct bridge *,
160 uint8_t ea[ETH_ADDR_LEN],
161 struct iface **hw_addr_iface);
162 static uint64_t bridge_pick_datapath_id(struct bridge *,
163 const uint8_t bridge_ea[ETH_ADDR_LEN],
164 struct iface *hw_addr_iface);
165 static const char *bridge_get_other_config(const struct ovsrec_bridge *,
167 static const char *get_port_other_config(const struct ovsrec_port *,
169 const char *default_value);
170 static uint64_t dpid_from_hash(const void *, size_t nbytes);
171 static bool bridge_has_bond_fake_iface(const struct bridge *,
173 static bool port_is_bond_fake_iface(const struct port *);
175 static unixctl_cb_func qos_unixctl_show;
177 static struct port *port_create(struct bridge *, const struct ovsrec_port *);
178 static void port_add_ifaces(struct port *);
179 static void port_del_ifaces(struct port *);
180 static void port_destroy(struct port *);
181 static struct port *port_lookup(const struct bridge *, const char *name);
182 static void port_configure(struct port *);
183 static struct lacp_settings *port_configure_lacp(struct port *,
184 struct lacp_settings *);
185 static void port_configure_bond(struct port *, struct bond_settings *,
186 uint32_t *bond_stable_ids);
188 static void bridge_configure_mirrors(struct bridge *);
189 static struct mirror *mirror_create(struct bridge *,
190 const struct ovsrec_mirror *);
191 static void mirror_destroy(struct mirror *);
192 static bool mirror_configure(struct mirror *, const struct ovsrec_mirror *);
194 static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
195 static struct iface *iface_create(struct port *port,
196 const struct ovsrec_interface *if_cfg);
197 static void iface_destroy(struct iface *);
198 static struct iface *iface_lookup(const struct bridge *, const char *name);
199 static struct iface *iface_find(const char *name);
200 static struct iface *iface_from_ofp_port(const struct bridge *,
202 static void iface_set_mac(struct iface *);
203 static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
204 static void iface_clear_db_record(const struct ovsrec_interface *if_cfg);
205 static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
206 static void iface_configure_cfm(struct iface *);
207 static void iface_refresh_cfm_stats(struct iface *);
208 static void iface_refresh_stats(struct iface *);
209 static void iface_refresh_status(struct iface *);
210 static bool iface_is_synthetic(const struct iface *);
212 static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
214 static void shash_to_ovs_idl_map(struct shash *,
215 char ***keys, char ***values, size_t *n);
217 /* Public functions. */
219 /* Initializes the bridge module, configuring it to obtain its configuration
220 * from an OVSDB server accessed over 'remote', which should be a string in a
221 * form acceptable to ovsdb_idl_create(). */
223 bridge_init(const char *remote)
225 /* Create connection to database. */
226 idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
227 ovsdb_idl_set_lock(idl, "ovs_vswitchd");
229 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
230 ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
231 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
232 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
233 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
234 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
235 ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
237 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
238 ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
239 ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
241 ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
242 ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
243 ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
245 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
246 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
247 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
248 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
249 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
250 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
251 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
252 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
253 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
254 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
255 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
256 ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
257 ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
259 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
260 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
261 ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
262 ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
264 ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
266 ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
268 ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
270 ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
272 ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
274 ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
275 ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
276 ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
277 ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
278 ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
280 ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
282 /* Register unixctl commands. */
283 unixctl_command_register("qos/show", "interface", qos_unixctl_show, NULL);
284 unixctl_command_register("bridge/dump-flows", "bridge",
285 bridge_unixctl_dump_flows, NULL);
286 unixctl_command_register("bridge/reconnect", "[bridge]",
287 bridge_unixctl_reconnect, NULL);
296 struct bridge *br, *next_br;
298 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
301 ovsdb_idl_destroy(idl);
304 /* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
305 * addresses and ports into '*managersp' and '*n_managersp'. The caller is
306 * responsible for freeing '*managersp' (with free()).
308 * You may be asking yourself "why does ovs-vswitchd care?", because
309 * ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
310 * should not be and in fact is not directly involved in that. But
311 * ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
312 * it has to tell in-band control where the managers are to enable that.
313 * (Thus, only managers connected in-band are collected.)
316 collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
317 struct sockaddr_in **managersp, size_t *n_managersp)
319 struct sockaddr_in *managers = NULL;
320 size_t n_managers = 0;
324 /* Collect all of the potential targets from the "targets" columns of the
325 * rows pointed to by "manager_options", excluding any that are
328 for (i = 0; i < ovs_cfg->n_manager_options; i++) {
329 struct ovsrec_manager *m = ovs_cfg->manager_options[i];
331 if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
332 sset_find_and_delete(&targets, m->target);
334 sset_add(&targets, m->target);
338 /* Now extract the targets' IP addresses. */
339 if (!sset_is_empty(&targets)) {
342 managers = xmalloc(sset_count(&targets) * sizeof *managers);
343 SSET_FOR_EACH (target, &targets) {
344 struct sockaddr_in *sin = &managers[n_managers];
346 if ((!strncmp(target, "tcp:", 4)
347 && inet_parse_active(target + 4, JSONRPC_TCP_PORT, sin)) ||
348 (!strncmp(target, "ssl:", 4)
349 && inet_parse_active(target + 4, JSONRPC_SSL_PORT, sin))) {
354 sset_destroy(&targets);
356 *managersp = managers;
357 *n_managersp = n_managers;
361 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
363 struct sockaddr_in *managers;
364 struct bridge *br, *next;
365 int sflow_bridge_number;
368 COVERAGE_INC(bridge_reconfigure);
370 /* Create and destroy "struct bridge"s, "struct port"s, and "struct
371 * iface"s according to 'ovs_cfg', with only very minimal configuration
374 * This is purely an update to bridge data structures. Nothing is pushed
375 * down to ofproto or lower layers. */
376 add_del_bridges(ovs_cfg);
377 HMAP_FOR_EACH (br, node, &all_bridges) {
378 bridge_add_del_ports(br);
381 /* Delete all datapaths and datapath ports that are no longer configured.
383 * The kernel will reject any attempt to add a given port to a datapath if
384 * that port already belongs to a different datapath, so we must do all
385 * port deletions before any port additions. A datapath always has a
386 * "local port" so we must delete not-configured datapaths too. */
387 bridge_del_ofprotos();
388 HMAP_FOR_EACH (br, node, &all_bridges) {
390 bridge_del_ofproto_ports(br);
394 /* Create datapaths and datapath ports that are missing.
396 * After this is done, we have our final set of bridges, ports, and
397 * interfaces. Every "struct bridge" has an ofproto, every "struct port"
398 * has at least one iface, every "struct iface" has a valid ofp_port and
400 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
401 if (!br->ofproto && !bridge_add_ofprotos(br)) {
405 HMAP_FOR_EACH (br, node, &all_bridges) {
406 bridge_refresh_ofp_port(br);
407 bridge_add_ofproto_ports(br);
410 /* Complete the configuration. */
411 sflow_bridge_number = 0;
412 collect_in_band_managers(ovs_cfg, &managers, &n_managers);
413 HMAP_FOR_EACH (br, node, &all_bridges) {
416 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
419 port_configure(port);
421 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
422 iface_configure_cfm(iface);
423 iface_configure_qos(iface, port->cfg->qos);
424 iface_set_mac(iface);
427 bridge_configure_mirrors(br);
428 bridge_configure_datapath_id(br);
429 bridge_configure_flow_eviction_threshold(br);
430 bridge_configure_forward_bpdu(br);
431 bridge_configure_remotes(br, managers, n_managers);
432 bridge_configure_netflow(br);
433 bridge_configure_sflow(br, &sflow_bridge_number);
434 bridge_configure_stp(br);
438 /* ovs-vswitchd has completed initialization, so allow the process that
439 * forked us to exit successfully. */
440 daemonize_complete();
443 /* Iterate over all ofprotos and delete any of them that do not have a
444 * configured bridge or that are the wrong type. */
446 bridge_del_ofprotos(void)
454 ofproto_enumerate_types(&types);
455 SSET_FOR_EACH (type, &types) {
458 ofproto_enumerate_names(type, &names);
459 SSET_FOR_EACH (name, &names) {
460 struct bridge *br = bridge_lookup(name);
461 if (!br || strcmp(type, br->type)) {
462 ofproto_delete(name, type);
466 sset_destroy(&names);
467 sset_destroy(&types);
471 bridge_add_ofprotos(struct bridge *br)
473 int error = ofproto_create(br->name, br->type, &br->ofproto);
475 VLOG_ERR("failed to create bridge %s: %s", br->name, strerror(error));
482 port_configure(struct port *port)
484 const struct ovsrec_port *cfg = port->cfg;
485 struct bond_settings bond_settings;
486 struct lacp_settings lacp_settings;
487 struct ofproto_bundle_settings s;
495 s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves);
496 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
497 s.slaves[s.n_slaves++] = iface->ofp_port;
503 if (list_is_short(&port->ifaces)) {
504 if (*cfg->tag >= 0 && *cfg->tag <= 4095) {
508 /* It's possible that bonded, VLAN-tagged ports make sense. Maybe
509 * they even work as-is. But they have not been tested. */
510 VLOG_WARN("port %s: VLAN tags not supported on bonded ports",
515 /* Get VLAN trunks. */
518 s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
522 if (cfg->vlan_mode) {
523 if (!strcmp(cfg->vlan_mode, "access")) {
524 s.vlan_mode = PORT_VLAN_ACCESS;
525 } else if (!strcmp(cfg->vlan_mode, "trunk")) {
526 s.vlan_mode = PORT_VLAN_TRUNK;
527 } else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
528 s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
529 } else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
530 s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
532 /* This "can't happen" because ovsdb-server should prevent it. */
533 VLOG_ERR("unknown VLAN mode %s", cfg->vlan_mode);
534 s.vlan_mode = PORT_VLAN_TRUNK;
538 s.vlan_mode = PORT_VLAN_ACCESS;
540 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
544 s.vlan_mode = PORT_VLAN_TRUNK;
548 /* Get LACP settings. */
549 s.lacp = port_configure_lacp(port, &lacp_settings);
553 s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
554 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
555 iface_configure_lacp(iface, &s.lacp_slaves[i++]);
558 s.lacp_slaves = NULL;
561 /* Get bond settings. */
562 if (s.n_slaves > 1) {
563 s.bond = &bond_settings;
564 s.bond_stable_ids = xmalloc(s.n_slaves * sizeof *s.bond_stable_ids);
565 port_configure_bond(port, &bond_settings, s.bond_stable_ids);
568 s.bond_stable_ids = NULL;
570 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
571 netdev_set_miimon_interval(iface->netdev, 0);
576 ofproto_bundle_register(port->bridge->ofproto, port, &s);
582 free(s.bond_stable_ids);
585 /* Pick local port hardware address and datapath ID for 'br'. */
587 bridge_configure_datapath_id(struct bridge *br)
589 uint8_t ea[ETH_ADDR_LEN];
591 struct iface *local_iface;
592 struct iface *hw_addr_iface;
595 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
596 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
598 int error = netdev_set_etheraddr(local_iface->netdev, ea);
600 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
601 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
602 "Ethernet address: %s",
603 br->name, strerror(error));
606 memcpy(br->ea, ea, ETH_ADDR_LEN);
608 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
609 ofproto_set_datapath_id(br->ofproto, dpid);
611 dpid_string = xasprintf("%016"PRIx64, dpid);
612 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
616 /* Set NetFlow configuration on 'br'. */
618 bridge_configure_netflow(struct bridge *br)
620 struct ovsrec_netflow *cfg = br->cfg->netflow;
621 struct netflow_options opts;
624 ofproto_set_netflow(br->ofproto, NULL);
628 memset(&opts, 0, sizeof opts);
630 /* Get default NetFlow configuration from datapath.
631 * Apply overrides from 'cfg'. */
632 ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
633 if (cfg->engine_type) {
634 opts.engine_type = *cfg->engine_type;
636 if (cfg->engine_id) {
637 opts.engine_id = *cfg->engine_id;
640 /* Configure active timeout interval. */
641 opts.active_timeout = cfg->active_timeout;
642 if (!opts.active_timeout) {
643 opts.active_timeout = -1;
644 } else if (opts.active_timeout < 0) {
645 VLOG_WARN("bridge %s: active timeout interval set to negative "
646 "value, using default instead (%d seconds)", br->name,
647 NF_ACTIVE_TIMEOUT_DEFAULT);
648 opts.active_timeout = -1;
651 /* Add engine ID to interface number to disambiguate bridgs? */
652 opts.add_id_to_iface = cfg->add_id_to_interface;
653 if (opts.add_id_to_iface) {
654 if (opts.engine_id > 0x7f) {
655 VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
656 "another vswitch, choose an engine id less than 128",
659 if (hmap_count(&br->ports) > 508) {
660 VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
661 "another port when more than 508 ports are used",
667 sset_init(&opts.collectors);
668 sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
671 if (ofproto_set_netflow(br->ofproto, &opts)) {
672 VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
674 sset_destroy(&opts.collectors);
677 /* Set sFlow configuration on 'br'. */
679 bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
681 const struct ovsrec_sflow *cfg = br->cfg->sflow;
682 struct ovsrec_controller **controllers;
683 struct ofproto_sflow_options oso;
684 size_t n_controllers;
688 ofproto_set_sflow(br->ofproto, NULL);
692 memset(&oso, 0, sizeof oso);
694 sset_init(&oso.targets);
695 sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
697 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
699 oso.sampling_rate = *cfg->sampling;
702 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
704 oso.polling_interval = *cfg->polling;
707 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
709 oso.header_len = *cfg->header;
712 oso.sub_id = (*sflow_bridge_number)++;
713 oso.agent_device = cfg->agent;
715 oso.control_ip = NULL;
716 n_controllers = bridge_get_controllers(br, &controllers);
717 for (i = 0; i < n_controllers; i++) {
718 if (controllers[i]->local_ip) {
719 oso.control_ip = controllers[i]->local_ip;
723 ofproto_set_sflow(br->ofproto, &oso);
725 sset_destroy(&oso.targets);
729 port_configure_stp(const struct ofproto *ofproto, struct port *port,
730 struct ofproto_port_stp_settings *port_s,
731 int *port_num_counter, unsigned long *port_num_bitmap)
733 const char *config_str;
736 config_str = get_port_other_config(port->cfg, "stp-enable", NULL);
737 if (config_str && !strcmp(config_str, "false")) {
738 port_s->enable = false;
741 port_s->enable = true;
744 /* STP over bonds is not supported. */
745 if (!list_is_singleton(&port->ifaces)) {
746 VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
748 port_s->enable = false;
752 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
754 /* Internal ports shouldn't participate in spanning tree, so
756 if (!strcmp(iface->type, "internal")) {
757 VLOG_DBG("port %s: disable STP on internal ports", port->name);
758 port_s->enable = false;
762 /* STP on mirror output ports is not supported. */
763 if (ofproto_is_mirror_output_bundle(ofproto, port)) {
764 VLOG_DBG("port %s: disable STP on mirror ports", port->name);
765 port_s->enable = false;
769 config_str = get_port_other_config(port->cfg, "stp-port-num", NULL);
771 unsigned long int port_num = strtoul(config_str, NULL, 0);
772 int port_idx = port_num - 1;
774 if (port_num < 1 || port_num > STP_MAX_PORTS) {
775 VLOG_ERR("port %s: invalid stp-port-num", port->name);
776 port_s->enable = false;
780 if (bitmap_is_set(port_num_bitmap, port_idx)) {
781 VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
782 port->name, port_num);
783 port_s->enable = false;
786 bitmap_set1(port_num_bitmap, port_idx);
787 port_s->port_num = port_idx;
789 if (*port_num_counter > STP_MAX_PORTS) {
790 VLOG_ERR("port %s: too many STP ports, disabling", port->name);
791 port_s->enable = false;
795 port_s->port_num = (*port_num_counter)++;
798 config_str = get_port_other_config(port->cfg, "stp-path-cost", NULL);
800 port_s->path_cost = strtoul(config_str, NULL, 10);
804 if (netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL)) {
805 /* Couldn't get speed, so assume 100Mb/s. */
806 port_s->path_cost = 19;
810 mbps = netdev_features_to_bps(current) / 1000000;
811 port_s->path_cost = stp_convert_speed_to_cost(mbps);
815 config_str = get_port_other_config(port->cfg, "stp-port-priority", NULL);
817 port_s->priority = strtoul(config_str, NULL, 0);
819 port_s->priority = STP_DEFAULT_PORT_PRIORITY;
823 /* Set spanning tree configuration on 'br'. */
825 bridge_configure_stp(struct bridge *br)
827 if (!br->cfg->stp_enable) {
828 ofproto_set_stp(br->ofproto, NULL);
830 struct ofproto_stp_settings br_s;
831 const char *config_str;
833 int port_num_counter;
834 unsigned long *port_num_bitmap;
836 config_str = bridge_get_other_config(br->cfg, "stp-system-id");
838 uint8_t ea[ETH_ADDR_LEN];
840 if (eth_addr_from_string(config_str, ea)) {
841 br_s.system_id = eth_addr_to_uint64(ea);
843 br_s.system_id = eth_addr_to_uint64(br->ea);
844 VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
845 "to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
848 br_s.system_id = eth_addr_to_uint64(br->ea);
851 config_str = bridge_get_other_config(br->cfg, "stp-priority");
853 br_s.priority = strtoul(config_str, NULL, 0);
855 br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY;
858 config_str = bridge_get_other_config(br->cfg, "stp-hello-time");
860 br_s.hello_time = strtoul(config_str, NULL, 10) * 1000;
862 br_s.hello_time = STP_DEFAULT_HELLO_TIME;
865 config_str = bridge_get_other_config(br->cfg, "stp-max-age");
867 br_s.max_age = strtoul(config_str, NULL, 10) * 1000;
869 br_s.max_age = STP_DEFAULT_MAX_AGE;
872 config_str = bridge_get_other_config(br->cfg, "stp-forward-delay");
874 br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000;
876 br_s.fwd_delay = STP_DEFAULT_FWD_DELAY;
879 /* Configure STP on the bridge. */
880 if (ofproto_set_stp(br->ofproto, &br_s)) {
881 VLOG_ERR("bridge %s: could not enable STP", br->name);
885 /* Users must either set the port number with the "stp-port-num"
886 * configuration on all ports or none. If manual configuration
887 * is not done, then we allocate them sequentially. */
888 port_num_counter = 0;
889 port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
890 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
891 struct ofproto_port_stp_settings port_s;
894 port_configure_stp(br->ofproto, port, &port_s,
895 &port_num_counter, port_num_bitmap);
897 /* As bonds are not supported, just apply configuration to
899 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
900 if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
902 VLOG_ERR("port %s: could not enable STP", port->name);
908 if (bitmap_scan(port_num_bitmap, 0, STP_MAX_PORTS) != STP_MAX_PORTS
909 && port_num_counter) {
910 VLOG_ERR("bridge %s: must manually configure all STP port "
911 "IDs or none, disabling", br->name);
912 ofproto_set_stp(br->ofproto, NULL);
914 bitmap_free(port_num_bitmap);
919 bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
921 const struct port *port = port_lookup(br, name);
922 return port && port_is_bond_fake_iface(port);
926 port_is_bond_fake_iface(const struct port *port)
928 return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces);
932 add_del_bridges(const struct ovsrec_open_vswitch *cfg)
934 struct bridge *br, *next;
938 /* Collect new bridges' names and types. */
940 for (i = 0; i < cfg->n_bridges; i++) {
941 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
942 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
944 if (strchr(br_cfg->name, '/')) {
945 /* Prevent remote ovsdb-server users from accessing arbitrary
946 * directories, e.g. consider a bridge named "../../../etc/". */
947 VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
949 } else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
950 VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
954 /* Get rid of deleted bridges or those whose types have changed.
955 * Update 'cfg' of bridges that still exist. */
956 HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
957 br->cfg = shash_find_data(&new_br, br->name);
958 if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
959 br->cfg->datapath_type))) {
964 /* Add new bridges. */
965 for (i = 0; i < cfg->n_bridges; i++) {
966 const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
967 struct bridge *br = bridge_lookup(br_cfg->name);
969 bridge_create(br_cfg);
973 shash_destroy(&new_br);
976 /* Delete each ofproto port on 'br' that doesn't have a corresponding "struct
979 * The kernel will reject any attempt to add a given port to a datapath if that
980 * port already belongs to a different datapath, so we must do all port
981 * deletions before any port additions. */
983 bridge_del_ofproto_ports(struct bridge *br)
985 struct ofproto_port_dump dump;
986 struct ofproto_port ofproto_port;
988 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
989 const char *name = ofproto_port.name;
994 /* Ignore the local port. We can't change it anyhow. */
995 if (!strcmp(name, br->name)) {
999 /* Get the type that 'ofproto_port' should have (ordinarily the
1000 * type of its corresponding iface) or NULL if it should be
1002 iface = iface_lookup(br, name);
1003 type = (iface ? iface->type
1004 : bridge_has_bond_fake_iface(br, name) ? "internal"
1007 /* If it's the wrong type then delete the ofproto port. */
1009 && !strcmp(ofproto_port.type, type)
1010 && (!iface || !iface->netdev
1011 || !strcmp(netdev_get_type(iface->netdev), type))) {
1014 error = ofproto_port_del(br->ofproto, ofproto_port.ofp_port);
1016 VLOG_WARN("bridge %s: failed to remove %s interface (%s)",
1017 br->name, name, strerror(error));
1020 netdev_close(iface->netdev);
1021 iface->netdev = NULL;
1027 iface_set_ofp_port(struct iface *iface, int ofp_port)
1029 struct bridge *br = iface->port->bridge;
1031 assert(iface->ofp_port < 0 && ofp_port >= 0);
1032 iface->ofp_port = ofp_port;
1033 hmap_insert(&br->ifaces, &iface->ofp_port_node, hash_int(ofp_port, 0));
1034 iface_set_ofport(iface->cfg, ofp_port);
1038 bridge_refresh_ofp_port(struct bridge *br)
1040 struct ofproto_port_dump dump;
1041 struct ofproto_port ofproto_port;
1044 /* Clear all the "ofp_port"es. */
1045 hmap_clear(&br->ifaces);
1046 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1047 struct iface *iface;
1049 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1050 iface->ofp_port = -1;
1054 /* Obtain the correct "ofp_port"s from ofproto. */
1055 OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
1056 struct iface *iface = iface_lookup(br, ofproto_port.name);
1058 if (iface->ofp_port >= 0) {
1059 VLOG_WARN("bridge %s: interface %s reported twice",
1060 br->name, ofproto_port.name);
1061 } else if (iface_from_ofp_port(br, ofproto_port.ofp_port)) {
1062 VLOG_WARN("bridge %s: interface %"PRIu16" reported twice",
1063 br->name, ofproto_port.ofp_port);
1065 iface_set_ofp_port(iface, ofproto_port.ofp_port);
1071 /* Add an ofproto port for any "struct iface" that doesn't have one.
1072 * Delete any "struct iface" for which this fails.
1073 * Delete any "struct port" that thereby ends up with no ifaces. */
1075 bridge_add_ofproto_ports(struct bridge *br)
1077 struct port *port, *next_port;
1079 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
1080 struct iface *iface, *next_iface;
1081 struct ofproto_port ofproto_port;
1083 LIST_FOR_EACH_SAFE (iface, next_iface, port_elem, &port->ifaces) {
1086 /* Open the netdev. */
1087 if (!iface->netdev) {
1088 error = netdev_open(iface->name, iface->type, &iface->netdev);
1090 VLOG_WARN("could not open network device %s (%s)",
1091 iface->name, strerror(error));
1097 /* Configure the netdev. */
1098 if (iface->netdev) {
1102 shash_from_ovs_idl_map(iface->cfg->key_options,
1103 iface->cfg->value_options,
1104 iface->cfg->n_options, &args);
1105 error = netdev_set_config(iface->netdev, &args);
1106 shash_destroy(&args);
1109 VLOG_WARN("could not configure network device %s (%s)",
1110 iface->name, strerror(error));
1111 netdev_close(iface->netdev);
1112 iface->netdev = NULL;
1116 /* Add the port, if necessary. */
1117 if (iface->netdev && iface->ofp_port < 0) {
1121 error = ofproto_port_add(br->ofproto, iface->netdev,
1124 iface_set_ofp_port(iface, ofp_port);
1126 netdev_close(iface->netdev);
1127 iface->netdev = NULL;
1131 /* Populate stats columns in new Interface rows. */
1132 if (iface->netdev && !iface->cfg->mtu) {
1133 iface_refresh_stats(iface);
1134 iface_refresh_status(iface);
1137 /* Delete the iface if we failed. */
1138 if (iface->netdev && iface->ofp_port >= 0) {
1139 VLOG_DBG("bridge %s: interface %s is on port %d",
1140 br->name, iface->name, iface->ofp_port);
1142 if (iface->netdev) {
1143 VLOG_ERR("bridge %s: missing %s interface, dropping",
1144 br->name, iface->name);
1146 /* We already reported a related error, don't bother
1147 * duplicating it. */
1149 iface_clear_db_record(iface->cfg);
1150 iface_destroy(iface);
1153 if (list_is_empty(&port->ifaces)) {
1154 VLOG_WARN("%s port has no interfaces, dropping", port->name);
1159 /* Add bond fake iface if necessary. */
1160 if (port_is_bond_fake_iface(port)) {
1161 if (ofproto_port_query_by_name(br->ofproto, port->name,
1163 struct netdev *netdev;
1166 error = netdev_open(port->name, "internal", &netdev);
1168 ofproto_port_add(br->ofproto, netdev, NULL);
1169 netdev_close(netdev);
1171 VLOG_WARN("could not open network device %s (%s)",
1172 port->name, strerror(error));
1175 /* Already exists, nothing to do. */
1176 ofproto_port_destroy(&ofproto_port);
1183 get_ovsrec_key_value(const struct ovsdb_idl_row *row,
1184 const struct ovsdb_idl_column *column,
1187 const struct ovsdb_datum *datum;
1188 union ovsdb_atom atom;
1191 datum = ovsdb_idl_get(row, column, OVSDB_TYPE_STRING, OVSDB_TYPE_STRING);
1192 atom.string = (char *) key;
1193 idx = ovsdb_datum_find_key(datum, &atom, OVSDB_TYPE_STRING);
1194 return idx == UINT_MAX ? NULL : datum->values[idx].string;
1198 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
1200 return get_ovsrec_key_value(&br_cfg->header_,
1201 &ovsrec_bridge_col_other_config, key);
1204 /* Set Flow eviction threshold */
1206 bridge_configure_flow_eviction_threshold(struct bridge *br)
1208 const char *threshold_str;
1211 threshold_str = bridge_get_other_config(br->cfg, "flow-eviction-threshold");
1212 if (threshold_str) {
1213 threshold = strtoul(threshold_str, NULL, 10);
1215 threshold = OFPROTO_FLOW_EVICTON_THRESHOLD_DEFAULT;
1217 ofproto_set_flow_eviction_threshold(br->ofproto, threshold);
1220 /* Set forward BPDU option. */
1222 bridge_configure_forward_bpdu(struct bridge *br)
1224 const char *forward_bpdu_str;
1225 bool forward_bpdu = false;
1227 forward_bpdu_str = bridge_get_other_config(br->cfg, "forward-bpdu");
1228 if (forward_bpdu_str && !strcmp(forward_bpdu_str, "true")) {
1229 forward_bpdu = true;
1231 ofproto_set_forward_bpdu(br->ofproto, forward_bpdu);
1235 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
1236 struct iface **hw_addr_iface)
1240 bool found_addr = false;
1243 *hw_addr_iface = NULL;
1245 /* Did the user request a particular MAC? */
1246 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
1247 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
1248 if (eth_addr_is_multicast(ea)) {
1249 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
1250 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1251 } else if (eth_addr_is_zero(ea)) {
1252 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
1258 /* Otherwise choose the minimum non-local MAC address among all of the
1260 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1261 uint8_t iface_ea[ETH_ADDR_LEN];
1262 struct iface *candidate;
1263 struct iface *iface;
1265 /* Mirror output ports don't participate. */
1266 if (ofproto_is_mirror_output_bundle(br->ofproto, port)) {
1270 /* Choose the MAC address to represent the port. */
1272 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
1273 /* Find the interface with this Ethernet address (if any) so that
1274 * we can provide the correct devname to the caller. */
1275 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1276 uint8_t candidate_ea[ETH_ADDR_LEN];
1277 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
1278 && eth_addr_equals(iface_ea, candidate_ea)) {
1283 /* Choose the interface whose MAC address will represent the port.
1284 * The Linux kernel bonding code always chooses the MAC address of
1285 * the first slave added to a bond, and the Fedora networking
1286 * scripts always add slaves to a bond in alphabetical order, so
1287 * for compatibility we choose the interface with the name that is
1288 * first in alphabetical order. */
1289 LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
1290 if (!iface || strcmp(candidate->name, iface->name) < 0) {
1295 /* The local port doesn't count (since we're trying to choose its
1296 * MAC address anyway). */
1297 if (iface->ofp_port == OFPP_LOCAL) {
1302 error = netdev_get_etheraddr(iface->netdev, iface_ea);
1308 /* Compare against our current choice. */
1309 if (!eth_addr_is_multicast(iface_ea) &&
1310 !eth_addr_is_local(iface_ea) &&
1311 !eth_addr_is_reserved(iface_ea) &&
1312 !eth_addr_is_zero(iface_ea) &&
1313 (!found_addr || eth_addr_compare_3way(iface_ea, ea) < 0))
1315 memcpy(ea, iface_ea, ETH_ADDR_LEN);
1316 *hw_addr_iface = iface;
1321 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
1322 br->name, ETH_ADDR_ARGS(ea));
1324 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
1325 *hw_addr_iface = NULL;
1326 VLOG_WARN("bridge %s: using default bridge Ethernet "
1327 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
1331 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
1332 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
1333 * an interface on 'br', then that interface must be passed in as
1334 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
1335 * 'hw_addr_iface' must be passed in as a null pointer. */
1337 bridge_pick_datapath_id(struct bridge *br,
1338 const uint8_t bridge_ea[ETH_ADDR_LEN],
1339 struct iface *hw_addr_iface)
1342 * The procedure for choosing a bridge MAC address will, in the most
1343 * ordinary case, also choose a unique MAC that we can use as a datapath
1344 * ID. In some special cases, though, multiple bridges will end up with
1345 * the same MAC address. This is OK for the bridges, but it will confuse
1346 * the OpenFlow controller, because each datapath needs a unique datapath
1349 * Datapath IDs must be unique. It is also very desirable that they be
1350 * stable from one run to the next, so that policy set on a datapath
1353 const char *datapath_id;
1356 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
1357 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
1361 if (hw_addr_iface) {
1363 if (!netdev_get_vlan_vid(hw_addr_iface->netdev, &vlan)) {
1365 * A bridge whose MAC address is taken from a VLAN network device
1366 * (that is, a network device created with vconfig(8) or similar
1367 * tool) will have the same MAC address as a bridge on the VLAN
1368 * device's physical network device.
1370 * Handle this case by hashing the physical network device MAC
1371 * along with the VLAN identifier.
1373 uint8_t buf[ETH_ADDR_LEN + 2];
1374 memcpy(buf, bridge_ea, ETH_ADDR_LEN);
1375 buf[ETH_ADDR_LEN] = vlan >> 8;
1376 buf[ETH_ADDR_LEN + 1] = vlan;
1377 return dpid_from_hash(buf, sizeof buf);
1380 * Assume that this bridge's MAC address is unique, since it
1381 * doesn't fit any of the cases we handle specially.
1386 * A purely internal bridge, that is, one that has no non-virtual
1387 * network devices on it at all, is more difficult because it has no
1388 * natural unique identifier at all.
1390 * When the host is a XenServer, we handle this case by hashing the
1391 * host's UUID with the name of the bridge. Names of bridges are
1392 * persistent across XenServer reboots, although they can be reused if
1393 * an internal network is destroyed and then a new one is later
1394 * created, so this is fairly effective.
1396 * When the host is not a XenServer, we punt by using a random MAC
1397 * address on each run.
1399 const char *host_uuid = xenserver_get_host_uuid();
1401 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1402 dpid = dpid_from_hash(combined, strlen(combined));
1408 return eth_addr_to_uint64(bridge_ea);
1412 dpid_from_hash(const void *data, size_t n)
1414 uint8_t hash[SHA1_DIGEST_SIZE];
1416 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1417 sha1_bytes(data, n, hash);
1418 eth_addr_mark_random(hash);
1419 return eth_addr_to_uint64(hash);
1423 iface_refresh_status(struct iface *iface)
1427 enum netdev_flags flags;
1434 if (iface_is_synthetic(iface)) {
1440 if (!netdev_get_status(iface->netdev, &sh)) {
1442 char **keys, **values;
1444 shash_to_ovs_idl_map(&sh, &keys, &values, &n);
1445 ovsrec_interface_set_status(iface->cfg, keys, values, n);
1450 ovsrec_interface_set_status(iface->cfg, NULL, NULL, 0);
1453 shash_destroy_free_data(&sh);
1455 error = netdev_get_flags(iface->netdev, &flags);
1457 ovsrec_interface_set_admin_state(iface->cfg, flags & NETDEV_UP ? "up" : "down");
1460 ovsrec_interface_set_admin_state(iface->cfg, NULL);
1463 error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
1465 ovsrec_interface_set_duplex(iface->cfg,
1466 netdev_features_is_full_duplex(current)
1468 /* warning: uint64_t -> int64_t conversion */
1469 bps = netdev_features_to_bps(current);
1470 ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
1473 ovsrec_interface_set_duplex(iface->cfg, NULL);
1474 ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
1477 error = netdev_get_mtu(iface->netdev, &mtu);
1480 ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
1483 ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
1487 /* Writes 'iface''s CFM statistics to the database. */
1489 iface_refresh_cfm_stats(struct iface *iface)
1491 const struct ovsrec_interface *cfg = iface->cfg;
1493 const uint64_t *rmps;
1496 if (iface_is_synthetic(iface)) {
1500 fault = ofproto_port_get_cfm_fault(iface->port->bridge->ofproto,
1503 bool fault_bool = fault;
1504 ovsrec_interface_set_cfm_fault(cfg, &fault_bool, 1);
1506 ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
1509 error = ofproto_port_get_cfm_remote_mpids(iface->port->bridge->ofproto,
1510 iface->ofp_port, &rmps, &n_rmps);
1512 ovsrec_interface_set_cfm_remote_mpids(cfg, (const int64_t *)rmps,
1515 ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
1520 iface_refresh_stats(struct iface *iface)
1522 #define IFACE_STATS \
1523 IFACE_STAT(rx_packets, "rx_packets") \
1524 IFACE_STAT(tx_packets, "tx_packets") \
1525 IFACE_STAT(rx_bytes, "rx_bytes") \
1526 IFACE_STAT(tx_bytes, "tx_bytes") \
1527 IFACE_STAT(rx_dropped, "rx_dropped") \
1528 IFACE_STAT(tx_dropped, "tx_dropped") \
1529 IFACE_STAT(rx_errors, "rx_errors") \
1530 IFACE_STAT(tx_errors, "tx_errors") \
1531 IFACE_STAT(rx_frame_errors, "rx_frame_err") \
1532 IFACE_STAT(rx_over_errors, "rx_over_err") \
1533 IFACE_STAT(rx_crc_errors, "rx_crc_err") \
1534 IFACE_STAT(collisions, "collisions")
1536 #define IFACE_STAT(MEMBER, NAME) NAME,
1537 static char *keys[] = { IFACE_STATS };
1539 int64_t values[ARRAY_SIZE(keys)];
1542 struct netdev_stats stats;
1544 if (iface_is_synthetic(iface)) {
1548 /* Intentionally ignore return value, since errors will set 'stats' to
1549 * all-1s, and we will deal with that correctly below. */
1550 netdev_get_stats(iface->netdev, &stats);
1552 /* Copy statistics into values[] array. */
1554 #define IFACE_STAT(MEMBER, NAME) values[i++] = stats.MEMBER;
1557 assert(i == ARRAY_SIZE(keys));
1559 ovsrec_interface_set_statistics(iface->cfg, keys, values, ARRAY_SIZE(keys));
1564 br_refresh_stp_status(struct bridge *br)
1566 struct ofproto *ofproto = br->ofproto;
1567 struct ofproto_stp_status status;
1568 char *keys[3], *values[3];
1571 if (ofproto_get_stp_status(ofproto, &status)) {
1575 if (!status.enabled) {
1576 ovsrec_bridge_set_status(br->cfg, NULL, NULL, 0);
1580 keys[0] = "stp_bridge_id",
1581 values[0] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.bridge_id));
1582 keys[1] = "stp_designated_root",
1583 values[1] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.designated_root));
1584 keys[2] = "stp_root_path_cost",
1585 values[2] = xasprintf("%d", status.root_path_cost);
1587 ovsrec_bridge_set_status(br->cfg, keys, values, ARRAY_SIZE(values));
1589 for (i = 0; i < ARRAY_SIZE(values); i++) {
1595 port_refresh_stp_status(struct port *port)
1597 struct ofproto *ofproto = port->bridge->ofproto;
1598 struct iface *iface;
1599 struct ofproto_port_stp_status status;
1600 char *keys[4], *values[4];
1603 /* STP doesn't currently support bonds. */
1604 if (!list_is_singleton(&port->ifaces)) {
1605 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1609 iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
1611 if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
1615 if (!status.enabled) {
1616 ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
1620 keys[0] = "stp_port_id";
1621 values[0] = xasprintf(STP_PORT_ID_FMT, status.port_id);
1622 keys[1] = "stp_state";
1623 values[1] = xstrdup(stp_state_name(status.state));
1624 keys[2] = "stp_sec_in_state";
1625 values[2] = xasprintf("%u", status.sec_in_state);
1626 keys[3] = "stp_role";
1627 values[3] = xstrdup(stp_role_name(status.role));
1629 ovsrec_port_set_status(port->cfg, keys, values, ARRAY_SIZE(values));
1631 for (i = 0; i < ARRAY_SIZE(values); i++) {
1637 enable_system_stats(const struct ovsrec_open_vswitch *cfg)
1641 /* Use other-config:enable-system-stats by preference. */
1642 enable = get_ovsrec_key_value(&cfg->header_,
1643 &ovsrec_open_vswitch_col_other_config,
1644 "enable-statistics");
1646 return !strcmp(enable, "true");
1649 /* Disable by default. */
1654 refresh_system_stats(const struct ovsrec_open_vswitch *cfg)
1656 struct ovsdb_datum datum;
1660 if (enable_system_stats(cfg)) {
1661 get_system_stats(&stats);
1664 ovsdb_datum_from_shash(&datum, &stats);
1665 ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
1669 static inline const char *
1670 nx_role_to_str(enum nx_role role)
1675 case NX_ROLE_MASTER:
1680 return "*** INVALID ROLE ***";
1685 refresh_controller_status(void)
1689 const struct ovsrec_controller *cfg;
1693 /* Accumulate status for controllers on all bridges. */
1694 HMAP_FOR_EACH (br, node, &all_bridges) {
1695 ofproto_get_ofproto_controller_info(br->ofproto, &info);
1698 /* Update each controller in the database with current status. */
1699 OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
1700 struct ofproto_controller_info *cinfo =
1701 shash_find_data(&info, cfg->target);
1704 ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
1705 ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
1706 ovsrec_controller_set_status(cfg, (char **) cinfo->pairs.keys,
1707 (char **) cinfo->pairs.values,
1710 ovsrec_controller_set_is_connected(cfg, false);
1711 ovsrec_controller_set_role(cfg, NULL);
1712 ovsrec_controller_set_status(cfg, NULL, NULL, 0);
1716 ofproto_free_ofproto_controller_info(&info);
1720 refresh_cfm_stats(void)
1722 static struct ovsdb_idl_txn *txn = NULL;
1727 txn = ovsdb_idl_txn_create(idl);
1729 HMAP_FOR_EACH (br, node, &all_bridges) {
1730 struct iface *iface;
1732 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
1733 iface_refresh_cfm_stats(iface);
1738 if (ovsdb_idl_txn_commit(txn) != TXN_INCOMPLETE) {
1739 ovsdb_idl_txn_destroy(txn);
1747 const struct ovsrec_open_vswitch *cfg;
1749 bool datapath_destroyed;
1750 bool database_changed;
1753 /* (Re)configure if necessary. */
1754 database_changed = ovsdb_idl_run(idl);
1755 if (ovsdb_idl_is_lock_contended(idl)) {
1756 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
1757 struct bridge *br, *next_br;
1759 VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
1760 "disabling this process until it goes away");
1762 HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
1766 } else if (!ovsdb_idl_has_lock(idl)) {
1769 cfg = ovsrec_open_vswitch_first(idl);
1771 /* Let each bridge do the work that it needs to do. */
1772 datapath_destroyed = false;
1773 HMAP_FOR_EACH (br, node, &all_bridges) {
1774 int error = ofproto_run(br->ofproto);
1776 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1777 VLOG_ERR_RL(&rl, "bridge %s: datapath was destroyed externally, "
1778 "forcing reconfiguration", br->name);
1779 datapath_destroyed = true;
1783 /* Re-configure SSL. We do this on every trip through the main loop,
1784 * instead of just when the database changes, because the contents of the
1785 * key and certificate files can change without the database changing.
1787 * We do this before bridge_reconfigure() because that function might
1788 * initiate SSL connections and thus requires SSL to be configured. */
1789 if (cfg && cfg->ssl) {
1790 const struct ovsrec_ssl *ssl = cfg->ssl;
1792 stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
1793 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
1796 if (database_changed || datapath_destroyed) {
1798 struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
1800 bridge_reconfigure(cfg);
1802 ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
1803 ovsdb_idl_txn_commit(txn);
1804 ovsdb_idl_txn_destroy(txn); /* XXX */
1806 /* We still need to reconfigure to avoid dangling pointers to
1807 * now-destroyed ovsrec structures inside bridge data. */
1808 static const struct ovsrec_open_vswitch null_cfg;
1810 bridge_reconfigure(&null_cfg);
1814 /* Refresh system and interface stats if necessary. */
1815 if (time_msec() >= stats_timer) {
1817 struct ovsdb_idl_txn *txn;
1819 txn = ovsdb_idl_txn_create(idl);
1820 HMAP_FOR_EACH (br, node, &all_bridges) {
1823 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1824 struct iface *iface;
1826 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
1827 iface_refresh_stats(iface);
1828 iface_refresh_status(iface);
1832 refresh_system_stats(cfg);
1833 refresh_controller_status();
1834 ovsdb_idl_txn_commit(txn);
1835 ovsdb_idl_txn_destroy(txn); /* XXX */
1838 stats_timer = time_msec() + STATS_INTERVAL;
1841 if (time_msec() >= db_limiter) {
1842 struct ovsdb_idl_txn *txn;
1844 txn = ovsdb_idl_txn_create(idl);
1845 HMAP_FOR_EACH (br, node, &all_bridges) {
1846 struct iface *iface;
1849 br_refresh_stp_status(br);
1851 HMAP_FOR_EACH (port, hmap_node, &br->ports) {
1852 port_refresh_stp_status(port);
1855 HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
1856 const char *link_state;
1857 int64_t link_resets;
1860 if (iface_is_synthetic(iface)) {
1864 current = ofproto_port_is_lacp_current(br->ofproto,
1868 ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
1870 ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
1873 link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
1874 ovsrec_interface_set_link_state(iface->cfg, link_state);
1876 link_resets = netdev_get_carrier_resets(iface->netdev);
1877 ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
1881 if (ovsdb_idl_txn_commit(txn) != TXN_UNCHANGED) {
1882 db_limiter = time_msec() + DB_LIMIT_INTERVAL;
1884 ovsdb_idl_txn_destroy(txn);
1887 refresh_cfm_stats();
1893 ovsdb_idl_wait(idl);
1894 if (!hmap_is_empty(&all_bridges)) {
1897 HMAP_FOR_EACH (br, node, &all_bridges) {
1898 ofproto_wait(br->ofproto);
1900 poll_timer_wait_until(stats_timer);
1902 if (db_limiter > time_msec()) {
1903 poll_timer_wait_until(db_limiter);
1908 /* QoS unixctl user interface functions. */
1910 struct qos_unixctl_show_cbdata {
1912 struct iface *iface;
1916 qos_unixctl_show_cb(unsigned int queue_id,
1917 const struct shash *details,
1920 struct qos_unixctl_show_cbdata *data = aux;
1921 struct ds *ds = data->ds;
1922 struct iface *iface = data->iface;
1923 struct netdev_queue_stats stats;
1924 struct shash_node *node;
1927 ds_put_cstr(ds, "\n");
1929 ds_put_format(ds, "Queue %u:\n", queue_id);
1931 ds_put_cstr(ds, "Default:\n");
1934 SHASH_FOR_EACH (node, details) {
1935 ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
1938 error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
1940 if (stats.tx_packets != UINT64_MAX) {
1941 ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
1944 if (stats.tx_bytes != UINT64_MAX) {
1945 ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
1948 if (stats.tx_errors != UINT64_MAX) {
1949 ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
1952 ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
1953 queue_id, strerror(error));
1958 qos_unixctl_show(struct unixctl_conn *conn,
1959 const char *args, void *aux OVS_UNUSED)
1961 struct ds ds = DS_EMPTY_INITIALIZER;
1962 struct shash sh = SHASH_INITIALIZER(&sh);
1963 struct iface *iface;
1965 struct shash_node *node;
1966 struct qos_unixctl_show_cbdata data;
1969 iface = iface_find(args);
1971 unixctl_command_reply(conn, 501, "no such interface");
1975 netdev_get_qos(iface->netdev, &type, &sh);
1977 if (*type != '\0') {
1978 ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
1980 SHASH_FOR_EACH (node, &sh) {
1981 ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
1986 error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
1989 ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
1991 unixctl_command_reply(conn, 200, ds_cstr(&ds));
1993 ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
1994 unixctl_command_reply(conn, 501, ds_cstr(&ds));
1997 shash_destroy_free_data(&sh);
2001 /* Bridge reconfiguration functions. */
2003 bridge_create(const struct ovsrec_bridge *br_cfg)
2007 assert(!bridge_lookup(br_cfg->name));
2008 br = xzalloc(sizeof *br);
2010 br->name = xstrdup(br_cfg->name);
2011 br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
2014 /* Derive the default Ethernet address from the bridge's UUID. This should
2015 * be unique and it will be stable between ovs-vswitchd runs. */
2016 memcpy(br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
2017 eth_addr_mark_random(br->default_ea);
2019 hmap_init(&br->ports);
2020 hmap_init(&br->ifaces);
2021 hmap_init(&br->iface_by_name);
2022 hmap_init(&br->mirrors);
2024 hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
2028 bridge_destroy(struct bridge *br)
2031 struct mirror *mirror, *next_mirror;
2032 struct port *port, *next_port;
2034 HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
2037 HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
2038 mirror_destroy(mirror);
2040 hmap_remove(&all_bridges, &br->node);
2041 ofproto_destroy(br->ofproto);
2042 hmap_destroy(&br->ifaces);
2043 hmap_destroy(&br->ports);
2044 hmap_destroy(&br->iface_by_name);
2045 hmap_destroy(&br->mirrors);
2052 static struct bridge *
2053 bridge_lookup(const char *name)
2057 HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
2058 if (!strcmp(br->name, name)) {
2065 /* Handle requests for a listing of all flows known by the OpenFlow
2066 * stack, including those normally hidden. */
2068 bridge_unixctl_dump_flows(struct unixctl_conn *conn,
2069 const char *args, void *aux OVS_UNUSED)
2074 br = bridge_lookup(args);
2076 unixctl_command_reply(conn, 501, "Unknown bridge");
2081 ofproto_get_all_flows(br->ofproto, &results);
2083 unixctl_command_reply(conn, 200, ds_cstr(&results));
2084 ds_destroy(&results);
2087 /* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
2088 * connections and reconnect. If BRIDGE is not specified, then all bridges
2089 * drop their controller connections and reconnect. */
2091 bridge_unixctl_reconnect(struct unixctl_conn *conn,
2092 const char *args, void *aux OVS_UNUSED)
2095 if (args[0] != '\0') {
2096 br = bridge_lookup(args);
2098 unixctl_command_reply(conn, 501, "Unknown bridge");
2101 ofproto_reconnect_controllers(br->ofproto);
2103 HMAP_FOR_EACH (br, node, &all_bridges) {
2104 ofproto_reconnect_controllers(br->ofproto);
2107 unixctl_command_reply(conn, 200, NULL);
2111 bridge_get_controllers(const struct bridge *br,
2112 struct ovsrec_controller ***controllersp)
2114 struct ovsrec_controller **controllers;
2115 size_t n_controllers;
2117 controllers = br->cfg->controller;
2118 n_controllers = br->cfg->n_controller;
2120 if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
2126 *controllersp = controllers;
2128 return n_controllers;
2131 /* Adds and deletes "struct port"s and "struct iface"s under 'br' to match
2132 * those configured in 'br->cfg'. */
2134 bridge_add_del_ports(struct bridge *br)
2136 struct port *port, *next;
2137 struct shash_node *node;
2138 struct shash new_ports;
2141 /* Collect new ports. */
2142 shash_init(&new_ports);
2143 for (i = 0; i < br->cfg->n_ports; i++) {
2144 const char *name = br->cfg->ports[i]->name;
2145 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
2146 VLOG_WARN("bridge %s: %s specified twice as bridge port",
2150 if (bridge_get_controllers(br, NULL)
2151 && !shash_find(&new_ports, br->name)) {
2152 VLOG_WARN("bridge %s: no port named %s, synthesizing one",
2153 br->name, br->name);
2155 br->synth_local_port.interfaces = &br->synth_local_ifacep;
2156 br->synth_local_port.n_interfaces = 1;
2157 br->synth_local_port.name = br->name;
2159 br->synth_local_iface.name = br->name;
2160 br->synth_local_iface.type = "internal";
2162 br->synth_local_ifacep = &br->synth_local_iface;
2164 shash_add(&new_ports, br->name, &br->synth_local_port);
2167 /* Get rid of deleted ports.
2168 * Get rid of deleted interfaces on ports that still exist.
2169 * Update 'cfg' of ports that still exist. */
2170 HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
2171 port->cfg = shash_find_data(&new_ports, port->name);
2175 port_del_ifaces(port);
2179 /* Create new ports.
2180 * Add new interfaces to existing ports. */
2181 SHASH_FOR_EACH (node, &new_ports) {
2182 struct port *port = port_lookup(br, node->name);
2184 struct ovsrec_port *cfg = node->data;
2185 port = port_create(br, cfg);
2187 port_add_ifaces(port);
2188 if (list_is_empty(&port->ifaces)) {
2189 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
2190 br->name, port->name);
2194 shash_destroy(&new_ports);
2197 /* Initializes 'oc' appropriately as a management service controller for
2200 * The caller must free oc->target when it is no longer needed. */
2202 bridge_ofproto_controller_for_mgmt(const struct bridge *br,
2203 struct ofproto_controller *oc)
2205 oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
2206 oc->max_backoff = 0;
2207 oc->probe_interval = 60;
2208 oc->band = OFPROTO_OUT_OF_BAND;
2210 oc->burst_limit = 0;
2213 /* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
2215 bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
2216 struct ofproto_controller *oc)
2218 oc->target = c->target;
2219 oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
2220 oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
2221 oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
2222 ? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
2223 oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
2224 oc->burst_limit = (c->controller_burst_limit
2225 ? *c->controller_burst_limit : 0);
2228 /* Configures the IP stack for 'br''s local interface properly according to the
2229 * configuration in 'c'. */
2231 bridge_configure_local_iface_netdev(struct bridge *br,
2232 struct ovsrec_controller *c)
2234 struct netdev *netdev;
2235 struct in_addr mask, gateway;
2237 struct iface *local_iface;
2240 /* If there's no local interface or no IP address, give up. */
2241 local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
2242 if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
2246 /* Bring up the local interface. */
2247 netdev = local_iface->netdev;
2248 netdev_turn_flags_on(netdev, NETDEV_UP, true);
2250 /* Configure the IP address and netmask. */
2251 if (!c->local_netmask
2252 || !inet_aton(c->local_netmask, &mask)
2254 mask.s_addr = guess_netmask(ip.s_addr);
2256 if (!netdev_set_in4(netdev, ip, mask)) {
2257 VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
2258 br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
2261 /* Configure the default gateway. */
2262 if (c->local_gateway
2263 && inet_aton(c->local_gateway, &gateway)
2264 && gateway.s_addr) {
2265 if (!netdev_add_router(netdev, gateway)) {
2266 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
2267 br->name, IP_ARGS(&gateway.s_addr));
2272 /* Returns true if 'a' and 'b' are the same except that any number of slashes
2273 * in either string are treated as equal to any number of slashes in the other,
2274 * e.g. "x///y" is equal to "x/y". */
2276 equal_pathnames(const char *a, const char *b)
2280 a += strspn(a, "/");
2281 b += strspn(b, "/");
2282 } else if (*a == '\0') {
2293 bridge_configure_remotes(struct bridge *br,
2294 const struct sockaddr_in *managers, size_t n_managers)
2296 const char *disable_ib_str, *queue_id_str;
2297 bool disable_in_band = false;
2300 struct ovsrec_controller **controllers;
2301 size_t n_controllers;
2303 enum ofproto_fail_mode fail_mode;
2305 struct ofproto_controller *ocs;
2309 /* Check if we should disable in-band control on this bridge. */
2310 disable_ib_str = bridge_get_other_config(br->cfg, "disable-in-band");
2311 if (disable_ib_str && !strcmp(disable_ib_str, "true")) {
2312 disable_in_band = true;
2315 /* Set OpenFlow queue ID for in-band control. */
2316 queue_id_str = bridge_get_other_config(br->cfg, "in-band-queue");
2317 queue_id = queue_id_str ? strtol(queue_id_str, NULL, 10) : -1;
2318 ofproto_set_in_band_queue(br->ofproto, queue_id);
2320 if (disable_in_band) {
2321 ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
2323 ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
2326 n_controllers = bridge_get_controllers(br, &controllers);
2328 ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
2331 bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
2332 for (i = 0; i < n_controllers; i++) {
2333 struct ovsrec_controller *c = controllers[i];
2335 if (!strncmp(c->target, "punix:", 6)
2336 || !strncmp(c->target, "unix:", 5)) {
2337 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2340 whitelist = xasprintf("unix:%s/%s.controller",
2341 ovs_rundir(), br->name);
2342 if (!equal_pathnames(c->target, whitelist)) {
2343 /* Prevent remote ovsdb-server users from accessing arbitrary
2344 * Unix domain sockets and overwriting arbitrary local
2346 VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
2347 "controller \"%s\" due to possibility for remote "
2348 "exploit. Instead, specify whitelisted \"%s\" or "
2349 "connect to \"unix:%s/%s.mgmt\" (which is always "
2350 "available without special configuration).",
2351 br->name, c->target, whitelist,
2352 ovs_rundir(), br->name);
2360 bridge_configure_local_iface_netdev(br, c);
2361 bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
2362 if (disable_in_band) {
2363 ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
2368 ofproto_set_controllers(br->ofproto, ocs, n_ocs);
2369 free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
2372 /* Set the fail-mode. */
2373 fail_mode = !br->cfg->fail_mode
2374 || !strcmp(br->cfg->fail_mode, "standalone")
2375 ? OFPROTO_FAIL_STANDALONE
2376 : OFPROTO_FAIL_SECURE;
2377 ofproto_set_fail_mode(br->ofproto, fail_mode);
2379 /* Configure OpenFlow controller connection snooping. */
2380 if (!ofproto_has_snoops(br->ofproto)) {
2384 sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
2385 ovs_rundir(), br->name));
2386 ofproto_set_snoops(br->ofproto, &snoops);
2387 sset_destroy(&snoops);
2391 /* Port functions. */
2393 static struct port *
2394 port_create(struct bridge *br, const struct ovsrec_port *cfg)
2398 port = xzalloc(sizeof *port);
2400 port->name = xstrdup(cfg->name);
2402 list_init(&port->ifaces);
2404 hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
2406 VLOG_INFO("created port %s on bridge %s", port->name, br->name);
2412 get_port_other_config(const struct ovsrec_port *port, const char *key,
2413 const char *default_value)
2417 value = get_ovsrec_key_value(&port->header_, &ovsrec_port_col_other_config,
2419 return value ? value : default_value;
2423 get_interface_other_config(const struct ovsrec_interface *iface,
2424 const char *key, const char *default_value)
2428 value = get_ovsrec_key_value(&iface->header_,
2429 &ovsrec_interface_col_other_config, key);
2430 return value ? value : default_value;
2433 /* Deletes interfaces from 'port' that are no longer configured for it. */
2435 port_del_ifaces(struct port *port)
2437 struct iface *iface, *next;
2438 struct sset new_ifaces;
2441 /* Collect list of new interfaces. */
2442 sset_init(&new_ifaces);
2443 for (i = 0; i < port->cfg->n_interfaces; i++) {
2444 const char *name = port->cfg->interfaces[i]->name;
2445 const char *type = port->cfg->interfaces[i]->name;
2446 if (strcmp(type, "null")) {
2447 sset_add(&new_ifaces, name);
2451 /* Get rid of deleted interfaces. */
2452 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2453 if (!sset_contains(&new_ifaces, iface->name)) {
2454 iface_destroy(iface);
2458 sset_destroy(&new_ifaces);
2461 /* Adds new interfaces to 'port' and updates 'type' and 'cfg' members of
2464 port_add_ifaces(struct port *port)
2466 struct shash new_ifaces;
2467 struct shash_node *node;
2470 /* Collect new ifaces. */
2471 shash_init(&new_ifaces);
2472 for (i = 0; i < port->cfg->n_interfaces; i++) {
2473 const struct ovsrec_interface *cfg = port->cfg->interfaces[i];
2474 if (strcmp(cfg->type, "null")
2475 && !shash_add_once(&new_ifaces, cfg->name, cfg)) {
2476 VLOG_WARN("port %s: %s specified twice as port interface",
2477 port->name, cfg->name);
2478 iface_clear_db_record(cfg);
2482 /* Create new interfaces.
2483 * Update interface types and 'cfg' members. */
2484 SHASH_FOR_EACH (node, &new_ifaces) {
2485 const struct ovsrec_interface *cfg = node->data;
2486 const char *iface_name = node->name;
2487 struct iface *iface;
2489 iface = iface_lookup(port->bridge, iface_name);
2491 iface = iface_create(port, cfg);
2496 /* Determine interface type. The local port always has type
2497 * "internal". Other ports take their type from the database and
2498 * default to "system" if none is specified. */
2499 iface->type = (!strcmp(iface_name, port->bridge->name) ? "internal"
2500 : cfg->type[0] ? cfg->type
2503 shash_destroy(&new_ifaces);
2507 port_destroy(struct port *port)
2510 struct bridge *br = port->bridge;
2511 struct iface *iface, *next;
2514 ofproto_bundle_unregister(br->ofproto, port);
2517 LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
2518 iface_destroy(iface);
2521 hmap_remove(&br->ports, &port->hmap_node);
2523 VLOG_INFO("destroyed port %s on bridge %s", port->name, br->name);
2530 static struct port *
2531 port_lookup(const struct bridge *br, const char *name)
2535 HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
2537 if (!strcmp(port->name, name)) {
2545 enable_lacp(struct port *port, bool *activep)
2547 if (!port->cfg->lacp) {
2548 /* XXX when LACP implementation has been sufficiently tested, enable by
2549 * default and make active on bonded ports. */
2551 } else if (!strcmp(port->cfg->lacp, "off")) {
2553 } else if (!strcmp(port->cfg->lacp, "active")) {
2556 } else if (!strcmp(port->cfg->lacp, "passive")) {
2560 VLOG_WARN("port %s: unknown LACP mode %s",
2561 port->name, port->cfg->lacp);
2566 static struct lacp_settings *
2567 port_configure_lacp(struct port *port, struct lacp_settings *s)
2569 const char *lacp_time;
2570 long long int custom_time;
2573 if (!enable_lacp(port, &s->active)) {
2577 s->name = port->name;
2578 memcpy(s->id, port->bridge->ea, ETH_ADDR_LEN);
2580 /* Prefer bondable links if unspecified. */
2581 priority = atoi(get_port_other_config(port->cfg, "lacp-system-priority",
2583 s->priority = (priority > 0 && priority <= UINT16_MAX
2585 : UINT16_MAX - !list_is_short(&port->ifaces));
2587 s->heartbeat = !strcmp(get_port_other_config(port->cfg,
2592 lacp_time = get_port_other_config(port->cfg, "lacp-time", "slow");
2593 custom_time = atoi(lacp_time);
2594 if (!strcmp(lacp_time, "fast")) {
2595 s->lacp_time = LACP_TIME_FAST;
2596 } else if (!strcmp(lacp_time, "slow")) {
2597 s->lacp_time = LACP_TIME_SLOW;
2598 } else if (custom_time > 0) {
2599 s->lacp_time = LACP_TIME_CUSTOM;
2600 s->custom_time = custom_time;
2602 s->lacp_time = LACP_TIME_SLOW;
2609 iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
2611 int priority, portid, key;
2613 portid = atoi(get_interface_other_config(iface->cfg, "lacp-port-id", "0"));
2614 priority = atoi(get_interface_other_config(iface->cfg,
2615 "lacp-port-priority", "0"));
2616 key = atoi(get_interface_other_config(iface->cfg, "lacp-aggregation-key",
2619 if (portid <= 0 || portid > UINT16_MAX) {
2620 portid = iface->ofp_port;
2623 if (priority <= 0 || priority > UINT16_MAX) {
2624 priority = UINT16_MAX;
2627 if (key < 0 || key > UINT16_MAX) {
2631 s->name = iface->name;
2633 s->priority = priority;
2638 port_configure_bond(struct port *port, struct bond_settings *s,
2639 uint32_t *bond_stable_ids)
2641 const char *detect_s;
2642 struct iface *iface;
2643 int miimon_interval;
2646 s->name = port->name;
2647 s->balance = BM_SLB;
2648 if (port->cfg->bond_mode
2649 && !bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
2650 VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
2651 port->name, port->cfg->bond_mode,
2652 bond_mode_to_string(s->balance));
2654 if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
2655 VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
2656 "please use another bond type or disable flood_vlans",
2660 miimon_interval = atoi(get_port_other_config(port->cfg,
2661 "bond-miimon-interval", "0"));
2662 if (miimon_interval <= 0) {
2663 miimon_interval = 200;
2666 detect_s = get_port_other_config(port->cfg, "bond-detect-mode", "carrier");
2667 if (!strcmp(detect_s, "carrier")) {
2668 miimon_interval = 0;
2669 } else if (strcmp(detect_s, "miimon")) {
2670 VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
2671 "defaulting to carrier", port->name, detect_s);
2672 miimon_interval = 0;
2675 s->up_delay = MAX(0, port->cfg->bond_updelay);
2676 s->down_delay = MAX(0, port->cfg->bond_downdelay);
2677 s->basis = atoi(get_port_other_config(port->cfg, "bond-hash-basis", "0"));
2678 s->rebalance_interval = atoi(
2679 get_port_other_config(port->cfg, "bond-rebalance-interval", "10000"));
2680 if (s->rebalance_interval < 1000) {
2681 s->rebalance_interval = 1000;
2684 s->fake_iface = port->cfg->bond_fake_iface;
2687 LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
2688 long long stable_id;
2690 stable_id = atoll(get_interface_other_config(iface->cfg,
2691 "bond-stable-id", "0"));
2692 if (stable_id <= 0 || stable_id >= UINT32_MAX) {
2693 stable_id = iface->ofp_port;
2695 bond_stable_ids[i++] = stable_id;
2697 netdev_set_miimon_interval(iface->netdev, miimon_interval);
2701 /* Interface functions. */
2703 static struct iface *
2704 iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
2706 struct bridge *br = port->bridge;
2707 struct iface *iface;
2708 char *name = if_cfg->name;
2710 iface = xzalloc(sizeof *iface);
2712 iface->name = xstrdup(name);
2713 iface->ofp_port = -1;
2714 iface->tag = tag_create_random();
2715 iface->netdev = NULL;
2716 iface->cfg = if_cfg;
2718 hmap_insert(&br->iface_by_name, &iface->name_node, hash_string(name, 0));
2720 list_push_back(&port->ifaces, &iface->port_elem);
2722 VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
2728 iface_destroy(struct iface *iface)
2731 struct port *port = iface->port;
2732 struct bridge *br = port->bridge;
2734 if (br->ofproto && iface->ofp_port >= 0) {
2735 ofproto_port_unregister(br->ofproto, iface->ofp_port);
2738 if (iface->ofp_port >= 0) {
2739 hmap_remove(&br->ifaces, &iface->ofp_port_node);
2742 list_remove(&iface->port_elem);
2743 hmap_remove(&br->iface_by_name, &iface->name_node);
2745 netdev_close(iface->netdev);
2752 static struct iface *
2753 iface_lookup(const struct bridge *br, const char *name)
2755 struct iface *iface;
2757 HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
2758 &br->iface_by_name) {
2759 if (!strcmp(iface->name, name)) {
2767 static struct iface *
2768 iface_find(const char *name)
2770 const struct bridge *br;
2772 HMAP_FOR_EACH (br, node, &all_bridges) {
2773 struct iface *iface = iface_lookup(br, name);
2782 static struct iface *
2783 iface_from_ofp_port(const struct bridge *br, uint16_t ofp_port)
2785 struct iface *iface;
2787 HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node,
2788 hash_int(ofp_port, 0), &br->ifaces) {
2789 if (iface->ofp_port == ofp_port) {
2796 /* Set Ethernet address of 'iface', if one is specified in the configuration
2799 iface_set_mac(struct iface *iface)
2801 uint8_t ea[ETH_ADDR_LEN];
2803 if (!strcmp(iface->type, "internal")
2804 && iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
2805 if (iface->ofp_port == OFPP_LOCAL) {
2806 VLOG_ERR("interface %s: ignoring mac in Interface record "
2807 "(use Bridge record to set local port's mac)",
2809 } else if (eth_addr_is_multicast(ea)) {
2810 VLOG_ERR("interface %s: cannot set MAC to multicast address",
2813 int error = netdev_set_etheraddr(iface->netdev, ea);
2815 VLOG_ERR("interface %s: setting MAC failed (%s)",
2816 iface->name, strerror(error));
2822 /* Sets the ofport column of 'if_cfg' to 'ofport'. */
2824 iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
2826 if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
2827 ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
2831 /* Clears all of the fields in 'if_cfg' that indicate interface status, and
2832 * sets the "ofport" field to -1.
2834 * This is appropriate when 'if_cfg''s interface cannot be created or is
2835 * otherwise invalid. */
2837 iface_clear_db_record(const struct ovsrec_interface *if_cfg)
2839 if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
2840 iface_set_ofport(if_cfg, -1);
2841 ovsrec_interface_set_status(if_cfg, NULL, NULL, 0);
2842 ovsrec_interface_set_admin_state(if_cfg, NULL);
2843 ovsrec_interface_set_duplex(if_cfg, NULL);
2844 ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
2845 ovsrec_interface_set_link_state(if_cfg, NULL);
2846 ovsrec_interface_set_mtu(if_cfg, NULL, 0);
2847 ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
2848 ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
2849 ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
2850 ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
2854 /* Adds the 'n' key-value pairs in 'keys' in 'values' to 'shash'.
2856 * The value strings in '*shash' are taken directly from values[], not copied,
2857 * so the caller should not modify or free them. */
2859 shash_from_ovs_idl_map(char **keys, char **values, size_t n,
2860 struct shash *shash)
2865 for (i = 0; i < n; i++) {
2866 shash_add(shash, keys[i], values[i]);
2870 /* Creates 'keys' and 'values' arrays from 'shash'.
2872 * Sets 'keys' and 'values' to heap allocated arrays representing the key-value
2873 * pairs in 'shash'. The caller takes ownership of 'keys' and 'values'. They
2874 * are populated with with strings taken directly from 'shash' and thus have
2875 * the same ownership of the key-value pairs in shash.
2878 shash_to_ovs_idl_map(struct shash *shash,
2879 char ***keys, char ***values, size_t *n)
2883 struct shash_node *sn;
2885 count = shash_count(shash);
2887 k = xmalloc(count * sizeof *k);
2888 v = xmalloc(count * sizeof *v);
2891 SHASH_FOR_EACH(sn, shash) {
2902 struct iface_delete_queues_cbdata {
2903 struct netdev *netdev;
2904 const struct ovsdb_datum *queues;
2908 queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
2910 union ovsdb_atom atom;
2912 atom.integer = target;
2913 return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
2917 iface_delete_queues(unsigned int queue_id,
2918 const struct shash *details OVS_UNUSED, void *cbdata_)
2920 struct iface_delete_queues_cbdata *cbdata = cbdata_;
2922 if (!queue_ids_include(cbdata->queues, queue_id)) {
2923 netdev_delete_queue(cbdata->netdev, queue_id);
2928 iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
2930 if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
2931 netdev_set_qos(iface->netdev, NULL, NULL);
2933 struct iface_delete_queues_cbdata cbdata;
2934 struct shash details;
2938 /* Configure top-level Qos for 'iface'. */
2939 shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
2940 qos->n_other_config, &details);
2941 netdev_set_qos(iface->netdev, qos->type, &details);
2942 shash_destroy(&details);
2944 /* Deconfigure queues that were deleted. */
2945 cbdata.netdev = iface->netdev;
2946 cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
2948 netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
2950 /* Configure queues for 'iface'. */
2952 for (i = 0; i < qos->n_queues; i++) {
2953 const struct ovsrec_queue *queue = qos->value_queues[i];
2954 unsigned int queue_id = qos->key_queues[i];
2956 if (queue_id == 0) {
2960 shash_from_ovs_idl_map(queue->key_other_config,
2961 queue->value_other_config,
2962 queue->n_other_config, &details);
2963 netdev_set_queue(iface->netdev, queue_id, &details);
2964 shash_destroy(&details);
2967 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
2968 VLOG_WARN_RL(&rl, "interface %s: QoS configured without a default "
2969 "queue (queue 0). Packets not directed to a "
2970 "correctly configured queue may be dropped.",
2975 netdev_set_policing(iface->netdev,
2976 iface->cfg->ingress_policing_rate,
2977 iface->cfg->ingress_policing_burst);
2981 iface_configure_cfm(struct iface *iface)
2983 const struct ovsrec_interface *cfg = iface->cfg;
2984 const char *extended_str, *opstate_str;
2985 struct cfm_settings s;
2987 if (!cfg->n_cfm_mpid) {
2988 ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
2992 s.mpid = *cfg->cfm_mpid;
2993 s.interval = atoi(get_interface_other_config(iface->cfg, "cfm_interval",
2995 if (s.interval <= 0) {
2999 extended_str = get_interface_other_config(iface->cfg, "cfm_extended",
3001 s.extended = !strcasecmp("true", extended_str);
3003 opstate_str = get_interface_other_config(iface->cfg, "cfm_opstate", "up");
3004 s.opup = !strcasecmp("up", opstate_str);
3006 ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
3009 /* Returns true if 'iface' is synthetic, that is, if we constructed it locally
3010 * instead of obtaining it from the database. */
3012 iface_is_synthetic(const struct iface *iface)
3014 return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
3017 /* Port mirroring. */
3019 static struct mirror *
3020 mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
3024 HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
3025 if (uuid_equals(uuid, &m->uuid)) {
3033 bridge_configure_mirrors(struct bridge *br)
3035 const struct ovsdb_datum *mc;
3036 unsigned long *flood_vlans;
3037 struct mirror *m, *next;
3040 /* Get rid of deleted mirrors. */
3041 mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
3042 HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
3043 union ovsdb_atom atom;
3045 atom.uuid = m->uuid;
3046 if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
3051 /* Add new mirrors and reconfigure existing ones. */
3052 for (i = 0; i < br->cfg->n_mirrors; i++) {
3053 const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3054 struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
3056 m = mirror_create(br, cfg);
3058 if (!mirror_configure(m, cfg)) {
3063 /* Update flooded vlans (for RSPAN). */
3064 flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
3065 br->cfg->n_flood_vlans);
3066 ofproto_set_flood_vlans(br->ofproto, flood_vlans);
3067 bitmap_free(flood_vlans);
3070 static struct mirror *
3071 mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
3075 m = xzalloc(sizeof *m);
3076 m->uuid = cfg->header_.uuid;
3077 hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
3079 m->name = xstrdup(cfg->name);
3085 mirror_destroy(struct mirror *m)
3088 struct bridge *br = m->bridge;
3091 ofproto_mirror_unregister(br->ofproto, m);
3094 hmap_remove(&br->mirrors, &m->hmap_node);
3101 mirror_collect_ports(struct mirror *m,
3102 struct ovsrec_port **in_ports, int n_in_ports,
3103 void ***out_portsp, size_t *n_out_portsp)
3105 void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
3106 size_t n_out_ports = 0;
3109 for (i = 0; i < n_in_ports; i++) {
3110 const char *name = in_ports[i]->name;
3111 struct port *port = port_lookup(m->bridge, name);
3113 out_ports[n_out_ports++] = port;
3115 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3116 "port %s", m->bridge->name, m->name, name);
3119 *out_portsp = out_ports;
3120 *n_out_portsp = n_out_ports;
3124 mirror_configure(struct mirror *m, const struct ovsrec_mirror *cfg)
3126 struct ofproto_mirror_settings s;
3129 if (strcmp(cfg->name, m->name)) {
3131 m->name = xstrdup(cfg->name);
3135 /* Get output port or VLAN. */
3136 if (cfg->output_port) {
3137 s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
3138 if (!s.out_bundle) {
3139 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
3140 m->bridge->name, m->name);
3143 s.out_vlan = UINT16_MAX;
3145 if (cfg->output_vlan) {
3146 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
3147 "output vlan; ignoring output vlan",
3148 m->bridge->name, m->name);
3150 } else if (cfg->output_vlan) {
3151 /* The database should prevent invalid VLAN values. */
3152 s.out_bundle = NULL;
3153 s.out_vlan = *cfg->output_vlan;
3155 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
3156 m->bridge->name, m->name);
3160 /* Get port selection. */
3161 if (cfg->select_all) {
3162 size_t n_ports = hmap_count(&m->bridge->ports);
3163 void **ports = xmalloc(n_ports * sizeof *ports);
3168 HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
3178 /* Get ports, dropping ports that don't exist.
3179 * The IDL ensures that there are no duplicates. */
3180 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
3181 &s.srcs, &s.n_srcs);
3182 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
3183 &s.dsts, &s.n_dsts);
3186 /* Get VLAN selection. */
3187 s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
3190 ofproto_mirror_register(m->bridge->ofproto, m, &s);
3193 if (s.srcs != s.dsts) {