1 /* Copyright (c) 2008, 2009, 2010 Nicira Networks
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
20 #include <arpa/inet.h>
24 #include <openflow/openflow.h>
29 #include <sys/socket.h>
30 #include <sys/types.h>
36 #include "dynamic-string.h"
40 #include "mac-learning.h"
43 #include "ofp-print.h"
45 #include "ofproto/netflow.h"
46 #include "ofproto/ofproto.h"
48 #include "poll-loop.h"
49 #include "port-array.h"
50 #include "proc-net-compat.h"
54 #include "socket-util.h"
55 #include "stream-ssl.h"
61 #include "vswitchd/vswitch-idl.h"
62 #include "xenserver.h"
64 #include "sflow_api.h"
66 #define THIS_MODULE VLM_bridge
75 /* These members are always valid. */
76 struct port *port; /* Containing port. */
77 size_t port_ifidx; /* Index within containing port. */
78 char *name; /* Host network device name. */
79 tag_type tag; /* Tag associated with this interface. */
80 long long delay_expires; /* Time after which 'enabled' may change. */
82 /* These members are valid only after bridge_reconfigure() causes them to
84 int dp_ifidx; /* Index within kernel datapath. */
85 struct netdev *netdev; /* Network device. */
86 bool enabled; /* May be chosen for flows? */
88 /* This member is only valid *during* bridge_reconfigure(). */
89 const struct ovsrec_interface *cfg;
92 #define BOND_MASK 0xff
94 int iface_idx; /* Index of assigned iface, or -1 if none. */
95 uint64_t tx_bytes; /* Count of bytes recently transmitted. */
96 tag_type iface_tag; /* Tag associated with iface_idx. */
99 #define MAX_MIRRORS 32
100 typedef uint32_t mirror_mask_t;
101 #define MIRROR_MASK_C(X) UINT32_C(X)
102 BUILD_ASSERT_DECL(sizeof(mirror_mask_t) * CHAR_BIT >= MAX_MIRRORS);
104 struct bridge *bridge;
108 /* Selection criteria. */
109 struct shash src_ports; /* Name is port name; data is always NULL. */
110 struct shash dst_ports; /* Name is port name; data is always NULL. */
115 struct port *out_port;
119 #define FLOOD_PORT ((struct port *) 1) /* The 'flood' output port. */
121 struct bridge *bridge;
123 int vlan; /* -1=trunk port, else a 12-bit VLAN ID. */
124 unsigned long *trunks; /* Bitmap of trunked VLANs, if 'vlan' == -1. */
127 /* An ordinary bridge port has 1 interface.
128 * A bridge port for bonding has at least 2 interfaces. */
129 struct iface **ifaces;
130 size_t n_ifaces, allocated_ifaces;
133 struct bond_entry *bond_hash; /* An array of (BOND_MASK + 1) elements. */
134 int active_iface; /* Ifidx on which bcasts accepted, or -1. */
135 tag_type active_iface_tag; /* Tag for bcast flows. */
136 tag_type no_ifaces_tag; /* Tag for flows when all ifaces disabled. */
137 int updelay, downdelay; /* Delay before iface goes up/down, in ms. */
138 bool bond_compat_is_stale; /* Need to call port_update_bond_compat()? */
139 bool bond_fake_iface; /* Fake a bond interface for legacy compat? */
140 long bond_next_fake_iface_update; /* Next update to fake bond stats. */
141 int bond_rebalance_interval; /* Interval between rebalances, in ms. */
142 long long int bond_next_rebalance; /* Next rebalancing time. */
144 /* Port mirroring info. */
145 mirror_mask_t src_mirrors; /* Mirrors triggered when packet received. */
146 mirror_mask_t dst_mirrors; /* Mirrors triggered when packet sent. */
147 bool is_mirror_output_port; /* Does port mirroring send frames here? */
149 /* This member is only valid *during* bridge_reconfigure(). */
150 const struct ovsrec_port *cfg;
153 #define DP_MAX_PORTS 255
155 struct list node; /* Node in global list of bridges. */
156 char *name; /* User-specified arbitrary name. */
157 struct mac_learning *ml; /* MAC learning table. */
158 bool sent_config_request; /* Successfully sent config request? */
159 uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
161 /* Support for remote controllers. */
162 char *controller; /* NULL if there is no remote controller;
163 * "discover" to do controller discovery;
164 * otherwise a vconn name. */
166 /* OpenFlow switch processing. */
167 struct ofproto *ofproto; /* OpenFlow switch. */
169 /* Description strings. */
170 char *mfr_desc; /* Manufacturer. */
171 char *hw_desc; /* Hardware. */
172 char *sw_desc; /* Software version. */
173 char *serial_desc; /* Serial number. */
174 char *dp_desc; /* Datapath description. */
176 /* Kernel datapath information. */
177 struct dpif *dpif; /* Datapath. */
178 struct port_array ifaces; /* Indexed by kernel datapath port number. */
182 size_t n_ports, allocated_ports;
185 bool has_bonded_ports;
190 /* Flow statistics gathering. */
191 time_t next_stats_request;
193 /* Port mirroring. */
194 struct mirror *mirrors[MAX_MIRRORS];
196 /* This member is only valid *during* bridge_reconfigure(). */
197 const struct ovsrec_bridge *cfg;
200 /* List of all bridges. */
201 static struct list all_bridges = LIST_INITIALIZER(&all_bridges);
203 /* Maximum number of datapaths. */
204 enum { DP_MAX = 256 };
206 static struct bridge *bridge_create(const struct ovsrec_bridge *br_cfg);
207 static void bridge_destroy(struct bridge *);
208 static struct bridge *bridge_lookup(const char *name);
209 static unixctl_cb_func bridge_unixctl_dump_flows;
210 static int bridge_run_one(struct bridge *);
211 static const struct ovsrec_controller *bridge_get_controller(
212 const struct ovsrec_open_vswitch *ovs_cfg,
213 const struct bridge *br);
214 static void bridge_reconfigure_one(const struct ovsrec_open_vswitch *,
216 static void bridge_reconfigure_controller(const struct ovsrec_open_vswitch *,
218 static void bridge_get_all_ifaces(const struct bridge *, struct shash *ifaces);
219 static void bridge_fetch_dp_ifaces(struct bridge *);
220 static void bridge_flush(struct bridge *);
221 static void bridge_pick_local_hw_addr(struct bridge *,
222 uint8_t ea[ETH_ADDR_LEN],
223 struct iface **hw_addr_iface);
224 static uint64_t bridge_pick_datapath_id(struct bridge *,
225 const uint8_t bridge_ea[ETH_ADDR_LEN],
226 struct iface *hw_addr_iface);
227 static struct iface *bridge_get_local_iface(struct bridge *);
228 static uint64_t dpid_from_hash(const void *, size_t nbytes);
230 static unixctl_cb_func bridge_unixctl_fdb_show;
232 static void bond_init(void);
233 static void bond_run(struct bridge *);
234 static void bond_wait(struct bridge *);
235 static void bond_rebalance_port(struct port *);
236 static void bond_send_learning_packets(struct port *);
237 static void bond_enable_slave(struct iface *iface, bool enable);
239 static struct port *port_create(struct bridge *, const char *name);
240 static void port_reconfigure(struct port *, const struct ovsrec_port *);
241 static void port_destroy(struct port *);
242 static struct port *port_lookup(const struct bridge *, const char *name);
243 static struct iface *port_lookup_iface(const struct port *, const char *name);
244 static struct port *port_from_dp_ifidx(const struct bridge *,
246 static void port_update_bond_compat(struct port *);
247 static void port_update_vlan_compat(struct port *);
248 static void port_update_bonding(struct port *);
250 static struct mirror *mirror_create(struct bridge *, const char *name);
251 static void mirror_destroy(struct mirror *);
252 static void mirror_reconfigure(struct bridge *);
253 static void mirror_reconfigure_one(struct mirror *, struct ovsrec_mirror *);
254 static bool vlan_is_mirrored(const struct mirror *, int vlan);
256 static struct iface *iface_create(struct port *port,
257 const struct ovsrec_interface *if_cfg);
258 static void iface_destroy(struct iface *);
259 static struct iface *iface_lookup(const struct bridge *, const char *name);
260 static struct iface *iface_from_dp_ifidx(const struct bridge *,
262 static bool iface_is_internal(const struct bridge *, const char *name);
263 static void iface_set_mac(struct iface *);
265 /* Hooks into ofproto processing. */
266 static struct ofhooks bridge_ofhooks;
268 /* Public functions. */
270 /* Adds the name of each interface used by a bridge, including local and
271 * internal ports, to 'svec'. */
273 bridge_get_ifaces(struct svec *svec)
275 struct bridge *br, *next;
278 LIST_FOR_EACH_SAFE (br, next, struct bridge, node, &all_bridges) {
279 for (i = 0; i < br->n_ports; i++) {
280 struct port *port = br->ports[i];
282 for (j = 0; j < port->n_ifaces; j++) {
283 struct iface *iface = port->ifaces[j];
284 if (iface->dp_ifidx < 0) {
285 VLOG_ERR("%s interface not in datapath %s, ignoring",
286 iface->name, dpif_name(br->dpif));
288 if (iface->dp_ifidx != ODPP_LOCAL) {
289 svec_add(svec, iface->name);
298 bridge_init(const struct ovsrec_open_vswitch *cfg)
300 struct svec bridge_names;
301 struct svec dpif_names, dpif_types;
304 unixctl_command_register("fdb/show", bridge_unixctl_fdb_show, NULL);
306 svec_init(&bridge_names);
307 for (i = 0; i < cfg->n_bridges; i++) {
308 svec_add(&bridge_names, cfg->bridges[i]->name);
310 svec_sort(&bridge_names);
312 svec_init(&dpif_names);
313 svec_init(&dpif_types);
314 dp_enumerate_types(&dpif_types);
315 for (i = 0; i < dpif_types.n; i++) {
320 dp_enumerate_names(dpif_types.names[i], &dpif_names);
322 for (j = 0; j < dpif_names.n; j++) {
323 retval = dpif_open(dpif_names.names[j], dpif_types.names[i], &dpif);
325 struct svec all_names;
328 svec_init(&all_names);
329 dpif_get_all_names(dpif, &all_names);
330 for (k = 0; k < all_names.n; k++) {
331 if (svec_contains(&bridge_names, all_names.names[k])) {
337 svec_destroy(&all_names);
342 svec_destroy(&bridge_names);
343 svec_destroy(&dpif_names);
344 svec_destroy(&dpif_types);
346 unixctl_command_register("bridge/dump-flows", bridge_unixctl_dump_flows,
350 bridge_reconfigure(cfg);
355 bridge_configure_ssl(const struct ovsrec_ssl *ssl)
357 /* XXX SSL should be configurable on a per-bridge basis. */
359 stream_ssl_set_private_key_file(ssl->private_key);
360 stream_ssl_set_certificate_file(ssl->certificate);
361 stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
366 /* Attempt to create the network device 'iface_name' through the netdev
369 set_up_iface(const struct ovsrec_interface *iface_cfg, struct iface *iface,
372 struct shash_node *node;
373 struct shash options;
377 shash_init(&options);
378 for (i = 0; i < iface_cfg->n_options; i++) {
379 shash_add(&options, iface_cfg->key_options[i],
380 xstrdup(iface_cfg->value_options[i]));
384 struct netdev_options netdev_options;
386 memset(&netdev_options, 0, sizeof netdev_options);
387 netdev_options.name = iface_cfg->name;
388 if (!strcmp(iface_cfg->type, "internal")) {
389 /* An "internal" config type maps to a netdev "system" type. */
390 netdev_options.type = "system";
392 netdev_options.type = iface_cfg->type;
394 netdev_options.args = &options;
395 netdev_options.ethertype = NETDEV_ETH_TYPE_NONE;
396 netdev_options.may_create = true;
397 if (iface_is_internal(iface->port->bridge, iface_cfg->name)) {
398 netdev_options.may_open = true;
401 error = netdev_open(&netdev_options, &iface->netdev);
404 netdev_get_carrier(iface->netdev, &iface->enabled);
406 } else if (iface->netdev) {
407 const char *netdev_type = netdev_get_type(iface->netdev);
408 const char *iface_type = iface_cfg->type && strlen(iface_cfg->type)
409 ? iface_cfg->type : NULL;
411 /* An "internal" config type maps to a netdev "system" type. */
412 if (iface_type && !strcmp(iface_type, "internal")) {
413 iface_type = "system";
416 if (!iface_type || !strcmp(netdev_type, iface_type)) {
417 error = netdev_reconfigure(iface->netdev, &options);
419 VLOG_WARN("%s: attempting change device type from %s to %s",
420 iface_cfg->name, netdev_type, iface_type);
425 SHASH_FOR_EACH (node, &options) {
428 shash_destroy(&options);
434 reconfigure_iface(const struct ovsrec_interface *iface_cfg, struct iface *iface)
436 return set_up_iface(iface_cfg, iface, false);
440 check_iface_netdev(struct bridge *br OVS_UNUSED, struct iface *iface,
441 void *aux OVS_UNUSED)
443 if (!iface->netdev) {
444 int error = set_up_iface(iface->cfg, iface, true);
446 VLOG_WARN("could not open netdev on %s, dropping: %s", iface->name,
456 check_iface_dp_ifidx(struct bridge *br, struct iface *iface,
457 void *aux OVS_UNUSED)
459 if (iface->dp_ifidx >= 0) {
460 VLOG_DBG("%s has interface %s on port %d",
462 iface->name, iface->dp_ifidx);
465 VLOG_ERR("%s interface not in %s, dropping",
466 iface->name, dpif_name(br->dpif));
472 set_iface_properties(struct bridge *br OVS_UNUSED, struct iface *iface,
473 void *aux OVS_UNUSED)
475 /* Set policing attributes. */
476 netdev_set_policing(iface->netdev,
477 iface->cfg->ingress_policing_rate,
478 iface->cfg->ingress_policing_burst);
480 /* Set MAC address of internal interfaces other than the local
482 if (iface->dp_ifidx != ODPP_LOCAL
483 && iface_is_internal(br, iface->name)) {
484 iface_set_mac(iface);
490 /* Calls 'cb' for each interfaces in 'br', passing along the 'aux' argument.
491 * Deletes from 'br' all the interfaces for which 'cb' returns false, and then
492 * deletes from 'br' any ports that no longer have any interfaces. */
494 iterate_and_prune_ifaces(struct bridge *br,
495 bool (*cb)(struct bridge *, struct iface *,
501 for (i = 0; i < br->n_ports; ) {
502 struct port *port = br->ports[i];
503 for (j = 0; j < port->n_ifaces; ) {
504 struct iface *iface = port->ifaces[j];
505 if (cb(br, iface, aux)) {
508 iface_destroy(iface);
512 if (port->n_ifaces) {
515 VLOG_ERR("%s port has no interfaces, dropping", port->name);
522 bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
524 struct ovsdb_idl_txn *txn;
525 struct shash old_br, new_br;
526 struct shash_node *node;
527 struct bridge *br, *next;
529 int sflow_bridge_number;
531 COVERAGE_INC(bridge_reconfigure);
533 txn = ovsdb_idl_txn_create(ovs_cfg->header_.table->idl);
535 /* Collect old and new bridges. */
538 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
539 shash_add(&old_br, br->name, br);
541 for (i = 0; i < ovs_cfg->n_bridges; i++) {
542 const struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
543 if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
544 VLOG_WARN("more than one bridge named %s", br_cfg->name);
548 /* Get rid of deleted bridges and add new bridges. */
549 LIST_FOR_EACH_SAFE (br, next, struct bridge, node, &all_bridges) {
550 struct ovsrec_bridge *br_cfg = shash_find_data(&new_br, br->name);
557 SHASH_FOR_EACH (node, &new_br) {
558 const char *br_name = node->name;
559 const struct ovsrec_bridge *br_cfg = node->data;
560 br = shash_find_data(&old_br, br_name);
562 /* If the bridge datapath type has changed, we need to tear it
563 * down and recreate. */
564 if (strcmp(br->cfg->datapath_type, br_cfg->datapath_type)) {
566 bridge_create(br_cfg);
569 bridge_create(br_cfg);
572 shash_destroy(&old_br);
573 shash_destroy(&new_br);
577 bridge_configure_ssl(ovs_cfg->ssl);
580 /* Reconfigure all bridges. */
581 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
582 bridge_reconfigure_one(ovs_cfg, br);
585 /* Add and delete ports on all datapaths.
587 * The kernel will reject any attempt to add a given port to a datapath if
588 * that port already belongs to a different datapath, so we must do all
589 * port deletions before any port additions. */
590 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
591 struct odp_port *dpif_ports;
593 struct shash want_ifaces;
595 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
596 bridge_get_all_ifaces(br, &want_ifaces);
597 for (i = 0; i < n_dpif_ports; i++) {
598 const struct odp_port *p = &dpif_ports[i];
599 if (!shash_find(&want_ifaces, p->devname)
600 && strcmp(p->devname, br->name)) {
601 int retval = dpif_port_del(br->dpif, p->port);
603 VLOG_ERR("failed to remove %s interface from %s: %s",
604 p->devname, dpif_name(br->dpif),
609 shash_destroy(&want_ifaces);
612 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
613 struct odp_port *dpif_ports;
615 struct shash cur_ifaces, want_ifaces;
616 struct shash_node *node;
618 /* Get the set of interfaces currently in this datapath. */
619 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
620 shash_init(&cur_ifaces);
621 for (i = 0; i < n_dpif_ports; i++) {
622 const char *name = dpif_ports[i].devname;
623 if (!shash_find(&cur_ifaces, name)) {
624 shash_add(&cur_ifaces, name, NULL);
629 /* Get the set of interfaces we want on this datapath. */
630 bridge_get_all_ifaces(br, &want_ifaces);
632 SHASH_FOR_EACH (node, &want_ifaces) {
633 const char *if_name = node->name;
634 struct iface *iface = node->data;
636 if (shash_find(&cur_ifaces, if_name)) {
637 /* Already exists, just reconfigure it. */
639 reconfigure_iface(iface->cfg, iface);
642 /* Need to add to datapath. */
646 /* Add to datapath. */
647 internal = iface_is_internal(br, if_name);
648 error = dpif_port_add(br->dpif, if_name,
649 internal ? ODP_PORT_INTERNAL : 0, NULL);
650 if (error == EFBIG) {
651 VLOG_ERR("ran out of valid port numbers on %s",
652 dpif_name(br->dpif));
655 VLOG_ERR("failed to add %s interface to %s: %s",
656 if_name, dpif_name(br->dpif), strerror(error));
660 shash_destroy(&cur_ifaces);
661 shash_destroy(&want_ifaces);
663 sflow_bridge_number = 0;
664 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
667 struct iface *local_iface;
668 struct iface *hw_addr_iface;
671 bridge_fetch_dp_ifaces(br);
673 iterate_and_prune_ifaces(br, check_iface_netdev, NULL);
674 iterate_and_prune_ifaces(br, check_iface_dp_ifidx, NULL);
676 /* Pick local port hardware address, datapath ID. */
677 bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
678 local_iface = bridge_get_local_iface(br);
680 int error = netdev_set_etheraddr(local_iface->netdev, ea);
682 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
683 VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
684 "Ethernet address: %s",
685 br->name, strerror(error));
689 dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
690 ofproto_set_datapath_id(br->ofproto, dpid);
692 dpid_string = xasprintf("%012"PRIx64, dpid);
693 ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
696 /* Set NetFlow configuration on this bridge. */
697 if (br->cfg->netflow) {
698 struct ovsrec_netflow *nf_cfg = br->cfg->netflow;
699 struct netflow_options opts;
701 memset(&opts, 0, sizeof opts);
703 dpif_get_netflow_ids(br->dpif, &opts.engine_type, &opts.engine_id);
704 if (nf_cfg->engine_type) {
705 opts.engine_type = *nf_cfg->engine_type;
707 if (nf_cfg->engine_id) {
708 opts.engine_id = *nf_cfg->engine_id;
711 opts.active_timeout = nf_cfg->active_timeout;
712 if (!opts.active_timeout) {
713 opts.active_timeout = -1;
714 } else if (opts.active_timeout < 0) {
715 VLOG_WARN("bridge %s: active timeout interval set to negative "
716 "value, using default instead (%d seconds)", br->name,
717 NF_ACTIVE_TIMEOUT_DEFAULT);
718 opts.active_timeout = -1;
721 opts.add_id_to_iface = nf_cfg->add_id_to_interface;
722 if (opts.add_id_to_iface) {
723 if (opts.engine_id > 0x7f) {
724 VLOG_WARN("bridge %s: netflow port mangling may conflict "
725 "with another vswitch, choose an engine id less "
726 "than 128", br->name);
728 if (br->n_ports > 508) {
729 VLOG_WARN("bridge %s: netflow port mangling will conflict "
730 "with another port when more than 508 ports are "
735 opts.collectors.n = nf_cfg->n_targets;
736 opts.collectors.names = nf_cfg->targets;
737 if (ofproto_set_netflow(br->ofproto, &opts)) {
738 VLOG_ERR("bridge %s: problem setting netflow collectors",
742 ofproto_set_netflow(br->ofproto, NULL);
745 /* Set sFlow configuration on this bridge. */
746 if (br->cfg->sflow) {
747 const struct ovsrec_sflow *sflow_cfg = br->cfg->sflow;
748 const struct ovsrec_controller *ctrl;
749 struct ofproto_sflow_options oso;
751 memset(&oso, 0, sizeof oso);
753 oso.targets.n = sflow_cfg->n_targets;
754 oso.targets.names = sflow_cfg->targets;
756 oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
757 if (sflow_cfg->sampling) {
758 oso.sampling_rate = *sflow_cfg->sampling;
761 oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
762 if (sflow_cfg->polling) {
763 oso.polling_interval = *sflow_cfg->polling;
766 oso.header_len = SFL_DEFAULT_HEADER_SIZE;
767 if (sflow_cfg->header) {
768 oso.header_len = *sflow_cfg->header;
771 oso.sub_id = sflow_bridge_number++;
772 oso.agent_device = sflow_cfg->agent;
774 ctrl = bridge_get_controller(ovs_cfg, br);
775 oso.control_ip = ctrl ? ctrl->local_ip : NULL;
776 ofproto_set_sflow(br->ofproto, &oso);
778 svec_destroy(&oso.targets);
780 ofproto_set_sflow(br->ofproto, NULL);
783 /* Update the controller and related settings. It would be more
784 * straightforward to call this from bridge_reconfigure_one(), but we
785 * can't do it there for two reasons. First, and most importantly, at
786 * that point we don't know the dp_ifidx of any interfaces that have
787 * been added to the bridge (because we haven't actually added them to
788 * the datapath). Second, at that point we haven't set the datapath ID
789 * yet; when a controller is configured, resetting the datapath ID will
790 * immediately disconnect from the controller, so it's better to set
791 * the datapath ID before the controller. */
792 bridge_reconfigure_controller(ovs_cfg, br);
794 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
795 for (i = 0; i < br->n_ports; i++) {
796 struct port *port = br->ports[i];
798 port_update_vlan_compat(port);
799 port_update_bonding(port);
802 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
803 iterate_and_prune_ifaces(br, set_iface_properties, NULL);
806 ovsrec_open_vswitch_set_cur_cfg(ovs_cfg, ovs_cfg->next_cfg);
808 ovsdb_idl_txn_commit(txn);
809 ovsdb_idl_txn_destroy(txn); /* XXX */
813 get_ovsrec_key_value(const char *key, char **keys, char **values, size_t n)
817 for (i = 0; i < n; i++) {
818 if (!strcmp(keys[i], key)) {
826 bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
828 return get_ovsrec_key_value(key,
829 br_cfg->key_other_config,
830 br_cfg->value_other_config,
831 br_cfg->n_other_config);
835 bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
836 struct iface **hw_addr_iface)
842 *hw_addr_iface = NULL;
844 /* Did the user request a particular MAC? */
845 hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
846 if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
847 if (eth_addr_is_multicast(ea)) {
848 VLOG_ERR("bridge %s: cannot set MAC address to multicast "
849 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
850 } else if (eth_addr_is_zero(ea)) {
851 VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
857 /* Otherwise choose the minimum non-local MAC address among all of the
859 memset(ea, 0xff, sizeof ea);
860 for (i = 0; i < br->n_ports; i++) {
861 struct port *port = br->ports[i];
862 uint8_t iface_ea[ETH_ADDR_LEN];
865 /* Mirror output ports don't participate. */
866 if (port->is_mirror_output_port) {
870 /* Choose the MAC address to represent the port. */
871 if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
872 /* Find the interface with this Ethernet address (if any) so that
873 * we can provide the correct devname to the caller. */
875 for (j = 0; j < port->n_ifaces; j++) {
876 struct iface *candidate = port->ifaces[j];
877 uint8_t candidate_ea[ETH_ADDR_LEN];
878 if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
879 && eth_addr_equals(iface_ea, candidate_ea)) {
884 /* Choose the interface whose MAC address will represent the port.
885 * The Linux kernel bonding code always chooses the MAC address of
886 * the first slave added to a bond, and the Fedora networking
887 * scripts always add slaves to a bond in alphabetical order, so
888 * for compatibility we choose the interface with the name that is
889 * first in alphabetical order. */
890 iface = port->ifaces[0];
891 for (j = 1; j < port->n_ifaces; j++) {
892 struct iface *candidate = port->ifaces[j];
893 if (strcmp(candidate->name, iface->name) < 0) {
898 /* The local port doesn't count (since we're trying to choose its
899 * MAC address anyway). */
900 if (iface->dp_ifidx == ODPP_LOCAL) {
905 error = netdev_get_etheraddr(iface->netdev, iface_ea);
907 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
908 VLOG_ERR_RL(&rl, "failed to obtain Ethernet address of %s: %s",
909 iface->name, strerror(error));
914 /* Compare against our current choice. */
915 if (!eth_addr_is_multicast(iface_ea) &&
916 !eth_addr_is_local(iface_ea) &&
917 !eth_addr_is_reserved(iface_ea) &&
918 !eth_addr_is_zero(iface_ea) &&
919 memcmp(iface_ea, ea, ETH_ADDR_LEN) < 0)
921 memcpy(ea, iface_ea, ETH_ADDR_LEN);
922 *hw_addr_iface = iface;
925 if (eth_addr_is_multicast(ea)) {
926 memcpy(ea, br->default_ea, ETH_ADDR_LEN);
927 *hw_addr_iface = NULL;
928 VLOG_WARN("bridge %s: using default bridge Ethernet "
929 "address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
931 VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
932 br->name, ETH_ADDR_ARGS(ea));
936 /* Choose and returns the datapath ID for bridge 'br' given that the bridge
937 * Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
938 * an interface on 'br', then that interface must be passed in as
939 * 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
940 * 'hw_addr_iface' must be passed in as a null pointer. */
942 bridge_pick_datapath_id(struct bridge *br,
943 const uint8_t bridge_ea[ETH_ADDR_LEN],
944 struct iface *hw_addr_iface)
947 * The procedure for choosing a bridge MAC address will, in the most
948 * ordinary case, also choose a unique MAC that we can use as a datapath
949 * ID. In some special cases, though, multiple bridges will end up with
950 * the same MAC address. This is OK for the bridges, but it will confuse
951 * the OpenFlow controller, because each datapath needs a unique datapath
954 * Datapath IDs must be unique. It is also very desirable that they be
955 * stable from one run to the next, so that policy set on a datapath
958 const char *datapath_id;
961 datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
962 if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
968 if (!netdev_get_vlan_vid(hw_addr_iface->netdev, &vlan)) {
970 * A bridge whose MAC address is taken from a VLAN network device
971 * (that is, a network device created with vconfig(8) or similar
972 * tool) will have the same MAC address as a bridge on the VLAN
973 * device's physical network device.
975 * Handle this case by hashing the physical network device MAC
976 * along with the VLAN identifier.
978 uint8_t buf[ETH_ADDR_LEN + 2];
979 memcpy(buf, bridge_ea, ETH_ADDR_LEN);
980 buf[ETH_ADDR_LEN] = vlan >> 8;
981 buf[ETH_ADDR_LEN + 1] = vlan;
982 return dpid_from_hash(buf, sizeof buf);
985 * Assume that this bridge's MAC address is unique, since it
986 * doesn't fit any of the cases we handle specially.
991 * A purely internal bridge, that is, one that has no non-virtual
992 * network devices on it at all, is more difficult because it has no
993 * natural unique identifier at all.
995 * When the host is a XenServer, we handle this case by hashing the
996 * host's UUID with the name of the bridge. Names of bridges are
997 * persistent across XenServer reboots, although they can be reused if
998 * an internal network is destroyed and then a new one is later
999 * created, so this is fairly effective.
1001 * When the host is not a XenServer, we punt by using a random MAC
1002 * address on each run.
1004 const char *host_uuid = xenserver_get_host_uuid();
1006 char *combined = xasprintf("%s,%s", host_uuid, br->name);
1007 dpid = dpid_from_hash(combined, strlen(combined));
1013 return eth_addr_to_uint64(bridge_ea);
1017 dpid_from_hash(const void *data, size_t n)
1019 uint8_t hash[SHA1_DIGEST_SIZE];
1021 BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
1022 sha1_bytes(data, n, hash);
1023 eth_addr_mark_random(hash);
1024 return eth_addr_to_uint64(hash);
1030 struct bridge *br, *next;
1034 LIST_FOR_EACH_SAFE (br, next, struct bridge, node, &all_bridges) {
1035 int error = bridge_run_one(br);
1037 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
1038 VLOG_ERR_RL(&rl, "bridge %s: datapath was destroyed externally, "
1039 "forcing reconfiguration", br->name);
1053 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1054 ofproto_wait(br->ofproto);
1055 if (br->controller) {
1059 mac_learning_wait(br->ml);
1064 /* Forces 'br' to revalidate all of its flows. This is appropriate when 'br''s
1065 * configuration changes. */
1067 bridge_flush(struct bridge *br)
1069 COVERAGE_INC(bridge_flush);
1071 mac_learning_flush(br->ml);
1074 /* Returns the 'br' interface for the ODPP_LOCAL port, or null if 'br' has no
1075 * such interface. */
1076 static struct iface *
1077 bridge_get_local_iface(struct bridge *br)
1081 for (i = 0; i < br->n_ports; i++) {
1082 struct port *port = br->ports[i];
1083 for (j = 0; j < port->n_ifaces; j++) {
1084 struct iface *iface = port->ifaces[j];
1085 if (iface->dp_ifidx == ODPP_LOCAL) {
1094 /* Bridge unixctl user interface functions. */
1096 bridge_unixctl_fdb_show(struct unixctl_conn *conn,
1097 const char *args, void *aux OVS_UNUSED)
1099 struct ds ds = DS_EMPTY_INITIALIZER;
1100 const struct bridge *br;
1101 const struct mac_entry *e;
1103 br = bridge_lookup(args);
1105 unixctl_command_reply(conn, 501, "no such bridge");
1109 ds_put_cstr(&ds, " port VLAN MAC Age\n");
1110 LIST_FOR_EACH (e, struct mac_entry, lru_node, &br->ml->lrus) {
1111 if (e->port < 0 || e->port >= br->n_ports) {
1114 ds_put_format(&ds, "%5d %4d "ETH_ADDR_FMT" %3d\n",
1115 br->ports[e->port]->ifaces[0]->dp_ifidx,
1116 e->vlan, ETH_ADDR_ARGS(e->mac), mac_entry_age(e));
1118 unixctl_command_reply(conn, 200, ds_cstr(&ds));
1122 /* Bridge reconfiguration functions. */
1123 static struct bridge *
1124 bridge_create(const struct ovsrec_bridge *br_cfg)
1129 assert(!bridge_lookup(br_cfg->name));
1130 br = xzalloc(sizeof *br);
1132 error = dpif_create_and_open(br_cfg->name, br_cfg->datapath_type,
1138 dpif_flow_flush(br->dpif);
1140 error = ofproto_create(br_cfg->name, br_cfg->datapath_type, &bridge_ofhooks,
1143 VLOG_ERR("failed to create switch %s: %s", br_cfg->name,
1145 dpif_delete(br->dpif);
1146 dpif_close(br->dpif);
1151 br->name = xstrdup(br_cfg->name);
1153 br->ml = mac_learning_create();
1154 br->sent_config_request = false;
1155 eth_addr_nicira_random(br->default_ea);
1157 port_array_init(&br->ifaces);
1161 list_push_back(&all_bridges, &br->node);
1163 VLOG_INFO("created bridge %s on %s", br->name, dpif_name(br->dpif));
1169 bridge_destroy(struct bridge *br)
1174 while (br->n_ports > 0) {
1175 port_destroy(br->ports[br->n_ports - 1]);
1177 list_remove(&br->node);
1178 error = dpif_delete(br->dpif);
1179 if (error && error != ENOENT) {
1180 VLOG_ERR("failed to delete %s: %s",
1181 dpif_name(br->dpif), strerror(error));
1183 dpif_close(br->dpif);
1184 ofproto_destroy(br->ofproto);
1185 free(br->controller);
1186 mac_learning_destroy(br->ml);
1187 port_array_destroy(&br->ifaces);
1194 static struct bridge *
1195 bridge_lookup(const char *name)
1199 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
1200 if (!strcmp(br->name, name)) {
1208 bridge_exists(const char *name)
1210 return bridge_lookup(name) ? true : false;
1214 bridge_get_datapathid(const char *name)
1216 struct bridge *br = bridge_lookup(name);
1217 return br ? ofproto_get_datapath_id(br->ofproto) : 0;
1220 /* Handle requests for a listing of all flows known by the OpenFlow
1221 * stack, including those normally hidden. */
1223 bridge_unixctl_dump_flows(struct unixctl_conn *conn,
1224 const char *args, void *aux OVS_UNUSED)
1229 br = bridge_lookup(args);
1231 unixctl_command_reply(conn, 501, "Unknown bridge");
1236 ofproto_get_all_flows(br->ofproto, &results);
1238 unixctl_command_reply(conn, 200, ds_cstr(&results));
1239 ds_destroy(&results);
1243 bridge_run_one(struct bridge *br)
1247 error = ofproto_run1(br->ofproto);
1252 mac_learning_run(br->ml, ofproto_get_revalidate_set(br->ofproto));
1255 error = ofproto_run2(br->ofproto, br->flush);
1261 static const struct ovsrec_controller *
1262 bridge_get_controller(const struct ovsrec_open_vswitch *ovs_cfg,
1263 const struct bridge *br)
1265 const struct ovsrec_controller *controller;
1267 controller = (br->cfg->controller ? br->cfg->controller
1268 : ovs_cfg->controller ? ovs_cfg->controller
1271 if (controller && !strcmp(controller->target, "none")) {
1279 check_duplicate_ifaces(struct bridge *br, struct iface *iface, void *ifaces_)
1281 struct svec *ifaces = ifaces_;
1282 if (!svec_contains(ifaces, iface->name)) {
1283 svec_add(ifaces, iface->name);
1287 VLOG_ERR("bridge %s: %s interface is on multiple ports, "
1289 br->name, iface->name, iface->port->name);
1295 bridge_update_desc(struct bridge *br OVS_UNUSED)
1298 bool changed = false;
1301 desc = cfg_get_string(0, "bridge.%s.mfr-desc", br->name);
1302 if (desc != br->mfr_desc) {
1305 br->mfr_desc = xstrdup(desc);
1307 br->mfr_desc = xstrdup(DEFAULT_MFR_DESC);
1312 desc = cfg_get_string(0, "bridge.%s.hw-desc", br->name);
1313 if (desc != br->hw_desc) {
1316 br->hw_desc = xstrdup(desc);
1318 br->hw_desc = xstrdup(DEFAULT_HW_DESC);
1323 desc = cfg_get_string(0, "bridge.%s.sw-desc", br->name);
1324 if (desc != br->sw_desc) {
1327 br->sw_desc = xstrdup(desc);
1329 br->sw_desc = xstrdup(DEFAULT_SW_DESC);
1334 desc = cfg_get_string(0, "bridge.%s.serial-desc", br->name);
1335 if (desc != br->serial_desc) {
1336 free(br->serial_desc);
1338 br->serial_desc = xstrdup(desc);
1340 br->serial_desc = xstrdup(DEFAULT_SERIAL_DESC);
1345 desc = cfg_get_string(0, "bridge.%s.dp-desc", br->name);
1346 if (desc != br->dp_desc) {
1349 br->dp_desc = xstrdup(desc);
1351 br->dp_desc = xstrdup(DEFAULT_DP_DESC);
1357 ofproto_set_desc(br->ofproto, br->mfr_desc, br->hw_desc,
1358 br->sw_desc, br->serial_desc, br->dp_desc);
1364 bridge_reconfigure_one(const struct ovsrec_open_vswitch *ovs_cfg,
1367 struct shash old_ports, new_ports;
1369 struct svec listeners, old_listeners;
1370 struct svec snoops, old_snoops;
1371 struct shash_node *node;
1374 /* Collect old ports. */
1375 shash_init(&old_ports);
1376 for (i = 0; i < br->n_ports; i++) {
1377 shash_add(&old_ports, br->ports[i]->name, br->ports[i]);
1380 /* Collect new ports. */
1381 shash_init(&new_ports);
1382 for (i = 0; i < br->cfg->n_ports; i++) {
1383 const char *name = br->cfg->ports[i]->name;
1384 if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
1385 VLOG_WARN("bridge %s: %s specified twice as bridge port",
1390 /* If we have a controller, then we need a local port. Complain if the
1391 * user didn't specify one.
1393 * XXX perhaps we should synthesize a port ourselves in this case. */
1394 if (bridge_get_controller(ovs_cfg, br)) {
1395 char local_name[IF_NAMESIZE];
1398 error = dpif_port_get_name(br->dpif, ODPP_LOCAL,
1399 local_name, sizeof local_name);
1400 if (!error && !shash_find(&new_ports, local_name)) {
1401 VLOG_WARN("bridge %s: controller specified but no local port "
1402 "(port named %s) defined",
1403 br->name, local_name);
1407 /* Get rid of deleted ports and add new ports. */
1408 SHASH_FOR_EACH (node, &old_ports) {
1409 if (!shash_find(&new_ports, node->name)) {
1410 port_destroy(node->data);
1413 SHASH_FOR_EACH (node, &new_ports) {
1414 struct port *port = shash_find_data(&old_ports, node->name);
1416 port = port_create(br, node->name);
1418 port_reconfigure(port, node->data);
1420 shash_destroy(&old_ports);
1421 shash_destroy(&new_ports);
1423 /* Check and delete duplicate interfaces. */
1425 iterate_and_prune_ifaces(br, check_duplicate_ifaces, &ifaces);
1426 svec_destroy(&ifaces);
1428 /* Delete all flows if we're switching from connected to standalone or vice
1429 * versa. (XXX Should we delete all flows if we are switching from one
1430 * controller to another?) */
1433 /* Configure OpenFlow management listeners. */
1434 svec_init(&listeners);
1435 cfg_get_all_strings(&listeners, "bridge.%s.openflow.listeners", br->name);
1437 svec_add_nocopy(&listeners, xasprintf("punix:%s/%s.mgmt",
1438 ovs_rundir, br->name));
1439 } else if (listeners.n == 1 && !strcmp(listeners.names[0], "none")) {
1440 svec_clear(&listeners);
1442 svec_sort_unique(&listeners);
1444 svec_init(&old_listeners);
1445 ofproto_get_listeners(br->ofproto, &old_listeners);
1446 svec_sort_unique(&old_listeners);
1448 if (!svec_equal(&listeners, &old_listeners)) {
1449 ofproto_set_listeners(br->ofproto, &listeners);
1451 svec_destroy(&listeners);
1452 svec_destroy(&old_listeners);
1454 /* Configure OpenFlow controller connection snooping. */
1456 cfg_get_all_strings(&snoops, "bridge.%s.openflow.snoops", br->name);
1458 svec_add_nocopy(&snoops, xasprintf("punix:%s/%s.snoop",
1459 ovs_rundir, br->name));
1460 } else if (snoops.n == 1 && !strcmp(snoops.names[0], "none")) {
1461 svec_clear(&snoops);
1463 svec_sort_unique(&snoops);
1465 svec_init(&old_snoops);
1466 ofproto_get_snoops(br->ofproto, &old_snoops);
1467 svec_sort_unique(&old_snoops);
1469 if (!svec_equal(&snoops, &old_snoops)) {
1470 ofproto_set_snoops(br->ofproto, &snoops);
1472 svec_destroy(&snoops);
1473 svec_destroy(&old_snoops);
1475 /* Default listener. */
1476 svec_init(&listeners);
1477 svec_add_nocopy(&listeners, xasprintf("punix:%s/%s.mgmt",
1478 ovs_rundir, br->name));
1479 svec_init(&old_listeners);
1480 ofproto_get_listeners(br->ofproto, &old_listeners);
1481 if (!svec_equal(&listeners, &old_listeners)) {
1482 ofproto_set_listeners(br->ofproto, &listeners);
1484 svec_destroy(&listeners);
1485 svec_destroy(&old_listeners);
1487 /* Default snoop. */
1489 svec_add_nocopy(&snoops, xasprintf("punix:%s/%s.snoop",
1490 ovs_rundir, br->name));
1491 svec_init(&old_snoops);
1492 ofproto_get_snoops(br->ofproto, &old_snoops);
1493 if (!svec_equal(&snoops, &old_snoops)) {
1494 ofproto_set_snoops(br->ofproto, &snoops);
1496 svec_destroy(&snoops);
1497 svec_destroy(&old_snoops);
1500 mirror_reconfigure(br);
1502 bridge_update_desc(br);
1506 bridge_reconfigure_controller(const struct ovsrec_open_vswitch *ovs_cfg,
1509 const struct ovsrec_controller *c;
1511 c = bridge_get_controller(ovs_cfg, br);
1512 if ((br->controller != NULL) != (c != NULL)) {
1513 ofproto_flush_flows(br->ofproto);
1515 free(br->controller);
1516 br->controller = c ? xstrdup(c->target) : NULL;
1519 struct ofproto_controller oc;
1521 if (strcmp(c->target, "discover")) {
1522 struct iface *local_iface;
1525 local_iface = bridge_get_local_iface(br);
1526 if (local_iface && c->local_ip && inet_aton(c->local_ip, &ip)) {
1527 struct netdev *netdev = local_iface->netdev;
1528 struct in_addr mask, gateway;
1530 if (!c->local_netmask || !inet_aton(c->local_netmask, &mask)) {
1533 if (!c->local_gateway
1534 || !inet_aton(c->local_gateway, &gateway)) {
1538 netdev_turn_flags_on(netdev, NETDEV_UP, true);
1540 mask.s_addr = guess_netmask(ip.s_addr);
1542 if (!netdev_set_in4(netdev, ip, mask)) {
1543 VLOG_INFO("bridge %s: configured IP address "IP_FMT", "
1545 br->name, IP_ARGS(&ip.s_addr),
1546 IP_ARGS(&mask.s_addr));
1549 if (gateway.s_addr) {
1550 if (!netdev_add_router(netdev, gateway)) {
1551 VLOG_INFO("bridge %s: configured gateway "IP_FMT,
1552 br->name, IP_ARGS(&gateway.s_addr));
1558 oc.target = c->target;
1559 oc.max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
1560 oc.probe_interval = (c->inactivity_probe
1561 ? *c->inactivity_probe / 1000 : 5);
1562 oc.fail = (!c->fail_mode
1563 || !strcmp(c->fail_mode, "standalone")
1564 || !strcmp(c->fail_mode, "open")
1565 ? OFPROTO_FAIL_STANDALONE
1566 : OFPROTO_FAIL_SECURE);
1567 oc.band = (!c->connection_mode
1568 || !strcmp(c->connection_mode, "in-band")
1570 : OFPROTO_OUT_OF_BAND);
1571 oc.accept_re = c->discover_accept_regex;
1572 oc.update_resolv_conf = c->discover_update_resolv_conf;
1573 oc.rate_limit = (c->controller_rate_limit
1574 ? *c->controller_rate_limit : 0);
1575 oc.burst_limit = (c->controller_burst_limit
1576 ? *c->controller_burst_limit : 0);
1577 ofproto_set_controller(br->ofproto, &oc);
1579 union ofp_action action;
1582 /* Set up a flow that matches every packet and directs them to
1583 * OFPP_NORMAL (which goes to us). */
1584 memset(&action, 0, sizeof action);
1585 action.type = htons(OFPAT_OUTPUT);
1586 action.output.len = htons(sizeof action);
1587 action.output.port = htons(OFPP_NORMAL);
1588 memset(&flow, 0, sizeof flow);
1589 ofproto_add_flow(br->ofproto, &flow, OVSFW_ALL, 0, &action, 1, 0);
1591 ofproto_set_controller(br->ofproto, NULL);
1596 bridge_get_all_ifaces(const struct bridge *br, struct shash *ifaces)
1601 for (i = 0; i < br->n_ports; i++) {
1602 struct port *port = br->ports[i];
1603 for (j = 0; j < port->n_ifaces; j++) {
1604 struct iface *iface = port->ifaces[j];
1605 shash_add_once(ifaces, iface->name, iface);
1607 if (port->n_ifaces > 1 && port->cfg->bond_fake_iface) {
1608 shash_add_once(ifaces, port->name, NULL);
1613 /* For robustness, in case the administrator moves around datapath ports behind
1614 * our back, we re-check all the datapath port numbers here.
1616 * This function will set the 'dp_ifidx' members of interfaces that have
1617 * disappeared to -1, so only call this function from a context where those
1618 * 'struct iface's will be removed from the bridge. Otherwise, the -1
1619 * 'dp_ifidx'es will cause trouble later when we try to send them to the
1620 * datapath, which doesn't support UINT16_MAX+1 ports. */
1622 bridge_fetch_dp_ifaces(struct bridge *br)
1624 struct odp_port *dpif_ports;
1625 size_t n_dpif_ports;
1628 /* Reset all interface numbers. */
1629 for (i = 0; i < br->n_ports; i++) {
1630 struct port *port = br->ports[i];
1631 for (j = 0; j < port->n_ifaces; j++) {
1632 struct iface *iface = port->ifaces[j];
1633 iface->dp_ifidx = -1;
1636 port_array_clear(&br->ifaces);
1638 dpif_port_list(br->dpif, &dpif_ports, &n_dpif_ports);
1639 for (i = 0; i < n_dpif_ports; i++) {
1640 struct odp_port *p = &dpif_ports[i];
1641 struct iface *iface = iface_lookup(br, p->devname);
1643 if (iface->dp_ifidx >= 0) {
1644 VLOG_WARN("%s reported interface %s twice",
1645 dpif_name(br->dpif), p->devname);
1646 } else if (iface_from_dp_ifidx(br, p->port)) {
1647 VLOG_WARN("%s reported interface %"PRIu16" twice",
1648 dpif_name(br->dpif), p->port);
1650 port_array_set(&br->ifaces, p->port, iface);
1651 iface->dp_ifidx = p->port;
1655 int64_t ofport = (iface->dp_ifidx >= 0
1656 ? odp_port_to_ofp_port(iface->dp_ifidx)
1658 ovsrec_interface_set_ofport(iface->cfg, &ofport, 1);
1665 /* Bridge packet processing functions. */
1668 bond_hash(const uint8_t mac[ETH_ADDR_LEN])
1670 return hash_bytes(mac, ETH_ADDR_LEN, 0) & BOND_MASK;
1673 static struct bond_entry *
1674 lookup_bond_entry(const struct port *port, const uint8_t mac[ETH_ADDR_LEN])
1676 return &port->bond_hash[bond_hash(mac)];
1680 bond_choose_iface(const struct port *port)
1682 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1683 size_t i, best_down_slave = -1;
1684 long long next_delay_expiration = LLONG_MAX;
1686 for (i = 0; i < port->n_ifaces; i++) {
1687 struct iface *iface = port->ifaces[i];
1689 if (iface->enabled) {
1691 } else if (iface->delay_expires < next_delay_expiration) {
1692 best_down_slave = i;
1693 next_delay_expiration = iface->delay_expires;
1697 if (best_down_slave != -1) {
1698 struct iface *iface = port->ifaces[best_down_slave];
1700 VLOG_INFO_RL(&rl, "interface %s: skipping remaining %lli ms updelay "
1701 "since no other interface is up", iface->name,
1702 iface->delay_expires - time_msec());
1703 bond_enable_slave(iface, true);
1706 return best_down_slave;
1710 choose_output_iface(const struct port *port, const uint8_t *dl_src,
1711 uint16_t *dp_ifidx, tag_type *tags)
1713 struct iface *iface;
1715 assert(port->n_ifaces);
1716 if (port->n_ifaces == 1) {
1717 iface = port->ifaces[0];
1719 struct bond_entry *e = lookup_bond_entry(port, dl_src);
1720 if (e->iface_idx < 0 || e->iface_idx >= port->n_ifaces
1721 || !port->ifaces[e->iface_idx]->enabled) {
1722 /* XXX select interface properly. The current interface selection
1723 * is only good for testing the rebalancing code. */
1724 e->iface_idx = bond_choose_iface(port);
1725 if (e->iface_idx < 0) {
1726 *tags |= port->no_ifaces_tag;
1729 e->iface_tag = tag_create_random();
1730 ((struct port *) port)->bond_compat_is_stale = true;
1732 *tags |= e->iface_tag;
1733 iface = port->ifaces[e->iface_idx];
1735 *dp_ifidx = iface->dp_ifidx;
1736 *tags |= iface->tag; /* Currently only used for bonding. */
1741 bond_link_status_update(struct iface *iface, bool carrier)
1743 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1744 struct port *port = iface->port;
1746 if ((carrier == iface->enabled) == (iface->delay_expires == LLONG_MAX)) {
1747 /* Nothing to do. */
1750 VLOG_INFO_RL(&rl, "interface %s: carrier %s",
1751 iface->name, carrier ? "detected" : "dropped");
1752 if (carrier == iface->enabled) {
1753 iface->delay_expires = LLONG_MAX;
1754 VLOG_INFO_RL(&rl, "interface %s: will not be %s",
1755 iface->name, carrier ? "disabled" : "enabled");
1756 } else if (carrier && port->active_iface < 0) {
1757 bond_enable_slave(iface, true);
1758 if (port->updelay) {
1759 VLOG_INFO_RL(&rl, "interface %s: skipping %d ms updelay since no "
1760 "other interface is up", iface->name, port->updelay);
1763 int delay = carrier ? port->updelay : port->downdelay;
1764 iface->delay_expires = time_msec() + delay;
1767 "interface %s: will be %s if it stays %s for %d ms",
1769 carrier ? "enabled" : "disabled",
1770 carrier ? "up" : "down",
1777 bond_choose_active_iface(struct port *port)
1779 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20);
1781 port->active_iface = bond_choose_iface(port);
1782 port->active_iface_tag = tag_create_random();
1783 if (port->active_iface >= 0) {
1784 VLOG_INFO_RL(&rl, "port %s: active interface is now %s",
1785 port->name, port->ifaces[port->active_iface]->name);
1787 VLOG_WARN_RL(&rl, "port %s: all ports disabled, no active interface",
1793 bond_enable_slave(struct iface *iface, bool enable)
1795 struct port *port = iface->port;
1796 struct bridge *br = port->bridge;
1798 /* This acts as a recursion check. If the act of disabling a slave
1799 * causes a different slave to be enabled, the flag will allow us to
1800 * skip redundant work when we reenter this function. It must be
1801 * cleared on exit to keep things safe with multiple bonds. */
1802 static bool moving_active_iface = false;
1804 iface->delay_expires = LLONG_MAX;
1805 if (enable == iface->enabled) {
1809 iface->enabled = enable;
1810 if (!iface->enabled) {
1811 VLOG_WARN("interface %s: disabled", iface->name);
1812 ofproto_revalidate(br->ofproto, iface->tag);
1813 if (iface->port_ifidx == port->active_iface) {
1814 ofproto_revalidate(br->ofproto,
1815 port->active_iface_tag);
1817 /* Disabling a slave can lead to another slave being immediately
1818 * enabled if there will be no active slaves but one is waiting
1819 * on an updelay. In this case we do not need to run most of the
1820 * code for the newly enabled slave since there was no period
1821 * without an active slave and it is redundant with the disabling
1823 moving_active_iface = true;
1824 bond_choose_active_iface(port);
1826 bond_send_learning_packets(port);
1828 VLOG_WARN("interface %s: enabled", iface->name);
1829 if (port->active_iface < 0 && !moving_active_iface) {
1830 ofproto_revalidate(br->ofproto, port->no_ifaces_tag);
1831 bond_choose_active_iface(port);
1832 bond_send_learning_packets(port);
1834 iface->tag = tag_create_random();
1837 moving_active_iface = false;
1838 port->bond_compat_is_stale = true;
1841 /* Attempts to make the sum of the bond slaves' statistics appear on the fake
1842 * bond interface. */
1844 bond_update_fake_iface_stats(struct port *port)
1846 struct netdev_stats bond_stats;
1847 struct netdev *bond_dev;
1850 memset(&bond_stats, 0, sizeof bond_stats);
1852 for (i = 0; i < port->n_ifaces; i++) {
1853 struct netdev_stats slave_stats;
1855 if (!netdev_get_stats(port->ifaces[i]->netdev, &slave_stats)) {
1856 bond_stats.rx_packets += slave_stats.rx_packets;
1857 bond_stats.rx_bytes += slave_stats.rx_bytes;
1858 bond_stats.tx_packets += slave_stats.tx_packets;
1859 bond_stats.tx_bytes += slave_stats.tx_bytes;
1863 if (!netdev_open_default(port->name, &bond_dev)) {
1864 netdev_set_stats(bond_dev, &bond_stats);
1865 netdev_close(bond_dev);
1870 bond_run(struct bridge *br)
1874 for (i = 0; i < br->n_ports; i++) {
1875 struct port *port = br->ports[i];
1877 if (port->n_ifaces >= 2) {
1878 for (j = 0; j < port->n_ifaces; j++) {
1879 struct iface *iface = port->ifaces[j];
1880 if (time_msec() >= iface->delay_expires) {
1881 bond_enable_slave(iface, !iface->enabled);
1885 if (port->bond_fake_iface
1886 && time_msec() >= port->bond_next_fake_iface_update) {
1887 bond_update_fake_iface_stats(port);
1888 port->bond_next_fake_iface_update = time_msec() + 1000;
1892 if (port->bond_compat_is_stale) {
1893 port->bond_compat_is_stale = false;
1894 port_update_bond_compat(port);
1900 bond_wait(struct bridge *br)
1904 for (i = 0; i < br->n_ports; i++) {
1905 struct port *port = br->ports[i];
1906 if (port->n_ifaces < 2) {
1909 for (j = 0; j < port->n_ifaces; j++) {
1910 struct iface *iface = port->ifaces[j];
1911 if (iface->delay_expires != LLONG_MAX) {
1912 poll_timer_wait(iface->delay_expires - time_msec());
1915 if (port->bond_fake_iface) {
1916 poll_timer_wait(port->bond_next_fake_iface_update - time_msec());
1922 set_dst(struct dst *p, const flow_t *flow,
1923 const struct port *in_port, const struct port *out_port,
1926 p->vlan = (out_port->vlan >= 0 ? OFP_VLAN_NONE
1927 : in_port->vlan >= 0 ? in_port->vlan
1928 : ntohs(flow->dl_vlan));
1929 return choose_output_iface(out_port, flow->dl_src, &p->dp_ifidx, tags);
1933 swap_dst(struct dst *p, struct dst *q)
1935 struct dst tmp = *p;
1940 /* Moves all the dsts with vlan == 'vlan' to the front of the 'n_dsts' in
1941 * 'dsts'. (This may help performance by reducing the number of VLAN changes
1942 * that we push to the datapath. We could in fact fully sort the array by
1943 * vlan, but in most cases there are at most two different vlan tags so that's
1944 * possibly overkill.) */
1946 partition_dsts(struct dst *dsts, size_t n_dsts, int vlan)
1948 struct dst *first = dsts;
1949 struct dst *last = dsts + n_dsts;
1951 while (first != last) {
1953 * - All dsts < first have vlan == 'vlan'.
1954 * - All dsts >= last have vlan != 'vlan'.
1955 * - first < last. */
1956 while (first->vlan == vlan) {
1957 if (++first == last) {
1962 /* Same invariants, plus one additional:
1963 * - first->vlan != vlan.
1965 while (last[-1].vlan != vlan) {
1966 if (--last == first) {
1971 /* Same invariants, plus one additional:
1972 * - last[-1].vlan == vlan.*/
1973 swap_dst(first++, --last);
1978 mirror_mask_ffs(mirror_mask_t mask)
1980 BUILD_ASSERT_DECL(sizeof(unsigned int) >= sizeof(mask));
1985 dst_is_duplicate(const struct dst *dsts, size_t n_dsts,
1986 const struct dst *test)
1989 for (i = 0; i < n_dsts; i++) {
1990 if (dsts[i].vlan == test->vlan && dsts[i].dp_ifidx == test->dp_ifidx) {
1998 port_trunks_vlan(const struct port *port, uint16_t vlan)
2000 return port->vlan < 0 && bitmap_is_set(port->trunks, vlan);
2004 port_includes_vlan(const struct port *port, uint16_t vlan)
2006 return vlan == port->vlan || port_trunks_vlan(port, vlan);
2010 compose_dsts(const struct bridge *br, const flow_t *flow, uint16_t vlan,
2011 const struct port *in_port, const struct port *out_port,
2012 struct dst dsts[], tag_type *tags, uint16_t *nf_output_iface)
2014 mirror_mask_t mirrors = in_port->src_mirrors;
2015 struct dst *dst = dsts;
2018 if (out_port == FLOOD_PORT) {
2019 /* XXX use ODP_FLOOD if no vlans or bonding. */
2020 /* XXX even better, define each VLAN as a datapath port group */
2021 for (i = 0; i < br->n_ports; i++) {
2022 struct port *port = br->ports[i];
2023 if (port != in_port && port_includes_vlan(port, vlan)
2024 && !port->is_mirror_output_port
2025 && set_dst(dst, flow, in_port, port, tags)) {
2026 mirrors |= port->dst_mirrors;
2030 *nf_output_iface = NF_OUT_FLOOD;
2031 } else if (out_port && set_dst(dst, flow, in_port, out_port, tags)) {
2032 *nf_output_iface = dst->dp_ifidx;
2033 mirrors |= out_port->dst_mirrors;
2038 struct mirror *m = br->mirrors[mirror_mask_ffs(mirrors) - 1];
2039 if (!m->n_vlans || vlan_is_mirrored(m, vlan)) {
2041 if (set_dst(dst, flow, in_port, m->out_port, tags)
2042 && !dst_is_duplicate(dsts, dst - dsts, dst)) {
2046 for (i = 0; i < br->n_ports; i++) {
2047 struct port *port = br->ports[i];
2048 if (port_includes_vlan(port, m->out_vlan)
2049 && set_dst(dst, flow, in_port, port, tags))
2053 if (port->vlan < 0) {
2054 dst->vlan = m->out_vlan;
2056 if (dst_is_duplicate(dsts, dst - dsts, dst)) {
2060 /* Use the vlan tag on the original flow instead of
2061 * the one passed in the vlan parameter. This ensures
2062 * that we compare the vlan from before any implicit
2063 * tagging tags place. This is necessary because
2064 * dst->vlan is the final vlan, after removing implicit
2066 flow_vlan = ntohs(flow->dl_vlan);
2067 if (flow_vlan == 0) {
2068 flow_vlan = OFP_VLAN_NONE;
2070 if (port == in_port && dst->vlan == flow_vlan) {
2071 /* Don't send out input port on same VLAN. */
2079 mirrors &= mirrors - 1;
2082 partition_dsts(dsts, dst - dsts, ntohs(flow->dl_vlan));
2086 static void OVS_UNUSED
2087 print_dsts(const struct dst *dsts, size_t n)
2089 for (; n--; dsts++) {
2090 printf(">p%"PRIu16, dsts->dp_ifidx);
2091 if (dsts->vlan != OFP_VLAN_NONE) {
2092 printf("v%"PRIu16, dsts->vlan);
2098 compose_actions(struct bridge *br, const flow_t *flow, uint16_t vlan,
2099 const struct port *in_port, const struct port *out_port,
2100 tag_type *tags, struct odp_actions *actions,
2101 uint16_t *nf_output_iface)
2103 struct dst dsts[DP_MAX_PORTS * (MAX_MIRRORS + 1)];
2105 const struct dst *p;
2108 n_dsts = compose_dsts(br, flow, vlan, in_port, out_port, dsts, tags,
2111 cur_vlan = ntohs(flow->dl_vlan);
2112 for (p = dsts; p < &dsts[n_dsts]; p++) {
2113 union odp_action *a;
2114 if (p->vlan != cur_vlan) {
2115 if (p->vlan == OFP_VLAN_NONE) {
2116 odp_actions_add(actions, ODPAT_STRIP_VLAN);
2118 a = odp_actions_add(actions, ODPAT_SET_VLAN_VID);
2119 a->vlan_vid.vlan_vid = htons(p->vlan);
2123 a = odp_actions_add(actions, ODPAT_OUTPUT);
2124 a->output.port = p->dp_ifidx;
2128 /* Returns the effective vlan of a packet, taking into account both the
2129 * 802.1Q header and implicitly tagged ports. A value of 0 indicates that
2130 * the packet is untagged and -1 indicates it has an invalid header and
2131 * should be dropped. */
2132 static int flow_get_vlan(struct bridge *br, const flow_t *flow,
2133 struct port *in_port, bool have_packet)
2135 /* Note that dl_vlan of 0 and of OFP_VLAN_NONE both mean that the packet
2136 * belongs to VLAN 0, so we should treat both cases identically. (In the
2137 * former case, the packet has an 802.1Q header that specifies VLAN 0,
2138 * presumably to allow a priority to be specified. In the latter case, the
2139 * packet does not have any 802.1Q header.) */
2140 int vlan = ntohs(flow->dl_vlan);
2141 if (vlan == OFP_VLAN_NONE) {
2144 if (in_port->vlan >= 0) {
2146 /* XXX support double tagging? */
2148 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2149 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %"PRIu16" tagged "
2150 "packet received on port %s configured with "
2151 "implicit VLAN %"PRIu16,
2152 br->name, ntohs(flow->dl_vlan),
2153 in_port->name, in_port->vlan);
2157 vlan = in_port->vlan;
2159 if (!port_includes_vlan(in_port, vlan)) {
2161 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2162 VLOG_WARN_RL(&rl, "bridge %s: dropping VLAN %d tagged "
2163 "packet received on port %s not configured for "
2165 br->name, vlan, in_port->name, vlan);
2175 update_learning_table(struct bridge *br, const flow_t *flow, int vlan,
2176 struct port *in_port)
2178 tag_type rev_tag = mac_learning_learn(br->ml, flow->dl_src,
2179 vlan, in_port->port_idx);
2181 /* The log messages here could actually be useful in debugging,
2182 * so keep the rate limit relatively high. */
2183 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(30,
2185 VLOG_DBG_RL(&rl, "bridge %s: learned that "ETH_ADDR_FMT" is "
2186 "on port %s in VLAN %d",
2187 br->name, ETH_ADDR_ARGS(flow->dl_src),
2188 in_port->name, vlan);
2189 ofproto_revalidate(br->ofproto, rev_tag);
2194 is_bcast_arp_reply(const flow_t *flow)
2196 return (flow->dl_type == htons(ETH_TYPE_ARP)
2197 && flow->nw_proto == ARP_OP_REPLY
2198 && eth_addr_is_broadcast(flow->dl_dst));
2201 /* Determines whether packets in 'flow' within 'br' should be forwarded or
2202 * dropped. Returns true if they may be forwarded, false if they should be
2205 * If 'have_packet' is true, it indicates that the caller is processing a
2206 * received packet. If 'have_packet' is false, then the caller is just
2207 * revalidating an existing flow because configuration has changed. Either
2208 * way, 'have_packet' only affects logging (there is no point in logging errors
2209 * during revalidation).
2211 * Sets '*in_portp' to the input port. This will be a null pointer if
2212 * flow->in_port does not designate a known input port (in which case
2213 * is_admissible() returns false).
2215 * When returning true, sets '*vlanp' to the effective VLAN of the input
2216 * packet, as returned by flow_get_vlan().
2218 * May also add tags to '*tags', although the current implementation only does
2219 * so in one special case.
2222 is_admissible(struct bridge *br, const flow_t *flow, bool have_packet,
2223 tag_type *tags, int *vlanp, struct port **in_portp)
2225 struct iface *in_iface;
2226 struct port *in_port;
2229 /* Find the interface and port structure for the received packet. */
2230 in_iface = iface_from_dp_ifidx(br, flow->in_port);
2232 /* No interface? Something fishy... */
2234 /* Odd. A few possible reasons here:
2236 * - We deleted an interface but there are still a few packets
2237 * queued up from it.
2239 * - Someone externally added an interface (e.g. with "ovs-dpctl
2240 * add-if") that we don't know about.
2242 * - Packet arrived on the local port but the local port is not
2243 * one of our bridge ports.
2245 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2247 VLOG_WARN_RL(&rl, "bridge %s: received packet on unknown "
2248 "interface %"PRIu16, br->name, flow->in_port);
2254 *in_portp = in_port = in_iface->port;
2255 *vlanp = vlan = flow_get_vlan(br, flow, in_port, have_packet);
2260 /* Drop frames for reserved multicast addresses. */
2261 if (eth_addr_is_reserved(flow->dl_dst)) {
2265 /* Drop frames on ports reserved for mirroring. */
2266 if (in_port->is_mirror_output_port) {
2268 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2269 VLOG_WARN_RL(&rl, "bridge %s: dropping packet received on port "
2270 "%s, which is reserved exclusively for mirroring",
2271 br->name, in_port->name);
2276 /* Packets received on bonds need special attention to avoid duplicates. */
2277 if (in_port->n_ifaces > 1) {
2280 if (eth_addr_is_multicast(flow->dl_dst)) {
2281 *tags |= in_port->active_iface_tag;
2282 if (in_port->active_iface != in_iface->port_ifidx) {
2283 /* Drop all multicast packets on inactive slaves. */
2288 /* Drop all packets for which we have learned a different input
2289 * port, because we probably sent the packet on one slave and got
2290 * it back on the other. Broadcast ARP replies are an exception
2291 * to this rule: the host has moved to another switch. */
2292 src_idx = mac_learning_lookup(br->ml, flow->dl_src, vlan);
2293 if (src_idx != -1 && src_idx != in_port->port_idx &&
2294 !is_bcast_arp_reply(flow)) {
2302 /* If the composed actions may be applied to any packet in the given 'flow',
2303 * returns true. Otherwise, the actions should only be applied to 'packet', or
2304 * not at all, if 'packet' was NULL. */
2306 process_flow(struct bridge *br, const flow_t *flow,
2307 const struct ofpbuf *packet, struct odp_actions *actions,
2308 tag_type *tags, uint16_t *nf_output_iface)
2310 struct port *in_port;
2311 struct port *out_port;
2315 /* Check whether we should drop packets in this flow. */
2316 if (!is_admissible(br, flow, packet != NULL, tags, &vlan, &in_port)) {
2321 /* Learn source MAC (but don't try to learn from revalidation). */
2323 update_learning_table(br, flow, vlan, in_port);
2326 /* Determine output port. */
2327 out_port_idx = mac_learning_lookup_tag(br->ml, flow->dl_dst, vlan, tags);
2328 if (out_port_idx >= 0 && out_port_idx < br->n_ports) {
2329 out_port = br->ports[out_port_idx];
2330 } else if (!packet && !eth_addr_is_multicast(flow->dl_dst)) {
2331 /* If we are revalidating but don't have a learning entry then
2332 * eject the flow. Installing a flow that floods packets opens
2333 * up a window of time where we could learn from a packet reflected
2334 * on a bond and blackhole packets before the learning table is
2335 * updated to reflect the correct port. */
2338 out_port = FLOOD_PORT;
2341 /* Don't send packets out their input ports. */
2342 if (in_port == out_port) {
2348 compose_actions(br, flow, vlan, in_port, out_port, tags, actions,
2355 /* Careful: 'opp' is in host byte order and opp->port_no is an OFP port
2358 bridge_port_changed_ofhook_cb(enum ofp_port_reason reason,
2359 const struct ofp_phy_port *opp,
2362 struct bridge *br = br_;
2363 struct iface *iface;
2366 iface = iface_from_dp_ifidx(br, ofp_port_to_odp_port(opp->port_no));
2372 if (reason == OFPPR_DELETE) {
2373 VLOG_WARN("bridge %s: interface %s deleted unexpectedly",
2374 br->name, iface->name);
2375 iface_destroy(iface);
2376 if (!port->n_ifaces) {
2377 VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
2378 br->name, port->name);
2384 if (port->n_ifaces > 1) {
2385 bool up = !(opp->state & OFPPS_LINK_DOWN);
2386 bond_link_status_update(iface, up);
2387 port_update_bond_compat(port);
2393 bridge_normal_ofhook_cb(const flow_t *flow, const struct ofpbuf *packet,
2394 struct odp_actions *actions, tag_type *tags,
2395 uint16_t *nf_output_iface, void *br_)
2397 struct bridge *br = br_;
2399 COVERAGE_INC(bridge_process_flow);
2400 return process_flow(br, flow, packet, actions, tags, nf_output_iface);
2404 bridge_account_flow_ofhook_cb(const flow_t *flow,
2405 const union odp_action *actions,
2406 size_t n_actions, unsigned long long int n_bytes,
2409 struct bridge *br = br_;
2410 const union odp_action *a;
2411 struct port *in_port;
2415 /* Feed information from the active flows back into the learning table
2416 * to ensure that table is always in sync with what is actually flowing
2417 * through the datapath. */
2418 if (is_admissible(br, flow, false, &tags, &vlan, &in_port)) {
2419 update_learning_table(br, flow, vlan, in_port);
2422 if (!br->has_bonded_ports) {
2426 for (a = actions; a < &actions[n_actions]; a++) {
2427 if (a->type == ODPAT_OUTPUT) {
2428 struct port *out_port = port_from_dp_ifidx(br, a->output.port);
2429 if (out_port && out_port->n_ifaces >= 2) {
2430 struct bond_entry *e = lookup_bond_entry(out_port,
2432 e->tx_bytes += n_bytes;
2439 bridge_account_checkpoint_ofhook_cb(void *br_)
2441 struct bridge *br = br_;
2445 if (!br->has_bonded_ports) {
2450 for (i = 0; i < br->n_ports; i++) {
2451 struct port *port = br->ports[i];
2452 if (port->n_ifaces > 1 && now >= port->bond_next_rebalance) {
2453 port->bond_next_rebalance = now + port->bond_rebalance_interval;
2454 bond_rebalance_port(port);
2459 static struct ofhooks bridge_ofhooks = {
2460 bridge_port_changed_ofhook_cb,
2461 bridge_normal_ofhook_cb,
2462 bridge_account_flow_ofhook_cb,
2463 bridge_account_checkpoint_ofhook_cb,
2466 /* Bonding functions. */
2468 /* Statistics for a single interface on a bonded port, used for load-based
2469 * bond rebalancing. */
2470 struct slave_balance {
2471 struct iface *iface; /* The interface. */
2472 uint64_t tx_bytes; /* Sum of hashes[*]->tx_bytes. */
2474 /* All the "bond_entry"s that are assigned to this interface, in order of
2475 * increasing tx_bytes. */
2476 struct bond_entry **hashes;
2480 /* Sorts pointers to pointers to bond_entries in ascending order by the
2481 * interface to which they are assigned, and within a single interface in
2482 * ascending order of bytes transmitted. */
2484 compare_bond_entries(const void *a_, const void *b_)
2486 const struct bond_entry *const *ap = a_;
2487 const struct bond_entry *const *bp = b_;
2488 const struct bond_entry *a = *ap;
2489 const struct bond_entry *b = *bp;
2490 if (a->iface_idx != b->iface_idx) {
2491 return a->iface_idx > b->iface_idx ? 1 : -1;
2492 } else if (a->tx_bytes != b->tx_bytes) {
2493 return a->tx_bytes > b->tx_bytes ? 1 : -1;
2499 /* Sorts slave_balances so that enabled ports come first, and otherwise in
2500 * *descending* order by number of bytes transmitted. */
2502 compare_slave_balance(const void *a_, const void *b_)
2504 const struct slave_balance *a = a_;
2505 const struct slave_balance *b = b_;
2506 if (a->iface->enabled != b->iface->enabled) {
2507 return a->iface->enabled ? -1 : 1;
2508 } else if (a->tx_bytes != b->tx_bytes) {
2509 return a->tx_bytes > b->tx_bytes ? -1 : 1;
2516 swap_bals(struct slave_balance *a, struct slave_balance *b)
2518 struct slave_balance tmp = *a;
2523 /* Restores the 'n_bals' slave_balance structures in 'bals' to sorted order
2524 * given that 'p' (and only 'p') might be in the wrong location.
2526 * This function invalidates 'p', since it might now be in a different memory
2529 resort_bals(struct slave_balance *p,
2530 struct slave_balance bals[], size_t n_bals)
2533 for (; p > bals && p->tx_bytes > p[-1].tx_bytes; p--) {
2534 swap_bals(p, p - 1);
2536 for (; p < &bals[n_bals - 1] && p->tx_bytes < p[1].tx_bytes; p++) {
2537 swap_bals(p, p + 1);
2543 log_bals(const struct slave_balance *bals, size_t n_bals, struct port *port)
2545 if (VLOG_IS_DBG_ENABLED()) {
2546 struct ds ds = DS_EMPTY_INITIALIZER;
2547 const struct slave_balance *b;
2549 for (b = bals; b < bals + n_bals; b++) {
2553 ds_put_char(&ds, ',');
2555 ds_put_format(&ds, " %s %"PRIu64"kB",
2556 b->iface->name, b->tx_bytes / 1024);
2558 if (!b->iface->enabled) {
2559 ds_put_cstr(&ds, " (disabled)");
2561 if (b->n_hashes > 0) {
2562 ds_put_cstr(&ds, " (");
2563 for (i = 0; i < b->n_hashes; i++) {
2564 const struct bond_entry *e = b->hashes[i];
2566 ds_put_cstr(&ds, " + ");
2568 ds_put_format(&ds, "h%td: %"PRIu64"kB",
2569 e - port->bond_hash, e->tx_bytes / 1024);
2571 ds_put_cstr(&ds, ")");
2574 VLOG_DBG("bond %s:%s", port->name, ds_cstr(&ds));
2579 /* Shifts 'hash' from 'from' to 'to' within 'port'. */
2581 bond_shift_load(struct slave_balance *from, struct slave_balance *to,
2584 struct bond_entry *hash = from->hashes[hash_idx];
2585 struct port *port = from->iface->port;
2586 uint64_t delta = hash->tx_bytes;
2588 VLOG_INFO("bond %s: shift %"PRIu64"kB of load (with hash %td) "
2589 "from %s to %s (now carrying %"PRIu64"kB and "
2590 "%"PRIu64"kB load, respectively)",
2591 port->name, delta / 1024, hash - port->bond_hash,
2592 from->iface->name, to->iface->name,
2593 (from->tx_bytes - delta) / 1024,
2594 (to->tx_bytes + delta) / 1024);
2596 /* Delete element from from->hashes.
2598 * We don't bother to add the element to to->hashes because not only would
2599 * it require more work, the only purpose it would be to allow that hash to
2600 * be migrated to another slave in this rebalancing run, and there is no
2601 * point in doing that. */
2602 if (hash_idx == 0) {
2605 memmove(from->hashes + hash_idx, from->hashes + hash_idx + 1,
2606 (from->n_hashes - (hash_idx + 1)) * sizeof *from->hashes);
2610 /* Shift load away from 'from' to 'to'. */
2611 from->tx_bytes -= delta;
2612 to->tx_bytes += delta;
2614 /* Arrange for flows to be revalidated. */
2615 ofproto_revalidate(port->bridge->ofproto, hash->iface_tag);
2616 hash->iface_idx = to->iface->port_ifidx;
2617 hash->iface_tag = tag_create_random();
2621 bond_rebalance_port(struct port *port)
2623 struct slave_balance bals[DP_MAX_PORTS];
2625 struct bond_entry *hashes[BOND_MASK + 1];
2626 struct slave_balance *b, *from, *to;
2627 struct bond_entry *e;
2630 /* Sets up 'bals' to describe each of the port's interfaces, sorted in
2631 * descending order of tx_bytes, so that bals[0] represents the most
2632 * heavily loaded slave and bals[n_bals - 1] represents the least heavily
2635 * The code is a bit tricky: to avoid dynamically allocating a 'hashes'
2636 * array for each slave_balance structure, we sort our local array of
2637 * hashes in order by slave, so that all of the hashes for a given slave
2638 * become contiguous in memory, and then we point each 'hashes' members of
2639 * a slave_balance structure to the start of a contiguous group. */
2640 n_bals = port->n_ifaces;
2641 for (b = bals; b < &bals[n_bals]; b++) {
2642 b->iface = port->ifaces[b - bals];
2647 for (i = 0; i <= BOND_MASK; i++) {
2648 hashes[i] = &port->bond_hash[i];
2650 qsort(hashes, BOND_MASK + 1, sizeof *hashes, compare_bond_entries);
2651 for (i = 0; i <= BOND_MASK; i++) {
2653 if (e->iface_idx >= 0 && e->iface_idx < port->n_ifaces) {
2654 b = &bals[e->iface_idx];
2655 b->tx_bytes += e->tx_bytes;
2657 b->hashes = &hashes[i];
2662 qsort(bals, n_bals, sizeof *bals, compare_slave_balance);
2663 log_bals(bals, n_bals, port);
2665 /* Discard slaves that aren't enabled (which were sorted to the back of the
2666 * array earlier). */
2667 while (!bals[n_bals - 1].iface->enabled) {
2674 /* Shift load from the most-loaded slaves to the least-loaded slaves. */
2675 to = &bals[n_bals - 1];
2676 for (from = bals; from < to; ) {
2677 uint64_t overload = from->tx_bytes - to->tx_bytes;
2678 if (overload < to->tx_bytes >> 5 || overload < 100000) {
2679 /* The extra load on 'from' (and all less-loaded slaves), compared
2680 * to that of 'to' (the least-loaded slave), is less than ~3%, or
2681 * it is less than ~1Mbps. No point in rebalancing. */
2683 } else if (from->n_hashes == 1) {
2684 /* 'from' only carries a single MAC hash, so we can't shift any
2685 * load away from it, even though we want to. */
2688 /* 'from' is carrying significantly more load than 'to', and that
2689 * load is split across at least two different hashes. Pick a hash
2690 * to migrate to 'to' (the least-loaded slave), given that doing so
2691 * must decrease the ratio of the load on the two slaves by at
2694 * The sort order we use means that we prefer to shift away the
2695 * smallest hashes instead of the biggest ones. There is little
2696 * reason behind this decision; we could use the opposite sort
2697 * order to shift away big hashes ahead of small ones. */
2701 for (i = 0; i < from->n_hashes; i++) {
2702 double old_ratio, new_ratio;
2703 uint64_t delta = from->hashes[i]->tx_bytes;
2705 if (delta == 0 || from->tx_bytes - delta == 0) {
2706 /* Pointless move. */
2710 order_swapped = from->tx_bytes - delta < to->tx_bytes + delta;
2712 if (to->tx_bytes == 0) {
2713 /* Nothing on the new slave, move it. */
2717 old_ratio = (double)from->tx_bytes / to->tx_bytes;
2718 new_ratio = (double)(from->tx_bytes - delta) /
2719 (to->tx_bytes + delta);
2721 if (new_ratio == 0) {
2722 /* Should already be covered but check to prevent division
2727 if (new_ratio < 1) {
2728 new_ratio = 1 / new_ratio;
2731 if (old_ratio - new_ratio > 0.1) {
2732 /* Would decrease the ratio, move it. */
2736 if (i < from->n_hashes) {
2737 bond_shift_load(from, to, i);
2738 port->bond_compat_is_stale = true;
2740 /* If the result of the migration changed the relative order of
2741 * 'from' and 'to' swap them back to maintain invariants. */
2742 if (order_swapped) {
2743 swap_bals(from, to);
2746 /* Re-sort 'bals'. Note that this may make 'from' and 'to'
2747 * point to different slave_balance structures. It is only
2748 * valid to do these two operations in a row at all because we
2749 * know that 'from' will not move past 'to' and vice versa. */
2750 resort_bals(from, bals, n_bals);
2751 resort_bals(to, bals, n_bals);
2758 /* Implement exponentially weighted moving average. A weight of 1/2 causes
2759 * historical data to decay to <1% in 7 rebalancing runs. */
2760 for (e = &port->bond_hash[0]; e <= &port->bond_hash[BOND_MASK]; e++) {
2766 bond_send_learning_packets(struct port *port)
2768 struct bridge *br = port->bridge;
2769 struct mac_entry *e;
2770 struct ofpbuf packet;
2771 int error, n_packets, n_errors;
2773 if (!port->n_ifaces || port->active_iface < 0) {
2777 ofpbuf_init(&packet, 128);
2778 error = n_packets = n_errors = 0;
2779 LIST_FOR_EACH (e, struct mac_entry, lru_node, &br->ml->lrus) {
2780 union ofp_action actions[2], *a;
2786 if (e->port == port->port_idx
2787 || !choose_output_iface(port, e->mac, &dp_ifidx, &tags)) {
2791 /* Compose actions. */
2792 memset(actions, 0, sizeof actions);
2795 a->vlan_vid.type = htons(OFPAT_SET_VLAN_VID);
2796 a->vlan_vid.len = htons(sizeof *a);
2797 a->vlan_vid.vlan_vid = htons(e->vlan);
2800 a->output.type = htons(OFPAT_OUTPUT);
2801 a->output.len = htons(sizeof *a);
2802 a->output.port = htons(odp_port_to_ofp_port(dp_ifidx));
2807 compose_benign_packet(&packet, "Open vSwitch Bond Failover", 0xf177,
2809 flow_extract(&packet, 0, ODPP_NONE, &flow);
2810 retval = ofproto_send_packet(br->ofproto, &flow, actions, a - actions,
2817 ofpbuf_uninit(&packet);
2820 static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
2821 VLOG_WARN_RL(&rl, "bond %s: %d errors sending %d gratuitous learning "
2822 "packets, last error was: %s",
2823 port->name, n_errors, n_packets, strerror(error));
2825 VLOG_DBG("bond %s: sent %d gratuitous learning packets",
2826 port->name, n_packets);
2830 /* Bonding unixctl user interface functions. */
2833 bond_unixctl_list(struct unixctl_conn *conn,
2834 const char *args OVS_UNUSED, void *aux OVS_UNUSED)
2836 struct ds ds = DS_EMPTY_INITIALIZER;
2837 const struct bridge *br;
2839 ds_put_cstr(&ds, "bridge\tbond\tslaves\n");
2841 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
2844 for (i = 0; i < br->n_ports; i++) {
2845 const struct port *port = br->ports[i];
2846 if (port->n_ifaces > 1) {
2849 ds_put_format(&ds, "%s\t%s\t", br->name, port->name);
2850 for (j = 0; j < port->n_ifaces; j++) {
2851 const struct iface *iface = port->ifaces[j];
2853 ds_put_cstr(&ds, ", ");
2855 ds_put_cstr(&ds, iface->name);
2857 ds_put_char(&ds, '\n');
2861 unixctl_command_reply(conn, 200, ds_cstr(&ds));
2865 static struct port *
2866 bond_find(const char *name)
2868 const struct bridge *br;
2870 LIST_FOR_EACH (br, struct bridge, node, &all_bridges) {
2873 for (i = 0; i < br->n_ports; i++) {
2874 struct port *port = br->ports[i];
2875 if (!strcmp(port->name, name) && port->n_ifaces > 1) {
2884 bond_unixctl_show(struct unixctl_conn *conn,
2885 const char *args, void *aux OVS_UNUSED)
2887 struct ds ds = DS_EMPTY_INITIALIZER;
2888 const struct port *port;
2891 port = bond_find(args);
2893 unixctl_command_reply(conn, 501, "no such bond");
2897 ds_put_format(&ds, "updelay: %d ms\n", port->updelay);
2898 ds_put_format(&ds, "downdelay: %d ms\n", port->downdelay);
2899 ds_put_format(&ds, "next rebalance: %lld ms\n",
2900 port->bond_next_rebalance - time_msec());
2901 for (j = 0; j < port->n_ifaces; j++) {
2902 const struct iface *iface = port->ifaces[j];
2903 struct bond_entry *be;
2906 ds_put_format(&ds, "slave %s: %s\n",
2907 iface->name, iface->enabled ? "enabled" : "disabled");
2908 if (j == port->active_iface) {
2909 ds_put_cstr(&ds, "\tactive slave\n");
2911 if (iface->delay_expires != LLONG_MAX) {
2912 ds_put_format(&ds, "\t%s expires in %lld ms\n",
2913 iface->enabled ? "downdelay" : "updelay",
2914 iface->delay_expires - time_msec());
2918 for (be = port->bond_hash; be <= &port->bond_hash[BOND_MASK]; be++) {
2919 int hash = be - port->bond_hash;
2920 struct mac_entry *me;
2922 if (be->iface_idx != j) {
2926 ds_put_format(&ds, "\thash %d: %"PRIu64" kB load\n",
2927 hash, be->tx_bytes / 1024);
2930 LIST_FOR_EACH (me, struct mac_entry, lru_node,
2931 &port->bridge->ml->lrus) {
2934 if (bond_hash(me->mac) == hash
2935 && me->port != port->port_idx
2936 && choose_output_iface(port, me->mac, &dp_ifidx, &tags)
2937 && dp_ifidx == iface->dp_ifidx)
2939 ds_put_format(&ds, "\t\t"ETH_ADDR_FMT"\n",
2940 ETH_ADDR_ARGS(me->mac));
2945 unixctl_command_reply(conn, 200, ds_cstr(&ds));
2950 bond_unixctl_migrate(struct unixctl_conn *conn, const char *args_,
2951 void *aux OVS_UNUSED)
2953 char *args = (char *) args_;
2954 char *save_ptr = NULL;
2955 char *bond_s, *hash_s, *slave_s;
2956 uint8_t mac[ETH_ADDR_LEN];
2958 struct iface *iface;
2959 struct bond_entry *entry;
2962 bond_s = strtok_r(args, " ", &save_ptr);
2963 hash_s = strtok_r(NULL, " ", &save_ptr);
2964 slave_s = strtok_r(NULL, " ", &save_ptr);
2966 unixctl_command_reply(conn, 501,
2967 "usage: bond/migrate BOND HASH SLAVE");
2971 port = bond_find(bond_s);
2973 unixctl_command_reply(conn, 501, "no such bond");
2977 if (sscanf(hash_s, ETH_ADDR_SCAN_FMT, ETH_ADDR_SCAN_ARGS(mac))
2978 == ETH_ADDR_SCAN_COUNT) {
2979 hash = bond_hash(mac);
2980 } else if (strspn(hash_s, "0123456789") == strlen(hash_s)) {
2981 hash = atoi(hash_s) & BOND_MASK;
2983 unixctl_command_reply(conn, 501, "bad hash");
2987 iface = port_lookup_iface(port, slave_s);
2989 unixctl_command_reply(conn, 501, "no such slave");
2993 if (!iface->enabled) {
2994 unixctl_command_reply(conn, 501, "cannot migrate to disabled slave");
2998 entry = &port->bond_hash[hash];
2999 ofproto_revalidate(port->bridge->ofproto, entry->iface_tag);
3000 entry->iface_idx = iface->port_ifidx;
3001 entry->iface_tag = tag_create_random();
3002 port->bond_compat_is_stale = true;
3003 unixctl_command_reply(conn, 200, "migrated");
3007 bond_unixctl_set_active_slave(struct unixctl_conn *conn, const char *args_,
3008 void *aux OVS_UNUSED)
3010 char *args = (char *) args_;
3011 char *save_ptr = NULL;
3012 char *bond_s, *slave_s;
3014 struct iface *iface;
3016 bond_s = strtok_r(args, " ", &save_ptr);
3017 slave_s = strtok_r(NULL, " ", &save_ptr);
3019 unixctl_command_reply(conn, 501,
3020 "usage: bond/set-active-slave BOND SLAVE");
3024 port = bond_find(bond_s);
3026 unixctl_command_reply(conn, 501, "no such bond");
3030 iface = port_lookup_iface(port, slave_s);
3032 unixctl_command_reply(conn, 501, "no such slave");
3036 if (!iface->enabled) {
3037 unixctl_command_reply(conn, 501, "cannot make disabled slave active");
3041 if (port->active_iface != iface->port_ifidx) {
3042 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
3043 port->active_iface = iface->port_ifidx;
3044 port->active_iface_tag = tag_create_random();
3045 VLOG_INFO("port %s: active interface is now %s",
3046 port->name, iface->name);
3047 bond_send_learning_packets(port);
3048 unixctl_command_reply(conn, 200, "done");
3050 unixctl_command_reply(conn, 200, "no change");
3055 enable_slave(struct unixctl_conn *conn, const char *args_, bool enable)
3057 char *args = (char *) args_;
3058 char *save_ptr = NULL;
3059 char *bond_s, *slave_s;
3061 struct iface *iface;
3063 bond_s = strtok_r(args, " ", &save_ptr);
3064 slave_s = strtok_r(NULL, " ", &save_ptr);
3066 unixctl_command_reply(conn, 501,
3067 "usage: bond/enable/disable-slave BOND SLAVE");
3071 port = bond_find(bond_s);
3073 unixctl_command_reply(conn, 501, "no such bond");
3077 iface = port_lookup_iface(port, slave_s);
3079 unixctl_command_reply(conn, 501, "no such slave");
3083 bond_enable_slave(iface, enable);
3084 unixctl_command_reply(conn, 501, enable ? "enabled" : "disabled");
3088 bond_unixctl_enable_slave(struct unixctl_conn *conn, const char *args,
3089 void *aux OVS_UNUSED)
3091 enable_slave(conn, args, true);
3095 bond_unixctl_disable_slave(struct unixctl_conn *conn, const char *args,
3096 void *aux OVS_UNUSED)
3098 enable_slave(conn, args, false);
3102 bond_unixctl_hash(struct unixctl_conn *conn, const char *args,
3103 void *aux OVS_UNUSED)
3105 uint8_t mac[ETH_ADDR_LEN];
3109 if (sscanf(args, ETH_ADDR_SCAN_FMT, ETH_ADDR_SCAN_ARGS(mac))
3110 == ETH_ADDR_SCAN_COUNT) {
3111 hash = bond_hash(mac);
3113 hash_cstr = xasprintf("%u", hash);
3114 unixctl_command_reply(conn, 200, hash_cstr);
3117 unixctl_command_reply(conn, 501, "invalid mac");
3124 unixctl_command_register("bond/list", bond_unixctl_list, NULL);
3125 unixctl_command_register("bond/show", bond_unixctl_show, NULL);
3126 unixctl_command_register("bond/migrate", bond_unixctl_migrate, NULL);
3127 unixctl_command_register("bond/set-active-slave",
3128 bond_unixctl_set_active_slave, NULL);
3129 unixctl_command_register("bond/enable-slave", bond_unixctl_enable_slave,
3131 unixctl_command_register("bond/disable-slave", bond_unixctl_disable_slave,
3133 unixctl_command_register("bond/hash", bond_unixctl_hash, NULL);
3136 /* Port functions. */
3138 static struct port *
3139 port_create(struct bridge *br, const char *name)
3143 port = xzalloc(sizeof *port);
3145 port->port_idx = br->n_ports;
3147 port->trunks = NULL;
3148 port->name = xstrdup(name);
3149 port->active_iface = -1;
3151 if (br->n_ports >= br->allocated_ports) {
3152 br->ports = x2nrealloc(br->ports, &br->allocated_ports,
3155 br->ports[br->n_ports++] = port;
3157 VLOG_INFO("created port %s on bridge %s", port->name, br->name);
3164 get_port_other_config(const struct ovsrec_port *port, const char *key,
3165 const char *default_value)
3167 const char *value = get_ovsrec_key_value(key,
3168 port->key_other_config,
3169 port->value_other_config,
3170 port->n_other_config);
3171 return value ? value : default_value;
3175 port_reconfigure(struct port *port, const struct ovsrec_port *cfg)
3177 struct shash old_ifaces, new_ifaces;
3178 long long int next_rebalance;
3179 struct shash_node *node;
3180 unsigned long *trunks;
3186 /* Collect old and new interfaces. */
3187 shash_init(&old_ifaces);
3188 shash_init(&new_ifaces);
3189 for (i = 0; i < port->n_ifaces; i++) {
3190 shash_add(&old_ifaces, port->ifaces[i]->name, port->ifaces[i]);
3192 for (i = 0; i < cfg->n_interfaces; i++) {
3193 const char *name = cfg->interfaces[i]->name;
3194 if (!shash_add_once(&new_ifaces, name, cfg->interfaces[i])) {
3195 VLOG_WARN("port %s: %s specified twice as port interface",
3199 port->updelay = cfg->bond_updelay;
3200 if (port->updelay < 0) {
3203 port->updelay = cfg->bond_downdelay;
3204 if (port->downdelay < 0) {
3205 port->downdelay = 0;
3207 port->bond_rebalance_interval = atoi(
3208 get_port_other_config(cfg, "bond-rebalance-interval", "10000"));
3209 if (port->bond_rebalance_interval < 1000) {
3210 port->bond_rebalance_interval = 1000;
3212 next_rebalance = time_msec() + port->bond_rebalance_interval;
3213 if (port->bond_next_rebalance > next_rebalance) {
3214 port->bond_next_rebalance = next_rebalance;
3217 /* Get rid of deleted interfaces and add new interfaces. */
3218 SHASH_FOR_EACH (node, &old_ifaces) {
3219 if (!shash_find(&new_ifaces, node->name)) {
3220 iface_destroy(node->data);
3223 SHASH_FOR_EACH (node, &new_ifaces) {
3224 const struct ovsrec_interface *if_cfg = node->data;
3225 struct iface *iface;
3227 iface = shash_find_data(&old_ifaces, if_cfg->name);
3229 iface_create(port, if_cfg);
3231 iface->cfg = if_cfg;
3238 if (port->n_ifaces < 2) {
3240 if (vlan >= 0 && vlan <= 4095) {
3241 VLOG_DBG("port %s: assigning VLAN tag %d", port->name, vlan);
3246 /* It's possible that bonded, VLAN-tagged ports make sense. Maybe
3247 * they even work as-is. But they have not been tested. */
3248 VLOG_WARN("port %s: VLAN tags not supported on bonded ports",
3252 if (port->vlan != vlan) {
3254 bridge_flush(port->bridge);
3257 /* Get trunked VLANs. */
3263 trunks = bitmap_allocate(4096);
3265 for (i = 0; i < cfg->n_trunks; i++) {
3266 int trunk = cfg->trunks[i];
3268 bitmap_set1(trunks, trunk);
3274 VLOG_ERR("port %s: invalid values for %zu trunk VLANs",
3275 port->name, cfg->n_trunks);
3277 if (n_errors == cfg->n_trunks) {
3279 VLOG_ERR("port %s: no valid trunks, trunking all VLANs",
3282 bitmap_set_multiple(trunks, 0, 4096, 1);
3285 if (cfg->n_trunks) {
3286 VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
3291 ? port->trunks != NULL
3292 : port->trunks == NULL || !bitmap_equal(trunks, port->trunks, 4096)) {
3293 bridge_flush(port->bridge);
3295 bitmap_free(port->trunks);
3296 port->trunks = trunks;
3298 shash_destroy(&old_ifaces);
3299 shash_destroy(&new_ifaces);
3303 port_destroy(struct port *port)
3306 struct bridge *br = port->bridge;
3310 proc_net_compat_update_vlan(port->name, NULL, 0);
3311 proc_net_compat_update_bond(port->name, NULL);
3313 for (i = 0; i < MAX_MIRRORS; i++) {
3314 struct mirror *m = br->mirrors[i];
3315 if (m && m->out_port == port) {
3320 while (port->n_ifaces > 0) {
3321 iface_destroy(port->ifaces[port->n_ifaces - 1]);
3324 del = br->ports[port->port_idx] = br->ports[--br->n_ports];
3325 del->port_idx = port->port_idx;
3328 bitmap_free(port->trunks);
3335 static struct port *
3336 port_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
3338 struct iface *iface = iface_from_dp_ifidx(br, dp_ifidx);
3339 return iface ? iface->port : NULL;
3342 static struct port *
3343 port_lookup(const struct bridge *br, const char *name)
3347 for (i = 0; i < br->n_ports; i++) {
3348 struct port *port = br->ports[i];
3349 if (!strcmp(port->name, name)) {
3356 static struct iface *
3357 port_lookup_iface(const struct port *port, const char *name)
3361 for (j = 0; j < port->n_ifaces; j++) {
3362 struct iface *iface = port->ifaces[j];
3363 if (!strcmp(iface->name, name)) {
3371 port_update_bonding(struct port *port)
3373 if (port->n_ifaces < 2) {
3374 /* Not a bonded port. */
3375 if (port->bond_hash) {
3376 free(port->bond_hash);
3377 port->bond_hash = NULL;
3378 port->bond_compat_is_stale = true;
3379 port->bond_fake_iface = false;
3382 if (!port->bond_hash) {
3385 port->bond_hash = xcalloc(BOND_MASK + 1, sizeof *port->bond_hash);
3386 for (i = 0; i <= BOND_MASK; i++) {
3387 struct bond_entry *e = &port->bond_hash[i];
3391 port->no_ifaces_tag = tag_create_random();
3392 bond_choose_active_iface(port);
3393 port->bond_next_rebalance
3394 = time_msec() + port->bond_rebalance_interval;
3396 if (port->cfg->bond_fake_iface) {
3397 port->bond_next_fake_iface_update = time_msec();
3400 port->bond_compat_is_stale = true;
3401 port->bond_fake_iface = port->cfg->bond_fake_iface;
3406 port_update_bond_compat(struct port *port)
3408 struct compat_bond_hash compat_hashes[BOND_MASK + 1];
3409 struct compat_bond bond;
3412 if (port->n_ifaces < 2) {
3413 proc_net_compat_update_bond(port->name, NULL);
3418 bond.updelay = port->updelay;
3419 bond.downdelay = port->downdelay;
3422 bond.hashes = compat_hashes;
3423 if (port->bond_hash) {
3424 const struct bond_entry *e;
3425 for (e = port->bond_hash; e <= &port->bond_hash[BOND_MASK]; e++) {
3426 if (e->iface_idx >= 0 && e->iface_idx < port->n_ifaces) {
3427 struct compat_bond_hash *cbh = &bond.hashes[bond.n_hashes++];
3428 cbh->hash = e - port->bond_hash;
3429 cbh->netdev_name = port->ifaces[e->iface_idx]->name;
3434 bond.n_slaves = port->n_ifaces;
3435 bond.slaves = xmalloc(port->n_ifaces * sizeof *bond.slaves);
3436 for (i = 0; i < port->n_ifaces; i++) {
3437 struct iface *iface = port->ifaces[i];
3438 struct compat_bond_slave *slave = &bond.slaves[i];
3439 slave->name = iface->name;
3441 /* We need to make the same determination as the Linux bonding
3442 * code to determine whether a slave should be consider "up".
3443 * The Linux function bond_miimon_inspect() supports four
3444 * BOND_LINK_* states:
3446 * - BOND_LINK_UP: carrier detected, updelay has passed.
3447 * - BOND_LINK_FAIL: carrier lost, downdelay in progress.
3448 * - BOND_LINK_DOWN: carrier lost, downdelay has passed.
3449 * - BOND_LINK_BACK: carrier detected, updelay in progress.
3451 * The function bond_info_show_slave() only considers BOND_LINK_UP
3452 * to be "up" and anything else to be "down".
3454 slave->up = iface->enabled && iface->delay_expires == LLONG_MAX;
3458 netdev_get_etheraddr(iface->netdev, slave->mac);
3461 if (port->bond_fake_iface) {
3462 struct netdev *bond_netdev;
3464 if (!netdev_open_default(port->name, &bond_netdev)) {
3466 netdev_turn_flags_on(bond_netdev, NETDEV_UP, true);
3468 netdev_turn_flags_off(bond_netdev, NETDEV_UP, true);
3470 netdev_close(bond_netdev);
3474 proc_net_compat_update_bond(port->name, &bond);
3479 port_update_vlan_compat(struct port *port)
3481 struct bridge *br = port->bridge;
3482 char *vlandev_name = NULL;
3484 if (port->vlan > 0) {
3485 /* Figure out the name that the VLAN device should actually have, if it
3486 * existed. This takes some work because the VLAN device would not
3487 * have port->name in its name; rather, it would have the trunk port's
3488 * name, and 'port' would be attached to a bridge that also had the
3489 * VLAN device one of its ports. So we need to find a trunk port that
3490 * includes port->vlan.
3492 * There might be more than one candidate. This doesn't happen on
3493 * XenServer, so if it happens we just pick the first choice in
3494 * alphabetical order instead of creating multiple VLAN devices. */
3496 for (i = 0; i < br->n_ports; i++) {
3497 struct port *p = br->ports[i];
3498 if (port_trunks_vlan(p, port->vlan)
3500 && (!vlandev_name || strcmp(p->name, vlandev_name) <= 0))
3502 uint8_t ea[ETH_ADDR_LEN];
3503 netdev_get_etheraddr(p->ifaces[0]->netdev, ea);
3504 if (!eth_addr_is_multicast(ea) &&
3505 !eth_addr_is_reserved(ea) &&
3506 !eth_addr_is_zero(ea)) {
3507 vlandev_name = p->name;
3512 proc_net_compat_update_vlan(port->name, vlandev_name, port->vlan);
3515 /* Interface functions. */
3517 static struct iface *
3518 iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
3520 struct iface *iface;
3521 char *name = if_cfg->name;
3524 iface = xzalloc(sizeof *iface);
3526 iface->port_ifidx = port->n_ifaces;
3527 iface->name = xstrdup(name);
3528 iface->dp_ifidx = -1;
3529 iface->tag = tag_create_random();
3530 iface->delay_expires = LLONG_MAX;
3531 iface->netdev = NULL;
3532 iface->cfg = if_cfg;
3534 if (port->n_ifaces >= port->allocated_ifaces) {
3535 port->ifaces = x2nrealloc(port->ifaces, &port->allocated_ifaces,
3536 sizeof *port->ifaces);
3538 port->ifaces[port->n_ifaces++] = iface;
3539 if (port->n_ifaces > 1) {
3540 port->bridge->has_bonded_ports = true;
3543 /* Attempt to create the network interface in case it
3544 * doesn't exist yet. */
3545 if (!iface_is_internal(port->bridge, iface->name)) {
3546 error = set_up_iface(if_cfg, iface, true);
3548 VLOG_WARN("could not create iface %s: %s", iface->name,
3553 VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
3555 bridge_flush(port->bridge);
3561 iface_destroy(struct iface *iface)
3564 struct port *port = iface->port;
3565 struct bridge *br = port->bridge;
3566 bool del_active = port->active_iface == iface->port_ifidx;
3569 if (iface->dp_ifidx >= 0) {
3570 port_array_set(&br->ifaces, iface->dp_ifidx, NULL);
3573 del = port->ifaces[iface->port_ifidx] = port->ifaces[--port->n_ifaces];
3574 del->port_ifidx = iface->port_ifidx;
3576 netdev_close(iface->netdev);
3579 ofproto_revalidate(port->bridge->ofproto, port->active_iface_tag);
3580 bond_choose_active_iface(port);
3581 bond_send_learning_packets(port);
3587 bridge_flush(port->bridge);
3591 static struct iface *
3592 iface_lookup(const struct bridge *br, const char *name)
3596 for (i = 0; i < br->n_ports; i++) {
3597 struct port *port = br->ports[i];
3598 for (j = 0; j < port->n_ifaces; j++) {
3599 struct iface *iface = port->ifaces[j];
3600 if (!strcmp(iface->name, name)) {
3608 static struct iface *
3609 iface_from_dp_ifidx(const struct bridge *br, uint16_t dp_ifidx)
3611 return port_array_get(&br->ifaces, dp_ifidx);
3614 /* Returns true if 'iface' is the name of an "internal" interface on bridge
3615 * 'br', that is, an interface that is entirely simulated within the datapath.
3616 * The local port (ODPP_LOCAL) is always an internal interface. Other local
3617 * interfaces are created by setting "iface.<iface>.internal = true".
3619 * In addition, we have a kluge-y feature that creates an internal port with
3620 * the name of a bonded port if "bonding.<bondname>.fake-iface = true" is set.
3621 * This feature needs to go away in the long term. Until then, this is one
3622 * reason why this function takes a name instead of a struct iface: the fake
3623 * interfaces created this way do not have a struct iface. */
3625 iface_is_internal(const struct bridge *br, const char *if_name)
3627 /* XXX wastes time */
3628 struct iface *iface;
3631 if (!strcmp(if_name, br->name)) {
3635 iface = iface_lookup(br, if_name);
3636 if (iface && !strcmp(iface->cfg->type, "internal")) {
3640 port = port_lookup(br, if_name);
3641 if (port && port->n_ifaces > 1 && port->cfg->bond_fake_iface) {
3647 /* Set Ethernet address of 'iface', if one is specified in the configuration
3650 iface_set_mac(struct iface *iface)
3652 uint8_t ea[ETH_ADDR_LEN];
3654 if (iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
3655 if (eth_addr_is_multicast(ea)) {
3656 VLOG_ERR("interface %s: cannot set MAC to multicast address",
3658 } else if (iface->dp_ifidx == ODPP_LOCAL) {
3659 VLOG_ERR("ignoring iface.%s.mac; use bridge.%s.mac instead",
3660 iface->name, iface->name);
3662 int error = netdev_set_etheraddr(iface->netdev, ea);
3664 VLOG_ERR("interface %s: setting MAC failed (%s)",
3665 iface->name, strerror(error));
3671 /* Port mirroring. */
3674 mirror_reconfigure(struct bridge *br)
3676 struct shash old_mirrors, new_mirrors;
3677 struct shash_node *node;
3678 unsigned long *rspan_vlans;
3681 /* Collect old mirrors. */
3682 shash_init(&old_mirrors);
3683 for (i = 0; i < MAX_MIRRORS; i++) {
3684 if (br->mirrors[i]) {
3685 shash_add(&old_mirrors, br->mirrors[i]->name, br->mirrors[i]);
3689 /* Collect new mirrors. */
3690 shash_init(&new_mirrors);
3691 for (i = 0; i < br->cfg->n_mirrors; i++) {
3692 struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
3693 if (!shash_add_once(&new_mirrors, cfg->name, cfg)) {
3694 VLOG_WARN("bridge %s: %s specified twice as mirror",
3695 br->name, cfg->name);
3699 /* Get rid of deleted mirrors and add new mirrors. */
3700 SHASH_FOR_EACH (node, &old_mirrors) {
3701 if (!shash_find(&new_mirrors, node->name)) {
3702 mirror_destroy(node->data);
3705 SHASH_FOR_EACH (node, &new_mirrors) {
3706 struct mirror *mirror = shash_find_data(&old_mirrors, node->name);
3708 mirror = mirror_create(br, node->name);
3713 mirror_reconfigure_one(mirror, node->data);
3715 shash_destroy(&old_mirrors);
3716 shash_destroy(&new_mirrors);
3718 /* Update port reserved status. */
3719 for (i = 0; i < br->n_ports; i++) {
3720 br->ports[i]->is_mirror_output_port = false;
3722 for (i = 0; i < MAX_MIRRORS; i++) {
3723 struct mirror *m = br->mirrors[i];
3724 if (m && m->out_port) {
3725 m->out_port->is_mirror_output_port = true;
3729 /* Update flooded vlans (for RSPAN). */
3731 if (br->cfg->n_flood_vlans) {
3732 rspan_vlans = bitmap_allocate(4096);
3734 for (i = 0; i < br->cfg->n_flood_vlans; i++) {
3735 int64_t vlan = br->cfg->flood_vlans[i];
3736 if (vlan >= 0 && vlan < 4096) {
3737 bitmap_set1(rspan_vlans, vlan);
3738 VLOG_INFO("bridge %s: disabling learning on vlan %"PRId64,
3741 VLOG_ERR("bridge %s: invalid value %"PRId64 "for flood VLAN",
3746 if (mac_learning_set_flood_vlans(br->ml, rspan_vlans)) {
3751 static struct mirror *
3752 mirror_create(struct bridge *br, const char *name)
3757 for (i = 0; ; i++) {
3758 if (i >= MAX_MIRRORS) {
3759 VLOG_WARN("bridge %s: maximum of %d port mirrors reached, "
3760 "cannot create %s", br->name, MAX_MIRRORS, name);
3763 if (!br->mirrors[i]) {
3768 VLOG_INFO("created port mirror %s on bridge %s", name, br->name);
3771 br->mirrors[i] = m = xzalloc(sizeof *m);
3774 m->name = xstrdup(name);
3775 shash_init(&m->src_ports);
3776 shash_init(&m->dst_ports);
3786 mirror_destroy(struct mirror *m)
3789 struct bridge *br = m->bridge;
3792 for (i = 0; i < br->n_ports; i++) {
3793 br->ports[i]->src_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
3794 br->ports[i]->dst_mirrors &= ~(MIRROR_MASK_C(1) << m->idx);
3797 shash_destroy(&m->src_ports);
3798 shash_destroy(&m->dst_ports);
3801 m->bridge->mirrors[m->idx] = NULL;
3809 mirror_collect_ports(struct mirror *m, struct ovsrec_port **ports, int n_ports,
3810 struct shash *names)
3814 for (i = 0; i < n_ports; i++) {
3815 const char *name = ports[i]->name;
3816 if (port_lookup(m->bridge, name)) {
3817 shash_add_once(names, name, NULL);
3819 VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
3820 "port %s", m->bridge->name, m->name, name);
3826 mirror_collect_vlans(struct mirror *m, const struct ovsrec_mirror *cfg,
3832 *vlans = xmalloc(sizeof **vlans * cfg->n_select_vlan);
3834 for (i = 0; i < cfg->n_select_vlan; i++) {
3835 int64_t vlan = cfg->select_vlan[i];
3836 if (vlan < 0 || vlan > 4095) {
3837 VLOG_WARN("bridge %s: mirror %s selects invalid VLAN %"PRId64,
3838 m->bridge->name, m->name, vlan);
3840 (*vlans)[n_vlans++] = vlan;
3847 vlan_is_mirrored(const struct mirror *m, int vlan)
3851 for (i = 0; i < m->n_vlans; i++) {
3852 if (m->vlans[i] == vlan) {
3860 port_trunks_any_mirrored_vlan(const struct mirror *m, const struct port *p)
3864 for (i = 0; i < m->n_vlans; i++) {
3865 if (port_trunks_vlan(p, m->vlans[i])) {
3873 mirror_reconfigure_one(struct mirror *m, struct ovsrec_mirror *cfg)
3875 struct shash src_ports, dst_ports;
3876 mirror_mask_t mirror_bit;
3877 struct port *out_port;
3883 /* Get output port. */
3884 if (cfg->output_port) {
3885 out_port = port_lookup(m->bridge, cfg->output_port->name);
3887 VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
3888 m->bridge->name, m->name);
3894 if (cfg->output_vlan) {
3895 VLOG_ERR("bridge %s: mirror %s specifies both output port and "
3896 "output vlan; ignoring output vlan",
3897 m->bridge->name, m->name);
3899 } else if (cfg->output_vlan) {
3901 out_vlan = *cfg->output_vlan;
3903 VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
3904 m->bridge->name, m->name);
3909 shash_init(&src_ports);
3910 shash_init(&dst_ports);
3911 if (cfg->select_all) {
3912 for (i = 0; i < m->bridge->n_ports; i++) {
3913 const char *name = m->bridge->ports[i]->name;
3914 shash_add_once(&src_ports, name, NULL);
3915 shash_add_once(&dst_ports, name, NULL);
3920 /* Get ports, and drop duplicates and ports that don't exist. */
3921 mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
3923 mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
3926 /* Get all the vlans, and drop duplicate and invalid vlans. */
3927 n_vlans = mirror_collect_vlans(m, cfg, &vlans);
3930 /* Update mirror data. */
3931 if (!shash_equal_keys(&m->src_ports, &src_ports)
3932 || !shash_equal_keys(&m->dst_ports, &dst_ports)
3933 || m->n_vlans != n_vlans
3934 || memcmp(m->vlans, vlans, sizeof *vlans * n_vlans)
3935 || m->out_port != out_port
3936 || m->out_vlan != out_vlan) {
3937 bridge_flush(m->bridge);
3939 shash_swap(&m->src_ports, &src_ports);
3940 shash_swap(&m->dst_ports, &dst_ports);
3943 m->n_vlans = n_vlans;
3944 m->out_port = out_port;
3945 m->out_vlan = out_vlan;
3948 mirror_bit = MIRROR_MASK_C(1) << m->idx;
3949 for (i = 0; i < m->bridge->n_ports; i++) {
3950 struct port *port = m->bridge->ports[i];
3952 if (shash_find(&m->src_ports, port->name)
3955 ? port_trunks_any_mirrored_vlan(m, port)
3956 : vlan_is_mirrored(m, port->vlan)))) {
3957 port->src_mirrors |= mirror_bit;
3959 port->src_mirrors &= ~mirror_bit;
3962 if (shash_find(&m->dst_ports, port->name)) {
3963 port->dst_mirrors |= mirror_bit;
3965 port->dst_mirrors &= ~mirror_bit;
3970 shash_destroy(&src_ports);
3971 shash_destroy(&dst_ports);