2 * Copyright (c) 2009, 2010 Nicira Networks.
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at:
8 * http://www.apache.org/licenses/LICENSE-2.0
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
17 /* "White box" tests for classifier.
19 * With very few exceptions, these tests obtain complete coverage of every
20 * basic block and every branch in the classifier implementation, e.g. a clean
21 * report from "gcov -b". (Covering the exceptions would require finding
22 * collisions in the hash function used for flow data, etc.)
24 * This test should receive a clean report from "valgrind --leak-check=full":
25 * it frees every heap block that it allocates.
29 #include "classifier.h"
32 #include "byte-order.h"
33 #include "command-line.h"
41 int aux; /* Auxiliary data. */
42 struct cls_rule cls_rule; /* Classifier rule data. */
45 static struct test_rule *
46 test_rule_from_cls_rule(const struct cls_rule *rule)
48 return rule ? CONTAINER_OF(rule, struct test_rule, cls_rule) : NULL;
51 /* Trivial (linear) classifier. */
54 size_t allocated_rules;
55 struct test_rule **rules;
59 tcls_init(struct tcls *tcls)
62 tcls->allocated_rules = 0;
67 tcls_destroy(struct tcls *tcls)
72 for (i = 0; i < tcls->n_rules; i++) {
80 tcls_count_exact(const struct tcls *tcls)
86 for (i = 0; i < tcls->n_rules; i++) {
87 n_exact += tcls->rules[i]->cls_rule.wc.wildcards == 0;
93 tcls_is_empty(const struct tcls *tcls)
95 return tcls->n_rules == 0;
98 static struct test_rule *
99 tcls_insert(struct tcls *tcls, const struct test_rule *rule)
103 assert(rule->cls_rule.wc.wildcards || rule->cls_rule.priority == UINT_MAX);
104 for (i = 0; i < tcls->n_rules; i++) {
105 const struct cls_rule *pos = &tcls->rules[i]->cls_rule;
106 if (pos->priority == rule->cls_rule.priority
107 && pos->wc.wildcards == rule->cls_rule.wc.wildcards
108 && flow_equal(&pos->flow, &rule->cls_rule.flow)) {
110 * XXX flow_equal should ignore wildcarded fields */
111 free(tcls->rules[i]);
112 tcls->rules[i] = xmemdup(rule, sizeof *rule);
113 return tcls->rules[i];
114 } else if (pos->priority < rule->cls_rule.priority) {
119 if (tcls->n_rules >= tcls->allocated_rules) {
120 tcls->rules = x2nrealloc(tcls->rules, &tcls->allocated_rules,
121 sizeof *tcls->rules);
123 if (i != tcls->n_rules) {
124 memmove(&tcls->rules[i + 1], &tcls->rules[i],
125 sizeof *tcls->rules * (tcls->n_rules - i));
127 tcls->rules[i] = xmemdup(rule, sizeof *rule);
129 return tcls->rules[i];
133 tcls_remove(struct tcls *cls, const struct test_rule *rule)
137 for (i = 0; i < cls->n_rules; i++) {
138 struct test_rule *pos = cls->rules[i];
141 memmove(&cls->rules[i], &cls->rules[i + 1],
142 sizeof *cls->rules * (cls->n_rules - i - 1));
151 read_uint32(const void *p)
154 memcpy(&x, p, sizeof x);
159 match(const struct cls_rule *wild, const struct flow *fixed)
163 for (f_idx = 0; f_idx < CLS_N_FIELDS; f_idx++) {
164 const struct cls_field *f = &cls_fields[f_idx];
165 void *wild_field = (char *) &wild->flow + f->ofs;
166 void *fixed_field = (char *) fixed + f->ofs;
168 if ((wild->wc.wildcards & f->wildcards) == f->wildcards ||
169 !memcmp(wild_field, fixed_field, f->len)) {
170 /* Definite match. */
174 if (wild->wc.wildcards & f->wildcards) {
175 uint32_t test = read_uint32(wild_field);
176 uint32_t ip = read_uint32(fixed_field);
177 int shift = (f_idx == CLS_F_IDX_NW_SRC
178 ? OFPFW_NW_SRC_SHIFT : OFPFW_NW_DST_SHIFT);
179 uint32_t mask = flow_nw_bits_to_mask(wild->wc.wildcards, shift);
180 if (!((test ^ ip) & mask)) {
190 static struct cls_rule *
191 tcls_lookup(const struct tcls *cls, const struct flow *flow, int include)
195 for (i = 0; i < cls->n_rules; i++) {
196 struct test_rule *pos = cls->rules[i];
197 uint32_t wildcards = pos->cls_rule.wc.wildcards;
198 if (include & (wildcards ? CLS_INC_WILD : CLS_INC_EXACT)
199 && match(&pos->cls_rule, flow)) {
200 return &pos->cls_rule;
207 tcls_delete_matches(struct tcls *cls,
208 const struct cls_rule *target,
213 for (i = 0; i < cls->n_rules; ) {
214 struct test_rule *pos = cls->rules[i];
215 uint32_t wildcards = pos->cls_rule.wc.wildcards;
216 if (include & (wildcards ? CLS_INC_WILD : CLS_INC_EXACT)
217 && match(target, &pos->cls_rule.flow)) {
218 tcls_remove(cls, pos);
225 static uint32_t nw_src_values[] = { CONSTANT_HTONL(0xc0a80001),
226 CONSTANT_HTONL(0xc0a04455) };
227 static uint32_t nw_dst_values[] = { CONSTANT_HTONL(0xc0a80002),
228 CONSTANT_HTONL(0xc0a04455) };
229 static uint32_t tun_id_values[] = { 0, 0xffff0000 };
230 static uint16_t in_port_values[] = { CONSTANT_HTONS(1),
231 CONSTANT_HTONS(OFPP_LOCAL) };
232 static uint16_t dl_vlan_values[] = { CONSTANT_HTONS(101), CONSTANT_HTONS(0) };
233 static uint8_t dl_vlan_pcp_values[] = { 7, 0 };
234 static uint16_t dl_type_values[]
235 = { CONSTANT_HTONS(ETH_TYPE_IP), CONSTANT_HTONS(ETH_TYPE_ARP) };
236 static uint16_t tp_src_values[] = { CONSTANT_HTONS(49362),
237 CONSTANT_HTONS(80) };
238 static uint16_t tp_dst_values[] = { CONSTANT_HTONS(6667), CONSTANT_HTONS(22) };
239 static uint8_t dl_src_values[][6] = { { 0x00, 0x02, 0xe3, 0x0f, 0x80, 0xa4 },
240 { 0x5e, 0x33, 0x7f, 0x5f, 0x1e, 0x99 } };
241 static uint8_t dl_dst_values[][6] = { { 0x4a, 0x27, 0x71, 0xae, 0x64, 0xc1 },
242 { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff } };
243 static uint8_t nw_proto_values[] = { IP_TYPE_TCP, IP_TYPE_ICMP };
244 static uint8_t nw_tos_values[] = { 49, 0 };
246 static void *values[CLS_N_FIELDS][2];
251 values[CLS_F_IDX_TUN_ID][0] = &tun_id_values[0];
252 values[CLS_F_IDX_TUN_ID][1] = &tun_id_values[1];
254 values[CLS_F_IDX_IN_PORT][0] = &in_port_values[0];
255 values[CLS_F_IDX_IN_PORT][1] = &in_port_values[1];
257 values[CLS_F_IDX_DL_VLAN][0] = &dl_vlan_values[0];
258 values[CLS_F_IDX_DL_VLAN][1] = &dl_vlan_values[1];
260 values[CLS_F_IDX_DL_VLAN_PCP][0] = &dl_vlan_pcp_values[0];
261 values[CLS_F_IDX_DL_VLAN_PCP][1] = &dl_vlan_pcp_values[1];
263 values[CLS_F_IDX_DL_SRC][0] = dl_src_values[0];
264 values[CLS_F_IDX_DL_SRC][1] = dl_src_values[1];
266 values[CLS_F_IDX_DL_DST][0] = dl_dst_values[0];
267 values[CLS_F_IDX_DL_DST][1] = dl_dst_values[1];
269 values[CLS_F_IDX_DL_TYPE][0] = &dl_type_values[0];
270 values[CLS_F_IDX_DL_TYPE][1] = &dl_type_values[1];
272 values[CLS_F_IDX_NW_SRC][0] = &nw_src_values[0];
273 values[CLS_F_IDX_NW_SRC][1] = &nw_src_values[1];
275 values[CLS_F_IDX_NW_DST][0] = &nw_dst_values[0];
276 values[CLS_F_IDX_NW_DST][1] = &nw_dst_values[1];
278 values[CLS_F_IDX_NW_PROTO][0] = &nw_proto_values[0];
279 values[CLS_F_IDX_NW_PROTO][1] = &nw_proto_values[1];
281 values[CLS_F_IDX_NW_TOS][0] = &nw_tos_values[0];
282 values[CLS_F_IDX_NW_TOS][1] = &nw_tos_values[1];
284 values[CLS_F_IDX_TP_SRC][0] = &tp_src_values[0];
285 values[CLS_F_IDX_TP_SRC][1] = &tp_src_values[1];
287 values[CLS_F_IDX_TP_DST][0] = &tp_dst_values[0];
288 values[CLS_F_IDX_TP_DST][1] = &tp_dst_values[1];
291 #define N_NW_SRC_VALUES ARRAY_SIZE(nw_src_values)
292 #define N_NW_DST_VALUES ARRAY_SIZE(nw_dst_values)
293 #define N_TUN_ID_VALUES ARRAY_SIZE(tun_id_values)
294 #define N_IN_PORT_VALUES ARRAY_SIZE(in_port_values)
295 #define N_DL_VLAN_VALUES ARRAY_SIZE(dl_vlan_values)
296 #define N_DL_VLAN_PCP_VALUES ARRAY_SIZE(dl_vlan_pcp_values)
297 #define N_DL_TYPE_VALUES ARRAY_SIZE(dl_type_values)
298 #define N_TP_SRC_VALUES ARRAY_SIZE(tp_src_values)
299 #define N_TP_DST_VALUES ARRAY_SIZE(tp_dst_values)
300 #define N_DL_SRC_VALUES ARRAY_SIZE(dl_src_values)
301 #define N_DL_DST_VALUES ARRAY_SIZE(dl_dst_values)
302 #define N_NW_PROTO_VALUES ARRAY_SIZE(nw_proto_values)
303 #define N_NW_TOS_VALUES ARRAY_SIZE(nw_tos_values)
305 #define N_FLOW_VALUES (N_NW_SRC_VALUES * \
310 N_DL_VLAN_PCP_VALUES * \
316 N_NW_PROTO_VALUES * \
320 get_value(unsigned int *x, unsigned n_values)
322 unsigned int rem = *x % n_values;
328 compare_classifiers(struct classifier *cls, struct tcls *tcls)
330 static const int confidence = 500;
333 assert(classifier_count(cls) == tcls->n_rules);
334 assert(classifier_count_exact(cls) == tcls_count_exact(tcls));
335 for (i = 0; i < confidence; i++) {
336 struct cls_rule *cr0, *cr1;
341 x = rand () % N_FLOW_VALUES;
342 flow.nw_src = nw_src_values[get_value(&x, N_NW_SRC_VALUES)];
343 flow.nw_dst = nw_dst_values[get_value(&x, N_NW_DST_VALUES)];
344 flow.tun_id = tun_id_values[get_value(&x, N_TUN_ID_VALUES)];
345 flow.in_port = in_port_values[get_value(&x, N_IN_PORT_VALUES)];
346 flow.dl_vlan = dl_vlan_values[get_value(&x, N_DL_VLAN_VALUES)];
347 flow.dl_vlan_pcp = dl_vlan_pcp_values[get_value(&x,
348 N_DL_VLAN_PCP_VALUES)];
349 flow.dl_type = dl_type_values[get_value(&x, N_DL_TYPE_VALUES)];
350 flow.tp_src = tp_src_values[get_value(&x, N_TP_SRC_VALUES)];
351 flow.tp_dst = tp_dst_values[get_value(&x, N_TP_DST_VALUES)];
352 memcpy(flow.dl_src, dl_src_values[get_value(&x, N_DL_SRC_VALUES)],
354 memcpy(flow.dl_dst, dl_dst_values[get_value(&x, N_DL_DST_VALUES)],
356 flow.nw_proto = nw_proto_values[get_value(&x, N_NW_PROTO_VALUES)];
357 flow.nw_tos = nw_tos_values[get_value(&x, N_NW_TOS_VALUES)];
359 for (include = 1; include <= 3; include++) {
360 cr0 = classifier_lookup(cls, &flow, include);
361 cr1 = tcls_lookup(tcls, &flow, include);
362 assert((cr0 == NULL) == (cr1 == NULL));
364 const struct test_rule *tr0 = test_rule_from_cls_rule(cr0);
365 const struct test_rule *tr1 = test_rule_from_cls_rule(cr1);
367 assert(flow_equal(&cr0->flow, &cr1->flow));
368 assert(cr0->wc.wildcards == cr1->wc.wildcards);
369 assert(cr0->priority == cr1->priority);
370 /* Skip nw_src_mask and nw_dst_mask, because they are derived
371 * members whose values are used only for optimization. */
372 assert(tr0->aux == tr1->aux);
379 free_rule(struct cls_rule *cls_rule, void *cls)
381 classifier_remove(cls, cls_rule);
382 free(test_rule_from_cls_rule(cls_rule));
386 destroy_classifier(struct classifier *cls)
388 classifier_for_each(cls, CLS_INC_ALL, free_rule, cls);
389 classifier_destroy(cls);
393 check_tables(const struct classifier *cls,
394 int n_tables, int n_buckets, int n_rules)
396 int found_tables = 0;
397 int found_buckets = 0;
401 BUILD_ASSERT(CLS_N_FIELDS == ARRAY_SIZE(cls->tables));
402 for (i = 0; i < CLS_N_FIELDS; i++) {
403 const struct cls_bucket *bucket;
404 if (!hmap_is_empty(&cls->tables[i])) {
407 HMAP_FOR_EACH (bucket, hmap_node, &cls->tables[i]) {
409 assert(!list_is_empty(&bucket->rules));
410 found_rules += list_size(&bucket->rules);
414 if (!hmap_is_empty(&cls->exact_table)) {
417 found_rules += hmap_count(&cls->exact_table);
420 assert(n_tables == -1 || found_tables == n_tables);
421 assert(n_rules == -1 || found_rules == n_rules);
422 assert(n_buckets == -1 || found_buckets == n_buckets);
425 static struct test_rule *
426 make_rule(int wc_fields, unsigned int priority, int value_pat)
428 const struct cls_field *f;
429 struct test_rule *rule;
434 memset(&flow, 0, sizeof flow);
435 for (f = &cls_fields[0]; f < &cls_fields[CLS_N_FIELDS]; f++) {
436 int f_idx = f - cls_fields;
437 if (wc_fields & (1u << f_idx)) {
438 wildcards |= f->wildcards;
440 int value_idx = (value_pat & (1u << f_idx)) != 0;
441 memcpy((char *) &flow + f->ofs, values[f_idx][value_idx], f->len);
445 rule = xzalloc(sizeof *rule);
446 cls_rule_from_flow(&flow, wildcards, !wildcards ? UINT_MAX : priority,
452 shuffle(unsigned int *p, size_t n)
454 for (; n > 1; n--, p++) {
455 unsigned int *q = &p[rand() % n];
456 unsigned int tmp = *p;
462 /* Tests an empty classifier. */
464 test_empty(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
466 struct classifier cls;
469 classifier_init(&cls);
471 assert(classifier_is_empty(&cls));
472 assert(tcls_is_empty(&tcls));
473 compare_classifiers(&cls, &tcls);
474 classifier_destroy(&cls);
478 /* Destroys a null classifier. */
480 test_destroy_null(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
482 classifier_destroy(NULL);
485 /* Tests classification with one rule at a time. */
487 test_single_rule(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
489 unsigned int wc_fields; /* Hilarious. */
491 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
492 struct classifier cls;
493 struct test_rule *rule, *tcls_rule;
496 rule = make_rule(wc_fields,
497 hash_bytes(&wc_fields, sizeof wc_fields, 0), 0);
499 classifier_init(&cls);
502 tcls_rule = tcls_insert(&tcls, rule);
503 assert(!classifier_insert(&cls, &rule->cls_rule));
504 check_tables(&cls, 1, 1, 1);
505 compare_classifiers(&cls, &tcls);
507 classifier_remove(&cls, &rule->cls_rule);
508 tcls_remove(&tcls, tcls_rule);
509 assert(classifier_is_empty(&cls));
510 assert(tcls_is_empty(&tcls));
511 compare_classifiers(&cls, &tcls);
514 classifier_destroy(&cls);
519 /* Tests replacing one rule by another. */
521 test_rule_replacement(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
523 unsigned int wc_fields;
525 for (wc_fields = 0; wc_fields < (1u << CLS_N_FIELDS); wc_fields++) {
526 struct classifier cls;
527 struct test_rule *rule1;
528 struct test_rule *rule2;
531 rule1 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
532 rule2 = make_rule(wc_fields, OFP_DEFAULT_PRIORITY, UINT_MAX);
536 classifier_init(&cls);
538 tcls_insert(&tcls, rule1);
539 assert(!classifier_insert(&cls, &rule1->cls_rule));
540 check_tables(&cls, 1, 1, 1);
541 compare_classifiers(&cls, &tcls);
545 tcls_insert(&tcls, rule2);
546 assert(test_rule_from_cls_rule(
547 classifier_insert(&cls, &rule2->cls_rule)) == rule1);
549 check_tables(&cls, 1, 1, 1);
550 compare_classifiers(&cls, &tcls);
552 destroy_classifier(&cls);
557 table_mask(int table)
559 return ((1u << CLS_N_FIELDS) - 1) & ~((1u << table) - 1);
563 random_wcf_in_table(int table, int seed)
565 int wc_fields = (1u << table) | hash_int(seed, 0);
566 return wc_fields & table_mask(table);
569 /* Tests classification with two rules at a time that fall into the same
572 test_two_rules_in_one_bucket(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
574 int table, rel_pri, wcf_pat, value_pat;
576 for (table = 0; table <= CLS_N_FIELDS; table++) {
577 for (rel_pri = -1; rel_pri <= +1; rel_pri++) {
578 for (wcf_pat = 0; wcf_pat < 4; wcf_pat++) {
579 int n_value_pats = table == CLS_N_FIELDS - 1 ? 1 : 2;
580 for (value_pat = 0; value_pat < n_value_pats; value_pat++) {
581 struct test_rule *rule1, *tcls_rule1;
582 struct test_rule *rule2, *tcls_rule2;
583 struct test_rule *displaced_rule;
584 struct classifier cls;
586 unsigned int pri1, pri2;
589 if (table != CLS_F_IDX_EXACT) {
590 /* We can use identical priorities in this test because
591 * the classifier always chooses the rule added later
592 * for equal-priority rules that fall into the same
594 pri1 = table * 257 + 50;
595 pri2 = pri1 + rel_pri;
598 ? random_wcf_in_table(table, pri1)
601 ? random_wcf_in_table(table, pri2)
604 wcf1 &= ~(1u << (CLS_N_FIELDS - 1));
605 wcf2 &= ~(1u << (CLS_N_FIELDS - 1));
608 /* This classifier always puts exact-match rules at
609 * maximum priority. */
610 pri1 = pri2 = UINT_MAX;
612 /* No wildcard fields. */
616 rule1 = make_rule(wcf1, pri1, 0);
617 rule2 = make_rule(wcf2, pri2,
618 value_pat << (CLS_N_FIELDS - 1));
620 classifier_init(&cls);
623 tcls_rule1 = tcls_insert(&tcls, rule1);
624 tcls_rule2 = tcls_insert(&tcls, rule2);
625 assert(!classifier_insert(&cls, &rule1->cls_rule));
626 displaced_rule = test_rule_from_cls_rule(
627 classifier_insert(&cls, &rule2->cls_rule));
628 if (wcf1 != wcf2 || pri1 != pri2 || value_pat) {
629 assert(!displaced_rule);
631 check_tables(&cls, 1, 1, 2);
632 compare_classifiers(&cls, &tcls);
634 classifier_remove(&cls, &rule1->cls_rule);
635 tcls_remove(&tcls, tcls_rule1);
636 check_tables(&cls, 1, 1, 1);
637 compare_classifiers(&cls, &tcls);
639 assert(displaced_rule == rule1);
640 check_tables(&cls, 1, 1, 1);
641 compare_classifiers(&cls, &tcls);
645 classifier_remove(&cls, &rule2->cls_rule);
646 tcls_remove(&tcls, tcls_rule2);
647 compare_classifiers(&cls, &tcls);
650 destroy_classifier(&cls);
658 /* Tests classification with two rules at a time that fall into the same
659 * table but different buckets. */
661 test_two_rules_in_one_table(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
663 int table, rel_pri, wcf_pat;
665 /* Skip tables 0 and CLS_F_IDX_EXACT because they have one bucket. */
666 for (table = 1; table < CLS_N_FIELDS; table++) {
667 for (rel_pri = -1; rel_pri <= +1; rel_pri++) {
668 for (wcf_pat = 0; wcf_pat < 5; wcf_pat++) {
669 struct test_rule *rule1, *tcls_rule1;
670 struct test_rule *rule2, *tcls_rule2;
671 struct classifier cls;
673 unsigned int pri1, pri2;
675 int value_mask, value_pat1, value_pat2;
678 /* We can use identical priorities in this test because the
679 * classifier always chooses the rule added later for
680 * equal-priority rules that fall into the same table. */
681 pri1 = table * 257 + 50;
682 pri2 = pri1 + rel_pri;
685 wcf1 = wcf2 = random_wcf_in_table(table, pri1);
688 ? random_wcf_in_table(table, pri1)
691 ? random_wcf_in_table(table, pri2)
695 /* Generate value patterns that will put the two rules into
696 * different buckets. */
697 value_mask = ((1u << table) - 1);
698 value_pat1 = hash_int(pri1, 1) & value_mask;
701 value_pat2 = (hash_int(pri2, i++) & value_mask);
702 } while (value_pat1 == value_pat2);
703 rule1 = make_rule(wcf1, pri1, value_pat1);
704 rule2 = make_rule(wcf2, pri2, value_pat2);
706 classifier_init(&cls);
709 tcls_rule1 = tcls_insert(&tcls, rule1);
710 tcls_rule2 = tcls_insert(&tcls, rule2);
711 assert(!classifier_insert(&cls, &rule1->cls_rule));
712 assert(!classifier_insert(&cls, &rule2->cls_rule));
713 check_tables(&cls, 1, 2, 2);
714 compare_classifiers(&cls, &tcls);
716 classifier_remove(&cls, &rule1->cls_rule);
717 tcls_remove(&tcls, tcls_rule1);
718 check_tables(&cls, 1, 1, 1);
719 compare_classifiers(&cls, &tcls);
722 classifier_remove(&cls, &rule2->cls_rule);
723 tcls_remove(&tcls, tcls_rule2);
724 compare_classifiers(&cls, &tcls);
727 classifier_destroy(&cls);
734 /* Tests classification with two rules at a time that fall into different
737 test_two_rules_in_different_tables(int argc OVS_UNUSED,
738 char *argv[] OVS_UNUSED)
740 int table1, table2, rel_pri, wcf_pat;
742 for (table1 = 0; table1 < CLS_N_FIELDS; table1++) {
743 for (table2 = table1 + 1; table2 <= CLS_N_FIELDS; table2++) {
744 for (rel_pri = 0; rel_pri < 2; rel_pri++) {
745 for (wcf_pat = 0; wcf_pat < 4; wcf_pat++) {
746 struct test_rule *rule1, *tcls_rule1;
747 struct test_rule *rule2, *tcls_rule2;
748 struct classifier cls;
750 unsigned int pri1, pri2;
753 /* We must use unique priorities in this test because the
754 * classifier makes the rule choice undefined for rules of
755 * equal priority that fall into different tables. (In
756 * practice, lower-numbered tables win.) */
757 pri1 = table1 * 257 + 50;
758 pri2 = rel_pri ? pri1 - 1 : pri1 + 1;
761 ? random_wcf_in_table(table1, pri1)
764 ? random_wcf_in_table(table2, pri2)
767 if (table2 == CLS_F_IDX_EXACT) {
772 rule1 = make_rule(wcf1, pri1, 0);
773 rule2 = make_rule(wcf2, pri2, 0);
775 classifier_init(&cls);
778 tcls_rule1 = tcls_insert(&tcls, rule1);
779 tcls_rule2 = tcls_insert(&tcls, rule2);
780 assert(!classifier_insert(&cls, &rule1->cls_rule));
781 assert(!classifier_insert(&cls, &rule2->cls_rule));
782 check_tables(&cls, 2, 2, 2);
783 compare_classifiers(&cls, &tcls);
785 classifier_remove(&cls, &rule1->cls_rule);
786 tcls_remove(&tcls, tcls_rule1);
787 check_tables(&cls, 1, 1, 1);
788 compare_classifiers(&cls, &tcls);
791 classifier_remove(&cls, &rule2->cls_rule);
792 tcls_remove(&tcls, tcls_rule2);
793 compare_classifiers(&cls, &tcls);
796 classifier_destroy(&cls);
804 /* Tests classification with many rules at a time that fall into the same
805 * bucket but have unique priorities (and various wildcards). */
807 test_many_rules_in_one_bucket(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
809 enum { MAX_RULES = 50 };
810 int iteration, table;
812 for (iteration = 0; iteration < 3; iteration++) {
813 for (table = 0; table <= CLS_N_FIELDS; table++) {
814 unsigned int priorities[MAX_RULES];
815 struct classifier cls;
819 srand(hash_int(table, iteration));
820 for (i = 0; i < MAX_RULES; i++) {
821 priorities[i] = i * 129;
823 shuffle(priorities, ARRAY_SIZE(priorities));
825 classifier_init(&cls);
828 for (i = 0; i < MAX_RULES; i++) {
829 struct test_rule *rule;
830 unsigned int priority = priorities[i];
833 wcf = random_wcf_in_table(table, priority);
834 rule = make_rule(wcf, priority,
835 table == CLS_F_IDX_EXACT ? i : 1234);
836 tcls_insert(&tcls, rule);
837 assert(!classifier_insert(&cls, &rule->cls_rule));
838 check_tables(&cls, 1, 1, i + 1);
839 compare_classifiers(&cls, &tcls);
842 destroy_classifier(&cls);
848 /* Tests classification with many rules at a time that fall into the same
849 * table but random buckets. */
851 test_many_rules_in_one_table(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
853 enum { MAX_RULES = 50 };
854 int iteration, table;
856 for (iteration = 0; iteration < 3; iteration++) {
857 for (table = 0; table < CLS_N_FIELDS; table++) {
858 unsigned int priorities[MAX_RULES];
859 struct classifier cls;
863 srand(hash_int(table, iteration));
864 for (i = 0; i < MAX_RULES; i++) {
865 priorities[i] = i * 129;
867 shuffle(priorities, ARRAY_SIZE(priorities));
869 classifier_init(&cls);
872 for (i = 0; i < MAX_RULES; i++) {
873 struct test_rule *rule;
874 unsigned int priority = priorities[i];
877 wcf = random_wcf_in_table(table, priority);
878 rule = make_rule(wcf, priority, hash_int(priority, 1));
879 tcls_insert(&tcls, rule);
880 assert(!classifier_insert(&cls, &rule->cls_rule));
881 check_tables(&cls, 1, -1, i + 1);
882 compare_classifiers(&cls, &tcls);
885 destroy_classifier(&cls);
891 /* Tests classification with many rules at a time that fall into random buckets
892 * in random tables. */
894 test_many_rules_in_different_tables(int argc OVS_UNUSED,
895 char *argv[] OVS_UNUSED)
897 enum { MAX_RULES = 50 };
900 for (iteration = 0; iteration < 30; iteration++) {
901 unsigned int priorities[MAX_RULES];
902 struct classifier cls;
907 for (i = 0; i < MAX_RULES; i++) {
908 priorities[i] = i * 129;
910 shuffle(priorities, ARRAY_SIZE(priorities));
912 classifier_init(&cls);
915 for (i = 0; i < MAX_RULES; i++) {
916 struct test_rule *rule;
917 unsigned int priority = priorities[i];
918 int table = rand() % (CLS_N_FIELDS + 1);
919 int wcf = random_wcf_in_table(table, rand());
920 int value_pat = rand() & ((1u << CLS_N_FIELDS) - 1);
921 rule = make_rule(wcf, priority, value_pat);
922 tcls_insert(&tcls, rule);
923 assert(!classifier_insert(&cls, &rule->cls_rule));
924 check_tables(&cls, -1, -1, i + 1);
925 compare_classifiers(&cls, &tcls);
928 while (!classifier_is_empty(&cls)) {
929 struct test_rule *rule = xmemdup(tcls.rules[rand() % tcls.n_rules],
930 sizeof(struct test_rule));
931 int include = rand() % 2 ? CLS_INC_WILD : CLS_INC_EXACT;
932 include |= (rule->cls_rule.wc.wildcards
933 ? CLS_INC_WILD : CLS_INC_EXACT);
934 classifier_for_each_match(&cls, &rule->cls_rule, include,
936 tcls_delete_matches(&tcls, &rule->cls_rule, include);
937 compare_classifiers(&cls, &tcls);
941 destroy_classifier(&cls);
946 static const struct command commands[] = {
947 {"empty", 0, 0, test_empty},
948 {"destroy-null", 0, 0, test_destroy_null},
949 {"single-rule", 0, 0, test_single_rule},
950 {"rule-replacement", 0, 0, test_rule_replacement},
951 {"two-rules-in-one-bucket", 0, 0, test_two_rules_in_one_bucket},
952 {"two-rules-in-one-table", 0, 0, test_two_rules_in_one_table},
953 {"two-rules-in-different-tables", 0, 0,
954 test_two_rules_in_different_tables},
955 {"many-rules-in-one-bucket", 0, 0, test_many_rules_in_one_bucket},
956 {"many-rules-in-one-table", 0, 0, test_many_rules_in_one_table},
957 {"many-rules-in-different-tables", 0, 0,
958 test_many_rules_in_different_tables},
963 main(int argc, char *argv[])
966 run_command(argc - 1, argv + 1, commands);