1 2007-07-27 Ben Pfaff <blp@gnu.org>
3 * regression.q (run_regression): Move casereader_destroy call so
4 that it always gets called, not just if there was some valid
5 data. Fixes bug #19581.
6 Reviewed by Jason Stover.
8 2007-07-24 Ben Pfaff <blp@gnu.org>
10 * flip.c (struct flip_pgm): Remove `case_size' member (now
12 (cmd_flip): Pass var_cnt as number of cases instead of case_cnt,
13 to fix bug #20494. Don't assign to `case_size' member, which was
14 unused after assignment.
15 (build_dictionary): When NEWNAMES not used, get the number of
16 variables right, to fix bug #20493.
18 2007-07-10 Jason Stover <jhs@math.gcsu.edu>
20 * glm.q: Initial version of the GLM procedure.
22 2007-06-06 Ben Pfaff <blp@gnu.org>
24 Adapt case sources, sinks, and clients of procedure code to the
27 * aggregate.c: Simplify greatly since everything is more uniform
30 * autorecode.c: Adapt to new procedure code.
34 * descriptives.c: Ditto.
36 * npar-summary.c: Ditto.
37 * frequencies.q: Ditto.
40 * regression.q: Ditto.
41 * sort-cases.c: Ditto.
44 * sort-criteria.c: Rewrite to output a struct case_ordering.
46 * flip.c: Rewrite to be a casereader.
48 * rank.q: Simplify greatly since casereaders are much more
49 flexible than what we had before.
51 2007-05-15 Jason Stover <jhs@math.gcsu.edu>
53 * regression.q (run_regression): Tell the user when the data
54 contain no valid cases.
56 2007-05-08 Jason Stover <jhs@math.gcsu.edu>
58 * regression.q: Partial fix of bug which caused a crash if
59 dependent variable and independent variable were the same.
61 2007-04-16 John Darrington <john@darrington.wattle.id.au>
63 * t-test.q: Changed the output width of reported counts and
64 degrees of freedom, to avoid truncating these values. Thanks
65 to Seth Woolley for reporting this problem. A proper fix involves
66 re-thinking the output driver.
68 2007-04-12 Jason Stover <jhs@math.gcsu.edu>
70 * regression.q (run_regression): Added if (n_data >0) to fix bug
73 2007-03-29 Jason Stover <jhs@math.gcsu.edu>
75 * regression.q (prepare_data): New function.
77 * regression.q (compute_moments): New function.
79 2007-03-18 Ben Pfaff <blp@gnu.org>
81 * crosstabs.q (static var write): Rename write_style to avoid
82 conflict with POSIX function of same name.
84 2007-03-16 Jason Stover <jhs@math.gcsu.edu>
86 * regression.q (run_regression): Added support for moments.
88 Sat Feb 17 08:16:00 2007 Ben Pfaff <blp@gnu.org>
90 * flip.c (flip_sink_create): Improve error message when temporary
91 file cannot be created.
93 Tue Feb 6 19:58:03 2007 Ben Pfaff <blp@gnu.org>
95 * flip.c (flip_file): Give better error message on end-of-file.
97 2007-02-04 Jason Stover <jhs@math.gcsu.edu>
99 * regression.q: Fixed p-value computation in the test for
100 individual regression coefficients.
102 Mon Jan 15 11:03:20 2007 Ben Pfaff <blp@gnu.org>
104 Fix bugs found by valgrind when --enable-debug is used with the
105 new case code. These bugs are hidden when the data set is small
106 enough to find in memory; if a bigger data set that would overflow
107 to disk were used, then data corruption would occur.
109 * chisquare.c (create_freq_hash): Pass free_freq_mutable_hash to
110 hsh_create as free function. Make copy of data put into hash.
112 * oneway.q (free_value): New function.
113 (run_oneway): Use free_value as arg to hsh_create. Make copy of
116 * rank.q (rank_cases): Don't access data in case after we've given
119 Tue Jan 9 19:16:11 2007 Ben Pfaff <blp@gnu.org>
123 * aggregate.c (parse_aggregate_functions) Initialize
126 Fri Dec 22 14:04:09 2006 Ben Pfaff <blp@gnu.org>
128 Simplify missing value handling.
130 * aggregate.c (struct agr_var): Remove `bool include_missing', add
131 `enum mv_class exclude'. Remove `int missing', add `bool
132 saw_missing'. Update users.
134 * descriptives.c (struct dsc_trns): Removed `int
135 include_user_missing', add `enum mv_class exclude'. Update users.
136 (struct dsc_proc): Ditto.
138 * examine.q: (static var value_is_missing): Rename
139 `exclude_values', change type to `enum mv_class'. Update users.
143 Fri Dec 22 19:22:18 WST 2006 John Darrington <john@darrington.wattle.id.au>
145 * frequencies.q : Fixed bug #17420, where the table bounds were overun
146 when /FORMAT=nolabels was given.
148 Wed Dec 20 18:45:31 WST 2006 John Darrington <john@darrington.wattle.id.au>
150 * binomial.c binomial.h : New files. Thanks to Jason Stover
151 for assistance with these.
153 * chisquare.c chisquare.h freq.c freq.h npar-summary.c npar-summary.h
154 npar.h npar.q: New files. Implementing NPAR TESTS.
156 * frequencies.q : Moved structure definitions into freq.[ch]
158 Sat Dec 16 22:26:44 2006 Ben Pfaff <blp@gnu.org>
160 Make it possible to pull cases from the active file with a
161 function call, instead of requiring indirection through a callback
164 * aggregate.c (cmd_aggregate): Take advantage of new procedure
166 (agr_to_active_file): Removed.
167 (presorted_agr_to_sysfile): Removed.
169 * autorecode.c (cmd_autorecode): Take advantage of new procedure
171 (autorecode_proc_func): Removed.
173 * flip.c (struct flip_pgm): New members to allow conformance with
174 new case_source_class interface.
175 (cmd_flip): Adapt to new case_source_class interface.
176 (flip_source_read): Ditto.
177 (flip_source_destroy): Ditto.
179 Sat Dec 16 12:54:27 2006 Ben Pfaff <blp@gnu.org>
181 * rank.q (rank_custom_variables): Allow grouping variables to be
182 strings. Fixes bug #18533. Thanks to John Darrington for review.
184 Sat Dec 9 18:47:51 2006 Ben Pfaff <blp@gnu.org>
186 * regression.q (is_depvar): Compare variable pointers instead of
189 Thu Dec 7 15:26:25 WST 2006 John Darrington <john@darrington.wattle.id.au>
191 * examine.q: Allocated the categorical values for the dependent and
192 independent variables, on the heap. Hence they can be of any width.
194 Wed Dec 6 21:14:26 2006 Ben Pfaff <blp@gnu.org>
196 * regression.q (reg_inserted): Compare variable pointers instead
199 Mon Dec 4 22:33:46 2006 Ben Pfaff <blp@gnu.org>
201 * crosstabs.q (insert_summary): Use var_to_string for labeling.
202 (output_pivot_table) Ditto.
205 * frequencies.q (setup_z_trns): Ditto.
207 (dump_condensed) Ditto.
208 (dump_statistics) Ditto.
211 Sun Nov 5 08:31:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
213 * t-test.q, oneway.q: Changed to use the new casefilter structure.
215 Sat Oct 14 16:52:28 2006 Ben Pfaff <blp@gnu.org>
217 * rank.q: (rank_sorted_casefile) Add some missing case_destroy()
218 calls to fix a memory leak.
220 Sun Oct 8 09:45:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
222 * rank.q: Plugged a small memory leak which occurred under error
225 Sat Oct 7 11:06:01 WST 2006 John Darrington <john@darrington.wattle.id.au>
227 * rank.q: Implemented most of the RANK command.
229 2006-07-14 Jason Stover <jhs@math.gcsu.edu>
231 * regression.q (run_regression): New function to move knowledge of
232 pspp_linreg_cache out of math/coefficient.[ch].
234 Sat Jul 1 17:41:46 2006 Ben Pfaff <blp@gnu.org>
236 Fix bug #11612, "q2c documentation does not agree with code".
238 * examine.q: Audit use of q2c "+" prefixes that indicate that a
239 command may appear multiple times.
241 * frequencies.q: Ditto.
245 * regression.q: Ditto.
249 Fri Jun 23 14:18:22 2006 Ben Pfaff <blp@gnu.org>
251 Support long string variables on FREQUENCIES, as
252 an extension when in enhanced algorithms mode. For Greg Hunt
253 <greg@firmansyah.com>.
255 * frequencies.q: (struct freq) Change `v' member from union value
256 to union value *. Update all references.
257 (struct var_freqs) Add width, print members to represent effective
258 variable width and display format.
259 (calc) Copy entire long string value into the hash table.
260 (frq_custom_variables) Set new width, print members.
261 (hash_value_alpha) Get width from var_freqs.
262 (compare_value_alpha_a) Ditto.
263 (compare_freq_alpha_a) Ditto.
264 (compare_freq_alpha_d) Ditto.
265 (dump_full) Get display format from var_freqs.
266 (dump_condensed) Ditto.
268 Mon Jun 19 22:07:13 2006 Ben Pfaff <blp@gnu.org>
270 * frequencies.q: (dump_full) Only put the first MAX_SHORT_STRING
271 bytes of string variables into the output cells, seeing as we only
273 (dump_condensed) Ditto.
275 Mon Jun 19 21:52:05 2006 Ben Pfaff <blp@gnu.org>
277 Fixes a bug reported by Greg Hunt <greg@firmansyah.com>.
279 * frequencies.q: (hsh_hash_bytes) We only copy the first
280 MAX_SHORT_STRING bytes of string variables, so we must only
281 compare that many bytes, even if the string variable is longer.
282 (compare_value_alpha_a) Ditto.
283 (compare_freq_alpha_a) Ditto.
284 (compare_freq_alpha_d) Ditto.
286 2006-05-11 Jason Stover <jhs@math.gcsu.edu>
288 * regression.q: Adjusted code to account for cache->coeff being a
289 pspp_linreg_coeff **.
291 Sun May 7 18:31:25 2006 Ben Pfaff <blp@gnu.org>
295 * aggregate.c (cmd_aggregate): Free default_dict before replacing
298 Sun May 7 17:09:19 2006 Ben Pfaff <blp@gnu.org>
300 * flip.c (flip_file): Check return value of pool_fclose().
302 Sat May 6 16:00:13 2006 Ben Pfaff <blp@gnu.org>
304 Get rid of `char *c' member in union value, for cleanliness.
306 * aggregate.c: (union agr_argument) New union.
307 (struct agr_var) Change element type of arg[] from union value to
309 (parse_aggregate_functions) Change local variable types likewise.
311 * autorecode.c: (union arc_value) New union.
312 (struct arc_item) Change "from" from union value to union
314 (recode) Change local variable from union value to union
316 (autorecode_trns_proc) Ditto.
317 (compare_alpha_value) Ditto.
318 (hash_alpha_value) Ditto.
319 (compare_numeric_value) Ditto.
320 (hash_numeric_value) Ditto.
321 (autorecode_proc_func) Ditto.
323 Sat May 6 10:43:33 2006 Ben Pfaff <blp@gnu.org>
325 Continue reforming procedure execution. In this phase, get rid of
326 the output code for SPLIT FILE groups in procedure.c, which really
327 shouldn't be doing any output. Move it into the individual
328 procedures instead. This also adds some flexibility.
330 * crosstabs.q (precalc): Call output_split_file_values().
332 * descriptives.c (calc_descriptives): Ditto.
334 * examine.q (run_examine): Ditto.
336 * frequencies.q (precalc): Ditto.
338 * oneway.q (run_oneway): Ditto.
340 * regression.q (run_regression): Ditto.
342 * t-test.q (calculate): Ditto.
344 Wed May 3 23:05:31 2006 Ben Pfaff <blp@gnu.org>
346 Continue reforming procedure execution. In this phase, get rid of
347 many global variables, consolidating procedure execution in
348 procedure.c. Encapsulate transformations in new "struct
349 trns_chain". Also, change implementation of N OF CASES, FILTER,
350 and PROCESS IF from special cases to transformations.
352 * aggregate.c (cmd_aggregate) Use discard_variables().
354 2006-04-28 Jason Stover <jhs@math.gcsu.edu>
356 * regression.q (regression_trns_resid_proc): Pass only the
357 variables used in the model to (*model->residual)().
359 * regression.q (regression_trns_pred_proc): Pass only the
360 variables used in the model to (*model->pred)().
362 2006-04-26 Jason Stover <jhs@math.gcsu.edu>
364 * regression.q: Added support for multiple transformations.
366 * regression.q (regression_trns_resid_proc): New function.
368 * regression.q (regression_trns_pred_proc): New function.
370 * regression.q (subcommand_save): Added support for saving
373 * regression.q (regression_trns_free): New function.
375 * regression.q (reg_get_name): New function.
377 * regression.q (reg_save_var): New function.
379 Tue Apr 25 13:18:56 2006 Ben Pfaff <blp@gnu.org>
381 * rank.q (parse_rank_function): Use SE instead of ME for parse
384 Tue Apr 25 13:16:28 2006 Ben Pfaff <blp@gnu.org>
386 * flip.c (flip_sink_write): Use snprintf() to simplify a bit of
389 2006-04-21 Jason Stover <jhs@math.gcsu.edu>
391 * regression.q (try_name): New function. (Partly copied from
392 try_name in descriptives.c.)
394 * regression.q (subcommand_save): Choose residual variable names
397 2006-04-20 Jason Stover <jhs@math.gcsu.edu>
399 * regression.q (cmd_regression): Moved call to subcommand_save()
400 outside multipass_procedure_with_splits().
402 * regression.q (regression_trns_proc): Fixed value counter n_vals
403 before calling *model->residual().
405 2006-04-19 Jason Stover <jhs@math.gcsu.edu>
407 * regression.q (regression_trns_proc): Fixed the look-up of the
410 2006-04-18 Jason Stover <jhs@math.gcsu.edu>
412 * regression.q (regression_trns_proc): Look up the residual
413 variable in the linear regression cache.
415 * regression.q (subcommand_save): Set the residual variable in the
416 linear regression cache.
418 2006-04-17 Jason Stover <jason@wonko.gcsu.edu>
420 * regression.q (regression_trns_proc): Accept case_idx as an int
421 to match the definition of trns_proc_func.
423 2006-04-17 Jason Stover <jhs@math.gcsu.edu>
425 * regression.q (regression_trns_proc): New function.
427 * regression.q (subcommand_save): Create variable residuals and
428 add a transformation to assign values to them. Also free the
429 linreg_cache if the SAVE command was not called. Removed the
430 casereading loop. Placed actual computation of residuals in
431 regression_trns_proc.
433 * regression.q (run_regression): Moved call to free
434 pspp_linreg_cache to subcommand_save.
436 Sat Apr 15 18:01:03 2006 Ben Pfaff <blp@gnu.org>
438 * examine.q (output_examine): Add casts to fix warnings.
440 2006-04-07 Jason Stover <jhs@math.gcsu.edu>
442 * regression.q (subcommand_save): New function.
444 2006-04-04 Jason Stover <jhs@math.gcsu.edu>
446 * regression.q: New function reg_has_categorical () to tell
447 whether a pspp_linreg_struct was made with any variables of type
450 * regression.q: (subcommand_export): Call
451 reg_print_categorical_encoding() only if the model uses any
452 categorical variables.
454 Mon Mar 27 16:00:42 2006 Ben Pfaff <blp@gnu.org>
456 * crosstabs.q: (output_pivot_table) Drop spurious space from
459 2006-03-15 Jason Stover <jhs@math.gcsu.edu>
461 * regression.q: Added custom syntax parser for VARIABLES subcommand
463 * regression.q: Moved most instructions for run_regression ()
464 inside the loop over dependent variables.
466 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
468 * Moved files from src directory