1 2007-11-03 Ben Pfaff <blp@gnu.org>
3 Allow output files to overwrite input files (bug #21280).
5 * aggregate.c (cmd_aggregate): Manage file handle reference
8 * correlations.q (internal_cmd_frequencies): Ditto.
9 (cor_custom_matrix): Ditto.
11 * regression.q (regression_custom_export): Ditto.
12 (cmd_regression): Ditto.
14 2007-10-12 Ben Pfaff <blp@gnu.org>
16 * flip.c (flip_file): No need to conditionally substitute for
17 "fseeko" and "off_t" manually anymore, as gnulib takes care of it
20 2007-09-21 Jason Stover <jhs@wonko.gcsu.edu>
22 * regression.q (run_regression): Partial fix of memory leak, bug
25 2007-09-19 Ben Pfaff <blp@gnu.org>
29 * aggregate.c (cmd_aggregate): Destroy casereader consistently,
30 even if casereader fails.
32 * examine.q (run_examine): Ditto.
34 * glm.q (run_glm): Ditto.
36 * oneway.q (run_oneway): Ditto.
38 * regression.q (run_regression): Ditto.
40 * t-test.q (calculate): Ditto.
42 * descriptives.c (calc_descriptives): Ditto. Also avoid
43 gratuitous casereader_clone.
45 2007-09-13 Jason Stover <jhs@debs.hoobahooba.net>
47 * regression.q (cmd_regression): Move declaration of models in to
48 definition of cmd_regression.
50 * regression.q (run_regression): Free mom to fix memory leak.
52 2007-09-12 Ben Pfaff <blp@gnu.org>
54 * crosstabs.q (postcalc): Free sorted_tab and the structures that
55 it points to, to plug a memory leak. Fixes bug #20910. Thanks to
56 John Darrington for reporting this bug and for review.
58 2007-09-04 Ben Pfaff <blp@gnu.org>
60 * crosstabs.q (cmd_crosstabs): Free xtab and the structures that
61 it points to, to plug a memory leak. Fixes bug #18315.
63 2007-08-15 Jason Stover <jhs@wonko.gcsu.edu>
65 * regression.q (identify_indep_vars): Print an error if dependent
66 and independent variables are the same. Fixes bug 19819.
68 2007-08-12 Ben Pfaff <blp@gnu.org>
70 * flip.c: Drop use of dict_get_compacted_dict_index_to_case_index
71 and just use the ordinary case indexes. There seemed to be no
72 reason for the former method.
74 2007-08-03 Ben Pfaff <blp@gnu.org>
76 * rank.q (rank_cmd): Instead of sorting by SPLIT FILE vars, group
77 by them. Fixes bug #17239.
78 Reviewed by John Darrington.
80 2007-08-01 Ben Pfaff <blp@gnu.org>
82 Clean up handling of median, by treating it almost like any other
83 percentile. Fixes bug #17424. Thanks to John Darrington for
85 * frequencies.q (internal_cmd_frequencies): Fix handling of bit
86 masks for `stats' variable. If median is selected, turn it off
87 and add a 50th percentile.
88 (add_percentile): Simplify code a little.
89 (calc_stats): Drop special casing of median.
90 (dump_statistics): Ditto, except that we label the 50th percentile
91 as "50 (Median)" to make it clear that it's also the median.
93 2007-07-31 Ben Pfaff <blp@gnu.org>
95 Remove integer mode from FREQUENCIES and incidentally fix bug
96 #17421. Reviewed by John Darrington.
97 * frequencies.q (int_pool): Rename data_pool.
98 (gen_pool): Rename syntax_pool.
99 (enum FRQM_*): Removed.
100 (struct freq_tab): Removed `mode', `vector', `min', `max',
101 `out_of_range', `sysmis' members.
102 (calc): Delete support for integer mode.
104 (postprocess_freq_tab): Ditto.
105 (cleanup_freq_tab): Ditto.
106 (frq_custom_variables): Ditto.
108 2007-07-28 John Darrington <john@darrington.wattle.id.au>
110 * t-test.q: Moved the order in which groups are displayed in the
111 independent samples case, where a cut point is given.
113 2007-07-27 Ben Pfaff <blp@gnu.org>
115 * regression.q (run_regression): Move casereader_destroy call so
116 that it always gets called, not just if there was some valid
117 data. Fixes bug #19581.
118 Reviewed by Jason Stover.
120 2007-07-24 Ben Pfaff <blp@gnu.org>
122 * flip.c (struct flip_pgm): Remove `case_size' member (now
124 (cmd_flip): Pass var_cnt as number of cases instead of case_cnt,
125 to fix bug #20494. Don't assign to `case_size' member, which was
126 unused after assignment.
127 (build_dictionary): When NEWNAMES not used, get the number of
128 variables right, to fix bug #20493.
130 2007-07-10 Jason Stover <jhs@math.gcsu.edu>
132 * glm.q: Initial version of the GLM procedure.
134 2007-06-06 Ben Pfaff <blp@gnu.org>
136 Adapt case sources, sinks, and clients of procedure code to the
139 * aggregate.c: Simplify greatly since everything is more uniform
142 * autorecode.c: Adapt to new procedure code.
144 * chisquare.c: Ditto.
145 * crosstabs.q: Ditto.
146 * descriptives.c: Ditto.
148 * npar-summary.c: Ditto.
149 * frequencies.q: Ditto.
152 * regression.q: Ditto.
153 * sort-cases.c: Ditto.
156 * sort-criteria.c: Rewrite to output a struct case_ordering.
158 * flip.c: Rewrite to be a casereader.
160 * rank.q: Simplify greatly since casereaders are much more
161 flexible than what we had before.
163 2007-05-15 Jason Stover <jhs@math.gcsu.edu>
165 * regression.q (run_regression): Tell the user when the data
166 contain no valid cases.
168 2007-05-08 Jason Stover <jhs@math.gcsu.edu>
170 * regression.q: Partial fix of bug which caused a crash if
171 dependent variable and independent variable were the same.
173 2007-04-16 John Darrington <john@darrington.wattle.id.au>
175 * t-test.q: Changed the output width of reported counts and
176 degrees of freedom, to avoid truncating these values. Thanks
177 to Seth Woolley for reporting this problem. A proper fix involves
178 re-thinking the output driver.
180 2007-04-12 Jason Stover <jhs@math.gcsu.edu>
182 * regression.q (run_regression): Added if (n_data >0) to fix bug
185 2007-03-29 Jason Stover <jhs@math.gcsu.edu>
187 * regression.q (prepare_data): New function.
189 * regression.q (compute_moments): New function.
191 2007-03-18 Ben Pfaff <blp@gnu.org>
193 * crosstabs.q (static var write): Rename write_style to avoid
194 conflict with POSIX function of same name.
196 2007-03-16 Jason Stover <jhs@math.gcsu.edu>
198 * regression.q (run_regression): Added support for moments.
200 Sat Feb 17 08:16:00 2007 Ben Pfaff <blp@gnu.org>
202 * flip.c (flip_sink_create): Improve error message when temporary
203 file cannot be created.
205 Tue Feb 6 19:58:03 2007 Ben Pfaff <blp@gnu.org>
207 * flip.c (flip_file): Give better error message on end-of-file.
209 2007-02-04 Jason Stover <jhs@math.gcsu.edu>
211 * regression.q: Fixed p-value computation in the test for
212 individual regression coefficients.
214 Mon Jan 15 11:03:20 2007 Ben Pfaff <blp@gnu.org>
216 Fix bugs found by valgrind when --enable-debug is used with the
217 new case code. These bugs are hidden when the data set is small
218 enough to find in memory; if a bigger data set that would overflow
219 to disk were used, then data corruption would occur.
221 * chisquare.c (create_freq_hash): Pass free_freq_mutable_hash to
222 hsh_create as free function. Make copy of data put into hash.
224 * oneway.q (free_value): New function.
225 (run_oneway): Use free_value as arg to hsh_create. Make copy of
228 * rank.q (rank_cases): Don't access data in case after we've given
231 Tue Jan 9 19:16:11 2007 Ben Pfaff <blp@gnu.org>
235 * aggregate.c (parse_aggregate_functions) Initialize
238 Fri Dec 22 14:04:09 2006 Ben Pfaff <blp@gnu.org>
240 Simplify missing value handling.
242 * aggregate.c (struct agr_var): Remove `bool include_missing', add
243 `enum mv_class exclude'. Remove `int missing', add `bool
244 saw_missing'. Update users.
246 * descriptives.c (struct dsc_trns): Removed `int
247 include_user_missing', add `enum mv_class exclude'. Update users.
248 (struct dsc_proc): Ditto.
250 * examine.q: (static var value_is_missing): Rename
251 `exclude_values', change type to `enum mv_class'. Update users.
255 Fri Dec 22 19:22:18 WST 2006 John Darrington <john@darrington.wattle.id.au>
257 * frequencies.q : Fixed bug #17420, where the table bounds were overun
258 when /FORMAT=nolabels was given.
260 Wed Dec 20 18:45:31 WST 2006 John Darrington <john@darrington.wattle.id.au>
262 * binomial.c binomial.h : New files. Thanks to Jason Stover
263 for assistance with these.
265 * chisquare.c chisquare.h freq.c freq.h npar-summary.c npar-summary.h
266 npar.h npar.q: New files. Implementing NPAR TESTS.
268 * frequencies.q : Moved structure definitions into freq.[ch]
270 Sat Dec 16 22:26:44 2006 Ben Pfaff <blp@gnu.org>
272 Make it possible to pull cases from the active file with a
273 function call, instead of requiring indirection through a callback
276 * aggregate.c (cmd_aggregate): Take advantage of new procedure
278 (agr_to_active_file): Removed.
279 (presorted_agr_to_sysfile): Removed.
281 * autorecode.c (cmd_autorecode): Take advantage of new procedure
283 (autorecode_proc_func): Removed.
285 * flip.c (struct flip_pgm): New members to allow conformance with
286 new case_source_class interface.
287 (cmd_flip): Adapt to new case_source_class interface.
288 (flip_source_read): Ditto.
289 (flip_source_destroy): Ditto.
291 Sat Dec 16 12:54:27 2006 Ben Pfaff <blp@gnu.org>
293 * rank.q (rank_custom_variables): Allow grouping variables to be
294 strings. Fixes bug #18533. Thanks to John Darrington for review.
296 Sat Dec 9 18:47:51 2006 Ben Pfaff <blp@gnu.org>
298 * regression.q (is_depvar): Compare variable pointers instead of
301 Thu Dec 7 15:26:25 WST 2006 John Darrington <john@darrington.wattle.id.au>
303 * examine.q: Allocated the categorical values for the dependent and
304 independent variables, on the heap. Hence they can be of any width.
306 Wed Dec 6 21:14:26 2006 Ben Pfaff <blp@gnu.org>
308 * regression.q (reg_inserted): Compare variable pointers instead
311 Mon Dec 4 22:33:46 2006 Ben Pfaff <blp@gnu.org>
313 * crosstabs.q (insert_summary): Use var_to_string for labeling.
314 (output_pivot_table) Ditto.
317 * frequencies.q (setup_z_trns): Ditto.
319 (dump_condensed) Ditto.
320 (dump_statistics) Ditto.
323 Sun Nov 5 08:31:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
325 * t-test.q, oneway.q: Changed to use the new casefilter structure.
327 Sat Oct 14 16:52:28 2006 Ben Pfaff <blp@gnu.org>
329 * rank.q: (rank_sorted_casefile) Add some missing case_destroy()
330 calls to fix a memory leak.
332 Sun Oct 8 09:45:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
334 * rank.q: Plugged a small memory leak which occurred under error
337 Sat Oct 7 11:06:01 WST 2006 John Darrington <john@darrington.wattle.id.au>
339 * rank.q: Implemented most of the RANK command.
341 2006-07-14 Jason Stover <jhs@math.gcsu.edu>
343 * regression.q (run_regression): New function to move knowledge of
344 pspp_linreg_cache out of math/coefficient.[ch].
346 Sat Jul 1 17:41:46 2006 Ben Pfaff <blp@gnu.org>
348 Fix bug #11612, "q2c documentation does not agree with code".
350 * examine.q: Audit use of q2c "+" prefixes that indicate that a
351 command may appear multiple times.
353 * frequencies.q: Ditto.
357 * regression.q: Ditto.
361 Fri Jun 23 14:18:22 2006 Ben Pfaff <blp@gnu.org>
363 Support long string variables on FREQUENCIES, as
364 an extension when in enhanced algorithms mode. For Greg Hunt
365 <greg@firmansyah.com>.
367 * frequencies.q: (struct freq) Change `v' member from union value
368 to union value *. Update all references.
369 (struct var_freqs) Add width, print members to represent effective
370 variable width and display format.
371 (calc) Copy entire long string value into the hash table.
372 (frq_custom_variables) Set new width, print members.
373 (hash_value_alpha) Get width from var_freqs.
374 (compare_value_alpha_a) Ditto.
375 (compare_freq_alpha_a) Ditto.
376 (compare_freq_alpha_d) Ditto.
377 (dump_full) Get display format from var_freqs.
378 (dump_condensed) Ditto.
380 Mon Jun 19 22:07:13 2006 Ben Pfaff <blp@gnu.org>
382 * frequencies.q: (dump_full) Only put the first MAX_SHORT_STRING
383 bytes of string variables into the output cells, seeing as we only
385 (dump_condensed) Ditto.
387 Mon Jun 19 21:52:05 2006 Ben Pfaff <blp@gnu.org>
389 Fixes a bug reported by Greg Hunt <greg@firmansyah.com>.
391 * frequencies.q: (hsh_hash_bytes) We only copy the first
392 MAX_SHORT_STRING bytes of string variables, so we must only
393 compare that many bytes, even if the string variable is longer.
394 (compare_value_alpha_a) Ditto.
395 (compare_freq_alpha_a) Ditto.
396 (compare_freq_alpha_d) Ditto.
398 2006-05-11 Jason Stover <jhs@math.gcsu.edu>
400 * regression.q: Adjusted code to account for cache->coeff being a
401 pspp_linreg_coeff **.
403 Sun May 7 18:31:25 2006 Ben Pfaff <blp@gnu.org>
407 * aggregate.c (cmd_aggregate): Free default_dict before replacing
410 Sun May 7 17:09:19 2006 Ben Pfaff <blp@gnu.org>
412 * flip.c (flip_file): Check return value of pool_fclose().
414 Sat May 6 16:00:13 2006 Ben Pfaff <blp@gnu.org>
416 Get rid of `char *c' member in union value, for cleanliness.
418 * aggregate.c: (union agr_argument) New union.
419 (struct agr_var) Change element type of arg[] from union value to
421 (parse_aggregate_functions) Change local variable types likewise.
423 * autorecode.c: (union arc_value) New union.
424 (struct arc_item) Change "from" from union value to union
426 (recode) Change local variable from union value to union
428 (autorecode_trns_proc) Ditto.
429 (compare_alpha_value) Ditto.
430 (hash_alpha_value) Ditto.
431 (compare_numeric_value) Ditto.
432 (hash_numeric_value) Ditto.
433 (autorecode_proc_func) Ditto.
435 Sat May 6 10:43:33 2006 Ben Pfaff <blp@gnu.org>
437 Continue reforming procedure execution. In this phase, get rid of
438 the output code for SPLIT FILE groups in procedure.c, which really
439 shouldn't be doing any output. Move it into the individual
440 procedures instead. This also adds some flexibility.
442 * crosstabs.q (precalc): Call output_split_file_values().
444 * descriptives.c (calc_descriptives): Ditto.
446 * examine.q (run_examine): Ditto.
448 * frequencies.q (precalc): Ditto.
450 * oneway.q (run_oneway): Ditto.
452 * regression.q (run_regression): Ditto.
454 * t-test.q (calculate): Ditto.
456 Wed May 3 23:05:31 2006 Ben Pfaff <blp@gnu.org>
458 Continue reforming procedure execution. In this phase, get rid of
459 many global variables, consolidating procedure execution in
460 procedure.c. Encapsulate transformations in new "struct
461 trns_chain". Also, change implementation of N OF CASES, FILTER,
462 and PROCESS IF from special cases to transformations.
464 * aggregate.c (cmd_aggregate) Use discard_variables().
466 2006-04-28 Jason Stover <jhs@math.gcsu.edu>
468 * regression.q (regression_trns_resid_proc): Pass only the
469 variables used in the model to (*model->residual)().
471 * regression.q (regression_trns_pred_proc): Pass only the
472 variables used in the model to (*model->pred)().
474 2006-04-26 Jason Stover <jhs@math.gcsu.edu>
476 * regression.q: Added support for multiple transformations.
478 * regression.q (regression_trns_resid_proc): New function.
480 * regression.q (regression_trns_pred_proc): New function.
482 * regression.q (subcommand_save): Added support for saving
485 * regression.q (regression_trns_free): New function.
487 * regression.q (reg_get_name): New function.
489 * regression.q (reg_save_var): New function.
491 Tue Apr 25 13:18:56 2006 Ben Pfaff <blp@gnu.org>
493 * rank.q (parse_rank_function): Use SE instead of ME for parse
496 Tue Apr 25 13:16:28 2006 Ben Pfaff <blp@gnu.org>
498 * flip.c (flip_sink_write): Use snprintf() to simplify a bit of
501 2006-04-21 Jason Stover <jhs@math.gcsu.edu>
503 * regression.q (try_name): New function. (Partly copied from
504 try_name in descriptives.c.)
506 * regression.q (subcommand_save): Choose residual variable names
509 2006-04-20 Jason Stover <jhs@math.gcsu.edu>
511 * regression.q (cmd_regression): Moved call to subcommand_save()
512 outside multipass_procedure_with_splits().
514 * regression.q (regression_trns_proc): Fixed value counter n_vals
515 before calling *model->residual().
517 2006-04-19 Jason Stover <jhs@math.gcsu.edu>
519 * regression.q (regression_trns_proc): Fixed the look-up of the
522 2006-04-18 Jason Stover <jhs@math.gcsu.edu>
524 * regression.q (regression_trns_proc): Look up the residual
525 variable in the linear regression cache.
527 * regression.q (subcommand_save): Set the residual variable in the
528 linear regression cache.
530 2006-04-17 Jason Stover <jason@wonko.gcsu.edu>
532 * regression.q (regression_trns_proc): Accept case_idx as an int
533 to match the definition of trns_proc_func.
535 2006-04-17 Jason Stover <jhs@math.gcsu.edu>
537 * regression.q (regression_trns_proc): New function.
539 * regression.q (subcommand_save): Create variable residuals and
540 add a transformation to assign values to them. Also free the
541 linreg_cache if the SAVE command was not called. Removed the
542 casereading loop. Placed actual computation of residuals in
543 regression_trns_proc.
545 * regression.q (run_regression): Moved call to free
546 pspp_linreg_cache to subcommand_save.
548 Sat Apr 15 18:01:03 2006 Ben Pfaff <blp@gnu.org>
550 * examine.q (output_examine): Add casts to fix warnings.
552 2006-04-07 Jason Stover <jhs@math.gcsu.edu>
554 * regression.q (subcommand_save): New function.
556 2006-04-04 Jason Stover <jhs@math.gcsu.edu>
558 * regression.q: New function reg_has_categorical () to tell
559 whether a pspp_linreg_struct was made with any variables of type
562 * regression.q: (subcommand_export): Call
563 reg_print_categorical_encoding() only if the model uses any
564 categorical variables.
566 Mon Mar 27 16:00:42 2006 Ben Pfaff <blp@gnu.org>
568 * crosstabs.q: (output_pivot_table) Drop spurious space from
571 2006-03-15 Jason Stover <jhs@math.gcsu.edu>
573 * regression.q: Added custom syntax parser for VARIABLES subcommand
575 * regression.q: Moved most instructions for run_regression ()
576 inside the loop over dependent variables.
578 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
580 * Moved files from src directory