1 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
3 * casefile.c: Convert many uses of `int' to `bool'.
5 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
7 * transformations.c (trns_chain_destroy): Destroy chain's trns
8 member, to fix memory leak.
10 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
12 * storage-stream.c (storage_source_decapsulate): Destroy case
13 source to fix memory leak.
15 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
17 * scratch-reader.c (scratch_reader_read_case): Copy into existing
18 case passed as argument instead of initializing the argument as a
19 case. Fixes memory leak that showed up in
20 tests/command/aggregate.sh with scratch files.
22 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
24 * procedure.c (proc_done): Destroy default_dict, to fix memory
27 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
29 Simplify procedure_with_splits().
31 * procedure.c (struct split_aux_data): Removed case_count member.
32 (procedure_with_splits) Don't initialize case_count.
33 (split_procedure_case_func) Check whether prev_case is null
34 instead of case_count.
35 (split_procedure_end_func) Ditto.
37 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
39 * case.c (case_move): Do nothing if dst and src are the same
41 (case_try_create) Merge two similar cases.
42 (case_copy) Unshare only if data must be actually copied.
44 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
46 * data-in.c data-out.c dictionary.c sys-file-reader.c
47 sys-file-writer.c variable.c variable.h: Reworked very long string
48 support for better encapsulation.
50 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
52 * value-labels.c (val_labs_can_set_width): New function.
53 (val_labs_set_width) Clear labels if increasing width to long
55 (val_labs_destroy) Remove unneeded test for null.
57 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
59 * value-labels.h: Remove unneeded dependency on variable.h.
61 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
63 Get rid of `char *c' member in union value, for cleanliness.
65 * value.h: (union value) Remove `c' member.
67 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
69 Make dictionary compacting functions a little more general.
71 * sys-file-writer.c (sfm_open_writer): Use
72 dict_compacting_would_change().
73 (does_dict_need_translation) Removed.
75 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
77 Make dictionary compacting functions a little more general.
79 * dictionary.c (dict_needs_compaction): Rename
80 dict_compacting_would_shrink(). Update all callers.
81 (dict_compacting_would_change) New function.
83 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
85 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
86 inverted return value (!).
88 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
90 Continue reforming procedure execution.
92 * procedure.c: Search and replace "vfm" by "proc". Notably:
93 (static var vfm_source) Rename proc_source. Update all
95 (static var vfm_sink) Rename proc_sink. Update all references.
97 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
99 Continue reforming procedure execution. In this phase, remove
100 PROCESS IF, which was deprecated anyway and can be easily
101 simulated with TEMPORARY followed by SELECT IF.
103 * procedure.c: (open_active_file) Don't call
104 add_process_if_trns().
105 (discard_variables) Get rid of redundant call to
106 proc_cancel_all_transformations().
107 (add_process_if_trns) Removed.
108 (process_if_trns_proc) Removed.
109 (process_if_trns_free) Removed.
111 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
113 Continue reforming procedure execution. In this phase, add
114 `const' to the case passed to procedure()'s callback.
116 Updated all users of procedure() as well.
118 * procedure.c: (struct write_case_data) Add "const" to ccase
119 parameter for case_func member.
120 (procedure) Add "const" to ccase parameter for proc_func
122 (multipass_case_func) Make ccase parameter const.
123 (internal_procedure) Add "const" to ccase parameter for case_func
125 (split_procedure_case_func) Make ccase parameter const.
126 (multipass_split_case_func) Make ccase parameter const.
128 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
130 Continue reforming procedure execution. In this phase, get rid of
131 the output code for SPLIT FILE groups in procedure.c, which really
132 shouldn't be doing any output. Move it into the individual
133 procedures instead. This also adds some flexibility.
135 Updated many users of procedure_with_splits() and
136 multipass_procedure_with_splits() to call
137 output_split_file_values() and to deal with increased use of
140 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
141 parameter to begin_func member.
142 (procedure_with_splits) Add "const struct ccase *" parameter to
143 begin_func parameter. Make ccase parameter const in proc_func
145 (split_procedure_case_func) Don't dump split file group. Pass
147 (dump_splits) Moved to language/dictionary/split-file.c as
148 output_split_file_values().
149 (struct multipass_split_aux_data) Add "const struct ccase *"
150 parameter to split_func member.
151 (multipass_procedure_with_splits) Add "const struct ccase *"
152 parameter to split_func parameter.
153 (multipass_split_case_func) Save new SPLIT FILE case before
155 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
157 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
159 Continue reforming procedure execution. Change
160 internal_procedure() so that it calls open_active_file() and
161 close_active_file(), which isolates most of the actual procedure
164 * procedure.c: (struct write_case_data) Rename `proc_func' member
165 to `case_func' and update all references.
166 (procedure) Rewrite as one-line wrapper around
167 internal_procedure().
168 (struct multipass_aux_data) New.
169 (multipass_callback) Renamed multipass_case_func(). Use struct
170 multipass_aux_data as auxiliary data.
171 (multipass_end_func) New function.
172 (multipass_procedure) Rewrite as wrapper for internal_procedure()
173 that uses multipass_case_func, multipass_end_func.
174 (internal_procedure) Add `end_func' argument. Move optimization
175 of trivial case in here. Move call to open_active_file() and
176 close_active_file() in here. Now assert that vfm_source is
178 (procedure_with_splits_callback) Rename
179 split_procedure_case_func().
180 (split_procedure_end_func) New function.
181 (multipass_split_callback) Rename multipass_split_case_func.
182 (multipass_split_end_func) New function.
183 (discard_variables) No need to test for nonnull vfm_source.
185 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
187 Continue reforming procedure execution. Get rid of unused member.
189 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
191 (write_case) Don't increment cases_analyzed.
193 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
195 Continue reforming procedure execution. In this phase, move
196 procedure.c and procedure.h from src to src/data. Update
197 makefiles and #includes accordingly.
199 * procedure.c: Moved here from src/.
201 * procedure.h: Moved here from src/.
203 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
205 Continue reforming procedure execution. In this phase, get rid of
206 many global variables, consolidating procedure execution in
207 procedure.c. Encapsulate transformations in new "struct
208 trns_chain". Also, change implementation of N OF CASES, FILTER,
209 and PROCESS IF from special cases to transformations.
211 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
214 * dictionary.c: (global variable default_dict) Move to
217 * variable.h: (TRNS_*) Move to transformations.h.
218 (struct transformation) Move to transformations.c.
220 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
222 * sys-file-reader.c: Fixed invalid read problems.
224 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
226 * storage-stream.c: Add missing function comments.
228 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
230 Continue reforming procedure execution. In this phase, add some
231 new, needed functionality to storage-stream.
233 * storage-stream.c: (storage_source_decapsulate) New function.
235 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
237 * variable.c (width_to_bytes): Declarations must precede
238 statements for C90 compliance.
240 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
242 * data-out.c, data-in.c, variable.c, variable.h: New functions
243 copy_mangle and copy_demangle for reading/writing cases; emulates the
244 way SPSS deals with strings > 255 bytes.
246 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
247 subtype 14 needed for strings longer than 255 bytes.
249 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
250 instead of literal values. Also fixed some constness issues.
252 * format.h: Constness
254 * sfm-private.h: Renamed the case_size identifier, since I discovered
255 that SPSS's respect for this variable is very nominal.
257 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
259 Change case limit type from int to size_t.
261 * dictionary.c: (struct dictionary) Change type of case_limit
263 (dict_get_case_limit) Change return type.
264 (dict_set_case_limit) Change parameter type.
266 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
268 * variable.h: (struct variable) Rename `reinit' member as `leave'
269 and invert sense. Fix up all references.
271 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
273 Continue reforming procedure execution. In this phase, break
274 procedure.c into multiple files.
276 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
278 * case-sink.c: New file.
280 * case-sink.h: New file.
282 * case-source.c: New file.
284 * case-source.h: New file.
286 * storage-stream.c: New file.
288 * storage-stream.h: New file.
290 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
292 * variable.h: (struct variable) Remove `init' member and all
293 references to it from other files. It was initialized in several
294 places, but nothing really ever used it for anything worthwhile.
295 Thanks to Jason Stover for pointing out how confusing this
298 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
300 Continue reforming error message support. In this phase, get rid
301 of message "titles" and put the message text in `struct error'.
302 Now `struct error' encapsulates a message more properly.
304 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
305 Format message ourselves.
307 * data-in.c: (vdls_error) Ditto.
309 * por-file-reader.c: (error) Ditto.
311 * sys-file-reader.c: (corrupt_msg) Ditto.
313 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
315 GNU standards require "file name" instead of "filename" in
316 documentation. It's nice for our code to follow the convention
319 * casefile.c: (struct casefile) Rename `filename' member to
320 `file_name'. Updated all references.
322 * file-name.c: [!unix] (struct file_identity) Rename
323 normalized_filename member to normalized_file_name. Updated all
326 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
328 We don't really support anything but Unix-like environments well,
329 so we might as well de-obfuscate by writing directory and path
330 separators explicitly.
332 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
334 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
335 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
337 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
340 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
342 GNU standards require "file name" instead of "filename" in
343 documentation. It's nice for our code to follow the convention
346 * filename.c: Rename to file-name.c.
348 * filename.h: Rename to file-name.h. Update all inclusions.
349 Update header guards.
351 * automake.mk: Update file names.
353 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
355 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
357 (fn_basename) Removed (dead code).
358 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
359 (fn_special_p) Renamed fn_is_special(), all references updated.
360 (fn_exists_p) Renamed fn_exists(), all references updated.
362 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
364 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
365 Also, now it only tilde-expands file names, not paths.
366 (fn_search_path) Tilde-expand one directory at a time.
368 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
370 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
371 get rid of non-Unixlike version of the code, which has probably
373 (fn_prepend_dir) Removed (dead code).
375 * filename.h: (macro DIR_SEPARATOR_STRING) New.
376 (macro PATH_SEPARATOR_STRING) New.
377 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
379 Continue reforming error message support. In this phase, we get
380 rid of VM() and the other msg() support for "verbosity", replacing
381 it by a new function verbose_msg().
383 * filename.c: (fn_search_path) Use verbose_msg() instead of
386 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
388 * sfm-private.h: Get rid of #defines after #error, which makes no
391 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
393 Get rid of our own int32 type in favor of the standard int32_t
396 * sfm-private.h: (int32 macro) Don't define this anymore. Do
399 * sys-file-reader.c: Use int32_t instead of int32 throughout.
401 * sys-file-writer.c: Use int32_t instead of int32 throughout.
403 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
405 Remove ill-considered file routines that are no longer used.
407 * filename.c: (fn_open_ext) Removed.
408 (fn_close_ext) Removed.
410 * filename.h: (struct file_ext) Removed.
412 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
414 * variable.c (var_is_valid_name): Move declarations before code
417 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
419 * filename.ch (fn_interp_vars): Fixed small buglet.
421 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
423 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
424 so as to modify the string inline. Thus makeing it easier to
425 destroy the results when no longer needed.
427 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
429 * category.c (cat_stored_values_destroy): Fixed memory leak.
431 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
433 Add some missing frees. Thanks to John Darrington for reporting
436 * any-writer.c (any_writer_close): Free writer.
438 * any-reader.c (any_reader_close): Free reader.
440 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
442 * por-file-reader.c: (error) Mark as NO_RETURN.
444 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
446 * settings.c: Changed default value of scompress to true.
448 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
450 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
452 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
455 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
456 here from pref.h.orig.
458 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
460 * sys-file-reader.c: Fixed bug reading compressed files.
462 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
464 * Numerous renames. See src/ChangeLog for details.
466 * Moved files from src directory