1 2007-08-12 Ben Pfaff <blp@gnu.org>
3 Drop dict_compactor in favor of using the new struct case_map.
5 * dictionary.c (struct copy_map): Removed.
6 (struct dict_compactor): Removed.
7 (dict_make_compactor): Removed.
8 (dict_compactor_compact): Removed.
9 (dict_compactor_destroy): Removed.
11 * procedure.c (struct data_set): Change `compactor' member to be a
13 (proc_open): Use case_map_to_compact_dict instead of
15 (proc_casereader_read): Use case_map_execute instead of
16 dict_compactor_compact.
17 (proc_commit): Use case_map_destroy instead of
18 dict_compactor_destroy.
20 * scratch-writer.c (struct scratch_writer): Change `compactor'
21 member to be a struct case_map *.
22 (scratch_writer_open): Use case_map_to_compact_dict instead of
24 (scratch_writer_casewriter_write): Use case_map_execute instead of
25 dict_compactor_compact.
27 2007-08-12 Ben Pfaff <blp@gnu.org>
29 * automake.mk: Add case-map.c, case-map.h.
31 * case-map.c: New file.
33 * case-map.h: New file.
35 2007-08-12 Ben Pfaff <blp@gnu.org>
37 * dictionary.c (dict_compact_values): Don't delete scratch
38 variables as well as compacting case indexes. Update all callers.
39 (dict_get_compacted_value_cnt): Rename dict_count_values and
40 change interface. Update all callers.
41 (dict_get_compacted_value_cnt): Remove.
42 (dict_compacting_would_shrink): Remove.
43 (dict_compacting_would_change): Remove.
44 (dict_make_compactor): Add new parameter. Update all callers.
46 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
47 instead of dict_count_values, changing an O(N) operation into
50 2007-08-12 Ben Pfaff <blp@gnu.org>
52 * casereader.c (casereader_read): Don't require cases read by a
53 casereader to be exactly the expected size: as long as they're big
56 2007-08-12 Ben Pfaff <blp@gnu.org>
58 Make casewriters keep track of the number of `union value's in
59 each case. This is useful for two reasons: casewriter_write can
60 then check that the case being written is large enough, and later
61 recipients of the casewriter can determine the size of the case.
63 * casewriter-translator.c (casewriter_create_translator): Add
66 * casewriter.c (struct casewriter): Add value_cnt member.
67 (casewriter_write): Check that the case passed in is big enough.
68 (casewriter_get_value_cnt): New function.
69 (casewriter_create): Add value_cnt parameter.
71 2007-08-09 Ben Pfaff <blp@gnu.org>
73 Fix bug reported by Jason Stover.
74 * settings.c: Move get_termcap_viewport and in particular the
75 #include for <curses.h> to the end of the file. curses.h
76 redefines bool on some systems (e.g. OpenBSD), which causes
77 disagreement between uses of bool before its inclusion and
79 Tested by Jason Stover.
81 2007-07-29 Ben Pfaff <blp@gnu.org>
83 Provisional fix for bug #18692 and bug #20161. Reviewed by John
86 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
87 argument (never "rb" or "wb") because SUSv3 says that only those
88 modes are defined, and glibc in fact rejects other modes.
90 Open portable files with fn_open so that they can be read from
91 pipes. Fix missing fh_close call to go along with fh_open.
92 Report an error if the file close reports an error.
93 * por-file-reader.c (close_reader): New function.
94 (por_file_casereader_destroy): Use close_reader.
95 (pfm_open_reader): Open file with fn_open.
97 2007-07-28 Ben Pfaff <blp@gnu.org>
99 Make PSPP able to read all the portable files I could find on the
100 web. Thanks to John Darrington for review. Bug #17620.
101 * por-file-reader.c (struct pfm_reader): New member `line_length'.
102 (error): Print file offset in hexadecimal.
103 (warning): New function.
104 (advance): Treat lines less than 80 bytes long as padded to 80
106 (pfm_open_reader): Call read_documents if we find an "E" record.
107 (convert_format): Convert invalid formats to the default format
108 instead of aborting reading the file.
109 (read_variables): Rename duplicate variable names instead of
110 aborting reading the file.
111 (read_value_label): Allow string variables of different widths to
112 be assigned value labels in the same record. Replace duplicate
113 value labels instead of aborting.
114 (read_documents): New function.
116 * por-file-writer.c (pfm_open_writer): Call write_documents if the
117 dictionary has documents.
118 (write_documents): New function.
120 2007-07-25 Ben Pfaff <blp@gnu.org>
122 Fix bugs related to bug #17213.
124 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
125 since the former is what config.h has. Include the needed ncurses
127 (static var echo) Rename to `do_echo' because the original name is
128 the same as an ncurses identifier.
129 (get_termcap_viewport) Use error instead of msg.
131 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
132 (fn_close): Don't close stdin, stdout, stderr.
134 2007-07-26 John Darrington <john@darrington.wattle.id.au>
136 * procedure.c procedure.h: Added callbacks which get invoked whenever
137 a dataset's transformation chain changes.
139 2007-07-24 Ben Pfaff <blp@gnu.org>
142 * sys-file-writer.c (write_variable_display_parameters): Use new
143 var_default_display_width function to choose display width of
144 segments after the first one in a given variable.
145 * variable.c (var_create): Use var_default_display_width to pick
146 new variable's display width.
147 (var_default_display_width): New function.
148 Reviewed by John Darrington.
150 2007-07-24 Ben Pfaff <blp@gnu.org>
153 * por-file-writer.c (write_variables): Write weight variable.
154 Reviewed by John Darrington.
156 2007-07-23 Ben Pfaff <blp@gnu.org>
158 Improvements to system file reader and writer.
160 First, move all detailed knowledge of very long strings into
161 sys-file-private.[ch], so that this nasty stuff can be isolated.
163 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
164 (EFFECTIVE_VLS_CHUNK): New macro.
165 (min_int): New function.
166 (max_int): New function.
167 (sfm_width_to_bytes): Rewrite.
168 (sfm_width_to_octs): New function.
169 (sfm_segment_alloc_width): New function.
170 (sfm_segment_alloc_bytes): New function.
171 (sfm_segment_used_bytes): New function.
172 (sfm_segment_offset): New function.
173 (sfm_segment_effective_offset): New function.
174 (sfm_dictionary_to_sfm_vars): New function.
176 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
177 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
178 (struct sfm_var): New structure.
180 Next, improvements to the system file reader.
182 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
183 type casenumber. Added `version_major', `version_minor',
186 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
187 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
188 Change `case_cnt' to type casenumber. Removed `has_vls'.
189 (struct sfm_var): Removed.
190 (sfm_open_reader): Don't warn on wrong case size if the file was
191 written by SPSS 13, which tends to get it wrong. Use
192 sfm_dictionary_to_sfm_vars.
193 (read_header): Always output system file info.
194 (read_variable_record): Simplify code for reading missing values.
195 (read_machine_int32_info): Save version numbers from system file
196 into info struct passed as new argument.
197 (read_long_string_map): Restructured to use new sys-file-private
199 (read_value_labels): Use size_overflow_p.
200 (sys_file_casereader_read): Get rid of distinction between fast
201 and slow paths. Use information provided by sys-file-primate's
202 struct sfm_var to simplify code.
203 (skip_whole_strings): New function.
204 (read_int32): Renamed read_int. Changed return value to int.
206 (read_flt64): Renamed read_float. Changed return value to
207 double. Updated all callers.
208 (int32_to_native): Removed. Changed callers to use
210 (flt64_to_double): Removed. Changed callers to use float_convert.
212 Finally, get rid of int32, flt64 terminology and types in system
213 file writer. The former wasn't very useful since a POSIX "int"
214 can hold the whole range of int32 and we generally didn't have a
215 need for it to be exactly-32-bits, just at-least-32-bits. The
216 latter was inconvenient because we had to assume that it could be
217 different from double and thereby convert special values SYSMIS,
218 HIGHEST, LOWEST to and from it in multiple places. Instead, now
219 we just use "int" and "double" in most places, and do conversions,
220 if necessary, very close to where we do I/O. This change meant
221 that the writer code couldn't represent records in the file as C
222 structs any longer, but that's no great loss. The code actually
223 seems to be more readable without them.
225 Simplify the compression buffering code: only buffer as much as
226 necessary, which is no more than eight 8-byte units at any given
229 * sys-file-writer.c (typedef flt64): Removed.
230 (macro second_lowest_flt64): Removed.
231 (struct sysfile_header): Removed.
232 (struct sysfile_variable): Removed.
233 (struct sfm_writer): Removed `needs_translation', `has_vls',
234 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
235 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
236 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
237 compression buffering by `opcodes', `opcode_cnt', `data',
238 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
239 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
240 data writer functions instead of structures.
241 (calc_oct_idx): New function.
242 (write_header): Use simple data writer functions instead of
244 (write_format_spec): Renamed write_format. New argument.
245 (write_variable_continuation_records): New function.
246 (write_variable): Use simple data writer functions instead of
247 structures. Use write_variable_continuation_records. Write
248 entire very long string instead of requiring caller to understand
250 (write_value_labels): Use simple data writer functions instead of
252 (write_documents): Ditto.
253 (write_variable_display_parameters): Use sys-file-private
254 functions to simplify. Use simple data writer functions instead
256 (write_vls_length_table): Use simple data writer functions instead
258 (write_longvar_table): Ditto.
259 (write_rec_7_34): Break into new functions
260 write_integer_info_record, write_float_info_record. Use simple
261 data writer functions instead of structures.
262 (buf_write): Removed.
263 (append_string_max): Removed.
264 (ensure_buf_space): Removed.
265 (sys_file_casewriter_write): Get rid of the distinction between
266 fast and slow paths, which didn't seem to be too useful. Use new
267 functions write_case_uncompressed, write_case_compressed.
268 (put_instruction): Removed.
269 (put_element): Removed.
270 (write_compressed_data): Removed.
271 (close_writer): Use flush_compressed. Only write case count to
272 system file if it will fit in the field.
273 (write_case_compressed): New function.
274 (write_case_uncompressed): New function.
275 (flush_compressed): New function.
276 (put_cmp_opcode): New function.
277 (put_cmp_number): New function.
278 (write_int): New function.
279 (convert_double_to_output_format): New function.
280 (write_float): New function.
281 (write_value): New function.
282 (write_string): New function.
283 (write_bytes): New function.
284 (write_zeros): New function.
285 (write_spaces): New function.
287 Reviewed by John Darrington.
289 2007-07-22 Ben Pfaff <blp@gnu.org>
291 Don't try to write very long strings to portable files. The
292 format does not support it.
294 * por-file-writer.c (MAX_POR_WIDTH): New macro.
295 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
296 (write_format): Add arg to take width to resize format to.
297 (write_value): Limit width of value written to MAX_POR_WIDTH.
298 (write_variables): Limit width of variable and its output formats
300 Reviewed by John Darrington.
302 2007-07-22 Ben Pfaff <blp@gnu.org>
304 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
305 local variable instead of literal 5.
306 Reviewed by John Darrington.
308 2007-07-22 Ben Pfaff <blp@gnu.org>
310 Fix problems with uniqueness of short names in system files with
311 very long string variables. Now a variable may have multiple
314 * automake.mk (src_data_libdata_a_SOURCES): Add new files
315 short-names.c, short-names.h.
317 * dictionary.c (dict_clone): Clone all the short names.
318 (compare_strings): Move into short-names.c.
319 (hash_strings): Ditto.
320 (set_var_short_name_suffix): Ditto.
321 (dict_assign_short_names): Ditto, rename short_names_assign,
322 change to assign all short names.
324 * por-file-writer.c (write_variables): Use short_names_assign
325 instead of dict_assign_short_names.
327 * short-names.c: New file.
329 * short-names.h: New file.
331 * sys-file-private.c (sfm_width_to_segments): New function.
333 * sys-file-reader.c (read_long_var_name_map): Save and restore all
334 the short names, not just the first one.
336 * sys-file-writer.c (cont_var_name): Removed.
337 (sfm_open_writer): Use short_names_assign instead of
338 dict_assign_short_names. Use unique short names assigned by
339 short_names_assign instead of those generated by cont_var_name.
341 * variable.c (struct variable): Remove `short_name' member,
342 replace by `short_names' and `short_name_cnt'.
343 (var_create) Initialize new members.
344 (var_get_short_name_cnt): New function.
345 (var_get_short_name): Now takes an index argument. Changed most
347 (var_set_short_name): Ditto.
348 (var_clear_short_name): Renamed var_clear_short_names, changed to
349 clear all short names.
351 Reviewed by John Darrington.
353 2007-07-22 Ben Pfaff <blp@gnu.org>
355 * variable.c (var_set_width): Use new var_set_width function.
357 * missing-values.c (mv_n_values): Drop assertion, which was not
360 * format.c (fmt_default_for_width): New function.
361 (fmt_resize): New function.
363 Reviewed by John Darrington.
365 2007-07-18 John Darrington <john@darrington.wattle.id.au>
367 * datasheet.c (datasheet_delete_columns): Added assertion to check
368 we're not deleting outside the range of the sheet.
371 * dictionary.c dictionary.h variable.c: Added the ability for string
372 variables to be resized.
374 * vardict.h: Added some prototypes (moved from dictionary.h) as
375 these should only be called by variable.c
378 2007-07-14 John Darrington <john@darrington.wattle.id.au>
380 * sfm-reader.c: Respect case_cnt field in file header.
382 2007-07-01 John Darrington <john@darrington.wattle.id.au>
384 * transformation.c transformation.h (trns_chain_execute): Changed the
385 signature (Patch #6057)
387 2007-06-10 Ben Pfaff <blp@gnu.org>
389 * casereader-filter.c (casereader_filter_destroy): Make sure to
390 write all the remaining excluded cases to the casewriter, if any.
392 * caseinit.c (init_list_destroy): Rewrite.
393 (init_list_clear): Ditto.
395 * casegrouper.c (casegrouper_get_next_group): Always set *reader
396 to null when returning false.
398 2007-06-06 Ben Pfaff <blp@gnu.org>
400 Actually implement the new procedure code and adapt all of its
401 clients to match. Also adapt all of the other case sources and
402 sinks in the tree and their clients to use the
403 casereader/casewriter infrastructure.
405 * automake.mk: Add and remove files.
407 * any-reader.c: Change into a casereader.
408 * por-file-reader.c: Ditto.
409 * scratch-reader.c: Ditto.
410 * sys-file-reader.c: Ditto.
412 * any-writer.c: Change into a casewriter.
413 * por-file-writer.c: Ditto.
414 * scratch-writer.c: Ditto.
415 * sys-file-writer.c: Ditto.
417 * procedure.c: Change to use casereader, casewriter, caseinit, and
418 other new infrastructure.
420 * scratch-handle.c: Adapt to new infrastructure.
422 * case-sink.c: Removed, now dead code.
423 * case-sink.h: Ditto.
424 * case-source.c: Ditto.
425 * case-source.h: Ditto.
426 * casefile-factory.c: Ditto.
427 * casefile-private.h: Ditto.
430 * casefilter.c: Ditto.
431 * casefilter.h: Ditto.
434 * fastfile-factory.c: Ditto.
435 * fastfile-factory.h: Ditto.
436 * storage-stream.c: Ditto.
437 * storage-stream.h: Ditto.
439 2007-06-06 Ben Pfaff <blp@gnu.org>
443 * automake.mk: Add new files.
445 * datasheet.c: New file.
447 * datasheet.h: New file.
449 2007-06-06 Ben Pfaff <blp@gnu.org>
451 Until now, the procedure code has provided a case to the
452 case_source, which has filled in the data values that come from
453 the active file. "Left" data values that don't come from the
454 active file naturally stay the same from case to case, because the
455 procedure code keeps using that same case.
457 One of the compromises that comes with the new procedure code is
458 that the active file allocates and provides its own case, which
459 the procedure code then has to resize to provide room for any
460 other variables that should go in the case and then fill in the
461 values of "left" variables. Then, when we're done with that case,
462 we have to save the values of "left" variables to copy into the
463 next case read from the active file.
465 The caseinit code helps with this.
467 * automake.mk: Add new files.
469 * caseinit.c: New file.
471 * caseinit.h: New file.
473 2007-06-06 Ben Pfaff <blp@gnu.org>
475 * value.h (value_cnt_from_width): New function.
477 * variable.c (var_get_value_cnt): Use new function.
479 2007-06-06 Ben Pfaff <blp@gnu.org>
481 Add casegrouper, to allow cases read from a given casereader to be
482 broken into groups, each of which has its own casereader.
483 Generally cases are grouped based on having equal values for some
486 * automake.mk: Add new files.
488 * casegrouper.c: New file.
490 * casegrouper.h: New file.
492 2007-06-06 Ben Pfaff <blp@gnu.org>
494 Add interface to lexicographical ordering of cases.
496 * automake.mk: Add new files.
498 * case-ordering.c: New file.
500 * case-ordering.h: New file.
502 2007-06-06 Ben Pfaff <blp@gnu.org>
504 Add casereaders and casewriters, the basis of the new data processing
505 implementation. A casereader is a uniform interface to reading cases
506 from a data source; a casewriter is a uniform interface to writing
507 cases to a data sink.
509 * automake.mk: Add new files.
511 * casereader-filter.c: New file.
513 * casereader-provider.h: New file.
515 * casereader-translator.c: New file.
517 * casereader.c: New file.
519 * casereader.h: New file.
521 * casewriter-provider.h: New file.
523 * casewriter-translator.c: New file.
525 * casewriter.c: New file.
527 * casewriter.h: New file.
529 2007-06-06 Ben Pfaff <blp@gnu.org>
531 "casewindow" data structure that extends the deque (from libpspp)
532 of cases with the ability to dump cases to disk if we get too many
535 * automake.mk: Add new files.
537 * casewindow.c: New file.
539 * casewindow.h: New file.
541 2007-06-06 Ben Pfaff <blp@gnu.org>
543 sparse_cases data structure that augments a sparse_array of cases
544 with the ability to dump cases to disk if we get too many cases in
547 * automake.mk: Add new files.
549 * sparse-cases.c: New file.
551 * sparse-cases.h: New file.
553 2007-06-06 Ben Pfaff <blp@gnu.org>
555 Adds a low-level on-disk case array data structure.
557 * automake.mk: Add new files.
559 * case-tmpfile.c: New file.
561 * case-tmpfile.h: New file.
563 2007-06-06 Ben Pfaff <blp@gnu.org>
565 In a couple of places we calculate the maximum number of cases to
566 keep in memory based on the user-defined workspace. Enable
567 centralizing the calculation through a new function.
569 * settings.c (get_workspace_cases): New function.
571 2007-06-06 Ben Pfaff <blp@gnu.org>
573 The casenumber type is defined in transformations.h, but case.h is
574 a more sensible place. Move it.
576 * case.h (CASENUMBER_MAX): New macro.
577 (typedef casenumber): Move here, from transformations.h.
579 2007-06-03 Ben Pfaff <blp@gnu.org>
581 Slightly generalize case_to_values and case_from_values functions.
583 * case.c (case_to_values): Rename case_copy_out, change interface.
584 (case_from_values): Rename case_copy_in, change interface.
586 * fastfile.c (fastfilereader_get_next_case): Update caller.
587 (write_case_to_disk): Ditto.
589 2007-06-02 Ben Pfaff <blp@gnu.org>
591 Clean up after a forgotten part of patch #5829.
593 * casedeque.h: Remove unused file.
595 * automake.mk: Remove casedeque.h from sources.
597 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
599 * category.c: Removed redundant #include
601 2007-05-06 Ben Pfaff <blp@gnu.org>
603 Abstract the documents within a dictionary a little better.
604 Thanks to John Darrington for suggestion, initial version, and
607 * dictionary.c (struct dictionary): Change `documents' member from
608 char * to struct string.
609 (dict_clear): Destroy struct string.
610 (dict_get_documents): Convert struct string to char *.
611 (dict_set_documents): Set struct string. Pad to 80-character
613 (dict_clear_documents): New function.
614 (dict_add_document_line): New function.
615 (dict_get_document_line_cnt): New function.
616 (dict_get_document_line): New function.
618 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
620 * sys-file-reader.c (read_documents): Use new document functions.
622 2007-04-19 John Darrington <john@darrington.wattle.id.au>
624 * sys-file-reader.c: When reading a system file which has no
625 long name table, automatically create one where the long names
626 are the lower case versions of the short names.
628 2007-04-22 Ben Pfaff <blp@gnu.org>
630 * dictionary.c (dict_set_split_vars): dict_destroy expects that
631 dict_clear will free most data related to the dictionary.
632 dict_clear does a decent job, except that dict_set_split_vars on
633 some systems won't actually free the dict's "split" member.
634 Instead, it'll allocate a 1-byte region. Fix this.
636 * value.c (value_copy): New function.
637 (value_set_missing): Ditto.
639 2007-04-22 John Darrington <john@darrington.wattle.id.au>
641 * Deleted existing category.h and moved cat-routines.h into
642 category.h Encapsulated struct cat_vals better.
644 2007-04-19 John Darrington <john@darrington.wattle.id.au>
646 * sys-file-reader.c: When reading a system file which has no
647 long name table, automatically create one where the long names
648 are the lower case versions of the short names.
650 2007-04-16 John Darrington <john@darrington.wattle.id.au>
652 * sys-file-reader.c: Some versions of Other Software seem to
653 produce system files with string variables' measure set to
654 zero. We'll assume these are supposed to be nominal variables.
656 2007-03-30 Ben Pfaff <blp@gnu.org>
658 * procedure.c: Adapt to new deque data structure.
660 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
661 Ben Pfaff <blp@gnu.org>
663 * file-name.c: Mingw compatibility fixes.
664 (fn_search_path): Use ISSLASH instead of comparing against '/'
666 (fn_dir_name): Use dir_name from gnulib.
667 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
668 (fn_get_identity): Use GetFullPathName instead of canonicalize
669 from gnulib, because the latter does not fully support
670 Windows-style path names. Use this implementation based on the
671 detected presence of Windows instead of the absence of Unix, since
672 the new implementation is Windows-specific.
673 (fn_compare_file_identities): In Windows implementation, compare
674 names case-insensitively.
676 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
678 * make-file.c: Don't include mkstemp.h, because gnulib now causes
679 <stdlib.h> to have the same effect.
681 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
683 * por-file-reader.c: Add missing _() around messages.
685 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
687 * make-file.c: Include "mkstemp.h", without which linking on
690 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
692 Reduce platform dependence.
694 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
695 Everywhere we using this, we really should have just depended on
696 the shell to expand tildes.
697 (fn_search_path): Simplify, given that we don't do tilde expansion
699 (fn_normalize): Removed. Caller changed to use the canonicalize
701 (fn_get_cwd): Removed. Only user was fn_normalize.
702 (fn_is_absolute): Really only test for absolute names.
703 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
705 (fn_readlink): Removed, as it was only used fn_normalize.
706 (fn_exists): Assume the stat function is available; gnulib does.
707 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
709 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
711 * dictionary.c (dict_create_vector_assert): New function.
713 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
715 * file-name.c (fn_normalize): Correct name of function
716 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
717 for pointing this out.
719 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
721 We are using a single member in struct file_handle, the "name"
722 field, for more than one purpose. When it begins with '"', it's a
723 file name; otherwise, it's a token that can be used to identify
724 it. When that assertion fires, it's because we searched for the
725 name case-sensitively as a file name (so that there was no match),
726 and then we try to insert it case-insensitively as a token, which
727 fails because duplicates aren't allowed.
729 Solution: break the two purposes into two separate fields. This
730 fixes the problem and likely makes the code easier to read too.
732 Fixes bug #18922. Thanks to John Darrington for bug report and
735 * file-handle-def.c (struct file_handle): New `id' member.
736 (fh_from_name): Rename fh_from_id. Update all callers.
737 (create_handle): New `id' parameter. Update all callers.
738 (fh_create_file): Ditto.
739 (fh_get_id): New function.
741 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
743 * case.c (case_is_null): Change return type to bool.
745 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
749 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
750 reference counting to share data. This makes it easy for
751 valgrind, etc. to find accesses to cases that have been destroyed
752 but have been kept around by another user's ref-count. This often
753 happens when the data set is small enough to find in memory; if a
754 bigger data set that would overflow to disk were used, then data
755 corruption would occur.
757 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
761 * case.c (case_unshare): Make it check internally whether the
762 ref_cnt is greater than 1, so that the callers don't have to.
763 Update callers not to check.
765 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
767 Before, I was thinking that I might want to get rid of reference
768 counting at some point. Now, I'm pretty sure that it's here to
769 stay. Thus, because we have to store the value_cnt anyway for
770 reference-counted cases, we might as well expose it to users.
772 * case.c (case_get_value_cnt): New function.
773 (case_resize): Drop OLD_CNT argument. Update all callers. Only
774 resize case if its size actually changed.
776 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
777 instead of peeking inside struct case directly.
778 (casefile_append): Ditto.
780 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
782 Get rid of the inlines for the case functions, which made the
783 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
784 the inlines didn't speed up "make check" at all, which is not a
785 perfect benchmark but seems indicative.)
787 * case.c: Remove #ifdef DEBUGGING...#endif around many function
788 definitions. Remove some assertions on nonnull pointers that were
789 redundant with a pointer dereference soon after in the function.
791 (struct case_data): Move definition here from case.h.
795 (case_data_wr): Ditto.
797 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
799 * automake.mk: Add casedeque.h to sources.
801 * casedeque.h: New file.
803 * procedure.c: (struct dataset) Change lag_count, lag_head,
804 lag_queue member into single struct casedeque member. Update all
805 users to use the casedeque instead.
808 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
810 * procedure.c: Simplify lagged cases interface. Updated all
811 clients--well, the only client--to use the simplified interface.
812 (dataset_n_lag) Removed.
813 (dataset_set_n_lag) Removed.
814 (dataset_need_lag) New function.
816 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
818 * dictionary.c procedure.c: More changes to ensure that callbacks occur
819 whenever appropriate, but only when the dataset/dictionary is in a
822 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
824 * dictionary.c dictionary.h : Added callbacks for change of filter and
825 split variables. Refactored some code to ensure that callbacks get
826 invoked when appropriate.
828 * procedure.c (proc_cancel_temporary_transformations): Make sure that
829 replace_dict callback occurs when permanent_dict replaces the current
832 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
834 * dictionary.c dictionary.h : Added callback for when the weight
835 variable of a dictionary changes.
837 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
839 * dictionary.c dictionary.h : Added replace_source and replace_dict
840 callbacks, and functions to deal with them.
842 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
844 Simplify missing value handling.
846 * missing-values.h (enum mv_class): New type.
847 (enum mv_type): Moved definition into missing-values.c and renamed
848 each MV_* to MVT_*, to distinguish them from the exposed mv_class
849 enums. Updated all uses.
850 (struct missing_values): Changed type of `type' from `enum
851 mv_type' to `int' because the definition is no longer exposed.
853 * missing-values.c (mv_is_value_missing): Add new enum mv_class
854 parameter. Update all callers.
855 (mv_is_num_missing): Ditto.
856 (mv_is_str_missing): Ditto.
857 (mv_is_value_user_missing): Removed. Changed callers to use
859 (mv_is_num_user_missing): Removed. Changed callers to use
861 (mv_is_str_user_missing): Removed. Changed callers to use
863 (mv_is_value_system_missing): Removed. Changed callers to use
865 (mv_set_type): Removed. Changed callers to use mv_clear.
866 (mv_clear): New function.
868 * variable.c (var_is_value_missing): Add new enum mv_class
869 parameter. Update all callers.
870 (var_is_num_missing): Ditto.
871 (var_is_str_missing): Ditto.
872 (var_is_value_user_missing): Removed. Changed callers to use
873 var_is_value_missing.
874 (var_is_num_user_missing): Removed. Changed callers to use
876 (var_is_str_user_missing): Removed. Changed callers to use
878 (var_is_value_system_missing): Removed. Changed callers to use
879 var_is_value_missing.
881 * casefilter.c (struct casefilter): Use enum mv_class in place of
883 (casefilter_variable_missing): Adapt to new member.
884 (casefilter_create): Change signature to take enum mv_class,
887 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
889 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
891 * case-sink.c case-sink.h procedure.c procedure.h
892 storage-stream.c: Now uses the factory.
894 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
896 Make it possible to pull cases from the active file with a
897 function call, instead of requiring indirection through a callback
900 * case-source.h (struct case_source_class): Change ->read function
901 to return a single case, instead of calling a callback function
902 for each case. Change ->destroy function to return an error
905 * case-source.c (free_case_source): Pass along the value returned
906 by the case_source ->destroy function.
908 * procedure.c (struct write_case_data): Removed.
909 (struct dataset): Added some members to track procedure state.
910 (procedure): Optimize the trivial case at this level.
911 (internal_procedure): Re-implement in terms of proc_open,
912 proc_read, proc_close.
913 (proc_open) New function.
914 (proc_read) New function.
915 (proc_close) New function.
916 (write_case) Moved into proc_read.
917 (close_active_file) Moved closing of data source into proc_close.
919 * storage-source.c: Rewrote to conform with modified
920 case_source_class interface.
922 * transformations.c (trns_chain_execute): Added argument to allow
923 starting execution from an arbitrary transformation. Updated
926 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
928 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
930 * sys-file-reader.c (read_display_parameters): Don't assume that
931 MEASURE_* and ALIGN_* have the same values found in system files.
933 * sys-file-writer.c (write_variable_display_parameters): Ditto.
935 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
936 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
937 the value of n_MEASURES, which was off by 1 (at least from my
940 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
942 * dictionary.c dictionary.h vardict.h variable.c: Added optional
943 callbacks which are invoked when the dictionary or its
944 variables are changed.
946 * missing-values.c missing-values.h value-labels.c: Tidied up
947 consistency checks, and made some of them return false
948 instead of assert-failing.
950 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
952 * calendar.c (calendar_days_in_month): New function.
954 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
956 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
957 the value label's width.
959 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
961 * sfm-private.h: Move contents into sys-file-writer.c, which is
962 the only remaining user. Removed Borland C++-specific directives.
964 * sys-file-reader.c: Clean up and rewrite entire file. The
965 rewritten version is simpler and better abstracted, and should be
966 easier to maintain and extend. It avoids using structures to read
967 file data, which is prone to padding variations among compilers.
968 It should also handle non-IEEE 754 system files, although I
969 haven't been able to find any. It has been tested against many
970 .sav files obtained from the Web and found to produce the same
971 results as the earlier version of the code, or in some cases
972 improved results. It is more tolerant of format variations found
975 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
976 member, putting an enum integer_format in its place. New member
977 `float_format'. Changed `compressed' member to type bool.
979 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
981 * dictionary.c (dict_delete_consecutive_vars): New function.
983 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
985 * file-name.c (fn_search_path): Remove prefix arg that was unused
986 by any caller. Updated all callers.
988 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
990 * format.c (fmt_dollar_template): Use user's decimal point
991 character. Add assertion.
993 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
995 * format.c (fmt_dollar_template): New function, based on
996 dollar_format_template from var-type-dialog.c.
998 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1000 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1003 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1005 Finish converting struct variable to an opaque type. In this
1006 phase, we add remaining setter and getter functions, convert the
1007 remaining PSPP code to use them, and do a bunch of cleanup. The
1008 resulting changes are pervasive but mostly trivial, and only the
1009 notable changes are logged.
1011 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1014 * case.c (case_data): Renamed case_data_idx.
1015 (case_num): Renamed case_num_idx.
1016 (case_str): Renamed case_str_idx.
1017 (case_data_rw): Renamed case_data_rw_idx.
1019 * case.h (case_data): New function with old name and an interface
1020 that takes a variable instead of an index, which is easier to
1021 use. Updated all callers to use the new interface, or to use the
1022 new *_idx function (see above).
1025 (case_data_rw): Ditto.
1027 * category.c (cat_stored_values_destroy): Changed interface to
1028 take a struct cat_vals * instead of a struct variable *.
1030 * dictionary.c (dict_clone): Use new vector_clone function.
1031 (dict_clear) Use new var_destroy function.
1032 (add_var) New function.
1033 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1034 (dict_create_var_assert) Rewrite in terms of add_var.
1035 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1036 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1037 (dict_lookup_var) Use new var_create, var_destroy functions.
1038 (dict_contains_var) Rewrite in terms of new vardict functionality.
1039 (set_var_dict_index) New function.
1040 (set_var_case_index) New function.
1041 (reindex_vars) New function.
1042 (dict_delete_var) Rewrite in terms of new vardict functionality.
1043 (dict_reorder_var) Ditto.
1044 (dict_reorder_vars) Ditto.
1045 (rename_var) New function.
1046 (dict_rename_var) Use rename_var.
1047 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1048 (dict_get_compacted_idx_to_fv) Rename
1049 dict_get_compacted_dict_index_to_case_index, update callers.
1050 (dict_create_vector) Use new vector_create function.
1051 (dict_clear_vectors) Use new vector_destroy function.
1052 (set_var_short_name_suffix) Move here from variable.c, renamed
1053 from var_set_short_name_suffix, make static, update caller.
1055 * sys-file-private.c: New file.
1056 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1057 width_to_bytes, update callers.
1059 * sys-file-private.h: New file. Later it will supplant
1060 sfm-private.h; for now it supplements it.
1061 (macro MIN_VERY_LONG_STRING) New macro.
1062 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1064 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1065 MAX_LONG_STRING was used before.
1067 * sys-file-writer.c: Ditto.
1069 * value-labels.c: Change the paradigm here to be that a null
1070 pointer is OK for a struct val_labs * in most cases; it just
1071 represents an empty set of value labels.
1072 (val_labs_copy) A copy of a null set is a null set.
1073 (val_labs_count) A null set has 0 labels.
1074 (val_labs_replace) Change return type to void. Rewrite for
1076 (val_labs_find) A null set does not contain the value.
1077 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1078 transposed argument order, updated all callers.
1080 * value.c: New file.
1081 (value_dup) Moved here from variable.c.
1082 (compare_values) Ditto.
1085 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1086 (macro MAX_LONG_STRING) Removed, because it was only interesting
1087 for system files, not for general code.
1088 (macro MAX_VERY_LONG_STRING) Ditto.
1089 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1090 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1092 * vardict.h: New file, for an interface between variables and
1095 * variable.c: A lot of functions were moved around, for better
1097 (struct variable) Move definition here, from variable.h.
1098 (var_type_adj) Removed--makes i18n hard.
1099 (var_type_noun) Ditto.
1100 (var_create) New function.
1101 (var_clone) New function.
1102 (var_destroy) New function.
1103 (var_set_name) Assert that variable is not in a dictionary.
1104 (compare_var_names) Rename compare_vars_by_name and fix a couple
1105 of callers who thought the args were strings.
1106 (hash_var_name) Rename hash_var_by_name.
1107 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1108 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1109 (var_is_very_long_string) Removed, because it was only interesting
1110 to system file code.
1111 (var_set_missing_values) Allow the argument to be the wrong width,
1112 as long as we can resize it. Simplify callers who were doing the
1113 resizing themselves.
1114 (var_get_value_labels) New function.
1115 (var_has_value_labels) New function.
1116 (var_set_value_labels) New function.
1117 (alloc_value_labels) New function.
1118 (var_add_value_label) New function.
1119 (var_replace_value_label) New function.
1120 (var_clear_value_labels) New function.
1121 (var_lookup_value_label) New function.
1122 (var_get_value_name) Moved here from variable.c, renamed from
1123 var_get_value_name, transposed argument order, updated all
1125 (var_to_string) Moved here, from variable-label.c.
1126 (var_set_leave) New function.
1127 (var_get_leave) New function.
1128 (var_must_leave) New function.
1129 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1130 set_var_short_name_suffix.
1131 (var_get_dict_index) New function.
1132 (var_get_case_index) New function.
1133 (var_get_obs_vals) New function.
1134 (var_set_obs_vals) New function.
1135 (var_has_obs_vals) New function.
1136 (var_get_vardict) New function.
1137 (var_set_vardict) New function.
1138 (var_has_vardict) New function.
1139 (var_clear_vardict) New function.
1140 (value_dup) Moved to value.c.
1141 (compare_values) Ditto.
1144 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1145 (enum ALPHA) Rename VAR_STRING, update all users.
1147 * vector.c: New file.
1148 (struct vector) Moved here, from variable.h.
1149 (check_widths) New function.
1150 (vector_create) New function.
1151 (vector_clone) New function.
1152 (vector_destroy) New function.
1153 (vector_get_name) New function.
1154 (vector_get_var) New function.
1155 (vector_get_var_cnt) New function.
1156 (compare_vector_ptrs_by_name) New function.
1158 * vector.h: New file.
1160 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1162 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1163 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1166 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1168 * value-labels.c (destroy_atoms): New function.
1169 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1171 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1173 Thanks to Jason Stover for pointing out this problem.
1175 * data-out.c (output_number): Use gsl_finite from GSL, which is
1176 portable, instead of isfinite, which is not.
1179 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1181 * variable.c variable.h (value_dup): New function.
1183 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1185 Start converting struct variable to an opaque type. In this
1186 phase, we add a bunch of setter and getter functions and convert
1187 most of the PSPP code to use them. The resulting changes are
1188 pervasive but mostly trivial, and only the notable changes are
1191 * format.c (fmt_equal): New function.
1193 * variable.c (var_type_is_valid): New function.
1194 (measure_is_valid) Moved here, from format.c.
1195 (alignment_is_valid) Moved here, from format.c.
1196 (var_get_name) New function.
1197 (var_set_name) New function.
1198 (width_to_type) New function.
1199 (var_get_type) New function.
1200 (var_get_width) New function.
1201 (var_set_width) New function.
1202 (var_is_numeric) New function.
1203 (var_is_alpha) New function.
1204 (var_is_short_string) New function.
1205 (var_is_long_string) New function.
1206 (var_is_very_long_string) New function.
1207 (var_get_missing_values) New function.
1208 (var_set_missing_values) New function.
1209 (var_clear_missing_values) New function.
1210 (var_has_missing_values) New function.
1211 (var_is_value_missing) New function.
1212 (var_is_num_missing) New function.
1213 (var_is_str_missing) New function.
1214 (var_is_value_user_missing) New function.
1215 (var_is_num_user_missing) New function.
1216 (var_is_str_user_missing) New function.
1217 (var_is_value_system_missing) New function.
1218 (var_get_print_format) New function.
1219 (var_set_print_format) New function.
1220 (var_get_write_format) New function.
1221 (var_set_write_format) New function.
1222 (var_set_both_formats) New function.
1223 (var_get_label) New function.
1224 (var_set_label) New function.
1225 (var_clear_label) New function.
1226 (var_has_label) New function.
1227 (var_get_measure) New function.
1228 (var_set_measure) New function.
1229 (var_get_display_width) New function.
1230 (var_set_display_width) New function.
1231 (var_get_alignment) New function.
1232 (var_set_alignment) New function.
1233 (var_get_value_cnt) New function.
1234 (var_get_leave) New function.
1235 (var_get_short_name) New function.
1237 * variable.h: (struct variable) Removed "type" and "nv" members;
1238 they are now computed from "width" where needed.
1240 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1242 * missing-values.c (mv_resize): Don't write beyond end of the
1243 allocated buffer when resizing a long string.
1245 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1247 Clean up identifier code: don't require identifier enumerations to
1248 be in a particular order; make better use of string library;
1249 expose less of the internals.
1251 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1252 change interface. Updated all callers.
1253 (lex_id_match) Change interface to use struct substring, update
1255 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1256 (global array keywords[]) Make static, change form. Update all
1257 users to use lex_id_name instead.
1258 (lex_is_keyword) New function.
1259 (lex_id_to_token) Change interface to use struct substring, update
1261 (lex_id_name) New function.
1263 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1264 lex_is_keyword instead.
1265 (T_LAST_KEYWORD) Removed.
1266 (T_N_KEYWORDS) Removed.
1268 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1270 * format.c: (fmt_date_template) Distinguish characters for which a
1271 space is output and any date delimiter is allowed on input, from
1272 those for which a space is output and only a space is allowed on
1273 input. The former is represented by X, the latter by a space.
1274 Also, drop distinction between h and H, changing the former to the
1277 * data-in.c: Completely rewrite internals to conform to SPSS input
1278 formats as closely as possible.
1279 (data_in) Changed external interface by replacing the structure
1280 that was used as a single argument by a set of arguments. Updated
1282 (data_in_finite_line) Removed. Converted all callers to use plain
1284 (data_in_get_integer_format) New function.
1285 (data_in_set_integer_format) New function.
1286 (data_in_get_float_format) New function.
1287 (data_in_set_float_format) New function.
1289 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1290 (struct data_in) Removed.
1292 * data-out.c: (output_date) Drop each component from the input as
1293 it is output, to allow us to drop the distinction between h (a
1294 count of hours) and H (the hour of day) template characters.
1295 Also, handle new X template character.
1296 (output_scientific) Follow more rational rule on when to drop
1297 fraction introduced between SPSS 13 and 15. Updated test case to
1300 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1302 Fix buffer overflow reported by John Darrington.
1304 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1305 realize that DIGITS is a count of nibbles, not of bytes.
1307 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1309 * calendar.c (calendar_offset_to_gregorian) Also return the
1310 year-of-day. Change callers to new interface.
1312 * data-out.c: Completely rewrite internals to conform to SPSS
1313 output formats as completely as possible.
1314 (data_out) Change interface to put input parameters before output
1315 parameters, for consistency with the style I now prefer. Update
1317 (data_out_get_integer_format) New public function.
1318 (data_out_set_integer_format) New public function.
1319 (data_out_get_float_format) New public function.
1320 (data_out_set_float_format) New public function.
1322 * data-out.h: New file. Move prototype for data_out here, from
1325 * format.c: (fmt_step_width) Use equality comparison instead of
1326 bitwise and, for clarity.
1327 (fmt_is_string) Ditto.
1328 (fmt_input_to_output) Fix categories that are translated to F
1331 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1333 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1334 casefile-private.h: Added casefilter to assist commands with missing
1337 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1339 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1341 * settings.c: (route_errors_to_terminal) New variable.
1342 (route_errors_to_listing) New variable.
1343 (get_error_routing_to_terminal) New function.
1344 (set_error_routing_to_terminal) New function.
1345 (get_error_routing_to_listing) New function.
1346 (set_error_routing_to_listing) New function.
1348 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1350 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1352 * format.c: Completely rewrite, to achieve better abstraction.
1353 Rewrite all references to formats in other files.
1355 * format.def: Rewrite and reorganize.
1357 * settings.c: Move everything related to custom currency formats
1358 into format.[ch], changing them in form, so as to group related
1359 code and definitions better. Changed all references to use the
1361 (static var decimal) Removed.
1362 (static var grouping) Removed.
1363 (static var cc) Removed.
1364 (get_decimal) Removed.
1365 (set_decimal) Removed.
1366 (get_grouping) Removed.
1367 (set_grouping) Removed.
1371 * settings.h: (macro CC_CNT) Removed.
1372 (macro CC_WIDTH) Removed.
1373 (struct custom_currency) Removed.
1375 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1377 * data-in.c (data_in): Use switch statement instead of table, to
1378 avoid dependence on the order of the FMT_* enums.
1380 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1382 * data-out.c: (num_to_string) Removed, because it was dead code.
1384 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1386 * data-in.c (parse_trailer): Fix error message.
1388 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1390 * format.c (fmt_is_binary): New function.
1392 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1394 * procedure.c procedure.h: Encapsulated the static data into a single
1397 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1399 * casefile.c (casereader_read_xfer): Always initialize the case,
1400 even on an error condition.
1402 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1404 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1405 entire function useless.
1407 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1409 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1410 casereader method casereader_clone.
1412 * procedure.c pransformations.h: Introduced new type casenum_t
1414 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1416 * variable.c: (width_to_bytes) Rephrase code for clarify.
1418 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1420 * format.c: (fmt_type_from_string) New function.
1421 (fmt_to_string) Include decimals in output if the format has
1422 decimals, even if the format type does not. This way, we can
1423 accurately reproduce incorrect formats in user output.
1424 (check_common_specifier) Make the check for a bad format type an
1425 assertion, so we get bug reports if they show up. Fix message.
1426 Check for decimal places with a format type that doesn't allow
1428 (check_input_specifier) Remove check for FMT_X, which has been
1430 (check_output_specifier) Ditto.
1432 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1434 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1435 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1436 (enum fmt_parse_flags) Removed.
1438 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1440 * casefile.c casefile.h: Converted to an abstract base class.
1441 * casefile-private.h fastfile.c fastfile.h: New files.
1442 * automake.mk procedure.c scratch-writer.c storage-stream.c
1444 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1446 * procedure.c (internal_procedure): Create sink_case with only as
1447 many values as the compacted dictionary.
1449 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1451 Remove "debugging" code that caused plenty of false positives and
1454 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1456 * case.c: Remove all references to `this' member.
1458 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1460 Fix link error noted by Jason Stover.
1462 * storage-stream.c: Include <assert.h>.
1464 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1466 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1467 ALL) and additional underlying system file issues.
1469 Thanks to John Darrington for review.
1471 First problem: var_hash points to variables not owned by the
1472 sys-file-reader, which the caller may free or modify. Use an
1473 array of sfm_vars instead, as done earlier (e.g. CVS version
1476 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1477 members and remove all code that references it. Add vars, var_cnt
1478 members. Remove fix_specials member, which was unused.
1479 (struct sfm_var) Remove name member, which was unused.
1480 (sfm_close_reader) Free vars member instead of var_hash.
1481 (compare_var_shortnames) Removed.
1482 (hash_var_shortname) Removed.
1483 (sfm_open_reader) Fill out vars array.
1484 (compare_var_index) Removed.
1485 (sfm_read_case) Use vars instead of var_hash.
1487 Second problem: we're confused about when we actually have very
1488 long strings, causing us to choose incorrectly between slow path
1489 and fast path in sfm_read_case.
1491 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1492 have very long strings, not when we have long variable names,
1493 which is an unrelated feature.
1495 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1497 * variable.h: Move var_set and variable parsing declarations to
1498 new header, src/language/lexer/variable-parser.h. Modified lots
1499 of files to include the new header.
1501 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1503 * value-labels.c (value_to_string): When there's no value label,
1504 format the variable according to its print format, instead of
1505 always effectively using A or F format.
1507 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1509 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1512 * format.c: Removed tortological assertion.
1514 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1516 Reform string library.
1518 * file-name.c (fn_interp_vars): Change interface to take a
1519 substring as input. Updated all users.
1521 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1523 * format.c (measure_is_valid): Really return false when m >=
1526 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1528 Implement random access to casefiles, for use in GUI.
1530 * casefile.c: (struct casereader) Add `random', `file_ofs',
1531 `buffer_ofs' members.
1532 (casefile_get_random_reader) New function.
1533 (read_open_file) Break part into new function
1534 seek_and_fill_buffer().
1535 (fill_buffer) Update buffer_ofs, file_ofs.
1536 (casereader_seek) New function.
1538 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1540 * settings.c: Added call to i18n{done, init}.
1542 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1544 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1547 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1549 * casefile.c: Convert many uses of `int' to `bool'.
1551 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1553 * transformations.c (trns_chain_destroy): Destroy chain's trns
1554 member, to fix memory leak.
1556 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1558 * storage-stream.c (storage_source_decapsulate): Destroy case
1559 source to fix memory leak.
1561 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1563 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1564 case passed as argument instead of initializing the argument as a
1565 case. Fixes memory leak that showed up in
1566 tests/command/aggregate.sh with scratch files.
1568 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1570 * procedure.c (proc_done): Destroy default_dict, to fix memory
1573 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1575 Simplify procedure_with_splits().
1577 * procedure.c (struct split_aux_data): Removed case_count member.
1578 (procedure_with_splits) Don't initialize case_count.
1579 (split_procedure_case_func) Check whether prev_case is null
1580 instead of case_count.
1581 (split_procedure_end_func) Ditto.
1583 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1585 * case.c (case_move): Do nothing if dst and src are the same
1587 (case_try_create) Merge two similar cases.
1588 (case_copy) Unshare only if data must be actually copied.
1590 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1592 * data-in.c data-out.c dictionary.c sys-file-reader.c
1593 sys-file-writer.c variable.c variable.h: Reworked very long string
1594 support for better encapsulation.
1596 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1598 * value-labels.c (val_labs_can_set_width): New function.
1599 (val_labs_set_width) Clear labels if increasing width to long
1601 (val_labs_destroy) Remove unneeded test for null.
1603 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1605 * value-labels.h: Remove unneeded dependency on variable.h.
1607 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1609 Get rid of `char *c' member in union value, for cleanliness.
1611 * value.h: (union value) Remove `c' member.
1613 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1615 Make dictionary compacting functions a little more general.
1617 * sys-file-writer.c (sfm_open_writer): Use
1618 dict_compacting_would_change().
1619 (does_dict_need_translation) Removed.
1621 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1623 Make dictionary compacting functions a little more general.
1625 * dictionary.c (dict_needs_compaction): Rename
1626 dict_compacting_would_shrink(). Update all callers.
1627 (dict_compacting_would_change) New function.
1629 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1631 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1632 inverted return value (!).
1634 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1636 Continue reforming procedure execution.
1638 * procedure.c: Search and replace "vfm" by "proc". Notably:
1639 (static var vfm_source) Rename proc_source. Update all
1641 (static var vfm_sink) Rename proc_sink. Update all references.
1643 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1645 Continue reforming procedure execution. In this phase, remove
1646 PROCESS IF, which was deprecated anyway and can be easily
1647 simulated with TEMPORARY followed by SELECT IF.
1649 * procedure.c: (open_active_file) Don't call
1650 add_process_if_trns().
1651 (discard_variables) Get rid of redundant call to
1652 proc_cancel_all_transformations().
1653 (add_process_if_trns) Removed.
1654 (process_if_trns_proc) Removed.
1655 (process_if_trns_free) Removed.
1657 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1659 Continue reforming procedure execution. In this phase, add
1660 `const' to the case passed to procedure()'s callback.
1662 Updated all users of procedure() as well.
1664 * procedure.c: (struct write_case_data) Add "const" to ccase
1665 parameter for case_func member.
1666 (procedure) Add "const" to ccase parameter for proc_func
1668 (multipass_case_func) Make ccase parameter const.
1669 (internal_procedure) Add "const" to ccase parameter for case_func
1671 (split_procedure_case_func) Make ccase parameter const.
1672 (multipass_split_case_func) Make ccase parameter const.
1674 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1676 Continue reforming procedure execution. In this phase, get rid of
1677 the output code for SPLIT FILE groups in procedure.c, which really
1678 shouldn't be doing any output. Move it into the individual
1679 procedures instead. This also adds some flexibility.
1681 Updated many users of procedure_with_splits() and
1682 multipass_procedure_with_splits() to call
1683 output_split_file_values() and to deal with increased use of
1686 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1687 parameter to begin_func member.
1688 (procedure_with_splits) Add "const struct ccase *" parameter to
1689 begin_func parameter. Make ccase parameter const in proc_func
1691 (split_procedure_case_func) Don't dump split file group. Pass
1693 (dump_splits) Moved to language/dictionary/split-file.c as
1694 output_split_file_values().
1695 (struct multipass_split_aux_data) Add "const struct ccase *"
1696 parameter to split_func member.
1697 (multipass_procedure_with_splits) Add "const struct ccase *"
1698 parameter to split_func parameter.
1699 (multipass_split_case_func) Save new SPLIT FILE case before
1701 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1703 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1705 Continue reforming procedure execution. Change
1706 internal_procedure() so that it calls open_active_file() and
1707 close_active_file(), which isolates most of the actual procedure
1710 * procedure.c: (struct write_case_data) Rename `proc_func' member
1711 to `case_func' and update all references.
1712 (procedure) Rewrite as one-line wrapper around
1713 internal_procedure().
1714 (struct multipass_aux_data) New.
1715 (multipass_callback) Renamed multipass_case_func(). Use struct
1716 multipass_aux_data as auxiliary data.
1717 (multipass_end_func) New function.
1718 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1719 that uses multipass_case_func, multipass_end_func.
1720 (internal_procedure) Add `end_func' argument. Move optimization
1721 of trivial case in here. Move call to open_active_file() and
1722 close_active_file() in here. Now assert that vfm_source is
1724 (procedure_with_splits_callback) Rename
1725 split_procedure_case_func().
1726 (split_procedure_end_func) New function.
1727 (multipass_split_callback) Rename multipass_split_case_func.
1728 (multipass_split_end_func) New function.
1729 (discard_variables) No need to test for nonnull vfm_source.
1731 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1733 Continue reforming procedure execution. Get rid of unused member.
1735 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1737 (write_case) Don't increment cases_analyzed.
1739 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1741 Continue reforming procedure execution. In this phase, move
1742 procedure.c and procedure.h from src to src/data. Update
1743 makefiles and #includes accordingly.
1745 * procedure.c: Moved here from src/.
1747 * procedure.h: Moved here from src/.
1749 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1751 Continue reforming procedure execution. In this phase, get rid of
1752 many global variables, consolidating procedure execution in
1753 procedure.c. Encapsulate transformations in new "struct
1754 trns_chain". Also, change implementation of N OF CASES, FILTER,
1755 and PROCESS IF from special cases to transformations.
1757 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1760 * dictionary.c: (global variable default_dict) Move to
1763 * variable.h: (TRNS_*) Move to transformations.h.
1764 (struct transformation) Move to transformations.c.
1766 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1768 * sys-file-reader.c: Fixed invalid read problems.
1770 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1772 * storage-stream.c: Add missing function comments.
1774 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1776 Continue reforming procedure execution. In this phase, add some
1777 new, needed functionality to storage-stream.
1779 * storage-stream.c: (storage_source_decapsulate) New function.
1781 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1783 * variable.c (width_to_bytes): Declarations must precede
1784 statements for C90 compliance.
1786 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1788 * data-out.c, data-in.c, variable.c, variable.h: New functions
1789 copy_mangle and copy_demangle for reading/writing cases; emulates the
1790 way SPSS deals with strings > 255 bytes.
1792 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1793 subtype 14 needed for strings longer than 255 bytes.
1795 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1796 instead of literal values. Also fixed some constness issues.
1798 * format.h: Constness
1800 * sfm-private.h: Renamed the case_size identifier, since I discovered
1801 that SPSS's respect for this variable is very nominal.
1803 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1805 Change case limit type from int to size_t.
1807 * dictionary.c: (struct dictionary) Change type of case_limit
1809 (dict_get_case_limit) Change return type.
1810 (dict_set_case_limit) Change parameter type.
1812 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1814 * variable.h: (struct variable) Rename `reinit' member as `leave'
1815 and invert sense. Fix up all references.
1817 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1819 Continue reforming procedure execution. In this phase, break
1820 procedure.c into multiple files.
1822 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1824 * case-sink.c: New file.
1826 * case-sink.h: New file.
1828 * case-source.c: New file.
1830 * case-source.h: New file.
1832 * storage-stream.c: New file.
1834 * storage-stream.h: New file.
1836 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1838 * variable.h: (struct variable) Remove `init' member and all
1839 references to it from other files. It was initialized in several
1840 places, but nothing really ever used it for anything worthwhile.
1841 Thanks to Jason Stover for pointing out how confusing this
1844 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1846 Continue reforming error message support. In this phase, get rid
1847 of message "titles" and put the message text in `struct error'.
1848 Now `struct error' encapsulates a message more properly.
1850 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1851 Format message ourselves.
1853 * data-in.c: (vdls_error) Ditto.
1855 * por-file-reader.c: (error) Ditto.
1857 * sys-file-reader.c: (corrupt_msg) Ditto.
1859 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1861 GNU standards require "file name" instead of "filename" in
1862 documentation. It's nice for our code to follow the convention
1865 * casefile.c: (struct casefile) Rename `filename' member to
1866 `file_name'. Updated all references.
1868 * file-name.c: [!unix] (struct file_identity) Rename
1869 normalized_filename member to normalized_file_name. Updated all
1872 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1874 We don't really support anything but Unix-like environments well,
1875 so we might as well de-obfuscate by writing directory and path
1876 separators explicitly.
1878 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1880 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1881 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1883 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1886 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1888 GNU standards require "file name" instead of "filename" in
1889 documentation. It's nice for our code to follow the convention
1892 * filename.c: Rename to file-name.c.
1894 * filename.h: Rename to file-name.h. Update all inclusions.
1895 Update header guards.
1897 * automake.mk: Update file names.
1899 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1901 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1903 (fn_basename) Removed (dead code).
1904 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1905 (fn_special_p) Renamed fn_is_special(), all references updated.
1906 (fn_exists_p) Renamed fn_exists(), all references updated.
1908 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1910 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1911 Also, now it only tilde-expands file names, not paths.
1912 (fn_search_path) Tilde-expand one directory at a time.
1914 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1916 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1917 get rid of non-Unixlike version of the code, which has probably
1919 (fn_prepend_dir) Removed (dead code).
1921 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1922 (macro PATH_SEPARATOR_STRING) New.
1923 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1925 Continue reforming error message support. In this phase, we get
1926 rid of VM() and the other msg() support for "verbosity", replacing
1927 it by a new function verbose_msg().
1929 * filename.c: (fn_search_path) Use verbose_msg() instead of
1932 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1934 * sfm-private.h: Get rid of #defines after #error, which makes no
1937 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1939 Get rid of our own int32 type in favor of the standard int32_t
1942 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1945 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1947 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1949 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1951 Remove ill-considered file routines that are no longer used.
1953 * filename.c: (fn_open_ext) Removed.
1954 (fn_close_ext) Removed.
1956 * filename.h: (struct file_ext) Removed.
1958 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1960 * variable.c (var_is_valid_name): Move declarations before code
1963 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1965 * filename.ch (fn_interp_vars): Fixed small buglet.
1967 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1969 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1970 so as to modify the string inline. Thus makeing it easier to
1971 destroy the results when no longer needed.
1973 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1975 * category.c (cat_stored_values_destroy): Fixed memory leak.
1977 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1979 Add some missing frees. Thanks to John Darrington for reporting
1982 * any-writer.c (any_writer_close): Free writer.
1984 * any-reader.c (any_reader_close): Free reader.
1986 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1988 * por-file-reader.c: (error) Mark as NO_RETURN.
1990 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1992 * settings.c: Changed default value of scompress to true.
1994 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1996 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1998 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2001 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2002 here from pref.h.orig.
2004 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2006 * sys-file-reader.c: Fixed bug reading compressed files.
2008 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2010 * Numerous renames. See src/ChangeLog for details.
2012 * Moved files from src directory