1 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
3 * procedure.c (proc_done): Destroy default_dict, to fix memory
6 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
8 Simplify procedure_with_splits().
10 * procedure.c (struct split_aux_data): Removed case_count member.
11 (procedure_with_splits) Don't initialize case_count.
12 (split_procedure_case_func) Check whether prev_case is null
13 instead of case_count.
14 (split_procedure_end_func) Ditto.
16 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
18 * case.c (case_move): Do nothing if dst and src are the same
20 (case_try_create) Merge two similar cases.
21 (case_copy) Unshare only if data must be actually copied.
23 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
25 * data-in.c data-out.c dictionary.c sys-file-reader.c
26 sys-file-writer.c variable.c variable.h: Reworked very long string
27 support for better encapsulation.
29 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
31 * value-labels.c (val_labs_can_set_width): New function.
32 (val_labs_set_width) Clear labels if increasing width to long
34 (val_labs_destroy) Remove unneeded test for null.
36 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
38 * value-labels.h: Remove unneeded dependency on variable.h.
40 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
42 Get rid of `char *c' member in union value, for cleanliness.
44 * value.h: (union value) Remove `c' member.
46 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
48 Make dictionary compacting functions a little more general.
50 * sys-file-writer.c (sfm_open_writer): Use
51 dict_compacting_would_change().
52 (does_dict_need_translation) Removed.
54 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
56 Make dictionary compacting functions a little more general.
58 * dictionary.c (dict_needs_compaction): Rename
59 dict_compacting_would_shrink(). Update all callers.
60 (dict_compacting_would_change) New function.
62 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
64 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
65 inverted return value (!).
67 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
69 Continue reforming procedure execution.
71 * procedure.c: Search and replace "vfm" by "proc". Notably:
72 (static var vfm_source) Rename proc_source. Update all
74 (static var vfm_sink) Rename proc_sink. Update all references.
76 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
78 Continue reforming procedure execution. In this phase, remove
79 PROCESS IF, which was deprecated anyway and can be easily
80 simulated with TEMPORARY followed by SELECT IF.
82 * procedure.c: (open_active_file) Don't call
83 add_process_if_trns().
84 (discard_variables) Get rid of redundant call to
85 proc_cancel_all_transformations().
86 (add_process_if_trns) Removed.
87 (process_if_trns_proc) Removed.
88 (process_if_trns_free) Removed.
90 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
92 Continue reforming procedure execution. In this phase, add
93 `const' to the case passed to procedure()'s callback.
95 Updated all users of procedure() as well.
97 * procedure.c: (struct write_case_data) Add "const" to ccase
98 parameter for case_func member.
99 (procedure) Add "const" to ccase parameter for proc_func
101 (multipass_case_func) Make ccase parameter const.
102 (internal_procedure) Add "const" to ccase parameter for case_func
104 (split_procedure_case_func) Make ccase parameter const.
105 (multipass_split_case_func) Make ccase parameter const.
107 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
109 Continue reforming procedure execution. In this phase, get rid of
110 the output code for SPLIT FILE groups in procedure.c, which really
111 shouldn't be doing any output. Move it into the individual
112 procedures instead. This also adds some flexibility.
114 Updated many users of procedure_with_splits() and
115 multipass_procedure_with_splits() to call
116 output_split_file_values() and to deal with increased use of
119 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
120 parameter to begin_func member.
121 (procedure_with_splits) Add "const struct ccase *" parameter to
122 begin_func parameter. Make ccase parameter const in proc_func
124 (split_procedure_case_func) Don't dump split file group. Pass
126 (dump_splits) Moved to language/dictionary/split-file.c as
127 output_split_file_values().
128 (struct multipass_split_aux_data) Add "const struct ccase *"
129 parameter to split_func member.
130 (multipass_procedure_with_splits) Add "const struct ccase *"
131 parameter to split_func parameter.
132 (multipass_split_case_func) Save new SPLIT FILE case before
134 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
136 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
138 Continue reforming procedure execution. Change
139 internal_procedure() so that it calls open_active_file() and
140 close_active_file(), which isolates most of the actual procedure
143 * procedure.c: (struct write_case_data) Rename `proc_func' member
144 to `case_func' and update all references.
145 (procedure) Rewrite as one-line wrapper around
146 internal_procedure().
147 (struct multipass_aux_data) New.
148 (multipass_callback) Renamed multipass_case_func(). Use struct
149 multipass_aux_data as auxiliary data.
150 (multipass_end_func) New function.
151 (multipass_procedure) Rewrite as wrapper for internal_procedure()
152 that uses multipass_case_func, multipass_end_func.
153 (internal_procedure) Add `end_func' argument. Move optimization
154 of trivial case in here. Move call to open_active_file() and
155 close_active_file() in here. Now assert that vfm_source is
157 (procedure_with_splits_callback) Rename
158 split_procedure_case_func().
159 (split_procedure_end_func) New function.
160 (multipass_split_callback) Rename multipass_split_case_func.
161 (multipass_split_end_func) New function.
162 (discard_variables) No need to test for nonnull vfm_source.
164 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
166 Continue reforming procedure execution. Get rid of unused member.
168 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
170 (write_case) Don't increment cases_analyzed.
172 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
174 Continue reforming procedure execution. In this phase, move
175 procedure.c and procedure.h from src to src/data. Update
176 makefiles and #includes accordingly.
178 * procedure.c: Moved here from src/.
180 * procedure.h: Moved here from src/.
182 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
184 Continue reforming procedure execution. In this phase, get rid of
185 many global variables, consolidating procedure execution in
186 procedure.c. Encapsulate transformations in new "struct
187 trns_chain". Also, change implementation of N OF CASES, FILTER,
188 and PROCESS IF from special cases to transformations.
190 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
193 * dictionary.c: (global variable default_dict) Move to
196 * variable.h: (TRNS_*) Move to transformations.h.
197 (struct transformation) Move to transformations.c.
199 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
201 * sys-file-reader.c: Fixed invalid read problems.
203 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
205 * storage-stream.c: Add missing function comments.
207 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
209 Continue reforming procedure execution. In this phase, add some
210 new, needed functionality to storage-stream.
212 * storage-stream.c: (storage_source_decapsulate) New function.
214 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
216 * variable.c (width_to_bytes): Declarations must precede
217 statements for C90 compliance.
219 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
221 * data-out.c, data-in.c, variable.c, variable.h: New functions
222 copy_mangle and copy_demangle for reading/writing cases; emulates the
223 way SPSS deals with strings > 255 bytes.
225 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
226 subtype 14 needed for strings longer than 255 bytes.
228 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
229 instead of literal values. Also fixed some constness issues.
231 * format.h: Constness
233 * sfm-private.h: Renamed the case_size identifier, since I discovered
234 that SPSS's respect for this variable is very nominal.
236 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
238 Change case limit type from int to size_t.
240 * dictionary.c: (struct dictionary) Change type of case_limit
242 (dict_get_case_limit) Change return type.
243 (dict_set_case_limit) Change parameter type.
245 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
247 * variable.h: (struct variable) Rename `reinit' member as `leave'
248 and invert sense. Fix up all references.
250 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
252 Continue reforming procedure execution. In this phase, break
253 procedure.c into multiple files.
255 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
257 * case-sink.c: New file.
259 * case-sink.h: New file.
261 * case-source.c: New file.
263 * case-source.h: New file.
265 * storage-stream.c: New file.
267 * storage-stream.h: New file.
269 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
271 * variable.h: (struct variable) Remove `init' member and all
272 references to it from other files. It was initialized in several
273 places, but nothing really ever used it for anything worthwhile.
274 Thanks to Jason Stover for pointing out how confusing this
277 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
279 Continue reforming error message support. In this phase, get rid
280 of message "titles" and put the message text in `struct error'.
281 Now `struct error' encapsulates a message more properly.
283 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
284 Format message ourselves.
286 * data-in.c: (vdls_error) Ditto.
288 * por-file-reader.c: (error) Ditto.
290 * sys-file-reader.c: (corrupt_msg) Ditto.
292 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
294 GNU standards require "file name" instead of "filename" in
295 documentation. It's nice for our code to follow the convention
298 * casefile.c: (struct casefile) Rename `filename' member to
299 `file_name'. Updated all references.
301 * file-name.c: [!unix] (struct file_identity) Rename
302 normalized_filename member to normalized_file_name. Updated all
305 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
307 We don't really support anything but Unix-like environments well,
308 so we might as well de-obfuscate by writing directory and path
309 separators explicitly.
311 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
313 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
314 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
316 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
319 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
321 GNU standards require "file name" instead of "filename" in
322 documentation. It's nice for our code to follow the convention
325 * filename.c: Rename to file-name.c.
327 * filename.h: Rename to file-name.h. Update all inclusions.
328 Update header guards.
330 * automake.mk: Update file names.
332 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
334 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
336 (fn_basename) Removed (dead code).
337 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
338 (fn_special_p) Renamed fn_is_special(), all references updated.
339 (fn_exists_p) Renamed fn_exists(), all references updated.
341 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
343 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
344 Also, now it only tilde-expands file names, not paths.
345 (fn_search_path) Tilde-expand one directory at a time.
347 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
349 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
350 get rid of non-Unixlike version of the code, which has probably
352 (fn_prepend_dir) Removed (dead code).
354 * filename.h: (macro DIR_SEPARATOR_STRING) New.
355 (macro PATH_SEPARATOR_STRING) New.
356 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
358 Continue reforming error message support. In this phase, we get
359 rid of VM() and the other msg() support for "verbosity", replacing
360 it by a new function verbose_msg().
362 * filename.c: (fn_search_path) Use verbose_msg() instead of
365 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
367 * sfm-private.h: Get rid of #defines after #error, which makes no
370 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
372 Get rid of our own int32 type in favor of the standard int32_t
375 * sfm-private.h: (int32 macro) Don't define this anymore. Do
378 * sys-file-reader.c: Use int32_t instead of int32 throughout.
380 * sys-file-writer.c: Use int32_t instead of int32 throughout.
382 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
384 Remove ill-considered file routines that are no longer used.
386 * filename.c: (fn_open_ext) Removed.
387 (fn_close_ext) Removed.
389 * filename.h: (struct file_ext) Removed.
391 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
393 * variable.c (var_is_valid_name): Move declarations before code
396 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
398 * filename.ch (fn_interp_vars): Fixed small buglet.
400 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
402 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
403 so as to modify the string inline. Thus makeing it easier to
404 destroy the results when no longer needed.
406 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
408 * category.c (cat_stored_values_destroy): Fixed memory leak.
410 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
412 Add some missing frees. Thanks to John Darrington for reporting
415 * any-writer.c (any_writer_close): Free writer.
417 * any-reader.c (any_reader_close): Free reader.
419 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
421 * por-file-reader.c: (error) Mark as NO_RETURN.
423 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
425 * settings.c: Changed default value of scompress to true.
427 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
429 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
431 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
434 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
435 here from pref.h.orig.
437 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
439 * sys-file-reader.c: Fixed bug reading compressed files.
441 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
443 * Numerous renames. See src/ChangeLog for details.
445 * Moved files from src directory