1 2007-10-27 John Darrington <john@darrington.wattle.id.au>
3 * dictionary.c: Fixed bug in dict_clone, where the vardict.dict member
4 wasn't initialised correctly. Closes bugs #21330 and 21397
7 2007-10-08 Ben Pfaff <blp@gnu.org>
9 Fix bug #21280. Thanks to John Darrington for review.
11 * file-name.c (create_stream): New function.
13 * por-file-writer.c (pfm_open_writer): Use fh_open to open the
14 file handle before creating the file, to ensure that we don't
15 truncate a file that we're reading. Make code easier to read by
18 * sys-file-write.c (sfm_open_writer): Ditto.
20 2007-10-01 Ben Pfaff <blp@gnu.org>
22 Fix bug #21192. Thanks to John Darrington for review.
24 * casereader.c (casereader_read): Decrement case_cnt before
25 calling the casereader's "read" member function, so that we
26 interact properly with lazy_casereader.
28 * datasheet.c: Add regression test for above bug fix.
29 (clone_datasheet): New function.
30 (lazy_callback): New function.
31 (check_datasheet_casereader): New function.
32 (check_datasheet): Check datasheet contents are reported correctly
33 through an ordinary casereader and a lazy casereader.
34 (clone_model): Use clone_datasheet.
36 2007-09-24 Ben Pfaff <blp@gnu.org>
38 Patch #6210. Reviewed by John Darrington.
39 * settings.c: Drop "long view", which is not needed any longer.
40 (static var long_view): Removed.
41 (force_long_view): Removed.
42 (get_viewwidth): Removed.
43 (init_viewport): Removed long_view reference.
45 2007-09-19 John Darrington <john@darrington.wattle.id.au>
47 * settings.c settings.h: Changed viewport's length and width to be
48 owned by the user interface which uses the data library. This allows
49 better abstraction, and makes dynamically adjustable dimensions easier.
51 2007-09-18 Ben Pfaff <blp@gnu.org>
53 * procedure.c (proc_extract_active_file_data): New function.
55 * lazy-casereader.h: New file.
57 * lazy-casereader.c: New file.
59 * casereader.c (casereader_dynamic_cast): New function.
61 2007-09-14 Ben Pfaff <blp@gnu.org>
63 * dictionary.c (dict_clone): Copy case indexes from cloned
64 dictionary. Fixes bug #21061. Reviewed by John Darrington.
66 2007-09-13 John Darrington <john@darrington.wattle.id.au>
68 * value.c value.h (create_value): New function.
70 2007-09-12 Ben Pfaff <blp@gnu.org>
72 Make it clear that translator casereader and casewriter translate
73 functions are supposed to destroy their input case.
75 * casereader-translator.c (struct casereader_translator): Change
76 input case parameter of translate member function from const
77 struct ccase * to struct ccase *.
78 (casereader_create_translator): Ditto, for translate parameter.
80 * casewriter-translator.c (struct casewriter_translator): Ditto.
81 (casewriter_create_translator): Ditto.
83 2007-08-27 John Darrington <john@darrington.wattle.id.au>
85 * sys-file-reader.c (read_display_parameters): Force display width
86 to 8, if the sys file says 0 (like SPSS does).
88 2007-08-12 Ben Pfaff <blp@gnu.org>
90 * dictionary.c (dict_dump): New function.
92 2007-08-12 Ben Pfaff <blp@gnu.org>
94 Drop dict_compactor in favor of using the new struct case_map.
96 * dictionary.c (struct copy_map): Removed.
97 (struct dict_compactor): Removed.
98 (dict_make_compactor): Removed.
99 (dict_compactor_compact): Removed.
100 (dict_compactor_destroy): Removed.
102 * procedure.c (struct data_set): Change `compactor' member to be a
104 (proc_open): Use case_map_to_compact_dict instead of
106 (proc_casereader_read): Use case_map_execute instead of
107 dict_compactor_compact.
108 (proc_commit): Use case_map_destroy instead of
109 dict_compactor_destroy.
111 * scratch-writer.c (struct scratch_writer): Change `compactor'
112 member to be a struct case_map *.
113 (scratch_writer_open): Use case_map_to_compact_dict instead of
115 (scratch_writer_casewriter_write): Use case_map_execute instead of
116 dict_compactor_compact.
118 2007-08-12 Ben Pfaff <blp@gnu.org>
120 * automake.mk: Add case-map.c, case-map.h.
122 * case-map.c: New file.
124 * case-map.h: New file.
126 2007-08-12 Ben Pfaff <blp@gnu.org>
128 * dictionary.c (dict_compact_values): Don't delete scratch
129 variables as well as compacting case indexes. Update all callers.
130 (dict_get_compacted_value_cnt): Rename dict_count_values and
131 change interface. Update all callers.
132 (dict_get_compacted_value_cnt): Remove.
133 (dict_compacting_would_shrink): Remove.
134 (dict_compacting_would_change): Remove.
135 (dict_make_compactor): Add new parameter. Update all callers.
137 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
138 instead of dict_count_values, changing an O(N) operation into
141 2007-08-12 Ben Pfaff <blp@gnu.org>
143 * casereader.c (casereader_read): Don't require cases read by a
144 casereader to be exactly the expected size: as long as they're big
147 2007-08-12 Ben Pfaff <blp@gnu.org>
149 Make casewriters keep track of the number of `union value's in
150 each case. This is useful for two reasons: casewriter_write can
151 then check that the case being written is large enough, and later
152 recipients of the casewriter can determine the size of the case.
154 * casewriter-translator.c (casewriter_create_translator): Add
157 * casewriter.c (struct casewriter): Add value_cnt member.
158 (casewriter_write): Check that the case passed in is big enough.
159 (casewriter_get_value_cnt): New function.
160 (casewriter_create): Add value_cnt parameter.
162 2007-08-09 Ben Pfaff <blp@gnu.org>
164 Fix bug reported by Jason Stover.
165 * settings.c: Move get_termcap_viewport and in particular the
166 #include for <curses.h> to the end of the file. curses.h
167 redefines bool on some systems (e.g. OpenBSD), which causes
168 disagreement between uses of bool before its inclusion and
170 Tested by Jason Stover.
172 2007-07-29 Ben Pfaff <blp@gnu.org>
174 Provisional fix for bug #18692 and bug #20161. Reviewed by John
177 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
178 argument (never "rb" or "wb") because SUSv3 says that only those
179 modes are defined, and glibc in fact rejects other modes.
181 Open portable files with fn_open so that they can be read from
182 pipes. Fix missing fh_close call to go along with fh_open.
183 Report an error if the file close reports an error.
184 * por-file-reader.c (close_reader): New function.
185 (por_file_casereader_destroy): Use close_reader.
186 (pfm_open_reader): Open file with fn_open.
188 2007-07-28 Ben Pfaff <blp@gnu.org>
190 Make PSPP able to read all the portable files I could find on the
191 web. Thanks to John Darrington for review. Bug #17620.
192 * por-file-reader.c (struct pfm_reader): New member `line_length'.
193 (error): Print file offset in hexadecimal.
194 (warning): New function.
195 (advance): Treat lines less than 80 bytes long as padded to 80
197 (pfm_open_reader): Call read_documents if we find an "E" record.
198 (convert_format): Convert invalid formats to the default format
199 instead of aborting reading the file.
200 (read_variables): Rename duplicate variable names instead of
201 aborting reading the file.
202 (read_value_label): Allow string variables of different widths to
203 be assigned value labels in the same record. Replace duplicate
204 value labels instead of aborting.
205 (read_documents): New function.
207 * por-file-writer.c (pfm_open_writer): Call write_documents if the
208 dictionary has documents.
209 (write_documents): New function.
211 2007-07-25 Ben Pfaff <blp@gnu.org>
213 Fix bugs related to bug #17213.
215 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
216 since the former is what config.h has. Include the needed ncurses
218 (static var echo) Rename to `do_echo' because the original name is
219 the same as an ncurses identifier.
220 (get_termcap_viewport) Use error instead of msg.
222 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
223 (fn_close): Don't close stdin, stdout, stderr.
225 2007-07-26 John Darrington <john@darrington.wattle.id.au>
227 * procedure.c procedure.h: Added callbacks which get invoked whenever
228 a dataset's transformation chain changes.
230 2007-07-24 Ben Pfaff <blp@gnu.org>
233 * sys-file-writer.c (write_variable_display_parameters): Use new
234 var_default_display_width function to choose display width of
235 segments after the first one in a given variable.
236 * variable.c (var_create): Use var_default_display_width to pick
237 new variable's display width.
238 (var_default_display_width): New function.
239 Reviewed by John Darrington.
241 2007-07-24 Ben Pfaff <blp@gnu.org>
244 * por-file-writer.c (write_variables): Write weight variable.
245 Reviewed by John Darrington.
247 2007-07-23 Ben Pfaff <blp@gnu.org>
249 Improvements to system file reader and writer.
251 First, move all detailed knowledge of very long strings into
252 sys-file-private.[ch], so that this nasty stuff can be isolated.
254 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
255 (EFFECTIVE_VLS_CHUNK): New macro.
256 (min_int): New function.
257 (max_int): New function.
258 (sfm_width_to_bytes): Rewrite.
259 (sfm_width_to_octs): New function.
260 (sfm_segment_alloc_width): New function.
261 (sfm_segment_alloc_bytes): New function.
262 (sfm_segment_used_bytes): New function.
263 (sfm_segment_offset): New function.
264 (sfm_segment_effective_offset): New function.
265 (sfm_dictionary_to_sfm_vars): New function.
267 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
268 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
269 (struct sfm_var): New structure.
271 Next, improvements to the system file reader.
273 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
274 type casenumber. Added `version_major', `version_minor',
277 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
278 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
279 Change `case_cnt' to type casenumber. Removed `has_vls'.
280 (struct sfm_var): Removed.
281 (sfm_open_reader): Don't warn on wrong case size if the file was
282 written by SPSS 13, which tends to get it wrong. Use
283 sfm_dictionary_to_sfm_vars.
284 (read_header): Always output system file info.
285 (read_variable_record): Simplify code for reading missing values.
286 (read_machine_int32_info): Save version numbers from system file
287 into info struct passed as new argument.
288 (read_long_string_map): Restructured to use new sys-file-private
290 (read_value_labels): Use size_overflow_p.
291 (sys_file_casereader_read): Get rid of distinction between fast
292 and slow paths. Use information provided by sys-file-primate's
293 struct sfm_var to simplify code.
294 (skip_whole_strings): New function.
295 (read_int32): Renamed read_int. Changed return value to int.
297 (read_flt64): Renamed read_float. Changed return value to
298 double. Updated all callers.
299 (int32_to_native): Removed. Changed callers to use
301 (flt64_to_double): Removed. Changed callers to use float_convert.
303 Finally, get rid of int32, flt64 terminology and types in system
304 file writer. The former wasn't very useful since a POSIX "int"
305 can hold the whole range of int32 and we generally didn't have a
306 need for it to be exactly-32-bits, just at-least-32-bits. The
307 latter was inconvenient because we had to assume that it could be
308 different from double and thereby convert special values SYSMIS,
309 HIGHEST, LOWEST to and from it in multiple places. Instead, now
310 we just use "int" and "double" in most places, and do conversions,
311 if necessary, very close to where we do I/O. This change meant
312 that the writer code couldn't represent records in the file as C
313 structs any longer, but that's no great loss. The code actually
314 seems to be more readable without them.
316 Simplify the compression buffering code: only buffer as much as
317 necessary, which is no more than eight 8-byte units at any given
320 * sys-file-writer.c (typedef flt64): Removed.
321 (macro second_lowest_flt64): Removed.
322 (struct sysfile_header): Removed.
323 (struct sysfile_variable): Removed.
324 (struct sfm_writer): Removed `needs_translation', `has_vls',
325 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
326 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
327 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
328 compression buffering by `opcodes', `opcode_cnt', `data',
329 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
330 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
331 data writer functions instead of structures.
332 (calc_oct_idx): New function.
333 (write_header): Use simple data writer functions instead of
335 (write_format_spec): Renamed write_format. New argument.
336 (write_variable_continuation_records): New function.
337 (write_variable): Use simple data writer functions instead of
338 structures. Use write_variable_continuation_records. Write
339 entire very long string instead of requiring caller to understand
341 (write_value_labels): Use simple data writer functions instead of
343 (write_documents): Ditto.
344 (write_variable_display_parameters): Use sys-file-private
345 functions to simplify. Use simple data writer functions instead
347 (write_vls_length_table): Use simple data writer functions instead
349 (write_longvar_table): Ditto.
350 (write_rec_7_34): Break into new functions
351 write_integer_info_record, write_float_info_record. Use simple
352 data writer functions instead of structures.
353 (buf_write): Removed.
354 (append_string_max): Removed.
355 (ensure_buf_space): Removed.
356 (sys_file_casewriter_write): Get rid of the distinction between
357 fast and slow paths, which didn't seem to be too useful. Use new
358 functions write_case_uncompressed, write_case_compressed.
359 (put_instruction): Removed.
360 (put_element): Removed.
361 (write_compressed_data): Removed.
362 (close_writer): Use flush_compressed. Only write case count to
363 system file if it will fit in the field.
364 (write_case_compressed): New function.
365 (write_case_uncompressed): New function.
366 (flush_compressed): New function.
367 (put_cmp_opcode): New function.
368 (put_cmp_number): New function.
369 (write_int): New function.
370 (convert_double_to_output_format): New function.
371 (write_float): New function.
372 (write_value): New function.
373 (write_string): New function.
374 (write_bytes): New function.
375 (write_zeros): New function.
376 (write_spaces): New function.
378 Reviewed by John Darrington.
380 2007-07-22 Ben Pfaff <blp@gnu.org>
382 Don't try to write very long strings to portable files. The
383 format does not support it.
385 * por-file-writer.c (MAX_POR_WIDTH): New macro.
386 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
387 (write_format): Add arg to take width to resize format to.
388 (write_value): Limit width of value written to MAX_POR_WIDTH.
389 (write_variables): Limit width of variable and its output formats
391 Reviewed by John Darrington.
393 2007-07-22 Ben Pfaff <blp@gnu.org>
395 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
396 local variable instead of literal 5.
397 Reviewed by John Darrington.
399 2007-07-22 Ben Pfaff <blp@gnu.org>
401 Fix problems with uniqueness of short names in system files with
402 very long string variables. Now a variable may have multiple
405 * automake.mk (src_data_libdata_a_SOURCES): Add new files
406 short-names.c, short-names.h.
408 * dictionary.c (dict_clone): Clone all the short names.
409 (compare_strings): Move into short-names.c.
410 (hash_strings): Ditto.
411 (set_var_short_name_suffix): Ditto.
412 (dict_assign_short_names): Ditto, rename short_names_assign,
413 change to assign all short names.
415 * por-file-writer.c (write_variables): Use short_names_assign
416 instead of dict_assign_short_names.
418 * short-names.c: New file.
420 * short-names.h: New file.
422 * sys-file-private.c (sfm_width_to_segments): New function.
424 * sys-file-reader.c (read_long_var_name_map): Save and restore all
425 the short names, not just the first one.
427 * sys-file-writer.c (cont_var_name): Removed.
428 (sfm_open_writer): Use short_names_assign instead of
429 dict_assign_short_names. Use unique short names assigned by
430 short_names_assign instead of those generated by cont_var_name.
432 * variable.c (struct variable): Remove `short_name' member,
433 replace by `short_names' and `short_name_cnt'.
434 (var_create) Initialize new members.
435 (var_get_short_name_cnt): New function.
436 (var_get_short_name): Now takes an index argument. Changed most
438 (var_set_short_name): Ditto.
439 (var_clear_short_name): Renamed var_clear_short_names, changed to
440 clear all short names.
442 Reviewed by John Darrington.
444 2007-07-22 Ben Pfaff <blp@gnu.org>
446 * variable.c (var_set_width): Use new var_set_width function.
448 * missing-values.c (mv_n_values): Drop assertion, which was not
451 * format.c (fmt_default_for_width): New function.
452 (fmt_resize): New function.
454 Reviewed by John Darrington.
456 2007-07-18 John Darrington <john@darrington.wattle.id.au>
458 * datasheet.c (datasheet_delete_columns): Added assertion to check
459 we're not deleting outside the range of the sheet.
462 * dictionary.c dictionary.h variable.c: Added the ability for string
463 variables to be resized.
465 * vardict.h: Added some prototypes (moved from dictionary.h) as
466 these should only be called by variable.c
469 2007-07-14 John Darrington <john@darrington.wattle.id.au>
471 * sfm-reader.c: Respect case_cnt field in file header.
473 2007-07-01 John Darrington <john@darrington.wattle.id.au>
475 * transformation.c transformation.h (trns_chain_execute): Changed the
476 signature (Patch #6057)
478 2007-06-10 Ben Pfaff <blp@gnu.org>
480 * casereader-filter.c (casereader_filter_destroy): Make sure to
481 write all the remaining excluded cases to the casewriter, if any.
483 * caseinit.c (init_list_destroy): Rewrite.
484 (init_list_clear): Ditto.
486 * casegrouper.c (casegrouper_get_next_group): Always set *reader
487 to null when returning false.
489 2007-06-06 Ben Pfaff <blp@gnu.org>
491 Actually implement the new procedure code and adapt all of its
492 clients to match. Also adapt all of the other case sources and
493 sinks in the tree and their clients to use the
494 casereader/casewriter infrastructure.
496 * automake.mk: Add and remove files.
498 * any-reader.c: Change into a casereader.
499 * por-file-reader.c: Ditto.
500 * scratch-reader.c: Ditto.
501 * sys-file-reader.c: Ditto.
503 * any-writer.c: Change into a casewriter.
504 * por-file-writer.c: Ditto.
505 * scratch-writer.c: Ditto.
506 * sys-file-writer.c: Ditto.
508 * procedure.c: Change to use casereader, casewriter, caseinit, and
509 other new infrastructure.
511 * scratch-handle.c: Adapt to new infrastructure.
513 * case-sink.c: Removed, now dead code.
514 * case-sink.h: Ditto.
515 * case-source.c: Ditto.
516 * case-source.h: Ditto.
517 * casefile-factory.c: Ditto.
518 * casefile-private.h: Ditto.
521 * casefilter.c: Ditto.
522 * casefilter.h: Ditto.
525 * fastfile-factory.c: Ditto.
526 * fastfile-factory.h: Ditto.
527 * storage-stream.c: Ditto.
528 * storage-stream.h: Ditto.
530 2007-06-06 Ben Pfaff <blp@gnu.org>
534 * automake.mk: Add new files.
536 * datasheet.c: New file.
538 * datasheet.h: New file.
540 2007-06-06 Ben Pfaff <blp@gnu.org>
542 Until now, the procedure code has provided a case to the
543 case_source, which has filled in the data values that come from
544 the active file. "Left" data values that don't come from the
545 active file naturally stay the same from case to case, because the
546 procedure code keeps using that same case.
548 One of the compromises that comes with the new procedure code is
549 that the active file allocates and provides its own case, which
550 the procedure code then has to resize to provide room for any
551 other variables that should go in the case and then fill in the
552 values of "left" variables. Then, when we're done with that case,
553 we have to save the values of "left" variables to copy into the
554 next case read from the active file.
556 The caseinit code helps with this.
558 * automake.mk: Add new files.
560 * caseinit.c: New file.
562 * caseinit.h: New file.
564 2007-06-06 Ben Pfaff <blp@gnu.org>
566 * value.h (value_cnt_from_width): New function.
568 * variable.c (var_get_value_cnt): Use new function.
570 2007-06-06 Ben Pfaff <blp@gnu.org>
572 Add casegrouper, to allow cases read from a given casereader to be
573 broken into groups, each of which has its own casereader.
574 Generally cases are grouped based on having equal values for some
577 * automake.mk: Add new files.
579 * casegrouper.c: New file.
581 * casegrouper.h: New file.
583 2007-06-06 Ben Pfaff <blp@gnu.org>
585 Add interface to lexicographical ordering of cases.
587 * automake.mk: Add new files.
589 * case-ordering.c: New file.
591 * case-ordering.h: New file.
593 2007-06-06 Ben Pfaff <blp@gnu.org>
595 Add casereaders and casewriters, the basis of the new data processing
596 implementation. A casereader is a uniform interface to reading cases
597 from a data source; a casewriter is a uniform interface to writing
598 cases to a data sink.
600 * automake.mk: Add new files.
602 * casereader-filter.c: New file.
604 * casereader-provider.h: New file.
606 * casereader-translator.c: New file.
608 * casereader.c: New file.
610 * casereader.h: New file.
612 * casewriter-provider.h: New file.
614 * casewriter-translator.c: New file.
616 * casewriter.c: New file.
618 * casewriter.h: New file.
620 2007-06-06 Ben Pfaff <blp@gnu.org>
622 "casewindow" data structure that extends the deque (from libpspp)
623 of cases with the ability to dump cases to disk if we get too many
626 * automake.mk: Add new files.
628 * casewindow.c: New file.
630 * casewindow.h: New file.
632 2007-06-06 Ben Pfaff <blp@gnu.org>
634 sparse_cases data structure that augments a sparse_array of cases
635 with the ability to dump cases to disk if we get too many cases in
638 * automake.mk: Add new files.
640 * sparse-cases.c: New file.
642 * sparse-cases.h: New file.
644 2007-06-06 Ben Pfaff <blp@gnu.org>
646 Adds a low-level on-disk case array data structure.
648 * automake.mk: Add new files.
650 * case-tmpfile.c: New file.
652 * case-tmpfile.h: New file.
654 2007-06-06 Ben Pfaff <blp@gnu.org>
656 In a couple of places we calculate the maximum number of cases to
657 keep in memory based on the user-defined workspace. Enable
658 centralizing the calculation through a new function.
660 * settings.c (get_workspace_cases): New function.
662 2007-06-06 Ben Pfaff <blp@gnu.org>
664 The casenumber type is defined in transformations.h, but case.h is
665 a more sensible place. Move it.
667 * case.h (CASENUMBER_MAX): New macro.
668 (typedef casenumber): Move here, from transformations.h.
670 2007-06-03 Ben Pfaff <blp@gnu.org>
672 Slightly generalize case_to_values and case_from_values functions.
674 * case.c (case_to_values): Rename case_copy_out, change interface.
675 (case_from_values): Rename case_copy_in, change interface.
677 * fastfile.c (fastfilereader_get_next_case): Update caller.
678 (write_case_to_disk): Ditto.
680 2007-06-02 Ben Pfaff <blp@gnu.org>
682 Clean up after a forgotten part of patch #5829.
684 * casedeque.h: Remove unused file.
686 * automake.mk: Remove casedeque.h from sources.
688 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
690 * category.c: Removed redundant #include
692 2007-05-06 Ben Pfaff <blp@gnu.org>
694 Abstract the documents within a dictionary a little better.
695 Thanks to John Darrington for suggestion, initial version, and
698 * dictionary.c (struct dictionary): Change `documents' member from
699 char * to struct string.
700 (dict_clear): Destroy struct string.
701 (dict_get_documents): Convert struct string to char *.
702 (dict_set_documents): Set struct string. Pad to 80-character
704 (dict_clear_documents): New function.
705 (dict_add_document_line): New function.
706 (dict_get_document_line_cnt): New function.
707 (dict_get_document_line): New function.
709 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
711 * sys-file-reader.c (read_documents): Use new document functions.
713 2007-04-19 John Darrington <john@darrington.wattle.id.au>
715 * sys-file-reader.c: When reading a system file which has no
716 long name table, automatically create one where the long names
717 are the lower case versions of the short names.
719 2007-04-22 Ben Pfaff <blp@gnu.org>
721 * dictionary.c (dict_set_split_vars): dict_destroy expects that
722 dict_clear will free most data related to the dictionary.
723 dict_clear does a decent job, except that dict_set_split_vars on
724 some systems won't actually free the dict's "split" member.
725 Instead, it'll allocate a 1-byte region. Fix this.
727 * value.c (value_copy): New function.
728 (value_set_missing): Ditto.
730 2007-04-22 John Darrington <john@darrington.wattle.id.au>
732 * Deleted existing category.h and moved cat-routines.h into
733 category.h Encapsulated struct cat_vals better.
735 2007-04-19 John Darrington <john@darrington.wattle.id.au>
737 * sys-file-reader.c: When reading a system file which has no
738 long name table, automatically create one where the long names
739 are the lower case versions of the short names.
741 2007-04-16 John Darrington <john@darrington.wattle.id.au>
743 * sys-file-reader.c: Some versions of Other Software seem to
744 produce system files with string variables' measure set to
745 zero. We'll assume these are supposed to be nominal variables.
747 2007-03-30 Ben Pfaff <blp@gnu.org>
749 * procedure.c: Adapt to new deque data structure.
751 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
752 Ben Pfaff <blp@gnu.org>
754 * file-name.c: Mingw compatibility fixes.
755 (fn_search_path): Use ISSLASH instead of comparing against '/'
757 (fn_dir_name): Use dir_name from gnulib.
758 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
759 (fn_get_identity): Use GetFullPathName instead of canonicalize
760 from gnulib, because the latter does not fully support
761 Windows-style path names. Use this implementation based on the
762 detected presence of Windows instead of the absence of Unix, since
763 the new implementation is Windows-specific.
764 (fn_compare_file_identities): In Windows implementation, compare
765 names case-insensitively.
767 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
769 * make-file.c: Don't include mkstemp.h, because gnulib now causes
770 <stdlib.h> to have the same effect.
772 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
774 * por-file-reader.c: Add missing _() around messages.
776 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
778 * make-file.c: Include "mkstemp.h", without which linking on
781 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
783 Reduce platform dependence.
785 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
786 Everywhere we using this, we really should have just depended on
787 the shell to expand tildes.
788 (fn_search_path): Simplify, given that we don't do tilde expansion
790 (fn_normalize): Removed. Caller changed to use the canonicalize
792 (fn_get_cwd): Removed. Only user was fn_normalize.
793 (fn_is_absolute): Really only test for absolute names.
794 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
796 (fn_readlink): Removed, as it was only used fn_normalize.
797 (fn_exists): Assume the stat function is available; gnulib does.
798 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
800 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
802 * dictionary.c (dict_create_vector_assert): New function.
804 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
806 * file-name.c (fn_normalize): Correct name of function
807 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
808 for pointing this out.
810 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
812 We are using a single member in struct file_handle, the "name"
813 field, for more than one purpose. When it begins with '"', it's a
814 file name; otherwise, it's a token that can be used to identify
815 it. When that assertion fires, it's because we searched for the
816 name case-sensitively as a file name (so that there was no match),
817 and then we try to insert it case-insensitively as a token, which
818 fails because duplicates aren't allowed.
820 Solution: break the two purposes into two separate fields. This
821 fixes the problem and likely makes the code easier to read too.
823 Fixes bug #18922. Thanks to John Darrington for bug report and
826 * file-handle-def.c (struct file_handle): New `id' member.
827 (fh_from_name): Rename fh_from_id. Update all callers.
828 (create_handle): New `id' parameter. Update all callers.
829 (fh_create_file): Ditto.
830 (fh_get_id): New function.
832 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
834 * case.c (case_is_null): Change return type to bool.
836 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
840 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
841 reference counting to share data. This makes it easy for
842 valgrind, etc. to find accesses to cases that have been destroyed
843 but have been kept around by another user's ref-count. This often
844 happens when the data set is small enough to find in memory; if a
845 bigger data set that would overflow to disk were used, then data
846 corruption would occur.
848 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
852 * case.c (case_unshare): Make it check internally whether the
853 ref_cnt is greater than 1, so that the callers don't have to.
854 Update callers not to check.
856 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
858 Before, I was thinking that I might want to get rid of reference
859 counting at some point. Now, I'm pretty sure that it's here to
860 stay. Thus, because we have to store the value_cnt anyway for
861 reference-counted cases, we might as well expose it to users.
863 * case.c (case_get_value_cnt): New function.
864 (case_resize): Drop OLD_CNT argument. Update all callers. Only
865 resize case if its size actually changed.
867 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
868 instead of peeking inside struct case directly.
869 (casefile_append): Ditto.
871 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
873 Get rid of the inlines for the case functions, which made the
874 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
875 the inlines didn't speed up "make check" at all, which is not a
876 perfect benchmark but seems indicative.)
878 * case.c: Remove #ifdef DEBUGGING...#endif around many function
879 definitions. Remove some assertions on nonnull pointers that were
880 redundant with a pointer dereference soon after in the function.
882 (struct case_data): Move definition here from case.h.
886 (case_data_wr): Ditto.
888 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
890 * automake.mk: Add casedeque.h to sources.
892 * casedeque.h: New file.
894 * procedure.c: (struct dataset) Change lag_count, lag_head,
895 lag_queue member into single struct casedeque member. Update all
896 users to use the casedeque instead.
899 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
901 * procedure.c: Simplify lagged cases interface. Updated all
902 clients--well, the only client--to use the simplified interface.
903 (dataset_n_lag) Removed.
904 (dataset_set_n_lag) Removed.
905 (dataset_need_lag) New function.
907 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
909 * dictionary.c procedure.c: More changes to ensure that callbacks occur
910 whenever appropriate, but only when the dataset/dictionary is in a
913 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
915 * dictionary.c dictionary.h : Added callbacks for change of filter and
916 split variables. Refactored some code to ensure that callbacks get
917 invoked when appropriate.
919 * procedure.c (proc_cancel_temporary_transformations): Make sure that
920 replace_dict callback occurs when permanent_dict replaces the current
923 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
925 * dictionary.c dictionary.h : Added callback for when the weight
926 variable of a dictionary changes.
928 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
930 * dictionary.c dictionary.h : Added replace_source and replace_dict
931 callbacks, and functions to deal with them.
933 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
935 Simplify missing value handling.
937 * missing-values.h (enum mv_class): New type.
938 (enum mv_type): Moved definition into missing-values.c and renamed
939 each MV_* to MVT_*, to distinguish them from the exposed mv_class
940 enums. Updated all uses.
941 (struct missing_values): Changed type of `type' from `enum
942 mv_type' to `int' because the definition is no longer exposed.
944 * missing-values.c (mv_is_value_missing): Add new enum mv_class
945 parameter. Update all callers.
946 (mv_is_num_missing): Ditto.
947 (mv_is_str_missing): Ditto.
948 (mv_is_value_user_missing): Removed. Changed callers to use
950 (mv_is_num_user_missing): Removed. Changed callers to use
952 (mv_is_str_user_missing): Removed. Changed callers to use
954 (mv_is_value_system_missing): Removed. Changed callers to use
956 (mv_set_type): Removed. Changed callers to use mv_clear.
957 (mv_clear): New function.
959 * variable.c (var_is_value_missing): Add new enum mv_class
960 parameter. Update all callers.
961 (var_is_num_missing): Ditto.
962 (var_is_str_missing): Ditto.
963 (var_is_value_user_missing): Removed. Changed callers to use
964 var_is_value_missing.
965 (var_is_num_user_missing): Removed. Changed callers to use
967 (var_is_str_user_missing): Removed. Changed callers to use
969 (var_is_value_system_missing): Removed. Changed callers to use
970 var_is_value_missing.
972 * casefilter.c (struct casefilter): Use enum mv_class in place of
974 (casefilter_variable_missing): Adapt to new member.
975 (casefilter_create): Change signature to take enum mv_class,
978 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
980 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
982 * case-sink.c case-sink.h procedure.c procedure.h
983 storage-stream.c: Now uses the factory.
985 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
987 Make it possible to pull cases from the active file with a
988 function call, instead of requiring indirection through a callback
991 * case-source.h (struct case_source_class): Change ->read function
992 to return a single case, instead of calling a callback function
993 for each case. Change ->destroy function to return an error
996 * case-source.c (free_case_source): Pass along the value returned
997 by the case_source ->destroy function.
999 * procedure.c (struct write_case_data): Removed.
1000 (struct dataset): Added some members to track procedure state.
1001 (procedure): Optimize the trivial case at this level.
1002 (internal_procedure): Re-implement in terms of proc_open,
1003 proc_read, proc_close.
1004 (proc_open) New function.
1005 (proc_read) New function.
1006 (proc_close) New function.
1007 (write_case) Moved into proc_read.
1008 (close_active_file) Moved closing of data source into proc_close.
1010 * storage-source.c: Rewrote to conform with modified
1011 case_source_class interface.
1013 * transformations.c (trns_chain_execute): Added argument to allow
1014 starting execution from an arbitrary transformation. Updated
1017 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
1019 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
1021 * sys-file-reader.c (read_display_parameters): Don't assume that
1022 MEASURE_* and ALIGN_* have the same values found in system files.
1024 * sys-file-writer.c (write_variable_display_parameters): Ditto.
1026 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
1027 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
1028 the value of n_MEASURES, which was off by 1 (at least from my
1031 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1033 * dictionary.c dictionary.h vardict.h variable.c: Added optional
1034 callbacks which are invoked when the dictionary or its
1035 variables are changed.
1037 * missing-values.c missing-values.h value-labels.c: Tidied up
1038 consistency checks, and made some of them return false
1039 instead of assert-failing.
1041 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
1043 * calendar.c (calendar_days_in_month): New function.
1045 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
1047 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
1048 the value label's width.
1050 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
1052 * sfm-private.h: Move contents into sys-file-writer.c, which is
1053 the only remaining user. Removed Borland C++-specific directives.
1055 * sys-file-reader.c: Clean up and rewrite entire file. The
1056 rewritten version is simpler and better abstracted, and should be
1057 easier to maintain and extend. It avoids using structures to read
1058 file data, which is prone to padding variations among compilers.
1059 It should also handle non-IEEE 754 system files, although I
1060 haven't been able to find any. It has been tested against many
1061 .sav files obtained from the Web and found to produce the same
1062 results as the earlier version of the code, or in some cases
1063 improved results. It is more tolerant of format variations found
1066 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
1067 member, putting an enum integer_format in its place. New member
1068 `float_format'. Changed `compressed' member to type bool.
1070 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
1072 * dictionary.c (dict_delete_consecutive_vars): New function.
1074 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
1076 * file-name.c (fn_search_path): Remove prefix arg that was unused
1077 by any caller. Updated all callers.
1079 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
1081 * format.c (fmt_dollar_template): Use user's decimal point
1082 character. Add assertion.
1084 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1086 * format.c (fmt_dollar_template): New function, based on
1087 dollar_format_template from var-type-dialog.c.
1089 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1091 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1094 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1096 Finish converting struct variable to an opaque type. In this
1097 phase, we add remaining setter and getter functions, convert the
1098 remaining PSPP code to use them, and do a bunch of cleanup. The
1099 resulting changes are pervasive but mostly trivial, and only the
1100 notable changes are logged.
1102 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1105 * case.c (case_data): Renamed case_data_idx.
1106 (case_num): Renamed case_num_idx.
1107 (case_str): Renamed case_str_idx.
1108 (case_data_rw): Renamed case_data_rw_idx.
1110 * case.h (case_data): New function with old name and an interface
1111 that takes a variable instead of an index, which is easier to
1112 use. Updated all callers to use the new interface, or to use the
1113 new *_idx function (see above).
1116 (case_data_rw): Ditto.
1118 * category.c (cat_stored_values_destroy): Changed interface to
1119 take a struct cat_vals * instead of a struct variable *.
1121 * dictionary.c (dict_clone): Use new vector_clone function.
1122 (dict_clear) Use new var_destroy function.
1123 (add_var) New function.
1124 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1125 (dict_create_var_assert) Rewrite in terms of add_var.
1126 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1127 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1128 (dict_lookup_var) Use new var_create, var_destroy functions.
1129 (dict_contains_var) Rewrite in terms of new vardict functionality.
1130 (set_var_dict_index) New function.
1131 (set_var_case_index) New function.
1132 (reindex_vars) New function.
1133 (dict_delete_var) Rewrite in terms of new vardict functionality.
1134 (dict_reorder_var) Ditto.
1135 (dict_reorder_vars) Ditto.
1136 (rename_var) New function.
1137 (dict_rename_var) Use rename_var.
1138 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1139 (dict_get_compacted_idx_to_fv) Rename
1140 dict_get_compacted_dict_index_to_case_index, update callers.
1141 (dict_create_vector) Use new vector_create function.
1142 (dict_clear_vectors) Use new vector_destroy function.
1143 (set_var_short_name_suffix) Move here from variable.c, renamed
1144 from var_set_short_name_suffix, make static, update caller.
1146 * sys-file-private.c: New file.
1147 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1148 width_to_bytes, update callers.
1150 * sys-file-private.h: New file. Later it will supplant
1151 sfm-private.h; for now it supplements it.
1152 (macro MIN_VERY_LONG_STRING) New macro.
1153 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1155 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1156 MAX_LONG_STRING was used before.
1158 * sys-file-writer.c: Ditto.
1160 * value-labels.c: Change the paradigm here to be that a null
1161 pointer is OK for a struct val_labs * in most cases; it just
1162 represents an empty set of value labels.
1163 (val_labs_copy) A copy of a null set is a null set.
1164 (val_labs_count) A null set has 0 labels.
1165 (val_labs_replace) Change return type to void. Rewrite for
1167 (val_labs_find) A null set does not contain the value.
1168 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1169 transposed argument order, updated all callers.
1171 * value.c: New file.
1172 (value_dup) Moved here from variable.c.
1173 (compare_values) Ditto.
1176 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1177 (macro MAX_LONG_STRING) Removed, because it was only interesting
1178 for system files, not for general code.
1179 (macro MAX_VERY_LONG_STRING) Ditto.
1180 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1181 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1183 * vardict.h: New file, for an interface between variables and
1186 * variable.c: A lot of functions were moved around, for better
1188 (struct variable) Move definition here, from variable.h.
1189 (var_type_adj) Removed--makes i18n hard.
1190 (var_type_noun) Ditto.
1191 (var_create) New function.
1192 (var_clone) New function.
1193 (var_destroy) New function.
1194 (var_set_name) Assert that variable is not in a dictionary.
1195 (compare_var_names) Rename compare_vars_by_name and fix a couple
1196 of callers who thought the args were strings.
1197 (hash_var_name) Rename hash_var_by_name.
1198 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1199 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1200 (var_is_very_long_string) Removed, because it was only interesting
1201 to system file code.
1202 (var_set_missing_values) Allow the argument to be the wrong width,
1203 as long as we can resize it. Simplify callers who were doing the
1204 resizing themselves.
1205 (var_get_value_labels) New function.
1206 (var_has_value_labels) New function.
1207 (var_set_value_labels) New function.
1208 (alloc_value_labels) New function.
1209 (var_add_value_label) New function.
1210 (var_replace_value_label) New function.
1211 (var_clear_value_labels) New function.
1212 (var_lookup_value_label) New function.
1213 (var_get_value_name) Moved here from variable.c, renamed from
1214 var_get_value_name, transposed argument order, updated all
1216 (var_to_string) Moved here, from variable-label.c.
1217 (var_set_leave) New function.
1218 (var_get_leave) New function.
1219 (var_must_leave) New function.
1220 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1221 set_var_short_name_suffix.
1222 (var_get_dict_index) New function.
1223 (var_get_case_index) New function.
1224 (var_get_obs_vals) New function.
1225 (var_set_obs_vals) New function.
1226 (var_has_obs_vals) New function.
1227 (var_get_vardict) New function.
1228 (var_set_vardict) New function.
1229 (var_has_vardict) New function.
1230 (var_clear_vardict) New function.
1231 (value_dup) Moved to value.c.
1232 (compare_values) Ditto.
1235 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1236 (enum ALPHA) Rename VAR_STRING, update all users.
1238 * vector.c: New file.
1239 (struct vector) Moved here, from variable.h.
1240 (check_widths) New function.
1241 (vector_create) New function.
1242 (vector_clone) New function.
1243 (vector_destroy) New function.
1244 (vector_get_name) New function.
1245 (vector_get_var) New function.
1246 (vector_get_var_cnt) New function.
1247 (compare_vector_ptrs_by_name) New function.
1249 * vector.h: New file.
1251 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1253 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1254 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1257 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1259 * value-labels.c (destroy_atoms): New function.
1260 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1262 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1264 Thanks to Jason Stover for pointing out this problem.
1266 * data-out.c (output_number): Use gsl_finite from GSL, which is
1267 portable, instead of isfinite, which is not.
1270 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1272 * variable.c variable.h (value_dup): New function.
1274 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1276 Start converting struct variable to an opaque type. In this
1277 phase, we add a bunch of setter and getter functions and convert
1278 most of the PSPP code to use them. The resulting changes are
1279 pervasive but mostly trivial, and only the notable changes are
1282 * format.c (fmt_equal): New function.
1284 * variable.c (var_type_is_valid): New function.
1285 (measure_is_valid) Moved here, from format.c.
1286 (alignment_is_valid) Moved here, from format.c.
1287 (var_get_name) New function.
1288 (var_set_name) New function.
1289 (width_to_type) New function.
1290 (var_get_type) New function.
1291 (var_get_width) New function.
1292 (var_set_width) New function.
1293 (var_is_numeric) New function.
1294 (var_is_alpha) New function.
1295 (var_is_short_string) New function.
1296 (var_is_long_string) New function.
1297 (var_is_very_long_string) New function.
1298 (var_get_missing_values) New function.
1299 (var_set_missing_values) New function.
1300 (var_clear_missing_values) New function.
1301 (var_has_missing_values) New function.
1302 (var_is_value_missing) New function.
1303 (var_is_num_missing) New function.
1304 (var_is_str_missing) New function.
1305 (var_is_value_user_missing) New function.
1306 (var_is_num_user_missing) New function.
1307 (var_is_str_user_missing) New function.
1308 (var_is_value_system_missing) New function.
1309 (var_get_print_format) New function.
1310 (var_set_print_format) New function.
1311 (var_get_write_format) New function.
1312 (var_set_write_format) New function.
1313 (var_set_both_formats) New function.
1314 (var_get_label) New function.
1315 (var_set_label) New function.
1316 (var_clear_label) New function.
1317 (var_has_label) New function.
1318 (var_get_measure) New function.
1319 (var_set_measure) New function.
1320 (var_get_display_width) New function.
1321 (var_set_display_width) New function.
1322 (var_get_alignment) New function.
1323 (var_set_alignment) New function.
1324 (var_get_value_cnt) New function.
1325 (var_get_leave) New function.
1326 (var_get_short_name) New function.
1328 * variable.h: (struct variable) Removed "type" and "nv" members;
1329 they are now computed from "width" where needed.
1331 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1333 * missing-values.c (mv_resize): Don't write beyond end of the
1334 allocated buffer when resizing a long string.
1336 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1338 Clean up identifier code: don't require identifier enumerations to
1339 be in a particular order; make better use of string library;
1340 expose less of the internals.
1342 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1343 change interface. Updated all callers.
1344 (lex_id_match) Change interface to use struct substring, update
1346 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1347 (global array keywords[]) Make static, change form. Update all
1348 users to use lex_id_name instead.
1349 (lex_is_keyword) New function.
1350 (lex_id_to_token) Change interface to use struct substring, update
1352 (lex_id_name) New function.
1354 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1355 lex_is_keyword instead.
1356 (T_LAST_KEYWORD) Removed.
1357 (T_N_KEYWORDS) Removed.
1359 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1361 * format.c: (fmt_date_template) Distinguish characters for which a
1362 space is output and any date delimiter is allowed on input, from
1363 those for which a space is output and only a space is allowed on
1364 input. The former is represented by X, the latter by a space.
1365 Also, drop distinction between h and H, changing the former to the
1368 * data-in.c: Completely rewrite internals to conform to SPSS input
1369 formats as closely as possible.
1370 (data_in) Changed external interface by replacing the structure
1371 that was used as a single argument by a set of arguments. Updated
1373 (data_in_finite_line) Removed. Converted all callers to use plain
1375 (data_in_get_integer_format) New function.
1376 (data_in_set_integer_format) New function.
1377 (data_in_get_float_format) New function.
1378 (data_in_set_float_format) New function.
1380 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1381 (struct data_in) Removed.
1383 * data-out.c: (output_date) Drop each component from the input as
1384 it is output, to allow us to drop the distinction between h (a
1385 count of hours) and H (the hour of day) template characters.
1386 Also, handle new X template character.
1387 (output_scientific) Follow more rational rule on when to drop
1388 fraction introduced between SPSS 13 and 15. Updated test case to
1391 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1393 Fix buffer overflow reported by John Darrington.
1395 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1396 realize that DIGITS is a count of nibbles, not of bytes.
1398 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1400 * calendar.c (calendar_offset_to_gregorian) Also return the
1401 year-of-day. Change callers to new interface.
1403 * data-out.c: Completely rewrite internals to conform to SPSS
1404 output formats as completely as possible.
1405 (data_out) Change interface to put input parameters before output
1406 parameters, for consistency with the style I now prefer. Update
1408 (data_out_get_integer_format) New public function.
1409 (data_out_set_integer_format) New public function.
1410 (data_out_get_float_format) New public function.
1411 (data_out_set_float_format) New public function.
1413 * data-out.h: New file. Move prototype for data_out here, from
1416 * format.c: (fmt_step_width) Use equality comparison instead of
1417 bitwise and, for clarity.
1418 (fmt_is_string) Ditto.
1419 (fmt_input_to_output) Fix categories that are translated to F
1422 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1424 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1425 casefile-private.h: Added casefilter to assist commands with missing
1428 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1430 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1432 * settings.c: (route_errors_to_terminal) New variable.
1433 (route_errors_to_listing) New variable.
1434 (get_error_routing_to_terminal) New function.
1435 (set_error_routing_to_terminal) New function.
1436 (get_error_routing_to_listing) New function.
1437 (set_error_routing_to_listing) New function.
1439 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1441 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1443 * format.c: Completely rewrite, to achieve better abstraction.
1444 Rewrite all references to formats in other files.
1446 * format.def: Rewrite and reorganize.
1448 * settings.c: Move everything related to custom currency formats
1449 into format.[ch], changing them in form, so as to group related
1450 code and definitions better. Changed all references to use the
1452 (static var decimal) Removed.
1453 (static var grouping) Removed.
1454 (static var cc) Removed.
1455 (get_decimal) Removed.
1456 (set_decimal) Removed.
1457 (get_grouping) Removed.
1458 (set_grouping) Removed.
1462 * settings.h: (macro CC_CNT) Removed.
1463 (macro CC_WIDTH) Removed.
1464 (struct custom_currency) Removed.
1466 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1468 * data-in.c (data_in): Use switch statement instead of table, to
1469 avoid dependence on the order of the FMT_* enums.
1471 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1473 * data-out.c: (num_to_string) Removed, because it was dead code.
1475 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1477 * data-in.c (parse_trailer): Fix error message.
1479 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1481 * format.c (fmt_is_binary): New function.
1483 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1485 * procedure.c procedure.h: Encapsulated the static data into a single
1488 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1490 * casefile.c (casereader_read_xfer): Always initialize the case,
1491 even on an error condition.
1493 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1495 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1496 entire function useless.
1498 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1500 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1501 casereader method casereader_clone.
1503 * procedure.c pransformations.h: Introduced new type casenum_t
1505 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1507 * variable.c: (width_to_bytes) Rephrase code for clarify.
1509 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1511 * format.c: (fmt_type_from_string) New function.
1512 (fmt_to_string) Include decimals in output if the format has
1513 decimals, even if the format type does not. This way, we can
1514 accurately reproduce incorrect formats in user output.
1515 (check_common_specifier) Make the check for a bad format type an
1516 assertion, so we get bug reports if they show up. Fix message.
1517 Check for decimal places with a format type that doesn't allow
1519 (check_input_specifier) Remove check for FMT_X, which has been
1521 (check_output_specifier) Ditto.
1523 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1525 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1526 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1527 (enum fmt_parse_flags) Removed.
1529 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1531 * casefile.c casefile.h: Converted to an abstract base class.
1532 * casefile-private.h fastfile.c fastfile.h: New files.
1533 * automake.mk procedure.c scratch-writer.c storage-stream.c
1535 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1537 * procedure.c (internal_procedure): Create sink_case with only as
1538 many values as the compacted dictionary.
1540 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1542 Remove "debugging" code that caused plenty of false positives and
1545 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1547 * case.c: Remove all references to `this' member.
1549 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1551 Fix link error noted by Jason Stover.
1553 * storage-stream.c: Include <assert.h>.
1555 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1557 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1558 ALL) and additional underlying system file issues.
1560 Thanks to John Darrington for review.
1562 First problem: var_hash points to variables not owned by the
1563 sys-file-reader, which the caller may free or modify. Use an
1564 array of sfm_vars instead, as done earlier (e.g. CVS version
1567 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1568 members and remove all code that references it. Add vars, var_cnt
1569 members. Remove fix_specials member, which was unused.
1570 (struct sfm_var) Remove name member, which was unused.
1571 (sfm_close_reader) Free vars member instead of var_hash.
1572 (compare_var_shortnames) Removed.
1573 (hash_var_shortname) Removed.
1574 (sfm_open_reader) Fill out vars array.
1575 (compare_var_index) Removed.
1576 (sfm_read_case) Use vars instead of var_hash.
1578 Second problem: we're confused about when we actually have very
1579 long strings, causing us to choose incorrectly between slow path
1580 and fast path in sfm_read_case.
1582 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1583 have very long strings, not when we have long variable names,
1584 which is an unrelated feature.
1586 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1588 * variable.h: Move var_set and variable parsing declarations to
1589 new header, src/language/lexer/variable-parser.h. Modified lots
1590 of files to include the new header.
1592 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1594 * value-labels.c (value_to_string): When there's no value label,
1595 format the variable according to its print format, instead of
1596 always effectively using A or F format.
1598 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1600 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1603 * format.c: Removed tortological assertion.
1605 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1607 Reform string library.
1609 * file-name.c (fn_interp_vars): Change interface to take a
1610 substring as input. Updated all users.
1612 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1614 * format.c (measure_is_valid): Really return false when m >=
1617 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1619 Implement random access to casefiles, for use in GUI.
1621 * casefile.c: (struct casereader) Add `random', `file_ofs',
1622 `buffer_ofs' members.
1623 (casefile_get_random_reader) New function.
1624 (read_open_file) Break part into new function
1625 seek_and_fill_buffer().
1626 (fill_buffer) Update buffer_ofs, file_ofs.
1627 (casereader_seek) New function.
1629 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1631 * settings.c: Added call to i18n{done, init}.
1633 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1635 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1638 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1640 * casefile.c: Convert many uses of `int' to `bool'.
1642 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1644 * transformations.c (trns_chain_destroy): Destroy chain's trns
1645 member, to fix memory leak.
1647 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1649 * storage-stream.c (storage_source_decapsulate): Destroy case
1650 source to fix memory leak.
1652 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1654 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1655 case passed as argument instead of initializing the argument as a
1656 case. Fixes memory leak that showed up in
1657 tests/command/aggregate.sh with scratch files.
1659 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1661 * procedure.c (proc_done): Destroy default_dict, to fix memory
1664 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1666 Simplify procedure_with_splits().
1668 * procedure.c (struct split_aux_data): Removed case_count member.
1669 (procedure_with_splits) Don't initialize case_count.
1670 (split_procedure_case_func) Check whether prev_case is null
1671 instead of case_count.
1672 (split_procedure_end_func) Ditto.
1674 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1676 * case.c (case_move): Do nothing if dst and src are the same
1678 (case_try_create) Merge two similar cases.
1679 (case_copy) Unshare only if data must be actually copied.
1681 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1683 * data-in.c data-out.c dictionary.c sys-file-reader.c
1684 sys-file-writer.c variable.c variable.h: Reworked very long string
1685 support for better encapsulation.
1687 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1689 * value-labels.c (val_labs_can_set_width): New function.
1690 (val_labs_set_width) Clear labels if increasing width to long
1692 (val_labs_destroy) Remove unneeded test for null.
1694 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1696 * value-labels.h: Remove unneeded dependency on variable.h.
1698 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1700 Get rid of `char *c' member in union value, for cleanliness.
1702 * value.h: (union value) Remove `c' member.
1704 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1706 Make dictionary compacting functions a little more general.
1708 * sys-file-writer.c (sfm_open_writer): Use
1709 dict_compacting_would_change().
1710 (does_dict_need_translation) Removed.
1712 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1714 Make dictionary compacting functions a little more general.
1716 * dictionary.c (dict_needs_compaction): Rename
1717 dict_compacting_would_shrink(). Update all callers.
1718 (dict_compacting_would_change) New function.
1720 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1722 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1723 inverted return value (!).
1725 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1727 Continue reforming procedure execution.
1729 * procedure.c: Search and replace "vfm" by "proc". Notably:
1730 (static var vfm_source) Rename proc_source. Update all
1732 (static var vfm_sink) Rename proc_sink. Update all references.
1734 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1736 Continue reforming procedure execution. In this phase, remove
1737 PROCESS IF, which was deprecated anyway and can be easily
1738 simulated with TEMPORARY followed by SELECT IF.
1740 * procedure.c: (open_active_file) Don't call
1741 add_process_if_trns().
1742 (discard_variables) Get rid of redundant call to
1743 proc_cancel_all_transformations().
1744 (add_process_if_trns) Removed.
1745 (process_if_trns_proc) Removed.
1746 (process_if_trns_free) Removed.
1748 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1750 Continue reforming procedure execution. In this phase, add
1751 `const' to the case passed to procedure()'s callback.
1753 Updated all users of procedure() as well.
1755 * procedure.c: (struct write_case_data) Add "const" to ccase
1756 parameter for case_func member.
1757 (procedure) Add "const" to ccase parameter for proc_func
1759 (multipass_case_func) Make ccase parameter const.
1760 (internal_procedure) Add "const" to ccase parameter for case_func
1762 (split_procedure_case_func) Make ccase parameter const.
1763 (multipass_split_case_func) Make ccase parameter const.
1765 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1767 Continue reforming procedure execution. In this phase, get rid of
1768 the output code for SPLIT FILE groups in procedure.c, which really
1769 shouldn't be doing any output. Move it into the individual
1770 procedures instead. This also adds some flexibility.
1772 Updated many users of procedure_with_splits() and
1773 multipass_procedure_with_splits() to call
1774 output_split_file_values() and to deal with increased use of
1777 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1778 parameter to begin_func member.
1779 (procedure_with_splits) Add "const struct ccase *" parameter to
1780 begin_func parameter. Make ccase parameter const in proc_func
1782 (split_procedure_case_func) Don't dump split file group. Pass
1784 (dump_splits) Moved to language/dictionary/split-file.c as
1785 output_split_file_values().
1786 (struct multipass_split_aux_data) Add "const struct ccase *"
1787 parameter to split_func member.
1788 (multipass_procedure_with_splits) Add "const struct ccase *"
1789 parameter to split_func parameter.
1790 (multipass_split_case_func) Save new SPLIT FILE case before
1792 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1794 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1796 Continue reforming procedure execution. Change
1797 internal_procedure() so that it calls open_active_file() and
1798 close_active_file(), which isolates most of the actual procedure
1801 * procedure.c: (struct write_case_data) Rename `proc_func' member
1802 to `case_func' and update all references.
1803 (procedure) Rewrite as one-line wrapper around
1804 internal_procedure().
1805 (struct multipass_aux_data) New.
1806 (multipass_callback) Renamed multipass_case_func(). Use struct
1807 multipass_aux_data as auxiliary data.
1808 (multipass_end_func) New function.
1809 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1810 that uses multipass_case_func, multipass_end_func.
1811 (internal_procedure) Add `end_func' argument. Move optimization
1812 of trivial case in here. Move call to open_active_file() and
1813 close_active_file() in here. Now assert that vfm_source is
1815 (procedure_with_splits_callback) Rename
1816 split_procedure_case_func().
1817 (split_procedure_end_func) New function.
1818 (multipass_split_callback) Rename multipass_split_case_func.
1819 (multipass_split_end_func) New function.
1820 (discard_variables) No need to test for nonnull vfm_source.
1822 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1824 Continue reforming procedure execution. Get rid of unused member.
1826 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1828 (write_case) Don't increment cases_analyzed.
1830 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1832 Continue reforming procedure execution. In this phase, move
1833 procedure.c and procedure.h from src to src/data. Update
1834 makefiles and #includes accordingly.
1836 * procedure.c: Moved here from src/.
1838 * procedure.h: Moved here from src/.
1840 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1842 Continue reforming procedure execution. In this phase, get rid of
1843 many global variables, consolidating procedure execution in
1844 procedure.c. Encapsulate transformations in new "struct
1845 trns_chain". Also, change implementation of N OF CASES, FILTER,
1846 and PROCESS IF from special cases to transformations.
1848 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1851 * dictionary.c: (global variable default_dict) Move to
1854 * variable.h: (TRNS_*) Move to transformations.h.
1855 (struct transformation) Move to transformations.c.
1857 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1859 * sys-file-reader.c: Fixed invalid read problems.
1861 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1863 * storage-stream.c: Add missing function comments.
1865 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1867 Continue reforming procedure execution. In this phase, add some
1868 new, needed functionality to storage-stream.
1870 * storage-stream.c: (storage_source_decapsulate) New function.
1872 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1874 * variable.c (width_to_bytes): Declarations must precede
1875 statements for C90 compliance.
1877 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1879 * data-out.c, data-in.c, variable.c, variable.h: New functions
1880 copy_mangle and copy_demangle for reading/writing cases; emulates the
1881 way SPSS deals with strings > 255 bytes.
1883 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1884 subtype 14 needed for strings longer than 255 bytes.
1886 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1887 instead of literal values. Also fixed some constness issues.
1889 * format.h: Constness
1891 * sfm-private.h: Renamed the case_size identifier, since I discovered
1892 that SPSS's respect for this variable is very nominal.
1894 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1896 Change case limit type from int to size_t.
1898 * dictionary.c: (struct dictionary) Change type of case_limit
1900 (dict_get_case_limit) Change return type.
1901 (dict_set_case_limit) Change parameter type.
1903 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1905 * variable.h: (struct variable) Rename `reinit' member as `leave'
1906 and invert sense. Fix up all references.
1908 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1910 Continue reforming procedure execution. In this phase, break
1911 procedure.c into multiple files.
1913 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1915 * case-sink.c: New file.
1917 * case-sink.h: New file.
1919 * case-source.c: New file.
1921 * case-source.h: New file.
1923 * storage-stream.c: New file.
1925 * storage-stream.h: New file.
1927 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1929 * variable.h: (struct variable) Remove `init' member and all
1930 references to it from other files. It was initialized in several
1931 places, but nothing really ever used it for anything worthwhile.
1932 Thanks to Jason Stover for pointing out how confusing this
1935 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1937 Continue reforming error message support. In this phase, get rid
1938 of message "titles" and put the message text in `struct error'.
1939 Now `struct error' encapsulates a message more properly.
1941 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1942 Format message ourselves.
1944 * data-in.c: (vdls_error) Ditto.
1946 * por-file-reader.c: (error) Ditto.
1948 * sys-file-reader.c: (corrupt_msg) Ditto.
1950 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1952 GNU standards require "file name" instead of "filename" in
1953 documentation. It's nice for our code to follow the convention
1956 * casefile.c: (struct casefile) Rename `filename' member to
1957 `file_name'. Updated all references.
1959 * file-name.c: [!unix] (struct file_identity) Rename
1960 normalized_filename member to normalized_file_name. Updated all
1963 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1965 We don't really support anything but Unix-like environments well,
1966 so we might as well de-obfuscate by writing directory and path
1967 separators explicitly.
1969 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1971 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1972 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1974 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1977 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1979 GNU standards require "file name" instead of "filename" in
1980 documentation. It's nice for our code to follow the convention
1983 * filename.c: Rename to file-name.c.
1985 * filename.h: Rename to file-name.h. Update all inclusions.
1986 Update header guards.
1988 * automake.mk: Update file names.
1990 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1992 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1994 (fn_basename) Removed (dead code).
1995 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1996 (fn_special_p) Renamed fn_is_special(), all references updated.
1997 (fn_exists_p) Renamed fn_exists(), all references updated.
1999 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
2001 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
2002 Also, now it only tilde-expands file names, not paths.
2003 (fn_search_path) Tilde-expand one directory at a time.
2005 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
2007 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
2008 get rid of non-Unixlike version of the code, which has probably
2010 (fn_prepend_dir) Removed (dead code).
2012 * filename.h: (macro DIR_SEPARATOR_STRING) New.
2013 (macro PATH_SEPARATOR_STRING) New.
2014 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
2016 Continue reforming error message support. In this phase, we get
2017 rid of VM() and the other msg() support for "verbosity", replacing
2018 it by a new function verbose_msg().
2020 * filename.c: (fn_search_path) Use verbose_msg() instead of
2023 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
2025 * sfm-private.h: Get rid of #defines after #error, which makes no
2028 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
2030 Get rid of our own int32 type in favor of the standard int32_t
2033 * sfm-private.h: (int32 macro) Don't define this anymore. Do
2036 * sys-file-reader.c: Use int32_t instead of int32 throughout.
2038 * sys-file-writer.c: Use int32_t instead of int32 throughout.
2040 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
2042 Remove ill-considered file routines that are no longer used.
2044 * filename.c: (fn_open_ext) Removed.
2045 (fn_close_ext) Removed.
2047 * filename.h: (struct file_ext) Removed.
2049 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
2051 * variable.c (var_is_valid_name): Move declarations before code
2054 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
2056 * filename.ch (fn_interp_vars): Fixed small buglet.
2058 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
2060 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
2061 so as to modify the string inline. Thus makeing it easier to
2062 destroy the results when no longer needed.
2064 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
2066 * category.c (cat_stored_values_destroy): Fixed memory leak.
2068 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
2070 Add some missing frees. Thanks to John Darrington for reporting
2073 * any-writer.c (any_writer_close): Free writer.
2075 * any-reader.c (any_reader_close): Free reader.
2077 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
2079 * por-file-reader.c: (error) Mark as NO_RETURN.
2081 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2083 * settings.c: Changed default value of scompress to true.
2085 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2087 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2089 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2092 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2093 here from pref.h.orig.
2095 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2097 * sys-file-reader.c: Fixed bug reading compressed files.
2099 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2101 * Numerous renames. See src/ChangeLog for details.
2103 * Moved files from src directory