1 2007-06-06 Ben Pfaff <blp@gnu.org>
3 Add interface to lexicographical ordering of cases.
5 * automake.mk: Add new files.
7 * case-ordering.c: New file.
9 * case-ordering.h: New file.
11 2007-06-06 Ben Pfaff <blp@gnu.org>
13 Add casereaders and casewriters, the basis of the new data processing
14 implementation. A casereader is a uniform interface to reading cases
15 from a data source; a casewriter is a uniform interface to writing
18 * automake.mk: Add new files.
20 * casereader-filter.c: New file.
22 * casereader-provider.h: New file.
24 * casereader-translator.c: New file.
26 * casereader.c: New file.
28 * casereader.h: New file.
30 * casewriter-provider.h: New file.
32 * casewriter-translator.c: New file.
34 * casewriter.c: New file.
36 * casewriter.h: New file.
38 2007-06-06 Ben Pfaff <blp@gnu.org>
40 "casewindow" data structure that extends the deque (from libpspp)
41 of cases with the ability to dump cases to disk if we get too many
44 * automake.mk: Add new files.
46 * casewindow.c: New file.
48 * casewindow.h: New file.
50 2007-06-06 Ben Pfaff <blp@gnu.org>
52 sparse_cases data structure that augments a sparse_array of cases
53 with the ability to dump cases to disk if we get too many cases in
56 * automake.mk: Add new files.
58 * sparse-cases.c: New file.
60 * sparse-cases.h: New file.
62 2007-06-06 Ben Pfaff <blp@gnu.org>
64 Adds a low-level on-disk case array data structure.
66 * automake.mk: Add new files.
68 * case-tmpfile.c: New file.
70 * case-tmpfile.h: New file.
72 2007-06-06 Ben Pfaff <blp@gnu.org>
74 In a couple of places we calculate the maximum number of cases to
75 keep in memory based on the user-defined workspace. Enable
76 centralizing the calculation through a new function.
78 * settings.c (get_workspace_cases): New function.
80 2007-06-06 Ben Pfaff <blp@gnu.org>
82 The casenumber type is defined in transformations.h, but case.h is
83 a more sensible place. Move it.
85 * case.h (CASENUMBER_MAX): New macro.
86 (typedef casenumber): Move here, from transformations.h.
88 2007-06-03 Ben Pfaff <blp@gnu.org>
90 Slightly generalize case_to_values and case_from_values functions.
92 * case.c (case_to_values): Rename case_copy_out, change interface.
93 (case_from_values): Rename case_copy_in, change interface.
95 * fastfile.c (fastfilereader_get_next_case): Update caller.
96 (write_case_to_disk): Ditto.
98 2007-06-02 Ben Pfaff <blp@gnu.org>
100 Clean up after a forgotten part of patch #5829.
102 * casedeque.h: Remove unused file.
104 * automake.mk: Remove casedeque.h from sources.
106 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
108 * category.c: Removed redundant #include
110 2007-05-06 Ben Pfaff <blp@gnu.org>
112 Abstract the documents within a dictionary a little better.
113 Thanks to John Darrington for suggestion, initial version, and
116 * dictionary.c (struct dictionary): Change `documents' member from
117 char * to struct string.
118 (dict_clear): Destroy struct string.
119 (dict_get_documents): Convert struct string to char *.
120 (dict_set_documents): Set struct string. Pad to 80-character
122 (dict_clear_documents): New function.
123 (dict_add_document_line): New function.
124 (dict_get_document_line_cnt): New function.
125 (dict_get_document_line): New function.
127 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
129 * sys-file-reader.c (read_documents): Use new document functions.
131 2007-04-19 John Darrington <john@darrington.wattle.id.au>
133 * sys-file-reader.c: When reading a system file which has no
134 long name table, automatically create one where the long names
135 are the lower case versions of the short names.
137 2007-04-22 Ben Pfaff <blp@gnu.org>
139 * dictionary.c (dict_set_split_vars): dict_destroy expects that
140 dict_clear will free most data related to the dictionary.
141 dict_clear does a decent job, except that dict_set_split_vars on
142 some systems won't actually free the dict's "split" member.
143 Instead, it'll allocate a 1-byte region. Fix this.
145 * value.c (value_copy): New function.
146 (value_set_missing): Ditto.
148 2007-04-22 John Darrington <john@darrington.wattle.id.au>
150 * Deleted existing category.h and moved cat-routines.h into
151 category.h Encapsulated struct cat_vals better.
153 2007-04-19 John Darrington <john@darrington.wattle.id.au>
155 * sys-file-reader.c: When reading a system file which has no
156 long name table, automatically create one where the long names
157 are the lower case versions of the short names.
159 2007-04-16 John Darrington <john@darrington.wattle.id.au>
161 * sys-file-reader.c: Some versions of Other Software seem to
162 produce system files with string variables' measure set to
163 zero. We'll assume these are supposed to be nominal variables.
165 2007-03-30 Ben Pfaff <blp@gnu.org>
167 * procedure.c: Adapt to new deque data structure.
169 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
170 Ben Pfaff <blp@gnu.org>
172 * file-name.c: Mingw compatibility fixes.
173 (fn_search_path): Use ISSLASH instead of comparing against '/'
175 (fn_dir_name): Use dir_name from gnulib.
176 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
177 (fn_get_identity): Use GetFullPathName instead of canonicalize
178 from gnulib, because the latter does not fully support
179 Windows-style path names. Use this implementation based on the
180 detected presence of Windows instead of the absence of Unix, since
181 the new implementation is Windows-specific.
182 (fn_compare_file_identities): In Windows implementation, compare
183 names case-insensitively.
185 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
187 * make-file.c: Don't include mkstemp.h, because gnulib now causes
188 <stdlib.h> to have the same effect.
190 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
192 * por-file-reader.c: Add missing _() around messages.
194 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
196 * make-file.c: Include "mkstemp.h", without which linking on
199 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
201 Reduce platform dependence.
203 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
204 Everywhere we using this, we really should have just depended on
205 the shell to expand tildes.
206 (fn_search_path): Simplify, given that we don't do tilde expansion
208 (fn_normalize): Removed. Caller changed to use the canonicalize
210 (fn_get_cwd): Removed. Only user was fn_normalize.
211 (fn_is_absolute): Really only test for absolute names.
212 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
214 (fn_readlink): Removed, as it was only used fn_normalize.
215 (fn_exists): Assume the stat function is available; gnulib does.
216 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
218 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
220 * dictionary.c (dict_create_vector_assert): New function.
222 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
224 * file-name.c (fn_normalize): Correct name of function
225 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
226 for pointing this out.
228 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
230 We are using a single member in struct file_handle, the "name"
231 field, for more than one purpose. When it begins with '"', it's a
232 file name; otherwise, it's a token that can be used to identify
233 it. When that assertion fires, it's because we searched for the
234 name case-sensitively as a file name (so that there was no match),
235 and then we try to insert it case-insensitively as a token, which
236 fails because duplicates aren't allowed.
238 Solution: break the two purposes into two separate fields. This
239 fixes the problem and likely makes the code easier to read too.
241 Fixes bug #18922. Thanks to John Darrington for bug report and
244 * file-handle-def.c (struct file_handle): New `id' member.
245 (fh_from_name): Rename fh_from_id. Update all callers.
246 (create_handle): New `id' parameter. Update all callers.
247 (fh_create_file): Ditto.
248 (fh_get_id): New function.
250 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
252 * case.c (case_is_null): Change return type to bool.
254 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
258 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
259 reference counting to share data. This makes it easy for
260 valgrind, etc. to find accesses to cases that have been destroyed
261 but have been kept around by another user's ref-count. This often
262 happens when the data set is small enough to find in memory; if a
263 bigger data set that would overflow to disk were used, then data
264 corruption would occur.
266 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
270 * case.c (case_unshare): Make it check internally whether the
271 ref_cnt is greater than 1, so that the callers don't have to.
272 Update callers not to check.
274 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
276 Before, I was thinking that I might want to get rid of reference
277 counting at some point. Now, I'm pretty sure that it's here to
278 stay. Thus, because we have to store the value_cnt anyway for
279 reference-counted cases, we might as well expose it to users.
281 * case.c (case_get_value_cnt): New function.
282 (case_resize): Drop OLD_CNT argument. Update all callers. Only
283 resize case if its size actually changed.
285 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
286 instead of peeking inside struct case directly.
287 (casefile_append): Ditto.
289 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
291 Get rid of the inlines for the case functions, which made the
292 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
293 the inlines didn't speed up "make check" at all, which is not a
294 perfect benchmark but seems indicative.)
296 * case.c: Remove #ifdef DEBUGGING...#endif around many function
297 definitions. Remove some assertions on nonnull pointers that were
298 redundant with a pointer dereference soon after in the function.
300 (struct case_data): Move definition here from case.h.
304 (case_data_wr): Ditto.
306 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
308 * automake.mk: Add casedeque.h to sources.
310 * casedeque.h: New file.
312 * procedure.c: (struct dataset) Change lag_count, lag_head,
313 lag_queue member into single struct casedeque member. Update all
314 users to use the casedeque instead.
317 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
319 * procedure.c: Simplify lagged cases interface. Updated all
320 clients--well, the only client--to use the simplified interface.
321 (dataset_n_lag) Removed.
322 (dataset_set_n_lag) Removed.
323 (dataset_need_lag) New function.
325 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
327 * dictionary.c procedure.c: More changes to ensure that callbacks occur
328 whenever appropriate, but only when the dataset/dictionary is in a
331 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
333 * dictionary.c dictionary.h : Added callbacks for change of filter and
334 split variables. Refactored some code to ensure that callbacks get
335 invoked when appropriate.
337 * procedure.c (proc_cancel_temporary_transformations): Make sure that
338 replace_dict callback occurs when permanent_dict replaces the current
341 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
343 * dictionary.c dictionary.h : Added callback for when the weight
344 variable of a dictionary changes.
346 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
348 * dictionary.c dictionary.h : Added replace_source and replace_dict
349 callbacks, and functions to deal with them.
351 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
353 Simplify missing value handling.
355 * missing-values.h (enum mv_class): New type.
356 (enum mv_type): Moved definition into missing-values.c and renamed
357 each MV_* to MVT_*, to distinguish them from the exposed mv_class
358 enums. Updated all uses.
359 (struct missing_values): Changed type of `type' from `enum
360 mv_type' to `int' because the definition is no longer exposed.
362 * missing-values.c (mv_is_value_missing): Add new enum mv_class
363 parameter. Update all callers.
364 (mv_is_num_missing): Ditto.
365 (mv_is_str_missing): Ditto.
366 (mv_is_value_user_missing): Removed. Changed callers to use
368 (mv_is_num_user_missing): Removed. Changed callers to use
370 (mv_is_str_user_missing): Removed. Changed callers to use
372 (mv_is_value_system_missing): Removed. Changed callers to use
374 (mv_set_type): Removed. Changed callers to use mv_clear.
375 (mv_clear): New function.
377 * variable.c (var_is_value_missing): Add new enum mv_class
378 parameter. Update all callers.
379 (var_is_num_missing): Ditto.
380 (var_is_str_missing): Ditto.
381 (var_is_value_user_missing): Removed. Changed callers to use
382 var_is_value_missing.
383 (var_is_num_user_missing): Removed. Changed callers to use
385 (var_is_str_user_missing): Removed. Changed callers to use
387 (var_is_value_system_missing): Removed. Changed callers to use
388 var_is_value_missing.
390 * casefilter.c (struct casefilter): Use enum mv_class in place of
392 (casefilter_variable_missing): Adapt to new member.
393 (casefilter_create): Change signature to take enum mv_class,
396 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
398 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
400 * case-sink.c case-sink.h procedure.c procedure.h
401 storage-stream.c: Now uses the factory.
403 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
405 Make it possible to pull cases from the active file with a
406 function call, instead of requiring indirection through a callback
409 * case-source.h (struct case_source_class): Change ->read function
410 to return a single case, instead of calling a callback function
411 for each case. Change ->destroy function to return an error
414 * case-source.c (free_case_source): Pass along the value returned
415 by the case_source ->destroy function.
417 * procedure.c (struct write_case_data): Removed.
418 (struct dataset): Added some members to track procedure state.
419 (procedure): Optimize the trivial case at this level.
420 (internal_procedure): Re-implement in terms of proc_open,
421 proc_read, proc_close.
422 (proc_open) New function.
423 (proc_read) New function.
424 (proc_close) New function.
425 (write_case) Moved into proc_read.
426 (close_active_file) Moved closing of data source into proc_close.
428 * storage-source.c: Rewrote to conform with modified
429 case_source_class interface.
431 * transformations.c (trns_chain_execute): Added argument to allow
432 starting execution from an arbitrary transformation. Updated
435 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
437 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
439 * sys-file-reader.c (read_display_parameters): Don't assume that
440 MEASURE_* and ALIGN_* have the same values found in system files.
442 * sys-file-writer.c (write_variable_display_parameters): Ditto.
444 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
445 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
446 the value of n_MEASURES, which was off by 1 (at least from my
449 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
451 * dictionary.c dictionary.h vardict.h variable.c: Added optional
452 callbacks which are invoked when the dictionary or its
453 variables are changed.
455 * missing-values.c missing-values.h value-labels.c: Tidied up
456 consistency checks, and made some of them return false
457 instead of assert-failing.
459 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
461 * calendar.c (calendar_days_in_month): New function.
463 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
465 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
466 the value label's width.
468 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
470 * sfm-private.h: Move contents into sys-file-writer.c, which is
471 the only remaining user. Removed Borland C++-specific directives.
473 * sys-file-reader.c: Clean up and rewrite entire file. The
474 rewritten version is simpler and better abstracted, and should be
475 easier to maintain and extend. It avoids using structures to read
476 file data, which is prone to padding variations among compilers.
477 It should also handle non-IEEE 754 system files, although I
478 haven't been able to find any. It has been tested against many
479 .sav files obtained from the Web and found to produce the same
480 results as the earlier version of the code, or in some cases
481 improved results. It is more tolerant of format variations found
484 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
485 member, putting an enum integer_format in its place. New member
486 `float_format'. Changed `compressed' member to type bool.
488 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
490 * dictionary.c (dict_delete_consecutive_vars): New function.
492 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
494 * file-name.c (fn_search_path): Remove prefix arg that was unused
495 by any caller. Updated all callers.
497 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
499 * format.c (fmt_dollar_template): Use user's decimal point
500 character. Add assertion.
502 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
504 * format.c (fmt_dollar_template): New function, based on
505 dollar_format_template from var-type-dialog.c.
507 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
509 * data-out.c (output_scientific): Fix bad assumption that "buf" is
512 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
514 Finish converting struct variable to an opaque type. In this
515 phase, we add remaining setter and getter functions, convert the
516 remaining PSPP code to use them, and do a bunch of cleanup. The
517 resulting changes are pervasive but mostly trivial, and only the
518 notable changes are logged.
520 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
523 * case.c (case_data): Renamed case_data_idx.
524 (case_num): Renamed case_num_idx.
525 (case_str): Renamed case_str_idx.
526 (case_data_rw): Renamed case_data_rw_idx.
528 * case.h (case_data): New function with old name and an interface
529 that takes a variable instead of an index, which is easier to
530 use. Updated all callers to use the new interface, or to use the
531 new *_idx function (see above).
534 (case_data_rw): Ditto.
536 * category.c (cat_stored_values_destroy): Changed interface to
537 take a struct cat_vals * instead of a struct variable *.
539 * dictionary.c (dict_clone): Use new vector_clone function.
540 (dict_clear) Use new var_destroy function.
541 (add_var) New function.
542 (dict_create_var) Rewrite in terms of dict_create_var_assert.
543 (dict_create_var_assert) Rewrite in terms of add_var.
544 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
545 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
546 (dict_lookup_var) Use new var_create, var_destroy functions.
547 (dict_contains_var) Rewrite in terms of new vardict functionality.
548 (set_var_dict_index) New function.
549 (set_var_case_index) New function.
550 (reindex_vars) New function.
551 (dict_delete_var) Rewrite in terms of new vardict functionality.
552 (dict_reorder_var) Ditto.
553 (dict_reorder_vars) Ditto.
554 (rename_var) New function.
555 (dict_rename_var) Use rename_var.
556 (dict_rename_vars) Use pool to simplify code. Use rename_var.
557 (dict_get_compacted_idx_to_fv) Rename
558 dict_get_compacted_dict_index_to_case_index, update callers.
559 (dict_create_vector) Use new vector_create function.
560 (dict_clear_vectors) Use new vector_destroy function.
561 (set_var_short_name_suffix) Move here from variable.c, renamed
562 from var_set_short_name_suffix, make static, update caller.
564 * sys-file-private.c: New file.
565 (sfm_width_to_bytes) Moved here from variable.c, renamed from
566 width_to_bytes, update callers.
568 * sys-file-private.h: New file. Later it will supplant
569 sfm-private.h; for now it supplements it.
570 (macro MIN_VERY_LONG_STRING) New macro.
571 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
573 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
574 MAX_LONG_STRING was used before.
576 * sys-file-writer.c: Ditto.
578 * value-labels.c: Change the paradigm here to be that a null
579 pointer is OK for a struct val_labs * in most cases; it just
580 represents an empty set of value labels.
581 (val_labs_copy) A copy of a null set is a null set.
582 (val_labs_count) A null set has 0 labels.
583 (val_labs_replace) Change return type to void. Rewrite for
585 (val_labs_find) A null set does not contain the value.
586 (value_to_string) Moved to variable.c, renamed var_get_value_name,
587 transposed argument order, updated all callers.
590 (value_dup) Moved here from variable.c.
591 (compare_values) Ditto.
594 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
595 (macro MAX_LONG_STRING) Removed, because it was only interesting
596 for system files, not for general code.
597 (macro MAX_VERY_LONG_STRING) Ditto.
598 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
599 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
601 * vardict.h: New file, for an interface between variables and
604 * variable.c: A lot of functions were moved around, for better
606 (struct variable) Move definition here, from variable.h.
607 (var_type_adj) Removed--makes i18n hard.
608 (var_type_noun) Ditto.
609 (var_create) New function.
610 (var_clone) New function.
611 (var_destroy) New function.
612 (var_set_name) Assert that variable is not in a dictionary.
613 (compare_var_names) Rename compare_vars_by_name and fix a couple
614 of callers who thought the args were strings.
615 (hash_var_name) Rename hash_var_by_name.
616 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
617 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
618 (var_is_very_long_string) Removed, because it was only interesting
620 (var_set_missing_values) Allow the argument to be the wrong width,
621 as long as we can resize it. Simplify callers who were doing the
623 (var_get_value_labels) New function.
624 (var_has_value_labels) New function.
625 (var_set_value_labels) New function.
626 (alloc_value_labels) New function.
627 (var_add_value_label) New function.
628 (var_replace_value_label) New function.
629 (var_clear_value_labels) New function.
630 (var_lookup_value_label) New function.
631 (var_get_value_name) Moved here from variable.c, renamed from
632 var_get_value_name, transposed argument order, updated all
634 (var_to_string) Moved here, from variable-label.c.
635 (var_set_leave) New function.
636 (var_get_leave) New function.
637 (var_must_leave) New function.
638 (var_set_short_name_suffix) Moved to dictionary.c, renamed
639 set_var_short_name_suffix.
640 (var_get_dict_index) New function.
641 (var_get_case_index) New function.
642 (var_get_obs_vals) New function.
643 (var_set_obs_vals) New function.
644 (var_has_obs_vals) New function.
645 (var_get_vardict) New function.
646 (var_set_vardict) New function.
647 (var_has_vardict) New function.
648 (var_clear_vardict) New function.
649 (value_dup) Moved to value.c.
650 (compare_values) Ditto.
653 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
654 (enum ALPHA) Rename VAR_STRING, update all users.
656 * vector.c: New file.
657 (struct vector) Moved here, from variable.h.
658 (check_widths) New function.
659 (vector_create) New function.
660 (vector_clone) New function.
661 (vector_destroy) New function.
662 (vector_get_name) New function.
663 (vector_get_var) New function.
664 (vector_get_var_cnt) New function.
665 (compare_vector_ptrs_by_name) New function.
667 * vector.h: New file.
669 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
671 * casefilter.c (casefilter_variable_missing): Avoided comparision of
672 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
675 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
677 * value-labels.c (destroy_atoms): New function.
678 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
680 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
682 Thanks to Jason Stover for pointing out this problem.
684 * data-out.c (output_number): Use gsl_finite from GSL, which is
685 portable, instead of isfinite, which is not.
688 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
690 * variable.c variable.h (value_dup): New function.
692 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
694 Start converting struct variable to an opaque type. In this
695 phase, we add a bunch of setter and getter functions and convert
696 most of the PSPP code to use them. The resulting changes are
697 pervasive but mostly trivial, and only the notable changes are
700 * format.c (fmt_equal): New function.
702 * variable.c (var_type_is_valid): New function.
703 (measure_is_valid) Moved here, from format.c.
704 (alignment_is_valid) Moved here, from format.c.
705 (var_get_name) New function.
706 (var_set_name) New function.
707 (width_to_type) New function.
708 (var_get_type) New function.
709 (var_get_width) New function.
710 (var_set_width) New function.
711 (var_is_numeric) New function.
712 (var_is_alpha) New function.
713 (var_is_short_string) New function.
714 (var_is_long_string) New function.
715 (var_is_very_long_string) New function.
716 (var_get_missing_values) New function.
717 (var_set_missing_values) New function.
718 (var_clear_missing_values) New function.
719 (var_has_missing_values) New function.
720 (var_is_value_missing) New function.
721 (var_is_num_missing) New function.
722 (var_is_str_missing) New function.
723 (var_is_value_user_missing) New function.
724 (var_is_num_user_missing) New function.
725 (var_is_str_user_missing) New function.
726 (var_is_value_system_missing) New function.
727 (var_get_print_format) New function.
728 (var_set_print_format) New function.
729 (var_get_write_format) New function.
730 (var_set_write_format) New function.
731 (var_set_both_formats) New function.
732 (var_get_label) New function.
733 (var_set_label) New function.
734 (var_clear_label) New function.
735 (var_has_label) New function.
736 (var_get_measure) New function.
737 (var_set_measure) New function.
738 (var_get_display_width) New function.
739 (var_set_display_width) New function.
740 (var_get_alignment) New function.
741 (var_set_alignment) New function.
742 (var_get_value_cnt) New function.
743 (var_get_leave) New function.
744 (var_get_short_name) New function.
746 * variable.h: (struct variable) Removed "type" and "nv" members;
747 they are now computed from "width" where needed.
749 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
751 * missing-values.c (mv_resize): Don't write beyond end of the
752 allocated buffer when resizing a long string.
754 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
756 Clean up identifier code: don't require identifier enumerations to
757 be in a particular order; make better use of string library;
758 expose less of the internals.
760 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
761 change interface. Updated all callers.
762 (lex_id_match) Change interface to use struct substring, update
764 (lex_id_match_len) Removed. Update callers to use lex_id_match.
765 (global array keywords[]) Make static, change form. Update all
766 users to use lex_id_name instead.
767 (lex_is_keyword) New function.
768 (lex_id_to_token) Change interface to use struct substring, update
770 (lex_id_name) New function.
772 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
773 lex_is_keyword instead.
774 (T_LAST_KEYWORD) Removed.
775 (T_N_KEYWORDS) Removed.
777 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
779 * format.c: (fmt_date_template) Distinguish characters for which a
780 space is output and any date delimiter is allowed on input, from
781 those for which a space is output and only a space is allowed on
782 input. The former is represented by X, the latter by a space.
783 Also, drop distinction between h and H, changing the former to the
786 * data-in.c: Completely rewrite internals to conform to SPSS input
787 formats as closely as possible.
788 (data_in) Changed external interface by replacing the structure
789 that was used as a single argument by a set of arguments. Updated
791 (data_in_finite_line) Removed. Converted all callers to use plain
793 (data_in_get_integer_format) New function.
794 (data_in_set_integer_format) New function.
795 (data_in_get_float_format) New function.
796 (data_in_set_float_format) New function.
798 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
799 (struct data_in) Removed.
801 * data-out.c: (output_date) Drop each component from the input as
802 it is output, to allow us to drop the distinction between h (a
803 count of hours) and H (the hour of day) template characters.
804 Also, handle new X template character.
805 (output_scientific) Follow more rational rule on when to drop
806 fraction introduced between SPSS 13 and 15. Updated test case to
809 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
811 Fix buffer overflow reported by John Darrington.
813 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
814 realize that DIGITS is a count of nibbles, not of bytes.
816 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
818 * calendar.c (calendar_offset_to_gregorian) Also return the
819 year-of-day. Change callers to new interface.
821 * data-out.c: Completely rewrite internals to conform to SPSS
822 output formats as completely as possible.
823 (data_out) Change interface to put input parameters before output
824 parameters, for consistency with the style I now prefer. Update
826 (data_out_get_integer_format) New public function.
827 (data_out_set_integer_format) New public function.
828 (data_out_get_float_format) New public function.
829 (data_out_set_float_format) New public function.
831 * data-out.h: New file. Move prototype for data_out here, from
834 * format.c: (fmt_step_width) Use equality comparison instead of
835 bitwise and, for clarity.
836 (fmt_is_string) Ditto.
837 (fmt_input_to_output) Fix categories that are translated to F
840 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
842 * casefilter.c casefilter.h (new files), casefile.c casefile.h
843 casefile-private.h: Added casefilter to assist commands with missing
846 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
848 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
850 * settings.c: (route_errors_to_terminal) New variable.
851 (route_errors_to_listing) New variable.
852 (get_error_routing_to_terminal) New function.
853 (set_error_routing_to_terminal) New function.
854 (get_error_routing_to_listing) New function.
855 (set_error_routing_to_listing) New function.
857 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
859 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
861 * format.c: Completely rewrite, to achieve better abstraction.
862 Rewrite all references to formats in other files.
864 * format.def: Rewrite and reorganize.
866 * settings.c: Move everything related to custom currency formats
867 into format.[ch], changing them in form, so as to group related
868 code and definitions better. Changed all references to use the
870 (static var decimal) Removed.
871 (static var grouping) Removed.
872 (static var cc) Removed.
873 (get_decimal) Removed.
874 (set_decimal) Removed.
875 (get_grouping) Removed.
876 (set_grouping) Removed.
880 * settings.h: (macro CC_CNT) Removed.
881 (macro CC_WIDTH) Removed.
882 (struct custom_currency) Removed.
884 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
886 * data-in.c (data_in): Use switch statement instead of table, to
887 avoid dependence on the order of the FMT_* enums.
889 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
891 * data-out.c: (num_to_string) Removed, because it was dead code.
893 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
895 * data-in.c (parse_trailer): Fix error message.
897 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
899 * format.c (fmt_is_binary): New function.
901 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
903 * procedure.c procedure.h: Encapsulated the static data into a single
906 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
908 * casefile.c (casereader_read_xfer): Always initialize the case,
909 even on an error condition.
911 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
913 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
914 entire function useless.
916 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
918 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
919 casereader method casereader_clone.
921 * procedure.c pransformations.h: Introduced new type casenum_t
923 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
925 * variable.c: (width_to_bytes) Rephrase code for clarify.
927 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
929 * format.c: (fmt_type_from_string) New function.
930 (fmt_to_string) Include decimals in output if the format has
931 decimals, even if the format type does not. This way, we can
932 accurately reproduce incorrect formats in user output.
933 (check_common_specifier) Make the check for a bad format type an
934 assertion, so we get bug reports if they show up. Fix message.
935 Check for decimal places with a format type that doesn't allow
937 (check_input_specifier) Remove check for FMT_X, which has been
939 (check_output_specifier) Ditto.
941 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
943 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
944 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
945 (enum fmt_parse_flags) Removed.
947 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
949 * casefile.c casefile.h: Converted to an abstract base class.
950 * casefile-private.h fastfile.c fastfile.h: New files.
951 * automake.mk procedure.c scratch-writer.c storage-stream.c
953 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
955 * procedure.c (internal_procedure): Create sink_case with only as
956 many values as the compacted dictionary.
958 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
960 Remove "debugging" code that caused plenty of false positives and
963 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
965 * case.c: Remove all references to `this' member.
967 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
969 Fix link error noted by Jason Stover.
971 * storage-stream.c: Include <assert.h>.
973 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
975 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
976 ALL) and additional underlying system file issues.
978 Thanks to John Darrington for review.
980 First problem: var_hash points to variables not owned by the
981 sys-file-reader, which the caller may free or modify. Use an
982 array of sfm_vars instead, as done earlier (e.g. CVS version
985 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
986 members and remove all code that references it. Add vars, var_cnt
987 members. Remove fix_specials member, which was unused.
988 (struct sfm_var) Remove name member, which was unused.
989 (sfm_close_reader) Free vars member instead of var_hash.
990 (compare_var_shortnames) Removed.
991 (hash_var_shortname) Removed.
992 (sfm_open_reader) Fill out vars array.
993 (compare_var_index) Removed.
994 (sfm_read_case) Use vars instead of var_hash.
996 Second problem: we're confused about when we actually have very
997 long strings, causing us to choose incorrectly between slow path
998 and fast path in sfm_read_case.
1000 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1001 have very long strings, not when we have long variable names,
1002 which is an unrelated feature.
1004 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1006 * variable.h: Move var_set and variable parsing declarations to
1007 new header, src/language/lexer/variable-parser.h. Modified lots
1008 of files to include the new header.
1010 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1012 * value-labels.c (value_to_string): When there's no value label,
1013 format the variable according to its print format, instead of
1014 always effectively using A or F format.
1016 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1018 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1021 * format.c: Removed tortological assertion.
1023 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1025 Reform string library.
1027 * file-name.c (fn_interp_vars): Change interface to take a
1028 substring as input. Updated all users.
1030 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1032 * format.c (measure_is_valid): Really return false when m >=
1035 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1037 Implement random access to casefiles, for use in GUI.
1039 * casefile.c: (struct casereader) Add `random', `file_ofs',
1040 `buffer_ofs' members.
1041 (casefile_get_random_reader) New function.
1042 (read_open_file) Break part into new function
1043 seek_and_fill_buffer().
1044 (fill_buffer) Update buffer_ofs, file_ofs.
1045 (casereader_seek) New function.
1047 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1049 * settings.c: Added call to i18n{done, init}.
1051 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1053 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1056 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1058 * casefile.c: Convert many uses of `int' to `bool'.
1060 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1062 * transformations.c (trns_chain_destroy): Destroy chain's trns
1063 member, to fix memory leak.
1065 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1067 * storage-stream.c (storage_source_decapsulate): Destroy case
1068 source to fix memory leak.
1070 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1072 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1073 case passed as argument instead of initializing the argument as a
1074 case. Fixes memory leak that showed up in
1075 tests/command/aggregate.sh with scratch files.
1077 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1079 * procedure.c (proc_done): Destroy default_dict, to fix memory
1082 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1084 Simplify procedure_with_splits().
1086 * procedure.c (struct split_aux_data): Removed case_count member.
1087 (procedure_with_splits) Don't initialize case_count.
1088 (split_procedure_case_func) Check whether prev_case is null
1089 instead of case_count.
1090 (split_procedure_end_func) Ditto.
1092 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1094 * case.c (case_move): Do nothing if dst and src are the same
1096 (case_try_create) Merge two similar cases.
1097 (case_copy) Unshare only if data must be actually copied.
1099 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1101 * data-in.c data-out.c dictionary.c sys-file-reader.c
1102 sys-file-writer.c variable.c variable.h: Reworked very long string
1103 support for better encapsulation.
1105 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1107 * value-labels.c (val_labs_can_set_width): New function.
1108 (val_labs_set_width) Clear labels if increasing width to long
1110 (val_labs_destroy) Remove unneeded test for null.
1112 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1114 * value-labels.h: Remove unneeded dependency on variable.h.
1116 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1118 Get rid of `char *c' member in union value, for cleanliness.
1120 * value.h: (union value) Remove `c' member.
1122 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1124 Make dictionary compacting functions a little more general.
1126 * sys-file-writer.c (sfm_open_writer): Use
1127 dict_compacting_would_change().
1128 (does_dict_need_translation) Removed.
1130 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1132 Make dictionary compacting functions a little more general.
1134 * dictionary.c (dict_needs_compaction): Rename
1135 dict_compacting_would_shrink(). Update all callers.
1136 (dict_compacting_would_change) New function.
1138 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1140 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1141 inverted return value (!).
1143 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1145 Continue reforming procedure execution.
1147 * procedure.c: Search and replace "vfm" by "proc". Notably:
1148 (static var vfm_source) Rename proc_source. Update all
1150 (static var vfm_sink) Rename proc_sink. Update all references.
1152 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1154 Continue reforming procedure execution. In this phase, remove
1155 PROCESS IF, which was deprecated anyway and can be easily
1156 simulated with TEMPORARY followed by SELECT IF.
1158 * procedure.c: (open_active_file) Don't call
1159 add_process_if_trns().
1160 (discard_variables) Get rid of redundant call to
1161 proc_cancel_all_transformations().
1162 (add_process_if_trns) Removed.
1163 (process_if_trns_proc) Removed.
1164 (process_if_trns_free) Removed.
1166 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1168 Continue reforming procedure execution. In this phase, add
1169 `const' to the case passed to procedure()'s callback.
1171 Updated all users of procedure() as well.
1173 * procedure.c: (struct write_case_data) Add "const" to ccase
1174 parameter for case_func member.
1175 (procedure) Add "const" to ccase parameter for proc_func
1177 (multipass_case_func) Make ccase parameter const.
1178 (internal_procedure) Add "const" to ccase parameter for case_func
1180 (split_procedure_case_func) Make ccase parameter const.
1181 (multipass_split_case_func) Make ccase parameter const.
1183 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1185 Continue reforming procedure execution. In this phase, get rid of
1186 the output code for SPLIT FILE groups in procedure.c, which really
1187 shouldn't be doing any output. Move it into the individual
1188 procedures instead. This also adds some flexibility.
1190 Updated many users of procedure_with_splits() and
1191 multipass_procedure_with_splits() to call
1192 output_split_file_values() and to deal with increased use of
1195 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1196 parameter to begin_func member.
1197 (procedure_with_splits) Add "const struct ccase *" parameter to
1198 begin_func parameter. Make ccase parameter const in proc_func
1200 (split_procedure_case_func) Don't dump split file group. Pass
1202 (dump_splits) Moved to language/dictionary/split-file.c as
1203 output_split_file_values().
1204 (struct multipass_split_aux_data) Add "const struct ccase *"
1205 parameter to split_func member.
1206 (multipass_procedure_with_splits) Add "const struct ccase *"
1207 parameter to split_func parameter.
1208 (multipass_split_case_func) Save new SPLIT FILE case before
1210 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1212 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1214 Continue reforming procedure execution. Change
1215 internal_procedure() so that it calls open_active_file() and
1216 close_active_file(), which isolates most of the actual procedure
1219 * procedure.c: (struct write_case_data) Rename `proc_func' member
1220 to `case_func' and update all references.
1221 (procedure) Rewrite as one-line wrapper around
1222 internal_procedure().
1223 (struct multipass_aux_data) New.
1224 (multipass_callback) Renamed multipass_case_func(). Use struct
1225 multipass_aux_data as auxiliary data.
1226 (multipass_end_func) New function.
1227 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1228 that uses multipass_case_func, multipass_end_func.
1229 (internal_procedure) Add `end_func' argument. Move optimization
1230 of trivial case in here. Move call to open_active_file() and
1231 close_active_file() in here. Now assert that vfm_source is
1233 (procedure_with_splits_callback) Rename
1234 split_procedure_case_func().
1235 (split_procedure_end_func) New function.
1236 (multipass_split_callback) Rename multipass_split_case_func.
1237 (multipass_split_end_func) New function.
1238 (discard_variables) No need to test for nonnull vfm_source.
1240 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1242 Continue reforming procedure execution. Get rid of unused member.
1244 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1246 (write_case) Don't increment cases_analyzed.
1248 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1250 Continue reforming procedure execution. In this phase, move
1251 procedure.c and procedure.h from src to src/data. Update
1252 makefiles and #includes accordingly.
1254 * procedure.c: Moved here from src/.
1256 * procedure.h: Moved here from src/.
1258 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1260 Continue reforming procedure execution. In this phase, get rid of
1261 many global variables, consolidating procedure execution in
1262 procedure.c. Encapsulate transformations in new "struct
1263 trns_chain". Also, change implementation of N OF CASES, FILTER,
1264 and PROCESS IF from special cases to transformations.
1266 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1269 * dictionary.c: (global variable default_dict) Move to
1272 * variable.h: (TRNS_*) Move to transformations.h.
1273 (struct transformation) Move to transformations.c.
1275 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1277 * sys-file-reader.c: Fixed invalid read problems.
1279 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1281 * storage-stream.c: Add missing function comments.
1283 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1285 Continue reforming procedure execution. In this phase, add some
1286 new, needed functionality to storage-stream.
1288 * storage-stream.c: (storage_source_decapsulate) New function.
1290 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1292 * variable.c (width_to_bytes): Declarations must precede
1293 statements for C90 compliance.
1295 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1297 * data-out.c, data-in.c, variable.c, variable.h: New functions
1298 copy_mangle and copy_demangle for reading/writing cases; emulates the
1299 way SPSS deals with strings > 255 bytes.
1301 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1302 subtype 14 needed for strings longer than 255 bytes.
1304 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1305 instead of literal values. Also fixed some constness issues.
1307 * format.h: Constness
1309 * sfm-private.h: Renamed the case_size identifier, since I discovered
1310 that SPSS's respect for this variable is very nominal.
1312 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1314 Change case limit type from int to size_t.
1316 * dictionary.c: (struct dictionary) Change type of case_limit
1318 (dict_get_case_limit) Change return type.
1319 (dict_set_case_limit) Change parameter type.
1321 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1323 * variable.h: (struct variable) Rename `reinit' member as `leave'
1324 and invert sense. Fix up all references.
1326 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1328 Continue reforming procedure execution. In this phase, break
1329 procedure.c into multiple files.
1331 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1333 * case-sink.c: New file.
1335 * case-sink.h: New file.
1337 * case-source.c: New file.
1339 * case-source.h: New file.
1341 * storage-stream.c: New file.
1343 * storage-stream.h: New file.
1345 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1347 * variable.h: (struct variable) Remove `init' member and all
1348 references to it from other files. It was initialized in several
1349 places, but nothing really ever used it for anything worthwhile.
1350 Thanks to Jason Stover for pointing out how confusing this
1353 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1355 Continue reforming error message support. In this phase, get rid
1356 of message "titles" and put the message text in `struct error'.
1357 Now `struct error' encapsulates a message more properly.
1359 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1360 Format message ourselves.
1362 * data-in.c: (vdls_error) Ditto.
1364 * por-file-reader.c: (error) Ditto.
1366 * sys-file-reader.c: (corrupt_msg) Ditto.
1368 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1370 GNU standards require "file name" instead of "filename" in
1371 documentation. It's nice for our code to follow the convention
1374 * casefile.c: (struct casefile) Rename `filename' member to
1375 `file_name'. Updated all references.
1377 * file-name.c: [!unix] (struct file_identity) Rename
1378 normalized_filename member to normalized_file_name. Updated all
1381 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1383 We don't really support anything but Unix-like environments well,
1384 so we might as well de-obfuscate by writing directory and path
1385 separators explicitly.
1387 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1389 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1390 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1392 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1395 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1397 GNU standards require "file name" instead of "filename" in
1398 documentation. It's nice for our code to follow the convention
1401 * filename.c: Rename to file-name.c.
1403 * filename.h: Rename to file-name.h. Update all inclusions.
1404 Update header guards.
1406 * automake.mk: Update file names.
1408 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1410 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1412 (fn_basename) Removed (dead code).
1413 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1414 (fn_special_p) Renamed fn_is_special(), all references updated.
1415 (fn_exists_p) Renamed fn_exists(), all references updated.
1417 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1419 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1420 Also, now it only tilde-expands file names, not paths.
1421 (fn_search_path) Tilde-expand one directory at a time.
1423 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1425 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1426 get rid of non-Unixlike version of the code, which has probably
1428 (fn_prepend_dir) Removed (dead code).
1430 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1431 (macro PATH_SEPARATOR_STRING) New.
1432 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1434 Continue reforming error message support. In this phase, we get
1435 rid of VM() and the other msg() support for "verbosity", replacing
1436 it by a new function verbose_msg().
1438 * filename.c: (fn_search_path) Use verbose_msg() instead of
1441 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1443 * sfm-private.h: Get rid of #defines after #error, which makes no
1446 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1448 Get rid of our own int32 type in favor of the standard int32_t
1451 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1454 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1456 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1458 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1460 Remove ill-considered file routines that are no longer used.
1462 * filename.c: (fn_open_ext) Removed.
1463 (fn_close_ext) Removed.
1465 * filename.h: (struct file_ext) Removed.
1467 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1469 * variable.c (var_is_valid_name): Move declarations before code
1472 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1474 * filename.ch (fn_interp_vars): Fixed small buglet.
1476 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1478 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1479 so as to modify the string inline. Thus makeing it easier to
1480 destroy the results when no longer needed.
1482 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1484 * category.c (cat_stored_values_destroy): Fixed memory leak.
1486 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1488 Add some missing frees. Thanks to John Darrington for reporting
1491 * any-writer.c (any_writer_close): Free writer.
1493 * any-reader.c (any_reader_close): Free reader.
1495 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1497 * por-file-reader.c: (error) Mark as NO_RETURN.
1499 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1501 * settings.c: Changed default value of scompress to true.
1503 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1505 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1507 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1510 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1511 here from pref.h.orig.
1513 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1515 * sys-file-reader.c: Fixed bug reading compressed files.
1517 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1519 * Numerous renames. See src/ChangeLog for details.
1521 * Moved files from src directory