1 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
3 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
6 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
8 * casefile.c: Convert many uses of `int' to `bool'.
10 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
12 * transformations.c (trns_chain_destroy): Destroy chain's trns
13 member, to fix memory leak.
15 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
17 * storage-stream.c (storage_source_decapsulate): Destroy case
18 source to fix memory leak.
20 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
22 * scratch-reader.c (scratch_reader_read_case): Copy into existing
23 case passed as argument instead of initializing the argument as a
24 case. Fixes memory leak that showed up in
25 tests/command/aggregate.sh with scratch files.
27 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
29 * procedure.c (proc_done): Destroy default_dict, to fix memory
32 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
34 Simplify procedure_with_splits().
36 * procedure.c (struct split_aux_data): Removed case_count member.
37 (procedure_with_splits) Don't initialize case_count.
38 (split_procedure_case_func) Check whether prev_case is null
39 instead of case_count.
40 (split_procedure_end_func) Ditto.
42 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
44 * case.c (case_move): Do nothing if dst and src are the same
46 (case_try_create) Merge two similar cases.
47 (case_copy) Unshare only if data must be actually copied.
49 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
51 * data-in.c data-out.c dictionary.c sys-file-reader.c
52 sys-file-writer.c variable.c variable.h: Reworked very long string
53 support for better encapsulation.
55 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
57 * value-labels.c (val_labs_can_set_width): New function.
58 (val_labs_set_width) Clear labels if increasing width to long
60 (val_labs_destroy) Remove unneeded test for null.
62 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
64 * value-labels.h: Remove unneeded dependency on variable.h.
66 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
68 Get rid of `char *c' member in union value, for cleanliness.
70 * value.h: (union value) Remove `c' member.
72 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
74 Make dictionary compacting functions a little more general.
76 * sys-file-writer.c (sfm_open_writer): Use
77 dict_compacting_would_change().
78 (does_dict_need_translation) Removed.
80 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
82 Make dictionary compacting functions a little more general.
84 * dictionary.c (dict_needs_compaction): Rename
85 dict_compacting_would_shrink(). Update all callers.
86 (dict_compacting_would_change) New function.
88 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
90 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
91 inverted return value (!).
93 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
95 Continue reforming procedure execution.
97 * procedure.c: Search and replace "vfm" by "proc". Notably:
98 (static var vfm_source) Rename proc_source. Update all
100 (static var vfm_sink) Rename proc_sink. Update all references.
102 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
104 Continue reforming procedure execution. In this phase, remove
105 PROCESS IF, which was deprecated anyway and can be easily
106 simulated with TEMPORARY followed by SELECT IF.
108 * procedure.c: (open_active_file) Don't call
109 add_process_if_trns().
110 (discard_variables) Get rid of redundant call to
111 proc_cancel_all_transformations().
112 (add_process_if_trns) Removed.
113 (process_if_trns_proc) Removed.
114 (process_if_trns_free) Removed.
116 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
118 Continue reforming procedure execution. In this phase, add
119 `const' to the case passed to procedure()'s callback.
121 Updated all users of procedure() as well.
123 * procedure.c: (struct write_case_data) Add "const" to ccase
124 parameter for case_func member.
125 (procedure) Add "const" to ccase parameter for proc_func
127 (multipass_case_func) Make ccase parameter const.
128 (internal_procedure) Add "const" to ccase parameter for case_func
130 (split_procedure_case_func) Make ccase parameter const.
131 (multipass_split_case_func) Make ccase parameter const.
133 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
135 Continue reforming procedure execution. In this phase, get rid of
136 the output code for SPLIT FILE groups in procedure.c, which really
137 shouldn't be doing any output. Move it into the individual
138 procedures instead. This also adds some flexibility.
140 Updated many users of procedure_with_splits() and
141 multipass_procedure_with_splits() to call
142 output_split_file_values() and to deal with increased use of
145 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
146 parameter to begin_func member.
147 (procedure_with_splits) Add "const struct ccase *" parameter to
148 begin_func parameter. Make ccase parameter const in proc_func
150 (split_procedure_case_func) Don't dump split file group. Pass
152 (dump_splits) Moved to language/dictionary/split-file.c as
153 output_split_file_values().
154 (struct multipass_split_aux_data) Add "const struct ccase *"
155 parameter to split_func member.
156 (multipass_procedure_with_splits) Add "const struct ccase *"
157 parameter to split_func parameter.
158 (multipass_split_case_func) Save new SPLIT FILE case before
160 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
162 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
164 Continue reforming procedure execution. Change
165 internal_procedure() so that it calls open_active_file() and
166 close_active_file(), which isolates most of the actual procedure
169 * procedure.c: (struct write_case_data) Rename `proc_func' member
170 to `case_func' and update all references.
171 (procedure) Rewrite as one-line wrapper around
172 internal_procedure().
173 (struct multipass_aux_data) New.
174 (multipass_callback) Renamed multipass_case_func(). Use struct
175 multipass_aux_data as auxiliary data.
176 (multipass_end_func) New function.
177 (multipass_procedure) Rewrite as wrapper for internal_procedure()
178 that uses multipass_case_func, multipass_end_func.
179 (internal_procedure) Add `end_func' argument. Move optimization
180 of trivial case in here. Move call to open_active_file() and
181 close_active_file() in here. Now assert that vfm_source is
183 (procedure_with_splits_callback) Rename
184 split_procedure_case_func().
185 (split_procedure_end_func) New function.
186 (multipass_split_callback) Rename multipass_split_case_func.
187 (multipass_split_end_func) New function.
188 (discard_variables) No need to test for nonnull vfm_source.
190 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
192 Continue reforming procedure execution. Get rid of unused member.
194 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
196 (write_case) Don't increment cases_analyzed.
198 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
200 Continue reforming procedure execution. In this phase, move
201 procedure.c and procedure.h from src to src/data. Update
202 makefiles and #includes accordingly.
204 * procedure.c: Moved here from src/.
206 * procedure.h: Moved here from src/.
208 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
210 Continue reforming procedure execution. In this phase, get rid of
211 many global variables, consolidating procedure execution in
212 procedure.c. Encapsulate transformations in new "struct
213 trns_chain". Also, change implementation of N OF CASES, FILTER,
214 and PROCESS IF from special cases to transformations.
216 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
219 * dictionary.c: (global variable default_dict) Move to
222 * variable.h: (TRNS_*) Move to transformations.h.
223 (struct transformation) Move to transformations.c.
225 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
227 * sys-file-reader.c: Fixed invalid read problems.
229 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
231 * storage-stream.c: Add missing function comments.
233 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
235 Continue reforming procedure execution. In this phase, add some
236 new, needed functionality to storage-stream.
238 * storage-stream.c: (storage_source_decapsulate) New function.
240 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
242 * variable.c (width_to_bytes): Declarations must precede
243 statements for C90 compliance.
245 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
247 * data-out.c, data-in.c, variable.c, variable.h: New functions
248 copy_mangle and copy_demangle for reading/writing cases; emulates the
249 way SPSS deals with strings > 255 bytes.
251 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
252 subtype 14 needed for strings longer than 255 bytes.
254 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
255 instead of literal values. Also fixed some constness issues.
257 * format.h: Constness
259 * sfm-private.h: Renamed the case_size identifier, since I discovered
260 that SPSS's respect for this variable is very nominal.
262 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
264 Change case limit type from int to size_t.
266 * dictionary.c: (struct dictionary) Change type of case_limit
268 (dict_get_case_limit) Change return type.
269 (dict_set_case_limit) Change parameter type.
271 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
273 * variable.h: (struct variable) Rename `reinit' member as `leave'
274 and invert sense. Fix up all references.
276 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
278 Continue reforming procedure execution. In this phase, break
279 procedure.c into multiple files.
281 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
283 * case-sink.c: New file.
285 * case-sink.h: New file.
287 * case-source.c: New file.
289 * case-source.h: New file.
291 * storage-stream.c: New file.
293 * storage-stream.h: New file.
295 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
297 * variable.h: (struct variable) Remove `init' member and all
298 references to it from other files. It was initialized in several
299 places, but nothing really ever used it for anything worthwhile.
300 Thanks to Jason Stover for pointing out how confusing this
303 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
305 Continue reforming error message support. In this phase, get rid
306 of message "titles" and put the message text in `struct error'.
307 Now `struct error' encapsulates a message more properly.
309 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
310 Format message ourselves.
312 * data-in.c: (vdls_error) Ditto.
314 * por-file-reader.c: (error) Ditto.
316 * sys-file-reader.c: (corrupt_msg) Ditto.
318 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
320 GNU standards require "file name" instead of "filename" in
321 documentation. It's nice for our code to follow the convention
324 * casefile.c: (struct casefile) Rename `filename' member to
325 `file_name'. Updated all references.
327 * file-name.c: [!unix] (struct file_identity) Rename
328 normalized_filename member to normalized_file_name. Updated all
331 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
333 We don't really support anything but Unix-like environments well,
334 so we might as well de-obfuscate by writing directory and path
335 separators explicitly.
337 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
339 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
340 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
342 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
345 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
347 GNU standards require "file name" instead of "filename" in
348 documentation. It's nice for our code to follow the convention
351 * filename.c: Rename to file-name.c.
353 * filename.h: Rename to file-name.h. Update all inclusions.
354 Update header guards.
356 * automake.mk: Update file names.
358 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
360 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
362 (fn_basename) Removed (dead code).
363 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
364 (fn_special_p) Renamed fn_is_special(), all references updated.
365 (fn_exists_p) Renamed fn_exists(), all references updated.
367 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
369 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
370 Also, now it only tilde-expands file names, not paths.
371 (fn_search_path) Tilde-expand one directory at a time.
373 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
375 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
376 get rid of non-Unixlike version of the code, which has probably
378 (fn_prepend_dir) Removed (dead code).
380 * filename.h: (macro DIR_SEPARATOR_STRING) New.
381 (macro PATH_SEPARATOR_STRING) New.
382 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
384 Continue reforming error message support. In this phase, we get
385 rid of VM() and the other msg() support for "verbosity", replacing
386 it by a new function verbose_msg().
388 * filename.c: (fn_search_path) Use verbose_msg() instead of
391 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
393 * sfm-private.h: Get rid of #defines after #error, which makes no
396 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
398 Get rid of our own int32 type in favor of the standard int32_t
401 * sfm-private.h: (int32 macro) Don't define this anymore. Do
404 * sys-file-reader.c: Use int32_t instead of int32 throughout.
406 * sys-file-writer.c: Use int32_t instead of int32 throughout.
408 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
410 Remove ill-considered file routines that are no longer used.
412 * filename.c: (fn_open_ext) Removed.
413 (fn_close_ext) Removed.
415 * filename.h: (struct file_ext) Removed.
417 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
419 * variable.c (var_is_valid_name): Move declarations before code
422 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
424 * filename.ch (fn_interp_vars): Fixed small buglet.
426 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
428 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
429 so as to modify the string inline. Thus makeing it easier to
430 destroy the results when no longer needed.
432 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
434 * category.c (cat_stored_values_destroy): Fixed memory leak.
436 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
438 Add some missing frees. Thanks to John Darrington for reporting
441 * any-writer.c (any_writer_close): Free writer.
443 * any-reader.c (any_reader_close): Free reader.
445 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
447 * por-file-reader.c: (error) Mark as NO_RETURN.
449 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
451 * settings.c: Changed default value of scompress to true.
453 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
455 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
457 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
460 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
461 here from pref.h.orig.
463 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
465 * sys-file-reader.c: Fixed bug reading compressed files.
467 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
469 * Numerous renames. See src/ChangeLog for details.
471 * Moved files from src directory