1 2007-08-27 John Darrinton <john@darrington.wattle.id.au>
3 * sys-file-reader.c (read_display_parameters): Force display width
4 to 8, if the sys file says 0 (like SPSS does).
6 2007-08-12 Ben Pfaff <blp@gnu.org>
8 * dictionary.c (dict_dump): New function.
10 2007-08-12 Ben Pfaff <blp@gnu.org>
12 Drop dict_compactor in favor of using the new struct case_map.
14 * dictionary.c (struct copy_map): Removed.
15 (struct dict_compactor): Removed.
16 (dict_make_compactor): Removed.
17 (dict_compactor_compact): Removed.
18 (dict_compactor_destroy): Removed.
20 * procedure.c (struct data_set): Change `compactor' member to be a
22 (proc_open): Use case_map_to_compact_dict instead of
24 (proc_casereader_read): Use case_map_execute instead of
25 dict_compactor_compact.
26 (proc_commit): Use case_map_destroy instead of
27 dict_compactor_destroy.
29 * scratch-writer.c (struct scratch_writer): Change `compactor'
30 member to be a struct case_map *.
31 (scratch_writer_open): Use case_map_to_compact_dict instead of
33 (scratch_writer_casewriter_write): Use case_map_execute instead of
34 dict_compactor_compact.
36 2007-08-12 Ben Pfaff <blp@gnu.org>
38 * automake.mk: Add case-map.c, case-map.h.
40 * case-map.c: New file.
42 * case-map.h: New file.
44 2007-08-12 Ben Pfaff <blp@gnu.org>
46 * dictionary.c (dict_compact_values): Don't delete scratch
47 variables as well as compacting case indexes. Update all callers.
48 (dict_get_compacted_value_cnt): Rename dict_count_values and
49 change interface. Update all callers.
50 (dict_get_compacted_value_cnt): Remove.
51 (dict_compacting_would_shrink): Remove.
52 (dict_compacting_would_change): Remove.
53 (dict_make_compactor): Add new parameter. Update all callers.
55 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
56 instead of dict_count_values, changing an O(N) operation into
59 2007-08-12 Ben Pfaff <blp@gnu.org>
61 * casereader.c (casereader_read): Don't require cases read by a
62 casereader to be exactly the expected size: as long as they're big
65 2007-08-12 Ben Pfaff <blp@gnu.org>
67 Make casewriters keep track of the number of `union value's in
68 each case. This is useful for two reasons: casewriter_write can
69 then check that the case being written is large enough, and later
70 recipients of the casewriter can determine the size of the case.
72 * casewriter-translator.c (casewriter_create_translator): Add
75 * casewriter.c (struct casewriter): Add value_cnt member.
76 (casewriter_write): Check that the case passed in is big enough.
77 (casewriter_get_value_cnt): New function.
78 (casewriter_create): Add value_cnt parameter.
80 2007-08-09 Ben Pfaff <blp@gnu.org>
82 Fix bug reported by Jason Stover.
83 * settings.c: Move get_termcap_viewport and in particular the
84 #include for <curses.h> to the end of the file. curses.h
85 redefines bool on some systems (e.g. OpenBSD), which causes
86 disagreement between uses of bool before its inclusion and
88 Tested by Jason Stover.
90 2007-07-29 Ben Pfaff <blp@gnu.org>
92 Provisional fix for bug #18692 and bug #20161. Reviewed by John
95 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
96 argument (never "rb" or "wb") because SUSv3 says that only those
97 modes are defined, and glibc in fact rejects other modes.
99 Open portable files with fn_open so that they can be read from
100 pipes. Fix missing fh_close call to go along with fh_open.
101 Report an error if the file close reports an error.
102 * por-file-reader.c (close_reader): New function.
103 (por_file_casereader_destroy): Use close_reader.
104 (pfm_open_reader): Open file with fn_open.
106 2007-07-28 Ben Pfaff <blp@gnu.org>
108 Make PSPP able to read all the portable files I could find on the
109 web. Thanks to John Darrington for review. Bug #17620.
110 * por-file-reader.c (struct pfm_reader): New member `line_length'.
111 (error): Print file offset in hexadecimal.
112 (warning): New function.
113 (advance): Treat lines less than 80 bytes long as padded to 80
115 (pfm_open_reader): Call read_documents if we find an "E" record.
116 (convert_format): Convert invalid formats to the default format
117 instead of aborting reading the file.
118 (read_variables): Rename duplicate variable names instead of
119 aborting reading the file.
120 (read_value_label): Allow string variables of different widths to
121 be assigned value labels in the same record. Replace duplicate
122 value labels instead of aborting.
123 (read_documents): New function.
125 * por-file-writer.c (pfm_open_writer): Call write_documents if the
126 dictionary has documents.
127 (write_documents): New function.
129 2007-07-25 Ben Pfaff <blp@gnu.org>
131 Fix bugs related to bug #17213.
133 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
134 since the former is what config.h has. Include the needed ncurses
136 (static var echo) Rename to `do_echo' because the original name is
137 the same as an ncurses identifier.
138 (get_termcap_viewport) Use error instead of msg.
140 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
141 (fn_close): Don't close stdin, stdout, stderr.
143 2007-07-26 John Darrington <john@darrington.wattle.id.au>
145 * procedure.c procedure.h: Added callbacks which get invoked whenever
146 a dataset's transformation chain changes.
148 2007-07-24 Ben Pfaff <blp@gnu.org>
151 * sys-file-writer.c (write_variable_display_parameters): Use new
152 var_default_display_width function to choose display width of
153 segments after the first one in a given variable.
154 * variable.c (var_create): Use var_default_display_width to pick
155 new variable's display width.
156 (var_default_display_width): New function.
157 Reviewed by John Darrington.
159 2007-07-24 Ben Pfaff <blp@gnu.org>
162 * por-file-writer.c (write_variables): Write weight variable.
163 Reviewed by John Darrington.
165 2007-07-23 Ben Pfaff <blp@gnu.org>
167 Improvements to system file reader and writer.
169 First, move all detailed knowledge of very long strings into
170 sys-file-private.[ch], so that this nasty stuff can be isolated.
172 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
173 (EFFECTIVE_VLS_CHUNK): New macro.
174 (min_int): New function.
175 (max_int): New function.
176 (sfm_width_to_bytes): Rewrite.
177 (sfm_width_to_octs): New function.
178 (sfm_segment_alloc_width): New function.
179 (sfm_segment_alloc_bytes): New function.
180 (sfm_segment_used_bytes): New function.
181 (sfm_segment_offset): New function.
182 (sfm_segment_effective_offset): New function.
183 (sfm_dictionary_to_sfm_vars): New function.
185 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
186 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
187 (struct sfm_var): New structure.
189 Next, improvements to the system file reader.
191 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
192 type casenumber. Added `version_major', `version_minor',
195 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
196 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
197 Change `case_cnt' to type casenumber. Removed `has_vls'.
198 (struct sfm_var): Removed.
199 (sfm_open_reader): Don't warn on wrong case size if the file was
200 written by SPSS 13, which tends to get it wrong. Use
201 sfm_dictionary_to_sfm_vars.
202 (read_header): Always output system file info.
203 (read_variable_record): Simplify code for reading missing values.
204 (read_machine_int32_info): Save version numbers from system file
205 into info struct passed as new argument.
206 (read_long_string_map): Restructured to use new sys-file-private
208 (read_value_labels): Use size_overflow_p.
209 (sys_file_casereader_read): Get rid of distinction between fast
210 and slow paths. Use information provided by sys-file-primate's
211 struct sfm_var to simplify code.
212 (skip_whole_strings): New function.
213 (read_int32): Renamed read_int. Changed return value to int.
215 (read_flt64): Renamed read_float. Changed return value to
216 double. Updated all callers.
217 (int32_to_native): Removed. Changed callers to use
219 (flt64_to_double): Removed. Changed callers to use float_convert.
221 Finally, get rid of int32, flt64 terminology and types in system
222 file writer. The former wasn't very useful since a POSIX "int"
223 can hold the whole range of int32 and we generally didn't have a
224 need for it to be exactly-32-bits, just at-least-32-bits. The
225 latter was inconvenient because we had to assume that it could be
226 different from double and thereby convert special values SYSMIS,
227 HIGHEST, LOWEST to and from it in multiple places. Instead, now
228 we just use "int" and "double" in most places, and do conversions,
229 if necessary, very close to where we do I/O. This change meant
230 that the writer code couldn't represent records in the file as C
231 structs any longer, but that's no great loss. The code actually
232 seems to be more readable without them.
234 Simplify the compression buffering code: only buffer as much as
235 necessary, which is no more than eight 8-byte units at any given
238 * sys-file-writer.c (typedef flt64): Removed.
239 (macro second_lowest_flt64): Removed.
240 (struct sysfile_header): Removed.
241 (struct sysfile_variable): Removed.
242 (struct sfm_writer): Removed `needs_translation', `has_vls',
243 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
244 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
245 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
246 compression buffering by `opcodes', `opcode_cnt', `data',
247 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
248 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
249 data writer functions instead of structures.
250 (calc_oct_idx): New function.
251 (write_header): Use simple data writer functions instead of
253 (write_format_spec): Renamed write_format. New argument.
254 (write_variable_continuation_records): New function.
255 (write_variable): Use simple data writer functions instead of
256 structures. Use write_variable_continuation_records. Write
257 entire very long string instead of requiring caller to understand
259 (write_value_labels): Use simple data writer functions instead of
261 (write_documents): Ditto.
262 (write_variable_display_parameters): Use sys-file-private
263 functions to simplify. Use simple data writer functions instead
265 (write_vls_length_table): Use simple data writer functions instead
267 (write_longvar_table): Ditto.
268 (write_rec_7_34): Break into new functions
269 write_integer_info_record, write_float_info_record. Use simple
270 data writer functions instead of structures.
271 (buf_write): Removed.
272 (append_string_max): Removed.
273 (ensure_buf_space): Removed.
274 (sys_file_casewriter_write): Get rid of the distinction between
275 fast and slow paths, which didn't seem to be too useful. Use new
276 functions write_case_uncompressed, write_case_compressed.
277 (put_instruction): Removed.
278 (put_element): Removed.
279 (write_compressed_data): Removed.
280 (close_writer): Use flush_compressed. Only write case count to
281 system file if it will fit in the field.
282 (write_case_compressed): New function.
283 (write_case_uncompressed): New function.
284 (flush_compressed): New function.
285 (put_cmp_opcode): New function.
286 (put_cmp_number): New function.
287 (write_int): New function.
288 (convert_double_to_output_format): New function.
289 (write_float): New function.
290 (write_value): New function.
291 (write_string): New function.
292 (write_bytes): New function.
293 (write_zeros): New function.
294 (write_spaces): New function.
296 Reviewed by John Darrington.
298 2007-07-22 Ben Pfaff <blp@gnu.org>
300 Don't try to write very long strings to portable files. The
301 format does not support it.
303 * por-file-writer.c (MAX_POR_WIDTH): New macro.
304 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
305 (write_format): Add arg to take width to resize format to.
306 (write_value): Limit width of value written to MAX_POR_WIDTH.
307 (write_variables): Limit width of variable and its output formats
309 Reviewed by John Darrington.
311 2007-07-22 Ben Pfaff <blp@gnu.org>
313 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
314 local variable instead of literal 5.
315 Reviewed by John Darrington.
317 2007-07-22 Ben Pfaff <blp@gnu.org>
319 Fix problems with uniqueness of short names in system files with
320 very long string variables. Now a variable may have multiple
323 * automake.mk (src_data_libdata_a_SOURCES): Add new files
324 short-names.c, short-names.h.
326 * dictionary.c (dict_clone): Clone all the short names.
327 (compare_strings): Move into short-names.c.
328 (hash_strings): Ditto.
329 (set_var_short_name_suffix): Ditto.
330 (dict_assign_short_names): Ditto, rename short_names_assign,
331 change to assign all short names.
333 * por-file-writer.c (write_variables): Use short_names_assign
334 instead of dict_assign_short_names.
336 * short-names.c: New file.
338 * short-names.h: New file.
340 * sys-file-private.c (sfm_width_to_segments): New function.
342 * sys-file-reader.c (read_long_var_name_map): Save and restore all
343 the short names, not just the first one.
345 * sys-file-writer.c (cont_var_name): Removed.
346 (sfm_open_writer): Use short_names_assign instead of
347 dict_assign_short_names. Use unique short names assigned by
348 short_names_assign instead of those generated by cont_var_name.
350 * variable.c (struct variable): Remove `short_name' member,
351 replace by `short_names' and `short_name_cnt'.
352 (var_create) Initialize new members.
353 (var_get_short_name_cnt): New function.
354 (var_get_short_name): Now takes an index argument. Changed most
356 (var_set_short_name): Ditto.
357 (var_clear_short_name): Renamed var_clear_short_names, changed to
358 clear all short names.
360 Reviewed by John Darrington.
362 2007-07-22 Ben Pfaff <blp@gnu.org>
364 * variable.c (var_set_width): Use new var_set_width function.
366 * missing-values.c (mv_n_values): Drop assertion, which was not
369 * format.c (fmt_default_for_width): New function.
370 (fmt_resize): New function.
372 Reviewed by John Darrington.
374 2007-07-18 John Darrington <john@darrington.wattle.id.au>
376 * datasheet.c (datasheet_delete_columns): Added assertion to check
377 we're not deleting outside the range of the sheet.
380 * dictionary.c dictionary.h variable.c: Added the ability for string
381 variables to be resized.
383 * vardict.h: Added some prototypes (moved from dictionary.h) as
384 these should only be called by variable.c
387 2007-07-14 John Darrington <john@darrington.wattle.id.au>
389 * sfm-reader.c: Respect case_cnt field in file header.
391 2007-07-01 John Darrington <john@darrington.wattle.id.au>
393 * transformation.c transformation.h (trns_chain_execute): Changed the
394 signature (Patch #6057)
396 2007-06-10 Ben Pfaff <blp@gnu.org>
398 * casereader-filter.c (casereader_filter_destroy): Make sure to
399 write all the remaining excluded cases to the casewriter, if any.
401 * caseinit.c (init_list_destroy): Rewrite.
402 (init_list_clear): Ditto.
404 * casegrouper.c (casegrouper_get_next_group): Always set *reader
405 to null when returning false.
407 2007-06-06 Ben Pfaff <blp@gnu.org>
409 Actually implement the new procedure code and adapt all of its
410 clients to match. Also adapt all of the other case sources and
411 sinks in the tree and their clients to use the
412 casereader/casewriter infrastructure.
414 * automake.mk: Add and remove files.
416 * any-reader.c: Change into a casereader.
417 * por-file-reader.c: Ditto.
418 * scratch-reader.c: Ditto.
419 * sys-file-reader.c: Ditto.
421 * any-writer.c: Change into a casewriter.
422 * por-file-writer.c: Ditto.
423 * scratch-writer.c: Ditto.
424 * sys-file-writer.c: Ditto.
426 * procedure.c: Change to use casereader, casewriter, caseinit, and
427 other new infrastructure.
429 * scratch-handle.c: Adapt to new infrastructure.
431 * case-sink.c: Removed, now dead code.
432 * case-sink.h: Ditto.
433 * case-source.c: Ditto.
434 * case-source.h: Ditto.
435 * casefile-factory.c: Ditto.
436 * casefile-private.h: Ditto.
439 * casefilter.c: Ditto.
440 * casefilter.h: Ditto.
443 * fastfile-factory.c: Ditto.
444 * fastfile-factory.h: Ditto.
445 * storage-stream.c: Ditto.
446 * storage-stream.h: Ditto.
448 2007-06-06 Ben Pfaff <blp@gnu.org>
452 * automake.mk: Add new files.
454 * datasheet.c: New file.
456 * datasheet.h: New file.
458 2007-06-06 Ben Pfaff <blp@gnu.org>
460 Until now, the procedure code has provided a case to the
461 case_source, which has filled in the data values that come from
462 the active file. "Left" data values that don't come from the
463 active file naturally stay the same from case to case, because the
464 procedure code keeps using that same case.
466 One of the compromises that comes with the new procedure code is
467 that the active file allocates and provides its own case, which
468 the procedure code then has to resize to provide room for any
469 other variables that should go in the case and then fill in the
470 values of "left" variables. Then, when we're done with that case,
471 we have to save the values of "left" variables to copy into the
472 next case read from the active file.
474 The caseinit code helps with this.
476 * automake.mk: Add new files.
478 * caseinit.c: New file.
480 * caseinit.h: New file.
482 2007-06-06 Ben Pfaff <blp@gnu.org>
484 * value.h (value_cnt_from_width): New function.
486 * variable.c (var_get_value_cnt): Use new function.
488 2007-06-06 Ben Pfaff <blp@gnu.org>
490 Add casegrouper, to allow cases read from a given casereader to be
491 broken into groups, each of which has its own casereader.
492 Generally cases are grouped based on having equal values for some
495 * automake.mk: Add new files.
497 * casegrouper.c: New file.
499 * casegrouper.h: New file.
501 2007-06-06 Ben Pfaff <blp@gnu.org>
503 Add interface to lexicographical ordering of cases.
505 * automake.mk: Add new files.
507 * case-ordering.c: New file.
509 * case-ordering.h: New file.
511 2007-06-06 Ben Pfaff <blp@gnu.org>
513 Add casereaders and casewriters, the basis of the new data processing
514 implementation. A casereader is a uniform interface to reading cases
515 from a data source; a casewriter is a uniform interface to writing
516 cases to a data sink.
518 * automake.mk: Add new files.
520 * casereader-filter.c: New file.
522 * casereader-provider.h: New file.
524 * casereader-translator.c: New file.
526 * casereader.c: New file.
528 * casereader.h: New file.
530 * casewriter-provider.h: New file.
532 * casewriter-translator.c: New file.
534 * casewriter.c: New file.
536 * casewriter.h: New file.
538 2007-06-06 Ben Pfaff <blp@gnu.org>
540 "casewindow" data structure that extends the deque (from libpspp)
541 of cases with the ability to dump cases to disk if we get too many
544 * automake.mk: Add new files.
546 * casewindow.c: New file.
548 * casewindow.h: New file.
550 2007-06-06 Ben Pfaff <blp@gnu.org>
552 sparse_cases data structure that augments a sparse_array of cases
553 with the ability to dump cases to disk if we get too many cases in
556 * automake.mk: Add new files.
558 * sparse-cases.c: New file.
560 * sparse-cases.h: New file.
562 2007-06-06 Ben Pfaff <blp@gnu.org>
564 Adds a low-level on-disk case array data structure.
566 * automake.mk: Add new files.
568 * case-tmpfile.c: New file.
570 * case-tmpfile.h: New file.
572 2007-06-06 Ben Pfaff <blp@gnu.org>
574 In a couple of places we calculate the maximum number of cases to
575 keep in memory based on the user-defined workspace. Enable
576 centralizing the calculation through a new function.
578 * settings.c (get_workspace_cases): New function.
580 2007-06-06 Ben Pfaff <blp@gnu.org>
582 The casenumber type is defined in transformations.h, but case.h is
583 a more sensible place. Move it.
585 * case.h (CASENUMBER_MAX): New macro.
586 (typedef casenumber): Move here, from transformations.h.
588 2007-06-03 Ben Pfaff <blp@gnu.org>
590 Slightly generalize case_to_values and case_from_values functions.
592 * case.c (case_to_values): Rename case_copy_out, change interface.
593 (case_from_values): Rename case_copy_in, change interface.
595 * fastfile.c (fastfilereader_get_next_case): Update caller.
596 (write_case_to_disk): Ditto.
598 2007-06-02 Ben Pfaff <blp@gnu.org>
600 Clean up after a forgotten part of patch #5829.
602 * casedeque.h: Remove unused file.
604 * automake.mk: Remove casedeque.h from sources.
606 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
608 * category.c: Removed redundant #include
610 2007-05-06 Ben Pfaff <blp@gnu.org>
612 Abstract the documents within a dictionary a little better.
613 Thanks to John Darrington for suggestion, initial version, and
616 * dictionary.c (struct dictionary): Change `documents' member from
617 char * to struct string.
618 (dict_clear): Destroy struct string.
619 (dict_get_documents): Convert struct string to char *.
620 (dict_set_documents): Set struct string. Pad to 80-character
622 (dict_clear_documents): New function.
623 (dict_add_document_line): New function.
624 (dict_get_document_line_cnt): New function.
625 (dict_get_document_line): New function.
627 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
629 * sys-file-reader.c (read_documents): Use new document functions.
631 2007-04-19 John Darrington <john@darrington.wattle.id.au>
633 * sys-file-reader.c: When reading a system file which has no
634 long name table, automatically create one where the long names
635 are the lower case versions of the short names.
637 2007-04-22 Ben Pfaff <blp@gnu.org>
639 * dictionary.c (dict_set_split_vars): dict_destroy expects that
640 dict_clear will free most data related to the dictionary.
641 dict_clear does a decent job, except that dict_set_split_vars on
642 some systems won't actually free the dict's "split" member.
643 Instead, it'll allocate a 1-byte region. Fix this.
645 * value.c (value_copy): New function.
646 (value_set_missing): Ditto.
648 2007-04-22 John Darrington <john@darrington.wattle.id.au>
650 * Deleted existing category.h and moved cat-routines.h into
651 category.h Encapsulated struct cat_vals better.
653 2007-04-19 John Darrington <john@darrington.wattle.id.au>
655 * sys-file-reader.c: When reading a system file which has no
656 long name table, automatically create one where the long names
657 are the lower case versions of the short names.
659 2007-04-16 John Darrington <john@darrington.wattle.id.au>
661 * sys-file-reader.c: Some versions of Other Software seem to
662 produce system files with string variables' measure set to
663 zero. We'll assume these are supposed to be nominal variables.
665 2007-03-30 Ben Pfaff <blp@gnu.org>
667 * procedure.c: Adapt to new deque data structure.
669 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
670 Ben Pfaff <blp@gnu.org>
672 * file-name.c: Mingw compatibility fixes.
673 (fn_search_path): Use ISSLASH instead of comparing against '/'
675 (fn_dir_name): Use dir_name from gnulib.
676 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
677 (fn_get_identity): Use GetFullPathName instead of canonicalize
678 from gnulib, because the latter does not fully support
679 Windows-style path names. Use this implementation based on the
680 detected presence of Windows instead of the absence of Unix, since
681 the new implementation is Windows-specific.
682 (fn_compare_file_identities): In Windows implementation, compare
683 names case-insensitively.
685 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
687 * make-file.c: Don't include mkstemp.h, because gnulib now causes
688 <stdlib.h> to have the same effect.
690 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
692 * por-file-reader.c: Add missing _() around messages.
694 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
696 * make-file.c: Include "mkstemp.h", without which linking on
699 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
701 Reduce platform dependence.
703 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
704 Everywhere we using this, we really should have just depended on
705 the shell to expand tildes.
706 (fn_search_path): Simplify, given that we don't do tilde expansion
708 (fn_normalize): Removed. Caller changed to use the canonicalize
710 (fn_get_cwd): Removed. Only user was fn_normalize.
711 (fn_is_absolute): Really only test for absolute names.
712 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
714 (fn_readlink): Removed, as it was only used fn_normalize.
715 (fn_exists): Assume the stat function is available; gnulib does.
716 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
718 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
720 * dictionary.c (dict_create_vector_assert): New function.
722 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
724 * file-name.c (fn_normalize): Correct name of function
725 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
726 for pointing this out.
728 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
730 We are using a single member in struct file_handle, the "name"
731 field, for more than one purpose. When it begins with '"', it's a
732 file name; otherwise, it's a token that can be used to identify
733 it. When that assertion fires, it's because we searched for the
734 name case-sensitively as a file name (so that there was no match),
735 and then we try to insert it case-insensitively as a token, which
736 fails because duplicates aren't allowed.
738 Solution: break the two purposes into two separate fields. This
739 fixes the problem and likely makes the code easier to read too.
741 Fixes bug #18922. Thanks to John Darrington for bug report and
744 * file-handle-def.c (struct file_handle): New `id' member.
745 (fh_from_name): Rename fh_from_id. Update all callers.
746 (create_handle): New `id' parameter. Update all callers.
747 (fh_create_file): Ditto.
748 (fh_get_id): New function.
750 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
752 * case.c (case_is_null): Change return type to bool.
754 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
758 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
759 reference counting to share data. This makes it easy for
760 valgrind, etc. to find accesses to cases that have been destroyed
761 but have been kept around by another user's ref-count. This often
762 happens when the data set is small enough to find in memory; if a
763 bigger data set that would overflow to disk were used, then data
764 corruption would occur.
766 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
770 * case.c (case_unshare): Make it check internally whether the
771 ref_cnt is greater than 1, so that the callers don't have to.
772 Update callers not to check.
774 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
776 Before, I was thinking that I might want to get rid of reference
777 counting at some point. Now, I'm pretty sure that it's here to
778 stay. Thus, because we have to store the value_cnt anyway for
779 reference-counted cases, we might as well expose it to users.
781 * case.c (case_get_value_cnt): New function.
782 (case_resize): Drop OLD_CNT argument. Update all callers. Only
783 resize case if its size actually changed.
785 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
786 instead of peeking inside struct case directly.
787 (casefile_append): Ditto.
789 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
791 Get rid of the inlines for the case functions, which made the
792 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
793 the inlines didn't speed up "make check" at all, which is not a
794 perfect benchmark but seems indicative.)
796 * case.c: Remove #ifdef DEBUGGING...#endif around many function
797 definitions. Remove some assertions on nonnull pointers that were
798 redundant with a pointer dereference soon after in the function.
800 (struct case_data): Move definition here from case.h.
804 (case_data_wr): Ditto.
806 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
808 * automake.mk: Add casedeque.h to sources.
810 * casedeque.h: New file.
812 * procedure.c: (struct dataset) Change lag_count, lag_head,
813 lag_queue member into single struct casedeque member. Update all
814 users to use the casedeque instead.
817 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
819 * procedure.c: Simplify lagged cases interface. Updated all
820 clients--well, the only client--to use the simplified interface.
821 (dataset_n_lag) Removed.
822 (dataset_set_n_lag) Removed.
823 (dataset_need_lag) New function.
825 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
827 * dictionary.c procedure.c: More changes to ensure that callbacks occur
828 whenever appropriate, but only when the dataset/dictionary is in a
831 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
833 * dictionary.c dictionary.h : Added callbacks for change of filter and
834 split variables. Refactored some code to ensure that callbacks get
835 invoked when appropriate.
837 * procedure.c (proc_cancel_temporary_transformations): Make sure that
838 replace_dict callback occurs when permanent_dict replaces the current
841 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
843 * dictionary.c dictionary.h : Added callback for when the weight
844 variable of a dictionary changes.
846 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
848 * dictionary.c dictionary.h : Added replace_source and replace_dict
849 callbacks, and functions to deal with them.
851 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
853 Simplify missing value handling.
855 * missing-values.h (enum mv_class): New type.
856 (enum mv_type): Moved definition into missing-values.c and renamed
857 each MV_* to MVT_*, to distinguish them from the exposed mv_class
858 enums. Updated all uses.
859 (struct missing_values): Changed type of `type' from `enum
860 mv_type' to `int' because the definition is no longer exposed.
862 * missing-values.c (mv_is_value_missing): Add new enum mv_class
863 parameter. Update all callers.
864 (mv_is_num_missing): Ditto.
865 (mv_is_str_missing): Ditto.
866 (mv_is_value_user_missing): Removed. Changed callers to use
868 (mv_is_num_user_missing): Removed. Changed callers to use
870 (mv_is_str_user_missing): Removed. Changed callers to use
872 (mv_is_value_system_missing): Removed. Changed callers to use
874 (mv_set_type): Removed. Changed callers to use mv_clear.
875 (mv_clear): New function.
877 * variable.c (var_is_value_missing): Add new enum mv_class
878 parameter. Update all callers.
879 (var_is_num_missing): Ditto.
880 (var_is_str_missing): Ditto.
881 (var_is_value_user_missing): Removed. Changed callers to use
882 var_is_value_missing.
883 (var_is_num_user_missing): Removed. Changed callers to use
885 (var_is_str_user_missing): Removed. Changed callers to use
887 (var_is_value_system_missing): Removed. Changed callers to use
888 var_is_value_missing.
890 * casefilter.c (struct casefilter): Use enum mv_class in place of
892 (casefilter_variable_missing): Adapt to new member.
893 (casefilter_create): Change signature to take enum mv_class,
896 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
898 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
900 * case-sink.c case-sink.h procedure.c procedure.h
901 storage-stream.c: Now uses the factory.
903 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
905 Make it possible to pull cases from the active file with a
906 function call, instead of requiring indirection through a callback
909 * case-source.h (struct case_source_class): Change ->read function
910 to return a single case, instead of calling a callback function
911 for each case. Change ->destroy function to return an error
914 * case-source.c (free_case_source): Pass along the value returned
915 by the case_source ->destroy function.
917 * procedure.c (struct write_case_data): Removed.
918 (struct dataset): Added some members to track procedure state.
919 (procedure): Optimize the trivial case at this level.
920 (internal_procedure): Re-implement in terms of proc_open,
921 proc_read, proc_close.
922 (proc_open) New function.
923 (proc_read) New function.
924 (proc_close) New function.
925 (write_case) Moved into proc_read.
926 (close_active_file) Moved closing of data source into proc_close.
928 * storage-source.c: Rewrote to conform with modified
929 case_source_class interface.
931 * transformations.c (trns_chain_execute): Added argument to allow
932 starting execution from an arbitrary transformation. Updated
935 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
937 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
939 * sys-file-reader.c (read_display_parameters): Don't assume that
940 MEASURE_* and ALIGN_* have the same values found in system files.
942 * sys-file-writer.c (write_variable_display_parameters): Ditto.
944 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
945 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
946 the value of n_MEASURES, which was off by 1 (at least from my
949 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
951 * dictionary.c dictionary.h vardict.h variable.c: Added optional
952 callbacks which are invoked when the dictionary or its
953 variables are changed.
955 * missing-values.c missing-values.h value-labels.c: Tidied up
956 consistency checks, and made some of them return false
957 instead of assert-failing.
959 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
961 * calendar.c (calendar_days_in_month): New function.
963 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
965 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
966 the value label's width.
968 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
970 * sfm-private.h: Move contents into sys-file-writer.c, which is
971 the only remaining user. Removed Borland C++-specific directives.
973 * sys-file-reader.c: Clean up and rewrite entire file. The
974 rewritten version is simpler and better abstracted, and should be
975 easier to maintain and extend. It avoids using structures to read
976 file data, which is prone to padding variations among compilers.
977 It should also handle non-IEEE 754 system files, although I
978 haven't been able to find any. It has been tested against many
979 .sav files obtained from the Web and found to produce the same
980 results as the earlier version of the code, or in some cases
981 improved results. It is more tolerant of format variations found
984 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
985 member, putting an enum integer_format in its place. New member
986 `float_format'. Changed `compressed' member to type bool.
988 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
990 * dictionary.c (dict_delete_consecutive_vars): New function.
992 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
994 * file-name.c (fn_search_path): Remove prefix arg that was unused
995 by any caller. Updated all callers.
997 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
999 * format.c (fmt_dollar_template): Use user's decimal point
1000 character. Add assertion.
1002 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1004 * format.c (fmt_dollar_template): New function, based on
1005 dollar_format_template from var-type-dialog.c.
1007 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1009 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1012 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1014 Finish converting struct variable to an opaque type. In this
1015 phase, we add remaining setter and getter functions, convert the
1016 remaining PSPP code to use them, and do a bunch of cleanup. The
1017 resulting changes are pervasive but mostly trivial, and only the
1018 notable changes are logged.
1020 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1023 * case.c (case_data): Renamed case_data_idx.
1024 (case_num): Renamed case_num_idx.
1025 (case_str): Renamed case_str_idx.
1026 (case_data_rw): Renamed case_data_rw_idx.
1028 * case.h (case_data): New function with old name and an interface
1029 that takes a variable instead of an index, which is easier to
1030 use. Updated all callers to use the new interface, or to use the
1031 new *_idx function (see above).
1034 (case_data_rw): Ditto.
1036 * category.c (cat_stored_values_destroy): Changed interface to
1037 take a struct cat_vals * instead of a struct variable *.
1039 * dictionary.c (dict_clone): Use new vector_clone function.
1040 (dict_clear) Use new var_destroy function.
1041 (add_var) New function.
1042 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1043 (dict_create_var_assert) Rewrite in terms of add_var.
1044 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1045 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1046 (dict_lookup_var) Use new var_create, var_destroy functions.
1047 (dict_contains_var) Rewrite in terms of new vardict functionality.
1048 (set_var_dict_index) New function.
1049 (set_var_case_index) New function.
1050 (reindex_vars) New function.
1051 (dict_delete_var) Rewrite in terms of new vardict functionality.
1052 (dict_reorder_var) Ditto.
1053 (dict_reorder_vars) Ditto.
1054 (rename_var) New function.
1055 (dict_rename_var) Use rename_var.
1056 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1057 (dict_get_compacted_idx_to_fv) Rename
1058 dict_get_compacted_dict_index_to_case_index, update callers.
1059 (dict_create_vector) Use new vector_create function.
1060 (dict_clear_vectors) Use new vector_destroy function.
1061 (set_var_short_name_suffix) Move here from variable.c, renamed
1062 from var_set_short_name_suffix, make static, update caller.
1064 * sys-file-private.c: New file.
1065 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1066 width_to_bytes, update callers.
1068 * sys-file-private.h: New file. Later it will supplant
1069 sfm-private.h; for now it supplements it.
1070 (macro MIN_VERY_LONG_STRING) New macro.
1071 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1073 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1074 MAX_LONG_STRING was used before.
1076 * sys-file-writer.c: Ditto.
1078 * value-labels.c: Change the paradigm here to be that a null
1079 pointer is OK for a struct val_labs * in most cases; it just
1080 represents an empty set of value labels.
1081 (val_labs_copy) A copy of a null set is a null set.
1082 (val_labs_count) A null set has 0 labels.
1083 (val_labs_replace) Change return type to void. Rewrite for
1085 (val_labs_find) A null set does not contain the value.
1086 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1087 transposed argument order, updated all callers.
1089 * value.c: New file.
1090 (value_dup) Moved here from variable.c.
1091 (compare_values) Ditto.
1094 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1095 (macro MAX_LONG_STRING) Removed, because it was only interesting
1096 for system files, not for general code.
1097 (macro MAX_VERY_LONG_STRING) Ditto.
1098 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1099 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1101 * vardict.h: New file, for an interface between variables and
1104 * variable.c: A lot of functions were moved around, for better
1106 (struct variable) Move definition here, from variable.h.
1107 (var_type_adj) Removed--makes i18n hard.
1108 (var_type_noun) Ditto.
1109 (var_create) New function.
1110 (var_clone) New function.
1111 (var_destroy) New function.
1112 (var_set_name) Assert that variable is not in a dictionary.
1113 (compare_var_names) Rename compare_vars_by_name and fix a couple
1114 of callers who thought the args were strings.
1115 (hash_var_name) Rename hash_var_by_name.
1116 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1117 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1118 (var_is_very_long_string) Removed, because it was only interesting
1119 to system file code.
1120 (var_set_missing_values) Allow the argument to be the wrong width,
1121 as long as we can resize it. Simplify callers who were doing the
1122 resizing themselves.
1123 (var_get_value_labels) New function.
1124 (var_has_value_labels) New function.
1125 (var_set_value_labels) New function.
1126 (alloc_value_labels) New function.
1127 (var_add_value_label) New function.
1128 (var_replace_value_label) New function.
1129 (var_clear_value_labels) New function.
1130 (var_lookup_value_label) New function.
1131 (var_get_value_name) Moved here from variable.c, renamed from
1132 var_get_value_name, transposed argument order, updated all
1134 (var_to_string) Moved here, from variable-label.c.
1135 (var_set_leave) New function.
1136 (var_get_leave) New function.
1137 (var_must_leave) New function.
1138 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1139 set_var_short_name_suffix.
1140 (var_get_dict_index) New function.
1141 (var_get_case_index) New function.
1142 (var_get_obs_vals) New function.
1143 (var_set_obs_vals) New function.
1144 (var_has_obs_vals) New function.
1145 (var_get_vardict) New function.
1146 (var_set_vardict) New function.
1147 (var_has_vardict) New function.
1148 (var_clear_vardict) New function.
1149 (value_dup) Moved to value.c.
1150 (compare_values) Ditto.
1153 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1154 (enum ALPHA) Rename VAR_STRING, update all users.
1156 * vector.c: New file.
1157 (struct vector) Moved here, from variable.h.
1158 (check_widths) New function.
1159 (vector_create) New function.
1160 (vector_clone) New function.
1161 (vector_destroy) New function.
1162 (vector_get_name) New function.
1163 (vector_get_var) New function.
1164 (vector_get_var_cnt) New function.
1165 (compare_vector_ptrs_by_name) New function.
1167 * vector.h: New file.
1169 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1171 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1172 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1175 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1177 * value-labels.c (destroy_atoms): New function.
1178 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1180 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1182 Thanks to Jason Stover for pointing out this problem.
1184 * data-out.c (output_number): Use gsl_finite from GSL, which is
1185 portable, instead of isfinite, which is not.
1188 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1190 * variable.c variable.h (value_dup): New function.
1192 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1194 Start converting struct variable to an opaque type. In this
1195 phase, we add a bunch of setter and getter functions and convert
1196 most of the PSPP code to use them. The resulting changes are
1197 pervasive but mostly trivial, and only the notable changes are
1200 * format.c (fmt_equal): New function.
1202 * variable.c (var_type_is_valid): New function.
1203 (measure_is_valid) Moved here, from format.c.
1204 (alignment_is_valid) Moved here, from format.c.
1205 (var_get_name) New function.
1206 (var_set_name) New function.
1207 (width_to_type) New function.
1208 (var_get_type) New function.
1209 (var_get_width) New function.
1210 (var_set_width) New function.
1211 (var_is_numeric) New function.
1212 (var_is_alpha) New function.
1213 (var_is_short_string) New function.
1214 (var_is_long_string) New function.
1215 (var_is_very_long_string) New function.
1216 (var_get_missing_values) New function.
1217 (var_set_missing_values) New function.
1218 (var_clear_missing_values) New function.
1219 (var_has_missing_values) New function.
1220 (var_is_value_missing) New function.
1221 (var_is_num_missing) New function.
1222 (var_is_str_missing) New function.
1223 (var_is_value_user_missing) New function.
1224 (var_is_num_user_missing) New function.
1225 (var_is_str_user_missing) New function.
1226 (var_is_value_system_missing) New function.
1227 (var_get_print_format) New function.
1228 (var_set_print_format) New function.
1229 (var_get_write_format) New function.
1230 (var_set_write_format) New function.
1231 (var_set_both_formats) New function.
1232 (var_get_label) New function.
1233 (var_set_label) New function.
1234 (var_clear_label) New function.
1235 (var_has_label) New function.
1236 (var_get_measure) New function.
1237 (var_set_measure) New function.
1238 (var_get_display_width) New function.
1239 (var_set_display_width) New function.
1240 (var_get_alignment) New function.
1241 (var_set_alignment) New function.
1242 (var_get_value_cnt) New function.
1243 (var_get_leave) New function.
1244 (var_get_short_name) New function.
1246 * variable.h: (struct variable) Removed "type" and "nv" members;
1247 they are now computed from "width" where needed.
1249 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1251 * missing-values.c (mv_resize): Don't write beyond end of the
1252 allocated buffer when resizing a long string.
1254 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1256 Clean up identifier code: don't require identifier enumerations to
1257 be in a particular order; make better use of string library;
1258 expose less of the internals.
1260 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1261 change interface. Updated all callers.
1262 (lex_id_match) Change interface to use struct substring, update
1264 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1265 (global array keywords[]) Make static, change form. Update all
1266 users to use lex_id_name instead.
1267 (lex_is_keyword) New function.
1268 (lex_id_to_token) Change interface to use struct substring, update
1270 (lex_id_name) New function.
1272 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1273 lex_is_keyword instead.
1274 (T_LAST_KEYWORD) Removed.
1275 (T_N_KEYWORDS) Removed.
1277 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1279 * format.c: (fmt_date_template) Distinguish characters for which a
1280 space is output and any date delimiter is allowed on input, from
1281 those for which a space is output and only a space is allowed on
1282 input. The former is represented by X, the latter by a space.
1283 Also, drop distinction between h and H, changing the former to the
1286 * data-in.c: Completely rewrite internals to conform to SPSS input
1287 formats as closely as possible.
1288 (data_in) Changed external interface by replacing the structure
1289 that was used as a single argument by a set of arguments. Updated
1291 (data_in_finite_line) Removed. Converted all callers to use plain
1293 (data_in_get_integer_format) New function.
1294 (data_in_set_integer_format) New function.
1295 (data_in_get_float_format) New function.
1296 (data_in_set_float_format) New function.
1298 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1299 (struct data_in) Removed.
1301 * data-out.c: (output_date) Drop each component from the input as
1302 it is output, to allow us to drop the distinction between h (a
1303 count of hours) and H (the hour of day) template characters.
1304 Also, handle new X template character.
1305 (output_scientific) Follow more rational rule on when to drop
1306 fraction introduced between SPSS 13 and 15. Updated test case to
1309 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1311 Fix buffer overflow reported by John Darrington.
1313 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1314 realize that DIGITS is a count of nibbles, not of bytes.
1316 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1318 * calendar.c (calendar_offset_to_gregorian) Also return the
1319 year-of-day. Change callers to new interface.
1321 * data-out.c: Completely rewrite internals to conform to SPSS
1322 output formats as completely as possible.
1323 (data_out) Change interface to put input parameters before output
1324 parameters, for consistency with the style I now prefer. Update
1326 (data_out_get_integer_format) New public function.
1327 (data_out_set_integer_format) New public function.
1328 (data_out_get_float_format) New public function.
1329 (data_out_set_float_format) New public function.
1331 * data-out.h: New file. Move prototype for data_out here, from
1334 * format.c: (fmt_step_width) Use equality comparison instead of
1335 bitwise and, for clarity.
1336 (fmt_is_string) Ditto.
1337 (fmt_input_to_output) Fix categories that are translated to F
1340 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1342 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1343 casefile-private.h: Added casefilter to assist commands with missing
1346 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1348 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1350 * settings.c: (route_errors_to_terminal) New variable.
1351 (route_errors_to_listing) New variable.
1352 (get_error_routing_to_terminal) New function.
1353 (set_error_routing_to_terminal) New function.
1354 (get_error_routing_to_listing) New function.
1355 (set_error_routing_to_listing) New function.
1357 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1359 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1361 * format.c: Completely rewrite, to achieve better abstraction.
1362 Rewrite all references to formats in other files.
1364 * format.def: Rewrite and reorganize.
1366 * settings.c: Move everything related to custom currency formats
1367 into format.[ch], changing them in form, so as to group related
1368 code and definitions better. Changed all references to use the
1370 (static var decimal) Removed.
1371 (static var grouping) Removed.
1372 (static var cc) Removed.
1373 (get_decimal) Removed.
1374 (set_decimal) Removed.
1375 (get_grouping) Removed.
1376 (set_grouping) Removed.
1380 * settings.h: (macro CC_CNT) Removed.
1381 (macro CC_WIDTH) Removed.
1382 (struct custom_currency) Removed.
1384 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1386 * data-in.c (data_in): Use switch statement instead of table, to
1387 avoid dependence on the order of the FMT_* enums.
1389 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1391 * data-out.c: (num_to_string) Removed, because it was dead code.
1393 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1395 * data-in.c (parse_trailer): Fix error message.
1397 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1399 * format.c (fmt_is_binary): New function.
1401 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1403 * procedure.c procedure.h: Encapsulated the static data into a single
1406 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1408 * casefile.c (casereader_read_xfer): Always initialize the case,
1409 even on an error condition.
1411 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1413 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1414 entire function useless.
1416 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1418 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1419 casereader method casereader_clone.
1421 * procedure.c pransformations.h: Introduced new type casenum_t
1423 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1425 * variable.c: (width_to_bytes) Rephrase code for clarify.
1427 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1429 * format.c: (fmt_type_from_string) New function.
1430 (fmt_to_string) Include decimals in output if the format has
1431 decimals, even if the format type does not. This way, we can
1432 accurately reproduce incorrect formats in user output.
1433 (check_common_specifier) Make the check for a bad format type an
1434 assertion, so we get bug reports if they show up. Fix message.
1435 Check for decimal places with a format type that doesn't allow
1437 (check_input_specifier) Remove check for FMT_X, which has been
1439 (check_output_specifier) Ditto.
1441 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1443 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1444 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1445 (enum fmt_parse_flags) Removed.
1447 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1449 * casefile.c casefile.h: Converted to an abstract base class.
1450 * casefile-private.h fastfile.c fastfile.h: New files.
1451 * automake.mk procedure.c scratch-writer.c storage-stream.c
1453 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1455 * procedure.c (internal_procedure): Create sink_case with only as
1456 many values as the compacted dictionary.
1458 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1460 Remove "debugging" code that caused plenty of false positives and
1463 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1465 * case.c: Remove all references to `this' member.
1467 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1469 Fix link error noted by Jason Stover.
1471 * storage-stream.c: Include <assert.h>.
1473 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1475 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1476 ALL) and additional underlying system file issues.
1478 Thanks to John Darrington for review.
1480 First problem: var_hash points to variables not owned by the
1481 sys-file-reader, which the caller may free or modify. Use an
1482 array of sfm_vars instead, as done earlier (e.g. CVS version
1485 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1486 members and remove all code that references it. Add vars, var_cnt
1487 members. Remove fix_specials member, which was unused.
1488 (struct sfm_var) Remove name member, which was unused.
1489 (sfm_close_reader) Free vars member instead of var_hash.
1490 (compare_var_shortnames) Removed.
1491 (hash_var_shortname) Removed.
1492 (sfm_open_reader) Fill out vars array.
1493 (compare_var_index) Removed.
1494 (sfm_read_case) Use vars instead of var_hash.
1496 Second problem: we're confused about when we actually have very
1497 long strings, causing us to choose incorrectly between slow path
1498 and fast path in sfm_read_case.
1500 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1501 have very long strings, not when we have long variable names,
1502 which is an unrelated feature.
1504 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1506 * variable.h: Move var_set and variable parsing declarations to
1507 new header, src/language/lexer/variable-parser.h. Modified lots
1508 of files to include the new header.
1510 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1512 * value-labels.c (value_to_string): When there's no value label,
1513 format the variable according to its print format, instead of
1514 always effectively using A or F format.
1516 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1518 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1521 * format.c: Removed tortological assertion.
1523 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1525 Reform string library.
1527 * file-name.c (fn_interp_vars): Change interface to take a
1528 substring as input. Updated all users.
1530 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1532 * format.c (measure_is_valid): Really return false when m >=
1535 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1537 Implement random access to casefiles, for use in GUI.
1539 * casefile.c: (struct casereader) Add `random', `file_ofs',
1540 `buffer_ofs' members.
1541 (casefile_get_random_reader) New function.
1542 (read_open_file) Break part into new function
1543 seek_and_fill_buffer().
1544 (fill_buffer) Update buffer_ofs, file_ofs.
1545 (casereader_seek) New function.
1547 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1549 * settings.c: Added call to i18n{done, init}.
1551 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1553 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1556 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1558 * casefile.c: Convert many uses of `int' to `bool'.
1560 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1562 * transformations.c (trns_chain_destroy): Destroy chain's trns
1563 member, to fix memory leak.
1565 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1567 * storage-stream.c (storage_source_decapsulate): Destroy case
1568 source to fix memory leak.
1570 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1572 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1573 case passed as argument instead of initializing the argument as a
1574 case. Fixes memory leak that showed up in
1575 tests/command/aggregate.sh with scratch files.
1577 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1579 * procedure.c (proc_done): Destroy default_dict, to fix memory
1582 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1584 Simplify procedure_with_splits().
1586 * procedure.c (struct split_aux_data): Removed case_count member.
1587 (procedure_with_splits) Don't initialize case_count.
1588 (split_procedure_case_func) Check whether prev_case is null
1589 instead of case_count.
1590 (split_procedure_end_func) Ditto.
1592 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1594 * case.c (case_move): Do nothing if dst and src are the same
1596 (case_try_create) Merge two similar cases.
1597 (case_copy) Unshare only if data must be actually copied.
1599 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1601 * data-in.c data-out.c dictionary.c sys-file-reader.c
1602 sys-file-writer.c variable.c variable.h: Reworked very long string
1603 support for better encapsulation.
1605 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1607 * value-labels.c (val_labs_can_set_width): New function.
1608 (val_labs_set_width) Clear labels if increasing width to long
1610 (val_labs_destroy) Remove unneeded test for null.
1612 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1614 * value-labels.h: Remove unneeded dependency on variable.h.
1616 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1618 Get rid of `char *c' member in union value, for cleanliness.
1620 * value.h: (union value) Remove `c' member.
1622 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1624 Make dictionary compacting functions a little more general.
1626 * sys-file-writer.c (sfm_open_writer): Use
1627 dict_compacting_would_change().
1628 (does_dict_need_translation) Removed.
1630 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1632 Make dictionary compacting functions a little more general.
1634 * dictionary.c (dict_needs_compaction): Rename
1635 dict_compacting_would_shrink(). Update all callers.
1636 (dict_compacting_would_change) New function.
1638 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1640 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1641 inverted return value (!).
1643 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1645 Continue reforming procedure execution.
1647 * procedure.c: Search and replace "vfm" by "proc". Notably:
1648 (static var vfm_source) Rename proc_source. Update all
1650 (static var vfm_sink) Rename proc_sink. Update all references.
1652 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1654 Continue reforming procedure execution. In this phase, remove
1655 PROCESS IF, which was deprecated anyway and can be easily
1656 simulated with TEMPORARY followed by SELECT IF.
1658 * procedure.c: (open_active_file) Don't call
1659 add_process_if_trns().
1660 (discard_variables) Get rid of redundant call to
1661 proc_cancel_all_transformations().
1662 (add_process_if_trns) Removed.
1663 (process_if_trns_proc) Removed.
1664 (process_if_trns_free) Removed.
1666 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1668 Continue reforming procedure execution. In this phase, add
1669 `const' to the case passed to procedure()'s callback.
1671 Updated all users of procedure() as well.
1673 * procedure.c: (struct write_case_data) Add "const" to ccase
1674 parameter for case_func member.
1675 (procedure) Add "const" to ccase parameter for proc_func
1677 (multipass_case_func) Make ccase parameter const.
1678 (internal_procedure) Add "const" to ccase parameter for case_func
1680 (split_procedure_case_func) Make ccase parameter const.
1681 (multipass_split_case_func) Make ccase parameter const.
1683 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1685 Continue reforming procedure execution. In this phase, get rid of
1686 the output code for SPLIT FILE groups in procedure.c, which really
1687 shouldn't be doing any output. Move it into the individual
1688 procedures instead. This also adds some flexibility.
1690 Updated many users of procedure_with_splits() and
1691 multipass_procedure_with_splits() to call
1692 output_split_file_values() and to deal with increased use of
1695 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1696 parameter to begin_func member.
1697 (procedure_with_splits) Add "const struct ccase *" parameter to
1698 begin_func parameter. Make ccase parameter const in proc_func
1700 (split_procedure_case_func) Don't dump split file group. Pass
1702 (dump_splits) Moved to language/dictionary/split-file.c as
1703 output_split_file_values().
1704 (struct multipass_split_aux_data) Add "const struct ccase *"
1705 parameter to split_func member.
1706 (multipass_procedure_with_splits) Add "const struct ccase *"
1707 parameter to split_func parameter.
1708 (multipass_split_case_func) Save new SPLIT FILE case before
1710 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1712 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1714 Continue reforming procedure execution. Change
1715 internal_procedure() so that it calls open_active_file() and
1716 close_active_file(), which isolates most of the actual procedure
1719 * procedure.c: (struct write_case_data) Rename `proc_func' member
1720 to `case_func' and update all references.
1721 (procedure) Rewrite as one-line wrapper around
1722 internal_procedure().
1723 (struct multipass_aux_data) New.
1724 (multipass_callback) Renamed multipass_case_func(). Use struct
1725 multipass_aux_data as auxiliary data.
1726 (multipass_end_func) New function.
1727 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1728 that uses multipass_case_func, multipass_end_func.
1729 (internal_procedure) Add `end_func' argument. Move optimization
1730 of trivial case in here. Move call to open_active_file() and
1731 close_active_file() in here. Now assert that vfm_source is
1733 (procedure_with_splits_callback) Rename
1734 split_procedure_case_func().
1735 (split_procedure_end_func) New function.
1736 (multipass_split_callback) Rename multipass_split_case_func.
1737 (multipass_split_end_func) New function.
1738 (discard_variables) No need to test for nonnull vfm_source.
1740 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1742 Continue reforming procedure execution. Get rid of unused member.
1744 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1746 (write_case) Don't increment cases_analyzed.
1748 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1750 Continue reforming procedure execution. In this phase, move
1751 procedure.c and procedure.h from src to src/data. Update
1752 makefiles and #includes accordingly.
1754 * procedure.c: Moved here from src/.
1756 * procedure.h: Moved here from src/.
1758 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1760 Continue reforming procedure execution. In this phase, get rid of
1761 many global variables, consolidating procedure execution in
1762 procedure.c. Encapsulate transformations in new "struct
1763 trns_chain". Also, change implementation of N OF CASES, FILTER,
1764 and PROCESS IF from special cases to transformations.
1766 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1769 * dictionary.c: (global variable default_dict) Move to
1772 * variable.h: (TRNS_*) Move to transformations.h.
1773 (struct transformation) Move to transformations.c.
1775 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1777 * sys-file-reader.c: Fixed invalid read problems.
1779 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1781 * storage-stream.c: Add missing function comments.
1783 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1785 Continue reforming procedure execution. In this phase, add some
1786 new, needed functionality to storage-stream.
1788 * storage-stream.c: (storage_source_decapsulate) New function.
1790 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1792 * variable.c (width_to_bytes): Declarations must precede
1793 statements for C90 compliance.
1795 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1797 * data-out.c, data-in.c, variable.c, variable.h: New functions
1798 copy_mangle and copy_demangle for reading/writing cases; emulates the
1799 way SPSS deals with strings > 255 bytes.
1801 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1802 subtype 14 needed for strings longer than 255 bytes.
1804 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1805 instead of literal values. Also fixed some constness issues.
1807 * format.h: Constness
1809 * sfm-private.h: Renamed the case_size identifier, since I discovered
1810 that SPSS's respect for this variable is very nominal.
1812 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1814 Change case limit type from int to size_t.
1816 * dictionary.c: (struct dictionary) Change type of case_limit
1818 (dict_get_case_limit) Change return type.
1819 (dict_set_case_limit) Change parameter type.
1821 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1823 * variable.h: (struct variable) Rename `reinit' member as `leave'
1824 and invert sense. Fix up all references.
1826 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1828 Continue reforming procedure execution. In this phase, break
1829 procedure.c into multiple files.
1831 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1833 * case-sink.c: New file.
1835 * case-sink.h: New file.
1837 * case-source.c: New file.
1839 * case-source.h: New file.
1841 * storage-stream.c: New file.
1843 * storage-stream.h: New file.
1845 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1847 * variable.h: (struct variable) Remove `init' member and all
1848 references to it from other files. It was initialized in several
1849 places, but nothing really ever used it for anything worthwhile.
1850 Thanks to Jason Stover for pointing out how confusing this
1853 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1855 Continue reforming error message support. In this phase, get rid
1856 of message "titles" and put the message text in `struct error'.
1857 Now `struct error' encapsulates a message more properly.
1859 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1860 Format message ourselves.
1862 * data-in.c: (vdls_error) Ditto.
1864 * por-file-reader.c: (error) Ditto.
1866 * sys-file-reader.c: (corrupt_msg) Ditto.
1868 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1870 GNU standards require "file name" instead of "filename" in
1871 documentation. It's nice for our code to follow the convention
1874 * casefile.c: (struct casefile) Rename `filename' member to
1875 `file_name'. Updated all references.
1877 * file-name.c: [!unix] (struct file_identity) Rename
1878 normalized_filename member to normalized_file_name. Updated all
1881 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1883 We don't really support anything but Unix-like environments well,
1884 so we might as well de-obfuscate by writing directory and path
1885 separators explicitly.
1887 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1889 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1890 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1892 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1895 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1897 GNU standards require "file name" instead of "filename" in
1898 documentation. It's nice for our code to follow the convention
1901 * filename.c: Rename to file-name.c.
1903 * filename.h: Rename to file-name.h. Update all inclusions.
1904 Update header guards.
1906 * automake.mk: Update file names.
1908 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1910 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1912 (fn_basename) Removed (dead code).
1913 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1914 (fn_special_p) Renamed fn_is_special(), all references updated.
1915 (fn_exists_p) Renamed fn_exists(), all references updated.
1917 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1919 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1920 Also, now it only tilde-expands file names, not paths.
1921 (fn_search_path) Tilde-expand one directory at a time.
1923 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1925 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1926 get rid of non-Unixlike version of the code, which has probably
1928 (fn_prepend_dir) Removed (dead code).
1930 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1931 (macro PATH_SEPARATOR_STRING) New.
1932 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1934 Continue reforming error message support. In this phase, we get
1935 rid of VM() and the other msg() support for "verbosity", replacing
1936 it by a new function verbose_msg().
1938 * filename.c: (fn_search_path) Use verbose_msg() instead of
1941 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1943 * sfm-private.h: Get rid of #defines after #error, which makes no
1946 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1948 Get rid of our own int32 type in favor of the standard int32_t
1951 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1954 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1956 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1958 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1960 Remove ill-considered file routines that are no longer used.
1962 * filename.c: (fn_open_ext) Removed.
1963 (fn_close_ext) Removed.
1965 * filename.h: (struct file_ext) Removed.
1967 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1969 * variable.c (var_is_valid_name): Move declarations before code
1972 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1974 * filename.ch (fn_interp_vars): Fixed small buglet.
1976 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1978 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1979 so as to modify the string inline. Thus makeing it easier to
1980 destroy the results when no longer needed.
1982 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1984 * category.c (cat_stored_values_destroy): Fixed memory leak.
1986 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1988 Add some missing frees. Thanks to John Darrington for reporting
1991 * any-writer.c (any_writer_close): Free writer.
1993 * any-reader.c (any_reader_close): Free reader.
1995 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1997 * por-file-reader.c: (error) Mark as NO_RETURN.
1999 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2001 * settings.c: Changed default value of scompress to true.
2003 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2005 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2007 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2010 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2011 here from pref.h.orig.
2013 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2015 * sys-file-reader.c: Fixed bug reading compressed files.
2017 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2019 * Numerous renames. See src/ChangeLog for details.
2021 * Moved files from src directory