1 2007-04-22 John Darrington <john@darrington.wattle.id.au>
3 * Deleted existing category.h and moved cat-routines.h into
4 category.h Encapsulated struct cat_vals better.
6 2007-04-19 John Darrington <john@darrington.wattle.id.au>
8 * sys-file-reader.c: When reading a system file which has no
9 long name table, automatically create one where the long names
10 are the lower case versions of the short names.
12 2007-04-16 John Darrington <john@darrington.wattle.id.au>
14 * sys-file-reader.c: Some versions of Other Software seem to
15 produce system files with string variables' measure set to
16 zero. We'll assume these are supposed to be nominal variables.
18 2007-03-30 Ben Pfaff <blp@gnu.org>
20 * procedure.c: Adapt to new deque data structure.
22 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
23 Ben Pfaff <blp@gnu.org>
25 * file-name.c: Mingw compatibility fixes.
26 (fn_search_path): Use ISSLASH instead of comparing against '/'
28 (fn_dir_name): Use dir_name from gnulib.
29 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
30 (fn_get_identity): Use GetFullPathName instead of canonicalize
31 from gnulib, because the latter does not fully support
32 Windows-style path names. Use this implementation based on the
33 detected presence of Windows instead of the absence of Unix, since
34 the new implementation is Windows-specific.
35 (fn_compare_file_identities): In Windows implementation, compare
36 names case-insensitively.
38 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
40 * make-file.c: Don't include mkstemp.h, because gnulib now causes
41 <stdlib.h> to have the same effect.
43 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
45 * por-file-reader.c: Add missing _() around messages.
47 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
49 * make-file.c: Include "mkstemp.h", without which linking on
52 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
54 Reduce platform dependence.
56 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
57 Everywhere we using this, we really should have just depended on
58 the shell to expand tildes.
59 (fn_search_path): Simplify, given that we don't do tilde expansion
61 (fn_normalize): Removed. Caller changed to use the canonicalize
63 (fn_get_cwd): Removed. Only user was fn_normalize.
64 (fn_is_absolute): Really only test for absolute names.
65 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
67 (fn_readlink): Removed, as it was only used fn_normalize.
68 (fn_exists): Assume the stat function is available; gnulib does.
69 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
71 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
73 * dictionary.c (dict_create_vector_assert): New function.
75 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
77 * file-name.c (fn_normalize): Correct name of function
78 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
79 for pointing this out.
81 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
83 We are using a single member in struct file_handle, the "name"
84 field, for more than one purpose. When it begins with '"', it's a
85 file name; otherwise, it's a token that can be used to identify
86 it. When that assertion fires, it's because we searched for the
87 name case-sensitively as a file name (so that there was no match),
88 and then we try to insert it case-insensitively as a token, which
89 fails because duplicates aren't allowed.
91 Solution: break the two purposes into two separate fields. This
92 fixes the problem and likely makes the code easier to read too.
94 Fixes bug #18922. Thanks to John Darrington for bug report and
97 * file-handle-def.c (struct file_handle): New `id' member.
98 (fh_from_name): Rename fh_from_id. Update all callers.
99 (create_handle): New `id' parameter. Update all callers.
100 (fh_create_file): Ditto.
101 (fh_get_id): New function.
103 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
105 * case.c (case_is_null): Change return type to bool.
107 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
111 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
112 reference counting to share data. This makes it easy for
113 valgrind, etc. to find accesses to cases that have been destroyed
114 but have been kept around by another user's ref-count. This often
115 happens when the data set is small enough to find in memory; if a
116 bigger data set that would overflow to disk were used, then data
117 corruption would occur.
119 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
123 * case.c (case_unshare): Make it check internally whether the
124 ref_cnt is greater than 1, so that the callers don't have to.
125 Update callers not to check.
127 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
129 Before, I was thinking that I might want to get rid of reference
130 counting at some point. Now, I'm pretty sure that it's here to
131 stay. Thus, because we have to store the value_cnt anyway for
132 reference-counted cases, we might as well expose it to users.
134 * case.c (case_get_value_cnt): New function.
135 (case_resize): Drop OLD_CNT argument. Update all callers. Only
136 resize case if its size actually changed.
138 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
139 instead of peeking inside struct case directly.
140 (casefile_append): Ditto.
142 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
144 Get rid of the inlines for the case functions, which made the
145 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
146 the inlines didn't speed up "make check" at all, which is not a
147 perfect benchmark but seems indicative.)
149 * case.c: Remove #ifdef DEBUGGING...#endif around many function
150 definitions. Remove some assertions on nonnull pointers that were
151 redundant with a pointer dereference soon after in the function.
153 (struct case_data): Move definition here from case.h.
157 (case_data_wr): Ditto.
159 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
161 * automake.mk: Add casedeque.h to sources.
163 * casedeque.h: New file.
165 * procedure.c: (struct dataset) Change lag_count, lag_head,
166 lag_queue member into single struct casedeque member. Update all
167 users to use the casedeque instead.
170 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
172 * procedure.c: Simplify lagged cases interface. Updated all
173 clients--well, the only client--to use the simplified interface.
174 (dataset_n_lag) Removed.
175 (dataset_set_n_lag) Removed.
176 (dataset_need_lag) New function.
178 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
180 * dictionary.c procedure.c: More changes to ensure that callbacks occur
181 whenever appropriate, but only when the dataset/dictionary is in a
184 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
186 * dictionary.c dictionary.h : Added callbacks for change of filter and
187 split variables. Refactored some code to ensure that callbacks get
188 invoked when appropriate.
190 * procedure.c (proc_cancel_temporary_transformations): Make sure that
191 replace_dict callback occurs when permanent_dict replaces the current
194 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
196 * dictionary.c dictionary.h : Added callback for when the weight
197 variable of a dictionary changes.
199 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
201 * dictionary.c dictionary.h : Added replace_source and replace_dict
202 callbacks, and functions to deal with them.
204 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
206 Simplify missing value handling.
208 * missing-values.h (enum mv_class): New type.
209 (enum mv_type): Moved definition into missing-values.c and renamed
210 each MV_* to MVT_*, to distinguish them from the exposed mv_class
211 enums. Updated all uses.
212 (struct missing_values): Changed type of `type' from `enum
213 mv_type' to `int' because the definition is no longer exposed.
215 * missing-values.c (mv_is_value_missing): Add new enum mv_class
216 parameter. Update all callers.
217 (mv_is_num_missing): Ditto.
218 (mv_is_str_missing): Ditto.
219 (mv_is_value_user_missing): Removed. Changed callers to use
221 (mv_is_num_user_missing): Removed. Changed callers to use
223 (mv_is_str_user_missing): Removed. Changed callers to use
225 (mv_is_value_system_missing): Removed. Changed callers to use
227 (mv_set_type): Removed. Changed callers to use mv_clear.
228 (mv_clear): New function.
230 * variable.c (var_is_value_missing): Add new enum mv_class
231 parameter. Update all callers.
232 (var_is_num_missing): Ditto.
233 (var_is_str_missing): Ditto.
234 (var_is_value_user_missing): Removed. Changed callers to use
235 var_is_value_missing.
236 (var_is_num_user_missing): Removed. Changed callers to use
238 (var_is_str_user_missing): Removed. Changed callers to use
240 (var_is_value_system_missing): Removed. Changed callers to use
241 var_is_value_missing.
243 * casefilter.c (struct casefilter): Use enum mv_class in place of
245 (casefilter_variable_missing): Adapt to new member.
246 (casefilter_create): Change signature to take enum mv_class,
249 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
251 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
253 * case-sink.c case-sink.h procedure.c procedure.h
254 storage-stream.c: Now uses the factory.
256 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
258 Make it possible to pull cases from the active file with a
259 function call, instead of requiring indirection through a callback
262 * case-source.h (struct case_source_class): Change ->read function
263 to return a single case, instead of calling a callback function
264 for each case. Change ->destroy function to return an error
267 * case-source.c (free_case_source): Pass along the value returned
268 by the case_source ->destroy function.
270 * procedure.c (struct write_case_data): Removed.
271 (struct dataset): Added some members to track procedure state.
272 (procedure): Optimize the trivial case at this level.
273 (internal_procedure): Re-implement in terms of proc_open,
274 proc_read, proc_close.
275 (proc_open) New function.
276 (proc_read) New function.
277 (proc_close) New function.
278 (write_case) Moved into proc_read.
279 (close_active_file) Moved closing of data source into proc_close.
281 * storage-source.c: Rewrote to conform with modified
282 case_source_class interface.
284 * transformations.c (trns_chain_execute): Added argument to allow
285 starting execution from an arbitrary transformation. Updated
288 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
290 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
292 * sys-file-reader.c (read_display_parameters): Don't assume that
293 MEASURE_* and ALIGN_* have the same values found in system files.
295 * sys-file-writer.c (write_variable_display_parameters): Ditto.
297 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
298 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
299 the value of n_MEASURES, which was off by 1 (at least from my
302 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
304 * dictionary.c dictionary.h vardict.h variable.c: Added optional
305 callbacks which are invoked when the dictionary or its
306 variables are changed.
308 * missing-values.c missing-values.h value-labels.c: Tidied up
309 consistency checks, and made some of them return false
310 instead of assert-failing.
312 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
314 * calendar.c (calendar_days_in_month): New function.
316 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
318 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
319 the value label's width.
321 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
323 * sfm-private.h: Move contents into sys-file-writer.c, which is
324 the only remaining user. Removed Borland C++-specific directives.
326 * sys-file-reader.c: Clean up and rewrite entire file. The
327 rewritten version is simpler and better abstracted, and should be
328 easier to maintain and extend. It avoids using structures to read
329 file data, which is prone to padding variations among compilers.
330 It should also handle non-IEEE 754 system files, although I
331 haven't been able to find any. It has been tested against many
332 .sav files obtained from the Web and found to produce the same
333 results as the earlier version of the code, or in some cases
334 improved results. It is more tolerant of format variations found
337 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
338 member, putting an enum integer_format in its place. New member
339 `float_format'. Changed `compressed' member to type bool.
341 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
343 * dictionary.c (dict_delete_consecutive_vars): New function.
345 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
347 * file-name.c (fn_search_path): Remove prefix arg that was unused
348 by any caller. Updated all callers.
350 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
352 * format.c (fmt_dollar_template): Use user's decimal point
353 character. Add assertion.
355 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
357 * format.c (fmt_dollar_template): New function, based on
358 dollar_format_template from var-type-dialog.c.
360 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
362 * data-out.c (output_scientific): Fix bad assumption that "buf" is
365 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
367 Finish converting struct variable to an opaque type. In this
368 phase, we add remaining setter and getter functions, convert the
369 remaining PSPP code to use them, and do a bunch of cleanup. The
370 resulting changes are pervasive but mostly trivial, and only the
371 notable changes are logged.
373 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
376 * case.c (case_data): Renamed case_data_idx.
377 (case_num): Renamed case_num_idx.
378 (case_str): Renamed case_str_idx.
379 (case_data_rw): Renamed case_data_rw_idx.
381 * case.h (case_data): New function with old name and an interface
382 that takes a variable instead of an index, which is easier to
383 use. Updated all callers to use the new interface, or to use the
384 new *_idx function (see above).
387 (case_data_rw): Ditto.
389 * category.c (cat_stored_values_destroy): Changed interface to
390 take a struct cat_vals * instead of a struct variable *.
392 * dictionary.c (dict_clone): Use new vector_clone function.
393 (dict_clear) Use new var_destroy function.
394 (add_var) New function.
395 (dict_create_var) Rewrite in terms of dict_create_var_assert.
396 (dict_create_var_assert) Rewrite in terms of add_var.
397 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
398 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
399 (dict_lookup_var) Use new var_create, var_destroy functions.
400 (dict_contains_var) Rewrite in terms of new vardict functionality.
401 (set_var_dict_index) New function.
402 (set_var_case_index) New function.
403 (reindex_vars) New function.
404 (dict_delete_var) Rewrite in terms of new vardict functionality.
405 (dict_reorder_var) Ditto.
406 (dict_reorder_vars) Ditto.
407 (rename_var) New function.
408 (dict_rename_var) Use rename_var.
409 (dict_rename_vars) Use pool to simplify code. Use rename_var.
410 (dict_get_compacted_idx_to_fv) Rename
411 dict_get_compacted_dict_index_to_case_index, update callers.
412 (dict_create_vector) Use new vector_create function.
413 (dict_clear_vectors) Use new vector_destroy function.
414 (set_var_short_name_suffix) Move here from variable.c, renamed
415 from var_set_short_name_suffix, make static, update caller.
417 * sys-file-private.c: New file.
418 (sfm_width_to_bytes) Moved here from variable.c, renamed from
419 width_to_bytes, update callers.
421 * sys-file-private.h: New file. Later it will supplant
422 sfm-private.h; for now it supplements it.
423 (macro MIN_VERY_LONG_STRING) New macro.
424 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
426 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
427 MAX_LONG_STRING was used before.
429 * sys-file-writer.c: Ditto.
431 * value-labels.c: Change the paradigm here to be that a null
432 pointer is OK for a struct val_labs * in most cases; it just
433 represents an empty set of value labels.
434 (val_labs_copy) A copy of a null set is a null set.
435 (val_labs_count) A null set has 0 labels.
436 (val_labs_replace) Change return type to void. Rewrite for
438 (val_labs_find) A null set does not contain the value.
439 (value_to_string) Moved to variable.c, renamed var_get_value_name,
440 transposed argument order, updated all callers.
443 (value_dup) Moved here from variable.c.
444 (compare_values) Ditto.
447 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
448 (macro MAX_LONG_STRING) Removed, because it was only interesting
449 for system files, not for general code.
450 (macro MAX_VERY_LONG_STRING) Ditto.
451 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
452 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
454 * vardict.h: New file, for an interface between variables and
457 * variable.c: A lot of functions were moved around, for better
459 (struct variable) Move definition here, from variable.h.
460 (var_type_adj) Removed--makes i18n hard.
461 (var_type_noun) Ditto.
462 (var_create) New function.
463 (var_clone) New function.
464 (var_destroy) New function.
465 (var_set_name) Assert that variable is not in a dictionary.
466 (compare_var_names) Rename compare_vars_by_name and fix a couple
467 of callers who thought the args were strings.
468 (hash_var_name) Rename hash_var_by_name.
469 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
470 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
471 (var_is_very_long_string) Removed, because it was only interesting
473 (var_set_missing_values) Allow the argument to be the wrong width,
474 as long as we can resize it. Simplify callers who were doing the
476 (var_get_value_labels) New function.
477 (var_has_value_labels) New function.
478 (var_set_value_labels) New function.
479 (alloc_value_labels) New function.
480 (var_add_value_label) New function.
481 (var_replace_value_label) New function.
482 (var_clear_value_labels) New function.
483 (var_lookup_value_label) New function.
484 (var_get_value_name) Moved here from variable.c, renamed from
485 var_get_value_name, transposed argument order, updated all
487 (var_to_string) Moved here, from variable-label.c.
488 (var_set_leave) New function.
489 (var_get_leave) New function.
490 (var_must_leave) New function.
491 (var_set_short_name_suffix) Moved to dictionary.c, renamed
492 set_var_short_name_suffix.
493 (var_get_dict_index) New function.
494 (var_get_case_index) New function.
495 (var_get_obs_vals) New function.
496 (var_set_obs_vals) New function.
497 (var_has_obs_vals) New function.
498 (var_get_vardict) New function.
499 (var_set_vardict) New function.
500 (var_has_vardict) New function.
501 (var_clear_vardict) New function.
502 (value_dup) Moved to value.c.
503 (compare_values) Ditto.
506 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
507 (enum ALPHA) Rename VAR_STRING, update all users.
509 * vector.c: New file.
510 (struct vector) Moved here, from variable.h.
511 (check_widths) New function.
512 (vector_create) New function.
513 (vector_clone) New function.
514 (vector_destroy) New function.
515 (vector_get_name) New function.
516 (vector_get_var) New function.
517 (vector_get_var_cnt) New function.
518 (compare_vector_ptrs_by_name) New function.
520 * vector.h: New file.
522 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
524 * casefilter.c (casefilter_variable_missing): Avoided comparision of
525 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
528 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
530 * value-labels.c (destroy_atoms): New function.
531 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
533 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
535 Thanks to Jason Stover for pointing out this problem.
537 * data-out.c (output_number): Use gsl_finite from GSL, which is
538 portable, instead of isfinite, which is not.
541 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
543 * variable.c variable.h (value_dup): New function.
545 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
547 Start converting struct variable to an opaque type. In this
548 phase, we add a bunch of setter and getter functions and convert
549 most of the PSPP code to use them. The resulting changes are
550 pervasive but mostly trivial, and only the notable changes are
553 * format.c (fmt_equal): New function.
555 * variable.c (var_type_is_valid): New function.
556 (measure_is_valid) Moved here, from format.c.
557 (alignment_is_valid) Moved here, from format.c.
558 (var_get_name) New function.
559 (var_set_name) New function.
560 (width_to_type) New function.
561 (var_get_type) New function.
562 (var_get_width) New function.
563 (var_set_width) New function.
564 (var_is_numeric) New function.
565 (var_is_alpha) New function.
566 (var_is_short_string) New function.
567 (var_is_long_string) New function.
568 (var_is_very_long_string) New function.
569 (var_get_missing_values) New function.
570 (var_set_missing_values) New function.
571 (var_clear_missing_values) New function.
572 (var_has_missing_values) New function.
573 (var_is_value_missing) New function.
574 (var_is_num_missing) New function.
575 (var_is_str_missing) New function.
576 (var_is_value_user_missing) New function.
577 (var_is_num_user_missing) New function.
578 (var_is_str_user_missing) New function.
579 (var_is_value_system_missing) New function.
580 (var_get_print_format) New function.
581 (var_set_print_format) New function.
582 (var_get_write_format) New function.
583 (var_set_write_format) New function.
584 (var_set_both_formats) New function.
585 (var_get_label) New function.
586 (var_set_label) New function.
587 (var_clear_label) New function.
588 (var_has_label) New function.
589 (var_get_measure) New function.
590 (var_set_measure) New function.
591 (var_get_display_width) New function.
592 (var_set_display_width) New function.
593 (var_get_alignment) New function.
594 (var_set_alignment) New function.
595 (var_get_value_cnt) New function.
596 (var_get_leave) New function.
597 (var_get_short_name) New function.
599 * variable.h: (struct variable) Removed "type" and "nv" members;
600 they are now computed from "width" where needed.
602 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
604 * missing-values.c (mv_resize): Don't write beyond end of the
605 allocated buffer when resizing a long string.
607 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
609 Clean up identifier code: don't require identifier enumerations to
610 be in a particular order; make better use of string library;
611 expose less of the internals.
613 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
614 change interface. Updated all callers.
615 (lex_id_match) Change interface to use struct substring, update
617 (lex_id_match_len) Removed. Update callers to use lex_id_match.
618 (global array keywords[]) Make static, change form. Update all
619 users to use lex_id_name instead.
620 (lex_is_keyword) New function.
621 (lex_id_to_token) Change interface to use struct substring, update
623 (lex_id_name) New function.
625 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
626 lex_is_keyword instead.
627 (T_LAST_KEYWORD) Removed.
628 (T_N_KEYWORDS) Removed.
630 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
632 * format.c: (fmt_date_template) Distinguish characters for which a
633 space is output and any date delimiter is allowed on input, from
634 those for which a space is output and only a space is allowed on
635 input. The former is represented by X, the latter by a space.
636 Also, drop distinction between h and H, changing the former to the
639 * data-in.c: Completely rewrite internals to conform to SPSS input
640 formats as closely as possible.
641 (data_in) Changed external interface by replacing the structure
642 that was used as a single argument by a set of arguments. Updated
644 (data_in_finite_line) Removed. Converted all callers to use plain
646 (data_in_get_integer_format) New function.
647 (data_in_set_integer_format) New function.
648 (data_in_get_float_format) New function.
649 (data_in_set_float_format) New function.
651 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
652 (struct data_in) Removed.
654 * data-out.c: (output_date) Drop each component from the input as
655 it is output, to allow us to drop the distinction between h (a
656 count of hours) and H (the hour of day) template characters.
657 Also, handle new X template character.
658 (output_scientific) Follow more rational rule on when to drop
659 fraction introduced between SPSS 13 and 15. Updated test case to
662 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
664 Fix buffer overflow reported by John Darrington.
666 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
667 realize that DIGITS is a count of nibbles, not of bytes.
669 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
671 * calendar.c (calendar_offset_to_gregorian) Also return the
672 year-of-day. Change callers to new interface.
674 * data-out.c: Completely rewrite internals to conform to SPSS
675 output formats as completely as possible.
676 (data_out) Change interface to put input parameters before output
677 parameters, for consistency with the style I now prefer. Update
679 (data_out_get_integer_format) New public function.
680 (data_out_set_integer_format) New public function.
681 (data_out_get_float_format) New public function.
682 (data_out_set_float_format) New public function.
684 * data-out.h: New file. Move prototype for data_out here, from
687 * format.c: (fmt_step_width) Use equality comparison instead of
688 bitwise and, for clarity.
689 (fmt_is_string) Ditto.
690 (fmt_input_to_output) Fix categories that are translated to F
693 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
695 * casefilter.c casefilter.h (new files), casefile.c casefile.h
696 casefile-private.h: Added casefilter to assist commands with missing
699 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
701 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
703 * settings.c: (route_errors_to_terminal) New variable.
704 (route_errors_to_listing) New variable.
705 (get_error_routing_to_terminal) New function.
706 (set_error_routing_to_terminal) New function.
707 (get_error_routing_to_listing) New function.
708 (set_error_routing_to_listing) New function.
710 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
712 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
714 * format.c: Completely rewrite, to achieve better abstraction.
715 Rewrite all references to formats in other files.
717 * format.def: Rewrite and reorganize.
719 * settings.c: Move everything related to custom currency formats
720 into format.[ch], changing them in form, so as to group related
721 code and definitions better. Changed all references to use the
723 (static var decimal) Removed.
724 (static var grouping) Removed.
725 (static var cc) Removed.
726 (get_decimal) Removed.
727 (set_decimal) Removed.
728 (get_grouping) Removed.
729 (set_grouping) Removed.
733 * settings.h: (macro CC_CNT) Removed.
734 (macro CC_WIDTH) Removed.
735 (struct custom_currency) Removed.
737 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
739 * data-in.c (data_in): Use switch statement instead of table, to
740 avoid dependence on the order of the FMT_* enums.
742 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
744 * data-out.c: (num_to_string) Removed, because it was dead code.
746 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
748 * data-in.c (parse_trailer): Fix error message.
750 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
752 * format.c (fmt_is_binary): New function.
754 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
756 * procedure.c procedure.h: Encapsulated the static data into a single
759 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
761 * casefile.c (casereader_read_xfer): Always initialize the case,
762 even on an error condition.
764 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
766 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
767 entire function useless.
769 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
771 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
772 casereader method casereader_clone.
774 * procedure.c pransformations.h: Introduced new type casenum_t
776 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
778 * variable.c: (width_to_bytes) Rephrase code for clarify.
780 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
782 * format.c: (fmt_type_from_string) New function.
783 (fmt_to_string) Include decimals in output if the format has
784 decimals, even if the format type does not. This way, we can
785 accurately reproduce incorrect formats in user output.
786 (check_common_specifier) Make the check for a bad format type an
787 assertion, so we get bug reports if they show up. Fix message.
788 Check for decimal places with a format type that doesn't allow
790 (check_input_specifier) Remove check for FMT_X, which has been
792 (check_output_specifier) Ditto.
794 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
796 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
797 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
798 (enum fmt_parse_flags) Removed.
800 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
802 * casefile.c casefile.h: Converted to an abstract base class.
803 * casefile-private.h fastfile.c fastfile.h: New files.
804 * automake.mk procedure.c scratch-writer.c storage-stream.c
806 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
808 * procedure.c (internal_procedure): Create sink_case with only as
809 many values as the compacted dictionary.
811 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
813 Remove "debugging" code that caused plenty of false positives and
816 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
818 * case.c: Remove all references to `this' member.
820 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
822 Fix link error noted by Jason Stover.
824 * storage-stream.c: Include <assert.h>.
826 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
828 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
829 ALL) and additional underlying system file issues.
831 Thanks to John Darrington for review.
833 First problem: var_hash points to variables not owned by the
834 sys-file-reader, which the caller may free or modify. Use an
835 array of sfm_vars instead, as done earlier (e.g. CVS version
838 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
839 members and remove all code that references it. Add vars, var_cnt
840 members. Remove fix_specials member, which was unused.
841 (struct sfm_var) Remove name member, which was unused.
842 (sfm_close_reader) Free vars member instead of var_hash.
843 (compare_var_shortnames) Removed.
844 (hash_var_shortname) Removed.
845 (sfm_open_reader) Fill out vars array.
846 (compare_var_index) Removed.
847 (sfm_read_case) Use vars instead of var_hash.
849 Second problem: we're confused about when we actually have very
850 long strings, causing us to choose incorrectly between slow path
851 and fast path in sfm_read_case.
853 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
854 have very long strings, not when we have long variable names,
855 which is an unrelated feature.
857 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
859 * variable.h: Move var_set and variable parsing declarations to
860 new header, src/language/lexer/variable-parser.h. Modified lots
861 of files to include the new header.
863 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
865 * value-labels.c (value_to_string): When there's no value label,
866 format the variable according to its print format, instead of
867 always effectively using A or F format.
869 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
871 * casefile.c (casefile_get_random_reader): Nasty hack to get around
874 * format.c: Removed tortological assertion.
876 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
878 Reform string library.
880 * file-name.c (fn_interp_vars): Change interface to take a
881 substring as input. Updated all users.
883 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
885 * format.c (measure_is_valid): Really return false when m >=
888 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
890 Implement random access to casefiles, for use in GUI.
892 * casefile.c: (struct casereader) Add `random', `file_ofs',
893 `buffer_ofs' members.
894 (casefile_get_random_reader) New function.
895 (read_open_file) Break part into new function
896 seek_and_fill_buffer().
897 (fill_buffer) Update buffer_ofs, file_ofs.
898 (casereader_seek) New function.
900 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
902 * settings.c: Added call to i18n{done, init}.
904 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
906 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
909 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
911 * casefile.c: Convert many uses of `int' to `bool'.
913 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
915 * transformations.c (trns_chain_destroy): Destroy chain's trns
916 member, to fix memory leak.
918 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
920 * storage-stream.c (storage_source_decapsulate): Destroy case
921 source to fix memory leak.
923 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
925 * scratch-reader.c (scratch_reader_read_case): Copy into existing
926 case passed as argument instead of initializing the argument as a
927 case. Fixes memory leak that showed up in
928 tests/command/aggregate.sh with scratch files.
930 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
932 * procedure.c (proc_done): Destroy default_dict, to fix memory
935 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
937 Simplify procedure_with_splits().
939 * procedure.c (struct split_aux_data): Removed case_count member.
940 (procedure_with_splits) Don't initialize case_count.
941 (split_procedure_case_func) Check whether prev_case is null
942 instead of case_count.
943 (split_procedure_end_func) Ditto.
945 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
947 * case.c (case_move): Do nothing if dst and src are the same
949 (case_try_create) Merge two similar cases.
950 (case_copy) Unshare only if data must be actually copied.
952 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
954 * data-in.c data-out.c dictionary.c sys-file-reader.c
955 sys-file-writer.c variable.c variable.h: Reworked very long string
956 support for better encapsulation.
958 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
960 * value-labels.c (val_labs_can_set_width): New function.
961 (val_labs_set_width) Clear labels if increasing width to long
963 (val_labs_destroy) Remove unneeded test for null.
965 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
967 * value-labels.h: Remove unneeded dependency on variable.h.
969 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
971 Get rid of `char *c' member in union value, for cleanliness.
973 * value.h: (union value) Remove `c' member.
975 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
977 Make dictionary compacting functions a little more general.
979 * sys-file-writer.c (sfm_open_writer): Use
980 dict_compacting_would_change().
981 (does_dict_need_translation) Removed.
983 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
985 Make dictionary compacting functions a little more general.
987 * dictionary.c (dict_needs_compaction): Rename
988 dict_compacting_would_shrink(). Update all callers.
989 (dict_compacting_would_change) New function.
991 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
993 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
994 inverted return value (!).
996 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
998 Continue reforming procedure execution.
1000 * procedure.c: Search and replace "vfm" by "proc". Notably:
1001 (static var vfm_source) Rename proc_source. Update all
1003 (static var vfm_sink) Rename proc_sink. Update all references.
1005 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1007 Continue reforming procedure execution. In this phase, remove
1008 PROCESS IF, which was deprecated anyway and can be easily
1009 simulated with TEMPORARY followed by SELECT IF.
1011 * procedure.c: (open_active_file) Don't call
1012 add_process_if_trns().
1013 (discard_variables) Get rid of redundant call to
1014 proc_cancel_all_transformations().
1015 (add_process_if_trns) Removed.
1016 (process_if_trns_proc) Removed.
1017 (process_if_trns_free) Removed.
1019 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1021 Continue reforming procedure execution. In this phase, add
1022 `const' to the case passed to procedure()'s callback.
1024 Updated all users of procedure() as well.
1026 * procedure.c: (struct write_case_data) Add "const" to ccase
1027 parameter for case_func member.
1028 (procedure) Add "const" to ccase parameter for proc_func
1030 (multipass_case_func) Make ccase parameter const.
1031 (internal_procedure) Add "const" to ccase parameter for case_func
1033 (split_procedure_case_func) Make ccase parameter const.
1034 (multipass_split_case_func) Make ccase parameter const.
1036 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1038 Continue reforming procedure execution. In this phase, get rid of
1039 the output code for SPLIT FILE groups in procedure.c, which really
1040 shouldn't be doing any output. Move it into the individual
1041 procedures instead. This also adds some flexibility.
1043 Updated many users of procedure_with_splits() and
1044 multipass_procedure_with_splits() to call
1045 output_split_file_values() and to deal with increased use of
1048 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1049 parameter to begin_func member.
1050 (procedure_with_splits) Add "const struct ccase *" parameter to
1051 begin_func parameter. Make ccase parameter const in proc_func
1053 (split_procedure_case_func) Don't dump split file group. Pass
1055 (dump_splits) Moved to language/dictionary/split-file.c as
1056 output_split_file_values().
1057 (struct multipass_split_aux_data) Add "const struct ccase *"
1058 parameter to split_func member.
1059 (multipass_procedure_with_splits) Add "const struct ccase *"
1060 parameter to split_func parameter.
1061 (multipass_split_case_func) Save new SPLIT FILE case before
1063 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1065 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1067 Continue reforming procedure execution. Change
1068 internal_procedure() so that it calls open_active_file() and
1069 close_active_file(), which isolates most of the actual procedure
1072 * procedure.c: (struct write_case_data) Rename `proc_func' member
1073 to `case_func' and update all references.
1074 (procedure) Rewrite as one-line wrapper around
1075 internal_procedure().
1076 (struct multipass_aux_data) New.
1077 (multipass_callback) Renamed multipass_case_func(). Use struct
1078 multipass_aux_data as auxiliary data.
1079 (multipass_end_func) New function.
1080 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1081 that uses multipass_case_func, multipass_end_func.
1082 (internal_procedure) Add `end_func' argument. Move optimization
1083 of trivial case in here. Move call to open_active_file() and
1084 close_active_file() in here. Now assert that vfm_source is
1086 (procedure_with_splits_callback) Rename
1087 split_procedure_case_func().
1088 (split_procedure_end_func) New function.
1089 (multipass_split_callback) Rename multipass_split_case_func.
1090 (multipass_split_end_func) New function.
1091 (discard_variables) No need to test for nonnull vfm_source.
1093 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1095 Continue reforming procedure execution. Get rid of unused member.
1097 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1099 (write_case) Don't increment cases_analyzed.
1101 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1103 Continue reforming procedure execution. In this phase, move
1104 procedure.c and procedure.h from src to src/data. Update
1105 makefiles and #includes accordingly.
1107 * procedure.c: Moved here from src/.
1109 * procedure.h: Moved here from src/.
1111 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1113 Continue reforming procedure execution. In this phase, get rid of
1114 many global variables, consolidating procedure execution in
1115 procedure.c. Encapsulate transformations in new "struct
1116 trns_chain". Also, change implementation of N OF CASES, FILTER,
1117 and PROCESS IF from special cases to transformations.
1119 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1122 * dictionary.c: (global variable default_dict) Move to
1125 * variable.h: (TRNS_*) Move to transformations.h.
1126 (struct transformation) Move to transformations.c.
1128 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1130 * sys-file-reader.c: Fixed invalid read problems.
1132 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1134 * storage-stream.c: Add missing function comments.
1136 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1138 Continue reforming procedure execution. In this phase, add some
1139 new, needed functionality to storage-stream.
1141 * storage-stream.c: (storage_source_decapsulate) New function.
1143 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1145 * variable.c (width_to_bytes): Declarations must precede
1146 statements for C90 compliance.
1148 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1150 * data-out.c, data-in.c, variable.c, variable.h: New functions
1151 copy_mangle and copy_demangle for reading/writing cases; emulates the
1152 way SPSS deals with strings > 255 bytes.
1154 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1155 subtype 14 needed for strings longer than 255 bytes.
1157 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1158 instead of literal values. Also fixed some constness issues.
1160 * format.h: Constness
1162 * sfm-private.h: Renamed the case_size identifier, since I discovered
1163 that SPSS's respect for this variable is very nominal.
1165 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1167 Change case limit type from int to size_t.
1169 * dictionary.c: (struct dictionary) Change type of case_limit
1171 (dict_get_case_limit) Change return type.
1172 (dict_set_case_limit) Change parameter type.
1174 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1176 * variable.h: (struct variable) Rename `reinit' member as `leave'
1177 and invert sense. Fix up all references.
1179 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1181 Continue reforming procedure execution. In this phase, break
1182 procedure.c into multiple files.
1184 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1186 * case-sink.c: New file.
1188 * case-sink.h: New file.
1190 * case-source.c: New file.
1192 * case-source.h: New file.
1194 * storage-stream.c: New file.
1196 * storage-stream.h: New file.
1198 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1200 * variable.h: (struct variable) Remove `init' member and all
1201 references to it from other files. It was initialized in several
1202 places, but nothing really ever used it for anything worthwhile.
1203 Thanks to Jason Stover for pointing out how confusing this
1206 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1208 Continue reforming error message support. In this phase, get rid
1209 of message "titles" and put the message text in `struct error'.
1210 Now `struct error' encapsulates a message more properly.
1212 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1213 Format message ourselves.
1215 * data-in.c: (vdls_error) Ditto.
1217 * por-file-reader.c: (error) Ditto.
1219 * sys-file-reader.c: (corrupt_msg) Ditto.
1221 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1223 GNU standards require "file name" instead of "filename" in
1224 documentation. It's nice for our code to follow the convention
1227 * casefile.c: (struct casefile) Rename `filename' member to
1228 `file_name'. Updated all references.
1230 * file-name.c: [!unix] (struct file_identity) Rename
1231 normalized_filename member to normalized_file_name. Updated all
1234 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1236 We don't really support anything but Unix-like environments well,
1237 so we might as well de-obfuscate by writing directory and path
1238 separators explicitly.
1240 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1242 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1243 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1245 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1248 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1250 GNU standards require "file name" instead of "filename" in
1251 documentation. It's nice for our code to follow the convention
1254 * filename.c: Rename to file-name.c.
1256 * filename.h: Rename to file-name.h. Update all inclusions.
1257 Update header guards.
1259 * automake.mk: Update file names.
1261 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1263 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1265 (fn_basename) Removed (dead code).
1266 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1267 (fn_special_p) Renamed fn_is_special(), all references updated.
1268 (fn_exists_p) Renamed fn_exists(), all references updated.
1270 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1272 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1273 Also, now it only tilde-expands file names, not paths.
1274 (fn_search_path) Tilde-expand one directory at a time.
1276 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1278 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1279 get rid of non-Unixlike version of the code, which has probably
1281 (fn_prepend_dir) Removed (dead code).
1283 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1284 (macro PATH_SEPARATOR_STRING) New.
1285 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1287 Continue reforming error message support. In this phase, we get
1288 rid of VM() and the other msg() support for "verbosity", replacing
1289 it by a new function verbose_msg().
1291 * filename.c: (fn_search_path) Use verbose_msg() instead of
1294 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1296 * sfm-private.h: Get rid of #defines after #error, which makes no
1299 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1301 Get rid of our own int32 type in favor of the standard int32_t
1304 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1307 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1309 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1311 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1313 Remove ill-considered file routines that are no longer used.
1315 * filename.c: (fn_open_ext) Removed.
1316 (fn_close_ext) Removed.
1318 * filename.h: (struct file_ext) Removed.
1320 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1322 * variable.c (var_is_valid_name): Move declarations before code
1325 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1327 * filename.ch (fn_interp_vars): Fixed small buglet.
1329 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1331 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1332 so as to modify the string inline. Thus makeing it easier to
1333 destroy the results when no longer needed.
1335 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1337 * category.c (cat_stored_values_destroy): Fixed memory leak.
1339 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1341 Add some missing frees. Thanks to John Darrington for reporting
1344 * any-writer.c (any_writer_close): Free writer.
1346 * any-reader.c (any_reader_close): Free reader.
1348 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1350 * por-file-reader.c: (error) Mark as NO_RETURN.
1352 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1354 * settings.c: Changed default value of scompress to true.
1356 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1358 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1360 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1363 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1364 here from pref.h.orig.
1366 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1368 * sys-file-reader.c: Fixed bug reading compressed files.
1370 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1372 * Numerous renames. See src/ChangeLog for details.
1374 * Moved files from src directory