1 2007-06-06 Ben Pfaff <blp@gnu.org>
3 * value.h (value_cnt_from_width): New function.
5 * variable.c (var_get_value_cnt): Use new function.
7 2007-06-06 Ben Pfaff <blp@gnu.org>
9 Add casegrouper, to allow cases read from a given casereader to be
10 broken into groups, each of which has its own casereader.
11 Generally cases are grouped based on having equal values for some
14 * automake.mk: Add new files.
16 * casegrouper.c: New file.
18 * casegrouper.h: New file.
20 2007-06-06 Ben Pfaff <blp@gnu.org>
22 Add interface to lexicographical ordering of cases.
24 * automake.mk: Add new files.
26 * case-ordering.c: New file.
28 * case-ordering.h: New file.
30 2007-06-06 Ben Pfaff <blp@gnu.org>
32 Add casereaders and casewriters, the basis of the new data processing
33 implementation. A casereader is a uniform interface to reading cases
34 from a data source; a casewriter is a uniform interface to writing
37 * automake.mk: Add new files.
39 * casereader-filter.c: New file.
41 * casereader-provider.h: New file.
43 * casereader-translator.c: New file.
45 * casereader.c: New file.
47 * casereader.h: New file.
49 * casewriter-provider.h: New file.
51 * casewriter-translator.c: New file.
53 * casewriter.c: New file.
55 * casewriter.h: New file.
57 2007-06-06 Ben Pfaff <blp@gnu.org>
59 "casewindow" data structure that extends the deque (from libpspp)
60 of cases with the ability to dump cases to disk if we get too many
63 * automake.mk: Add new files.
65 * casewindow.c: New file.
67 * casewindow.h: New file.
69 2007-06-06 Ben Pfaff <blp@gnu.org>
71 sparse_cases data structure that augments a sparse_array of cases
72 with the ability to dump cases to disk if we get too many cases in
75 * automake.mk: Add new files.
77 * sparse-cases.c: New file.
79 * sparse-cases.h: New file.
81 2007-06-06 Ben Pfaff <blp@gnu.org>
83 Adds a low-level on-disk case array data structure.
85 * automake.mk: Add new files.
87 * case-tmpfile.c: New file.
89 * case-tmpfile.h: New file.
91 2007-06-06 Ben Pfaff <blp@gnu.org>
93 In a couple of places we calculate the maximum number of cases to
94 keep in memory based on the user-defined workspace. Enable
95 centralizing the calculation through a new function.
97 * settings.c (get_workspace_cases): New function.
99 2007-06-06 Ben Pfaff <blp@gnu.org>
101 The casenumber type is defined in transformations.h, but case.h is
102 a more sensible place. Move it.
104 * case.h (CASENUMBER_MAX): New macro.
105 (typedef casenumber): Move here, from transformations.h.
107 2007-06-03 Ben Pfaff <blp@gnu.org>
109 Slightly generalize case_to_values and case_from_values functions.
111 * case.c (case_to_values): Rename case_copy_out, change interface.
112 (case_from_values): Rename case_copy_in, change interface.
114 * fastfile.c (fastfilereader_get_next_case): Update caller.
115 (write_case_to_disk): Ditto.
117 2007-06-02 Ben Pfaff <blp@gnu.org>
119 Clean up after a forgotten part of patch #5829.
121 * casedeque.h: Remove unused file.
123 * automake.mk: Remove casedeque.h from sources.
125 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
127 * category.c: Removed redundant #include
129 2007-05-06 Ben Pfaff <blp@gnu.org>
131 Abstract the documents within a dictionary a little better.
132 Thanks to John Darrington for suggestion, initial version, and
135 * dictionary.c (struct dictionary): Change `documents' member from
136 char * to struct string.
137 (dict_clear): Destroy struct string.
138 (dict_get_documents): Convert struct string to char *.
139 (dict_set_documents): Set struct string. Pad to 80-character
141 (dict_clear_documents): New function.
142 (dict_add_document_line): New function.
143 (dict_get_document_line_cnt): New function.
144 (dict_get_document_line): New function.
146 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
148 * sys-file-reader.c (read_documents): Use new document functions.
150 2007-04-19 John Darrington <john@darrington.wattle.id.au>
152 * sys-file-reader.c: When reading a system file which has no
153 long name table, automatically create one where the long names
154 are the lower case versions of the short names.
156 2007-04-22 Ben Pfaff <blp@gnu.org>
158 * dictionary.c (dict_set_split_vars): dict_destroy expects that
159 dict_clear will free most data related to the dictionary.
160 dict_clear does a decent job, except that dict_set_split_vars on
161 some systems won't actually free the dict's "split" member.
162 Instead, it'll allocate a 1-byte region. Fix this.
164 * value.c (value_copy): New function.
165 (value_set_missing): Ditto.
167 2007-04-22 John Darrington <john@darrington.wattle.id.au>
169 * Deleted existing category.h and moved cat-routines.h into
170 category.h Encapsulated struct cat_vals better.
172 2007-04-19 John Darrington <john@darrington.wattle.id.au>
174 * sys-file-reader.c: When reading a system file which has no
175 long name table, automatically create one where the long names
176 are the lower case versions of the short names.
178 2007-04-16 John Darrington <john@darrington.wattle.id.au>
180 * sys-file-reader.c: Some versions of Other Software seem to
181 produce system files with string variables' measure set to
182 zero. We'll assume these are supposed to be nominal variables.
184 2007-03-30 Ben Pfaff <blp@gnu.org>
186 * procedure.c: Adapt to new deque data structure.
188 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
189 Ben Pfaff <blp@gnu.org>
191 * file-name.c: Mingw compatibility fixes.
192 (fn_search_path): Use ISSLASH instead of comparing against '/'
194 (fn_dir_name): Use dir_name from gnulib.
195 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
196 (fn_get_identity): Use GetFullPathName instead of canonicalize
197 from gnulib, because the latter does not fully support
198 Windows-style path names. Use this implementation based on the
199 detected presence of Windows instead of the absence of Unix, since
200 the new implementation is Windows-specific.
201 (fn_compare_file_identities): In Windows implementation, compare
202 names case-insensitively.
204 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
206 * make-file.c: Don't include mkstemp.h, because gnulib now causes
207 <stdlib.h> to have the same effect.
209 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
211 * por-file-reader.c: Add missing _() around messages.
213 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
215 * make-file.c: Include "mkstemp.h", without which linking on
218 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
220 Reduce platform dependence.
222 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
223 Everywhere we using this, we really should have just depended on
224 the shell to expand tildes.
225 (fn_search_path): Simplify, given that we don't do tilde expansion
227 (fn_normalize): Removed. Caller changed to use the canonicalize
229 (fn_get_cwd): Removed. Only user was fn_normalize.
230 (fn_is_absolute): Really only test for absolute names.
231 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
233 (fn_readlink): Removed, as it was only used fn_normalize.
234 (fn_exists): Assume the stat function is available; gnulib does.
235 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
237 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
239 * dictionary.c (dict_create_vector_assert): New function.
241 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
243 * file-name.c (fn_normalize): Correct name of function
244 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
245 for pointing this out.
247 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
249 We are using a single member in struct file_handle, the "name"
250 field, for more than one purpose. When it begins with '"', it's a
251 file name; otherwise, it's a token that can be used to identify
252 it. When that assertion fires, it's because we searched for the
253 name case-sensitively as a file name (so that there was no match),
254 and then we try to insert it case-insensitively as a token, which
255 fails because duplicates aren't allowed.
257 Solution: break the two purposes into two separate fields. This
258 fixes the problem and likely makes the code easier to read too.
260 Fixes bug #18922. Thanks to John Darrington for bug report and
263 * file-handle-def.c (struct file_handle): New `id' member.
264 (fh_from_name): Rename fh_from_id. Update all callers.
265 (create_handle): New `id' parameter. Update all callers.
266 (fh_create_file): Ditto.
267 (fh_get_id): New function.
269 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
271 * case.c (case_is_null): Change return type to bool.
273 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
277 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
278 reference counting to share data. This makes it easy for
279 valgrind, etc. to find accesses to cases that have been destroyed
280 but have been kept around by another user's ref-count. This often
281 happens when the data set is small enough to find in memory; if a
282 bigger data set that would overflow to disk were used, then data
283 corruption would occur.
285 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
289 * case.c (case_unshare): Make it check internally whether the
290 ref_cnt is greater than 1, so that the callers don't have to.
291 Update callers not to check.
293 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
295 Before, I was thinking that I might want to get rid of reference
296 counting at some point. Now, I'm pretty sure that it's here to
297 stay. Thus, because we have to store the value_cnt anyway for
298 reference-counted cases, we might as well expose it to users.
300 * case.c (case_get_value_cnt): New function.
301 (case_resize): Drop OLD_CNT argument. Update all callers. Only
302 resize case if its size actually changed.
304 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
305 instead of peeking inside struct case directly.
306 (casefile_append): Ditto.
308 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
310 Get rid of the inlines for the case functions, which made the
311 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
312 the inlines didn't speed up "make check" at all, which is not a
313 perfect benchmark but seems indicative.)
315 * case.c: Remove #ifdef DEBUGGING...#endif around many function
316 definitions. Remove some assertions on nonnull pointers that were
317 redundant with a pointer dereference soon after in the function.
319 (struct case_data): Move definition here from case.h.
323 (case_data_wr): Ditto.
325 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
327 * automake.mk: Add casedeque.h to sources.
329 * casedeque.h: New file.
331 * procedure.c: (struct dataset) Change lag_count, lag_head,
332 lag_queue member into single struct casedeque member. Update all
333 users to use the casedeque instead.
336 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
338 * procedure.c: Simplify lagged cases interface. Updated all
339 clients--well, the only client--to use the simplified interface.
340 (dataset_n_lag) Removed.
341 (dataset_set_n_lag) Removed.
342 (dataset_need_lag) New function.
344 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
346 * dictionary.c procedure.c: More changes to ensure that callbacks occur
347 whenever appropriate, but only when the dataset/dictionary is in a
350 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
352 * dictionary.c dictionary.h : Added callbacks for change of filter and
353 split variables. Refactored some code to ensure that callbacks get
354 invoked when appropriate.
356 * procedure.c (proc_cancel_temporary_transformations): Make sure that
357 replace_dict callback occurs when permanent_dict replaces the current
360 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
362 * dictionary.c dictionary.h : Added callback for when the weight
363 variable of a dictionary changes.
365 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
367 * dictionary.c dictionary.h : Added replace_source and replace_dict
368 callbacks, and functions to deal with them.
370 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
372 Simplify missing value handling.
374 * missing-values.h (enum mv_class): New type.
375 (enum mv_type): Moved definition into missing-values.c and renamed
376 each MV_* to MVT_*, to distinguish them from the exposed mv_class
377 enums. Updated all uses.
378 (struct missing_values): Changed type of `type' from `enum
379 mv_type' to `int' because the definition is no longer exposed.
381 * missing-values.c (mv_is_value_missing): Add new enum mv_class
382 parameter. Update all callers.
383 (mv_is_num_missing): Ditto.
384 (mv_is_str_missing): Ditto.
385 (mv_is_value_user_missing): Removed. Changed callers to use
387 (mv_is_num_user_missing): Removed. Changed callers to use
389 (mv_is_str_user_missing): Removed. Changed callers to use
391 (mv_is_value_system_missing): Removed. Changed callers to use
393 (mv_set_type): Removed. Changed callers to use mv_clear.
394 (mv_clear): New function.
396 * variable.c (var_is_value_missing): Add new enum mv_class
397 parameter. Update all callers.
398 (var_is_num_missing): Ditto.
399 (var_is_str_missing): Ditto.
400 (var_is_value_user_missing): Removed. Changed callers to use
401 var_is_value_missing.
402 (var_is_num_user_missing): Removed. Changed callers to use
404 (var_is_str_user_missing): Removed. Changed callers to use
406 (var_is_value_system_missing): Removed. Changed callers to use
407 var_is_value_missing.
409 * casefilter.c (struct casefilter): Use enum mv_class in place of
411 (casefilter_variable_missing): Adapt to new member.
412 (casefilter_create): Change signature to take enum mv_class,
415 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
417 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
419 * case-sink.c case-sink.h procedure.c procedure.h
420 storage-stream.c: Now uses the factory.
422 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
424 Make it possible to pull cases from the active file with a
425 function call, instead of requiring indirection through a callback
428 * case-source.h (struct case_source_class): Change ->read function
429 to return a single case, instead of calling a callback function
430 for each case. Change ->destroy function to return an error
433 * case-source.c (free_case_source): Pass along the value returned
434 by the case_source ->destroy function.
436 * procedure.c (struct write_case_data): Removed.
437 (struct dataset): Added some members to track procedure state.
438 (procedure): Optimize the trivial case at this level.
439 (internal_procedure): Re-implement in terms of proc_open,
440 proc_read, proc_close.
441 (proc_open) New function.
442 (proc_read) New function.
443 (proc_close) New function.
444 (write_case) Moved into proc_read.
445 (close_active_file) Moved closing of data source into proc_close.
447 * storage-source.c: Rewrote to conform with modified
448 case_source_class interface.
450 * transformations.c (trns_chain_execute): Added argument to allow
451 starting execution from an arbitrary transformation. Updated
454 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
456 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
458 * sys-file-reader.c (read_display_parameters): Don't assume that
459 MEASURE_* and ALIGN_* have the same values found in system files.
461 * sys-file-writer.c (write_variable_display_parameters): Ditto.
463 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
464 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
465 the value of n_MEASURES, which was off by 1 (at least from my
468 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
470 * dictionary.c dictionary.h vardict.h variable.c: Added optional
471 callbacks which are invoked when the dictionary or its
472 variables are changed.
474 * missing-values.c missing-values.h value-labels.c: Tidied up
475 consistency checks, and made some of them return false
476 instead of assert-failing.
478 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
480 * calendar.c (calendar_days_in_month): New function.
482 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
484 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
485 the value label's width.
487 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
489 * sfm-private.h: Move contents into sys-file-writer.c, which is
490 the only remaining user. Removed Borland C++-specific directives.
492 * sys-file-reader.c: Clean up and rewrite entire file. The
493 rewritten version is simpler and better abstracted, and should be
494 easier to maintain and extend. It avoids using structures to read
495 file data, which is prone to padding variations among compilers.
496 It should also handle non-IEEE 754 system files, although I
497 haven't been able to find any. It has been tested against many
498 .sav files obtained from the Web and found to produce the same
499 results as the earlier version of the code, or in some cases
500 improved results. It is more tolerant of format variations found
503 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
504 member, putting an enum integer_format in its place. New member
505 `float_format'. Changed `compressed' member to type bool.
507 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
509 * dictionary.c (dict_delete_consecutive_vars): New function.
511 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
513 * file-name.c (fn_search_path): Remove prefix arg that was unused
514 by any caller. Updated all callers.
516 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
518 * format.c (fmt_dollar_template): Use user's decimal point
519 character. Add assertion.
521 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
523 * format.c (fmt_dollar_template): New function, based on
524 dollar_format_template from var-type-dialog.c.
526 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
528 * data-out.c (output_scientific): Fix bad assumption that "buf" is
531 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
533 Finish converting struct variable to an opaque type. In this
534 phase, we add remaining setter and getter functions, convert the
535 remaining PSPP code to use them, and do a bunch of cleanup. The
536 resulting changes are pervasive but mostly trivial, and only the
537 notable changes are logged.
539 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
542 * case.c (case_data): Renamed case_data_idx.
543 (case_num): Renamed case_num_idx.
544 (case_str): Renamed case_str_idx.
545 (case_data_rw): Renamed case_data_rw_idx.
547 * case.h (case_data): New function with old name and an interface
548 that takes a variable instead of an index, which is easier to
549 use. Updated all callers to use the new interface, or to use the
550 new *_idx function (see above).
553 (case_data_rw): Ditto.
555 * category.c (cat_stored_values_destroy): Changed interface to
556 take a struct cat_vals * instead of a struct variable *.
558 * dictionary.c (dict_clone): Use new vector_clone function.
559 (dict_clear) Use new var_destroy function.
560 (add_var) New function.
561 (dict_create_var) Rewrite in terms of dict_create_var_assert.
562 (dict_create_var_assert) Rewrite in terms of add_var.
563 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
564 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
565 (dict_lookup_var) Use new var_create, var_destroy functions.
566 (dict_contains_var) Rewrite in terms of new vardict functionality.
567 (set_var_dict_index) New function.
568 (set_var_case_index) New function.
569 (reindex_vars) New function.
570 (dict_delete_var) Rewrite in terms of new vardict functionality.
571 (dict_reorder_var) Ditto.
572 (dict_reorder_vars) Ditto.
573 (rename_var) New function.
574 (dict_rename_var) Use rename_var.
575 (dict_rename_vars) Use pool to simplify code. Use rename_var.
576 (dict_get_compacted_idx_to_fv) Rename
577 dict_get_compacted_dict_index_to_case_index, update callers.
578 (dict_create_vector) Use new vector_create function.
579 (dict_clear_vectors) Use new vector_destroy function.
580 (set_var_short_name_suffix) Move here from variable.c, renamed
581 from var_set_short_name_suffix, make static, update caller.
583 * sys-file-private.c: New file.
584 (sfm_width_to_bytes) Moved here from variable.c, renamed from
585 width_to_bytes, update callers.
587 * sys-file-private.h: New file. Later it will supplant
588 sfm-private.h; for now it supplements it.
589 (macro MIN_VERY_LONG_STRING) New macro.
590 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
592 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
593 MAX_LONG_STRING was used before.
595 * sys-file-writer.c: Ditto.
597 * value-labels.c: Change the paradigm here to be that a null
598 pointer is OK for a struct val_labs * in most cases; it just
599 represents an empty set of value labels.
600 (val_labs_copy) A copy of a null set is a null set.
601 (val_labs_count) A null set has 0 labels.
602 (val_labs_replace) Change return type to void. Rewrite for
604 (val_labs_find) A null set does not contain the value.
605 (value_to_string) Moved to variable.c, renamed var_get_value_name,
606 transposed argument order, updated all callers.
609 (value_dup) Moved here from variable.c.
610 (compare_values) Ditto.
613 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
614 (macro MAX_LONG_STRING) Removed, because it was only interesting
615 for system files, not for general code.
616 (macro MAX_VERY_LONG_STRING) Ditto.
617 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
618 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
620 * vardict.h: New file, for an interface between variables and
623 * variable.c: A lot of functions were moved around, for better
625 (struct variable) Move definition here, from variable.h.
626 (var_type_adj) Removed--makes i18n hard.
627 (var_type_noun) Ditto.
628 (var_create) New function.
629 (var_clone) New function.
630 (var_destroy) New function.
631 (var_set_name) Assert that variable is not in a dictionary.
632 (compare_var_names) Rename compare_vars_by_name and fix a couple
633 of callers who thought the args were strings.
634 (hash_var_name) Rename hash_var_by_name.
635 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
636 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
637 (var_is_very_long_string) Removed, because it was only interesting
639 (var_set_missing_values) Allow the argument to be the wrong width,
640 as long as we can resize it. Simplify callers who were doing the
642 (var_get_value_labels) New function.
643 (var_has_value_labels) New function.
644 (var_set_value_labels) New function.
645 (alloc_value_labels) New function.
646 (var_add_value_label) New function.
647 (var_replace_value_label) New function.
648 (var_clear_value_labels) New function.
649 (var_lookup_value_label) New function.
650 (var_get_value_name) Moved here from variable.c, renamed from
651 var_get_value_name, transposed argument order, updated all
653 (var_to_string) Moved here, from variable-label.c.
654 (var_set_leave) New function.
655 (var_get_leave) New function.
656 (var_must_leave) New function.
657 (var_set_short_name_suffix) Moved to dictionary.c, renamed
658 set_var_short_name_suffix.
659 (var_get_dict_index) New function.
660 (var_get_case_index) New function.
661 (var_get_obs_vals) New function.
662 (var_set_obs_vals) New function.
663 (var_has_obs_vals) New function.
664 (var_get_vardict) New function.
665 (var_set_vardict) New function.
666 (var_has_vardict) New function.
667 (var_clear_vardict) New function.
668 (value_dup) Moved to value.c.
669 (compare_values) Ditto.
672 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
673 (enum ALPHA) Rename VAR_STRING, update all users.
675 * vector.c: New file.
676 (struct vector) Moved here, from variable.h.
677 (check_widths) New function.
678 (vector_create) New function.
679 (vector_clone) New function.
680 (vector_destroy) New function.
681 (vector_get_name) New function.
682 (vector_get_var) New function.
683 (vector_get_var_cnt) New function.
684 (compare_vector_ptrs_by_name) New function.
686 * vector.h: New file.
688 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
690 * casefilter.c (casefilter_variable_missing): Avoided comparision of
691 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
694 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
696 * value-labels.c (destroy_atoms): New function.
697 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
699 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
701 Thanks to Jason Stover for pointing out this problem.
703 * data-out.c (output_number): Use gsl_finite from GSL, which is
704 portable, instead of isfinite, which is not.
707 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
709 * variable.c variable.h (value_dup): New function.
711 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
713 Start converting struct variable to an opaque type. In this
714 phase, we add a bunch of setter and getter functions and convert
715 most of the PSPP code to use them. The resulting changes are
716 pervasive but mostly trivial, and only the notable changes are
719 * format.c (fmt_equal): New function.
721 * variable.c (var_type_is_valid): New function.
722 (measure_is_valid) Moved here, from format.c.
723 (alignment_is_valid) Moved here, from format.c.
724 (var_get_name) New function.
725 (var_set_name) New function.
726 (width_to_type) New function.
727 (var_get_type) New function.
728 (var_get_width) New function.
729 (var_set_width) New function.
730 (var_is_numeric) New function.
731 (var_is_alpha) New function.
732 (var_is_short_string) New function.
733 (var_is_long_string) New function.
734 (var_is_very_long_string) New function.
735 (var_get_missing_values) New function.
736 (var_set_missing_values) New function.
737 (var_clear_missing_values) New function.
738 (var_has_missing_values) New function.
739 (var_is_value_missing) New function.
740 (var_is_num_missing) New function.
741 (var_is_str_missing) New function.
742 (var_is_value_user_missing) New function.
743 (var_is_num_user_missing) New function.
744 (var_is_str_user_missing) New function.
745 (var_is_value_system_missing) New function.
746 (var_get_print_format) New function.
747 (var_set_print_format) New function.
748 (var_get_write_format) New function.
749 (var_set_write_format) New function.
750 (var_set_both_formats) New function.
751 (var_get_label) New function.
752 (var_set_label) New function.
753 (var_clear_label) New function.
754 (var_has_label) New function.
755 (var_get_measure) New function.
756 (var_set_measure) New function.
757 (var_get_display_width) New function.
758 (var_set_display_width) New function.
759 (var_get_alignment) New function.
760 (var_set_alignment) New function.
761 (var_get_value_cnt) New function.
762 (var_get_leave) New function.
763 (var_get_short_name) New function.
765 * variable.h: (struct variable) Removed "type" and "nv" members;
766 they are now computed from "width" where needed.
768 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
770 * missing-values.c (mv_resize): Don't write beyond end of the
771 allocated buffer when resizing a long string.
773 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
775 Clean up identifier code: don't require identifier enumerations to
776 be in a particular order; make better use of string library;
777 expose less of the internals.
779 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
780 change interface. Updated all callers.
781 (lex_id_match) Change interface to use struct substring, update
783 (lex_id_match_len) Removed. Update callers to use lex_id_match.
784 (global array keywords[]) Make static, change form. Update all
785 users to use lex_id_name instead.
786 (lex_is_keyword) New function.
787 (lex_id_to_token) Change interface to use struct substring, update
789 (lex_id_name) New function.
791 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
792 lex_is_keyword instead.
793 (T_LAST_KEYWORD) Removed.
794 (T_N_KEYWORDS) Removed.
796 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
798 * format.c: (fmt_date_template) Distinguish characters for which a
799 space is output and any date delimiter is allowed on input, from
800 those for which a space is output and only a space is allowed on
801 input. The former is represented by X, the latter by a space.
802 Also, drop distinction between h and H, changing the former to the
805 * data-in.c: Completely rewrite internals to conform to SPSS input
806 formats as closely as possible.
807 (data_in) Changed external interface by replacing the structure
808 that was used as a single argument by a set of arguments. Updated
810 (data_in_finite_line) Removed. Converted all callers to use plain
812 (data_in_get_integer_format) New function.
813 (data_in_set_integer_format) New function.
814 (data_in_get_float_format) New function.
815 (data_in_set_float_format) New function.
817 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
818 (struct data_in) Removed.
820 * data-out.c: (output_date) Drop each component from the input as
821 it is output, to allow us to drop the distinction between h (a
822 count of hours) and H (the hour of day) template characters.
823 Also, handle new X template character.
824 (output_scientific) Follow more rational rule on when to drop
825 fraction introduced between SPSS 13 and 15. Updated test case to
828 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
830 Fix buffer overflow reported by John Darrington.
832 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
833 realize that DIGITS is a count of nibbles, not of bytes.
835 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
837 * calendar.c (calendar_offset_to_gregorian) Also return the
838 year-of-day. Change callers to new interface.
840 * data-out.c: Completely rewrite internals to conform to SPSS
841 output formats as completely as possible.
842 (data_out) Change interface to put input parameters before output
843 parameters, for consistency with the style I now prefer. Update
845 (data_out_get_integer_format) New public function.
846 (data_out_set_integer_format) New public function.
847 (data_out_get_float_format) New public function.
848 (data_out_set_float_format) New public function.
850 * data-out.h: New file. Move prototype for data_out here, from
853 * format.c: (fmt_step_width) Use equality comparison instead of
854 bitwise and, for clarity.
855 (fmt_is_string) Ditto.
856 (fmt_input_to_output) Fix categories that are translated to F
859 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
861 * casefilter.c casefilter.h (new files), casefile.c casefile.h
862 casefile-private.h: Added casefilter to assist commands with missing
865 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
867 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
869 * settings.c: (route_errors_to_terminal) New variable.
870 (route_errors_to_listing) New variable.
871 (get_error_routing_to_terminal) New function.
872 (set_error_routing_to_terminal) New function.
873 (get_error_routing_to_listing) New function.
874 (set_error_routing_to_listing) New function.
876 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
878 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
880 * format.c: Completely rewrite, to achieve better abstraction.
881 Rewrite all references to formats in other files.
883 * format.def: Rewrite and reorganize.
885 * settings.c: Move everything related to custom currency formats
886 into format.[ch], changing them in form, so as to group related
887 code and definitions better. Changed all references to use the
889 (static var decimal) Removed.
890 (static var grouping) Removed.
891 (static var cc) Removed.
892 (get_decimal) Removed.
893 (set_decimal) Removed.
894 (get_grouping) Removed.
895 (set_grouping) Removed.
899 * settings.h: (macro CC_CNT) Removed.
900 (macro CC_WIDTH) Removed.
901 (struct custom_currency) Removed.
903 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
905 * data-in.c (data_in): Use switch statement instead of table, to
906 avoid dependence on the order of the FMT_* enums.
908 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
910 * data-out.c: (num_to_string) Removed, because it was dead code.
912 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
914 * data-in.c (parse_trailer): Fix error message.
916 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
918 * format.c (fmt_is_binary): New function.
920 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
922 * procedure.c procedure.h: Encapsulated the static data into a single
925 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
927 * casefile.c (casereader_read_xfer): Always initialize the case,
928 even on an error condition.
930 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
932 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
933 entire function useless.
935 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
937 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
938 casereader method casereader_clone.
940 * procedure.c pransformations.h: Introduced new type casenum_t
942 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
944 * variable.c: (width_to_bytes) Rephrase code for clarify.
946 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
948 * format.c: (fmt_type_from_string) New function.
949 (fmt_to_string) Include decimals in output if the format has
950 decimals, even if the format type does not. This way, we can
951 accurately reproduce incorrect formats in user output.
952 (check_common_specifier) Make the check for a bad format type an
953 assertion, so we get bug reports if they show up. Fix message.
954 Check for decimal places with a format type that doesn't allow
956 (check_input_specifier) Remove check for FMT_X, which has been
958 (check_output_specifier) Ditto.
960 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
962 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
963 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
964 (enum fmt_parse_flags) Removed.
966 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
968 * casefile.c casefile.h: Converted to an abstract base class.
969 * casefile-private.h fastfile.c fastfile.h: New files.
970 * automake.mk procedure.c scratch-writer.c storage-stream.c
972 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
974 * procedure.c (internal_procedure): Create sink_case with only as
975 many values as the compacted dictionary.
977 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
979 Remove "debugging" code that caused plenty of false positives and
982 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
984 * case.c: Remove all references to `this' member.
986 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
988 Fix link error noted by Jason Stover.
990 * storage-stream.c: Include <assert.h>.
992 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
994 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
995 ALL) and additional underlying system file issues.
997 Thanks to John Darrington for review.
999 First problem: var_hash points to variables not owned by the
1000 sys-file-reader, which the caller may free or modify. Use an
1001 array of sfm_vars instead, as done earlier (e.g. CVS version
1004 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1005 members and remove all code that references it. Add vars, var_cnt
1006 members. Remove fix_specials member, which was unused.
1007 (struct sfm_var) Remove name member, which was unused.
1008 (sfm_close_reader) Free vars member instead of var_hash.
1009 (compare_var_shortnames) Removed.
1010 (hash_var_shortname) Removed.
1011 (sfm_open_reader) Fill out vars array.
1012 (compare_var_index) Removed.
1013 (sfm_read_case) Use vars instead of var_hash.
1015 Second problem: we're confused about when we actually have very
1016 long strings, causing us to choose incorrectly between slow path
1017 and fast path in sfm_read_case.
1019 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1020 have very long strings, not when we have long variable names,
1021 which is an unrelated feature.
1023 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1025 * variable.h: Move var_set and variable parsing declarations to
1026 new header, src/language/lexer/variable-parser.h. Modified lots
1027 of files to include the new header.
1029 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1031 * value-labels.c (value_to_string): When there's no value label,
1032 format the variable according to its print format, instead of
1033 always effectively using A or F format.
1035 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1037 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1040 * format.c: Removed tortological assertion.
1042 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1044 Reform string library.
1046 * file-name.c (fn_interp_vars): Change interface to take a
1047 substring as input. Updated all users.
1049 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1051 * format.c (measure_is_valid): Really return false when m >=
1054 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1056 Implement random access to casefiles, for use in GUI.
1058 * casefile.c: (struct casereader) Add `random', `file_ofs',
1059 `buffer_ofs' members.
1060 (casefile_get_random_reader) New function.
1061 (read_open_file) Break part into new function
1062 seek_and_fill_buffer().
1063 (fill_buffer) Update buffer_ofs, file_ofs.
1064 (casereader_seek) New function.
1066 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1068 * settings.c: Added call to i18n{done, init}.
1070 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1072 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1075 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1077 * casefile.c: Convert many uses of `int' to `bool'.
1079 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1081 * transformations.c (trns_chain_destroy): Destroy chain's trns
1082 member, to fix memory leak.
1084 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1086 * storage-stream.c (storage_source_decapsulate): Destroy case
1087 source to fix memory leak.
1089 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1091 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1092 case passed as argument instead of initializing the argument as a
1093 case. Fixes memory leak that showed up in
1094 tests/command/aggregate.sh with scratch files.
1096 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1098 * procedure.c (proc_done): Destroy default_dict, to fix memory
1101 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1103 Simplify procedure_with_splits().
1105 * procedure.c (struct split_aux_data): Removed case_count member.
1106 (procedure_with_splits) Don't initialize case_count.
1107 (split_procedure_case_func) Check whether prev_case is null
1108 instead of case_count.
1109 (split_procedure_end_func) Ditto.
1111 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1113 * case.c (case_move): Do nothing if dst and src are the same
1115 (case_try_create) Merge two similar cases.
1116 (case_copy) Unshare only if data must be actually copied.
1118 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1120 * data-in.c data-out.c dictionary.c sys-file-reader.c
1121 sys-file-writer.c variable.c variable.h: Reworked very long string
1122 support for better encapsulation.
1124 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1126 * value-labels.c (val_labs_can_set_width): New function.
1127 (val_labs_set_width) Clear labels if increasing width to long
1129 (val_labs_destroy) Remove unneeded test for null.
1131 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1133 * value-labels.h: Remove unneeded dependency on variable.h.
1135 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1137 Get rid of `char *c' member in union value, for cleanliness.
1139 * value.h: (union value) Remove `c' member.
1141 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1143 Make dictionary compacting functions a little more general.
1145 * sys-file-writer.c (sfm_open_writer): Use
1146 dict_compacting_would_change().
1147 (does_dict_need_translation) Removed.
1149 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1151 Make dictionary compacting functions a little more general.
1153 * dictionary.c (dict_needs_compaction): Rename
1154 dict_compacting_would_shrink(). Update all callers.
1155 (dict_compacting_would_change) New function.
1157 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1159 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1160 inverted return value (!).
1162 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1164 Continue reforming procedure execution.
1166 * procedure.c: Search and replace "vfm" by "proc". Notably:
1167 (static var vfm_source) Rename proc_source. Update all
1169 (static var vfm_sink) Rename proc_sink. Update all references.
1171 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1173 Continue reforming procedure execution. In this phase, remove
1174 PROCESS IF, which was deprecated anyway and can be easily
1175 simulated with TEMPORARY followed by SELECT IF.
1177 * procedure.c: (open_active_file) Don't call
1178 add_process_if_trns().
1179 (discard_variables) Get rid of redundant call to
1180 proc_cancel_all_transformations().
1181 (add_process_if_trns) Removed.
1182 (process_if_trns_proc) Removed.
1183 (process_if_trns_free) Removed.
1185 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1187 Continue reforming procedure execution. In this phase, add
1188 `const' to the case passed to procedure()'s callback.
1190 Updated all users of procedure() as well.
1192 * procedure.c: (struct write_case_data) Add "const" to ccase
1193 parameter for case_func member.
1194 (procedure) Add "const" to ccase parameter for proc_func
1196 (multipass_case_func) Make ccase parameter const.
1197 (internal_procedure) Add "const" to ccase parameter for case_func
1199 (split_procedure_case_func) Make ccase parameter const.
1200 (multipass_split_case_func) Make ccase parameter const.
1202 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1204 Continue reforming procedure execution. In this phase, get rid of
1205 the output code for SPLIT FILE groups in procedure.c, which really
1206 shouldn't be doing any output. Move it into the individual
1207 procedures instead. This also adds some flexibility.
1209 Updated many users of procedure_with_splits() and
1210 multipass_procedure_with_splits() to call
1211 output_split_file_values() and to deal with increased use of
1214 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1215 parameter to begin_func member.
1216 (procedure_with_splits) Add "const struct ccase *" parameter to
1217 begin_func parameter. Make ccase parameter const in proc_func
1219 (split_procedure_case_func) Don't dump split file group. Pass
1221 (dump_splits) Moved to language/dictionary/split-file.c as
1222 output_split_file_values().
1223 (struct multipass_split_aux_data) Add "const struct ccase *"
1224 parameter to split_func member.
1225 (multipass_procedure_with_splits) Add "const struct ccase *"
1226 parameter to split_func parameter.
1227 (multipass_split_case_func) Save new SPLIT FILE case before
1229 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1231 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1233 Continue reforming procedure execution. Change
1234 internal_procedure() so that it calls open_active_file() and
1235 close_active_file(), which isolates most of the actual procedure
1238 * procedure.c: (struct write_case_data) Rename `proc_func' member
1239 to `case_func' and update all references.
1240 (procedure) Rewrite as one-line wrapper around
1241 internal_procedure().
1242 (struct multipass_aux_data) New.
1243 (multipass_callback) Renamed multipass_case_func(). Use struct
1244 multipass_aux_data as auxiliary data.
1245 (multipass_end_func) New function.
1246 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1247 that uses multipass_case_func, multipass_end_func.
1248 (internal_procedure) Add `end_func' argument. Move optimization
1249 of trivial case in here. Move call to open_active_file() and
1250 close_active_file() in here. Now assert that vfm_source is
1252 (procedure_with_splits_callback) Rename
1253 split_procedure_case_func().
1254 (split_procedure_end_func) New function.
1255 (multipass_split_callback) Rename multipass_split_case_func.
1256 (multipass_split_end_func) New function.
1257 (discard_variables) No need to test for nonnull vfm_source.
1259 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1261 Continue reforming procedure execution. Get rid of unused member.
1263 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1265 (write_case) Don't increment cases_analyzed.
1267 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1269 Continue reforming procedure execution. In this phase, move
1270 procedure.c and procedure.h from src to src/data. Update
1271 makefiles and #includes accordingly.
1273 * procedure.c: Moved here from src/.
1275 * procedure.h: Moved here from src/.
1277 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1279 Continue reforming procedure execution. In this phase, get rid of
1280 many global variables, consolidating procedure execution in
1281 procedure.c. Encapsulate transformations in new "struct
1282 trns_chain". Also, change implementation of N OF CASES, FILTER,
1283 and PROCESS IF from special cases to transformations.
1285 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1288 * dictionary.c: (global variable default_dict) Move to
1291 * variable.h: (TRNS_*) Move to transformations.h.
1292 (struct transformation) Move to transformations.c.
1294 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1296 * sys-file-reader.c: Fixed invalid read problems.
1298 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1300 * storage-stream.c: Add missing function comments.
1302 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1304 Continue reforming procedure execution. In this phase, add some
1305 new, needed functionality to storage-stream.
1307 * storage-stream.c: (storage_source_decapsulate) New function.
1309 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1311 * variable.c (width_to_bytes): Declarations must precede
1312 statements for C90 compliance.
1314 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1316 * data-out.c, data-in.c, variable.c, variable.h: New functions
1317 copy_mangle and copy_demangle for reading/writing cases; emulates the
1318 way SPSS deals with strings > 255 bytes.
1320 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1321 subtype 14 needed for strings longer than 255 bytes.
1323 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1324 instead of literal values. Also fixed some constness issues.
1326 * format.h: Constness
1328 * sfm-private.h: Renamed the case_size identifier, since I discovered
1329 that SPSS's respect for this variable is very nominal.
1331 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1333 Change case limit type from int to size_t.
1335 * dictionary.c: (struct dictionary) Change type of case_limit
1337 (dict_get_case_limit) Change return type.
1338 (dict_set_case_limit) Change parameter type.
1340 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1342 * variable.h: (struct variable) Rename `reinit' member as `leave'
1343 and invert sense. Fix up all references.
1345 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1347 Continue reforming procedure execution. In this phase, break
1348 procedure.c into multiple files.
1350 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1352 * case-sink.c: New file.
1354 * case-sink.h: New file.
1356 * case-source.c: New file.
1358 * case-source.h: New file.
1360 * storage-stream.c: New file.
1362 * storage-stream.h: New file.
1364 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1366 * variable.h: (struct variable) Remove `init' member and all
1367 references to it from other files. It was initialized in several
1368 places, but nothing really ever used it for anything worthwhile.
1369 Thanks to Jason Stover for pointing out how confusing this
1372 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1374 Continue reforming error message support. In this phase, get rid
1375 of message "titles" and put the message text in `struct error'.
1376 Now `struct error' encapsulates a message more properly.
1378 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1379 Format message ourselves.
1381 * data-in.c: (vdls_error) Ditto.
1383 * por-file-reader.c: (error) Ditto.
1385 * sys-file-reader.c: (corrupt_msg) Ditto.
1387 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1389 GNU standards require "file name" instead of "filename" in
1390 documentation. It's nice for our code to follow the convention
1393 * casefile.c: (struct casefile) Rename `filename' member to
1394 `file_name'. Updated all references.
1396 * file-name.c: [!unix] (struct file_identity) Rename
1397 normalized_filename member to normalized_file_name. Updated all
1400 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1402 We don't really support anything but Unix-like environments well,
1403 so we might as well de-obfuscate by writing directory and path
1404 separators explicitly.
1406 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1408 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1409 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1411 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1414 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1416 GNU standards require "file name" instead of "filename" in
1417 documentation. It's nice for our code to follow the convention
1420 * filename.c: Rename to file-name.c.
1422 * filename.h: Rename to file-name.h. Update all inclusions.
1423 Update header guards.
1425 * automake.mk: Update file names.
1427 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1429 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1431 (fn_basename) Removed (dead code).
1432 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1433 (fn_special_p) Renamed fn_is_special(), all references updated.
1434 (fn_exists_p) Renamed fn_exists(), all references updated.
1436 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1438 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1439 Also, now it only tilde-expands file names, not paths.
1440 (fn_search_path) Tilde-expand one directory at a time.
1442 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1444 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1445 get rid of non-Unixlike version of the code, which has probably
1447 (fn_prepend_dir) Removed (dead code).
1449 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1450 (macro PATH_SEPARATOR_STRING) New.
1451 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1453 Continue reforming error message support. In this phase, we get
1454 rid of VM() and the other msg() support for "verbosity", replacing
1455 it by a new function verbose_msg().
1457 * filename.c: (fn_search_path) Use verbose_msg() instead of
1460 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1462 * sfm-private.h: Get rid of #defines after #error, which makes no
1465 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1467 Get rid of our own int32 type in favor of the standard int32_t
1470 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1473 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1475 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1477 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1479 Remove ill-considered file routines that are no longer used.
1481 * filename.c: (fn_open_ext) Removed.
1482 (fn_close_ext) Removed.
1484 * filename.h: (struct file_ext) Removed.
1486 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1488 * variable.c (var_is_valid_name): Move declarations before code
1491 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1493 * filename.ch (fn_interp_vars): Fixed small buglet.
1495 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1497 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1498 so as to modify the string inline. Thus makeing it easier to
1499 destroy the results when no longer needed.
1501 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1503 * category.c (cat_stored_values_destroy): Fixed memory leak.
1505 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1507 Add some missing frees. Thanks to John Darrington for reporting
1510 * any-writer.c (any_writer_close): Free writer.
1512 * any-reader.c (any_reader_close): Free reader.
1514 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1516 * por-file-reader.c: (error) Mark as NO_RETURN.
1518 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1520 * settings.c: Changed default value of scompress to true.
1522 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1524 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1526 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1529 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1530 here from pref.h.orig.
1532 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1534 * sys-file-reader.c: Fixed bug reading compressed files.
1536 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1538 * Numerous renames. See src/ChangeLog for details.
1540 * Moved files from src directory