1 2007-06-06 Ben Pfaff <blp@gnu.org>
3 sparse_cases data structure that augments a sparse_array of cases
4 with the ability to dump cases to disk if we get too many cases in
7 * automake.mk: Add new files.
9 * sparse-cases.c: New file.
11 * sparse-cases.h: New file.
13 2007-06-06 Ben Pfaff <blp@gnu.org>
15 Adds a low-level on-disk case array data structure.
17 * automake.mk: Add new files.
19 * case-tmpfile.c: New file.
21 * case-tmpfile.h: New file.
23 2007-06-06 Ben Pfaff <blp@gnu.org>
25 In a couple of places we calculate the maximum number of cases to
26 keep in memory based on the user-defined workspace. Enable
27 centralizing the calculation through a new function.
29 * settings.c (get_workspace_cases): New function.
31 2007-06-06 Ben Pfaff <blp@gnu.org>
33 The casenumber type is defined in transformations.h, but case.h is
34 a more sensible place. Move it.
36 * case.h (CASENUMBER_MAX): New macro.
37 (typedef casenumber): Move here, from transformations.h.
39 2007-06-03 Ben Pfaff <blp@gnu.org>
41 Slightly generalize case_to_values and case_from_values functions.
43 * case.c (case_to_values): Rename case_copy_out, change interface.
44 (case_from_values): Rename case_copy_in, change interface.
46 * fastfile.c (fastfilereader_get_next_case): Update caller.
47 (write_case_to_disk): Ditto.
49 2007-06-02 Ben Pfaff <blp@gnu.org>
51 Clean up after a forgotten part of patch #5829.
53 * casedeque.h: Remove unused file.
55 * automake.mk: Remove casedeque.h from sources.
57 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
59 * category.c: Removed redundant #include
61 2007-05-06 Ben Pfaff <blp@gnu.org>
63 Abstract the documents within a dictionary a little better.
64 Thanks to John Darrington for suggestion, initial version, and
67 * dictionary.c (struct dictionary): Change `documents' member from
68 char * to struct string.
69 (dict_clear): Destroy struct string.
70 (dict_get_documents): Convert struct string to char *.
71 (dict_set_documents): Set struct string. Pad to 80-character
73 (dict_clear_documents): New function.
74 (dict_add_document_line): New function.
75 (dict_get_document_line_cnt): New function.
76 (dict_get_document_line): New function.
78 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
80 * sys-file-reader.c (read_documents): Use new document functions.
82 2007-04-19 John Darrington <john@darrington.wattle.id.au>
84 * sys-file-reader.c: When reading a system file which has no
85 long name table, automatically create one where the long names
86 are the lower case versions of the short names.
88 2007-04-22 Ben Pfaff <blp@gnu.org>
90 * dictionary.c (dict_set_split_vars): dict_destroy expects that
91 dict_clear will free most data related to the dictionary.
92 dict_clear does a decent job, except that dict_set_split_vars on
93 some systems won't actually free the dict's "split" member.
94 Instead, it'll allocate a 1-byte region. Fix this.
96 * value.c (value_copy): New function.
97 (value_set_missing): Ditto.
99 2007-04-22 John Darrington <john@darrington.wattle.id.au>
101 * Deleted existing category.h and moved cat-routines.h into
102 category.h Encapsulated struct cat_vals better.
104 2007-04-19 John Darrington <john@darrington.wattle.id.au>
106 * sys-file-reader.c: When reading a system file which has no
107 long name table, automatically create one where the long names
108 are the lower case versions of the short names.
110 2007-04-16 John Darrington <john@darrington.wattle.id.au>
112 * sys-file-reader.c: Some versions of Other Software seem to
113 produce system files with string variables' measure set to
114 zero. We'll assume these are supposed to be nominal variables.
116 2007-03-30 Ben Pfaff <blp@gnu.org>
118 * procedure.c: Adapt to new deque data structure.
120 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
121 Ben Pfaff <blp@gnu.org>
123 * file-name.c: Mingw compatibility fixes.
124 (fn_search_path): Use ISSLASH instead of comparing against '/'
126 (fn_dir_name): Use dir_name from gnulib.
127 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
128 (fn_get_identity): Use GetFullPathName instead of canonicalize
129 from gnulib, because the latter does not fully support
130 Windows-style path names. Use this implementation based on the
131 detected presence of Windows instead of the absence of Unix, since
132 the new implementation is Windows-specific.
133 (fn_compare_file_identities): In Windows implementation, compare
134 names case-insensitively.
136 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
138 * make-file.c: Don't include mkstemp.h, because gnulib now causes
139 <stdlib.h> to have the same effect.
141 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
143 * por-file-reader.c: Add missing _() around messages.
145 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
147 * make-file.c: Include "mkstemp.h", without which linking on
150 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
152 Reduce platform dependence.
154 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
155 Everywhere we using this, we really should have just depended on
156 the shell to expand tildes.
157 (fn_search_path): Simplify, given that we don't do tilde expansion
159 (fn_normalize): Removed. Caller changed to use the canonicalize
161 (fn_get_cwd): Removed. Only user was fn_normalize.
162 (fn_is_absolute): Really only test for absolute names.
163 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
165 (fn_readlink): Removed, as it was only used fn_normalize.
166 (fn_exists): Assume the stat function is available; gnulib does.
167 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
169 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
171 * dictionary.c (dict_create_vector_assert): New function.
173 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
175 * file-name.c (fn_normalize): Correct name of function
176 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
177 for pointing this out.
179 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
181 We are using a single member in struct file_handle, the "name"
182 field, for more than one purpose. When it begins with '"', it's a
183 file name; otherwise, it's a token that can be used to identify
184 it. When that assertion fires, it's because we searched for the
185 name case-sensitively as a file name (so that there was no match),
186 and then we try to insert it case-insensitively as a token, which
187 fails because duplicates aren't allowed.
189 Solution: break the two purposes into two separate fields. This
190 fixes the problem and likely makes the code easier to read too.
192 Fixes bug #18922. Thanks to John Darrington for bug report and
195 * file-handle-def.c (struct file_handle): New `id' member.
196 (fh_from_name): Rename fh_from_id. Update all callers.
197 (create_handle): New `id' parameter. Update all callers.
198 (fh_create_file): Ditto.
199 (fh_get_id): New function.
201 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
203 * case.c (case_is_null): Change return type to bool.
205 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
209 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
210 reference counting to share data. This makes it easy for
211 valgrind, etc. to find accesses to cases that have been destroyed
212 but have been kept around by another user's ref-count. This often
213 happens when the data set is small enough to find in memory; if a
214 bigger data set that would overflow to disk were used, then data
215 corruption would occur.
217 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
221 * case.c (case_unshare): Make it check internally whether the
222 ref_cnt is greater than 1, so that the callers don't have to.
223 Update callers not to check.
225 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
227 Before, I was thinking that I might want to get rid of reference
228 counting at some point. Now, I'm pretty sure that it's here to
229 stay. Thus, because we have to store the value_cnt anyway for
230 reference-counted cases, we might as well expose it to users.
232 * case.c (case_get_value_cnt): New function.
233 (case_resize): Drop OLD_CNT argument. Update all callers. Only
234 resize case if its size actually changed.
236 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
237 instead of peeking inside struct case directly.
238 (casefile_append): Ditto.
240 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
242 Get rid of the inlines for the case functions, which made the
243 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
244 the inlines didn't speed up "make check" at all, which is not a
245 perfect benchmark but seems indicative.)
247 * case.c: Remove #ifdef DEBUGGING...#endif around many function
248 definitions. Remove some assertions on nonnull pointers that were
249 redundant with a pointer dereference soon after in the function.
251 (struct case_data): Move definition here from case.h.
255 (case_data_wr): Ditto.
257 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
259 * automake.mk: Add casedeque.h to sources.
261 * casedeque.h: New file.
263 * procedure.c: (struct dataset) Change lag_count, lag_head,
264 lag_queue member into single struct casedeque member. Update all
265 users to use the casedeque instead.
268 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
270 * procedure.c: Simplify lagged cases interface. Updated all
271 clients--well, the only client--to use the simplified interface.
272 (dataset_n_lag) Removed.
273 (dataset_set_n_lag) Removed.
274 (dataset_need_lag) New function.
276 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
278 * dictionary.c procedure.c: More changes to ensure that callbacks occur
279 whenever appropriate, but only when the dataset/dictionary is in a
282 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
284 * dictionary.c dictionary.h : Added callbacks for change of filter and
285 split variables. Refactored some code to ensure that callbacks get
286 invoked when appropriate.
288 * procedure.c (proc_cancel_temporary_transformations): Make sure that
289 replace_dict callback occurs when permanent_dict replaces the current
292 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
294 * dictionary.c dictionary.h : Added callback for when the weight
295 variable of a dictionary changes.
297 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
299 * dictionary.c dictionary.h : Added replace_source and replace_dict
300 callbacks, and functions to deal with them.
302 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
304 Simplify missing value handling.
306 * missing-values.h (enum mv_class): New type.
307 (enum mv_type): Moved definition into missing-values.c and renamed
308 each MV_* to MVT_*, to distinguish them from the exposed mv_class
309 enums. Updated all uses.
310 (struct missing_values): Changed type of `type' from `enum
311 mv_type' to `int' because the definition is no longer exposed.
313 * missing-values.c (mv_is_value_missing): Add new enum mv_class
314 parameter. Update all callers.
315 (mv_is_num_missing): Ditto.
316 (mv_is_str_missing): Ditto.
317 (mv_is_value_user_missing): Removed. Changed callers to use
319 (mv_is_num_user_missing): Removed. Changed callers to use
321 (mv_is_str_user_missing): Removed. Changed callers to use
323 (mv_is_value_system_missing): Removed. Changed callers to use
325 (mv_set_type): Removed. Changed callers to use mv_clear.
326 (mv_clear): New function.
328 * variable.c (var_is_value_missing): Add new enum mv_class
329 parameter. Update all callers.
330 (var_is_num_missing): Ditto.
331 (var_is_str_missing): Ditto.
332 (var_is_value_user_missing): Removed. Changed callers to use
333 var_is_value_missing.
334 (var_is_num_user_missing): Removed. Changed callers to use
336 (var_is_str_user_missing): Removed. Changed callers to use
338 (var_is_value_system_missing): Removed. Changed callers to use
339 var_is_value_missing.
341 * casefilter.c (struct casefilter): Use enum mv_class in place of
343 (casefilter_variable_missing): Adapt to new member.
344 (casefilter_create): Change signature to take enum mv_class,
347 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
349 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
351 * case-sink.c case-sink.h procedure.c procedure.h
352 storage-stream.c: Now uses the factory.
354 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
356 Make it possible to pull cases from the active file with a
357 function call, instead of requiring indirection through a callback
360 * case-source.h (struct case_source_class): Change ->read function
361 to return a single case, instead of calling a callback function
362 for each case. Change ->destroy function to return an error
365 * case-source.c (free_case_source): Pass along the value returned
366 by the case_source ->destroy function.
368 * procedure.c (struct write_case_data): Removed.
369 (struct dataset): Added some members to track procedure state.
370 (procedure): Optimize the trivial case at this level.
371 (internal_procedure): Re-implement in terms of proc_open,
372 proc_read, proc_close.
373 (proc_open) New function.
374 (proc_read) New function.
375 (proc_close) New function.
376 (write_case) Moved into proc_read.
377 (close_active_file) Moved closing of data source into proc_close.
379 * storage-source.c: Rewrote to conform with modified
380 case_source_class interface.
382 * transformations.c (trns_chain_execute): Added argument to allow
383 starting execution from an arbitrary transformation. Updated
386 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
388 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
390 * sys-file-reader.c (read_display_parameters): Don't assume that
391 MEASURE_* and ALIGN_* have the same values found in system files.
393 * sys-file-writer.c (write_variable_display_parameters): Ditto.
395 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
396 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
397 the value of n_MEASURES, which was off by 1 (at least from my
400 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
402 * dictionary.c dictionary.h vardict.h variable.c: Added optional
403 callbacks which are invoked when the dictionary or its
404 variables are changed.
406 * missing-values.c missing-values.h value-labels.c: Tidied up
407 consistency checks, and made some of them return false
408 instead of assert-failing.
410 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
412 * calendar.c (calendar_days_in_month): New function.
414 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
416 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
417 the value label's width.
419 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
421 * sfm-private.h: Move contents into sys-file-writer.c, which is
422 the only remaining user. Removed Borland C++-specific directives.
424 * sys-file-reader.c: Clean up and rewrite entire file. The
425 rewritten version is simpler and better abstracted, and should be
426 easier to maintain and extend. It avoids using structures to read
427 file data, which is prone to padding variations among compilers.
428 It should also handle non-IEEE 754 system files, although I
429 haven't been able to find any. It has been tested against many
430 .sav files obtained from the Web and found to produce the same
431 results as the earlier version of the code, or in some cases
432 improved results. It is more tolerant of format variations found
435 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
436 member, putting an enum integer_format in its place. New member
437 `float_format'. Changed `compressed' member to type bool.
439 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
441 * dictionary.c (dict_delete_consecutive_vars): New function.
443 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
445 * file-name.c (fn_search_path): Remove prefix arg that was unused
446 by any caller. Updated all callers.
448 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
450 * format.c (fmt_dollar_template): Use user's decimal point
451 character. Add assertion.
453 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
455 * format.c (fmt_dollar_template): New function, based on
456 dollar_format_template from var-type-dialog.c.
458 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
460 * data-out.c (output_scientific): Fix bad assumption that "buf" is
463 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
465 Finish converting struct variable to an opaque type. In this
466 phase, we add remaining setter and getter functions, convert the
467 remaining PSPP code to use them, and do a bunch of cleanup. The
468 resulting changes are pervasive but mostly trivial, and only the
469 notable changes are logged.
471 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
474 * case.c (case_data): Renamed case_data_idx.
475 (case_num): Renamed case_num_idx.
476 (case_str): Renamed case_str_idx.
477 (case_data_rw): Renamed case_data_rw_idx.
479 * case.h (case_data): New function with old name and an interface
480 that takes a variable instead of an index, which is easier to
481 use. Updated all callers to use the new interface, or to use the
482 new *_idx function (see above).
485 (case_data_rw): Ditto.
487 * category.c (cat_stored_values_destroy): Changed interface to
488 take a struct cat_vals * instead of a struct variable *.
490 * dictionary.c (dict_clone): Use new vector_clone function.
491 (dict_clear) Use new var_destroy function.
492 (add_var) New function.
493 (dict_create_var) Rewrite in terms of dict_create_var_assert.
494 (dict_create_var_assert) Rewrite in terms of add_var.
495 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
496 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
497 (dict_lookup_var) Use new var_create, var_destroy functions.
498 (dict_contains_var) Rewrite in terms of new vardict functionality.
499 (set_var_dict_index) New function.
500 (set_var_case_index) New function.
501 (reindex_vars) New function.
502 (dict_delete_var) Rewrite in terms of new vardict functionality.
503 (dict_reorder_var) Ditto.
504 (dict_reorder_vars) Ditto.
505 (rename_var) New function.
506 (dict_rename_var) Use rename_var.
507 (dict_rename_vars) Use pool to simplify code. Use rename_var.
508 (dict_get_compacted_idx_to_fv) Rename
509 dict_get_compacted_dict_index_to_case_index, update callers.
510 (dict_create_vector) Use new vector_create function.
511 (dict_clear_vectors) Use new vector_destroy function.
512 (set_var_short_name_suffix) Move here from variable.c, renamed
513 from var_set_short_name_suffix, make static, update caller.
515 * sys-file-private.c: New file.
516 (sfm_width_to_bytes) Moved here from variable.c, renamed from
517 width_to_bytes, update callers.
519 * sys-file-private.h: New file. Later it will supplant
520 sfm-private.h; for now it supplements it.
521 (macro MIN_VERY_LONG_STRING) New macro.
522 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
524 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
525 MAX_LONG_STRING was used before.
527 * sys-file-writer.c: Ditto.
529 * value-labels.c: Change the paradigm here to be that a null
530 pointer is OK for a struct val_labs * in most cases; it just
531 represents an empty set of value labels.
532 (val_labs_copy) A copy of a null set is a null set.
533 (val_labs_count) A null set has 0 labels.
534 (val_labs_replace) Change return type to void. Rewrite for
536 (val_labs_find) A null set does not contain the value.
537 (value_to_string) Moved to variable.c, renamed var_get_value_name,
538 transposed argument order, updated all callers.
541 (value_dup) Moved here from variable.c.
542 (compare_values) Ditto.
545 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
546 (macro MAX_LONG_STRING) Removed, because it was only interesting
547 for system files, not for general code.
548 (macro MAX_VERY_LONG_STRING) Ditto.
549 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
550 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
552 * vardict.h: New file, for an interface between variables and
555 * variable.c: A lot of functions were moved around, for better
557 (struct variable) Move definition here, from variable.h.
558 (var_type_adj) Removed--makes i18n hard.
559 (var_type_noun) Ditto.
560 (var_create) New function.
561 (var_clone) New function.
562 (var_destroy) New function.
563 (var_set_name) Assert that variable is not in a dictionary.
564 (compare_var_names) Rename compare_vars_by_name and fix a couple
565 of callers who thought the args were strings.
566 (hash_var_name) Rename hash_var_by_name.
567 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
568 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
569 (var_is_very_long_string) Removed, because it was only interesting
571 (var_set_missing_values) Allow the argument to be the wrong width,
572 as long as we can resize it. Simplify callers who were doing the
574 (var_get_value_labels) New function.
575 (var_has_value_labels) New function.
576 (var_set_value_labels) New function.
577 (alloc_value_labels) New function.
578 (var_add_value_label) New function.
579 (var_replace_value_label) New function.
580 (var_clear_value_labels) New function.
581 (var_lookup_value_label) New function.
582 (var_get_value_name) Moved here from variable.c, renamed from
583 var_get_value_name, transposed argument order, updated all
585 (var_to_string) Moved here, from variable-label.c.
586 (var_set_leave) New function.
587 (var_get_leave) New function.
588 (var_must_leave) New function.
589 (var_set_short_name_suffix) Moved to dictionary.c, renamed
590 set_var_short_name_suffix.
591 (var_get_dict_index) New function.
592 (var_get_case_index) New function.
593 (var_get_obs_vals) New function.
594 (var_set_obs_vals) New function.
595 (var_has_obs_vals) New function.
596 (var_get_vardict) New function.
597 (var_set_vardict) New function.
598 (var_has_vardict) New function.
599 (var_clear_vardict) New function.
600 (value_dup) Moved to value.c.
601 (compare_values) Ditto.
604 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
605 (enum ALPHA) Rename VAR_STRING, update all users.
607 * vector.c: New file.
608 (struct vector) Moved here, from variable.h.
609 (check_widths) New function.
610 (vector_create) New function.
611 (vector_clone) New function.
612 (vector_destroy) New function.
613 (vector_get_name) New function.
614 (vector_get_var) New function.
615 (vector_get_var_cnt) New function.
616 (compare_vector_ptrs_by_name) New function.
618 * vector.h: New file.
620 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
622 * casefilter.c (casefilter_variable_missing): Avoided comparision of
623 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
626 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
628 * value-labels.c (destroy_atoms): New function.
629 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
631 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
633 Thanks to Jason Stover for pointing out this problem.
635 * data-out.c (output_number): Use gsl_finite from GSL, which is
636 portable, instead of isfinite, which is not.
639 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
641 * variable.c variable.h (value_dup): New function.
643 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
645 Start converting struct variable to an opaque type. In this
646 phase, we add a bunch of setter and getter functions and convert
647 most of the PSPP code to use them. The resulting changes are
648 pervasive but mostly trivial, and only the notable changes are
651 * format.c (fmt_equal): New function.
653 * variable.c (var_type_is_valid): New function.
654 (measure_is_valid) Moved here, from format.c.
655 (alignment_is_valid) Moved here, from format.c.
656 (var_get_name) New function.
657 (var_set_name) New function.
658 (width_to_type) New function.
659 (var_get_type) New function.
660 (var_get_width) New function.
661 (var_set_width) New function.
662 (var_is_numeric) New function.
663 (var_is_alpha) New function.
664 (var_is_short_string) New function.
665 (var_is_long_string) New function.
666 (var_is_very_long_string) New function.
667 (var_get_missing_values) New function.
668 (var_set_missing_values) New function.
669 (var_clear_missing_values) New function.
670 (var_has_missing_values) New function.
671 (var_is_value_missing) New function.
672 (var_is_num_missing) New function.
673 (var_is_str_missing) New function.
674 (var_is_value_user_missing) New function.
675 (var_is_num_user_missing) New function.
676 (var_is_str_user_missing) New function.
677 (var_is_value_system_missing) New function.
678 (var_get_print_format) New function.
679 (var_set_print_format) New function.
680 (var_get_write_format) New function.
681 (var_set_write_format) New function.
682 (var_set_both_formats) New function.
683 (var_get_label) New function.
684 (var_set_label) New function.
685 (var_clear_label) New function.
686 (var_has_label) New function.
687 (var_get_measure) New function.
688 (var_set_measure) New function.
689 (var_get_display_width) New function.
690 (var_set_display_width) New function.
691 (var_get_alignment) New function.
692 (var_set_alignment) New function.
693 (var_get_value_cnt) New function.
694 (var_get_leave) New function.
695 (var_get_short_name) New function.
697 * variable.h: (struct variable) Removed "type" and "nv" members;
698 they are now computed from "width" where needed.
700 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
702 * missing-values.c (mv_resize): Don't write beyond end of the
703 allocated buffer when resizing a long string.
705 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
707 Clean up identifier code: don't require identifier enumerations to
708 be in a particular order; make better use of string library;
709 expose less of the internals.
711 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
712 change interface. Updated all callers.
713 (lex_id_match) Change interface to use struct substring, update
715 (lex_id_match_len) Removed. Update callers to use lex_id_match.
716 (global array keywords[]) Make static, change form. Update all
717 users to use lex_id_name instead.
718 (lex_is_keyword) New function.
719 (lex_id_to_token) Change interface to use struct substring, update
721 (lex_id_name) New function.
723 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
724 lex_is_keyword instead.
725 (T_LAST_KEYWORD) Removed.
726 (T_N_KEYWORDS) Removed.
728 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
730 * format.c: (fmt_date_template) Distinguish characters for which a
731 space is output and any date delimiter is allowed on input, from
732 those for which a space is output and only a space is allowed on
733 input. The former is represented by X, the latter by a space.
734 Also, drop distinction between h and H, changing the former to the
737 * data-in.c: Completely rewrite internals to conform to SPSS input
738 formats as closely as possible.
739 (data_in) Changed external interface by replacing the structure
740 that was used as a single argument by a set of arguments. Updated
742 (data_in_finite_line) Removed. Converted all callers to use plain
744 (data_in_get_integer_format) New function.
745 (data_in_set_integer_format) New function.
746 (data_in_get_float_format) New function.
747 (data_in_set_float_format) New function.
749 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
750 (struct data_in) Removed.
752 * data-out.c: (output_date) Drop each component from the input as
753 it is output, to allow us to drop the distinction between h (a
754 count of hours) and H (the hour of day) template characters.
755 Also, handle new X template character.
756 (output_scientific) Follow more rational rule on when to drop
757 fraction introduced between SPSS 13 and 15. Updated test case to
760 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
762 Fix buffer overflow reported by John Darrington.
764 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
765 realize that DIGITS is a count of nibbles, not of bytes.
767 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
769 * calendar.c (calendar_offset_to_gregorian) Also return the
770 year-of-day. Change callers to new interface.
772 * data-out.c: Completely rewrite internals to conform to SPSS
773 output formats as completely as possible.
774 (data_out) Change interface to put input parameters before output
775 parameters, for consistency with the style I now prefer. Update
777 (data_out_get_integer_format) New public function.
778 (data_out_set_integer_format) New public function.
779 (data_out_get_float_format) New public function.
780 (data_out_set_float_format) New public function.
782 * data-out.h: New file. Move prototype for data_out here, from
785 * format.c: (fmt_step_width) Use equality comparison instead of
786 bitwise and, for clarity.
787 (fmt_is_string) Ditto.
788 (fmt_input_to_output) Fix categories that are translated to F
791 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
793 * casefilter.c casefilter.h (new files), casefile.c casefile.h
794 casefile-private.h: Added casefilter to assist commands with missing
797 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
799 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
801 * settings.c: (route_errors_to_terminal) New variable.
802 (route_errors_to_listing) New variable.
803 (get_error_routing_to_terminal) New function.
804 (set_error_routing_to_terminal) New function.
805 (get_error_routing_to_listing) New function.
806 (set_error_routing_to_listing) New function.
808 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
810 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
812 * format.c: Completely rewrite, to achieve better abstraction.
813 Rewrite all references to formats in other files.
815 * format.def: Rewrite and reorganize.
817 * settings.c: Move everything related to custom currency formats
818 into format.[ch], changing them in form, so as to group related
819 code and definitions better. Changed all references to use the
821 (static var decimal) Removed.
822 (static var grouping) Removed.
823 (static var cc) Removed.
824 (get_decimal) Removed.
825 (set_decimal) Removed.
826 (get_grouping) Removed.
827 (set_grouping) Removed.
831 * settings.h: (macro CC_CNT) Removed.
832 (macro CC_WIDTH) Removed.
833 (struct custom_currency) Removed.
835 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
837 * data-in.c (data_in): Use switch statement instead of table, to
838 avoid dependence on the order of the FMT_* enums.
840 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
842 * data-out.c: (num_to_string) Removed, because it was dead code.
844 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
846 * data-in.c (parse_trailer): Fix error message.
848 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
850 * format.c (fmt_is_binary): New function.
852 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
854 * procedure.c procedure.h: Encapsulated the static data into a single
857 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
859 * casefile.c (casereader_read_xfer): Always initialize the case,
860 even on an error condition.
862 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
864 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
865 entire function useless.
867 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
869 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
870 casereader method casereader_clone.
872 * procedure.c pransformations.h: Introduced new type casenum_t
874 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
876 * variable.c: (width_to_bytes) Rephrase code for clarify.
878 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
880 * format.c: (fmt_type_from_string) New function.
881 (fmt_to_string) Include decimals in output if the format has
882 decimals, even if the format type does not. This way, we can
883 accurately reproduce incorrect formats in user output.
884 (check_common_specifier) Make the check for a bad format type an
885 assertion, so we get bug reports if they show up. Fix message.
886 Check for decimal places with a format type that doesn't allow
888 (check_input_specifier) Remove check for FMT_X, which has been
890 (check_output_specifier) Ditto.
892 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
894 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
895 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
896 (enum fmt_parse_flags) Removed.
898 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
900 * casefile.c casefile.h: Converted to an abstract base class.
901 * casefile-private.h fastfile.c fastfile.h: New files.
902 * automake.mk procedure.c scratch-writer.c storage-stream.c
904 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
906 * procedure.c (internal_procedure): Create sink_case with only as
907 many values as the compacted dictionary.
909 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
911 Remove "debugging" code that caused plenty of false positives and
914 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
916 * case.c: Remove all references to `this' member.
918 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
920 Fix link error noted by Jason Stover.
922 * storage-stream.c: Include <assert.h>.
924 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
926 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
927 ALL) and additional underlying system file issues.
929 Thanks to John Darrington for review.
931 First problem: var_hash points to variables not owned by the
932 sys-file-reader, which the caller may free or modify. Use an
933 array of sfm_vars instead, as done earlier (e.g. CVS version
936 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
937 members and remove all code that references it. Add vars, var_cnt
938 members. Remove fix_specials member, which was unused.
939 (struct sfm_var) Remove name member, which was unused.
940 (sfm_close_reader) Free vars member instead of var_hash.
941 (compare_var_shortnames) Removed.
942 (hash_var_shortname) Removed.
943 (sfm_open_reader) Fill out vars array.
944 (compare_var_index) Removed.
945 (sfm_read_case) Use vars instead of var_hash.
947 Second problem: we're confused about when we actually have very
948 long strings, causing us to choose incorrectly between slow path
949 and fast path in sfm_read_case.
951 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
952 have very long strings, not when we have long variable names,
953 which is an unrelated feature.
955 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
957 * variable.h: Move var_set and variable parsing declarations to
958 new header, src/language/lexer/variable-parser.h. Modified lots
959 of files to include the new header.
961 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
963 * value-labels.c (value_to_string): When there's no value label,
964 format the variable according to its print format, instead of
965 always effectively using A or F format.
967 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
969 * casefile.c (casefile_get_random_reader): Nasty hack to get around
972 * format.c: Removed tortological assertion.
974 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
976 Reform string library.
978 * file-name.c (fn_interp_vars): Change interface to take a
979 substring as input. Updated all users.
981 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
983 * format.c (measure_is_valid): Really return false when m >=
986 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
988 Implement random access to casefiles, for use in GUI.
990 * casefile.c: (struct casereader) Add `random', `file_ofs',
991 `buffer_ofs' members.
992 (casefile_get_random_reader) New function.
993 (read_open_file) Break part into new function
994 seek_and_fill_buffer().
995 (fill_buffer) Update buffer_ofs, file_ofs.
996 (casereader_seek) New function.
998 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1000 * settings.c: Added call to i18n{done, init}.
1002 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1004 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1007 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1009 * casefile.c: Convert many uses of `int' to `bool'.
1011 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1013 * transformations.c (trns_chain_destroy): Destroy chain's trns
1014 member, to fix memory leak.
1016 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1018 * storage-stream.c (storage_source_decapsulate): Destroy case
1019 source to fix memory leak.
1021 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1023 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1024 case passed as argument instead of initializing the argument as a
1025 case. Fixes memory leak that showed up in
1026 tests/command/aggregate.sh with scratch files.
1028 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1030 * procedure.c (proc_done): Destroy default_dict, to fix memory
1033 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1035 Simplify procedure_with_splits().
1037 * procedure.c (struct split_aux_data): Removed case_count member.
1038 (procedure_with_splits) Don't initialize case_count.
1039 (split_procedure_case_func) Check whether prev_case is null
1040 instead of case_count.
1041 (split_procedure_end_func) Ditto.
1043 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1045 * case.c (case_move): Do nothing if dst and src are the same
1047 (case_try_create) Merge two similar cases.
1048 (case_copy) Unshare only if data must be actually copied.
1050 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1052 * data-in.c data-out.c dictionary.c sys-file-reader.c
1053 sys-file-writer.c variable.c variable.h: Reworked very long string
1054 support for better encapsulation.
1056 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1058 * value-labels.c (val_labs_can_set_width): New function.
1059 (val_labs_set_width) Clear labels if increasing width to long
1061 (val_labs_destroy) Remove unneeded test for null.
1063 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1065 * value-labels.h: Remove unneeded dependency on variable.h.
1067 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1069 Get rid of `char *c' member in union value, for cleanliness.
1071 * value.h: (union value) Remove `c' member.
1073 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1075 Make dictionary compacting functions a little more general.
1077 * sys-file-writer.c (sfm_open_writer): Use
1078 dict_compacting_would_change().
1079 (does_dict_need_translation) Removed.
1081 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1083 Make dictionary compacting functions a little more general.
1085 * dictionary.c (dict_needs_compaction): Rename
1086 dict_compacting_would_shrink(). Update all callers.
1087 (dict_compacting_would_change) New function.
1089 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1091 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1092 inverted return value (!).
1094 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1096 Continue reforming procedure execution.
1098 * procedure.c: Search and replace "vfm" by "proc". Notably:
1099 (static var vfm_source) Rename proc_source. Update all
1101 (static var vfm_sink) Rename proc_sink. Update all references.
1103 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1105 Continue reforming procedure execution. In this phase, remove
1106 PROCESS IF, which was deprecated anyway and can be easily
1107 simulated with TEMPORARY followed by SELECT IF.
1109 * procedure.c: (open_active_file) Don't call
1110 add_process_if_trns().
1111 (discard_variables) Get rid of redundant call to
1112 proc_cancel_all_transformations().
1113 (add_process_if_trns) Removed.
1114 (process_if_trns_proc) Removed.
1115 (process_if_trns_free) Removed.
1117 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1119 Continue reforming procedure execution. In this phase, add
1120 `const' to the case passed to procedure()'s callback.
1122 Updated all users of procedure() as well.
1124 * procedure.c: (struct write_case_data) Add "const" to ccase
1125 parameter for case_func member.
1126 (procedure) Add "const" to ccase parameter for proc_func
1128 (multipass_case_func) Make ccase parameter const.
1129 (internal_procedure) Add "const" to ccase parameter for case_func
1131 (split_procedure_case_func) Make ccase parameter const.
1132 (multipass_split_case_func) Make ccase parameter const.
1134 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1136 Continue reforming procedure execution. In this phase, get rid of
1137 the output code for SPLIT FILE groups in procedure.c, which really
1138 shouldn't be doing any output. Move it into the individual
1139 procedures instead. This also adds some flexibility.
1141 Updated many users of procedure_with_splits() and
1142 multipass_procedure_with_splits() to call
1143 output_split_file_values() and to deal with increased use of
1146 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1147 parameter to begin_func member.
1148 (procedure_with_splits) Add "const struct ccase *" parameter to
1149 begin_func parameter. Make ccase parameter const in proc_func
1151 (split_procedure_case_func) Don't dump split file group. Pass
1153 (dump_splits) Moved to language/dictionary/split-file.c as
1154 output_split_file_values().
1155 (struct multipass_split_aux_data) Add "const struct ccase *"
1156 parameter to split_func member.
1157 (multipass_procedure_with_splits) Add "const struct ccase *"
1158 parameter to split_func parameter.
1159 (multipass_split_case_func) Save new SPLIT FILE case before
1161 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1163 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1165 Continue reforming procedure execution. Change
1166 internal_procedure() so that it calls open_active_file() and
1167 close_active_file(), which isolates most of the actual procedure
1170 * procedure.c: (struct write_case_data) Rename `proc_func' member
1171 to `case_func' and update all references.
1172 (procedure) Rewrite as one-line wrapper around
1173 internal_procedure().
1174 (struct multipass_aux_data) New.
1175 (multipass_callback) Renamed multipass_case_func(). Use struct
1176 multipass_aux_data as auxiliary data.
1177 (multipass_end_func) New function.
1178 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1179 that uses multipass_case_func, multipass_end_func.
1180 (internal_procedure) Add `end_func' argument. Move optimization
1181 of trivial case in here. Move call to open_active_file() and
1182 close_active_file() in here. Now assert that vfm_source is
1184 (procedure_with_splits_callback) Rename
1185 split_procedure_case_func().
1186 (split_procedure_end_func) New function.
1187 (multipass_split_callback) Rename multipass_split_case_func.
1188 (multipass_split_end_func) New function.
1189 (discard_variables) No need to test for nonnull vfm_source.
1191 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1193 Continue reforming procedure execution. Get rid of unused member.
1195 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1197 (write_case) Don't increment cases_analyzed.
1199 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1201 Continue reforming procedure execution. In this phase, move
1202 procedure.c and procedure.h from src to src/data. Update
1203 makefiles and #includes accordingly.
1205 * procedure.c: Moved here from src/.
1207 * procedure.h: Moved here from src/.
1209 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1211 Continue reforming procedure execution. In this phase, get rid of
1212 many global variables, consolidating procedure execution in
1213 procedure.c. Encapsulate transformations in new "struct
1214 trns_chain". Also, change implementation of N OF CASES, FILTER,
1215 and PROCESS IF from special cases to transformations.
1217 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1220 * dictionary.c: (global variable default_dict) Move to
1223 * variable.h: (TRNS_*) Move to transformations.h.
1224 (struct transformation) Move to transformations.c.
1226 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1228 * sys-file-reader.c: Fixed invalid read problems.
1230 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1232 * storage-stream.c: Add missing function comments.
1234 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1236 Continue reforming procedure execution. In this phase, add some
1237 new, needed functionality to storage-stream.
1239 * storage-stream.c: (storage_source_decapsulate) New function.
1241 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1243 * variable.c (width_to_bytes): Declarations must precede
1244 statements for C90 compliance.
1246 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1248 * data-out.c, data-in.c, variable.c, variable.h: New functions
1249 copy_mangle and copy_demangle for reading/writing cases; emulates the
1250 way SPSS deals with strings > 255 bytes.
1252 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1253 subtype 14 needed for strings longer than 255 bytes.
1255 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1256 instead of literal values. Also fixed some constness issues.
1258 * format.h: Constness
1260 * sfm-private.h: Renamed the case_size identifier, since I discovered
1261 that SPSS's respect for this variable is very nominal.
1263 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1265 Change case limit type from int to size_t.
1267 * dictionary.c: (struct dictionary) Change type of case_limit
1269 (dict_get_case_limit) Change return type.
1270 (dict_set_case_limit) Change parameter type.
1272 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1274 * variable.h: (struct variable) Rename `reinit' member as `leave'
1275 and invert sense. Fix up all references.
1277 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1279 Continue reforming procedure execution. In this phase, break
1280 procedure.c into multiple files.
1282 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1284 * case-sink.c: New file.
1286 * case-sink.h: New file.
1288 * case-source.c: New file.
1290 * case-source.h: New file.
1292 * storage-stream.c: New file.
1294 * storage-stream.h: New file.
1296 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1298 * variable.h: (struct variable) Remove `init' member and all
1299 references to it from other files. It was initialized in several
1300 places, but nothing really ever used it for anything worthwhile.
1301 Thanks to Jason Stover for pointing out how confusing this
1304 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1306 Continue reforming error message support. In this phase, get rid
1307 of message "titles" and put the message text in `struct error'.
1308 Now `struct error' encapsulates a message more properly.
1310 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1311 Format message ourselves.
1313 * data-in.c: (vdls_error) Ditto.
1315 * por-file-reader.c: (error) Ditto.
1317 * sys-file-reader.c: (corrupt_msg) Ditto.
1319 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1321 GNU standards require "file name" instead of "filename" in
1322 documentation. It's nice for our code to follow the convention
1325 * casefile.c: (struct casefile) Rename `filename' member to
1326 `file_name'. Updated all references.
1328 * file-name.c: [!unix] (struct file_identity) Rename
1329 normalized_filename member to normalized_file_name. Updated all
1332 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1334 We don't really support anything but Unix-like environments well,
1335 so we might as well de-obfuscate by writing directory and path
1336 separators explicitly.
1338 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1340 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1341 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1343 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1346 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1348 GNU standards require "file name" instead of "filename" in
1349 documentation. It's nice for our code to follow the convention
1352 * filename.c: Rename to file-name.c.
1354 * filename.h: Rename to file-name.h. Update all inclusions.
1355 Update header guards.
1357 * automake.mk: Update file names.
1359 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1361 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1363 (fn_basename) Removed (dead code).
1364 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1365 (fn_special_p) Renamed fn_is_special(), all references updated.
1366 (fn_exists_p) Renamed fn_exists(), all references updated.
1368 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1370 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1371 Also, now it only tilde-expands file names, not paths.
1372 (fn_search_path) Tilde-expand one directory at a time.
1374 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1376 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1377 get rid of non-Unixlike version of the code, which has probably
1379 (fn_prepend_dir) Removed (dead code).
1381 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1382 (macro PATH_SEPARATOR_STRING) New.
1383 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1385 Continue reforming error message support. In this phase, we get
1386 rid of VM() and the other msg() support for "verbosity", replacing
1387 it by a new function verbose_msg().
1389 * filename.c: (fn_search_path) Use verbose_msg() instead of
1392 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1394 * sfm-private.h: Get rid of #defines after #error, which makes no
1397 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1399 Get rid of our own int32 type in favor of the standard int32_t
1402 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1405 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1407 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1409 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1411 Remove ill-considered file routines that are no longer used.
1413 * filename.c: (fn_open_ext) Removed.
1414 (fn_close_ext) Removed.
1416 * filename.h: (struct file_ext) Removed.
1418 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1420 * variable.c (var_is_valid_name): Move declarations before code
1423 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1425 * filename.ch (fn_interp_vars): Fixed small buglet.
1427 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1429 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1430 so as to modify the string inline. Thus makeing it easier to
1431 destroy the results when no longer needed.
1433 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1435 * category.c (cat_stored_values_destroy): Fixed memory leak.
1437 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1439 Add some missing frees. Thanks to John Darrington for reporting
1442 * any-writer.c (any_writer_close): Free writer.
1444 * any-reader.c (any_reader_close): Free reader.
1446 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1448 * por-file-reader.c: (error) Mark as NO_RETURN.
1450 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1452 * settings.c: Changed default value of scompress to true.
1454 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1456 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1458 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1461 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1462 here from pref.h.orig.
1464 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1466 * sys-file-reader.c: Fixed bug reading compressed files.
1468 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1470 * Numerous renames. See src/ChangeLog for details.
1472 * Moved files from src directory