1 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
3 * procedure.c procedure.h: Encapsulated the static data into a single
6 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
8 * casefile.c (casereader_read_xfer): Always initialize the case,
9 even on an error condition.
11 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
13 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
14 entire function useless.
16 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
18 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
19 casereader method casereader_clone.
21 * procedure.c pransformations.h: Introduced new type casenum_t
23 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
25 * variable.c: (width_to_bytes) Rephrase code for clarify.
27 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
29 * format.c: (fmt_type_from_string) New function.
30 (fmt_to_string) Include decimals in output if the format has
31 decimals, even if the format type does not. This way, we can
32 accurately reproduce incorrect formats in user output.
33 (check_common_specifier) Make the check for a bad format type an
34 assertion, so we get bug reports if they show up. Fix message.
35 Check for decimal places with a format type that doesn't allow
37 (check_input_specifier) Remove check for FMT_X, which has been
39 (check_output_specifier) Ditto.
41 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
43 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
44 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
45 (enum fmt_parse_flags) Removed.
47 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
49 * casefile.c casefile.h: Converted to an abstract base class.
50 * casefile-private.h fastfile.c fastfile.h: New files.
51 * automake.mk procedure.c scratch-writer.c storage-stream.c
53 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
55 * procedure.c (internal_procedure): Create sink_case with only as
56 many values as the compacted dictionary.
58 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
60 Remove "debugging" code that caused plenty of false positives and
63 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
65 * case.c: Remove all references to `this' member.
67 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
69 Fix link error noted by Jason Stover.
71 * storage-stream.c: Include <assert.h>.
73 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
75 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
76 ALL) and additional underlying system file issues.
78 Thanks to John Darrington for review.
80 First problem: var_hash points to variables not owned by the
81 sys-file-reader, which the caller may free or modify. Use an
82 array of sfm_vars instead, as done earlier (e.g. CVS version
85 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
86 members and remove all code that references it. Add vars, var_cnt
87 members. Remove fix_specials member, which was unused.
88 (struct sfm_var) Remove name member, which was unused.
89 (sfm_close_reader) Free vars member instead of var_hash.
90 (compare_var_shortnames) Removed.
91 (hash_var_shortname) Removed.
92 (sfm_open_reader) Fill out vars array.
93 (compare_var_index) Removed.
94 (sfm_read_case) Use vars instead of var_hash.
96 Second problem: we're confused about when we actually have very
97 long strings, causing us to choose incorrectly between slow path
98 and fast path in sfm_read_case.
100 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
101 have very long strings, not when we have long variable names,
102 which is an unrelated feature.
104 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
106 * variable.h: Move var_set and variable parsing declarations to
107 new header, src/language/lexer/variable-parser.h. Modified lots
108 of files to include the new header.
110 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
112 * value-labels.c (value_to_string): When there's no value label,
113 format the variable according to its print format, instead of
114 always effectively using A or F format.
116 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
118 * casefile.c (casefile_get_random_reader): Nasty hack to get around
121 * format.c: Removed tortological assertion.
123 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
125 Reform string library.
127 * file-name.c (fn_interp_vars): Change interface to take a
128 substring as input. Updated all users.
130 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
132 * format.c (measure_is_valid): Really return false when m >=
135 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
137 Implement random access to casefiles, for use in GUI.
139 * casefile.c: (struct casereader) Add `random', `file_ofs',
140 `buffer_ofs' members.
141 (casefile_get_random_reader) New function.
142 (read_open_file) Break part into new function
143 seek_and_fill_buffer().
144 (fill_buffer) Update buffer_ofs, file_ofs.
145 (casereader_seek) New function.
147 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
149 * settings.c: Added call to i18n{done, init}.
151 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
153 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
156 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
158 * casefile.c: Convert many uses of `int' to `bool'.
160 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
162 * transformations.c (trns_chain_destroy): Destroy chain's trns
163 member, to fix memory leak.
165 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
167 * storage-stream.c (storage_source_decapsulate): Destroy case
168 source to fix memory leak.
170 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
172 * scratch-reader.c (scratch_reader_read_case): Copy into existing
173 case passed as argument instead of initializing the argument as a
174 case. Fixes memory leak that showed up in
175 tests/command/aggregate.sh with scratch files.
177 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
179 * procedure.c (proc_done): Destroy default_dict, to fix memory
182 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
184 Simplify procedure_with_splits().
186 * procedure.c (struct split_aux_data): Removed case_count member.
187 (procedure_with_splits) Don't initialize case_count.
188 (split_procedure_case_func) Check whether prev_case is null
189 instead of case_count.
190 (split_procedure_end_func) Ditto.
192 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
194 * case.c (case_move): Do nothing if dst and src are the same
196 (case_try_create) Merge two similar cases.
197 (case_copy) Unshare only if data must be actually copied.
199 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
201 * data-in.c data-out.c dictionary.c sys-file-reader.c
202 sys-file-writer.c variable.c variable.h: Reworked very long string
203 support for better encapsulation.
205 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
207 * value-labels.c (val_labs_can_set_width): New function.
208 (val_labs_set_width) Clear labels if increasing width to long
210 (val_labs_destroy) Remove unneeded test for null.
212 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
214 * value-labels.h: Remove unneeded dependency on variable.h.
216 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
218 Get rid of `char *c' member in union value, for cleanliness.
220 * value.h: (union value) Remove `c' member.
222 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
224 Make dictionary compacting functions a little more general.
226 * sys-file-writer.c (sfm_open_writer): Use
227 dict_compacting_would_change().
228 (does_dict_need_translation) Removed.
230 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
232 Make dictionary compacting functions a little more general.
234 * dictionary.c (dict_needs_compaction): Rename
235 dict_compacting_would_shrink(). Update all callers.
236 (dict_compacting_would_change) New function.
238 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
240 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
241 inverted return value (!).
243 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
245 Continue reforming procedure execution.
247 * procedure.c: Search and replace "vfm" by "proc". Notably:
248 (static var vfm_source) Rename proc_source. Update all
250 (static var vfm_sink) Rename proc_sink. Update all references.
252 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
254 Continue reforming procedure execution. In this phase, remove
255 PROCESS IF, which was deprecated anyway and can be easily
256 simulated with TEMPORARY followed by SELECT IF.
258 * procedure.c: (open_active_file) Don't call
259 add_process_if_trns().
260 (discard_variables) Get rid of redundant call to
261 proc_cancel_all_transformations().
262 (add_process_if_trns) Removed.
263 (process_if_trns_proc) Removed.
264 (process_if_trns_free) Removed.
266 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
268 Continue reforming procedure execution. In this phase, add
269 `const' to the case passed to procedure()'s callback.
271 Updated all users of procedure() as well.
273 * procedure.c: (struct write_case_data) Add "const" to ccase
274 parameter for case_func member.
275 (procedure) Add "const" to ccase parameter for proc_func
277 (multipass_case_func) Make ccase parameter const.
278 (internal_procedure) Add "const" to ccase parameter for case_func
280 (split_procedure_case_func) Make ccase parameter const.
281 (multipass_split_case_func) Make ccase parameter const.
283 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
285 Continue reforming procedure execution. In this phase, get rid of
286 the output code for SPLIT FILE groups in procedure.c, which really
287 shouldn't be doing any output. Move it into the individual
288 procedures instead. This also adds some flexibility.
290 Updated many users of procedure_with_splits() and
291 multipass_procedure_with_splits() to call
292 output_split_file_values() and to deal with increased use of
295 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
296 parameter to begin_func member.
297 (procedure_with_splits) Add "const struct ccase *" parameter to
298 begin_func parameter. Make ccase parameter const in proc_func
300 (split_procedure_case_func) Don't dump split file group. Pass
302 (dump_splits) Moved to language/dictionary/split-file.c as
303 output_split_file_values().
304 (struct multipass_split_aux_data) Add "const struct ccase *"
305 parameter to split_func member.
306 (multipass_procedure_with_splits) Add "const struct ccase *"
307 parameter to split_func parameter.
308 (multipass_split_case_func) Save new SPLIT FILE case before
310 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
312 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
314 Continue reforming procedure execution. Change
315 internal_procedure() so that it calls open_active_file() and
316 close_active_file(), which isolates most of the actual procedure
319 * procedure.c: (struct write_case_data) Rename `proc_func' member
320 to `case_func' and update all references.
321 (procedure) Rewrite as one-line wrapper around
322 internal_procedure().
323 (struct multipass_aux_data) New.
324 (multipass_callback) Renamed multipass_case_func(). Use struct
325 multipass_aux_data as auxiliary data.
326 (multipass_end_func) New function.
327 (multipass_procedure) Rewrite as wrapper for internal_procedure()
328 that uses multipass_case_func, multipass_end_func.
329 (internal_procedure) Add `end_func' argument. Move optimization
330 of trivial case in here. Move call to open_active_file() and
331 close_active_file() in here. Now assert that vfm_source is
333 (procedure_with_splits_callback) Rename
334 split_procedure_case_func().
335 (split_procedure_end_func) New function.
336 (multipass_split_callback) Rename multipass_split_case_func.
337 (multipass_split_end_func) New function.
338 (discard_variables) No need to test for nonnull vfm_source.
340 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
342 Continue reforming procedure execution. Get rid of unused member.
344 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
346 (write_case) Don't increment cases_analyzed.
348 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
350 Continue reforming procedure execution. In this phase, move
351 procedure.c and procedure.h from src to src/data. Update
352 makefiles and #includes accordingly.
354 * procedure.c: Moved here from src/.
356 * procedure.h: Moved here from src/.
358 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
360 Continue reforming procedure execution. In this phase, get rid of
361 many global variables, consolidating procedure execution in
362 procedure.c. Encapsulate transformations in new "struct
363 trns_chain". Also, change implementation of N OF CASES, FILTER,
364 and PROCESS IF from special cases to transformations.
366 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
369 * dictionary.c: (global variable default_dict) Move to
372 * variable.h: (TRNS_*) Move to transformations.h.
373 (struct transformation) Move to transformations.c.
375 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
377 * sys-file-reader.c: Fixed invalid read problems.
379 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
381 * storage-stream.c: Add missing function comments.
383 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
385 Continue reforming procedure execution. In this phase, add some
386 new, needed functionality to storage-stream.
388 * storage-stream.c: (storage_source_decapsulate) New function.
390 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
392 * variable.c (width_to_bytes): Declarations must precede
393 statements for C90 compliance.
395 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
397 * data-out.c, data-in.c, variable.c, variable.h: New functions
398 copy_mangle and copy_demangle for reading/writing cases; emulates the
399 way SPSS deals with strings > 255 bytes.
401 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
402 subtype 14 needed for strings longer than 255 bytes.
404 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
405 instead of literal values. Also fixed some constness issues.
407 * format.h: Constness
409 * sfm-private.h: Renamed the case_size identifier, since I discovered
410 that SPSS's respect for this variable is very nominal.
412 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
414 Change case limit type from int to size_t.
416 * dictionary.c: (struct dictionary) Change type of case_limit
418 (dict_get_case_limit) Change return type.
419 (dict_set_case_limit) Change parameter type.
421 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
423 * variable.h: (struct variable) Rename `reinit' member as `leave'
424 and invert sense. Fix up all references.
426 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
428 Continue reforming procedure execution. In this phase, break
429 procedure.c into multiple files.
431 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
433 * case-sink.c: New file.
435 * case-sink.h: New file.
437 * case-source.c: New file.
439 * case-source.h: New file.
441 * storage-stream.c: New file.
443 * storage-stream.h: New file.
445 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
447 * variable.h: (struct variable) Remove `init' member and all
448 references to it from other files. It was initialized in several
449 places, but nothing really ever used it for anything worthwhile.
450 Thanks to Jason Stover for pointing out how confusing this
453 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
455 Continue reforming error message support. In this phase, get rid
456 of message "titles" and put the message text in `struct error'.
457 Now `struct error' encapsulates a message more properly.
459 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
460 Format message ourselves.
462 * data-in.c: (vdls_error) Ditto.
464 * por-file-reader.c: (error) Ditto.
466 * sys-file-reader.c: (corrupt_msg) Ditto.
468 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
470 GNU standards require "file name" instead of "filename" in
471 documentation. It's nice for our code to follow the convention
474 * casefile.c: (struct casefile) Rename `filename' member to
475 `file_name'. Updated all references.
477 * file-name.c: [!unix] (struct file_identity) Rename
478 normalized_filename member to normalized_file_name. Updated all
481 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
483 We don't really support anything but Unix-like environments well,
484 so we might as well de-obfuscate by writing directory and path
485 separators explicitly.
487 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
489 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
490 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
492 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
495 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
497 GNU standards require "file name" instead of "filename" in
498 documentation. It's nice for our code to follow the convention
501 * filename.c: Rename to file-name.c.
503 * filename.h: Rename to file-name.h. Update all inclusions.
504 Update header guards.
506 * automake.mk: Update file names.
508 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
510 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
512 (fn_basename) Removed (dead code).
513 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
514 (fn_special_p) Renamed fn_is_special(), all references updated.
515 (fn_exists_p) Renamed fn_exists(), all references updated.
517 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
519 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
520 Also, now it only tilde-expands file names, not paths.
521 (fn_search_path) Tilde-expand one directory at a time.
523 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
525 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
526 get rid of non-Unixlike version of the code, which has probably
528 (fn_prepend_dir) Removed (dead code).
530 * filename.h: (macro DIR_SEPARATOR_STRING) New.
531 (macro PATH_SEPARATOR_STRING) New.
532 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
534 Continue reforming error message support. In this phase, we get
535 rid of VM() and the other msg() support for "verbosity", replacing
536 it by a new function verbose_msg().
538 * filename.c: (fn_search_path) Use verbose_msg() instead of
541 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
543 * sfm-private.h: Get rid of #defines after #error, which makes no
546 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
548 Get rid of our own int32 type in favor of the standard int32_t
551 * sfm-private.h: (int32 macro) Don't define this anymore. Do
554 * sys-file-reader.c: Use int32_t instead of int32 throughout.
556 * sys-file-writer.c: Use int32_t instead of int32 throughout.
558 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
560 Remove ill-considered file routines that are no longer used.
562 * filename.c: (fn_open_ext) Removed.
563 (fn_close_ext) Removed.
565 * filename.h: (struct file_ext) Removed.
567 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
569 * variable.c (var_is_valid_name): Move declarations before code
572 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
574 * filename.ch (fn_interp_vars): Fixed small buglet.
576 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
578 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
579 so as to modify the string inline. Thus makeing it easier to
580 destroy the results when no longer needed.
582 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
584 * category.c (cat_stored_values_destroy): Fixed memory leak.
586 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
588 Add some missing frees. Thanks to John Darrington for reporting
591 * any-writer.c (any_writer_close): Free writer.
593 * any-reader.c (any_reader_close): Free reader.
595 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
597 * por-file-reader.c: (error) Mark as NO_RETURN.
599 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
601 * settings.c: Changed default value of scompress to true.
603 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
605 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
607 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
610 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
611 here from pref.h.orig.
613 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
615 * sys-file-reader.c: Fixed bug reading compressed files.
617 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
619 * Numerous renames. See src/ChangeLog for details.
621 * Moved files from src directory