1 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
3 Continue reforming procedure execution. In this phase, get rid of
4 the output code for SPLIT FILE groups in procedure.c, which really
5 shouldn't be doing any output. Move it into the individual
6 procedures instead. This also adds some flexibility.
8 Updated many users of procedure_with_splits() and
9 multipass_procedure_with_splits() to call
10 output_split_file_values() and to deal with increased use of
13 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
14 parameter to begin_func member.
15 (procedure_with_splits) Add "const struct ccase *" parameter to
16 begin_func parameter. Make ccase parameter const in proc_func
18 (split_procedure_case_func) Don't dump split file group. Pass
20 (dump_splits) Moved to language/dictionary/split-file.c as
21 output_split_file_values().
22 (struct multipass_split_aux_data) Add "const struct ccase *"
23 parameter to split_func member.
24 (multipass_procedure_with_splits) Add "const struct ccase *"
25 parameter to split_func parameter.
26 (multipass_split_case_func) Save new SPLIT FILE case before
28 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
30 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
32 Continue reforming procedure execution. Change
33 internal_procedure() so that it calls open_active_file() and
34 close_active_file(), which isolates most of the actual procedure
37 * procedure.c: (struct write_case_data) Rename `proc_func' member
38 to `case_func' and update all references.
39 (procedure) Rewrite as one-line wrapper around
41 (struct multipass_aux_data) New.
42 (multipass_callback) Renamed multipass_case_func(). Use struct
43 multipass_aux_data as auxiliary data.
44 (multipass_end_func) New function.
45 (multipass_procedure) Rewrite as wrapper for internal_procedure()
46 that uses multipass_case_func, multipass_end_func.
47 (internal_procedure) Add `end_func' argument. Move optimization
48 of trivial case in here. Move call to open_active_file() and
49 close_active_file() in here. Now assert that vfm_source is
51 (procedure_with_splits_callback) Rename
52 split_procedure_case_func().
53 (split_procedure_end_func) New function.
54 (multipass_split_callback) Rename multipass_split_case_func.
55 (multipass_split_end_func) New function.
56 (discard_variables) No need to test for nonnull vfm_source.
58 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
60 Continue reforming procedure execution. Get rid of unused member.
62 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
64 (write_case) Don't increment cases_analyzed.
66 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
68 Continue reforming procedure execution. In this phase, move
69 procedure.c and procedure.h from src to src/data. Update
70 makefiles and #includes accordingly.
72 * procedure.c: Moved here from src/.
74 * procedure.h: Moved here from src/.
76 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
78 Continue reforming procedure execution. In this phase, get rid of
79 many global variables, consolidating procedure execution in
80 procedure.c. Encapsulate transformations in new "struct
81 trns_chain". Also, change implementation of N OF CASES, FILTER,
82 and PROCESS IF from special cases to transformations.
84 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
87 * dictionary.c: (global variable default_dict) Move to
90 * variable.h: (TRNS_*) Move to transformations.h.
91 (struct transformation) Move to transformations.c.
93 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
95 * sys-file-reader.c: Fixed invalid read problems.
97 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
99 * storage-stream.c: Add missing function comments.
101 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
103 Continue reforming procedure execution. In this phase, add some
104 new, needed functionality to storage-stream.
106 * storage-stream.c: (storage_source_decapsulate) New function.
108 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
110 * variable.c (width_to_bytes): Declarations must precede
111 statements for C90 compliance.
113 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
115 * data-out.c, data-in.c, variable.c, variable.h: New functions
116 copy_mangle and copy_demangle for reading/writing cases; emulates the
117 way SPSS deals with strings > 255 bytes.
119 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
120 subtype 14 needed for strings longer than 255 bytes.
122 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
123 instead of literal values. Also fixed some constness issues.
125 * format.h: Constness
127 * sfm-private.h: Renamed the case_size identifier, since I discovered
128 that SPSS's respect for this variable is very nominal.
130 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
132 Change case limit type from int to size_t.
134 * dictionary.c: (struct dictionary) Change type of case_limit
136 (dict_get_case_limit) Change return type.
137 (dict_set_case_limit) Change parameter type.
139 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
141 * variable.h: (struct variable) Rename `reinit' member as `leave'
142 and invert sense. Fix up all references.
144 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
146 Continue reforming procedure execution. In this phase, break
147 procedure.c into multiple files.
149 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
151 * case-sink.c: New file.
153 * case-sink.h: New file.
155 * case-source.c: New file.
157 * case-source.h: New file.
159 * storage-stream.c: New file.
161 * storage-stream.h: New file.
163 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
165 * variable.h: (struct variable) Remove `init' member and all
166 references to it from other files. It was initialized in several
167 places, but nothing really ever used it for anything worthwhile.
168 Thanks to Jason Stover for pointing out how confusing this
171 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
173 Continue reforming error message support. In this phase, get rid
174 of message "titles" and put the message text in `struct error'.
175 Now `struct error' encapsulates a message more properly.
177 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
178 Format message ourselves.
180 * data-in.c: (vdls_error) Ditto.
182 * por-file-reader.c: (error) Ditto.
184 * sys-file-reader.c: (corrupt_msg) Ditto.
186 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
188 GNU standards require "file name" instead of "filename" in
189 documentation. It's nice for our code to follow the convention
192 * casefile.c: (struct casefile) Rename `filename' member to
193 `file_name'. Updated all references.
195 * file-name.c: [!unix] (struct file_identity) Rename
196 normalized_filename member to normalized_file_name. Updated all
199 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
201 We don't really support anything but Unix-like environments well,
202 so we might as well de-obfuscate by writing directory and path
203 separators explicitly.
205 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
207 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
208 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
210 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
213 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
215 GNU standards require "file name" instead of "filename" in
216 documentation. It's nice for our code to follow the convention
219 * filename.c: Rename to file-name.c.
221 * filename.h: Rename to file-name.h. Update all inclusions.
222 Update header guards.
224 * automake.mk: Update file names.
226 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
228 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
230 (fn_basename) Removed (dead code).
231 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
232 (fn_special_p) Renamed fn_is_special(), all references updated.
233 (fn_exists_p) Renamed fn_exists(), all references updated.
235 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
237 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
238 Also, now it only tilde-expands file names, not paths.
239 (fn_search_path) Tilde-expand one directory at a time.
241 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
243 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
244 get rid of non-Unixlike version of the code, which has probably
246 (fn_prepend_dir) Removed (dead code).
248 * filename.h: (macro DIR_SEPARATOR_STRING) New.
249 (macro PATH_SEPARATOR_STRING) New.
250 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
252 Continue reforming error message support. In this phase, we get
253 rid of VM() and the other msg() support for "verbosity", replacing
254 it by a new function verbose_msg().
256 * filename.c: (fn_search_path) Use verbose_msg() instead of
259 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
261 * sfm-private.h: Get rid of #defines after #error, which makes no
264 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
266 Get rid of our own int32 type in favor of the standard int32_t
269 * sfm-private.h: (int32 macro) Don't define this anymore. Do
272 * sys-file-reader.c: Use int32_t instead of int32 throughout.
274 * sys-file-writer.c: Use int32_t instead of int32 throughout.
276 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
278 Remove ill-considered file routines that are no longer used.
280 * filename.c: (fn_open_ext) Removed.
281 (fn_close_ext) Removed.
283 * filename.h: (struct file_ext) Removed.
285 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
287 * variable.c (var_is_valid_name): Move declarations before code
290 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
292 * filename.ch (fn_interp_vars): Fixed small buglet.
294 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
296 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
297 so as to modify the string inline. Thus makeing it easier to
298 destroy the results when no longer needed.
300 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
302 * category.c (cat_stored_values_destroy): Fixed memory leak.
304 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
306 Add some missing frees. Thanks to John Darrington for reporting
309 * any-writer.c (any_writer_close): Free writer.
311 * any-reader.c (any_reader_close): Free reader.
313 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
315 * por-file-reader.c: (error) Mark as NO_RETURN.
317 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
319 * settings.c: Changed default value of scompress to true.
321 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
323 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
325 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
328 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
329 here from pref.h.orig.
331 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
333 * sys-file-reader.c: Fixed bug reading compressed files.
335 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
337 * Numerous renames. See src/ChangeLog for details.
339 * Moved files from src directory