1 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
3 * misc.h: Remove GCC specializations.
5 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
7 Make sort stable (PR 12313).
9 * sort.c: Don't need to include some headers anymore.
10 (static var min_buffers) New variable.
11 (static var max_buffers) New variable.
12 (static var allow_internal_sort) New variable.
13 (cmd_sort_cases) Add test mode.
14 (sort_execute) Rephrase.
15 (do_internal_sort) Don't try internal sorting if
16 allow_internal_sort is set.
17 (struct external_sort) Renamed `initial_runs' to `runs' and
18 updated all references.
19 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
20 (macro MIN_BUFFER_SIZE_BYTES) Removed.
21 (macro MIN_BUFFER_SIZE_RECS) Removed.
22 (compare_initial_runs) Removed.
23 (struct record_run) Add member `idx'.
24 (write_initial_runs) Pass increasing values to process_case() as
26 (process_case) Add `idx' parameter and use it to initialize new
28 (allocate_cases) Limit allocated buffers to max_buffers.
29 (compare_record_run) Use new `idx' member for last resort
30 comparison, for stability.
31 (end_run) Call casefile_sleep() on irs->casefile, to prevent
32 running out of file descriptors.
33 (struct merge_state) Removed.
34 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
35 unless we have fewer runs left. Always merge consecutive runs,
36 for stability. Return the final run.
38 (choose_merge) New function.
39 (merge_once) Rewritten.
41 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
43 * cmdline.c: (static var testing_mode) Move into
46 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
48 * algorithm.c: (remove_range) New function.
49 (remove_element) New function.
51 * dictionary.c: (dict_delete_var) Use remove_element().
53 * flip.c: (cmd_flip) Ditto.
55 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
57 * file-handle.q: (struct file_handle) `open_mode' should not be
60 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
62 First phase of making SORT CASES stable (PR 12313).
64 * sort.c: (struct indexed_case) New structure.
65 (do_internal_sort) Rewrite to make internal sorting stable.
66 (compare_case_dblptrs) Removed.
67 (compare_indexed_cases) New function.
69 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
73 * casefile.c: (casereader_read_xfer_assert) New function.
75 * dictionary.c: (dict_compact_case) New function.
77 * flip.c: (struct flip_pgm) New member idx_to_fv.
78 (cmd_flip) Initialize idx_to_fv member.
79 (destroy_flip_pgm) Free idx_to_fv member.
80 (flip_sink_write) Use struct flip_pgm member instead of case_sink
82 (flip_sink_write) Ditto.
84 * vfm.c: (write_case) Use dict_compact_case() instead of
86 (compact_case) Removed.
87 (storage_source_create) Removed `dict' parameter. All references
90 * vfm.h: (struct case_source) Removed `value_cnt' member. All
92 (struct case_sink) Removed `dict', `idx_to_fv' members. All
95 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
99 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
100 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
102 (initialize_aggregate_info) Fix initialization for MIN, MAX for
105 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
107 Start work on testing and debugging AGGREGATE.
109 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
110 of a bit-map. Require proper subcommand ordering. Make OUTFILE
111 subcommand mandatory.
112 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
113 functions' arguments are in the correct order and swap them if
115 (accumulate_aggregate_info) Make SUM include weights. Add various
117 (dump_aggregate_info) Add various string functions.
118 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
120 * sort.c: (sort_parse_criteria) Add parameter for returning
121 whether any directions were specified. All callers updated.
123 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
125 * t-test.q: Fixed erroneous logic in compare_group_binary.
127 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
129 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
132 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
134 * vfm.c: (procedure_with_splits) Fix PR 11492: end_func() must be
135 called *before* close_active_file().
137 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
139 * file-handle.q: (struct file_handle) Change open_mode from
140 character pointer to 3-char array, for safety. Updated all
143 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
145 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
148 * pfm-read.c: (read_header) Improve error message for many cases
149 in which the input is not actually a portable file.
151 * file-handle.q: (fh_open) When we give an error message, actually
154 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
156 * format.c: (check_common_specifier) New function for checks
157 common to check_input_specifier() and check_output_specifier().
158 (check_input_specifier) Use check_common_specifier().
159 (check_output_specifier) Use check_common_specifier().
160 (check_string_specifier) Removed.
161 (check_specifier_type) New function.
162 (check_specifier_width) New function.
163 (get_format_var_width) Fix bug.
165 * formats.c: (internal_cmd_formats) Only accept numeric variables.
167 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
168 update all references. Make case-insensitive.
170 * pfm-read.c: Essentially rewrite the whole file. Now much
173 * print.c: (check_string_width) New function.
174 (fixed_parse_compatible) Use check_string_width(),
175 check_specifier_type().
176 (dump_fmt_list) Ditto.
178 * str.c: (st_trim_copy) New function.
179 (st_uppercase) New function.
181 * vars-atr.c: (var_is_valid_name) New function.
183 * expressions/parse.c: (type_coercion_core) Use
184 check_specifier_type().
186 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
188 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
190 * expressions/parse.c: (no_match) Ditto.
192 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
194 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
196 * expressions/helpers.c: (struct func_params) Removed.
197 (generalized_idf) Removed.
200 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
202 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
203 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
204 Implement SIG.F, which I had overlooked previously.
206 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
208 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
209 available only in testing mode.
211 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
213 * data-in.c: Use `bool' throughout, where relevant.
215 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
217 DATA LIST with free-field formats should not have implied decimal
218 places (PR 12035). Also clean up data-in.c a bit.
220 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
222 * data-in.c: (apply_implied_decimals) New function.
223 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
224 set. Also, get rid of gotos.
225 (parse_Z) Use apply_implied_decimals() if the field doesn't
226 contain a decimal point.
227 (parse_N) Use apply_implied_decimals().
233 (parse_enum) New function.
234 (macro CHAR_IS_ROMAN) Removed.
235 (macro ROMAN_VALUE) Removed.
236 (parse_month) Use parse_enum().
237 (parse_weekday) Use parse_enum().
238 (parse_DATETIME) Use long for weekday.
240 * data-list.c: (read_from_data_list_fixed) Use
243 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
245 When the lexer sees something like `-5' in the input, it has to
246 decide whether it's a negative numeric constant token or a '-'
247 token followed by a positive numeric constant token. It always
248 decides on the former, and then the parser can call
249 lex_negative_to_dash() if it wants the latter. However, this
250 doesn't work for the case of `-0', because negative zero is
251 (portably) indistinguishable from positive zero. So now we divide
252 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
253 distinction clear. This requires a little bit of extra effort,
254 because there were several references to T_NUM in the code base.
256 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
257 positive and negative numeric constants.
258 (lex_double_p) Renamed lex_is_number(). Changed return type to
259 bool. Updated all relevant references to T_NUM to instead use
261 (lex_double) Renamed lex_number(). All references updated.
262 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
263 bool. All references updated.
264 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
265 (lex_negative_to_dash) Ditto.
268 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
270 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
272 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
274 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
276 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
277 values as system-missing.
279 * expressions/parse.c: (parse_vector_element) Fix order of
280 arguments in call to expr_allocate_binary().
282 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
284 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
287 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
288 failure, as indicated by function comment.
289 (parse_binary_operators) Always return NULL on type_coercion()
290 failure. Should have been doing this anyway, but bug in
291 type_coercion_core() filtered through.
292 (parse_add) Fix typo in user message.
293 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
295 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
297 * expressions/operations.def: Add VALUE function.
299 * expressions/parse.c: (parse_function) Need an unary composite
300 node for variables in A TO B, not a variable node. Use
301 allocate_unary_variable().
302 (parse_primary) Use allocate_unary_variable().
303 (allocate_unary_variable) New function.
305 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
307 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
308 but fixed the real problem that was preventing the build from a
309 separate directory. I liked it my way better ;-)
311 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
313 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
314 John Darrington <john@darrington.wattle.id.au> for reporting this
317 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
319 * expressions/Makefile.am expressions/evaluate.h.pl
320 expressions/evaluate.inc.pl expressions/operations.h.pl
321 expressions/optimize.inc.pl expressions/parse.inc.p:
323 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
326 Fixed everything so that it can be built from an arbitrary
329 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
331 * Makefile.am : Fixed up CLEANFILES target.
333 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
335 * str.h: Changed `struct len_string' to `struct fixed_string', a
336 more accurate name. Updated all references.
338 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
340 Redo calendar support. Should now be bug-for-bug compatible.
342 * calendar.c: New file.
344 * calendar.h: New file.
346 * data-in.c: Use new calendar functions.
347 (parse_sign) Change sense of return value.
348 (calendar_error) New function.
349 (ymd_to_ofs) New function.
350 (ymd_to_date) New function.
351 (parse_DATE) Use new function.
361 (parse_DATETIME) Ditto.
363 * data-out.c: (convert_date) Use new calendar functions.
365 * error.c: (err_vmsg) Changed interface to be more sensible.
367 (dump_message) Don't double new-lines (why did we do this
370 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
372 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
373 (macro FLT64_MAX) Moved here from pref.h.orig.
375 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
377 * set.q: Support SET EPOCH.
378 (static var set_epoch) New var.
379 (aux_stc_custom_epoch) New function.
380 (stc_custom_epoch) New function.
381 (get_epoch) New function.
382 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
384 * format.c: Make it possible just to check whether a specifier is
385 valid without emitting an error message.
386 (parse_format_specifier_name) Change interface, update all
388 (check_input_specifier) Ditto.
389 (check_output_specifier) Ditto.
390 (parse_format_specifier) Ditto.
392 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
394 * command.def: Add DEBUG POOL.
396 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
398 (pool_clear) Properly account for size of pool gizmo.
399 (pool_realloc) Ditto.
400 (pool_clone) New function.
402 * pool.h: Mark our allocation functions MALLOC_LIKE.
404 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
406 * Makefile.am: Move many definitions into new top-level
407 Make.build. Add expressions to SUBDIRS. Add calendar.c,
408 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
411 * case.c: (case_resize) New function.
412 (case_swap) New function.
414 * casefile.c: Include mkfile.h.
416 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
418 * sfm-read.c: Fixed a buglet which caused a crash when trying
419 to read a non-existent file.
421 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
425 * aggregate.c: (parse_aggregate_functions) Code cleanup.
426 Important part: get rid of spurious copying of function->format to
427 destvar->print and destvar->write.
429 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
431 Fix PR 11916, which was confusing a variable's `index' member
432 with the variable's position in a var_set. Although these are
433 usually the same, they are not for array `var_set's.
435 Took advantage of this bug as an opportunity to clean up and
436 rewrite parse_var_set_vars().
438 * vars-prs.c: (parse_vs_variable_idx) New function.
439 (parse_vs_variable) Reimplement in terms of
440 parse_vs_variable_idx().
441 (parse_var_idx_class) New function.
442 (add_variable) New function.
443 (add_variables) New function.
444 (parse_var_set_vars) Rewritten.
445 (struct var_set) Change `lookup_var' member that returns a
446 variable into `lookup_var_idx' member that returns an int.
447 Updated the var set implementations in obvious corresponding ways.
448 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
450 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
452 Use our global variable compare & hash functions and give them
453 better names. Add similar functions for dealing with double
454 pointers to variables.
456 * vars-atr.c: (compare_variables) Renamed compare_var_names().
457 (hash_variable) Renamed hash_var_name().
458 (compare_var_ptr_names) New function.
459 (hash_var_ptr_name) New function.
461 * t-test.q: (cmd_t_test) Use global compare_var_names(),
463 (compare_var_name) Removed.
464 (hash_var_name) Removed.
466 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
470 * dictionary.c: (compare_variable_dblptrs) Rename
471 compare_var_ptrs() and fix it to properly dereference the double
474 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
476 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
477 declare subcommands as mandatory. Closed bug #11843
479 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
481 * getline.c command.[ch] command.def: Added (very rudimentary)
482 support for line completion when in interactive mode. Partially
485 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
487 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
488 problems revealed by valgrind.
491 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
493 * set.q: Affixed a fix to the previous fix such that we'll be OK now
494 whether or not PAGER is set.
496 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
498 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
499 "invalid free" errors. Hopefully fixes bug #11722
501 * compute.c expr-prs.c: Check that lvalues are populated before
502 attempting to destroy them. Closes bug #11676
504 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
506 * aggregate.c: Initialised the complete agr_proc structure.
510 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
512 * print.c: (print_trns_free) Close the dfm writer if there is one,
513 fixing a memory leak.
515 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
517 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
521 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
523 * linked-list.[ch] Added
525 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
526 set.q: Yet more memory leaks
528 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
530 * t-test.q examine.q : More memory leaks fixed.
532 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
534 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
537 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
539 * ascii.c cartesian.c casefile.c chart.h devind.c
540 examine.q frequencies.q
541 html.c output.h piechart.c plot-chart.c plot-hist.c
543 Integrated the chart rendering into the output stream
544 (currently only works for html).
546 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
547 dummy-chart.c for compiling without charts.
549 * mkfile.[ch] Created.
551 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
552 Added type element so we can tell if it's a chart or a table.
554 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
555 API of charts to be more like that of tables.
557 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
559 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
560 main.c. Removed the handler for SIGQUIT.
562 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
564 * casefile.c: Added a signal handler to delete temp files on
567 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
569 * command.def Added a lot more unimplemented commands.
571 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
573 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
575 * sort.c: (compare_initial_runs) Needed additional level of
577 (merge_once) Fix plenty of stupid mistakes.
579 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
581 * casefile.c: (casefile_sleep) Need to flush_buffer() after
582 calling casefile_to_disk() or we will lose the last block in the
583 file if the casefile started out as disk-based.
584 (casefile_get_reader) Initialize reader->destructive to 0.
585 (cmd_debug_casefile) Add new test pattern.
586 (test_casefile) Define new test pattern to make sure
587 casefile_sleep() works properly.
589 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
591 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
592 plot-hist.c plot-chart.c (Added) Reorganised these files in an
593 attempt to seperate the creation and processing of charts from their
596 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
599 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
601 * main.c Added a signal handler for SIGFPE
603 * sort.c Somewhat more robust fix to the previous entry.
605 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
607 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
608 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
609 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
612 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
614 * case.h Fixed bug # 11307
616 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
618 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
621 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
623 * pfm-read.c: (read_variables) Remove direct manipulation of
624 v->aux, which is no longer needed. Fixes PR 11483.
626 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
628 * data-list.c Fixed a bug in parsing delimiters.
630 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
633 * percentiles.c Properly handled calculation of Tukey hinges where
634 the number of data is small.
636 * oneway.q Used the generic value_to_string function for independent
637 variable instead of trying to do it ourselves.
639 * box-whisker.c Fixed a buglet which caused a crash if the number of
643 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
645 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
647 * percentiles.c Fixed some bugs when calculating percentiles when
648 there's a small number of cases.
650 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
652 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
654 * examine.q factor_stats.[ch] Added calculation of percentiles
656 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
658 * t-test.q Fixed bug #11227 Made t-test work when the independent
661 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
663 * factor_stats.c Fixed calculation of trimmed mean under various
666 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
668 * histogram.c chart.[ch] factor_stats.c frequencies.q
670 Added code to calculate sensible histogram ranges and limits.
672 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
674 * chart.h Updated to reflect many API changes.
676 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
677 cartesian.c and into chart.c
679 * factorstats.[ch] Added the histogram calculations
681 * casefile.c Removed an unused variable.
683 * frequencies.q examine.q histogram.c Reworked the API for
686 * piechart.c Revised the API for piecharts.
688 * var.h Moved the definitions of freq_tab and freq out of var.h
689 and into frequencies.q where they belong.
691 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
693 * flip.c: (flip_file) Check for off_t separately from fseeko(),
696 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
698 * flip.c: (flip_file) If fseeko() is not available, use long int
699 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
700 reporting the problem.
702 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
704 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
707 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
709 * var-labs.c (var_to_string) Now returns null if the variable is null
711 * value-labels.c (value_to_string) Made it return null if either the
712 value or the variable is null.
714 * hash.c (hsh_clear) Fixed a buglet.
716 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
717 with the wrong model.
719 * casefile.[ch] Added a function to return the casereader.case_idx
722 * examine.q Implemented the extreme values results.
724 John Darrington <john@darrington.wattle.id.au>
726 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
727 output.[ch] getline.c
729 Plugged some memory leaks
731 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
733 Adopt GSL random number generators, paving the way for providing
734 the complete suite of random number generators on expressions.
736 * Makefile.am: Remove random.c, random.h.
742 * algorithm.c: (algo_default_random) Use GSL functions.
744 * casefile.c: (test_casefile) Use GSL RNG functions.
746 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
749 * sample.c: (cmd_sample) Use GSL RNG functions.
750 (sample_trns_proc) Ditto.
752 * set.q: (static var set_seed) Removed.
753 (static var seed_flag) Removed.
754 (static var rng) New variable.
755 (aux_stc_custom_seed) No seed value anymore, don't print anything.
756 (stc_custom_seed) Use new seed functions.
757 (seed_is_set) Removed.
758 (get_rng) New function that composes the entire external
760 (set_rng) New function.
761 (random_seed) New function.
763 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
765 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
766 John Darrington <john@darrington.wattle.id.au> for reporting this
769 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
771 * permissions.c command.def Added the PERMISSIONS command
773 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
775 * q2c.c: (dump_header) Don't try to emit #includes at very top of
776 output file because that will precede #include <config.h>, which
778 (main) Add needed headers to /* (header) */ code.
780 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
782 Instead of making system or portable file readers responsible for
783 dropping and reordering variables, make them read full cases and
784 let the caller take care of any changes.
786 * get.c: New "case map" structure to handle this. Use for GET,
787 IMPORT, MATCH FILES. Essentially rewrite the whole file.
789 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
790 changed appropriately.
792 * sfm-read.c: (sfm_read_case) Ditto.
794 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
796 Decided that case_serialize() and case_unserialize() were too
797 abstract. Also we need a couple more functions to avoid excessive
798 copying for data in/out fast paths.
800 * case.c: (case_serial_size) Removed.
801 (case_serialize) Rename case_to_values() and make its argument
802 explicitly an array of union values.
803 (case_unserialize) Rename case_from_values() and make its argument
804 explicitly an array of union values.
805 (case_data_all) New function.
806 (case_data_all_rw) New function.
808 * casefile.c: (struct casefile) Change buffer from array of
809 unsigned char to array of union value for better accuracy.
810 Redefine buffer_used and buffer_size in terms of values, not
811 bytes. Remove case_size because it is now redundant with
812 value_cnt. Fix up all references to these members.
814 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
816 * barchart.c: (struct subcat) Make `label' member const to silence
817 GCC warning with -Wwrite-strings.
819 * cartesian.c: (struct dataset) Ditto.
821 * case.c: Don't re-define NDEBUG if already defined.
822 Add lots of comments.
824 * str.c: Fix includes.
826 * crosstabs.q: Fix includes.
828 * examine.q: Fix includes. Fix GCC warning about unused
831 * frequencies.q: (stat macro) Removed and replaced where used by
834 * list.q: Fix includes.
836 * oneway.q: Fix includes.
838 * piechart.c: Fix includes. Only define M_PI if not already
841 * sfm-read.c: (bswap) New function.
842 (bswap_int32) Write in terms of bswap.
845 * str.c: (ds_data) Add external definition here, needed because
846 str.h has only an `extern inline' version.
848 * value-labels.c: Fix includes.
850 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
852 Instead of providing a system or portable file writer with a raw
853 case in the format needed for output, provide it with a regular
854 case. The writer takes care of any needed translation.
856 * aggregate.c: Adopt new scheme for AGGREGATE.
857 (struct agr_proc) sfm_agr_case member removed.
858 (write_case_to_sfm) Removed because the new interface is easier to
861 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
863 * pfm-write.c: Implement new scheme.
865 * sfm-write.c: Ditto.
867 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
869 Instead of treating `struct file_handle' as a class to subclass
870 into data files, system files, and portable files, instead use it
871 as a helper that coordinates access. Now it is opaque, too.
873 This means that most references to a struct file_handle are now
874 changed into references to one of struct dfm_reader, struct
875 dfm_writer, struct sfm_reader, struct sfm_writer, struct
876 pfm_reader, or struct pfm_writer, according to what's being read
879 Most related changes are only worth summarizing briefly.
881 * dictionary.c: (dict_clear) Destroy aux data in deleted
883 (dict_clear_aux) New function.
884 (dict_create_var) Initialize aux, aux_dtor.
885 (dict_delete_var) Destroy aux data in deleted variable.
887 * file-handle.h: (struct fh_ext_class) Removed.
888 (struct file_handle) Removed.
889 (fh_init_files) Removed.
891 * file-handle.q: Changed references to a handle's `private' member
892 to direct references.
893 (struct private_file_handle) Renamed file_handle.
894 Add next, open_cnt, type, open_mode, aux members.
895 (struct file_handle_list) Removed.
896 (extern var inline_file) Removed.
897 (static var file_handles) Changed from file_handle_list * to
899 (create_file_handle) Initialize new members.
900 (fh_close_handle) Removed.
901 (mode_name) New function.
902 (fh_open) New function.
903 (fh_close) New function.
904 (fh_parse_file_handle) Renamed fh_parse().
906 * glob.c: (init_glob) Remove fh_init_files() call.
908 * aggregate.c: use sfm_writer.
909 (create_sysfile) Removed because the new interface is simpler.
911 * apply-dict.c: Use sfm_reader.
913 * data-list.c: Use dfm_reader.
915 * file-type.c: Use dfm_reader.
917 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
919 * inpt-pgm.c: Use dfm_reader.
921 * print.c: Use dfm_writer.
923 * sysfile-info: Use sfm_reader.
925 * dfm-read.c: Adopt new file handle infrastructure.
927 * dfm-write.c: Ditto.
931 * pfm-write.c: Ditto.
935 * sfm-write.c: Ditto.
937 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
939 Break dictionary functions into separate header file.
941 * dictionary.h: New file.
943 * var.h: Moved dict_*() functions to dictionary.h.
945 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
947 Get rid of procedure-specific union in struct variable, using
948 instead a void * pointer and a destructor function.
950 Most related changes are only worth brief summaries.
952 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
953 old p.crs member in struct variable.
955 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
956 of old p.frq member in struct variable.
958 * histogram.c: (draw_histogram) Takes new freq_tab arg because
959 it's no longer possible to grab this from var->p.frq.
961 * piechart.c: (draw_piechart) Ditto.
963 * group.c: (group_proc_get) New function.
965 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
972 * main.c: (execute_command) Clear aux data in default_dict after
973 each command. (It's debatable whether this should be done.)
975 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
976 member in struct variable.
978 * means.q: Get rid of integer mode, which is not included in
979 recent SPSS and was the only code that wanted per-variable private
982 * var.h: (struct crosstab_proc) Removed.
983 (struct frequencies_proc) Removed.
984 (struct list_proc) Removed.
985 (struct get_proc) Removed.
986 (struct means_proc) Removed.
987 (struct matrix_data_proc) Removed.
988 (struct match_files_proc) Removed.
989 (lots of enums) Removed.
990 (struct variable) Removed members `p', `get'. Add member
993 * vars-atr.c: (var_attach_aux) New function.
994 (var_detach_aux) New function.
995 (var_clear_aux) New function.
996 (var_dtor_free) New function.
997 (discard_variables) Use NULL instead of inline_file.
999 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1001 * value-labs.c Fixed the implmentation of value_to_string, so
1002 that it properly handles alpha values.
1004 * oneway.q Changed instances where labels were being probed manually,
1005 to use the canonical {var,value}_to_string functions
1007 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1009 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1010 plots. Changed the API of the cartesian plot to be a much lower level
1013 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1015 * examine.q Added some of the parametric calculations
1017 * factor_stats.[ch] Created
1019 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1021 * examine.q Changed the definition of factors to be a composite, and
1022 dealt with the consequences.
1024 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1026 * examine.q Fixed problem where examine wasn't dealing properly with
1029 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1031 * oneway.q Fixed problem where oneway wasn't dealing properly with
1034 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1036 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1037 command which had settings didn't get the appropriate code
1040 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1041 to convert variables/values to strings.
1043 * examine.q Added framework for the EXAMINE command.
1045 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1047 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1048 subcommand types. Changed frequencies.q to use it rather then the
1049 custom parser. Dealt with the consequences. Added a test for NTILES
1050 subcommand of frequencies.
1052 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1054 * oneway.q Fixed up the behaviour when given missing values
1056 * levene.c oneway.q Fixed a buglet with the levene statistic and
1057 incorporated the levene test into the oneway command.
1059 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1060 global scope, since they're only relevant to T-TEST
1062 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1064 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1066 Made the t-test more consistent
1067 with the way it handles groups. That is, it now uses a hash instead
1068 of an array of 2. Also, made the levene.c file independent of the
1069 implementation of the t-test. So now levene should be fine for both
1072 * Added an oneway.q file for one way anova
1074 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1076 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1079 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1083 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1084 (data_list_trns_free) Free dls->delims.
1086 * t-test.q: (tts_custom_pairs) Free vars.
1087 (ssbox_one_sample_init) Fix tab_vline() argument.
1088 (ssbox_independent_samples_init) Ditto.
1089 (trbox_paired_init) Ditto.
1090 (trbox_one_sample_init) Ditto.
1092 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1094 Generalize casefiles to the extent that we can use them for
1095 sorting and other kinds of data transformations. Change cases to
1096 be copy-on-write to improve memory efficiency in common cases.
1097 Every access to a member of a `struct ccase' was changed to be a
1098 call to a case_*() function, especially case_data(), case_num(),
1099 case_str(), or case_data_rw(). Many instances of a local variable
1100 named "case_num" were changed to "case_idx" as a consequence.
1101 Many `struct ccase *' were changed to actual `struct ccase'
1102 because of copying semantics of cases. In several places there
1103 was a choice between updating debug code to work with the new ADTs
1104 or just deleting it because it was useless; I chose to delete it.
1106 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1112 * aggregate.c: (struct agr_proc) Change type of `sort' to
1113 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1114 Rename `vars' to `agr_vars', all references updated. Change
1115 `agr_case' to type `struct ccase'.
1116 (cmd_aggregate) Deal with new members. Use case_create(),
1117 sort_active_file_in_place(), sort_active_file_to_casefile().
1118 (agr_destroy) Deal with new members.
1119 (aggregate_single_case) Ditto.
1120 (dump_aggregate_info) Ditto.
1121 (initialize_aggregate_info) Ditto.
1122 (agr_to_active_file) Ditto.
1123 (presorted_agr_to_sysfile) Ditto.
1124 (sort_agr_to_sysfile) Removed.
1126 * alloc.c: (out_of_memory) Make non-static.
1128 * alloc.h: Prototype out_of_memory().
1130 * casefile.c: Switched from a linked list in-memory representation
1131 to a two-level array-style representation. The linked list was
1132 appropriate when we could stick a header onto cases, but that's no
1133 longer the case. Also, the two-level array will allow for random
1134 in-memory access in case that's ever wanted. Also added the
1135 concept of a `destructive casereader', one that destroys cases in
1136 the underlying casefile as they are read out.
1137 (macro CASES_PER_BLOCK) New macro.
1138 (struct casefile) New members `value_cnt', `case_list_size',
1139 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1141 (struct casereader) Removed `cur'. Added `destructive', `c'.
1142 (global var casefiles) Made static.
1143 (static var case_bytes) New var.
1144 (casefile_create) Takes a value count, not a case size in bytes,
1145 to conform to the case interface. All callers updated. Deal with
1146 new and removed members.
1147 (casefile_destroy) Deal with new and removed members.
1148 (casefile_sleep) New function.
1149 (casefile_get_case_size) Removed.
1150 (casefile_get_value_cnt) New function.
1151 (casefile_append) Rewritten to deal with new and removed members.
1152 (casefile_append_xfer) New function.
1153 (write_case_to_disk) Use case_serialize().
1154 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1155 Couldn't figure out why.
1156 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1157 deal with new and removed members.
1159 (merge_sort) Removed.
1160 (casefile_sort) Removed.
1161 (casefile_get_reader) Deal with new and removed members.
1162 (casefile_get_destructive_reader) New function.
1163 (reader_open_file) Make code more readable. Create case for
1165 (casereader_get_casefile) New function.
1166 (casereader_read) Deal with new and removed members. Now returns
1167 a copy of the case, so that the caller is responsible for
1168 destroying the returned case.
1169 (casereader_read_xfer) New function.
1170 (casereader_destroy) Destroy reader's case.
1171 (test_casefile) Second arg is now a value count, all callers
1172 updated. Now tests destructive readers too.
1173 (get_random_case) Deal with new case ADT.
1174 (write_random_case) Ditto.
1175 (read_and_verify_random_case) Ditto.
1177 * crosstabs.q: Remove debug code.
1179 * descript.q: (calc_descriptives) Deal with new case, casefile
1182 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1184 * do-if.c: Remove unneeded header inclusion.
1186 * expr-prs.c: Remove debug code.
1188 * exprP.h: Remove debug code.
1190 * flip.c: (flip_file) Use fseeko() if available.
1192 * formats.c: Remove debug code.
1194 * get.c: Remove debug code.
1195 (struct mtf_file) Change `input' from `union value *' to `struct
1196 ccase', all references updated.
1198 * levene.c: (levene) Deal with new case, casefile ADTs.
1200 * list.q: Remove debug code.
1202 * loop.c: Remove debug code.
1204 * matrix-data.c: Remove debug code.
1206 * means.q: Remove debug code.
1208 * mis-val.c: Remove debug code.
1210 * pfm-read.c: Remove debug code.
1211 (pfm_read_code) Change second arg from `union value *' to `struct
1212 ccase *', all references updated.
1214 * recode.c: (string_to_long) Make first arg const.
1215 (convert_to_double) Ditto.
1217 * repeat.c: Remove debug code.
1219 * sample.c: Remove debug code.
1221 * sfm-read.c: Remove debug code.
1222 (sfm_read_case) Change second arg from `union value *' to `struct
1225 * sort.c: Redone in terms of casefiles.
1226 (enum sort_direction) Moved here from sort.h.
1227 (struct sort_criterion) New structure.
1228 (struct sort_criteria) New structure.
1229 (cmd_sort_cases) Rewritten.
1230 (prepare_to_sort_active_file) New function.
1231 (sort_active_file_in_place) New function.
1232 (sort_active_file_to_casefile) New function.
1233 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1234 changed, all callers updated.
1235 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1236 rewritten & interface changed, all callers updated.
1237 (sort_cases) Renamed sort_execute(), rewritten & interface
1238 changed, all callers updated.
1239 (struct internal_sort) Removed.
1240 (do_internal_sort) Rewritten, interface changed.
1241 (destroy_internal_sort) Removed.
1242 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1243 (struct initial_run) Removed; an initial run is now just a
1245 (compare_initial_runs) Rewritten.
1246 (struct external_sort) Changed almost completely.
1247 (do_external_sort) Rewritten, interface changed.
1248 (destroy_external_sort) Rewritten.
1249 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1250 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1251 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1252 (init_external_sort) Removed.
1253 (simulate_error) Removed.
1254 (rmdir_temp_dir) Removed.
1255 (get_temp_file_name) Removed.
1256 (open_temp_file) Removed.
1257 (close_temp_file) Removed.
1258 (remove_temp_file) Removed.
1259 (write_temp_file) Removed.
1260 (read_temp_file) Removed.
1261 (struct record_run) Change `record' from `struct case_lit *' to
1263 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1264 `file_idx', `output_file'. Add `run', casefile'. Change
1265 `last_output' from `struct case_list *' to `struct ccase'.
1266 (write_initial_runs) Change interface, rewrite.
1267 (sort_sink_write) Renamed process_case(), changed interfaced,
1269 (destroy_initial_run_state) Rewritten.
1270 (allocate_cases) Rewritten.
1271 (compare_record) Interface changed, rewritten.
1272 (start_run) Rewritten.
1273 (end_run) Rewritten.
1274 (output_record) Rewritten.
1275 (grab_case) Removed.
1276 (release_case) Removed.
1277 (struct merge_case) Change `cases' from double pointer to single
1279 (merge) Deal with new case and casefile ADTs.
1280 (struct run) Removed.
1281 (merge_once) Rewritten, interface changed.
1282 (fill_run_buffer) Removed.
1283 (sort_sink_make_source) Removed.
1284 (sort_sink_class) Removed.
1285 (struct sort_source_aux) Removed.
1286 (sort_source_read_helper) Removed.
1287 (sort_source_read) Removed.
1288 (read_sort_output) Removed.
1289 (read_internal_sort_output) Removed.
1290 (read_external_sort_output) Removed.
1291 (sort_source_destroy) Removed.
1292 (sort_source_class) Removed.
1294 * sort.h: (struct sort_cases_pgm) Removed.
1295 (enum sort_direction) Moved to sort.c.
1297 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1299 * tab.c: Remove debug code.
1301 * var-labs.c: Remove debug code.
1303 * var.h: (struct ccase) Removed.
1304 (struct case_list) Removed.
1306 * vars-atr.c: (discard_variables) Use free_case_source().
1308 * vars-prs.c: (parse_vs_variable) Make arg const.
1309 (parse_dict_variable) Ditto.
1310 (parse_variables) Make struct dictionary * arg const.
1311 (parse_var_set_vars) Make struct var_set * arg const.
1312 (struct var_set) Add const to some of the function pointers' args.
1313 (var_set_get_cnt) Make arg const.
1314 (var_set_get_var) Make first arg const.
1315 (var_set_lookup_var) Make first arg const.
1316 (dict_var_set_get_cnt) Make arg const.
1317 (dict_var_set_get_var) Make first arg const.
1318 (dict_var_set_lookup_var) Make first arg const.
1319 (var_set_create_from_dict) Make arg const. Add cast to aux
1321 (struct array_var_set) Add const to var member.
1322 (array_var_set_get_cnt) Make arg const.
1323 (array_var_set_get_var) Make first arg const.
1324 (array_var_set_lookup_var) Make first arg const.
1325 (var_set_create_from_array) Make first arg const. Insert cast.
1327 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1328 members from `struct ccase *' to `struct ccase'.
1329 (static var lag_queue) Change from double to single pointer.
1330 (procedure) Optimize trivial case.
1331 (internal_procedure) Deal with changed case, case_source ADTs.
1332 (create_trns_case) Changed interface, rewrote.
1333 (open_active_interface) Initialize modified lag queue.
1334 (write_case) Deal with changed case ADT.
1335 (lag_case) Deal with modified lag queue.
1336 (close_active_file) Destroy modified lag queue.
1337 Deal with changed case_source, case_sink ADTs.
1338 (destroy_storage_stream_info) Make null arg into no-op.
1339 (storage_sink_make_source) Set aux in created source.
1340 (storage_source_read) Deal with changed case, casefile ADTs.
1341 (storage_source_create) New function.
1342 (lagged_case) Rewrite.
1343 (free_case_source) New function.
1344 (free_case_sink) Rewrite.
1345 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1347 (procedure_with_splits) Deal with changed prev_case.
1348 (procedure_with_splits_callback) Ditto.
1349 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1351 (multipass_procedure_with_splits) Deal with changed prev_case.
1352 (multipass_split_callback) Ditto.
1355 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1357 The workspace idea didn't work out.
1359 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1361 * workspace.c: Removed.
1363 * workspace.h: Removed.
1365 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1367 Fully implement arbitrary delimiters on DATA LIST, extending the
1368 half implementation that was already there.
1370 * data-list.c: (struct data_list_pgm) Remove `delim', add
1371 `delims', `delim_cnt'.
1372 (cmd_data_list) Initialize new members. Parse delimiters and
1373 clean up code a bit.
1374 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1375 handling of leading commas.
1376 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1378 (read_from_data_list_free) Adapt to new DFM interfaces.
1379 (read_from_data_list_list) Ditto.
1380 (repeating_data_trns_proc) Ditto.
1382 * dfm.c: Split up reader and writer into separate code, because
1383 they do different things. Use struct string instead of explicit
1384 allocation code, for clarity.
1385 (enum dfm_reader_flags) New enum.
1386 (struct dfm_fhuser_ext) Removed.
1387 (struct dfm_reader_ext) New.
1388 (get_reader) New function, used by just about all the reader
1390 (dfm_close) Removed.
1391 (close_reader) New function.
1392 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1393 (dfm_open_for_writing) Ditto.
1394 (macro force_line_buffer_expansion) Removed.
1395 (count_tabs) Removed.
1396 (tabs_to_spaces) Removed.
1397 (read_record) Deal with new dfm_reader_ext. Use struct string
1398 functions. Don't convert tabs to spaces.
1399 (dfm_eof) New function.
1400 (dfm_get_record) Changed interface, rewrote.
1401 (dfm_expand_tabs) New function.
1402 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1403 dfm_reader_ext, rewritten.
1404 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1405 dfm_reader_ext, rewritten.
1406 (dfm_set_record) Removed in favor of dfm_forward_columns().
1407 (dfm_forward_columns) New function.
1408 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1409 dfm_reader_ext, rewritten.
1410 (static var dfm_r_class) Use close_reader for the destructor.
1411 (struct dfm_writer_ext) New.
1412 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1413 bounce buffer now instead of local allocation.
1414 (close_writer) New function.
1415 (static var dfm_writer_ext) Use close_writer for destructor.
1416 (cmd_begin_data) Adapt to new dfm_reader_ext.
1418 * file-handle.q: Add support for per-file tab width.
1419 (struct private_file_handle) Add tab_width member.
1420 (q2c specifications) Add tabwidth subcommand.
1421 (cmd_file_handle) Put parsed tab width into private_file_handle.
1422 (create_file_handle) Set default tab width.
1423 (handle_get_tab_width) New function.
1425 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1427 * inpt-pgm.c: (reread_trns_proc) Ditto.
1429 * matrix-data.c: (context) Ditto.
1430 (another_token) Ditto.
1434 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1436 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1438 (casereader_destroy) Don't close file descriptor -1.
1440 * recode.c: (cmd_recode) Fix memory leak.
1442 * set.q: (q2c specifications) Fix typo in user message.
1444 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
1445 undefined behavior for overlapping arguments.
1447 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
1449 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
1450 don't call it when we're running under valgrind.
1451 (call_posix_fadvise) New function.
1452 (casefile_to_disk) Use call_posix_fadvise().
1453 (reader_open_file) Ditto.
1455 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
1457 Update our string ADTs, struct string and struct len_string. Get
1458 rid of pool support, which was largely unused. Rename lots of
1459 functions to have more obvious or consistent names.
1461 * ascii.c: Get rid of ascii_pool. It was only used for string
1463 (ascii_open_global) Don't create ascii_pool.
1464 (ascii_close_driver) Don't destroy ascii_pool.
1465 (ascii_postopen_driver) Don't use pool.
1466 (ascii_close_driver) Destroy strings manually.
1468 * str.c: (ds_create) Remove pool argument, all references updated.
1470 (ds_replace) Remove pool support, make more efficient when we
1471 don't need to reallocate.
1472 (ds_destroy) Remove pool support.
1473 (ds_rpad) New function.
1474 (ds_size) Renamed ds_capacity(), all references updated.
1475 (ds_value) Renamed ds_c_str(), all references updated.
1476 (ds_concat) Renamed ds_puts(), all references updated.
1477 (ds_concat_buffer) Renamed ds_concat(), all references updated.
1478 (ds_putchar) Renamed ds_putc(), all references updated.
1479 (ds_getline) Renamed ds_gets(), all references updated.
1480 (ls_create) Remove pool argument, all references updated.
1481 (ls_create_buffer) Ditto.
1482 (ls_destroy) Removed pool support.
1483 (ls_value) Renamed ls_c_str(), all references updated.
1485 * str.h: (ls_length) [__GNUC__] Add inline version.
1486 (ls_c_str) [__GNUC__] Add inline version.
1487 (ls_end) [__GNUC__] Add inline version.
1488 (struct string) Remove pool member. Rename `size' to `capacity',
1489 all references updated.
1491 * tab.c: (text_format) Instead of using pool argument to
1492 ls_create_buffer(), call pool_register() on allocated data.
1494 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
1496 We're abusing the current ASCII driver by telling it to allocate a
1497 9999-line, 9999-character page in the tests. This causes some
1498 systems to curl up and die because it allocates 20 MB of
1499 contiguous RAM. This change alleviates at least part of the
1500 problem. It is mostly a stop-gap until the new output system is
1503 * ascii.c: (struct line) New structure.
1504 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
1505 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
1506 (ascii_preopen_driver) Initialize new members, not old ones.
1507 (ascii_close_driver) Destroy new members, not old ones.
1508 (ascii_open_page) Allocate new members, not old ones.
1509 (expand_line) Allocate room in line.
1510 (draw_line) Use new members.
1511 (ascii_line_horz) Ditto.
1512 (ascii_line_vert) Ditto.
1513 (ascii_line_intersection) Ditto.
1515 (output_lines) Ditto.
1516 (ascii_close_page) Ditto.
1518 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
1520 * matrix.c: Dead code. Removed.
1522 * matrix.h: Dead code. Removed.
1524 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
1526 Contrary to what I'd always understood, there is an efficient
1527 algorithm for deletion from a hash table populated via linear
1528 probing. This change implements it.
1530 * hash.c: (hsh_rehash) Probe in increasing order.
1532 (locate_matching_entry) Ditto.
1533 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
1535 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
1537 * moments.c (calc_moments): Adjust calculation of kurtosis to
1538 avoid subtracting huge numbers from huge numbers, on Michael
1541 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
1543 Rework moments routines for improved numerical stability based on
1544 Michael Kiefte's advice. Any bugs or remaining numerical problems
1545 are still mine though.
1547 There is now a struct moments1 for use with one-pass moments. It
1548 uses a provisional means algorithm as an attempt to improve
1549 accuracy of higher moments. The older struct moments now only
1550 handles two-pass moments.
1552 * aggregate.c: Use moments1 instead moments.
1554 * descript.c: Revert previous change, which is no longer needed
1555 due to the moments revision.
1557 * moments.c: (calc_moments) New function for calculating variance,
1559 (moments_pass_one) Only accumulate weights bigger than zero.
1560 (moments_calculate) Allow calculating the mean on pass one, others
1561 require pass two. Implement in terms of calc_moments().
1562 (struct moments1) New structure.
1563 (init_moments1) New function.
1564 (moments1_clear) Ditto.
1565 (moments1_create) Ditto.
1566 (moments1_add) Ditto.
1567 (moments1_calculate) Ditto.
1568 (moments1_destroy) Ditto.
1569 (cmd_debug_moments) Deal with `struct moments' or `struct
1570 moments1' as requested by user.
1572 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
1574 * Makefile.am (pspp_SOURCES): Remove debug.c.
1576 * debug.c: Removed. It was empty anyway.
1578 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
1580 * descript.c (calc_descriptives): Fix assert failure when only
1581 MOMENT_MEAN is needed.
1583 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
1587 fixed problem with parsing in match_statistic() causing
1588 "DESCRIPTIVE STAT=MEAN." to barf.
1590 "MEAN" is now default if "SORT" given without specification.
1592 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
1593 generally less forgiving of syntax errors: better to have it do
1594 nothing and type it in again then to not know what it actually did
1597 z-score transformation now checks score for user-missing values
1598 and checks std_dev for SYSMIS.
1600 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
1602 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
1603 Changed dict_get_case_weight() to accept an additional int * flag
1604 to complain about system-missing, user-missing, zero, or negative
1605 weights and updated existing functions to pass int * to
1606 dict_get_case_weight().
1608 2004-04-05 jmd <jmd@gnu.org>
1610 * main.c: Fixed configuration problems with gsl
1612 * t-test.q: Fixed some problems encountered when compiling under Cygwin
1614 2004-04-03 blp <blp@gnu.org>
1616 * lexer.c, ChangeLog:
1617 Fix infinite loop on comment at end of file, add test.
1619 2004-04-03 jmd <jmd@gnu.org>
1621 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
1622 Fixed the calculation of percentiles and added --syntax and --algorithm options
1624 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
1626 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
1629 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1631 * frequencies.q: Fixed the calculation of percentiles
1633 * Makefile.am: Added the --ansi flag and dealt with the
1634 consequences. Added some entries to PSPP_sources so that
1635 make distcheck would pass
1637 * cmdline.c: Added the --syntax and --algorithm options
1639 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
1641 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1643 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
1644 use the new multipass_split_... mechanism.
1646 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
1648 * frequencies.q: (calc_stats) Use moments data structure and
1649 calc_seskew(), calc_sekurt() functions.
1651 * set.q main.c settings.h Added support for --syntax and --algorithm
1654 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
1656 * vfm.c: Had to get last call to multipass_split_output() inside
1657 open_active_file()/close_active_file() pairing, so introduce new
1659 (internal_procedure) Move procedure() code here, except for calls
1660 to open_active_file() and close_active_file().
1661 (procedure) Wrap open_active_file() and close_active_file() around
1662 internal_procedure().
1663 (multipass_procedure_with_splits) Wrap open_active_file() and
1664 close_active_file() around internal_procedure().
1666 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1668 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1670 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1672 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1674 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1676 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1678 * algorithm.c: By default turn off some of the more expensive
1680 (expensive_assert) New macro which expands to assert if
1681 EXTRA_CHECKS is defined, to nothing otherwise.
1682 (unique) Use expensive_assert().
1683 (binary_search) Ditto.
1689 * command.c: (conflicting_3char_prefixes) Words that are the same
1690 don't cause conflicts when they are abbreviated to the first three
1693 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1694 nonterm_node's n earlier.
1695 (generic_str_func) Ditto.
1697 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1699 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1700 test multipass support, take advantage of new moments
1701 calculation, and to not be such crappy code. Get rid of q2c
1702 processing for DESCRIPTIVES.
1704 * vfm.c: (struct multipass_split_aux_data) New structure.
1705 (multipass_procedure_with_splits) New function.
1706 (multipass_split_callback) New function.
1707 (multipass_split_output) New function.
1708 * descript.q: Removed.
1710 * descript.c: New file.
1712 * var.h: Removed descriptives enums.
1713 (struct descriptives_proc) Removed.
1714 (struct variable) Removed p.dsc.
1716 * Makefile.am: (q_sources_c) Remove descript.c.
1717 (q_sources_q) Removed descript.q.
1719 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1721 New manager for keeping track of used workspace.
1723 * workspace.c: New file.
1725 * workspace.h: New file.
1727 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1729 * sort.c: (do_internal_sort) Use workspace_malloc().
1730 (destroy_internal_sort) Use workspace_free().
1732 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1734 New `struct casefile' for managing sets of cases.
1736 * casefile.c: New file.
1738 * casefile.h: New file.
1740 * command.def: Add DEBUG CASEFILE command.
1742 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1744 * sort.c: (sort_cases) Move logic for sending storage file to disk
1745 into do_external_sort().
1746 (struct internal_sort) Use an array of ccase pointers instead of a
1748 (do_internal_sort) Rewrite to handle casefiles.
1749 (compare_case_list) Removed.
1750 (compare_cases) New function.
1751 (compare_case_dblptrs) New function.
1752 (read_internal_sort_output) Deal with new struct internal_sort.
1754 * vfm.c: (static var workspace_overflow) Removed.
1755 (struct storage_stream_info) Removed all the members. Added
1756 struct casefile * member.
1757 (storage_sink_open) Use casefile.
1758 (open_storage_file) Removed.
1759 (write_storage_file) Removed.
1760 (storage_to_disk) Removed.
1761 (destroy_storage_stream_info) Use casefile.
1762 (storage_sink_write) Use casefile.
1763 (storage_sink_make_source) Use casefile.
1764 (storage_source_count) Use casefile.
1765 (storage_source_read) Use casefile.
1766 (storage_source_on_disk) Removed.
1767 (storage_source_get_cases) Removed.
1768 (storage_source_set_cases) Removed.
1769 (storage_source_get_casefile) New function.
1771 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1773 New `struct moments' for calculating moments.
1779 * moments.c: New file.
1781 * moments.h: New file.
1783 * command.def: Add DEBUG MOMENTS command.
1785 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1788 * aggregate.c: Modify AGGREGATE to use the new moments
1789 calculation, even if not in such a great way.
1790 (struct agr_var) Add `moments' member.
1791 (parse_aggregate_functions) Set `moments' member to null.
1792 (agr_destroy) Destroy `moments' member.
1793 (accumulate_aggregate_info) Use `moments' for standard deviation.
1794 (dump_aggregate_info) Ditto.
1795 (initialize_aggregate_info) Create or clear `moments'.
1797 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1798 cube(), pow4() that were in stats.h. All references updated.
1800 * crosstabs.q: stats.h had chi-square significance functions. Use
1802 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1804 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1805 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1807 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1809 * dictionary.c: (dict_compact_values) Compacted values need to
1812 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1814 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1815 `/' at start. Check return value of parse_variables() for error
1818 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1820 Revamp expressions: make the code a little nicer, and fix bugs
1823 * expr-evl.c: (expr_evaluate) Make expression argument const.
1824 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1825 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1826 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1827 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1828 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1829 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1830 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1831 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1832 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1833 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1834 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1835 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1836 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1838 * expr-opt.c: (optimize_expression) Rewrite.
1843 (macro s0l) Removed.
1845 (macro s1l) Removed.
1847 (macro s2l) Removed.
1850 (eq_num_con) New function.
1851 (optimize_tree) New function.
1852 (macro rnc) Removed.
1853 (macro frnc) Removed.
1854 (str_search) Add const to string params.
1855 (str_rsearch) Ditto.
1856 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1857 str[], str_len[] locals to substitute for most of removed macros.
1858 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1859 Removed support for missing values because we're never called with
1860 missing values. Use set_number() or set_number_errno() instead of
1861 rnc or frnc. Removed any stuff that caused trouble in testing.
1862 We can re-add it later if it really slows anything. Fix some
1864 (evaluate_tree_with_missing) Not yet supported. To be added later
1866 (repl_num_con) Removed.
1867 (collapse_node) New function.
1868 (force_repl_num_con) Removed.
1869 (set_number) New function.
1870 (set_number_errno) New function.
1871 (repl_str_con) Removed.
1872 (set_string) New function.
1873 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1875 (dump_node) No special case for OP_AND, OP_OR.
1877 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1878 (expr_get_type) New function.
1879 (type_check) Rewrite.
1880 (type_coercion) New function.
1881 (struct operator) New structure.
1882 (match_operator New function.
1883 (parse_binary_operators) New function.
1884 (parse_inverting_unary_operator) New function.
1885 (parse_or) Rewritten.
1886 (parse_and) Rewritten.
1887 (parse_not) Rewritten.
1888 (parse_rel) Rewritten.
1889 (parse_add) Rewritten.
1890 (parse_mul) Rewritten.
1891 (parse_neg) Rewritten.
1892 (parse_exp) Rewritten.
1893 (parse_sysvar) Add $TRUE, $FALSE system variables.
1894 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1895 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1897 (struct function) Remove desc, change `func' prototype.
1898 (unary_func) Remove special cases.
1899 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1900 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1901 (VALUE_func) Use allocate_var_node().
1902 (nary_num_func) Allow MIN and MAX for strings.
1903 Use allocate_var_node(). Properly clean up.
1905 (generic_str_func) Use local table instead of removed `desc'
1906 member. Mostly rewrite.
1907 (get_num_args) Revise error message.
1908 (parse_function) Return EXPR_ERROR, not 0 on error.
1910 (macro varies) Removed.
1911 (ops[]) Use expr.def.
1912 (free_node) Do nothing if node is null.
1913 (allocate_num_con) New function.
1914 (allocate_str_con) New function.
1915 (allocate_var_node) New function.
1916 (allocate_binary_nonterminal) New function.
1917 (append_nonterminal_arg) Removed.
1918 (static var func_tab[]) Revised.
1919 (expr_debug_print_postfix) Make parameter const.
1920 Use printf() instead of debug_printf().
1922 * expr.def: New file.
1924 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1925 use named enum instead of unnamed, all references updated. Add
1926 EXPR_ANY, EXPR_NO_OPTIMIZE.
1928 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1929 instead of defining OP_* directly.
1930 (macro IS_TERMINAL) New macro.
1931 (macro IS_NONTERMINAL) New macro.
1932 (enum OP_NO_FLAGS) New.
1934 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
1936 * error.c: (err_assert_fail) msg variable needs to be non-const.
1938 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
1940 * debug.c: (cmd_debug_evaluate) Rewrite.
1942 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
1944 Fix some CROSSTABS bit rot stupidity.
1946 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
1947 (internal_cmd_crosstabs) Initializes cells[] correctly.
1948 (float_M_suffix) Rename format_cell_entry(), change prototype,
1950 (display_crosstabulation) Fix cell formatting.
1952 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
1954 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
1955 to call lex_discard_line() to do that.
1957 * command.c: (run_command) Call lex_discard_line() after
1960 * lexer.c: (lex_entire_end) Change behavior.
1961 (lex_rest_of_line) Change behavior. Return const char *.
1962 (lex_discard_line) Don't clear getl_buf, don't emit message.
1964 * main.c: (handle_error) Emit message here.
1966 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
1967 instead of lex_entire_line().
1969 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
1971 * title.c: (get_title) Call lex_discard_line() after
1973 (cmd_file_label) Ditto.
1974 (cmd_document) Deal with const char * return value.
1976 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
1978 Removed REMARK command.
1980 * command.c: (extract_prefix) Removed.
1981 (output_line) Removed.
1982 (cmd_remark) Removed.
1984 * command.def: Remove REMARK.
1986 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
1988 Added abort() after lots of assert(0) invocations to avoid some
1989 compiler warnings. We really need a NOT_REACHED macro.
1991 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1993 * sort.c: Added missing call to temp_file_close. Changed error
1994 messages to warnings.
1996 * set.q: Improved setting of set_view{length,width} to be more tolerant
1999 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2001 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2002 used with incorrect syntax.
2004 * error.c, error.h et al: Overridden definition of assert for a
2007 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2008 subcommand was given when it ought to have been.
2010 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2012 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2016 (tab_joint_text) Ditto.
2018 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2020 * levene.c: Add #include.
2022 * set.q: (set_viewport) Add `int' argument to make its prototype
2023 correct for signal().
2025 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2027 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2030 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2032 Changed DFM from open-at-first-access to explicit-open. Before,
2033 calling dfm_get_record() or dfm_put_record() would automatically
2034 open the file. Now, you have to call dfm_open_for_reading() or
2035 dfm_open_for_writing() explicitly. This makes it possible to
2036 check permissions, file existence, etc. earlier.
2038 Also made struct file_handle more opaque, and clean up in general.
2040 * data-list.c: (cmd_data_list) Open handle for reading.
2042 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2044 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2045 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2046 (open_inline_file) Removed.
2047 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2048 it. Deal with line_number in extension record instead of file
2050 (dfm_get_record) Rewrote.
2051 (dfm_put_record) Rewrote.
2052 (dfm_push) Assert file is open and one of ours. Deal with
2053 line_number in extension record instead of file handle.
2054 (dfm_pop) Assert file is open and one of ours. Deal with
2055 line_number in extension record instead of file handle.
2056 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2059 * file-handle.h: (enum constants RH_RF_*) Removed.
2060 (enum constants FH_MD_*) Removed.
2061 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2062 `recform', `lrecl', `mode' members. Public references to
2063 `recform' changed to use handle_get_mode(), references to `lrecl'
2064 changed to use handle_get_record_width(). Added `private' member.
2065 (enum file_handle_mode) New.
2067 * file-handle.q: (struct private_file_handle) New structure.
2068 (struct file_handle_list) New structure.
2069 (static var files) New.
2070 (static var file_handles) Removed.
2071 (init_file_handle) Removed.
2072 (create_file_handle) Removed.
2073 (get_handle_with_name) New function.
2074 (get_handle_for_filename) New function.
2075 (cmd_file_handle) Rewritten.
2076 (hash_file_handle) Removed.
2077 (cmp_file_handle) Removed.
2078 (fh_init_files) Rewritten.
2079 (fh_parse_file_handle) Rewritten. Allows identifiers as
2081 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2083 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2084 references updated. Rewritten.
2085 (fh_record_width) Renamed handle_get_record_width(), all
2086 references updated. Rewritten.
2087 (handle_get_mode) New function.
2089 * file-type.c: (cmd_file_type) Open handle for reading.
2091 * filename.c: [unix] (struct file_identity) New structure.
2092 [unix] (fn_get_identity) New function.
2093 [unix] (fn_free_identity) New function.
2094 [unix] (fn_compare_file_identities) New function.
2095 [!unix] (struct file_identity) New structure.
2096 [!unix] (fn_get_identity) New function.
2097 [!unix] (fn_free_identity) New function.
2098 [!unix] (fn_compare_file_identities) New function.
2100 * lexer.c: (static var put) Renamed put_token, all references
2102 (static var put_tokstr) New.
2103 (static var put_tokval) New.
2104 (lex_init) Initialize put_tokstr().
2105 (restore_token) New function.
2106 (save_token) New function.
2107 (lex_get) Use restore_token().
2108 (lex_put_back) Use save_token().
2109 (lex_put_back_id) New function.
2110 (lex_put_forward) Removed.
2111 (lex_preprocess_line) Set put_token instead of using
2113 (lex_negative_to_dash) Use save_token(), set put_token directly.
2114 (dump_token) Use stderr instead of stdout.
2116 * main.c: (main) Remove call to cmd_init().
2118 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2120 * pfm-read.c: Use handle_get_filename() instead of trying to use
2121 h->fn directly, all over.
2123 * pfm-write.c: Ditto.
2125 * print.c: (internal_cmd_print) Open handle for writing.
2126 (dump_table) Use handle_get_filename().
2127 (print_trns_proc) Use handle_get_mode().
2128 (cmd_print_space) Use fh_parse_file_handle().
2129 Open handle for writing.
2130 [0] (debug_print) Removed.
2132 * sfm-read.c: Use handle_get_filename() instead of trying to use
2133 h->fn directly, all over.
2135 * sfm-write.c: Ditto.
2137 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2141 * autorecode.c: (arc_free) Free arc->src_values.
2143 * error.c: (msg) Free buf.
2145 * val-labs.c: (do_value_labels) Always free vars.
2147 * vfm.c: (close_active_file) If sink has no make_source then call
2148 its destroy function.
2150 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2152 Fixed cmd_parse() so that it always skips past a full command
2153 name. A few special commands for which this would be bad get
2154 special treatment. This lets us drop code for skipping past the
2155 end of a command name in most cmd_*() functions. It's not worth
2156 listing all the commands affected.
2158 * command.c: (struct command) Remove `cmd' member, replace by
2159 `name' member, all references updated. Remove `word', `next',
2160 `skip_entire_name' members.
2161 (macro DEFCMD) Deal with revised `struct command'.
2162 (macro UNIMPL) Ditto.
2163 (macro SPCCMD) New macro for commands whose last word shouldn't be
2165 (static array cmd_table[]) Make const, rename `commands', remove
2167 (macro COMMAND_CNT) New macro.
2168 (split_words) Removed.
2170 (FILE_TYPE_okay) Make parameter const.
2171 (cmd_parse) Improve error messages.
2172 (match_strings) New function.
2173 (next_word) New function.
2174 (enum command_match) New enum.
2175 (conflicting_3char_prefixes) New function.
2176 (conflicting_3char_prefix_command) New function.
2177 (cmd_match_words) New function.
2178 (count_matching_commands) New function.
2179 (get_command_name) New function.
2180 (free_words) New function.
2181 (unknown_command_error) New function.
2182 (figure_out_command) Renamed parse_command_name(), rewritten.
2184 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2185 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2186 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2189 * command.h: (macro SPCCMD) New.
2191 * include.c: (cmd_include_at) Removed.
2192 (cmd_include) Allow identifier to be used as filename.
2194 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2196 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2199 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2201 Start work on better test framework.
2203 * Makefile.am: (pspp_sources) Add debug.c.
2205 * debug.c: New file.
2207 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2208 cmd_debug_evaluate().
2210 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2212 * expr.h: (enum constant PXP_DUMP) Removed.
2214 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2216 * set.q: Implemented the SHOW command, and synced it to the existing
2219 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2220 changes as the window size is changed.
2222 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2223 environment variables if other methods are not available.
2225 glob.c: Removed a lot of global variables from glob.c and encapsulated
2228 random.c: Tidied up the way the random seed is set.
2230 str.c: Added a ds_vprintf function.
2232 error.c: Extended dump_message so that messages are always broken at
2235 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2237 * pfm-write.c: (bufwrite) Write out the correct element for string
2238 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2240 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2242 Get rid of static and global (!) vars in matrix-data.c.
2244 * matrix-data.c: (static var nr_data) Removed.
2245 (static var nr_factor_values) Removed.
2246 (static var max_cell_index) Removed.
2247 (static var split_values) Removed.
2248 (struct nr_aux_data) New structure.
2249 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2250 place of static vars, pass to create_case_source() and procedure()
2252 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2253 struct matrix_data_pgm *.
2254 (nr_read_splits) Ditto.
2255 (nr_read_factors) Ditto.
2256 (nr_output_data) Ditto.
2257 (static var wr_content) Removed.
2258 (global var wr_data) Removed.
2259 (global var wr_current) Removed.
2260 (struct wr_aux_data) New structure.
2261 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2262 place of static vars, pass to create_case_source() and procedure()
2264 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2265 instead of matrix_data_pgm *.
2266 (wr_read_splits) Ditto.
2267 (wr_output_data) Ditto.
2268 (wr_read_rowtype) Ditto.
2269 (wr_read_factors) Ditto.
2270 (wr_read_indeps) Ditto.
2272 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2274 Get rid of static vars in autorecode.c.
2276 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2277 `n_arc' to `spec_cnt'. All references updated.
2278 (static var v_src) Removed.
2279 (static var v_dest) Removed.
2280 (static var h_trns) Removed.
2281 (static var nv_src) Removed.
2282 (static var descend) Removed.
2283 (static var print) Removed.
2284 (enum direction) New enum.
2285 (struct autorecode_pgm) New structure.
2286 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2287 Move n_dest local var into struct autorecode_pgm for ease of
2288 clean-up. Use arc_free().
2289 (arc_free) New function.
2290 (recode) Modify to take struct autorecode_pgm * parameter instead
2291 of using statics. Let the caller clean up.
2292 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2293 instead of statics. Rearrange code a little.
2295 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2297 Get rid of static, global vars in recode.c. Remove debug code.
2299 * recode.c: (static var head) Removed.
2300 (global var v) Removed.
2301 (global var nv) Removed.
2302 (cmd_recode) New local variables head, v, nv. Initialize and free
2303 v. Don't call debug_print().
2304 [DEBUGGING] (dump_dest) Removed.
2305 [DEBUGGING] (debug_print) Removed.
2307 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2309 Get rid of static vars in expr-opt.c.
2311 * expr-opt.c: (static var e) Removed.
2312 (static var nop) Removed.
2313 (static var mop) Removed.
2314 (static var ndbl) Removed.
2315 (static var mdbl) Removed.
2316 (static var nstr) Removed.
2317 (static var mstr) Removed.
2318 (static var nvars) Removed.
2319 (static var mvars) Removed.
2320 (struct expr_dump_state) New structure.
2321 (dump_expression) Use new struct expr_dump_state instead of static
2322 vars and pass to functions we call.
2323 (dump_node) Use struct expr_dump_state * parameter.
2325 (emit_num_con) Ditto.
2326 (emit_str_con) Ditto.
2329 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2331 Get rid of static var in COUNT.
2333 * count.c: (static var head) Move into cmd_count().
2334 (cmd_count) [DEBUGGING] Don't call debug_print.
2335 [DEBUGGING] (debug_print) Removed.
2337 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2339 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2341 * val-labs.c: (static var v) Removed.
2342 (static var nv) Removed.
2343 [DEBUGGING] (debug_print) Removed.
2344 (verify_val_labs) Add struct variable **, int parameters.
2345 (get_label) Ditto. Improve error messages, streamline.
2346 (erase_labels) New function for erasing value labels, taking over
2347 part of verify_val_labs()'s function.
2350 (cmd_value_labels) No need to call init() or done() anymore.
2351 (cmd_add_value_labels) Ditto.
2352 (do_value_labels) Add vars, var_cnt local variables. Clean up
2353 after them internally. Call erase_labels() if we should. Don't
2356 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2358 Get rid of static vars in MATCH FILES.
2360 * get.c: (static var mtf_head) Removed.
2361 (static var mtf_tail) Removed.
2362 (static var mtf_by) Removed.
2363 (static var mtf_n_by) Removed.
2364 (static var mtf_master) Removed.
2365 (static var mtf_seq_num) Removed.
2366 (static var mtf_seq_nums) Removed.
2367 (static var mtf_sink) Removed.
2368 (static var mtf_case) Removed.
2369 (struct mtf_proc) New structure.
2370 (cmd_match_files) Use struct mtf_proc instead of static vars.
2371 (mtf_processing_finish) Ditto.
2373 (mtf_delete_file_in_place) Ditto.
2374 (mtf_read_nonactive_records) Ditto.
2375 (mtf_compare_BY_values) Ditto.
2376 (mtf_processing) Ditto.
2377 (mtf_merge_dictionary) Ditto.
2379 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2381 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2383 * dictionary.c: (dict_rename_var) Add assertion.
2384 (dict_contains_var) Check by index instead of name.
2386 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2388 Get rid of compaction_necessary, compaction_nval, compaction_case.
2389 Redo VFM interface. Replace disk_sink and memory_sink by
2390 storage_sink, disk_source and memory_source by storage_source.
2392 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2396 (struct write_case_data) Remove `begin_func', `end_func',
2397 `func_aux' members. Add `aux', `trns_case', `sink_case',
2398 `cases_written', `cases_analyzed' members.
2399 (global var compaction_necessary) Make static.
2400 (global var compaction_nval) Removed.
2401 (global var compaction_case) Removed.
2402 (static var case_count) Removed.
2403 (struct procedure_aux_data) Removed.
2404 (struct split_aux_data) Removed.
2405 (procedure) Remove begin_func, end_func parameters. Rewrite.
2406 (static var not_canceled) Removed.
2407 (process_active_file) Removed.
2408 (process_active_file_write_case) Removed.
2409 (process_active_file_output_case) Removed.
2410 (prepare_for_writing) Moved into open_active_file().
2411 (arrange_compaction) Ditto.
2413 (open_active_file) Rewrote.
2414 (write_case) New function.
2415 [DEBUGGING] (index_to_varname) Removed.
2416 (execute_transformations) New function.
2417 (exclude_this_case) Renamed filter_case(), changed interface.
2418 (clear_case) Added struct ccase * parameter to interface.
2419 (close_active_file) Added struct write_case_data * parameter,
2421 (disk_sink_create) Removed.
2422 (disk_sink_destroy) Removed.
2423 (disk_sink_make_source) Removed.
2424 (disk_sink_write) Removed.
2425 (disk_source_count) Removed.
2426 (disk_source_destroy) Removed.
2427 (disk_source_read) Removed.
2428 (global var disk_sink_class) Removed.
2429 (global var disk_source_class) Removed.
2430 (global var memory_sink_class) Removed.
2431 (global var memory_source_class) Removed.
2432 (memory_sink_create) Removed.
2433 (memory_sink_destroy) Removed.
2434 (memory_sink_make_source) Removed.
2435 (memory_sink_write) Removed.
2436 (memory_source_count) Removed.
2437 (memory_source_destroy) Removed.
2438 (memory_source_get_cases) Removed.
2439 (memory_source_read) Removed.
2440 (memory_source_set_cases) Removed.
2441 (struct disk_stream_info) Removed.
2442 (struct memory_sink_info) Removed.
2443 (struct memory_source_info) Removed.
2444 (write_active_file_to_disk) Removed.
2445 (destroy_storage_stream_info) New function.
2446 (global var null_sink_class) New var.
2447 (global var storage_sink_class) New var.
2448 (global var storage_source_class) New var.
2449 (open_storage_file) New function.
2450 (storage_sink_destroy) New function.
2451 (storage_sink_make_source) New function.
2452 (storage_sink_open) New function.
2453 (storage_sink_write) New function.
2454 (storage_source_count) New function.
2455 (storage_source_destroy) New function.
2456 (storage_source_get_cases) New function.
2457 (storage_source_on_disk) New function.
2458 (storage_source_read) New function.
2459 (storage_source_set_cases) New function.
2460 (storage_source_to_disk) New function.
2461 (storage_to_disk) New function.
2462 (struct storage_stream_info) New structure.
2463 (write_storage_file) New function.
2464 (procedure_write_case) Removed.
2465 (create_case_source) Add `struct dictionary *' parameter, all
2467 (create_case_sink) Ditto.
2468 (free_case_sink) New function.
2469 (struct split_aux_data) New structure.
2470 (procedure_with_splits) New function implementing what procedure()
2472 (SPLIT_FILE_proc_func) Removed.
2473 (procedure_with_splits_callback) New function.
2474 (equal_splits) New function.
2476 * aggregate.c: Pass around a struct instead of using statics.
2477 (static var outfile) Remove.
2478 (enum type) Give it tag `missing_treatment'.
2479 (static var missing) Remove.
2480 (static var sort) Remove.
2481 (static var agr_first) Remove.
2482 (static var agr_next) Remove.
2483 (static var case_count) Remove.
2484 (static var prev_case) Remove.
2485 (static var buf64_1xx) Remove.
2486 (static var buf_1xx) Remove.
2487 (struct agr_proc) New structure incorporating the above.
2488 (cmd_aggregate) Use new struct. Clean up error handling using
2489 agr_destroy(). Completely rewrite actual implementation of
2491 (create_sysfile) Add struct agr_proc * parameter, modify
2493 (parse_aggregate_functions) Ditto.
2494 (free_aggregate_functions) Ditto. Rename agr_destroy().
2495 (aggregate_single_case) Add struct agr_proc * parameter, modify
2497 (accumulate_aggregate_info) Ditto.
2498 (dump_aggregate_info) Ditto.
2499 (initialize_aggregate_info) Ditto.
2500 (agr_00x_trns_proc) Removed.
2501 (agr_00x_end_func) Removed.
2502 (agr_10x_trns_proc) Removed.
2503 (agr_10x_trns_free) Removed.
2504 (agr_10x_end_func) Removed.
2505 (agr_11x_read) Removed.
2506 (agr_11x_finish) Removed.
2507 [DEBUGGING] (debug_print) Removed.
2508 (write_case_to_sfm) Add struct agr_proc * parameter, modify
2510 (agr_to_active_file) New function.
2511 (presorted_agr_to_sysfile) New function.
2512 (sort_agr_to_sysfile) New function.
2514 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
2516 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
2518 * descript.q: (cmd_descriptives) Ditto.
2520 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
2521 to new procedure() interface.
2523 * command.c: (cmd_execute) Adapt to new procedure() interface.
2525 * dictionary.c: (dict_compact_values) Also delete scratch
2527 (dict_get_compacted_value_cnt) New function.
2528 (dict_get_compacted_idx_to_fv) New function.
2530 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
2531 (cmd_flip) Adapt to new procedure() interface.
2532 (flip_sink_write) Use sink->idx_to_fv.
2534 * frequencies.q: (internal_cmd_frequencies) Use
2535 procedure_with_splits().
2537 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
2538 (static var mtf_sink) New static var.
2539 (static var mtf_case) New static var.
2540 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
2541 we actually implement the matching.
2542 (mtf_delete_file_in_place) Use mtf_case.
2543 (mtf_processing) Use mtf_case and mtf_sink.
2544 (cmd_export) Adapt to new procedure() interface.
2546 * levene.c: (levene) Use procedure_with_splits().
2548 * list.q: (cmd_list) Use procedure_with_splits().
2550 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
2551 procedure() interface.
2552 (read_matrices_with_rowtype) Ditto.
2554 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
2555 TEMPORARY. Adapt to new procedure() interface.
2557 * rename-vars.c: Warn about and cancel TEMPORARY.
2559 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
2560 (sort_cases) Use dict_get_compacted_value_cnt() instead of
2561 compaction_nval. Adapt to new procedure() interface. Use
2562 storage_source_to_disk().
2563 (do_internal_sort) Don't try to dump the cases to memory.
2564 (compare_case_lists) Pass null idx_to_fv.
2565 (struct initial_run_state) Add `idx_to_fv' member. Remove
2567 (write_initial_runs) Don't initialize irs->case_size. Adapt to
2568 new procedure() interface. Reset irs->idx_to_fv after calling
2570 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
2571 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
2573 (destroy_initial_run_state) Don't dereference irs after freeing
2575 (allocate_cases) Don't calculate case_size locally.
2576 (compare_record) Add idx_to_fv parameter.
2577 (compare_record_run) Change parameter from struct sort_cases_pgm *
2578 to struct initial_run_state *. Pass irs->idx_to_fv to
2580 (compare_record_run) Third parameter now a struct
2581 initial_run_state *.
2582 (output_record) No need for out_case anymore. Pass irs, not
2583 struct sort_cases_pgm to pop_heap(). Use case_size from struct
2585 (merge) Use case_size from struct sort_cases_pgm.
2586 (merge_once) Use case_size from struct sort_cases_pgm.
2587 Pass null pointer to compare_record() as idx_to_fv.
2588 (global var sort_sink_class) Make static.
2590 * t-test.q: (cmd_t_test) Use procedure_with_splits().
2592 * temporary.c: Remove debugging crap.
2594 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
2596 * t-test.q, levene.c: Fixed up the handling of MISSING values
2599 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
2601 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
2604 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
2606 Change explicit variable name checks into use of
2607 dict_class_from_id().
2609 * dictionary.c: (dict_create_var) Change explicit variable name
2610 check into use of dict_class_from_id().
2612 * get.c: (trim_dictionary) Ditto.
2614 * sel-if.c: (cmd_filter) Ditto.
2616 * sysfile-info.c: (cmd_display) Ditto.
2618 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
2620 * vfm.c: (arrange_compaction) Ditto.
2622 * weight.c: (cmd_weight) Ditto.
2624 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
2626 * temporary.c: (cmd_temporary) When TEMPORARY was the first
2627 transformation following the input program, if any, for some
2628 reason we special-cased f_trns. That's just wrong. It should
2629 always be set to n_trns.
2631 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
2633 * format.c: (parse_format_specifier_name) Fix brown-bag bug
2634 introduced in last check-in.
2636 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
2638 * format.c: (global array translate_fmt[]) Removed.
2639 (translate_fmt) New function as replacement.
2640 (parse_format_specifier_name) Rewrite.
2642 * pfm-read.c: (convert_format) Use translate_fmt() instead of
2645 * sfm-read.c: (parse_format_spec) Ditto.
2647 * postscript.c: (text) Fix handling of fonts with missing
2650 * sort.c: (struct external_sort) Add temp_name member.
2651 (destroy_external_sort) Free temp_dir, temp_name members.
2652 (init_external_sort) Allocate temp_name.
2653 (get_temp_file_name) Change prototype.
2654 (open_temp_file) Deal with change to get_temp_file_name().
2655 (close_temp_file) Ditto.
2656 (remove_temp_file) Ditto.
2657 (write_temp_file) Ditto.
2658 (read_temp_file) Ditto.
2659 (sort_sink_destroy) Removed.
2660 (sort_sink_class) Change destroy member to null.
2662 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2664 Eliminate temp_case.
2666 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2667 anymore. Use agr_11x_finish().
2668 (aggregate_single_case) Make first param const.
2669 (accumulate_aggregate_info) Ditto.
2670 (agr_00x_end_func) Use compaction_case, not temp_case.
2671 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2673 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2674 (cmd_data_list) Initialize case_size.
2675 (read_from_data_list_fixed) Add struct ccase * param, use instead
2677 (read_from_data_list_free) Ditto.
2678 (read_from_data_list_list) Ditto.
2679 (read_one_case) Rename data_list_trns_proc(), all references
2680 updated. Add argument in calling above functions. Use c
2681 argument instead of temp_case.
2682 (destroy_dls) Rename data_list_trns_free(), all references
2685 * expr-evl.c: (expr_evaluate) Make second parameter const.
2687 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2688 (cmd_end_file_type) Initialize `case_size'.
2689 (file_type_source_read) Add struct ccase * parameter. Use instead
2692 * flip.c: Rewritten.
2694 * get.c: (struct get_pgm) New structure to keep track of
2696 (cmd_get) Initialize case_size.
2698 (get_source) Deal with struct get_pgm.
2699 (get_source_read) Add struct ccase * parameter, use instead of
2701 (import_source_read) Ditto.
2703 * get.c: Use a null pointer instead of temp_case to represent the
2704 "current case" in a struct mtf_file's input member.
2705 (mtf_processing_finish) Pass null to mtf_processing(), not
2707 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2708 (mtf_compare_BY_values) Add extra arg, use instead of null input
2710 (mtf_processing) Use c parameter instead of temp_case. Pass
2711 compaction_case to process_active_file_output_case().
2713 * glob.c: (global variable temp_case) Removed.
2715 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2716 (cmd_input_program) Initialize case_size. Set
2717 vfm_source->value_cnt.
2718 (init_case) Add struct ccase * parameter, use instead of
2721 (input_program_source_read) Ditto.
2723 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2724 (dump_cell_content) Ditto.
2725 (nr_output_data) Ditto.
2726 (read_matrices_without_rowtype) Ditto.
2727 (matrix_data_read_with_rowtype) Ditto.
2728 (wr_read_splits) Ditto.
2729 (wr_output_data) Ditto.
2731 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2733 * sort.c: (sort_cases) Initialize scp->case_size.
2734 (struct external_sort) Remove `case_size' member.
2735 (write_initial_runs) Only call vfm_sink->class_destroy if
2737 (struct sort_source_aux) New structure.
2738 (sort_source_read_helper) New function.
2739 (sort_source_read) Use sort_source_read_helper().
2740 (read_sort_output) Change interface to be more reasonable.
2741 (read_internal_sort_output) Ditto.
2742 (read_external_sort_output) Ditto.
2744 * vars-prs.c: (dict_class_to_name) Pass return value through
2747 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2748 (procedure) Initialize trns_case.
2749 (procedure) Pass trns_case to vfm_source->class->read().
2751 (process_active_file) Start using struct procedure_aux_data.
2752 (process_active_file_write_case) Pass trns_case to
2753 transformations, lag_case(), clear_case().
2754 (process_active_file_output_case) Add struct ccase * parameter.
2755 (create_trns_case) New function.
2756 (make_temp_case) Removed.
2757 (vector_initialization) Removed.
2758 (close_active_file) Only call make_source if non-null, otherwise
2759 set vfm_source to null pointer. Don't free temp_case.
2760 (disk_source_read) Add struct ccase * parameter, use instead of
2762 (memory_source_read) Ditto.
2763 (lag_case) Add const struct ccase * member.
2764 (procedure_write_case) Use trns_case instead of temp_case.
2765 (clear_case) Add struct ccase * member, use instead of temp_case.
2766 (exclude_this_case) Ditto.
2767 (create_case_source) Add struct dictionary * parameter, use to
2768 initialize source->value_cnt.
2770 * vfm.h: (struct case_source) Add `value_cnt' member.
2771 (struct case_source_class) Add struct ccase * parameter to `read'
2772 member function pointer.
2773 (struct case_sink_class) Make struct ccase * parameter const in
2774 `write' member function pointer.
2776 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2778 Fix a lot of "possibly uninitialized variable" warnings. Some of
2779 them are even real bugs. A few of them make me wonder how the
2782 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2784 * ascii.c: (output_lines) Add default case to switch.
2786 * crosstabs.q: Remove static variable `expected' and all
2788 (display_crosstabulation) Always calculate expected value.
2790 (output_pivot_table) Initialize `cmp'.
2791 (display_crosstabulation) New variable `last_row', which is
2794 * data-in.c: (parse_numeric) Always initialize sign. How did this
2797 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2798 Always set info.ofs. (How did this work?!)
2800 * expr-opt.c: (optimize_tree) Always initialize `m'.
2801 (evaluate_tree) Always initialize `c'. (How did this work?)
2803 * frequencies.q: (frq_custom_variables) Always initialize min,
2805 (frq_custom_grouped) Always initialize `dl'.
2807 * groff-font.c: (groff_read_font) Always initialize char_set.
2809 * matrix-data.c: (nr_output_data) Initialize `split'.
2810 (wr_read_splits) Remove shadowing split_cnt declaration.
2811 (wr_output_data) Initialize `split'.
2813 * output.c: (tokener) Skip add character on syntax error.
2815 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2817 * postscript.c: (read_ps_encodings) Use line.string instead of
2819 (write_text) Add default case to switch.
2820 (text) Always initialize multiple variables. Fix bug with
2823 * print.c: (fixed_parse_fortran) Initialize head.
2824 (alloc_line) Add default case to switch.
2826 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2827 (recode_trns_proc) Move variable declaration inward. Add default
2830 * sfm-read.c: (read_header) Initialize skip_amt.
2832 * sysfile-info.c: (display_variables) Always initialize pc.
2834 * vars-prs.c: Initialized `included'.
2836 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2838 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2839 Just use signal() instead.
2841 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2843 Get rid of vfm_sink_info and vfm_source_info.
2845 * aggregate.c: (agr_00x_end_func) Don't increment
2846 sfm_sink_info.ncases.
2848 * sort.c: (do_internal_sort) Get case count from
2849 vfm_source->class->count().
2850 (struct external_sort) Add `case_size' member.
2851 (do_external_sort) Initialize case_size.
2852 (struct initial_run_state) Add `case_size' member.
2853 (write_initial_runs) Initialize case_size.
2854 (sort_sink_write) Use case_size.
2855 (read_external_sort_output) Use case_size. Get case_cnt from
2858 * vfm.c: (struct write_case_data) Add underscores to existing arg
2859 names, all references updated. Renamed `aux' as `func_aux', all
2860 references updated. Added new `aux' member.
2861 (global var vfm_source_info) Removed.
2862 (global var vfm_sink_info) Removed.
2863 (struct procedure_aux_data) New.
2864 (struct split_aux_data) New.
2865 (procedure) Use `aux' fields for procedure_aux_data,
2867 (process_active_file_write_case) Pass case_count + 1 to
2868 transformation procedures, exclude_this_case().
2869 (process_active_file_output_case) Don't increment
2870 vfm_sink_info.ncases.
2871 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2872 to send data to disk early.
2873 (make_temp_case) Don't use vfm_sink_info.case_size.
2874 (close_active_file) Don't initialize vfm_source_info.
2875 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2876 (disk_sink_create) Initialize and/or update disk_stream_info.
2877 (disk_sink_write) Ditto.
2878 (disk_sink_destroy) Ditto.
2879 (disk_sink_make_source) Ditto.
2880 (disk_source_read) Ditto.
2881 (disk_source_destroy) Ditto.
2882 (global var disk_source_class) Add disk_source_count().
2883 (disk_source_count) New function.
2884 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2885 (struct memory_source_info) Ditto.
2886 (memory_sink_create) Deal with case_cnt, case_size.
2887 (memory_sink_write) Ditto.
2888 (memory_sink_make_source) Ditto.
2889 (memory_source_read) Ditto.
2890 (memory_source_count) New function.
2891 (memory_source_class) Add memory_source_count().
2892 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2893 proc_aux->cases_written, and pass it to transformation procedures
2894 and exclude_this_case ().
2895 (exclude_this_case) Add case_num parameter. Pass it to
2897 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2900 * vfm.h: (struct case_source_class) Add `count' member.
2902 * vfmP.h: (struct stream_info) Removed.
2903 (global variable vfm_source_info) Removed.
2904 (global variable vfm_sink_info) Removed.
2906 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2908 * var.h: (typedef trns_proc_func) New typedef.
2909 (trns_free_func) New typedef.
2910 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2911 to type trns_free_func. This only changes the actual type of
2912 trns_proc_func, adding a `case_num' parameter. Updated all
2913 implementations to use the typedefs instead.
2915 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2916 (compute_num_vec) Ditto.
2917 (compute_str) Ditto.
2918 (compute_str_vec) Ditto.
2920 * do-if.c: (do_if_trns_proc) Ditto.
2922 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2925 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2926 pass to transformation functions.
2927 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2929 * loop.c: (loop_1_trns_proc) Ditto.
2930 (loop_2_trns_proc) Ditto.
2931 (loop_3_trns_proc) Ditto.
2933 * print.c: (print_space_trns_proc) Ditto.
2935 * sel-if.c: (select_if_proc) Ditto.
2937 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
2939 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
2940 destroying hash table.
2942 * glob.c: (read_active_file) Variable not referenced, removed.
2943 (cancel_input_pgm) Ditto.
2945 * levene.c: Add #include <stdlib.h> needed to call free().
2947 * aggregate.c: (parse_aggregate_functions) Make `function'
2950 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
2952 Start working to eliminate VFM dependence on static variables.
2954 * command.c: (cmd_parse) Use case_source_is_class().
2956 * data-list.c: Rewrite to eliminate use of static variables.
2958 * dfm.c: (cmd_begin_data) Use case_source_is_class().
2960 * file-handle.q: (fh_handle_name) Make parameter const.
2962 * file-type.c: Rewrite to eliminate use of static variables.
2964 * flip.c: Rewrite to eliminate use of static variables.
2966 * format.c: (get_format_var_width) New function.
2968 * get.c: Eliminate use of static variables.
2970 * inpt-pgm.c: Eliminate use of static variables.
2972 * matrix-data.c: Eliminate use of static variables.
2974 * set.q: (set_max_workspace) New variable.
2975 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
2977 * var.h: (struct case_list) Move here from vfmP.h.
2979 * vars-atr.c: (discard_variables) Handle new vfm_source type.
2981 * vfm.c: (vfm_source) Change type from struct case_stream to
2983 (vfm_sink) Change type from struct case_stream to struct
2985 (static var paging) Rename workspace_overflow, all references
2987 (procedure) Use new class structures.
2988 (process_active_file) Ditto.
2989 (process_active_file_write_case) Ditto.
2990 (prepare_for_writing) Use set_max_workspace. Use new class
2992 (close_active_file) Use new class structures. Free old sink.
2993 (global var disk_source_file) Removed.
2994 (global var disk_sink_file) Removed.
2995 (disk_stream_init) Removed.
2996 (disk_stream_read) Removed.
2997 (disk_stream_write) Removed.
2998 (disk_stream_mode) Removed.
2999 (disk_stream_destroy_source) Removed.
3000 (disk_stream_destroy_sink) Removed.
3001 (global var vfm_disk_stream) Removed.
3002 (disk_sink_create) New function.
3003 (disk_sink_write) New function.
3004 (disk_sink_destroy) New function.
3005 (disk_sink_make_source) New function.
3006 (disk_sink_class) New static var.
3007 (disk_source_read) New function.
3008 (disk_source_destroy) New function.
3009 (global var vfm_source_class) New var.
3010 (global var memory_source_cases) Removed.
3011 (global var memory_sink_cases) Removed.
3012 (global var memory_sink_max_cases) Removed.
3013 (struct memory_sink_info) New struct.
3014 (memory_stream_init) Removed.
3015 (memory_stream_read) Removed.
3016 (memory_stream_write) Removed.
3017 (memory_stream_mode) Removed.
3018 (memory_stream_destroy_source) Removed.
3019 (memory_stream_destroy_sink) Removed.
3020 (global var vfm_memory_stream) Removed.
3021 (page_to_disk) Renamed write_active_file_to_disk().
3022 (memory_sink_create) New function.
3023 (memory_sink_write) New function.
3024 (memory_sink_destroy) New function.
3025 (memory_sink_make_source) New function.
3026 (memory_sink_class) New static var.
3027 (memory_source_read) New function.
3028 (memory_source_destroy) New function.
3029 (memory_source_get_cases) New function.
3030 (memory_source_set_cases) New function.
3031 (global var vfm_source_class) New var.
3032 (procedure_write_case) Use new class structures.
3033 (create_case_source) New function.
3034 (case_source_is_complex) New function.
3035 (case_source_is_class) New function.
3036 (create_case_sink) New function.
3038 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3039 (global variable reinit_blanks) Not used, removed.
3040 (global variable init_zero) Not used, removed.
3041 (global variable init_blanks) Not used, removed.
3042 (struct case_source) New struct.
3043 (struct case_source_class) New struct.
3044 (struct case_sink) New struct.
3045 (struct case_sink_class) New struct.
3046 (struct case_stream) Removed.
3048 * vfmP.h: (struct case_list) Moved to var.h.
3050 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3052 * algorithm.c: (count_equal) New function.
3053 (count_if) New function.
3054 (unique) Add assertions.
3055 (partition) Add assertions.
3056 (is_partitioned) New function.
3057 (copy_if) Add assertions.
3058 (remove_equal) Add assertions.
3059 (lexicographical_compare) Rename lexicographical_compare_3way.
3060 (sort) Add assertions. Rephrase some code.
3061 (is_sorted) New function.
3063 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3067 * sort.c: Completely rewrite.
3069 * sort.h: Expose interface via struct sort_cases_pgm, not via
3072 * aggregate.c: (sort) New static var.
3073 (cmd_aggregate) Use sort.
3074 (create_sysfile) Ditto.
3075 (aggregate_single_case) Ditto.
3076 (dump_aggregate_info) Ditto.
3077 (agr_00x_end_func) Ditto.
3078 (debug_print) Ditto.
3080 * var.h: (enum SRT_ASCEND) Removed.
3081 (enum SRT_DESCEND) Removed.
3082 (struct sort_cases_proc) Removed.
3083 (struct variable) Remove p.srt member.
3085 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3087 Get rid of the old, crappy heap structure and replace it by a new,
3088 shiny, C++ STL-like heap structure.
3090 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3092 * algorithm.c: (push_heap) New function.
3103 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3105 Increase warning level.
3107 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3109 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3111 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3113 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3115 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3116 around by previous change log entry.
3118 * compute.c: (lvalue_finalize) Remove workaround from previous
3121 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3123 * compute.c: Fixed a bug where the Format was not getting set for
3124 computed variables (thus causing a crash when SAVEing).
3126 * Added a test to stop this bug ever coming back
3128 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3130 Got rid of approx.h. In general, replaced all references to
3131 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3134 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3136 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3137 test for mag < EPSILON.
3139 * misc.h: Add definition of EPSILON.
3141 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3143 * vfm.c: (procedure) Add check to prevent recursive call.
3145 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3147 * Moved the declarations relating to values to their own header file
3150 * Added levene.c and levene.h
3152 * vars-atr.c: Changed the signature of compare_values to
3153 take const * arguments.
3155 * t-test.q: Changed the structure of struct t_test_proc
3156 variables now contain their own group statistics information.
3157 Eventually, t_test_proc might get renamed, because it'd be
3158 applicable to other commands too.
3160 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3162 * data-out.c: Clean up. Changed interface of convert_*() to take
3163 either a `double' or a `const char *' instead of a `const union
3164 value *'. Update all implementations of those interfaces.
3165 (data_out) Use switch statements instead of a table.
3166 (convert_AHEX) Rewrite.
3168 * format.h: Update comment.
3170 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3172 * q2c.c: (dump_header) Add an Emacs header line to output files
3173 that makes generated .c files read-only by default, to make it
3174 difficult to accidentally change generated files.
3176 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3178 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3179 not bogus a->v.c <=> b->v.c pointer compare.
3180 (compare_freq_alpha_a) Ditto.
3181 (compare_freq_numeric_d) Ditto.
3182 (compare_freq_alpha_d) Ditto.
3184 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3186 Changed data_out() to store string data directly into a `union
3187 value''s s member, not indirectly into c.
3189 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3191 (table_value_missing) Ditto.
3192 (float_M_suffix) Ditto.
3193 (format_short) New function.
3195 * data-in.h: (data_in_finite_line) Remove inline definition.
3197 * data-list.c: (destroy_dls_var_spec) New function.
3198 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3199 (data_list_source_destroy_source) Avoid cast.
3200 (struct repeating_data_trns) New field `id_value'. Update
3202 (cmd_repeating_data) Initialize id_value. Use new
3203 repeating_data_trns_free() for freeing REPEATING DATA
3205 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3206 (repeating_data_trns_free) New function.
3208 * data-out.c: (data_out) Change return type to `void' by replacing
3209 error returns by writing a message into the output buffer.
3210 (convert_A) Read from v->s instead of v->c.
3211 (convert_AHEX) Ditto.
3213 * expr-evl.c: Update comment.
3214 (expr_evaluate) Add assertion in OP_STRING case.
3216 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3218 * list.q: (list_cases) Update for new data_out() semantics.
3220 * print.c: (print_trns_proc) Ditto.
3222 * tab.c: (tab_value) Ditto.
3223 (tab_float) Avoid stupid cast.
3225 * var.h: Update comments.
3226 (macro MAX_STRING) New macro.
3227 (macro MAX_ELEMS_PER_VALUE) New macro.
3229 * vars-atr.c: (compare_values) New function.
3231 * vfm.c: (dump_splits) Update for new data_out() semantics.
3233 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3235 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3237 (struct crosstab) Rename v[] to vars[]. All references updated.
3238 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3239 same time, which caused the hash value to depend only on a single
3240 value, not all of the variables' values.
3242 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3244 Clean up struct dictionary's value_cnt usage.
3246 * dictionary.c: Add a function comment to each function.
3247 (struct dictionary) Rename value_cnt to next_value_idx, which more
3248 accurately reflects its meaning. All references updated.
3249 (dict_rename_vars) Add assertion.
3250 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3252 (dict_get_case_size) New function.
3254 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3256 * get.c: (mtf_read_nonactive_records) Ditto.
3258 * sort.c: (allocate_cases) Ditto.
3259 (write_initial_runs) Ditto.
3263 * vfm.c: (prepare_for_writing) Ditto.
3267 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3269 Make vfm.c slightly less grotesque.
3271 * vfm.c: (filter_var) Removed.
3272 (filter_index) Removed.
3273 (FILTERED macro) Removed.
3274 (exclude_this_case) New function.
3275 (process_active_file_write_case) Use exclude_this_case() instead
3276 of FILTERED and inline tests.
3277 (procedure_write_case) Ditto.
3278 (setup_filter) Removed.
3279 (open_active_file) Don't call setup_filter().
3280 (close_active_file) Call dict_get_filter() instead of checking
3283 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3285 * var.h: (struct variable) Update comments.
3287 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3289 New functions dict_create_var_assert(), dict_lookup_var_assert().
3290 Converted several dict_*_var()/assert pairs into a single
3291 dict_*_var_assert().
3293 * dictionary.c: (dict_create_var_assert) New function.
3294 (dict_lookup_var_assert) New function.
3296 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3298 Got rid of "struct long_vec", envector(), devector(), etc. Added
3299 two members `init', `reinit' to struct variable as a substitute.
3301 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3307 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3310 * autorecode.c: (cmd_autorecode) destvars don't need init.
3312 * compute.c: (lvalue_finalize) Set reinit.
3314 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3315 (dump_fmt_list) Ditto.
3318 * descript.q: (run_z_pass) Don't need init for z-scores.
3320 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3322 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3324 * glob.c: (init_glob) Remove vec_init() calls.
3326 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3328 * loop.c: (internal_cmd_loop) Don't need to call envector().
3330 * numeric.c: (cmd_numeric) Ditto.
3332 (cmd_leave) Ditto. Set `init', `reinit' members.
3334 * recode.c: (cmd_recode) Don't need to call envector().
3336 * repeat.c: (internal_cmd_do_repeat) Ditto.
3338 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3339 (force_create_variable) Removed prototype.
3340 (force_dup_variable) Ditto.
3342 * vector.c: (cmd_vector) Don't need to call envector().
3344 * vfm.c: (reinit_sysmis) Removed.
3345 (reinit_blanks) Removed.
3346 (init_zero) Removed.
3347 (init_blanks) Removed.
3348 (process_active_file_write_case) No need to deal with vectors.
3349 Call clear_temp_case().
3350 (vector_initialization) Rewrite to use `init', `reinit'.
3351 (close_active_file) No need to call vec_clear().
3352 (procedure_write_case) Call clear_temp_case().
3353 (clear_temp_case) New function.
3355 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3357 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3360 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3362 Add auxiliary argument to procedure() interface. Associated small
3363 clean-ups of vfm interface.
3365 * Updated every caller of procedure() and process_active_file() to
3366 reflect modified interface. Simple, ordinary changes not listed
3369 * Updated every function that implements struct case_stream's
3370 `read' function to take a write_case_func and a write_case_data.
3371 Also updated every caller of write_case() to instead call them
3372 through these arguments. In some cases this meant that the extra
3373 args had to be threaded through a couple of extra levels. This
3374 wasn't difficult or interesting so the details won't be given.
3376 * data-list.c: (struct repeating_data_trns) Add members
3377 `write_case', `wc_data' as kluge.
3378 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3380 (repeating_data_set_write_case) New function.
3382 * data-list.h: New file to declare repeating_data_trns_proc() and
3383 repeating_data_set_write_case().
3385 * inpt-pgm.c: (input_program_source_read) Call
3386 repeating_data_set_write_case() for all the REPEATING DATA
3387 transformations, so that they know where to send their cases.
3388 It's a big kluge. Also kluge in END CASE.
3389 (end_case_trns_proc) Never called anymore, but we still need it,
3392 * sort.c: (read_sort_output) Update to match struct case_stream
3395 * vfm.c: (struct write_case_data) New structure.
3396 (proc_func) Removed.
3397 (virt_proc_func) Removed.
3398 (begin_func) Removed.
3399 (virt_begin_func) Removed.
3401 (write_case) Removed.
3402 (procedure) Added an auxiliary parameter to each function pointer
3403 argument's prototype. Added an auxiliary data parameter.
3405 (process_active_file) Ditto.
3406 (process_active_file_write_case) Pass aux data along.
3407 (close_active_file) Ditto.
3408 (procedure_write_case) Ditto.
3409 (SPLIT_FILE_procfunc) Ditto.
3411 * vfm.h: (typedef write_case_data) New.
3412 (typedef write_case_func) New.
3413 (struct case_stream) Add parameters to `read' member prototype.
3415 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3417 * t-test.q: Added calculations for independent samples. (But no Levene
3420 * Makefile.am: Moved q_sources_c into own variable
3422 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3424 Miscellaneous cleanups.
3426 * Change unused to UNUSED in many source files to reflect modified
3427 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3428 __CYGWIN32__, __unix__, and unix not to assume that they're
3429 defined to a nonzero value. Change use of __attribute__ to use
3430 NO_RETURN or PRINTF_FORMAT instead.
3432 * alloc.h: Move definitions for local_alloc(), local_free() here
3433 from ../pref.h.orig and simplify.
3435 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3436 use a pool allocator unconditionally.
3437 (CHECK_STRING_SPACE) Removed.
3438 (ALLOC_STRING_SPACE) Removed.
3439 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
3442 * expr-opt.c: (dump_expression) Allocate string pool.
3444 * expr-prs.c: (expr_free) Free string pool.
3446 * pool.c: (pool_destroy) This pool must be removed from its
3447 parent's list of gizmos, not from its own. Use free_all_gizmos().
3448 (pool_clear) New function.
3449 (free_all_gizmos) New function.
3450 (pool_alloc) Use space in empty block after this one if any.
3451 (pool_release) Only empty out blocks, don't actually free() them.
3453 * print.c: Get rid of PAGED_STACK special case by always
3454 dynamically allocating line buffers.
3455 (struct print_trns) Always include the `line' member.
3456 (internal_cmd_print) Always initialize the `line' member.
3457 (alloc_line) Always allocate memory for `line'.
3458 (print_trns_proc) Always initialize buf from `line' member.
3459 (print_trns_free) Always free `line' memory.
3461 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
3464 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
3466 * flip.c: Fixed crash from FLIP when a numeric variable is
3467 specified on NEWNAMES and a large value is used, and a couple of
3468 other minor bugs besides.
3469 (struct varname) Make name a 9-character fixed-size array
3470 instead of a 1-character variable size array.
3471 (make_new_var) Allow digits in variable names.
3472 (flip_stream_write) Limit numeric values to 8 characters and
3473 format system missing and very large and small values more
3476 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3478 * command.c: Fixed test on command return status for the correct
3479 value, which had been causing a crash under certain invalid input.
3481 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3483 * t-test.q: Added calculations for the one sample variant of the T-TEST
3485 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
3487 * tab.c: (render_strip) Fix bug that sometimes caused joined text
3488 in joined cells to be rendered outside box boundaries.
3490 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3492 * random.c (rng_create): Fixed seeding so that it gets reseeded after
3493 SET seed=xx has been called.
3495 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
3497 * random.c (rng_get_double): Fix always-returning-zero bug in my
3498 preferred way, and at the same time make sure rounding doesn't
3501 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
3503 * html.c: (change_attributes) Dead code, removed.
3504 (escape_string) Eliminate code to call change_attributes() that
3505 never actually called it.
3506 (output_tab_table) Get rid of dependence on tab_hit
3507 and struct tab_joined_cell's hit member, which are abominations.
3509 * tab.c: (tab_output_text) Don't call
3510 d->class->text_set_font_by_name if it's a null pointer.
3511 (macro UNROLL_LOOP) Eliminate.
3512 (macro UNROLL_3_LOOPS) Eliminate.
3513 (tabi_render) Rewrite not to use the above macros.
3515 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
3517 Start working on a new output driver system, one that doesn't suck
3518 so much, by adding a "device-independent" output driver. The idea
3519 is to write out only a single output stream, then use separate
3520 processes to translate them into whatever formats we want. This
3521 is similar to how "groff" works with its various output drivers
3522 (grops, grotty, grodvi, ...).
3524 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
3526 * list.q: (write_all_headers) Stub out devind class.
3528 (determine_layout) Ditto.
3531 * output.c: (outp_init) Add devind class.
3533 * devind.c: New file.
3535 * devind.h: New file.
3537 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
3539 * frequencies.q: (hash_value_alpha) Fixed up the previous change
3540 to use the proper string length.
3542 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3544 * Fixed bug where FREQ would crash on alpha values
3546 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
3548 * Removed bletcherous alloca() workarounds for AIX from top of
3549 many files. AIX can use the alternative alloca() implementation
3552 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
3554 * ascii.c: (ascii_option) Fix implementation of headers option.
3556 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
3558 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
3559 multiple blank lines into one.
3560 (struct ascii_driver_ext) Add squeeze_blank_lines option.
3561 (ascii_preopen_driver) Initialize squeeze_blank_lines.
3562 (static var option_tab) Add squeeze entry.
3563 (ascii_option) Set squeeze_blank_lines.
3564 (output_lines) Implement squeezing blank lines.
3566 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
3568 * Removed redundant code from output.h
3570 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
3572 Dictionary classes: each variable is "ordinary", "system", or
3575 * var.h: (enum dict_class) New enum.
3577 * vars-prs.c: (dict_class_from_id) New function.
3578 (dict_class_to_name) New function.
3580 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
3582 * var.h: (struct freq_tab_set) Removed (not used).
3584 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
3586 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
3588 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
3590 * stats.c: (hypercube) Rename pow4(). All references updated.
3592 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
3594 * rename-vars.c: (cmd_rename_variables) Rewritten.
3595 (compare_name) Removed.
3597 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
3599 var_set feature, and code taking advantage of it.
3601 * crosstabs.q: (static var var_dict) Removed.
3602 (static var variables) New variable.
3603 (static var variables_cnt) New variable.
3604 (cmd_crosstabs) Free variables instead of var_dict.
3605 (internal_cmd_crosstabs) Initialize and use variables,
3606 variables_cnt instead of var_dict.
3607 (free_var_dict) Removed.
3608 (crs_custom_tables) Use var_set instead of a copied dictionary.
3609 (crs_custom_variables) Set up variables, variables_cnt instead of
3611 [DEBUGGING] (debug_print) Ditto.
3613 * means.q: (mns_custom_tables) Use var_set instead of a copied
3616 * vars-prs.c: (parse_vs_variable) New function.
3617 (parse_dict_variable) Rewritten.
3618 (parse_variable) Rewritten.
3619 (parse_variables) Renamed parse_var_set_vars(), rewritten.
3620 (parse_variables) New function in terms of parse_var_set_vars().
3621 Now requires its first argument to be non-null. All references
3622 that passed a null pointer updated to pass default_dict instead.
3623 (macro id_dict) Removed.
3624 (parse_DATA_LIST_vars) Add assertions.
3625 (parse_mixed_vars) Ditto.
3626 (struct var_set) New structure.
3627 (var_set_get_cnt) New function.
3628 (var_set_get_var) New function.
3629 (var_set_lookup_var) New function.
3630 (var_set_destroy) New function.
3631 (dict_var_set_get_cnt) New function.
3632 (dict_var_set_get_var) New function.
3633 (dict_var_set_lookup_var) New function.
3634 (dict_var_set_destroy) New function.
3635 (var_set_create_from_dict) New function.
3636 (struct array_var_set) New structure.
3637 (array_var_set_get_cnt) New function.
3638 (array_var_set_get_var) New function.
3639 (array_var_set_lookup_var) New function.
3640 (array_var_set_destroy) New function.
3641 (var_set_create_from_array) New function.
3643 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
3644 instead of parse_variables(NULL, ...) in output code.
3646 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
3648 Change inp_init from a 2-bit vector to an ordinary array.
3649 Initialize it all in cmd_end_input_program() instead of in
3652 * inpt-pgm.c: (enum value_init_type) New enum.
3653 (global var inp_init) Change to `enum value_init_type *', make
3655 (inp_init_size) Removed.
3656 (inp_nval) Change to `size_t', make static.
3657 (cmd_input_program) Don't initialize inp_init or inp_init_size.
3658 (cmd_end_input_program) Initialize inp_init, inp_nval.
3659 (init_case) Rewrite.
3660 (clear_case) Rewrite.
3662 * inpt-pgm.h: Removed.
3664 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3666 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3667 Colin Plumb hash. It is simpler and should better resist
3669 (hsh_hash_string) Ditto.
3671 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3673 * get.c: (export_write_case_func) Remove debug printing code.
3675 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3677 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3679 (save_write_case_func) Use &trns->h instead of cast.
3680 (cmd_export) Use &t->h instead of cast.
3682 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3684 Moved vectors into the dictionary.
3686 * var.h: (struct vector) Moved here from vector.h. `index' member
3687 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3690 * vector.h: Removed.
3692 * vector.c: (global var vec) Removed.
3693 (global var nvec) Removed.
3694 (cmd_vector) Rewritten.
3695 (find_vector) Removed.
3697 * dictionary.c: (dict_create_vector) New function.
3698 (dict_get_vector) New function, replaces reading global vec[]
3700 (dict_get_vector_cnt) New function, replaces reading global nvec
3702 (dict_lookup_vector) New function, replaces find_vector().
3703 (dict_clear_vectors) New function.
3705 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3707 Start to move away from `struct variable' p `union' member to void
3710 * var.h: (struct variable) Add `aux' member.
3712 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3714 Get rid of struct variable `foo' member.
3716 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3718 (frq_custom_variables) Ditto.
3719 (frq_custom_grouped) Ditto.
3721 * get.c: (struct save_trns) Change `var' member from `int *' to
3722 `struct variable **'.
3723 (cmd_save_internal) Use aux instead of foo.
3724 (save_trns_proc) Use revised `var' member.
3725 (static var mtf_seq_no) Renamed mtf_seq_num.
3726 (static var mtf_seq_nums) New static var.
3727 (cmd_match_files) Initialize mtf_seq_nums.
3728 (mtf_free) Free mtf_seq_nums.
3729 (mtf_processing) Use mtf_seq_nums instead of foo.
3730 (mtf_merge_dictionary) No need to initialize mv->foo.
3731 (cmd_export) Use aux instead of foo. Use revised `var' member.
3732 (mns_custom_tables) Don't use foo to check for duplicates, that's
3733 what PV_NO_DUPLICATE is for.
3735 * var.h: (struct variable) Remove `foo' member.
3736 (struct frequencies_proc) New member.
3738 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3740 Clean up COMPUTE and IF.
3742 * compute.c: More or less rewrite the darn thing.
3743 (struct compute_trns) Rename and reorder and add and delete
3745 (cmd_compute) Rewrite.
3746 (compute_num) Make conditional on test expression. Now used for
3747 both COMPUTE and IF.
3748 (compute_num_vec) Ditto.
3749 (compute_str) Ditto.
3750 (compute_str_vec) Ditto.
3753 (if_num_vec) Removed.
3755 (if_str_vec) Removed.
3756 (parse_target_expression) Renamed parse_rvalue_expression(),
3758 (new_trns) Renamed compute_trns_create(), rewritten.
3759 (delete_trns) Removed.
3760 (free_trns) Renamed compute_trns_free(), rewritten.
3761 (struct lvalue) New structure.
3762 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3763 (lvalue_get_type) New function.
3764 (lvalue_is_vector) New function.
3765 (lvalue_finalize) New function.
3766 (lvalue_destroy) New function.
3768 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3770 * command.def: Disallow MODIFY VARS in input mode, so that
3771 variables can't get dropped and confuse cmd_end_input_program()'s
3772 attempt to fill inp_init[].
3774 * modify-vars.c: (static var forward_positional_ordering) New
3776 (struct var_modification) Entirely changed.
3777 (rearrange_dict) Interface changed, rewritten.
3778 (cmd_modify_vars) Deal with modified struct var_modification, much
3780 (struct var_renaming) New structure.
3781 (compare_var_renaming_by_new_name) New function.
3782 (validate_var_modification) New function.
3784 * var.h: (struct modify_vars_proc) Removed.
3785 (struct variable) Removed member p.mfv.
3787 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3789 Make EVALUATE a valid command whether we're debugging or not, so
3790 that `make check' can succeed regardless of whether debugging is
3793 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3795 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3797 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3799 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3800 statement by a simple if test.
3802 * dfm.c: (dfm_get_record) Add assertion.
3804 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3806 For each file x.c, move #include "x.h" to the very top of the
3807 include list, to catch x.h failing to include the proper headers.
3809 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3811 * algorithm.c: (find) New function.
3812 (remove_equal) New function.
3813 (set_difference) New function.
3814 (adjacent_find_equal) New function.
3815 [TEST_UNIQUE] Removed test case.
3816 (copy_if) Find end test.
3818 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3820 * dictionary.c: (dict_get_case_weight) New convenience function.
3822 * aggregate.c: (accumulate_aggregate_info) Use
3823 dict_get_case_weight().
3825 * frequencies.q: (calc_general) Ditto.
3826 (calc_integer) Ditto.
3829 * t-test.q: (groups_calc) Ditto.
3832 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3834 * glob.c: (global var default_dict) Change from `struct
3835 dictionary' to `struct dictionary *'. All references changed.
3836 (init_glob) Initialize default_dict with dict_create().
3838 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3840 struct dictionary now made opaque. All related functions:
3842 * get.c: (rename_variables) Removed.
3843 (dict_delete_run) Removed.
3845 * temporary.c: (copy_variable) Removed.
3846 (new_dictionary) Removed.
3847 (save_dictionary) Removed.
3848 (restore_dictionary) Removed.
3849 (free_dictionary) Removed.
3851 * vars-atr.c: (clear_default_dict) Removed.
3852 (find_variable) Removed.
3853 (find_dict_variable) Removed.
3854 (create_variable) Removed.
3855 (delete_variable) Removed.
3856 (common_init_stuff) Removed.
3857 (init_variable) Removed. Updating of inp_init moved into
3858 cmd_end_input_program().
3859 (replace_variable) Removed.
3860 (rename_variable) Removed.
3861 (clear_variable) Removed.
3862 (dup_variable) Removed.
3864 * vars-prs.c: (is_varname) Removed.
3865 (is_dict_varname) Removed.
3866 (fill_all_vars) Removed.
3868 * vector.c: (find_vector) Removed.
3870 * weight.c: (stop_weighting) Removed.
3872 * dictionary.c: New file.
3873 (dict_create) New, replaces new_dictionary().
3874 (dict_clone) New, replaces save_dictionary() and
3875 restore_dictionary().
3876 (dict_clear) New, replaces clear_default_dict().
3877 (dict_destroy) New, replaces free_dictionary().
3878 (dict_get_var_cnt) New function, replaces references to
3880 (dict_get_var) New function, replaces references to dict->var[i].
3881 (dict_get_vars) New function, replaces fill_all_vars().
3882 (dict_create_var) New, replaces create_variable(). Interface
3883 drops `type' parameter, using a zero `width' to designate numeric.
3884 (dict_clone_var) New, replaces dup_variable().
3885 (dict_rename_var) New, replaces rename_variable().
3886 (dict_lookup_var) New, replaces find_variable(),
3887 find_dict_variable(), is_varname().
3888 (dict_contains_var) New function.
3889 (compare_variable_dblptrs) New function.
3890 (dict_delete_var) New function, replaces clear_variable().
3891 (dict_delete_vars) New function, replaces dict_delete_run().
3892 (dict_reorder_vars) New function.
3893 (dict_rename_vars) New function, replaces rename_variables().
3894 (dict_get_weight) New function, replaces reading dict->weight_var.
3895 (dict_set_weight) New function, replaces writing dict->weight_var
3896 or calling stop_weight(dict).
3897 (dict_get_filter) New function, replaces reading dict->filter_var.
3898 (dict_set_filter) New function, replaces writing dict->filter_var.
3899 (dict_get_case_limit) New function, replaces reading dict->N.
3900 (dict_set_case_limit) New function, replaces writing dict->N.
3901 (dict_get_value_cnt) New function, replaces reading dict->nval.
3902 (dict_compact_values) New function, replaces a loop that was
3903 replicated in several places.
3904 (dict_get_split_vars) New function, replaces reading dict->splits.
3905 (dict_get_split_cnt) New function, replaces reading
3907 (dict_set_split_vars) New function, replaces writing dict->splits.
3908 (dict_get_label) New function, replaces reading dict->label.
3909 (dict_set_label) New function, replaces writing dict->label.
3910 (dict_get_documents) New function, replaces reading
3912 (dict_set_documents) New function, replaces writing
3915 All references to above functions updated.
3917 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3918 old dictionary to new by hand, because dict_create() can't do it
3919 itself. Use dict_set_documents(), dict_set_split_vars().
3921 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3922 calling dict_destroy().
3924 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3926 (fixed_parse_compatible) Some slightly nontrivial changes for
3928 (dump_fmt_list) Ditto.
3931 * file-type.c: (create_col_var) Ditto.
3933 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
3934 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
3935 (rename_variables) Use dict_rename_vars().
3936 (mtf_merge_dictionary) Use dict_get_documents(),
3937 dict_set_documents(), dict_compact_values().
3939 * pfm-read.c: (read_variables) Deal with changes to weighting.
3941 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
3942 is_varname() in output code.
3944 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
3945 other dictionary functions.
3947 * title.c: (add_document_line) Use dict_get_documents(),
3948 dict_set_documents().
3950 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
3951 reset default_handle by hand. dict_clear() will clear vectors so
3952 there's no need for that by hand.
3954 * vfm.c: (close_active_file) Move call to finish_compaction()
3955 earlier, so that we can do the compaction as a single step using
3956 dict_compact_values(). Use dict_clear_vectors().
3957 (finish_compaction) Use dict_delete_var(), dict_compact_values().
3959 Some functions don't have replacements:
3961 * vars-atr.c: (force_create_variable) Removed. All references
3962 updated to dict_create_var() followed by an assertion.
3963 (force_dup_variable) Removed. All references updated to
3964 dict_clone_var() followed by an assertion.
3966 * weight.c: (update_weighting) Removed. No longer necessary, so
3967 all references removed.
3969 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
3973 * aggregate.c: Eliminate separation of weighted and unweighted
3974 case. It made the code too obscure and I doubt it was actually
3975 faster. Instead, all code uses the "weighted" code, because
3976 that's a generalization of the "unweighted" code.
3979 (parse_aggregate_functions) No need to set FWEIGHT.
3980 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
3981 (dump_aggregate_info) Ditto.
3982 (initialize_aggregate_info) No need for special plain_function
3983 that gets rid of FWEIGHT option.
3985 * aggregate.c: Get rid of approximations.
3986 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
3988 (aggregate_single_case) Don't use approx_ne().
3990 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
3992 * ascii.c (ascii_line_width): Dead code, removed.
3994 * postscript.c (ps_line_width): Ditto.
3996 * q2c.c (xrealloc): Ditto.
3998 * count.c (internal_cmd_count): Ditto.
4000 * means.q (validate_dependent_endpoint): Ditto.
4002 * set.q: (cmd_gset) Ditto.
4004 * weight.c: [0] (weight_trns_proc) Ditto.
4006 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4008 Make the code -Wmissing-prototypes clean.
4010 * Makefile.am (version.c): Add #include "version.h".
4012 * ascii.c: (ascii_open_global) Make static.
4013 (ascii_close_page) Ditto.
4014 (ascii_font_sizes) Ditto.
4015 (ascii_postopen_driver) Ditto.
4016 (ascii_close_driver) Ditto.
4017 (ascii_option) Ditto.
4018 (ascii_open_page) Ditto.
4019 (ascii_line_horz) Ditto.
4020 (ascii_line_vert) Ditto.
4021 (ascii_line_intersection) Ditto.
4023 (ascii_polyline_begin) Ditto.
4024 (ascii_polyline_point) Ditto.
4025 (ascii_polyline_end) Ditto.
4026 (ascii_text_set_font_by_name) Ditto.
4027 (ascii_text_set_font_by_position) Ditto.
4028 (ascii_text_set_font_by_family) Ditto.
4029 (ascii_text_get_font_name) Ditto.
4030 (ascii_text_get_font_family) Ditto.
4031 (ascii_text_set_size) Ditto.
4032 (ascii_text_get_size) Ditto.
4033 (ascii_text_metrics) Ditto.
4034 (ascii_text_draw) Ditto.
4035 (ascii_close_page) Ditto.
4037 * cmdline.h: New header for parse_command_line(). Used where
4040 * command.c: Move prototypes for cmd_*() functions to command.h.
4042 * command.h: Prototypes for cmd_*() functions moved here from
4045 * crosstabs.q: (gamma_int) Ditto.
4047 * file-handle.h: Add fh_init_files() prototype.
4049 * getline.c: (welcome) Ditto.
4051 * glob.h: New header for init_glob(). Used where appropriate.
4053 * hash.c: (comparison_helper) Ditto.
4055 * html.c: (html_open_global) Ditto.
4056 (html_close_global) Ditto.
4057 (html_preopen_driver) Ditto.
4058 (html_postopen_driver) Ditto.
4059 (html_close_driver) Ditto.
4060 (html_option) Ditto.
4061 (html_open_page) Ditto.
4062 (html_close_page) Ditto.
4063 (html_submit) Ditto.
4065 * inpt-pgm.c: (input_program_source_read) Ditto.
4067 * output.c: (find_defn_value) Ditto.
4068 (destroy_list) Ditto.
4070 * pfm-read.c: (read_int) Ditto.
4072 * postscript.c: (ps_open_global) Ditto.
4073 (ps_close_global) Ditto.
4074 (ps_font_sizes) Ditto.
4075 (ps_preopen_driver) Ditto.
4076 (ps_postopen_driver) Ditto.
4077 (ps_close_driver) Ditto.
4079 (ps_open_page) Ditto.
4080 (ps_close_page) Ditto.
4081 (ps_line_horz) Ditto.
4082 (ps_line_vert) Ditto.
4083 (ps_line_intersection) Ditto.
4085 (ps_polyline_begin) Ditto.
4086 (ps_polyline_point) Ditto.
4087 (ps_polyline_end) Ditto.
4088 (ps_text_set_font_by_name) Ditto.
4089 (ps_text_set_font_by_position) Ditto.
4090 (ps_text_set_font_family) Ditto.
4091 (ps_text_get_font_name) Ditto.
4092 (ps_text_get_font_family) Ditto.
4093 (ps_text_set_size) Ditto.
4094 (ps_text_get_size) Ditto.
4095 (ps_text_metrics) Ditto.
4096 (ps_text_draw) Ditto.
4098 * q2c.c: (finish_up) Ditto.
4107 (find_symbol) Ditto.
4110 (force_string) Ditto.
4112 (match_token) Ditto.
4115 (parse_setting) Ditto.
4116 (parse_specifier) Ditto.
4117 (parse_specifiers) Ditto.
4118 (parse_subcommand) Ditto.
4119 (dump_specifier_vars) Ditto.
4121 (make_identifier) Ditto.
4122 (dump_declarations) Ditto.
4123 (dump_specifier_init) Ditto.
4124 (dump_vars_init) Ditto.
4126 (dump_specifier_parse) Ditto.
4127 (dump_subcommand) Ditto.
4128 (dump_parser) Ditto.
4129 (dump_header) Ditto.
4131 (recognize_directive) Ditto.
4133 * recode.c: (string_to_long) Ditto.
4135 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4137 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4140 * sort.c: (sort_stream_read) Ditto.
4141 (sort_stream_mode) Ditto.
4143 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4145 * algorithm.c (binary_search): Fix comparison.
4147 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4149 * algorithm.c: (binary_search) Fix assertion.
4151 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4153 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4155 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4157 * sort.c: (compare_case_lists) Rewrite.
4159 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4161 * quicksort.c: Removed (not used).
4163 * quicksort.h: Removed (not used).
4165 * sort.c: Removed blp_quicksort() prototype.
4167 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4169 * postscript.c: (int_2_compare) Rewrite.
4170 (compare_line) Rewrite.
4172 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4174 * matrix-data.c (compare_factors) Use lexicographical_compare()
4176 (compare_doubles) New function.
4178 * algorithm.c: (lexicographical_compare) New algorithm.
4180 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4182 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4184 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4186 * expr-prs.c: (cmp_func) Removed.
4187 (parse_function) Use binary_search() algorithm.
4188 (compare_functions) New function.
4189 (init_func_tab) Use sort() algorithm.
4191 * algorithm.c: (binary_search) New algorithm.
4193 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4195 * descript.q: (display) Use sort() algorithm instead of qsort().
4196 (compare_func) Removed.
4197 (descriptives_compare_variables) New function.
4199 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4201 Get rid of AVL trees. Hashes are more appropriate for everything
4204 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4210 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4212 Much code can be clarified by using C++ STL-like algorithms. Not
4213 all uses of these algorithms are listed below, only the ones where
4214 the change to an algorithm was the only change of interest.
4216 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4218 * algorithm.c: New file.
4220 * algorithm.h: New file.
4222 * modify-vars.c: (static var forward) Removed.
4223 (static var positional) Removed.
4224 (compare_variables) Removed.
4225 (struct ordering) New.
4226 (cmd_modify_vars) Use sort() algorithm.
4227 (compare_variables_given_ordering) New function.
4228 (rearrange_dict) Use sort() algorithm.
4230 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4231 (cmp_var_by_name) Removed.
4233 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4235 Make file handles use a hash table.
4237 * file-handle.q: (files) Change to hash table, make static.
4238 (cmd_file_handle) Use hash table functions.
4239 (fh_get_handle_by_filename) Ditto.
4240 (fh_get_handle_by_name) Ditto.
4241 (hash_file_handle) New function.
4242 (cmp_file_handle) Rewrite.
4243 (fh_init_files) Use hash table functions.
4245 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4247 Clean up FREQUENCIES.
4249 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4251 * frequencies.q: Remove a lot of old #if'd out code at the end.
4252 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4253 or calc_weight(). Initialize percentile_values.
4254 (calc) New function based on calc_weight() from frequencies.g.
4255 (precalc) Use hash functions.
4256 (static var comparison_func) Removed.
4257 (static var comparison_param) Removed.
4258 (comparison_helper) Removed.
4259 (get_freq_comparator) New function.
4260 (not_missing) New function.
4262 (postprocess_freq_tab) Use hash table functions, algorithms,
4263 get_freq_comparator(). Rewrite.
4264 (cleanup_freq_tab) Rephrase.
4265 (add_percentile) Clean up spacing.
4266 (hash_value_numeric) New function.
4267 (hash_value_alpha) New function.
4268 (compare_value_numeric_a) Rewrite.
4269 (compare_value_alpha_a) Rewrite.
4270 (compare_value_numeric_d) Rewrite.
4271 (compare_value_alpha_d) Rewrite.
4272 (compare_freq_numeric_a) Rewrite.
4273 (compare_freq_alpha_a) Rewrite.
4274 (compare_freq_numeric_d) Rewrite.
4275 (compare_freq_alpha_d) Rewrite.
4276 (calc_stats) Clean up mode, percentiles, max.
4277 (dump_statistics) Clean up spacing.
4279 * frequencies.g: Removed.
4281 * var.h: (struct freq_tab) Change `data' to hash table.
4283 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4285 * file-handle.h: Remove declaration of global variable `files',
4286 which wasn't used anywhere.
4288 * postscript.c: (add_encoding) Remove superfluous cast.
4291 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4294 * temporary.c: [0] (display_tree) Removed.
4296 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4298 Implement a new random number generator based on the alleged RC4
4301 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4304 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4305 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4307 (static var V[]) Removed.
4308 (static var Y) Removed.
4309 (static var X2) Removed.
4310 (setup_randomize) Removed.
4312 (rand_uniform) Removed.
4313 (rand_normal) Removed.
4314 (struct rng) New structure.
4315 (rng_create) New function.
4316 (rng_destroy) New function.
4317 (swap_byte) New static function.
4318 (rng_seed) New function.
4319 (rng_get_bytes) New function.
4320 (rng_get_int) New function.
4321 (rng_get_unsigned) New function.
4322 (rng_get_double) New function.
4323 (rng_get_double_normal) New function.
4324 (pspp_rng) New function.
4326 * random.h: Sync up to random.c.
4328 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4329 fraction of UINT_MAX, not 65536.
4330 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4333 * vfm.c: (open_active_file) No need to call setup_randomize() any
4336 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4338 Change dictionary name indexes to use hash tables instead of AVL
4341 * crosstabs.q: (free_var_dict) Use hash tables.
4342 (crs_custom_tables) Ditto.
4343 (calc_general) Ditto.
4344 (compare_table_entry) Rewrite.
4345 (enum_var_values) Reorder parameters. All references updated.
4348 * get.c: (rename_variable) Use hash tables.
4349 (mtf_merge_dictionary) Ditto.
4351 * glob.c: (init_glob) Use hash tables.
4352 (cmp_variable) Removed.
4354 * means.q: (mns_custom_tables) Use hash tables.
4356 * modify-vars.c: (rearrange_dict) Use hash tables.
4358 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4360 * sfm-read.c: (read_header) Use hash tables.
4361 (read_variables) Ditto.
4363 * temporary.c: (new_dictionary) Use hash tables.
4364 (save_dictionary) Ditto.
4365 (restore_dictionary) Ditto.
4367 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4368 hash table `name_tab'.
4370 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4371 [DEBUGGING] (dump_var_tree) Removed.
4372 (find_variable) Use hash tables.
4373 (find_dict_variable) Ditto.
4374 (common_init_stuff) Ditto.
4375 (rename_variable) Ditto.
4376 (clear_variable) Ditto. Also, remove debug code.
4377 (dup_variable) Use hash tables.
4379 * vars-prs.c: (fill_all_vars) Use hash tables.
4380 (is_dict_varname) Ditto.
4381 (parse_dict_variable) Ditto.
4383 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4385 Change value labels to use hash tables instead of AVL trees, and
4386 change value labels into an ADT.
4388 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4390 * value-labels.c: New file.
4392 * value-labels.h: New file.
4394 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4395 Get rid of a stupid use of goto.
4397 * autorecode.c: (compare_alpha_value) Rewrite.
4398 (hash_alpha_value) Ditto.
4399 (compare_numeric_value) Rewrite.
4400 (hash_numeric_value) Ditto.
4402 * frequencies.q: (dump_full) Use value label ADT.
4404 * pfm-read.c: (read_value_label) Use value label ADT.
4406 * pfm-write.c: (write_value_labels) Use value label ADT.
4408 * sfm-read.c: (read_variables) Use value label ADT.
4409 (read_value_labels) Rewrite.
4411 * sfm-write.c: (write_value_labels) Rewrite.
4413 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4414 (display_variables) Ditto.
4415 (describe_variable) Ditto.
4417 * t-test.q: (print_t_groups) Use value label ADT.
4419 * temporary.c: (copy_variable) Use value label ADT.
4420 (free_dictionary) Ditto.
4422 * val-labs.c: (verify_val_labs) Use value label ADT.
4424 (debug_print) Ditto.
4425 (val_lab_cmp) Removed.
4426 (inc_ref_count) Removed.
4427 (copy_value_labels) Removed.
4429 * var.h: (struct value_label) Removed.
4430 (struct variable) Change AVL tree `val_lab' into hash table
4433 * vars-atr.c: (init_variable) Use value label ADT.
4434 (clear_variable) Ditto.
4435 (free_value_label) Removed.
4436 (free_val_lab) Removed.
4437 (get_val_lab) Removed.
4438 (compare_variables) New function.
4439 (hash_variable) New function.
4441 * vfm.c: (dump_splits) Use value label ADT.
4443 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
4445 Add to the hash table interface.
4447 * hash.c: (hsh_hash_bytes) Add assertion.
4448 (hsh_hash_string) Ditto.
4452 (hsh_create) Ditto. Also make minimum `size'.
4453 (hsh_destroy) Rephrase.
4454 (sort_nulls_last) Removed.
4455 (not_null) New function.
4457 (comparison_helper) Ditto.
4458 (hsh_sort) Rewritten.
4459 (hsh_data_copy) New function.
4460 (hsh_sort_copy) Ditto.
4462 (hsh_replace) Ditto.
4463 (hsh_hash_double) Ditto.
4464 (hsh_delete) Fix stupid bug.
4466 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4467 * added a calculation of the mode to FREQUENCIES
4469 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4471 * moved (un)defs of DEBUGGING to config.h
4473 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
4475 * groff-font.c: (add_kern) Fix indentation.
4476 (add_kern) Use & instead of % to take power-of-2 modulus.
4477 (font_get_kern_adjust) Likewise.
4479 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
4481 * autorecode.c: (recode) Replace stupid use of memcpy() by
4483 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
4484 (hash_numeric_value) Ditto.
4485 (autorecode_proc_func) pool_strdup() was wrong here because the
4486 source string was not null-terminated. Use new pool_strndup()
4489 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
4490 use of hsh_iterator_init().
4492 * data-in.c: (parse_N) Initialize i->v->f.
4494 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
4497 * groff-font.c: Use power-of-2 hash table sizes, not prime.
4498 (groff_read_font) Don't call hsh_next_prime(). Don't call
4500 (static var hash) Remove `size_p', `max_used' members.
4501 (font_char_name_to_index) Don't call hsh_next_prime(). Use
4502 hsh_hash_string() instead of hashpjw(), & instead of %.
4503 (default_font) Don't call hsh_next_prime().
4505 * pool.c: (pool_strndup) New function.
4506 (pool_strdup) Reimplement in terms of pool_strndup.
4508 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
4510 (hash_ps_encoding) Use hsh_hash_string().
4511 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
4512 (hash_filename2font) Use hsh_hash_string().
4514 * som.c: Add #include <stdlib.h>.
4516 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
4517 (by destroying its pool).
4519 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
4521 Miscellaneous hash table code cleanup:
4523 * hash.h: (struct hsh_table) Moved into hash.c.
4524 (hsh_count) Ditto, and transformed into function.
4525 (hsh_compare_func) New typedef, used for defining otherwise-long
4526 function types here and in hash.c
4527 (hsh_hash_func) Ditto.
4528 (hsh_free_func) Ditto.
4530 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
4531 `table' to `entries'. Removed `mp'. All references updated.
4532 (hsh_clear) Don't shrink entries array; if the hash was this big
4533 once, it probably will be again.
4534 (hsh_rehash) Made static.
4535 (force_hsh_insert) Renamed hsh_force_insert.
4536 (force_hsh_find) Renamed hsh_force_find.
4538 Made hash table sizes powers of 2, because that's fine with any
4539 reasonable hash function and because taking a power-of-2 modulus
4540 is faster than any other:
4542 (hsh_prime_tab) Removed;
4543 (hsh_next_prime) Ditto.
4544 (next_power_of_2) New function.
4545 (hsh_create) Use next_power_of_2.
4546 (hsh_rehash) Use & instead of %.
4548 Cleaned up hsh_sort:
4550 (internal_comparison_fn) Removed.
4551 (sort_nulls_last) New function.
4552 (hsh_sort) Removed second parameter, switched to using the new
4553 quicksort() function from quicksort.h to avoid using nasty need
4554 for static variables with qsort(). All references updated.
4556 Changed the hash functions offered, because there are better hash
4557 functions than the ones we had, and cleaned up the names to boot:
4559 * hash.c: (hashpjw_d) Removed.
4561 (hsh_hash_bytes) New function.
4562 (hsh_hash_string) New function.
4563 (hsh_hash_int) New function.
4565 Improved the hash table iteration interface:
4567 * hash.h: (hsh_iterator_init) Removed.
4568 (struct hsh_iterator) Removed `init' member, change `next' to
4571 * hash.c: (hsh_foreach) Removed. All references updated to use
4572 hsh_first/hsh_next instead.
4573 (hsh_first) New function. Notably, unlike hsh_foreach() it does
4574 not treat a null pointer as an empty hash table.
4575 (hsh_next) New function.
4577 Made deletion possible, though slow:
4579 * hash.c: (locate_matching_entry) New function.
4580 (hsh_find) Use locate_matching_entry().
4581 (hsh_delete) New function also using locate_matching_entry().
4582 (hsh_force_delete) New function.
4584 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
4586 * quicksort.c: New file implementing a sort routine with a
4587 interface better than qsort() because it passes a user-provided
4588 parameter to the sort routine.
4590 * Makefile.am: Add quicksort.c, quicksort.h.
4592 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
4594 * All source files: Get rid of nasty special cases for Checker,
4595 which is pretty obsolete now.
4597 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
4599 * Fixed a bug apparent when using the FREQUENCIES command with the
4600 html driver. The html driver was incorrectly trying to display
4603 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
4605 * Makefile.am: Reorganized. Put locale dir in version.c instead
4606 of passing it to each compile command. Only put local gmp libs in
4607 LD_ADD if not installed on system. Remove `boast' target.
4609 * All source files: struct and union typedefs eliminated.
4610 `sizeof type' replaced by `sizeof object' where practical. Moved
4611 `unused' qualifiers from start to end of declarations for gcc
4612 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
4613 assertions on pointers strictly compliant. Removed _ prefixes on
4614 some function parameter names.
4616 * alloc.c: New source file, containing these external linkage
4617 functions removed from common.c: xmalloc, xcalloc, xrealloc,
4624 * ascii.c: Migrated from arenas to pools.
4625 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
4626 c_string to len_string. All references changed.
4627 (ascii_option) Signature changed to comply to new output.c
4629 (count_fancy_chars) Removed.
4630 (delineate) Removed support for rich text.
4631 (ascii_text_metrics) Ditto.
4633 (output_shorts) Change `box', `off', `on' from c_string to
4634 len_string. Change `remaining' from int to size_t.
4635 (ascii_close_page) Make page numbering less haphazard.
4637 * autorecode.c: Migrate from arenas to pools.
4639 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
4641 * bitvector.h: New file containing these macros from misc.h:
4642 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
4644 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
4645 word[3]. ncmd removed.
4646 (var empty_string) Removed.
4647 (var cmd_table) Declaration updated.
4648 (var cmdtab) Removed.
4649 (cmp_command) Removed.
4650 (split_words) Rewritten to use strtok_r().
4651 (init_cmd_parser) Renamed cmd_init(). Rewritten.
4652 (find_command) Removed.
4653 (FILE_TYPE_okay) Rewritten.
4654 (cmd_parse) Rewritten. Semantics of the return value of command
4655 handlers has changed: they must now return one of the new CMD_*
4656 enumerals, rather than a magic value. This meant that all
4657 commands had to be modified, and they were.
4658 (figure_out_command) New function.
4660 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
4661 #defines for INIT, INPU, etc.
4663 * command.h: New CMD_* enum series.
4664 (cur_proc) Make const char *, not char *.
4665 (cmd_init) Prototype.
4668 * common.c: Removed.
4670 * common.h: Removed.
4672 * correlations.q: New file.
4674 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4676 (custom_tables) Renamed crs_custom_tables().
4677 (custom_variables) Renamed crs_custom_variables().
4678 (calc_integer) Add in some `const' qualifiers.
4679 (table_value_missing) Change from a_string to len_string.
4680 (float_M_suffix) Change from a_string to len_string.
4682 * data-in.c: Rewritten. All references to
4683 parse_string_as_format() changed to data_in().
4685 * data-in.h: New file.
4687 * data-list.c: Change DLS_* from #define's to enums. Move from
4688 rpd_msg() to tmsg().
4689 (RPD_ERR) New #define.
4690 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4692 (read_from_data_list_fixed) Change from old
4693 parse_string_as_format() to new data_in().
4694 (read_from_data_list_free) Ditto.
4695 (read_from_data_list_list) Ditto.
4696 (cmd_repeating_data) Modify approach to checking for end of
4699 (rpd_parse_record) Change from old parse_string_as_format() to new
4700 data_in(). Change from old convert_format_to_string() to new
4702 (read_one_set_of_repetitions) Change dfm_push_cust() to
4703 dfm_push(), pop_cust() to dfm_pop().
4705 * data-out.c: Rewritten. All references to
4706 convert_format_to_string() changed to data_out().
4708 * descript.q: Migrate to new q2c.
4709 (cmd_descriptives) Removed.
4710 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4711 (custom_variables) Renamed dsc_custom_variables().
4713 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4715 (open_file_r) Initialize h->where.line_number. Migrate to new
4717 (open_file_w) Initialize h->where.line_number.
4718 (read_record) Change from ext->ln to h->where.line_number.
4719 Migrate to struct string.
4720 (dfm_put_record) Rephrased.
4721 (dfm_push_cust) Renamed dfm_push(), rewritten.
4722 (dfm_pop) New function.
4724 * error.c: All references updated.
4725 (glob var error_count) Renamed err_err_count.
4726 (glob var warning_count) Renamed err_warning_count.
4727 (glob var error_already_flagged) Renamed err_already_flagged.
4728 (glob var verbosity) Renamed err_verbosity.
4729 (glob var cust_fn) Removed.
4730 (glob var cust_ln) Removed.
4731 (static var file_loc) New.
4732 (static var nfile_loc) New.
4733 (static var mfile_loc) New.
4734 (tmsg) New function.
4735 (push_cust) Removed.
4738 (static var terminating) Removed.
4739 (failure) Renamed err_failure().
4740 (hcf) Renamed err_hcf().
4741 (err_push_file_locator) New function.
4742 (err_pop_file_locator) New function.
4743 (err_location) New function.
4744 (check_error_count) Renamed err_check_count().
4745 (vmsg) Renamed err_vmsg(). Interface changed.
4746 (verbose_msg) Removed.
4747 (err_cond_fail) New function.
4748 (error_break) Renamed err_break().
4750 * error.h: All references updated.
4751 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4752 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4754 (struct file_locator) New.
4756 (macro verbose_msg) Removed.
4757 (macro cond_fail) Removed.
4759 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4761 * expr-prs.c: Reorganized. All references updated.
4762 (exprtypename) Renamed expr_type_name().
4763 (typename) Renamed type_name().
4764 (free_expression) Renamed expr_free().
4765 (parse_expression) Renamed expr_parse(). Uses new type_check()
4767 (init_functab) Renamed init_func_tab().
4768 (type_check) New function.
4769 (parse_or) Rewritten to use new allocate_nonterminal() and
4770 append_nonterminal_arg() functions.
4773 (parse_rel) Ditto. Also simplified logic.
4778 (SYSMIS_func) Ditto.
4779 (VALUE_func) Rephrased.
4780 (CONCAT_func) Fix memory leak by replacing free by free_node on
4782 (generic_str_func) Ditto.
4783 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4785 (allocate_nonterminal) New function.
4786 (append_nonterminal_arg) New function.
4787 (static func_tab[]) Now at file level.
4789 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4791 * expr.h: (enum series OP_*) Moved to exprP.h.
4792 (OP_* defines) Ditto.
4793 (struct op_desc) Ditto.
4794 (global ops[]) Ditto.
4795 (struct num_con_node) Ditto.
4796 (struct str_con_node) Ditto.
4797 (struct var_node) Ditto.
4798 (struct lag_node) Ditto.
4799 (struct casenum_node) Ditto.
4800 (struct nonterm_node) Ditto.
4801 (union any_node) Members renamed.
4802 (struct sys_node) Removed.
4803 (struct val_node) Removed.
4804 (operator typedef) Removed.
4805 (typedef exprtype) Removed.
4806 (enum series EX_*) Moved to exprP.h.
4807 (struct expression) Ditto. Also renamed a lot of the members.
4808 (PXP_* defines) Changed to enums.
4809 (free_node prototype) Moved to exprP.h.
4811 * file-handle.h: (struct file_handle) New member `where'.
4813 * file-handle.q: Migrated to new q2c format.
4814 (prepend_current_directory) Removed (dead code).
4815 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4816 (fh_get_handle_by_filename) Removed dead code.
4817 Set new `where' member.
4819 * file-type.c: (file_type_source_read) References to
4820 parse_string_as_format() changed to data_in().
4821 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4823 * filename.c: All references updated.
4824 (init_filename) Renamed fn_init().
4825 (expand_line) Removed.
4826 (macro EXPAND_LINE) Removed.
4827 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4828 of custom functions.
4829 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4830 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4831 (normalize_filename) Renamed fn_normalize().
4832 (search_path) Renamed fn_search_path(), rewritten.
4833 (prepend_dir) Renamed fn_prepend_dir().
4834 (blp_getenv) Renamed fn_getenv().
4835 (blp_dirname) Renamed fn_dirname().
4836 (fn_basename) New function, not used.
4837 (absolute_filename_p) Renamed fn_absolute_p().
4838 (is_special_filename) Renamed fn_special_p().
4839 (file_exists) Renamed fn_exists_p().
4840 (readlink_malloc) Renamed fn_readlink().
4841 (getenv_default) Renamed fn_getenv_default().
4842 (open_file) Renamed fn_open().
4843 (close_file) Renamed fn_close().
4844 (open_file_ext) Renamed fn_open_ext().
4845 (close_file_ext) Renamed fn_close_ext().
4847 * font.h: Migrate from arenas to pools.
4849 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4851 * frequencies.g: Migrate from arenas to pools.
4853 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4856 * getline.c: All references updated.
4857 (global getl_buf) Changed from char * to struct string.
4858 (static getl_include_path) Ditto.
4859 (global getl_buf_len) Removed.
4860 (global getl_buf_size) Removed.
4861 (getl_include_path) Deal with new getl_buf, getl_include_path.
4862 (getl_uninitialize) New function.
4863 (getl_get_current_directory) Rewritten.
4864 (getl_clear_include_path) Rewritten.
4865 (getl_add_include_dir) Rewritten.
4866 (getl_add_file) Assertion fixed.
4867 (getl_add_virtual_file) Change initial value of `remaining_loops'
4869 (welcome) Rewritten.
4870 (handle_line_buffer) Make static. Change logic to make
4871 getl_add_virtual_file() change sensible. Use ds_*() strings.
4872 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4873 (getl_close_file) Moved.
4874 (getl_location) New function.
4876 * getline.h: All references updated.
4877 (macro curln) Removed.
4878 (macro curfn) Removed.
4879 (macro am_interactive) Renamed getl_am_interactive.
4880 (macro am_reading_script) Renamed getl_reading_script.
4882 * glob.c: (global fmt_parse_ignore_error) Removed.
4883 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4884 systems that support it (C99). Turn off SET ECHO by default. No
4885 necessary julcal initialization anymore.
4887 * groff-font.c: Migrate from arenas to pools.
4888 (groff_read_font) Use err_push_file_locator().
4889 (groff_read_DESC) Ditto.
4890 (font_msg) Use tmsg().
4892 * hash.c: (hsh_sort) Fix debug code.
4893 [GLOBAL_DEBUGGING] Include stdio.h.
4895 * hash.h: (macro force_hsh_insert) Rephrase.
4897 * heap.c: Rewritten.
4899 * heap.h: Rewritten.
4901 * html.c: (html_option) Change from outp_value to struct string.
4902 (postopen) Change from curfn to getl_location().
4903 (escape_string) Remove rich-text code. Signature changed.
4904 (output_tab_table) Switch from a_string to struct len_string.
4905 Remove rich text support.
4907 * lexer.c: All references updated. Largely rewritten. Major
4908 changes listed below. Removed tagged quote support. Adapted to
4909 struct string tokstr.
4910 (global tokstr) Changed to struct string.
4911 (global tokstr_size) Removed.
4912 (global tokstr_len) Removed.
4914 (global tokint) Removed.
4915 (global toklongstr) Removed.
4916 (C* defines) Removed.
4917 (static tbl[]) Removed.
4918 (static id[]) Removed.
4919 (static une[]) Removed.
4920 (discard_line) Renamed lex_discard_line().
4921 (get_entire_line) Renamed lex_entire_line().
4922 (get_rest_of_line) Renamed lex_rest_of_line().
4923 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4924 (make_hexit) Removed.
4925 (syntax_error) Renamed lex_error(). Return value removed.
4926 (get_token_representation) Renamed lex_token_representation().
4927 (putback) Renamed lex_put_back().
4928 (putfwd) Renamed lex_put_forward().
4929 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4930 (set_prog) Renamed lex_set_prog().
4931 (init_lex) Renamed lex_init().
4932 (reset_eof) Renamed lex_reset_eof().
4933 (lookahead) Renamed lex_look_ahead().
4934 (check_id) Rewritten.
4935 (yylex) Renamed lex_get(), rewritten.
4936 (lex_end_of_command) New function. Many commands were rephrased
4938 (lex_integer_p) New function. Replaces compare of tokint against
4940 (lex_integer) New function. Replaces tokint.
4941 (match_tok) Renamed lex_match().
4942 (match_id) Renamed lex_match_id().
4943 (match_int) Renamed lex_match_int().
4944 (force_match_id) Renamed lex_force_match_id(), added return value.
4945 (force_match) Renamed lex_force_match(), added return value.
4946 (force_string) Renamed lex_force_string(), added return value.
4947 (force_int) Renamed lex_force_int(), added return value.
4948 (lex_id_match_len) New function.
4949 (id_match) Renamed lex_id_match(), rewritten.
4950 (get_line) Renamed lex_get_line().
4951 (preprocess_line) Renamed lex_preprocess_line().
4952 (tokname) Renamed lex_token_name().
4953 (bin_value_func) Removed.
4954 (oct_value_func) Removed.
4955 (hex_value_func) Removed.
4956 (unexpected_eof) New function.
4957 (convert_numeric_string_to_char_string) New function.
4958 (parse_string) Rewritten, signature changed.
4959 (add_tokstr_char) Removed.
4960 (add_tokstr_unsigned) Removed.
4961 (add_tokstr_string) Removed.
4962 (parse_tagged_quote) Removed.
4963 (skip_comment) Renamed lex_skip_comment().
4965 * lexer.h: All references updated.
4966 (macro is_id1) Renamed CHAR_IS_ID1.
4967 (macro is_idn) Renamed CHAR_IS_IDN.
4968 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
4969 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
4970 (macro get_token) Removed.
4971 (macro id_match) Removed.
4972 (macro force_match_id) Removed.
4973 (macro force_match) Removed.
4974 (macro force_string) Removed.
4975 (macro force_int) Removed.
4976 (macro force_num) Removed.
4977 (macro force_id) Removed.
4979 * lexerP.h: Removed.
4981 * list.q: Migrated to new q2c format.
4982 (write_line) Deal with struct len_string.
4983 (write_varname) Ditto.
4984 (write_fallback_headers) Ditto.
4986 * magic.c: New file, incorporating the following global variables
4987 previously in other files: endian, second_lowest_value. And both
4988 of those are conditional on #define's.
4990 * magic.h: New file, incorporating the following global variable
4991 declarations: endian, second_lowest_value, and the following macro
4992 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
4994 * main.c: Added declarations of pgmname, finished, curdate,
4996 (main) Call new parse_script() function.
4997 (parse_script) New function.
4998 (execute_command) New function.
4999 (dump_token) Removed.
5000 (handle_error) New function.
5002 * matrix.c: New file.
5004 * matrix.h: New file.
5006 * matrix-data.c: Migrated from arenas to pools.
5007 (mget_token) Change from parse_string_as_format() to data_in().
5009 * means.q: Migrate to new q2c.
5010 (custom_tables) Renamed mns_custom_tables().
5011 (custom_crossbreak) Renamed mns_custom_crossbreak().
5012 (custom_variables) Renamed mns_custom_variables().
5014 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5015 (parse_varnames) Prototype.
5016 (parse_numeric) Rephrasings.
5017 (parse_alpha) Adapt to new struct string tokstr.
5019 * misc.c: (intlog10) Rewritten.
5021 (ansi_rand) Renamed real_rand(), moved into random.c.
5022 (ansi_srand) Renamed real_srand(), moved into random.c.
5023 (setup_randomize) Moved to random.c.
5024 (rand_uniform) Ditto.
5025 (rand_normal) Ditto.
5026 (rand_simple) Ditto.
5027 (get_config_line) Removed.
5028 (reverse) Removed (dead code).
5030 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5031 (macro CLEAR_BIT) Ditto.
5032 (macro TEST_BIT) Ditto.
5033 (macro SET_BIT_TO) Ditto.
5034 (macro BIT_INDEX) Ditto.
5036 * output.c: (outp_read_devices) Move to err_push_file_locator()
5037 from push_cust(). Use struct string.
5038 (expand_op_tokstr) Removed.
5039 (static var op_tokstr) Changed to struct string.
5040 (static var op_tokstr_size) Removed.
5041 (tokener) Rephrasings. Use struct string.
5042 (parse_options) Use struct string.
5043 (destroy_driver) Fix assertion.
5044 (outp_get_paper_size) Move to err_push_file_locator().
5045 [0] Removed dead code.
5046 (outp_string_width) Move to len_string.
5048 * output.h: Comment fixes.
5049 (TAG_* enum series) Removed.
5050 (struct outp_value) Removed.
5051 (enum OUTP_T_FANCY) Removed.
5052 (struct outp_text) `s' changed from a_string to len_string.
5053 (struct outp_class) `option' change arg 3 from outp_value to
5056 * pfm-read.c: (corrupt_msg) Rewritten.
5058 * pfm-write.c: (bufwrite) Fix assertion.
5060 * pool.c: New file, reference version.
5062 * pool.h: New file, reference version.
5064 * postscript.c: (ps_font_sizes) Fix assertion.
5065 (ps_option) Change arg 3 from outp_value to struct string.
5066 Adapt to struct string.
5067 (macro output_line) Removed.
5068 (macro add_string) Removed.
5069 (output_encodings) Adapted to struct string. Moved to
5070 err_push_file_locator().
5071 (find_encoding_file) Fix assertion.
5072 (read_ps_encodings) Move to err_push_file_locator().
5073 (postopen) Use getl_location() instead of curfn.
5074 (out_text_plain) Move to len_string.
5075 (text) Ditto. Remove rich text support.
5077 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5078 (cmd_print_eject) Ditto.
5080 (internal_cmd_print) Now cleans up after itself. Uses
5081 fh_parse_file_handle() now.
5082 (cmd_print_space) Use PXP_NUMERIC to type-check.
5084 * q2c.c: Overhauled. Removed _("") i18n support. All references
5085 updated. All output functions updated to handle structures rather
5086 than local or static variables. Adapt to new PSPP lex_*()
5090 (macro MAX_N_SBC) Removed.
5091 (global bare) Removed.
5092 (enum STRING) Renamed T_STRING.
5093 (enum ID) Renamed T_ID.
5094 (get_buffer) Buffer size increased.
5095 (strlower) Renamed st_lower(), rephrased.
5096 (strupper) Renamed st_upper(), rephrased.
5097 (skip_ws) New function.
5098 (get_line) Don't special-case any types of lines (like those
5099 beginning with ! or $, for instance).
5100 (get_token) Renamed lex_get(). Rephrased.
5101 (static var `prefix') New.
5102 (parse) New function.
5103 (parse_setting) Minor rephrasing.
5104 (dump_specifier_vars) Ditto.
5105 (make_identifier) Put null terminator on identifier, duh.
5106 (dump_vars) Renamed dump_declarations(). Never indent. Never
5107 static. Output changed entirely.
5108 (dump_specifier_init) Rephrase.
5109 (dump_vars_init) No index variable needed. Other modifications.
5110 (dump_parser) Don't parse command name. Do dump functions instead
5111 of just code fragments.
5112 (dump_free) Dump function instead of code fragment.
5113 (recognize_directive) New function.
5114 (main) Use recognize_directive(). Don't rely on magic $ line
5115 beginning: instead, parse comments. Update list of headers.
5117 * random.c: New file, containing the following functions:
5118 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5119 rand_normal, rand_simple.
5121 * random.h: New file.
5123 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5124 function. `max_src_width', `max_dst_width' changed to size_t.
5125 (internal_cmd_recode) Removed.
5126 (parse_dest_spec) Merge similar cases.
5127 (parse_src_spec) Add assertion.
5129 * repeat.c: (recognize_keyword) New function.
5130 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5131 REPEAT. Improve recognition of END REPEAT (use
5132 recognize_keyword()). Move from curfn to getl_location(). Use
5135 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5137 * set.q: Adapt to new q2c.
5138 (cmd_set) Range-check some values better.
5139 (custom_blanks) Renamed stc_custom_blanks().
5140 (custom_length) Renamed stc_custom_length().
5141 (custom_results) Renamed stc_custom_results().
5142 (custom_seed) Renamed stc_custom_seed().
5143 (custom_width) Renamed stc_custom_width().
5144 (custom_format) Renamed stc_custom_format().
5145 (custom_journal) Renamed stc_custom_journal().
5146 (custom_color) Renamed stc_custom_color().
5147 (custom_listing) Renamed stc_custom_listing().
5148 (custom_disk) Renamed stc_custom_disk().
5149 (custom_log) Renamed stc_custom_log().
5150 (custom_rcolor) Renamed stc_custom_rcolor().
5151 (custom_viewlength) Renamed stc_custom_viewlength().
5152 (custom_workdev) Renamed stc_custom_workdev().
5154 * settings.h: Not necessary to include format.h any longer.
5156 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5157 (corrupt_msg) Rewritten.
5159 * sort.c: Adapt to rewritten heap ADT.
5161 * str.c: (aa_strcpy) Removed.
5162 (ab_strcpy) Removed.
5163 (ac_strcpy) Removed.
5164 (ba_strcpy) Removed.
5165 (bb_strcpy) Removed.
5166 (ca_strcpy) Removed.
5167 (aa_strdup) Removed.
5168 (aa_strdupcpy) Removed.
5169 (ba_strdup) Removed.
5170 (sa_strdup) Removed.
5171 (memrev) Renamed mm_reverse().
5172 (memrmem) Renamed mm_find_reverse().
5173 (cmp_str) Renamed st_compare_pad().
5174 (strmaxcpy) Removed.
5175 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5176 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5178 (strpadcpy) Renamed st_pad_copy(), signature changed.
5179 (blpstrset) Removed.
5180 (ds_create) New function.
5181 (ds_init) New function.
5182 (ds_replace) New function.
5183 (ds_destroy) New function.
5184 (ds_clear) New function.
5185 (ds_extend) New function.
5186 (ds_shrink) New function.
5187 (ds_truncate) New function.
5188 (ds_length) New function.
5189 (ds_size) New function.
5190 (ds_value) New function.
5191 (ds_end) New function.
5192 (ds_concat) New function.
5193 (ds_concat_buffer) New function.
5194 (ds_printf) New function.
5195 (ds_putchar) New function.
5196 (ds_getline) New function.
5197 (ds_get_config_line) New function derived from the old
5198 misc.c:get_config_line().
5199 (ls_create) New function.
5200 (ls_create_buffer) New function.
5201 (ls_init) New function.
5202 (ls_shallow_copy) New function.
5203 (ls_destroy) New function.
5204 (ls_null) New function.
5205 (ls_null_p) New function.
5206 (ls_empty_p) New function.
5207 (ls_length) New function.
5208 (ls_value) New function.
5209 (ls_end) New function.
5211 * str.h: Reformatted.
5212 (struct a_string) Removed.
5213 (struct b_string) Removed.
5214 (struct c_string) Removed.
5215 (struct len_string) New.
5216 (struct string) New.
5217 (macro as_streq) Removed.
5218 (macro bs_streq) Removed.
5219 (macro cs_streq) Removed.
5220 (macro sa_streq) Removed.
5221 (macro sb_streq) Removed.
5222 [__GNUC__] (inline function ds_putchar) New function.
5223 [__GNUC__] (inline function ds_length) New function.
5224 [__GNUC__] (inline function ds_value) New function.
5225 [__GNUC__] (inline function ds_end) New function.
5227 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5228 (display_vectors) Fix missing i18n.
5230 * t-test.q: Migrate to new q2c.
5232 * tab.c: Migrate from arenas to pools.
5233 (tab_create) Use struct len_string.
5234 (tab_realloc) Ditto.
5235 (text_format) Ditto.
5236 (tab_joint_text) Ditto.
5237 (tab_natural_width) Remove rich text support.
5238 (tab_natural_height) Ditto.
5239 (tab_output_text) Handle TAT_FIX.
5240 (tab_raw) Change arg from a_string to len_string.
5241 (tabi_driver) Fix assertion. Use struct len_string.
5242 (render_strip) Use struct len_string. Remove rich text support.
5243 Add `const' qualifiers.
5245 * tab.h: (enum TAB_RICH) Remove.
5246 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5247 SOM_COL_* updated to read TAB_COL_*.
5248 (struct tab_table) Change arena to pool. Change a_string to
5251 * temporary.c: (restore_dictionary) Rewrite Checker code.
5253 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5254 LOWEST, HIGHEST) Moved here from common.h.
5255 (typedef any_trns) Removed. All references changed to `struct
5258 * vars-atr.c: (force_create_variable) Fix assertion.
5259 (force_dup_variable) Fix assertion.
5261 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5263 Using alphanumeric variables in functions under AGGREGATE
5264 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5265 <BZN-mdksh@t-online.de> for reporting this bug.
5267 * aggregate.c: (parse_aggregate_functions) When setting the
5268 FSTRING bit, also allocate memory for the `string' member of
5270 (free_aggregate_functions) Free iter->string. Don't use the
5271 non-function bits when indexing the array of functions.
5272 [DEBUGGING] (debug_print) Don't use the non-function bits when
5273 indexing the array of functions.
5275 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5277 Under certain circumstances, the final case would be omitted from
5278 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5279 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5281 * aggregate.c (agr_00x_end_func): Increment number of cases in
5282 sink before writing case. For streams that keep track of how many
5283 cases there are based on this value, this means that the last case
5284 will be read in on the next stream read.
5286 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5288 Undefined behavior was invoked by referencing a freed pointer.
5290 * vfm.c (memory_stream_write): Free pointer *after* checking for
5293 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5295 A wrong record size was displayed when paging the active file to
5298 * vfm.c: (memory_stream_write) Fix off-by-one error.
5300 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5302 Not having enough temporary space for sorting caused a core dump.
5305 * sort.c: (allocate_cases) Initialize i.
5307 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5309 Syntax errors in function descriptions on AGGREGATE caused core
5312 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5313 free_aggregate_functions(), since that function already frees
5316 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5318 A null pointer was dereferenced, causing a core dump, when
5319 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5320 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5321 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5323 * arena.c: (arena_malloc) If the arena hasn't been initialized
5324 already, initialize it.
5326 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5328 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5329 for compilation with Cygnus Windows B20. Not used by other
5332 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5334 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5335 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5337 * sort.c: (compare_case_lists) Reverse sense of comparison if
5338 sorting in descending order.
5339 (compare_record) Ditto.
5341 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5343 SPLIT FILE with a string variable caused a core dump. Fixed.
5345 * vfm.c: If the variable is a string then make a temporary value
5346 struct pointing to it. The underlying problem is a lot bigger
5347 than this (see TODO) but this is a stopgap for the simple case at
5350 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5352 Nested INCLUDEs didn't work. Fixed.
5354 * getline.c: (getl_include) Set first_line to NULL in allocated
5357 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5359 The MATCH FILES procedure set the values of variables not present
5360 to 0. It should have been SYSMIS. This is now fixed.
5362 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5364 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5366 The REMARK command was too aggressive about skipping lines. It
5367 didn't like being the last command in a file.
5369 * command.c: (cmd_remark) Call get_entire_line() instead of
5372 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5374 Comment parsing wasn't consistent with the rest of the code in its
5375 idea of where one command ends and another starts. This meant
5376 that sometimes commands would be mysteriously ignored. Thanks to
5377 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5379 * command.c: (parse_cmd) Hand off comment parsing to new function
5380 skip_comment() in lexer.c.
5381 * lexer.c: (skip_comment) New function.
5383 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5385 The TABLE subcommand on MATCH FILES worked only erratically at
5386 best. This fixes it. Thanks to Dr. Dirk Melcher
5387 <BZN-mdksh@t-online.de> for reporting this bug.
5389 * get.c: (mtf_compare_BY_values) When comparing string values, a
5390 difference of 1 is still a difference :-)
5391 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5392 advance TABLE files automatically when matched. Comment fixes.
5394 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5396 VARIABLE LABELS rejected a slash before the first variable
5397 specification, contradicting the documentation. Thanks to Walter
5398 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5400 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5401 command specification.
5403 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5405 Because of an incorrect optimization in memory allocation,
5406 CROSSTABS sometimes segfaulted when asked to output multiple
5407 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5410 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5411 are passed to output_pivot_table() for its use.
5412 (output_pivot_table) Instead of assuming the number of columns is
5413 constant, keep track with maxcols. In general mode, use maxcells
5414 to determine whether more matrix cells need to be allocated.
5416 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5418 CROSSTABS didn't display value labels for column and row
5419 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5422 * crosstabs.q: (table_value_missing) If the specified value has a
5423 value label for this variable, then show it instead of the raw
5425 (display_dimensions) Delegate display of value_labels to
5426 table_value_missing.
5428 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5430 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5431 <BZN-mdksh@t-online.de> for reporting this bug.
5433 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5434 if the file isn't declared as binary.
5436 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5438 MATCH FILES corrupted memory and dumped core on some syntax
5441 * get.c: (cmd_match_files) Set file->handle to NULL before
5443 (mtf_free_file) Don't free a null dictionary.
5445 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
5447 MATCH FILES should set numeric values not available to the
5448 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
5449 <BZN-mdksh@t-online.de> for reporting this bug.
5451 * get.c: (mtf_processing) Set unused records to system-missing,
5454 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
5456 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
5457 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
5459 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
5460 in newly created dictionary, and add each copied variable to the
5463 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
5467 * get.c: (trim_dictionary) Free variable list for KEEP after
5470 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
5472 Some systems didn't like the way open_file was coded. Thanks to
5473 Hankin <hankin@rogue.consultco.com> for pointing this out.
5475 * filename.c: (open_file) Don't try to store stdin, stdout,
5476 stderr as part of an array, because that doesn't always work.
5478 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
5480 The SAVE procedure didn't save long string variables properly.
5481 Fixed by this patch. Thanks to Hankin
5482 <hankin@rogue.consultco.com> for this patch.
5484 * sfm-write.c: (write_variable) Fix off-by-one error in writing
5485 out variable pad records.
5487 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
5489 Previously, if PRINT SPACE were given a negative argument, it
5490 would report an error, then spin in an (almost) infinite loop.
5491 This fixes that behavior.
5493 * print.c: (print_space_trns_proc) After reporting a negative
5494 argument, set number of lines to print to 1.
5496 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
5498 SPSS 8.0 outputs some new record types in its system files, and it
5499 allows longer value labels. Accept these system files.
5501 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
5502 11 emitted by SPSS 8.0.
5504 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
5506 The LIST procedure was too conservative in allocating space for
5507 buffers, which caused a bug that only showed up with very long
5508 output variables. Thanks to Hankin <hankin@dunno.com> for this
5511 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
5513 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
5515 Typo meant string format specifiers weren't checked properly. I
5516 think that Hankin <hankin@dunno.com> sent me this report, but I'm
5517 willing to be corrected on this point.
5519 * format.c: (check_string_specifier) Fix obvious typo.
5521 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
5523 Using $CASENUM in an expression didn't work. Here's a fix.
5524 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
5527 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
5529 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
5531 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
5533 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
5534 other behavior, *sigh*. This patch hopefully fixes that. This
5535 time I've actually tested it.
5537 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
5539 * data-list.c: (read_from_data_list_free,
5540 read_from_data_list_list) Call parse_string_as_format() directly
5541 without mucking around with the field width.
5543 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
5545 Occasionally, you may encounter a script that wants to be
5546 interpreted in interactive mode. Make -i emulate this behavior to
5547 allow such scripts to be executed with PSPP.
5549 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
5551 * cmdline.c: (pre_syntax_message[]) Update -i description.
5553 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
5554 when -i is given on the command line) don't treat unindented lines
5555 as starting a new command.
5557 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
5559 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
5560 mostly caused by local initialized aggregates. After egcs is
5561 fixed upstream these can be removed, but for now they're not a big
5564 * ascii.c: (ascii_postopen_driver) Checker chokes on local
5565 initialized arrays. Avoid this.
5567 * sfm-write.c: (sfm_write_dictionary) Don't use a local
5570 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
5572 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
5573 following changes avoid. Currently I compile sources with egcs
5574 1.1.1 and gcc 2.7.2.3 before sending them out.
5576 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
5578 * ascii.c: (option_tab[]) Initialize all struct members.
5580 * avl.h: (avl_traverser_init) New macro.
5582 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
5585 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
5588 * hash.c: Comment fix.
5590 * hash.h: (hsh_iterator_init) New macro.
5592 * html.c: (option_tab[]) Initialize all struct members.
5594 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
5597 * postscript.c: (option_tab[]) Initialize all struct members.
5598 (output_encodings, preclose, dump_lines) Use new
5599 hsh_iterator_init() macro.
5601 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
5604 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
5607 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
5609 * data-in.c: Examined each of the parsing functions to make sure
5610 that they wouldn't dump core if they were passed a string of the
5611 wrong length, since now the DATA LIST FREE/LIST routines don't
5612 check for field width before passing it to the data parser.
5613 (parse_RBHEX, parse_AHEX) Reject odd length input.
5614 (parse_string_as_format) Reject input that's too short or too
5617 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
5618 a field to its entire declared output width then pass it to the
5619 data-in parsing routines. This contradicted the documented
5620 behavior. This is fixed in these changes. Thanks to Mark H. Wood
5621 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
5622 free-format parsing that differed from SPSS.
5623 (cut_field) Commas and spaces are treated identically. Returns
5624 the proper column instead of a fixed 1 value.
5625 (parse_field) Removed.
5626 (read_from_data_list_free, read_from_data_list_list) Call
5627 parse_string_as_format directly instead of parse_field.
5629 * heap.c: (heap_delete) Stylistic fixes.
5631 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
5633 * loop.c: (loop_2_trns_proc) Formatting fix.
5635 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
5637 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
5639 * vfm.c: (macro FILTERED) New.
5640 (static var filter_var) New.
5641 (process_active_file_write_case) Use FILTERED.
5642 (setup_filter) Set filter_var.
5643 (close_active_file) Delete the filter if not
5644 FILTER_before_TEMPORARY.
5645 (procedure_write_case) Use FILTERED.
5647 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
5649 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
5651 * data-in.c: (parse_day_count) Message fix.
5652 (parse_month) Style fix.
5654 * data-list.c: (struct data_list_pgm) New member eof.
5655 (cmd_data_list) Init eof to 0.
5656 (do_reading) Implement the /END subcommand and read-past-eof
5659 * do-if.c: Include stdio.h when debugging.
5660 (cmd_else_if) Make sure the command is .-terminated.
5662 * glob.c: (init_glob) Capitalize the command prompt.
5664 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5665 (end_file_trns_proc) Debugging message.
5667 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5669 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5671 * main.c: (dump_token) Make kwtab[] const.
5673 * set.q: Spelling, comment fixes.
5675 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5678 * vars-prs.c: (fill_all_vars) Style fix.
5680 * vfm.c: (index_to_varname) Return const.
5682 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5684 * Changes in many source files for partial -ansi -pedantic and
5685 no-debugging compliance: Remove trailing common in enum
5686 declarations; add `unused' attributes; insert some appropriate
5689 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5691 * command.c: (shell) Make static.
5692 (run_command) Make static.
5694 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5696 * dfm.c: (cmd_begin_data) I18n fix.
5698 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5700 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5702 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5705 * file-handle.q: Don't prepend the source file directory name to
5706 the data file name. (Ongoing issue.)
5707 (prepend_current_directory) Comment out.
5708 (internal_cmd_file_handle) Don't call prepend_current_directory().
5709 (fh_get_handle_by_filename) Ditto.
5711 * filename.c: Append zero byte to readlink() return value.
5713 * getline.c: (getl_read_line) I18n fix.
5715 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5717 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5719 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5722 * postscript.c: (output_encodings) Don't use local_strdup().
5725 * print.c: Don't use gcc features if __STRICT_ANSI__.
5727 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5729 * recode.c: (parse_src_spec) Fully brace nested if's.
5731 * set.q: (global var set_testing_mode) New var.
5733 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5735 * ascii.c: Add some more `unused' attributes that only come into
5736 play when NDEBUG is defined.
5737 (ascii_close_page) Set s_len when reallocating s.
5739 * crosstabs.q: (delete_missing) New function.
5740 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5741 (make_summary_table) Create summary table reallocable.
5743 * postscript.c: Add more `unused' attributes as above.
5745 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5746 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5748 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5751 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5752 gratuitous space between parameter definition.
5754 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5755 complaints about running off the end of functions with NDEBUG
5758 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5760 * Several source files: Removed some PORTME notes when reflection
5761 revealed that ANSI forbids that sort of breakage. Also, added
5762 lots of `unused' qualifiers here and there.
5764 * aggregate.c: (accumulate_aggregate_info) Remove local var
5765 weighting that turned out not to be used.
5767 * avl.c: Update to version 1.1.0. Add unused specifier.
5768 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5770 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5771 (avl_find) Cast return value to void *.
5772 (avl_delete) q doesn't need to be initialized at the beginning of
5773 the function. Replace some instances of 1 with +1.
5774 (force_avl_delete) Renamed avl_force_delete, all references changed.
5775 (compare_ints) `param' marked unused.
5776 (print_int) `param' marked unused.
5777 (recurse_tree) Replace some instances of 1 with +1.
5779 * avl.h: Update to version 1.1.0. Only declares avl function
5780 types if not already declared.
5781 (AVL_MAX_HEIGHT) Only define if not already defined.
5782 (struct avl_node) New unused member char pad[2].
5783 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5784 (force_avl_insert) Renamed avl_force_insert.
5785 (force_avl_delete) Renamed avl_force_delete.
5787 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5789 (struct crosstab) Add new member `ofs'.
5790 (glob var int_tab) Removed.
5791 (custom_tables) In integer mode, assign v[i] properly through the
5793 (custom_variables) Now p.crs.max == max + 1.
5794 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5795 (precalc) Implement integer mode.
5796 (calc_integer) Implement integer mode.
5797 (compare_table_entry) Remove unused local variable `comparing'.
5798 (make_summary_table) Implement integer mode.
5799 (macro ns_rows) Implemented as static variable now.
5800 (several variables) Made static, from global.
5801 (output_pivot_table) Use table_value_missing() for column heads.
5802 Remove several unused local variables. Implement integer mode
5803 table summing. Count up ns_rows.
5804 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5805 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5806 calls that function or find_pivot_extent_integer.
5807 (find_pivot_extent_integer) New function.
5808 (enum_var_values) Implemented for integer mode.
5809 (table_value_missing) New function.
5810 (display_dimensions) Call table_value_missing() for heads.
5811 (float_M_suffix) New function.
5812 (display_crosstabulation) Call table_value_missing() for row
5813 heads. Handle missing values in /MISSING=REPORT mode.
5814 (calc_fisher) Remove unused var N.
5815 (calc_r) Remove unused var fact.
5817 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5818 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5820 * data-out.c: (insert_commas) Remove unused var cp.
5821 (convert_CCx) Remove unused vars save_set_decimal,
5824 * descript.q: (dump_z_table) Fix table dimensioning.
5825 (pre_calc) Remove unused var j.
5826 (display) Remove unused vars title, s. Fix table dimensioning.
5828 * expr-evl.c: Comment fixes.
5830 * frequencies.q: (full_dim) New function.
5831 (dump_full) Fix table dimensioning.
5832 (condensed_dim) New function.
5833 (dump_condensed) Fix table dimensioning.
5835 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5838 * html.c: (html_close_drive) Remove unused var i.
5839 (postopen) Remove unused vars title, curfn_len, cp.
5840 (preclose) Remove unused vars this, x.
5842 * lexer.c: Comment fixes.
5844 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5846 * means.q: (custom_tables) Remove unused var m_dim.
5848 * mis-val.c: Format fix.
5850 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5852 * output.c: (outp_get_paper_size) Remove unused var cp.
5854 * pfm-read.c: (read_float) Remove unused var save, unused label
5856 (read_variables) Remove unused vars cp, j.
5857 (read_value_label) Remove unused var j.
5859 * pfm-write.c: (bufwrite) Remove unused var i.
5861 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5863 (output_encodings) Remove unused vars char_cp, n_output.
5864 (read_ps_encodings) Remove unused var ep.
5865 (postopen) Remove unused var title.
5866 (preclose) Remove unused var fp.
5867 (ps_open_page) Remove unused vars true, false, orientation,
5868 mirror_horz, mirror_vert, width, length.
5869 (ps_text_metrics) Remove unused var x.
5871 * q2c.c: (find_symbol) Remove unused var y.
5872 (parse_setting) Remove unused parameter sbc, all references
5874 (dump_parser) Remove unused var cp.
5875 (dump_free) Remove unused var i.
5877 * set.q: (static vars args, n) Removed.
5878 (internal_cmd_gset) Removed.
5880 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5881 (read_machine_flt64_info) Removed unused var file_endian.
5882 (read_documents) Removed unused var i.
5883 (read_compressed_data) Removed unused parameter dict, all
5886 * sfm-write.c: (bufwrite) Removed unused var i.
5887 (sfm_write_case) Removed unused var i.
5889 * sort.c: (merge_once) Remove unused var t.
5890 (write_separate) #if 0 out as dead code.
5892 * split-file.c: (cmd_split_file) Remove unused var i.
5894 * sysfile-info.c: (sysfile_info_dim) New function.
5895 (cmd_sysfile_info) Fix table dimensioning.
5896 (variables_dim) New function.
5897 (display_variables) Fix table dimensioning.
5898 (describe_variable) Remove unused var prev_r.
5900 * t-test.q: (z_postcalc) Removed.
5901 (pairs_calc) Remove unused var bad_weight.
5902 (postcalc) Remove unused vars dfn, dfd.
5904 * tab.c: (tab_create) Set t->dim to NULL.
5905 (tab_dim) Make sure t->dim is NULL first.
5906 (tab_natural_width) Remove parameter `clamp'.
5907 (tab_value) Remove duplicate assertion for table.
5908 (tab_raw) New function.
5909 (nowrap_dim) New function.
5910 (wrap_dim) New function.
5911 (tab_output_text) Fix table dimensioning.
5913 * tab.h: (tab_raw) New macro.
5915 * val-labs.c: (get_label) Remove unused var type.
5916 (copy_value_labels) Remove unused var trav.
5918 * var.h: (struct crosstab_proc) Completely changed.
5920 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5922 * vfm.c: (open_active_file) Remove unused vars i, lp.
5924 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5926 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5928 * Makefile.am: Add apply-dict.c, flip.c.
5930 * apply-dict.c: New file.
5932 * command.c: (struct command) Make cmd[] larger for CLEAR
5933 TRANSFORMATIONS command name.
5934 (parse_cmd) Make sure we're in a valid state before using it as an
5935 index. Discard variables and reset state on invalid transitions.
5936 (cmd_clear_transformations) New function.
5938 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
5939 Add unimplemented PRESERVE, RESTORE.
5941 * file-handle.h: Include stddef.h.
5945 * pfm-read.c: (parse_value) Pad value label values with spaces,
5948 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
5949 (sfm_close) Decrement reference count, make sure it's zero.
5950 (sfm_maybe_close) New function.
5951 (sfm_read_dictionary) Handle reference counts.
5953 * vars-atr.c: (clear_default_dict) New function.
5954 (discard_variables) Use clear_default_dict().
5956 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
5958 * Makefile.am: Add pfm-write.c.
5959 (LDADD) Add the libgmp2 libraries.
5961 * command.def: Define EXPORT.
5963 * get.c: (cmd_export) New function.
5964 (export_write_case_func) New function.
5966 * pfm-read.c: (static spss2ascii[]) Make it const.
5968 * pfm-write.c: New file.
5970 * sfm-write.c: Formatting, comment fixes.
5972 * var.h: Comment fix.
5974 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
5976 * Makefile.am: Add pfm.h, pfm-read.c.
5978 * command.def: IMPORT is now implemented.
5980 * format.c: (glob var translate_fmt[]) New var.
5982 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
5983 (cmd_import) New function.
5984 (import_source_read) New function.
5985 (glob var import_source) New var.
5987 * pfm-read.c: New file.
5991 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
5993 (dump_dictionary) Disabled printing a couple of items.
5995 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
5997 * crosstabs.q: (postcalc) Call make_summary_table().
5998 (make_summary_table) New function.
5999 (insert_summary) New function.
6000 (display_dimensions) Remove some unnecessary arguments, all
6002 (output_pivot_table) Fix lots of problems with the risk table
6004 (submit) Don't display an empty table.
6005 (display_risk) Fix order of arguments to calc_risk().
6007 * glob.c: Always include assert.h and stdlib.h.
6009 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6012 * tab.c: (tab_create) Cosmetic changes.
6014 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6016 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6020 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6021 code simplified, moved into new function submit().
6022 (submit) New function.
6023 (crosstabs_dim) New function.
6024 (display_directional) Substitute variable names for %s where
6026 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6027 (calc_symmetric) Initialize parameters only if non-NULL.
6028 Calculate Somers' d.
6029 (calc_directional) Calculate Somers' d (or copy it, really).
6032 * output.c: (outp_string_width) New function.
6034 * postscript.c: (postopen) Calculate font widths based on the
6035 width of the zero '0' character, not the width of the space
6036 character. Set paper-width and paper-length based on points, not
6038 (ps_open_page) Fix page setup string for landscape mode.
6040 * som.h: (struct som_dimension) Removed.
6041 (struct som_table_class) height, width members take int * not
6044 * tab.c: Many functions now have added parameter validation.
6045 (tab_height, tab_width) These functions were removed and merged
6046 into a single function tab_resize(), and all references changed.
6047 (tab_dim) Rewritten since the interface changed; reduced from
6048 hundreds of lines to two. All callers were changed. Currently
6049 most of them just use tab_natural_dimensions as their callback and
6050 await detailed translation of functionality.
6051 (tab_natural_width) New function.
6052 (tab_natural_height) New function.
6053 (tab_natural_dimensions) New function. This is a callback
6054 function, not something that you'd want to call directly.
6055 (tab_nat_dim) Removed.
6056 (tabi_table) Allocates t->w and t->h.
6057 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6058 dimensions callback.
6059 (evaluate_dimensions) Removed.
6060 (sum_columns) Removed.
6062 * tab.h: (enum TAL_1THIN) Removed.
6063 (enum series t_*) Removed.
6064 (struct tab_table) Members trh, trv changed to unsigned char *
6065 from int *. Member dim changed to a function pointer from a
6066 unsigned char *. Member max_stack_height removed. New members
6068 (macros tab_l, tab_r, tab_t, tab_b) New.
6070 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6072 * ascii.c: (delineate) Assign last_space_nchars before skipping
6073 spaces, to fix right justification.
6075 * crosstabs.q: (static vars risk, direct) New vars.
6076 (static var pearson_r) Removed.
6077 (glob var chisq_fisher) Made static.
6078 (static vars row_tot[], col_tot[]) Don't include grand total
6080 (static var grand_total) Renamed W, all references changed.
6081 (output_pivot_table) Only make `table' if num_cells != 0. Make
6082 risk and directional tables. Deal with grand total no longer part
6083 of col_tot[]. Free rows and cols after we're done with them.
6084 (display_risk) New function.
6085 (display_directional) New function.
6086 (clac_r) Rewritten so that it stores all its results into its
6087 arguments, so it can be used for Spearman's correlation too.
6088 (calc_symmetric) Added a t[] argument, all references changed.
6089 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6090 Pearson's r, Cohen's kappa.
6091 (calc_risk) New function.
6092 (calc_directional) New function.
6094 * som.c: (som_submit) Improved debugging code.
6096 * stats.c: (hypercube) New function.
6097 (cube) New function.
6099 (normal_sig) Went back to old implementation, which actually
6102 * stats.h: (macros square, cube, hypercube) Removed. The
6103 equivalent functions in stats.c are inlined here; all references
6104 to square changed to sqr.
6106 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6108 * crosstabs.q: (N_SYMMETRIC) New define.
6109 (postcalc) Disable debug printing.
6110 (static vars chisq_fisher, pearson_r) New.
6111 (output_pivot_table) Add support for symmetric measures. Add
6112 chi-square output of exact sigs.
6113 (display_chisq) Rewritten.
6114 (display_symmetric) New function.
6115 (gamma_int) New function.
6117 (swap) New function.
6118 (calc_fisher) New function.
6119 (calc_chisq) Check boundary conditions better. Calculate Yates,
6120 Fisher, Mantel-Haenszel tests.
6121 (calc_r) New function.
6122 (calc_symmetric) New function.
6124 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6126 (chisq_sig) Better boundary conditions. Renamed from
6129 * tab.h: (struct tab_table) New member cf.
6131 * tab.c: (tab_create) Set cf.
6132 (tab_width) New function.
6133 (tab_realloc) Handle cf.
6134 (tab_vline) Handle cf.
6135 (tab_hline) Handle cf.
6136 (tab_box) Handle cf.
6137 (tab_value) Handle cf.
6138 (tab_float) Handle cf.
6139 (tab_text) Handle cf.
6140 (tab_joint_text) Handle cf.
6141 (tab_offset) Handle cf.
6142 (tab_next_row) Handle cf.
6143 (evaluate_dimensions) Handle cf.
6144 (render_strip) Handle cf.
6146 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6148 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6149 output_pivot_table().
6150 (output_pivot_table) Moved lots of local variables outside and
6151 made them static. Add beginnings of chi-square statistic
6152 support. Now column and row totals aren't in the main matrix.
6153 Always zero out any leftover rows & columns after we're done with
6154 the table entries. Move all output stuff into
6155 display_dimensions(), display_crosstabs(), display_chisq().
6156 (display_dimensions) New function.
6157 (display_crosstabulation) New function.
6158 (display_chisq) New function.
6159 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6161 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6162 references, simplify logic.
6164 * postscript.c: Remove scale, translate-x, translate-y,
6165 mirror-horz, mirror-vert, rotate-180 options.
6166 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6167 All references deleted.
6168 (macro YT) New macro.
6169 (array option_tab[]) Removed options.
6170 (ps_option) Removed options.
6171 (ps_open_page) Write page setup explicitly to output file, without
6172 using now-deleted BP function.
6173 (macro dump_line) Use YT().
6174 (macro dump_thick_line) Use YT().
6175 (draw_headers) Use YT().
6176 (switch_font) Reorder arguments to SF function.
6177 (write_text) Use YT().
6179 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6182 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6184 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6185 null-debugging code.
6186 (tab_realloc) Remove null-debugging code. Initialize new regions
6188 (tab_vline) Support offsets.
6189 (tab_hline) Support offsets.
6190 (tab_box) Support offsets.
6192 (tab_nulls) Removed.
6195 (evaluate_dimensions) Remove null-debugging code. Understand
6196 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6197 TAB_EMPTY not present.
6199 * tab.h: New cell attribute TAB_EMPTY.
6200 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6202 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6203 try to read them from system files.
6205 * vfm.c: (dump_splits) Don't call tab_null().
6207 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6209 * crosstabs.q: (struct crosstab) Added `missing' member.
6210 (custom_tables) Init missing.
6211 (calc_general) Handle missing values.
6212 (calc_chisq) New function.
6213 (output_pivot_table) Start work on chi-square output. Update for
6214 new tab offset support functions. Shorten statistic names.
6216 * Several files: add in more `const's to placate gcc's warnings.
6218 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6221 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6222 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6223 tab_joint_text) Add col_ofs and row_ofs support.
6224 (tab_offset) New function.
6225 (tab_next_row) New function.
6226 (tab_row) New function.
6227 (tab_col) New function.
6228 (tabi_table) Add col_ofs and row_ofs support.
6230 * vars-atr.c: (is_system_missing) New function.
6232 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6234 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6235 (static var no_cells) Removed.
6236 (static var num_cells) New.
6237 (static var expected) New.
6238 (static var cells[]) New.
6239 (internal_cmd_crosstabs) Deal with new variables.
6240 (postcalc) Removed most of the meat and put it in new function
6241 output_pivot_table().
6242 (output_pivot_table) Calculates and outputs an entire pivot table.
6244 * postscript.c: (postopen) Fix problems with free()ing addresses
6245 not obtained from malloc().
6247 * som.c: (som_submit) Add assertion.
6249 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6252 * tab.c: (static var tab_names[]) New.
6253 (tab_realloc) -1 for nc or nr indicates no change.
6254 (tab_nulls) New function.
6255 (tab_dim) Use tab_names[].
6256 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6257 (evaluate_dimensions) Don't terminate on uninited cells, just put
6258 an X in them and emit a notice. Use tab_names[].
6260 * tab.h: Move bits into tab.def.
6262 * tab.def: New. Don't try to declare tab_table_class because then
6263 som.h has to be included.
6265 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6267 * command.def: New file, contains all the command definitions
6268 previously included bodily in command.c.
6270 * format.def: New file, contains all of the format definitions
6271 previously split across format.h, format.c, and sfm-write.c.
6273 * lexer.h: Renamed from tokens.h in order to match corresponding
6276 * lexerP.h: Moved some rarely used functions exported by lexer.c
6279 * Makefile.am: Commemorate renamed files.
6280 (EXTRA_DIST) Add command.def, format.def.
6282 * command.c: [0] (walk_cmdtable_func) Removed.
6284 * crosstabs.q: (postcalc) Made it work and print out matrices
6286 (enum_column_values) Renamed enum_var_values, generalized for any
6289 * format.h: (struct fmt_desc) New member `spss'.
6291 * q2c.c: (main) Generated code includes lexer.h instead of
6294 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6295 instead of an independent translation table.
6297 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6299 * Lots of source files: Added const to declarations.
6301 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6303 * arena.c: (arena_clear) Set prev pointer to null when done.
6305 * ascii.c: (ascii_option) Rename index as indx.
6307 * avl.c: This is now a separate library called libavl.
6308 (xmalloc) Make static.
6309 (avl_probe) Step A7 can use the cache instead of an explicit
6311 (avl_delete) Don't maintain a q pointer because it's always
6312 available in the pointer stack. Comment fix.
6314 * avl.h: This is now a separate library called libavl.
6316 * command.c: (cmd_table[]) Remove spurious trailing "".
6318 * common.h: Only include random() fix if this system needs it.
6320 * crosstabs.q: Include alloca headers.
6321 (n_sorted_tab) New global var.
6322 (postcalc) Mostly rewritten.
6323 (find_pivot_extent) Rewritten.
6324 (enum_column_values) Rewritten.
6326 * data-out.c: (convert_F) Rename inner n as n_spaces.
6328 * error.c: (dump_message) Don't have an outer var i.
6330 * file-handle.q: (static var f) Removed. All references removed.
6331 (internal_cmd_file_handle) Uses a local variable instead of f.
6333 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6334 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6337 * getline.h: Declare getl_history as extern. Reported by
6338 palme@uni-wuppertal.de (Hubert Palme).
6340 * postscript.c: (postopen) Some large mods for constness.
6342 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6345 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6347 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6348 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6351 * avl.c, avl.h: New files. These form a clean-room
6352 reimplementation of avllib. Iterative algorithms are used in
6353 place of recursive ones, so there is no resemblance in the code.
6355 * Lots of headers: Don't include other headers by default.
6357 * Lots of source files: Explicitly include all needed headers.
6359 * arena.c: (arena_clear) New function.
6361 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6362 (static var ar) Removed.
6363 (staitc vars ar_tc, ar_col) New.
6364 (cmd_crosstabs) Destroy the arenas.
6365 (internal_cmd_crosstabs) Create the arenas.
6366 (precalc) Don't need a free function for the hash.
6367 (calc_general) Make sure to zero out the trailer on the key data
6369 (print_table_entries) Updated.
6370 (postcalc) Worked on actually implementing.
6371 (find_pivot_extent) New function.
6372 (compare_value) New function.
6373 (enum_column_values) New function.
6375 * data-in.c: (parse_month) Make local array `static const'.
6377 * data-out.c: (convert_date) Make local array `static const'.
6378 (convert_WKDAY) Same.
6379 (convert_MONTH) Same.
6381 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6382 been renamed to avl_walk().
6384 * hash.c: Rewritten more efficiently.
6386 * hash.h: Add attribute const to hsh_next_prime declaration.
6388 * lexer.c: (id_match) Make arguments const.
6390 * postscript.c: (ps_postopen_driver) Make default fonts the
6393 * q2c.c: (main) Generated code needs stdlib.h.
6395 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6396 initialized to 0 now, not to NULL. All other references to
6397 avl_traverser were updated in the same way.
6399 * tokens.h: Macro version of id_match updated to use const
6402 * val-labs.c: (inc_ref_count) New function.
6403 (copy_value_labels) Simply through use of new avl_copy() function.
6405 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6407 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6408 (postcalc) Worked on this.
6410 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6411 (struct ps_driver_ext) New line_width_thick member.
6412 (ps_preopen_drive) Init line_width_thick.
6413 (option_tab[]) Add line-* options.
6414 (ps_option) Parse line-* options.
6415 (postopen) Add line_width_thick support. Strip leading spaces on
6416 prologue output lines.
6417 (ps_open_page) Include line_width_thick in output.
6418 (macro dump_thick_line) New.
6419 (dump_fancy_line) Support thick lines as well as double lines.
6421 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6423 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6424 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6426 * Many source files: Rename `options' to `pv_opts' as appropriate.
6428 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6430 * common.c: (xcalloc) New function.
6432 * crosstabs.q: New file. Not finished yet, though.
6434 * data-list.c: Comment fix.
6436 * error.c: Remove some old Checker cruft.
6438 * frequencies.q: (dump_full) Cumulate valid percent instead of
6441 * getline.c: Comment fix.
6443 * hash.c: Comment fixes.
6445 * hash.h: (struct hsh_table) Make hash functions return unsigned
6446 instead of int to avoid problems with taking the modulo of
6447 negative return values. All references changed.
6449 * misc.c: (intlog10) Make its table static const instead of auto.
6451 * sfm-read.c: (read_header) Make `prefix' static const instead of
6454 * var.h: (union value) Add member `hash'.
6455 (struct variable) Rename prv_index as `foo'--all references
6457 (typedef pv_opts) Removed. All references changed.
6459 * vars-prs.c: (parse_variables) Message fixes.
6461 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
6463 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
6464 they are being inserted. Don't check for BY variables of
6465 different types. Discard variables if the active file isn't
6466 included in the merge.
6467 (mtf_processing) Essentially rewritten.
6468 (mtf_merge_dictionary) Check for master/slave variables of
6469 different types/widths.
6471 * vfm.c: (static var not_canceled) New var.
6472 (process_active_file) Don't call vfm_source->read() if
6473 there's no vfm-source. Initialize not_canceled.
6474 (process_active_file_write_case) Honor and update not_canceled.
6475 (prepare_for_writing) Rollback changes from yesterday, they were
6477 (close_active_file) Don't destroy vfm_source unless it exists.
6479 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
6481 * Lots of source files: Added { } around nested if/else constructs
6482 to avoid new gcc 2.8 warnings.
6484 * data-in.c: (parse_Z) Declare `int' type explicitly.
6487 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
6488 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
6489 prev members. Put TABLEs at the end of the chain and FILEs at the
6490 beginning. Don't allow the active file in STATE_INIT. Use proper
6491 `seen' value for the active file. Fill out the by members and
6492 make sure they're of consistent type. Do the actual merge
6494 (mtf_processing_finish) New function.
6495 (var_type_description) New function.
6496 (mtf_free_file) New function.
6497 (mtf_free) Rewritten.
6498 (mtf_delete_file_in_place) New function.
6499 (mtf_read_nonactive_records) New function.
6500 (mtf_compare_BY_values) New function.
6501 (static var mtf_seq_no) New var.
6502 (mtf_processing) New function.
6503 (mtf_merge_dictionary) Assign nval members for the system file
6504 dictionary. Assign fv values for its variables. Point each slave
6505 variable to the corresponding master variable.
6507 * hash.c: Include str.h.
6509 * mis-val.c: (copy_missing_values) src arg is const.
6511 * misc.c: (spacing) Make `max' var explicitly int.
6513 * sfm-read.c: (dump_dictionary) Message reformatting.
6514 (sfm_read_case) Add assertion.
6516 * sort.c: Esthetic fixes.
6518 * var.h: (struct match_files_proc) New struct.
6519 (struct variable) Add private data match_files_proc.
6521 * vars-atr.c: (delete_variable) Implement. Add argument for the
6522 dictionary that owning the variable.
6523 (dup_variable) Add assertion.
6525 * vfm.c: Comment fixes, hopefully the comments are correct now.
6526 (process_active_file) New function.
6527 (process_active_file_write_case) New function.
6528 (process_active_file_output_case) New function.
6529 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
6531 (write_case) Renamed procedure_write_case(). Now write_case is a
6532 pointer to a function. Style fixes.
6534 1998-03-05 Ben Pfaff <blp@gnu.org>
6536 * Makefile.am: (q2c) Link with libmisc.
6537 (version.c) Define default_config_path, include_path,
6540 * ascii.c: (ascii_postopen_driver) When the default newline string
6541 is requested, open file in text mode. Suggested by
6542 palme@uni-wuppertal.de (Hubert Palme).
6543 (static vars line_buf, line_p) Change from char * to unsigned char
6545 (ascii_close_page) char * to unsigned char *.
6547 * cmdline.c: (parse_command_line) Implement -r option by
6548 prepending ~/.pspp/rc to the list of files to process.
6550 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
6551 before pulling in a final line.
6552 (null_func, null_int_func) Removed (dead code).
6554 * descript.q: (display) Calculate width of variable name column
6555 properly. Calculate number of valid cases properly. Reported by
6556 palme@uni-wuppertal.de (Hubert Palme).
6558 * filename.c: (init_filename) Use default_config_path instead of
6559 now obsolete CONFIG_PATH.
6561 * getline.c: (getl_initialize) Use include_path instead of now
6562 obsolete INCLUDE_PATH.
6563 (getl_add_file) New argument `where'. All references changed.
6565 * groff.c: (find_font_file) Use groff_font_path instead of now
6566 obsolete GROFF_FONT_PATH.
6568 * postscript.c: (find_ps_file) Use groff_font_path instead of now
6569 obsolete GROFF_FONT_PATH. Copy through temporary variable to
6570 avoid problems with constness.
6572 * str.h: (macro cs_streq) New macro.
6574 * version.h: (glob var default_config_path, include_path,
6575 groff_font_path) New vars.
6577 1998-02-23 Ben Pfaff <blp@gnu.org>
6579 * Many source files: Change verbose_msg() priority levels and
6582 * aggregate.c: Include debug-print.h.
6584 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
6586 (static var pre_syntax_message) Document --safer/-s and
6589 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
6591 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
6592 because it's not used but it's still copied.
6593 (open_file_r) Remove gratuitous debug message.
6595 * filename.c: (safety_violation) New function.
6596 (open_file) Remove gratuitous debug messages. Don't allow pipe
6597 files if set_safer is set.
6599 * get.c: Turn off debugging.
6601 * getline.c: (getl_add_virtual_file) New function.
6602 (getl_read_line) Add verbose_msg() call for opening new syntax
6604 (getl_perform_delayed_reset) Add a return value describing whether
6605 any action was taken. Call reset_eof().
6607 * getline.h: Comment fix.
6609 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
6610 place of incorrect `continue'. Use strtok_r() instead of
6611 strtok(). Always check strtok_r() return value.
6612 (groff_read_DESC) Use strtok_r() instead of strtok().
6614 * lexer.c: (reset_eof) New function.
6616 * main.c: (parse) Get a token after performing a delayed reset
6617 action; allow empty syntax files.
6619 * postscript.c: (output_encodings) Use strtok_r() instead of
6622 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
6624 * set.q: Comment fixes.
6625 (glob var set_safer) New var.
6626 (internal_cmd_set) Support SAFER.
6628 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
6630 * temporary.c: (free_dictionary) Set d->splits to NULL after
6633 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
6634 variable deleted, not if it *isn't* deleted.
6636 1998-02-16 Ben Pfaff <blp@gnu.org>
6638 * command.c: (array cmd_table[]) Add MATCH FILES.
6640 * common.c: Comment fixes.
6642 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
6643 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
6644 Include alloca.h. Problem reported by palme@uni-wuppertal.de
6647 * expr-opt.c: Include str.h. Problem reported by
6648 palme@uni-wuppertal.de (Hubert Palme).
6650 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
6651 (static var mtf_by) Change from char ** to variable **.
6652 (static var mtf_master) New var.
6653 (mtf_merge_dictionary) New function.
6654 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
6655 var type. Reorder tests properly. Initialize file->dict. Detect
6656 TABLE= without BY=. Read file dictionaries and merge them. Give
6657 subcommand name with IN, LAST, FIRST error messages. Create IN,
6658 LAST, FIRST variables. Comment fixes.
6659 (mtf_free) Don't free default_dict. Free mtf_master.
6661 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6663 (handle_line_buffer) Cast int to size_t in comparison to avoid
6666 * getline.h: Declare getl_mode extern.
6668 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6669 (groff_read_DESC) Make line_size a size_t.
6670 (match_tok) Parenthesize name to avoid macro expansion.
6672 * mis-val.c: (copy_missing_values) New function.
6674 * postscript.c: (postopen) Make buf_size a size_t.
6676 * sfm-read.c: (dump_dictionary) Make global from static. Print
6677 variable info in parts for easier debugging with Checker.
6679 * temporary.c: (copy_variable) Use copy_value_labels().
6680 (new_dictionary) New arg: whether to copy file label, documents.
6682 * val-labs.c: (copy_value_labels) New function.
6684 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6686 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6688 (dup_variable) Set prv_index, get.fv, get.nv.
6690 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6692 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6694 * Many source files: For ANSI-compliance, add empty statement
6695 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6696 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6698 * data-in.c: (parse_numeric) Some header files break on
6699 -DBL_MIN_10_EXP because they get a --; add () for safety.
6700 Reported by palme@uni-wuppertal.de (Hubert Palme).
6702 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6703 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6704 (dfm_close) Use close_file_ext.
6705 (open_inline_file) Set file.file to NULL, not file.
6706 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6707 struct and use open_file_ext().
6708 (read_record) Use file.file.
6710 * file-handle.q: (prepend_current_directory) Pass through special
6713 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6714 (normalize_filename) Pass through special filenames.
6715 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6717 (dirname) Rename blp_dirname() because of name conflict on some
6718 OS. All references changed. Reported by palme@uni-wuppertal.de
6720 (is_special_filename) New function.
6722 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6723 (trim_dictionary) Conditionalize some of the options on whether
6724 GTSV_OPT_MATCH_FILES is in *options.
6725 (rename_variables) Don't allow variables to be renamed as scratch
6727 (MTF_*) New enum series.
6728 (struct mtf_file) New struct.
6729 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6731 (cmd_match_files, mtf_free) New functions.
6733 * lexer.c: (match_int) Needed parentheses around name to escape
6734 macro expansion. Reported by Micah Altman
6735 <maltman@www-vdc.fas.harvard.edu>.
6737 * print.c: Needed to include alloca.h. Reported by Micah Altman
6738 <maltman@www-vdc.fas.harvard.edu>.
6740 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6741 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6744 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6745 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6747 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6749 * html.c: (struct html_driver_ext) Move into htmlP.h.
6750 (html_preopen_driver) Initialize cp_x, cp_y.
6751 (html_submit) Implement as call to output_tab_table().
6752 (change_attributes) New function.
6753 (escape_string) New function.
6754 (output_tab_table) New function.
6756 * list.q: (write_all_headers) Add code for writing headers for the
6758 (clean_up) Write out the html close-table tag.
6759 (determine_layout) Ignore html driver.
6760 (list_cases) Write html data.
6762 * som.c: (som_submit) Move more of the code into output_table().
6764 * tab.c: (static var hit) Make a global var and rename tab_hit.
6765 (static var tab_table_class) Make a global var.
6767 * htmlP.h: New file.
6769 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6771 * dump-sysfile.c: Removed.
6773 * html.c: (preclose) Change comment in emitted code.
6775 * matrix-data.c: Debugging off by default. Comment fixes.
6776 (static var container) New var.
6777 (cmd_matrix_data) Create and destroy container. Initialize
6778 is_per_factor[] to 0s. Move code into new function
6779 string_to_content_type(). Require split values to be present in
6780 the data when ROWTYPE_ is explicit. Call specific function, not
6781 general read_matrices().
6782 (string_to_content_type) New function.
6783 (context) Exclude all whitespace, not just spaces.
6784 (mget_token) A dot is a number. Add assertion.
6785 (static var data) Renamed nr_data.
6786 (static var factor_values) Renamed nr_factor_values.
6787 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6788 only specific case. Close data_file before exit.
6789 (fill_matrix) New function.
6790 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6791 printing. Style fixes. Message fixes. Move code into
6793 (read_matrices_without_rowtype) Rename
6794 matrix_data_read_without_rowtype(). Fix off-by-one error on
6795 loops. Allocate nr_data[] memory from arena.
6796 (read_matrices_with_rowtype) Removed.
6797 (read_splits) Renamed nr_read_splits(). Style fixes.
6798 (read_factors) Renamed nr_read_factors().
6799 (dump_cell_content) Comment fixes. Arguments changed. Change
6800 debug printing. All references changed.
6801 (output_data) Renamed nr_output_data().
6802 (static var wr_content) New var.
6803 (struct factor_data) New struct.
6804 (static var wr_data) New var.
6805 (static var wr_current) New var.
6806 (matrix_data_source_destroy_source) Removed.
6807 (read_matrices_with_rowtype) New function.
6808 (matrix_data_read_with_rowtype) New function.
6809 (wr_read_splits) New function.
6810 (compare_factors) New function.
6811 (wr_output_data) New function.
6812 (wr_read_rowtype) New function.
6813 (wr_read_factors) New function.
6814 (wr_read_indeps) New function.
6815 (glob var matrix_data_source) Make destroy_source member NULL as
6818 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6820 * lexer.c: (syntax_error) Give better error message when at end of
6823 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6824 N_SCALAR to output as plain N.
6825 (mdump_token) Change output format.
6826 (context) Fix message output interaction with spaces in input.
6827 (another_token) New function.
6828 (force_eol) Improved error message.
6829 (static var max_cell_index) New var.
6830 (read_matrices) Init `cells'. factor_values is now per-cell.
6831 Init max_cell_index.
6832 (read_data_lines) Replace `compare' local with new `compare' arg.
6833 Debugging messages changed. Only read factors if per_factor.
6834 Propagate error return from read_factors(), force_eol().
6835 Copy N_SCALAR values across the N vector.
6836 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6837 check parentheses manually since we now have is_per_factor[].
6838 Call read_data_lines() with new args. Check for end of data after
6839 looping, using another_token().
6840 (read_factors) Arguments changed. Use max_cell_index to determine
6841 whether to read or compare factors. Message fixes.
6842 (dump_cell_content) New function.
6843 (output_data) Completely rewritten because content types were
6844 supported to be nested inside factor values, not vice versa.
6846 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6848 * lexer.c: (syntax_error) Support formatted varargs messages.
6850 * matrix-data.c: Turn debugging on by default.
6851 (static content_type[]) New array.
6852 (static content_names[]) New array.
6853 (static rowtype_, varname_) New vars.
6854 (static is_per_factor[]) New array.
6855 (static split_values) Moved declaration.
6856 (static n_continuous, first_continuous) New var.
6857 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6858 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6859 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6860 Check for continuous variables.
6861 [DEBUGGING] (debug_print) Remove content_names[].
6862 (mdump_token) New macro.
6863 (mget_token_dump) New function.
6864 (mdump_token) New function.
6865 (context) New function.
6866 (mget_token) Fix messages.
6867 (static var data, split_values, factor_values) New vars.
6868 (read_matrices) Manage split_values, factor_values.
6869 (read_data_lines) New function.
6870 (read_matrices_without_rowtype) Implemented.
6871 (read_splits) Message fixes. Uses `just_read'.
6872 (read_factors) New function.
6873 (output_data) New function.
6874 (matrix_data_source_destroy_source) Close the file handle.
6875 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6878 * str.c: (strpadcmp) Removed.
6880 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6882 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6884 * Lots of source files: Add cast to unsigned character to calls to
6885 tolower() and toupper().
6887 * aggregate.c: Set default_dict.splits to NULL.
6889 * command.c: (static variable tab[]) Add MATRIX DATA.
6891 * data-in.c: Add debugging defines. Formatting fixes.
6893 * expr-opt.c: Formatting fixes.
6895 * lexer.c: (syntax_error) Message fixes.
6897 * matrix-data.c: New enum series.
6898 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6899 split_values, n_factors, factors, cells, pop_n, contents,
6900 n_contents) New vars.
6901 (cmd_matrix_data) Finished implementation.
6902 (compare_variables_by_mxd_vartype) New function.
6903 [DEBUGGING] (debug_print) New function.
6904 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6905 (read_matrices) New function.
6906 (read_matrices_without_rowtype) New function.
6907 (read_matrices_with_rowtype) New function.
6908 (read_splits) New function.
6909 (mget_token) New function.
6910 (force_eol) New function.
6911 [0] (test_tokenizer) New function.
6912 (matrix_data_source_destroy_source) New function.
6913 (glob var matrix_data_source) New var.
6915 * misc.h: Include ieeefp.h if present.
6917 * split-file.h: (cmd_split_file) Changes corresponding to struct
6920 * str.h: Fix memmem prototype.
6922 * temporary.c: (save_dictionary, restore_dictionary,
6923 free_dictionary) Changes corresponding to struct dictionary
6926 * var.h: (MXD_* enums) New enum series.
6927 (struct matrix_data_proc) New struct.
6928 (struct split) Removed.
6929 (struct dictionary) Changed `splits' member from `split *' to
6931 (macro force_create_variable) New macro. Replaced lots of
6932 create_variable()/assert() calls with calls to this macro.
6934 * vars-atr.c: (discard_variables) Changed assertion.
6935 [GLOBAL_DEBUGGING] (force_create_variable) New function
6936 called by the macro of the same name.
6937 (clear_variable) Changes to delete splits from the dictionary
6938 corresponding to struct dictionary changes.
6940 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
6941 corrupted variable `index' values in the dictionary passed in
6942 every time this function is called.
6944 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
6945 to struct dictionary changes.
6947 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
6949 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
6951 * command.c: New includes.
6952 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
6953 (cmd_erase) New function.
6954 [unix] (shell) New function.
6955 (run_command) New function.
6956 (cmd_host) New function.
6957 (cmd_new_file) New function.
6959 * expr-prs.c: (parse_primary) Message fix.
6961 * inpt-pgm.c: Formatting fix.
6962 (cmd_reread) Implement the FILE subcommand.
6964 * matrix-data.c: New file.
6966 * q2c.c: (dump_header) Change output commenting style.
6968 * weight.c: Comment fix.
6970 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
6972 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
6974 (buf_10x) Renamed buf_1xx, all references changed.
6975 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
6976 cases now implemented).
6977 (create_sysfile) New function.
6978 (agr_11x_func) New function.
6980 * data-in.c: (parse_numeric) Work properly if there's an
6981 explicitly coded decimal point in the data and decimal places are
6982 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
6983 <el@linux.lisse.na>.
6985 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
6986 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
6987 Eberhard W Lisse <el@linux.lisse.na>.
6989 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
6990 strerror.c. Bug reported by Alexandre Oliva
6991 <oliva@dcc.unicamp.br>.
6993 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
6994 (static var separate_case_tab) New var.
6995 (cmd_sort_cases) Cancel temporary transformations here. Free
6996 v_sort before return.
6997 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
6998 we're reading from a sort stream. Don't cancel temporary
6999 transformations. Offload internal sorting to do_internal_sort().
7000 (do_internal_sort) New function. Handles internal sorting even
7001 when SEPARATE is nonzero. Doesn't free v_sort.
7002 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7004 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7005 sink if SEPARATE is zero.
7006 (read_output_cases) Renamed read_sort_output(), all references
7007 changed. Now uses separate_case_tab when it exists.
7008 (write_separate) New function.
7010 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7011 memory_sink_cases. Don't redundantly call
7012 vfm_source->destroy_source().
7013 (memory_stream_mode) After switching over, set memory_sink_cases
7016 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7018 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7020 (static var prev_case) New, moved out of aggregate_single_case()
7022 (static var buf64_10x, buf_10x) New.
7023 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7024 the 000, 001, 100, and 101 cases. Free prev_case.
7025 (parse_aggregate_functions) Disallow scratch variables.
7026 (free_aggregate_functions) Only free agr_dict if non-null. Use
7027 iter->function to determine numeric/string type, not
7029 (aggregate_single_case) Don't manage prev_case. Initialize
7030 aggregate info after dumping it.
7031 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7032 mean, stddev, weighted stddev definitions.
7033 (dump_aggregate_info) Implemented.
7034 (initialize_aggregate_info) Renamed from
7035 initialize_aggregate_functions(). Initializes dbl[2].
7036 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7037 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7039 * cases.c: (alloc_val) Removed.
7041 * get.c: (cmd_save_internal) Initialize new `dict' member.
7043 * sfm-write.c: (sfm_write_dictionary, write_header,
7044 write_variable, write_value_labels, write_documents) Reorganize,
7045 simplify for new parameter structure.
7046 (write_variable) Only one variable * argument now.
7048 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7049 replaced by new `dict' member.
7051 * temporary.c: (new_dictionary) Initialize n_documents.
7053 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7055 (init_variable, replace_variable) Eliminate usage of alloc_val().
7057 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7059 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7060 signal that AGGREGATE is to be used for forming final cases.
7061 (close_active_file) Call end_func before stopping lagging. Cancel
7062 temporary after finishing compaction.
7063 (write_case) Comment fixes. Cleaned up.
7064 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7067 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7069 * Makefile.am: (BUILT_SOURCES) Add means.c.
7070 (pspp_SOURCES) Add means.c.
7071 (EXTRA_DIST) Add means.q.
7073 * command.c: (array cmd_table[]) Add MEANS.
7075 * common.h: Esthetic fixes. Comment fixes. Test for
7076 MAX_SHORT_STRING greater than 8.
7077 (macros LOWEST, HIGHEST) New.
7079 * data-in.c, data-list.c, recode.c: Comment fixes.
7081 * means.q: New file, base version.
7083 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7084 with LOWEST, DBL_MAX with HIGHEST.
7086 * q2c.c: (dump_vars) Add an enum to array types giving the number
7087 of values for the enum.
7089 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7090 Replace second_lowest_value with second_lowest_flt64.
7092 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7093 second_lowest_value with second_lowest_flt64.
7095 * t-test.q: Comment fix.
7097 * temporary.c: (restore_dictionary) Esthetic fix.
7099 * tokens.h: (force_match_id, force_match, force_string, force_int,
7100 force_num, force_id) Replace msg() with syntax_error().
7102 * var.h: (struct means_proc) New.
7103 (struct variable) Add mns member to `p' union.
7105 * vars-prs.c: (parse_variable, parse_dict_variable,
7106 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7109 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7111 * Makefile.am: (pspp_SOURCES) Add tab.h.
7113 * Most source files: Added a cast to unsigned char in usages of
7114 the ctype is*() functions. Replaced `end of command expected'
7115 calls to msg() with calls to syntax_error().
7117 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7119 * lexer.c: (hex_val) Removed (was dead code).
7120 (idmatch) Parenthesize function name to avoid macro expansion.
7122 * postscript.c: Comment fixes.
7123 (ps_preopen_driver) Change default font size to 10pt.
7125 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7127 (parse_format_spec) Change system-file format spec argument type
7128 to int32. Parse the format spec with bitwise operators.
7130 * sfmP.h: (struct sysfile_format) Removed.
7131 (struct sysfile_variable) Changed print, write members from
7132 sysfile_format to int32.
7134 * tokens.h: Esthetic fixes.
7135 [__GNUC__] (macro id_match) New macro to hopefully speed up
7136 identifier matching.
7137 (macros match_id, match_tok, match_int) Implemented in
7138 compiler-independent manner; no longer GNU C only.
7140 * vfm.h: Include time.h.
7142 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7144 * data-list.c: (dump_fixed_table) Change tab_dim().
7146 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7148 * error.c: Include command.h.
7150 * frequencies.g: Formatting fixes.
7152 * frequencies.q: Add tab_dim() calls. Make the total cell a
7155 * glob.c: Include command.h.
7157 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7159 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7160 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7161 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7162 the other elements (is this right?).
7163 (read_variables) Use lowest, highest members.
7164 (parse_format_spec) New arg `vv' for more stringent checking.
7165 (dump_dictionary) Byteswaps nonexplicit data.
7166 (sfm_read_case) Byteswap numeric data.
7168 * som.c: Initialize table_num to 1.
7169 (render_segments) Remember to increment y_index after each table
7172 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7173 avl_count() on a NULL tree. No title for the second table.
7174 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7175 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7176 fix call to display_variables().
7177 (display_variables) Default to 4 columns, not 3. Set up headers.
7178 Column title is Variable, not Name. Fix index column.
7179 Add joint text. Add tab_dim(). Handle value labels properly.
7180 Handle DISPLAY LABELS properly. Draw boxes correctly.
7181 (describe_variable) Value labels don't need titles. Don't clear
7182 nonexistent index column.
7183 (compare_vectors_by_name) New function.
7184 (display_vectors) New function.
7186 * tab.c: (tab_height) Add assertion.
7187 (tab_null) Add debug code.
7188 (evaluate_dimensions) Add debug code.
7190 * var.h: (struct variable) get_proc data is sometimes used
7191 simultaneously with other per-procedure info, therefore it was
7192 removed from the union. All references changed.
7194 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7196 * ascii.c: (ascii_close_page) Put title on second line of headers
7197 if there is no subtitle.
7199 * command.c: (glob var cur_proc) Move definition here, from
7201 (cmd_remark) Emit blank line before remarks.
7203 * command.h: (glob var cur_proc) Move declaration here, from
7206 * data-list.c: (dump_fixed_table) Fix messages.
7207 (dump_free_table) Call tab_nat_dim().
7209 * descript.q: (dump_z_table) Modify tab_dim() call.
7211 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7213 (dump_statistics) Don't output header.
7215 * groff-font.c: Minor format fix.
7217 * html.c: Comment fix.
7219 * list.q: (write_varname) Indent after advancing page.
7221 * output.h: Minor reordering.
7223 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7224 a reference to eol[].
7225 (struct ps_driver_ext) New member eol[].
7226 (ps_preopen_driver) Initialize eol[].
7227 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7228 defaults. Handle headers. Fix test for minimum page length.
7229 (static var option_tab[]) Add `line-ends'.
7230 (ps_option) Handle line-ends to change eol[].
7231 (postopen) Scale prop_em_width and fixed_width properly. Set the
7232 prologue title to outp_title if applicable. Replace the prologue
7233 line ends with eol[]. Call draw_headers() if headers are enabled.
7234 (text_width) New function.
7235 (out_text_plain) New function.
7236 (draw_headers) New function.
7238 * print.c: (dump_table) Call tab_nat_dim().
7240 * som.c: (som_blank_line) Only advance a line if not at the top of
7242 (som_submit) Move several informational table calls here.
7243 Increment subtable_num if SOMF_NO_TITLE not set.
7244 (output_table) Advance a line if SOMF_NO_SPACING not set.
7245 (render_columns, render_segments, render_simple) Handle spacing
7246 between tables. Handle table titles. Remove debug output.
7248 * som.h: (SOMF_*) New enum series.
7249 (struct som_table_class) New member `flags'.
7251 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7253 (display_variables) Calls tab_nat_dim().
7254 (describe_variable) Remove restriction on number of value labels.
7255 Make value labels separated by thin lines.
7257 * tab.c: (tab_create) Default `flags' to none.
7258 (tab_float) New arg `w'. All references changed.
7259 (tab_nat_dim) New function.
7260 (tab_output_text) No title or spacing.
7261 (tab_flags) New function.
7262 (tabi_flags) New function.
7263 (tabi_title) New function.
7264 (strip_height) Removed.
7265 (tabi_render) Skip title when necessary.
7266 (static var tab_tab_class) Add tabi_flags, tabi_title.
7267 (evaluate_dimensions) Disable display of column, row size.
7268 (sum_columns) Add title height to top header.
7269 (render_strip) Moved within file.
7271 * tab.h: (struct tab_table) New member `flags'.
7273 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7275 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7277 * Most source files: Add `const' attribute in all appropriate
7280 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7281 column to the variables table for use by describe_variable().
7282 (cmd_display) Disable for the present.
7283 (display_documents) Don't wrap documents.
7284 (display_variables) Table has four columns now.
7285 (describe_variable) Table has four columns now. Don't use a
7286 subtable, use joined cells instead.
7288 * tab.c: (tab_create) Don't set `join'.
7289 (tab_realloc) ct array is not made up of a_string's.
7290 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7291 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7292 (text_format) New function.
7293 (tab_title) Rewritten, uses text_format().
7294 (tab_text) Rewritten, uses text_format().
7295 (tab_joint_text) New function.
7297 (static var hit) New variable.
7298 (render_strip) New args r1, r2. Implement joined cells that fit
7300 (tabi_render) Increment hit. Pass new args to render_strip().
7301 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7302 cells. For t_naw and t_nah, ignore joined cells and null cells in
7305 * tab.h: (struct tab_join_rect) Removed.
7306 (struct tab_table) Removed `join'.
7307 (TAB_JOIN_MAIN) Removed.
7308 (struct tab_joined_cell) New struct.
7309 (TAT_NOWRAP) New enum.
7311 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7313 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7315 (ascii_postopen_driver) Fix initialization of *_spacing so that
7316 the TAL_0 bit doesn't count.
7318 * data-list.c: (dump_fixed_table) Use natural width for Format
7321 * glob.c: (rerange) Removed.
7322 (get_date) Formatting fixes. Internationalization fix.
7324 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7327 * postscript.c: (ps_postopen_driver) Replace
7328 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7330 * som.c: (som_submit) Don't eject page before every table.
7331 (output_table) Fix order of arguments on call to area().
7332 (render_columns) Fix calculation of max_len.
7334 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7335 (render_strip) New function.
7336 (strip_height) New function.
7337 (tabi_render) Rewrite as calls to render_strip().
7339 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7340 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7341 with the TAB_* and OUTP_T_* constants.
7343 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7345 * Makefile.am: Formatting fixes.
7347 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7350 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7352 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7354 * dump-sysfile.c: (glob var length) Make type off_t.
7355 (usage) Fix arguments.
7358 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7359 Now right-justification is the default so many references had to
7361 (struct outp_class) Removed line_width, all references changed.
7362 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7363 (struct outp_driver) Add elements horiz_line_width,
7364 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7367 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7369 (postopen) Initialize all the informational members of
7372 * som.c: (som_blank_line) New function, renamed from blank_line(),
7373 all references changed.
7374 (som_submit) Disables drivers whose pages can't be opened.
7375 (render_columns, render_simple, render_segments) Add debug output.
7376 (render_columns) Fix loop range.
7377 (render_simple) Don't try to render the headers, they're taken
7378 care of automatically. Advance cp_y past the table when done.
7379 (render_segments) Fix loop ranges.
7381 * tab.c: Initialize new members of tab_table.
7382 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7383 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7384 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7387 (tab_dim) New function.
7388 (tab_col_width) Removed.
7389 (tab_row_height) Removed.
7390 (tab_output_text) Call tab_dim().
7391 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7392 (tabi_area) Implemented.
7393 (tabi_cumulate) Implemented.
7394 (tabi_render) Partially implemented, but broken.
7395 (var tab_table_class) Made static.
7396 (evaluate_dimensions) New function.
7397 (sum_columns) New function.
7399 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7400 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7401 t_scr, t_srr, t_sentinel. Removed: t_nat.
7402 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7403 max_stack_height, w, h. Removed: ce, re.
7404 (macro blank_line) Removed.
7405 (glob var zero_length) Removed.
7407 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7409 * Most source files: include some of the new include files broken
7412 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7415 * aggregate.c: (glob var outfile) Make static.
7417 * command.c: (glob var pgm_state) Move here.
7419 * common.c: (glob vars endian, second_lowest_value, pgmname,
7420 finished, curdate, cur_proc, start_interactive, history_file) Move
7423 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7425 * file-handle.q: (glob vars files, inline_file) Move here.
7427 * glob.c: Lost lots of glob vars, detailed in individual file
7429 (init_glob) set_printer, set_screen were obsolete, deleted.
7430 set_cprompt has fewer spaces because pspp has fewer letters than
7433 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7434 (inp_nval) Made static.
7436 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7437 tokstr_len, toklongstr, tokint) Move here.
7439 * misc.c: Lost several vars and functions.
7441 * set.q: (all the set_* variables) Move here.
7443 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
7444 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
7447 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
7449 * tab.h: (enum series t_*) New enums.
7450 (struct tab_table) Use arena struct tag. New members ce, re.
7452 * tokens.h: Comment fixes.
7454 * var.h: Move lots of enums and variables and functions and
7455 structures to other files. Use and declare a lot more union and
7456 struct tags. Comment fixes.
7458 * vector.c: (glob vars vec, nvec) Move here.
7460 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
7461 init_blanks, last_vfm_invocation) Move here.
7463 * cases.h: New file.
7464 (struct long_vec) Move here.
7465 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
7468 * command.h: New file.
7469 (STATE_* enums) Move here.
7470 (glob var pgm_state) Move here.
7472 * format.c: New file.
7473 (glob var formats) Move here.
7474 (parse_format_specifier_name, fmt_to_string,
7475 check_input_specifier, check_output_specifier,
7476 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
7479 * format.h: New file. Move functions now in format.c here.
7480 (FMT_* enums) Move here.
7481 (struct fmt_desc) Move here.
7482 (FCAT_* enums) Move here.
7483 (struct fmt_spec) Move here.
7484 (glob vars formats, fmt_parse_ignore_error) Move here.
7486 * inpt-pgm.h: New file.
7487 (INP_* enums) Move here, make #defines into enums.
7488 (glob vars inp_init, inp_init_size) Move here.
7491 (glob vars v_sort, nv_sort) Move here.
7492 (sort_cases, read_sort_output) Move here.
7494 * vector.h: New file.
7495 (struct vector) Move here, add struct tag.
7496 (glob vars vec, nvec) Move here.
7497 (find_vector) Move here.
7500 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
7501 reinit_blanks, init_zero, init_blanks) Move here.
7502 (struct case_stream) Move here.
7503 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
7504 vfm_disk_stream, sort_stream, data_list_source,
7505 input_program_source, file_type_source, get_source, n_lag) Move
7507 (procedure, write_case, lagged_case, compact_case, page_to_disk)
7510 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
7512 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
7513 (LDADD) Add libdcdflib.
7515 * ascii.c: Comment and formatting fixes. Almost every external
7516 function had an assert added, checking driver_open and page_open.
7517 (ascii_init_driver) Broken into ascii_preopen_driver,
7518 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
7519 (ascii_open_page) Sets page_open.
7520 (ascii_close_page) Clears page_open.
7522 * html.c: Comment and formatting fixes. Almost every external
7523 function had an assert added, checking driver_open and page_open.
7524 (html_init_driver) Broken into html_preopen_driver,
7525 html_postopen_driver, html_close_driver. Manages driver_open.
7526 (html_open_page) Sets page_open.
7527 (html_close_page) Clears page_open.
7528 (html_submit) Disabled.
7530 * lexer.c: (parse_string) Remove debugging printf.
7532 * list.q: (determine_layout) Open a page if one is not yet open.
7534 * output.c: Comment fixes.
7535 (add_class) Set the class member of the new list element.
7536 (parse_options) Don't handle device type.
7537 (colon_tokenize) New function.
7538 (configure_driver) New four-field format with a field for device
7539 type. Now initialize driver_open, page_open, next, and prev
7540 fields. Use new colon_tokenize() function. Don't do a memory
7541 copy to replace a driver, it doesn't work; instead delete the old
7542 driver and insert a new one.
7543 (destroy_driver) Don't call som_destroy_driver(). Close the page
7544 if it's open. Find the class in the list of classes and decrement
7545 that reference count. Remove the driver from the global driver
7547 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
7548 references changed. Rewritten. Don't return a driver that's not
7550 (outp_eject_page) All references to som_internal_eject_page()
7551 changed to use this. Sets cp_x to 0 as well as cp_y.
7553 * output.h: (OUTP_I_* enums) Removed.
7554 (struct som_submission_form) Removed.
7555 (struct outp_class) init_driver broken into preopen_driver,
7556 postopen_driver, and close_driver. submit changed to take a
7559 * postscript.c: Comment and formatting fixes. Almost every
7560 external function had an assert added, checking driver_open and
7562 (ps_init_driver) Broken into ps_preopen_driver,
7563 ps_postopen_driver, ps_close_driver. Manages driver_open.
7564 (ps_open_page) Sets page_open.
7565 (ps_close_page) Clears page_open.
7567 * som.c: New file, base implementation.
7569 * som.h: (struct som_table) Add struct tag.
7570 (enum SOM_COL_ACROSS) Removed.
7571 (SOM_ROWS, SOM_COLUMNS) New enums.
7572 (struct som_table_class) Add member `cumulate'. Remove `segment';
7573 change `render' arguments.
7574 (struct som_point, struct som_rect) Removed.
7575 (som_submit_table) Fixed typo, should have been som_submit.
7577 * sysfile-info: (describe_variable) Don't try to insert a
7578 subtable; just destroy it for now.
7580 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
7581 references to value labels.
7583 * tab.c: (tab_destroy) New function.
7584 (tab_columns) Change argument.
7585 [0] (tab_submit) Remove dead code.
7586 (tab_title) Allocate string from the table's arena.
7587 (tab_output_text) Only free the buffer if we allocated it.
7588 (tab_submit) New function.
7589 (static vars t, d) New static vars.
7590 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
7591 tabi_headers, tabi_cumulate, tabi_render) New functions.
7592 (glob var tab_table_class) New global var.
7594 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
7595 encapsulate the rectangle. All references changed.
7597 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
7599 * All header files updated to use struct tags in addition to
7600 typedefs for all structures. Don't use word `struct' in struct
7603 * Makefile.am: (pspp_SOURCES) Remove html.c.
7604 (INCLUDES) Replace the lib/* includes with a single lib/ include;
7605 all references updated.
7607 * command.c: (parse_cmd) Remove call to som_check_workspace.
7608 (output_line) Update to new som.
7610 * data-in.c: (parse_numeric) A single dot is not an error; it is
7611 the system-missing value.
7613 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
7616 * data-out.c: Added `const' as appropriate to many prototypes.
7617 (convert_E, convert_F, convert_CCx) Take double argument instead
7618 of value * argument.
7619 (convert_format_to_string) Call changed functions appropriately.
7620 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
7621 make a local copy of the value.
7623 * descript.q: Remove custom_variables() prototype now provided by
7625 (custom_variables) Don't increment sbc_variables, the caller does
7627 (dump_z_table, display) Update to new som.
7629 * error.c: (vmsg) Add const to prototype. Remove code to handle
7630 `too many errors' condition.
7631 (check_error_count) New function.
7632 (msg) Add const to prototype.
7634 * filename.c: (open_file) Rewrite for elegance.
7636 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
7637 (dump_full, dump_condensed, dump_statistics) Update for new som.
7639 * list.q: Don't include somP.h. Change all references to
7640 som_driver_ext to refer to the new members of som_driver. Change
7641 som_internal_eject_page() references to outp_eject_page().
7643 * main.c: (parse) Rewrite for elegance. Add call to
7644 check_error_count().
7646 * output.c: (add_class, outp_list_classes, outp_configure_driver)
7647 Rewrite or revise for new outp_driver_class_list structure.
7648 (outp_iterate_enabled_drivers) Fix comparison between disabled
7649 devices and current device type.
7650 (outp_eject_page) New function.
7652 * output.h: Comment fixes.
7653 (struct outp_driver) New members driver_open, page_open, cp_x,
7654 cp_y, font_height, prop_em_width, fixed_width. Deleted members
7656 (struct outp_driver_class_list) New struct.
7657 (outp_class_list) Changed to type outp_driver_class_list; all
7660 * print.c: (dump_table, print_trns_proc) Updated for new som.
7662 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7663 prototypes for custom subcommands.
7664 (dump_subcommand) Always include the `else'.
7665 (dump_parser) Fix comments in output code.
7667 * set.q: Reordered functions.
7669 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7671 * som.h: Rewritten from scratch.
7673 * str.h: Remove dead code.
7675 * tab.c, tab.h: New files, base implementation.
7677 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7680 * t-test.q: New code from John Williams
7681 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7682 Many many new static vars and defines.
7683 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7684 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7685 (struct value_list) New struct.
7686 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7687 t_crt, t_sig, print_t_groups) New functions.
7688 (cmd_t_test) Implemented.
7690 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7693 * vfm.c: (dump_splits) Update to new som.
7695 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7697 * Makefile.am: (fiasco_SOURCES) Add html.c.
7699 * aggregate.c: Base source.
7701 * ascii.c: (postopen, preclose) Reformat.
7703 * data-out.c, expr-evl.c: Comment fixes.
7705 * filename.c: (open_file) When opening a file for writing, use
7706 line buffering instead of full buffering for better interactive
7707 performance. Suggested by Valerio Aimale
7708 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7709 names `stdin', `stdout', `stderr'.
7711 * groff-font.c: Comment fixes.
7713 * html.c: New file; base version.
7715 * list.q: (write_all_headers, clean_up, determine_layout,
7716 list_cases) Ignore `special' devices for now. Needs to be fixed
7719 * output.c: (outp_init) Add html driver to list; reverse list
7722 * output.h: (struct outp_class_struct) New members `special',
7723 `submit'; comment fixes. All references changed.
7725 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7726 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7728 (postopen) Comment fix.
7729 (preclose) Comment fixes, formatting fixes. Change x->file.file
7730 references to more proper f->file.
7732 * som-high.c: (som_submit_table) Special classes use their own
7735 * som.h: Comment fixes.
7737 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7740 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7742 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7744 * aggregate.c: Still working on this.
7746 * command.c: (cmd_table[]) Add AGGREGATE back in.
7747 (split_words) Make '-' a legal word separator as well as ' '.
7749 * main.c: Comment fixes.
7751 * q2c.c: (dump_parser) Don't require the procedure's full name to
7752 be present, in the generated source.
7754 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7755 multiply specified and let it be default; let MISSING, CRITERIA,
7756 FORMAT be multiply specified.
7757 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7758 (custom_groups) Fix defaults.
7759 (custom_pairs) Check whether this is a PAIRS subcommand before
7760 attempting to parse. Better garbage collection. Proper storage
7762 [DEBUGGING] (debug_print) New function.
7764 * temporary.c: Comment fixes.
7765 (copy_variable) Don't copy variable name and index.
7766 (save_dictionary) Copy variable name and index by hand.
7768 * vars-atr.c: Comment fixes.
7769 (create_variable) New dictionary argument. All references
7771 (common_init_stuff) New dictionary argument. All references
7773 (init_variable) New dictionary argument. All references changed.
7774 (dup_variable) New function.
7776 * vars-prs.c: (parse_variables) If there are any errors, we always
7777 return 0. Previously, it was possible for some types of errors to
7780 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7782 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7785 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7787 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7790 * q2c.c: Comment fixes.
7791 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7793 * t-test.q: (cmd_list) Rename cmd_t_test.
7795 * temporary.c: (new_dictionary) Don't declare as static.
7797 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7799 * aggregate.c: Changes, still not finished.
7801 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7803 * q2c.c: Comment fixes. Now its output is internationalized.
7804 (get_token) Fix parsing of escapes within literal strings.
7805 (main) Fix bad #line directives in output.
7807 * t-test.q: Base implementation.
7809 * temporary.c: (new_dictionary) New function.
7810 (restore_dictionary) [__CHECKER__] Change fill character to *
7813 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7815 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7817 * aggregate.c: Changes, still not finished.
7819 * descript.q, list.q: Comment fixes.
7821 * q2c.c: Almost completely rewritten.
7823 * t-test.q: New file, not complete.
7825 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7827 * aggregate.c: Changes, still not finished.
7829 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7832 * temporary.c: (cancel_temporary) New function.
7834 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7835 of doing it by hand.
7837 * vfm.c: (close_active_file) After restoring a TEMPORARY
7838 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7840 (SPLIT_FILE_procfunc) Comment fix.
7842 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7844 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7846 * aggregate.c: New file, not finished yet.
7848 * command.c: (cmd_table) Add AGGREGATE.
7850 * common.h: (pgm_state) Move declaration to var.h.
7852 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7854 (parse_string) Message fix.
7856 * recode.c: Comment fix.
7858 * sfm-read.c: (read_variables) Code esthetic fixes.
7859 (write_header) Default date is `Jan', not `JAN'.
7861 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7863 * sort.c: (cmd_sort_cases) Farm the work out to new function
7864 parse_sort_variables().
7865 (parse_sort_variables) New function.
7866 (sort_cases) New function. Cancels temporary transformations,
7867 which sorting didn't do previously.
7868 (cmd_sort_cases) Better garbage collection on error. Uses
7870 (write_initial_runs, merge_once) Improved code esthetics.
7871 (sort_stream_read) Reduced to one call to read_output_cases().
7872 (read_output_cases) New function.
7874 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7875 variable labels to 120 characters.
7877 * var.h: Comment fixes.
7878 (glob var pgm_state) From common.h.
7880 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7882 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7883 options. Set *names to NULL on error.
7885 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7887 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7889 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7890 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7892 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7894 * vfm.c: (page_to_disk) Added missing local variables.
7896 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7898 * get.c: Comment fix.
7900 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7901 source is anything other than a disk stream, not just if it's in a
7902 memory stream. Call page_to_disk() before external sort.
7903 (allocate_cases) Message fix.
7905 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7907 (page_to_disk) New function.
7909 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7911 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7913 * common.h: (macro strerror) Remove. From Alexandre Oliva
7914 <oliva@dcc.unicamp.br>.
7916 * get.c: (dict_delete_run) The number of variables to delete is
7917 not necessarily the number of variables that need to be shifted
7919 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7920 too many variables to be deleted.
7922 * postscript.c: Comment fix.
7924 * q2c.c: Include strerror.c. From Alexandre Oliva
7925 <oliva@dcc.unicamp.br>.
7927 * set.q: #undef ON and OFF. From Alexandre Oliva
7928 <oliva@dcc.unicamp.br>.
7930 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7931 early, otherwise errors cause a bad free().
7933 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
7934 Oliva <oliva@dcc.unicamp.br>.
7936 * temporary.c: (save_dictionary) Don't allocate memory if
7939 * vfm.c: (memory_stream_write) Message fix.
7941 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
7943 * command.c: (static var cmd_table[]) Define REPEATING DATA
7946 * common.h: Added support for broken systems that are missing
7947 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
7949 * Many source files: Replace syntax error messages via msg() with
7950 call to syntax_error().
7952 * data-list.c: (dump_fixed_table) Add support for dumping table
7953 for REPEATING DATA as well as DATA LIST FIXED.
7954 (cmd_repeating_data) Allows and requires `/' between subcommands.
7955 Does proper thing with allowing rpd.starts_end to stay 0. Allows
7956 CONTINUED specifications to be omitted. Forces CONTINUED to be
7957 specified if ID is. Calculates starts_end, cont_end from logical
7958 record length as reported by fhp. Calls dump_fixed_table() if
7959 requested. Fixed length of record copied by memcpy.
7960 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
7962 (realize_value) Returns sensible value for out-of-range variable
7964 (rpd_parse_record) New argument `ofs'. Fixed confusion between
7965 length of occurrences and length of line. Added warning for
7966 fields that exceed the line length. Fixed infinite loop.
7967 (read_one_set_of_repetitions) Numerous minor changes for more
7968 complete SPSS compliance. Message fixes.
7970 * dfm.c: (dfm_close) If the file being closed is the inline file,
7971 read all the remaining data before closing it.
7972 (dfm_get_record) Don't close the file on lossage, as either it
7973 has been closed already or it doesn't belong to us.
7975 * error.c: (puts_stdout) New function.
7976 (vmsg) Use puts_stdout instead of puts.
7978 * file-handle.q: (fh_record_width) New function.
7980 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
7983 (input_program_source_read) Made an old kluge an approved method.
7985 * lexer.c: (syntax_error) New function.
7987 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
7990 * output.c: (oupt_get_paper_size) Message fix.
7992 * q2c.c: Numerous fixes to formatting of generated code made to
7993 conform to GNU coding standards. Uses syntax_error() in generated
7994 code. Other miscellaneous generated message fixes. Added support
7995 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
7996 RAND_MAX, and/or strerror().
7998 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8000 * data-in.c: Comment fixes.
8002 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8003 (find_variable_input_spec) New function.
8004 (cmd_repeating_data) Initializes id_spec.
8005 (rpd_parse_record) Implemented.
8006 (read_one_set_of_repetitions) Returns -3 by default in order to
8007 kluge out some potential bugs.
8009 * data-out.c: Comment fixes.
8011 * file-type.c: (internal_cmd_record_type) Message fix.
8013 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8014 for handling -3 return value.
8016 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8018 * data-list.c: Comment fixes.
8019 (struct dls_var_spec) Reordered members.
8020 (read_from_data_list_fixed) Restructured.
8021 (struct repeating_data_trns) Reordered members. Renamed `starts'
8022 as `starts_beg', `ends' as `starts_end'.
8023 (cmd_repeating_data) Calculates length of repeated data if
8024 necessary and possible.
8025 (parse_num_or_var) Don't allow string variables.
8026 (realize_value) New function.
8027 (rpd_msg) New function.
8028 (rpd_parse_record) New function. Currently stubbed out.
8029 (read_one_set_of_repetitions) Implemented.
8031 * inpt-pgm.c: (input_program_source_read) Comment fix.
8033 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8035 * command.c: (cmd_end_repeat_p) Removed.
8036 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8037 (parse_cmd_name) Removed.
8039 * data-list.c: Comment fixes.
8040 (data_list_pgm) Removed `eof' member.
8041 (static var first) New var.
8042 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8043 FILE TYPE file inside FILE TYPE structures.
8044 (append_var_spec) Appends to *first, not dls.spec.
8045 (parse_fixed) Message fixes.
8046 (struct rpd_num_or_var) New.
8047 (struct repeating_data_trns) New.
8048 (static var rpd) New.
8049 (cmd_repeating_data) New function.
8050 (parse_num_or_var) New function.
8051 (parse_repeating_data) New function.
8052 (read_one_set_of_repetitions) New function.
8054 * file-type.c: (cmd_file_type) Message fixes. Always
8055 default_handle to FILE TYPE file handle.
8056 (internal_cmd_record_type) Message fixes.
8058 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8060 * repeat.c: Comment fix. Disable debugging.
8062 * temporary.c: (restore_dictionary) Sets splits to NULL and
8063 n_splits to 0 before destroying the variables because now doing
8064 this tries to remove split variables.
8066 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8067 destroying the dictionary.
8068 (clear_variable) Removes a variable from splits after destroying
8071 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8073 * cmdline.c: (set_compat) Removed.
8074 (pick_compat) Removed.
8075 (parse_command_line) Removed -c option.
8076 (pre_syntax_message) Removed -c option.
8077 (usage) Remove compatibility code.
8079 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8080 (glob var compat) Removed.
8082 * compute.c: (type_check) Fixed messages about type mismatches.
8084 * data-list.c: (cmd_data_list) Removed compatibility code.
8085 (fixed_parse_compatible) Calls convert_negative_to_dash().
8086 Fixed bug where it only set the variable in fx.spec if it created
8087 the variable itself.
8088 (dump_fmt_list) Spelling fix.
8089 (cut_field) Removed compatibility code.
8091 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8094 * expr-evl.c: (evaluate_expression) Implement LAG.
8096 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8097 (parse_neg) Calls convert_negative_to_dash().
8098 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8101 * expr.h: (struct expression_struct) Removed member max_lag.
8103 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8104 (internal_cmd_record_type) Removed special handling to produce
8105 negative numbers from dash tokens.
8107 * getline.c: (static var DO_REPEAT_level) New var.
8108 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8109 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8110 copy_with_DO_REPEAT_substitutions().
8111 (getl_read_line) Maintains value of getl_mode. Calls
8112 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8114 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8116 * getline.h: (getl_mode) New glob var.
8118 * glob.c: Comment fixes.
8119 (init_glob) Restructured. Sets set_seed.
8120 (init_compat_dependent) Removed. All references removed.
8121 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8122 (__htonl, __htons) Removed. (What were these for?)
8124 * lexer.c: (static var tbl) Dash set to class CNUM.
8125 (make_hexit) New function from data-out.c.
8126 (get_token_representation) Rewritten.
8127 (convert_negative_to_dash) New function.
8128 (lex_init_compat_dependent) Removed.
8129 (yylex) A dash is parsed as part of a number if it is followed by
8130 a digit. The ASCII representation of a number is copied to
8131 tokstr. String parsing farmed out to parse_string(). Comment
8133 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8135 (preprocess_line) Line processing depends on interactive/batch
8136 mode, not on compatibility mode. Removed PC+ compatibility code.
8138 * loop.c: (loop_3_trns_proc) Comment fix.
8140 * main.c: Remove dead code.
8141 (main) Remove call to init_compat_dependent().
8143 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8146 * print.c: (parse_string_argument) Calls
8147 convert_negative_to_dash().
8148 (fixed_parse_compatible) Calls convert_negative_to_dash().
8150 * repeat.c: (RPT_* defines) Removed.
8151 (struct rpt_numeric) Removed.
8152 (struct repeat_entry) New member type, changed `replacement' from
8154 (clean_up) Deallocation adapted to new repeat_entry.
8155 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8156 usage. Creates vars for `type' of 1.
8157 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8158 (store_numeric) Rewritten, new interface.
8159 (parse_numbers) Rewritten.
8160 (parse_strings) Rewritten.
8161 (find_DO_REPEAT_substitution) New function.
8162 (perform_DO_REPEAT_substitutions) New function.
8163 (copy_with_DO_REPEAT_substitutions) Removed.
8164 (debug_print) Rewritten.
8166 * set.q: Comment fix.
8167 (custom_results) Removed compatibility code.
8168 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8171 * sysfile-info.c: (cmd_display) Removed compatibility code.
8173 * tokens.h: Comment fixes.
8174 (token types enum) Removed `toktype' typedef name for this int
8175 type. Removed SUBST. Restructured.
8177 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8179 * vars-prs.c: Comment fix.
8181 * vfm.c: Comment fixes.
8182 (glob var n_lag) New var.
8183 (static vars lag_count, lag_head, lag_queue) New vars.
8184 (procedure) Removed argument nlag.
8185 (setup_lag) New function.
8186 (close_active_file) Discards lagging state.
8187 (lag_case) New function.
8188 (lagged_case) New function.
8189 (write_case) Lags a case if lagging.
8191 * weight.c: (cmd_weight) Removed compatibility code.
8193 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8195 * getline.h: (struct getl_script) New members loop_index, macros.
8197 * getline.c: (getl_add_file) Sets first_line field to NULL.
8198 (getl_add_DO_REPEAT_file) New function.
8199 (handle_line_buffer) When the current line's length is negative,
8200 set the filename and line number. Increment line number after
8201 reading line. Pass the line to
8202 copy_with_DO_REPEAT_substitutions() for processing.
8203 (getl_close_file) Free DO REPEAT lines before freeing the
8204 filename, and just set the filename to NULL when doing this,
8205 because otherwise the filename gets freed twice.
8207 * glob.c: (glob var queuing) Removed. All references removed.
8209 * lexer.c: Comment fixes.
8210 (get_token_representation) New function.
8212 * repeat.c: Comment fixes.
8213 (struct repeat_entry) Replaced type and v union members with a
8215 (append_record) New function.
8216 (internal_cmd_do_repeat) Started reforming it for the new
8217 repeat_entry struct. Properly records filename changes in the
8218 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8219 strncasecmp() result usage. Uses append_record() to simplify.
8220 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8223 (copy_with_DO_REPEAT_substitutions) Started coding.
8225 [DEBUGGING] (debug_print_lines) New function.
8227 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8229 * tokens.h: (macro is_id1, is_idn) New macros.
8231 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8233 * cmdline.c: (static var pre_syntax_message) Changed `win'
8234 compatibility mode to `wnd'.
8236 * data-list.c: (fixed_parse_spss) Renamed
8237 fixed_parse_compatible().
8239 * glob.c: (init_glob) Excise unused code for
8240 program_invocation_short_name.
8242 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8245 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8247 * set.q: `win' compatibility renamed `wnd'.
8249 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8251 * filename.c: [__WIN32__] Change the included Windows header files
8253 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8254 second character is absolute.
8255 (dirname) Fix logic error. Don't printf() the results.
8256 (prepend_dir) Don't printf() the results.
8258 * getline.c: (handle_line_buffer) New function.
8259 (getl_read_line) Reads line with handle_line_buffer() when
8261 (getl_close_file) Discard line buffer data.
8263 * getline.h: Comment fixes.
8264 (struct getl_line_list) New struct.
8265 (getl_script_struct) Added line buffer members. These are hooks
8266 for use by DO REPEAT to allow it to insert virtual source code
8269 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8270 Override Borland C++ stupidity that claims Windows has a console
8273 * repeat.c: This is in the process of being restructured from
8274 using a token-buffering approach to the DO REPEAT facility to
8275 using the more flexible approach of a line-buffering approach in
8276 conjunction with the getline module. Comment fixes.
8277 (struct tok_struct) Removed.
8278 (static vars queue_index, queue_head, queue) Removed.
8279 (static vars line_buf_head, line_buf_tail) New vars.
8280 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8282 (pull_queue, destroy_queue) Removed.
8283 [DEBUGGING] (debug_print_tokens) Removed.
8285 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8287 * file-handle.q: (prepend_current_directory) New function.
8288 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8289 current directory before normalizing filename.
8291 * filename.c: (gnu_getcwd) New function.
8292 (absolute_filename_p) New function.
8293 (search_path) New argument, PREPEND. All references changed to
8294 pass NULL except those explicitly mentioned. Uses
8295 absolute_filename_p(). Prepends PREPEND before trying the
8297 (dirname, prepend_dir) New functions.
8299 * getline.c: (getl_get_current_directory) New function.
8300 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8303 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8305 * In several source files, the term `script' was replaced with
8306 `syntax file' inside error messages. Usage of the term `script'
8307 in the sense of a syntax file is now deprecated.
8309 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8312 * dump-sysfile.c: (usage) Update message.
8314 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8316 * getline.h: (glob var getl_include_path) Declare extern.
8318 * list.q: Define EXTERN as extern before #including somP.h.
8320 * var.h: Remove declaration of `disptype' variable.
8322 * vfm.c: (close_active_file) After switching the data sink to a
8323 data source, set vfm_sink to NULL, because it doesn't exist any
8326 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8328 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8329 _matherrl() to ignore all math errors.
8331 * sfm-read.c: (read_value_labels) When reading the labels from
8332 disk, read the little parts separately instead of as a struct;
8333 this avoids alignment problems.
8335 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8336 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8337 (write_header) Allocates and initializes elem_type.
8338 (sfm_write_case) Uses elem_type to determine how to handle each
8340 (sfm_close) Frees elem_type.
8342 * sfmP.h: Comment fix.
8343 [__BORLANDC__] Uses #pragma -a to adjust structure member
8346 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8348 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8350 * common.c: Fix typo.
8352 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8353 sense of the condition.
8355 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8356 line-continuation backslash.
8358 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8360 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8361 non-constant expression as an argument to sizeof.
8363 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8364 undefine gettext macro because that's a conio function.
8366 * hash.h: (hsh_prime_tab declaration) Remove.
8368 * list.q: (write_fallback_headers) Move `leader' allocation out of
8369 main loop. Change to local_alloc() allocation.
8371 * output.h: Formatting fixes. Put __attribute__ in right place on
8372 function prototypes.
8374 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8375 incorrect `SECOND_LOWEST_VALUE' references to proper
8376 `second_lowest_value'.
8378 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8379 value. This way 2 out of 3 of the som files define the vars
8380 extern, the correct way, that actually works under BC++.
8381 (som_set_float) Don't use nonconstant initializers for a struct.
8383 * som-high.c: Add the standard alloca() header.
8384 (replicate_table) Add prototype.
8386 Merged DISPLAY routine.
8387 * sysfile-info.c: (AS_*) New enum series.
8388 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8390 (cmd_display, display_macros, display_documents,
8391 display_variables) Stolen from defunct display.c.
8392 (describe_variable) New function.
8394 * temporary.c: [0] (display_tree) New debug function.
8395 (copy_variable) Performs shallow copy of value labels instead of
8396 deep copy; i.e., just copys the AVL tree and increments the
8399 * val-labs.c: Comment fixes.
8400 (do_value_labels) Optionally skip leading forward slash.
8401 (get_label) Creates only a single value label instead of many
8402 copies of one, and sets the reference count.
8404 * display.c: Removed.
8406 * dump-sysfile.c: New file, not yet complete.
8408 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8410 For lots of source files I added more verbose_msg's. These aren't
8411 listed below as they have tested as being benign. In some cases
8412 these replaced debug_printf() calls.
8414 * output.c: (outp_read_devices) Message fix.
8416 * postscript.c: (output_encodings) Message fix. Reports errors on
8418 (postopen) Message fix.
8420 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8422 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8424 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8427 * main.c: Remove <malloc.h> #include.
8429 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8430 instead of trying to just set the missing[] itself, which is a
8433 * sfm-read.c: (read_variables) Same.
8435 * str.h: Add memmem() prototype.
8437 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8439 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
8441 * Makefile.am: (q2c) Don't include any libraries in the link.
8443 * dfm.c: (force_line_buffer_extension) New macro.
8444 (count_tabs) New function.
8445 (tabs_To_spaces) New function.
8446 (read_record) Calls tabs_to_spaces() on the line being processed.
8448 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
8449 have to be compiled twice (once for CC, once for LOCAL_CC).
8451 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
8453 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
8454 (LDADD) Add @INTLLIBS@.
8455 (q2c) Add LIBS, @INTLLIBS@ to link step.
8457 * inpt-pgm.c: Turn off debugging.
8459 * postscript.c: (postopen) Format fix. local_free() blocks
8460 returned by local_alloc(); don't free() them.
8462 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
8464 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
8467 * data-list.c: (read_from_data_list_fixed) Pass proper value for
8468 LEN arg, not simply the full string length.
8470 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
8471 directories before generic temp file directories.
8473 * vfm.c: Disable debugging.
8475 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
8477 * get.c: Comment fix.
8478 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
8480 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
8482 * expr-prs.c: (debug_print_postfix) Conditionally included on
8483 GLOBAL_DEBUGGING. Removed out_header() reference.
8485 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
8487 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
8489 * ascii.c: Removed obsolete ascii_close_page() prototype.
8491 * command.c: (output_line) Comment fix.
8493 * data-in.c: Formatting fix.
8494 (parse_string_as_format) Now the `fc' argument is used only for
8495 the purpose of error messages; it is not an index into the string
8496 passed. All references changed.
8498 * data-list.c: Comment fix.
8499 (cut_field) Comment fix. Now returns the column number of the
8500 position of the field cut out on success.
8501 (parse_field) Added `column' argument. Puts the column numbers in
8503 (read_from_data_list_free, read_from_data_list_list) Record the
8504 column number returned by cut_field(), pass it to parse_field().
8506 * dfm.c: Comment fix.
8508 * do-ifP.h: Comment fix.
8510 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
8511 the SYSMIS function.
8513 * expr.h, exprP.h: Comment fix.
8515 * glob.c: (init_glob) Only calls setlocale() and family if
8518 * hash.h: Comment fix.
8520 * include.c: Comment fix.
8522 * output.c: Comment fix.
8524 * postscript.c: (ps_line_intersection) Simplified assertion.
8526 * repeat.c: Comment fix.
8528 * vars-atr.c: Comment fix.
8530 * vars-prs.c: Comment fix.
8532 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
8533 behavior with usage of postincrement.
8534 (memory_stream_read) Discards cases as it goes.
8536 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
8538 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
8541 * Most source files: Includes debug-print.h, related comment
8544 * cases.c: (alloc_val) Removed complex allocation code. Merely
8545 increments default_dict.nval and returns the former value.
8546 (envector, devector) Removed references to lv member of struct
8549 * common.h: (macro VME) Replaced complex definition with simple
8552 * data-list.c: (cmd_data_list) Sets vfm_source instead of
8553 read_active_file and cancel_input_pgm.
8554 (read_from_data_list, cancel_data_list) Removed.
8555 (data_list_source_read, data_list_source_destroy_source) New
8557 (glob var data_list_source) New var.
8559 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
8560 (cmd_begin_data) Improved criteria for an input program accessing
8561 the inline file. Still not perfect.
8563 * do-if.c: (do_if_trns_proc) Simplified debug output.
8565 * expr-prs.c: Comment fixes.
8566 [DEBUGGING] (debug_print_postfix) Simplified debug output.
8568 * file-handle.q: (fh_close_handle) Simplified debug output.
8570 * file-type.c: Comment fixes.
8571 (cmd_file_type) Sets vfm_source instead of read_active_file and
8573 (cmd_end_file_type) On failure, discards variables in place of
8574 just canceling the input program.
8575 (read_from_file_type) Renamed file_type_source_read.
8576 (cancel_file_type) Renamed file_type_source_destroy_source.
8577 (glob var file_type_source) New var.
8579 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
8580 (cmd_get) Initializes options to GTSV_NONE before passing to
8581 trim_dictionary(). Removed `lv' reference. Sets vfm_source
8582 instead of read_active_file and cancel_input_pgm.
8583 (cmd_save_internal) Initializes options before passing to
8584 trim_dictionary(). Local var `nval' removed.
8585 (dict_delete_run) Comment fixes.
8586 (trim_dictionary) Comment fixes. Disallows scratch variables if
8587 GTSV_OPT_SAVE set in options.
8588 (read_from_get) Renamed get_source_read.
8589 (cancel_get) Renamed get_source_destroy_source.
8590 (glob var get_source) New var.
8592 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
8593 read_active_file and cancel_input_pgm.
8594 (read_from_input_program) Renamed input_program_source_read.
8595 Simplified debug output.
8596 (cancel_input_program) Renamed
8597 input_program_source_destroy_source.
8598 (glob var input_program_source) New var.
8600 * loop.c: (loop_1_trns_proc) Simplified debug output.
8602 * main.c: (dump_token) Made eof output more explicit.
8604 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
8607 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
8608 code for always-memory or always-disk cases. malloc's case-list
8609 based on vfm_source_info.ncases. Explicit support for
8610 memory_stream via memory_source_cases.
8611 (do_external_sort) Sets vfm_source instead of read_active_file and
8613 (allocate_file_handles) The temporary directory permissions are
8614 set to 0700 instead of 0777.
8615 (allocate_cases) Formatting fixes. Simplified debug output.
8616 (output_record) Compacts the case if necessary before writing it
8618 (close_handle, open_handle_w) Simplified debug output.
8619 (write_initial_runs) Destroys vfm_sink, then sets it to
8620 sort_stream. Writes records to memory based on
8621 vfm_sink_info.case_size.
8622 (write_to_sort_cases) Renamed sort_stream_write().
8623 (merge) Simplified error handling. Simplified debug output.
8625 (read_from_external_sort) Renamed sort_stream_read().
8626 Reads records based on vfm_source_info.case_size.
8627 (sort_stream_write) Writes records to memory based on
8628 vfm_sink_info.case_size.
8629 (sort_stream_mode) New function.
8630 (glob var sort_stream) New variable.
8632 * temporary.c: (cmd_temporary) Simplified debug output.
8633 (copy_variable) Removed references to `lv'.
8635 * title.c: (get_title) Simplified debug output.
8637 * var.h: Comment fixes.
8638 (struct get_proc) Removed member `lv'.
8639 (struct variable) Removed member `lv'. Comment fixes.
8640 (glob vars read_active_file, write_active_file, cancel_input_pgm)
8642 (struct case_stream) New.
8644 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
8645 read_active_file references to use vfm_source.
8646 (init_variable, replace_variable) Removed references to `lv'.
8648 * vfm.c: Comment fixes.
8649 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
8651 (static var queue, qh, qt, n_lag) Removed. All references
8653 (glob var compaction_necessary, compaction_nval, compaction_case,
8654 paging) New variables.
8655 (record_case) Removed.
8656 (procedure) Comment fixes. Calls vfm_source->read() instead of
8659 (prepare_for_writing, arrange_compaction, make_temp_case,
8660 vector_initialization, setup_filter) New function.
8661 (open_active_file) Most of the code moved into the abovementioned
8662 new functions. Now sets temp_dict to &default_dict if there is no
8663 temporary dictionary, for convenience. New debug output.
8664 (close_active_file) Deals with changing the sink to the source.
8665 Calls finish_compaction(). Frees compaction_case. Mostly
8667 (glob vars disk_source_file, disk_sink_file) New vars.
8668 (destroy_active_file, read_from_memory) Removed.
8669 (disk_stream_init, disk_stream_read, disk_stream_write,
8670 disk_stream_mode, disk_stream_destroy_source,
8671 disk_stream_destroy_sink) New functions.
8672 (glob var vfm_disk_stream) New var.
8673 (glob vars memory_source_cases, memory_sink_cases,
8674 memory_sink_iter, memory_sink_max_cases) New vars.
8675 (memory_stream_init, memory_stream_read, memory_stream_write,
8676 memory_stream_mode, memory_stream_destroy_source,
8677 memory_stream_destroy_sink) New functions.
8678 (glob var vfm_memory_stream) New var.
8679 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8680 named `more_cases'. Simplified debug output. Otherwise mostly
8682 (record_case) Moved into the stream drivers. Removed.
8683 (transform) Removed (was dead code).
8684 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8685 common case that the splits don't change, we don't need to copy
8686 the case into prev_case again--pointless.
8687 (compact_case) New function.
8688 (finish_compaction) New function.
8690 * vfmP.h: Comment fixes.
8691 (DEV_* enum series) Removed.
8692 (struct storage) Renamed `stream_info'. Removed variant record.
8693 Removed `device' member.
8695 * debug-print.h: New file.
8697 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8699 * autorecode.c: Turned off debugging.
8701 * data-list.c: (destroy_dls) Closes the associated file handle.
8703 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8704 parse_variables() options.
8706 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8708 * display.c: (display_variables) Really fixed null cell bug.
8710 * file-handle.q: (fh_close_handle) Changed debugging message.
8712 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8713 parse_variables() options.
8715 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8716 (cmd_list) Fails if no variables specified.
8717 (determine_layout) Writes blank lines manually.
8719 * loop.c: (loop_1_trns_proc) Made debugging code only print
8720 messages if debugging.
8722 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8723 parse_variables() arguments.
8724 (main) Parses optional parenthesized options to varlist
8725 subcommands into sbc->message.
8727 * sfm-read.c: Format fix.
8729 * var.h: (FV_*) New enum series.
8730 (PV_*) New enum PV_NO_SCRATCH.
8732 * vars-prs.c: (find_var) Removed.
8733 (fill_all_vars) Takes FV_* enum instead of boolean third
8734 argument. Rewritten to deal with scratch as well as system
8736 (parse_variables) Error message on scratch variable if
8739 * vfm.c: (static var virt_begin_func) New var.
8740 (procedure) Sets up virt_begin_func.
8741 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8742 after dump_splits(). For succeeding groups changes, calls
8743 virt_begin_func() instead of begin_func().
8745 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8747 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8750 * dfm.c: Added some debugging messages, disabled by default.
8751 (open_file_r) Fixed error message.
8752 (read_record) On eof on inline_file, instead of calling
8753 fh_close_handle(), simply jump to eof label like a normal file.
8756 * display.c: Thin lines between rows for certain kinds of
8757 listing. Fixed `null cell' bug.
8759 * error.c: (failure) Flush stdout, stderr before failing.
8761 * file-handle.q: (fh_close_handle) Added debugging message.
8763 * frequencies.q: (dump_full) Bottom line extends across entire
8764 table width. Changed title formatting.
8765 (dump_condensed) Changed title formatting.
8766 (dump_statistics) Fixed title formatting.
8768 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8769 Sets default value of set_format.
8771 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8772 Passes write_all_headers() to procedure() as pre-group func.
8773 (write_all_headers) New function.
8774 (determine_layout) Removed calls to write_header().
8775 Calls blank_line() before and after write_fallback_headers().
8777 * recode.c: (recode_trns_free) Only attempts to free head->map if
8780 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8781 file variable names but gives a warning. Sets `left' based on
8782 first character being/not being `#'. On lossage frees dict->var.
8784 * som-high.c: (som_draw_title) Simplified title formatting.
8786 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8788 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8790 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8791 beginning. Frees v_src, v_dest on successful exit. Frees
8792 h_trans[*], h_trans on lossage.
8793 (recode) Frees h_trans[*], h_trans.
8795 * dfm.c: (dfm_close) Formatting change.
8796 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8797 longer allocates its own in inline_file.
8798 (open_file_r) Passes the local dfm_fhuser_ext to
8800 (open_file_w) Message fix.
8801 (read_record) Buffer reallocation strategy changed. Frees
8802 ext->line even in inline_file to prevent leaks.
8803 (dfm_put_record) Fixed bug where `ext' was cached before the file
8804 was opened and thus it would be NULL when the file really was
8806 (cmd_begin_data) Sets up inline_file basics itself, then calls
8807 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8809 * list.q: (write_line) Formatting fix.
8810 (clean_up) Minor strategy change. Sets proportional font after
8812 (determine_layout) Sets fixed font before writing regular headers,
8813 or after writing fallback headers.
8815 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8816 and KEEP vars after using them.
8818 * postscript.c: (ps_init_driver) Frees x->family.
8819 (postopen) When loading fonts, free the temporary font name buffer
8821 (ps_text_set_font_by_position) Free temporary font name buffer
8823 (text) Fixed code that calculated `lig' so that `lig' always gets
8824 initialized. Formatting fix.
8826 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8828 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8829 cells, not xmalloc(), so that the cells will get destroyed
8832 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8835 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8837 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8840 * dfm.c: Comment fix.
8842 * list.q: Comment fixes. Include somP.h. Removed static vars
8843 table, n_columns, n_rows, part. New struct list_ext. New static
8845 (n_lines_remaining, n_chars_width, write_line) New functions.
8846 (cmd_list, list_cases) Rewritten.
8847 (begin_row, end_row, flush_table) Removed.
8848 (write_header, clean_up, write_varname, write_fallback_headers,
8849 determine_layout) New functions.
8851 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8853 * output.h: Comment fix.
8855 * postscript.c: Comment fix.
8856 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8857 added font_size. All references changed.
8858 (ps_init_driver) Initializes font_size. Simplified space checking
8860 (static var option_tab[]) Removed prop-size, fixed-size; added
8862 (ps_option) Handles font_size.
8864 * som-high.c: Moved prototypes into somP.h.
8865 (som_init_driver) New function.
8866 (som_submit_table) Moved some code into new function
8868 (build_target) Moved some code into new function
8869 som_internal_eject_page().
8870 (som_eject_page) Uses som_internal_eject_page().
8871 (som_internal_eject_page) New function.
8873 * som-low.c: Moved prototypes into somP.h.
8875 * som.h: Formatting fixes.
8877 * somP.h: (struct som_driver_ext) Removed em_width;
8878 added prop_em_width, fixed_width.
8880 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8882 * Makefile.am: Added `localedir' definition. Added
8883 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8885 * ascii.c: (macro draw_line) Fixed capitalization.
8887 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8888 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8889 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8890 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8891 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8892 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8893 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8894 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8895 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8896 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8897 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8898 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8899 for internationlization.
8901 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8903 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8905 * do-if.c, sort.c, val-labs.c: Comment fixes.
8907 * glob.c: (init_glob) Uncommented, updated i18n support.
8909 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8910 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8911 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8912 the declarations of macros taking arguments a lot nicer.
8914 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8916 * error.h: Removed CE, CW aliases for SE, SW.
8918 * q2c.c: Removed explicit streq() definition since it's duplicated
8921 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8922 stats.h, str.h, tokens.h: Made the declarations of macros taking
8923 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8926 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8928 * cmdline.c: Comment fixes.
8929 (pick_compat) Changed return type to int. Now, instead of setting
8930 glob var `compat' to the emulation, returns the emulation. All
8932 (parse_command_line) Added terminating null to end of
8933 `long_options' array definition.
8934 (pre_syntax_message) Fixes.
8935 (usage) Shows the default emulation in the syntax message by
8936 calling pick_compat().
8938 * getline.c: (getl_add_include_dir) Separates paths with
8939 PATH_DELIMITER, not DIR_SEPARATOR.
8941 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
8942 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
8944 * output.c: (outp_configure_macro) Make earlier definitions for a
8945 particular key override later ones for the same key.
8947 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
8949 * ascii.c: Comment fixes.
8951 * output.c: (outp_get_paper_size)
8952 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
8954 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
8956 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
8957 <errno.h>. GNU libc 2 enforces this!
8959 * command.c: (parse_cmd) Fixed problem with `else' clause being
8960 paired with wrong `if'. Comment fix.
8962 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
8964 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
8965 blp_getline() to getline().
8967 * output.c: (outp_eval_dimension) Changed the fix from last time;
8968 there was no variable `a'.
8970 * q2c.c: (get_line) Fixed boundary condition overrun bug.
8972 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
8974 * output.c: (outp_evaluate_dimension) Fixed handling of negative
8975 numbers having fractional parts. Added case of a fraction without
8976 a whole-number part.
8978 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
8980 * ascii.c: (ascii_text_get_font_position) Removed.
8982 * expr.h, exprP.h: Disabled debugging.
8984 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
8987 * output.h: (struct outp_class_struct) Removed
8988 text_get_font_position method. All references deleted.
8990 * postscript.c: Big change here. Fontmaps were completely
8991 eliminated because of a change in philosophy. Comment fixes.
8992 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
8994 (struct ps_driver_ext) `position', `fontmap', `prop_name',
8995 `fixed_name' members removed. New members `prop_family',
8996 `fixed_family'. `family' member changed to type char *.
8997 (static var ps_fontmaps) Removed.
8999 (ps_init_driver) Removed obsolete references, updated.
9000 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9001 fontmap, of course. Refers to font names through internal_name
9002 rather than subversive means. Frees proper items.
9003 (static var option_tab[]) Removed `fontmap-file' option; renamed
9004 `fixed-font', `prop-font'.
9005 (ps_option) Corresponds to option_tab[].
9006 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9007 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9008 hash_family) Removed.
9009 (postopen) Generates font names from family names. Gets
9010 PostScript font name properly. New prologue file comment `!!!'
9012 (ps_open_page) Adds translate_x, translate_y to BP prologue
9013 function; gives SF argument floating-point format.
9014 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9015 font name. Doesn't change font family.
9016 (ps_text_set_font_by_position) Generates Groff font name from font
9017 family name instead of through table lookup.
9018 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9019 all references changed. Reduced to simple string assignment.
9020 (ps_get_font_name) Removed.
9021 (ps_get_font_family) Reduced to string return.
9022 (text) Doesn't save `position' since it no longer exists. Ugly
9023 kluge to save font family--fix soon?
9024 (load_font) Removed PostScript name argument.
9026 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9028 * postscript.c: Comment fix.
9029 (ps_open_page) Puts scale factor in PostScript output.
9031 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9033 * Makefile.am: Distcleans q2c.
9035 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9037 * ascii.c: (delineate) Sets text size even if width is zero.
9039 * command.c: Comment fix.
9040 (static var cmd_table[]) Re-enabled EVALUATE command.
9041 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9042 of comments in script files. Now more liberal on criteria for
9043 performing a state transition--if *anything* happened correctly,
9044 not just if *everything* happened correctly.
9046 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9047 Checker segfault on formatting large numbers and why in the fsck
9048 hadn't I noticed this before?
9050 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9052 * list.q: (cmd_list) Commented out the actual output routine
9053 because of various problems. Probably will abandon the idea of
9054 using the general `crushed tables' for the LIST procedure.
9056 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9057 clearing it. Allocates a new var_by_name dictionary before trying
9058 to add members to it.
9060 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9061 `sib'. Changed type of `node' argument.
9062 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9064 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9065 [DEBUGGING] Only deletes the variable from var_by_name if that var
9068 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9070 * Makefile.am: Added include files to SOURCES. Added
9071 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9072 includes rules for q2c. Added `boast' target.
9074 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9076 * Makefile.am: Maintainer-clean Makefile.in.
9078 * Makefile.am: Fixed redundant EXTRA_DIST line.
9080 * ascii.c: Comment fixes.
9081 (ascii_line_vert) Fixed overly aggressive range check.
9083 * display.c: Removed dead code.
9085 * list.q: Turn debugging on.
9086 (flush_table) New debug code.
9088 * sfm-read.c: (read_value_labels) malloc's the structure before
9089 trying to assign to its members.
9091 * sfm-write.c: Comment fix.
9093 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9095 (output_table) No arguments anymore--gets them through `som'
9096 global. New debug code. In crushed tables, now sets `htv' as
9097 well as `hv' to avoid bad confusion later.
9098 (dump_crush_page) New debug code.
9100 * som-low.c: (som_dump_crush_page) New debug code.
9102 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9104 All source files: Broke long lines into multiple lines.
9106 * ascii.c: (ascii_close_page) Uses host_system var in place of
9107 HOST_SYSTEM constant.
9109 * cmdline.c: (var syntax_message[]) Broke into
9110 pre_syntax_message[] and post_syntax_message[].
9111 (usage) Outputs both parts, separated by driver list.
9113 * error.h: Fixed broken formatting.
9115 * expr-opt.c: (str_search, str_rsearch) New functions.
9117 * misc.c: (blp_getdelim) Removed. All references changed to
9119 (str_search, str_rsearch) Removed.
9120 (memrmem) New function.
9122 * misc.h: (blp_getline) Removed. All reference changed to
9127 * filename.c: Includes "stat.h", not <sys/stat.h>.
9128 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9130 * output.c: (outp_list_classes) Changed output formatting.
9132 * sfm-write.c: (write_header) Uses host_system var instead of
9133 HOST_SYSTEM constant.
9134 (write_rec_7_34) Extracts version numbers from the version string.
9137 * sort.c: Includes "stat.h", not <sys/stat.h>.
9139 * str.c: (strcasecmp) Removed.
9141 * title.c: (cmd_document) Uses host_system var instead of
9142 HOST_SYSTEM constant.
9144 * version.c: Generated on-the-fly by the Makefile instead of being
9147 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9149 [!HAVE_STRNCASECMP] Declares strncasecmp().
9151 * version.h: Removed stray character. Comment fixes.
9152 (vars host_system, build_system) New vars.
9154 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9156 * Most source files: Changed formatting of copyright notice; fixed
9157 FSF address; reformatted to better conform to GNU standards;
9158 comment fixes. Added markups to prevent GNU indent from messing
9159 up my beautiful formatting :-).
9161 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9162 that GNU indent markups can be passed through without problems.
9164 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9166 * get.c: Turned off debugging.
9168 * glob.c: (init_glob) Turned on save-file compression by default.
9170 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9171 compression than was possible in save files.
9173 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9175 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9177 * frequencies.q: Removed Fiasco extensions. Updated calculation
9178 algorithms. Polished output format.
9179 (struct frq_info_struct) Removed members `max_degree', `min_n',
9180 all references removed.
9181 (macro frq_extensions) Removed.
9182 (static vars min_n, max_degree) Removed, all references removed.
9183 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9184 calculate `min_n', `max_degree'.
9185 (postcalc) Passes new arg to dump_statistics().
9186 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9188 (dump_condensed) Adds variable name title.
9189 (sum_freqs) Removed.
9190 (calc_stats) Updated calculation algorithm.
9191 (dump_statistics) Removed warning for too-few observations.
9192 Changed table formatting. Adds variable name title if passed new
9195 * output.h: Comment fix.
9197 * recode.c, sample.c, sort.c: Disabled debug code.
9199 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9200 Improved debug code.
9202 * var.h: (enum series frq_*) Removed Fiasco extensions.
9204 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9206 * command.c: Added PROCESS IF to command table.
9208 * Lots & lots of places, removed checks for NULLs preceding calls
9209 to free_expression(), which itself checks.
9211 * descript.q: Removed Fiasco extensions. Removed optimizations
9212 for non-weighted active files. Implemented some options.
9213 Finished polishing output format. Comment fixes. Merged
9215 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9216 max_degree, min_n) Removed.
9217 (macro dsc_extensions) Removed.
9218 (struct dsc_info_struct) Removed `min_n' member, all references
9220 (internal_cmd_descriptives) Removed calculation of min_n,
9221 max_degree. Only deals with one `calc' routine instead of two
9223 (precalc) Eliminated redundancy. Updated for changes to
9224 descriptives_proc structure.
9225 (calc) Moved here from `descript.g'. Rewritten to calculate
9226 statistics via `moments about the mean' rather than by summing,
9227 summing squares, summing cubes, and so on.
9228 (postcalc) Rewritten for new-style statistical calculation.
9229 (display) Removed support for displaying variables across rows.
9230 No longer crushes the descriptives table. Removed ancient code.
9231 Added display of N, by variable and listwise.
9233 * descript.g: Removed; merged into `descript.q'.
9235 * expr-evl.c: (evaluate_expression) Now returns a double. For
9236 numeric results, it returns the result as well as storing it in
9237 the passed `value' structure if non-NULL. For string results it
9238 just returns 0.0 and it must be passed non-NULL. Many references
9239 to this function were optimized by use of this change, especially
9240 but not exclusively in `compute.c'.
9242 * frequencies.g: Comment fix.
9244 * glob.c: (glob var process_if_expr) New global var.
9246 * postscript.c: (static var option_tab[]) Corrected entry for
9248 (postopen) Sets x->size to x->prop_size.
9249 (ps_text_set_font_by_name) Sets font size as well as typeface for
9250 PROP and FIXED fonts.
9252 * sel-if.c: (cmd_process_if) New function.
9254 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9255 (sfm_write_dictionary) Sets `n_cases' to 0.
9256 (sfm_write_case) Increments `n_cases'.
9257 (sfm_close) Attempts to seek the system file back to the header
9258 and write the number of cases in its proper slot.
9260 * som-frnt.c: (som_insert_table) Masks off expansion options since
9261 only SOPT_X_NORM seems to work sensibly.
9263 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9264 with a `fixed' value of 2.
9266 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9268 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9269 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9271 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9272 (struct descriptives_proc) Removed `miss_noweight'; new members
9273 `X_bar', `M2', `M3', `M4', `min', `max'.
9275 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9277 * vfm.c: (close_active_file) Cancels PROCESS IF.
9278 (write_case) Doesn't process cases unselected by PROCESS IF.
9280 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9282 * glob.c: (glob var err) Removed.
9284 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9285 doesn't have to take into account number of value labels since
9286 they're in a subtable anyway. Also, doesn't display more than 10
9287 value labels since we can't yet break pages in subtables.
9289 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9291 * som-frnt.c: (som_change_table_size) Simple change for elegance
9292 that shouldn't change behavior.
9293 (som_set_value) Comment fix.
9295 * som-high.c: (som_submit_table) Message fix.
9297 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9299 * command.c: Added SYSFILE INFO to command table.
9301 * file-handle.q: (fh_handle_filename) New function.
9303 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9306 * main.c: (parse) New return value for command functions, -3.
9308 * misc.h: Comment fix.
9310 * output.h: Comment fixes.
9311 (macro COMPONENTS) Removed.
9313 * postscript.c: (write_text) Modified literal_chars[] so that `('
9314 and ')' are not written to the output in strings as literals.
9316 * sfm-read.c: (sfm_read_dictionary) New argument.
9317 (read_header) New argument. Sets the information structure's
9318 values from the header information.
9319 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9320 bizarre Checker problem, I guess.
9321 (read_variables) Proper cleanup on lossage.
9323 * sfm.h: (struct sfm_read_info) New struct for use by
9324 sfm_read_dictionary().
9326 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9327 currently used just for tables that can be dynamically resized and
9328 thus have to be allocated with arena_malloc() instead of
9329 arena_alloc(). All references changed.
9330 (som_change_table_size) New function.
9331 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9333 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9334 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9337 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9339 (draw_intersection) Now takes an argument specifying the table in
9340 question. All references changed.
9341 (draw_table_cell) New function.
9342 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9343 (som_get_table_size) Many nice new explanatory comments.
9344 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9346 * som.h: New enum series SOM_CREATE_* for use as create flags with
9349 * str.h: Moved a comment here from TODO.
9351 * sysfile-info.c: New file. Reference implementation.
9353 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9355 * command.c: Added RENAME VARIABLES to table of commands.
9357 * data-in.c: (dls_error) Sets `cust_field'.
9358 (parse_N) Message fix.
9359 (parse_day_count) New function.
9360 (to_roman) Never outputs VX as a `short form' of V.
9361 (parse_month) Fixed parsing of Roman numerals.
9362 (parse_trailer) Message fix.
9363 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9364 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9365 the date is invalid.
9366 (parse_SDATE) Fixed swapped day, year.
9367 (parse_JDATE) Fixed bug for dates in 1582.
9368 (parse_DTIME) Allows days not between 1 and 31.
9369 (parse_numeric) Makes local copy of f.type for easier usage.
9372 * data-out.c: (convert_F) When outputting as scientific, properly
9373 sets f.type as fp->type.
9374 (insert_commas) Fixed operator precedence problem with setting of
9375 nitems. Changed strcpy to memcpy (no null terminator).
9376 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9377 (convert_CCx) Essentially rewritten, but now it works.
9379 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9381 (display_documents) Implemented.
9383 * error.c: (glob var cust_field) New var.
9384 (vmsg) Displays cust_field as part of message classes DE and DW.
9386 * formats.c: (debug_print) Fixed to compile under updated
9389 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9392 * misc.c: (parse_format_specifier) Formatting fix.
9394 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9395 `n_rename' for clarity.
9396 (cmd_modify_vars) Initializes `forward' and `positional' at
9397 appropriate times. Frees lists of vars to rename on failure.
9398 Comment fix. Frees memory on success.
9399 (rearrange_dict) Simplified `for' loop condition.
9401 * rename-vars.c: New file (reference implementation).
9403 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9405 * sfm-read.c: (read_header) File label is created only if file
9406 label in file is not blank.
9407 (read_variables) Initializes `dict' local variable.
9408 (read_documents) Proper behavior on lossage.
9410 * sfm-write.c: (write_header) Doesn't blank out the file label
9411 (why was this here to begin with?!)
9413 * temporary.c: (save_dictionary) File label is copied only if
9414 non-NULL. Doesn't try to xstrdup() dictionary documents.
9415 Adapted so as to not irritate Checker.
9416 (free_dictionary) Only destroys var_by_name if non-NULL.
9418 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9419 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9420 lines to the document, indents the document. Also, it works now.
9421 (add_document_line) New function.
9423 * var.h: (struct dictionary) Reordering.
9425 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9426 bits if it was allocated to begin with.
9428 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9430 * command.c: Added MODIFY VARS to list of commands.
9432 * configure.in: Updated custom macros for autoconf 2.12. Removed
9433 mmap reference; fixed termcap library reference.
9435 * display.c: (display_variables) Fixed a few bugs although it's
9436 still not well written.
9438 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9439 (induce_segfault) Calls chkr_disp_call_chain() instead of
9440 inducing an actual SIGSEGV.
9442 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
9443 str_search() and str_rsearch(). Fixed tests for matches on
9444 OP_INDEX and OP_RINDEX.
9446 * filename.c: (good_getcwd) Removed as the new libc for Checker
9447 doesn't contain this bug, apparently.
9449 * misc.c: (str_search, str_rsearch) Changed order of arguments for
9450 consistency with GNU memmem.
9451 (blp_getdelim) Changed `len' from `int' to `size_t'.
9453 * modify-vars.c: Reference implementation.
9455 * som-frnt.c: (zero_length) New global var.
9456 (som_create_table) Message fix.
9458 * som.h: Added gcc attributions to som_set_text(),
9459 som_output_text() prototypes. blank_line() refers to
9460 zero_length[] instead of a literal null string to suppress gcc
9463 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
9464 (allocate_cases) Decrements x_max so the last element of x[] can
9465 be used by the algorithm.
9467 * var.h: Changed minor details of `variable' declaration.
9468 (struct modify_vars_proc) New struct.
9469 (struct variable) Added field p.mfv.
9471 * vars-atr.c: Comment fix.
9473 * vars-prs.c: (fill_all_vars) More optimal implementation.
9475 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
9476 character, which it shouldn't have to do but printf() seems to
9477 read the null byte even though I supply a maximum length...
9479 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
9481 * command.c: Removed command alias X for QUIT.
9482 (parse_cmd) Fixed comment parsing.
9484 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
9486 (read_record) Fixed references to len, size.
9487 (dfm_get_record) Restructured.
9489 * file-handle.h: (struct file_handle) Field `lrecl' now of type
9492 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
9495 * modify-vars.c: New file. Not complete.
9497 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
9500 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
9501 problems caused by int/size_t differences.
9503 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
9506 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
9507 being compared were of equal length.
9509 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
9511 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
9513 * lexer.c: (get_dotted_rest_of_line) New function.
9515 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
9518 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
9519 type 6 records. Frees the dictionary properly.
9520 (read_header) Initializes the dictionary instead of letting
9521 read_variables() do it. Sets the dictionary file label from the
9523 (read_documents) New function.
9525 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
9526 write type 6 record if appropriate.
9527 (write_header) Writes file label from dictionary.
9528 (write_documents) New function.
9530 * temporary.c: (save_dictionary, restore_dictionary,
9531 free_dictionary) Properly handle new fields in dictionary struct.
9533 * title.c: (get_title) Returns after failure().
9534 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
9535 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
9537 * var.h: (struct dictionary) New fields `label', `n_documents',
9540 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
9542 * command.c: Added FILTER to list of commands.
9544 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
9547 * get.c: (cmd_save_internal) Removed weighting code since it's now
9548 handled by sfm-write.c. Properly commented out debug code.
9550 * glob.c: (glob var weighting) Removed.
9552 * sel-if.c: Comment fixes.
9553 (cmd_filter) New function.
9555 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
9556 (sfm_read_dictionary) Sets weighting variable direct in the
9557 created dictionary now. (Apparently we previously didn't support
9559 (read_header) Sets weight_index field in sfm_fhuser_ext from
9560 header read from disk.
9562 * sfm-write.c: (sfm_write_dictionary) Comment fix.
9563 (write_header) Now sets the weighting in the header from the
9564 passed primary dictionary instead of from the sfm_write_info.
9566 * sfm.h: (struct sfm_write_info) Removed field `weight'.
9568 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
9569 broke on boundary conditions.
9571 * var.h: (struct dictionary) New fields `weight_var',
9572 `weight_index', and `filter_var'.
9573 (glob var weighting) Removed. This is now part of struct
9574 dictionary. All references changed; the less mechanical changes
9575 are described above.
9577 * vars-atr.c: (find_dict_variable) New function.
9579 * vfm.c: (static var filter_index) New variable.
9580 (open_active_file) Initializes filter_index from default_dict.
9581 (write_case) Calls proc_func() only if the filter variable is
9582 nonzero; this implements FILTER behavior.
9584 * weight.c: (static var weight_varname) Removed.
9585 (cmd_weight) Modified default_dict instead of glob vars.
9586 (update_weighting) Changed the signature to modify a dictionary
9587 instead of glob vars. Now returns the weighting variable.
9588 (get_weighting_variable) Removed; its function is absorbed by
9590 (stop_weighting) Operates on a dictionary now.
9592 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
9594 * sort.c: Removed debugging info from messages.
9595 (do_external_sort) Cleans up after itself by deleting the
9596 temporary directory on failure. (On success it is deleted by the
9598 (allocate_cases) Removed debug code. Added clean up code.
9599 (output_record) Removed debug code.
9600 (merge) Added code to close all the input files that are currently
9601 open. This is a likely location for bugs, because I'm not sure
9602 about boundary conditions. Removed an unnecesary heap_delete().
9603 (merge_once) Removed input file "optimization" that in fact
9604 screwed up the rest of the code. Message and comment fixes.
9606 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
9608 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
9610 * heap.c: (heap_delete) New argument.
9612 * sort.c: Finished implementation of external sort.
9614 * vfm.c: (read_from_disk) Returns after a disk error.
9616 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
9618 * sort.c: (static var state) Removed.
9619 (static vars max_handles, tmp_basename, tmp_extname,
9620 huffman_queue) New variables.
9621 (do_external_sort) Moved most code to new functions.
9622 Creates huffman_queue.
9623 (allocate_file_handles, allocate_cases) New functions.
9624 (static vars run_no, run_length, file_index, case_count) New
9626 (output_record) Returns success. Now really writes to the output
9628 (begin_run, end_run) New functions.
9629 (write_initial_runs) Returns success. Initializes run_no to -1.
9630 Calls begin_run(), end_run() at appropriate times. Outputs debug
9632 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
9634 (merge) New function.
9636 * heap.c, heap.h: New files. Hopefully in near-final form.
9638 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
9640 * glob.c: Added write_active_file to global vars.
9642 * sort.c: Several new miscellaneous static variables.
9643 (cmd_sort_cases) Big comment fix.
9644 (perform_case_2) Renamed `do_external_sort' and completely
9646 (case_2_proc_func) Removed.
9647 (output_record, write_initial_runs, write_to_sort_cases,
9648 compare_record) New functions.
9650 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
9652 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
9654 * sort.c: (perform_case_2) Changed the method for allocation of
9655 lots of memory--now allocates one case at a time in hopes that
9656 more cases can be allocated with heavily fragmented memory.
9658 * var.h: (write_active_file) New global var.
9660 * vfm.c: (procedure, close_active_file, write_case,
9661 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
9662 arguments to procedure() to be NULL. All references to
9663 procedure() that made use of dummy functions were changed to NULL
9665 (open_active_file) If write_active_file is non-NULL, the output
9666 device becomes DEV_PGM (a new enum).
9667 (close_active_file) Sets write_active_file to NULL.
9668 (read_from_memory) Comment fix.
9669 (record_case) Calls write_active_file() when the output device is
9672 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9676 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9677 Fixed checking for duplicate varnames.
9678 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9680 (autorecode_trns_free) Destroys hash tables for each recoding
9682 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9684 * command.c: Added SORT CASES to cmd_table.
9685 (null_func, null_int_func) Prototyped.
9687 * descript.g: (calc_weight, calc_noweight) Computes own case
9690 * frequencies.q: (dump_statistics) Fixed problem with
9691 too-few-cases warning message.
9693 * get.c: (cmd_save_internal) Handles weighting properly.
9695 * hash.c: (hsh_dump) Output format changed.
9696 (force_hsh_insert) Actually works now, prototype changed.
9698 * list.q: (static var case_num) New variable.
9699 (cmd_list) Initializes case_num.
9700 (list_cases) Increments case_num.
9702 * var.h: Added definitions for SORT CASES. Comment fixes.
9704 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9705 fixes. `active' renamed vfm_active, `rep' renamed
9706 vfm_replacement, all references changed.
9707 (procedure) The procfunc no longer receives a case number. All
9709 (write_case) Subtle reordering.
9710 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9713 * weight.c: (get_weighting_variable) New function.
9715 * vfmP.h: New file with definitions from vfm.c.
9717 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9719 * command.c: (FILE_TYPE_okay) Commented out some tests because
9720 they're clumsy and not yet needed.
9722 * var.h: Most *_trns structures moved to their respective source
9723 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9724 (union any_trns) Changed to a typedef for trns_header.
9725 (struct input_program_pgm) Removed.
9727 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9728 was allocated in the first place.
9730 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9732 * autorecode.c: New file.
9734 * command.c: Added AUTORECODE to command table; re-enabled SET.
9736 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9738 * error.c: (vmsg) Comment fixes.
9740 * hash.c: Comment fix.
9741 (hashpjw_d) New function.
9742 (hashpjw) Reimplemented as call to more general function
9744 (internal_comparison_fn) Initializes pointers properly.
9745 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9746 (force_hsh_insert, force_hsh_find) New debugging wrapper
9749 * main.c: (main) Message fix.
9751 * output.c: (outp_read_devices) Message fix.
9753 * set.q: Comment fixes.
9754 (custom_results) Implemented Wnd/X form of subcommand.
9755 (set_routing) New function.
9756 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9758 * settings.h: (SET_ROUTE_*) New enum series.
9759 (set_results) Renamed set_results_file, all references changed.
9760 (set_messages) Removed.
9761 (glob vars set_errors, set_messages, set_results) New vars.
9763 * title.c: (get_title) Remembers to xstrdup() the result of
9766 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9768 (union any_trns) New element `arc'.
9770 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9772 * command.c: (output_line) Removed references to set_screen.
9774 * error.c: (static var terminating) New var.
9775 (hcf) Sets terminating to 1.
9776 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9777 This prevents an infinite loop if an error occurs within hcf().
9779 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9780 statement circumlocution with `case 42000' trick.
9781 (evaluate_expression) New support for OP_STR_MIS.
9783 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9784 statement circumlocution with `case 42000' trick.
9785 (dump_node) Handles OP_STR_MIS.
9787 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9788 variables exceptions.
9789 (parse_function) Message fix.
9790 (ops[]) Added OP_STR_MIS.
9792 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9794 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9796 * glob.c: Removed set_scrnfile glob var.
9797 (init_glob) set_errorbreak set to 0 by default.
9799 * groff-font.c: Changed included files.
9800 (groff_read_font) Initializes font_arena local var correctly.
9801 (default_font) New function.
9803 * output.c: Comment fixes.
9804 (glob var disabled_devices) New variable.
9805 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9807 [GLOBAL_DEBUGGING] (reentrancy) New function.
9808 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9809 outp_iterate_enabled_drivers) Calls to reentrancy().
9810 (destroy_list) New function.
9811 (outp_done) Moved code to destroy_list().
9812 (parse_options) Parses `listing', `screen', `printer' options
9814 (configure_driver) Sets new `device' member of driver.
9815 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9817 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9818 (struct outp_driver_struct) New member `device'.
9820 * postscript.c: (find_encoding_file) Doesn't display its own error
9822 (default_encoding) New function.
9823 (switch_font) Calls default_encoding() if no encoding can be
9825 (text) Makes up a character metric if none exists for the desired
9827 (load_font) Properly copies a fallback filename. Calls
9828 default_font() for a font if none at all are known.
9830 * set.q: Comment fixes. Removed OUTPUT subcommand.
9831 (custom_listing) Calls outp_enable_device() to enable/disable
9833 (turn_screen_on) Removed.
9834 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9835 screen, printer devices.
9837 * settings.h: Comment fixes.
9838 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9841 * som-high.c: (som_submit_table, som_eject_page) Use
9842 outp_iterate_enabled_drivers() instead of iterating
9843 outp_driver_list directly.
9845 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9847 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9848 (parse_string_as_format) Handles new formats.
9849 (parse_numeric) Now handles DOT and PCT formats.
9851 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9853 (convert_date) Handle EDATE and SDATE formats.
9854 (convert_CCx) Now if there's not room for the currency characters,
9855 converts it as F format if it's positive instead of giving up
9856 quickly. Also fixed save-and-restore bug with decimal point
9858 (convert_format_to_string) Handles new formats.
9860 * misc.c: (formats[]) Added new formats.
9861 (convert_fmt_ItoO) Supports new formats.
9863 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9864 data checking. New argument, all references changed.
9866 * sfm-write.c: (write_format_spec) Supports new formats.
9868 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9871 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9873 * cmdline.c: Comment fixes.
9874 (parse_command_line) Changed return type to void.
9876 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9878 (parse_numeric) Handles international numbers (comma as decimal
9879 point). Some reformatting.
9881 * data-list.c: (parse_free) Default output format is now
9882 set_format instead of hard-coded F8.2.
9883 (read_from_data_list_list) Emits error message on undefined data
9884 only if set_undefined is nonzero.
9886 * data-out.c: (convert_E) Changes decimal point from period to
9887 comma if appropriate. Restructured. Better comments.
9888 (convert_F) Changes decimal point from period to comma if
9890 (insert_commas) Major bug with handling of negative values fixed.
9891 Also, inserts periods instead of commas if appropriate.
9892 (convert_CCx) New function.
9893 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9894 (num_to_string) Changed `.' to set_decimal.
9896 * dfm.c: Comment fixes.
9897 (dfm_close) Frees ext->line even in inline_file.
9898 (open_inline_file) New function.
9899 (open_file_r) When opening the inline file: now properly
9900 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9902 (read_record) Calls fh_close_handle() instead of dfm_close() to
9903 close the inline file. Makes a copy of the line getl_buf to avoid
9905 (dfm_get_record) Restructured. Now checks the return value of
9907 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9908 checking for use of inline file. No longer tries to close inline
9911 * error.c: (glob var error_already_flagged) New var.
9912 (vmsg) Message change. Now checks max number of errors/warnings,
9915 * file-handle.q: (fh_handle_name) Now allows closing of
9917 (fh_init_files) Reformatted.
9919 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9921 * getline.c: (getl_include) Fixed bug that popped up when called
9922 when file queue was empty.
9923 (read_console) Resets error_count, warning_count,
9924 error_already_flagged to zero.
9926 * glob.c: Many changes to update list of variables.
9927 (init_compat_dependent) Now this function is called whenever
9928 `compat' changes. It now sets set_seed only if it hasn't
9929 previously been referenced. It now calls
9930 lex_init_compat_dependent().
9932 * include.c: (cmd_include_at) Frees temporary buffer instead of
9934 (cmd_include) Doesn't make copy of include file name.
9936 * lexer.c: Comment fixes.
9937 (init_lex) Moved some code into new function
9938 lex_init_compat_dependent().
9939 (lex_init_compat_dependent) New function.
9940 (hex_val) Simplified.
9941 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
9943 * main.c: Comment fixes.
9946 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
9947 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
9948 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
9949 (setup_randomize) Sets set_seed_used.
9951 * set.q: Comment fixes.
9952 (custom_results) Conditionalizes on `compat'.
9953 (custom_log) Calls custom_journal().
9954 (set_ccx) New function.
9955 (cmd_set) Calls init_compat_dependent() when `compat' changes.
9956 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
9957 when set_decimal changes. Range-checks values for MITERATE,
9958 MNEST. Message fixes.
9960 * settings.h: Comment fixes.
9961 (struct set_cust_currency) New struct.
9962 (set_cc[], set_grouping, set_seed_used) New global vars.
9964 * var.h: (FMT_CCA...FMT_CCE) New output formats.
9965 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
9967 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
9969 * glob.c: Revised variables to correspond to settings.h.
9970 (init_glob) Initializes variables from settings.h properly.
9972 * set.q: Began long-overdue major revision to correspond to new
9973 philosophy. Most code changed.
9975 * settings.h: Mostly changed; reorganized, reordered, large new
9978 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
9980 * get.c: (cmd_save_internal) No longer forces compression off.
9982 * sfm-read.c: (read_compressed_data) If eof is reached when
9983 reading a new instruction octet, only signal error if we're in the
9986 * sfm-write.c: (COMPRESSION_BIAS) New #define.
9987 (struct sfm_fhuser_ext) New member `end'.
9988 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
9989 (ensure_buf_space) New function.
9990 (sfm_write_case) Reimplemented in order to support compression.
9991 (sfm_close) Writes out the remaining contents of the compression
9994 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
9996 * command.c: Defined SAVE and XSAVE commands in command table.
9998 * common.h: second_lowest_value is of type flt64, not double.
10000 * file-handle.h: Comment fix.
10002 * get.c: Comment fixes.
10003 (static var `trns') New.
10004 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10005 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10006 (dict_delete_run) Clears the variables and frees them now.
10007 (trim_dictionary) Sets default for compression.
10008 On KEEP subcommand, frees deleted variables as well as clearing
10009 them. Finally got the sense of the test for deleting all
10011 [DEBUGGING] (dump_dict_variables) Message fix.
10013 * glob.c: (init_glob) set_compression set to 1 by default.
10015 * list.q: Properly #includes config.h.
10017 * misc.h: New macro REM_RND_UP.
10019 * settings.h: Comment fix.
10021 * sfm-read.c: (structs sysfile_header, sysfile_format,
10022 sysfile_variable; inline function bswap_int32) Moved to new file
10024 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10025 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10027 (read_machine_flt64_info) Fixed some problems caused by confusion
10028 between flt64 and double types.
10029 (read_header) Message fix.
10030 (read_variables) Fixed set of cases in which we byte-swap sv.print
10031 and sv.write. Fixed confusion of flt64 and double.
10033 * sfm.h: (struct sfm_write_info) New.
10035 * som-high.c: (som_draw_title) Properly frees `s'.
10037 * temporary.c: (save_dictionary) Comment fix.
10039 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10040 (struct trns_header) Formatting fix.
10041 (struct save_trns) New.
10043 * vars-atr.c: (discard_variables) Comment fix.
10045 * sfm-write.c: New file, baseline release.
10047 * sfmP.h: New file, baseline release.
10049 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10051 * cmdline.c: (parse_command_line) `--version' output updated.
10052 (glob var syntax_message[]) Added my e-mail address.
10054 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10055 `illegal' to `invalid'.
10057 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10058 uncompression buffer.
10059 (sfm_close) Frees decompression buffer.
10060 (sfm_read_dictionary) Initializes decompression buffer.
10061 (buffer_input, read_compressed_data) New functions.
10062 (sfm_read_case) Restructured; now calls read_compressed_data() to
10063 handle compressed system file data.
10065 * var.h: Comment fix.
10067 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10069 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10072 * get.c: New comments. New static var `get_file'.
10073 (cmd_get) Now fully implemented. Calls discard_variables();
10074 initializes fv and lv for all variables; new debug code; sets
10075 up the dictionary; sets up the input program.
10076 (read_from_get, cancel_get) New functions.
10078 * sfm-read.c: Comment fixes.
10079 (sfm_close) New static function.
10080 (sfm_read_dictionary) Properly sets up the class of the
10081 file_handle. No longer cares what size the data is in records of
10082 type 7. Also, on failure, properly cleans up the file_handle and
10083 free()s some stuff.
10084 (read_variables) No longer thinks it knows `nval' of the
10085 dictionary. Now sets p.get.fv, etc., instead of speculatively
10087 (read_value_labels) Fixed off-by-one error in indexing of
10089 (sfm_read_case) New function.
10090 (sfm_r_class) New static var.
10092 * var.h: (get_proc) New struct.
10093 (struct variable) New member p.get.
10095 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10097 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10098 the manual's meaning.
10099 (rename_variables) New function.
10100 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10101 code. Now properly reorders the dictionary on the KEEP keyword.
10103 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10104 garbage collection.
10106 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10107 (rename_variable) New function.
10108 (free_val_lab) Reformatted.
10110 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10112 * var.h: Reindented entire file. Comment fixes.
10113 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10115 (glob var default_dict) New.
10116 (struct indirect_dictionary) Removed.
10118 * Many other source files were changed to add `default_dict.'
10119 before all references to the dictionary of the active file.
10121 * vars-atr.c: (make_indirect_dictionary) Removed.
10123 * glob.c: Reindented all variable declarations. Updated for
10124 changed var.h. Comment fixes.
10126 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10127 because now we can mainly copy dictionary structs.
10129 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10130 parse_variables) Takes dictionary instead of indirect_dictionary
10132 (parse_variables) Instead of calling make_indirect_dictionary,
10133 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10134 of `*dict.' references had to be changed to `dict->'. Removed
10137 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10139 * get.c: Added GTSV_OPT_* series of enums.
10140 (trim_dictionary, dict_delete_run) New functions.
10141 [DEBUGGING] (dump_dict_variables) New function.
10142 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10143 [DEBUGGING] Calls dump_dict_variables() to display results.
10145 * glob.c: (cmp_variable) Now a public function declared in var.h.
10147 * sfm-read.c: Turned off debug code. Comment fixes.
10148 (read_machine_int32_info, read_machine_flt64_info) New functions
10149 to parse type 7 records.
10150 (sfm_read_dictionary) Properly byteswaps several fields now.
10151 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10152 records. [DEBUGGING] Dumps dictionary.
10153 (read_variables) Sets `index' field of variables created properly.
10154 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10155 longer dumps dictionary.
10156 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10158 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10160 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10161 var before destroying any variables just to save a little time.
10163 * var.h: (struct variable) Reordered in order to make name[] the
10164 first member; this makes pointers to `variable' pointers to the
10165 variable name, simplifying avl trees, etc.
10166 (struct indirect_dictionary) New struct.
10168 * vars-atr.c: (find_variable) Rewritten for efficiency.
10169 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10171 (is_varname) Rewritten for efficiency.
10172 (parse_variables) New argument, which is a `dictionary *'. All
10173 references changed. This function now reads variable names from
10174 the dictionary passed, or from the default dictionary if NULL.
10176 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10178 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10179 rounding up. Changed many references to ROUND_UP to use this
10182 * sfm-read.c: Includes avl.h.
10183 (corrupt_msg) Induces a segfault under Checker.
10184 (macro assertive_bufread) New. Many references to bufread() now
10186 (sfm_read_dictionary) Split up into several functions. Added code
10187 to read dictionary records following the the type 2 records. Not
10188 quite complete. New variable `var_by_index'.
10189 (read_header, read_variables) New functions extracted from
10190 sfm_read_dictionary().
10191 (read_value_labels) New function.
10192 (bufread) Checks ferror() if fread() doesn't return the expected
10193 value; if ferror() is zero it's just EOF.
10194 (dump_dictionary) Stubbed out.
10196 * BTW: The source code now exceeds 50000 lines!
10198 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10200 * command.c: Added GET to cmd_table[].
10202 * list.q: Removed reference to alloca headers.
10203 (cmd_list) Gave prototype.
10205 * sfm-read.c: Added DEBUGGING comments.
10206 (sfm_read_dictionary) Checks bias correctly. Sets
10207 dict->var_by_name to NULL. Calculates long_string_count
10208 correctly. realloc's dict->var[] array to minimum size.
10209 [DEBUGGING] Calls dump_dictionary.
10210 [DEBUGGING] (dump_dictionary) New function.
10212 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10213 (restore_dictionary) If the dictionary contains a non-NULL
10214 var_by_name, uses that instead of generating one.
10215 (free_dictionary) Destroys var_by_name.
10217 * var.h: (struct dictionary) Added field `var_by_name'.
10219 * get.c: New file, not complete.
10221 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10223 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10224 (parse_num_or_range) New function.
10225 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10226 <n> THRU HIGH missing values.
10228 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10229 __attribute__((const)).
10231 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10233 * sfm-read.c: Finished reference implementation.
10235 * sfm.h: Includes var.h.
10237 * var.h: Comment fixes.
10238 (struct `variable') Reordered some fields.
10240 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10241 constants added previously.
10243 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10245 * common.h: Comment fixes. Added declaration of
10246 `second_lowest_value' as variable or macro. Made `compat_type',
10247 `pgm_state_type' into anonymous enums.
10249 * display.c: Comment fix.
10251 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10253 [!defined SECOND_LOWEST_VALUE] Added definition for
10254 `second_lowest_value' global var.
10255 (compat, pgm_state global vars) Changed types to `int'.
10256 (init_glob) Initializes `second_lowest_value'.
10258 * sfm-read.c: Continued work, not complete.
10260 * var.h: Added new MISSING_* constants to handle LOWEST and
10263 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10265 * sfm-read.c: New file, not complete.
10267 * cases.c: (vec_insert) Changed vector expansion algorithm.
10268 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10269 mucking up the RECODE transformation in particular.
10270 (envector) Harmless change in notation.
10272 dfm is now fairly well tested again.
10273 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10275 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10277 * recode.c: Comment fix.
10279 * sfm.h: Interface should be fairly final now, or at least for a
10282 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10283 (open_active_file) [DEBUGGING] Translates ccase indices into
10284 variable names now to make it easier to understand what's really
10287 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10289 * data-in.c: Comment fix.
10291 * data-list.c: Includes dfm.h.
10292 (do_reading) Uses new function dfm_push_cust().
10294 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10295 `return 1;' at end.
10297 * file-handle.h: Completely changed. Some parts split off into
10298 new file dfm.h. Implemented in file-handle.q.
10299 (enum FH_*) Removed.
10300 (struct fh_ext_class) New struct.
10301 (struct file_handle) Retained only these fields: name, norm_fn,
10302 fn, recform, lrecl, mode. New fields class, ext.
10303 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10304 close_handle, handle_name) Added `fh_' prefix to name, all
10305 references changed.
10307 * dfm.h: New file, implemented in dfm.c.
10308 (get_record, put_record, fwd_record, bkwd_record, set_record,
10309 get_cur_col) Functions moved from file-handle.h, now prefixed with
10311 (dfm_push_cust) New function.
10313 * sfm.h: New file. Incomplete.
10315 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10316 interface. Functions reordered, comments changed. Not well
10317 tested, probably full of bugs.
10318 (struct dfm_fhuser_ext) New struct.
10319 (dfm_close) New function.
10320 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10321 (open_file_w) User messages changed.
10322 (get_record) Comment fixed.
10323 (read_record) Increments ext->ln even for inline_file. Calls
10324 dfm_close() for inline_file when `END DATA.' encountered.
10325 (dfm_get_record) Experimental restructuring.
10326 (dfm_push_cust) New function.
10327 (cmd_begin_data) Detects whether the inline file was fully read by
10328 checking whether it is still open; detects whether it was read at
10329 all by checking whether the line number is greater than zero.
10331 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10332 interface. Functions reordered, comments changed. Not well
10333 tested, probably full of bugs.
10334 (init_file_handle) Removed initializers for obsolete fields, added
10336 (fh_close_handle) Much simpler, now mainly calls the class
10338 (fh_init_files) Renamed inline file internal filename.
10340 * file-type.c: Includes dfm.h.
10341 (read_from_file_type) Doesn't use dfm internal state anymore.
10343 * inpt-pgm.c, print.c: Include dfm.h.
10345 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10346 int in comparison with other int.
10348 * som-high.c: (build_target) Fixed operator precedence problem in
10349 if statement (& versus ==).
10351 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10353 * dfm.c: (read_record) Can now read fixed-length records; not
10355 (put_record) Can now write fixed-length records; not tested.
10357 * file-handle.h: FH_* defines changed to enums. New enum series
10359 (struct file_handle) New members recform, lrecl, mode.
10361 * file-handle.q: Parser changed.
10362 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10363 /LRECL subcommands. These are compatible with Windows.
10364 (init_file_handle) Initializes recform, mode fields.
10366 * q2c.c: (get_line) When outputting `!' comment lines, now
10367 increments the output file line number so that `#line' directives
10369 (make_identifier) New function that converts an arbitrary string
10370 into a valid C identifier.
10371 (dump_vars) Calls make_identifier() in two places in order to
10372 suppress some errors for bad identifiers.
10373 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10374 for NO. Allows numbers to be prefixed by underscores to make them
10375 acceptable C identifiers but still to be parsed as numbers by the
10378 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10380 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10382 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10383 was opened for writing.
10384 (open_file_w) New function.
10385 (read_record) Uses strncasecmp if available. Improved error
10386 messages, comments.
10387 (put_record) New function.
10389 * file-handle.h: Moved function comments into dfm.c and
10390 file-handle.q. Comment fixes. Removed declarations of
10391 tilde_expand() and normalize_filename().
10392 (struct file_handle) Changed `open' from boolean to enumerated
10393 field to allow for three states--closed, open for reading, open
10394 for writing--all references changed.
10396 * file-handle.q: Includes filename.h.
10398 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10399 references changed.
10400 (alloc_line) Makes allowance for line terminator characters in
10402 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10403 (print_space_trns_proc) Handles OUTFILE differences.
10405 * recode.c, sample.c: Comment fixes.
10407 * var.h: (struct print_trns) Changed boolean field `eject' to
10408 bitmapped field `options'; all references changed. New enums
10409 PRT_* for use with this field.
10411 * exception.h, test-exception.c: Removed.
10413 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10415 * ascii.c: (delineate) Turned off debug output.
10417 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10420 * data-in.c: (parse_string_as_format) Sets the entire string value
10421 to spaces, not just the short string part of it. Is this correct
10424 * data-out.c: (convert_date) Fixed DATETIME format problems with
10425 decimal places, removed debug code.
10427 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10428 middle of parsing BEGIN DATA that would cause the lexer to read
10429 from a wild pointer `prog'; now calls new function
10430 preprocess_line() in lexer.c.
10432 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10434 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10435 Now call induce_segfault() to induce the segfault.
10436 (induce_segfault) New function.
10438 * expr-opt.c: Comment fix.
10439 (parse_sysvar) New function.
10440 (parse_primary) Added system variable support--calls
10442 (global var ops) Added OP_CASENUM operator.
10444 * expr.h: Comment fixes.
10445 (OP_* enum) added OP_CASENUM operator.
10446 (struct casenum_node) New struct.
10447 (union any_union_union) New member `cas' of type `casenum_node'.
10449 * glob.c: (global var last_vfm_invocation) New var.
10450 (init_glob) Initializes last_vfm_invocation.
10452 * lexer.c: (lookahead) Fixed reversed condition on if statement.
10454 * getline.c: (get_line) Split into get_line() and preprocess_line().
10455 (preprocess_line) New function.
10457 * var.h: Declares last_vfm_invocation.
10459 * vfm.c: (procedure) Sets last_vfm_invocation.
10461 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
10463 * command.c: (parse_cmd) Fixed bad assertion related to
10466 * data-in.c: (parse_month) Implemented to parse months according
10467 to full interpretation of standard.
10468 (to_roman) New function.
10469 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
10470 (parse_weekday) Bug fix (forgot to skip all the day name).
10472 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
10473 up parsing of multirecord data items. Also fixed user message.
10475 * data-out.c: Comment fix.
10476 (year2, year4, convert_date, convert_time, convert_WKDAY,
10477 convert_MONTH) New functions to support time & date output.
10478 (convert_format_to_string) Calls new time & date output routines.
10480 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
10482 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
10485 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
10487 * misc.c: (global var formats) Fixed declarations of DATETIME,
10490 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
10491 the output_char buffer.
10493 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
10494 memory bug. Fixed user messages.
10496 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
10498 * Removed #pragma argsused from lots of places.
10500 * data-in.c: Implemented zoned decimal and time-date formats.
10501 Untested. This is a huge chunk of code--maybe 1000 lines and 50
10504 * data-out.c: Implemented zoned decimal format.
10506 * expr.h: Moved yrmoda() declaration here from exprP.h.
10508 * misc.c: (global var formats) Minor fixes--added
10509 FCAT_SHIFT_DECIMAL to formats N and Z.
10510 (convert_fmt_ItoO) Added support for format Z.
10512 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
10514 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
10516 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
10517 som_check_workspace() that is activated between commands.
10519 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
10522 * list.q: (begin_row) Changed title expansion style from
10523 SOPT_X_VERT to SOPT_X_SHSP.
10525 * som-frnt.c: Now includes `somP.h'.
10526 (som_push_workspace, som_pop_workspace) New functions that, taken
10527 together, form a solution to the recursive table building problem
10528 mentioned yesterday. Surrounded every table output routine
10529 throughout the program with calls to these functions.
10530 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
10531 (som_create_table) Checks that there's an active workspace.
10532 (som_destroy_all_tables, som_crush) Removed.
10534 * som-high.c: (global var som_preserve_tables) Removed, all
10535 references deleted.
10536 (som_submit_table) Checks that there's an active workspace.
10537 (dump_columnated_table) Doesn't columnate tables that would have
10538 just one row per column.
10539 (dump_crush_page, som_dump_crush_page) Removed debugging code.
10540 (som_dump_crush_page) Moved row number labels from left side of
10541 tables to right side.
10542 (som_get_table_size) Added support for SOPT_X_SHSP.
10544 * som.h: New cell expansion type SOPT_X_SHSP.
10546 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
10548 (global var curtab_arena) Moved from som-frnt.c.
10550 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
10552 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
10553 that causes bad location warnings to be suppressed.
10554 (delineate) Saves current font when calling draw_text(); fixed
10555 handling of NULLs when backing up. Also fixed line-wrapping bug.
10557 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
10558 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
10560 * common.c: Added code to cause assertion failure to dump core
10561 when run under Checker.
10563 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
10564 there are still bugs.
10566 * glob.c: (__eprintf) Removed.
10568 * list.q: Inserted som_preserve_tables kluge that prevents tables
10569 from being thrown away due to recursive table building through
10570 som_output_line being called from a transformation during the LIST
10571 procedure invocation. This is a general problem that must be
10572 solved in a better way since it applies to all procedures in
10574 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
10575 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
10577 * numeric.c: Fixed several errors in the form of msg() calls.
10579 * print.c: Updated for use of som.
10580 (dump_table) Reimplemented.
10581 (print_trns_proc) Calls som_eject_page() instead of eject_page().
10582 Calls som_output_text() instead of outs_line().
10584 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
10586 (som_output_text) Function moved from som-low.c. Interface
10589 * som-high.c: (som_preserve_tables) New global public variable
10591 (som_submit_table) Destroys the tables only if som_preserve_tables
10593 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
10594 one subrow per row. Now labels subrows if there's more than one
10596 (dump_crush_table) Added wishlist comment.
10597 (som_eject_page) New public function declared in som.h.
10599 * som-low.c: (som_dump_crush_page) Draws row labels if there's
10600 more than one subrow per row.
10601 (som_output_text) Moved to som-frnt.c.
10603 * som.h: (SOM_TOPT_PRESERVE) Removed.
10605 * title.c: (get_title) Changed interface.
10606 (cmd_title) Changed `title' to `outp_title'.
10607 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
10609 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
10611 * list.q: (flush_table) Conforms to new partial options in
10612 som_submission_form.
10614 * som-high.c: (paginate_horizontally) Changed form of subrow
10616 (build_target) Omits spacing before table if
10617 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
10618 (dump_crush_page) Changed interface. Only trims bottom rule if
10619 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
10620 (dump_crush_table) Handles partial tables.
10621 (output_row_label) New function.
10622 (som_dump_crush_page) Emits subrow number labels. Draws vertical
10623 rule on the right edge of narrow subrows.
10625 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
10626 constants to a series of SOM_TOPT_PARTIAL_* submission options.
10627 All references updated.
10629 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
10631 * misc.c: Comment fix.
10633 * som-high.c: (examine_table) Treats crushed tables separates for
10634 purpose of determining header size.
10635 (paginate_horizontally) Allots space for line numbers in crushed
10636 tables with lots of subrows per row. Calculates the `maximum page
10637 width', the width of the widest horizontal page.
10638 (build_target) Removed trim argument; all references changed.
10639 Stricter assertions. (dump_crush_page) New function.
10640 (dump_crush_table) Reimplemented.
10642 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
10643 (som_dump_crush_page) Reimplemented, interface changed.
10645 * somP.h: Many many new helper macros for use with crushed tables.
10646 (global var som) Removed `tv', `cum_y' members; all references
10647 removed. New members `mpw', `digit_space'.
10649 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
10651 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
10652 variable, changed to constant 1024.
10653 (arena_ca_strdup) Changed `sizeof(a_string)' to
10654 `sizeof(c_string)'.
10655 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
10656 `(c_string *)' to `(char *)'; this fixed some offset problems.
10658 * filename.c: (readlink_malloc) Changed initial allocation from
10660 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10663 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10664 &fm->owner in several places.
10666 * som-high.c: (output_table) Changed interface to rest of world.
10667 (examine_crush_table) Removed. Crushed tables are re-broken now,
10668 in preparation for rewrite.
10670 * som.h: Comment fix.
10672 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10674 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10675 itself in the cleanup stage.
10677 * descript.q: (display) At least temporarily, changed the table
10678 format to a crushed table.
10680 * list.q: (begin_row) At least temporarily, added horizontal lines
10683 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10684 the horizontal "headers," that is, to the width of the far left
10685 and far right rules.
10686 (justify_pagination) Sets som.th to the width of the widest row
10687 in the crushed table. Fixed inner loop off-by-one error.
10689 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10692 * somP.h: Comment fix.
10694 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10696 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10697 before closing it; also, opens the constructed filename `s'
10698 instead of f->filename.
10700 * postscript.c: Moved initialization of x->loaded, x->prop,
10701 x->fixed, x->current, also the add_encoding() calls, into
10703 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10704 sets x->last_font to NULL; sets x->next_combo to zero.
10706 * som-high.c: (crushed_row_height) Moved definition farther up.
10707 (som_submit_table) Doesn't calculate line width, font size until
10708 after calling open_page(), to accomodate changes to PostScript
10710 (vert_headers) Removed; equivalent functionality moved to
10711 examine_table(), examine_crush_table().
10712 (justify_pagination) Replaced with different algorithm.
10713 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10714 at the bottom of the page.
10716 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10718 * command.c: Added cmd_list back into cmd_table.
10720 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10721 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10723 * list.q: (flush_table) Updated to new som_submission_form format.
10725 * som-frnt.c: Comment fix.
10727 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10728 (output_table) Calls som_get_table_size() directly; handles
10730 (examine_crush_table) New function; calls vert_headers().
10731 (examine_table) Moved some code into new function, vert_headers().
10732 (justify_pagination) New function.
10733 (dump_plain_table) Removed `static' from `cy'.
10734 (dump_crush_table) New function.
10736 * som-low.c: (som_dump_crush_page) New function.
10738 * som.h: Comment fixes.
10739 (enum SOM_TOPT_CRUSH) New.
10740 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10741 Temporarily set to zero to make do with LIST procedure.
10743 * somP.h: Re-ordering.
10745 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10747 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10749 * somP.h: New file for use by som-high.c, som-low.c.
10751 * q2c.c: Added definition for VME.
10752 (get_line) Now dumps `!' comment lines to the output file
10755 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10756 set.q: Changed format of `!' comment lines.
10758 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10760 * All source files: Added copyright notice.
10762 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10763 longs in msg() calls.
10765 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10767 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10769 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10771 * output.c: (outp_read_devices) Changed criteria for
10772 distinguishing different types of lines.
10774 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10776 * cmdline.c: Changed syntax message.
10778 * filename.c: (good_getcwd) Bug fix (?).
10779 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10781 (search_path) Appends DIR_SEPARATOR to directory name only if it
10782 does not already end with one.
10784 * glob.c: Checks STAT_PAGER envvar before PAGER.
10786 * output.c: Checks environment variables instead of just local
10789 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10791 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10792 when the pointer passed to the function was within the arena
10793 itself, so that it couldn't properly be set to NULL _after the
10796 * command.c: Re-enabled DISPLAY.
10798 * display.c: Rewritten to handle tables. Untested.
10800 * filename.c: (search_path) Fixed memory leak.
10802 * frequencies.q: (cmd_frequencies) Frees v_variables.
10803 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10804 (cleanup_freq_tab) New function to garbage collect.
10805 (dump_full) Elegantized.
10807 * main.c: New comment.
10809 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10811 * postscript.c: Comment fix.
10812 (release_fontmap, free_font_entry) New functions.
10813 (ps_init_driver) Sets free_font_entry() as the freefunc for
10814 hashtable `loaded'. Calls release_fontmap() when destroying a
10815 driver; also frees the output filename; also frees the
10816 ps_driver_ext block.
10817 (free_ps_encoding) Frees the filename as well as the encoding
10819 (output_encodings) Frees the line buffer and pops the msg-filename
10821 (read_fontmap) Frees the fontmap filename and the line buffer.
10822 (postopen, preclose) Misc. garbage collection fixes.
10823 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10824 to NULL; this fixes some output problems.
10825 (text) Handles TAG_NEWLINE. Untested.
10827 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10828 (som_set_string) Removed. All references changed to
10830 (som_set_text) Rewritten. New interface. More general.
10832 * som.h: Minor format changes.
10833 (struct som_value_cell) Removed; all references changed to
10835 (enums SOT_*) Changed.
10837 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10839 * command.c: Re-enabled SPLIT FILE.
10841 * postscript.c: Comment fix.
10843 * som.h: Added `SOT_NONE'.
10845 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10847 * vfm.c: (dump_splits) Reimplemented.
10849 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10851 * Compiled the project under gcc 2.7.2, which gave some new
10852 warnings. This led to many additions of casts from unsigned to
10853 int sprinkled throughout the code.
10855 * arena.c: Many uses of `unsigned' changed to `size_t'.
10857 * command.c: Added END FILE, END REPEAT to command table.
10858 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10859 (find_command, FILE_TYPE_okay) Not commented out anymore.
10860 (parse_cmd) Calls FILE_TYPE_okay again.
10861 (output_line) Added calls to som_output_text() to put the line
10862 in the output files.
10864 * common.c: (macro VME) Format changes.
10865 (xstrdup) Asserts that its argument is not NULL.
10867 * data-list.c: Implemented dump_fixed_table().
10869 * inpt-pgm.c: Formatting changes. Comment changes.
10870 (end_case_proc) Renamed end_case_trns_proc.
10871 (cmd_end_file, end_file_trns_proc) New functions.
10873 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10875 * misc.h: (local_strdup) New macro corresponding to strdup() but
10876 allocating its data through local_alloc() if possible--that is, if
10879 * postscript.c: Comment changes.
10880 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10881 (output_line, add_string) New macros supporting
10882 output_encodings().
10883 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10884 substitution vars. Calls output_encodings() when a line
10885 consisting of `!encodings' is encountered.
10886 (preclose) Some code moved into quote_ps_string().
10887 (dump_line) Changed into macro supporting dump_fancy_line().
10888 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10889 command when appropriate.
10890 (write_text) Fixed `literal_char' array (I think it's fixed, at
10892 (text) Fixed bug when width was zero. Now exits immediately on
10893 zero height_left. Now, when executing `goto restart;', checks
10894 that cp<end, so that we don't read beyond end-of-string. Also,
10895 outputs the correct code to the output file by outputting the code
10896 from the metric instead of the internal metric index.
10898 * repeat.c: (cmd_end_repeat) New function.
10900 * som.c: (var som) `headers' renamed `options' and semantics
10901 changed. All references changed.
10902 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10903 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10905 (som_text_table) Removed.
10906 (som_output_text) New function.
10908 * som.h: (struct som_submission_form) Removed `header', `reuse',
10909 replaced with bitmapped field `options'.
10910 (SOM_TOPT_*) New enum set for som_submission_form.options.
10911 (SOT_*) New enum set for som_output_text().
10913 * temporary.c: (copy_variable) When copying the var label, only
10914 calls xstrdup() if it's non-NULL.
10916 * var.h: (enum type `vartype') Removed; all references changed to
10919 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10922 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10924 * font.h: Comment changes.
10926 * groff-font.c: (groff_read_font) Initializes `name' field to
10927 NULL. Handles `encoding' field.
10929 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10931 * postscript.c: (struct font_entry) Removed `position' field.
10932 (struct ps_font_combo) New struct.
10933 (struct ps_driver_ext) Removed field `next_position'. New fields
10934 `combos', `next_combo'. `last_font' field changed from
10935 `font_entry *' to `ps_font_combo *'.
10936 (ps_init_driver) Reformatted; handles new fields. When
10937 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
10939 (get_encoding, find_encoding_file) New functions.
10940 (add_encoding) Some code moved out into find_encoding_file().
10941 (postopen) Changed value for ${title}.
10942 (preclose) Sets `loaded' field to NULL after destroying the hash
10944 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
10946 (ps_text_set_font_by_position) Figures out the current family if
10948 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
10949 (switch_font) Implemented.
10950 (write_text) Calls switch_font() more often. Format changes.
10951 #undefs its macros after they're no longer useful.
10952 (text) Changed `continue' at one point to a jump to the top of the
10953 loop because we don't want `separate' reset to 0 at that point.
10954 (load_font) No longer sets `position' in the font_entry created.
10956 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
10958 * font.h: (struct font_desc) New member `encoding', which is not
10959 properly handled yet.
10961 * glob.c: (init_glob) Some new i18n code, which is probably
10964 * output.c: (outp_read_devices, outp_get_paper_size) Changed
10965 `size' local from `int' to `size_t'.
10967 * postscript.c: New driver configuration parameter `auto-encode'.
10968 New enums OPO_AUTO_ENCODE, ODA_COUNT.
10969 (struct font_entry) New member `position'.
10970 (struct ps_driver_ext) Reordered. New hash table member
10971 `encodings'; new members `next_position', `next_encoding',
10972 `last_font'. Members `current', `prop', `fixed' changed from type
10973 `font_desc *' to `font_entry *'; all references changed.
10974 (struct ps_encoding) New struct.
10975 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
10976 free_ps_encoding, add_encoding) New functions.
10977 (ps_init_driver) Added OPO_AUTO_ENCODE to default
10978 x->output_options. Initializes new members of ps_driver_ext.
10979 Changed default value for prologue_fn, encoding_fn. Calls
10980 read_ps_encodings after loading default fonts.
10981 (option_tab[], ps_option) Handle new configuration parameter.
10982 (switch_font) New function.
10983 (struct output_char) `font' member changed from `font_desc *' to
10984 `font_entry *'. New member `separate'.
10985 (read_fontmap) Changed `size' from `int' to `size_t'.
10986 (output_line, put_number) New macros for write_text().
10987 (write_text) Optimizes text output by consolidating multiple
10988 calls to PostScript `show' operator.
10989 (text) Keeps track of when text arguments can't be consolidated by
10990 write_text(), and marks those spots in the output stream.
10991 (load_font) Sets `position' of the allocated font_entry to -1, cuz
10992 the font hasn't been switched to by switch_font(), which is where
10993 the position is important--the PostScript is what cares about the
10996 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
10998 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
10999 call a NULL free_func.
11000 (hsh_rehash) Elegantized.
11001 (hsh_probe) Fix bug that manifested when the table was expanded
11002 and thus had to change location in memory. Good thing
11003 too--otherwise could have been much more subtle.
11004 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11005 (hsh_foreach) New function for hash table iteration.
11007 * hash.h: (struct hsh_iterator) New.
11009 * lexer.c: (parse_tagged_quote) Font and family name strings in
11010 tags are now null-terminated.
11012 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11014 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11015 documented. (Never before tested?)
11017 * output.h: Comment changes.
11019 * postscript.c: New driver options `optimize-text-size',
11020 `optimize-line-size', `max-fonts-simult'. New enum set for
11021 specing cached line types. Comment fixes.
11022 (struct line_form) New struct.
11023 (struct ps_driver_struct) New members `text_opt', `line_opt',
11024 `max_fonts', `lines'.
11025 (ps_init_driver) Initializes new members of ps_driver_struct.
11026 (user option type enum set) New member `nonneg_int_arg'.
11027 (static var option_tab[]) Supports new options.
11028 (ps_option) Handles new options.
11029 (find_ps_file) Made static. No longer calls hsh_dump().
11030 (ps_get_var) Made static.
11031 (preclose) Dumps out proper DSC trailer.
11032 (ps_open_page) Elegantized.
11033 (ps_close_page) Calls dump_lines() if appropriate.
11034 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11035 wrappers around line().
11036 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11037 dump_lines, hash_line, free_line, line) New functions for support
11039 (write_text, text) Made static.
11040 (text) Added to font support, not finished.
11042 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11044 * font.h: (struct font_desc) New members ascent, descent.
11046 * groff-font.c: (groff_read_font) Calculates font ascent and
11047 descent from the ascent and descent of the `d' and `p' characters,
11048 respectively, as per a suggestion on comp.fonts.
11050 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11051 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11053 (write_text) Handles text right-justification and centering (not
11054 full justification). Still very inefficient. (One output line
11056 (struct output_char) Added fields for font and font size.
11057 (text) Many bugfixes.
11059 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11061 * cmdline.c: (usage) Calls outp_list_classes().
11063 * font.h: Comment fix.
11065 * groff-font.c: New exported global var `space_index'.
11066 (groff_init) New function to initialize `space_index'.
11067 (hash_kern) Casts result to unsigned.
11068 (font_name_to_index) Renamed font_char_name_to_index. All
11069 references changed. Also, now returns the value of `space_index'
11070 when passed an ASCII space character as an argument. Fixed
11072 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11073 Handles passed NULL pointers properly.
11075 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11078 * output.c: (outp_list_drivers) Removed. Removed all references.
11080 * output.h: Comment fixes.
11082 * postscript.c: (ps_open_global) Calls groff_init().
11083 (output_char) New structure.
11084 (write_text) New function.
11085 (text) No longer stubbed out! Now the output is correct--with a
11086 few exceptions, one of them being that the page has to be held
11087 upside down into a mirror.
11089 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11091 * font.h: Comment fix.
11093 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11094 All callers changed.
11095 (number_to_index) Renamed font_number_to_index, made extern. All
11097 (font_get_kern_adjust, font_get_char_metrics) New functions.
11099 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11101 * postscript.c: Changed default line width back to 1/2 point.
11102 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11103 in the center of the space allotted for them, not just a fixed
11104 offset from the edge of the space; this fixes some bugs.
11105 (ps_line_intersection) Now supports all command line styles.
11106 (ps_text_get_size) Bug fix in computation of em width.
11107 (text) New function, the meat behind ps_text_metrics and
11108 ps_text_draw. Not complete.
11109 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11110 ascii.c; call text().
11112 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11114 * arena.c: (arena_free) Assert that the argument is non-NULL.
11116 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11117 only if old_kern is non-NULL.
11119 * postscript.c: (ps_init_driver) Changed default line width to 1
11121 (postopen) New prologue variables.
11122 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11123 more of the common line styles properly, but not all.
11124 (ps_text_metrics) Fixed problem with this stubbed out version that
11125 kept it from taking font sizes into account.
11127 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11129 * arena.c: (arena_malloc) Bug fix.
11130 (arena_dump) [GLOBAL_DEBUGGING] New function.
11132 * ascii.c: Comment fix.
11133 (count_fancy_chars, delineate) Now static functions.
11135 * filename.c: (interp_vars) Bug fixes.
11137 * font.h: Comment fixes.
11139 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11140 beginning in case we have an error message to display before
11141 initializing the display.
11143 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11145 (groff_read_font) Bug fixes.
11146 (name_to_index) Increments hash.used. Sets `name' field of hash
11148 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11150 * hash.c: Return type changed.
11152 * postscript.c: Continued development. Now marks lines on the
11153 paper, but very buggy.
11155 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11157 * Changed comments in many source files from `/* xxx /* yyy */' to
11158 `/* xxx */ /* yyy */' for cleanliness.
11160 * arena.c: (arena_sd_strdup) New function.
11162 * ascii.c: (struct ascii_driver_ext) New member `file'.
11163 (ascii_init_driver) Fills out member `file' for initing; uses
11164 close_file_ext for closing drivers.
11165 (ascii_option) Changed %.*s back to %s because the a_string's are
11166 always null-terminated.
11167 (postopen, preclose) New functions.
11168 (ascii_open_page) Uses new style of open_file_ext.
11169 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11170 instead of this->output.
11171 (__assert_fail) Removed.
11173 * cmdline.c: Changed syntax_message[].
11175 * error.c: #include's <readline/history.h> only if the history
11176 library is available, not if just the readline library is
11179 * filename.c: (expand_line) Removed alloca() support.
11180 (interp_vars) No longer tilde-expands argument. Limit on output
11182 (tilde_expand) Now treats argument as path rather than filename.
11183 [!unix] Now is a no-op function.
11184 (search_path) Better verbose message formatting.
11185 (open_file, close_file) Comment fixes.
11186 (close_file) [!unix] Doesn't bother with pipes.
11187 (open_file_ext) Completely rewritten, interface revamped.
11188 (close_file_ext) New function.
11190 * font.h: Comment changes.
11192 * frequencies.q: Removed AIX alloca support since it doesn't use
11195 * hash.c: Comment changes & additions.
11196 (hsh_create) Initializes entire table instead of first M entries.
11197 (hsh_probe) Stupid bug fixed. Now it works.
11198 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11200 * main.c: (parse) Detects EOF properly in token-eating loop.
11201 Should the STOP token have its value changed to 0?
11203 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11204 (blp_getline) Now it's a macro.
11206 * output.h: (struct outp_driver) Removed members output, filename.
11208 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11209 drivers in driver table.
11210 (outp_read_devices) Frees buf. Warns if there are no active
11212 (outp_configure_clear) Sets outp_configure_vec to NULL after
11213 deleting its elements.
11214 (configure_driver, destroy_driver) Removed references to output,
11215 filename members of outp_driver.
11216 (outp_evaluate_dimension, internal_get_paper_size,
11217 outp_get_paper_size) New functions.
11219 * postscript.c: Continued development. Now links but doesn't make
11220 any marks on the page. Lotsa bugs I suppose.
11222 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11224 * str.h: Comment changes.
11226 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11228 * Removed dependencies on non-nested comments in several files.
11229 Also removed references to (unix || __unix__) in #if's since
11230 prefh.orig makes those two equivalent.
11232 * ascii.c: (ascii_open_global) Creates ascii_arena.
11233 (ascii_close_global) Destroys ascii_arena.
11234 (ascii_init_driver) Doesn't create ascii_arena.
11235 (ascii_copy_driver) Removed.
11236 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11237 (outp_class ascii_class) Removed ascii_copy_driver reference.
11239 * frequencies.q: Now can display all statistics except median.
11240 Still not finished.
11242 * output.c: Handles outp_class.ref_count so output class
11243 destructors are called properly.
11244 (add_class) Sets ref_count to 0.
11245 (configure_driver) Initializes class if ref_count++ is 0.
11246 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11247 class output file name.
11249 * output.h: (struct outp_class) Removed copy_driver, inited.
11252 * postscript.c: Completely replaced but not finished.
11254 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11256 * approx.h: #includes <float.h>.
11258 * arena.h, arena.c: Many functions changed to take an arena **
11259 instead of an arena *, for consistency. All callers changed.
11260 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11261 (arena_destroy) Sets *A to NULL.
11263 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11264 assertion that `width' be positive.
11266 * command.c: Removed #if's from cmd_table.
11267 (walk_cmdtable_func) [0] New function (debug code).
11268 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11269 (parse_cmd) Doesn't return failure for unimplemented commands.
11271 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11272 (SYSCODE) New constant macro.
11274 * descript.q: Checks for positive n_variables before performing
11277 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11278 avl_find instead of &fp as arg 2.
11280 * frequencies.g, frequencies.q: Continued updating; now compiles &
11281 works again, but not complete.
11283 * main.c: Changes to user messages.
11285 * misc.c: (reverse) [0] New function.
11287 * settings.h: Comment removed. #includes "common.h".
11289 * som.c: (som_set_null) New function.
11290 (som_set_value, som_set_string, som_set_text) More detailing
11292 (som_set_float) Implemented function.
11293 (dump_columnated_table) Bug fix regarding page breaks.
11294 (draw_cell) Bug fix regarding text that spilled out of a cell.
11295 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11297 (get_cell_size) Support SCON_EMPTY cells.
11298 (get_table_size) When calculating rules' widths and heights, mask
11299 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11301 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11303 (struct som_submission_form) New member `header'; all users
11306 * val-labs.c: (get_label) User messages changed.
11308 * var.h: Changed FREQUENCIES structures.
11310 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11313 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11315 * approx.h: Definition of EPSILON now depends on system's
11316 DBL_EPSILON. Removed GNU C specific code.
11317 (cmpapx) Renamed approx_compare.
11319 * frequencies.g, frequencies.q: Continued updating; still doesn't
11322 * groff-font.c: (name_to_index) Fix bug that kept it from
11325 * hash.c, hash.h: Completed work.
11327 * var.h: Changes to freq_tab, frequencies_proc.
11329 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11332 * hash.c, hash.h: New files. Not completed.
11333 * Makefile.am: Added hash.c to source file list.
11334 * font.h: (struct font_desc) New member kern_size_p.
11335 * groff-font.c: Uses hash.h.
11336 (hashpjw) Moved to hash.c.
11337 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11339 (static var hash) New member size_p.
11340 * var.h: Includes hash.h.
11341 (struct freq_tab) Changed AVL_TREE to hash_tab.
11343 * vars-prs.c: Comment, formatting fixes.
11345 * frequencies.g, frequencies.q: Continued updating. Not yet
11348 * formats.c: Bug fix.
11350 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11352 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11353 * descript.g: Comment fixes.
11354 * descript.q: Comment fixes. Moved some declarations into var.h.
11355 Made dsc_info a static table. Updated FIXMEs.
11356 (internal_cmd_descriptives) Beautified.
11358 * frequencies.q: Started updating into working order.
11359 * frequencies.g: New file analogous to descript.g.
11360 * var.h: Comment fixes. Added structures for FREQUENCIES.
11362 * som.c: Removed vestiges of crushing and partial table support.
11364 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11366 * Many more changes to som.c especially, but these will not be
11367 documented as I have resolved to remove them. This patchlevel is
11368 being released solely so that I can fall back to it if I decide
11369 that removing the changes is not a good idea.
11371 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11373 * som.c: (global var som) New member `cum_y'.
11374 (build_target) Properly handles titles for partial tables.
11375 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11376 Merged into single new function dump_partial(). Fixed problem
11377 with titles on partial tables.
11378 (dump_table) Calls dump_partial() for all parts of partial tables.
11379 (dump_page) Criteria for drawing title changed.
11381 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11383 * command.c: (cmd_table) Added LIST, WEIGHT.
11385 * command.c: (cmd_remark) No longer frees `s' since it's not
11386 dynamically allocated.
11388 * data-out.c: (convert_f) Now correctly handles the case where
11389 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11390 number of decimals.
11391 (som_destroy_all_tables) Removed argument. All callers changed.
11392 (som_vline, som_hline) Argument validity checking corrected.
11393 (som_set_value) Implemented half-heartedly.
11394 (replicate_table) Copies tables piece-by-piece when using Checker.
11396 * som.h: New line style SLIN_1THIN, currently equivalent to
11397 SLIN_0. New enum set SOM_SUB_*.
11398 (struct som_submission_form) Removed `seq_no'. Added `type'.
11400 * list.q: Newly working file; uses partial tables.
11402 * som.c: (som_reduce_table) Renamed som_set_table_height().
11403 (som_crush) Removed argument `group'.
11404 (global var som) Removed `nt', `seq_no'. Added `type'.
11405 (som_submit_table) Arguments changed.
11406 (output_table) Removed partial table code.
11407 (build_target) New arg; partial table support added. All callers
11409 (dump_plain_table) Removed partial table code.
11410 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11411 (dump_table) Supports partial tables.
11412 (dump_page) New argument to allow not drawing top and/or bottom
11413 headers. All callers changed. Supports partial tables.
11415 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11417 * data-out.c: Changed `#include <approx.h>' to `#include
11419 (convert_F) Comment fix. Now won't print `-.000', etc.
11421 * descript.q: Now Z-scores work, although there appears to
11422 be a bug (which might actually be in data-out.c:convert_F()).
11423 (descriptives_trns_proc, descriptives_trns_free) New functions.
11424 (run_z_pass) Implemented.
11426 * var.h: Comment fixes.
11427 (dsc_z_score, descriptives_trns) New structs.
11428 (descriptives_trns) Added to any_trns as `dsc'.
11430 * error.c, error.h: New error class, IS (Installation Script
11431 error), used in those instances where the error is in the
11432 installation, but there is a script file or installation file that
11433 can be usefully referred to.
11435 * output.c: Change many IE classes to IS classes.
11437 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11438 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11439 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11440 include the corresponding header?
11442 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
11443 Don't bail out if termcap can't be read.
11445 * som.c: (som_destroy_table) Removed.
11446 (som_reduce_table, som_destroy_all_tables) New functions.
11447 (som_crush) New function, not implemented.
11449 * som.h: New table option STAB_CRUSH. Comment fix. New struct
11450 som_submission_form. Function prototypes revised.
11452 Outputting huge tables (1000s of rows) a few rows at a time
11453 is supported, though untested. May even break everything.
11454 Actually, the code doesn't even compile right now.
11455 * som.c: (struct som) New fields htv, nt, seq_no.
11456 (som_submit_table) Multiple arguments changed to a single
11457 pointer to struct submission_form. Only increments subtable_num
11458 if seq_no is zero. Only destroys table if it's not going to
11460 (replicate_table) New function.
11461 (output_table) Comment fix.
11462 (examine_table) Changed inline code to code calling
11463 replicate_table(). Calculates htv. Supports partial tables.
11464 (draw_title) Removed comment.
11465 (build_target) Only allows for title on first part of partial
11467 (dump_plain_table) Only resets table chunk number on first part
11468 of partial tables; FIXME: doesn't work quite right. Supports
11470 (dump_page) Titles only on first part of partial tables.
11472 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
11474 * Thanks to an unreliable IDE hard drive, I have spent the last
11475 day reconstructing my Debian GNU/Linux installation and redoing
11476 the previous day's changes--somehow I managed to save every file
11477 except for output.c and output.h. So the following changes could
11478 really be considered independent of the output.c, output.h changes
11481 * output.h, output.c: Moved the outp_configure_vec global var,
11482 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
11483 outp_configure_vec is now static.
11485 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
11487 * The entire philosophy behind configuration of the output drivers
11488 changed. Now there is a termcap-type configuration where drivers
11489 to be read are determined beforehand, rather than parsing the
11490 entire output init file and storing it in memory & deciding what
11491 to actually use later. Faster & more memory-efficient at the same
11494 * output.c: Comment fix. Removed outp_init_drivers global var.
11495 Removed all references to synonyms. New structure outp_defn. New
11496 global vars outp_macros, outp_configure_vec.
11497 (search_name, delete_name, add_name, check_configure_vec,
11498 expand_name, find_defn_value) New static functions.
11499 (outp_configure_clear, outp_configure_add, outp_configure_macro,
11500 outp_read_devices) New extern functions.
11501 (outp_init) Much functionality moved into outp_read_devices.
11502 (outp_read_devices) Format of output init file changed; name of
11503 file is `devices' rather than `output' to avoid Makefile
11505 (outp_clear) Renamed outp_done.
11506 (outp_list_classes) Bug fix, cleaned up.
11507 (outp_list_drivers) Not implemented anymore.
11508 (outp_configure_driver) Now a static function; simplified; now
11509 interpolates macros; supports new structure.
11510 (outp_enable_driver, match_synonym) Removed; all references
11512 (find_driver) First argument removed.
11514 * output.h: Global var outp_init_drivers removed; new structure
11515 outp_names; new enum set OUTP_S_*; new global var
11516 outp_configure_vec; function prototypes for output.c exports
11519 * main.c: (main) Calls outp_read_devices() after parsing the
11522 * cmdline.c: (parse_command_line) New option -v --verbose;
11523 --version changed to -V. --device option changed syntax to just
11524 take a single device name. Accepts key=value declaration of
11525 output init file macros. Syntax message updated.
11527 * filename.c: (expand_line) New function.
11528 (interp_environ_vars) Renamed interp_vars; no longer uses
11530 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
11531 overridden by real environment vars.
11532 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
11533 * filename.h: interp_environ_vars() renamed interp_vars().
11535 * error.c, error.h: Added extern variable `verbosity', message
11538 * error.c: (vmsg) Support message class MM.
11539 (verbose_msg) New function.
11541 * descript.q: (generate_z_varname) Bug fix in generation of
11543 (dump_z_table) Bug fix in column headers.
11545 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
11546 page from 29 to 15. Don't set a default for ops[OPS_INIT,
11547 OPS_DONE]. Writes the uninit string when the driver is closed.
11548 (ascii_open_page) Write the init string before the first page.
11549 (output_shorts) Form of main loop changed from `while' to `for'.
11550 Bug fix with overstrikes: the character is printed *after* the
11551 backspace. Eliminated a lot of `& 0xff' modifiers.
11552 (advance_to_left_margin) New function.
11553 (return_carriage, output_lines) Handle left margin.
11555 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
11557 * ascii.c: New option `carriage-return-style'.
11559 * ascii.c: (count_fancy_chars) New function.
11560 (delineate, text_metrics) Use new function; bug fixes regarding
11562 (text_draw) Bug fix with rich text.
11563 (output_string, output_shorts) Reordered.
11564 (output_shorts) Now handles boxchars and some overstrike font
11566 (output_char, return_carriage) New functions.
11567 (output_lines) Now handles overstriking and font changes properly;
11568 some code moved to output_shorts.
11570 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
11573 * ascii.c: New member `debug' in ascii_driver_ext.
11574 (ascii_init_driver, delineate) Uses new member.
11576 Now you can set a vertical height on writing text.
11577 * ascii.c: (delineate) Keeps track of vertical position.
11578 (text_draw) No longer considers fully justified text an internal
11581 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
11583 Tables' titles are drawn; they can have variable height.
11584 * som.c: `som' struct has new member, title_height.
11585 (draw_title) New argument. Moved within file. All caller
11587 (build_target) New argument, amount of space needed for first row.
11588 Calculates height of title, takes that into account. All callers
11590 (dump_plain_table, dump_columnated_table) Took calculation of y1,
11592 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
11594 (dump_columnated_table) Organized for readability.
11595 (dump_page) Makes use of som.title_height.
11597 * som.c: Many comment bug fixes.
11599 * descript.q: (try_name, generate_z_name) Bug fix regarding
11600 generation of Z-score variable names.
11601 * var.h: Removed num from descriptives_proc; all referents removed.
11603 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
11605 * ascii.c: (ascii_line_horz, ascii_line_vert,
11606 ascii_line_intersection) Added debugging code.
11608 Added a descriptive line above each table to describe it.
11609 * command.c: (parse_cmd) Calls som_new_series.
11611 * som.c: New static vars table_num, subtable_num. New `som'
11613 (dump_page) New arguments.
11614 (som_submit_table) Handle new variables.
11616 * som.c, som.h: (som_submit_table) New arguments. All callers
11618 (som_new_series) New function.
11619 (build_target) Makes room for extra line.
11620 (draw_title) New function.
11621 (dump_page) Calls draw_title. Bug fix: doesn't always set
11624 Columnation of tables support.
11625 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
11627 * som.c: Deleted references to fr, lr, ri.
11628 (som_columnate) Bux fix: sets group member of table.
11629 (som_add_options) Function removed.
11630 (dump_table) Split into three functions; extensively reworked.
11632 * descript.q: (dump_z_table) Better output table formatting; added
11633 title support to correspond to som.h changes.
11634 (display) Title support.
11636 * output.h: Added OUTP_T_NONE.
11638 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
11640 * descript.q: Improved handling of Z scores; still not perfect.
11642 * output.h, ascii.c: Added hook for getting em width of current
11645 * som.c: Uses new em-width hook. Added debugging code to
11647 (som_columnate) New argument.
11648 (som_add_options) Removed.
11650 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
11652 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
11653 rules as a property of the table instead of as a property of the
11656 * ascii.c: Added `header' to table of options.
11658 * descript.q: Added even shorter statistic names; modified to work
11659 with new som interface.
11661 * misc.c (blp_getdelim): Bug fix.
11663 * version.c: includes 'conf.h'.
11665 ----------------------------------------------------------------------
11668 version-control: never