1 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
3 Work to get rid of GCC 4.0 warnings, part 1.
5 In many files, change count parameters to parse_variables(),
6 etc. from `int' to `size_t'. Also change related variables and
7 struct members. Also change messages as needed (e.g. %d to %u
8 with cast to unsigned). Also change arithmetic as necessary
9 (e.g. n >= m - 1 to n + 1 >= m).
11 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
14 * q2c.c: (dump_declarations) Generate code for size_t instead of
17 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
19 * output.c: (outp_read_devices) Fix message.
21 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
23 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
24 address is passed to dict_get_vars() from size_t to int to match
27 * modify-vars.c: (validate_var_modification) Ditto.
29 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
31 * dictionary.[ch] Changed cnt from size_t* to int* since that's
32 what it's called as, and on x86_64 machines they're different sizes.
34 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
36 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
38 * lexer.c: (lex_sbc_only_once) New function.
39 (lex_sbc_missing) New function.
41 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
43 * case.h: (case_str) Make it return `unsigned char'.
45 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
47 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
48 subcommands that we didn't support. Fix bug 13911. Fix bug
49 reported by Adam Pierson (COMPRESSED and other subcommands didn't
50 work on SAVE). Refactor all related code.
52 * command.def: Add XEXPORT command.
54 * dictionary.c: (dict_delete_scratch_vars) New function.
56 * get.c: (cmd_get) Fix parsing.
57 (struct save_trns) Removed.
58 (cmd_save_internal) Removed.
60 (do_write_case) Removed.
61 (save_write_case_func) Removed.
62 (save_trns_proc) Removed.
63 (save_trns_free) Removed.
64 (trim_dictionary) Removed.
65 (struct export_proc) Removed.
67 (export_write_case_func) Removed.
68 (export_proc_free) Removed.
69 (enum writer_type) New enum.
70 (enum command_type) New enum.
71 (struct any_writer) New struct.
72 (any_writer_destroy) New function.
73 (parse_write_command) New function.
74 (any_writer_write_case) New function.
75 (parse_output_proc) New function.
76 (output_proc) New function.
79 (struct output_trns) New struct.
80 (parse_output_trns) New function.
81 (output_trns_proc) New function.
82 (output_trns_free) New function.
84 (cmd_xexport) New function.
85 (parse_dict_trim) New function.
86 (struct mtf_proc) Change `by_cnt' member type to `int'.
89 * pfm-write.c: (struct pfm_writer) Add `digits' member.
90 (pfm_writer_default_options) New function.
91 (pfm_open_writer) Add `opts' argument and handle options.
92 (write_float) Write only as many digits as `digits' member says.
93 (format_trig_double) Limit base-10 precision to LDBL_DIG.
95 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
96 (struct pfm_write_options) New struct.
98 * sfm-write.c: (sfm_writer_default_options) New function.
99 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
100 `opts' argument. Implement options.
102 * sfm-write.h: (struct sfm_write_options) New struct.
104 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
105 char *' instead of `char *'.
107 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
109 * factor_stats.c: Needed <config.h> included earlier.
111 * percentiles.c: Needed to include <config.h>.
113 * val.h: Don't include "config.h".
115 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
117 Clean up treatment of missing values by moving all the code into
118 one place. All references to the missing value function were
119 updated, but only major changes are detailed below.
121 * Makefile.am: Add missing-values.c, missing-values.h to sources.
123 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
125 * dictionary.c: (dict_create_var) Initialize `miss' member with
127 (dict_clone_var) Copy `miss' member with mv_copy().
129 * get.c: (mtf_merge_dictionary) Use mv_copy().
131 * missing-values.c: New file.
133 * missing-values.h: New file.
135 * mis-val.c: Rewrite. New version implements updated semantics.
137 * pfm-read.c: (read_variables) Rewrite missing value handling.
139 * pfm-write.c: (write_variables) Rewrite missing value handling.
141 * sfm-read.c: (read_variables) Rewrite missing value handling.
143 * sfm-write.c: (write_variable) Rewrite missing value handling.
145 * sfmP.h: Include "magic.h" to get definition of
148 * sysfile-info.c: (describe_variable) Rewrite missing value
151 * val.h: Include "magic.h" to get definition of
154 * var.h: Include "missing-values.h". Drop MISSING_* enums.
155 (struct variable) Remove `miss_type', `missing'. Add `miss'.
157 * vars-atr.c: (is_num_user_missing) Removed--use
158 mv_is_num_user_missing().
159 (is_str_user_missing) Removed--use mv_is_str_user_missing().
160 (is_system_missing) Removed--use mv_is_value_system_missing().
161 (is_missing) Removed--use mv_is_value_missing().
162 (is_user_missing) Removed--use mv_is_value_user_missing().
164 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
166 Adopt use of gnulib for portability.
168 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
171 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
172 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
175 * In many source files, added an explicit inclusion of gettext.h
176 and definition of _ macro. These are no longer in pref.h because
177 it interfered with definitions in a few gnulib source files.
179 * In many source files, changed #include "bool.h" to #include
180 <stdbool.h>, which is provided by gnulib.
182 * alloc.c: Removed functions defined in gnulib:
187 (out_of_memory) Redefined as wrapper for xalloc_die().
189 * alloc.h: Replace prototypes by #include "xalloc.h".
191 * casefile.c: Use full_read() and full_write() from gnulib instead
192 of our home-grown versions.
194 (full_write) Removed.
196 * getline.c: Renamed getl.c.
198 * getline.h: Renamed getl.h, updated all references.
200 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
203 * glob.c: Just #include <time.h> instead of the crazy rigmarole
205 (init_glob) Call set_program_name() to initial gnulib progname
208 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
210 * permissions.c: Use "stat-macros.h" from gnulib.
212 * postscript.c: Just #include <time.h> instead of the crazy
213 rigmarole here before.
215 * q2c.c: (main) Make generated code #include "gettext.h".
217 * str.h: Get rid of most explicit declarations of standard
218 functions, in favor of including gnulib header files.
220 * expressions/evaluate.c: Ditto.
222 * expressions/operations.h.pl: Make generated code #include
223 <stdbool.h>, not "bool.h".
225 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
227 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
230 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
232 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
233 null pointer to printf for %.*s.
235 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
237 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
240 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
242 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
244 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
246 * postscript.c: (postopen) Cast `char' to `unsigned char' before
247 passing to isspace().
249 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
251 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
253 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
255 * histogram.c: Include <config.h>.
257 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
259 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
261 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
263 * format.c: (check_common_specifier) Fix msg() bug found by
265 (check_output_specifier) Ditto.
267 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
269 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
272 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
274 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
275 avoid "unused variable" warning.
277 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
279 * command.c: (find_word) Cast `char' to `unsigned char' before
280 passing to isspace().
282 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
284 * case.c: (case_compare) Implement as delegating to
285 case_compare_2dict().
287 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
289 * algorithm.c: Inclusion of <alloca.h> is unneeded.
291 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
293 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
294 -ansi changes the behavior of header files significantly. It
295 causes __STRICT_ANSI__ to be defined, and some headers interpret
296 that as cause to e.g. not use `long long' or __attribute__. The
297 former example is bad when off_t is supposed to be `long long',
298 and the latter prevents -Wformat from working.
300 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
302 Get rid of dependency on libgmp by writing our own routine for
303 floating-point base conversion.
305 * pfm-write.c: (write_float) Rewrote.
307 (pow30_nonnegative) New function.
308 (pow30) New function.
309 (trig_to_char) New function.
310 (format_trig_digits) New function.
311 (recurse_format_trig_int) New function.
312 (format_trig_int) New function.
313 (should_round_up) New function.
314 (try_round_up) New function.
315 (format_trig_double) New function.
317 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
319 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
322 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
324 * pfm-read.c: (read_version_data) Read and ignore author field.
326 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
328 * get.c: (mtf_processing) Don't assume that
329 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
330 returns a negative, zero, or positive result. Fixes MATCH FILES
331 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
333 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
335 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
336 preprocessor test for sys/types.h was accidentally inverted. This
339 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
341 * get.c: (cmd_match_files) Fix memory leak on `by' and on
344 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
347 * vfm.c: (close_active_file) Remove unnecessary test.
349 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
351 Fix NDEBUG compile errors.
353 * hash.h: Needed explicit #include <assert.h>.
355 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
358 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
360 Implement embedding for PostScript driver. Fixes bug 12970.
362 * ascii.c: Fix compiler warnings.
366 * chart.h: Add `file' member.
368 * output.h: (struct outp_class) initialise_chart, finalise_chart
369 should take outp_driver *, not outp_class *. Update all
372 * plot-chart.c: (chart_create) Fix segfault when there are no
373 output drivers at all.
374 (chart_submit) Call d->class->finalise_chart.
376 * postscript.c: (ps_open_page) Set cp_y to 0.
377 (ps_submit) New function.
378 (ps_chart_initialise) Implement.
379 (ps_chart_finalise) Implement.
380 (static var postscript_class) Add ps_submit.
381 (static var epsf_class) Add ps_submit.
384 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
386 Did some more work on bug 12859 and then realized that a *good*
387 solution would require some fundamental restructuring. For now,
388 I'm marking REPEATING DATA unimplemented, and then we can revisit
391 * command.def: Make REPEATING DATA unimplemented.
393 * data-list.c: (cmd_repeating_data) Assume inline file is 80
395 (realize_value) Revert previous changes; no longer needed.
398 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
399 file_loc, to avoid bad references later.
403 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
405 Make some code tolerant of reentry. Should not be needed if other
406 code is correct but it is good to be generally tolerant.
408 * error.c: (err_hcf) Set file_loc to null after free().
410 * output.c: (outp_done) Similar changes.
412 * str.c: (ds_destroy) Ditto.
414 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
416 Continue work on bug 12859, plus some code cleanup.
418 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
419 boolean variables. Don't try to compute starts_end, cont_end for
420 inline file. Calculate length only after parsing variable
421 specifications. Add proper transformation to list.
422 (realize_value) If the rpd_num_or_var has no value, return new
423 DEFAULT_MEMBER argument (for use with inline file).
424 (repeating_data_trns_proc) Pass default values.
426 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
427 open, and only if we actually started reading data.
429 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
433 * output.c: (outp_read_devices) Fix message.
435 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
437 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
438 of the sort algorithm from the parser for the SORT command.
440 * rank.q: Added the parser for the RANK command.
442 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
446 * sort.c: (sort_parse_criteria) Only set *saw_direction if
447 saw_direction is non-null. Thanks to John Darrington for
450 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
452 * get.c: (mtf_processing) Handle case of a lookup table as the
453 active file. Thanks to John Darrington for reporting this bug.
455 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
457 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
458 POSIX calloc function.
460 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
461 reflect new signature.
463 * sfm-read.c: Now much more robust in the face of badly formed
466 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
468 *sfm-read.c: Fixed some bugs regarding long string continuation
469 records, which the previous fix uncovered.
471 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
473 * sfm-read.c, sfmP.h: Allow reading of system files when the
474 case_size value in the header is -1. Also changed some Errors to
475 Warnings when reading system files.
477 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
479 * data-list.c: (data_list_trns_free) Don't free the argument
480 because cancel_transformations() will do that itself.
481 (data_list_source_destroy) Destroy the argument to
482 data_list_trns_free(), because it no longer does so itself.
484 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
486 * data-out.c: (format_and_round) Don't output leading `-' if value
489 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
493 * som.c: (output_encodings) If some cell in the table won't fit
494 with the horizontal or vertical headers, cancel those headers.
496 * som.h: (struct som_table_class) Add fits_width, fits_length,
499 * tab.c: (tabi_fits_width) New function.
500 (tabi_fits_length) New function.
501 (tabi_set_headers) New function.
502 (global var tab_table_class) Add the new functions as appropriate
505 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
507 Fix rest of bug 13054.
509 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
510 DATETIME, TIME system/portable file values.
512 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
514 * data-list.c: (parse_free) Use make_input_format().
516 * data-out.c: (num_to_string) Use make_output_format().
518 * dictionary.c: (dict_create_var) Ditto.
520 * format.c: (global var f8_2) New var.
521 (make_input_format) New function.
522 (make_output_format) New function.
524 * get.c: (cmd_match_files) Use make_output_format().
526 * list.q: (cmd_list) Ditto.
528 * matrix-data.c: Ditto.
530 * sfm-read.c: (parse_format_spec) Check output specifier
533 * tab.c: (tab_float) Use make_output_format().
535 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
537 Fix more of bug 13054.
539 * format.def: FMT_A should allow 255-character output. FMT_AHEX
540 should allow 510-character input and output.
542 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
543 (convert_E) Handle non-finite values.
545 (format_and_round) New function.
546 (convert_infinite) New function used by try_F() and convert_E().
548 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
550 Regularize string and buffer function names so that they make some
553 * str.c: (mm_reverse) Rename buf_reverse(). Update all
555 (mm_find_reverse) Rename buf_find_reverse(). Update all
557 (mm_case_compare) Rename buf_compare_case(). Update all
559 (st_compare_pad) Rename buf_compare_rpad(). Update all
561 (str_compare_rpad) New function.
562 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
564 (buf_copy_str_lpad) New function.
565 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
567 (st_pad_copy) Rename str_copy_rpad(). Update all references.
568 (st_trim_copy) Rename str_copy_trunc(). Update all references.
569 (st_uppercase) Renamed str_uppercase(). Update all references.
571 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
573 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
576 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
578 * data-in.c: (data_in) Add assertion to check input specifier.
580 * data-out.c: (data_out) Add assertion to check output specifier.
582 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
584 Start to fix bug 13054.
586 * format.c: (check_input_specifier) Improve error message.
587 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
588 valid decimal places.
589 (check_output_specifier) Ditto (but different criteria).
590 (convert_fmt_ItoO) Assert valid input and output specifiers.
591 Also, if input specifier has *any* decimal places, make the output
592 specifier 1 place wider.
594 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
596 * sysfile-info.c: Fixed bug [# 13024 ]
598 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
600 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
601 actually implement it.
603 * command.c: (FILE_TYPE_okay) Always return 1.
605 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
607 * file-type.c: Add prototypes to get rid of warnings.
609 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
611 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
612 more ISO/IEC 9899:1990 conformance issues.
614 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
616 Fix bug 12948. See also new test in
617 tests/bugs/match-file-scratch.sh.
619 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
620 that deletes scratch variables that someone else might be using,
621 and because we can't reassign our sources' value indexes.
622 Instead, simply don't copy scratch variables into the master
625 * dictionary.c: (dict_compact_values) Delete variables from the
626 dictionary passed in, not from default_dict (!).
628 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
630 Improve hash.c comments, error-checking.
632 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
633 (hsh_create) size == 0 should *not* return NULL! Set
635 (hsh_clear) Set hash_ordered.
636 (locate_matching_entry) Check hash_ordered.
637 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
638 (hsh_data) Set hash_ordered. Add const-ness to return value and
642 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
644 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
646 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
648 * copyleft.c: Updated copyright date.
650 * Makefile.am: Removed erroneous explicit "-lplot"
652 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
654 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
656 * command.c command.def: Added description string for unimplemented commands.
658 * oneway.q: Sorted the hash tables before shipping out the results. Closes
661 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
665 * data-list.c: (parse_fixed) Use lex_end_of_command().
667 (cmd_repeating_data) Set cont_end.num in right situations.
668 (parse_repeating_data) Remove redundant test.
670 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
672 Partial fix for bug 12859.
674 * data-list.c: (cmd_data_list) Add transformation properly in
675 vfm_source == NULL case.
677 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
679 * lexer.c: (lex_error) Improve error messages.
681 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
683 * get.c: (cmd_match_files) Check token type before trying to match
684 tokid. Fixes bug 12923.
686 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
688 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
691 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
693 * expressions/generate.pl: (get_token) Make use of /g
694 backward-compatible with Perl 5.6.1.
696 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
698 * var-display.c: (cmd_variable_alignment) Fix memory leak.
699 (cmd_variable_level) Ditto.
701 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
703 Hash table had buggy deletion function. The fix required changing
704 other functions to do probing in the required order.
706 * hash.c: (locate_matching_entry) Rewrite and change interface.
707 (hsh_rehash) Rewrite to use locate_matching_entry().
710 (hsh_delete) Ditto. Also, fix stupid bugs.
712 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
714 * dictionary.c: (dict_clone) Properly copy vectors.
716 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
718 New implementation of long variable names. Each variable has a
719 "normal" name, which may be up to 64 bytes long and which is used
720 for all normal operations. Variables may have a "short" name,
721 which is limited to 8 bytes and used only for system and portable
722 file input and output.
724 Make tokid case-preserving. Update most uses of tokid to treat it
727 Update many commands to deal with long variable names.
729 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
731 * command.c: (cmd_parse) Ditto.
732 (match_strings) Use toupper() before comparing characters.
733 (conflicting_3char_prefixes) Use mm_case_compare() instead of
735 (cmd_match_words) Ditto.
737 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
740 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
741 Use st_trim_copy() instead of strcpy().
743 * data-in.c: (parse_enum) Use mm_case_compare() instead of
746 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
748 (parse_free) Use st_trim_copy() instead of strcpy().
750 * descript.c: (struct dsc_var) Change z_name[] to fit long var
752 (try_name) Use strcasecmp() instead of strcmp().
753 (generate_z_varname) Use st_trim_copy() instead of strcpy().
754 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
757 * dictionary.c: (struct dictionary) Removed `long_name_tab'
759 (compare_long_names) Removed.
760 (hash_long_name) Removed.
761 (dict_create) Don't initialize `long_name_tab' member.
762 (dict_clone) Copy short names into new dictionary.
763 (dict_clear) Don't clear `long_name_tab' member.
764 (dict_get_varname_block) Removed.
765 (dict_add_longvar_entry) Removed.
767 (dict_destroy) Don't destroy `long_name_tab' member.
768 (dict_create_var_from_short) Removed.
769 (dict_create_var_x) Removed.
770 (dict_create_var) Get rid of longname handling.
772 (dict_clone_var) Get rid of longname parameter and longname
774 (dict_lookup_var) Get rid of longname handling.
775 (dict_reorder_var) New function.
776 (dict_rename_var) Clear short name.
777 (dict_rename_vars) Get rid of longname handling. Clear short
779 (dict_create_vector) Support long vector names.
780 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
781 (quasi_base27) Removed.
782 (make_short_name) Removed.
783 (compare_strings) New function.
784 (hash_string) New function.
785 (dict_assign_short_names) New function.
787 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
789 (get_handle_for_filename) Support long handle names.
791 * file-type.c: (struct col_spec) Make `name' fit long var names.
792 (cmd_file_type) Use strcasecmp() instead of strcmp().
794 * flip.c: (make_new_var) Rewrite.
795 (flip_sink_write) Use st_trim_copy() instead of strncpy().
797 * format.c: (parse_format_specifier_name) Use mm_case_compare()
800 * get.c: (cmd_save_internal) Rephrase.
801 (rename_variables) Drop test for identical variable name.
802 (struct mtf_proc) Change `first', `last' to fit long var name.
804 * hash.c: (hsh_hash_case_string) New function for case-insensitive
807 * lexer.c: (restore_token) Use st_trim_copy() instead of
809 (lex_get) Don't uppercase string when copying into tokid.
810 (lex_put_back_id) Use st_trim_copy() instead of
813 * list.q: (determine_layout) Consider length of variable names in
814 choosing vertical layout.
816 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
818 (string_to_content_type) Ditto.
820 * modify-vars.c: (compare_variables_given_ordering) Ditto.
821 (struct var_renaming) Change `new_name' to fit long var name.
822 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
825 * pfm-read.c: (read_variables) Disallow system variables in system
827 (write_variables) Call dict_assign_short_names() and use
828 short_name[] members.
830 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
833 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
834 map. Reorder variables into same order as long variable map.
835 (read_variables) Set short name.
837 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
838 (write_variable) Use st_bare_pad_copy().
839 (write_longvar_table) Rewrite.
841 * str.c: (mm_case_compare) New function.
843 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
846 * t-test.q: (tts_custom_groups) Remove redundant test.
847 (tts_custom_pairs) Ditto.
849 * var.h: (struct variable) Change `name' to fit long var names.
850 Remove `longname'. Add `short_name' member. Reorder some
852 (struct name_table_entry) Removed.
853 (struct vector) Change `name' to fit long vector names.
855 * vars-atr.c: (var_is_valid_name) Allow long var names.
856 (compare_var_names) Use strcasecmp() instead of strcmp().
857 (compare_var_ptr_names) Ditto.
858 (hash_var_name) Use hsh_hash_case_string().
859 (hash_var_ptr_name) Ditto.
860 (var_set_short_name) New function.
861 (var_clear_short_name) New function.
862 (var_set_short_name_suffix) New function.
864 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
865 Use strcasecmp() instead of strcmp().
866 (struct array_var_set) Removed `longname_tab'.
867 (array_var_set_lookup_var_idx) Drop longname_tab support.
868 (array_var_set_destroy) Don't destroy `longname_tab'.
869 (var_set_create_from_array) Don't create `longname_tab'.
871 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
874 * expressions/parse.c: (word_matches) Use mm_case_compare()
876 (compare_strings) New function.
877 (lookup_function) Use compare_strings() instead of strcmp().
879 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
881 * algorithm.c: (move_element) New function.
883 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
885 * aggregate.c: (parse_aggregate_functions) Always initialize
888 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
890 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
892 * dictionary.c: (dict_clone) Ditto.
893 (dict_clone_var_assert) New function.
895 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
897 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
899 * error.c: Added a string for the compiler version to the
900 request_bug_report_and_abort function.
902 * groff_font.c, font.c: Removed manpage(1) style references from
903 comments, because RMS frowns upon them.
905 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
907 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
909 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
911 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
914 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
916 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
917 which should be LONG_NAME_LEN
919 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
921 * command.def echo.c: Added the ECHO command.
923 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
925 Finish fixing MATCH FILES (bug 11677).
927 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
928 keep_variables(), rename_variables().
929 (drop_variables) New function.
930 (keep_variables) New function.
931 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
932 (cmd_match_files) Deal with in_var. Use drop_variables(),
933 keep_variables(). When IN is specified, require BY. Set master
934 variables after master dictionary is complete. Add IN variables
935 after master dictionary is complete.
936 (mtf_free_file) Free `in_name'.
937 (mtf_delete_file_in_place) Set in_var value to 0.
938 (mtf_read_nonactive_records) Rephrase.
939 (mtf_processing) Support IN. Rephrase. Fix bugs.
940 (mtf_merge_dictionary) Don't set master variables; we do that
942 (get_master) Don't insist that there's a master variable.
944 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
946 Kluge to make some variable renaming sort of work.
949 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
951 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
953 Add functions for comparing sets of variables between cases.
956 * case.c: (case_compare) New function.
957 (case_compare_2dict) New function.
959 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
961 (cmd_aggregate) Nullify break_case. Don't call
962 initialize_aggregate_info().
963 (agr_destroy) Destroy break_case.
964 (aggregate_single_case) Rewrite. Use case_compare().
965 (dump_aggregate_info) Copy from break_case into output.
966 (initialize_aggregate_info) Copy break_case from input.
968 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
970 * vfm.c: (equal_splits) Use case_compare().
972 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
974 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
976 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
978 Start work on fixing MATCH FILES.
980 * get.c: (enum operation) Remove OP_MATCH.
981 (trim_dictionary) Change return value to bool. Don't support
983 (struct mtf_file) Remove `first', `last' members.
984 (struct mtf_proc) Add `first', `last' members. Change mtf_case
985 from `struct ccase *' to `struct ccase'. Remove `by' member.
986 (cmd_match_files) Essentially rewrite.
987 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
988 (mtf_read_nonactive_records) mtf_ parameter is not unused.
989 (mtf_processing) Ditto. Also rephrase some code.
990 (mtf_merge_dictionary) Rewrite for easy comprehension.
992 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
994 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
997 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
999 Thu Apr 14 2005 John Darrington
1001 * var-display.c: New file.
1003 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
1004 display_width, measure and alignment parameters to variables.
1006 * aggregate.c command.def compute.c count.c data-list.c descript.c
1007 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
1008 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
1009 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
1010 vars-prs.c vector.c :
1011 - Replaced literal constants representing maximum variable name
1012 length with macro definitions.
1013 - Added support for long variable names.
1014 - Changed lexer such that it no longer makes tokens upper
1015 case, but relies upon case insensitive behaviour of commands.
1017 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1019 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1020 fails, don't dereference the resulting null pointer (bug 12427).
1021 Also, fix double free error.
1023 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1025 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1026 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1027 (dump_aggregate_info) Only make SUM non-missing if there was at
1030 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1032 * aggregate.c: (dump_aggregate_info) Properly test whether the
1033 destination variable is numeric, when making the result
1034 system-missing for columnwise missing values.
1036 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1038 * misc.h: Remove GCC specializations.
1040 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1042 Make sort stable (bug 12313).
1044 * sort.c: Don't need to include some headers anymore.
1045 (static var min_buffers) New variable.
1046 (static var max_buffers) New variable.
1047 (static var allow_internal_sort) New variable.
1048 (cmd_sort_cases) Add test mode.
1049 (sort_execute) Rephrase.
1050 (do_internal_sort) Don't try internal sorting if
1051 allow_internal_sort is set.
1052 (struct external_sort) Renamed `initial_runs' to `runs' and
1053 updated all references.
1054 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1055 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1056 (macro MIN_BUFFER_SIZE_RECS) Removed.
1057 (compare_initial_runs) Removed.
1058 (struct record_run) Add member `idx'.
1059 (write_initial_runs) Pass increasing values to process_case() as
1061 (process_case) Add `idx' parameter and use it to initialize new
1063 (allocate_cases) Limit allocated buffers to max_buffers.
1064 (compare_record_run) Use new `idx' member for last resort
1065 comparison, for stability.
1066 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1067 running out of file descriptors.
1068 (struct merge_state) Removed.
1069 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1070 unless we have fewer runs left. Always merge consecutive runs,
1071 for stability. Return the final run.
1073 (choose_merge) New function.
1074 (merge_once) Rewritten.
1076 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1078 * cmdline.c: (static var testing_mode) Move into
1079 parse_command_line().
1081 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1083 * algorithm.c: (remove_range) New function.
1084 (remove_element) New function.
1086 * dictionary.c: (dict_delete_var) Use remove_element().
1088 * flip.c: (cmd_flip) Ditto.
1090 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1092 * file-handle.q: (struct file_handle) `open_mode' should not be
1095 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1097 First phase of making SORT CASES stable (bug 12313).
1099 * sort.c: (struct indexed_case) New structure.
1100 (do_internal_sort) Rewrite to make internal sorting stable.
1101 (compare_case_dblptrs) Removed.
1102 (compare_indexed_cases) New function.
1104 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1108 * casefile.c: (casereader_read_xfer_assert) New function.
1110 * dictionary.c: (dict_compact_case) New function.
1112 * flip.c: (struct flip_pgm) New member idx_to_fv.
1113 (cmd_flip) Initialize idx_to_fv member.
1114 (destroy_flip_pgm) Free idx_to_fv member.
1115 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1117 (flip_sink_write) Ditto.
1119 * vfm.c: (write_case) Use dict_compact_case() instead of
1121 (compact_case) Removed.
1122 (storage_source_create) Removed `dict' parameter. All references
1125 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1127 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1130 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1132 More AGGREGATE fixes.
1134 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1135 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1137 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1140 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1142 Start work on testing and debugging AGGREGATE.
1144 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1145 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1146 subcommand mandatory.
1147 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1148 functions' arguments are in the correct order and swap them if
1150 (accumulate_aggregate_info) Make SUM include weights. Add various
1152 (dump_aggregate_info) Add various string functions.
1153 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1155 * sort.c: (sort_parse_criteria) Add parameter for returning
1156 whether any directions were specified. All callers updated.
1158 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1160 * t-test.q: Fixed erroneous logic in compare_group_binary.
1162 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1164 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1165 keywords (bug 11628).
1167 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1169 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1170 called *before* close_active_file().
1172 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1174 * file-handle.q: (struct file_handle) Change open_mode from
1175 character pointer to 3-char array, for safety. Updated all
1178 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1180 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1183 * pfm-read.c: (read_header) Improve error message for many cases
1184 in which the input is not actually a portable file.
1186 * file-handle.q: (fh_open) When we give an error message, actually
1189 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1191 * format.c: (check_common_specifier) New function for checks
1192 common to check_input_specifier() and check_output_specifier().
1193 (check_input_specifier) Use check_common_specifier().
1194 (check_output_specifier) Use check_common_specifier().
1195 (check_string_specifier) Removed.
1196 (check_specifier_type) New function.
1197 (check_specifier_width) New function.
1198 (get_format_var_width) Fix bug.
1200 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1202 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1203 update all references. Make case-insensitive.
1205 * pfm-read.c: Essentially rewrite the whole file. Now much
1208 * print.c: (check_string_width) New function.
1209 (fixed_parse_compatible) Use check_string_width(),
1210 check_specifier_type().
1211 (dump_fmt_list) Ditto.
1213 * str.c: (st_trim_copy) New function.
1214 (st_uppercase) New function.
1216 * vars-atr.c: (var_is_valid_name) New function.
1218 * expressions/parse.c: (type_coercion_core) Use
1219 check_specifier_type().
1221 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1223 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1225 * expressions/parse.c: (no_match) Ditto.
1227 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1229 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1231 * expressions/helpers.c: (struct func_params) Removed.
1232 (generalized_idf) Removed.
1235 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1237 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1238 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1239 Implement SIG.F, which I had overlooked previously.
1241 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1243 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1244 available only in testing mode.
1246 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1248 * data-in.c: Use `bool' throughout, where relevant.
1250 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1252 DATA LIST with free-field formats should not have implied decimal
1253 places (bug 12035). Also clean up data-in.c a bit.
1255 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1257 * data-in.c: (apply_implied_decimals) New function.
1258 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1259 set. Also, get rid of gotos.
1260 (parse_Z) Use apply_implied_decimals() if the field doesn't
1261 contain a decimal point.
1262 (parse_N) Use apply_implied_decimals().
1268 (parse_enum) New function.
1269 (macro CHAR_IS_ROMAN) Removed.
1270 (macro ROMAN_VALUE) Removed.
1271 (parse_month) Use parse_enum().
1272 (parse_weekday) Use parse_enum().
1273 (parse_DATETIME) Use long for weekday.
1275 * data-list.c: (read_from_data_list_fixed) Use
1276 DI_IMPLIED_DECIMALS.
1278 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1280 When the lexer sees something like `-5' in the input, it has to
1281 decide whether it's a negative numeric constant token or a '-'
1282 token followed by a positive numeric constant token. It always
1283 decides on the former, and then the parser can call
1284 lex_negative_to_dash() if it wants the latter. However, this
1285 doesn't work for the case of `-0', because negative zero is
1286 (portably) indistinguishable from positive zero. So now we divide
1287 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1288 distinction clear. This requires a little bit of extra effort,
1289 because there were several references to T_NUM in the code base.
1291 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1292 positive and negative numeric constants.
1293 (lex_double_p) Renamed lex_is_number(). Changed return type to
1294 bool. Updated all relevant references to T_NUM to instead use
1296 (lex_double) Renamed lex_number(). All references updated.
1297 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1298 bool. All references updated.
1299 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1300 (lex_negative_to_dash) Ditto.
1303 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1305 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1307 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1309 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1311 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1312 values as system-missing.
1314 * expressions/parse.c: (parse_vector_element) Fix order of
1315 arguments in call to expr_allocate_binary().
1317 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1319 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1322 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1323 failure, as indicated by function comment.
1324 (parse_binary_operators) Always return NULL on type_coercion()
1325 failure. Should have been doing this anyway, but bug in
1326 type_coercion_core() filtered through.
1327 (parse_add) Fix typo in user message.
1328 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1330 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1332 * expressions/operations.def: Add VALUE function.
1334 * expressions/parse.c: (parse_function) Need an unary composite
1335 node for variables in A TO B, not a variable node. Use
1336 allocate_unary_variable().
1337 (parse_primary) Use allocate_unary_variable().
1338 (allocate_unary_variable) New function.
1340 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1342 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1343 but fixed the real problem that was preventing the build from a
1344 separate directory. I liked it my way better ;-)
1346 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1348 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1349 John Darrington <john@darrington.wattle.id.au> for reporting this
1352 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1354 * expressions/Makefile.am expressions/evaluate.h.pl
1355 expressions/evaluate.inc.pl expressions/operations.h.pl
1356 expressions/optimize.inc.pl expressions/parse.inc.p:
1358 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1361 Fixed everything so that it can be built from an arbitrary
1364 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1366 * Makefile.am : Fixed up CLEANFILES target.
1368 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1370 * str.h: Changed `struct len_string' to `struct fixed_string', a
1371 more accurate name. Updated all references.
1373 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1375 Redo calendar support. Should now be bug-for-bug compatible.
1377 * calendar.c: New file.
1379 * calendar.h: New file.
1381 * data-in.c: Use new calendar functions.
1382 (parse_sign) Change sense of return value.
1383 (calendar_error) New function.
1384 (ymd_to_ofs) New function.
1385 (ymd_to_date) New function.
1386 (parse_DATE) Use new function.
1387 (parse_ADATE) Ditto.
1388 (parse_EDATE) Ditto.
1389 (parse_SDATE) Ditto.
1390 (parse_JDATE) Ditto.
1395 (parse_DTIME) Ditto.
1396 (parse_DATETIME) Ditto.
1398 * data-out.c: (convert_date) Use new calendar functions.
1400 * error.c: (err_vmsg) Changed interface to be more sensible.
1401 Updated all callers.
1402 (dump_message) Don't double new-lines (why did we do this
1405 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1407 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1408 (macro FLT64_MAX) Moved here from pref.h.orig.
1410 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1412 * set.q: Support SET EPOCH.
1413 (static var set_epoch) New var.
1414 (aux_stc_custom_epoch) New function.
1415 (stc_custom_epoch) New function.
1416 (get_epoch) New function.
1417 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1419 * format.c: Make it possible just to check whether a specifier is
1420 valid without emitting an error message.
1421 (parse_format_specifier_name) Change interface, update all
1423 (check_input_specifier) Ditto.
1424 (check_output_specifier) Ditto.
1425 (parse_format_specifier) Ditto.
1427 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1429 * command.def: Add DEBUG POOL.
1431 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1433 (pool_clear) Properly account for size of pool gizmo.
1434 (pool_realloc) Ditto.
1435 (pool_clone) New function.
1437 * pool.h: Mark our allocation functions MALLOC_LIKE.
1439 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1441 * Makefile.am: Move many definitions into new top-level
1442 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1443 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1446 * case.c: (case_resize) New function.
1447 (case_swap) New function.
1449 * casefile.c: Include mkfile.h.
1451 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1453 * sfm-read.c: Fixed a buglet which caused a crash when trying
1454 to read a non-existent file.
1456 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1460 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1461 Important part: get rid of spurious copying of function->format to
1462 destvar->print and destvar->write.
1464 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1466 Fix bug 11916, which was confusing a variable's `index' member
1467 with the variable's position in a var_set. Although these are
1468 usually the same, they are not for array `var_set's.
1470 Took advantage of this bug as an opportunity to clean up and
1471 rewrite parse_var_set_vars().
1473 * vars-prs.c: (parse_vs_variable_idx) New function.
1474 (parse_vs_variable) Reimplement in terms of
1475 parse_vs_variable_idx().
1476 (parse_var_idx_class) New function.
1477 (add_variable) New function.
1478 (add_variables) New function.
1479 (parse_var_set_vars) Rewritten.
1480 (struct var_set) Change `lookup_var' member that returns a
1481 variable into `lookup_var_idx' member that returns an int.
1482 Updated the var set implementations in obvious corresponding ways.
1483 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1485 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1487 Use our global variable compare & hash functions and give them
1488 better names. Add similar functions for dealing with double
1489 pointers to variables.
1491 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1492 (hash_variable) Renamed hash_var_name().
1493 (compare_var_ptr_names) New function.
1494 (hash_var_ptr_name) New function.
1496 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1498 (compare_var_name) Removed.
1499 (hash_var_name) Removed.
1501 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1505 * dictionary.c: (compare_variable_dblptrs) Rename
1506 compare_var_ptrs() and fix it to properly dereference the double
1509 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1511 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1512 declare subcommands as mandatory. Closed bug #11843
1514 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1516 * getline.c command.[ch] command.def: Added (very rudimentary)
1517 support for line completion when in interactive mode. Partially
1518 addresses bug #11693
1520 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1522 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1523 problems revealed by valgrind.
1526 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1528 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1529 whether or not PAGER is set.
1531 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1533 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1534 "invalid free" errors. Hopefully fixes bug #11722
1536 * compute.c expr-prs.c: Check that lvalues are populated before
1537 attempting to destroy them. Closes bug #11676
1539 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1541 * aggregate.c: Initialised the complete agr_proc structure.
1545 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1547 * print.c: (print_trns_free) Close the dfm writer if there is one,
1548 fixing a memory leak.
1550 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1552 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1556 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1558 * linked-list.[ch] Added
1560 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1561 set.q: Yet more memory leaks
1563 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1565 * t-test.q examine.q : More memory leaks fixed.
1567 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1569 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1572 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1574 * ascii.c cartesian.c casefile.c chart.h devind.c
1575 examine.q frequencies.q
1576 html.c output.h piechart.c plot-chart.c plot-hist.c
1578 Integrated the chart rendering into the output stream
1579 (currently only works for html).
1581 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1582 dummy-chart.c for compiling without charts.
1584 * mkfile.[ch] Created.
1586 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1587 Added type element so we can tell if it's a chart or a table.
1589 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1590 API of charts to be more like that of tables.
1592 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1594 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1595 main.c. Removed the handler for SIGQUIT.
1597 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1599 * casefile.c: Added a signal handler to delete temp files on
1602 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1604 * command.def Added a lot more unimplemented commands.
1606 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1608 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1610 * sort.c: (compare_initial_runs) Needed additional level of
1612 (merge_once) Fix plenty of stupid mistakes.
1614 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1616 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1617 calling casefile_to_disk() or we will lose the last block in the
1618 file if the casefile started out as disk-based.
1619 (casefile_get_reader) Initialize reader->destructive to 0.
1620 (cmd_debug_casefile) Add new test pattern.
1621 (test_casefile) Define new test pattern to make sure
1622 casefile_sleep() works properly.
1624 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1626 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1627 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1628 attempt to seperate the creation and processing of charts from their
1631 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1634 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1636 * main.c Added a signal handler for SIGFPE
1638 * sort.c Somewhat more robust fix to the previous entry.
1640 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1642 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1643 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1644 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1647 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1649 * case.h Fixed bug # 11307
1651 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1653 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1656 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1658 * pfm-read.c: (read_variables) Remove direct manipulation of
1659 v->aux, which is no longer needed. Fixes bug 11483.
1661 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1663 * data-list.c Fixed a bug in parsing delimiters.
1665 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1668 * percentiles.c Properly handled calculation of Tukey hinges where
1669 the number of data is small.
1671 * oneway.q Used the generic value_to_string function for independent
1672 variable instead of trying to do it ourselves.
1674 * box-whisker.c Fixed a buglet which caused a crash if the number of
1678 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1680 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1682 * percentiles.c Fixed some bugs when calculating percentiles when
1683 there's a small number of cases.
1685 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1687 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1689 * examine.q factor_stats.[ch] Added calculation of percentiles
1691 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1693 * t-test.q Fixed bug #11227 Made t-test work when the independent
1696 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1698 * factor_stats.c Fixed calculation of trimmed mean under various
1701 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1703 * histogram.c chart.[ch] factor_stats.c frequencies.q
1705 Added code to calculate sensible histogram ranges and limits.
1707 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1709 * chart.h Updated to reflect many API changes.
1711 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1712 cartesian.c and into chart.c
1714 * factorstats.[ch] Added the histogram calculations
1716 * casefile.c Removed an unused variable.
1718 * frequencies.q examine.q histogram.c Reworked the API for
1721 * piechart.c Revised the API for piecharts.
1723 * var.h Moved the definitions of freq_tab and freq out of var.h
1724 and into frequencies.q where they belong.
1726 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1728 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1729 using AC_TYPE_OFF_T.
1731 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1733 * flip.c: (flip_file) If fseeko() is not available, use long int
1734 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1735 reporting the problem.
1737 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1739 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1740 conflict with stdio.
1742 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1744 * var-labs.c (var_to_string) Now returns null if the variable is null
1746 * value-labels.c (value_to_string) Made it return null if either the
1747 value or the variable is null.
1749 * hash.c (hsh_clear) Fixed a buglet.
1751 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1752 with the wrong model.
1754 * casefile.[ch] Added a function to return the casereader.case_idx
1757 * examine.q Implemented the extreme values results.
1759 John Darrington <john@darrington.wattle.id.au>
1761 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1762 output.[ch] getline.c
1764 Plugged some memory leaks
1766 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1768 Adopt GSL random number generators, paving the way for providing
1769 the complete suite of random number generators on expressions.
1771 * Makefile.am: Remove random.c, random.h.
1773 * random.c: Removed.
1775 * random.h: Removed.
1777 * algorithm.c: (algo_default_random) Use GSL functions.
1779 * casefile.c: (test_casefile) Use GSL RNG functions.
1781 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1784 * sample.c: (cmd_sample) Use GSL RNG functions.
1785 (sample_trns_proc) Ditto.
1787 * set.q: (static var set_seed) Removed.
1788 (static var seed_flag) Removed.
1789 (static var rng) New variable.
1790 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1791 (stc_custom_seed) Use new seed functions.
1792 (seed_is_set) Removed.
1793 (get_rng) New function that composes the entire external
1795 (set_rng) New function.
1796 (random_seed) New function.
1798 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1800 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1801 John Darrington <john@darrington.wattle.id.au> for reporting this
1804 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1806 * permissions.c command.def Added the PERMISSIONS command
1808 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1810 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1811 output file because that will precede #include <config.h>, which
1813 (main) Add needed headers to /* (header) */ code.
1815 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1817 Instead of making system or portable file readers responsible for
1818 dropping and reordering variables, make them read full cases and
1819 let the caller take care of any changes.
1821 * get.c: New "case map" structure to handle this. Use for GET,
1822 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1824 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1825 changed appropriately.
1827 * sfm-read.c: (sfm_read_case) Ditto.
1829 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1831 Decided that case_serialize() and case_unserialize() were too
1832 abstract. Also we need a couple more functions to avoid excessive
1833 copying for data in/out fast paths.
1835 * case.c: (case_serial_size) Removed.
1836 (case_serialize) Rename case_to_values() and make its argument
1837 explicitly an array of union values.
1838 (case_unserialize) Rename case_from_values() and make its argument
1839 explicitly an array of union values.
1840 (case_data_all) New function.
1841 (case_data_all_rw) New function.
1843 * casefile.c: (struct casefile) Change buffer from array of
1844 unsigned char to array of union value for better accuracy.
1845 Redefine buffer_used and buffer_size in terms of values, not
1846 bytes. Remove case_size because it is now redundant with
1847 value_cnt. Fix up all references to these members.
1849 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1851 * barchart.c: (struct subcat) Make `label' member const to silence
1852 GCC warning with -Wwrite-strings.
1854 * cartesian.c: (struct dataset) Ditto.
1856 * case.c: Don't re-define NDEBUG if already defined.
1857 Add lots of comments.
1859 * str.c: Fix includes.
1861 * crosstabs.q: Fix includes.
1863 * examine.q: Fix includes. Fix GCC warning about unused
1866 * frequencies.q: (stat macro) Removed and replaced where used by
1869 * list.q: Fix includes.
1871 * oneway.q: Fix includes.
1873 * piechart.c: Fix includes. Only define M_PI if not already
1876 * sfm-read.c: (bswap) New function.
1877 (bswap_int32) Write in terms of bswap.
1878 (bswap_flt64) Ditto.
1880 * str.c: (ds_data) Add external definition here, needed because
1881 str.h has only an `extern inline' version.
1883 * value-labels.c: Fix includes.
1885 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1887 Instead of providing a system or portable file writer with a raw
1888 case in the format needed for output, provide it with a regular
1889 case. The writer takes care of any needed translation.
1891 * aggregate.c: Adopt new scheme for AGGREGATE.
1892 (struct agr_proc) sfm_agr_case member removed.
1893 (write_case_to_sfm) Removed because the new interface is easier to
1896 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1898 * pfm-write.c: Implement new scheme.
1900 * sfm-write.c: Ditto.
1902 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1904 Instead of treating `struct file_handle' as a class to subclass
1905 into data files, system files, and portable files, instead use it
1906 as a helper that coordinates access. Now it is opaque, too.
1908 This means that most references to a struct file_handle are now
1909 changed into references to one of struct dfm_reader, struct
1910 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1911 pfm_reader, or struct pfm_writer, according to what's being read
1914 Most related changes are only worth summarizing briefly.
1916 * dictionary.c: (dict_clear) Destroy aux data in deleted
1918 (dict_clear_aux) New function.
1919 (dict_create_var) Initialize aux, aux_dtor.
1920 (dict_delete_var) Destroy aux data in deleted variable.
1922 * file-handle.h: (struct fh_ext_class) Removed.
1923 (struct file_handle) Removed.
1924 (fh_init_files) Removed.
1926 * file-handle.q: Changed references to a handle's `private' member
1927 to direct references.
1928 (struct private_file_handle) Renamed file_handle.
1929 Add next, open_cnt, type, open_mode, aux members.
1930 (struct file_handle_list) Removed.
1931 (extern var inline_file) Removed.
1932 (static var file_handles) Changed from file_handle_list * to
1934 (create_file_handle) Initialize new members.
1935 (fh_close_handle) Removed.
1936 (mode_name) New function.
1937 (fh_open) New function.
1938 (fh_close) New function.
1939 (fh_parse_file_handle) Renamed fh_parse().
1941 * glob.c: (init_glob) Remove fh_init_files() call.
1943 * aggregate.c: use sfm_writer.
1944 (create_sysfile) Removed because the new interface is simpler.
1946 * apply-dict.c: Use sfm_reader.
1948 * data-list.c: Use dfm_reader.
1950 * file-type.c: Use dfm_reader.
1952 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1954 * inpt-pgm.c: Use dfm_reader.
1956 * print.c: Use dfm_writer.
1958 * sysfile-info: Use sfm_reader.
1960 * dfm-read.c: Adopt new file handle infrastructure.
1962 * dfm-write.c: Ditto.
1964 * pfm-read.c: Ditto.
1966 * pfm-write.c: Ditto.
1968 * sfm-read.c: Ditto.
1970 * sfm-write.c: Ditto.
1972 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1974 Break dictionary functions into separate header file.
1976 * dictionary.h: New file.
1978 * var.h: Moved dict_*() functions to dictionary.h.
1980 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1982 Get rid of procedure-specific union in struct variable, using
1983 instead a void * pointer and a destructor function.
1985 Most related changes are only worth brief summaries.
1987 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1988 old p.crs member in struct variable.
1990 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1991 of old p.frq member in struct variable.
1993 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1994 it's no longer possible to grab this from var->p.frq.
1996 * piechart.c: (draw_piechart) Ditto.
1998 * group.c: (group_proc_get) New function.
2000 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
2007 * main.c: (execute_command) Clear aux data in default_dict after
2008 each command. (It's debatable whether this should be done.)
2010 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
2011 member in struct variable.
2013 * means.q: Get rid of integer mode, which is not included in
2014 recent SPSS and was the only code that wanted per-variable private
2017 * var.h: (struct crosstab_proc) Removed.
2018 (struct frequencies_proc) Removed.
2019 (struct list_proc) Removed.
2020 (struct get_proc) Removed.
2021 (struct means_proc) Removed.
2022 (struct matrix_data_proc) Removed.
2023 (struct match_files_proc) Removed.
2024 (lots of enums) Removed.
2025 (struct variable) Removed members `p', `get'. Add member
2028 * vars-atr.c: (var_attach_aux) New function.
2029 (var_detach_aux) New function.
2030 (var_clear_aux) New function.
2031 (var_dtor_free) New function.
2032 (discard_variables) Use NULL instead of inline_file.
2034 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2036 * value-labs.c Fixed the implmentation of value_to_string, so
2037 that it properly handles alpha values.
2039 * oneway.q Changed instances where labels were being probed manually,
2040 to use the canonical {var,value}_to_string functions
2042 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2044 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2045 plots. Changed the API of the cartesian plot to be a much lower level
2048 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2050 * examine.q Added some of the parametric calculations
2052 * factor_stats.[ch] Created
2054 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2056 * examine.q Changed the definition of factors to be a composite, and
2057 dealt with the consequences.
2059 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2061 * examine.q Fixed problem where examine wasn't dealing properly with
2064 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2066 * oneway.q Fixed problem where oneway wasn't dealing properly with
2069 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2071 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2072 command which had settings didn't get the appropriate code
2075 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2076 to convert variables/values to strings.
2078 * examine.q Added framework for the EXAMINE command.
2080 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2082 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2083 subcommand types. Changed frequencies.q to use it rather then the
2084 custom parser. Dealt with the consequences. Added a test for NTILES
2085 subcommand of frequencies.
2087 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2089 * oneway.q Fixed up the behaviour when given missing values
2091 * levene.c oneway.q Fixed a buglet with the levene statistic and
2092 incorporated the levene test into the oneway command.
2094 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2095 global scope, since they're only relevant to T-TEST
2097 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2099 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2101 Made the t-test more consistent
2102 with the way it handles groups. That is, it now uses a hash instead
2103 of an array of 2. Also, made the levene.c file independent of the
2104 implementation of the t-test. So now levene should be fine for both
2107 * Added an oneway.q file for one way anova
2109 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2111 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2114 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2118 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2119 (data_list_trns_free) Free dls->delims.
2121 * t-test.q: (tts_custom_pairs) Free vars.
2122 (ssbox_one_sample_init) Fix tab_vline() argument.
2123 (ssbox_independent_samples_init) Ditto.
2124 (trbox_paired_init) Ditto.
2125 (trbox_one_sample_init) Ditto.
2127 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2129 Generalize casefiles to the extent that we can use them for
2130 sorting and other kinds of data transformations. Change cases to
2131 be copy-on-write to improve memory efficiency in common cases.
2132 Every access to a member of a `struct ccase' was changed to be a
2133 call to a case_*() function, especially case_data(), case_num(),
2134 case_str(), or case_data_rw(). Many instances of a local variable
2135 named "case_num" were changed to "case_idx" as a consequence.
2136 Many `struct ccase *' were changed to actual `struct ccase'
2137 because of copying semantics of cases. In several places there
2138 was a choice between updating debug code to work with the new ADTs
2139 or just deleting it because it was useless; I chose to delete it.
2141 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2147 * aggregate.c: (struct agr_proc) Change type of `sort' to
2148 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2149 Rename `vars' to `agr_vars', all references updated. Change
2150 `agr_case' to type `struct ccase'.
2151 (cmd_aggregate) Deal with new members. Use case_create(),
2152 sort_active_file_in_place(), sort_active_file_to_casefile().
2153 (agr_destroy) Deal with new members.
2154 (aggregate_single_case) Ditto.
2155 (dump_aggregate_info) Ditto.
2156 (initialize_aggregate_info) Ditto.
2157 (agr_to_active_file) Ditto.
2158 (presorted_agr_to_sysfile) Ditto.
2159 (sort_agr_to_sysfile) Removed.
2161 * alloc.c: (out_of_memory) Make non-static.
2163 * alloc.h: Prototype out_of_memory().
2165 * casefile.c: Switched from a linked list in-memory representation
2166 to a two-level array-style representation. The linked list was
2167 appropriate when we could stick a header onto cases, but that's no
2168 longer the case. Also, the two-level array will allow for random
2169 in-memory access in case that's ever wanted. Also added the
2170 concept of a `destructive casereader', one that destroys cases in
2171 the underlying casefile as they are read out.
2172 (macro CASES_PER_BLOCK) New macro.
2173 (struct casefile) New members `value_cnt', `case_list_size',
2174 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2176 (struct casereader) Removed `cur'. Added `destructive', `c'.
2177 (global var casefiles) Made static.
2178 (static var case_bytes) New var.
2179 (casefile_create) Takes a value count, not a case size in bytes,
2180 to conform to the case interface. All callers updated. Deal with
2181 new and removed members.
2182 (casefile_destroy) Deal with new and removed members.
2183 (casefile_sleep) New function.
2184 (casefile_get_case_size) Removed.
2185 (casefile_get_value_cnt) New function.
2186 (casefile_append) Rewritten to deal with new and removed members.
2187 (casefile_append_xfer) New function.
2188 (write_case_to_disk) Use case_serialize().
2189 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2190 Couldn't figure out why.
2191 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2192 deal with new and removed members.
2194 (merge_sort) Removed.
2195 (casefile_sort) Removed.
2196 (casefile_get_reader) Deal with new and removed members.
2197 (casefile_get_destructive_reader) New function.
2198 (reader_open_file) Make code more readable. Create case for
2200 (casereader_get_casefile) New function.
2201 (casereader_read) Deal with new and removed members. Now returns
2202 a copy of the case, so that the caller is responsible for
2203 destroying the returned case.
2204 (casereader_read_xfer) New function.
2205 (casereader_destroy) Destroy reader's case.
2206 (test_casefile) Second arg is now a value count, all callers
2207 updated. Now tests destructive readers too.
2208 (get_random_case) Deal with new case ADT.
2209 (write_random_case) Ditto.
2210 (read_and_verify_random_case) Ditto.
2212 * crosstabs.q: Remove debug code.
2214 * descript.q: (calc_descriptives) Deal with new case, casefile
2217 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2219 * do-if.c: Remove unneeded header inclusion.
2221 * expr-prs.c: Remove debug code.
2223 * exprP.h: Remove debug code.
2225 * flip.c: (flip_file) Use fseeko() if available.
2227 * formats.c: Remove debug code.
2229 * get.c: Remove debug code.
2230 (struct mtf_file) Change `input' from `union value *' to `struct
2231 ccase', all references updated.
2233 * levene.c: (levene) Deal with new case, casefile ADTs.
2235 * list.q: Remove debug code.
2237 * loop.c: Remove debug code.
2239 * matrix-data.c: Remove debug code.
2241 * means.q: Remove debug code.
2243 * mis-val.c: Remove debug code.
2245 * pfm-read.c: Remove debug code.
2246 (pfm_read_code) Change second arg from `union value *' to `struct
2247 ccase *', all references updated.
2249 * recode.c: (string_to_long) Make first arg const.
2250 (convert_to_double) Ditto.
2252 * repeat.c: Remove debug code.
2254 * sample.c: Remove debug code.
2256 * sfm-read.c: Remove debug code.
2257 (sfm_read_case) Change second arg from `union value *' to `struct
2260 * sort.c: Redone in terms of casefiles.
2261 (enum sort_direction) Moved here from sort.h.
2262 (struct sort_criterion) New structure.
2263 (struct sort_criteria) New structure.
2264 (cmd_sort_cases) Rewritten.
2265 (prepare_to_sort_active_file) New function.
2266 (sort_active_file_in_place) New function.
2267 (sort_active_file_to_casefile) New function.
2268 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2269 changed, all callers updated.
2270 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2271 rewritten & interface changed, all callers updated.
2272 (sort_cases) Renamed sort_execute(), rewritten & interface
2273 changed, all callers updated.
2274 (struct internal_sort) Removed.
2275 (do_internal_sort) Rewritten, interface changed.
2276 (destroy_internal_sort) Removed.
2277 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2278 (struct initial_run) Removed; an initial run is now just a
2280 (compare_initial_runs) Rewritten.
2281 (struct external_sort) Changed almost completely.
2282 (do_external_sort) Rewritten, interface changed.
2283 (destroy_external_sort) Rewritten.
2284 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2285 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2286 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2287 (init_external_sort) Removed.
2288 (simulate_error) Removed.
2289 (rmdir_temp_dir) Removed.
2290 (get_temp_file_name) Removed.
2291 (open_temp_file) Removed.
2292 (close_temp_file) Removed.
2293 (remove_temp_file) Removed.
2294 (write_temp_file) Removed.
2295 (read_temp_file) Removed.
2296 (struct record_run) Change `record' from `struct case_lit *' to
2298 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2299 `file_idx', `output_file'. Add `run', casefile'. Change
2300 `last_output' from `struct case_list *' to `struct ccase'.
2301 (write_initial_runs) Change interface, rewrite.
2302 (sort_sink_write) Renamed process_case(), changed interfaced,
2304 (destroy_initial_run_state) Rewritten.
2305 (allocate_cases) Rewritten.
2306 (compare_record) Interface changed, rewritten.
2307 (start_run) Rewritten.
2308 (end_run) Rewritten.
2309 (output_record) Rewritten.
2310 (grab_case) Removed.
2311 (release_case) Removed.
2312 (struct merge_case) Change `cases' from double pointer to single
2314 (merge) Deal with new case and casefile ADTs.
2315 (struct run) Removed.
2316 (merge_once) Rewritten, interface changed.
2317 (fill_run_buffer) Removed.
2318 (sort_sink_make_source) Removed.
2319 (sort_sink_class) Removed.
2320 (struct sort_source_aux) Removed.
2321 (sort_source_read_helper) Removed.
2322 (sort_source_read) Removed.
2323 (read_sort_output) Removed.
2324 (read_internal_sort_output) Removed.
2325 (read_external_sort_output) Removed.
2326 (sort_source_destroy) Removed.
2327 (sort_source_class) Removed.
2329 * sort.h: (struct sort_cases_pgm) Removed.
2330 (enum sort_direction) Moved to sort.c.
2332 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2334 * tab.c: Remove debug code.
2336 * var-labs.c: Remove debug code.
2338 * var.h: (struct ccase) Removed.
2339 (struct case_list) Removed.
2341 * vars-atr.c: (discard_variables) Use free_case_source().
2343 * vars-prs.c: (parse_vs_variable) Make arg const.
2344 (parse_dict_variable) Ditto.
2345 (parse_variables) Make struct dictionary * arg const.
2346 (parse_var_set_vars) Make struct var_set * arg const.
2347 (struct var_set) Add const to some of the function pointers' args.
2348 (var_set_get_cnt) Make arg const.
2349 (var_set_get_var) Make first arg const.
2350 (var_set_lookup_var) Make first arg const.
2351 (dict_var_set_get_cnt) Make arg const.
2352 (dict_var_set_get_var) Make first arg const.
2353 (dict_var_set_lookup_var) Make first arg const.
2354 (var_set_create_from_dict) Make arg const. Add cast to aux
2356 (struct array_var_set) Add const to var member.
2357 (array_var_set_get_cnt) Make arg const.
2358 (array_var_set_get_var) Make first arg const.
2359 (array_var_set_lookup_var) Make first arg const.
2360 (var_set_create_from_array) Make first arg const. Insert cast.
2362 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2363 members from `struct ccase *' to `struct ccase'.
2364 (static var lag_queue) Change from double to single pointer.
2365 (procedure) Optimize trivial case.
2366 (internal_procedure) Deal with changed case, case_source ADTs.
2367 (create_trns_case) Changed interface, rewrote.
2368 (open_active_interface) Initialize modified lag queue.
2369 (write_case) Deal with changed case ADT.
2370 (lag_case) Deal with modified lag queue.
2371 (close_active_file) Destroy modified lag queue.
2372 Deal with changed case_source, case_sink ADTs.
2373 (destroy_storage_stream_info) Make null arg into no-op.
2374 (storage_sink_make_source) Set aux in created source.
2375 (storage_source_read) Deal with changed case, casefile ADTs.
2376 (storage_source_create) New function.
2377 (lagged_case) Rewrite.
2378 (free_case_source) New function.
2379 (free_case_sink) Rewrite.
2380 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2382 (procedure_with_splits) Deal with changed prev_case.
2383 (procedure_with_splits_callback) Ditto.
2384 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2386 (multipass_procedure_with_splits) Deal with changed prev_case.
2387 (multipass_split_callback) Ditto.
2390 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2392 The workspace idea didn't work out.
2394 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2396 * workspace.c: Removed.
2398 * workspace.h: Removed.
2400 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2402 Fully implement arbitrary delimiters on DATA LIST, extending the
2403 half implementation that was already there.
2405 * data-list.c: (struct data_list_pgm) Remove `delim', add
2406 `delims', `delim_cnt'.
2407 (cmd_data_list) Initialize new members. Parse delimiters and
2408 clean up code a bit.
2409 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2410 handling of leading commas.
2411 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2413 (read_from_data_list_free) Adapt to new DFM interfaces.
2414 (read_from_data_list_list) Ditto.
2415 (repeating_data_trns_proc) Ditto.
2417 * dfm.c: Split up reader and writer into separate code, because
2418 they do different things. Use struct string instead of explicit
2419 allocation code, for clarity.
2420 (enum dfm_reader_flags) New enum.
2421 (struct dfm_fhuser_ext) Removed.
2422 (struct dfm_reader_ext) New.
2423 (get_reader) New function, used by just about all the reader
2425 (dfm_close) Removed.
2426 (close_reader) New function.
2427 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2428 (dfm_open_for_writing) Ditto.
2429 (macro force_line_buffer_expansion) Removed.
2430 (count_tabs) Removed.
2431 (tabs_to_spaces) Removed.
2432 (read_record) Deal with new dfm_reader_ext. Use struct string
2433 functions. Don't convert tabs to spaces.
2434 (dfm_eof) New function.
2435 (dfm_get_record) Changed interface, rewrote.
2436 (dfm_expand_tabs) New function.
2437 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2438 dfm_reader_ext, rewritten.
2439 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2440 dfm_reader_ext, rewritten.
2441 (dfm_set_record) Removed in favor of dfm_forward_columns().
2442 (dfm_forward_columns) New function.
2443 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2444 dfm_reader_ext, rewritten.
2445 (static var dfm_r_class) Use close_reader for the destructor.
2446 (struct dfm_writer_ext) New.
2447 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2448 bounce buffer now instead of local allocation.
2449 (close_writer) New function.
2450 (static var dfm_writer_ext) Use close_writer for destructor.
2451 (cmd_begin_data) Adapt to new dfm_reader_ext.
2453 * file-handle.q: Add support for per-file tab width.
2454 (struct private_file_handle) Add tab_width member.
2455 (q2c specifications) Add tabwidth subcommand.
2456 (cmd_file_handle) Put parsed tab width into private_file_handle.
2457 (create_file_handle) Set default tab width.
2458 (handle_get_tab_width) New function.
2460 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2462 * inpt-pgm.c: (reread_trns_proc) Ditto.
2464 * matrix-data.c: (context) Ditto.
2465 (another_token) Ditto.
2469 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2471 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2473 (casereader_destroy) Don't close file descriptor -1.
2475 * recode.c: (cmd_recode) Fix memory leak.
2477 * set.q: (q2c specifications) Fix typo in user message.
2479 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2480 undefined behavior for overlapping arguments.
2482 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2484 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2485 don't call it when we're running under valgrind.
2486 (call_posix_fadvise) New function.
2487 (casefile_to_disk) Use call_posix_fadvise().
2488 (reader_open_file) Ditto.
2490 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2492 Update our string ADTs, struct string and struct len_string. Get
2493 rid of pool support, which was largely unused. Rename lots of
2494 functions to have more obvious or consistent names.
2496 * ascii.c: Get rid of ascii_pool. It was only used for string
2498 (ascii_open_global) Don't create ascii_pool.
2499 (ascii_close_driver) Don't destroy ascii_pool.
2500 (ascii_postopen_driver) Don't use pool.
2501 (ascii_close_driver) Destroy strings manually.
2503 * str.c: (ds_create) Remove pool argument, all references updated.
2505 (ds_replace) Remove pool support, make more efficient when we
2506 don't need to reallocate.
2507 (ds_destroy) Remove pool support.
2508 (ds_rpad) New function.
2509 (ds_size) Renamed ds_capacity(), all references updated.
2510 (ds_value) Renamed ds_c_str(), all references updated.
2511 (ds_concat) Renamed ds_puts(), all references updated.
2512 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2513 (ds_putchar) Renamed ds_putc(), all references updated.
2514 (ds_getline) Renamed ds_gets(), all references updated.
2515 (ls_create) Remove pool argument, all references updated.
2516 (ls_create_buffer) Ditto.
2517 (ls_destroy) Removed pool support.
2518 (ls_value) Renamed ls_c_str(), all references updated.
2520 * str.h: (ls_length) [__GNUC__] Add inline version.
2521 (ls_c_str) [__GNUC__] Add inline version.
2522 (ls_end) [__GNUC__] Add inline version.
2523 (struct string) Remove pool member. Rename `size' to `capacity',
2524 all references updated.
2526 * tab.c: (text_format) Instead of using pool argument to
2527 ls_create_buffer(), call pool_register() on allocated data.
2529 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2531 We're abusing the current ASCII driver by telling it to allocate a
2532 9999-line, 9999-character page in the tests. This causes some
2533 systems to curl up and die because it allocates 20 MB of
2534 contiguous RAM. This change alleviates at least part of the
2535 problem. It is mostly a stop-gap until the new output system is
2538 * ascii.c: (struct line) New structure.
2539 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2540 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2541 (ascii_preopen_driver) Initialize new members, not old ones.
2542 (ascii_close_driver) Destroy new members, not old ones.
2543 (ascii_open_page) Allocate new members, not old ones.
2544 (expand_line) Allocate room in line.
2545 (draw_line) Use new members.
2546 (ascii_line_horz) Ditto.
2547 (ascii_line_vert) Ditto.
2548 (ascii_line_intersection) Ditto.
2550 (output_lines) Ditto.
2551 (ascii_close_page) Ditto.
2553 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2555 * matrix.c: Dead code. Removed.
2557 * matrix.h: Dead code. Removed.
2559 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2561 Contrary to what I'd always understood, there is an efficient
2562 algorithm for deletion from a hash table populated via linear
2563 probing. This change implements it.
2565 * hash.c: (hsh_rehash) Probe in increasing order.
2567 (locate_matching_entry) Ditto.
2568 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2570 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2572 * moments.c (calc_moments): Adjust calculation of kurtosis to
2573 avoid subtracting huge numbers from huge numbers, on Michael
2576 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2578 Rework moments routines for improved numerical stability based on
2579 Michael Kiefte's advice. Any bugs or remaining numerical problems
2580 are still mine though.
2582 There is now a struct moments1 for use with one-pass moments. It
2583 uses a provisional means algorithm as an attempt to improve
2584 accuracy of higher moments. The older struct moments now only
2585 handles two-pass moments.
2587 * aggregate.c: Use moments1 instead moments.
2589 * descript.c: Revert previous change, which is no longer needed
2590 due to the moments revision.
2592 * moments.c: (calc_moments) New function for calculating variance,
2594 (moments_pass_one) Only accumulate weights bigger than zero.
2595 (moments_calculate) Allow calculating the mean on pass one, others
2596 require pass two. Implement in terms of calc_moments().
2597 (struct moments1) New structure.
2598 (init_moments1) New function.
2599 (moments1_clear) Ditto.
2600 (moments1_create) Ditto.
2601 (moments1_add) Ditto.
2602 (moments1_calculate) Ditto.
2603 (moments1_destroy) Ditto.
2604 (cmd_debug_moments) Deal with `struct moments' or `struct
2605 moments1' as requested by user.
2607 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2609 * Makefile.am (pspp_SOURCES): Remove debug.c.
2611 * debug.c: Removed. It was empty anyway.
2613 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2615 * descript.c (calc_descriptives): Fix assert failure when only
2616 MOMENT_MEAN is needed.
2618 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2622 fixed problem with parsing in match_statistic() causing
2623 "DESCRIPTIVE STAT=MEAN." to barf.
2625 "MEAN" is now default if "SORT" given without specification.
2627 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2628 generally less forgiving of syntax errors: better to have it do
2629 nothing and type it in again then to not know what it actually did
2632 z-score transformation now checks score for user-missing values
2633 and checks std_dev for SYSMIS.
2635 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2637 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2638 Changed dict_get_case_weight() to accept an additional int * flag
2639 to complain about system-missing, user-missing, zero, or negative
2640 weights and updated existing functions to pass int * to
2641 dict_get_case_weight().
2643 2004-04-05 jmd <jmd@gnu.org>
2645 * main.c: Fixed configuration problems with gsl
2647 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2649 2004-04-03 blp <blp@gnu.org>
2651 * lexer.c, ChangeLog:
2652 Fix infinite loop on comment at end of file, add test.
2654 2004-04-03 jmd <jmd@gnu.org>
2656 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2657 Fixed the calculation of percentiles and added --syntax and --algorithm options
2659 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2661 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2664 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2666 * frequencies.q: Fixed the calculation of percentiles
2668 * Makefile.am: Added the --ansi flag and dealt with the
2669 consequences. Added some entries to PSPP_sources so that
2670 make distcheck would pass
2672 * cmdline.c: Added the --syntax and --algorithm options
2674 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2676 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2678 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2679 use the new multipass_split_... mechanism.
2681 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2683 * frequencies.q: (calc_stats) Use moments data structure and
2684 calc_seskew(), calc_sekurt() functions.
2686 * set.q main.c settings.h Added support for --syntax and --algorithm
2689 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2691 * vfm.c: Had to get last call to multipass_split_output() inside
2692 open_active_file()/close_active_file() pairing, so introduce new
2694 (internal_procedure) Move procedure() code here, except for calls
2695 to open_active_file() and close_active_file().
2696 (procedure) Wrap open_active_file() and close_active_file() around
2697 internal_procedure().
2698 (multipass_procedure_with_splits) Wrap open_active_file() and
2699 close_active_file() around internal_procedure().
2701 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2703 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2705 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2707 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2709 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2711 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2713 * algorithm.c: By default turn off some of the more expensive
2715 (expensive_assert) New macro which expands to assert if
2716 EXTRA_CHECKS is defined, to nothing otherwise.
2717 (unique) Use expensive_assert().
2718 (binary_search) Ditto.
2724 * command.c: (conflicting_3char_prefixes) Words that are the same
2725 don't cause conflicts when they are abbreviated to the first three
2728 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2729 nonterm_node's n earlier.
2730 (generic_str_func) Ditto.
2732 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2734 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2735 test multipass support, take advantage of new moments
2736 calculation, and to not be such crappy code. Get rid of q2c
2737 processing for DESCRIPTIVES.
2739 * vfm.c: (struct multipass_split_aux_data) New structure.
2740 (multipass_procedure_with_splits) New function.
2741 (multipass_split_callback) New function.
2742 (multipass_split_output) New function.
2743 * descript.q: Removed.
2745 * descript.c: New file.
2747 * var.h: Removed descriptives enums.
2748 (struct descriptives_proc) Removed.
2749 (struct variable) Removed p.dsc.
2751 * Makefile.am: (q_sources_c) Remove descript.c.
2752 (q_sources_q) Removed descript.q.
2754 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2756 New manager for keeping track of used workspace.
2758 * workspace.c: New file.
2760 * workspace.h: New file.
2762 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2764 * sort.c: (do_internal_sort) Use workspace_malloc().
2765 (destroy_internal_sort) Use workspace_free().
2767 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2769 New `struct casefile' for managing sets of cases.
2771 * casefile.c: New file.
2773 * casefile.h: New file.
2775 * command.def: Add DEBUG CASEFILE command.
2777 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2779 * sort.c: (sort_cases) Move logic for sending storage file to disk
2780 into do_external_sort().
2781 (struct internal_sort) Use an array of ccase pointers instead of a
2783 (do_internal_sort) Rewrite to handle casefiles.
2784 (compare_case_list) Removed.
2785 (compare_cases) New function.
2786 (compare_case_dblptrs) New function.
2787 (read_internal_sort_output) Deal with new struct internal_sort.
2789 * vfm.c: (static var workspace_overflow) Removed.
2790 (struct storage_stream_info) Removed all the members. Added
2791 struct casefile * member.
2792 (storage_sink_open) Use casefile.
2793 (open_storage_file) Removed.
2794 (write_storage_file) Removed.
2795 (storage_to_disk) Removed.
2796 (destroy_storage_stream_info) Use casefile.
2797 (storage_sink_write) Use casefile.
2798 (storage_sink_make_source) Use casefile.
2799 (storage_source_count) Use casefile.
2800 (storage_source_read) Use casefile.
2801 (storage_source_on_disk) Removed.
2802 (storage_source_get_cases) Removed.
2803 (storage_source_set_cases) Removed.
2804 (storage_source_get_casefile) New function.
2806 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2808 New `struct moments' for calculating moments.
2814 * moments.c: New file.
2816 * moments.h: New file.
2818 * command.def: Add DEBUG MOMENTS command.
2820 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2823 * aggregate.c: Modify AGGREGATE to use the new moments
2824 calculation, even if not in such a great way.
2825 (struct agr_var) Add `moments' member.
2826 (parse_aggregate_functions) Set `moments' member to null.
2827 (agr_destroy) Destroy `moments' member.
2828 (accumulate_aggregate_info) Use `moments' for standard deviation.
2829 (dump_aggregate_info) Ditto.
2830 (initialize_aggregate_info) Create or clear `moments'.
2832 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2833 cube(), pow4() that were in stats.h. All references updated.
2835 * crosstabs.q: stats.h had chi-square significance functions. Use
2837 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2839 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2840 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2842 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2844 * dictionary.c: (dict_compact_values) Compacted values need to
2847 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2849 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2850 `/' at start. Check return value of parse_variables() for error
2853 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2855 Revamp expressions: make the code a little nicer, and fix bugs
2858 * expr-evl.c: (expr_evaluate) Make expression argument const.
2859 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2860 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2861 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2862 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2863 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2864 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2865 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2866 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2867 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2868 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2869 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2870 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2871 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2873 * expr-opt.c: (optimize_expression) Rewrite.
2878 (macro s0l) Removed.
2880 (macro s1l) Removed.
2882 (macro s2l) Removed.
2885 (eq_num_con) New function.
2886 (optimize_tree) New function.
2887 (macro rnc) Removed.
2888 (macro frnc) Removed.
2889 (str_search) Add const to string params.
2890 (str_rsearch) Ditto.
2891 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2892 str[], str_len[] locals to substitute for most of removed macros.
2893 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2894 Removed support for missing values because we're never called with
2895 missing values. Use set_number() or set_number_errno() instead of
2896 rnc or frnc. Removed any stuff that caused trouble in testing.
2897 We can re-add it later if it really slows anything. Fix some
2899 (evaluate_tree_with_missing) Not yet supported. To be added later
2901 (repl_num_con) Removed.
2902 (collapse_node) New function.
2903 (force_repl_num_con) Removed.
2904 (set_number) New function.
2905 (set_number_errno) New function.
2906 (repl_str_con) Removed.
2907 (set_string) New function.
2908 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2910 (dump_node) No special case for OP_AND, OP_OR.
2912 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2913 (expr_get_type) New function.
2914 (type_check) Rewrite.
2915 (type_coercion) New function.
2916 (struct operator) New structure.
2917 (match_operator New function.
2918 (parse_binary_operators) New function.
2919 (parse_inverting_unary_operator) New function.
2920 (parse_or) Rewritten.
2921 (parse_and) Rewritten.
2922 (parse_not) Rewritten.
2923 (parse_rel) Rewritten.
2924 (parse_add) Rewritten.
2925 (parse_mul) Rewritten.
2926 (parse_neg) Rewritten.
2927 (parse_exp) Rewritten.
2928 (parse_sysvar) Add $TRUE, $FALSE system variables.
2929 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2930 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2932 (struct function) Remove desc, change `func' prototype.
2933 (unary_func) Remove special cases.
2934 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2935 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2936 (VALUE_func) Use allocate_var_node().
2937 (nary_num_func) Allow MIN and MAX for strings.
2938 Use allocate_var_node(). Properly clean up.
2940 (generic_str_func) Use local table instead of removed `desc'
2941 member. Mostly rewrite.
2942 (get_num_args) Revise error message.
2943 (parse_function) Return EXPR_ERROR, not 0 on error.
2945 (macro varies) Removed.
2946 (ops[]) Use expr.def.
2947 (free_node) Do nothing if node is null.
2948 (allocate_num_con) New function.
2949 (allocate_str_con) New function.
2950 (allocate_var_node) New function.
2951 (allocate_binary_nonterminal) New function.
2952 (append_nonterminal_arg) Removed.
2953 (static var func_tab[]) Revised.
2954 (expr_debug_print_postfix) Make parameter const.
2955 Use printf() instead of debug_printf().
2957 * expr.def: New file.
2959 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2960 use named enum instead of unnamed, all references updated. Add
2961 EXPR_ANY, EXPR_NO_OPTIMIZE.
2963 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2964 instead of defining OP_* directly.
2965 (macro IS_TERMINAL) New macro.
2966 (macro IS_NONTERMINAL) New macro.
2967 (enum OP_NO_FLAGS) New.
2969 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2971 * error.c: (err_assert_fail) msg variable needs to be non-const.
2973 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2975 * debug.c: (cmd_debug_evaluate) Rewrite.
2977 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2979 Fix some CROSSTABS bit rot stupidity.
2981 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2982 (internal_cmd_crosstabs) Initializes cells[] correctly.
2983 (float_M_suffix) Rename format_cell_entry(), change prototype,
2985 (display_crosstabulation) Fix cell formatting.
2987 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2989 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2990 to call lex_discard_line() to do that.
2992 * command.c: (run_command) Call lex_discard_line() after
2995 * lexer.c: (lex_entire_end) Change behavior.
2996 (lex_rest_of_line) Change behavior. Return const char *.
2997 (lex_discard_line) Don't clear getl_buf, don't emit message.
2999 * main.c: (handle_error) Emit message here.
3001 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
3002 instead of lex_entire_line().
3004 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
3006 * title.c: (get_title) Call lex_discard_line() after
3008 (cmd_file_label) Ditto.
3009 (cmd_document) Deal with const char * return value.
3011 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
3013 Removed REMARK command.
3015 * command.c: (extract_prefix) Removed.
3016 (output_line) Removed.
3017 (cmd_remark) Removed.
3019 * command.def: Remove REMARK.
3021 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3023 Added abort() after lots of assert(0) invocations to avoid some
3024 compiler warnings. We really need a NOT_REACHED macro.
3026 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3028 * sort.c: Added missing call to temp_file_close. Changed error
3029 messages to warnings.
3031 * set.q: Improved setting of set_view{length,width} to be more tolerant
3034 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3036 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3037 used with incorrect syntax.
3039 * error.c, error.h et al: Overridden definition of assert for a
3042 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3043 subcommand was given when it ought to have been.
3045 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3047 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3051 (tab_joint_text) Ditto.
3053 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3055 * levene.c: Add #include.
3057 * set.q: (set_viewport) Add `int' argument to make its prototype
3058 correct for signal().
3060 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3062 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3065 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3067 Changed DFM from open-at-first-access to explicit-open. Before,
3068 calling dfm_get_record() or dfm_put_record() would automatically
3069 open the file. Now, you have to call dfm_open_for_reading() or
3070 dfm_open_for_writing() explicitly. This makes it possible to
3071 check permissions, file existence, etc. earlier.
3073 Also made struct file_handle more opaque, and clean up in general.
3075 * data-list.c: (cmd_data_list) Open handle for reading.
3077 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3079 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3080 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3081 (open_inline_file) Removed.
3082 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3083 it. Deal with line_number in extension record instead of file
3085 (dfm_get_record) Rewrote.
3086 (dfm_put_record) Rewrote.
3087 (dfm_push) Assert file is open and one of ours. Deal with
3088 line_number in extension record instead of file handle.
3089 (dfm_pop) Assert file is open and one of ours. Deal with
3090 line_number in extension record instead of file handle.
3091 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3094 * file-handle.h: (enum constants RH_RF_*) Removed.
3095 (enum constants FH_MD_*) Removed.
3096 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3097 `recform', `lrecl', `mode' members. Public references to
3098 `recform' changed to use handle_get_mode(), references to `lrecl'
3099 changed to use handle_get_record_width(). Added `private' member.
3100 (enum file_handle_mode) New.
3102 * file-handle.q: (struct private_file_handle) New structure.
3103 (struct file_handle_list) New structure.
3104 (static var files) New.
3105 (static var file_handles) Removed.
3106 (init_file_handle) Removed.
3107 (create_file_handle) Removed.
3108 (get_handle_with_name) New function.
3109 (get_handle_for_filename) New function.
3110 (cmd_file_handle) Rewritten.
3111 (hash_file_handle) Removed.
3112 (cmp_file_handle) Removed.
3113 (fh_init_files) Rewritten.
3114 (fh_parse_file_handle) Rewritten. Allows identifiers as
3116 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3118 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3119 references updated. Rewritten.
3120 (fh_record_width) Renamed handle_get_record_width(), all
3121 references updated. Rewritten.
3122 (handle_get_mode) New function.
3124 * file-type.c: (cmd_file_type) Open handle for reading.
3126 * filename.c: [unix] (struct file_identity) New structure.
3127 [unix] (fn_get_identity) New function.
3128 [unix] (fn_free_identity) New function.
3129 [unix] (fn_compare_file_identities) New function.
3130 [!unix] (struct file_identity) New structure.
3131 [!unix] (fn_get_identity) New function.
3132 [!unix] (fn_free_identity) New function.
3133 [!unix] (fn_compare_file_identities) New function.
3135 * lexer.c: (static var put) Renamed put_token, all references
3137 (static var put_tokstr) New.
3138 (static var put_tokval) New.
3139 (lex_init) Initialize put_tokstr().
3140 (restore_token) New function.
3141 (save_token) New function.
3142 (lex_get) Use restore_token().
3143 (lex_put_back) Use save_token().
3144 (lex_put_back_id) New function.
3145 (lex_put_forward) Removed.
3146 (lex_preprocess_line) Set put_token instead of using
3148 (lex_negative_to_dash) Use save_token(), set put_token directly.
3149 (dump_token) Use stderr instead of stdout.
3151 * main.c: (main) Remove call to cmd_init().
3153 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3155 * pfm-read.c: Use handle_get_filename() instead of trying to use
3156 h->fn directly, all over.
3158 * pfm-write.c: Ditto.
3160 * print.c: (internal_cmd_print) Open handle for writing.
3161 (dump_table) Use handle_get_filename().
3162 (print_trns_proc) Use handle_get_mode().
3163 (cmd_print_space) Use fh_parse_file_handle().
3164 Open handle for writing.
3165 [0] (debug_print) Removed.
3167 * sfm-read.c: Use handle_get_filename() instead of trying to use
3168 h->fn directly, all over.
3170 * sfm-write.c: Ditto.
3172 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3176 * autorecode.c: (arc_free) Free arc->src_values.
3178 * error.c: (msg) Free buf.
3180 * val-labs.c: (do_value_labels) Always free vars.
3182 * vfm.c: (close_active_file) If sink has no make_source then call
3183 its destroy function.
3185 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3187 Fixed cmd_parse() so that it always skips past a full command
3188 name. A few special commands for which this would be bad get
3189 special treatment. This lets us drop code for skipping past the
3190 end of a command name in most cmd_*() functions. It's not worth
3191 listing all the commands affected.
3193 * command.c: (struct command) Remove `cmd' member, replace by
3194 `name' member, all references updated. Remove `word', `next',
3195 `skip_entire_name' members.
3196 (macro DEFCMD) Deal with revised `struct command'.
3197 (macro UNIMPL) Ditto.
3198 (macro SPCCMD) New macro for commands whose last word shouldn't be
3200 (static array cmd_table[]) Make const, rename `commands', remove
3202 (macro COMMAND_CNT) New macro.
3203 (split_words) Removed.
3205 (FILE_TYPE_okay) Make parameter const.
3206 (cmd_parse) Improve error messages.
3207 (match_strings) New function.
3208 (next_word) New function.
3209 (enum command_match) New enum.
3210 (conflicting_3char_prefixes) New function.
3211 (conflicting_3char_prefix_command) New function.
3212 (cmd_match_words) New function.
3213 (count_matching_commands) New function.
3214 (get_command_name) New function.
3215 (free_words) New function.
3216 (unknown_command_error) New function.
3217 (figure_out_command) Renamed parse_command_name(), rewritten.
3219 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3220 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3221 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3224 * command.h: (macro SPCCMD) New.
3226 * include.c: (cmd_include_at) Removed.
3227 (cmd_include) Allow identifier to be used as filename.
3229 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3231 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3234 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3236 Start work on better test framework.
3238 * Makefile.am: (pspp_sources) Add debug.c.
3240 * debug.c: New file.
3242 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3243 cmd_debug_evaluate().
3245 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3247 * expr.h: (enum constant PXP_DUMP) Removed.
3249 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3251 * set.q: Implemented the SHOW command, and synced it to the existing
3254 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3255 changes as the window size is changed.
3257 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3258 environment variables if other methods are not available.
3260 glob.c: Removed a lot of global variables from glob.c and encapsulated
3263 random.c: Tidied up the way the random seed is set.
3265 str.c: Added a ds_vprintf function.
3267 error.c: Extended dump_message so that messages are always broken at
3270 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3272 * pfm-write.c: (bufwrite) Write out the correct element for string
3273 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3275 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3277 Get rid of static and global (!) vars in matrix-data.c.
3279 * matrix-data.c: (static var nr_data) Removed.
3280 (static var nr_factor_values) Removed.
3281 (static var max_cell_index) Removed.
3282 (static var split_values) Removed.
3283 (struct nr_aux_data) New structure.
3284 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3285 place of static vars, pass to create_case_source() and procedure()
3287 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3288 struct matrix_data_pgm *.
3289 (nr_read_splits) Ditto.
3290 (nr_read_factors) Ditto.
3291 (nr_output_data) Ditto.
3292 (static var wr_content) Removed.
3293 (global var wr_data) Removed.
3294 (global var wr_current) Removed.
3295 (struct wr_aux_data) New structure.
3296 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3297 place of static vars, pass to create_case_source() and procedure()
3299 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3300 instead of matrix_data_pgm *.
3301 (wr_read_splits) Ditto.
3302 (wr_output_data) Ditto.
3303 (wr_read_rowtype) Ditto.
3304 (wr_read_factors) Ditto.
3305 (wr_read_indeps) Ditto.
3307 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3309 Get rid of static vars in autorecode.c.
3311 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3312 `n_arc' to `spec_cnt'. All references updated.
3313 (static var v_src) Removed.
3314 (static var v_dest) Removed.
3315 (static var h_trns) Removed.
3316 (static var nv_src) Removed.
3317 (static var descend) Removed.
3318 (static var print) Removed.
3319 (enum direction) New enum.
3320 (struct autorecode_pgm) New structure.
3321 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3322 Move n_dest local var into struct autorecode_pgm for ease of
3323 clean-up. Use arc_free().
3324 (arc_free) New function.
3325 (recode) Modify to take struct autorecode_pgm * parameter instead
3326 of using statics. Let the caller clean up.
3327 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3328 instead of statics. Rearrange code a little.
3330 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3332 Get rid of static, global vars in recode.c. Remove debug code.
3334 * recode.c: (static var head) Removed.
3335 (global var v) Removed.
3336 (global var nv) Removed.
3337 (cmd_recode) New local variables head, v, nv. Initialize and free
3338 v. Don't call debug_print().
3339 [DEBUGGING] (dump_dest) Removed.
3340 [DEBUGGING] (debug_print) Removed.
3342 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3344 Get rid of static vars in expr-opt.c.
3346 * expr-opt.c: (static var e) Removed.
3347 (static var nop) Removed.
3348 (static var mop) Removed.
3349 (static var ndbl) Removed.
3350 (static var mdbl) Removed.
3351 (static var nstr) Removed.
3352 (static var mstr) Removed.
3353 (static var nvars) Removed.
3354 (static var mvars) Removed.
3355 (struct expr_dump_state) New structure.
3356 (dump_expression) Use new struct expr_dump_state instead of static
3357 vars and pass to functions we call.
3358 (dump_node) Use struct expr_dump_state * parameter.
3360 (emit_num_con) Ditto.
3361 (emit_str_con) Ditto.
3364 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3366 Get rid of static var in COUNT.
3368 * count.c: (static var head) Move into cmd_count().
3369 (cmd_count) [DEBUGGING] Don't call debug_print.
3370 [DEBUGGING] (debug_print) Removed.
3372 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3374 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3376 * val-labs.c: (static var v) Removed.
3377 (static var nv) Removed.
3378 [DEBUGGING] (debug_print) Removed.
3379 (verify_val_labs) Add struct variable **, int parameters.
3380 (get_label) Ditto. Improve error messages, streamline.
3381 (erase_labels) New function for erasing value labels, taking over
3382 part of verify_val_labs()'s function.
3385 (cmd_value_labels) No need to call init() or done() anymore.
3386 (cmd_add_value_labels) Ditto.
3387 (do_value_labels) Add vars, var_cnt local variables. Clean up
3388 after them internally. Call erase_labels() if we should. Don't
3391 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3393 Get rid of static vars in MATCH FILES.
3395 * get.c: (static var mtf_head) Removed.
3396 (static var mtf_tail) Removed.
3397 (static var mtf_by) Removed.
3398 (static var mtf_n_by) Removed.
3399 (static var mtf_master) Removed.
3400 (static var mtf_seq_num) Removed.
3401 (static var mtf_seq_nums) Removed.
3402 (static var mtf_sink) Removed.
3403 (static var mtf_case) Removed.
3404 (struct mtf_proc) New structure.
3405 (cmd_match_files) Use struct mtf_proc instead of static vars.
3406 (mtf_processing_finish) Ditto.
3408 (mtf_delete_file_in_place) Ditto.
3409 (mtf_read_nonactive_records) Ditto.
3410 (mtf_compare_BY_values) Ditto.
3411 (mtf_processing) Ditto.
3412 (mtf_merge_dictionary) Ditto.
3414 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3416 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3418 * dictionary.c: (dict_rename_var) Add assertion.
3419 (dict_contains_var) Check by index instead of name.
3421 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3423 Get rid of compaction_necessary, compaction_nval, compaction_case.
3424 Redo VFM interface. Replace disk_sink and memory_sink by
3425 storage_sink, disk_source and memory_source by storage_source.
3427 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3431 (struct write_case_data) Remove `begin_func', `end_func',
3432 `func_aux' members. Add `aux', `trns_case', `sink_case',
3433 `cases_written', `cases_analyzed' members.
3434 (global var compaction_necessary) Make static.
3435 (global var compaction_nval) Removed.
3436 (global var compaction_case) Removed.
3437 (static var case_count) Removed.
3438 (struct procedure_aux_data) Removed.
3439 (struct split_aux_data) Removed.
3440 (procedure) Remove begin_func, end_func parameters. Rewrite.
3441 (static var not_canceled) Removed.
3442 (process_active_file) Removed.
3443 (process_active_file_write_case) Removed.
3444 (process_active_file_output_case) Removed.
3445 (prepare_for_writing) Moved into open_active_file().
3446 (arrange_compaction) Ditto.
3448 (open_active_file) Rewrote.
3449 (write_case) New function.
3450 [DEBUGGING] (index_to_varname) Removed.
3451 (execute_transformations) New function.
3452 (exclude_this_case) Renamed filter_case(), changed interface.
3453 (clear_case) Added struct ccase * parameter to interface.
3454 (close_active_file) Added struct write_case_data * parameter,
3456 (disk_sink_create) Removed.
3457 (disk_sink_destroy) Removed.
3458 (disk_sink_make_source) Removed.
3459 (disk_sink_write) Removed.
3460 (disk_source_count) Removed.
3461 (disk_source_destroy) Removed.
3462 (disk_source_read) Removed.
3463 (global var disk_sink_class) Removed.
3464 (global var disk_source_class) Removed.
3465 (global var memory_sink_class) Removed.
3466 (global var memory_source_class) Removed.
3467 (memory_sink_create) Removed.
3468 (memory_sink_destroy) Removed.
3469 (memory_sink_make_source) Removed.
3470 (memory_sink_write) Removed.
3471 (memory_source_count) Removed.
3472 (memory_source_destroy) Removed.
3473 (memory_source_get_cases) Removed.
3474 (memory_source_read) Removed.
3475 (memory_source_set_cases) Removed.
3476 (struct disk_stream_info) Removed.
3477 (struct memory_sink_info) Removed.
3478 (struct memory_source_info) Removed.
3479 (write_active_file_to_disk) Removed.
3480 (destroy_storage_stream_info) New function.
3481 (global var null_sink_class) New var.
3482 (global var storage_sink_class) New var.
3483 (global var storage_source_class) New var.
3484 (open_storage_file) New function.
3485 (storage_sink_destroy) New function.
3486 (storage_sink_make_source) New function.
3487 (storage_sink_open) New function.
3488 (storage_sink_write) New function.
3489 (storage_source_count) New function.
3490 (storage_source_destroy) New function.
3491 (storage_source_get_cases) New function.
3492 (storage_source_on_disk) New function.
3493 (storage_source_read) New function.
3494 (storage_source_set_cases) New function.
3495 (storage_source_to_disk) New function.
3496 (storage_to_disk) New function.
3497 (struct storage_stream_info) New structure.
3498 (write_storage_file) New function.
3499 (procedure_write_case) Removed.
3500 (create_case_source) Add `struct dictionary *' parameter, all
3502 (create_case_sink) Ditto.
3503 (free_case_sink) New function.
3504 (struct split_aux_data) New structure.
3505 (procedure_with_splits) New function implementing what procedure()
3507 (SPLIT_FILE_proc_func) Removed.
3508 (procedure_with_splits_callback) New function.
3509 (equal_splits) New function.
3511 * aggregate.c: Pass around a struct instead of using statics.
3512 (static var outfile) Remove.
3513 (enum type) Give it tag `missing_treatment'.
3514 (static var missing) Remove.
3515 (static var sort) Remove.
3516 (static var agr_first) Remove.
3517 (static var agr_next) Remove.
3518 (static var case_count) Remove.
3519 (static var prev_case) Remove.
3520 (static var buf64_1xx) Remove.
3521 (static var buf_1xx) Remove.
3522 (struct agr_proc) New structure incorporating the above.
3523 (cmd_aggregate) Use new struct. Clean up error handling using
3524 agr_destroy(). Completely rewrite actual implementation of
3526 (create_sysfile) Add struct agr_proc * parameter, modify
3528 (parse_aggregate_functions) Ditto.
3529 (free_aggregate_functions) Ditto. Rename agr_destroy().
3530 (aggregate_single_case) Add struct agr_proc * parameter, modify
3532 (accumulate_aggregate_info) Ditto.
3533 (dump_aggregate_info) Ditto.
3534 (initialize_aggregate_info) Ditto.
3535 (agr_00x_trns_proc) Removed.
3536 (agr_00x_end_func) Removed.
3537 (agr_10x_trns_proc) Removed.
3538 (agr_10x_trns_free) Removed.
3539 (agr_10x_end_func) Removed.
3540 (agr_11x_read) Removed.
3541 (agr_11x_finish) Removed.
3542 [DEBUGGING] (debug_print) Removed.
3543 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3545 (agr_to_active_file) New function.
3546 (presorted_agr_to_sysfile) New function.
3547 (sort_agr_to_sysfile) New function.
3549 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3551 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3553 * descript.q: (cmd_descriptives) Ditto.
3555 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3556 to new procedure() interface.
3558 * command.c: (cmd_execute) Adapt to new procedure() interface.
3560 * dictionary.c: (dict_compact_values) Also delete scratch
3562 (dict_get_compacted_value_cnt) New function.
3563 (dict_get_compacted_idx_to_fv) New function.
3565 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3566 (cmd_flip) Adapt to new procedure() interface.
3567 (flip_sink_write) Use sink->idx_to_fv.
3569 * frequencies.q: (internal_cmd_frequencies) Use
3570 procedure_with_splits().
3572 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3573 (static var mtf_sink) New static var.
3574 (static var mtf_case) New static var.
3575 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3576 we actually implement the matching.
3577 (mtf_delete_file_in_place) Use mtf_case.
3578 (mtf_processing) Use mtf_case and mtf_sink.
3579 (cmd_export) Adapt to new procedure() interface.
3581 * levene.c: (levene) Use procedure_with_splits().
3583 * list.q: (cmd_list) Use procedure_with_splits().
3585 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3586 procedure() interface.
3587 (read_matrices_with_rowtype) Ditto.
3589 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3590 TEMPORARY. Adapt to new procedure() interface.
3592 * rename-vars.c: Warn about and cancel TEMPORARY.
3594 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3595 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3596 compaction_nval. Adapt to new procedure() interface. Use
3597 storage_source_to_disk().
3598 (do_internal_sort) Don't try to dump the cases to memory.
3599 (compare_case_lists) Pass null idx_to_fv.
3600 (struct initial_run_state) Add `idx_to_fv' member. Remove
3602 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3603 new procedure() interface. Reset irs->idx_to_fv after calling
3605 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3606 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3608 (destroy_initial_run_state) Don't dereference irs after freeing
3610 (allocate_cases) Don't calculate case_size locally.
3611 (compare_record) Add idx_to_fv parameter.
3612 (compare_record_run) Change parameter from struct sort_cases_pgm *
3613 to struct initial_run_state *. Pass irs->idx_to_fv to
3615 (compare_record_run) Third parameter now a struct
3616 initial_run_state *.
3617 (output_record) No need for out_case anymore. Pass irs, not
3618 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3620 (merge) Use case_size from struct sort_cases_pgm.
3621 (merge_once) Use case_size from struct sort_cases_pgm.
3622 Pass null pointer to compare_record() as idx_to_fv.
3623 (global var sort_sink_class) Make static.
3625 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3627 * temporary.c: Remove debugging crap.
3629 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3631 * t-test.q, levene.c: Fixed up the handling of MISSING values
3634 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3636 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3639 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3641 Change explicit variable name checks into use of
3642 dict_class_from_id().
3644 * dictionary.c: (dict_create_var) Change explicit variable name
3645 check into use of dict_class_from_id().
3647 * get.c: (trim_dictionary) Ditto.
3649 * sel-if.c: (cmd_filter) Ditto.
3651 * sysfile-info.c: (cmd_display) Ditto.
3653 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3655 * vfm.c: (arrange_compaction) Ditto.
3657 * weight.c: (cmd_weight) Ditto.
3659 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3661 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3662 transformation following the input program, if any, for some
3663 reason we special-cased f_trns. That's just wrong. It should
3664 always be set to n_trns.
3666 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3668 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3669 introduced in last check-in.
3671 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3673 * format.c: (global array translate_fmt[]) Removed.
3674 (translate_fmt) New function as replacement.
3675 (parse_format_specifier_name) Rewrite.
3677 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3680 * sfm-read.c: (parse_format_spec) Ditto.
3682 * postscript.c: (text) Fix handling of fonts with missing
3685 * sort.c: (struct external_sort) Add temp_name member.
3686 (destroy_external_sort) Free temp_dir, temp_name members.
3687 (init_external_sort) Allocate temp_name.
3688 (get_temp_file_name) Change prototype.
3689 (open_temp_file) Deal with change to get_temp_file_name().
3690 (close_temp_file) Ditto.
3691 (remove_temp_file) Ditto.
3692 (write_temp_file) Ditto.
3693 (read_temp_file) Ditto.
3694 (sort_sink_destroy) Removed.
3695 (sort_sink_class) Change destroy member to null.
3697 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3699 Eliminate temp_case.
3701 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3702 anymore. Use agr_11x_finish().
3703 (aggregate_single_case) Make first param const.
3704 (accumulate_aggregate_info) Ditto.
3705 (agr_00x_end_func) Use compaction_case, not temp_case.
3706 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3708 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3709 (cmd_data_list) Initialize case_size.
3710 (read_from_data_list_fixed) Add struct ccase * param, use instead
3712 (read_from_data_list_free) Ditto.
3713 (read_from_data_list_list) Ditto.
3714 (read_one_case) Rename data_list_trns_proc(), all references
3715 updated. Add argument in calling above functions. Use c
3716 argument instead of temp_case.
3717 (destroy_dls) Rename data_list_trns_free(), all references
3720 * expr-evl.c: (expr_evaluate) Make second parameter const.
3722 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3723 (cmd_end_file_type) Initialize `case_size'.
3724 (file_type_source_read) Add struct ccase * parameter. Use instead
3727 * flip.c: Rewritten.
3729 * get.c: (struct get_pgm) New structure to keep track of
3731 (cmd_get) Initialize case_size.
3733 (get_source) Deal with struct get_pgm.
3734 (get_source_read) Add struct ccase * parameter, use instead of
3736 (import_source_read) Ditto.
3738 * get.c: Use a null pointer instead of temp_case to represent the
3739 "current case" in a struct mtf_file's input member.
3740 (mtf_processing_finish) Pass null to mtf_processing(), not
3742 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3743 (mtf_compare_BY_values) Add extra arg, use instead of null input
3745 (mtf_processing) Use c parameter instead of temp_case. Pass
3746 compaction_case to process_active_file_output_case().
3748 * glob.c: (global variable temp_case) Removed.
3750 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3751 (cmd_input_program) Initialize case_size. Set
3752 vfm_source->value_cnt.
3753 (init_case) Add struct ccase * parameter, use instead of
3756 (input_program_source_read) Ditto.
3758 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3759 (dump_cell_content) Ditto.
3760 (nr_output_data) Ditto.
3761 (read_matrices_without_rowtype) Ditto.
3762 (matrix_data_read_with_rowtype) Ditto.
3763 (wr_read_splits) Ditto.
3764 (wr_output_data) Ditto.
3766 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3768 * sort.c: (sort_cases) Initialize scp->case_size.
3769 (struct external_sort) Remove `case_size' member.
3770 (write_initial_runs) Only call vfm_sink->class_destroy if
3772 (struct sort_source_aux) New structure.
3773 (sort_source_read_helper) New function.
3774 (sort_source_read) Use sort_source_read_helper().
3775 (read_sort_output) Change interface to be more reasonable.
3776 (read_internal_sort_output) Ditto.
3777 (read_external_sort_output) Ditto.
3779 * vars-prs.c: (dict_class_to_name) Pass return value through
3782 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3783 (procedure) Initialize trns_case.
3784 (procedure) Pass trns_case to vfm_source->class->read().
3786 (process_active_file) Start using struct procedure_aux_data.
3787 (process_active_file_write_case) Pass trns_case to
3788 transformations, lag_case(), clear_case().
3789 (process_active_file_output_case) Add struct ccase * parameter.
3790 (create_trns_case) New function.
3791 (make_temp_case) Removed.
3792 (vector_initialization) Removed.
3793 (close_active_file) Only call make_source if non-null, otherwise
3794 set vfm_source to null pointer. Don't free temp_case.
3795 (disk_source_read) Add struct ccase * parameter, use instead of
3797 (memory_source_read) Ditto.
3798 (lag_case) Add const struct ccase * member.
3799 (procedure_write_case) Use trns_case instead of temp_case.
3800 (clear_case) Add struct ccase * member, use instead of temp_case.
3801 (exclude_this_case) Ditto.
3802 (create_case_source) Add struct dictionary * parameter, use to
3803 initialize source->value_cnt.
3805 * vfm.h: (struct case_source) Add `value_cnt' member.
3806 (struct case_source_class) Add struct ccase * parameter to `read'
3807 member function pointer.
3808 (struct case_sink_class) Make struct ccase * parameter const in
3809 `write' member function pointer.
3811 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3813 Fix a lot of "possibly uninitialized variable" warnings. Some of
3814 them are even real bugs. A few of them make me wonder how the
3817 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3819 * ascii.c: (output_lines) Add default case to switch.
3821 * crosstabs.q: Remove static variable `expected' and all
3823 (display_crosstabulation) Always calculate expected value.
3825 (output_pivot_table) Initialize `cmp'.
3826 (display_crosstabulation) New variable `last_row', which is
3829 * data-in.c: (parse_numeric) Always initialize sign. How did this
3832 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3833 Always set info.ofs. (How did this work?!)
3835 * expr-opt.c: (optimize_tree) Always initialize `m'.
3836 (evaluate_tree) Always initialize `c'. (How did this work?)
3838 * frequencies.q: (frq_custom_variables) Always initialize min,
3840 (frq_custom_grouped) Always initialize `dl'.
3842 * groff-font.c: (groff_read_font) Always initialize char_set.
3844 * matrix-data.c: (nr_output_data) Initialize `split'.
3845 (wr_read_splits) Remove shadowing split_cnt declaration.
3846 (wr_output_data) Initialize `split'.
3848 * output.c: (tokener) Skip add character on syntax error.
3850 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3852 * postscript.c: (read_ps_encodings) Use line.string instead of
3854 (write_text) Add default case to switch.
3855 (text) Always initialize multiple variables. Fix bug with
3858 * print.c: (fixed_parse_fortran) Initialize head.
3859 (alloc_line) Add default case to switch.
3861 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3862 (recode_trns_proc) Move variable declaration inward. Add default
3865 * sfm-read.c: (read_header) Initialize skip_amt.
3867 * sysfile-info.c: (display_variables) Always initialize pc.
3869 * vars-prs.c: Initialized `included'.
3871 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3873 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3874 Just use signal() instead.
3876 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3878 Get rid of vfm_sink_info and vfm_source_info.
3880 * aggregate.c: (agr_00x_end_func) Don't increment
3881 sfm_sink_info.ncases.
3883 * sort.c: (do_internal_sort) Get case count from
3884 vfm_source->class->count().
3885 (struct external_sort) Add `case_size' member.
3886 (do_external_sort) Initialize case_size.
3887 (struct initial_run_state) Add `case_size' member.
3888 (write_initial_runs) Initialize case_size.
3889 (sort_sink_write) Use case_size.
3890 (read_external_sort_output) Use case_size. Get case_cnt from
3893 * vfm.c: (struct write_case_data) Add underscores to existing arg
3894 names, all references updated. Renamed `aux' as `func_aux', all
3895 references updated. Added new `aux' member.
3896 (global var vfm_source_info) Removed.
3897 (global var vfm_sink_info) Removed.
3898 (struct procedure_aux_data) New.
3899 (struct split_aux_data) New.
3900 (procedure) Use `aux' fields for procedure_aux_data,
3902 (process_active_file_write_case) Pass case_count + 1 to
3903 transformation procedures, exclude_this_case().
3904 (process_active_file_output_case) Don't increment
3905 vfm_sink_info.ncases.
3906 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3907 to send data to disk early.
3908 (make_temp_case) Don't use vfm_sink_info.case_size.
3909 (close_active_file) Don't initialize vfm_source_info.
3910 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3911 (disk_sink_create) Initialize and/or update disk_stream_info.
3912 (disk_sink_write) Ditto.
3913 (disk_sink_destroy) Ditto.
3914 (disk_sink_make_source) Ditto.
3915 (disk_source_read) Ditto.
3916 (disk_source_destroy) Ditto.
3917 (global var disk_source_class) Add disk_source_count().
3918 (disk_source_count) New function.
3919 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3920 (struct memory_source_info) Ditto.
3921 (memory_sink_create) Deal with case_cnt, case_size.
3922 (memory_sink_write) Ditto.
3923 (memory_sink_make_source) Ditto.
3924 (memory_source_read) Ditto.
3925 (memory_source_count) New function.
3926 (memory_source_class) Add memory_source_count().
3927 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3928 proc_aux->cases_written, and pass it to transformation procedures
3929 and exclude_this_case ().
3930 (exclude_this_case) Add case_num parameter. Pass it to
3932 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3935 * vfm.h: (struct case_source_class) Add `count' member.
3937 * vfmP.h: (struct stream_info) Removed.
3938 (global variable vfm_source_info) Removed.
3939 (global variable vfm_sink_info) Removed.
3941 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3943 * var.h: (typedef trns_proc_func) New typedef.
3944 (trns_free_func) New typedef.
3945 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3946 to type trns_free_func. This only changes the actual type of
3947 trns_proc_func, adding a `case_num' parameter. Updated all
3948 implementations to use the typedefs instead.
3950 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3951 (compute_num_vec) Ditto.
3952 (compute_str) Ditto.
3953 (compute_str_vec) Ditto.
3955 * do-if.c: (do_if_trns_proc) Ditto.
3957 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3960 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3961 pass to transformation functions.
3962 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3964 * loop.c: (loop_1_trns_proc) Ditto.
3965 (loop_2_trns_proc) Ditto.
3966 (loop_3_trns_proc) Ditto.
3968 * print.c: (print_space_trns_proc) Ditto.
3970 * sel-if.c: (select_if_proc) Ditto.
3972 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3974 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3975 destroying hash table.
3977 * glob.c: (read_active_file) Variable not referenced, removed.
3978 (cancel_input_pgm) Ditto.
3980 * levene.c: Add #include <stdlib.h> needed to call free().
3982 * aggregate.c: (parse_aggregate_functions) Make `function'
3985 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3987 Start working to eliminate VFM dependence on static variables.
3989 * command.c: (cmd_parse) Use case_source_is_class().
3991 * data-list.c: Rewrite to eliminate use of static variables.
3993 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3995 * file-handle.q: (fh_handle_name) Make parameter const.
3997 * file-type.c: Rewrite to eliminate use of static variables.
3999 * flip.c: Rewrite to eliminate use of static variables.
4001 * format.c: (get_format_var_width) New function.
4003 * get.c: Eliminate use of static variables.
4005 * inpt-pgm.c: Eliminate use of static variables.
4007 * matrix-data.c: Eliminate use of static variables.
4009 * set.q: (set_max_workspace) New variable.
4010 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
4012 * var.h: (struct case_list) Move here from vfmP.h.
4014 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4016 * vfm.c: (vfm_source) Change type from struct case_stream to
4018 (vfm_sink) Change type from struct case_stream to struct
4020 (static var paging) Rename workspace_overflow, all references
4022 (procedure) Use new class structures.
4023 (process_active_file) Ditto.
4024 (process_active_file_write_case) Ditto.
4025 (prepare_for_writing) Use set_max_workspace. Use new class
4027 (close_active_file) Use new class structures. Free old sink.
4028 (global var disk_source_file) Removed.
4029 (global var disk_sink_file) Removed.
4030 (disk_stream_init) Removed.
4031 (disk_stream_read) Removed.
4032 (disk_stream_write) Removed.
4033 (disk_stream_mode) Removed.
4034 (disk_stream_destroy_source) Removed.
4035 (disk_stream_destroy_sink) Removed.
4036 (global var vfm_disk_stream) Removed.
4037 (disk_sink_create) New function.
4038 (disk_sink_write) New function.
4039 (disk_sink_destroy) New function.
4040 (disk_sink_make_source) New function.
4041 (disk_sink_class) New static var.
4042 (disk_source_read) New function.
4043 (disk_source_destroy) New function.
4044 (global var vfm_source_class) New var.
4045 (global var memory_source_cases) Removed.
4046 (global var memory_sink_cases) Removed.
4047 (global var memory_sink_max_cases) Removed.
4048 (struct memory_sink_info) New struct.
4049 (memory_stream_init) Removed.
4050 (memory_stream_read) Removed.
4051 (memory_stream_write) Removed.
4052 (memory_stream_mode) Removed.
4053 (memory_stream_destroy_source) Removed.
4054 (memory_stream_destroy_sink) Removed.
4055 (global var vfm_memory_stream) Removed.
4056 (page_to_disk) Renamed write_active_file_to_disk().
4057 (memory_sink_create) New function.
4058 (memory_sink_write) New function.
4059 (memory_sink_destroy) New function.
4060 (memory_sink_make_source) New function.
4061 (memory_sink_class) New static var.
4062 (memory_source_read) New function.
4063 (memory_source_destroy) New function.
4064 (memory_source_get_cases) New function.
4065 (memory_source_set_cases) New function.
4066 (global var vfm_source_class) New var.
4067 (procedure_write_case) Use new class structures.
4068 (create_case_source) New function.
4069 (case_source_is_complex) New function.
4070 (case_source_is_class) New function.
4071 (create_case_sink) New function.
4073 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4074 (global variable reinit_blanks) Not used, removed.
4075 (global variable init_zero) Not used, removed.
4076 (global variable init_blanks) Not used, removed.
4077 (struct case_source) New struct.
4078 (struct case_source_class) New struct.
4079 (struct case_sink) New struct.
4080 (struct case_sink_class) New struct.
4081 (struct case_stream) Removed.
4083 * vfmP.h: (struct case_list) Moved to var.h.
4085 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4087 * algorithm.c: (count_equal) New function.
4088 (count_if) New function.
4089 (unique) Add assertions.
4090 (partition) Add assertions.
4091 (is_partitioned) New function.
4092 (copy_if) Add assertions.
4093 (remove_equal) Add assertions.
4094 (lexicographical_compare) Rename lexicographical_compare_3way.
4095 (sort) Add assertions. Rephrase some code.
4096 (is_sorted) New function.
4098 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4102 * sort.c: Completely rewrite.
4104 * sort.h: Expose interface via struct sort_cases_pgm, not via
4107 * aggregate.c: (sort) New static var.
4108 (cmd_aggregate) Use sort.
4109 (create_sysfile) Ditto.
4110 (aggregate_single_case) Ditto.
4111 (dump_aggregate_info) Ditto.
4112 (agr_00x_end_func) Ditto.
4113 (debug_print) Ditto.
4115 * var.h: (enum SRT_ASCEND) Removed.
4116 (enum SRT_DESCEND) Removed.
4117 (struct sort_cases_proc) Removed.
4118 (struct variable) Remove p.srt member.
4120 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4122 Get rid of the old, crappy heap structure and replace it by a new,
4123 shiny, C++ STL-like heap structure.
4125 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4127 * algorithm.c: (push_heap) New function.
4138 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4140 Increase warning level.
4142 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4144 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4146 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4148 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4150 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4151 around by previous change log entry.
4153 * compute.c: (lvalue_finalize) Remove workaround from previous
4156 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4158 * compute.c: Fixed a bug where the Format was not getting set for
4159 computed variables (thus causing a crash when SAVEing).
4161 * Added a test to stop this bug ever coming back
4163 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4165 Got rid of approx.h. In general, replaced all references to
4166 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4169 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4171 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4172 test for mag < EPSILON.
4174 * misc.h: Add definition of EPSILON.
4176 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4178 * vfm.c: (procedure) Add check to prevent recursive call.
4180 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4182 * Moved the declarations relating to values to their own header file
4185 * Added levene.c and levene.h
4187 * vars-atr.c: Changed the signature of compare_values to
4188 take const * arguments.
4190 * t-test.q: Changed the structure of struct t_test_proc
4191 variables now contain their own group statistics information.
4192 Eventually, t_test_proc might get renamed, because it'd be
4193 applicable to other commands too.
4195 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4197 * data-out.c: Clean up. Changed interface of convert_*() to take
4198 either a `double' or a `const char *' instead of a `const union
4199 value *'. Update all implementations of those interfaces.
4200 (data_out) Use switch statements instead of a table.
4201 (convert_AHEX) Rewrite.
4203 * format.h: Update comment.
4205 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4207 * q2c.c: (dump_header) Add an Emacs header line to output files
4208 that makes generated .c files read-only by default, to make it
4209 difficult to accidentally change generated files.
4211 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4213 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4214 not bogus a->v.c <=> b->v.c pointer compare.
4215 (compare_freq_alpha_a) Ditto.
4216 (compare_freq_numeric_d) Ditto.
4217 (compare_freq_alpha_d) Ditto.
4219 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4221 Changed data_out() to store string data directly into a `union
4222 value''s s member, not indirectly into c.
4224 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4226 (table_value_missing) Ditto.
4227 (float_M_suffix) Ditto.
4228 (format_short) New function.
4230 * data-in.h: (data_in_finite_line) Remove inline definition.
4232 * data-list.c: (destroy_dls_var_spec) New function.
4233 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4234 (data_list_source_destroy_source) Avoid cast.
4235 (struct repeating_data_trns) New field `id_value'. Update
4237 (cmd_repeating_data) Initialize id_value. Use new
4238 repeating_data_trns_free() for freeing REPEATING DATA
4240 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4241 (repeating_data_trns_free) New function.
4243 * data-out.c: (data_out) Change return type to `void' by replacing
4244 error returns by writing a message into the output buffer.
4245 (convert_A) Read from v->s instead of v->c.
4246 (convert_AHEX) Ditto.
4248 * expr-evl.c: Update comment.
4249 (expr_evaluate) Add assertion in OP_STRING case.
4251 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4253 * list.q: (list_cases) Update for new data_out() semantics.
4255 * print.c: (print_trns_proc) Ditto.
4257 * tab.c: (tab_value) Ditto.
4258 (tab_float) Avoid stupid cast.
4260 * var.h: Update comments.
4261 (macro MAX_STRING) New macro.
4262 (macro MAX_ELEMS_PER_VALUE) New macro.
4264 * vars-atr.c: (compare_values) New function.
4266 * vfm.c: (dump_splits) Update for new data_out() semantics.
4268 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4270 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4272 (struct crosstab) Rename v[] to vars[]. All references updated.
4273 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4274 same time, which caused the hash value to depend only on a single
4275 value, not all of the variables' values.
4277 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4279 Clean up struct dictionary's value_cnt usage.
4281 * dictionary.c: Add a function comment to each function.
4282 (struct dictionary) Rename value_cnt to next_value_idx, which more
4283 accurately reflects its meaning. All references updated.
4284 (dict_rename_vars) Add assertion.
4285 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4287 (dict_get_case_size) New function.
4289 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4291 * get.c: (mtf_read_nonactive_records) Ditto.
4293 * sort.c: (allocate_cases) Ditto.
4294 (write_initial_runs) Ditto.
4298 * vfm.c: (prepare_for_writing) Ditto.
4302 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4304 Make vfm.c slightly less grotesque.
4306 * vfm.c: (filter_var) Removed.
4307 (filter_index) Removed.
4308 (FILTERED macro) Removed.
4309 (exclude_this_case) New function.
4310 (process_active_file_write_case) Use exclude_this_case() instead
4311 of FILTERED and inline tests.
4312 (procedure_write_case) Ditto.
4313 (setup_filter) Removed.
4314 (open_active_file) Don't call setup_filter().
4315 (close_active_file) Call dict_get_filter() instead of checking
4318 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4320 * var.h: (struct variable) Update comments.
4322 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4324 New functions dict_create_var_assert(), dict_lookup_var_assert().
4325 Converted several dict_*_var()/assert pairs into a single
4326 dict_*_var_assert().
4328 * dictionary.c: (dict_create_var_assert) New function.
4329 (dict_lookup_var_assert) New function.
4331 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4333 Got rid of "struct long_vec", envector(), devector(), etc. Added
4334 two members `init', `reinit' to struct variable as a substitute.
4336 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4342 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4345 * autorecode.c: (cmd_autorecode) destvars don't need init.
4347 * compute.c: (lvalue_finalize) Set reinit.
4349 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4350 (dump_fmt_list) Ditto.
4353 * descript.q: (run_z_pass) Don't need init for z-scores.
4355 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4357 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4359 * glob.c: (init_glob) Remove vec_init() calls.
4361 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4363 * loop.c: (internal_cmd_loop) Don't need to call envector().
4365 * numeric.c: (cmd_numeric) Ditto.
4367 (cmd_leave) Ditto. Set `init', `reinit' members.
4369 * recode.c: (cmd_recode) Don't need to call envector().
4371 * repeat.c: (internal_cmd_do_repeat) Ditto.
4373 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4374 (force_create_variable) Removed prototype.
4375 (force_dup_variable) Ditto.
4377 * vector.c: (cmd_vector) Don't need to call envector().
4379 * vfm.c: (reinit_sysmis) Removed.
4380 (reinit_blanks) Removed.
4381 (init_zero) Removed.
4382 (init_blanks) Removed.
4383 (process_active_file_write_case) No need to deal with vectors.
4384 Call clear_temp_case().
4385 (vector_initialization) Rewrite to use `init', `reinit'.
4386 (close_active_file) No need to call vec_clear().
4387 (procedure_write_case) Call clear_temp_case().
4388 (clear_temp_case) New function.
4390 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4392 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4395 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4397 Add auxiliary argument to procedure() interface. Associated small
4398 clean-ups of vfm interface.
4400 * Updated every caller of procedure() and process_active_file() to
4401 reflect modified interface. Simple, ordinary changes not listed
4404 * Updated every function that implements struct case_stream's
4405 `read' function to take a write_case_func and a write_case_data.
4406 Also updated every caller of write_case() to instead call them
4407 through these arguments. In some cases this meant that the extra
4408 args had to be threaded through a couple of extra levels. This
4409 wasn't difficult or interesting so the details won't be given.
4411 * data-list.c: (struct repeating_data_trns) Add members
4412 `write_case', `wc_data' as kluge.
4413 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4415 (repeating_data_set_write_case) New function.
4417 * data-list.h: New file to declare repeating_data_trns_proc() and
4418 repeating_data_set_write_case().
4420 * inpt-pgm.c: (input_program_source_read) Call
4421 repeating_data_set_write_case() for all the REPEATING DATA
4422 transformations, so that they know where to send their cases.
4423 It's a big kluge. Also kluge in END CASE.
4424 (end_case_trns_proc) Never called anymore, but we still need it,
4427 * sort.c: (read_sort_output) Update to match struct case_stream
4430 * vfm.c: (struct write_case_data) New structure.
4431 (proc_func) Removed.
4432 (virt_proc_func) Removed.
4433 (begin_func) Removed.
4434 (virt_begin_func) Removed.
4436 (write_case) Removed.
4437 (procedure) Added an auxiliary parameter to each function pointer
4438 argument's prototype. Added an auxiliary data parameter.
4440 (process_active_file) Ditto.
4441 (process_active_file_write_case) Pass aux data along.
4442 (close_active_file) Ditto.
4443 (procedure_write_case) Ditto.
4444 (SPLIT_FILE_procfunc) Ditto.
4446 * vfm.h: (typedef write_case_data) New.
4447 (typedef write_case_func) New.
4448 (struct case_stream) Add parameters to `read' member prototype.
4450 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4452 * t-test.q: Added calculations for independent samples. (But no Levene
4455 * Makefile.am: Moved q_sources_c into own variable
4457 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4459 Miscellaneous cleanups.
4461 * Change unused to UNUSED in many source files to reflect modified
4462 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4463 __CYGWIN32__, __unix__, and unix not to assume that they're
4464 defined to a nonzero value. Change use of __attribute__ to use
4465 NO_RETURN or PRINTF_FORMAT instead.
4467 * alloc.h: Move definitions for local_alloc(), local_free() here
4468 from ../pref.h.orig and simplify.
4470 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4471 use a pool allocator unconditionally.
4472 (CHECK_STRING_SPACE) Removed.
4473 (ALLOC_STRING_SPACE) Removed.
4474 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4477 * expr-opt.c: (dump_expression) Allocate string pool.
4479 * expr-prs.c: (expr_free) Free string pool.
4481 * pool.c: (pool_destroy) This pool must be removed from its
4482 parent's list of gizmos, not from its own. Use free_all_gizmos().
4483 (pool_clear) New function.
4484 (free_all_gizmos) New function.
4485 (pool_alloc) Use space in empty block after this one if any.
4486 (pool_release) Only empty out blocks, don't actually free() them.
4488 * print.c: Get rid of PAGED_STACK special case by always
4489 dynamically allocating line buffers.
4490 (struct print_trns) Always include the `line' member.
4491 (internal_cmd_print) Always initialize the `line' member.
4492 (alloc_line) Always allocate memory for `line'.
4493 (print_trns_proc) Always initialize buf from `line' member.
4494 (print_trns_free) Always free `line' memory.
4496 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4499 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4501 * flip.c: Fixed crash from FLIP when a numeric variable is
4502 specified on NEWNAMES and a large value is used, and a couple of
4503 other minor bugs besides.
4504 (struct varname) Make name a 9-character fixed-size array
4505 instead of a 1-character variable size array.
4506 (make_new_var) Allow digits in variable names.
4507 (flip_stream_write) Limit numeric values to 8 characters and
4508 format system missing and very large and small values more
4511 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4513 * command.c: Fixed test on command return status for the correct
4514 value, which had been causing a crash under certain invalid input.
4516 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4518 * t-test.q: Added calculations for the one sample variant of the T-TEST
4520 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4522 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4523 in joined cells to be rendered outside box boundaries.
4525 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4527 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4528 SET seed=xx has been called.
4530 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4532 * random.c (rng_get_double): Fix always-returning-zero bug in my
4533 preferred way, and at the same time make sure rounding doesn't
4536 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4538 * html.c: (change_attributes) Dead code, removed.
4539 (escape_string) Eliminate code to call change_attributes() that
4540 never actually called it.
4541 (output_tab_table) Get rid of dependence on tab_hit
4542 and struct tab_joined_cell's hit member, which are abominations.
4544 * tab.c: (tab_output_text) Don't call
4545 d->class->text_set_font_by_name if it's a null pointer.
4546 (macro UNROLL_LOOP) Eliminate.
4547 (macro UNROLL_3_LOOPS) Eliminate.
4548 (tabi_render) Rewrite not to use the above macros.
4550 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4552 Start working on a new output driver system, one that doesn't suck
4553 so much, by adding a "device-independent" output driver. The idea
4554 is to write out only a single output stream, then use separate
4555 processes to translate them into whatever formats we want. This
4556 is similar to how "groff" works with its various output drivers
4557 (grops, grotty, grodvi, ...).
4559 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4561 * list.q: (write_all_headers) Stub out devind class.
4563 (determine_layout) Ditto.
4566 * output.c: (outp_init) Add devind class.
4568 * devind.c: New file.
4570 * devind.h: New file.
4572 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4574 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4575 to use the proper string length.
4577 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4579 * Fixed bug where FREQ would crash on alpha values
4581 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4583 * Removed bletcherous alloca() workarounds for AIX from top of
4584 many files. AIX can use the alternative alloca() implementation
4587 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4589 * ascii.c: (ascii_option) Fix implementation of headers option.
4591 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4593 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4594 multiple blank lines into one.
4595 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4596 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4597 (static var option_tab) Add squeeze entry.
4598 (ascii_option) Set squeeze_blank_lines.
4599 (output_lines) Implement squeezing blank lines.
4601 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4603 * Removed redundant code from output.h
4605 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4607 Dictionary classes: each variable is "ordinary", "system", or
4610 * var.h: (enum dict_class) New enum.
4612 * vars-prs.c: (dict_class_from_id) New function.
4613 (dict_class_to_name) New function.
4615 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4617 * var.h: (struct freq_tab_set) Removed (not used).
4619 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4621 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4623 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4625 * stats.c: (hypercube) Rename pow4(). All references updated.
4627 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4629 * rename-vars.c: (cmd_rename_variables) Rewritten.
4630 (compare_name) Removed.
4632 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4634 var_set feature, and code taking advantage of it.
4636 * crosstabs.q: (static var var_dict) Removed.
4637 (static var variables) New variable.
4638 (static var variables_cnt) New variable.
4639 (cmd_crosstabs) Free variables instead of var_dict.
4640 (internal_cmd_crosstabs) Initialize and use variables,
4641 variables_cnt instead of var_dict.
4642 (free_var_dict) Removed.
4643 (crs_custom_tables) Use var_set instead of a copied dictionary.
4644 (crs_custom_variables) Set up variables, variables_cnt instead of
4646 [DEBUGGING] (debug_print) Ditto.
4648 * means.q: (mns_custom_tables) Use var_set instead of a copied
4651 * vars-prs.c: (parse_vs_variable) New function.
4652 (parse_dict_variable) Rewritten.
4653 (parse_variable) Rewritten.
4654 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4655 (parse_variables) New function in terms of parse_var_set_vars().
4656 Now requires its first argument to be non-null. All references
4657 that passed a null pointer updated to pass default_dict instead.
4658 (macro id_dict) Removed.
4659 (parse_DATA_LIST_vars) Add assertions.
4660 (parse_mixed_vars) Ditto.
4661 (struct var_set) New structure.
4662 (var_set_get_cnt) New function.
4663 (var_set_get_var) New function.
4664 (var_set_lookup_var) New function.
4665 (var_set_destroy) New function.
4666 (dict_var_set_get_cnt) New function.
4667 (dict_var_set_get_var) New function.
4668 (dict_var_set_lookup_var) New function.
4669 (dict_var_set_destroy) New function.
4670 (var_set_create_from_dict) New function.
4671 (struct array_var_set) New structure.
4672 (array_var_set_get_cnt) New function.
4673 (array_var_set_get_var) New function.
4674 (array_var_set_lookup_var) New function.
4675 (array_var_set_destroy) New function.
4676 (var_set_create_from_array) New function.
4678 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4679 instead of parse_variables(NULL, ...) in output code.
4681 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4683 Change inp_init from a 2-bit vector to an ordinary array.
4684 Initialize it all in cmd_end_input_program() instead of in
4687 * inpt-pgm.c: (enum value_init_type) New enum.
4688 (global var inp_init) Change to `enum value_init_type *', make
4690 (inp_init_size) Removed.
4691 (inp_nval) Change to `size_t', make static.
4692 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4693 (cmd_end_input_program) Initialize inp_init, inp_nval.
4694 (init_case) Rewrite.
4695 (clear_case) Rewrite.
4697 * inpt-pgm.h: Removed.
4699 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4701 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4702 Colin Plumb hash. It is simpler and should better resist
4704 (hsh_hash_string) Ditto.
4706 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4708 * get.c: (export_write_case_func) Remove debug printing code.
4710 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4712 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4714 (save_write_case_func) Use &trns->h instead of cast.
4715 (cmd_export) Use &t->h instead of cast.
4717 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4719 Moved vectors into the dictionary.
4721 * var.h: (struct vector) Moved here from vector.h. `index' member
4722 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4725 * vector.h: Removed.
4727 * vector.c: (global var vec) Removed.
4728 (global var nvec) Removed.
4729 (cmd_vector) Rewritten.
4730 (find_vector) Removed.
4732 * dictionary.c: (dict_create_vector) New function.
4733 (dict_get_vector) New function, replaces reading global vec[]
4735 (dict_get_vector_cnt) New function, replaces reading global nvec
4737 (dict_lookup_vector) New function, replaces find_vector().
4738 (dict_clear_vectors) New function.
4740 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4742 Start to move away from `struct variable' p `union' member to void
4745 * var.h: (struct variable) Add `aux' member.
4747 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4749 Get rid of struct variable `foo' member.
4751 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4753 (frq_custom_variables) Ditto.
4754 (frq_custom_grouped) Ditto.
4756 * get.c: (struct save_trns) Change `var' member from `int *' to
4757 `struct variable **'.
4758 (cmd_save_internal) Use aux instead of foo.
4759 (save_trns_proc) Use revised `var' member.
4760 (static var mtf_seq_no) Renamed mtf_seq_num.
4761 (static var mtf_seq_nums) New static var.
4762 (cmd_match_files) Initialize mtf_seq_nums.
4763 (mtf_free) Free mtf_seq_nums.
4764 (mtf_processing) Use mtf_seq_nums instead of foo.
4765 (mtf_merge_dictionary) No need to initialize mv->foo.
4766 (cmd_export) Use aux instead of foo. Use revised `var' member.
4767 (mns_custom_tables) Don't use foo to check for duplicates, that's
4768 what PV_NO_DUPLICATE is for.
4770 * var.h: (struct variable) Remove `foo' member.
4771 (struct frequencies_proc) New member.
4773 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4775 Clean up COMPUTE and IF.
4777 * compute.c: More or less rewrite the darn thing.
4778 (struct compute_trns) Rename and reorder and add and delete
4780 (cmd_compute) Rewrite.
4781 (compute_num) Make conditional on test expression. Now used for
4782 both COMPUTE and IF.
4783 (compute_num_vec) Ditto.
4784 (compute_str) Ditto.
4785 (compute_str_vec) Ditto.
4788 (if_num_vec) Removed.
4790 (if_str_vec) Removed.
4791 (parse_target_expression) Renamed parse_rvalue_expression(),
4793 (new_trns) Renamed compute_trns_create(), rewritten.
4794 (delete_trns) Removed.
4795 (free_trns) Renamed compute_trns_free(), rewritten.
4796 (struct lvalue) New structure.
4797 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4798 (lvalue_get_type) New function.
4799 (lvalue_is_vector) New function.
4800 (lvalue_finalize) New function.
4801 (lvalue_destroy) New function.
4803 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4805 * command.def: Disallow MODIFY VARS in input mode, so that
4806 variables can't get dropped and confuse cmd_end_input_program()'s
4807 attempt to fill inp_init[].
4809 * modify-vars.c: (static var forward_positional_ordering) New
4811 (struct var_modification) Entirely changed.
4812 (rearrange_dict) Interface changed, rewritten.
4813 (cmd_modify_vars) Deal with modified struct var_modification, much
4815 (struct var_renaming) New structure.
4816 (compare_var_renaming_by_new_name) New function.
4817 (validate_var_modification) New function.
4819 * var.h: (struct modify_vars_proc) Removed.
4820 (struct variable) Removed member p.mfv.
4822 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4824 Make EVALUATE a valid command whether we're debugging or not, so
4825 that `make check' can succeed regardless of whether debugging is
4828 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4830 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4832 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4834 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4835 statement by a simple if test.
4837 * dfm.c: (dfm_get_record) Add assertion.
4839 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4841 For each file x.c, move #include "x.h" to the very top of the
4842 include list, to catch x.h failing to include the proper headers.
4844 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4846 * algorithm.c: (find) New function.
4847 (remove_equal) New function.
4848 (set_difference) New function.
4849 (adjacent_find_equal) New function.
4850 [TEST_UNIQUE] Removed test case.
4851 (copy_if) Find end test.
4853 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4855 * dictionary.c: (dict_get_case_weight) New convenience function.
4857 * aggregate.c: (accumulate_aggregate_info) Use
4858 dict_get_case_weight().
4860 * frequencies.q: (calc_general) Ditto.
4861 (calc_integer) Ditto.
4864 * t-test.q: (groups_calc) Ditto.
4867 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4869 * glob.c: (global var default_dict) Change from `struct
4870 dictionary' to `struct dictionary *'. All references changed.
4871 (init_glob) Initialize default_dict with dict_create().
4873 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4875 struct dictionary now made opaque. All related functions:
4877 * get.c: (rename_variables) Removed.
4878 (dict_delete_run) Removed.
4880 * temporary.c: (copy_variable) Removed.
4881 (new_dictionary) Removed.
4882 (save_dictionary) Removed.
4883 (restore_dictionary) Removed.
4884 (free_dictionary) Removed.
4886 * vars-atr.c: (clear_default_dict) Removed.
4887 (find_variable) Removed.
4888 (find_dict_variable) Removed.
4889 (create_variable) Removed.
4890 (delete_variable) Removed.
4891 (common_init_stuff) Removed.
4892 (init_variable) Removed. Updating of inp_init moved into
4893 cmd_end_input_program().
4894 (replace_variable) Removed.
4895 (rename_variable) Removed.
4896 (clear_variable) Removed.
4897 (dup_variable) Removed.
4899 * vars-prs.c: (is_varname) Removed.
4900 (is_dict_varname) Removed.
4901 (fill_all_vars) Removed.
4903 * vector.c: (find_vector) Removed.
4905 * weight.c: (stop_weighting) Removed.
4907 * dictionary.c: New file.
4908 (dict_create) New, replaces new_dictionary().
4909 (dict_clone) New, replaces save_dictionary() and
4910 restore_dictionary().
4911 (dict_clear) New, replaces clear_default_dict().
4912 (dict_destroy) New, replaces free_dictionary().
4913 (dict_get_var_cnt) New function, replaces references to
4915 (dict_get_var) New function, replaces references to dict->var[i].
4916 (dict_get_vars) New function, replaces fill_all_vars().
4917 (dict_create_var) New, replaces create_variable(). Interface
4918 drops `type' parameter, using a zero `width' to designate numeric.
4919 (dict_clone_var) New, replaces dup_variable().
4920 (dict_rename_var) New, replaces rename_variable().
4921 (dict_lookup_var) New, replaces find_variable(),
4922 find_dict_variable(), is_varname().
4923 (dict_contains_var) New function.
4924 (compare_variable_dblptrs) New function.
4925 (dict_delete_var) New function, replaces clear_variable().
4926 (dict_delete_vars) New function, replaces dict_delete_run().
4927 (dict_reorder_vars) New function.
4928 (dict_rename_vars) New function, replaces rename_variables().
4929 (dict_get_weight) New function, replaces reading dict->weight_var.
4930 (dict_set_weight) New function, replaces writing dict->weight_var
4931 or calling stop_weight(dict).
4932 (dict_get_filter) New function, replaces reading dict->filter_var.
4933 (dict_set_filter) New function, replaces writing dict->filter_var.
4934 (dict_get_case_limit) New function, replaces reading dict->N.
4935 (dict_set_case_limit) New function, replaces writing dict->N.
4936 (dict_get_value_cnt) New function, replaces reading dict->nval.
4937 (dict_compact_values) New function, replaces a loop that was
4938 replicated in several places.
4939 (dict_get_split_vars) New function, replaces reading dict->splits.
4940 (dict_get_split_cnt) New function, replaces reading
4942 (dict_set_split_vars) New function, replaces writing dict->splits.
4943 (dict_get_label) New function, replaces reading dict->label.
4944 (dict_set_label) New function, replaces writing dict->label.
4945 (dict_get_documents) New function, replaces reading
4947 (dict_set_documents) New function, replaces writing
4950 All references to above functions updated.
4952 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4953 old dictionary to new by hand, because dict_create() can't do it
4954 itself. Use dict_set_documents(), dict_set_split_vars().
4956 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4957 calling dict_destroy().
4959 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4961 (fixed_parse_compatible) Some slightly nontrivial changes for
4963 (dump_fmt_list) Ditto.
4966 * file-type.c: (create_col_var) Ditto.
4968 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4969 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4970 (rename_variables) Use dict_rename_vars().
4971 (mtf_merge_dictionary) Use dict_get_documents(),
4972 dict_set_documents(), dict_compact_values().
4974 * pfm-read.c: (read_variables) Deal with changes to weighting.
4976 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4977 is_varname() in output code.
4979 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4980 other dictionary functions.
4982 * title.c: (add_document_line) Use dict_get_documents(),
4983 dict_set_documents().
4985 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4986 reset default_handle by hand. dict_clear() will clear vectors so
4987 there's no need for that by hand.
4989 * vfm.c: (close_active_file) Move call to finish_compaction()
4990 earlier, so that we can do the compaction as a single step using
4991 dict_compact_values(). Use dict_clear_vectors().
4992 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4994 Some functions don't have replacements:
4996 * vars-atr.c: (force_create_variable) Removed. All references
4997 updated to dict_create_var() followed by an assertion.
4998 (force_dup_variable) Removed. All references updated to
4999 dict_clone_var() followed by an assertion.
5001 * weight.c: (update_weighting) Removed. No longer necessary, so
5002 all references removed.
5004 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
5008 * aggregate.c: Eliminate separation of weighted and unweighted
5009 case. It made the code too obscure and I doubt it was actually
5010 faster. Instead, all code uses the "weighted" code, because
5011 that's a generalization of the "unweighted" code.
5014 (parse_aggregate_functions) No need to set FWEIGHT.
5015 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5016 (dump_aggregate_info) Ditto.
5017 (initialize_aggregate_info) No need for special plain_function
5018 that gets rid of FWEIGHT option.
5020 * aggregate.c: Get rid of approximations.
5021 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5023 (aggregate_single_case) Don't use approx_ne().
5025 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5027 * ascii.c (ascii_line_width): Dead code, removed.
5029 * postscript.c (ps_line_width): Ditto.
5031 * q2c.c (xrealloc): Ditto.
5033 * count.c (internal_cmd_count): Ditto.
5035 * means.q (validate_dependent_endpoint): Ditto.
5037 * set.q: (cmd_gset) Ditto.
5039 * weight.c: [0] (weight_trns_proc) Ditto.
5041 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5043 Make the code -Wmissing-prototypes clean.
5045 * Makefile.am (version.c): Add #include "version.h".
5047 * ascii.c: (ascii_open_global) Make static.
5048 (ascii_close_page) Ditto.
5049 (ascii_font_sizes) Ditto.
5050 (ascii_postopen_driver) Ditto.
5051 (ascii_close_driver) Ditto.
5052 (ascii_option) Ditto.
5053 (ascii_open_page) Ditto.
5054 (ascii_line_horz) Ditto.
5055 (ascii_line_vert) Ditto.
5056 (ascii_line_intersection) Ditto.
5058 (ascii_polyline_begin) Ditto.
5059 (ascii_polyline_point) Ditto.
5060 (ascii_polyline_end) Ditto.
5061 (ascii_text_set_font_by_name) Ditto.
5062 (ascii_text_set_font_by_position) Ditto.
5063 (ascii_text_set_font_by_family) Ditto.
5064 (ascii_text_get_font_name) Ditto.
5065 (ascii_text_get_font_family) Ditto.
5066 (ascii_text_set_size) Ditto.
5067 (ascii_text_get_size) Ditto.
5068 (ascii_text_metrics) Ditto.
5069 (ascii_text_draw) Ditto.
5070 (ascii_close_page) Ditto.
5072 * cmdline.h: New header for parse_command_line(). Used where
5075 * command.c: Move prototypes for cmd_*() functions to command.h.
5077 * command.h: Prototypes for cmd_*() functions moved here from
5080 * crosstabs.q: (gamma_int) Ditto.
5082 * file-handle.h: Add fh_init_files() prototype.
5084 * getline.c: (welcome) Ditto.
5086 * glob.h: New header for init_glob(). Used where appropriate.
5088 * hash.c: (comparison_helper) Ditto.
5090 * html.c: (html_open_global) Ditto.
5091 (html_close_global) Ditto.
5092 (html_preopen_driver) Ditto.
5093 (html_postopen_driver) Ditto.
5094 (html_close_driver) Ditto.
5095 (html_option) Ditto.
5096 (html_open_page) Ditto.
5097 (html_close_page) Ditto.
5098 (html_submit) Ditto.
5100 * inpt-pgm.c: (input_program_source_read) Ditto.
5102 * output.c: (find_defn_value) Ditto.
5103 (destroy_list) Ditto.
5105 * pfm-read.c: (read_int) Ditto.
5107 * postscript.c: (ps_open_global) Ditto.
5108 (ps_close_global) Ditto.
5109 (ps_font_sizes) Ditto.
5110 (ps_preopen_driver) Ditto.
5111 (ps_postopen_driver) Ditto.
5112 (ps_close_driver) Ditto.
5114 (ps_open_page) Ditto.
5115 (ps_close_page) Ditto.
5116 (ps_line_horz) Ditto.
5117 (ps_line_vert) Ditto.
5118 (ps_line_intersection) Ditto.
5120 (ps_polyline_begin) Ditto.
5121 (ps_polyline_point) Ditto.
5122 (ps_polyline_end) Ditto.
5123 (ps_text_set_font_by_name) Ditto.
5124 (ps_text_set_font_by_position) Ditto.
5125 (ps_text_set_font_family) Ditto.
5126 (ps_text_get_font_name) Ditto.
5127 (ps_text_get_font_family) Ditto.
5128 (ps_text_set_size) Ditto.
5129 (ps_text_get_size) Ditto.
5130 (ps_text_metrics) Ditto.
5131 (ps_text_draw) Ditto.
5133 * q2c.c: (finish_up) Ditto.
5142 (find_symbol) Ditto.
5145 (force_string) Ditto.
5147 (match_token) Ditto.
5150 (parse_setting) Ditto.
5151 (parse_specifier) Ditto.
5152 (parse_specifiers) Ditto.
5153 (parse_subcommand) Ditto.
5154 (dump_specifier_vars) Ditto.
5156 (make_identifier) Ditto.
5157 (dump_declarations) Ditto.
5158 (dump_specifier_init) Ditto.
5159 (dump_vars_init) Ditto.
5161 (dump_specifier_parse) Ditto.
5162 (dump_subcommand) Ditto.
5163 (dump_parser) Ditto.
5164 (dump_header) Ditto.
5166 (recognize_directive) Ditto.
5168 * recode.c: (string_to_long) Ditto.
5170 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5172 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5175 * sort.c: (sort_stream_read) Ditto.
5176 (sort_stream_mode) Ditto.
5178 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5180 * algorithm.c (binary_search): Fix comparison.
5182 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5184 * algorithm.c: (binary_search) Fix assertion.
5186 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5188 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5190 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5192 * sort.c: (compare_case_lists) Rewrite.
5194 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5196 * quicksort.c: Removed (not used).
5198 * quicksort.h: Removed (not used).
5200 * sort.c: Removed blp_quicksort() prototype.
5202 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5204 * postscript.c: (int_2_compare) Rewrite.
5205 (compare_line) Rewrite.
5207 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5209 * matrix-data.c (compare_factors) Use lexicographical_compare()
5211 (compare_doubles) New function.
5213 * algorithm.c: (lexicographical_compare) New algorithm.
5215 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5217 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5219 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5221 * expr-prs.c: (cmp_func) Removed.
5222 (parse_function) Use binary_search() algorithm.
5223 (compare_functions) New function.
5224 (init_func_tab) Use sort() algorithm.
5226 * algorithm.c: (binary_search) New algorithm.
5228 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5230 * descript.q: (display) Use sort() algorithm instead of qsort().
5231 (compare_func) Removed.
5232 (descriptives_compare_variables) New function.
5234 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5236 Get rid of AVL trees. Hashes are more appropriate for everything
5239 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5245 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5247 Much code can be clarified by using C++ STL-like algorithms. Not
5248 all uses of these algorithms are listed below, only the ones where
5249 the change to an algorithm was the only change of interest.
5251 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5253 * algorithm.c: New file.
5255 * algorithm.h: New file.
5257 * modify-vars.c: (static var forward) Removed.
5258 (static var positional) Removed.
5259 (compare_variables) Removed.
5260 (struct ordering) New.
5261 (cmd_modify_vars) Use sort() algorithm.
5262 (compare_variables_given_ordering) New function.
5263 (rearrange_dict) Use sort() algorithm.
5265 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5266 (cmp_var_by_name) Removed.
5268 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5270 Make file handles use a hash table.
5272 * file-handle.q: (files) Change to hash table, make static.
5273 (cmd_file_handle) Use hash table functions.
5274 (fh_get_handle_by_filename) Ditto.
5275 (fh_get_handle_by_name) Ditto.
5276 (hash_file_handle) New function.
5277 (cmp_file_handle) Rewrite.
5278 (fh_init_files) Use hash table functions.
5280 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5282 Clean up FREQUENCIES.
5284 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5286 * frequencies.q: Remove a lot of old #if'd out code at the end.
5287 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5288 or calc_weight(). Initialize percentile_values.
5289 (calc) New function based on calc_weight() from frequencies.g.
5290 (precalc) Use hash functions.
5291 (static var comparison_func) Removed.
5292 (static var comparison_param) Removed.
5293 (comparison_helper) Removed.
5294 (get_freq_comparator) New function.
5295 (not_missing) New function.
5297 (postprocess_freq_tab) Use hash table functions, algorithms,
5298 get_freq_comparator(). Rewrite.
5299 (cleanup_freq_tab) Rephrase.
5300 (add_percentile) Clean up spacing.
5301 (hash_value_numeric) New function.
5302 (hash_value_alpha) New function.
5303 (compare_value_numeric_a) Rewrite.
5304 (compare_value_alpha_a) Rewrite.
5305 (compare_value_numeric_d) Rewrite.
5306 (compare_value_alpha_d) Rewrite.
5307 (compare_freq_numeric_a) Rewrite.
5308 (compare_freq_alpha_a) Rewrite.
5309 (compare_freq_numeric_d) Rewrite.
5310 (compare_freq_alpha_d) Rewrite.
5311 (calc_stats) Clean up mode, percentiles, max.
5312 (dump_statistics) Clean up spacing.
5314 * frequencies.g: Removed.
5316 * var.h: (struct freq_tab) Change `data' to hash table.
5318 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5320 * file-handle.h: Remove declaration of global variable `files',
5321 which wasn't used anywhere.
5323 * postscript.c: (add_encoding) Remove superfluous cast.
5326 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5329 * temporary.c: [0] (display_tree) Removed.
5331 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5333 Implement a new random number generator based on the alleged RC4
5336 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5339 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5340 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5342 (static var V[]) Removed.
5343 (static var Y) Removed.
5344 (static var X2) Removed.
5345 (setup_randomize) Removed.
5347 (rand_uniform) Removed.
5348 (rand_normal) Removed.
5349 (struct rng) New structure.
5350 (rng_create) New function.
5351 (rng_destroy) New function.
5352 (swap_byte) New static function.
5353 (rng_seed) New function.
5354 (rng_get_bytes) New function.
5355 (rng_get_int) New function.
5356 (rng_get_unsigned) New function.
5357 (rng_get_double) New function.
5358 (rng_get_double_normal) New function.
5359 (pspp_rng) New function.
5361 * random.h: Sync up to random.c.
5363 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5364 fraction of UINT_MAX, not 65536.
5365 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5368 * vfm.c: (open_active_file) No need to call setup_randomize() any
5371 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5373 Change dictionary name indexes to use hash tables instead of AVL
5376 * crosstabs.q: (free_var_dict) Use hash tables.
5377 (crs_custom_tables) Ditto.
5378 (calc_general) Ditto.
5379 (compare_table_entry) Rewrite.
5380 (enum_var_values) Reorder parameters. All references updated.
5383 * get.c: (rename_variable) Use hash tables.
5384 (mtf_merge_dictionary) Ditto.
5386 * glob.c: (init_glob) Use hash tables.
5387 (cmp_variable) Removed.
5389 * means.q: (mns_custom_tables) Use hash tables.
5391 * modify-vars.c: (rearrange_dict) Use hash tables.
5393 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5395 * sfm-read.c: (read_header) Use hash tables.
5396 (read_variables) Ditto.
5398 * temporary.c: (new_dictionary) Use hash tables.
5399 (save_dictionary) Ditto.
5400 (restore_dictionary) Ditto.
5402 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5403 hash table `name_tab'.
5405 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5406 [DEBUGGING] (dump_var_tree) Removed.
5407 (find_variable) Use hash tables.
5408 (find_dict_variable) Ditto.
5409 (common_init_stuff) Ditto.
5410 (rename_variable) Ditto.
5411 (clear_variable) Ditto. Also, remove debug code.
5412 (dup_variable) Use hash tables.
5414 * vars-prs.c: (fill_all_vars) Use hash tables.
5415 (is_dict_varname) Ditto.
5416 (parse_dict_variable) Ditto.
5418 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5420 Change value labels to use hash tables instead of AVL trees, and
5421 change value labels into an ADT.
5423 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5425 * value-labels.c: New file.
5427 * value-labels.h: New file.
5429 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5430 Get rid of a stupid use of goto.
5432 * autorecode.c: (compare_alpha_value) Rewrite.
5433 (hash_alpha_value) Ditto.
5434 (compare_numeric_value) Rewrite.
5435 (hash_numeric_value) Ditto.
5437 * frequencies.q: (dump_full) Use value label ADT.
5439 * pfm-read.c: (read_value_label) Use value label ADT.
5441 * pfm-write.c: (write_value_labels) Use value label ADT.
5443 * sfm-read.c: (read_variables) Use value label ADT.
5444 (read_value_labels) Rewrite.
5446 * sfm-write.c: (write_value_labels) Rewrite.
5448 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5449 (display_variables) Ditto.
5450 (describe_variable) Ditto.
5452 * t-test.q: (print_t_groups) Use value label ADT.
5454 * temporary.c: (copy_variable) Use value label ADT.
5455 (free_dictionary) Ditto.
5457 * val-labs.c: (verify_val_labs) Use value label ADT.
5459 (debug_print) Ditto.
5460 (val_lab_cmp) Removed.
5461 (inc_ref_count) Removed.
5462 (copy_value_labels) Removed.
5464 * var.h: (struct value_label) Removed.
5465 (struct variable) Change AVL tree `val_lab' into hash table
5468 * vars-atr.c: (init_variable) Use value label ADT.
5469 (clear_variable) Ditto.
5470 (free_value_label) Removed.
5471 (free_val_lab) Removed.
5472 (get_val_lab) Removed.
5473 (compare_variables) New function.
5474 (hash_variable) New function.
5476 * vfm.c: (dump_splits) Use value label ADT.
5478 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5480 Add to the hash table interface.
5482 * hash.c: (hsh_hash_bytes) Add assertion.
5483 (hsh_hash_string) Ditto.
5487 (hsh_create) Ditto. Also make minimum `size'.
5488 (hsh_destroy) Rephrase.
5489 (sort_nulls_last) Removed.
5490 (not_null) New function.
5492 (comparison_helper) Ditto.
5493 (hsh_sort) Rewritten.
5494 (hsh_data_copy) New function.
5495 (hsh_sort_copy) Ditto.
5497 (hsh_replace) Ditto.
5498 (hsh_hash_double) Ditto.
5499 (hsh_delete) Fix stupid bug.
5501 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5502 * added a calculation of the mode to FREQUENCIES
5504 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5506 * moved (un)defs of DEBUGGING to config.h
5508 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5510 * groff-font.c: (add_kern) Fix indentation.
5511 (add_kern) Use & instead of % to take power-of-2 modulus.
5512 (font_get_kern_adjust) Likewise.
5514 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5516 * autorecode.c: (recode) Replace stupid use of memcpy() by
5518 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5519 (hash_numeric_value) Ditto.
5520 (autorecode_proc_func) pool_strdup() was wrong here because the
5521 source string was not null-terminated. Use new pool_strndup()
5524 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5525 use of hsh_iterator_init().
5527 * data-in.c: (parse_N) Initialize i->v->f.
5529 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5532 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5533 (groff_read_font) Don't call hsh_next_prime(). Don't call
5535 (static var hash) Remove `size_p', `max_used' members.
5536 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5537 hsh_hash_string() instead of hashpjw(), & instead of %.
5538 (default_font) Don't call hsh_next_prime().
5540 * pool.c: (pool_strndup) New function.
5541 (pool_strdup) Reimplement in terms of pool_strndup.
5543 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5545 (hash_ps_encoding) Use hsh_hash_string().
5546 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5547 (hash_filename2font) Use hsh_hash_string().
5549 * som.c: Add #include <stdlib.h>.
5551 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5552 (by destroying its pool).
5554 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5556 Miscellaneous hash table code cleanup:
5558 * hash.h: (struct hsh_table) Moved into hash.c.
5559 (hsh_count) Ditto, and transformed into function.
5560 (hsh_compare_func) New typedef, used for defining otherwise-long
5561 function types here and in hash.c
5562 (hsh_hash_func) Ditto.
5563 (hsh_free_func) Ditto.
5565 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5566 `table' to `entries'. Removed `mp'. All references updated.
5567 (hsh_clear) Don't shrink entries array; if the hash was this big
5568 once, it probably will be again.
5569 (hsh_rehash) Made static.
5570 (force_hsh_insert) Renamed hsh_force_insert.
5571 (force_hsh_find) Renamed hsh_force_find.
5573 Made hash table sizes powers of 2, because that's fine with any
5574 reasonable hash function and because taking a power-of-2 modulus
5575 is faster than any other:
5577 (hsh_prime_tab) Removed;
5578 (hsh_next_prime) Ditto.
5579 (next_power_of_2) New function.
5580 (hsh_create) Use next_power_of_2.
5581 (hsh_rehash) Use & instead of %.
5583 Cleaned up hsh_sort:
5585 (internal_comparison_fn) Removed.
5586 (sort_nulls_last) New function.
5587 (hsh_sort) Removed second parameter, switched to using the new
5588 quicksort() function from quicksort.h to avoid using nasty need
5589 for static variables with qsort(). All references updated.
5591 Changed the hash functions offered, because there are better hash
5592 functions than the ones we had, and cleaned up the names to boot:
5594 * hash.c: (hashpjw_d) Removed.
5596 (hsh_hash_bytes) New function.
5597 (hsh_hash_string) New function.
5598 (hsh_hash_int) New function.
5600 Improved the hash table iteration interface:
5602 * hash.h: (hsh_iterator_init) Removed.
5603 (struct hsh_iterator) Removed `init' member, change `next' to
5606 * hash.c: (hsh_foreach) Removed. All references updated to use
5607 hsh_first/hsh_next instead.
5608 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5609 not treat a null pointer as an empty hash table.
5610 (hsh_next) New function.
5612 Made deletion possible, though slow:
5614 * hash.c: (locate_matching_entry) New function.
5615 (hsh_find) Use locate_matching_entry().
5616 (hsh_delete) New function also using locate_matching_entry().
5617 (hsh_force_delete) New function.
5619 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5621 * quicksort.c: New file implementing a sort routine with a
5622 interface better than qsort() because it passes a user-provided
5623 parameter to the sort routine.
5625 * Makefile.am: Add quicksort.c, quicksort.h.
5627 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5629 * All source files: Get rid of nasty special cases for Checker,
5630 which is pretty obsolete now.
5632 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5634 * Fixed a bug apparent when using the FREQUENCIES command with the
5635 html driver. The html driver was incorrectly trying to display
5638 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5640 * Makefile.am: Reorganized. Put locale dir in version.c instead
5641 of passing it to each compile command. Only put local gmp libs in
5642 LD_ADD if not installed on system. Remove `boast' target.
5644 * All source files: struct and union typedefs eliminated.
5645 `sizeof type' replaced by `sizeof object' where practical. Moved
5646 `unused' qualifiers from start to end of declarations for gcc
5647 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5648 assertions on pointers strictly compliant. Removed _ prefixes on
5649 some function parameter names.
5651 * alloc.c: New source file, containing these external linkage
5652 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5659 * ascii.c: Migrated from arenas to pools.
5660 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5661 c_string to len_string. All references changed.
5662 (ascii_option) Signature changed to comply to new output.c
5664 (count_fancy_chars) Removed.
5665 (delineate) Removed support for rich text.
5666 (ascii_text_metrics) Ditto.
5668 (output_shorts) Change `box', `off', `on' from c_string to
5669 len_string. Change `remaining' from int to size_t.
5670 (ascii_close_page) Make page numbering less haphazard.
5672 * autorecode.c: Migrate from arenas to pools.
5674 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5676 * bitvector.h: New file containing these macros from misc.h:
5677 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5679 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5680 word[3]. ncmd removed.
5681 (var empty_string) Removed.
5682 (var cmd_table) Declaration updated.
5683 (var cmdtab) Removed.
5684 (cmp_command) Removed.
5685 (split_words) Rewritten to use strtok_r().
5686 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5687 (find_command) Removed.
5688 (FILE_TYPE_okay) Rewritten.
5689 (cmd_parse) Rewritten. Semantics of the return value of command
5690 handlers has changed: they must now return one of the new CMD_*
5691 enumerals, rather than a magic value. This meant that all
5692 commands had to be modified, and they were.
5693 (figure_out_command) New function.
5695 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5696 #defines for INIT, INPU, etc.
5698 * command.h: New CMD_* enum series.
5699 (cur_proc) Make const char *, not char *.
5700 (cmd_init) Prototype.
5703 * common.c: Removed.
5705 * common.h: Removed.
5707 * correlations.q: New file.
5709 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5711 (custom_tables) Renamed crs_custom_tables().
5712 (custom_variables) Renamed crs_custom_variables().
5713 (calc_integer) Add in some `const' qualifiers.
5714 (table_value_missing) Change from a_string to len_string.
5715 (float_M_suffix) Change from a_string to len_string.
5717 * data-in.c: Rewritten. All references to
5718 parse_string_as_format() changed to data_in().
5720 * data-in.h: New file.
5722 * data-list.c: Change DLS_* from #define's to enums. Move from
5723 rpd_msg() to tmsg().
5724 (RPD_ERR) New #define.
5725 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5727 (read_from_data_list_fixed) Change from old
5728 parse_string_as_format() to new data_in().
5729 (read_from_data_list_free) Ditto.
5730 (read_from_data_list_list) Ditto.
5731 (cmd_repeating_data) Modify approach to checking for end of
5734 (rpd_parse_record) Change from old parse_string_as_format() to new
5735 data_in(). Change from old convert_format_to_string() to new
5737 (read_one_set_of_repetitions) Change dfm_push_cust() to
5738 dfm_push(), pop_cust() to dfm_pop().
5740 * data-out.c: Rewritten. All references to
5741 convert_format_to_string() changed to data_out().
5743 * descript.q: Migrate to new q2c.
5744 (cmd_descriptives) Removed.
5745 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5746 (custom_variables) Renamed dsc_custom_variables().
5748 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5750 (open_file_r) Initialize h->where.line_number. Migrate to new
5752 (open_file_w) Initialize h->where.line_number.
5753 (read_record) Change from ext->ln to h->where.line_number.
5754 Migrate to struct string.
5755 (dfm_put_record) Rephrased.
5756 (dfm_push_cust) Renamed dfm_push(), rewritten.
5757 (dfm_pop) New function.
5759 * error.c: All references updated.
5760 (glob var error_count) Renamed err_err_count.
5761 (glob var warning_count) Renamed err_warning_count.
5762 (glob var error_already_flagged) Renamed err_already_flagged.
5763 (glob var verbosity) Renamed err_verbosity.
5764 (glob var cust_fn) Removed.
5765 (glob var cust_ln) Removed.
5766 (static var file_loc) New.
5767 (static var nfile_loc) New.
5768 (static var mfile_loc) New.
5769 (tmsg) New function.
5770 (push_cust) Removed.
5773 (static var terminating) Removed.
5774 (failure) Renamed err_failure().
5775 (hcf) Renamed err_hcf().
5776 (err_push_file_locator) New function.
5777 (err_pop_file_locator) New function.
5778 (err_location) New function.
5779 (check_error_count) Renamed err_check_count().
5780 (vmsg) Renamed err_vmsg(). Interface changed.
5781 (verbose_msg) Removed.
5782 (err_cond_fail) New function.
5783 (error_break) Renamed err_break().
5785 * error.h: All references updated.
5786 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5787 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5789 (struct file_locator) New.
5791 (macro verbose_msg) Removed.
5792 (macro cond_fail) Removed.
5794 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5796 * expr-prs.c: Reorganized. All references updated.
5797 (exprtypename) Renamed expr_type_name().
5798 (typename) Renamed type_name().
5799 (free_expression) Renamed expr_free().
5800 (parse_expression) Renamed expr_parse(). Uses new type_check()
5802 (init_functab) Renamed init_func_tab().
5803 (type_check) New function.
5804 (parse_or) Rewritten to use new allocate_nonterminal() and
5805 append_nonterminal_arg() functions.
5808 (parse_rel) Ditto. Also simplified logic.
5813 (SYSMIS_func) Ditto.
5814 (VALUE_func) Rephrased.
5815 (CONCAT_func) Fix memory leak by replacing free by free_node on
5817 (generic_str_func) Ditto.
5818 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5820 (allocate_nonterminal) New function.
5821 (append_nonterminal_arg) New function.
5822 (static func_tab[]) Now at file level.
5824 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5826 * expr.h: (enum series OP_*) Moved to exprP.h.
5827 (OP_* defines) Ditto.
5828 (struct op_desc) Ditto.
5829 (global ops[]) Ditto.
5830 (struct num_con_node) Ditto.
5831 (struct str_con_node) Ditto.
5832 (struct var_node) Ditto.
5833 (struct lag_node) Ditto.
5834 (struct casenum_node) Ditto.
5835 (struct nonterm_node) Ditto.
5836 (union any_node) Members renamed.
5837 (struct sys_node) Removed.
5838 (struct val_node) Removed.
5839 (operator typedef) Removed.
5840 (typedef exprtype) Removed.
5841 (enum series EX_*) Moved to exprP.h.
5842 (struct expression) Ditto. Also renamed a lot of the members.
5843 (PXP_* defines) Changed to enums.
5844 (free_node prototype) Moved to exprP.h.
5846 * file-handle.h: (struct file_handle) New member `where'.
5848 * file-handle.q: Migrated to new q2c format.
5849 (prepend_current_directory) Removed (dead code).
5850 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5851 (fh_get_handle_by_filename) Removed dead code.
5852 Set new `where' member.
5854 * file-type.c: (file_type_source_read) References to
5855 parse_string_as_format() changed to data_in().
5856 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5858 * filename.c: All references updated.
5859 (init_filename) Renamed fn_init().
5860 (expand_line) Removed.
5861 (macro EXPAND_LINE) Removed.
5862 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5863 of custom functions.
5864 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5865 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5866 (normalize_filename) Renamed fn_normalize().
5867 (search_path) Renamed fn_search_path(), rewritten.
5868 (prepend_dir) Renamed fn_prepend_dir().
5869 (blp_getenv) Renamed fn_getenv().
5870 (blp_dirname) Renamed fn_dirname().
5871 (fn_basename) New function, not used.
5872 (absolute_filename_p) Renamed fn_absolute_p().
5873 (is_special_filename) Renamed fn_special_p().
5874 (file_exists) Renamed fn_exists_p().
5875 (readlink_malloc) Renamed fn_readlink().
5876 (getenv_default) Renamed fn_getenv_default().
5877 (open_file) Renamed fn_open().
5878 (close_file) Renamed fn_close().
5879 (open_file_ext) Renamed fn_open_ext().
5880 (close_file_ext) Renamed fn_close_ext().
5882 * font.h: Migrate from arenas to pools.
5884 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5886 * frequencies.g: Migrate from arenas to pools.
5888 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5891 * getline.c: All references updated.
5892 (global getl_buf) Changed from char * to struct string.
5893 (static getl_include_path) Ditto.
5894 (global getl_buf_len) Removed.
5895 (global getl_buf_size) Removed.
5896 (getl_include_path) Deal with new getl_buf, getl_include_path.
5897 (getl_uninitialize) New function.
5898 (getl_get_current_directory) Rewritten.
5899 (getl_clear_include_path) Rewritten.
5900 (getl_add_include_dir) Rewritten.
5901 (getl_add_file) Assertion fixed.
5902 (getl_add_virtual_file) Change initial value of `remaining_loops'
5904 (welcome) Rewritten.
5905 (handle_line_buffer) Make static. Change logic to make
5906 getl_add_virtual_file() change sensible. Use ds_*() strings.
5907 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5908 (getl_close_file) Moved.
5909 (getl_location) New function.
5911 * getline.h: All references updated.
5912 (macro curln) Removed.
5913 (macro curfn) Removed.
5914 (macro am_interactive) Renamed getl_am_interactive.
5915 (macro am_reading_script) Renamed getl_reading_script.
5917 * glob.c: (global fmt_parse_ignore_error) Removed.
5918 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5919 systems that support it (C99). Turn off SET ECHO by default. No
5920 necessary julcal initialization anymore.
5922 * groff-font.c: Migrate from arenas to pools.
5923 (groff_read_font) Use err_push_file_locator().
5924 (groff_read_DESC) Ditto.
5925 (font_msg) Use tmsg().
5927 * hash.c: (hsh_sort) Fix debug code.
5928 [GLOBAL_DEBUGGING] Include stdio.h.
5930 * hash.h: (macro force_hsh_insert) Rephrase.
5932 * heap.c: Rewritten.
5934 * heap.h: Rewritten.
5936 * html.c: (html_option) Change from outp_value to struct string.
5937 (postopen) Change from curfn to getl_location().
5938 (escape_string) Remove rich-text code. Signature changed.
5939 (output_tab_table) Switch from a_string to struct len_string.
5940 Remove rich text support.
5942 * lexer.c: All references updated. Largely rewritten. Major
5943 changes listed below. Removed tagged quote support. Adapted to
5944 struct string tokstr.
5945 (global tokstr) Changed to struct string.
5946 (global tokstr_size) Removed.
5947 (global tokstr_len) Removed.
5949 (global tokint) Removed.
5950 (global toklongstr) Removed.
5951 (C* defines) Removed.
5952 (static tbl[]) Removed.
5953 (static id[]) Removed.
5954 (static une[]) Removed.
5955 (discard_line) Renamed lex_discard_line().
5956 (get_entire_line) Renamed lex_entire_line().
5957 (get_rest_of_line) Renamed lex_rest_of_line().
5958 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5959 (make_hexit) Removed.
5960 (syntax_error) Renamed lex_error(). Return value removed.
5961 (get_token_representation) Renamed lex_token_representation().
5962 (putback) Renamed lex_put_back().
5963 (putfwd) Renamed lex_put_forward().
5964 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5965 (set_prog) Renamed lex_set_prog().
5966 (init_lex) Renamed lex_init().
5967 (reset_eof) Renamed lex_reset_eof().
5968 (lookahead) Renamed lex_look_ahead().
5969 (check_id) Rewritten.
5970 (yylex) Renamed lex_get(), rewritten.
5971 (lex_end_of_command) New function. Many commands were rephrased
5973 (lex_integer_p) New function. Replaces compare of tokint against
5975 (lex_integer) New function. Replaces tokint.
5976 (match_tok) Renamed lex_match().
5977 (match_id) Renamed lex_match_id().
5978 (match_int) Renamed lex_match_int().
5979 (force_match_id) Renamed lex_force_match_id(), added return value.
5980 (force_match) Renamed lex_force_match(), added return value.
5981 (force_string) Renamed lex_force_string(), added return value.
5982 (force_int) Renamed lex_force_int(), added return value.
5983 (lex_id_match_len) New function.
5984 (id_match) Renamed lex_id_match(), rewritten.
5985 (get_line) Renamed lex_get_line().
5986 (preprocess_line) Renamed lex_preprocess_line().
5987 (tokname) Renamed lex_token_name().
5988 (bin_value_func) Removed.
5989 (oct_value_func) Removed.
5990 (hex_value_func) Removed.
5991 (unexpected_eof) New function.
5992 (convert_numeric_string_to_char_string) New function.
5993 (parse_string) Rewritten, signature changed.
5994 (add_tokstr_char) Removed.
5995 (add_tokstr_unsigned) Removed.
5996 (add_tokstr_string) Removed.
5997 (parse_tagged_quote) Removed.
5998 (skip_comment) Renamed lex_skip_comment().
6000 * lexer.h: All references updated.
6001 (macro is_id1) Renamed CHAR_IS_ID1.
6002 (macro is_idn) Renamed CHAR_IS_IDN.
6003 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
6004 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
6005 (macro get_token) Removed.
6006 (macro id_match) Removed.
6007 (macro force_match_id) Removed.
6008 (macro force_match) Removed.
6009 (macro force_string) Removed.
6010 (macro force_int) Removed.
6011 (macro force_num) Removed.
6012 (macro force_id) Removed.
6014 * lexerP.h: Removed.
6016 * list.q: Migrated to new q2c format.
6017 (write_line) Deal with struct len_string.
6018 (write_varname) Ditto.
6019 (write_fallback_headers) Ditto.
6021 * magic.c: New file, incorporating the following global variables
6022 previously in other files: endian, second_lowest_value. And both
6023 of those are conditional on #define's.
6025 * magic.h: New file, incorporating the following global variable
6026 declarations: endian, second_lowest_value, and the following macro
6027 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6029 * main.c: Added declarations of pgmname, finished, curdate,
6031 (main) Call new parse_script() function.
6032 (parse_script) New function.
6033 (execute_command) New function.
6034 (dump_token) Removed.
6035 (handle_error) New function.
6037 * matrix.c: New file.
6039 * matrix.h: New file.
6041 * matrix-data.c: Migrated from arenas to pools.
6042 (mget_token) Change from parse_string_as_format() to data_in().
6044 * means.q: Migrate to new q2c.
6045 (custom_tables) Renamed mns_custom_tables().
6046 (custom_crossbreak) Renamed mns_custom_crossbreak().
6047 (custom_variables) Renamed mns_custom_variables().
6049 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6050 (parse_varnames) Prototype.
6051 (parse_numeric) Rephrasings.
6052 (parse_alpha) Adapt to new struct string tokstr.
6054 * misc.c: (intlog10) Rewritten.
6056 (ansi_rand) Renamed real_rand(), moved into random.c.
6057 (ansi_srand) Renamed real_srand(), moved into random.c.
6058 (setup_randomize) Moved to random.c.
6059 (rand_uniform) Ditto.
6060 (rand_normal) Ditto.
6061 (rand_simple) Ditto.
6062 (get_config_line) Removed.
6063 (reverse) Removed (dead code).
6065 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6066 (macro CLEAR_BIT) Ditto.
6067 (macro TEST_BIT) Ditto.
6068 (macro SET_BIT_TO) Ditto.
6069 (macro BIT_INDEX) Ditto.
6071 * output.c: (outp_read_devices) Move to err_push_file_locator()
6072 from push_cust(). Use struct string.
6073 (expand_op_tokstr) Removed.
6074 (static var op_tokstr) Changed to struct string.
6075 (static var op_tokstr_size) Removed.
6076 (tokener) Rephrasings. Use struct string.
6077 (parse_options) Use struct string.
6078 (destroy_driver) Fix assertion.
6079 (outp_get_paper_size) Move to err_push_file_locator().
6080 [0] Removed dead code.
6081 (outp_string_width) Move to len_string.
6083 * output.h: Comment fixes.
6084 (TAG_* enum series) Removed.
6085 (struct outp_value) Removed.
6086 (enum OUTP_T_FANCY) Removed.
6087 (struct outp_text) `s' changed from a_string to len_string.
6088 (struct outp_class) `option' change arg 3 from outp_value to
6091 * pfm-read.c: (corrupt_msg) Rewritten.
6093 * pfm-write.c: (bufwrite) Fix assertion.
6095 * pool.c: New file, reference version.
6097 * pool.h: New file, reference version.
6099 * postscript.c: (ps_font_sizes) Fix assertion.
6100 (ps_option) Change arg 3 from outp_value to struct string.
6101 Adapt to struct string.
6102 (macro output_line) Removed.
6103 (macro add_string) Removed.
6104 (output_encodings) Adapted to struct string. Moved to
6105 err_push_file_locator().
6106 (find_encoding_file) Fix assertion.
6107 (read_ps_encodings) Move to err_push_file_locator().
6108 (postopen) Use getl_location() instead of curfn.
6109 (out_text_plain) Move to len_string.
6110 (text) Ditto. Remove rich text support.
6112 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6113 (cmd_print_eject) Ditto.
6115 (internal_cmd_print) Now cleans up after itself. Uses
6116 fh_parse_file_handle() now.
6117 (cmd_print_space) Use PXP_NUMERIC to type-check.
6119 * q2c.c: Overhauled. Removed _("") i18n support. All references
6120 updated. All output functions updated to handle structures rather
6121 than local or static variables. Adapt to new PSPP lex_*()
6125 (macro MAX_N_SBC) Removed.
6126 (global bare) Removed.
6127 (enum STRING) Renamed T_STRING.
6128 (enum ID) Renamed T_ID.
6129 (get_buffer) Buffer size increased.
6130 (strlower) Renamed st_lower(), rephrased.
6131 (strupper) Renamed st_upper(), rephrased.
6132 (skip_ws) New function.
6133 (get_line) Don't special-case any types of lines (like those
6134 beginning with ! or $, for instance).
6135 (get_token) Renamed lex_get(). Rephrased.
6136 (static var `prefix') New.
6137 (parse) New function.
6138 (parse_setting) Minor rephrasing.
6139 (dump_specifier_vars) Ditto.
6140 (make_identifier) Put null terminator on identifier, duh.
6141 (dump_vars) Renamed dump_declarations(). Never indent. Never
6142 static. Output changed entirely.
6143 (dump_specifier_init) Rephrase.
6144 (dump_vars_init) No index variable needed. Other modifications.
6145 (dump_parser) Don't parse command name. Do dump functions instead
6146 of just code fragments.
6147 (dump_free) Dump function instead of code fragment.
6148 (recognize_directive) New function.
6149 (main) Use recognize_directive(). Don't rely on magic $ line
6150 beginning: instead, parse comments. Update list of headers.
6152 * random.c: New file, containing the following functions:
6153 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6154 rand_normal, rand_simple.
6156 * random.h: New file.
6158 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6159 function. `max_src_width', `max_dst_width' changed to size_t.
6160 (internal_cmd_recode) Removed.
6161 (parse_dest_spec) Merge similar cases.
6162 (parse_src_spec) Add assertion.
6164 * repeat.c: (recognize_keyword) New function.
6165 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6166 REPEAT. Improve recognition of END REPEAT (use
6167 recognize_keyword()). Move from curfn to getl_location(). Use
6170 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6172 * set.q: Adapt to new q2c.
6173 (cmd_set) Range-check some values better.
6174 (custom_blanks) Renamed stc_custom_blanks().
6175 (custom_length) Renamed stc_custom_length().
6176 (custom_results) Renamed stc_custom_results().
6177 (custom_seed) Renamed stc_custom_seed().
6178 (custom_width) Renamed stc_custom_width().
6179 (custom_format) Renamed stc_custom_format().
6180 (custom_journal) Renamed stc_custom_journal().
6181 (custom_color) Renamed stc_custom_color().
6182 (custom_listing) Renamed stc_custom_listing().
6183 (custom_disk) Renamed stc_custom_disk().
6184 (custom_log) Renamed stc_custom_log().
6185 (custom_rcolor) Renamed stc_custom_rcolor().
6186 (custom_viewlength) Renamed stc_custom_viewlength().
6187 (custom_workdev) Renamed stc_custom_workdev().
6189 * settings.h: Not necessary to include format.h any longer.
6191 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6192 (corrupt_msg) Rewritten.
6194 * sort.c: Adapt to rewritten heap ADT.
6196 * str.c: (aa_strcpy) Removed.
6197 (ab_strcpy) Removed.
6198 (ac_strcpy) Removed.
6199 (ba_strcpy) Removed.
6200 (bb_strcpy) Removed.
6201 (ca_strcpy) Removed.
6202 (aa_strdup) Removed.
6203 (aa_strdupcpy) Removed.
6204 (ba_strdup) Removed.
6205 (sa_strdup) Removed.
6206 (memrev) Renamed mm_reverse().
6207 (memrmem) Renamed mm_find_reverse().
6208 (cmp_str) Renamed st_compare_pad().
6209 (strmaxcpy) Removed.
6210 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6211 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6213 (strpadcpy) Renamed st_pad_copy(), signature changed.
6214 (blpstrset) Removed.
6215 (ds_create) New function.
6216 (ds_init) New function.
6217 (ds_replace) New function.
6218 (ds_destroy) New function.
6219 (ds_clear) New function.
6220 (ds_extend) New function.
6221 (ds_shrink) New function.
6222 (ds_truncate) New function.
6223 (ds_length) New function.
6224 (ds_size) New function.
6225 (ds_value) New function.
6226 (ds_end) New function.
6227 (ds_concat) New function.
6228 (ds_concat_buffer) New function.
6229 (ds_printf) New function.
6230 (ds_putchar) New function.
6231 (ds_getline) New function.
6232 (ds_get_config_line) New function derived from the old
6233 misc.c:get_config_line().
6234 (ls_create) New function.
6235 (ls_create_buffer) New function.
6236 (ls_init) New function.
6237 (ls_shallow_copy) New function.
6238 (ls_destroy) New function.
6239 (ls_null) New function.
6240 (ls_null_p) New function.
6241 (ls_empty_p) New function.
6242 (ls_length) New function.
6243 (ls_value) New function.
6244 (ls_end) New function.
6246 * str.h: Reformatted.
6247 (struct a_string) Removed.
6248 (struct b_string) Removed.
6249 (struct c_string) Removed.
6250 (struct len_string) New.
6251 (struct string) New.
6252 (macro as_streq) Removed.
6253 (macro bs_streq) Removed.
6254 (macro cs_streq) Removed.
6255 (macro sa_streq) Removed.
6256 (macro sb_streq) Removed.
6257 [__GNUC__] (inline function ds_putchar) New function.
6258 [__GNUC__] (inline function ds_length) New function.
6259 [__GNUC__] (inline function ds_value) New function.
6260 [__GNUC__] (inline function ds_end) New function.
6262 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6263 (display_vectors) Fix missing i18n.
6265 * t-test.q: Migrate to new q2c.
6267 * tab.c: Migrate from arenas to pools.
6268 (tab_create) Use struct len_string.
6269 (tab_realloc) Ditto.
6270 (text_format) Ditto.
6271 (tab_joint_text) Ditto.
6272 (tab_natural_width) Remove rich text support.
6273 (tab_natural_height) Ditto.
6274 (tab_output_text) Handle TAT_FIX.
6275 (tab_raw) Change arg from a_string to len_string.
6276 (tabi_driver) Fix assertion. Use struct len_string.
6277 (render_strip) Use struct len_string. Remove rich text support.
6278 Add `const' qualifiers.
6280 * tab.h: (enum TAB_RICH) Remove.
6281 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6282 SOM_COL_* updated to read TAB_COL_*.
6283 (struct tab_table) Change arena to pool. Change a_string to
6286 * temporary.c: (restore_dictionary) Rewrite Checker code.
6288 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6289 LOWEST, HIGHEST) Moved here from common.h.
6290 (typedef any_trns) Removed. All references changed to `struct
6293 * vars-atr.c: (force_create_variable) Fix assertion.
6294 (force_dup_variable) Fix assertion.
6296 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6298 Using alphanumeric variables in functions under AGGREGATE
6299 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6300 <BZN-mdksh@t-online.de> for reporting this bug.
6302 * aggregate.c: (parse_aggregate_functions) When setting the
6303 FSTRING bit, also allocate memory for the `string' member of
6305 (free_aggregate_functions) Free iter->string. Don't use the
6306 non-function bits when indexing the array of functions.
6307 [DEBUGGING] (debug_print) Don't use the non-function bits when
6308 indexing the array of functions.
6310 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6312 Under certain circumstances, the final case would be omitted from
6313 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6314 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6316 * aggregate.c (agr_00x_end_func): Increment number of cases in
6317 sink before writing case. For streams that keep track of how many
6318 cases there are based on this value, this means that the last case
6319 will be read in on the next stream read.
6321 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6323 Undefined behavior was invoked by referencing a freed pointer.
6325 * vfm.c (memory_stream_write): Free pointer *after* checking for
6328 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6330 A wrong record size was displayed when paging the active file to
6333 * vfm.c: (memory_stream_write) Fix off-by-one error.
6335 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6337 Not having enough temporary space for sorting caused a core dump.
6340 * sort.c: (allocate_cases) Initialize i.
6342 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6344 Syntax errors in function descriptions on AGGREGATE caused core
6347 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6348 free_aggregate_functions(), since that function already frees
6351 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6353 A null pointer was dereferenced, causing a core dump, when
6354 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6355 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6356 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6358 * arena.c: (arena_malloc) If the arena hasn't been initialized
6359 already, initialize it.
6361 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6363 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6364 for compilation with Cygnus Windows B20. Not used by other
6367 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6369 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6370 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6372 * sort.c: (compare_case_lists) Reverse sense of comparison if
6373 sorting in descending order.
6374 (compare_record) Ditto.
6376 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6378 SPLIT FILE with a string variable caused a core dump. Fixed.
6380 * vfm.c: If the variable is a string then make a temporary value
6381 struct pointing to it. The underlying problem is a lot bigger
6382 than this (see TODO) but this is a stopgap for the simple case at
6385 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6387 Nested INCLUDEs didn't work. Fixed.
6389 * getline.c: (getl_include) Set first_line to NULL in allocated
6392 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6394 The MATCH FILES procedure set the values of variables not present
6395 to 0. It should have been SYSMIS. This is now fixed.
6397 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6399 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6401 The REMARK command was too aggressive about skipping lines. It
6402 didn't like being the last command in a file.
6404 * command.c: (cmd_remark) Call get_entire_line() instead of
6407 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6409 Comment parsing wasn't consistent with the rest of the code in its
6410 idea of where one command ends and another starts. This meant
6411 that sometimes commands would be mysteriously ignored. Thanks to
6412 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6414 * command.c: (parse_cmd) Hand off comment parsing to new function
6415 skip_comment() in lexer.c.
6416 * lexer.c: (skip_comment) New function.
6418 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6420 The TABLE subcommand on MATCH FILES worked only erratically at
6421 best. This fixes it. Thanks to Dr. Dirk Melcher
6422 <BZN-mdksh@t-online.de> for reporting this bug.
6424 * get.c: (mtf_compare_BY_values) When comparing string values, a
6425 difference of 1 is still a difference :-)
6426 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6427 advance TABLE files automatically when matched. Comment fixes.
6429 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6431 VARIABLE LABELS rejected a slash before the first variable
6432 specification, contradicting the documentation. Thanks to Walter
6433 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6435 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6436 command specification.
6438 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6440 Because of an incorrect optimization in memory allocation,
6441 CROSSTABS sometimes segfaulted when asked to output multiple
6442 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6445 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6446 are passed to output_pivot_table() for its use.
6447 (output_pivot_table) Instead of assuming the number of columns is
6448 constant, keep track with maxcols. In general mode, use maxcells
6449 to determine whether more matrix cells need to be allocated.
6451 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6453 CROSSTABS didn't display value labels for column and row
6454 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6457 * crosstabs.q: (table_value_missing) If the specified value has a
6458 value label for this variable, then show it instead of the raw
6460 (display_dimensions) Delegate display of value_labels to
6461 table_value_missing.
6463 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6465 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6466 <BZN-mdksh@t-online.de> for reporting this bug.
6468 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6469 if the file isn't declared as binary.
6471 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6473 MATCH FILES corrupted memory and dumped core on some syntax
6476 * get.c: (cmd_match_files) Set file->handle to NULL before
6478 (mtf_free_file) Don't free a null dictionary.
6480 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6482 MATCH FILES should set numeric values not available to the
6483 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6484 <BZN-mdksh@t-online.de> for reporting this bug.
6486 * get.c: (mtf_processing) Set unused records to system-missing,
6489 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6491 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6492 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6494 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6495 in newly created dictionary, and add each copied variable to the
6498 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6502 * get.c: (trim_dictionary) Free variable list for KEEP after
6505 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6507 Some systems didn't like the way open_file was coded. Thanks to
6508 Hankin <hankin@rogue.consultco.com> for pointing this out.
6510 * filename.c: (open_file) Don't try to store stdin, stdout,
6511 stderr as part of an array, because that doesn't always work.
6513 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6515 The SAVE procedure didn't save long string variables properly.
6516 Fixed by this patch. Thanks to Hankin
6517 <hankin@rogue.consultco.com> for this patch.
6519 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6520 out variable pad records.
6522 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6524 Previously, if PRINT SPACE were given a negative argument, it
6525 would report an error, then spin in an (almost) infinite loop.
6526 This fixes that behavior.
6528 * print.c: (print_space_trns_proc) After reporting a negative
6529 argument, set number of lines to print to 1.
6531 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6533 SPSS 8.0 outputs some new record types in its system files, and it
6534 allows longer value labels. Accept these system files.
6536 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6537 11 emitted by SPSS 8.0.
6539 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6541 The LIST procedure was too conservative in allocating space for
6542 buffers, which caused a bug that only showed up with very long
6543 output variables. Thanks to Hankin <hankin@dunno.com> for this
6546 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6548 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6550 Typo meant string format specifiers weren't checked properly. I
6551 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6552 willing to be corrected on this point.
6554 * format.c: (check_string_specifier) Fix obvious typo.
6556 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6558 Using $CASENUM in an expression didn't work. Here's a fix.
6559 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6562 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6564 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6566 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6568 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6569 other behavior, *sigh*. This patch hopefully fixes that. This
6570 time I've actually tested it.
6572 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6574 * data-list.c: (read_from_data_list_free,
6575 read_from_data_list_list) Call parse_string_as_format() directly
6576 without mucking around with the field width.
6578 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6580 Occasionally, you may encounter a script that wants to be
6581 interpreted in interactive mode. Make -i emulate this behavior to
6582 allow such scripts to be executed with PSPP.
6584 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6586 * cmdline.c: (pre_syntax_message[]) Update -i description.
6588 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6589 when -i is given on the command line) don't treat unindented lines
6590 as starting a new command.
6592 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6594 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6595 mostly caused by local initialized aggregates. After egcs is
6596 fixed upstream these can be removed, but for now they're not a big
6599 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6600 initialized arrays. Avoid this.
6602 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6605 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6607 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6608 following changes avoid. Currently I compile sources with egcs
6609 1.1.1 and gcc 2.7.2.3 before sending them out.
6611 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6613 * ascii.c: (option_tab[]) Initialize all struct members.
6615 * avl.h: (avl_traverser_init) New macro.
6617 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6620 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6623 * hash.c: Comment fix.
6625 * hash.h: (hsh_iterator_init) New macro.
6627 * html.c: (option_tab[]) Initialize all struct members.
6629 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6632 * postscript.c: (option_tab[]) Initialize all struct members.
6633 (output_encodings, preclose, dump_lines) Use new
6634 hsh_iterator_init() macro.
6636 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6639 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6642 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6644 * data-in.c: Examined each of the parsing functions to make sure
6645 that they wouldn't dump core if they were passed a string of the
6646 wrong length, since now the DATA LIST FREE/LIST routines don't
6647 check for field width before passing it to the data parser.
6648 (parse_RBHEX, parse_AHEX) Reject odd length input.
6649 (parse_string_as_format) Reject input that's too short or too
6652 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6653 a field to its entire declared output width then pass it to the
6654 data-in parsing routines. This contradicted the documented
6655 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6656 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6657 free-format parsing that differed from SPSS.
6658 (cut_field) Commas and spaces are treated identically. Returns
6659 the proper column instead of a fixed 1 value.
6660 (parse_field) Removed.
6661 (read_from_data_list_free, read_from_data_list_list) Call
6662 parse_string_as_format directly instead of parse_field.
6664 * heap.c: (heap_delete) Stylistic fixes.
6666 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6668 * loop.c: (loop_2_trns_proc) Formatting fix.
6670 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6672 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6674 * vfm.c: (macro FILTERED) New.
6675 (static var filter_var) New.
6676 (process_active_file_write_case) Use FILTERED.
6677 (setup_filter) Set filter_var.
6678 (close_active_file) Delete the filter if not
6679 FILTER_before_TEMPORARY.
6680 (procedure_write_case) Use FILTERED.
6682 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6684 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6686 * data-in.c: (parse_day_count) Message fix.
6687 (parse_month) Style fix.
6689 * data-list.c: (struct data_list_pgm) New member eof.
6690 (cmd_data_list) Init eof to 0.
6691 (do_reading) Implement the /END subcommand and read-past-eof
6694 * do-if.c: Include stdio.h when debugging.
6695 (cmd_else_if) Make sure the command is .-terminated.
6697 * glob.c: (init_glob) Capitalize the command prompt.
6699 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6700 (end_file_trns_proc) Debugging message.
6702 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6704 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6706 * main.c: (dump_token) Make kwtab[] const.
6708 * set.q: Spelling, comment fixes.
6710 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6713 * vars-prs.c: (fill_all_vars) Style fix.
6715 * vfm.c: (index_to_varname) Return const.
6717 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6719 * Changes in many source files for partial -ansi -pedantic and
6720 no-debugging compliance: Remove trailing common in enum
6721 declarations; add `unused' attributes; insert some appropriate
6724 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6726 * command.c: (shell) Make static.
6727 (run_command) Make static.
6729 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6731 * dfm.c: (cmd_begin_data) I18n fix.
6733 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6735 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6737 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6740 * file-handle.q: Don't prepend the source file directory name to
6741 the data file name. (Ongoing issue.)
6742 (prepend_current_directory) Comment out.
6743 (internal_cmd_file_handle) Don't call prepend_current_directory().
6744 (fh_get_handle_by_filename) Ditto.
6746 * filename.c: Append zero byte to readlink() return value.
6748 * getline.c: (getl_read_line) I18n fix.
6750 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6752 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6754 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6757 * postscript.c: (output_encodings) Don't use local_strdup().
6760 * print.c: Don't use gcc features if __STRICT_ANSI__.
6762 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6764 * recode.c: (parse_src_spec) Fully brace nested if's.
6766 * set.q: (global var set_testing_mode) New var.
6768 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6770 * ascii.c: Add some more `unused' attributes that only come into
6771 play when NDEBUG is defined.
6772 (ascii_close_page) Set s_len when reallocating s.
6774 * crosstabs.q: (delete_missing) New function.
6775 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6776 (make_summary_table) Create summary table reallocable.
6778 * postscript.c: Add more `unused' attributes as above.
6780 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6781 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6783 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6786 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6787 gratuitous space between parameter definition.
6789 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6790 complaints about running off the end of functions with NDEBUG
6793 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6795 * Several source files: Removed some PORTME notes when reflection
6796 revealed that ANSI forbids that sort of breakage. Also, added
6797 lots of `unused' qualifiers here and there.
6799 * aggregate.c: (accumulate_aggregate_info) Remove local var
6800 weighting that turned out not to be used.
6802 * avl.c: Update to version 1.1.0. Add unused specifier.
6803 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6805 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6806 (avl_find) Cast return value to void *.
6807 (avl_delete) q doesn't need to be initialized at the beginning of
6808 the function. Replace some instances of 1 with +1.
6809 (force_avl_delete) Renamed avl_force_delete, all references changed.
6810 (compare_ints) `param' marked unused.
6811 (print_int) `param' marked unused.
6812 (recurse_tree) Replace some instances of 1 with +1.
6814 * avl.h: Update to version 1.1.0. Only declares avl function
6815 types if not already declared.
6816 (AVL_MAX_HEIGHT) Only define if not already defined.
6817 (struct avl_node) New unused member char pad[2].
6818 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6819 (force_avl_insert) Renamed avl_force_insert.
6820 (force_avl_delete) Renamed avl_force_delete.
6822 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6824 (struct crosstab) Add new member `ofs'.
6825 (glob var int_tab) Removed.
6826 (custom_tables) In integer mode, assign v[i] properly through the
6828 (custom_variables) Now p.crs.max == max + 1.
6829 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6830 (precalc) Implement integer mode.
6831 (calc_integer) Implement integer mode.
6832 (compare_table_entry) Remove unused local variable `comparing'.
6833 (make_summary_table) Implement integer mode.
6834 (macro ns_rows) Implemented as static variable now.
6835 (several variables) Made static, from global.
6836 (output_pivot_table) Use table_value_missing() for column heads.
6837 Remove several unused local variables. Implement integer mode
6838 table summing. Count up ns_rows.
6839 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6840 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6841 calls that function or find_pivot_extent_integer.
6842 (find_pivot_extent_integer) New function.
6843 (enum_var_values) Implemented for integer mode.
6844 (table_value_missing) New function.
6845 (display_dimensions) Call table_value_missing() for heads.
6846 (float_M_suffix) New function.
6847 (display_crosstabulation) Call table_value_missing() for row
6848 heads. Handle missing values in /MISSING=REPORT mode.
6849 (calc_fisher) Remove unused var N.
6850 (calc_r) Remove unused var fact.
6852 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6853 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6855 * data-out.c: (insert_commas) Remove unused var cp.
6856 (convert_CCx) Remove unused vars save_set_decimal,
6859 * descript.q: (dump_z_table) Fix table dimensioning.
6860 (pre_calc) Remove unused var j.
6861 (display) Remove unused vars title, s. Fix table dimensioning.
6863 * expr-evl.c: Comment fixes.
6865 * frequencies.q: (full_dim) New function.
6866 (dump_full) Fix table dimensioning.
6867 (condensed_dim) New function.
6868 (dump_condensed) Fix table dimensioning.
6870 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6873 * html.c: (html_close_drive) Remove unused var i.
6874 (postopen) Remove unused vars title, curfn_len, cp.
6875 (preclose) Remove unused vars this, x.
6877 * lexer.c: Comment fixes.
6879 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6881 * means.q: (custom_tables) Remove unused var m_dim.
6883 * mis-val.c: Format fix.
6885 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6887 * output.c: (outp_get_paper_size) Remove unused var cp.
6889 * pfm-read.c: (read_float) Remove unused var save, unused label
6891 (read_variables) Remove unused vars cp, j.
6892 (read_value_label) Remove unused var j.
6894 * pfm-write.c: (bufwrite) Remove unused var i.
6896 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6898 (output_encodings) Remove unused vars char_cp, n_output.
6899 (read_ps_encodings) Remove unused var ep.
6900 (postopen) Remove unused var title.
6901 (preclose) Remove unused var fp.
6902 (ps_open_page) Remove unused vars true, false, orientation,
6903 mirror_horz, mirror_vert, width, length.
6904 (ps_text_metrics) Remove unused var x.
6906 * q2c.c: (find_symbol) Remove unused var y.
6907 (parse_setting) Remove unused parameter sbc, all references
6909 (dump_parser) Remove unused var cp.
6910 (dump_free) Remove unused var i.
6912 * set.q: (static vars args, n) Removed.
6913 (internal_cmd_gset) Removed.
6915 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6916 (read_machine_flt64_info) Removed unused var file_endian.
6917 (read_documents) Removed unused var i.
6918 (read_compressed_data) Removed unused parameter dict, all
6921 * sfm-write.c: (bufwrite) Removed unused var i.
6922 (sfm_write_case) Removed unused var i.
6924 * sort.c: (merge_once) Remove unused var t.
6925 (write_separate) #if 0 out as dead code.
6927 * split-file.c: (cmd_split_file) Remove unused var i.
6929 * sysfile-info.c: (sysfile_info_dim) New function.
6930 (cmd_sysfile_info) Fix table dimensioning.
6931 (variables_dim) New function.
6932 (display_variables) Fix table dimensioning.
6933 (describe_variable) Remove unused var prev_r.
6935 * t-test.q: (z_postcalc) Removed.
6936 (pairs_calc) Remove unused var bad_weight.
6937 (postcalc) Remove unused vars dfn, dfd.
6939 * tab.c: (tab_create) Set t->dim to NULL.
6940 (tab_dim) Make sure t->dim is NULL first.
6941 (tab_natural_width) Remove parameter `clamp'.
6942 (tab_value) Remove duplicate assertion for table.
6943 (tab_raw) New function.
6944 (nowrap_dim) New function.
6945 (wrap_dim) New function.
6946 (tab_output_text) Fix table dimensioning.
6948 * tab.h: (tab_raw) New macro.
6950 * val-labs.c: (get_label) Remove unused var type.
6951 (copy_value_labels) Remove unused var trav.
6953 * var.h: (struct crosstab_proc) Completely changed.
6955 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6957 * vfm.c: (open_active_file) Remove unused vars i, lp.
6959 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6961 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6963 * Makefile.am: Add apply-dict.c, flip.c.
6965 * apply-dict.c: New file.
6967 * command.c: (struct command) Make cmd[] larger for CLEAR
6968 TRANSFORMATIONS command name.
6969 (parse_cmd) Make sure we're in a valid state before using it as an
6970 index. Discard variables and reset state on invalid transitions.
6971 (cmd_clear_transformations) New function.
6973 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6974 Add unimplemented PRESERVE, RESTORE.
6976 * file-handle.h: Include stddef.h.
6980 * pfm-read.c: (parse_value) Pad value label values with spaces,
6983 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6984 (sfm_close) Decrement reference count, make sure it's zero.
6985 (sfm_maybe_close) New function.
6986 (sfm_read_dictionary) Handle reference counts.
6988 * vars-atr.c: (clear_default_dict) New function.
6989 (discard_variables) Use clear_default_dict().
6991 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6993 * Makefile.am: Add pfm-write.c.
6994 (LDADD) Add the libgmp2 libraries.
6996 * command.def: Define EXPORT.
6998 * get.c: (cmd_export) New function.
6999 (export_write_case_func) New function.
7001 * pfm-read.c: (static spss2ascii[]) Make it const.
7003 * pfm-write.c: New file.
7005 * sfm-write.c: Formatting, comment fixes.
7007 * var.h: Comment fix.
7009 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
7011 * Makefile.am: Add pfm.h, pfm-read.c.
7013 * command.def: IMPORT is now implemented.
7015 * format.c: (glob var translate_fmt[]) New var.
7017 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7018 (cmd_import) New function.
7019 (import_source_read) New function.
7020 (glob var import_source) New var.
7022 * pfm-read.c: New file.
7026 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7028 (dump_dictionary) Disabled printing a couple of items.
7030 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7032 * crosstabs.q: (postcalc) Call make_summary_table().
7033 (make_summary_table) New function.
7034 (insert_summary) New function.
7035 (display_dimensions) Remove some unnecessary arguments, all
7037 (output_pivot_table) Fix lots of problems with the risk table
7039 (submit) Don't display an empty table.
7040 (display_risk) Fix order of arguments to calc_risk().
7042 * glob.c: Always include assert.h and stdlib.h.
7044 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7047 * tab.c: (tab_create) Cosmetic changes.
7049 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7051 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7055 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7056 code simplified, moved into new function submit().
7057 (submit) New function.
7058 (crosstabs_dim) New function.
7059 (display_directional) Substitute variable names for %s where
7061 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7062 (calc_symmetric) Initialize parameters only if non-NULL.
7063 Calculate Somers' d.
7064 (calc_directional) Calculate Somers' d (or copy it, really).
7067 * output.c: (outp_string_width) New function.
7069 * postscript.c: (postopen) Calculate font widths based on the
7070 width of the zero '0' character, not the width of the space
7071 character. Set paper-width and paper-length based on points, not
7073 (ps_open_page) Fix page setup string for landscape mode.
7075 * som.h: (struct som_dimension) Removed.
7076 (struct som_table_class) height, width members take int * not
7079 * tab.c: Many functions now have added parameter validation.
7080 (tab_height, tab_width) These functions were removed and merged
7081 into a single function tab_resize(), and all references changed.
7082 (tab_dim) Rewritten since the interface changed; reduced from
7083 hundreds of lines to two. All callers were changed. Currently
7084 most of them just use tab_natural_dimensions as their callback and
7085 await detailed translation of functionality.
7086 (tab_natural_width) New function.
7087 (tab_natural_height) New function.
7088 (tab_natural_dimensions) New function. This is a callback
7089 function, not something that you'd want to call directly.
7090 (tab_nat_dim) Removed.
7091 (tabi_table) Allocates t->w and t->h.
7092 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7093 dimensions callback.
7094 (evaluate_dimensions) Removed.
7095 (sum_columns) Removed.
7097 * tab.h: (enum TAL_1THIN) Removed.
7098 (enum series t_*) Removed.
7099 (struct tab_table) Members trh, trv changed to unsigned char *
7100 from int *. Member dim changed to a function pointer from a
7101 unsigned char *. Member max_stack_height removed. New members
7103 (macros tab_l, tab_r, tab_t, tab_b) New.
7105 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7107 * ascii.c: (delineate) Assign last_space_nchars before skipping
7108 spaces, to fix right justification.
7110 * crosstabs.q: (static vars risk, direct) New vars.
7111 (static var pearson_r) Removed.
7112 (glob var chisq_fisher) Made static.
7113 (static vars row_tot[], col_tot[]) Don't include grand total
7115 (static var grand_total) Renamed W, all references changed.
7116 (output_pivot_table) Only make `table' if num_cells != 0. Make
7117 risk and directional tables. Deal with grand total no longer part
7118 of col_tot[]. Free rows and cols after we're done with them.
7119 (display_risk) New function.
7120 (display_directional) New function.
7121 (clac_r) Rewritten so that it stores all its results into its
7122 arguments, so it can be used for Spearman's correlation too.
7123 (calc_symmetric) Added a t[] argument, all references changed.
7124 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7125 Pearson's r, Cohen's kappa.
7126 (calc_risk) New function.
7127 (calc_directional) New function.
7129 * som.c: (som_submit) Improved debugging code.
7131 * stats.c: (hypercube) New function.
7132 (cube) New function.
7134 (normal_sig) Went back to old implementation, which actually
7137 * stats.h: (macros square, cube, hypercube) Removed. The
7138 equivalent functions in stats.c are inlined here; all references
7139 to square changed to sqr.
7141 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7143 * crosstabs.q: (N_SYMMETRIC) New define.
7144 (postcalc) Disable debug printing.
7145 (static vars chisq_fisher, pearson_r) New.
7146 (output_pivot_table) Add support for symmetric measures. Add
7147 chi-square output of exact sigs.
7148 (display_chisq) Rewritten.
7149 (display_symmetric) New function.
7150 (gamma_int) New function.
7152 (swap) New function.
7153 (calc_fisher) New function.
7154 (calc_chisq) Check boundary conditions better. Calculate Yates,
7155 Fisher, Mantel-Haenszel tests.
7156 (calc_r) New function.
7157 (calc_symmetric) New function.
7159 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7161 (chisq_sig) Better boundary conditions. Renamed from
7164 * tab.h: (struct tab_table) New member cf.
7166 * tab.c: (tab_create) Set cf.
7167 (tab_width) New function.
7168 (tab_realloc) Handle cf.
7169 (tab_vline) Handle cf.
7170 (tab_hline) Handle cf.
7171 (tab_box) Handle cf.
7172 (tab_value) Handle cf.
7173 (tab_float) Handle cf.
7174 (tab_text) Handle cf.
7175 (tab_joint_text) Handle cf.
7176 (tab_offset) Handle cf.
7177 (tab_next_row) Handle cf.
7178 (evaluate_dimensions) Handle cf.
7179 (render_strip) Handle cf.
7181 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7183 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7184 output_pivot_table().
7185 (output_pivot_table) Moved lots of local variables outside and
7186 made them static. Add beginnings of chi-square statistic
7187 support. Now column and row totals aren't in the main matrix.
7188 Always zero out any leftover rows & columns after we're done with
7189 the table entries. Move all output stuff into
7190 display_dimensions(), display_crosstabs(), display_chisq().
7191 (display_dimensions) New function.
7192 (display_crosstabulation) New function.
7193 (display_chisq) New function.
7194 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7196 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7197 references, simplify logic.
7199 * postscript.c: Remove scale, translate-x, translate-y,
7200 mirror-horz, mirror-vert, rotate-180 options.
7201 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7202 All references deleted.
7203 (macro YT) New macro.
7204 (array option_tab[]) Removed options.
7205 (ps_option) Removed options.
7206 (ps_open_page) Write page setup explicitly to output file, without
7207 using now-deleted BP function.
7208 (macro dump_line) Use YT().
7209 (macro dump_thick_line) Use YT().
7210 (draw_headers) Use YT().
7211 (switch_font) Reorder arguments to SF function.
7212 (write_text) Use YT().
7214 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7217 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7219 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7220 null-debugging code.
7221 (tab_realloc) Remove null-debugging code. Initialize new regions
7223 (tab_vline) Support offsets.
7224 (tab_hline) Support offsets.
7225 (tab_box) Support offsets.
7227 (tab_nulls) Removed.
7230 (evaluate_dimensions) Remove null-debugging code. Understand
7231 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7232 TAB_EMPTY not present.
7234 * tab.h: New cell attribute TAB_EMPTY.
7235 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7237 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7238 try to read them from system files.
7240 * vfm.c: (dump_splits) Don't call tab_null().
7242 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7244 * crosstabs.q: (struct crosstab) Added `missing' member.
7245 (custom_tables) Init missing.
7246 (calc_general) Handle missing values.
7247 (calc_chisq) New function.
7248 (output_pivot_table) Start work on chi-square output. Update for
7249 new tab offset support functions. Shorten statistic names.
7251 * Several files: add in more `const's to placate gcc's warnings.
7253 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7256 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7257 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7258 tab_joint_text) Add col_ofs and row_ofs support.
7259 (tab_offset) New function.
7260 (tab_next_row) New function.
7261 (tab_row) New function.
7262 (tab_col) New function.
7263 (tabi_table) Add col_ofs and row_ofs support.
7265 * vars-atr.c: (is_system_missing) New function.
7267 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7269 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7270 (static var no_cells) Removed.
7271 (static var num_cells) New.
7272 (static var expected) New.
7273 (static var cells[]) New.
7274 (internal_cmd_crosstabs) Deal with new variables.
7275 (postcalc) Removed most of the meat and put it in new function
7276 output_pivot_table().
7277 (output_pivot_table) Calculates and outputs an entire pivot table.
7279 * postscript.c: (postopen) Fix problems with free()ing addresses
7280 not obtained from malloc().
7282 * som.c: (som_submit) Add assertion.
7284 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7287 * tab.c: (static var tab_names[]) New.
7288 (tab_realloc) -1 for nc or nr indicates no change.
7289 (tab_nulls) New function.
7290 (tab_dim) Use tab_names[].
7291 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7292 (evaluate_dimensions) Don't terminate on uninited cells, just put
7293 an X in them and emit a notice. Use tab_names[].
7295 * tab.h: Move bits into tab.def.
7297 * tab.def: New. Don't try to declare tab_table_class because then
7298 som.h has to be included.
7300 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7302 * command.def: New file, contains all the command definitions
7303 previously included bodily in command.c.
7305 * format.def: New file, contains all of the format definitions
7306 previously split across format.h, format.c, and sfm-write.c.
7308 * lexer.h: Renamed from tokens.h in order to match corresponding
7311 * lexerP.h: Moved some rarely used functions exported by lexer.c
7314 * Makefile.am: Commemorate renamed files.
7315 (EXTRA_DIST) Add command.def, format.def.
7317 * command.c: [0] (walk_cmdtable_func) Removed.
7319 * crosstabs.q: (postcalc) Made it work and print out matrices
7321 (enum_column_values) Renamed enum_var_values, generalized for any
7324 * format.h: (struct fmt_desc) New member `spss'.
7326 * q2c.c: (main) Generated code includes lexer.h instead of
7329 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7330 instead of an independent translation table.
7332 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7334 * Lots of source files: Added const to declarations.
7336 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7338 * arena.c: (arena_clear) Set prev pointer to null when done.
7340 * ascii.c: (ascii_option) Rename index as indx.
7342 * avl.c: This is now a separate library called libavl.
7343 (xmalloc) Make static.
7344 (avl_probe) Step A7 can use the cache instead of an explicit
7346 (avl_delete) Don't maintain a q pointer because it's always
7347 available in the pointer stack. Comment fix.
7349 * avl.h: This is now a separate library called libavl.
7351 * command.c: (cmd_table[]) Remove spurious trailing "".
7353 * common.h: Only include random() fix if this system needs it.
7355 * crosstabs.q: Include alloca headers.
7356 (n_sorted_tab) New global var.
7357 (postcalc) Mostly rewritten.
7358 (find_pivot_extent) Rewritten.
7359 (enum_column_values) Rewritten.
7361 * data-out.c: (convert_F) Rename inner n as n_spaces.
7363 * error.c: (dump_message) Don't have an outer var i.
7365 * file-handle.q: (static var f) Removed. All references removed.
7366 (internal_cmd_file_handle) Uses a local variable instead of f.
7368 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7369 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7372 * getline.h: Declare getl_history as extern. Reported by
7373 palme@uni-wuppertal.de (Hubert Palme).
7375 * postscript.c: (postopen) Some large mods for constness.
7377 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7380 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7382 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7383 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7386 * avl.c, avl.h: New files. These form a clean-room
7387 reimplementation of avllib. Iterative algorithms are used in
7388 place of recursive ones, so there is no resemblance in the code.
7390 * Lots of headers: Don't include other headers by default.
7392 * Lots of source files: Explicitly include all needed headers.
7394 * arena.c: (arena_clear) New function.
7396 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7397 (static var ar) Removed.
7398 (staitc vars ar_tc, ar_col) New.
7399 (cmd_crosstabs) Destroy the arenas.
7400 (internal_cmd_crosstabs) Create the arenas.
7401 (precalc) Don't need a free function for the hash.
7402 (calc_general) Make sure to zero out the trailer on the key data
7404 (print_table_entries) Updated.
7405 (postcalc) Worked on actually implementing.
7406 (find_pivot_extent) New function.
7407 (compare_value) New function.
7408 (enum_column_values) New function.
7410 * data-in.c: (parse_month) Make local array `static const'.
7412 * data-out.c: (convert_date) Make local array `static const'.
7413 (convert_WKDAY) Same.
7414 (convert_MONTH) Same.
7416 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7417 been renamed to avl_walk().
7419 * hash.c: Rewritten more efficiently.
7421 * hash.h: Add attribute const to hsh_next_prime declaration.
7423 * lexer.c: (id_match) Make arguments const.
7425 * postscript.c: (ps_postopen_driver) Make default fonts the
7428 * q2c.c: (main) Generated code needs stdlib.h.
7430 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7431 initialized to 0 now, not to NULL. All other references to
7432 avl_traverser were updated in the same way.
7434 * tokens.h: Macro version of id_match updated to use const
7437 * val-labs.c: (inc_ref_count) New function.
7438 (copy_value_labels) Simply through use of new avl_copy() function.
7440 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7442 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7443 (postcalc) Worked on this.
7445 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7446 (struct ps_driver_ext) New line_width_thick member.
7447 (ps_preopen_drive) Init line_width_thick.
7448 (option_tab[]) Add line-* options.
7449 (ps_option) Parse line-* options.
7450 (postopen) Add line_width_thick support. Strip leading spaces on
7451 prologue output lines.
7452 (ps_open_page) Include line_width_thick in output.
7453 (macro dump_thick_line) New.
7454 (dump_fancy_line) Support thick lines as well as double lines.
7456 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7458 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7459 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7461 * Many source files: Rename `options' to `pv_opts' as appropriate.
7463 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7465 * common.c: (xcalloc) New function.
7467 * crosstabs.q: New file. Not finished yet, though.
7469 * data-list.c: Comment fix.
7471 * error.c: Remove some old Checker cruft.
7473 * frequencies.q: (dump_full) Cumulate valid percent instead of
7476 * getline.c: Comment fix.
7478 * hash.c: Comment fixes.
7480 * hash.h: (struct hsh_table) Make hash functions return unsigned
7481 instead of int to avoid problems with taking the modulo of
7482 negative return values. All references changed.
7484 * misc.c: (intlog10) Make its table static const instead of auto.
7486 * sfm-read.c: (read_header) Make `prefix' static const instead of
7489 * var.h: (union value) Add member `hash'.
7490 (struct variable) Rename prv_index as `foo'--all references
7492 (typedef pv_opts) Removed. All references changed.
7494 * vars-prs.c: (parse_variables) Message fixes.
7496 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7498 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7499 they are being inserted. Don't check for BY variables of
7500 different types. Discard variables if the active file isn't
7501 included in the merge.
7502 (mtf_processing) Essentially rewritten.
7503 (mtf_merge_dictionary) Check for master/slave variables of
7504 different types/widths.
7506 * vfm.c: (static var not_canceled) New var.
7507 (process_active_file) Don't call vfm_source->read() if
7508 there's no vfm-source. Initialize not_canceled.
7509 (process_active_file_write_case) Honor and update not_canceled.
7510 (prepare_for_writing) Rollback changes from yesterday, they were
7512 (close_active_file) Don't destroy vfm_source unless it exists.
7514 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7516 * Lots of source files: Added { } around nested if/else constructs
7517 to avoid new gcc 2.8 warnings.
7519 * data-in.c: (parse_Z) Declare `int' type explicitly.
7522 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7523 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7524 prev members. Put TABLEs at the end of the chain and FILEs at the
7525 beginning. Don't allow the active file in STATE_INIT. Use proper
7526 `seen' value for the active file. Fill out the by members and
7527 make sure they're of consistent type. Do the actual merge
7529 (mtf_processing_finish) New function.
7530 (var_type_description) New function.
7531 (mtf_free_file) New function.
7532 (mtf_free) Rewritten.
7533 (mtf_delete_file_in_place) New function.
7534 (mtf_read_nonactive_records) New function.
7535 (mtf_compare_BY_values) New function.
7536 (static var mtf_seq_no) New var.
7537 (mtf_processing) New function.
7538 (mtf_merge_dictionary) Assign nval members for the system file
7539 dictionary. Assign fv values for its variables. Point each slave
7540 variable to the corresponding master variable.
7542 * hash.c: Include str.h.
7544 * mis-val.c: (copy_missing_values) src arg is const.
7546 * misc.c: (spacing) Make `max' var explicitly int.
7548 * sfm-read.c: (dump_dictionary) Message reformatting.
7549 (sfm_read_case) Add assertion.
7551 * sort.c: Esthetic fixes.
7553 * var.h: (struct match_files_proc) New struct.
7554 (struct variable) Add private data match_files_proc.
7556 * vars-atr.c: (delete_variable) Implement. Add argument for the
7557 dictionary that owning the variable.
7558 (dup_variable) Add assertion.
7560 * vfm.c: Comment fixes, hopefully the comments are correct now.
7561 (process_active_file) New function.
7562 (process_active_file_write_case) New function.
7563 (process_active_file_output_case) New function.
7564 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7566 (write_case) Renamed procedure_write_case(). Now write_case is a
7567 pointer to a function. Style fixes.
7569 1998-03-05 Ben Pfaff <blp@gnu.org>
7571 * Makefile.am: (q2c) Link with libmisc.
7572 (version.c) Define default_config_path, include_path,
7575 * ascii.c: (ascii_postopen_driver) When the default newline string
7576 is requested, open file in text mode. Suggested by
7577 palme@uni-wuppertal.de (Hubert Palme).
7578 (static vars line_buf, line_p) Change from char * to unsigned char
7580 (ascii_close_page) char * to unsigned char *.
7582 * cmdline.c: (parse_command_line) Implement -r option by
7583 prepending ~/.pspp/rc to the list of files to process.
7585 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7586 before pulling in a final line.
7587 (null_func, null_int_func) Removed (dead code).
7589 * descript.q: (display) Calculate width of variable name column
7590 properly. Calculate number of valid cases properly. Reported by
7591 palme@uni-wuppertal.de (Hubert Palme).
7593 * filename.c: (init_filename) Use default_config_path instead of
7594 now obsolete CONFIG_PATH.
7596 * getline.c: (getl_initialize) Use include_path instead of now
7597 obsolete INCLUDE_PATH.
7598 (getl_add_file) New argument `where'. All references changed.
7600 * groff.c: (find_font_file) Use groff_font_path instead of now
7601 obsolete GROFF_FONT_PATH.
7603 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7604 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7605 avoid problems with constness.
7607 * str.h: (macro cs_streq) New macro.
7609 * version.h: (glob var default_config_path, include_path,
7610 groff_font_path) New vars.
7612 1998-02-23 Ben Pfaff <blp@gnu.org>
7614 * Many source files: Change verbose_msg() priority levels and
7617 * aggregate.c: Include debug-print.h.
7619 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7621 (static var pre_syntax_message) Document --safer/-s and
7624 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7626 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7627 because it's not used but it's still copied.
7628 (open_file_r) Remove gratuitous debug message.
7630 * filename.c: (safety_violation) New function.
7631 (open_file) Remove gratuitous debug messages. Don't allow pipe
7632 files if set_safer is set.
7634 * get.c: Turn off debugging.
7636 * getline.c: (getl_add_virtual_file) New function.
7637 (getl_read_line) Add verbose_msg() call for opening new syntax
7639 (getl_perform_delayed_reset) Add a return value describing whether
7640 any action was taken. Call reset_eof().
7642 * getline.h: Comment fix.
7644 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7645 place of incorrect `continue'. Use strtok_r() instead of
7646 strtok(). Always check strtok_r() return value.
7647 (groff_read_DESC) Use strtok_r() instead of strtok().
7649 * lexer.c: (reset_eof) New function.
7651 * main.c: (parse) Get a token after performing a delayed reset
7652 action; allow empty syntax files.
7654 * postscript.c: (output_encodings) Use strtok_r() instead of
7657 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7659 * set.q: Comment fixes.
7660 (glob var set_safer) New var.
7661 (internal_cmd_set) Support SAFER.
7663 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7665 * temporary.c: (free_dictionary) Set d->splits to NULL after
7668 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7669 variable deleted, not if it *isn't* deleted.
7671 1998-02-16 Ben Pfaff <blp@gnu.org>
7673 * command.c: (array cmd_table[]) Add MATCH FILES.
7675 * common.c: Comment fixes.
7677 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7678 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7679 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7682 * expr-opt.c: Include str.h. Problem reported by
7683 palme@uni-wuppertal.de (Hubert Palme).
7685 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7686 (static var mtf_by) Change from char ** to variable **.
7687 (static var mtf_master) New var.
7688 (mtf_merge_dictionary) New function.
7689 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7690 var type. Reorder tests properly. Initialize file->dict. Detect
7691 TABLE= without BY=. Read file dictionaries and merge them. Give
7692 subcommand name with IN, LAST, FIRST error messages. Create IN,
7693 LAST, FIRST variables. Comment fixes.
7694 (mtf_free) Don't free default_dict. Free mtf_master.
7696 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7698 (handle_line_buffer) Cast int to size_t in comparison to avoid
7701 * getline.h: Declare getl_mode extern.
7703 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7704 (groff_read_DESC) Make line_size a size_t.
7705 (match_tok) Parenthesize name to avoid macro expansion.
7707 * mis-val.c: (copy_missing_values) New function.
7709 * postscript.c: (postopen) Make buf_size a size_t.
7711 * sfm-read.c: (dump_dictionary) Make global from static. Print
7712 variable info in parts for easier debugging with Checker.
7714 * temporary.c: (copy_variable) Use copy_value_labels().
7715 (new_dictionary) New arg: whether to copy file label, documents.
7717 * val-labs.c: (copy_value_labels) New function.
7719 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7721 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7723 (dup_variable) Set prv_index, get.fv, get.nv.
7725 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7727 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7729 * Many source files: For ANSI-compliance, add empty statement
7730 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7731 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7733 * data-in.c: (parse_numeric) Some header files break on
7734 -DBL_MIN_10_EXP because they get a --; add () for safety.
7735 Reported by palme@uni-wuppertal.de (Hubert Palme).
7737 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7738 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7739 (dfm_close) Use close_file_ext.
7740 (open_inline_file) Set file.file to NULL, not file.
7741 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7742 struct and use open_file_ext().
7743 (read_record) Use file.file.
7745 * file-handle.q: (prepend_current_directory) Pass through special
7748 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7749 (normalize_filename) Pass through special filenames.
7750 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7752 (dirname) Rename blp_dirname() because of name conflict on some
7753 OS. All references changed. Reported by palme@uni-wuppertal.de
7755 (is_special_filename) New function.
7757 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7758 (trim_dictionary) Conditionalize some of the options on whether
7759 GTSV_OPT_MATCH_FILES is in *options.
7760 (rename_variables) Don't allow variables to be renamed as scratch
7762 (MTF_*) New enum series.
7763 (struct mtf_file) New struct.
7764 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7766 (cmd_match_files, mtf_free) New functions.
7768 * lexer.c: (match_int) Needed parentheses around name to escape
7769 macro expansion. Reported by Micah Altman
7770 <maltman@www-vdc.fas.harvard.edu>.
7772 * print.c: Needed to include alloca.h. Reported by Micah Altman
7773 <maltman@www-vdc.fas.harvard.edu>.
7775 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7776 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7779 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7780 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7782 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7784 * html.c: (struct html_driver_ext) Move into htmlP.h.
7785 (html_preopen_driver) Initialize cp_x, cp_y.
7786 (html_submit) Implement as call to output_tab_table().
7787 (change_attributes) New function.
7788 (escape_string) New function.
7789 (output_tab_table) New function.
7791 * list.q: (write_all_headers) Add code for writing headers for the
7793 (clean_up) Write out the html close-table tag.
7794 (determine_layout) Ignore html driver.
7795 (list_cases) Write html data.
7797 * som.c: (som_submit) Move more of the code into output_table().
7799 * tab.c: (static var hit) Make a global var and rename tab_hit.
7800 (static var tab_table_class) Make a global var.
7802 * htmlP.h: New file.
7804 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7806 * dump-sysfile.c: Removed.
7808 * html.c: (preclose) Change comment in emitted code.
7810 * matrix-data.c: Debugging off by default. Comment fixes.
7811 (static var container) New var.
7812 (cmd_matrix_data) Create and destroy container. Initialize
7813 is_per_factor[] to 0s. Move code into new function
7814 string_to_content_type(). Require split values to be present in
7815 the data when ROWTYPE_ is explicit. Call specific function, not
7816 general read_matrices().
7817 (string_to_content_type) New function.
7818 (context) Exclude all whitespace, not just spaces.
7819 (mget_token) A dot is a number. Add assertion.
7820 (static var data) Renamed nr_data.
7821 (static var factor_values) Renamed nr_factor_values.
7822 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7823 only specific case. Close data_file before exit.
7824 (fill_matrix) New function.
7825 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7826 printing. Style fixes. Message fixes. Move code into
7828 (read_matrices_without_rowtype) Rename
7829 matrix_data_read_without_rowtype(). Fix off-by-one error on
7830 loops. Allocate nr_data[] memory from arena.
7831 (read_matrices_with_rowtype) Removed.
7832 (read_splits) Renamed nr_read_splits(). Style fixes.
7833 (read_factors) Renamed nr_read_factors().
7834 (dump_cell_content) Comment fixes. Arguments changed. Change
7835 debug printing. All references changed.
7836 (output_data) Renamed nr_output_data().
7837 (static var wr_content) New var.
7838 (struct factor_data) New struct.
7839 (static var wr_data) New var.
7840 (static var wr_current) New var.
7841 (matrix_data_source_destroy_source) Removed.
7842 (read_matrices_with_rowtype) New function.
7843 (matrix_data_read_with_rowtype) New function.
7844 (wr_read_splits) New function.
7845 (compare_factors) New function.
7846 (wr_output_data) New function.
7847 (wr_read_rowtype) New function.
7848 (wr_read_factors) New function.
7849 (wr_read_indeps) New function.
7850 (glob var matrix_data_source) Make destroy_source member NULL as
7853 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7855 * lexer.c: (syntax_error) Give better error message when at end of
7858 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7859 N_SCALAR to output as plain N.
7860 (mdump_token) Change output format.
7861 (context) Fix message output interaction with spaces in input.
7862 (another_token) New function.
7863 (force_eol) Improved error message.
7864 (static var max_cell_index) New var.
7865 (read_matrices) Init `cells'. factor_values is now per-cell.
7866 Init max_cell_index.
7867 (read_data_lines) Replace `compare' local with new `compare' arg.
7868 Debugging messages changed. Only read factors if per_factor.
7869 Propagate error return from read_factors(), force_eol().
7870 Copy N_SCALAR values across the N vector.
7871 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7872 check parentheses manually since we now have is_per_factor[].
7873 Call read_data_lines() with new args. Check for end of data after
7874 looping, using another_token().
7875 (read_factors) Arguments changed. Use max_cell_index to determine
7876 whether to read or compare factors. Message fixes.
7877 (dump_cell_content) New function.
7878 (output_data) Completely rewritten because content types were
7879 supported to be nested inside factor values, not vice versa.
7881 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7883 * lexer.c: (syntax_error) Support formatted varargs messages.
7885 * matrix-data.c: Turn debugging on by default.
7886 (static content_type[]) New array.
7887 (static content_names[]) New array.
7888 (static rowtype_, varname_) New vars.
7889 (static is_per_factor[]) New array.
7890 (static split_values) Moved declaration.
7891 (static n_continuous, first_continuous) New var.
7892 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7893 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7894 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7895 Check for continuous variables.
7896 [DEBUGGING] (debug_print) Remove content_names[].
7897 (mdump_token) New macro.
7898 (mget_token_dump) New function.
7899 (mdump_token) New function.
7900 (context) New function.
7901 (mget_token) Fix messages.
7902 (static var data, split_values, factor_values) New vars.
7903 (read_matrices) Manage split_values, factor_values.
7904 (read_data_lines) New function.
7905 (read_matrices_without_rowtype) Implemented.
7906 (read_splits) Message fixes. Uses `just_read'.
7907 (read_factors) New function.
7908 (output_data) New function.
7909 (matrix_data_source_destroy_source) Close the file handle.
7910 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7913 * str.c: (strpadcmp) Removed.
7915 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7917 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7919 * Lots of source files: Add cast to unsigned character to calls to
7920 tolower() and toupper().
7922 * aggregate.c: Set default_dict.splits to NULL.
7924 * command.c: (static variable tab[]) Add MATRIX DATA.
7926 * data-in.c: Add debugging defines. Formatting fixes.
7928 * expr-opt.c: Formatting fixes.
7930 * lexer.c: (syntax_error) Message fixes.
7932 * matrix-data.c: New enum series.
7933 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7934 split_values, n_factors, factors, cells, pop_n, contents,
7935 n_contents) New vars.
7936 (cmd_matrix_data) Finished implementation.
7937 (compare_variables_by_mxd_vartype) New function.
7938 [DEBUGGING] (debug_print) New function.
7939 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7940 (read_matrices) New function.
7941 (read_matrices_without_rowtype) New function.
7942 (read_matrices_with_rowtype) New function.
7943 (read_splits) New function.
7944 (mget_token) New function.
7945 (force_eol) New function.
7946 [0] (test_tokenizer) New function.
7947 (matrix_data_source_destroy_source) New function.
7948 (glob var matrix_data_source) New var.
7950 * misc.h: Include ieeefp.h if present.
7952 * split-file.h: (cmd_split_file) Changes corresponding to struct
7955 * str.h: Fix memmem prototype.
7957 * temporary.c: (save_dictionary, restore_dictionary,
7958 free_dictionary) Changes corresponding to struct dictionary
7961 * var.h: (MXD_* enums) New enum series.
7962 (struct matrix_data_proc) New struct.
7963 (struct split) Removed.
7964 (struct dictionary) Changed `splits' member from `split *' to
7966 (macro force_create_variable) New macro. Replaced lots of
7967 create_variable()/assert() calls with calls to this macro.
7969 * vars-atr.c: (discard_variables) Changed assertion.
7970 [GLOBAL_DEBUGGING] (force_create_variable) New function
7971 called by the macro of the same name.
7972 (clear_variable) Changes to delete splits from the dictionary
7973 corresponding to struct dictionary changes.
7975 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7976 corrupted variable `index' values in the dictionary passed in
7977 every time this function is called.
7979 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7980 to struct dictionary changes.
7982 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7984 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7986 * command.c: New includes.
7987 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7988 (cmd_erase) New function.
7989 [unix] (shell) New function.
7990 (run_command) New function.
7991 (cmd_host) New function.
7992 (cmd_new_file) New function.
7994 * expr-prs.c: (parse_primary) Message fix.
7996 * inpt-pgm.c: Formatting fix.
7997 (cmd_reread) Implement the FILE subcommand.
7999 * matrix-data.c: New file.
8001 * q2c.c: (dump_header) Change output commenting style.
8003 * weight.c: Comment fix.
8005 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
8007 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
8009 (buf_10x) Renamed buf_1xx, all references changed.
8010 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
8011 cases now implemented).
8012 (create_sysfile) New function.
8013 (agr_11x_func) New function.
8015 * data-in.c: (parse_numeric) Work properly if there's an
8016 explicitly coded decimal point in the data and decimal places are
8017 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8018 <el@linux.lisse.na>.
8020 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8021 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8022 Eberhard W Lisse <el@linux.lisse.na>.
8024 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8025 strerror.c. Bug reported by Alexandre Oliva
8026 <oliva@dcc.unicamp.br>.
8028 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8029 (static var separate_case_tab) New var.
8030 (cmd_sort_cases) Cancel temporary transformations here. Free
8031 v_sort before return.
8032 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8033 we're reading from a sort stream. Don't cancel temporary
8034 transformations. Offload internal sorting to do_internal_sort().
8035 (do_internal_sort) New function. Handles internal sorting even
8036 when SEPARATE is nonzero. Doesn't free v_sort.
8037 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8039 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8040 sink if SEPARATE is zero.
8041 (read_output_cases) Renamed read_sort_output(), all references
8042 changed. Now uses separate_case_tab when it exists.
8043 (write_separate) New function.
8045 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8046 memory_sink_cases. Don't redundantly call
8047 vfm_source->destroy_source().
8048 (memory_stream_mode) After switching over, set memory_sink_cases
8051 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8053 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8055 (static var prev_case) New, moved out of aggregate_single_case()
8057 (static var buf64_10x, buf_10x) New.
8058 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8059 the 000, 001, 100, and 101 cases. Free prev_case.
8060 (parse_aggregate_functions) Disallow scratch variables.
8061 (free_aggregate_functions) Only free agr_dict if non-null. Use
8062 iter->function to determine numeric/string type, not
8064 (aggregate_single_case) Don't manage prev_case. Initialize
8065 aggregate info after dumping it.
8066 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8067 mean, stddev, weighted stddev definitions.
8068 (dump_aggregate_info) Implemented.
8069 (initialize_aggregate_info) Renamed from
8070 initialize_aggregate_functions(). Initializes dbl[2].
8071 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8072 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8074 * cases.c: (alloc_val) Removed.
8076 * get.c: (cmd_save_internal) Initialize new `dict' member.
8078 * sfm-write.c: (sfm_write_dictionary, write_header,
8079 write_variable, write_value_labels, write_documents) Reorganize,
8080 simplify for new parameter structure.
8081 (write_variable) Only one variable * argument now.
8083 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8084 replaced by new `dict' member.
8086 * temporary.c: (new_dictionary) Initialize n_documents.
8088 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8090 (init_variable, replace_variable) Eliminate usage of alloc_val().
8092 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8094 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8095 signal that AGGREGATE is to be used for forming final cases.
8096 (close_active_file) Call end_func before stopping lagging. Cancel
8097 temporary after finishing compaction.
8098 (write_case) Comment fixes. Cleaned up.
8099 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8102 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8104 * Makefile.am: (BUILT_SOURCES) Add means.c.
8105 (pspp_SOURCES) Add means.c.
8106 (EXTRA_DIST) Add means.q.
8108 * command.c: (array cmd_table[]) Add MEANS.
8110 * common.h: Esthetic fixes. Comment fixes. Test for
8111 MAX_SHORT_STRING greater than 8.
8112 (macros LOWEST, HIGHEST) New.
8114 * data-in.c, data-list.c, recode.c: Comment fixes.
8116 * means.q: New file, base version.
8118 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8119 with LOWEST, DBL_MAX with HIGHEST.
8121 * q2c.c: (dump_vars) Add an enum to array types giving the number
8122 of values for the enum.
8124 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8125 Replace second_lowest_value with second_lowest_flt64.
8127 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8128 second_lowest_value with second_lowest_flt64.
8130 * t-test.q: Comment fix.
8132 * temporary.c: (restore_dictionary) Esthetic fix.
8134 * tokens.h: (force_match_id, force_match, force_string, force_int,
8135 force_num, force_id) Replace msg() with syntax_error().
8137 * var.h: (struct means_proc) New.
8138 (struct variable) Add mns member to `p' union.
8140 * vars-prs.c: (parse_variable, parse_dict_variable,
8141 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8144 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8146 * Makefile.am: (pspp_SOURCES) Add tab.h.
8148 * Most source files: Added a cast to unsigned char in usages of
8149 the ctype is*() functions. Replaced `end of command expected'
8150 calls to msg() with calls to syntax_error().
8152 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8154 * lexer.c: (hex_val) Removed (was dead code).
8155 (idmatch) Parenthesize function name to avoid macro expansion.
8157 * postscript.c: Comment fixes.
8158 (ps_preopen_driver) Change default font size to 10pt.
8160 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8162 (parse_format_spec) Change system-file format spec argument type
8163 to int32. Parse the format spec with bitwise operators.
8165 * sfmP.h: (struct sysfile_format) Removed.
8166 (struct sysfile_variable) Changed print, write members from
8167 sysfile_format to int32.
8169 * tokens.h: Esthetic fixes.
8170 [__GNUC__] (macro id_match) New macro to hopefully speed up
8171 identifier matching.
8172 (macros match_id, match_tok, match_int) Implemented in
8173 compiler-independent manner; no longer GNU C only.
8175 * vfm.h: Include time.h.
8177 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8179 * data-list.c: (dump_fixed_table) Change tab_dim().
8181 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8183 * error.c: Include command.h.
8185 * frequencies.g: Formatting fixes.
8187 * frequencies.q: Add tab_dim() calls. Make the total cell a
8190 * glob.c: Include command.h.
8192 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8194 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8195 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8196 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8197 the other elements (is this right?).
8198 (read_variables) Use lowest, highest members.
8199 (parse_format_spec) New arg `vv' for more stringent checking.
8200 (dump_dictionary) Byteswaps nonexplicit data.
8201 (sfm_read_case) Byteswap numeric data.
8203 * som.c: Initialize table_num to 1.
8204 (render_segments) Remember to increment y_index after each table
8207 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8208 avl_count() on a NULL tree. No title for the second table.
8209 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8210 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8211 fix call to display_variables().
8212 (display_variables) Default to 4 columns, not 3. Set up headers.
8213 Column title is Variable, not Name. Fix index column.
8214 Add joint text. Add tab_dim(). Handle value labels properly.
8215 Handle DISPLAY LABELS properly. Draw boxes correctly.
8216 (describe_variable) Value labels don't need titles. Don't clear
8217 nonexistent index column.
8218 (compare_vectors_by_name) New function.
8219 (display_vectors) New function.
8221 * tab.c: (tab_height) Add assertion.
8222 (tab_null) Add debug code.
8223 (evaluate_dimensions) Add debug code.
8225 * var.h: (struct variable) get_proc data is sometimes used
8226 simultaneously with other per-procedure info, therefore it was
8227 removed from the union. All references changed.
8229 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8231 * ascii.c: (ascii_close_page) Put title on second line of headers
8232 if there is no subtitle.
8234 * command.c: (glob var cur_proc) Move definition here, from
8236 (cmd_remark) Emit blank line before remarks.
8238 * command.h: (glob var cur_proc) Move declaration here, from
8241 * data-list.c: (dump_fixed_table) Fix messages.
8242 (dump_free_table) Call tab_nat_dim().
8244 * descript.q: (dump_z_table) Modify tab_dim() call.
8246 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8248 (dump_statistics) Don't output header.
8250 * groff-font.c: Minor format fix.
8252 * html.c: Comment fix.
8254 * list.q: (write_varname) Indent after advancing page.
8256 * output.h: Minor reordering.
8258 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8259 a reference to eol[].
8260 (struct ps_driver_ext) New member eol[].
8261 (ps_preopen_driver) Initialize eol[].
8262 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8263 defaults. Handle headers. Fix test for minimum page length.
8264 (static var option_tab[]) Add `line-ends'.
8265 (ps_option) Handle line-ends to change eol[].
8266 (postopen) Scale prop_em_width and fixed_width properly. Set the
8267 prologue title to outp_title if applicable. Replace the prologue
8268 line ends with eol[]. Call draw_headers() if headers are enabled.
8269 (text_width) New function.
8270 (out_text_plain) New function.
8271 (draw_headers) New function.
8273 * print.c: (dump_table) Call tab_nat_dim().
8275 * som.c: (som_blank_line) Only advance a line if not at the top of
8277 (som_submit) Move several informational table calls here.
8278 Increment subtable_num if SOMF_NO_TITLE not set.
8279 (output_table) Advance a line if SOMF_NO_SPACING not set.
8280 (render_columns, render_segments, render_simple) Handle spacing
8281 between tables. Handle table titles. Remove debug output.
8283 * som.h: (SOMF_*) New enum series.
8284 (struct som_table_class) New member `flags'.
8286 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8288 (display_variables) Calls tab_nat_dim().
8289 (describe_variable) Remove restriction on number of value labels.
8290 Make value labels separated by thin lines.
8292 * tab.c: (tab_create) Default `flags' to none.
8293 (tab_float) New arg `w'. All references changed.
8294 (tab_nat_dim) New function.
8295 (tab_output_text) No title or spacing.
8296 (tab_flags) New function.
8297 (tabi_flags) New function.
8298 (tabi_title) New function.
8299 (strip_height) Removed.
8300 (tabi_render) Skip title when necessary.
8301 (static var tab_tab_class) Add tabi_flags, tabi_title.
8302 (evaluate_dimensions) Disable display of column, row size.
8303 (sum_columns) Add title height to top header.
8304 (render_strip) Moved within file.
8306 * tab.h: (struct tab_table) New member `flags'.
8308 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8310 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8312 * Most source files: Add `const' attribute in all appropriate
8315 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8316 column to the variables table for use by describe_variable().
8317 (cmd_display) Disable for the present.
8318 (display_documents) Don't wrap documents.
8319 (display_variables) Table has four columns now.
8320 (describe_variable) Table has four columns now. Don't use a
8321 subtable, use joined cells instead.
8323 * tab.c: (tab_create) Don't set `join'.
8324 (tab_realloc) ct array is not made up of a_string's.
8325 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8326 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8327 (text_format) New function.
8328 (tab_title) Rewritten, uses text_format().
8329 (tab_text) Rewritten, uses text_format().
8330 (tab_joint_text) New function.
8332 (static var hit) New variable.
8333 (render_strip) New args r1, r2. Implement joined cells that fit
8335 (tabi_render) Increment hit. Pass new args to render_strip().
8336 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8337 cells. For t_naw and t_nah, ignore joined cells and null cells in
8340 * tab.h: (struct tab_join_rect) Removed.
8341 (struct tab_table) Removed `join'.
8342 (TAB_JOIN_MAIN) Removed.
8343 (struct tab_joined_cell) New struct.
8344 (TAT_NOWRAP) New enum.
8346 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8348 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8350 (ascii_postopen_driver) Fix initialization of *_spacing so that
8351 the TAL_0 bit doesn't count.
8353 * data-list.c: (dump_fixed_table) Use natural width for Format
8356 * glob.c: (rerange) Removed.
8357 (get_date) Formatting fixes. Internationalization fix.
8359 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8362 * postscript.c: (ps_postopen_driver) Replace
8363 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8365 * som.c: (som_submit) Don't eject page before every table.
8366 (output_table) Fix order of arguments on call to area().
8367 (render_columns) Fix calculation of max_len.
8369 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8370 (render_strip) New function.
8371 (strip_height) New function.
8372 (tabi_render) Rewrite as calls to render_strip().
8374 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8375 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8376 with the TAB_* and OUTP_T_* constants.
8378 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8380 * Makefile.am: Formatting fixes.
8382 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8385 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8387 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8389 * dump-sysfile.c: (glob var length) Make type off_t.
8390 (usage) Fix arguments.
8393 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8394 Now right-justification is the default so many references had to
8396 (struct outp_class) Removed line_width, all references changed.
8397 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8398 (struct outp_driver) Add elements horiz_line_width,
8399 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8402 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8404 (postopen) Initialize all the informational members of
8407 * som.c: (som_blank_line) New function, renamed from blank_line(),
8408 all references changed.
8409 (som_submit) Disables drivers whose pages can't be opened.
8410 (render_columns, render_simple, render_segments) Add debug output.
8411 (render_columns) Fix loop range.
8412 (render_simple) Don't try to render the headers, they're taken
8413 care of automatically. Advance cp_y past the table when done.
8414 (render_segments) Fix loop ranges.
8416 * tab.c: Initialize new members of tab_table.
8417 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8418 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8419 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8422 (tab_dim) New function.
8423 (tab_col_width) Removed.
8424 (tab_row_height) Removed.
8425 (tab_output_text) Call tab_dim().
8426 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8427 (tabi_area) Implemented.
8428 (tabi_cumulate) Implemented.
8429 (tabi_render) Partially implemented, but broken.
8430 (var tab_table_class) Made static.
8431 (evaluate_dimensions) New function.
8432 (sum_columns) New function.
8434 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8435 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8436 t_scr, t_srr, t_sentinel. Removed: t_nat.
8437 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8438 max_stack_height, w, h. Removed: ce, re.
8439 (macro blank_line) Removed.
8440 (glob var zero_length) Removed.
8442 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8444 * Most source files: include some of the new include files broken
8447 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8450 * aggregate.c: (glob var outfile) Make static.
8452 * command.c: (glob var pgm_state) Move here.
8454 * common.c: (glob vars endian, second_lowest_value, pgmname,
8455 finished, curdate, cur_proc, start_interactive, history_file) Move
8458 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8460 * file-handle.q: (glob vars files, inline_file) Move here.
8462 * glob.c: Lost lots of glob vars, detailed in individual file
8464 (init_glob) set_printer, set_screen were obsolete, deleted.
8465 set_cprompt has fewer spaces because pspp has fewer letters than
8468 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8469 (inp_nval) Made static.
8471 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8472 tokstr_len, toklongstr, tokint) Move here.
8474 * misc.c: Lost several vars and functions.
8476 * set.q: (all the set_* variables) Move here.
8478 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8479 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8482 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8484 * tab.h: (enum series t_*) New enums.
8485 (struct tab_table) Use arena struct tag. New members ce, re.
8487 * tokens.h: Comment fixes.
8489 * var.h: Move lots of enums and variables and functions and
8490 structures to other files. Use and declare a lot more union and
8491 struct tags. Comment fixes.
8493 * vector.c: (glob vars vec, nvec) Move here.
8495 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8496 init_blanks, last_vfm_invocation) Move here.
8498 * cases.h: New file.
8499 (struct long_vec) Move here.
8500 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8503 * command.h: New file.
8504 (STATE_* enums) Move here.
8505 (glob var pgm_state) Move here.
8507 * format.c: New file.
8508 (glob var formats) Move here.
8509 (parse_format_specifier_name, fmt_to_string,
8510 check_input_specifier, check_output_specifier,
8511 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8514 * format.h: New file. Move functions now in format.c here.
8515 (FMT_* enums) Move here.
8516 (struct fmt_desc) Move here.
8517 (FCAT_* enums) Move here.
8518 (struct fmt_spec) Move here.
8519 (glob vars formats, fmt_parse_ignore_error) Move here.
8521 * inpt-pgm.h: New file.
8522 (INP_* enums) Move here, make #defines into enums.
8523 (glob vars inp_init, inp_init_size) Move here.
8526 (glob vars v_sort, nv_sort) Move here.
8527 (sort_cases, read_sort_output) Move here.
8529 * vector.h: New file.
8530 (struct vector) Move here, add struct tag.
8531 (glob vars vec, nvec) Move here.
8532 (find_vector) Move here.
8535 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8536 reinit_blanks, init_zero, init_blanks) Move here.
8537 (struct case_stream) Move here.
8538 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8539 vfm_disk_stream, sort_stream, data_list_source,
8540 input_program_source, file_type_source, get_source, n_lag) Move
8542 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8545 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8547 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8548 (LDADD) Add libdcdflib.
8550 * ascii.c: Comment and formatting fixes. Almost every external
8551 function had an assert added, checking driver_open and page_open.
8552 (ascii_init_driver) Broken into ascii_preopen_driver,
8553 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8554 (ascii_open_page) Sets page_open.
8555 (ascii_close_page) Clears page_open.
8557 * html.c: Comment and formatting fixes. Almost every external
8558 function had an assert added, checking driver_open and page_open.
8559 (html_init_driver) Broken into html_preopen_driver,
8560 html_postopen_driver, html_close_driver. Manages driver_open.
8561 (html_open_page) Sets page_open.
8562 (html_close_page) Clears page_open.
8563 (html_submit) Disabled.
8565 * lexer.c: (parse_string) Remove debugging printf.
8567 * list.q: (determine_layout) Open a page if one is not yet open.
8569 * output.c: Comment fixes.
8570 (add_class) Set the class member of the new list element.
8571 (parse_options) Don't handle device type.
8572 (colon_tokenize) New function.
8573 (configure_driver) New four-field format with a field for device
8574 type. Now initialize driver_open, page_open, next, and prev
8575 fields. Use new colon_tokenize() function. Don't do a memory
8576 copy to replace a driver, it doesn't work; instead delete the old
8577 driver and insert a new one.
8578 (destroy_driver) Don't call som_destroy_driver(). Close the page
8579 if it's open. Find the class in the list of classes and decrement
8580 that reference count. Remove the driver from the global driver
8582 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8583 references changed. Rewritten. Don't return a driver that's not
8585 (outp_eject_page) All references to som_internal_eject_page()
8586 changed to use this. Sets cp_x to 0 as well as cp_y.
8588 * output.h: (OUTP_I_* enums) Removed.
8589 (struct som_submission_form) Removed.
8590 (struct outp_class) init_driver broken into preopen_driver,
8591 postopen_driver, and close_driver. submit changed to take a
8594 * postscript.c: Comment and formatting fixes. Almost every
8595 external function had an assert added, checking driver_open and
8597 (ps_init_driver) Broken into ps_preopen_driver,
8598 ps_postopen_driver, ps_close_driver. Manages driver_open.
8599 (ps_open_page) Sets page_open.
8600 (ps_close_page) Clears page_open.
8602 * som.c: New file, base implementation.
8604 * som.h: (struct som_table) Add struct tag.
8605 (enum SOM_COL_ACROSS) Removed.
8606 (SOM_ROWS, SOM_COLUMNS) New enums.
8607 (struct som_table_class) Add member `cumulate'. Remove `segment';
8608 change `render' arguments.
8609 (struct som_point, struct som_rect) Removed.
8610 (som_submit_table) Fixed typo, should have been som_submit.
8612 * sysfile-info: (describe_variable) Don't try to insert a
8613 subtable; just destroy it for now.
8615 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8616 references to value labels.
8618 * tab.c: (tab_destroy) New function.
8619 (tab_columns) Change argument.
8620 [0] (tab_submit) Remove dead code.
8621 (tab_title) Allocate string from the table's arena.
8622 (tab_output_text) Only free the buffer if we allocated it.
8623 (tab_submit) New function.
8624 (static vars t, d) New static vars.
8625 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8626 tabi_headers, tabi_cumulate, tabi_render) New functions.
8627 (glob var tab_table_class) New global var.
8629 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8630 encapsulate the rectangle. All references changed.
8632 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8634 * All header files updated to use struct tags in addition to
8635 typedefs for all structures. Don't use word `struct' in struct
8638 * Makefile.am: (pspp_SOURCES) Remove html.c.
8639 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8640 all references updated.
8642 * command.c: (parse_cmd) Remove call to som_check_workspace.
8643 (output_line) Update to new som.
8645 * data-in.c: (parse_numeric) A single dot is not an error; it is
8646 the system-missing value.
8648 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8651 * data-out.c: Added `const' as appropriate to many prototypes.
8652 (convert_E, convert_F, convert_CCx) Take double argument instead
8653 of value * argument.
8654 (convert_format_to_string) Call changed functions appropriately.
8655 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8656 make a local copy of the value.
8658 * descript.q: Remove custom_variables() prototype now provided by
8660 (custom_variables) Don't increment sbc_variables, the caller does
8662 (dump_z_table, display) Update to new som.
8664 * error.c: (vmsg) Add const to prototype. Remove code to handle
8665 `too many errors' condition.
8666 (check_error_count) New function.
8667 (msg) Add const to prototype.
8669 * filename.c: (open_file) Rewrite for elegance.
8671 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8672 (dump_full, dump_condensed, dump_statistics) Update for new som.
8674 * list.q: Don't include somP.h. Change all references to
8675 som_driver_ext to refer to the new members of som_driver. Change
8676 som_internal_eject_page() references to outp_eject_page().
8678 * main.c: (parse) Rewrite for elegance. Add call to
8679 check_error_count().
8681 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8682 Rewrite or revise for new outp_driver_class_list structure.
8683 (outp_iterate_enabled_drivers) Fix comparison between disabled
8684 devices and current device type.
8685 (outp_eject_page) New function.
8687 * output.h: Comment fixes.
8688 (struct outp_driver) New members driver_open, page_open, cp_x,
8689 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8691 (struct outp_driver_class_list) New struct.
8692 (outp_class_list) Changed to type outp_driver_class_list; all
8695 * print.c: (dump_table, print_trns_proc) Updated for new som.
8697 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8698 prototypes for custom subcommands.
8699 (dump_subcommand) Always include the `else'.
8700 (dump_parser) Fix comments in output code.
8702 * set.q: Reordered functions.
8704 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8706 * som.h: Rewritten from scratch.
8708 * str.h: Remove dead code.
8710 * tab.c, tab.h: New files, base implementation.
8712 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8715 * t-test.q: New code from John Williams
8716 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8717 Many many new static vars and defines.
8718 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8719 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8720 (struct value_list) New struct.
8721 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8722 t_crt, t_sig, print_t_groups) New functions.
8723 (cmd_t_test) Implemented.
8725 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8728 * vfm.c: (dump_splits) Update to new som.
8730 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8732 * Makefile.am: (fiasco_SOURCES) Add html.c.
8734 * aggregate.c: Base source.
8736 * ascii.c: (postopen, preclose) Reformat.
8738 * data-out.c, expr-evl.c: Comment fixes.
8740 * filename.c: (open_file) When opening a file for writing, use
8741 line buffering instead of full buffering for better interactive
8742 performance. Suggested by Valerio Aimale
8743 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8744 names `stdin', `stdout', `stderr'.
8746 * groff-font.c: Comment fixes.
8748 * html.c: New file; base version.
8750 * list.q: (write_all_headers, clean_up, determine_layout,
8751 list_cases) Ignore `special' devices for now. Needs to be fixed
8754 * output.c: (outp_init) Add html driver to list; reverse list
8757 * output.h: (struct outp_class_struct) New members `special',
8758 `submit'; comment fixes. All references changed.
8760 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8761 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8763 (postopen) Comment fix.
8764 (preclose) Comment fixes, formatting fixes. Change x->file.file
8765 references to more proper f->file.
8767 * som-high.c: (som_submit_table) Special classes use their own
8770 * som.h: Comment fixes.
8772 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8775 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8777 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8779 * aggregate.c: Still working on this.
8781 * command.c: (cmd_table[]) Add AGGREGATE back in.
8782 (split_words) Make '-' a legal word separator as well as ' '.
8784 * main.c: Comment fixes.
8786 * q2c.c: (dump_parser) Don't require the procedure's full name to
8787 be present, in the generated source.
8789 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8790 multiply specified and let it be default; let MISSING, CRITERIA,
8791 FORMAT be multiply specified.
8792 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8793 (custom_groups) Fix defaults.
8794 (custom_pairs) Check whether this is a PAIRS subcommand before
8795 attempting to parse. Better garbage collection. Proper storage
8797 [DEBUGGING] (debug_print) New function.
8799 * temporary.c: Comment fixes.
8800 (copy_variable) Don't copy variable name and index.
8801 (save_dictionary) Copy variable name and index by hand.
8803 * vars-atr.c: Comment fixes.
8804 (create_variable) New dictionary argument. All references
8806 (common_init_stuff) New dictionary argument. All references
8808 (init_variable) New dictionary argument. All references changed.
8809 (dup_variable) New function.
8811 * vars-prs.c: (parse_variables) If there are any errors, we always
8812 return 0. Previously, it was possible for some types of errors to
8815 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8817 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8820 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8822 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8825 * q2c.c: Comment fixes.
8826 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8828 * t-test.q: (cmd_list) Rename cmd_t_test.
8830 * temporary.c: (new_dictionary) Don't declare as static.
8832 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8834 * aggregate.c: Changes, still not finished.
8836 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8838 * q2c.c: Comment fixes. Now its output is internationalized.
8839 (get_token) Fix parsing of escapes within literal strings.
8840 (main) Fix bad #line directives in output.
8842 * t-test.q: Base implementation.
8844 * temporary.c: (new_dictionary) New function.
8845 (restore_dictionary) [__CHECKER__] Change fill character to *
8848 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8850 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8852 * aggregate.c: Changes, still not finished.
8854 * descript.q, list.q: Comment fixes.
8856 * q2c.c: Almost completely rewritten.
8858 * t-test.q: New file, not complete.
8860 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8862 * aggregate.c: Changes, still not finished.
8864 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8867 * temporary.c: (cancel_temporary) New function.
8869 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8870 of doing it by hand.
8872 * vfm.c: (close_active_file) After restoring a TEMPORARY
8873 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8875 (SPLIT_FILE_procfunc) Comment fix.
8877 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8879 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8881 * aggregate.c: New file, not finished yet.
8883 * command.c: (cmd_table) Add AGGREGATE.
8885 * common.h: (pgm_state) Move declaration to var.h.
8887 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8889 (parse_string) Message fix.
8891 * recode.c: Comment fix.
8893 * sfm-read.c: (read_variables) Code esthetic fixes.
8894 (write_header) Default date is `Jan', not `JAN'.
8896 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8898 * sort.c: (cmd_sort_cases) Farm the work out to new function
8899 parse_sort_variables().
8900 (parse_sort_variables) New function.
8901 (sort_cases) New function. Cancels temporary transformations,
8902 which sorting didn't do previously.
8903 (cmd_sort_cases) Better garbage collection on error. Uses
8905 (write_initial_runs, merge_once) Improved code esthetics.
8906 (sort_stream_read) Reduced to one call to read_output_cases().
8907 (read_output_cases) New function.
8909 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8910 variable labels to 120 characters.
8912 * var.h: Comment fixes.
8913 (glob var pgm_state) From common.h.
8915 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8917 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8918 options. Set *names to NULL on error.
8920 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8922 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8924 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8925 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8927 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8929 * vfm.c: (page_to_disk) Added missing local variables.
8931 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8933 * get.c: Comment fix.
8935 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8936 source is anything other than a disk stream, not just if it's in a
8937 memory stream. Call page_to_disk() before external sort.
8938 (allocate_cases) Message fix.
8940 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8942 (page_to_disk) New function.
8944 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8946 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8948 * common.h: (macro strerror) Remove. From Alexandre Oliva
8949 <oliva@dcc.unicamp.br>.
8951 * get.c: (dict_delete_run) The number of variables to delete is
8952 not necessarily the number of variables that need to be shifted
8954 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8955 too many variables to be deleted.
8957 * postscript.c: Comment fix.
8959 * q2c.c: Include strerror.c. From Alexandre Oliva
8960 <oliva@dcc.unicamp.br>.
8962 * set.q: #undef ON and OFF. From Alexandre Oliva
8963 <oliva@dcc.unicamp.br>.
8965 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8966 early, otherwise errors cause a bad free().
8968 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8969 Oliva <oliva@dcc.unicamp.br>.
8971 * temporary.c: (save_dictionary) Don't allocate memory if
8974 * vfm.c: (memory_stream_write) Message fix.
8976 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8978 * command.c: (static var cmd_table[]) Define REPEATING DATA
8981 * common.h: Added support for broken systems that are missing
8982 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8984 * Many source files: Replace syntax error messages via msg() with
8985 call to syntax_error().
8987 * data-list.c: (dump_fixed_table) Add support for dumping table
8988 for REPEATING DATA as well as DATA LIST FIXED.
8989 (cmd_repeating_data) Allows and requires `/' between subcommands.
8990 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8991 CONTINUED specifications to be omitted. Forces CONTINUED to be
8992 specified if ID is. Calculates starts_end, cont_end from logical
8993 record length as reported by fhp. Calls dump_fixed_table() if
8994 requested. Fixed length of record copied by memcpy.
8995 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8997 (realize_value) Returns sensible value for out-of-range variable
8999 (rpd_parse_record) New argument `ofs'. Fixed confusion between
9000 length of occurrences and length of line. Added warning for
9001 fields that exceed the line length. Fixed infinite loop.
9002 (read_one_set_of_repetitions) Numerous minor changes for more
9003 complete SPSS compliance. Message fixes.
9005 * dfm.c: (dfm_close) If the file being closed is the inline file,
9006 read all the remaining data before closing it.
9007 (dfm_get_record) Don't close the file on lossage, as either it
9008 has been closed already or it doesn't belong to us.
9010 * error.c: (puts_stdout) New function.
9011 (vmsg) Use puts_stdout instead of puts.
9013 * file-handle.q: (fh_record_width) New function.
9015 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9018 (input_program_source_read) Made an old kluge an approved method.
9020 * lexer.c: (syntax_error) New function.
9022 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9025 * output.c: (oupt_get_paper_size) Message fix.
9027 * q2c.c: Numerous fixes to formatting of generated code made to
9028 conform to GNU coding standards. Uses syntax_error() in generated
9029 code. Other miscellaneous generated message fixes. Added support
9030 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9031 RAND_MAX, and/or strerror().
9033 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9035 * data-in.c: Comment fixes.
9037 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9038 (find_variable_input_spec) New function.
9039 (cmd_repeating_data) Initializes id_spec.
9040 (rpd_parse_record) Implemented.
9041 (read_one_set_of_repetitions) Returns -3 by default in order to
9042 kluge out some potential bugs.
9044 * data-out.c: Comment fixes.
9046 * file-type.c: (internal_cmd_record_type) Message fix.
9048 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9049 for handling -3 return value.
9051 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9053 * data-list.c: Comment fixes.
9054 (struct dls_var_spec) Reordered members.
9055 (read_from_data_list_fixed) Restructured.
9056 (struct repeating_data_trns) Reordered members. Renamed `starts'
9057 as `starts_beg', `ends' as `starts_end'.
9058 (cmd_repeating_data) Calculates length of repeated data if
9059 necessary and possible.
9060 (parse_num_or_var) Don't allow string variables.
9061 (realize_value) New function.
9062 (rpd_msg) New function.
9063 (rpd_parse_record) New function. Currently stubbed out.
9064 (read_one_set_of_repetitions) Implemented.
9066 * inpt-pgm.c: (input_program_source_read) Comment fix.
9068 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9070 * command.c: (cmd_end_repeat_p) Removed.
9071 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9072 (parse_cmd_name) Removed.
9074 * data-list.c: Comment fixes.
9075 (data_list_pgm) Removed `eof' member.
9076 (static var first) New var.
9077 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9078 FILE TYPE file inside FILE TYPE structures.
9079 (append_var_spec) Appends to *first, not dls.spec.
9080 (parse_fixed) Message fixes.
9081 (struct rpd_num_or_var) New.
9082 (struct repeating_data_trns) New.
9083 (static var rpd) New.
9084 (cmd_repeating_data) New function.
9085 (parse_num_or_var) New function.
9086 (parse_repeating_data) New function.
9087 (read_one_set_of_repetitions) New function.
9089 * file-type.c: (cmd_file_type) Message fixes. Always
9090 default_handle to FILE TYPE file handle.
9091 (internal_cmd_record_type) Message fixes.
9093 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9095 * repeat.c: Comment fix. Disable debugging.
9097 * temporary.c: (restore_dictionary) Sets splits to NULL and
9098 n_splits to 0 before destroying the variables because now doing
9099 this tries to remove split variables.
9101 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9102 destroying the dictionary.
9103 (clear_variable) Removes a variable from splits after destroying
9106 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9108 * cmdline.c: (set_compat) Removed.
9109 (pick_compat) Removed.
9110 (parse_command_line) Removed -c option.
9111 (pre_syntax_message) Removed -c option.
9112 (usage) Remove compatibility code.
9114 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9115 (glob var compat) Removed.
9117 * compute.c: (type_check) Fixed messages about type mismatches.
9119 * data-list.c: (cmd_data_list) Removed compatibility code.
9120 (fixed_parse_compatible) Calls convert_negative_to_dash().
9121 Fixed bug where it only set the variable in fx.spec if it created
9122 the variable itself.
9123 (dump_fmt_list) Spelling fix.
9124 (cut_field) Removed compatibility code.
9126 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9129 * expr-evl.c: (evaluate_expression) Implement LAG.
9131 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9132 (parse_neg) Calls convert_negative_to_dash().
9133 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9136 * expr.h: (struct expression_struct) Removed member max_lag.
9138 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9139 (internal_cmd_record_type) Removed special handling to produce
9140 negative numbers from dash tokens.
9142 * getline.c: (static var DO_REPEAT_level) New var.
9143 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9144 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9145 copy_with_DO_REPEAT_substitutions().
9146 (getl_read_line) Maintains value of getl_mode. Calls
9147 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9149 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9151 * getline.h: (getl_mode) New glob var.
9153 * glob.c: Comment fixes.
9154 (init_glob) Restructured. Sets set_seed.
9155 (init_compat_dependent) Removed. All references removed.
9156 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9157 (__htonl, __htons) Removed. (What were these for?)
9159 * lexer.c: (static var tbl) Dash set to class CNUM.
9160 (make_hexit) New function from data-out.c.
9161 (get_token_representation) Rewritten.
9162 (convert_negative_to_dash) New function.
9163 (lex_init_compat_dependent) Removed.
9164 (yylex) A dash is parsed as part of a number if it is followed by
9165 a digit. The ASCII representation of a number is copied to
9166 tokstr. String parsing farmed out to parse_string(). Comment
9168 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9170 (preprocess_line) Line processing depends on interactive/batch
9171 mode, not on compatibility mode. Removed PC+ compatibility code.
9173 * loop.c: (loop_3_trns_proc) Comment fix.
9175 * main.c: Remove dead code.
9176 (main) Remove call to init_compat_dependent().
9178 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9181 * print.c: (parse_string_argument) Calls
9182 convert_negative_to_dash().
9183 (fixed_parse_compatible) Calls convert_negative_to_dash().
9185 * repeat.c: (RPT_* defines) Removed.
9186 (struct rpt_numeric) Removed.
9187 (struct repeat_entry) New member type, changed `replacement' from
9189 (clean_up) Deallocation adapted to new repeat_entry.
9190 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9191 usage. Creates vars for `type' of 1.
9192 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9193 (store_numeric) Rewritten, new interface.
9194 (parse_numbers) Rewritten.
9195 (parse_strings) Rewritten.
9196 (find_DO_REPEAT_substitution) New function.
9197 (perform_DO_REPEAT_substitutions) New function.
9198 (copy_with_DO_REPEAT_substitutions) Removed.
9199 (debug_print) Rewritten.
9201 * set.q: Comment fix.
9202 (custom_results) Removed compatibility code.
9203 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9206 * sysfile-info.c: (cmd_display) Removed compatibility code.
9208 * tokens.h: Comment fixes.
9209 (token types enum) Removed `toktype' typedef name for this int
9210 type. Removed SUBST. Restructured.
9212 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9214 * vars-prs.c: Comment fix.
9216 * vfm.c: Comment fixes.
9217 (glob var n_lag) New var.
9218 (static vars lag_count, lag_head, lag_queue) New vars.
9219 (procedure) Removed argument nlag.
9220 (setup_lag) New function.
9221 (close_active_file) Discards lagging state.
9222 (lag_case) New function.
9223 (lagged_case) New function.
9224 (write_case) Lags a case if lagging.
9226 * weight.c: (cmd_weight) Removed compatibility code.
9228 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9230 * getline.h: (struct getl_script) New members loop_index, macros.
9232 * getline.c: (getl_add_file) Sets first_line field to NULL.
9233 (getl_add_DO_REPEAT_file) New function.
9234 (handle_line_buffer) When the current line's length is negative,
9235 set the filename and line number. Increment line number after
9236 reading line. Pass the line to
9237 copy_with_DO_REPEAT_substitutions() for processing.
9238 (getl_close_file) Free DO REPEAT lines before freeing the
9239 filename, and just set the filename to NULL when doing this,
9240 because otherwise the filename gets freed twice.
9242 * glob.c: (glob var queuing) Removed. All references removed.
9244 * lexer.c: Comment fixes.
9245 (get_token_representation) New function.
9247 * repeat.c: Comment fixes.
9248 (struct repeat_entry) Replaced type and v union members with a
9250 (append_record) New function.
9251 (internal_cmd_do_repeat) Started reforming it for the new
9252 repeat_entry struct. Properly records filename changes in the
9253 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9254 strncasecmp() result usage. Uses append_record() to simplify.
9255 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9258 (copy_with_DO_REPEAT_substitutions) Started coding.
9260 [DEBUGGING] (debug_print_lines) New function.
9262 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9264 * tokens.h: (macro is_id1, is_idn) New macros.
9266 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9268 * cmdline.c: (static var pre_syntax_message) Changed `win'
9269 compatibility mode to `wnd'.
9271 * data-list.c: (fixed_parse_spss) Renamed
9272 fixed_parse_compatible().
9274 * glob.c: (init_glob) Excise unused code for
9275 program_invocation_short_name.
9277 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9280 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9282 * set.q: `win' compatibility renamed `wnd'.
9284 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9286 * filename.c: [__WIN32__] Change the included Windows header files
9288 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9289 second character is absolute.
9290 (dirname) Fix logic error. Don't printf() the results.
9291 (prepend_dir) Don't printf() the results.
9293 * getline.c: (handle_line_buffer) New function.
9294 (getl_read_line) Reads line with handle_line_buffer() when
9296 (getl_close_file) Discard line buffer data.
9298 * getline.h: Comment fixes.
9299 (struct getl_line_list) New struct.
9300 (getl_script_struct) Added line buffer members. These are hooks
9301 for use by DO REPEAT to allow it to insert virtual source code
9304 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9305 Override Borland C++ stupidity that claims Windows has a console
9308 * repeat.c: This is in the process of being restructured from
9309 using a token-buffering approach to the DO REPEAT facility to
9310 using the more flexible approach of a line-buffering approach in
9311 conjunction with the getline module. Comment fixes.
9312 (struct tok_struct) Removed.
9313 (static vars queue_index, queue_head, queue) Removed.
9314 (static vars line_buf_head, line_buf_tail) New vars.
9315 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9317 (pull_queue, destroy_queue) Removed.
9318 [DEBUGGING] (debug_print_tokens) Removed.
9320 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9322 * file-handle.q: (prepend_current_directory) New function.
9323 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9324 current directory before normalizing filename.
9326 * filename.c: (gnu_getcwd) New function.
9327 (absolute_filename_p) New function.
9328 (search_path) New argument, PREPEND. All references changed to
9329 pass NULL except those explicitly mentioned. Uses
9330 absolute_filename_p(). Prepends PREPEND before trying the
9332 (dirname, prepend_dir) New functions.
9334 * getline.c: (getl_get_current_directory) New function.
9335 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9338 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9340 * In several source files, the term `script' was replaced with
9341 `syntax file' inside error messages. Usage of the term `script'
9342 in the sense of a syntax file is now deprecated.
9344 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9347 * dump-sysfile.c: (usage) Update message.
9349 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9351 * getline.h: (glob var getl_include_path) Declare extern.
9353 * list.q: Define EXTERN as extern before #including somP.h.
9355 * var.h: Remove declaration of `disptype' variable.
9357 * vfm.c: (close_active_file) After switching the data sink to a
9358 data source, set vfm_sink to NULL, because it doesn't exist any
9361 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9363 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9364 _matherrl() to ignore all math errors.
9366 * sfm-read.c: (read_value_labels) When reading the labels from
9367 disk, read the little parts separately instead of as a struct;
9368 this avoids alignment problems.
9370 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9371 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9372 (write_header) Allocates and initializes elem_type.
9373 (sfm_write_case) Uses elem_type to determine how to handle each
9375 (sfm_close) Frees elem_type.
9377 * sfmP.h: Comment fix.
9378 [__BORLANDC__] Uses #pragma -a to adjust structure member
9381 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9383 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9385 * common.c: Fix typo.
9387 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9388 sense of the condition.
9390 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9391 line-continuation backslash.
9393 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9395 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9396 non-constant expression as an argument to sizeof.
9398 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9399 undefine gettext macro because that's a conio function.
9401 * hash.h: (hsh_prime_tab declaration) Remove.
9403 * list.q: (write_fallback_headers) Move `leader' allocation out of
9404 main loop. Change to local_alloc() allocation.
9406 * output.h: Formatting fixes. Put __attribute__ in right place on
9407 function prototypes.
9409 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9410 incorrect `SECOND_LOWEST_VALUE' references to proper
9411 `second_lowest_value'.
9413 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9414 value. This way 2 out of 3 of the som files define the vars
9415 extern, the correct way, that actually works under BC++.
9416 (som_set_float) Don't use nonconstant initializers for a struct.
9418 * som-high.c: Add the standard alloca() header.
9419 (replicate_table) Add prototype.
9421 Merged DISPLAY routine.
9422 * sysfile-info.c: (AS_*) New enum series.
9423 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9425 (cmd_display, display_macros, display_documents,
9426 display_variables) Stolen from defunct display.c.
9427 (describe_variable) New function.
9429 * temporary.c: [0] (display_tree) New debug function.
9430 (copy_variable) Performs shallow copy of value labels instead of
9431 deep copy; i.e., just copys the AVL tree and increments the
9434 * val-labs.c: Comment fixes.
9435 (do_value_labels) Optionally skip leading forward slash.
9436 (get_label) Creates only a single value label instead of many
9437 copies of one, and sets the reference count.
9439 * display.c: Removed.
9441 * dump-sysfile.c: New file, not yet complete.
9443 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9445 For lots of source files I added more verbose_msg's. These aren't
9446 listed below as they have tested as being benign. In some cases
9447 these replaced debug_printf() calls.
9449 * output.c: (outp_read_devices) Message fix.
9451 * postscript.c: (output_encodings) Message fix. Reports errors on
9453 (postopen) Message fix.
9455 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9457 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9459 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9462 * main.c: Remove <malloc.h> #include.
9464 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9465 instead of trying to just set the missing[] itself, which is a
9468 * sfm-read.c: (read_variables) Same.
9470 * str.h: Add memmem() prototype.
9472 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9474 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9476 * Makefile.am: (q2c) Don't include any libraries in the link.
9478 * dfm.c: (force_line_buffer_extension) New macro.
9479 (count_tabs) New function.
9480 (tabs_To_spaces) New function.
9481 (read_record) Calls tabs_to_spaces() on the line being processed.
9483 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9484 have to be compiled twice (once for CC, once for LOCAL_CC).
9486 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9488 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9489 (LDADD) Add @INTLLIBS@.
9490 (q2c) Add LIBS, @INTLLIBS@ to link step.
9492 * inpt-pgm.c: Turn off debugging.
9494 * postscript.c: (postopen) Format fix. local_free() blocks
9495 returned by local_alloc(); don't free() them.
9497 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9499 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9502 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9503 LEN arg, not simply the full string length.
9505 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9506 directories before generic temp file directories.
9508 * vfm.c: Disable debugging.
9510 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9512 * get.c: Comment fix.
9513 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9515 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9517 * expr-prs.c: (debug_print_postfix) Conditionally included on
9518 GLOBAL_DEBUGGING. Removed out_header() reference.
9520 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9522 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9524 * ascii.c: Removed obsolete ascii_close_page() prototype.
9526 * command.c: (output_line) Comment fix.
9528 * data-in.c: Formatting fix.
9529 (parse_string_as_format) Now the `fc' argument is used only for
9530 the purpose of error messages; it is not an index into the string
9531 passed. All references changed.
9533 * data-list.c: Comment fix.
9534 (cut_field) Comment fix. Now returns the column number of the
9535 position of the field cut out on success.
9536 (parse_field) Added `column' argument. Puts the column numbers in
9538 (read_from_data_list_free, read_from_data_list_list) Record the
9539 column number returned by cut_field(), pass it to parse_field().
9541 * dfm.c: Comment fix.
9543 * do-ifP.h: Comment fix.
9545 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9546 the SYSMIS function.
9548 * expr.h, exprP.h: Comment fix.
9550 * glob.c: (init_glob) Only calls setlocale() and family if
9553 * hash.h: Comment fix.
9555 * include.c: Comment fix.
9557 * output.c: Comment fix.
9559 * postscript.c: (ps_line_intersection) Simplified assertion.
9561 * repeat.c: Comment fix.
9563 * vars-atr.c: Comment fix.
9565 * vars-prs.c: Comment fix.
9567 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9568 behavior with usage of postincrement.
9569 (memory_stream_read) Discards cases as it goes.
9571 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9573 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9576 * Most source files: Includes debug-print.h, related comment
9579 * cases.c: (alloc_val) Removed complex allocation code. Merely
9580 increments default_dict.nval and returns the former value.
9581 (envector, devector) Removed references to lv member of struct
9584 * common.h: (macro VME) Replaced complex definition with simple
9587 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9588 read_active_file and cancel_input_pgm.
9589 (read_from_data_list, cancel_data_list) Removed.
9590 (data_list_source_read, data_list_source_destroy_source) New
9592 (glob var data_list_source) New var.
9594 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9595 (cmd_begin_data) Improved criteria for an input program accessing
9596 the inline file. Still not perfect.
9598 * do-if.c: (do_if_trns_proc) Simplified debug output.
9600 * expr-prs.c: Comment fixes.
9601 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9603 * file-handle.q: (fh_close_handle) Simplified debug output.
9605 * file-type.c: Comment fixes.
9606 (cmd_file_type) Sets vfm_source instead of read_active_file and
9608 (cmd_end_file_type) On failure, discards variables in place of
9609 just canceling the input program.
9610 (read_from_file_type) Renamed file_type_source_read.
9611 (cancel_file_type) Renamed file_type_source_destroy_source.
9612 (glob var file_type_source) New var.
9614 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9615 (cmd_get) Initializes options to GTSV_NONE before passing to
9616 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9617 instead of read_active_file and cancel_input_pgm.
9618 (cmd_save_internal) Initializes options before passing to
9619 trim_dictionary(). Local var `nval' removed.
9620 (dict_delete_run) Comment fixes.
9621 (trim_dictionary) Comment fixes. Disallows scratch variables if
9622 GTSV_OPT_SAVE set in options.
9623 (read_from_get) Renamed get_source_read.
9624 (cancel_get) Renamed get_source_destroy_source.
9625 (glob var get_source) New var.
9627 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9628 read_active_file and cancel_input_pgm.
9629 (read_from_input_program) Renamed input_program_source_read.
9630 Simplified debug output.
9631 (cancel_input_program) Renamed
9632 input_program_source_destroy_source.
9633 (glob var input_program_source) New var.
9635 * loop.c: (loop_1_trns_proc) Simplified debug output.
9637 * main.c: (dump_token) Made eof output more explicit.
9639 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9642 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9643 code for always-memory or always-disk cases. malloc's case-list
9644 based on vfm_source_info.ncases. Explicit support for
9645 memory_stream via memory_source_cases.
9646 (do_external_sort) Sets vfm_source instead of read_active_file and
9648 (allocate_file_handles) The temporary directory permissions are
9649 set to 0700 instead of 0777.
9650 (allocate_cases) Formatting fixes. Simplified debug output.
9651 (output_record) Compacts the case if necessary before writing it
9653 (close_handle, open_handle_w) Simplified debug output.
9654 (write_initial_runs) Destroys vfm_sink, then sets it to
9655 sort_stream. Writes records to memory based on
9656 vfm_sink_info.case_size.
9657 (write_to_sort_cases) Renamed sort_stream_write().
9658 (merge) Simplified error handling. Simplified debug output.
9660 (read_from_external_sort) Renamed sort_stream_read().
9661 Reads records based on vfm_source_info.case_size.
9662 (sort_stream_write) Writes records to memory based on
9663 vfm_sink_info.case_size.
9664 (sort_stream_mode) New function.
9665 (glob var sort_stream) New variable.
9667 * temporary.c: (cmd_temporary) Simplified debug output.
9668 (copy_variable) Removed references to `lv'.
9670 * title.c: (get_title) Simplified debug output.
9672 * var.h: Comment fixes.
9673 (struct get_proc) Removed member `lv'.
9674 (struct variable) Removed member `lv'. Comment fixes.
9675 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9677 (struct case_stream) New.
9679 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9680 read_active_file references to use vfm_source.
9681 (init_variable, replace_variable) Removed references to `lv'.
9683 * vfm.c: Comment fixes.
9684 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9686 (static var queue, qh, qt, n_lag) Removed. All references
9688 (glob var compaction_necessary, compaction_nval, compaction_case,
9689 paging) New variables.
9690 (record_case) Removed.
9691 (procedure) Comment fixes. Calls vfm_source->read() instead of
9694 (prepare_for_writing, arrange_compaction, make_temp_case,
9695 vector_initialization, setup_filter) New function.
9696 (open_active_file) Most of the code moved into the abovementioned
9697 new functions. Now sets temp_dict to &default_dict if there is no
9698 temporary dictionary, for convenience. New debug output.
9699 (close_active_file) Deals with changing the sink to the source.
9700 Calls finish_compaction(). Frees compaction_case. Mostly
9702 (glob vars disk_source_file, disk_sink_file) New vars.
9703 (destroy_active_file, read_from_memory) Removed.
9704 (disk_stream_init, disk_stream_read, disk_stream_write,
9705 disk_stream_mode, disk_stream_destroy_source,
9706 disk_stream_destroy_sink) New functions.
9707 (glob var vfm_disk_stream) New var.
9708 (glob vars memory_source_cases, memory_sink_cases,
9709 memory_sink_iter, memory_sink_max_cases) New vars.
9710 (memory_stream_init, memory_stream_read, memory_stream_write,
9711 memory_stream_mode, memory_stream_destroy_source,
9712 memory_stream_destroy_sink) New functions.
9713 (glob var vfm_memory_stream) New var.
9714 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9715 named `more_cases'. Simplified debug output. Otherwise mostly
9717 (record_case) Moved into the stream drivers. Removed.
9718 (transform) Removed (was dead code).
9719 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9720 common case that the splits don't change, we don't need to copy
9721 the case into prev_case again--pointless.
9722 (compact_case) New function.
9723 (finish_compaction) New function.
9725 * vfmP.h: Comment fixes.
9726 (DEV_* enum series) Removed.
9727 (struct storage) Renamed `stream_info'. Removed variant record.
9728 Removed `device' member.
9730 * debug-print.h: New file.
9732 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9734 * autorecode.c: Turned off debugging.
9736 * data-list.c: (destroy_dls) Closes the associated file handle.
9738 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9739 parse_variables() options.
9741 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9743 * display.c: (display_variables) Really fixed null cell bug.
9745 * file-handle.q: (fh_close_handle) Changed debugging message.
9747 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9748 parse_variables() options.
9750 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9751 (cmd_list) Fails if no variables specified.
9752 (determine_layout) Writes blank lines manually.
9754 * loop.c: (loop_1_trns_proc) Made debugging code only print
9755 messages if debugging.
9757 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9758 parse_variables() arguments.
9759 (main) Parses optional parenthesized options to varlist
9760 subcommands into sbc->message.
9762 * sfm-read.c: Format fix.
9764 * var.h: (FV_*) New enum series.
9765 (PV_*) New enum PV_NO_SCRATCH.
9767 * vars-prs.c: (find_var) Removed.
9768 (fill_all_vars) Takes FV_* enum instead of boolean third
9769 argument. Rewritten to deal with scratch as well as system
9771 (parse_variables) Error message on scratch variable if
9774 * vfm.c: (static var virt_begin_func) New var.
9775 (procedure) Sets up virt_begin_func.
9776 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9777 after dump_splits(). For succeeding groups changes, calls
9778 virt_begin_func() instead of begin_func().
9780 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9782 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9785 * dfm.c: Added some debugging messages, disabled by default.
9786 (open_file_r) Fixed error message.
9787 (read_record) On eof on inline_file, instead of calling
9788 fh_close_handle(), simply jump to eof label like a normal file.
9791 * display.c: Thin lines between rows for certain kinds of
9792 listing. Fixed `null cell' bug.
9794 * error.c: (failure) Flush stdout, stderr before failing.
9796 * file-handle.q: (fh_close_handle) Added debugging message.
9798 * frequencies.q: (dump_full) Bottom line extends across entire
9799 table width. Changed title formatting.
9800 (dump_condensed) Changed title formatting.
9801 (dump_statistics) Fixed title formatting.
9803 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9804 Sets default value of set_format.
9806 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9807 Passes write_all_headers() to procedure() as pre-group func.
9808 (write_all_headers) New function.
9809 (determine_layout) Removed calls to write_header().
9810 Calls blank_line() before and after write_fallback_headers().
9812 * recode.c: (recode_trns_free) Only attempts to free head->map if
9815 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9816 file variable names but gives a warning. Sets `left' based on
9817 first character being/not being `#'. On lossage frees dict->var.
9819 * som-high.c: (som_draw_title) Simplified title formatting.
9821 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9823 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9825 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9826 beginning. Frees v_src, v_dest on successful exit. Frees
9827 h_trans[*], h_trans on lossage.
9828 (recode) Frees h_trans[*], h_trans.
9830 * dfm.c: (dfm_close) Formatting change.
9831 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9832 longer allocates its own in inline_file.
9833 (open_file_r) Passes the local dfm_fhuser_ext to
9835 (open_file_w) Message fix.
9836 (read_record) Buffer reallocation strategy changed. Frees
9837 ext->line even in inline_file to prevent leaks.
9838 (dfm_put_record) Fixed bug where `ext' was cached before the file
9839 was opened and thus it would be NULL when the file really was
9841 (cmd_begin_data) Sets up inline_file basics itself, then calls
9842 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9844 * list.q: (write_line) Formatting fix.
9845 (clean_up) Minor strategy change. Sets proportional font after
9847 (determine_layout) Sets fixed font before writing regular headers,
9848 or after writing fallback headers.
9850 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9851 and KEEP vars after using them.
9853 * postscript.c: (ps_init_driver) Frees x->family.
9854 (postopen) When loading fonts, free the temporary font name buffer
9856 (ps_text_set_font_by_position) Free temporary font name buffer
9858 (text) Fixed code that calculated `lig' so that `lig' always gets
9859 initialized. Formatting fix.
9861 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9863 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9864 cells, not xmalloc(), so that the cells will get destroyed
9867 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9870 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9872 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9875 * dfm.c: Comment fix.
9877 * list.q: Comment fixes. Include somP.h. Removed static vars
9878 table, n_columns, n_rows, part. New struct list_ext. New static
9880 (n_lines_remaining, n_chars_width, write_line) New functions.
9881 (cmd_list, list_cases) Rewritten.
9882 (begin_row, end_row, flush_table) Removed.
9883 (write_header, clean_up, write_varname, write_fallback_headers,
9884 determine_layout) New functions.
9886 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9888 * output.h: Comment fix.
9890 * postscript.c: Comment fix.
9891 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9892 added font_size. All references changed.
9893 (ps_init_driver) Initializes font_size. Simplified space checking
9895 (static var option_tab[]) Removed prop-size, fixed-size; added
9897 (ps_option) Handles font_size.
9899 * som-high.c: Moved prototypes into somP.h.
9900 (som_init_driver) New function.
9901 (som_submit_table) Moved some code into new function
9903 (build_target) Moved some code into new function
9904 som_internal_eject_page().
9905 (som_eject_page) Uses som_internal_eject_page().
9906 (som_internal_eject_page) New function.
9908 * som-low.c: Moved prototypes into somP.h.
9910 * som.h: Formatting fixes.
9912 * somP.h: (struct som_driver_ext) Removed em_width;
9913 added prop_em_width, fixed_width.
9915 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9917 * Makefile.am: Added `localedir' definition. Added
9918 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9920 * ascii.c: (macro draw_line) Fixed capitalization.
9922 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9923 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9924 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9925 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9926 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9927 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9928 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9929 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9930 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9931 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9932 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9933 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9934 for internationlization.
9936 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9938 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9940 * do-if.c, sort.c, val-labs.c: Comment fixes.
9942 * glob.c: (init_glob) Uncommented, updated i18n support.
9944 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9945 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9946 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9947 the declarations of macros taking arguments a lot nicer.
9949 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9951 * error.h: Removed CE, CW aliases for SE, SW.
9953 * q2c.c: Removed explicit streq() definition since it's duplicated
9956 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9957 stats.h, str.h, tokens.h: Made the declarations of macros taking
9958 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9961 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9963 * cmdline.c: Comment fixes.
9964 (pick_compat) Changed return type to int. Now, instead of setting
9965 glob var `compat' to the emulation, returns the emulation. All
9967 (parse_command_line) Added terminating null to end of
9968 `long_options' array definition.
9969 (pre_syntax_message) Fixes.
9970 (usage) Shows the default emulation in the syntax message by
9971 calling pick_compat().
9973 * getline.c: (getl_add_include_dir) Separates paths with
9974 PATH_DELIMITER, not DIR_SEPARATOR.
9976 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9977 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9979 * output.c: (outp_configure_macro) Make earlier definitions for a
9980 particular key override later ones for the same key.
9982 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9984 * ascii.c: Comment fixes.
9986 * output.c: (outp_get_paper_size)
9987 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9989 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9991 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9992 <errno.h>. GNU libc 2 enforces this!
9994 * command.c: (parse_cmd) Fixed problem with `else' clause being
9995 paired with wrong `if'. Comment fix.
9997 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9999 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
10000 blp_getline() to getline().
10002 * output.c: (outp_eval_dimension) Changed the fix from last time;
10003 there was no variable `a'.
10005 * q2c.c: (get_line) Fixed boundary condition overrun bug.
10007 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
10009 * output.c: (outp_evaluate_dimension) Fixed handling of negative
10010 numbers having fractional parts. Added case of a fraction without
10011 a whole-number part.
10013 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
10015 * ascii.c: (ascii_text_get_font_position) Removed.
10017 * expr.h, exprP.h: Disabled debugging.
10019 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10022 * output.h: (struct outp_class_struct) Removed
10023 text_get_font_position method. All references deleted.
10025 * postscript.c: Big change here. Fontmaps were completely
10026 eliminated because of a change in philosophy. Comment fixes.
10027 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10029 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10030 `fixed_name' members removed. New members `prop_family',
10031 `fixed_family'. `family' member changed to type char *.
10032 (static var ps_fontmaps) Removed.
10034 (ps_init_driver) Removed obsolete references, updated.
10035 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10036 fontmap, of course. Refers to font names through internal_name
10037 rather than subversive means. Frees proper items.
10038 (static var option_tab[]) Removed `fontmap-file' option; renamed
10039 `fixed-font', `prop-font'.
10040 (ps_option) Corresponds to option_tab[].
10041 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10042 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10043 hash_family) Removed.
10044 (postopen) Generates font names from family names. Gets
10045 PostScript font name properly. New prologue file comment `!!!'
10047 (ps_open_page) Adds translate_x, translate_y to BP prologue
10048 function; gives SF argument floating-point format.
10049 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10050 font name. Doesn't change font family.
10051 (ps_text_set_font_by_position) Generates Groff font name from font
10052 family name instead of through table lookup.
10053 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10054 all references changed. Reduced to simple string assignment.
10055 (ps_get_font_name) Removed.
10056 (ps_get_font_family) Reduced to string return.
10057 (text) Doesn't save `position' since it no longer exists. Ugly
10058 kluge to save font family--fix soon?
10059 (load_font) Removed PostScript name argument.
10061 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10063 * postscript.c: Comment fix.
10064 (ps_open_page) Puts scale factor in PostScript output.
10066 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10068 * Makefile.am: Distcleans q2c.
10070 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10072 * ascii.c: (delineate) Sets text size even if width is zero.
10074 * command.c: Comment fix.
10075 (static var cmd_table[]) Re-enabled EVALUATE command.
10076 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10077 of comments in script files. Now more liberal on criteria for
10078 performing a state transition--if *anything* happened correctly,
10079 not just if *everything* happened correctly.
10081 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10082 Checker segfault on formatting large numbers and why in the fsck
10083 hadn't I noticed this before?
10085 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10087 * list.q: (cmd_list) Commented out the actual output routine
10088 because of various problems. Probably will abandon the idea of
10089 using the general `crushed tables' for the LIST procedure.
10091 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10092 clearing it. Allocates a new var_by_name dictionary before trying
10093 to add members to it.
10095 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10096 `sib'. Changed type of `node' argument.
10097 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10098 avl_walk_inorder().
10099 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10100 [DEBUGGING] Only deletes the variable from var_by_name if that var
10103 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10105 * Makefile.am: Added include files to SOURCES. Added
10106 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10107 includes rules for q2c. Added `boast' target.
10109 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10111 * Makefile.am: Maintainer-clean Makefile.in.
10113 * Makefile.am: Fixed redundant EXTRA_DIST line.
10115 * ascii.c: Comment fixes.
10116 (ascii_line_vert) Fixed overly aggressive range check.
10118 * display.c: Removed dead code.
10120 * list.q: Turn debugging on.
10121 (flush_table) New debug code.
10123 * sfm-read.c: (read_value_labels) malloc's the structure before
10124 trying to assign to its members.
10126 * sfm-write.c: Comment fix.
10128 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10130 (output_table) No arguments anymore--gets them through `som'
10131 global. New debug code. In crushed tables, now sets `htv' as
10132 well as `hv' to avoid bad confusion later.
10133 (dump_crush_page) New debug code.
10135 * som-low.c: (som_dump_crush_page) New debug code.
10137 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10139 All source files: Broke long lines into multiple lines.
10141 * ascii.c: (ascii_close_page) Uses host_system var in place of
10142 HOST_SYSTEM constant.
10144 * cmdline.c: (var syntax_message[]) Broke into
10145 pre_syntax_message[] and post_syntax_message[].
10146 (usage) Outputs both parts, separated by driver list.
10148 * error.h: Fixed broken formatting.
10150 * expr-opt.c: (str_search, str_rsearch) New functions.
10152 * misc.c: (blp_getdelim) Removed. All references changed to
10154 (str_search, str_rsearch) Removed.
10155 (memrmem) New function.
10157 * misc.h: (blp_getline) Removed. All reference changed to
10160 * stat.h: New file.
10162 * filename.c: Includes "stat.h", not <sys/stat.h>.
10163 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10165 * output.c: (outp_list_classes) Changed output formatting.
10167 * sfm-write.c: (write_header) Uses host_system var instead of
10168 HOST_SYSTEM constant.
10169 (write_rec_7_34) Extracts version numbers from the version string.
10172 * sort.c: Includes "stat.h", not <sys/stat.h>.
10174 * str.c: (strcasecmp) Removed.
10176 * title.c: (cmd_document) Uses host_system var instead of
10177 HOST_SYSTEM constant.
10179 * version.c: Generated on-the-fly by the Makefile instead of being
10182 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10184 [!HAVE_STRNCASECMP] Declares strncasecmp().
10186 * version.h: Removed stray character. Comment fixes.
10187 (vars host_system, build_system) New vars.
10189 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10191 * Most source files: Changed formatting of copyright notice; fixed
10192 FSF address; reformatted to better conform to GNU standards;
10193 comment fixes. Added markups to prevent GNU indent from messing
10194 up my beautiful formatting :-).
10196 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10197 that GNU indent markups can be passed through without problems.
10199 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10201 * get.c: Turned off debugging.
10203 * glob.c: (init_glob) Turned on save-file compression by default.
10205 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10206 compression than was possible in save files.
10208 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10210 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10212 * frequencies.q: Removed Fiasco extensions. Updated calculation
10213 algorithms. Polished output format.
10214 (struct frq_info_struct) Removed members `max_degree', `min_n',
10215 all references removed.
10216 (macro frq_extensions) Removed.
10217 (static vars min_n, max_degree) Removed, all references removed.
10218 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10219 calculate `min_n', `max_degree'.
10220 (postcalc) Passes new arg to dump_statistics().
10221 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10223 (dump_condensed) Adds variable name title.
10224 (sum_freqs) Removed.
10225 (calc_stats) Updated calculation algorithm.
10226 (dump_statistics) Removed warning for too-few observations.
10227 Changed table formatting. Adds variable name title if passed new
10230 * output.h: Comment fix.
10232 * recode.c, sample.c, sort.c: Disabled debug code.
10234 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10235 Improved debug code.
10237 * var.h: (enum series frq_*) Removed Fiasco extensions.
10239 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10241 * command.c: Added PROCESS IF to command table.
10243 * Lots & lots of places, removed checks for NULLs preceding calls
10244 to free_expression(), which itself checks.
10246 * descript.q: Removed Fiasco extensions. Removed optimizations
10247 for non-weighted active files. Implemented some options.
10248 Finished polishing output format. Comment fixes. Merged
10250 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10251 max_degree, min_n) Removed.
10252 (macro dsc_extensions) Removed.
10253 (struct dsc_info_struct) Removed `min_n' member, all references
10255 (internal_cmd_descriptives) Removed calculation of min_n,
10256 max_degree. Only deals with one `calc' routine instead of two
10258 (precalc) Eliminated redundancy. Updated for changes to
10259 descriptives_proc structure.
10260 (calc) Moved here from `descript.g'. Rewritten to calculate
10261 statistics via `moments about the mean' rather than by summing,
10262 summing squares, summing cubes, and so on.
10263 (postcalc) Rewritten for new-style statistical calculation.
10264 (display) Removed support for displaying variables across rows.
10265 No longer crushes the descriptives table. Removed ancient code.
10266 Added display of N, by variable and listwise.
10268 * descript.g: Removed; merged into `descript.q'.
10270 * expr-evl.c: (evaluate_expression) Now returns a double. For
10271 numeric results, it returns the result as well as storing it in
10272 the passed `value' structure if non-NULL. For string results it
10273 just returns 0.0 and it must be passed non-NULL. Many references
10274 to this function were optimized by use of this change, especially
10275 but not exclusively in `compute.c'.
10277 * frequencies.g: Comment fix.
10279 * glob.c: (glob var process_if_expr) New global var.
10281 * postscript.c: (static var option_tab[]) Corrected entry for
10283 (postopen) Sets x->size to x->prop_size.
10284 (ps_text_set_font_by_name) Sets font size as well as typeface for
10285 PROP and FIXED fonts.
10287 * sel-if.c: (cmd_process_if) New function.
10289 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10290 (sfm_write_dictionary) Sets `n_cases' to 0.
10291 (sfm_write_case) Increments `n_cases'.
10292 (sfm_close) Attempts to seek the system file back to the header
10293 and write the number of cases in its proper slot.
10295 * som-frnt.c: (som_insert_table) Masks off expansion options since
10296 only SOPT_X_NORM seems to work sensibly.
10298 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10299 with a `fixed' value of 2.
10301 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10303 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10304 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10306 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10307 (struct descriptives_proc) Removed `miss_noweight'; new members
10308 `X_bar', `M2', `M3', `M4', `min', `max'.
10310 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10312 * vfm.c: (close_active_file) Cancels PROCESS IF.
10313 (write_case) Doesn't process cases unselected by PROCESS IF.
10315 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10317 * glob.c: (glob var err) Removed.
10319 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10320 doesn't have to take into account number of value labels since
10321 they're in a subtable anyway. Also, doesn't display more than 10
10322 value labels since we can't yet break pages in subtables.
10324 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10326 * som-frnt.c: (som_change_table_size) Simple change for elegance
10327 that shouldn't change behavior.
10328 (som_set_value) Comment fix.
10330 * som-high.c: (som_submit_table) Message fix.
10332 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10334 * command.c: Added SYSFILE INFO to command table.
10336 * file-handle.q: (fh_handle_filename) New function.
10338 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10341 * main.c: (parse) New return value for command functions, -3.
10343 * misc.h: Comment fix.
10345 * output.h: Comment fixes.
10346 (macro COMPONENTS) Removed.
10348 * postscript.c: (write_text) Modified literal_chars[] so that `('
10349 and ')' are not written to the output in strings as literals.
10351 * sfm-read.c: (sfm_read_dictionary) New argument.
10352 (read_header) New argument. Sets the information structure's
10353 values from the header information.
10354 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10355 bizarre Checker problem, I guess.
10356 (read_variables) Proper cleanup on lossage.
10358 * sfm.h: (struct sfm_read_info) New struct for use by
10359 sfm_read_dictionary().
10361 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10362 currently used just for tables that can be dynamically resized and
10363 thus have to be allocated with arena_malloc() instead of
10364 arena_alloc(). All references changed.
10365 (som_change_table_size) New function.
10366 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10368 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10369 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10372 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10374 (draw_intersection) Now takes an argument specifying the table in
10375 question. All references changed.
10376 (draw_table_cell) New function.
10377 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10378 (som_get_table_size) Many nice new explanatory comments.
10379 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10381 * som.h: New enum series SOM_CREATE_* for use as create flags with
10382 som_create_table().
10384 * str.h: Moved a comment here from TODO.
10386 * sysfile-info.c: New file. Reference implementation.
10388 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10390 * command.c: Added RENAME VARIABLES to table of commands.
10392 * data-in.c: (dls_error) Sets `cust_field'.
10393 (parse_N) Message fix.
10394 (parse_day_count) New function.
10395 (to_roman) Never outputs VX as a `short form' of V.
10396 (parse_month) Fixed parsing of Roman numerals.
10397 (parse_trailer) Message fix.
10398 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10399 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10400 the date is invalid.
10401 (parse_SDATE) Fixed swapped day, year.
10402 (parse_JDATE) Fixed bug for dates in 1582.
10403 (parse_DTIME) Allows days not between 1 and 31.
10404 (parse_numeric) Makes local copy of f.type for easier usage.
10407 * data-out.c: (convert_F) When outputting as scientific, properly
10408 sets f.type as fp->type.
10409 (insert_commas) Fixed operator precedence problem with setting of
10410 nitems. Changed strcpy to memcpy (no null terminator).
10411 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10412 (convert_CCx) Essentially rewritten, but now it works.
10414 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10415 feature of Fiasco).
10416 (display_documents) Implemented.
10418 * error.c: (glob var cust_field) New var.
10419 (vmsg) Displays cust_field as part of message classes DE and DW.
10421 * formats.c: (debug_print) Fixed to compile under updated
10424 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10427 * misc.c: (parse_format_specifier) Formatting fix.
10429 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10430 `n_rename' for clarity.
10431 (cmd_modify_vars) Initializes `forward' and `positional' at
10432 appropriate times. Frees lists of vars to rename on failure.
10433 Comment fix. Frees memory on success.
10434 (rearrange_dict) Simplified `for' loop condition.
10436 * rename-vars.c: New file (reference implementation).
10438 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10440 * sfm-read.c: (read_header) File label is created only if file
10441 label in file is not blank.
10442 (read_variables) Initializes `dict' local variable.
10443 (read_documents) Proper behavior on lossage.
10445 * sfm-write.c: (write_header) Doesn't blank out the file label
10446 (why was this here to begin with?!)
10448 * temporary.c: (save_dictionary) File label is copied only if
10449 non-NULL. Doesn't try to xstrdup() dictionary documents.
10450 Adapted so as to not irritate Checker.
10451 (free_dictionary) Only destroys var_by_name if non-NULL.
10453 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10454 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10455 lines to the document, indents the document. Also, it works now.
10456 (add_document_line) New function.
10458 * var.h: (struct dictionary) Reordering.
10460 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10461 bits if it was allocated to begin with.
10463 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10465 * command.c: Added MODIFY VARS to list of commands.
10467 * configure.in: Updated custom macros for autoconf 2.12. Removed
10468 mmap reference; fixed termcap library reference.
10470 * display.c: (display_variables) Fixed a few bugs although it's
10471 still not well written.
10473 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10474 (induce_segfault) Calls chkr_disp_call_chain() instead of
10475 inducing an actual SIGSEGV.
10477 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10478 str_search() and str_rsearch(). Fixed tests for matches on
10479 OP_INDEX and OP_RINDEX.
10481 * filename.c: (good_getcwd) Removed as the new libc for Checker
10482 doesn't contain this bug, apparently.
10484 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10485 consistency with GNU memmem.
10486 (blp_getdelim) Changed `len' from `int' to `size_t'.
10488 * modify-vars.c: Reference implementation.
10490 * som-frnt.c: (zero_length) New global var.
10491 (som_create_table) Message fix.
10493 * som.h: Added gcc attributions to som_set_text(),
10494 som_output_text() prototypes. blank_line() refers to
10495 zero_length[] instead of a literal null string to suppress gcc
10498 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10499 (allocate_cases) Decrements x_max so the last element of x[] can
10500 be used by the algorithm.
10502 * var.h: Changed minor details of `variable' declaration.
10503 (struct modify_vars_proc) New struct.
10504 (struct variable) Added field p.mfv.
10506 * vars-atr.c: Comment fix.
10508 * vars-prs.c: (fill_all_vars) More optimal implementation.
10510 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10511 character, which it shouldn't have to do but printf() seems to
10512 read the null byte even though I supply a maximum length...
10514 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10516 * command.c: Removed command alias X for QUIT.
10517 (parse_cmd) Fixed comment parsing.
10519 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10521 (read_record) Fixed references to len, size.
10522 (dfm_get_record) Restructured.
10524 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10527 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10530 * modify-vars.c: New file. Not complete.
10532 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10535 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10536 problems caused by int/size_t differences.
10538 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10541 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10542 being compared were of equal length.
10544 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10546 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10548 * lexer.c: (get_dotted_rest_of_line) New function.
10550 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10553 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10554 type 6 records. Frees the dictionary properly.
10555 (read_header) Initializes the dictionary instead of letting
10556 read_variables() do it. Sets the dictionary file label from the
10558 (read_documents) New function.
10560 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10561 write type 6 record if appropriate.
10562 (write_header) Writes file label from dictionary.
10563 (write_documents) New function.
10565 * temporary.c: (save_dictionary, restore_dictionary,
10566 free_dictionary) Properly handle new fields in dictionary struct.
10568 * title.c: (get_title) Returns after failure().
10569 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10570 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10572 * var.h: (struct dictionary) New fields `label', `n_documents',
10575 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10577 * command.c: Added FILTER to list of commands.
10579 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10582 * get.c: (cmd_save_internal) Removed weighting code since it's now
10583 handled by sfm-write.c. Properly commented out debug code.
10585 * glob.c: (glob var weighting) Removed.
10587 * sel-if.c: Comment fixes.
10588 (cmd_filter) New function.
10590 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10591 (sfm_read_dictionary) Sets weighting variable direct in the
10592 created dictionary now. (Apparently we previously didn't support
10594 (read_header) Sets weight_index field in sfm_fhuser_ext from
10595 header read from disk.
10597 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10598 (write_header) Now sets the weighting in the header from the
10599 passed primary dictionary instead of from the sfm_write_info.
10601 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10603 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10604 broke on boundary conditions.
10606 * var.h: (struct dictionary) New fields `weight_var',
10607 `weight_index', and `filter_var'.
10608 (glob var weighting) Removed. This is now part of struct
10609 dictionary. All references changed; the less mechanical changes
10610 are described above.
10612 * vars-atr.c: (find_dict_variable) New function.
10614 * vfm.c: (static var filter_index) New variable.
10615 (open_active_file) Initializes filter_index from default_dict.
10616 (write_case) Calls proc_func() only if the filter variable is
10617 nonzero; this implements FILTER behavior.
10619 * weight.c: (static var weight_varname) Removed.
10620 (cmd_weight) Modified default_dict instead of glob vars.
10621 (update_weighting) Changed the signature to modify a dictionary
10622 instead of glob vars. Now returns the weighting variable.
10623 (get_weighting_variable) Removed; its function is absorbed by
10624 update_weighting().
10625 (stop_weighting) Operates on a dictionary now.
10627 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10629 * sort.c: Removed debugging info from messages.
10630 (do_external_sort) Cleans up after itself by deleting the
10631 temporary directory on failure. (On success it is deleted by the
10633 (allocate_cases) Removed debug code. Added clean up code.
10634 (output_record) Removed debug code.
10635 (merge) Added code to close all the input files that are currently
10636 open. This is a likely location for bugs, because I'm not sure
10637 about boundary conditions. Removed an unnecesary heap_delete().
10638 (merge_once) Removed input file "optimization" that in fact
10639 screwed up the rest of the code. Message and comment fixes.
10641 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10643 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10645 * heap.c: (heap_delete) New argument.
10647 * sort.c: Finished implementation of external sort.
10649 * vfm.c: (read_from_disk) Returns after a disk error.
10651 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10653 * sort.c: (static var state) Removed.
10654 (static vars max_handles, tmp_basename, tmp_extname,
10655 huffman_queue) New variables.
10656 (do_external_sort) Moved most code to new functions.
10657 Creates huffman_queue.
10658 (allocate_file_handles, allocate_cases) New functions.
10659 (static vars run_no, run_length, file_index, case_count) New
10661 (output_record) Returns success. Now really writes to the output
10663 (begin_run, end_run) New functions.
10664 (write_initial_runs) Returns success. Initializes run_no to -1.
10665 Calls begin_run(), end_run() at appropriate times. Outputs debug
10667 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10669 (merge) New function.
10671 * heap.c, heap.h: New files. Hopefully in near-final form.
10673 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10675 * glob.c: Added write_active_file to global vars.
10677 * sort.c: Several new miscellaneous static variables.
10678 (cmd_sort_cases) Big comment fix.
10679 (perform_case_2) Renamed `do_external_sort' and completely
10681 (case_2_proc_func) Removed.
10682 (output_record, write_initial_runs, write_to_sort_cases,
10683 compare_record) New functions.
10685 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10687 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10689 * sort.c: (perform_case_2) Changed the method for allocation of
10690 lots of memory--now allocates one case at a time in hopes that
10691 more cases can be allocated with heavily fragmented memory.
10693 * var.h: (write_active_file) New global var.
10695 * vfm.c: (procedure, close_active_file, write_case,
10696 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10697 arguments to procedure() to be NULL. All references to
10698 procedure() that made use of dummy functions were changed to NULL
10700 (open_active_file) If write_active_file is non-NULL, the output
10701 device becomes DEV_PGM (a new enum).
10702 (close_active_file) Sets write_active_file to NULL.
10703 (read_from_memory) Comment fix.
10704 (record_case) Calls write_active_file() when the output device is
10707 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10709 * sort.c: New file.
10711 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10712 Fixed checking for duplicate varnames.
10713 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10715 (autorecode_trns_free) Destroys hash tables for each recoding
10717 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10719 * command.c: Added SORT CASES to cmd_table.
10720 (null_func, null_int_func) Prototyped.
10722 * descript.g: (calc_weight, calc_noweight) Computes own case
10725 * frequencies.q: (dump_statistics) Fixed problem with
10726 too-few-cases warning message.
10728 * get.c: (cmd_save_internal) Handles weighting properly.
10730 * hash.c: (hsh_dump) Output format changed.
10731 (force_hsh_insert) Actually works now, prototype changed.
10733 * list.q: (static var case_num) New variable.
10734 (cmd_list) Initializes case_num.
10735 (list_cases) Increments case_num.
10737 * var.h: Added definitions for SORT CASES. Comment fixes.
10739 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10740 fixes. `active' renamed vfm_active, `rep' renamed
10741 vfm_replacement, all references changed.
10742 (procedure) The procfunc no longer receives a case number. All
10743 references changed.
10744 (write_case) Subtle reordering.
10745 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10748 * weight.c: (get_weighting_variable) New function.
10750 * vfmP.h: New file with definitions from vfm.c.
10752 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10754 * command.c: (FILE_TYPE_okay) Commented out some tests because
10755 they're clumsy and not yet needed.
10757 * var.h: Most *_trns structures moved to their respective source
10758 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10759 (union any_trns) Changed to a typedef for trns_header.
10760 (struct input_program_pgm) Removed.
10762 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10763 was allocated in the first place.
10765 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10767 * autorecode.c: New file.
10769 * command.c: Added AUTORECODE to command table; re-enabled SET.
10771 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10773 * error.c: (vmsg) Comment fixes.
10775 * hash.c: Comment fix.
10776 (hashpjw_d) New function.
10777 (hashpjw) Reimplemented as call to more general function
10779 (internal_comparison_fn) Initializes pointers properly.
10780 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10781 (force_hsh_insert, force_hsh_find) New debugging wrapper
10784 * main.c: (main) Message fix.
10786 * output.c: (outp_read_devices) Message fix.
10788 * set.q: Comment fixes.
10789 (custom_results) Implemented Wnd/X form of subcommand.
10790 (set_routing) New function.
10791 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10793 * settings.h: (SET_ROUTE_*) New enum series.
10794 (set_results) Renamed set_results_file, all references changed.
10795 (set_messages) Removed.
10796 (glob vars set_errors, set_messages, set_results) New vars.
10798 * title.c: (get_title) Remembers to xstrdup() the result of
10799 get_rest_of_line().
10801 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10803 (union any_trns) New element `arc'.
10805 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10807 * command.c: (output_line) Removed references to set_screen.
10809 * error.c: (static var terminating) New var.
10810 (hcf) Sets terminating to 1.
10811 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10812 This prevents an infinite loop if an error occurs within hcf().
10814 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10815 statement circumlocution with `case 42000' trick.
10816 (evaluate_expression) New support for OP_STR_MIS.
10818 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10819 statement circumlocution with `case 42000' trick.
10820 (dump_node) Handles OP_STR_MIS.
10822 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10823 variables exceptions.
10824 (parse_function) Message fix.
10825 (ops[]) Added OP_STR_MIS.
10827 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10829 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10831 * glob.c: Removed set_scrnfile glob var.
10832 (init_glob) set_errorbreak set to 0 by default.
10834 * groff-font.c: Changed included files.
10835 (groff_read_font) Initializes font_arena local var correctly.
10836 (default_font) New function.
10838 * output.c: Comment fixes.
10839 (glob var disabled_devices) New variable.
10840 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10842 [GLOBAL_DEBUGGING] (reentrancy) New function.
10843 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10844 outp_iterate_enabled_drivers) Calls to reentrancy().
10845 (destroy_list) New function.
10846 (outp_done) Moved code to destroy_list().
10847 (parse_options) Parses `listing', `screen', `printer' options
10849 (configure_driver) Sets new `device' member of driver.
10850 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10852 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10853 (struct outp_driver_struct) New member `device'.
10855 * postscript.c: (find_encoding_file) Doesn't display its own error
10857 (default_encoding) New function.
10858 (switch_font) Calls default_encoding() if no encoding can be
10860 (text) Makes up a character metric if none exists for the desired
10862 (load_font) Properly copies a fallback filename. Calls
10863 default_font() for a font if none at all are known.
10865 * set.q: Comment fixes. Removed OUTPUT subcommand.
10866 (custom_listing) Calls outp_enable_device() to enable/disable
10868 (turn_screen_on) Removed.
10869 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10870 screen, printer devices.
10872 * settings.h: Comment fixes.
10873 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10876 * som-high.c: (som_submit_table, som_eject_page) Use
10877 outp_iterate_enabled_drivers() instead of iterating
10878 outp_driver_list directly.
10880 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10882 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10883 (parse_string_as_format) Handles new formats.
10884 (parse_numeric) Now handles DOT and PCT formats.
10886 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10888 (convert_date) Handle EDATE and SDATE formats.
10889 (convert_CCx) Now if there's not room for the currency characters,
10890 converts it as F format if it's positive instead of giving up
10891 quickly. Also fixed save-and-restore bug with decimal point
10893 (convert_format_to_string) Handles new formats.
10895 * misc.c: (formats[]) Added new formats.
10896 (convert_fmt_ItoO) Supports new formats.
10898 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10899 data checking. New argument, all references changed.
10901 * sfm-write.c: (write_format_spec) Supports new formats.
10903 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10906 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10908 * cmdline.c: Comment fixes.
10909 (parse_command_line) Changed return type to void.
10911 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10913 (parse_numeric) Handles international numbers (comma as decimal
10914 point). Some reformatting.
10916 * data-list.c: (parse_free) Default output format is now
10917 set_format instead of hard-coded F8.2.
10918 (read_from_data_list_list) Emits error message on undefined data
10919 only if set_undefined is nonzero.
10921 * data-out.c: (convert_E) Changes decimal point from period to
10922 comma if appropriate. Restructured. Better comments.
10923 (convert_F) Changes decimal point from period to comma if
10925 (insert_commas) Major bug with handling of negative values fixed.
10926 Also, inserts periods instead of commas if appropriate.
10927 (convert_CCx) New function.
10928 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10929 (num_to_string) Changed `.' to set_decimal.
10931 * dfm.c: Comment fixes.
10932 (dfm_close) Frees ext->line even in inline_file.
10933 (open_inline_file) New function.
10934 (open_file_r) When opening the inline file: now properly
10935 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10937 (read_record) Calls fh_close_handle() instead of dfm_close() to
10938 close the inline file. Makes a copy of the line getl_buf to avoid
10939 interlock problems.
10940 (dfm_get_record) Restructured. Now checks the return value of
10942 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10943 checking for use of inline file. No longer tries to close inline
10946 * error.c: (glob var error_already_flagged) New var.
10947 (vmsg) Message change. Now checks max number of errors/warnings,
10950 * file-handle.q: (fh_handle_name) Now allows closing of
10952 (fh_init_files) Reformatted.
10954 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10956 * getline.c: (getl_include) Fixed bug that popped up when called
10957 when file queue was empty.
10958 (read_console) Resets error_count, warning_count,
10959 error_already_flagged to zero.
10961 * glob.c: Many changes to update list of variables.
10962 (init_compat_dependent) Now this function is called whenever
10963 `compat' changes. It now sets set_seed only if it hasn't
10964 previously been referenced. It now calls
10965 lex_init_compat_dependent().
10967 * include.c: (cmd_include_at) Frees temporary buffer instead of
10969 (cmd_include) Doesn't make copy of include file name.
10971 * lexer.c: Comment fixes.
10972 (init_lex) Moved some code into new function
10973 lex_init_compat_dependent().
10974 (lex_init_compat_dependent) New function.
10975 (hex_val) Simplified.
10976 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10978 * main.c: Comment fixes.
10979 (main) Reformatted.
10981 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10982 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10983 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10984 (setup_randomize) Sets set_seed_used.
10986 * set.q: Comment fixes.
10987 (custom_results) Conditionalizes on `compat'.
10988 (custom_log) Calls custom_journal().
10989 (set_ccx) New function.
10990 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10991 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10992 when set_decimal changes. Range-checks values for MITERATE,
10993 MNEST. Message fixes.
10995 * settings.h: Comment fixes.
10996 (struct set_cust_currency) New struct.
10997 (set_cc[], set_grouping, set_seed_used) New global vars.
10999 * var.h: (FMT_CCA...FMT_CCE) New output formats.
11000 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
11002 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
11004 * glob.c: Revised variables to correspond to settings.h.
11005 (init_glob) Initializes variables from settings.h properly.
11007 * set.q: Began long-overdue major revision to correspond to new
11008 philosophy. Most code changed.
11010 * settings.h: Mostly changed; reorganized, reordered, large new
11013 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
11015 * get.c: (cmd_save_internal) No longer forces compression off.
11017 * sfm-read.c: (read_compressed_data) If eof is reached when
11018 reading a new instruction octet, only signal error if we're in the
11021 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11022 (struct sfm_fhuser_ext) New member `end'.
11023 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11024 (ensure_buf_space) New function.
11025 (sfm_write_case) Reimplemented in order to support compression.
11026 (sfm_close) Writes out the remaining contents of the compression
11029 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11031 * command.c: Defined SAVE and XSAVE commands in command table.
11033 * common.h: second_lowest_value is of type flt64, not double.
11035 * file-handle.h: Comment fix.
11037 * get.c: Comment fixes.
11038 (static var `trns') New.
11039 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11040 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11041 (dict_delete_run) Clears the variables and frees them now.
11042 (trim_dictionary) Sets default for compression.
11043 On KEEP subcommand, frees deleted variables as well as clearing
11044 them. Finally got the sense of the test for deleting all
11046 [DEBUGGING] (dump_dict_variables) Message fix.
11048 * glob.c: (init_glob) set_compression set to 1 by default.
11050 * list.q: Properly #includes config.h.
11052 * misc.h: New macro REM_RND_UP.
11054 * settings.h: Comment fix.
11056 * sfm-read.c: (structs sysfile_header, sysfile_format,
11057 sysfile_variable; inline function bswap_int32) Moved to new file
11059 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11060 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11062 (read_machine_flt64_info) Fixed some problems caused by confusion
11063 between flt64 and double types.
11064 (read_header) Message fix.
11065 (read_variables) Fixed set of cases in which we byte-swap sv.print
11066 and sv.write. Fixed confusion of flt64 and double.
11068 * sfm.h: (struct sfm_write_info) New.
11070 * som-high.c: (som_draw_title) Properly frees `s'.
11072 * temporary.c: (save_dictionary) Comment fix.
11074 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11075 (struct trns_header) Formatting fix.
11076 (struct save_trns) New.
11078 * vars-atr.c: (discard_variables) Comment fix.
11080 * sfm-write.c: New file, baseline release.
11082 * sfmP.h: New file, baseline release.
11084 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11086 * cmdline.c: (parse_command_line) `--version' output updated.
11087 (glob var syntax_message[]) Added my e-mail address.
11089 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11090 `illegal' to `invalid'.
11092 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11093 uncompression buffer.
11094 (sfm_close) Frees decompression buffer.
11095 (sfm_read_dictionary) Initializes decompression buffer.
11096 (buffer_input, read_compressed_data) New functions.
11097 (sfm_read_case) Restructured; now calls read_compressed_data() to
11098 handle compressed system file data.
11100 * var.h: Comment fix.
11102 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11104 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11107 * get.c: New comments. New static var `get_file'.
11108 (cmd_get) Now fully implemented. Calls discard_variables();
11109 initializes fv and lv for all variables; new debug code; sets
11110 up the dictionary; sets up the input program.
11111 (read_from_get, cancel_get) New functions.
11113 * sfm-read.c: Comment fixes.
11114 (sfm_close) New static function.
11115 (sfm_read_dictionary) Properly sets up the class of the
11116 file_handle. No longer cares what size the data is in records of
11117 type 7. Also, on failure, properly cleans up the file_handle and
11118 free()s some stuff.
11119 (read_variables) No longer thinks it knows `nval' of the
11120 dictionary. Now sets p.get.fv, etc., instead of speculatively
11122 (read_value_labels) Fixed off-by-one error in indexing of
11124 (sfm_read_case) New function.
11125 (sfm_r_class) New static var.
11127 * var.h: (get_proc) New struct.
11128 (struct variable) New member p.get.
11130 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11132 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11133 the manual's meaning.
11134 (rename_variables) New function.
11135 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11136 code. Now properly reorders the dictionary on the KEEP keyword.
11138 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11139 garbage collection.
11141 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11142 (rename_variable) New function.
11143 (free_val_lab) Reformatted.
11145 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11147 * var.h: Reindented entire file. Comment fixes.
11148 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11150 (glob var default_dict) New.
11151 (struct indirect_dictionary) Removed.
11153 * Many other source files were changed to add `default_dict.'
11154 before all references to the dictionary of the active file.
11156 * vars-atr.c: (make_indirect_dictionary) Removed.
11158 * glob.c: Reindented all variable declarations. Updated for
11159 changed var.h. Comment fixes.
11161 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11162 because now we can mainly copy dictionary structs.
11164 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11165 parse_variables) Takes dictionary instead of indirect_dictionary
11167 (parse_variables) Instead of calling make_indirect_dictionary,
11168 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11169 of `*dict.' references had to be changed to `dict->'. Removed
11172 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11174 * get.c: Added GTSV_OPT_* series of enums.
11175 (trim_dictionary, dict_delete_run) New functions.
11176 [DEBUGGING] (dump_dict_variables) New function.
11177 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11178 [DEBUGGING] Calls dump_dict_variables() to display results.
11180 * glob.c: (cmp_variable) Now a public function declared in var.h.
11182 * sfm-read.c: Turned off debug code. Comment fixes.
11183 (read_machine_int32_info, read_machine_flt64_info) New functions
11184 to parse type 7 records.
11185 (sfm_read_dictionary) Properly byteswaps several fields now.
11186 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11187 records. [DEBUGGING] Dumps dictionary.
11188 (read_variables) Sets `index' field of variables created properly.
11189 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11190 longer dumps dictionary.
11191 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11193 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11195 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11196 var before destroying any variables just to save a little time.
11198 * var.h: (struct variable) Reordered in order to make name[] the
11199 first member; this makes pointers to `variable' pointers to the
11200 variable name, simplifying avl trees, etc.
11201 (struct indirect_dictionary) New struct.
11203 * vars-atr.c: (find_variable) Rewritten for efficiency.
11204 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11206 (is_varname) Rewritten for efficiency.
11207 (parse_variables) New argument, which is a `dictionary *'. All
11208 references changed. This function now reads variable names from
11209 the dictionary passed, or from the default dictionary if NULL.
11211 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11213 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11214 rounding up. Changed many references to ROUND_UP to use this
11217 * sfm-read.c: Includes avl.h.
11218 (corrupt_msg) Induces a segfault under Checker.
11219 (macro assertive_bufread) New. Many references to bufread() now
11221 (sfm_read_dictionary) Split up into several functions. Added code
11222 to read dictionary records following the the type 2 records. Not
11223 quite complete. New variable `var_by_index'.
11224 (read_header, read_variables) New functions extracted from
11225 sfm_read_dictionary().
11226 (read_value_labels) New function.
11227 (bufread) Checks ferror() if fread() doesn't return the expected
11228 value; if ferror() is zero it's just EOF.
11229 (dump_dictionary) Stubbed out.
11231 * BTW: The source code now exceeds 50000 lines!
11233 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11235 * command.c: Added GET to cmd_table[].
11237 * list.q: Removed reference to alloca headers.
11238 (cmd_list) Gave prototype.
11240 * sfm-read.c: Added DEBUGGING comments.
11241 (sfm_read_dictionary) Checks bias correctly. Sets
11242 dict->var_by_name to NULL. Calculates long_string_count
11243 correctly. realloc's dict->var[] array to minimum size.
11244 [DEBUGGING] Calls dump_dictionary.
11245 [DEBUGGING] (dump_dictionary) New function.
11247 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11248 (restore_dictionary) If the dictionary contains a non-NULL
11249 var_by_name, uses that instead of generating one.
11250 (free_dictionary) Destroys var_by_name.
11252 * var.h: (struct dictionary) Added field `var_by_name'.
11254 * get.c: New file, not complete.
11256 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11258 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11259 (parse_num_or_range) New function.
11260 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11261 <n> THRU HIGH missing values.
11263 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11264 __attribute__((const)).
11266 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11268 * sfm-read.c: Finished reference implementation.
11270 * sfm.h: Includes var.h.
11272 * var.h: Comment fixes.
11273 (struct `variable') Reordered some fields.
11275 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11276 constants added previously.
11278 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11280 * common.h: Comment fixes. Added declaration of
11281 `second_lowest_value' as variable or macro. Made `compat_type',
11282 `pgm_state_type' into anonymous enums.
11284 * display.c: Comment fix.
11286 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11288 [!defined SECOND_LOWEST_VALUE] Added definition for
11289 `second_lowest_value' global var.
11290 (compat, pgm_state global vars) Changed types to `int'.
11291 (init_glob) Initializes `second_lowest_value'.
11293 * sfm-read.c: Continued work, not complete.
11295 * var.h: Added new MISSING_* constants to handle LOWEST and
11298 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11300 * sfm-read.c: New file, not complete.
11302 * cases.c: (vec_insert) Changed vector expansion algorithm.
11303 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11304 mucking up the RECODE transformation in particular.
11305 (envector) Harmless change in notation.
11307 dfm is now fairly well tested again.
11308 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11310 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11312 * recode.c: Comment fix.
11314 * sfm.h: Interface should be fairly final now, or at least for a
11317 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11318 (open_active_file) [DEBUGGING] Translates ccase indices into
11319 variable names now to make it easier to understand what's really
11322 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11324 * data-in.c: Comment fix.
11326 * data-list.c: Includes dfm.h.
11327 (do_reading) Uses new function dfm_push_cust().
11329 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11330 `return 1;' at end.
11332 * file-handle.h: Completely changed. Some parts split off into
11333 new file dfm.h. Implemented in file-handle.q.
11334 (enum FH_*) Removed.
11335 (struct fh_ext_class) New struct.
11336 (struct file_handle) Retained only these fields: name, norm_fn,
11337 fn, recform, lrecl, mode. New fields class, ext.
11338 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11339 close_handle, handle_name) Added `fh_' prefix to name, all
11340 references changed.
11342 * dfm.h: New file, implemented in dfm.c.
11343 (get_record, put_record, fwd_record, bkwd_record, set_record,
11344 get_cur_col) Functions moved from file-handle.h, now prefixed with
11346 (dfm_push_cust) New function.
11348 * sfm.h: New file. Incomplete.
11350 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11351 interface. Functions reordered, comments changed. Not well
11352 tested, probably full of bugs.
11353 (struct dfm_fhuser_ext) New struct.
11354 (dfm_close) New function.
11355 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11356 (open_file_w) User messages changed.
11357 (get_record) Comment fixed.
11358 (read_record) Increments ext->ln even for inline_file. Calls
11359 dfm_close() for inline_file when `END DATA.' encountered.
11360 (dfm_get_record) Experimental restructuring.
11361 (dfm_push_cust) New function.
11362 (cmd_begin_data) Detects whether the inline file was fully read by
11363 checking whether it is still open; detects whether it was read at
11364 all by checking whether the line number is greater than zero.
11366 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11367 interface. Functions reordered, comments changed. Not well
11368 tested, probably full of bugs.
11369 (init_file_handle) Removed initializers for obsolete fields, added
11371 (fh_close_handle) Much simpler, now mainly calls the class
11373 (fh_init_files) Renamed inline file internal filename.
11375 * file-type.c: Includes dfm.h.
11376 (read_from_file_type) Doesn't use dfm internal state anymore.
11378 * inpt-pgm.c, print.c: Include dfm.h.
11380 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11381 int in comparison with other int.
11383 * som-high.c: (build_target) Fixed operator precedence problem in
11384 if statement (& versus ==).
11386 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11388 * dfm.c: (read_record) Can now read fixed-length records; not
11390 (put_record) Can now write fixed-length records; not tested.
11392 * file-handle.h: FH_* defines changed to enums. New enum series
11394 (struct file_handle) New members recform, lrecl, mode.
11396 * file-handle.q: Parser changed.
11397 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11398 /LRECL subcommands. These are compatible with Windows.
11399 (init_file_handle) Initializes recform, mode fields.
11401 * q2c.c: (get_line) When outputting `!' comment lines, now
11402 increments the output file line number so that `#line' directives
11404 (make_identifier) New function that converts an arbitrary string
11405 into a valid C identifier.
11406 (dump_vars) Calls make_identifier() in two places in order to
11407 suppress some errors for bad identifiers.
11408 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11409 for NO. Allows numbers to be prefixed by underscores to make them
11410 acceptable C identifiers but still to be parsed as numbers by the
11413 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11415 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11417 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11418 was opened for writing.
11419 (open_file_w) New function.
11420 (read_record) Uses strncasecmp if available. Improved error
11421 messages, comments.
11422 (put_record) New function.
11424 * file-handle.h: Moved function comments into dfm.c and
11425 file-handle.q. Comment fixes. Removed declarations of
11426 tilde_expand() and normalize_filename().
11427 (struct file_handle) Changed `open' from boolean to enumerated
11428 field to allow for three states--closed, open for reading, open
11429 for writing--all references changed.
11431 * file-handle.q: Includes filename.h.
11433 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11434 references changed.
11435 (alloc_line) Makes allowance for line terminator characters in
11437 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11438 (print_space_trns_proc) Handles OUTFILE differences.
11440 * recode.c, sample.c: Comment fixes.
11442 * var.h: (struct print_trns) Changed boolean field `eject' to
11443 bitmapped field `options'; all references changed. New enums
11444 PRT_* for use with this field.
11446 * exception.h, test-exception.c: Removed.
11448 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11450 * ascii.c: (delineate) Turned off debug output.
11452 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11455 * data-in.c: (parse_string_as_format) Sets the entire string value
11456 to spaces, not just the short string part of it. Is this correct
11459 * data-out.c: (convert_date) Fixed DATETIME format problems with
11460 decimal places, removed debug code.
11462 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11463 middle of parsing BEGIN DATA that would cause the lexer to read
11464 from a wild pointer `prog'; now calls new function
11465 preprocess_line() in lexer.c.
11467 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11469 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11470 Now call induce_segfault() to induce the segfault.
11471 (induce_segfault) New function.
11473 * expr-opt.c: Comment fix.
11474 (parse_sysvar) New function.
11475 (parse_primary) Added system variable support--calls
11477 (global var ops) Added OP_CASENUM operator.
11479 * expr.h: Comment fixes.
11480 (OP_* enum) added OP_CASENUM operator.
11481 (struct casenum_node) New struct.
11482 (union any_union_union) New member `cas' of type `casenum_node'.
11484 * glob.c: (global var last_vfm_invocation) New var.
11485 (init_glob) Initializes last_vfm_invocation.
11487 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11489 * getline.c: (get_line) Split into get_line() and preprocess_line().
11490 (preprocess_line) New function.
11492 * var.h: Declares last_vfm_invocation.
11494 * vfm.c: (procedure) Sets last_vfm_invocation.
11496 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11498 * command.c: (parse_cmd) Fixed bad assertion related to
11501 * data-in.c: (parse_month) Implemented to parse months according
11502 to full interpretation of standard.
11503 (to_roman) New function.
11504 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11505 (parse_weekday) Bug fix (forgot to skip all the day name).
11507 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11508 up parsing of multirecord data items. Also fixed user message.
11510 * data-out.c: Comment fix.
11511 (year2, year4, convert_date, convert_time, convert_WKDAY,
11512 convert_MONTH) New functions to support time & date output.
11513 (convert_format_to_string) Calls new time & date output routines.
11515 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11517 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11520 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11522 * misc.c: (global var formats) Fixed declarations of DATETIME,
11525 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11526 the output_char buffer.
11528 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11529 memory bug. Fixed user messages.
11531 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11533 * Removed #pragma argsused from lots of places.
11535 * data-in.c: Implemented zoned decimal and time-date formats.
11536 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11539 * data-out.c: Implemented zoned decimal format.
11541 * expr.h: Moved yrmoda() declaration here from exprP.h.
11543 * misc.c: (global var formats) Minor fixes--added
11544 FCAT_SHIFT_DECIMAL to formats N and Z.
11545 (convert_fmt_ItoO) Added support for format Z.
11547 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11549 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11551 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11552 som_check_workspace() that is activated between commands.
11554 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11557 * list.q: (begin_row) Changed title expansion style from
11558 SOPT_X_VERT to SOPT_X_SHSP.
11560 * som-frnt.c: Now includes `somP.h'.
11561 (som_push_workspace, som_pop_workspace) New functions that, taken
11562 together, form a solution to the recursive table building problem
11563 mentioned yesterday. Surrounded every table output routine
11564 throughout the program with calls to these functions.
11565 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11566 (som_create_table) Checks that there's an active workspace.
11567 (som_destroy_all_tables, som_crush) Removed.
11569 * som-high.c: (global var som_preserve_tables) Removed, all
11570 references deleted.
11571 (som_submit_table) Checks that there's an active workspace.
11572 (dump_columnated_table) Doesn't columnate tables that would have
11573 just one row per column.
11574 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11575 (som_dump_crush_page) Moved row number labels from left side of
11576 tables to right side.
11577 (som_get_table_size) Added support for SOPT_X_SHSP.
11579 * som.h: New cell expansion type SOPT_X_SHSP.
11581 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11583 (global var curtab_arena) Moved from som-frnt.c.
11585 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11587 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11588 that causes bad location warnings to be suppressed.
11589 (delineate) Saves current font when calling draw_text(); fixed
11590 handling of NULLs when backing up. Also fixed line-wrapping bug.
11592 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11593 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11595 * common.c: Added code to cause assertion failure to dump core
11596 when run under Checker.
11598 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11599 there are still bugs.
11601 * glob.c: (__eprintf) Removed.
11603 * list.q: Inserted som_preserve_tables kluge that prevents tables
11604 from being thrown away due to recursive table building through
11605 som_output_line being called from a transformation during the LIST
11606 procedure invocation. This is a general problem that must be
11607 solved in a better way since it applies to all procedures in
11609 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11610 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11612 * numeric.c: Fixed several errors in the form of msg() calls.
11614 * print.c: Updated for use of som.
11615 (dump_table) Reimplemented.
11616 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11617 Calls som_output_text() instead of outs_line().
11619 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11621 (som_output_text) Function moved from som-low.c. Interface
11624 * som-high.c: (som_preserve_tables) New global public variable
11626 (som_submit_table) Destroys the tables only if som_preserve_tables
11628 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11629 one subrow per row. Now labels subrows if there's more than one
11631 (dump_crush_table) Added wishlist comment.
11632 (som_eject_page) New public function declared in som.h.
11634 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11635 more than one subrow per row.
11636 (som_output_text) Moved to som-frnt.c.
11638 * som.h: (SOM_TOPT_PRESERVE) Removed.
11640 * title.c: (get_title) Changed interface.
11641 (cmd_title) Changed `title' to `outp_title'.
11642 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11644 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11646 * list.q: (flush_table) Conforms to new partial options in
11647 som_submission_form.
11649 * som-high.c: (paginate_horizontally) Changed form of subrow
11651 (build_target) Omits spacing before table if
11652 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11653 (dump_crush_page) Changed interface. Only trims bottom rule if
11654 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11655 (dump_crush_table) Handles partial tables.
11656 (output_row_label) New function.
11657 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11658 rule on the right edge of narrow subrows.
11660 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11661 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11662 All references updated.
11664 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11666 * misc.c: Comment fix.
11668 * som-high.c: (examine_table) Treats crushed tables separates for
11669 purpose of determining header size.
11670 (paginate_horizontally) Allots space for line numbers in crushed
11671 tables with lots of subrows per row. Calculates the `maximum page
11672 width', the width of the widest horizontal page.
11673 (build_target) Removed trim argument; all references changed.
11674 Stricter assertions. (dump_crush_page) New function.
11675 (dump_crush_table) Reimplemented.
11677 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11678 (som_dump_crush_page) Reimplemented, interface changed.
11680 * somP.h: Many many new helper macros for use with crushed tables.
11681 (global var som) Removed `tv', `cum_y' members; all references
11682 removed. New members `mpw', `digit_space'.
11684 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11686 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11687 variable, changed to constant 1024.
11688 (arena_ca_strdup) Changed `sizeof(a_string)' to
11689 `sizeof(c_string)'.
11690 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11691 `(c_string *)' to `(char *)'; this fixed some offset problems.
11693 * filename.c: (readlink_malloc) Changed initial allocation from
11695 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11698 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11699 &fm->owner in several places.
11701 * som-high.c: (output_table) Changed interface to rest of world.
11702 (examine_crush_table) Removed. Crushed tables are re-broken now,
11703 in preparation for rewrite.
11705 * som.h: Comment fix.
11707 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11709 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11710 itself in the cleanup stage.
11712 * descript.q: (display) At least temporarily, changed the table
11713 format to a crushed table.
11715 * list.q: (begin_row) At least temporarily, added horizontal lines
11718 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11719 the horizontal "headers," that is, to the width of the far left
11720 and far right rules.
11721 (justify_pagination) Sets som.th to the width of the widest row
11722 in the crushed table. Fixed inner loop off-by-one error.
11724 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11727 * somP.h: Comment fix.
11729 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11731 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11732 before closing it; also, opens the constructed filename `s'
11733 instead of f->filename.
11735 * postscript.c: Moved initialization of x->loaded, x->prop,
11736 x->fixed, x->current, also the add_encoding() calls, into
11738 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11739 sets x->last_font to NULL; sets x->next_combo to zero.
11741 * som-high.c: (crushed_row_height) Moved definition farther up.
11742 (som_submit_table) Doesn't calculate line width, font size until
11743 after calling open_page(), to accomodate changes to PostScript
11745 (vert_headers) Removed; equivalent functionality moved to
11746 examine_table(), examine_crush_table().
11747 (justify_pagination) Replaced with different algorithm.
11748 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11749 at the bottom of the page.
11751 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11753 * command.c: Added cmd_list back into cmd_table.
11755 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11756 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11758 * list.q: (flush_table) Updated to new som_submission_form format.
11760 * som-frnt.c: Comment fix.
11762 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11763 (output_table) Calls som_get_table_size() directly; handles
11765 (examine_crush_table) New function; calls vert_headers().
11766 (examine_table) Moved some code into new function, vert_headers().
11767 (justify_pagination) New function.
11768 (dump_plain_table) Removed `static' from `cy'.
11769 (dump_crush_table) New function.
11771 * som-low.c: (som_dump_crush_page) New function.
11773 * som.h: Comment fixes.
11774 (enum SOM_TOPT_CRUSH) New.
11775 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11776 Temporarily set to zero to make do with LIST procedure.
11778 * somP.h: Re-ordering.
11780 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11782 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11784 * somP.h: New file for use by som-high.c, som-low.c.
11786 * q2c.c: Added definition for VME.
11787 (get_line) Now dumps `!' comment lines to the output file
11790 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11791 set.q: Changed format of `!' comment lines.
11793 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11795 * All source files: Added copyright notice.
11797 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11798 longs in msg() calls.
11800 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11802 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11804 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11806 * output.c: (outp_read_devices) Changed criteria for
11807 distinguishing different types of lines.
11809 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11811 * cmdline.c: Changed syntax message.
11813 * filename.c: (good_getcwd) Bug fix (?).
11814 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11816 (search_path) Appends DIR_SEPARATOR to directory name only if it
11817 does not already end with one.
11819 * glob.c: Checks STAT_PAGER envvar before PAGER.
11821 * output.c: Checks environment variables instead of just local
11824 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11826 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11827 when the pointer passed to the function was within the arena
11828 itself, so that it couldn't properly be set to NULL _after the
11831 * command.c: Re-enabled DISPLAY.
11833 * display.c: Rewritten to handle tables. Untested.
11835 * filename.c: (search_path) Fixed memory leak.
11837 * frequencies.q: (cmd_frequencies) Frees v_variables.
11838 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11839 (cleanup_freq_tab) New function to garbage collect.
11840 (dump_full) Elegantized.
11842 * main.c: New comment.
11844 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11846 * postscript.c: Comment fix.
11847 (release_fontmap, free_font_entry) New functions.
11848 (ps_init_driver) Sets free_font_entry() as the freefunc for
11849 hashtable `loaded'. Calls release_fontmap() when destroying a
11850 driver; also frees the output filename; also frees the
11851 ps_driver_ext block.
11852 (free_ps_encoding) Frees the filename as well as the encoding
11854 (output_encodings) Frees the line buffer and pops the msg-filename
11856 (read_fontmap) Frees the fontmap filename and the line buffer.
11857 (postopen, preclose) Misc. garbage collection fixes.
11858 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11859 to NULL; this fixes some output problems.
11860 (text) Handles TAG_NEWLINE. Untested.
11862 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11863 (som_set_string) Removed. All references changed to
11865 (som_set_text) Rewritten. New interface. More general.
11867 * som.h: Minor format changes.
11868 (struct som_value_cell) Removed; all references changed to
11870 (enums SOT_*) Changed.
11872 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11874 * command.c: Re-enabled SPLIT FILE.
11876 * postscript.c: Comment fix.
11878 * som.h: Added `SOT_NONE'.
11880 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11882 * vfm.c: (dump_splits) Reimplemented.
11884 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11886 * Compiled the project under gcc 2.7.2, which gave some new
11887 warnings. This led to many additions of casts from unsigned to
11888 int sprinkled throughout the code.
11890 * arena.c: Many uses of `unsigned' changed to `size_t'.
11892 * command.c: Added END FILE, END REPEAT to command table.
11893 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11894 (find_command, FILE_TYPE_okay) Not commented out anymore.
11895 (parse_cmd) Calls FILE_TYPE_okay again.
11896 (output_line) Added calls to som_output_text() to put the line
11897 in the output files.
11899 * common.c: (macro VME) Format changes.
11900 (xstrdup) Asserts that its argument is not NULL.
11902 * data-list.c: Implemented dump_fixed_table().
11904 * inpt-pgm.c: Formatting changes. Comment changes.
11905 (end_case_proc) Renamed end_case_trns_proc.
11906 (cmd_end_file, end_file_trns_proc) New functions.
11908 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11910 * misc.h: (local_strdup) New macro corresponding to strdup() but
11911 allocating its data through local_alloc() if possible--that is, if
11914 * postscript.c: Comment changes.
11915 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11916 (output_line, add_string) New macros supporting
11917 output_encodings().
11918 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11919 substitution vars. Calls output_encodings() when a line
11920 consisting of `!encodings' is encountered.
11921 (preclose) Some code moved into quote_ps_string().
11922 (dump_line) Changed into macro supporting dump_fancy_line().
11923 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11924 command when appropriate.
11925 (write_text) Fixed `literal_char' array (I think it's fixed, at
11927 (text) Fixed bug when width was zero. Now exits immediately on
11928 zero height_left. Now, when executing `goto restart;', checks
11929 that cp<end, so that we don't read beyond end-of-string. Also,
11930 outputs the correct code to the output file by outputting the code
11931 from the metric instead of the internal metric index.
11933 * repeat.c: (cmd_end_repeat) New function.
11935 * som.c: (var som) `headers' renamed `options' and semantics
11936 changed. All references changed.
11937 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11938 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11940 (som_text_table) Removed.
11941 (som_output_text) New function.
11943 * som.h: (struct som_submission_form) Removed `header', `reuse',
11944 replaced with bitmapped field `options'.
11945 (SOM_TOPT_*) New enum set for som_submission_form.options.
11946 (SOT_*) New enum set for som_output_text().
11948 * temporary.c: (copy_variable) When copying the var label, only
11949 calls xstrdup() if it's non-NULL.
11951 * var.h: (enum type `vartype') Removed; all references changed to
11954 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11957 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11959 * font.h: Comment changes.
11961 * groff-font.c: (groff_read_font) Initializes `name' field to
11962 NULL. Handles `encoding' field.
11964 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11966 * postscript.c: (struct font_entry) Removed `position' field.
11967 (struct ps_font_combo) New struct.
11968 (struct ps_driver_ext) Removed field `next_position'. New fields
11969 `combos', `next_combo'. `last_font' field changed from
11970 `font_entry *' to `ps_font_combo *'.
11971 (ps_init_driver) Reformatted; handles new fields. When
11972 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11974 (get_encoding, find_encoding_file) New functions.
11975 (add_encoding) Some code moved out into find_encoding_file().
11976 (postopen) Changed value for ${title}.
11977 (preclose) Sets `loaded' field to NULL after destroying the hash
11979 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11981 (ps_text_set_font_by_position) Figures out the current family if
11983 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11984 (switch_font) Implemented.
11985 (write_text) Calls switch_font() more often. Format changes.
11986 #undefs its macros after they're no longer useful.
11987 (text) Changed `continue' at one point to a jump to the top of the
11988 loop because we don't want `separate' reset to 0 at that point.
11989 (load_font) No longer sets `position' in the font_entry created.
11991 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11993 * font.h: (struct font_desc) New member `encoding', which is not
11994 properly handled yet.
11996 * glob.c: (init_glob) Some new i18n code, which is probably
11999 * output.c: (outp_read_devices, outp_get_paper_size) Changed
12000 `size' local from `int' to `size_t'.
12002 * postscript.c: New driver configuration parameter `auto-encode'.
12003 New enums OPO_AUTO_ENCODE, ODA_COUNT.
12004 (struct font_entry) New member `position'.
12005 (struct ps_driver_ext) Reordered. New hash table member
12006 `encodings'; new members `next_position', `next_encoding',
12007 `last_font'. Members `current', `prop', `fixed' changed from type
12008 `font_desc *' to `font_entry *'; all references changed.
12009 (struct ps_encoding) New struct.
12010 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
12011 free_ps_encoding, add_encoding) New functions.
12012 (ps_init_driver) Added OPO_AUTO_ENCODE to default
12013 x->output_options. Initializes new members of ps_driver_ext.
12014 Changed default value for prologue_fn, encoding_fn. Calls
12015 read_ps_encodings after loading default fonts.
12016 (option_tab[], ps_option) Handle new configuration parameter.
12017 (switch_font) New function.
12018 (struct output_char) `font' member changed from `font_desc *' to
12019 `font_entry *'. New member `separate'.
12020 (read_fontmap) Changed `size' from `int' to `size_t'.
12021 (output_line, put_number) New macros for write_text().
12022 (write_text) Optimizes text output by consolidating multiple
12023 calls to PostScript `show' operator.
12024 (text) Keeps track of when text arguments can't be consolidated by
12025 write_text(), and marks those spots in the output stream.
12026 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12027 the font hasn't been switched to by switch_font(), which is where
12028 the position is important--the PostScript is what cares about the
12031 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12033 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12034 call a NULL free_func.
12035 (hsh_rehash) Elegantized.
12036 (hsh_probe) Fix bug that manifested when the table was expanded
12037 and thus had to change location in memory. Good thing
12038 too--otherwise could have been much more subtle.
12039 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12040 (hsh_foreach) New function for hash table iteration.
12042 * hash.h: (struct hsh_iterator) New.
12044 * lexer.c: (parse_tagged_quote) Font and family name strings in
12045 tags are now null-terminated.
12047 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12049 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12050 documented. (Never before tested?)
12052 * output.h: Comment changes.
12054 * postscript.c: New driver options `optimize-text-size',
12055 `optimize-line-size', `max-fonts-simult'. New enum set for
12056 specing cached line types. Comment fixes.
12057 (struct line_form) New struct.
12058 (struct ps_driver_struct) New members `text_opt', `line_opt',
12059 `max_fonts', `lines'.
12060 (ps_init_driver) Initializes new members of ps_driver_struct.
12061 (user option type enum set) New member `nonneg_int_arg'.
12062 (static var option_tab[]) Supports new options.
12063 (ps_option) Handles new options.
12064 (find_ps_file) Made static. No longer calls hsh_dump().
12065 (ps_get_var) Made static.
12066 (preclose) Dumps out proper DSC trailer.
12067 (ps_open_page) Elegantized.
12068 (ps_close_page) Calls dump_lines() if appropriate.
12069 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12070 wrappers around line().
12071 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12072 dump_lines, hash_line, free_line, line) New functions for support
12074 (write_text, text) Made static.
12075 (text) Added to font support, not finished.
12077 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12079 * font.h: (struct font_desc) New members ascent, descent.
12081 * groff-font.c: (groff_read_font) Calculates font ascent and
12082 descent from the ascent and descent of the `d' and `p' characters,
12083 respectively, as per a suggestion on comp.fonts.
12085 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12086 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12088 (write_text) Handles text right-justification and centering (not
12089 full justification). Still very inefficient. (One output line
12091 (struct output_char) Added fields for font and font size.
12092 (text) Many bugfixes.
12094 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12096 * cmdline.c: (usage) Calls outp_list_classes().
12098 * font.h: Comment fix.
12100 * groff-font.c: New exported global var `space_index'.
12101 (groff_init) New function to initialize `space_index'.
12102 (hash_kern) Casts result to unsigned.
12103 (font_name_to_index) Renamed font_char_name_to_index. All
12104 references changed. Also, now returns the value of `space_index'
12105 when passed an ASCII space character as an argument. Fixed
12107 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12108 Handles passed NULL pointers properly.
12110 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12113 * output.c: (outp_list_drivers) Removed. Removed all references.
12115 * output.h: Comment fixes.
12117 * postscript.c: (ps_open_global) Calls groff_init().
12118 (output_char) New structure.
12119 (write_text) New function.
12120 (text) No longer stubbed out! Now the output is correct--with a
12121 few exceptions, one of them being that the page has to be held
12122 upside down into a mirror.
12124 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12126 * font.h: Comment fix.
12128 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12129 All callers changed.
12130 (number_to_index) Renamed font_number_to_index, made extern. All
12132 (font_get_kern_adjust, font_get_char_metrics) New functions.
12134 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12136 * postscript.c: Changed default line width back to 1/2 point.
12137 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12138 in the center of the space allotted for them, not just a fixed
12139 offset from the edge of the space; this fixes some bugs.
12140 (ps_line_intersection) Now supports all command line styles.
12141 (ps_text_get_size) Bug fix in computation of em width.
12142 (text) New function, the meat behind ps_text_metrics and
12143 ps_text_draw. Not complete.
12144 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12145 ascii.c; call text().
12147 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12149 * arena.c: (arena_free) Assert that the argument is non-NULL.
12151 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12152 only if old_kern is non-NULL.
12154 * postscript.c: (ps_init_driver) Changed default line width to 1
12156 (postopen) New prologue variables.
12157 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12158 more of the common line styles properly, but not all.
12159 (ps_text_metrics) Fixed problem with this stubbed out version that
12160 kept it from taking font sizes into account.
12162 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12164 * arena.c: (arena_malloc) Bug fix.
12165 (arena_dump) [GLOBAL_DEBUGGING] New function.
12167 * ascii.c: Comment fix.
12168 (count_fancy_chars, delineate) Now static functions.
12170 * filename.c: (interp_vars) Bug fixes.
12172 * font.h: Comment fixes.
12174 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12175 beginning in case we have an error message to display before
12176 initializing the display.
12178 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12180 (groff_read_font) Bug fixes.
12181 (name_to_index) Increments hash.used. Sets `name' field of hash
12183 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12185 * hash.c: Return type changed.
12187 * postscript.c: Continued development. Now marks lines on the
12188 paper, but very buggy.
12190 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12192 * Changed comments in many source files from `/* xxx /* yyy */' to
12193 `/* xxx */ /* yyy */' for cleanliness.
12195 * arena.c: (arena_sd_strdup) New function.
12197 * ascii.c: (struct ascii_driver_ext) New member `file'.
12198 (ascii_init_driver) Fills out member `file' for initing; uses
12199 close_file_ext for closing drivers.
12200 (ascii_option) Changed %.*s back to %s because the a_string's are
12201 always null-terminated.
12202 (postopen, preclose) New functions.
12203 (ascii_open_page) Uses new style of open_file_ext.
12204 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12205 instead of this->output.
12206 (__assert_fail) Removed.
12208 * cmdline.c: Changed syntax_message[].
12210 * error.c: #include's <readline/history.h> only if the history
12211 library is available, not if just the readline library is
12214 * filename.c: (expand_line) Removed alloca() support.
12215 (interp_vars) No longer tilde-expands argument. Limit on output
12217 (tilde_expand) Now treats argument as path rather than filename.
12218 [!unix] Now is a no-op function.
12219 (search_path) Better verbose message formatting.
12220 (open_file, close_file) Comment fixes.
12221 (close_file) [!unix] Doesn't bother with pipes.
12222 (open_file_ext) Completely rewritten, interface revamped.
12223 (close_file_ext) New function.
12225 * font.h: Comment changes.
12227 * frequencies.q: Removed AIX alloca support since it doesn't use
12230 * hash.c: Comment changes & additions.
12231 (hsh_create) Initializes entire table instead of first M entries.
12232 (hsh_probe) Stupid bug fixed. Now it works.
12233 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12235 * main.c: (parse) Detects EOF properly in token-eating loop.
12236 Should the STOP token have its value changed to 0?
12238 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12239 (blp_getline) Now it's a macro.
12241 * output.h: (struct outp_driver) Removed members output, filename.
12243 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12244 drivers in driver table.
12245 (outp_read_devices) Frees buf. Warns if there are no active
12247 (outp_configure_clear) Sets outp_configure_vec to NULL after
12248 deleting its elements.
12249 (configure_driver, destroy_driver) Removed references to output,
12250 filename members of outp_driver.
12251 (outp_evaluate_dimension, internal_get_paper_size,
12252 outp_get_paper_size) New functions.
12254 * postscript.c: Continued development. Now links but doesn't make
12255 any marks on the page. Lotsa bugs I suppose.
12257 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12259 * str.h: Comment changes.
12261 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12263 * Removed dependencies on non-nested comments in several files.
12264 Also removed references to (unix || __unix__) in #if's since
12265 prefh.orig makes those two equivalent.
12267 * ascii.c: (ascii_open_global) Creates ascii_arena.
12268 (ascii_close_global) Destroys ascii_arena.
12269 (ascii_init_driver) Doesn't create ascii_arena.
12270 (ascii_copy_driver) Removed.
12271 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12272 (outp_class ascii_class) Removed ascii_copy_driver reference.
12274 * frequencies.q: Now can display all statistics except median.
12275 Still not finished.
12277 * output.c: Handles outp_class.ref_count so output class
12278 destructors are called properly.
12279 (add_class) Sets ref_count to 0.
12280 (configure_driver) Initializes class if ref_count++ is 0.
12281 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12282 class output file name.
12284 * output.h: (struct outp_class) Removed copy_driver, inited.
12287 * postscript.c: Completely replaced but not finished.
12289 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12291 * approx.h: #includes <float.h>.
12293 * arena.h, arena.c: Many functions changed to take an arena **
12294 instead of an arena *, for consistency. All callers changed.
12295 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12296 (arena_destroy) Sets *A to NULL.
12298 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12299 assertion that `width' be positive.
12301 * command.c: Removed #if's from cmd_table.
12302 (walk_cmdtable_func) [0] New function (debug code).
12303 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12304 (parse_cmd) Doesn't return failure for unimplemented commands.
12306 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12307 (SYSCODE) New constant macro.
12309 * descript.q: Checks for positive n_variables before performing
12312 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12313 avl_find instead of &fp as arg 2.
12315 * frequencies.g, frequencies.q: Continued updating; now compiles &
12316 works again, but not complete.
12318 * main.c: Changes to user messages.
12320 * misc.c: (reverse) [0] New function.
12322 * settings.h: Comment removed. #includes "common.h".
12324 * som.c: (som_set_null) New function.
12325 (som_set_value, som_set_string, som_set_text) More detailing
12327 (som_set_float) Implemented function.
12328 (dump_columnated_table) Bug fix regarding page breaks.
12329 (draw_cell) Bug fix regarding text that spilled out of a cell.
12330 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12332 (get_cell_size) Support SCON_EMPTY cells.
12333 (get_table_size) When calculating rules' widths and heights, mask
12334 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12336 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12338 (struct som_submission_form) New member `header'; all users
12341 * val-labs.c: (get_label) User messages changed.
12343 * var.h: Changed FREQUENCIES structures.
12345 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12348 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12350 * approx.h: Definition of EPSILON now depends on system's
12351 DBL_EPSILON. Removed GNU C specific code.
12352 (cmpapx) Renamed approx_compare.
12354 * frequencies.g, frequencies.q: Continued updating; still doesn't
12357 * groff-font.c: (name_to_index) Fix bug that kept it from
12360 * hash.c, hash.h: Completed work.
12362 * var.h: Changes to freq_tab, frequencies_proc.
12364 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12367 * hash.c, hash.h: New files. Not completed.
12368 * Makefile.am: Added hash.c to source file list.
12369 * font.h: (struct font_desc) New member kern_size_p.
12370 * groff-font.c: Uses hash.h.
12371 (hashpjw) Moved to hash.c.
12372 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12374 (static var hash) New member size_p.
12375 * var.h: Includes hash.h.
12376 (struct freq_tab) Changed AVL_TREE to hash_tab.
12378 * vars-prs.c: Comment, formatting fixes.
12380 * frequencies.g, frequencies.q: Continued updating. Not yet
12383 * formats.c: Bug fix.
12385 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12387 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12388 * descript.g: Comment fixes.
12389 * descript.q: Comment fixes. Moved some declarations into var.h.
12390 Made dsc_info a static table. Updated FIXMEs.
12391 (internal_cmd_descriptives) Beautified.
12393 * frequencies.q: Started updating into working order.
12394 * frequencies.g: New file analogous to descript.g.
12395 * var.h: Comment fixes. Added structures for FREQUENCIES.
12397 * som.c: Removed vestiges of crushing and partial table support.
12399 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12401 * Many more changes to som.c especially, but these will not be
12402 documented as I have resolved to remove them. This patchlevel is
12403 being released solely so that I can fall back to it if I decide
12404 that removing the changes is not a good idea.
12406 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12408 * som.c: (global var som) New member `cum_y'.
12409 (build_target) Properly handles titles for partial tables.
12410 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12411 Merged into single new function dump_partial(). Fixed problem
12412 with titles on partial tables.
12413 (dump_table) Calls dump_partial() for all parts of partial tables.
12414 (dump_page) Criteria for drawing title changed.
12416 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12418 * command.c: (cmd_table) Added LIST, WEIGHT.
12420 * command.c: (cmd_remark) No longer frees `s' since it's not
12421 dynamically allocated.
12423 * data-out.c: (convert_f) Now correctly handles the case where
12424 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12425 number of decimals.
12426 (som_destroy_all_tables) Removed argument. All callers changed.
12427 (som_vline, som_hline) Argument validity checking corrected.
12428 (som_set_value) Implemented half-heartedly.
12429 (replicate_table) Copies tables piece-by-piece when using Checker.
12431 * som.h: New line style SLIN_1THIN, currently equivalent to
12432 SLIN_0. New enum set SOM_SUB_*.
12433 (struct som_submission_form) Removed `seq_no'. Added `type'.
12435 * list.q: Newly working file; uses partial tables.
12437 * som.c: (som_reduce_table) Renamed som_set_table_height().
12438 (som_crush) Removed argument `group'.
12439 (global var som) Removed `nt', `seq_no'. Added `type'.
12440 (som_submit_table) Arguments changed.
12441 (output_table) Removed partial table code.
12442 (build_target) New arg; partial table support added. All callers
12444 (dump_plain_table) Removed partial table code.
12445 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12446 (dump_table) Supports partial tables.
12447 (dump_page) New argument to allow not drawing top and/or bottom
12448 headers. All callers changed. Supports partial tables.
12450 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12452 * data-out.c: Changed `#include <approx.h>' to `#include
12454 (convert_F) Comment fix. Now won't print `-.000', etc.
12456 * descript.q: Now Z-scores work, although there appears to
12457 be a bug (which might actually be in data-out.c:convert_F()).
12458 (descriptives_trns_proc, descriptives_trns_free) New functions.
12459 (run_z_pass) Implemented.
12461 * var.h: Comment fixes.
12462 (dsc_z_score, descriptives_trns) New structs.
12463 (descriptives_trns) Added to any_trns as `dsc'.
12465 * error.c, error.h: New error class, IS (Installation Script
12466 error), used in those instances where the error is in the
12467 installation, but there is a script file or installation file that
12468 can be usefully referred to.
12470 * output.c: Change many IE classes to IS classes.
12472 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12473 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12474 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12475 include the corresponding header?
12477 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12478 Don't bail out if termcap can't be read.
12480 * som.c: (som_destroy_table) Removed.
12481 (som_reduce_table, som_destroy_all_tables) New functions.
12482 (som_crush) New function, not implemented.
12484 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12485 som_submission_form. Function prototypes revised.
12487 Outputting huge tables (1000s of rows) a few rows at a time
12488 is supported, though untested. May even break everything.
12489 Actually, the code doesn't even compile right now.
12490 * som.c: (struct som) New fields htv, nt, seq_no.
12491 (som_submit_table) Multiple arguments changed to a single
12492 pointer to struct submission_form. Only increments subtable_num
12493 if seq_no is zero. Only destroys table if it's not going to
12495 (replicate_table) New function.
12496 (output_table) Comment fix.
12497 (examine_table) Changed inline code to code calling
12498 replicate_table(). Calculates htv. Supports partial tables.
12499 (draw_title) Removed comment.
12500 (build_target) Only allows for title on first part of partial
12502 (dump_plain_table) Only resets table chunk number on first part
12503 of partial tables; FIXME: doesn't work quite right. Supports
12505 (dump_page) Titles only on first part of partial tables.
12507 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12509 * Thanks to an unreliable IDE hard drive, I have spent the last
12510 day reconstructing my Debian GNU/Linux installation and redoing
12511 the previous day's changes--somehow I managed to save every file
12512 except for output.c and output.h. So the following changes could
12513 really be considered independent of the output.c, output.h changes
12516 * output.h, output.c: Moved the outp_configure_vec global var,
12517 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12518 outp_configure_vec is now static.
12520 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12522 * The entire philosophy behind configuration of the output drivers
12523 changed. Now there is a termcap-type configuration where drivers
12524 to be read are determined beforehand, rather than parsing the
12525 entire output init file and storing it in memory & deciding what
12526 to actually use later. Faster & more memory-efficient at the same
12529 * output.c: Comment fix. Removed outp_init_drivers global var.
12530 Removed all references to synonyms. New structure outp_defn. New
12531 global vars outp_macros, outp_configure_vec.
12532 (search_name, delete_name, add_name, check_configure_vec,
12533 expand_name, find_defn_value) New static functions.
12534 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12535 outp_read_devices) New extern functions.
12536 (outp_init) Much functionality moved into outp_read_devices.
12537 (outp_read_devices) Format of output init file changed; name of
12538 file is `devices' rather than `output' to avoid Makefile
12540 (outp_clear) Renamed outp_done.
12541 (outp_list_classes) Bug fix, cleaned up.
12542 (outp_list_drivers) Not implemented anymore.
12543 (outp_configure_driver) Now a static function; simplified; now
12544 interpolates macros; supports new structure.
12545 (outp_enable_driver, match_synonym) Removed; all references
12547 (find_driver) First argument removed.
12549 * output.h: Global var outp_init_drivers removed; new structure
12550 outp_names; new enum set OUTP_S_*; new global var
12551 outp_configure_vec; function prototypes for output.c exports
12554 * main.c: (main) Calls outp_read_devices() after parsing the
12557 * cmdline.c: (parse_command_line) New option -v --verbose;
12558 --version changed to -V. --device option changed syntax to just
12559 take a single device name. Accepts key=value declaration of
12560 output init file macros. Syntax message updated.
12562 * filename.c: (expand_line) New function.
12563 (interp_environ_vars) Renamed interp_vars; no longer uses
12565 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12566 overridden by real environment vars.
12567 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12568 * filename.h: interp_environ_vars() renamed interp_vars().
12570 * error.c, error.h: Added extern variable `verbosity', message
12573 * error.c: (vmsg) Support message class MM.
12574 (verbose_msg) New function.
12576 * descript.q: (generate_z_varname) Bug fix in generation of
12578 (dump_z_table) Bug fix in column headers.
12580 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12581 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12582 OPS_DONE]. Writes the uninit string when the driver is closed.
12583 (ascii_open_page) Write the init string before the first page.
12584 (output_shorts) Form of main loop changed from `while' to `for'.
12585 Bug fix with overstrikes: the character is printed *after* the
12586 backspace. Eliminated a lot of `& 0xff' modifiers.
12587 (advance_to_left_margin) New function.
12588 (return_carriage, output_lines) Handle left margin.
12590 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12592 * ascii.c: New option `carriage-return-style'.
12594 * ascii.c: (count_fancy_chars) New function.
12595 (delineate, text_metrics) Use new function; bug fixes regarding
12597 (text_draw) Bug fix with rich text.
12598 (output_string, output_shorts) Reordered.
12599 (output_shorts) Now handles boxchars and some overstrike font
12601 (output_char, return_carriage) New functions.
12602 (output_lines) Now handles overstriking and font changes properly;
12603 some code moved to output_shorts.
12605 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12608 * ascii.c: New member `debug' in ascii_driver_ext.
12609 (ascii_init_driver, delineate) Uses new member.
12611 Now you can set a vertical height on writing text.
12612 * ascii.c: (delineate) Keeps track of vertical position.
12613 (text_draw) No longer considers fully justified text an internal
12616 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12618 Tables' titles are drawn; they can have variable height.
12619 * som.c: `som' struct has new member, title_height.
12620 (draw_title) New argument. Moved within file. All caller
12622 (build_target) New argument, amount of space needed for first row.
12623 Calculates height of title, takes that into account. All callers
12625 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12627 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12629 (dump_columnated_table) Organized for readability.
12630 (dump_page) Makes use of som.title_height.
12632 * som.c: Many comment bug fixes.
12634 * descript.q: (try_name, generate_z_name) Bug fix regarding
12635 generation of Z-score variable names.
12636 * var.h: Removed num from descriptives_proc; all referents removed.
12638 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12640 * ascii.c: (ascii_line_horz, ascii_line_vert,
12641 ascii_line_intersection) Added debugging code.
12643 Added a descriptive line above each table to describe it.
12644 * command.c: (parse_cmd) Calls som_new_series.
12646 * som.c: New static vars table_num, subtable_num. New `som'
12648 (dump_page) New arguments.
12649 (som_submit_table) Handle new variables.
12651 * som.c, som.h: (som_submit_table) New arguments. All callers
12653 (som_new_series) New function.
12654 (build_target) Makes room for extra line.
12655 (draw_title) New function.
12656 (dump_page) Calls draw_title. Bug fix: doesn't always set
12659 Columnation of tables support.
12660 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12662 * som.c: Deleted references to fr, lr, ri.
12663 (som_columnate) Bux fix: sets group member of table.
12664 (som_add_options) Function removed.
12665 (dump_table) Split into three functions; extensively reworked.
12667 * descript.q: (dump_z_table) Better output table formatting; added
12668 title support to correspond to som.h changes.
12669 (display) Title support.
12671 * output.h: Added OUTP_T_NONE.
12673 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12675 * descript.q: Improved handling of Z scores; still not perfect.
12677 * output.h, ascii.c: Added hook for getting em width of current
12680 * som.c: Uses new em-width hook. Added debugging code to
12682 (som_columnate) New argument.
12683 (som_add_options) Removed.
12685 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12687 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12688 rules as a property of the table instead of as a property of the
12691 * ascii.c: Added `header' to table of options.
12693 * descript.q: Added even shorter statistic names; modified to work
12694 with new som interface.
12696 * misc.c (blp_getdelim): Bug fix.
12698 * version.c: includes 'conf.h'.
12700 ----------------------------------------------------------------------
12703 version-control: never