1 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
3 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
4 entire function useless.
6 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
8 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
9 casereader method casereader_clone.
11 * procedure.c pransformations.h: Introduced new type casenum_t
13 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
15 * variable.c: (width_to_bytes) Rephrase code for clarify.
17 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
19 * format.c: (fmt_type_from_string) New function.
20 (fmt_to_string) Include decimals in output if the format has
21 decimals, even if the format type does not. This way, we can
22 accurately reproduce incorrect formats in user output.
23 (check_common_specifier) Make the check for a bad format type an
24 assertion, so we get bug reports if they show up. Fix message.
25 Check for decimal places with a format type that doesn't allow
27 (check_input_specifier) Remove check for FMT_X, which has been
29 (check_output_specifier) Ditto.
31 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
33 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
34 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
35 (enum fmt_parse_flags) Removed.
37 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
39 * casefile.c casefile.h: Converted to an abstract base class.
40 * casefile-private.h fastfile.c fastfile.h: New files.
41 * automake.mk procedure.c scratch-writer.c storage-stream.c
43 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
45 * procedure.c (internal_procedure): Create sink_case with only as
46 many values as the compacted dictionary.
48 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
50 Remove "debugging" code that caused plenty of false positives and
53 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
55 * case.c: Remove all references to `this' member.
57 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
59 Fix link error noted by Jason Stover.
61 * storage-stream.c: Include <assert.h>.
63 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
65 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
66 ALL) and additional underlying system file issues.
68 Thanks to John Darrington for review.
70 First problem: var_hash points to variables not owned by the
71 sys-file-reader, which the caller may free or modify. Use an
72 array of sfm_vars instead, as done earlier (e.g. CVS version
75 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
76 members and remove all code that references it. Add vars, var_cnt
77 members. Remove fix_specials member, which was unused.
78 (struct sfm_var) Remove name member, which was unused.
79 (sfm_close_reader) Free vars member instead of var_hash.
80 (compare_var_shortnames) Removed.
81 (hash_var_shortname) Removed.
82 (sfm_open_reader) Fill out vars array.
83 (compare_var_index) Removed.
84 (sfm_read_case) Use vars instead of var_hash.
86 Second problem: we're confused about when we actually have very
87 long strings, causing us to choose incorrectly between slow path
88 and fast path in sfm_read_case.
90 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
91 have very long strings, not when we have long variable names,
92 which is an unrelated feature.
94 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
96 * variable.h: Move var_set and variable parsing declarations to
97 new header, src/language/lexer/variable-parser.h. Modified lots
98 of files to include the new header.
100 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
102 * value-labels.c (value_to_string): When there's no value label,
103 format the variable according to its print format, instead of
104 always effectively using A or F format.
106 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
108 * casefile.c (casefile_get_random_reader): Nasty hack to get around
111 * format.c: Removed tortological assertion.
113 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
115 Reform string library.
117 * file-name.c (fn_interp_vars): Change interface to take a
118 substring as input. Updated all users.
120 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
122 * format.c (measure_is_valid): Really return false when m >=
125 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
127 Implement random access to casefiles, for use in GUI.
129 * casefile.c: (struct casereader) Add `random', `file_ofs',
130 `buffer_ofs' members.
131 (casefile_get_random_reader) New function.
132 (read_open_file) Break part into new function
133 seek_and_fill_buffer().
134 (fill_buffer) Update buffer_ofs, file_ofs.
135 (casereader_seek) New function.
137 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
139 * settings.c: Added call to i18n{done, init}.
141 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
143 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
146 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
148 * casefile.c: Convert many uses of `int' to `bool'.
150 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
152 * transformations.c (trns_chain_destroy): Destroy chain's trns
153 member, to fix memory leak.
155 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
157 * storage-stream.c (storage_source_decapsulate): Destroy case
158 source to fix memory leak.
160 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
162 * scratch-reader.c (scratch_reader_read_case): Copy into existing
163 case passed as argument instead of initializing the argument as a
164 case. Fixes memory leak that showed up in
165 tests/command/aggregate.sh with scratch files.
167 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
169 * procedure.c (proc_done): Destroy default_dict, to fix memory
172 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
174 Simplify procedure_with_splits().
176 * procedure.c (struct split_aux_data): Removed case_count member.
177 (procedure_with_splits) Don't initialize case_count.
178 (split_procedure_case_func) Check whether prev_case is null
179 instead of case_count.
180 (split_procedure_end_func) Ditto.
182 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
184 * case.c (case_move): Do nothing if dst and src are the same
186 (case_try_create) Merge two similar cases.
187 (case_copy) Unshare only if data must be actually copied.
189 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
191 * data-in.c data-out.c dictionary.c sys-file-reader.c
192 sys-file-writer.c variable.c variable.h: Reworked very long string
193 support for better encapsulation.
195 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
197 * value-labels.c (val_labs_can_set_width): New function.
198 (val_labs_set_width) Clear labels if increasing width to long
200 (val_labs_destroy) Remove unneeded test for null.
202 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
204 * value-labels.h: Remove unneeded dependency on variable.h.
206 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
208 Get rid of `char *c' member in union value, for cleanliness.
210 * value.h: (union value) Remove `c' member.
212 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
214 Make dictionary compacting functions a little more general.
216 * sys-file-writer.c (sfm_open_writer): Use
217 dict_compacting_would_change().
218 (does_dict_need_translation) Removed.
220 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
222 Make dictionary compacting functions a little more general.
224 * dictionary.c (dict_needs_compaction): Rename
225 dict_compacting_would_shrink(). Update all callers.
226 (dict_compacting_would_change) New function.
228 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
230 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
231 inverted return value (!).
233 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
235 Continue reforming procedure execution.
237 * procedure.c: Search and replace "vfm" by "proc". Notably:
238 (static var vfm_source) Rename proc_source. Update all
240 (static var vfm_sink) Rename proc_sink. Update all references.
242 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
244 Continue reforming procedure execution. In this phase, remove
245 PROCESS IF, which was deprecated anyway and can be easily
246 simulated with TEMPORARY followed by SELECT IF.
248 * procedure.c: (open_active_file) Don't call
249 add_process_if_trns().
250 (discard_variables) Get rid of redundant call to
251 proc_cancel_all_transformations().
252 (add_process_if_trns) Removed.
253 (process_if_trns_proc) Removed.
254 (process_if_trns_free) Removed.
256 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
258 Continue reforming procedure execution. In this phase, add
259 `const' to the case passed to procedure()'s callback.
261 Updated all users of procedure() as well.
263 * procedure.c: (struct write_case_data) Add "const" to ccase
264 parameter for case_func member.
265 (procedure) Add "const" to ccase parameter for proc_func
267 (multipass_case_func) Make ccase parameter const.
268 (internal_procedure) Add "const" to ccase parameter for case_func
270 (split_procedure_case_func) Make ccase parameter const.
271 (multipass_split_case_func) Make ccase parameter const.
273 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
275 Continue reforming procedure execution. In this phase, get rid of
276 the output code for SPLIT FILE groups in procedure.c, which really
277 shouldn't be doing any output. Move it into the individual
278 procedures instead. This also adds some flexibility.
280 Updated many users of procedure_with_splits() and
281 multipass_procedure_with_splits() to call
282 output_split_file_values() and to deal with increased use of
285 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
286 parameter to begin_func member.
287 (procedure_with_splits) Add "const struct ccase *" parameter to
288 begin_func parameter. Make ccase parameter const in proc_func
290 (split_procedure_case_func) Don't dump split file group. Pass
292 (dump_splits) Moved to language/dictionary/split-file.c as
293 output_split_file_values().
294 (struct multipass_split_aux_data) Add "const struct ccase *"
295 parameter to split_func member.
296 (multipass_procedure_with_splits) Add "const struct ccase *"
297 parameter to split_func parameter.
298 (multipass_split_case_func) Save new SPLIT FILE case before
300 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
302 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
304 Continue reforming procedure execution. Change
305 internal_procedure() so that it calls open_active_file() and
306 close_active_file(), which isolates most of the actual procedure
309 * procedure.c: (struct write_case_data) Rename `proc_func' member
310 to `case_func' and update all references.
311 (procedure) Rewrite as one-line wrapper around
312 internal_procedure().
313 (struct multipass_aux_data) New.
314 (multipass_callback) Renamed multipass_case_func(). Use struct
315 multipass_aux_data as auxiliary data.
316 (multipass_end_func) New function.
317 (multipass_procedure) Rewrite as wrapper for internal_procedure()
318 that uses multipass_case_func, multipass_end_func.
319 (internal_procedure) Add `end_func' argument. Move optimization
320 of trivial case in here. Move call to open_active_file() and
321 close_active_file() in here. Now assert that vfm_source is
323 (procedure_with_splits_callback) Rename
324 split_procedure_case_func().
325 (split_procedure_end_func) New function.
326 (multipass_split_callback) Rename multipass_split_case_func.
327 (multipass_split_end_func) New function.
328 (discard_variables) No need to test for nonnull vfm_source.
330 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
332 Continue reforming procedure execution. Get rid of unused member.
334 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
336 (write_case) Don't increment cases_analyzed.
338 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
340 Continue reforming procedure execution. In this phase, move
341 procedure.c and procedure.h from src to src/data. Update
342 makefiles and #includes accordingly.
344 * procedure.c: Moved here from src/.
346 * procedure.h: Moved here from src/.
348 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
350 Continue reforming procedure execution. In this phase, get rid of
351 many global variables, consolidating procedure execution in
352 procedure.c. Encapsulate transformations in new "struct
353 trns_chain". Also, change implementation of N OF CASES, FILTER,
354 and PROCESS IF from special cases to transformations.
356 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
359 * dictionary.c: (global variable default_dict) Move to
362 * variable.h: (TRNS_*) Move to transformations.h.
363 (struct transformation) Move to transformations.c.
365 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
367 * sys-file-reader.c: Fixed invalid read problems.
369 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
371 * storage-stream.c: Add missing function comments.
373 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
375 Continue reforming procedure execution. In this phase, add some
376 new, needed functionality to storage-stream.
378 * storage-stream.c: (storage_source_decapsulate) New function.
380 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
382 * variable.c (width_to_bytes): Declarations must precede
383 statements for C90 compliance.
385 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
387 * data-out.c, data-in.c, variable.c, variable.h: New functions
388 copy_mangle and copy_demangle for reading/writing cases; emulates the
389 way SPSS deals with strings > 255 bytes.
391 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
392 subtype 14 needed for strings longer than 255 bytes.
394 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
395 instead of literal values. Also fixed some constness issues.
397 * format.h: Constness
399 * sfm-private.h: Renamed the case_size identifier, since I discovered
400 that SPSS's respect for this variable is very nominal.
402 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
404 Change case limit type from int to size_t.
406 * dictionary.c: (struct dictionary) Change type of case_limit
408 (dict_get_case_limit) Change return type.
409 (dict_set_case_limit) Change parameter type.
411 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
413 * variable.h: (struct variable) Rename `reinit' member as `leave'
414 and invert sense. Fix up all references.
416 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
418 Continue reforming procedure execution. In this phase, break
419 procedure.c into multiple files.
421 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
423 * case-sink.c: New file.
425 * case-sink.h: New file.
427 * case-source.c: New file.
429 * case-source.h: New file.
431 * storage-stream.c: New file.
433 * storage-stream.h: New file.
435 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
437 * variable.h: (struct variable) Remove `init' member and all
438 references to it from other files. It was initialized in several
439 places, but nothing really ever used it for anything worthwhile.
440 Thanks to Jason Stover for pointing out how confusing this
443 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
445 Continue reforming error message support. In this phase, get rid
446 of message "titles" and put the message text in `struct error'.
447 Now `struct error' encapsulates a message more properly.
449 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
450 Format message ourselves.
452 * data-in.c: (vdls_error) Ditto.
454 * por-file-reader.c: (error) Ditto.
456 * sys-file-reader.c: (corrupt_msg) Ditto.
458 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
460 GNU standards require "file name" instead of "filename" in
461 documentation. It's nice for our code to follow the convention
464 * casefile.c: (struct casefile) Rename `filename' member to
465 `file_name'. Updated all references.
467 * file-name.c: [!unix] (struct file_identity) Rename
468 normalized_filename member to normalized_file_name. Updated all
471 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
473 We don't really support anything but Unix-like environments well,
474 so we might as well de-obfuscate by writing directory and path
475 separators explicitly.
477 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
479 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
480 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
482 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
485 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
487 GNU standards require "file name" instead of "filename" in
488 documentation. It's nice for our code to follow the convention
491 * filename.c: Rename to file-name.c.
493 * filename.h: Rename to file-name.h. Update all inclusions.
494 Update header guards.
496 * automake.mk: Update file names.
498 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
500 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
502 (fn_basename) Removed (dead code).
503 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
504 (fn_special_p) Renamed fn_is_special(), all references updated.
505 (fn_exists_p) Renamed fn_exists(), all references updated.
507 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
509 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
510 Also, now it only tilde-expands file names, not paths.
511 (fn_search_path) Tilde-expand one directory at a time.
513 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
515 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
516 get rid of non-Unixlike version of the code, which has probably
518 (fn_prepend_dir) Removed (dead code).
520 * filename.h: (macro DIR_SEPARATOR_STRING) New.
521 (macro PATH_SEPARATOR_STRING) New.
522 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
524 Continue reforming error message support. In this phase, we get
525 rid of VM() and the other msg() support for "verbosity", replacing
526 it by a new function verbose_msg().
528 * filename.c: (fn_search_path) Use verbose_msg() instead of
531 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
533 * sfm-private.h: Get rid of #defines after #error, which makes no
536 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
538 Get rid of our own int32 type in favor of the standard int32_t
541 * sfm-private.h: (int32 macro) Don't define this anymore. Do
544 * sys-file-reader.c: Use int32_t instead of int32 throughout.
546 * sys-file-writer.c: Use int32_t instead of int32 throughout.
548 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
550 Remove ill-considered file routines that are no longer used.
552 * filename.c: (fn_open_ext) Removed.
553 (fn_close_ext) Removed.
555 * filename.h: (struct file_ext) Removed.
557 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
559 * variable.c (var_is_valid_name): Move declarations before code
562 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
564 * filename.ch (fn_interp_vars): Fixed small buglet.
566 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
568 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
569 so as to modify the string inline. Thus makeing it easier to
570 destroy the results when no longer needed.
572 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
574 * category.c (cat_stored_values_destroy): Fixed memory leak.
576 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
578 Add some missing frees. Thanks to John Darrington for reporting
581 * any-writer.c (any_writer_close): Free writer.
583 * any-reader.c (any_reader_close): Free reader.
585 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
587 * por-file-reader.c: (error) Mark as NO_RETURN.
589 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
591 * settings.c: Changed default value of scompress to true.
593 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
595 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
597 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
600 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
601 here from pref.h.orig.
603 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
605 * sys-file-reader.c: Fixed bug reading compressed files.
607 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
609 * Numerous renames. See src/ChangeLog for details.
611 * Moved files from src directory