From: Ben Pfaff Date: Tue, 24 Jan 2012 05:28:53 +0000 (-0800) Subject: gui: Use $(INSTALL_DATA), not $(INSTALL), to install data files. X-Git-Tag: v0.7.9~23 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp-builds.git;a=commitdiff_plain;h=a2d848d79d9938f6e170f80743f53c53f66f2548 gui: Use $(INSTALL_DATA), not $(INSTALL), to install data files. Plain $(INSTALL) always adds the executable bit to the installed files, which has the wrong effect for data files. Found by lintian. --- diff --git a/src/ui/gui/automake.mk b/src/ui/gui/automake.mk index 76e7ae09..d64d6df8 100644 --- a/src/ui/gui/automake.mk +++ b/src/ui/gui/automake.mk @@ -85,14 +85,14 @@ context = pspp install-lang: - $(INSTALL) $(top_srcdir)/src/ui/gui/pspp.lang $(DESTDIR)$(pkgdatadir) + $(INSTALL_DATA) $(top_srcdir)/src/ui/gui/pspp.lang $(DESTDIR)$(pkgdatadir) install-icons: for size in 16x16 ; do \ $(MKDIR_P) $(themedir)/$$size/$(context) ; \ - $(INSTALL) $(top_srcdir)/src/ui/gui/icons/$$size/* $(themedir)/$$size/$(context) ; \ + $(INSTALL_DATA) $(top_srcdir)/src/ui/gui/icons/$$size/* $(themedir)/$$size/$(context) ; \ $(MKDIR_P) $(themedir)/$$size/apps ; \ - $(INSTALL) $(top_srcdir)/src/ui/gui/app-icons/$$size/pspp.png $(themedir)/$$size/apps ; \ + $(INSTALL_DATA) $(top_srcdir)/src/ui/gui/app-icons/$$size/pspp.png $(themedir)/$$size/apps ; \ done gtk-update-icon-cache --ignore-theme-index $(themedir)