From: John Darrington Date: Sun, 19 Apr 2009 11:07:23 +0000 (+0800) Subject: Made psppire-conf thread safer X-Git-Tag: v0.7.3~146 X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?p=pspp-builds.git;a=commitdiff_plain;h=2d983f3e5bd2d5f531cbcbdcebe078034ddb8955 Made psppire-conf thread safer --- diff --git a/src/ui/gui/psppire-conf.c b/src/ui/gui/psppire-conf.c index 4090b74c..ed2f9178 100644 --- a/src/ui/gui/psppire-conf.c +++ b/src/ui/gui/psppire-conf.c @@ -95,6 +95,7 @@ static void psppire_conf_finalize (GObject *object) { PsppireConf *conf = PSPPIRE_CONF (object); + g_mutex_free (conf->mutex); g_key_file_free (conf->keyfile); g_free (conf->filename); } @@ -133,7 +134,6 @@ psppire_conf_class_init (PsppireConfClass *class) object_class->finalize = psppire_conf_finalize; object_class->dispose = psppire_conf_dispose; object_class->constructor = psppire_conf_construct; - } @@ -142,6 +142,8 @@ psppire_conf_init (PsppireConf *conf) { const gchar *dirname = g_get_user_config_dir (); + conf->mutex = g_mutex_new (); + conf->filename = g_strdup_printf ("%s/%s", dirname, "psppirerc"); conf->keyfile = g_key_file_new (); @@ -164,6 +166,8 @@ psppire_conf_get_int (PsppireConf *conf, const gchar *base, { gboolean ok; GError *err = NULL; + + g_mutex_lock (conf->mutex); conf_read (conf); *value = g_key_file_get_integer (conf->keyfile, base, @@ -173,6 +177,9 @@ psppire_conf_get_int (PsppireConf *conf, const gchar *base, if ( err != NULL ) g_error_free (err); + + g_mutex_unlock (conf->mutex); + return ok; } @@ -183,6 +190,8 @@ psppire_conf_get_boolean (PsppireConf *conf, const gchar *base, gboolean ok; gboolean b; GError *err = NULL; + g_mutex_lock (conf->mutex); + conf_read (conf); b = g_key_file_get_boolean (conf->keyfile, base, @@ -195,6 +204,8 @@ psppire_conf_get_boolean (PsppireConf *conf, const gchar *base, if (ok) *value = b; + g_mutex_unlock (conf->mutex); + return ok; } @@ -204,8 +215,10 @@ psppire_conf_set_int (PsppireConf *conf, const gchar *base, const gchar *name, gint value) { + g_mutex_lock (conf->mutex); g_key_file_set_integer (conf->keyfile, base, name, value); conf_write (conf); + g_mutex_unlock (conf->mutex); } void @@ -213,8 +226,10 @@ psppire_conf_set_boolean (PsppireConf *conf, const gchar *base, const gchar *name, gboolean value) { + g_mutex_lock (conf->mutex); g_key_file_set_boolean (conf->keyfile, base, name, value); conf_write (conf); + g_mutex_unlock (conf->mutex); } /* diff --git a/src/ui/gui/psppire-conf.h b/src/ui/gui/psppire-conf.h index a7415b24..7e9ab6ad 100644 --- a/src/ui/gui/psppire-conf.h +++ b/src/ui/gui/psppire-conf.h @@ -61,6 +61,7 @@ struct _PsppireConf gboolean dispose_has_run ; GKeyFile *keyfile; + GMutex *mutex; gchar *filename; };