lexer: Reimplement for better testability and internationalization.

[pspp-builds.git] / src / language / dictionary / value-labels.c

diff --git a/src/language/dictionary/value-labels.c b/src/language/dictionary/value-labels.c
index 9068290b7dda666495f24c1fe4499e7f7f28d9cf..18e890ddb87f87a1b206facc4f771fcc69ae361b 100644 (file)
--- a/src/language/dictionary/value-labels.c
+++ b/src/language/dictionary/value-labels.c
@@ -19,6 +19,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 
+#include "data/dictionary.h"
 #include "data/procedure.h"
 #include "data/value-labels.h"
 #include "data/variable.h"
@@ -26,6 +27,7 @@
 #include "language/lexer/lexer.h"
 #include "language/lexer/value-parser.h"
 #include "language/lexer/variable-parser.h"
+#include "libpspp/i18n.h"
 #include "libpspp/message.h"
 #include "libpspp/str.h"
 
@@ -39,7 +41,8 @@
 static int do_value_labels (struct lexer *,
                            const struct dictionary *dict, bool);
 static void erase_labels (struct variable **vars, size_t var_cnt);
-static int get_label (struct lexer *, struct variable **vars, size_t var_cnt);
+static int get_label (struct lexer *, struct variable **vars, size_t var_cnt,
+                      const char *dict_encoding);
 \f
 /* Stubs. */
 
@@ -78,7 +81,7 @@ do_value_labels (struct lexer *lexer, const struct dictionary *dict, bool erase)
       if (erase)
         erase_labels (vars, var_cnt);
       while (lex_token (lexer) != T_SLASH && lex_token (lexer) != T_ENDCMD)
-       if (!get_label (lexer, vars, var_cnt))
+       if (!get_label (lexer, vars, var_cnt, dict_get_encoding (dict)))
           goto lossage;
 
       if (lex_token (lexer) != T_SLASH)
@@ -92,10 +95,7 @@ do_value_labels (struct lexer *lexer, const struct dictionary *dict, bool erase)
       free (vars);
     }
 
-  if (parse_err)
-    return CMD_FAILURE;
-
-  return lex_end_of_command (lexer);
+  return parse_err ? CMD_FAILURE : CMD_SUCCESS;
 
  lossage:
   free (vars);
@@ -116,7 +116,8 @@ erase_labels (struct variable **vars, size_t var_cnt)
 /* Parse all the labels for the VAR_CNT variables in VARS and add
    the specified labels to those variables.  */
 static int
-get_label (struct lexer *lexer, struct variable **vars, size_t var_cnt)
+get_label (struct lexer *lexer, struct variable **vars, size_t var_cnt,
+           const char *dict_encoding)
 {
   /* Parse all the labels and add them to the variables. */
   do
@@ -125,6 +126,7 @@ get_label (struct lexer *lexer, struct variable **vars, size_t var_cnt)
       int width = var_get_width (vars[0]);
       union value value;
       struct string label;
+      size_t trunc_len;
       size_t i;
 
       /* Set value. */
@@ -145,10 +147,12 @@ get_label (struct lexer *lexer, struct variable **vars, size_t var_cnt)
 
       ds_init_substring (&label, lex_tokss (lexer));
 
-      if (ds_length (&label) > MAX_LABEL_LEN)
+      trunc_len = utf8_encoding_trunc_len (ds_cstr (&label), dict_encoding,
+                                           MAX_LABEL_LEN);
+      if (ds_length (&label) > trunc_len)
        {
          msg (SW, _("Truncating value label to %d bytes."), MAX_LABEL_LEN);
-         ds_truncate (&label, MAX_LABEL_LEN);
+         ds_truncate (&label, trunc_len);
        }
 
       for (i = 0; i < var_cnt; i++)