From 7f69a2ed219474868691fd485f7b02c01e2a7058 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Wed, 10 Feb 2010 20:26:15 -0800 Subject: [PATCH] gui: Fix theoretical comparison against garbage pointer. Presumably gtk_tree_model_iter_n_children() never returns a negative value, but in case it ever could, this eliminates a comparison against an uninitialized 'v1' value. Found by Clang (http://clang-analyzer.llvm.org). --- src/ui/gui/t-test-paired-samples.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ui/gui/t-test-paired-samples.c b/src/ui/gui/t-test-paired-samples.c index 95e212af..56de59fc 100644 --- a/src/ui/gui/t-test-paired-samples.c +++ b/src/ui/gui/t-test-paired-samples.c @@ -1,5 +1,5 @@ /* PSPPIRE - a graphical user interface for PSPP. - Copyright (C) 2008 Free Software Foundation + Copyright (C) 2008, 2010 Free Software Foundation This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -133,6 +133,8 @@ select_as_pair_member (GtkTreeIter source_iter, gtk_tree_model_get (tt_d->list_store, &dest_iter, 1, &v1, -1); } + else + v1 = NULL; if ( n_rows == 0 || v1 != NULL) { -- 2.30.2