X-Git-Url: https://pintos-os.org/cgi-bin/gitweb.cgi?a=blobdiff_plain;f=grading%2Fuserprog%2Freview.txt;h=0a400219c6895c6a10857a3e1868047448a4425e;hb=2cfc156c39840ce7f1cda6b473de1322691a8a0b;hp=29ed26b0e52e5de9b018d6081dc11421da9bed3b;hpb=63bae7d91cfdc5d6f73b52702ecb6dcca515496c;p=pintos-anon

diff --git a/grading/userprog/review.txt b/grading/userprog/review.txt
index 29ed26b..0a40021 100644
--- a/grading/userprog/review.txt
+++ b/grading/userprog/review.txt
@@ -44,6 +44,15 @@ System call design:
   -5 System call error exit leaks memory/fails to release global lock
   -5 Uses a pointer as a file descriptor or pid without justifying
 
+Wait system call:
+  -3 Busy waiting
+  -3 A static list of all parent-child pairs is extremely wasteful
+  -3 Obviously wasteful with memory (not deleting processes)
+  -2 Finished parent deletes children which may still be running
+  -1 Enable/disable interrupts
+  -2 Joinable child lets its struct thread be deleted before parent dies
+  -1 Race condition between wait and thread exit
+
 Style [[/25]]
 -------------
   -5 Extraneous output caused warnings