gui: Fix g_object_get() memory leaks for PsppireWindow's filename.
[pspp-builds.git] / src / ui / gui / psppire-window.c
index 7a4f8cefbd16885b6d983410db4941cca29251f3..332abe37608df3477a1a8249451d99fddb909ed1 100644 (file)
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2009  Free Software Foundation
+   Copyright (C) 2009, 2010, 2011  Free Software Foundation
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 
 #include <config.h>
 
+#include "psppire-window.h"
 
-#include <gtk/gtkstock.h>
-#include <gtk/gtkmessagedialog.h>
-#include <gtk/gtksignal.h>
-#include <gtk/gtkwindow.h>
-#include <gtk/gtkcheckmenuitem.h>
-#include <gtk/gtkmain.h>
+#include <gtk/gtk.h>
 
 #include <stdlib.h>
+#include <xalloc.h>
 
 #include <gettext.h>
 #define _(msgid) gettext (msgid)
 #define N_(msgid) msgid
 
-#include "psppire-window.h"
-#include "psppire-window-register.h"
+#include "data/any-reader.h"
+#include "data/dataset.h"
+
+#include "helper.h"
 #include "psppire-conf.h"
+#include "psppire-data-window.h"
+#include "psppire-syntax-window.h"
+#include "psppire-window-register.h"
+#include "psppire.h"
 
 static void psppire_window_base_finalize (PsppireWindowClass *, gpointer);
 static void psppire_window_base_init     (PsppireWindowClass *class);
@@ -86,16 +89,14 @@ uniquify (const gchar *str, int *x)
   return g_strdup_printf ("%s%d", str, (*x)++);
 }
 
-static gchar mdash[6] = {0,0,0,0,0,0};
-
 static void
 psppire_window_set_title (PsppireWindow *window)
 {
   GString *title = g_string_sized_new (80);
 
-  g_string_printf (title, _("%s %s PSPPIRE %s"),
-                  window->basename ? window->basename : "",
-                  mdash, window->description);
+  g_string_printf (title, "%s ", window->basename ? window->basename : "");
+  g_string_append_unichar (title, 0x2014); /* em dash */
+  g_string_printf (title, " PSPPIRE %s", window->description);
 
   if (window->dirty)
     g_string_prepend_c (title, '*');
@@ -137,7 +138,7 @@ psppire_window_set_property (GObject         *object,
              name = g_value_get_string (&def);
            }
 
-         candidate_name = strdup (name);
+         candidate_name = xstrdup (name);
 
          while ( psppire_window_register_lookup (reg, candidate_name))
            {
@@ -145,7 +146,7 @@ psppire_window_set_property (GObject         *object,
              candidate_name = uniquify (name, &x);
            }
 
-         window->basename = g_path_get_basename (candidate_name);
+         window->basename = g_filename_display_basename (candidate_name);
 
          g_value_unset (&def);
        }
@@ -202,19 +203,6 @@ on_realize (GtkWindow *window, gpointer data)
 }
 
 
-static gboolean
-on_configure (GtkWidget *window, GdkEventConfigure *event, gpointer data)
-{
-  const gchar *base = G_OBJECT_TYPE_NAME (window);
-
-  PsppireConf *conf = psppire_conf_new ();
-
-  psppire_conf_save_window_geometry (conf, base, event);
-
-  return FALSE;
-}
-
-
 static void
 psppire_window_finalize (GObject *object)
 {
@@ -255,11 +243,10 @@ psppire_window_class_init (PsppireWindowClass *class)
     g_param_spec_string ("filename",
                       "File name",
                       "The name of the file associated with this window, if any",
-                        "Untitled",
+                        /* TRANSLATORS: This will form a filename.  Please avoid whitespace. */
+                        _("Untitled"),
                         G_PARAM_CONSTRUCT | G_PARAM_READWRITE);
 
-  g_unichar_to_utf8 (0x2014, mdash);
-
   object_class->set_property = psppire_window_set_property;
   object_class->get_property = psppire_window_get_property;
 
@@ -315,7 +302,21 @@ menu_activate (GtkMenuItem *mi, gpointer data)
 static void
 insert_menuitem_into_menu (PsppireWindow *window, gpointer key)
 {
-  GtkWidget *item = gtk_check_menu_item_new_with_label (key);
+  gchar *filename;
+  GtkWidget *item;
+
+  /* Add a separator before adding the first real item.  If we add a separator
+     at any other time, sometimes GtkUIManager removes it. */
+  if (g_hash_table_size (window->menuitem_table) == 0)
+    {
+      GtkWidget *separator = gtk_separator_menu_item_new ();
+      gtk_widget_show (separator);
+      gtk_menu_shell_append (window->menu, separator);
+    }
+
+  filename = g_filename_display_name (key);
+  item = gtk_check_menu_item_new_with_label (filename);
+  g_free (filename);
 
   g_signal_connect (item, "toggled", G_CALLBACK (menu_toggled), NULL);
   g_signal_connect (item, "activate", G_CALLBACK (menu_activate), key);
@@ -378,16 +379,28 @@ on_delete (PsppireWindow *w, GdkEvent *event, gpointer user_data)
 {
   PsppireWindowRegister *reg = psppire_window_register_new ();
 
+  const gchar *base = G_OBJECT_TYPE_NAME (w);
+
+  PsppireConf *conf = psppire_conf_new ();
+
+  psppire_conf_save_window_geometry (conf, base, GTK_WINDOW (w));
+
+
   if ( w->dirty )
     {
       gint response = psppire_window_query_save (w);
 
-      if ( response == GTK_RESPONSE_CANCEL)
-       return TRUE;
-
-      if ( response == GTK_RESPONSE_ACCEPT)
+      switch (response)
        {
+       default:
+       case GTK_RESPONSE_CANCEL:
+         return TRUE;
+         break;
+       case GTK_RESPONSE_APPLY:
          psppire_window_save (w);
+         break;
+       case GTK_RESPONSE_REJECT:
+         break;
        }
     }
 
@@ -403,6 +416,7 @@ psppire_window_init (PsppireWindow *window)
 {
   window->name = NULL;
   window->menu = NULL;
+  window->description = xstrdup ("");
 
   window->menuitem_table  = g_hash_table_new (g_str_hash, g_str_equal);
 
@@ -425,52 +439,64 @@ psppire_window_init (PsppireWindow *window)
 
   g_object_set (window, "icon-name", "psppicon", NULL);
 
-  g_signal_connect (window, "configure-event",
-                   G_CALLBACK (on_configure), window);
-
   g_signal_connect (window, "realize",
                    G_CALLBACK (on_realize), window);
-
 }
 
-
-/* 
+/*
    Ask the user if the buffer should be saved.
    Return the response.
 */
 gint
 psppire_window_query_save (PsppireWindow *se)
 {
+  gchar *fn;
   gint response;
   GtkWidget *dialog;
+  GtkWidget *cancel_button;
 
   const gchar *description;
   const gchar *filename = psppire_window_get_filename (se);
 
+  GTimeVal time;
+
+  g_get_current_time (&time);
+
   g_object_get (se, "description", &description, NULL);
 
   g_return_val_if_fail (filename != NULL, GTK_RESPONSE_NONE);
 
+
+  fn = g_filename_display_basename (filename);
+
   dialog =
     gtk_message_dialog_new (GTK_WINDOW (se),
                            GTK_DIALOG_MODAL,
-                           GTK_MESSAGE_QUESTION,
+                           GTK_MESSAGE_WARNING,
                            GTK_BUTTONS_NONE,
-                           _("Save contents of %s to \"%s\"?"),
-                           description,
-                           filename);
+                           _("Save the changes to `%s' before closing?"),
+                           fn);
+  g_free (fn);
 
-  gtk_dialog_add_button  (GTK_DIALOG (dialog),
-                         GTK_STOCK_YES,
-                         GTK_RESPONSE_ACCEPT);
+  g_object_set (dialog, "icon-name", "psppicon", NULL);
+
+  gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
+                                           _("If you don't save, changes from the last %ld seconds will be permanently lost."),
+                                           time.tv_sec - se->savetime.tv_sec);
 
   gtk_dialog_add_button  (GTK_DIALOG (dialog),
-                         GTK_STOCK_NO,
+                         _("Close _without saving"),
                          GTK_RESPONSE_REJECT);
 
+  cancel_button = gtk_dialog_add_button  (GTK_DIALOG (dialog),
+                                         GTK_STOCK_CANCEL,
+                                         GTK_RESPONSE_CANCEL);
+
   gtk_dialog_add_button  (GTK_DIALOG (dialog),
-                         GTK_STOCK_CANCEL,
-                         GTK_RESPONSE_CANCEL);
+                         GTK_STOCK_SAVE,
+                         GTK_RESPONSE_APPLY);
+
+  gtk_widget_grab_focus (cancel_button);
 
   response = gtk_dialog_run (GTK_DIALOG (dialog));
 
@@ -480,12 +506,11 @@ psppire_window_query_save (PsppireWindow *se)
 }
 
 
+
 const gchar *
 psppire_window_get_filename (PsppireWindow *w)
 {
-  const gchar *name = NULL;
-  g_object_get (w, "filename", &name, NULL);
-  return name;
+  return w->filename;
 }
 
 
@@ -498,9 +523,10 @@ psppire_window_set_filename (PsppireWindow *w, const gchar *filename)
 void
 psppire_window_set_unsaved (PsppireWindow *w)
 {
-  w->dirty = TRUE;
+  if ( w->dirty == FALSE)
+    g_get_current_time (&w->savetime);
 
-  g_get_current_time (&w->savetime);
+  w->dirty = TRUE;
 
   psppire_window_set_title (w);
 }
@@ -576,6 +602,9 @@ psppire_window_save (PsppireWindow *w)
   g_return_if_fail (i->save);
 
   i->save (w);
+
+  w->dirty = FALSE;
+  psppire_window_set_title (w);
 }
 
 extern GtkRecentManager *the_recent_mgr;
@@ -599,6 +628,7 @@ psppire_window_load (PsppireWindow *w, const gchar *file)
 
   if ( ok )
     {
+      psppire_window_set_filename (w, file);
       add_most_recent (file, the_recent_mgr);
       w->dirty = FALSE;
     }
@@ -610,6 +640,123 @@ psppire_window_load (PsppireWindow *w, const gchar *file)
   return ok;
 }
 
+GtkWidget *
+psppire_window_file_chooser_dialog (PsppireWindow *toplevel)
+{
+  GtkWidget *dialog =
+    gtk_file_chooser_dialog_new (_("Open"),
+                                GTK_WINDOW (toplevel),
+                                GTK_FILE_CHOOSER_ACTION_OPEN,
+                                GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
+                                GTK_STOCK_OPEN, GTK_RESPONSE_ACCEPT,
+                                NULL);
+
+  GtkFileFilter *filter;
+
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("Data and Syntax Files"));
+  gtk_file_filter_add_pattern (filter, "*.sav");
+  gtk_file_filter_add_pattern (filter, "*.SAV");
+  gtk_file_filter_add_pattern (filter, "*.por");
+  gtk_file_filter_add_pattern (filter, "*.POR");
+  gtk_file_filter_add_pattern (filter, "*.sps");
+  gtk_file_filter_add_pattern (filter, "*.SPS");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("System Files (*.sav)"));
+  gtk_file_filter_add_pattern (filter, "*.sav");
+  gtk_file_filter_add_pattern (filter, "*.SAV");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("Portable Files (*.por) "));
+  gtk_file_filter_add_pattern (filter, "*.por");
+  gtk_file_filter_add_pattern (filter, "*.POR");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("Syntax Files (*.sps) "));
+  gtk_file_filter_add_pattern (filter, "*.sps");
+  gtk_file_filter_add_pattern (filter, "*.SPS");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("All Files"));
+  gtk_file_filter_add_pattern (filter, "*");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
+  {
+    gchar *dir_name;
+    gchar *filename = NULL;
+    g_object_get (toplevel, "filename", &filename, NULL);
+
+    if ( ! g_path_is_absolute (filename))
+      {
+       gchar *path =
+         g_build_filename (g_get_current_dir (), filename, NULL);
+       dir_name = g_path_get_dirname (path);
+       g_free (path);
+      }
+    else
+      {
+       dir_name = g_path_get_dirname (filename);
+      }
+    gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog),
+                                        dir_name);
+    free (dir_name);
+  }
+
+  return dialog;
+}
+
+/* Callback for the file_open action.
+   Prompts for a filename and opens it */
+void
+psppire_window_open (PsppireWindow *de)
+{
+  GtkWidget *dialog = psppire_window_file_chooser_dialog (de);
+
+  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
+    {
+    case GTK_RESPONSE_ACCEPT:
+      {
+       gchar *name =
+         gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));
+
+       gchar *sysname = convert_glib_filename_to_system_filename (name, NULL);
+
+       if (any_reader_may_open (sysname))
+          {
+            PsppireWindow *window;
+
+#if 0
+            if (PSPPIRE_IS_DATA_WINDOW (de)
+                && psppire_data_window_is_empty (PSPPIRE_DATA_WINDOW (de)))
+              window = de;
+            else
+              window = PSPPIRE_WINDOW (psppire_data_window_new (NULL));
+#else
+            window = PSPPIRE_WINDOW (psppire_default_data_window ());
+#endif
+
+            psppire_window_load (window, name);
+            gtk_widget_show (GTK_WIDGET (window));
+          }
+       else
+         open_syntax_window (name);
+
+       g_free (sysname);
+       g_free (name);
+      }
+      break;
+    default:
+      break;
+    }
+
+  gtk_widget_destroy (dialog);
+}
+
 
 /* Puts FILE_NAME into the recent list.
    If it's already in the list, it moves it to the top
@@ -627,7 +774,7 @@ add_most_recent (const char *file_name, GtkRecentManager *rm)
 
 
 
-/* 
+/*
    If FILE_NAME exists in the recent list, then  delete it.
  */
 static void
@@ -639,6 +786,5 @@ delete_recent (const char *file_name, GtkRecentManager *rm)
     gtk_recent_manager_remove_item (rm, uri, NULL);
 
   g_free (uri);
-  
 }