gui: Fix g_object_get() memory leaks for PsppireWindow's filename.
[pspp-builds.git] / src / ui / gui / psppire-data-window.c
index 72f8abbb65788a283160ace6a22ea0e1cbffe896..a463ee43d1a6c9effa5b9c6d879cc20f61e5ee34 100644 (file)
 
 #include <config.h>
 
-#include <gtk/gtksignal.h>
-#include <gtk/gtkbox.h>
+#include <gtk/gtk.h>
 #include <stdlib.h>
 
-#include "data/any-reader.h"
 #include "data/dataset.h"
 #include "language/lexer/lexer.h"
 #include "libpspp/message.h"
 #define _(msgid) gettext (msgid)
 #define N_(msgid) msgid
 
+static PsppireDataWindow *the_data_window;
 
-
-static void psppire_data_window_base_finalize (PsppireDataWindowClass *, gpointer);
-static void psppire_data_window_base_init     (PsppireDataWindowClass *class);
 static void psppire_data_window_class_init    (PsppireDataWindowClass *class);
 static void psppire_data_window_init          (PsppireDataWindow      *data_editor);
 
 
 static void psppire_data_window_iface_init (PsppireWindowIface *iface);
 
+static void psppire_data_window_dispose (GObject *object);
+static void psppire_data_window_set_property (GObject         *object,
+                                              guint            prop_id,
+                                              const GValue    *value,
+                                              GParamSpec      *pspec);
+static void psppire_data_window_get_property (GObject         *object,
+                                              guint            prop_id,
+                                              GValue          *value,
+                                              GParamSpec      *pspec);
 
 GType
 psppire_data_window_get_type (void)
@@ -88,8 +93,8 @@ psppire_data_window_get_type (void)
       static const GTypeInfo psppire_data_window_info =
        {
          sizeof (PsppireDataWindowClass),
-         (GBaseInitFunc) psppire_data_window_base_init,
-         (GBaseFinalizeFunc) psppire_data_window_base_finalize,
+         NULL,
+         NULL,
          (GClassInitFunc)psppire_data_window_class_init,
          (GClassFinalizeFunc) NULL,
          NULL,
@@ -120,49 +125,29 @@ psppire_data_window_get_type (void)
 
 static GObjectClass *parent_class ;
 
-static void
-psppire_data_window_finalize (GObject *object)
-{
-  PsppireDataWindow *de = PSPPIRE_DATA_WINDOW (object);
-
-  g_object_unref (de->builder);
-
-  if (G_OBJECT_CLASS (parent_class)->finalize)
-    (*G_OBJECT_CLASS (parent_class)->finalize) (object);
-}
-
+enum {
+    PROP_DATASET = 1
+};
 
 static void
 psppire_data_window_class_init (PsppireDataWindowClass *class)
-{
-  parent_class = g_type_class_peek_parent (class);
-}
-
-
-static void
-psppire_data_window_base_init (PsppireDataWindowClass *class)
 {
   GObjectClass *object_class = G_OBJECT_CLASS (class);
 
-  object_class->finalize = psppire_data_window_finalize;
-}
-
+  parent_class = g_type_class_peek_parent (class);
 
+  object_class->dispose = psppire_data_window_dispose;
+  object_class->set_property = psppire_data_window_set_property;
+  object_class->get_property = psppire_data_window_get_property;
 
-static void
-psppire_data_window_base_finalize (PsppireDataWindowClass *class,
-                                  gpointer class_data)
-{
+  g_object_class_install_property (
+    object_class, PROP_DATASET,
+    g_param_spec_pointer ("dataset", "Dataset",
+                          "'struct datset *' represented by the window",
+                          G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE));
 }
-
-
 \f
 
-
-extern PsppireVarStore *the_var_store;
-extern struct dataset *the_dataset;
-extern PsppireDataStore *the_data_store ;
-
 extern GtkRecentManager *the_recent_mgr;
 
 static void
@@ -185,9 +170,9 @@ set_cut_copy_menuitem_sensitivity (PsppireDataWindow *de, gboolean x)
 
 /* Run the EXECUTE command. */
 static void
-execute (void)
+execute (PsppireDataWindow *dw)
 {
-  execute_const_syntax_string ("EXECUTE.");
+  execute_const_syntax_string (dw, "EXECUTE.");
 }
 
 static void
@@ -367,113 +352,12 @@ load_file (PsppireWindow *de, const gchar *file_name)
   syntax = g_strdup_printf ("GET FILE=%s.", ds_cstr (&filename));
   ds_destroy (&filename);
 
-  ok = execute_syntax (lex_reader_for_string (syntax));
+  ok = execute_syntax (PSPPIRE_DATA_WINDOW (de),
+                       lex_reader_for_string (syntax));
   g_free (syntax);
   return ok;
 }
 
-static GtkWidget *
-sysfile_chooser_dialog (PsppireWindow *toplevel)
-{
-  GtkWidget *dialog =
-    gtk_file_chooser_dialog_new (_("Open"),
-                                GTK_WINDOW (toplevel),
-                                GTK_FILE_CHOOSER_ACTION_OPEN,
-                                GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
-                                GTK_STOCK_OPEN, GTK_RESPONSE_ACCEPT,
-                                NULL);
-
-  GtkFileFilter *filter;
-
-  filter = gtk_file_filter_new ();
-  gtk_file_filter_set_name (filter, _("Data and Syntax Files"));
-  gtk_file_filter_add_pattern (filter, "*.sav");
-  gtk_file_filter_add_pattern (filter, "*.SAV");
-  gtk_file_filter_add_pattern (filter, "*.por");
-  gtk_file_filter_add_pattern (filter, "*.POR");
-  gtk_file_filter_add_pattern (filter, "*.sps");
-  gtk_file_filter_add_pattern (filter, "*.SPS");
-  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
-
-  filter = gtk_file_filter_new ();
-  gtk_file_filter_set_name (filter, _("System Files (*.sav)"));
-  gtk_file_filter_add_pattern (filter, "*.sav");
-  gtk_file_filter_add_pattern (filter, "*.SAV");
-  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
-
-  filter = gtk_file_filter_new ();
-  gtk_file_filter_set_name (filter, _("Portable Files (*.por) "));
-  gtk_file_filter_add_pattern (filter, "*.por");
-  gtk_file_filter_add_pattern (filter, "*.POR");
-  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
-
-  filter = gtk_file_filter_new ();
-  gtk_file_filter_set_name (filter, _("Syntax Files (*.sps) "));
-  gtk_file_filter_add_pattern (filter, "*.sps");
-  gtk_file_filter_add_pattern (filter, "*.SPS");
-  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
-
-  filter = gtk_file_filter_new ();
-  gtk_file_filter_set_name (filter, _("All Files"));
-  gtk_file_filter_add_pattern (filter, "*");
-  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
-
-  {
-    gchar *dir_name;
-    gchar *filename = NULL;
-    g_object_get (toplevel, "filename", &filename, NULL);
-
-    if ( ! g_path_is_absolute (filename))
-      {
-       gchar *path =
-         g_build_filename (g_get_current_dir (), filename, NULL);
-       dir_name = g_path_get_dirname (path);
-       g_free (path);
-      }
-    else
-      {
-       dir_name = g_path_get_dirname (filename);
-      }
-    gtk_file_chooser_set_current_folder (GTK_FILE_CHOOSER (dialog),
-                                        dir_name);
-    free (dir_name);
-  }
-
-  return dialog;
-}
-
-/* Callback for the data_open action.
-   Prompts for a filename and opens it */
-static void
-open_window (PsppireWindow *de)
-{
-  GtkWidget *dialog = sysfile_chooser_dialog (de);
-
-  switch (gtk_dialog_run (GTK_DIALOG (dialog)))
-    {
-    case GTK_RESPONSE_ACCEPT:
-      {
-       gchar *name =
-         gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));
-
-       gchar *sysname = convert_glib_filename_to_system_filename (name, NULL);
-
-       if (any_reader_may_open (sysname))
-         psppire_window_load (de, name);
-       else
-         open_syntax_window (name);
-
-       g_free (sysname);
-       g_free (name);
-      }
-      break;
-    default:
-      break;
-    }
-
-  gtk_widget_destroy (dialog);
-}
-
 /* Returns true if NAME has a suffix which might denote a PSPP file */
 static gboolean
 name_has_suffix (const gchar *name)
@@ -495,14 +379,14 @@ name_has_suffix (const gchar *name)
 static void
 save_file (PsppireWindow *w)
 {
+  const gchar *file_name = NULL;
   gchar *utf8_file_name = NULL;
-  gchar *file_name = NULL;
   GString *fnx;
   struct string filename ;
   PsppireDataWindow *de = PSPPIRE_DATA_WINDOW (w);
   gchar *syntax;
 
-  g_object_get (w, "filename", &file_name, NULL);
+  file_name = psppire_window_get_filename (w);
 
   fnx = g_string_new (file_name);
 
@@ -529,7 +413,7 @@ save_file (PsppireWindow *w)
 
   ds_destroy (&filename);
 
-  g_free (execute_syntax_string (syntax));
+  g_free (execute_syntax_string (de, syntax));
 }
 
 
@@ -549,13 +433,13 @@ on_insert_variable (PsppireDataWindow *dw)
 static void
 display_dict (PsppireDataWindow *de)
 {
-  execute_const_syntax_string ("DISPLAY DICTIONARY.");
+  execute_const_syntax_string (de, "DISPLAY DICTIONARY.");
 }
 
 static void
 sysfile_info (PsppireDataWindow *de)
 {
-  GtkWidget *dialog = sysfile_chooser_dialog (PSPPIRE_WINDOW (de));
+  GtkWidget *dialog = psppire_window_file_chooser_dialog (PSPPIRE_WINDOW (de));
 
   if  ( GTK_RESPONSE_ACCEPT == gtk_dialog_run (GTK_DIALOG (dialog)))
     {
@@ -575,7 +459,7 @@ sysfile_info (PsppireDataWindow *de)
       g_free (utf8_file_name);
 
       syntax = g_strdup_printf ("SYSFILE INFO %s.", ds_cstr (&filename));
-      g_free (execute_syntax_string (syntax));
+      g_free (execute_syntax_string (de, syntax));
     }
 
   gtk_widget_destroy (dialog);
@@ -686,7 +570,7 @@ data_save (PsppireWindow *de)
 static void
 new_file (PsppireDataWindow *de)
 {
-  execute_const_syntax_string ("NEW FILE.");
+  execute_const_syntax_string (de, "NEW FILE.");
   psppire_window_set_filename (PSPPIRE_WINDOW (de), NULL);
 }
 
@@ -799,12 +683,12 @@ toggle_split_window (PsppireDataWindow  *de, GtkToggleAction *ta)
 
 
 static void
-file_quit (void)
+file_quit (PsppireDataWindow *de)
 {
   /* FIXME: Need to be more intelligent here.
      Give the user the opportunity to save any unsaved data.
   */
-  g_object_unref (the_data_store);
+  g_object_unref (de->data_store);
 
   psppire_quit ();
 }
@@ -935,8 +819,29 @@ connect_action (PsppireDataWindow *dw, const char *action_name,
   return action;
 }
 
+/* Initializes as much of a PsppireDataWindow as we can and must before the
+   dataset has been set.
+
+   In particular, the 'menu' member is required in case the "filename" property
+   is set before the "dataset" property: otherwise PsppireWindow will try to
+   modify the menu as part of the "filename" property_set() function and end up
+   with a Gtk-CRITICAL since 'menu' is NULL.  */
 static void
 psppire_data_window_init (PsppireDataWindow *de)
+{
+  GtkUIManager *uim;
+
+  de->builder = builder_new ("data-editor.ui");
+
+  uim = GTK_UI_MANAGER (get_object_assert (de->builder, "uimanager1", GTK_TYPE_UI_MANAGER));
+
+  PSPPIRE_WINDOW (de)->menu =
+    GTK_MENU_SHELL (gtk_ui_manager_get_widget (uim,"/ui/menubar/windows/windows_minimise_all")->parent);
+}
+
+static void
+psppire_data_window_finish_init (PsppireDataWindow *de,
+                                 struct dataset *ds)
 {
   static const struct dataset_callbacks cbs =
     {
@@ -944,33 +849,38 @@ psppire_data_window_init (PsppireDataWindow *de)
       transformation_change_callback, /* transformations_changed */
     };
 
-  PsppireVarStore *vs;
-  PsppireDict *dict = NULL;
+  PsppireDict *dict;
 
   GtkWidget *menubar;
   GtkWidget *hb ;
   GtkWidget *sb ;
 
   GtkWidget *box = gtk_vbox_new (FALSE, 0);
-  de->builder = builder_new ("data-editor.ui");
+
+  de->dataset = ds;
+  dict = psppire_dict_new_from_dict (dataset_dict (ds));
+  de->var_store = psppire_var_store_new (dict);
+  de->data_store = psppire_data_store_new (dict);
+  psppire_data_store_set_reader (de->data_store, NULL);
 
   menubar = get_widget_assert (de->builder, "menubar");
   hb = get_widget_assert (de->builder, "handlebox1");
   sb = get_widget_assert (de->builder, "status-bar");
 
   de->data_editor =
-    PSPPIRE_DATA_EDITOR (psppire_data_editor_new (the_var_store, the_data_store));
+    PSPPIRE_DATA_EDITOR (psppire_data_editor_new (de, de->var_store,
+                                                  de->data_store));
 
-  g_signal_connect_swapped (the_data_store, "case-changed",
+  g_signal_connect_swapped (de->data_store, "case-changed",
                            G_CALLBACK (set_unsaved), de);
 
-  g_signal_connect_swapped (the_data_store, "case-inserted",
+  g_signal_connect_swapped (de->data_store, "case-inserted",
                            G_CALLBACK (set_unsaved), de);
 
-  g_signal_connect_swapped (the_data_store, "cases-deleted",
+  g_signal_connect_swapped (de->data_store, "cases-deleted",
                            G_CALLBACK (set_unsaved), de);
 
-  dataset_set_callbacks (the_dataset, &cbs, de);
+  dataset_set_callbacks (de->dataset, &cbs, de);
 
   connect_help (de->builder);
 
@@ -992,12 +902,6 @@ psppire_data_window_init (PsppireDataWindow *de)
   g_signal_connect_swapped (de->data_editor, "data-available-changed",
                            G_CALLBACK (set_paste_menuitem_sensitivity), de);
 
-  vs = the_var_store;
-
-  g_assert(vs); /* Traps a possible bug in w32 build */
-
-  g_object_get (vs, "dictionary", &dict, NULL);
-
   g_signal_connect (dict, "weight-changed",
                    G_CALLBACK (on_weight_change),
                    de);
@@ -1021,7 +925,7 @@ psppire_data_window_init (PsppireDataWindow *de)
 
   connect_action (de, "file_save", G_CALLBACK (data_save));
  
-  connect_action (de, "file_open", G_CALLBACK (open_window));
+  connect_action (de, "file_open", G_CALLBACK (psppire_window_open));
 
   connect_action (de, "file_save_as", G_CALLBACK (data_save_as_dialog));
 
@@ -1211,9 +1115,6 @@ psppire_data_window_init (PsppireDataWindow *de)
     GtkUIManager *uim = GTK_UI_MANAGER (get_object_assert (de->builder, "uimanager1", GTK_TYPE_UI_MANAGER));
 
     merge_help_menu (uim);
-    
-    PSPPIRE_WINDOW (de)->menu =
-      GTK_MENU_SHELL (gtk_ui_manager_get_widget (uim,"/ui/menubar/windows/windows_minimise_all")->parent);
   }
 
   {
@@ -1243,17 +1144,77 @@ psppire_data_window_init (PsppireDataWindow *de)
 
   gtk_widget_show (GTK_WIDGET (de->data_editor));
   gtk_widget_show (box);
+
+  the_data_window = de;
+}
+
+static void
+psppire_data_window_dispose (GObject *object)
+{
+  PsppireDataWindow *dw = PSPPIRE_DATA_WINDOW (object);
+
+  if (dw->builder != NULL)
+    {
+      g_object_unref (dw->builder);
+      dw->builder = NULL;
+    }
+
+  if (the_data_window == dw)
+    the_data_window = NULL;
+
+  G_OBJECT_CLASS (parent_class)->dispose (object);
+}
+
+static void
+psppire_data_window_set_property (GObject         *object,
+                                  guint            prop_id,
+                                  const GValue    *value,
+                                  GParamSpec      *pspec)
+{
+  PsppireDataWindow *window = PSPPIRE_DATA_WINDOW (object);
+
+  switch (prop_id)
+    {
+    case PROP_DATASET:
+      psppire_data_window_finish_init (window, g_value_get_pointer (value));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    };
+}
+
+static void
+psppire_data_window_get_property (GObject         *object,
+                                  guint            prop_id,
+                                  GValue          *value,
+                                  GParamSpec      *pspec)
+{
+  PsppireDataWindow *window = PSPPIRE_DATA_WINDOW (object);
+
+  switch (prop_id)
+    {
+    case PROP_DATASET:
+      g_value_set_pointer (value, window->dataset);
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    };
 }
 
 
 GtkWidget*
-psppire_data_window_new (void)
+psppire_data_window_new (struct dataset *ds)
 {
-  return GTK_WIDGET (g_object_new (psppire_data_window_get_type (),
-                                  /* TRANSLATORS: This will form a filename.  Please avoid whitespace. */
-                                  "filename", _("PSPP-data"),
-                                  "description", _("Data Editor"),
-                                  NULL));
+  return GTK_WIDGET (
+    g_object_new (
+      psppire_data_window_get_type (),
+      /* TRANSLATORS: This will form a filename.  Please avoid whitespace. */
+      "filename", _("PSPP-data"),
+      "description", _("Data Editor"),
+      "dataset", ds,
+      NULL));
 }
 
 
@@ -1264,3 +1225,11 @@ psppire_data_window_iface_init (PsppireWindowIface *iface)
   iface->load = load_file;
 }
 
+\f
+PsppireDataWindow *
+psppire_default_data_window (void)
+{
+  if (the_data_window == NULL)
+    gtk_widget_show (psppire_data_window_new (dataset_create ()));
+  return the_data_window;
+}