Get rid of unnecessary barrier. Improve comment.

[pintos-anon] / grading / filesys / syn-read.c

diff --git a/grading/filesys/syn-read.c b/grading/filesys/syn-read.c
index d050db7dc4e798b2ec7c6910d9a8c9f16fcd12c7..57fd4cfcac8c6f67a0e892a291cd8f1953618441 100644 (file)
--- a/grading/filesys/syn-read.c
+++ b/grading/filesys/syn-read.c
@@ -2,40 +2,27 @@
 #include <stdio.h>
 #include <syscall.h>
 #include "fslib.h"
+#include "syn-read.h"
 
 const char test_name[] = "syn-read";
 
-static char buf[1024];
+static char buf[BUF_SIZE];
 
 #define CHILD_CNT 10
 
 void
 test_main (void) 
 {
-  const char *filename = "data";
   pid_t children[CHILD_CNT];
   int fd;
-  int i;
 
-  check (create (filename, sizeof buf), "create \"%s\"", filename);
-  check ((fd = open (filename)) > 1, "open \"%s\"", filename);
+  CHECK (create (filename, sizeof buf), "create \"%s\"", filename);
+  CHECK ((fd = open (filename)) > 1, "open \"%s\"", filename);
   random_bytes (buf, sizeof buf);
-  check (write (fd, buf, sizeof buf) > 0, "write \"%s\"", filename);
+  CHECK (write (fd, buf, sizeof buf) > 0, "write \"%s\"", filename);
   msg ("close \"%s\"", filename);
   close (fd);
 
-  for (i = 0; i < CHILD_CNT; i++) 
-    {
-      char cmd_line[128];
-      snprintf (cmd_line, sizeof cmd_line,
-                "child-syn-read %d %zu", i, sizeof buf);
-      check ((children[i] = exec (cmd_line)) != PID_ERROR,
-             "exec \"%s\"", cmd_line);
-    }
-
-  for (i = 0; i < CHILD_CNT; i++) 
-    {
-      int status = join (children[i]);
-      check (status == i, "join child %d of %d", i + 1, (int) CHILD_CNT);
-    }
+  exec_children ("child-syn-read", children, CHILD_CNT);
+  wait_children (children, CHILD_CNT);
 }