1 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
3 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
5 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
7 Start work on fixing MATCH FILES.
9 * get.c: (enum operation) Remove OP_MATCH.
10 (trim_dictionary) Change return value to bool. Don't support
12 (struct mtf_file) Remove `first', `last' members.
13 (struct mtf_proc) Add `first', `last' members. Change mtf_case
14 from `struct ccase *' to `struct ccase'. Remove `by' member.
15 (cmd_match_files) Essentially rewrite.
16 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
17 (mtf_read_nonactive_records) mtf_ parameter is not unused.
18 (mtf_processing) Ditto. Also rephrase some code.
19 (mtf_merge_dictionary) Rewrite for easy comprehension.
21 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
23 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
26 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
28 Thu Apr 14 2005 John Darrington
30 * var-display.c: New file.
32 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
33 display_width, measure and alignment parameters to variables.
35 * aggregate.c command.def compute.c count.c data-list.c descript.c
36 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
37 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
38 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
40 - Replaced literal constants representing maximum variable name
41 length with macro definitions.
42 - Added support for long variable names.
43 - Changed lexer such that it no longer makes tokens upper
44 case, but relies upon case insensitive behaviour of commands.
46 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
48 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
49 fails, don't dereference the resulting null pointer (PR 12427).
50 Also, fix double free error.
52 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
54 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
55 (accumulate_aggregate_info) Set int1 to 1 for SUM.
56 (dump_aggregate_info) Only make SUM non-missing if there was at
59 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
61 * aggregate.c: (dump_aggregate_info) Properly test whether the
62 destination variable is numeric, when making the result
63 system-missing for columnwise missing values.
65 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
67 * misc.h: Remove GCC specializations.
69 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
71 Make sort stable (PR 12313).
73 * sort.c: Don't need to include some headers anymore.
74 (static var min_buffers) New variable.
75 (static var max_buffers) New variable.
76 (static var allow_internal_sort) New variable.
77 (cmd_sort_cases) Add test mode.
78 (sort_execute) Rephrase.
79 (do_internal_sort) Don't try internal sorting if
80 allow_internal_sort is set.
81 (struct external_sort) Renamed `initial_runs' to `runs' and
82 updated all references.
83 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
84 (macro MIN_BUFFER_SIZE_BYTES) Removed.
85 (macro MIN_BUFFER_SIZE_RECS) Removed.
86 (compare_initial_runs) Removed.
87 (struct record_run) Add member `idx'.
88 (write_initial_runs) Pass increasing values to process_case() as
90 (process_case) Add `idx' parameter and use it to initialize new
92 (allocate_cases) Limit allocated buffers to max_buffers.
93 (compare_record_run) Use new `idx' member for last resort
94 comparison, for stability.
95 (end_run) Call casefile_sleep() on irs->casefile, to prevent
96 running out of file descriptors.
97 (struct merge_state) Removed.
98 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
99 unless we have fewer runs left. Always merge consecutive runs,
100 for stability. Return the final run.
102 (choose_merge) New function.
103 (merge_once) Rewritten.
105 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
107 * cmdline.c: (static var testing_mode) Move into
108 parse_command_line().
110 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
112 * algorithm.c: (remove_range) New function.
113 (remove_element) New function.
115 * dictionary.c: (dict_delete_var) Use remove_element().
117 * flip.c: (cmd_flip) Ditto.
120 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
122 * file-handle.q: (struct file_handle) `open_mode' should not be
125 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
127 First phase of making SORT CASES stable (PR 12313).
129 * sort.c: (struct indexed_case) New structure.
130 (do_internal_sort) Rewrite to make internal sorting stable.
131 (compare_case_dblptrs) Removed.
132 (compare_indexed_cases) New function.
134 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
138 * casefile.c: (casereader_read_xfer_assert) New function.
140 * dictionary.c: (dict_compact_case) New function.
142 * flip.c: (struct flip_pgm) New member idx_to_fv.
143 (cmd_flip) Initialize idx_to_fv member.
144 (destroy_flip_pgm) Free idx_to_fv member.
145 (flip_sink_write) Use struct flip_pgm member instead of case_sink
147 (flip_sink_write) Ditto.
149 * vfm.c: (write_case) Use dict_compact_case() instead of
151 (compact_case) Removed.
152 (storage_source_create) Removed `dict' parameter. All references
155 * vfm.h: (struct case_source) Removed `value_cnt' member. All
157 (struct case_sink) Removed `dict', `idx_to_fv' members. All
160 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
162 More AGGREGATE fixes.
164 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
165 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
167 (initialize_aggregate_info) Fix initialization for MIN, MAX for
171 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
173 Start work on testing and debugging AGGREGATE.
175 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
176 of a bit-map. Require proper subcommand ordering. Make OUTFILE
177 subcommand mandatory.
178 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
179 functions' arguments are in the correct order and swap them if
181 (accumulate_aggregate_info) Make SUM include weights. Add various
183 (dump_aggregate_info) Add various string functions.
184 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
186 * sort.c: (sort_parse_criteria) Add parameter for returning
187 whether any directions were specified. All callers updated.
189 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
191 * t-test.q: Fixed erroneous logic in compare_group_binary.
193 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
195 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
198 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
200 * vfm.c: (procedure_with_splits) Fix PR 11492: end_func() must be
201 called *before* close_active_file().
203 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
205 * file-handle.q: (struct file_handle) Change open_mode from
206 character pointer to 3-char array, for safety. Updated all
209 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
211 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
214 * pfm-read.c: (read_header) Improve error message for many cases
215 in which the input is not actually a portable file.
217 * file-handle.q: (fh_open) When we give an error message, actually
220 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
222 * format.c: (check_common_specifier) New function for checks
223 common to check_input_specifier() and check_output_specifier().
224 (check_input_specifier) Use check_common_specifier().
225 (check_output_specifier) Use check_common_specifier().
226 (check_string_specifier) Removed.
227 (check_specifier_type) New function.
228 (check_specifier_width) New function.
229 (get_format_var_width) Fix bug.
231 * formats.c: (internal_cmd_formats) Only accept numeric variables.
233 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
234 update all references. Make case-insensitive.
236 * pfm-read.c: Essentially rewrite the whole file. Now much
239 * print.c: (check_string_width) New function.
240 (fixed_parse_compatible) Use check_string_width(),
241 check_specifier_type().
242 (dump_fmt_list) Ditto.
244 * str.c: (st_trim_copy) New function.
245 (st_uppercase) New function.
247 * vars-atr.c: (var_is_valid_name) New function.
249 * expressions/parse.c: (type_coercion_core) Use
250 check_specifier_type().
252 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
254 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
256 * expressions/parse.c: (no_match) Ditto.
258 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
260 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
262 * expressions/helpers.c: (struct func_params) Removed.
263 (generalized_idf) Removed.
266 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
268 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
269 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
270 Implement SIG.F, which I had overlooked previously.
272 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
274 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
275 available only in testing mode.
277 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
279 * data-in.c: Use `bool' throughout, where relevant.
281 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
283 DATA LIST with free-field formats should not have implied decimal
284 places (PR 12035). Also clean up data-in.c a bit.
286 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
288 * data-in.c: (apply_implied_decimals) New function.
289 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
290 set. Also, get rid of gotos.
291 (parse_Z) Use apply_implied_decimals() if the field doesn't
292 contain a decimal point.
293 (parse_N) Use apply_implied_decimals().
299 (parse_enum) New function.
300 (macro CHAR_IS_ROMAN) Removed.
301 (macro ROMAN_VALUE) Removed.
302 (parse_month) Use parse_enum().
303 (parse_weekday) Use parse_enum().
304 (parse_DATETIME) Use long for weekday.
306 * data-list.c: (read_from_data_list_fixed) Use
309 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
311 When the lexer sees something like `-5' in the input, it has to
312 decide whether it's a negative numeric constant token or a '-'
313 token followed by a positive numeric constant token. It always
314 decides on the former, and then the parser can call
315 lex_negative_to_dash() if it wants the latter. However, this
316 doesn't work for the case of `-0', because negative zero is
317 (portably) indistinguishable from positive zero. So now we divide
318 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
319 distinction clear. This requires a little bit of extra effort,
320 because there were several references to T_NUM in the code base.
322 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
323 positive and negative numeric constants.
324 (lex_double_p) Renamed lex_is_number(). Changed return type to
325 bool. Updated all relevant references to T_NUM to instead use
327 (lex_double) Renamed lex_number(). All references updated.
328 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
329 bool. All references updated.
330 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
331 (lex_negative_to_dash) Ditto.
334 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
336 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
338 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
340 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
342 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
343 values as system-missing.
345 * expressions/parse.c: (parse_vector_element) Fix order of
346 arguments in call to expr_allocate_binary().
348 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
350 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
353 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
354 failure, as indicated by function comment.
355 (parse_binary_operators) Always return NULL on type_coercion()
356 failure. Should have been doing this anyway, but bug in
357 type_coercion_core() filtered through.
358 (parse_add) Fix typo in user message.
359 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
361 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
363 * expressions/operations.def: Add VALUE function.
365 * expressions/parse.c: (parse_function) Need an unary composite
366 node for variables in A TO B, not a variable node. Use
367 allocate_unary_variable().
368 (parse_primary) Use allocate_unary_variable().
369 (allocate_unary_variable) New function.
371 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
373 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
374 but fixed the real problem that was preventing the build from a
375 separate directory. I liked it my way better ;-)
377 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
379 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
380 John Darrington <john@darrington.wattle.id.au> for reporting this
383 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
385 * expressions/Makefile.am expressions/evaluate.h.pl
386 expressions/evaluate.inc.pl expressions/operations.h.pl
387 expressions/optimize.inc.pl expressions/parse.inc.p:
389 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
392 Fixed everything so that it can be built from an arbitrary
395 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
397 * Makefile.am : Fixed up CLEANFILES target.
399 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
401 * str.h: Changed `struct len_string' to `struct fixed_string', a
402 more accurate name. Updated all references.
404 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
406 Redo calendar support. Should now be bug-for-bug compatible.
408 * calendar.c: New file.
410 * calendar.h: New file.
412 * data-in.c: Use new calendar functions.
413 (parse_sign) Change sense of return value.
414 (calendar_error) New function.
415 (ymd_to_ofs) New function.
416 (ymd_to_date) New function.
417 (parse_DATE) Use new function.
427 (parse_DATETIME) Ditto.
429 * data-out.c: (convert_date) Use new calendar functions.
431 * error.c: (err_vmsg) Changed interface to be more sensible.
433 (dump_message) Don't double new-lines (why did we do this
436 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
438 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
439 (macro FLT64_MAX) Moved here from pref.h.orig.
441 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
443 * set.q: Support SET EPOCH.
444 (static var set_epoch) New var.
445 (aux_stc_custom_epoch) New function.
446 (stc_custom_epoch) New function.
447 (get_epoch) New function.
448 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
450 * format.c: Make it possible just to check whether a specifier is
451 valid without emitting an error message.
452 (parse_format_specifier_name) Change interface, update all
454 (check_input_specifier) Ditto.
455 (check_output_specifier) Ditto.
456 (parse_format_specifier) Ditto.
458 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
460 * command.def: Add DEBUG POOL.
462 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
464 (pool_clear) Properly account for size of pool gizmo.
465 (pool_realloc) Ditto.
466 (pool_clone) New function.
468 * pool.h: Mark our allocation functions MALLOC_LIKE.
470 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
472 * Makefile.am: Move many definitions into new top-level
473 Make.build. Add expressions to SUBDIRS. Add calendar.c,
474 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
477 * case.c: (case_resize) New function.
478 (case_swap) New function.
480 * casefile.c: Include mkfile.h.
482 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
484 * sfm-read.c: Fixed a buglet which caused a crash when trying
485 to read a non-existent file.
487 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
491 * aggregate.c: (parse_aggregate_functions) Code cleanup.
492 Important part: get rid of spurious copying of function->format to
493 destvar->print and destvar->write.
495 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
497 Fix PR 11916, which was confusing a variable's `index' member
498 with the variable's position in a var_set. Although these are
499 usually the same, they are not for array `var_set's.
501 Took advantage of this bug as an opportunity to clean up and
502 rewrite parse_var_set_vars().
504 * vars-prs.c: (parse_vs_variable_idx) New function.
505 (parse_vs_variable) Reimplement in terms of
506 parse_vs_variable_idx().
507 (parse_var_idx_class) New function.
508 (add_variable) New function.
509 (add_variables) New function.
510 (parse_var_set_vars) Rewritten.
511 (struct var_set) Change `lookup_var' member that returns a
512 variable into `lookup_var_idx' member that returns an int.
513 Updated the var set implementations in obvious corresponding ways.
514 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
516 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
518 Use our global variable compare & hash functions and give them
519 better names. Add similar functions for dealing with double
520 pointers to variables.
522 * vars-atr.c: (compare_variables) Renamed compare_var_names().
523 (hash_variable) Renamed hash_var_name().
524 (compare_var_ptr_names) New function.
525 (hash_var_ptr_name) New function.
527 * t-test.q: (cmd_t_test) Use global compare_var_names(),
529 (compare_var_name) Removed.
530 (hash_var_name) Removed.
532 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
536 * dictionary.c: (compare_variable_dblptrs) Rename
537 compare_var_ptrs() and fix it to properly dereference the double
540 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
542 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
543 declare subcommands as mandatory. Closed bug #11843
545 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
547 * getline.c command.[ch] command.def: Added (very rudimentary)
548 support for line completion when in interactive mode. Partially
551 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
553 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
554 problems revealed by valgrind.
557 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
559 * set.q: Affixed a fix to the previous fix such that we'll be OK now
560 whether or not PAGER is set.
562 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
564 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
565 "invalid free" errors. Hopefully fixes bug #11722
567 * compute.c expr-prs.c: Check that lvalues are populated before
568 attempting to destroy them. Closes bug #11676
570 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
572 * aggregate.c: Initialised the complete agr_proc structure.
576 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
578 * print.c: (print_trns_free) Close the dfm writer if there is one,
579 fixing a memory leak.
581 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
583 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
587 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
589 * linked-list.[ch] Added
591 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
592 set.q: Yet more memory leaks
594 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
596 * t-test.q examine.q : More memory leaks fixed.
598 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
600 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
603 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
605 * ascii.c cartesian.c casefile.c chart.h devind.c
606 examine.q frequencies.q
607 html.c output.h piechart.c plot-chart.c plot-hist.c
609 Integrated the chart rendering into the output stream
610 (currently only works for html).
612 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
613 dummy-chart.c for compiling without charts.
615 * mkfile.[ch] Created.
617 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
618 Added type element so we can tell if it's a chart or a table.
620 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
621 API of charts to be more like that of tables.
623 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
625 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
626 main.c. Removed the handler for SIGQUIT.
628 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
630 * casefile.c: Added a signal handler to delete temp files on
633 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
635 * command.def Added a lot more unimplemented commands.
637 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
639 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
641 * sort.c: (compare_initial_runs) Needed additional level of
643 (merge_once) Fix plenty of stupid mistakes.
645 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
647 * casefile.c: (casefile_sleep) Need to flush_buffer() after
648 calling casefile_to_disk() or we will lose the last block in the
649 file if the casefile started out as disk-based.
650 (casefile_get_reader) Initialize reader->destructive to 0.
651 (cmd_debug_casefile) Add new test pattern.
652 (test_casefile) Define new test pattern to make sure
653 casefile_sleep() works properly.
655 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
657 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
658 plot-hist.c plot-chart.c (Added) Reorganised these files in an
659 attempt to seperate the creation and processing of charts from their
662 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
665 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
667 * main.c Added a signal handler for SIGFPE
669 * sort.c Somewhat more robust fix to the previous entry.
671 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
673 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
674 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
675 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
678 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
680 * case.h Fixed bug # 11307
682 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
684 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
687 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
689 * pfm-read.c: (read_variables) Remove direct manipulation of
690 v->aux, which is no longer needed. Fixes PR 11483.
692 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
694 * data-list.c Fixed a bug in parsing delimiters.
696 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
699 * percentiles.c Properly handled calculation of Tukey hinges where
700 the number of data is small.
702 * oneway.q Used the generic value_to_string function for independent
703 variable instead of trying to do it ourselves.
705 * box-whisker.c Fixed a buglet which caused a crash if the number of
709 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
711 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
713 * percentiles.c Fixed some bugs when calculating percentiles when
714 there's a small number of cases.
716 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
718 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
720 * examine.q factor_stats.[ch] Added calculation of percentiles
722 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
724 * t-test.q Fixed bug #11227 Made t-test work when the independent
727 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
729 * factor_stats.c Fixed calculation of trimmed mean under various
732 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
734 * histogram.c chart.[ch] factor_stats.c frequencies.q
736 Added code to calculate sensible histogram ranges and limits.
738 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
740 * chart.h Updated to reflect many API changes.
742 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
743 cartesian.c and into chart.c
745 * factorstats.[ch] Added the histogram calculations
747 * casefile.c Removed an unused variable.
749 * frequencies.q examine.q histogram.c Reworked the API for
752 * piechart.c Revised the API for piecharts.
754 * var.h Moved the definitions of freq_tab and freq out of var.h
755 and into frequencies.q where they belong.
757 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
759 * flip.c: (flip_file) Check for off_t separately from fseeko(),
762 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
764 * flip.c: (flip_file) If fseeko() is not available, use long int
765 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
766 reporting the problem.
768 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
770 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
773 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
775 * var-labs.c (var_to_string) Now returns null if the variable is null
777 * value-labels.c (value_to_string) Made it return null if either the
778 value or the variable is null.
780 * hash.c (hsh_clear) Fixed a buglet.
782 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
783 with the wrong model.
785 * casefile.[ch] Added a function to return the casereader.case_idx
788 * examine.q Implemented the extreme values results.
790 John Darrington <john@darrington.wattle.id.au>
792 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
793 output.[ch] getline.c
795 Plugged some memory leaks
797 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
799 Adopt GSL random number generators, paving the way for providing
800 the complete suite of random number generators on expressions.
802 * Makefile.am: Remove random.c, random.h.
808 * algorithm.c: (algo_default_random) Use GSL functions.
810 * casefile.c: (test_casefile) Use GSL RNG functions.
812 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
815 * sample.c: (cmd_sample) Use GSL RNG functions.
816 (sample_trns_proc) Ditto.
818 * set.q: (static var set_seed) Removed.
819 (static var seed_flag) Removed.
820 (static var rng) New variable.
821 (aux_stc_custom_seed) No seed value anymore, don't print anything.
822 (stc_custom_seed) Use new seed functions.
823 (seed_is_set) Removed.
824 (get_rng) New function that composes the entire external
826 (set_rng) New function.
827 (random_seed) New function.
829 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
831 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
832 John Darrington <john@darrington.wattle.id.au> for reporting this
835 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
837 * permissions.c command.def Added the PERMISSIONS command
839 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
841 * q2c.c: (dump_header) Don't try to emit #includes at very top of
842 output file because that will precede #include <config.h>, which
844 (main) Add needed headers to /* (header) */ code.
846 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
848 Instead of making system or portable file readers responsible for
849 dropping and reordering variables, make them read full cases and
850 let the caller take care of any changes.
852 * get.c: New "case map" structure to handle this. Use for GET,
853 IMPORT, MATCH FILES. Essentially rewrite the whole file.
855 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
856 changed appropriately.
858 * sfm-read.c: (sfm_read_case) Ditto.
860 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
862 Decided that case_serialize() and case_unserialize() were too
863 abstract. Also we need a couple more functions to avoid excessive
864 copying for data in/out fast paths.
866 * case.c: (case_serial_size) Removed.
867 (case_serialize) Rename case_to_values() and make its argument
868 explicitly an array of union values.
869 (case_unserialize) Rename case_from_values() and make its argument
870 explicitly an array of union values.
871 (case_data_all) New function.
872 (case_data_all_rw) New function.
874 * casefile.c: (struct casefile) Change buffer from array of
875 unsigned char to array of union value for better accuracy.
876 Redefine buffer_used and buffer_size in terms of values, not
877 bytes. Remove case_size because it is now redundant with
878 value_cnt. Fix up all references to these members.
880 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
882 * barchart.c: (struct subcat) Make `label' member const to silence
883 GCC warning with -Wwrite-strings.
885 * cartesian.c: (struct dataset) Ditto.
887 * case.c: Don't re-define NDEBUG if already defined.
888 Add lots of comments.
890 * str.c: Fix includes.
892 * crosstabs.q: Fix includes.
894 * examine.q: Fix includes. Fix GCC warning about unused
897 * frequencies.q: (stat macro) Removed and replaced where used by
900 * list.q: Fix includes.
902 * oneway.q: Fix includes.
904 * piechart.c: Fix includes. Only define M_PI if not already
907 * sfm-read.c: (bswap) New function.
908 (bswap_int32) Write in terms of bswap.
911 * str.c: (ds_data) Add external definition here, needed because
912 str.h has only an `extern inline' version.
914 * value-labels.c: Fix includes.
916 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
918 Instead of providing a system or portable file writer with a raw
919 case in the format needed for output, provide it with a regular
920 case. The writer takes care of any needed translation.
922 * aggregate.c: Adopt new scheme for AGGREGATE.
923 (struct agr_proc) sfm_agr_case member removed.
924 (write_case_to_sfm) Removed because the new interface is easier to
927 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
929 * pfm-write.c: Implement new scheme.
931 * sfm-write.c: Ditto.
933 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
935 Instead of treating `struct file_handle' as a class to subclass
936 into data files, system files, and portable files, instead use it
937 as a helper that coordinates access. Now it is opaque, too.
939 This means that most references to a struct file_handle are now
940 changed into references to one of struct dfm_reader, struct
941 dfm_writer, struct sfm_reader, struct sfm_writer, struct
942 pfm_reader, or struct pfm_writer, according to what's being read
945 Most related changes are only worth summarizing briefly.
947 * dictionary.c: (dict_clear) Destroy aux data in deleted
949 (dict_clear_aux) New function.
950 (dict_create_var) Initialize aux, aux_dtor.
951 (dict_delete_var) Destroy aux data in deleted variable.
953 * file-handle.h: (struct fh_ext_class) Removed.
954 (struct file_handle) Removed.
955 (fh_init_files) Removed.
957 * file-handle.q: Changed references to a handle's `private' member
958 to direct references.
959 (struct private_file_handle) Renamed file_handle.
960 Add next, open_cnt, type, open_mode, aux members.
961 (struct file_handle_list) Removed.
962 (extern var inline_file) Removed.
963 (static var file_handles) Changed from file_handle_list * to
965 (create_file_handle) Initialize new members.
966 (fh_close_handle) Removed.
967 (mode_name) New function.
968 (fh_open) New function.
969 (fh_close) New function.
970 (fh_parse_file_handle) Renamed fh_parse().
972 * glob.c: (init_glob) Remove fh_init_files() call.
974 * aggregate.c: use sfm_writer.
975 (create_sysfile) Removed because the new interface is simpler.
977 * apply-dict.c: Use sfm_reader.
979 * data-list.c: Use dfm_reader.
981 * file-type.c: Use dfm_reader.
983 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
985 * inpt-pgm.c: Use dfm_reader.
987 * print.c: Use dfm_writer.
989 * sysfile-info: Use sfm_reader.
991 * dfm-read.c: Adopt new file handle infrastructure.
993 * dfm-write.c: Ditto.
997 * pfm-write.c: Ditto.
1001 * sfm-write.c: Ditto.
1003 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1005 Break dictionary functions into separate header file.
1007 * dictionary.h: New file.
1009 * var.h: Moved dict_*() functions to dictionary.h.
1011 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1013 Get rid of procedure-specific union in struct variable, using
1014 instead a void * pointer and a destructor function.
1016 Most related changes are only worth brief summaries.
1018 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1019 old p.crs member in struct variable.
1021 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1022 of old p.frq member in struct variable.
1024 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1025 it's no longer possible to grab this from var->p.frq.
1027 * piechart.c: (draw_piechart) Ditto.
1029 * group.c: (group_proc_get) New function.
1031 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1038 * main.c: (execute_command) Clear aux data in default_dict after
1039 each command. (It's debatable whether this should be done.)
1041 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1042 member in struct variable.
1044 * means.q: Get rid of integer mode, which is not included in
1045 recent SPSS and was the only code that wanted per-variable private
1048 * var.h: (struct crosstab_proc) Removed.
1049 (struct frequencies_proc) Removed.
1050 (struct list_proc) Removed.
1051 (struct get_proc) Removed.
1052 (struct means_proc) Removed.
1053 (struct matrix_data_proc) Removed.
1054 (struct match_files_proc) Removed.
1055 (lots of enums) Removed.
1056 (struct variable) Removed members `p', `get'. Add member
1059 * vars-atr.c: (var_attach_aux) New function.
1060 (var_detach_aux) New function.
1061 (var_clear_aux) New function.
1062 (var_dtor_free) New function.
1063 (discard_variables) Use NULL instead of inline_file.
1065 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1067 * value-labs.c Fixed the implmentation of value_to_string, so
1068 that it properly handles alpha values.
1070 * oneway.q Changed instances where labels were being probed manually,
1071 to use the canonical {var,value}_to_string functions
1073 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1075 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1076 plots. Changed the API of the cartesian plot to be a much lower level
1079 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1081 * examine.q Added some of the parametric calculations
1083 * factor_stats.[ch] Created
1085 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1087 * examine.q Changed the definition of factors to be a composite, and
1088 dealt with the consequences.
1090 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1092 * examine.q Fixed problem where examine wasn't dealing properly with
1095 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1097 * oneway.q Fixed problem where oneway wasn't dealing properly with
1100 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1102 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1103 command which had settings didn't get the appropriate code
1106 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1107 to convert variables/values to strings.
1109 * examine.q Added framework for the EXAMINE command.
1111 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1113 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1114 subcommand types. Changed frequencies.q to use it rather then the
1115 custom parser. Dealt with the consequences. Added a test for NTILES
1116 subcommand of frequencies.
1118 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1120 * oneway.q Fixed up the behaviour when given missing values
1122 * levene.c oneway.q Fixed a buglet with the levene statistic and
1123 incorporated the levene test into the oneway command.
1125 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1126 global scope, since they're only relevant to T-TEST
1128 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1130 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1132 Made the t-test more consistent
1133 with the way it handles groups. That is, it now uses a hash instead
1134 of an array of 2. Also, made the levene.c file independent of the
1135 implementation of the t-test. So now levene should be fine for both
1138 * Added an oneway.q file for one way anova
1140 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1142 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1145 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1149 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1150 (data_list_trns_free) Free dls->delims.
1152 * t-test.q: (tts_custom_pairs) Free vars.
1153 (ssbox_one_sample_init) Fix tab_vline() argument.
1154 (ssbox_independent_samples_init) Ditto.
1155 (trbox_paired_init) Ditto.
1156 (trbox_one_sample_init) Ditto.
1158 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1160 Generalize casefiles to the extent that we can use them for
1161 sorting and other kinds of data transformations. Change cases to
1162 be copy-on-write to improve memory efficiency in common cases.
1163 Every access to a member of a `struct ccase' was changed to be a
1164 call to a case_*() function, especially case_data(), case_num(),
1165 case_str(), or case_data_rw(). Many instances of a local variable
1166 named "case_num" were changed to "case_idx" as a consequence.
1167 Many `struct ccase *' were changed to actual `struct ccase'
1168 because of copying semantics of cases. In several places there
1169 was a choice between updating debug code to work with the new ADTs
1170 or just deleting it because it was useless; I chose to delete it.
1172 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1178 * aggregate.c: (struct agr_proc) Change type of `sort' to
1179 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1180 Rename `vars' to `agr_vars', all references updated. Change
1181 `agr_case' to type `struct ccase'.
1182 (cmd_aggregate) Deal with new members. Use case_create(),
1183 sort_active_file_in_place(), sort_active_file_to_casefile().
1184 (agr_destroy) Deal with new members.
1185 (aggregate_single_case) Ditto.
1186 (dump_aggregate_info) Ditto.
1187 (initialize_aggregate_info) Ditto.
1188 (agr_to_active_file) Ditto.
1189 (presorted_agr_to_sysfile) Ditto.
1190 (sort_agr_to_sysfile) Removed.
1192 * alloc.c: (out_of_memory) Make non-static.
1194 * alloc.h: Prototype out_of_memory().
1196 * casefile.c: Switched from a linked list in-memory representation
1197 to a two-level array-style representation. The linked list was
1198 appropriate when we could stick a header onto cases, but that's no
1199 longer the case. Also, the two-level array will allow for random
1200 in-memory access in case that's ever wanted. Also added the
1201 concept of a `destructive casereader', one that destroys cases in
1202 the underlying casefile as they are read out.
1203 (macro CASES_PER_BLOCK) New macro.
1204 (struct casefile) New members `value_cnt', `case_list_size',
1205 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1207 (struct casereader) Removed `cur'. Added `destructive', `c'.
1208 (global var casefiles) Made static.
1209 (static var case_bytes) New var.
1210 (casefile_create) Takes a value count, not a case size in bytes,
1211 to conform to the case interface. All callers updated. Deal with
1212 new and removed members.
1213 (casefile_destroy) Deal with new and removed members.
1214 (casefile_sleep) New function.
1215 (casefile_get_case_size) Removed.
1216 (casefile_get_value_cnt) New function.
1217 (casefile_append) Rewritten to deal with new and removed members.
1218 (casefile_append_xfer) New function.
1219 (write_case_to_disk) Use case_serialize().
1220 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1221 Couldn't figure out why.
1222 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1223 deal with new and removed members.
1225 (merge_sort) Removed.
1226 (casefile_sort) Removed.
1227 (casefile_get_reader) Deal with new and removed members.
1228 (casefile_get_destructive_reader) New function.
1229 (reader_open_file) Make code more readable. Create case for
1231 (casereader_get_casefile) New function.
1232 (casereader_read) Deal with new and removed members. Now returns
1233 a copy of the case, so that the caller is responsible for
1234 destroying the returned case.
1235 (casereader_read_xfer) New function.
1236 (casereader_destroy) Destroy reader's case.
1237 (test_casefile) Second arg is now a value count, all callers
1238 updated. Now tests destructive readers too.
1239 (get_random_case) Deal with new case ADT.
1240 (write_random_case) Ditto.
1241 (read_and_verify_random_case) Ditto.
1243 * crosstabs.q: Remove debug code.
1245 * descript.q: (calc_descriptives) Deal with new case, casefile
1248 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1250 * do-if.c: Remove unneeded header inclusion.
1252 * expr-prs.c: Remove debug code.
1254 * exprP.h: Remove debug code.
1256 * flip.c: (flip_file) Use fseeko() if available.
1258 * formats.c: Remove debug code.
1260 * get.c: Remove debug code.
1261 (struct mtf_file) Change `input' from `union value *' to `struct
1262 ccase', all references updated.
1264 * levene.c: (levene) Deal with new case, casefile ADTs.
1266 * list.q: Remove debug code.
1268 * loop.c: Remove debug code.
1270 * matrix-data.c: Remove debug code.
1272 * means.q: Remove debug code.
1274 * mis-val.c: Remove debug code.
1276 * pfm-read.c: Remove debug code.
1277 (pfm_read_code) Change second arg from `union value *' to `struct
1278 ccase *', all references updated.
1280 * recode.c: (string_to_long) Make first arg const.
1281 (convert_to_double) Ditto.
1283 * repeat.c: Remove debug code.
1285 * sample.c: Remove debug code.
1287 * sfm-read.c: Remove debug code.
1288 (sfm_read_case) Change second arg from `union value *' to `struct
1291 * sort.c: Redone in terms of casefiles.
1292 (enum sort_direction) Moved here from sort.h.
1293 (struct sort_criterion) New structure.
1294 (struct sort_criteria) New structure.
1295 (cmd_sort_cases) Rewritten.
1296 (prepare_to_sort_active_file) New function.
1297 (sort_active_file_in_place) New function.
1298 (sort_active_file_to_casefile) New function.
1299 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1300 changed, all callers updated.
1301 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1302 rewritten & interface changed, all callers updated.
1303 (sort_cases) Renamed sort_execute(), rewritten & interface
1304 changed, all callers updated.
1305 (struct internal_sort) Removed.
1306 (do_internal_sort) Rewritten, interface changed.
1307 (destroy_internal_sort) Removed.
1308 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1309 (struct initial_run) Removed; an initial run is now just a
1311 (compare_initial_runs) Rewritten.
1312 (struct external_sort) Changed almost completely.
1313 (do_external_sort) Rewritten, interface changed.
1314 (destroy_external_sort) Rewritten.
1315 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1316 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1317 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1318 (init_external_sort) Removed.
1319 (simulate_error) Removed.
1320 (rmdir_temp_dir) Removed.
1321 (get_temp_file_name) Removed.
1322 (open_temp_file) Removed.
1323 (close_temp_file) Removed.
1324 (remove_temp_file) Removed.
1325 (write_temp_file) Removed.
1326 (read_temp_file) Removed.
1327 (struct record_run) Change `record' from `struct case_lit *' to
1329 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1330 `file_idx', `output_file'. Add `run', casefile'. Change
1331 `last_output' from `struct case_list *' to `struct ccase'.
1332 (write_initial_runs) Change interface, rewrite.
1333 (sort_sink_write) Renamed process_case(), changed interfaced,
1335 (destroy_initial_run_state) Rewritten.
1336 (allocate_cases) Rewritten.
1337 (compare_record) Interface changed, rewritten.
1338 (start_run) Rewritten.
1339 (end_run) Rewritten.
1340 (output_record) Rewritten.
1341 (grab_case) Removed.
1342 (release_case) Removed.
1343 (struct merge_case) Change `cases' from double pointer to single
1345 (merge) Deal with new case and casefile ADTs.
1346 (struct run) Removed.
1347 (merge_once) Rewritten, interface changed.
1348 (fill_run_buffer) Removed.
1349 (sort_sink_make_source) Removed.
1350 (sort_sink_class) Removed.
1351 (struct sort_source_aux) Removed.
1352 (sort_source_read_helper) Removed.
1353 (sort_source_read) Removed.
1354 (read_sort_output) Removed.
1355 (read_internal_sort_output) Removed.
1356 (read_external_sort_output) Removed.
1357 (sort_source_destroy) Removed.
1358 (sort_source_class) Removed.
1360 * sort.h: (struct sort_cases_pgm) Removed.
1361 (enum sort_direction) Moved to sort.c.
1363 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1365 * tab.c: Remove debug code.
1367 * var-labs.c: Remove debug code.
1369 * var.h: (struct ccase) Removed.
1370 (struct case_list) Removed.
1372 * vars-atr.c: (discard_variables) Use free_case_source().
1374 * vars-prs.c: (parse_vs_variable) Make arg const.
1375 (parse_dict_variable) Ditto.
1376 (parse_variables) Make struct dictionary * arg const.
1377 (parse_var_set_vars) Make struct var_set * arg const.
1378 (struct var_set) Add const to some of the function pointers' args.
1379 (var_set_get_cnt) Make arg const.
1380 (var_set_get_var) Make first arg const.
1381 (var_set_lookup_var) Make first arg const.
1382 (dict_var_set_get_cnt) Make arg const.
1383 (dict_var_set_get_var) Make first arg const.
1384 (dict_var_set_lookup_var) Make first arg const.
1385 (var_set_create_from_dict) Make arg const. Add cast to aux
1387 (struct array_var_set) Add const to var member.
1388 (array_var_set_get_cnt) Make arg const.
1389 (array_var_set_get_var) Make first arg const.
1390 (array_var_set_lookup_var) Make first arg const.
1391 (var_set_create_from_array) Make first arg const. Insert cast.
1393 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1394 members from `struct ccase *' to `struct ccase'.
1395 (static var lag_queue) Change from double to single pointer.
1396 (procedure) Optimize trivial case.
1397 (internal_procedure) Deal with changed case, case_source ADTs.
1398 (create_trns_case) Changed interface, rewrote.
1399 (open_active_interface) Initialize modified lag queue.
1400 (write_case) Deal with changed case ADT.
1401 (lag_case) Deal with modified lag queue.
1402 (close_active_file) Destroy modified lag queue.
1403 Deal with changed case_source, case_sink ADTs.
1404 (destroy_storage_stream_info) Make null arg into no-op.
1405 (storage_sink_make_source) Set aux in created source.
1406 (storage_source_read) Deal with changed case, casefile ADTs.
1407 (storage_source_create) New function.
1408 (lagged_case) Rewrite.
1409 (free_case_source) New function.
1410 (free_case_sink) Rewrite.
1411 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1413 (procedure_with_splits) Deal with changed prev_case.
1414 (procedure_with_splits_callback) Ditto.
1415 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1417 (multipass_procedure_with_splits) Deal with changed prev_case.
1418 (multipass_split_callback) Ditto.
1421 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1423 The workspace idea didn't work out.
1425 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1427 * workspace.c: Removed.
1429 * workspace.h: Removed.
1431 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1433 Fully implement arbitrary delimiters on DATA LIST, extending the
1434 half implementation that was already there.
1436 * data-list.c: (struct data_list_pgm) Remove `delim', add
1437 `delims', `delim_cnt'.
1438 (cmd_data_list) Initialize new members. Parse delimiters and
1439 clean up code a bit.
1440 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1441 handling of leading commas.
1442 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1444 (read_from_data_list_free) Adapt to new DFM interfaces.
1445 (read_from_data_list_list) Ditto.
1446 (repeating_data_trns_proc) Ditto.
1448 * dfm.c: Split up reader and writer into separate code, because
1449 they do different things. Use struct string instead of explicit
1450 allocation code, for clarity.
1451 (enum dfm_reader_flags) New enum.
1452 (struct dfm_fhuser_ext) Removed.
1453 (struct dfm_reader_ext) New.
1454 (get_reader) New function, used by just about all the reader
1456 (dfm_close) Removed.
1457 (close_reader) New function.
1458 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1459 (dfm_open_for_writing) Ditto.
1460 (macro force_line_buffer_expansion) Removed.
1461 (count_tabs) Removed.
1462 (tabs_to_spaces) Removed.
1463 (read_record) Deal with new dfm_reader_ext. Use struct string
1464 functions. Don't convert tabs to spaces.
1465 (dfm_eof) New function.
1466 (dfm_get_record) Changed interface, rewrote.
1467 (dfm_expand_tabs) New function.
1468 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1469 dfm_reader_ext, rewritten.
1470 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1471 dfm_reader_ext, rewritten.
1472 (dfm_set_record) Removed in favor of dfm_forward_columns().
1473 (dfm_forward_columns) New function.
1474 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1475 dfm_reader_ext, rewritten.
1476 (static var dfm_r_class) Use close_reader for the destructor.
1477 (struct dfm_writer_ext) New.
1478 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1479 bounce buffer now instead of local allocation.
1480 (close_writer) New function.
1481 (static var dfm_writer_ext) Use close_writer for destructor.
1482 (cmd_begin_data) Adapt to new dfm_reader_ext.
1484 * file-handle.q: Add support for per-file tab width.
1485 (struct private_file_handle) Add tab_width member.
1486 (q2c specifications) Add tabwidth subcommand.
1487 (cmd_file_handle) Put parsed tab width into private_file_handle.
1488 (create_file_handle) Set default tab width.
1489 (handle_get_tab_width) New function.
1491 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1493 * inpt-pgm.c: (reread_trns_proc) Ditto.
1495 * matrix-data.c: (context) Ditto.
1496 (another_token) Ditto.
1500 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1502 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1504 (casereader_destroy) Don't close file descriptor -1.
1506 * recode.c: (cmd_recode) Fix memory leak.
1508 * set.q: (q2c specifications) Fix typo in user message.
1510 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
1511 undefined behavior for overlapping arguments.
1513 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
1515 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
1516 don't call it when we're running under valgrind.
1517 (call_posix_fadvise) New function.
1518 (casefile_to_disk) Use call_posix_fadvise().
1519 (reader_open_file) Ditto.
1521 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
1523 Update our string ADTs, struct string and struct len_string. Get
1524 rid of pool support, which was largely unused. Rename lots of
1525 functions to have more obvious or consistent names.
1527 * ascii.c: Get rid of ascii_pool. It was only used for string
1529 (ascii_open_global) Don't create ascii_pool.
1530 (ascii_close_driver) Don't destroy ascii_pool.
1531 (ascii_postopen_driver) Don't use pool.
1532 (ascii_close_driver) Destroy strings manually.
1534 * str.c: (ds_create) Remove pool argument, all references updated.
1536 (ds_replace) Remove pool support, make more efficient when we
1537 don't need to reallocate.
1538 (ds_destroy) Remove pool support.
1539 (ds_rpad) New function.
1540 (ds_size) Renamed ds_capacity(), all references updated.
1541 (ds_value) Renamed ds_c_str(), all references updated.
1542 (ds_concat) Renamed ds_puts(), all references updated.
1543 (ds_concat_buffer) Renamed ds_concat(), all references updated.
1544 (ds_putchar) Renamed ds_putc(), all references updated.
1545 (ds_getline) Renamed ds_gets(), all references updated.
1546 (ls_create) Remove pool argument, all references updated.
1547 (ls_create_buffer) Ditto.
1548 (ls_destroy) Removed pool support.
1549 (ls_value) Renamed ls_c_str(), all references updated.
1551 * str.h: (ls_length) [__GNUC__] Add inline version.
1552 (ls_c_str) [__GNUC__] Add inline version.
1553 (ls_end) [__GNUC__] Add inline version.
1554 (struct string) Remove pool member. Rename `size' to `capacity',
1555 all references updated.
1557 * tab.c: (text_format) Instead of using pool argument to
1558 ls_create_buffer(), call pool_register() on allocated data.
1560 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
1562 We're abusing the current ASCII driver by telling it to allocate a
1563 9999-line, 9999-character page in the tests. This causes some
1564 systems to curl up and die because it allocates 20 MB of
1565 contiguous RAM. This change alleviates at least part of the
1566 problem. It is mostly a stop-gap until the new output system is
1569 * ascii.c: (struct line) New structure.
1570 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
1571 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
1572 (ascii_preopen_driver) Initialize new members, not old ones.
1573 (ascii_close_driver) Destroy new members, not old ones.
1574 (ascii_open_page) Allocate new members, not old ones.
1575 (expand_line) Allocate room in line.
1576 (draw_line) Use new members.
1577 (ascii_line_horz) Ditto.
1578 (ascii_line_vert) Ditto.
1579 (ascii_line_intersection) Ditto.
1581 (output_lines) Ditto.
1582 (ascii_close_page) Ditto.
1584 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
1586 * matrix.c: Dead code. Removed.
1588 * matrix.h: Dead code. Removed.
1590 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
1592 Contrary to what I'd always understood, there is an efficient
1593 algorithm for deletion from a hash table populated via linear
1594 probing. This change implements it.
1596 * hash.c: (hsh_rehash) Probe in increasing order.
1598 (locate_matching_entry) Ditto.
1599 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
1601 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
1603 * moments.c (calc_moments): Adjust calculation of kurtosis to
1604 avoid subtracting huge numbers from huge numbers, on Michael
1607 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
1609 Rework moments routines for improved numerical stability based on
1610 Michael Kiefte's advice. Any bugs or remaining numerical problems
1611 are still mine though.
1613 There is now a struct moments1 for use with one-pass moments. It
1614 uses a provisional means algorithm as an attempt to improve
1615 accuracy of higher moments. The older struct moments now only
1616 handles two-pass moments.
1618 * aggregate.c: Use moments1 instead moments.
1620 * descript.c: Revert previous change, which is no longer needed
1621 due to the moments revision.
1623 * moments.c: (calc_moments) New function for calculating variance,
1625 (moments_pass_one) Only accumulate weights bigger than zero.
1626 (moments_calculate) Allow calculating the mean on pass one, others
1627 require pass two. Implement in terms of calc_moments().
1628 (struct moments1) New structure.
1629 (init_moments1) New function.
1630 (moments1_clear) Ditto.
1631 (moments1_create) Ditto.
1632 (moments1_add) Ditto.
1633 (moments1_calculate) Ditto.
1634 (moments1_destroy) Ditto.
1635 (cmd_debug_moments) Deal with `struct moments' or `struct
1636 moments1' as requested by user.
1638 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
1640 * Makefile.am (pspp_SOURCES): Remove debug.c.
1642 * debug.c: Removed. It was empty anyway.
1644 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
1646 * descript.c (calc_descriptives): Fix assert failure when only
1647 MOMENT_MEAN is needed.
1649 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
1653 fixed problem with parsing in match_statistic() causing
1654 "DESCRIPTIVE STAT=MEAN." to barf.
1656 "MEAN" is now default if "SORT" given without specification.
1658 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
1659 generally less forgiving of syntax errors: better to have it do
1660 nothing and type it in again then to not know what it actually did
1663 z-score transformation now checks score for user-missing values
1664 and checks std_dev for SYSMIS.
1666 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
1668 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
1669 Changed dict_get_case_weight() to accept an additional int * flag
1670 to complain about system-missing, user-missing, zero, or negative
1671 weights and updated existing functions to pass int * to
1672 dict_get_case_weight().
1674 2004-04-05 jmd <jmd@gnu.org>
1676 * main.c: Fixed configuration problems with gsl
1678 * t-test.q: Fixed some problems encountered when compiling under Cygwin
1680 2004-04-03 blp <blp@gnu.org>
1682 * lexer.c, ChangeLog:
1683 Fix infinite loop on comment at end of file, add test.
1685 2004-04-03 jmd <jmd@gnu.org>
1687 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
1688 Fixed the calculation of percentiles and added --syntax and --algorithm options
1690 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
1692 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
1695 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1697 * frequencies.q: Fixed the calculation of percentiles
1699 * Makefile.am: Added the --ansi flag and dealt with the
1700 consequences. Added some entries to PSPP_sources so that
1701 make distcheck would pass
1703 * cmdline.c: Added the --syntax and --algorithm options
1705 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
1707 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1709 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
1710 use the new multipass_split_... mechanism.
1712 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
1714 * frequencies.q: (calc_stats) Use moments data structure and
1715 calc_seskew(), calc_sekurt() functions.
1717 * set.q main.c settings.h Added support for --syntax and --algorithm
1720 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
1722 * vfm.c: Had to get last call to multipass_split_output() inside
1723 open_active_file()/close_active_file() pairing, so introduce new
1725 (internal_procedure) Move procedure() code here, except for calls
1726 to open_active_file() and close_active_file().
1727 (procedure) Wrap open_active_file() and close_active_file() around
1728 internal_procedure().
1729 (multipass_procedure_with_splits) Wrap open_active_file() and
1730 close_active_file() around internal_procedure().
1732 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1734 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1736 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1738 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1740 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1742 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1744 * algorithm.c: By default turn off some of the more expensive
1746 (expensive_assert) New macro which expands to assert if
1747 EXTRA_CHECKS is defined, to nothing otherwise.
1748 (unique) Use expensive_assert().
1749 (binary_search) Ditto.
1755 * command.c: (conflicting_3char_prefixes) Words that are the same
1756 don't cause conflicts when they are abbreviated to the first three
1759 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1760 nonterm_node's n earlier.
1761 (generic_str_func) Ditto.
1763 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1765 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1766 test multipass support, take advantage of new moments
1767 calculation, and to not be such crappy code. Get rid of q2c
1768 processing for DESCRIPTIVES.
1770 * vfm.c: (struct multipass_split_aux_data) New structure.
1771 (multipass_procedure_with_splits) New function.
1772 (multipass_split_callback) New function.
1773 (multipass_split_output) New function.
1774 * descript.q: Removed.
1776 * descript.c: New file.
1778 * var.h: Removed descriptives enums.
1779 (struct descriptives_proc) Removed.
1780 (struct variable) Removed p.dsc.
1782 * Makefile.am: (q_sources_c) Remove descript.c.
1783 (q_sources_q) Removed descript.q.
1785 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1787 New manager for keeping track of used workspace.
1789 * workspace.c: New file.
1791 * workspace.h: New file.
1793 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1795 * sort.c: (do_internal_sort) Use workspace_malloc().
1796 (destroy_internal_sort) Use workspace_free().
1798 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1800 New `struct casefile' for managing sets of cases.
1802 * casefile.c: New file.
1804 * casefile.h: New file.
1806 * command.def: Add DEBUG CASEFILE command.
1808 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1810 * sort.c: (sort_cases) Move logic for sending storage file to disk
1811 into do_external_sort().
1812 (struct internal_sort) Use an array of ccase pointers instead of a
1814 (do_internal_sort) Rewrite to handle casefiles.
1815 (compare_case_list) Removed.
1816 (compare_cases) New function.
1817 (compare_case_dblptrs) New function.
1818 (read_internal_sort_output) Deal with new struct internal_sort.
1820 * vfm.c: (static var workspace_overflow) Removed.
1821 (struct storage_stream_info) Removed all the members. Added
1822 struct casefile * member.
1823 (storage_sink_open) Use casefile.
1824 (open_storage_file) Removed.
1825 (write_storage_file) Removed.
1826 (storage_to_disk) Removed.
1827 (destroy_storage_stream_info) Use casefile.
1828 (storage_sink_write) Use casefile.
1829 (storage_sink_make_source) Use casefile.
1830 (storage_source_count) Use casefile.
1831 (storage_source_read) Use casefile.
1832 (storage_source_on_disk) Removed.
1833 (storage_source_get_cases) Removed.
1834 (storage_source_set_cases) Removed.
1835 (storage_source_get_casefile) New function.
1837 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1839 New `struct moments' for calculating moments.
1845 * moments.c: New file.
1847 * moments.h: New file.
1849 * command.def: Add DEBUG MOMENTS command.
1851 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1854 * aggregate.c: Modify AGGREGATE to use the new moments
1855 calculation, even if not in such a great way.
1856 (struct agr_var) Add `moments' member.
1857 (parse_aggregate_functions) Set `moments' member to null.
1858 (agr_destroy) Destroy `moments' member.
1859 (accumulate_aggregate_info) Use `moments' for standard deviation.
1860 (dump_aggregate_info) Ditto.
1861 (initialize_aggregate_info) Create or clear `moments'.
1863 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1864 cube(), pow4() that were in stats.h. All references updated.
1866 * crosstabs.q: stats.h had chi-square significance functions. Use
1868 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1870 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1871 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1873 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1875 * dictionary.c: (dict_compact_values) Compacted values need to
1878 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1880 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1881 `/' at start. Check return value of parse_variables() for error
1884 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1886 Revamp expressions: make the code a little nicer, and fix bugs
1889 * expr-evl.c: (expr_evaluate) Make expression argument const.
1890 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1891 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1892 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1893 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1894 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1895 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1896 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1897 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1898 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1899 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1900 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1901 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1902 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1904 * expr-opt.c: (optimize_expression) Rewrite.
1909 (macro s0l) Removed.
1911 (macro s1l) Removed.
1913 (macro s2l) Removed.
1916 (eq_num_con) New function.
1917 (optimize_tree) New function.
1918 (macro rnc) Removed.
1919 (macro frnc) Removed.
1920 (str_search) Add const to string params.
1921 (str_rsearch) Ditto.
1922 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1923 str[], str_len[] locals to substitute for most of removed macros.
1924 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1925 Removed support for missing values because we're never called with
1926 missing values. Use set_number() or set_number_errno() instead of
1927 rnc or frnc. Removed any stuff that caused trouble in testing.
1928 We can re-add it later if it really slows anything. Fix some
1930 (evaluate_tree_with_missing) Not yet supported. To be added later
1932 (repl_num_con) Removed.
1933 (collapse_node) New function.
1934 (force_repl_num_con) Removed.
1935 (set_number) New function.
1936 (set_number_errno) New function.
1937 (repl_str_con) Removed.
1938 (set_string) New function.
1939 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1941 (dump_node) No special case for OP_AND, OP_OR.
1943 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1944 (expr_get_type) New function.
1945 (type_check) Rewrite.
1946 (type_coercion) New function.
1947 (struct operator) New structure.
1948 (match_operator New function.
1949 (parse_binary_operators) New function.
1950 (parse_inverting_unary_operator) New function.
1951 (parse_or) Rewritten.
1952 (parse_and) Rewritten.
1953 (parse_not) Rewritten.
1954 (parse_rel) Rewritten.
1955 (parse_add) Rewritten.
1956 (parse_mul) Rewritten.
1957 (parse_neg) Rewritten.
1958 (parse_exp) Rewritten.
1959 (parse_sysvar) Add $TRUE, $FALSE system variables.
1960 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1961 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1963 (struct function) Remove desc, change `func' prototype.
1964 (unary_func) Remove special cases.
1965 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1966 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1967 (VALUE_func) Use allocate_var_node().
1968 (nary_num_func) Allow MIN and MAX for strings.
1969 Use allocate_var_node(). Properly clean up.
1971 (generic_str_func) Use local table instead of removed `desc'
1972 member. Mostly rewrite.
1973 (get_num_args) Revise error message.
1974 (parse_function) Return EXPR_ERROR, not 0 on error.
1976 (macro varies) Removed.
1977 (ops[]) Use expr.def.
1978 (free_node) Do nothing if node is null.
1979 (allocate_num_con) New function.
1980 (allocate_str_con) New function.
1981 (allocate_var_node) New function.
1982 (allocate_binary_nonterminal) New function.
1983 (append_nonterminal_arg) Removed.
1984 (static var func_tab[]) Revised.
1985 (expr_debug_print_postfix) Make parameter const.
1986 Use printf() instead of debug_printf().
1988 * expr.def: New file.
1990 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1991 use named enum instead of unnamed, all references updated. Add
1992 EXPR_ANY, EXPR_NO_OPTIMIZE.
1994 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1995 instead of defining OP_* directly.
1996 (macro IS_TERMINAL) New macro.
1997 (macro IS_NONTERMINAL) New macro.
1998 (enum OP_NO_FLAGS) New.
2000 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2002 * error.c: (err_assert_fail) msg variable needs to be non-const.
2004 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2006 * debug.c: (cmd_debug_evaluate) Rewrite.
2008 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2010 Fix some CROSSTABS bit rot stupidity.
2012 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2013 (internal_cmd_crosstabs) Initializes cells[] correctly.
2014 (float_M_suffix) Rename format_cell_entry(), change prototype,
2016 (display_crosstabulation) Fix cell formatting.
2018 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2020 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2021 to call lex_discard_line() to do that.
2023 * command.c: (run_command) Call lex_discard_line() after
2026 * lexer.c: (lex_entire_end) Change behavior.
2027 (lex_rest_of_line) Change behavior. Return const char *.
2028 (lex_discard_line) Don't clear getl_buf, don't emit message.
2030 * main.c: (handle_error) Emit message here.
2032 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2033 instead of lex_entire_line().
2035 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2037 * title.c: (get_title) Call lex_discard_line() after
2039 (cmd_file_label) Ditto.
2040 (cmd_document) Deal with const char * return value.
2042 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2044 Removed REMARK command.
2046 * command.c: (extract_prefix) Removed.
2047 (output_line) Removed.
2048 (cmd_remark) Removed.
2050 * command.def: Remove REMARK.
2052 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2054 Added abort() after lots of assert(0) invocations to avoid some
2055 compiler warnings. We really need a NOT_REACHED macro.
2057 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2059 * sort.c: Added missing call to temp_file_close. Changed error
2060 messages to warnings.
2062 * set.q: Improved setting of set_view{length,width} to be more tolerant
2065 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2067 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2068 used with incorrect syntax.
2070 * error.c, error.h et al: Overridden definition of assert for a
2073 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2074 subcommand was given when it ought to have been.
2076 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2078 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2082 (tab_joint_text) Ditto.
2084 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2086 * levene.c: Add #include.
2088 * set.q: (set_viewport) Add `int' argument to make its prototype
2089 correct for signal().
2091 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2093 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2096 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2098 Changed DFM from open-at-first-access to explicit-open. Before,
2099 calling dfm_get_record() or dfm_put_record() would automatically
2100 open the file. Now, you have to call dfm_open_for_reading() or
2101 dfm_open_for_writing() explicitly. This makes it possible to
2102 check permissions, file existence, etc. earlier.
2104 Also made struct file_handle more opaque, and clean up in general.
2106 * data-list.c: (cmd_data_list) Open handle for reading.
2108 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2110 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2111 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2112 (open_inline_file) Removed.
2113 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2114 it. Deal with line_number in extension record instead of file
2116 (dfm_get_record) Rewrote.
2117 (dfm_put_record) Rewrote.
2118 (dfm_push) Assert file is open and one of ours. Deal with
2119 line_number in extension record instead of file handle.
2120 (dfm_pop) Assert file is open and one of ours. Deal with
2121 line_number in extension record instead of file handle.
2122 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2125 * file-handle.h: (enum constants RH_RF_*) Removed.
2126 (enum constants FH_MD_*) Removed.
2127 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2128 `recform', `lrecl', `mode' members. Public references to
2129 `recform' changed to use handle_get_mode(), references to `lrecl'
2130 changed to use handle_get_record_width(). Added `private' member.
2131 (enum file_handle_mode) New.
2133 * file-handle.q: (struct private_file_handle) New structure.
2134 (struct file_handle_list) New structure.
2135 (static var files) New.
2136 (static var file_handles) Removed.
2137 (init_file_handle) Removed.
2138 (create_file_handle) Removed.
2139 (get_handle_with_name) New function.
2140 (get_handle_for_filename) New function.
2141 (cmd_file_handle) Rewritten.
2142 (hash_file_handle) Removed.
2143 (cmp_file_handle) Removed.
2144 (fh_init_files) Rewritten.
2145 (fh_parse_file_handle) Rewritten. Allows identifiers as
2147 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2149 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2150 references updated. Rewritten.
2151 (fh_record_width) Renamed handle_get_record_width(), all
2152 references updated. Rewritten.
2153 (handle_get_mode) New function.
2155 * file-type.c: (cmd_file_type) Open handle for reading.
2157 * filename.c: [unix] (struct file_identity) New structure.
2158 [unix] (fn_get_identity) New function.
2159 [unix] (fn_free_identity) New function.
2160 [unix] (fn_compare_file_identities) New function.
2161 [!unix] (struct file_identity) New structure.
2162 [!unix] (fn_get_identity) New function.
2163 [!unix] (fn_free_identity) New function.
2164 [!unix] (fn_compare_file_identities) New function.
2166 * lexer.c: (static var put) Renamed put_token, all references
2168 (static var put_tokstr) New.
2169 (static var put_tokval) New.
2170 (lex_init) Initialize put_tokstr().
2171 (restore_token) New function.
2172 (save_token) New function.
2173 (lex_get) Use restore_token().
2174 (lex_put_back) Use save_token().
2175 (lex_put_back_id) New function.
2176 (lex_put_forward) Removed.
2177 (lex_preprocess_line) Set put_token instead of using
2179 (lex_negative_to_dash) Use save_token(), set put_token directly.
2180 (dump_token) Use stderr instead of stdout.
2182 * main.c: (main) Remove call to cmd_init().
2184 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2186 * pfm-read.c: Use handle_get_filename() instead of trying to use
2187 h->fn directly, all over.
2189 * pfm-write.c: Ditto.
2191 * print.c: (internal_cmd_print) Open handle for writing.
2192 (dump_table) Use handle_get_filename().
2193 (print_trns_proc) Use handle_get_mode().
2194 (cmd_print_space) Use fh_parse_file_handle().
2195 Open handle for writing.
2196 [0] (debug_print) Removed.
2198 * sfm-read.c: Use handle_get_filename() instead of trying to use
2199 h->fn directly, all over.
2201 * sfm-write.c: Ditto.
2203 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2207 * autorecode.c: (arc_free) Free arc->src_values.
2209 * error.c: (msg) Free buf.
2211 * val-labs.c: (do_value_labels) Always free vars.
2213 * vfm.c: (close_active_file) If sink has no make_source then call
2214 its destroy function.
2216 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2218 Fixed cmd_parse() so that it always skips past a full command
2219 name. A few special commands for which this would be bad get
2220 special treatment. This lets us drop code for skipping past the
2221 end of a command name in most cmd_*() functions. It's not worth
2222 listing all the commands affected.
2224 * command.c: (struct command) Remove `cmd' member, replace by
2225 `name' member, all references updated. Remove `word', `next',
2226 `skip_entire_name' members.
2227 (macro DEFCMD) Deal with revised `struct command'.
2228 (macro UNIMPL) Ditto.
2229 (macro SPCCMD) New macro for commands whose last word shouldn't be
2231 (static array cmd_table[]) Make const, rename `commands', remove
2233 (macro COMMAND_CNT) New macro.
2234 (split_words) Removed.
2236 (FILE_TYPE_okay) Make parameter const.
2237 (cmd_parse) Improve error messages.
2238 (match_strings) New function.
2239 (next_word) New function.
2240 (enum command_match) New enum.
2241 (conflicting_3char_prefixes) New function.
2242 (conflicting_3char_prefix_command) New function.
2243 (cmd_match_words) New function.
2244 (count_matching_commands) New function.
2245 (get_command_name) New function.
2246 (free_words) New function.
2247 (unknown_command_error) New function.
2248 (figure_out_command) Renamed parse_command_name(), rewritten.
2250 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2251 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2252 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2255 * command.h: (macro SPCCMD) New.
2257 * include.c: (cmd_include_at) Removed.
2258 (cmd_include) Allow identifier to be used as filename.
2260 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2262 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2265 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2267 Start work on better test framework.
2269 * Makefile.am: (pspp_sources) Add debug.c.
2271 * debug.c: New file.
2273 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2274 cmd_debug_evaluate().
2276 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2278 * expr.h: (enum constant PXP_DUMP) Removed.
2280 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2282 * set.q: Implemented the SHOW command, and synced it to the existing
2285 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2286 changes as the window size is changed.
2288 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2289 environment variables if other methods are not available.
2291 glob.c: Removed a lot of global variables from glob.c and encapsulated
2294 random.c: Tidied up the way the random seed is set.
2296 str.c: Added a ds_vprintf function.
2298 error.c: Extended dump_message so that messages are always broken at
2301 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2303 * pfm-write.c: (bufwrite) Write out the correct element for string
2304 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2306 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2308 Get rid of static and global (!) vars in matrix-data.c.
2310 * matrix-data.c: (static var nr_data) Removed.
2311 (static var nr_factor_values) Removed.
2312 (static var max_cell_index) Removed.
2313 (static var split_values) Removed.
2314 (struct nr_aux_data) New structure.
2315 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2316 place of static vars, pass to create_case_source() and procedure()
2318 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2319 struct matrix_data_pgm *.
2320 (nr_read_splits) Ditto.
2321 (nr_read_factors) Ditto.
2322 (nr_output_data) Ditto.
2323 (static var wr_content) Removed.
2324 (global var wr_data) Removed.
2325 (global var wr_current) Removed.
2326 (struct wr_aux_data) New structure.
2327 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2328 place of static vars, pass to create_case_source() and procedure()
2330 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2331 instead of matrix_data_pgm *.
2332 (wr_read_splits) Ditto.
2333 (wr_output_data) Ditto.
2334 (wr_read_rowtype) Ditto.
2335 (wr_read_factors) Ditto.
2336 (wr_read_indeps) Ditto.
2338 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2340 Get rid of static vars in autorecode.c.
2342 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2343 `n_arc' to `spec_cnt'. All references updated.
2344 (static var v_src) Removed.
2345 (static var v_dest) Removed.
2346 (static var h_trns) Removed.
2347 (static var nv_src) Removed.
2348 (static var descend) Removed.
2349 (static var print) Removed.
2350 (enum direction) New enum.
2351 (struct autorecode_pgm) New structure.
2352 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2353 Move n_dest local var into struct autorecode_pgm for ease of
2354 clean-up. Use arc_free().
2355 (arc_free) New function.
2356 (recode) Modify to take struct autorecode_pgm * parameter instead
2357 of using statics. Let the caller clean up.
2358 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2359 instead of statics. Rearrange code a little.
2361 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2363 Get rid of static, global vars in recode.c. Remove debug code.
2365 * recode.c: (static var head) Removed.
2366 (global var v) Removed.
2367 (global var nv) Removed.
2368 (cmd_recode) New local variables head, v, nv. Initialize and free
2369 v. Don't call debug_print().
2370 [DEBUGGING] (dump_dest) Removed.
2371 [DEBUGGING] (debug_print) Removed.
2373 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2375 Get rid of static vars in expr-opt.c.
2377 * expr-opt.c: (static var e) Removed.
2378 (static var nop) Removed.
2379 (static var mop) Removed.
2380 (static var ndbl) Removed.
2381 (static var mdbl) Removed.
2382 (static var nstr) Removed.
2383 (static var mstr) Removed.
2384 (static var nvars) Removed.
2385 (static var mvars) Removed.
2386 (struct expr_dump_state) New structure.
2387 (dump_expression) Use new struct expr_dump_state instead of static
2388 vars and pass to functions we call.
2389 (dump_node) Use struct expr_dump_state * parameter.
2391 (emit_num_con) Ditto.
2392 (emit_str_con) Ditto.
2395 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2397 Get rid of static var in COUNT.
2399 * count.c: (static var head) Move into cmd_count().
2400 (cmd_count) [DEBUGGING] Don't call debug_print.
2401 [DEBUGGING] (debug_print) Removed.
2403 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2405 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2407 * val-labs.c: (static var v) Removed.
2408 (static var nv) Removed.
2409 [DEBUGGING] (debug_print) Removed.
2410 (verify_val_labs) Add struct variable **, int parameters.
2411 (get_label) Ditto. Improve error messages, streamline.
2412 (erase_labels) New function for erasing value labels, taking over
2413 part of verify_val_labs()'s function.
2416 (cmd_value_labels) No need to call init() or done() anymore.
2417 (cmd_add_value_labels) Ditto.
2418 (do_value_labels) Add vars, var_cnt local variables. Clean up
2419 after them internally. Call erase_labels() if we should. Don't
2422 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2424 Get rid of static vars in MATCH FILES.
2426 * get.c: (static var mtf_head) Removed.
2427 (static var mtf_tail) Removed.
2428 (static var mtf_by) Removed.
2429 (static var mtf_n_by) Removed.
2430 (static var mtf_master) Removed.
2431 (static var mtf_seq_num) Removed.
2432 (static var mtf_seq_nums) Removed.
2433 (static var mtf_sink) Removed.
2434 (static var mtf_case) Removed.
2435 (struct mtf_proc) New structure.
2436 (cmd_match_files) Use struct mtf_proc instead of static vars.
2437 (mtf_processing_finish) Ditto.
2439 (mtf_delete_file_in_place) Ditto.
2440 (mtf_read_nonactive_records) Ditto.
2441 (mtf_compare_BY_values) Ditto.
2442 (mtf_processing) Ditto.
2443 (mtf_merge_dictionary) Ditto.
2445 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2447 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2449 * dictionary.c: (dict_rename_var) Add assertion.
2450 (dict_contains_var) Check by index instead of name.
2452 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2454 Get rid of compaction_necessary, compaction_nval, compaction_case.
2455 Redo VFM interface. Replace disk_sink and memory_sink by
2456 storage_sink, disk_source and memory_source by storage_source.
2458 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2462 (struct write_case_data) Remove `begin_func', `end_func',
2463 `func_aux' members. Add `aux', `trns_case', `sink_case',
2464 `cases_written', `cases_analyzed' members.
2465 (global var compaction_necessary) Make static.
2466 (global var compaction_nval) Removed.
2467 (global var compaction_case) Removed.
2468 (static var case_count) Removed.
2469 (struct procedure_aux_data) Removed.
2470 (struct split_aux_data) Removed.
2471 (procedure) Remove begin_func, end_func parameters. Rewrite.
2472 (static var not_canceled) Removed.
2473 (process_active_file) Removed.
2474 (process_active_file_write_case) Removed.
2475 (process_active_file_output_case) Removed.
2476 (prepare_for_writing) Moved into open_active_file().
2477 (arrange_compaction) Ditto.
2479 (open_active_file) Rewrote.
2480 (write_case) New function.
2481 [DEBUGGING] (index_to_varname) Removed.
2482 (execute_transformations) New function.
2483 (exclude_this_case) Renamed filter_case(), changed interface.
2484 (clear_case) Added struct ccase * parameter to interface.
2485 (close_active_file) Added struct write_case_data * parameter,
2487 (disk_sink_create) Removed.
2488 (disk_sink_destroy) Removed.
2489 (disk_sink_make_source) Removed.
2490 (disk_sink_write) Removed.
2491 (disk_source_count) Removed.
2492 (disk_source_destroy) Removed.
2493 (disk_source_read) Removed.
2494 (global var disk_sink_class) Removed.
2495 (global var disk_source_class) Removed.
2496 (global var memory_sink_class) Removed.
2497 (global var memory_source_class) Removed.
2498 (memory_sink_create) Removed.
2499 (memory_sink_destroy) Removed.
2500 (memory_sink_make_source) Removed.
2501 (memory_sink_write) Removed.
2502 (memory_source_count) Removed.
2503 (memory_source_destroy) Removed.
2504 (memory_source_get_cases) Removed.
2505 (memory_source_read) Removed.
2506 (memory_source_set_cases) Removed.
2507 (struct disk_stream_info) Removed.
2508 (struct memory_sink_info) Removed.
2509 (struct memory_source_info) Removed.
2510 (write_active_file_to_disk) Removed.
2511 (destroy_storage_stream_info) New function.
2512 (global var null_sink_class) New var.
2513 (global var storage_sink_class) New var.
2514 (global var storage_source_class) New var.
2515 (open_storage_file) New function.
2516 (storage_sink_destroy) New function.
2517 (storage_sink_make_source) New function.
2518 (storage_sink_open) New function.
2519 (storage_sink_write) New function.
2520 (storage_source_count) New function.
2521 (storage_source_destroy) New function.
2522 (storage_source_get_cases) New function.
2523 (storage_source_on_disk) New function.
2524 (storage_source_read) New function.
2525 (storage_source_set_cases) New function.
2526 (storage_source_to_disk) New function.
2527 (storage_to_disk) New function.
2528 (struct storage_stream_info) New structure.
2529 (write_storage_file) New function.
2530 (procedure_write_case) Removed.
2531 (create_case_source) Add `struct dictionary *' parameter, all
2533 (create_case_sink) Ditto.
2534 (free_case_sink) New function.
2535 (struct split_aux_data) New structure.
2536 (procedure_with_splits) New function implementing what procedure()
2538 (SPLIT_FILE_proc_func) Removed.
2539 (procedure_with_splits_callback) New function.
2540 (equal_splits) New function.
2542 * aggregate.c: Pass around a struct instead of using statics.
2543 (static var outfile) Remove.
2544 (enum type) Give it tag `missing_treatment'.
2545 (static var missing) Remove.
2546 (static var sort) Remove.
2547 (static var agr_first) Remove.
2548 (static var agr_next) Remove.
2549 (static var case_count) Remove.
2550 (static var prev_case) Remove.
2551 (static var buf64_1xx) Remove.
2552 (static var buf_1xx) Remove.
2553 (struct agr_proc) New structure incorporating the above.
2554 (cmd_aggregate) Use new struct. Clean up error handling using
2555 agr_destroy(). Completely rewrite actual implementation of
2557 (create_sysfile) Add struct agr_proc * parameter, modify
2559 (parse_aggregate_functions) Ditto.
2560 (free_aggregate_functions) Ditto. Rename agr_destroy().
2561 (aggregate_single_case) Add struct agr_proc * parameter, modify
2563 (accumulate_aggregate_info) Ditto.
2564 (dump_aggregate_info) Ditto.
2565 (initialize_aggregate_info) Ditto.
2566 (agr_00x_trns_proc) Removed.
2567 (agr_00x_end_func) Removed.
2568 (agr_10x_trns_proc) Removed.
2569 (agr_10x_trns_free) Removed.
2570 (agr_10x_end_func) Removed.
2571 (agr_11x_read) Removed.
2572 (agr_11x_finish) Removed.
2573 [DEBUGGING] (debug_print) Removed.
2574 (write_case_to_sfm) Add struct agr_proc * parameter, modify
2576 (agr_to_active_file) New function.
2577 (presorted_agr_to_sysfile) New function.
2578 (sort_agr_to_sysfile) New function.
2580 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
2582 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
2584 * descript.q: (cmd_descriptives) Ditto.
2586 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
2587 to new procedure() interface.
2589 * command.c: (cmd_execute) Adapt to new procedure() interface.
2591 * dictionary.c: (dict_compact_values) Also delete scratch
2593 (dict_get_compacted_value_cnt) New function.
2594 (dict_get_compacted_idx_to_fv) New function.
2596 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
2597 (cmd_flip) Adapt to new procedure() interface.
2598 (flip_sink_write) Use sink->idx_to_fv.
2600 * frequencies.q: (internal_cmd_frequencies) Use
2601 procedure_with_splits().
2603 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
2604 (static var mtf_sink) New static var.
2605 (static var mtf_case) New static var.
2606 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
2607 we actually implement the matching.
2608 (mtf_delete_file_in_place) Use mtf_case.
2609 (mtf_processing) Use mtf_case and mtf_sink.
2610 (cmd_export) Adapt to new procedure() interface.
2612 * levene.c: (levene) Use procedure_with_splits().
2614 * list.q: (cmd_list) Use procedure_with_splits().
2616 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
2617 procedure() interface.
2618 (read_matrices_with_rowtype) Ditto.
2620 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
2621 TEMPORARY. Adapt to new procedure() interface.
2623 * rename-vars.c: Warn about and cancel TEMPORARY.
2625 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
2626 (sort_cases) Use dict_get_compacted_value_cnt() instead of
2627 compaction_nval. Adapt to new procedure() interface. Use
2628 storage_source_to_disk().
2629 (do_internal_sort) Don't try to dump the cases to memory.
2630 (compare_case_lists) Pass null idx_to_fv.
2631 (struct initial_run_state) Add `idx_to_fv' member. Remove
2633 (write_initial_runs) Don't initialize irs->case_size. Adapt to
2634 new procedure() interface. Reset irs->idx_to_fv after calling
2636 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
2637 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
2639 (destroy_initial_run_state) Don't dereference irs after freeing
2641 (allocate_cases) Don't calculate case_size locally.
2642 (compare_record) Add idx_to_fv parameter.
2643 (compare_record_run) Change parameter from struct sort_cases_pgm *
2644 to struct initial_run_state *. Pass irs->idx_to_fv to
2646 (compare_record_run) Third parameter now a struct
2647 initial_run_state *.
2648 (output_record) No need for out_case anymore. Pass irs, not
2649 struct sort_cases_pgm to pop_heap(). Use case_size from struct
2651 (merge) Use case_size from struct sort_cases_pgm.
2652 (merge_once) Use case_size from struct sort_cases_pgm.
2653 Pass null pointer to compare_record() as idx_to_fv.
2654 (global var sort_sink_class) Make static.
2656 * t-test.q: (cmd_t_test) Use procedure_with_splits().
2658 * temporary.c: Remove debugging crap.
2660 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
2662 * t-test.q, levene.c: Fixed up the handling of MISSING values
2665 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
2667 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
2670 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
2672 Change explicit variable name checks into use of
2673 dict_class_from_id().
2675 * dictionary.c: (dict_create_var) Change explicit variable name
2676 check into use of dict_class_from_id().
2678 * get.c: (trim_dictionary) Ditto.
2680 * sel-if.c: (cmd_filter) Ditto.
2682 * sysfile-info.c: (cmd_display) Ditto.
2684 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
2686 * vfm.c: (arrange_compaction) Ditto.
2688 * weight.c: (cmd_weight) Ditto.
2690 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
2692 * temporary.c: (cmd_temporary) When TEMPORARY was the first
2693 transformation following the input program, if any, for some
2694 reason we special-cased f_trns. That's just wrong. It should
2695 always be set to n_trns.
2697 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
2699 * format.c: (parse_format_specifier_name) Fix brown-bag bug
2700 introduced in last check-in.
2702 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
2704 * format.c: (global array translate_fmt[]) Removed.
2705 (translate_fmt) New function as replacement.
2706 (parse_format_specifier_name) Rewrite.
2708 * pfm-read.c: (convert_format) Use translate_fmt() instead of
2711 * sfm-read.c: (parse_format_spec) Ditto.
2713 * postscript.c: (text) Fix handling of fonts with missing
2716 * sort.c: (struct external_sort) Add temp_name member.
2717 (destroy_external_sort) Free temp_dir, temp_name members.
2718 (init_external_sort) Allocate temp_name.
2719 (get_temp_file_name) Change prototype.
2720 (open_temp_file) Deal with change to get_temp_file_name().
2721 (close_temp_file) Ditto.
2722 (remove_temp_file) Ditto.
2723 (write_temp_file) Ditto.
2724 (read_temp_file) Ditto.
2725 (sort_sink_destroy) Removed.
2726 (sort_sink_class) Change destroy member to null.
2728 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2730 Eliminate temp_case.
2732 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2733 anymore. Use agr_11x_finish().
2734 (aggregate_single_case) Make first param const.
2735 (accumulate_aggregate_info) Ditto.
2736 (agr_00x_end_func) Use compaction_case, not temp_case.
2737 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2739 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2740 (cmd_data_list) Initialize case_size.
2741 (read_from_data_list_fixed) Add struct ccase * param, use instead
2743 (read_from_data_list_free) Ditto.
2744 (read_from_data_list_list) Ditto.
2745 (read_one_case) Rename data_list_trns_proc(), all references
2746 updated. Add argument in calling above functions. Use c
2747 argument instead of temp_case.
2748 (destroy_dls) Rename data_list_trns_free(), all references
2751 * expr-evl.c: (expr_evaluate) Make second parameter const.
2753 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2754 (cmd_end_file_type) Initialize `case_size'.
2755 (file_type_source_read) Add struct ccase * parameter. Use instead
2758 * flip.c: Rewritten.
2760 * get.c: (struct get_pgm) New structure to keep track of
2762 (cmd_get) Initialize case_size.
2764 (get_source) Deal with struct get_pgm.
2765 (get_source_read) Add struct ccase * parameter, use instead of
2767 (import_source_read) Ditto.
2769 * get.c: Use a null pointer instead of temp_case to represent the
2770 "current case" in a struct mtf_file's input member.
2771 (mtf_processing_finish) Pass null to mtf_processing(), not
2773 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2774 (mtf_compare_BY_values) Add extra arg, use instead of null input
2776 (mtf_processing) Use c parameter instead of temp_case. Pass
2777 compaction_case to process_active_file_output_case().
2779 * glob.c: (global variable temp_case) Removed.
2781 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2782 (cmd_input_program) Initialize case_size. Set
2783 vfm_source->value_cnt.
2784 (init_case) Add struct ccase * parameter, use instead of
2787 (input_program_source_read) Ditto.
2789 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2790 (dump_cell_content) Ditto.
2791 (nr_output_data) Ditto.
2792 (read_matrices_without_rowtype) Ditto.
2793 (matrix_data_read_with_rowtype) Ditto.
2794 (wr_read_splits) Ditto.
2795 (wr_output_data) Ditto.
2797 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2799 * sort.c: (sort_cases) Initialize scp->case_size.
2800 (struct external_sort) Remove `case_size' member.
2801 (write_initial_runs) Only call vfm_sink->class_destroy if
2803 (struct sort_source_aux) New structure.
2804 (sort_source_read_helper) New function.
2805 (sort_source_read) Use sort_source_read_helper().
2806 (read_sort_output) Change interface to be more reasonable.
2807 (read_internal_sort_output) Ditto.
2808 (read_external_sort_output) Ditto.
2810 * vars-prs.c: (dict_class_to_name) Pass return value through
2813 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2814 (procedure) Initialize trns_case.
2815 (procedure) Pass trns_case to vfm_source->class->read().
2817 (process_active_file) Start using struct procedure_aux_data.
2818 (process_active_file_write_case) Pass trns_case to
2819 transformations, lag_case(), clear_case().
2820 (process_active_file_output_case) Add struct ccase * parameter.
2821 (create_trns_case) New function.
2822 (make_temp_case) Removed.
2823 (vector_initialization) Removed.
2824 (close_active_file) Only call make_source if non-null, otherwise
2825 set vfm_source to null pointer. Don't free temp_case.
2826 (disk_source_read) Add struct ccase * parameter, use instead of
2828 (memory_source_read) Ditto.
2829 (lag_case) Add const struct ccase * member.
2830 (procedure_write_case) Use trns_case instead of temp_case.
2831 (clear_case) Add struct ccase * member, use instead of temp_case.
2832 (exclude_this_case) Ditto.
2833 (create_case_source) Add struct dictionary * parameter, use to
2834 initialize source->value_cnt.
2836 * vfm.h: (struct case_source) Add `value_cnt' member.
2837 (struct case_source_class) Add struct ccase * parameter to `read'
2838 member function pointer.
2839 (struct case_sink_class) Make struct ccase * parameter const in
2840 `write' member function pointer.
2842 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2844 Fix a lot of "possibly uninitialized variable" warnings. Some of
2845 them are even real bugs. A few of them make me wonder how the
2848 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2850 * ascii.c: (output_lines) Add default case to switch.
2852 * crosstabs.q: Remove static variable `expected' and all
2854 (display_crosstabulation) Always calculate expected value.
2856 (output_pivot_table) Initialize `cmp'.
2857 (display_crosstabulation) New variable `last_row', which is
2860 * data-in.c: (parse_numeric) Always initialize sign. How did this
2863 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2864 Always set info.ofs. (How did this work?!)
2866 * expr-opt.c: (optimize_tree) Always initialize `m'.
2867 (evaluate_tree) Always initialize `c'. (How did this work?)
2869 * frequencies.q: (frq_custom_variables) Always initialize min,
2871 (frq_custom_grouped) Always initialize `dl'.
2873 * groff-font.c: (groff_read_font) Always initialize char_set.
2875 * matrix-data.c: (nr_output_data) Initialize `split'.
2876 (wr_read_splits) Remove shadowing split_cnt declaration.
2877 (wr_output_data) Initialize `split'.
2879 * output.c: (tokener) Skip add character on syntax error.
2881 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2883 * postscript.c: (read_ps_encodings) Use line.string instead of
2885 (write_text) Add default case to switch.
2886 (text) Always initialize multiple variables. Fix bug with
2889 * print.c: (fixed_parse_fortran) Initialize head.
2890 (alloc_line) Add default case to switch.
2892 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2893 (recode_trns_proc) Move variable declaration inward. Add default
2896 * sfm-read.c: (read_header) Initialize skip_amt.
2898 * sysfile-info.c: (display_variables) Always initialize pc.
2900 * vars-prs.c: Initialized `included'.
2902 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2904 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2905 Just use signal() instead.
2907 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2909 Get rid of vfm_sink_info and vfm_source_info.
2911 * aggregate.c: (agr_00x_end_func) Don't increment
2912 sfm_sink_info.ncases.
2914 * sort.c: (do_internal_sort) Get case count from
2915 vfm_source->class->count().
2916 (struct external_sort) Add `case_size' member.
2917 (do_external_sort) Initialize case_size.
2918 (struct initial_run_state) Add `case_size' member.
2919 (write_initial_runs) Initialize case_size.
2920 (sort_sink_write) Use case_size.
2921 (read_external_sort_output) Use case_size. Get case_cnt from
2924 * vfm.c: (struct write_case_data) Add underscores to existing arg
2925 names, all references updated. Renamed `aux' as `func_aux', all
2926 references updated. Added new `aux' member.
2927 (global var vfm_source_info) Removed.
2928 (global var vfm_sink_info) Removed.
2929 (struct procedure_aux_data) New.
2930 (struct split_aux_data) New.
2931 (procedure) Use `aux' fields for procedure_aux_data,
2933 (process_active_file_write_case) Pass case_count + 1 to
2934 transformation procedures, exclude_this_case().
2935 (process_active_file_output_case) Don't increment
2936 vfm_sink_info.ncases.
2937 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2938 to send data to disk early.
2939 (make_temp_case) Don't use vfm_sink_info.case_size.
2940 (close_active_file) Don't initialize vfm_source_info.
2941 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2942 (disk_sink_create) Initialize and/or update disk_stream_info.
2943 (disk_sink_write) Ditto.
2944 (disk_sink_destroy) Ditto.
2945 (disk_sink_make_source) Ditto.
2946 (disk_source_read) Ditto.
2947 (disk_source_destroy) Ditto.
2948 (global var disk_source_class) Add disk_source_count().
2949 (disk_source_count) New function.
2950 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2951 (struct memory_source_info) Ditto.
2952 (memory_sink_create) Deal with case_cnt, case_size.
2953 (memory_sink_write) Ditto.
2954 (memory_sink_make_source) Ditto.
2955 (memory_source_read) Ditto.
2956 (memory_source_count) New function.
2957 (memory_source_class) Add memory_source_count().
2958 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2959 proc_aux->cases_written, and pass it to transformation procedures
2960 and exclude_this_case ().
2961 (exclude_this_case) Add case_num parameter. Pass it to
2963 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2966 * vfm.h: (struct case_source_class) Add `count' member.
2968 * vfmP.h: (struct stream_info) Removed.
2969 (global variable vfm_source_info) Removed.
2970 (global variable vfm_sink_info) Removed.
2972 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2974 * var.h: (typedef trns_proc_func) New typedef.
2975 (trns_free_func) New typedef.
2976 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2977 to type trns_free_func. This only changes the actual type of
2978 trns_proc_func, adding a `case_num' parameter. Updated all
2979 implementations to use the typedefs instead.
2981 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2982 (compute_num_vec) Ditto.
2983 (compute_str) Ditto.
2984 (compute_str_vec) Ditto.
2986 * do-if.c: (do_if_trns_proc) Ditto.
2988 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2991 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2992 pass to transformation functions.
2993 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2995 * loop.c: (loop_1_trns_proc) Ditto.
2996 (loop_2_trns_proc) Ditto.
2997 (loop_3_trns_proc) Ditto.
2999 * print.c: (print_space_trns_proc) Ditto.
3001 * sel-if.c: (select_if_proc) Ditto.
3003 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3005 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3006 destroying hash table.
3008 * glob.c: (read_active_file) Variable not referenced, removed.
3009 (cancel_input_pgm) Ditto.
3011 * levene.c: Add #include <stdlib.h> needed to call free().
3013 * aggregate.c: (parse_aggregate_functions) Make `function'
3016 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3018 Start working to eliminate VFM dependence on static variables.
3020 * command.c: (cmd_parse) Use case_source_is_class().
3022 * data-list.c: Rewrite to eliminate use of static variables.
3024 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3026 * file-handle.q: (fh_handle_name) Make parameter const.
3028 * file-type.c: Rewrite to eliminate use of static variables.
3030 * flip.c: Rewrite to eliminate use of static variables.
3032 * format.c: (get_format_var_width) New function.
3034 * get.c: Eliminate use of static variables.
3036 * inpt-pgm.c: Eliminate use of static variables.
3038 * matrix-data.c: Eliminate use of static variables.
3040 * set.q: (set_max_workspace) New variable.
3041 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3043 * var.h: (struct case_list) Move here from vfmP.h.
3045 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3047 * vfm.c: (vfm_source) Change type from struct case_stream to
3049 (vfm_sink) Change type from struct case_stream to struct
3051 (static var paging) Rename workspace_overflow, all references
3053 (procedure) Use new class structures.
3054 (process_active_file) Ditto.
3055 (process_active_file_write_case) Ditto.
3056 (prepare_for_writing) Use set_max_workspace. Use new class
3058 (close_active_file) Use new class structures. Free old sink.
3059 (global var disk_source_file) Removed.
3060 (global var disk_sink_file) Removed.
3061 (disk_stream_init) Removed.
3062 (disk_stream_read) Removed.
3063 (disk_stream_write) Removed.
3064 (disk_stream_mode) Removed.
3065 (disk_stream_destroy_source) Removed.
3066 (disk_stream_destroy_sink) Removed.
3067 (global var vfm_disk_stream) Removed.
3068 (disk_sink_create) New function.
3069 (disk_sink_write) New function.
3070 (disk_sink_destroy) New function.
3071 (disk_sink_make_source) New function.
3072 (disk_sink_class) New static var.
3073 (disk_source_read) New function.
3074 (disk_source_destroy) New function.
3075 (global var vfm_source_class) New var.
3076 (global var memory_source_cases) Removed.
3077 (global var memory_sink_cases) Removed.
3078 (global var memory_sink_max_cases) Removed.
3079 (struct memory_sink_info) New struct.
3080 (memory_stream_init) Removed.
3081 (memory_stream_read) Removed.
3082 (memory_stream_write) Removed.
3083 (memory_stream_mode) Removed.
3084 (memory_stream_destroy_source) Removed.
3085 (memory_stream_destroy_sink) Removed.
3086 (global var vfm_memory_stream) Removed.
3087 (page_to_disk) Renamed write_active_file_to_disk().
3088 (memory_sink_create) New function.
3089 (memory_sink_write) New function.
3090 (memory_sink_destroy) New function.
3091 (memory_sink_make_source) New function.
3092 (memory_sink_class) New static var.
3093 (memory_source_read) New function.
3094 (memory_source_destroy) New function.
3095 (memory_source_get_cases) New function.
3096 (memory_source_set_cases) New function.
3097 (global var vfm_source_class) New var.
3098 (procedure_write_case) Use new class structures.
3099 (create_case_source) New function.
3100 (case_source_is_complex) New function.
3101 (case_source_is_class) New function.
3102 (create_case_sink) New function.
3104 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3105 (global variable reinit_blanks) Not used, removed.
3106 (global variable init_zero) Not used, removed.
3107 (global variable init_blanks) Not used, removed.
3108 (struct case_source) New struct.
3109 (struct case_source_class) New struct.
3110 (struct case_sink) New struct.
3111 (struct case_sink_class) New struct.
3112 (struct case_stream) Removed.
3114 * vfmP.h: (struct case_list) Moved to var.h.
3116 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3118 * algorithm.c: (count_equal) New function.
3119 (count_if) New function.
3120 (unique) Add assertions.
3121 (partition) Add assertions.
3122 (is_partitioned) New function.
3123 (copy_if) Add assertions.
3124 (remove_equal) Add assertions.
3125 (lexicographical_compare) Rename lexicographical_compare_3way.
3126 (sort) Add assertions. Rephrase some code.
3127 (is_sorted) New function.
3129 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3133 * sort.c: Completely rewrite.
3135 * sort.h: Expose interface via struct sort_cases_pgm, not via
3138 * aggregate.c: (sort) New static var.
3139 (cmd_aggregate) Use sort.
3140 (create_sysfile) Ditto.
3141 (aggregate_single_case) Ditto.
3142 (dump_aggregate_info) Ditto.
3143 (agr_00x_end_func) Ditto.
3144 (debug_print) Ditto.
3146 * var.h: (enum SRT_ASCEND) Removed.
3147 (enum SRT_DESCEND) Removed.
3148 (struct sort_cases_proc) Removed.
3149 (struct variable) Remove p.srt member.
3151 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3153 Get rid of the old, crappy heap structure and replace it by a new,
3154 shiny, C++ STL-like heap structure.
3156 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3158 * algorithm.c: (push_heap) New function.
3169 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3171 Increase warning level.
3173 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3175 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3177 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3179 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3181 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3182 around by previous change log entry.
3184 * compute.c: (lvalue_finalize) Remove workaround from previous
3187 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3189 * compute.c: Fixed a bug where the Format was not getting set for
3190 computed variables (thus causing a crash when SAVEing).
3192 * Added a test to stop this bug ever coming back
3194 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3196 Got rid of approx.h. In general, replaced all references to
3197 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3200 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3202 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3203 test for mag < EPSILON.
3205 * misc.h: Add definition of EPSILON.
3207 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3209 * vfm.c: (procedure) Add check to prevent recursive call.
3211 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3213 * Moved the declarations relating to values to their own header file
3216 * Added levene.c and levene.h
3218 * vars-atr.c: Changed the signature of compare_values to
3219 take const * arguments.
3221 * t-test.q: Changed the structure of struct t_test_proc
3222 variables now contain their own group statistics information.
3223 Eventually, t_test_proc might get renamed, because it'd be
3224 applicable to other commands too.
3226 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3228 * data-out.c: Clean up. Changed interface of convert_*() to take
3229 either a `double' or a `const char *' instead of a `const union
3230 value *'. Update all implementations of those interfaces.
3231 (data_out) Use switch statements instead of a table.
3232 (convert_AHEX) Rewrite.
3234 * format.h: Update comment.
3236 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3238 * q2c.c: (dump_header) Add an Emacs header line to output files
3239 that makes generated .c files read-only by default, to make it
3240 difficult to accidentally change generated files.
3242 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3244 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3245 not bogus a->v.c <=> b->v.c pointer compare.
3246 (compare_freq_alpha_a) Ditto.
3247 (compare_freq_numeric_d) Ditto.
3248 (compare_freq_alpha_d) Ditto.
3250 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3252 Changed data_out() to store string data directly into a `union
3253 value''s s member, not indirectly into c.
3255 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3257 (table_value_missing) Ditto.
3258 (float_M_suffix) Ditto.
3259 (format_short) New function.
3261 * data-in.h: (data_in_finite_line) Remove inline definition.
3263 * data-list.c: (destroy_dls_var_spec) New function.
3264 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3265 (data_list_source_destroy_source) Avoid cast.
3266 (struct repeating_data_trns) New field `id_value'. Update
3268 (cmd_repeating_data) Initialize id_value. Use new
3269 repeating_data_trns_free() for freeing REPEATING DATA
3271 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3272 (repeating_data_trns_free) New function.
3274 * data-out.c: (data_out) Change return type to `void' by replacing
3275 error returns by writing a message into the output buffer.
3276 (convert_A) Read from v->s instead of v->c.
3277 (convert_AHEX) Ditto.
3279 * expr-evl.c: Update comment.
3280 (expr_evaluate) Add assertion in OP_STRING case.
3282 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3284 * list.q: (list_cases) Update for new data_out() semantics.
3286 * print.c: (print_trns_proc) Ditto.
3288 * tab.c: (tab_value) Ditto.
3289 (tab_float) Avoid stupid cast.
3291 * var.h: Update comments.
3292 (macro MAX_STRING) New macro.
3293 (macro MAX_ELEMS_PER_VALUE) New macro.
3295 * vars-atr.c: (compare_values) New function.
3297 * vfm.c: (dump_splits) Update for new data_out() semantics.
3299 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3301 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3303 (struct crosstab) Rename v[] to vars[]. All references updated.
3304 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3305 same time, which caused the hash value to depend only on a single
3306 value, not all of the variables' values.
3308 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3310 Clean up struct dictionary's value_cnt usage.
3312 * dictionary.c: Add a function comment to each function.
3313 (struct dictionary) Rename value_cnt to next_value_idx, which more
3314 accurately reflects its meaning. All references updated.
3315 (dict_rename_vars) Add assertion.
3316 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3318 (dict_get_case_size) New function.
3320 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3322 * get.c: (mtf_read_nonactive_records) Ditto.
3324 * sort.c: (allocate_cases) Ditto.
3325 (write_initial_runs) Ditto.
3329 * vfm.c: (prepare_for_writing) Ditto.
3333 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3335 Make vfm.c slightly less grotesque.
3337 * vfm.c: (filter_var) Removed.
3338 (filter_index) Removed.
3339 (FILTERED macro) Removed.
3340 (exclude_this_case) New function.
3341 (process_active_file_write_case) Use exclude_this_case() instead
3342 of FILTERED and inline tests.
3343 (procedure_write_case) Ditto.
3344 (setup_filter) Removed.
3345 (open_active_file) Don't call setup_filter().
3346 (close_active_file) Call dict_get_filter() instead of checking
3349 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3351 * var.h: (struct variable) Update comments.
3353 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3355 New functions dict_create_var_assert(), dict_lookup_var_assert().
3356 Converted several dict_*_var()/assert pairs into a single
3357 dict_*_var_assert().
3359 * dictionary.c: (dict_create_var_assert) New function.
3360 (dict_lookup_var_assert) New function.
3362 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3364 Got rid of "struct long_vec", envector(), devector(), etc. Added
3365 two members `init', `reinit' to struct variable as a substitute.
3367 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3373 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3376 * autorecode.c: (cmd_autorecode) destvars don't need init.
3378 * compute.c: (lvalue_finalize) Set reinit.
3380 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3381 (dump_fmt_list) Ditto.
3384 * descript.q: (run_z_pass) Don't need init for z-scores.
3386 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3388 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3390 * glob.c: (init_glob) Remove vec_init() calls.
3392 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3394 * loop.c: (internal_cmd_loop) Don't need to call envector().
3396 * numeric.c: (cmd_numeric) Ditto.
3398 (cmd_leave) Ditto. Set `init', `reinit' members.
3400 * recode.c: (cmd_recode) Don't need to call envector().
3402 * repeat.c: (internal_cmd_do_repeat) Ditto.
3404 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3405 (force_create_variable) Removed prototype.
3406 (force_dup_variable) Ditto.
3408 * vector.c: (cmd_vector) Don't need to call envector().
3410 * vfm.c: (reinit_sysmis) Removed.
3411 (reinit_blanks) Removed.
3412 (init_zero) Removed.
3413 (init_blanks) Removed.
3414 (process_active_file_write_case) No need to deal with vectors.
3415 Call clear_temp_case().
3416 (vector_initialization) Rewrite to use `init', `reinit'.
3417 (close_active_file) No need to call vec_clear().
3418 (procedure_write_case) Call clear_temp_case().
3419 (clear_temp_case) New function.
3421 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3423 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3426 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3428 Add auxiliary argument to procedure() interface. Associated small
3429 clean-ups of vfm interface.
3431 * Updated every caller of procedure() and process_active_file() to
3432 reflect modified interface. Simple, ordinary changes not listed
3435 * Updated every function that implements struct case_stream's
3436 `read' function to take a write_case_func and a write_case_data.
3437 Also updated every caller of write_case() to instead call them
3438 through these arguments. In some cases this meant that the extra
3439 args had to be threaded through a couple of extra levels. This
3440 wasn't difficult or interesting so the details won't be given.
3442 * data-list.c: (struct repeating_data_trns) Add members
3443 `write_case', `wc_data' as kluge.
3444 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3446 (repeating_data_set_write_case) New function.
3448 * data-list.h: New file to declare repeating_data_trns_proc() and
3449 repeating_data_set_write_case().
3451 * inpt-pgm.c: (input_program_source_read) Call
3452 repeating_data_set_write_case() for all the REPEATING DATA
3453 transformations, so that they know where to send their cases.
3454 It's a big kluge. Also kluge in END CASE.
3455 (end_case_trns_proc) Never called anymore, but we still need it,
3458 * sort.c: (read_sort_output) Update to match struct case_stream
3461 * vfm.c: (struct write_case_data) New structure.
3462 (proc_func) Removed.
3463 (virt_proc_func) Removed.
3464 (begin_func) Removed.
3465 (virt_begin_func) Removed.
3467 (write_case) Removed.
3468 (procedure) Added an auxiliary parameter to each function pointer
3469 argument's prototype. Added an auxiliary data parameter.
3471 (process_active_file) Ditto.
3472 (process_active_file_write_case) Pass aux data along.
3473 (close_active_file) Ditto.
3474 (procedure_write_case) Ditto.
3475 (SPLIT_FILE_procfunc) Ditto.
3477 * vfm.h: (typedef write_case_data) New.
3478 (typedef write_case_func) New.
3479 (struct case_stream) Add parameters to `read' member prototype.
3481 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3483 * t-test.q: Added calculations for independent samples. (But no Levene
3486 * Makefile.am: Moved q_sources_c into own variable
3488 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3490 Miscellaneous cleanups.
3492 * Change unused to UNUSED in many source files to reflect modified
3493 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3494 __CYGWIN32__, __unix__, and unix not to assume that they're
3495 defined to a nonzero value. Change use of __attribute__ to use
3496 NO_RETURN or PRINTF_FORMAT instead.
3498 * alloc.h: Move definitions for local_alloc(), local_free() here
3499 from ../pref.h.orig and simplify.
3501 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3502 use a pool allocator unconditionally.
3503 (CHECK_STRING_SPACE) Removed.
3504 (ALLOC_STRING_SPACE) Removed.
3505 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
3508 * expr-opt.c: (dump_expression) Allocate string pool.
3510 * expr-prs.c: (expr_free) Free string pool.
3512 * pool.c: (pool_destroy) This pool must be removed from its
3513 parent's list of gizmos, not from its own. Use free_all_gizmos().
3514 (pool_clear) New function.
3515 (free_all_gizmos) New function.
3516 (pool_alloc) Use space in empty block after this one if any.
3517 (pool_release) Only empty out blocks, don't actually free() them.
3519 * print.c: Get rid of PAGED_STACK special case by always
3520 dynamically allocating line buffers.
3521 (struct print_trns) Always include the `line' member.
3522 (internal_cmd_print) Always initialize the `line' member.
3523 (alloc_line) Always allocate memory for `line'.
3524 (print_trns_proc) Always initialize buf from `line' member.
3525 (print_trns_free) Always free `line' memory.
3527 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
3530 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
3532 * flip.c: Fixed crash from FLIP when a numeric variable is
3533 specified on NEWNAMES and a large value is used, and a couple of
3534 other minor bugs besides.
3535 (struct varname) Make name a 9-character fixed-size array
3536 instead of a 1-character variable size array.
3537 (make_new_var) Allow digits in variable names.
3538 (flip_stream_write) Limit numeric values to 8 characters and
3539 format system missing and very large and small values more
3542 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3544 * command.c: Fixed test on command return status for the correct
3545 value, which had been causing a crash under certain invalid input.
3547 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3549 * t-test.q: Added calculations for the one sample variant of the T-TEST
3551 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
3553 * tab.c: (render_strip) Fix bug that sometimes caused joined text
3554 in joined cells to be rendered outside box boundaries.
3556 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3558 * random.c (rng_create): Fixed seeding so that it gets reseeded after
3559 SET seed=xx has been called.
3561 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
3563 * random.c (rng_get_double): Fix always-returning-zero bug in my
3564 preferred way, and at the same time make sure rounding doesn't
3567 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
3569 * html.c: (change_attributes) Dead code, removed.
3570 (escape_string) Eliminate code to call change_attributes() that
3571 never actually called it.
3572 (output_tab_table) Get rid of dependence on tab_hit
3573 and struct tab_joined_cell's hit member, which are abominations.
3575 * tab.c: (tab_output_text) Don't call
3576 d->class->text_set_font_by_name if it's a null pointer.
3577 (macro UNROLL_LOOP) Eliminate.
3578 (macro UNROLL_3_LOOPS) Eliminate.
3579 (tabi_render) Rewrite not to use the above macros.
3581 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
3583 Start working on a new output driver system, one that doesn't suck
3584 so much, by adding a "device-independent" output driver. The idea
3585 is to write out only a single output stream, then use separate
3586 processes to translate them into whatever formats we want. This
3587 is similar to how "groff" works with its various output drivers
3588 (grops, grotty, grodvi, ...).
3590 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
3592 * list.q: (write_all_headers) Stub out devind class.
3594 (determine_layout) Ditto.
3597 * output.c: (outp_init) Add devind class.
3599 * devind.c: New file.
3601 * devind.h: New file.
3603 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
3605 * frequencies.q: (hash_value_alpha) Fixed up the previous change
3606 to use the proper string length.
3608 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3610 * Fixed bug where FREQ would crash on alpha values
3612 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
3614 * Removed bletcherous alloca() workarounds for AIX from top of
3615 many files. AIX can use the alternative alloca() implementation
3618 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
3620 * ascii.c: (ascii_option) Fix implementation of headers option.
3622 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
3624 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
3625 multiple blank lines into one.
3626 (struct ascii_driver_ext) Add squeeze_blank_lines option.
3627 (ascii_preopen_driver) Initialize squeeze_blank_lines.
3628 (static var option_tab) Add squeeze entry.
3629 (ascii_option) Set squeeze_blank_lines.
3630 (output_lines) Implement squeezing blank lines.
3632 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
3634 * Removed redundant code from output.h
3636 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
3638 Dictionary classes: each variable is "ordinary", "system", or
3641 * var.h: (enum dict_class) New enum.
3643 * vars-prs.c: (dict_class_from_id) New function.
3644 (dict_class_to_name) New function.
3646 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
3648 * var.h: (struct freq_tab_set) Removed (not used).
3650 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
3652 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
3654 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
3656 * stats.c: (hypercube) Rename pow4(). All references updated.
3658 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
3660 * rename-vars.c: (cmd_rename_variables) Rewritten.
3661 (compare_name) Removed.
3663 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
3665 var_set feature, and code taking advantage of it.
3667 * crosstabs.q: (static var var_dict) Removed.
3668 (static var variables) New variable.
3669 (static var variables_cnt) New variable.
3670 (cmd_crosstabs) Free variables instead of var_dict.
3671 (internal_cmd_crosstabs) Initialize and use variables,
3672 variables_cnt instead of var_dict.
3673 (free_var_dict) Removed.
3674 (crs_custom_tables) Use var_set instead of a copied dictionary.
3675 (crs_custom_variables) Set up variables, variables_cnt instead of
3677 [DEBUGGING] (debug_print) Ditto.
3679 * means.q: (mns_custom_tables) Use var_set instead of a copied
3682 * vars-prs.c: (parse_vs_variable) New function.
3683 (parse_dict_variable) Rewritten.
3684 (parse_variable) Rewritten.
3685 (parse_variables) Renamed parse_var_set_vars(), rewritten.
3686 (parse_variables) New function in terms of parse_var_set_vars().
3687 Now requires its first argument to be non-null. All references
3688 that passed a null pointer updated to pass default_dict instead.
3689 (macro id_dict) Removed.
3690 (parse_DATA_LIST_vars) Add assertions.
3691 (parse_mixed_vars) Ditto.
3692 (struct var_set) New structure.
3693 (var_set_get_cnt) New function.
3694 (var_set_get_var) New function.
3695 (var_set_lookup_var) New function.
3696 (var_set_destroy) New function.
3697 (dict_var_set_get_cnt) New function.
3698 (dict_var_set_get_var) New function.
3699 (dict_var_set_lookup_var) New function.
3700 (dict_var_set_destroy) New function.
3701 (var_set_create_from_dict) New function.
3702 (struct array_var_set) New structure.
3703 (array_var_set_get_cnt) New function.
3704 (array_var_set_get_var) New function.
3705 (array_var_set_lookup_var) New function.
3706 (array_var_set_destroy) New function.
3707 (var_set_create_from_array) New function.
3709 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
3710 instead of parse_variables(NULL, ...) in output code.
3712 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
3714 Change inp_init from a 2-bit vector to an ordinary array.
3715 Initialize it all in cmd_end_input_program() instead of in
3718 * inpt-pgm.c: (enum value_init_type) New enum.
3719 (global var inp_init) Change to `enum value_init_type *', make
3721 (inp_init_size) Removed.
3722 (inp_nval) Change to `size_t', make static.
3723 (cmd_input_program) Don't initialize inp_init or inp_init_size.
3724 (cmd_end_input_program) Initialize inp_init, inp_nval.
3725 (init_case) Rewrite.
3726 (clear_case) Rewrite.
3728 * inpt-pgm.h: Removed.
3730 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3732 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3733 Colin Plumb hash. It is simpler and should better resist
3735 (hsh_hash_string) Ditto.
3737 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3739 * get.c: (export_write_case_func) Remove debug printing code.
3741 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3743 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3745 (save_write_case_func) Use &trns->h instead of cast.
3746 (cmd_export) Use &t->h instead of cast.
3748 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3750 Moved vectors into the dictionary.
3752 * var.h: (struct vector) Moved here from vector.h. `index' member
3753 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3756 * vector.h: Removed.
3758 * vector.c: (global var vec) Removed.
3759 (global var nvec) Removed.
3760 (cmd_vector) Rewritten.
3761 (find_vector) Removed.
3763 * dictionary.c: (dict_create_vector) New function.
3764 (dict_get_vector) New function, replaces reading global vec[]
3766 (dict_get_vector_cnt) New function, replaces reading global nvec
3768 (dict_lookup_vector) New function, replaces find_vector().
3769 (dict_clear_vectors) New function.
3771 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3773 Start to move away from `struct variable' p `union' member to void
3776 * var.h: (struct variable) Add `aux' member.
3778 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3780 Get rid of struct variable `foo' member.
3782 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3784 (frq_custom_variables) Ditto.
3785 (frq_custom_grouped) Ditto.
3787 * get.c: (struct save_trns) Change `var' member from `int *' to
3788 `struct variable **'.
3789 (cmd_save_internal) Use aux instead of foo.
3790 (save_trns_proc) Use revised `var' member.
3791 (static var mtf_seq_no) Renamed mtf_seq_num.
3792 (static var mtf_seq_nums) New static var.
3793 (cmd_match_files) Initialize mtf_seq_nums.
3794 (mtf_free) Free mtf_seq_nums.
3795 (mtf_processing) Use mtf_seq_nums instead of foo.
3796 (mtf_merge_dictionary) No need to initialize mv->foo.
3797 (cmd_export) Use aux instead of foo. Use revised `var' member.
3798 (mns_custom_tables) Don't use foo to check for duplicates, that's
3799 what PV_NO_DUPLICATE is for.
3801 * var.h: (struct variable) Remove `foo' member.
3802 (struct frequencies_proc) New member.
3804 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3806 Clean up COMPUTE and IF.
3808 * compute.c: More or less rewrite the darn thing.
3809 (struct compute_trns) Rename and reorder and add and delete
3811 (cmd_compute) Rewrite.
3812 (compute_num) Make conditional on test expression. Now used for
3813 both COMPUTE and IF.
3814 (compute_num_vec) Ditto.
3815 (compute_str) Ditto.
3816 (compute_str_vec) Ditto.
3819 (if_num_vec) Removed.
3821 (if_str_vec) Removed.
3822 (parse_target_expression) Renamed parse_rvalue_expression(),
3824 (new_trns) Renamed compute_trns_create(), rewritten.
3825 (delete_trns) Removed.
3826 (free_trns) Renamed compute_trns_free(), rewritten.
3827 (struct lvalue) New structure.
3828 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3829 (lvalue_get_type) New function.
3830 (lvalue_is_vector) New function.
3831 (lvalue_finalize) New function.
3832 (lvalue_destroy) New function.
3834 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3836 * command.def: Disallow MODIFY VARS in input mode, so that
3837 variables can't get dropped and confuse cmd_end_input_program()'s
3838 attempt to fill inp_init[].
3840 * modify-vars.c: (static var forward_positional_ordering) New
3842 (struct var_modification) Entirely changed.
3843 (rearrange_dict) Interface changed, rewritten.
3844 (cmd_modify_vars) Deal with modified struct var_modification, much
3846 (struct var_renaming) New structure.
3847 (compare_var_renaming_by_new_name) New function.
3848 (validate_var_modification) New function.
3850 * var.h: (struct modify_vars_proc) Removed.
3851 (struct variable) Removed member p.mfv.
3853 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3855 Make EVALUATE a valid command whether we're debugging or not, so
3856 that `make check' can succeed regardless of whether debugging is
3859 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3861 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3863 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3865 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3866 statement by a simple if test.
3868 * dfm.c: (dfm_get_record) Add assertion.
3870 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3872 For each file x.c, move #include "x.h" to the very top of the
3873 include list, to catch x.h failing to include the proper headers.
3875 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3877 * algorithm.c: (find) New function.
3878 (remove_equal) New function.
3879 (set_difference) New function.
3880 (adjacent_find_equal) New function.
3881 [TEST_UNIQUE] Removed test case.
3882 (copy_if) Find end test.
3884 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3886 * dictionary.c: (dict_get_case_weight) New convenience function.
3888 * aggregate.c: (accumulate_aggregate_info) Use
3889 dict_get_case_weight().
3891 * frequencies.q: (calc_general) Ditto.
3892 (calc_integer) Ditto.
3895 * t-test.q: (groups_calc) Ditto.
3898 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3900 * glob.c: (global var default_dict) Change from `struct
3901 dictionary' to `struct dictionary *'. All references changed.
3902 (init_glob) Initialize default_dict with dict_create().
3904 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3906 struct dictionary now made opaque. All related functions:
3908 * get.c: (rename_variables) Removed.
3909 (dict_delete_run) Removed.
3911 * temporary.c: (copy_variable) Removed.
3912 (new_dictionary) Removed.
3913 (save_dictionary) Removed.
3914 (restore_dictionary) Removed.
3915 (free_dictionary) Removed.
3917 * vars-atr.c: (clear_default_dict) Removed.
3918 (find_variable) Removed.
3919 (find_dict_variable) Removed.
3920 (create_variable) Removed.
3921 (delete_variable) Removed.
3922 (common_init_stuff) Removed.
3923 (init_variable) Removed. Updating of inp_init moved into
3924 cmd_end_input_program().
3925 (replace_variable) Removed.
3926 (rename_variable) Removed.
3927 (clear_variable) Removed.
3928 (dup_variable) Removed.
3930 * vars-prs.c: (is_varname) Removed.
3931 (is_dict_varname) Removed.
3932 (fill_all_vars) Removed.
3934 * vector.c: (find_vector) Removed.
3936 * weight.c: (stop_weighting) Removed.
3938 * dictionary.c: New file.
3939 (dict_create) New, replaces new_dictionary().
3940 (dict_clone) New, replaces save_dictionary() and
3941 restore_dictionary().
3942 (dict_clear) New, replaces clear_default_dict().
3943 (dict_destroy) New, replaces free_dictionary().
3944 (dict_get_var_cnt) New function, replaces references to
3946 (dict_get_var) New function, replaces references to dict->var[i].
3947 (dict_get_vars) New function, replaces fill_all_vars().
3948 (dict_create_var) New, replaces create_variable(). Interface
3949 drops `type' parameter, using a zero `width' to designate numeric.
3950 (dict_clone_var) New, replaces dup_variable().
3951 (dict_rename_var) New, replaces rename_variable().
3952 (dict_lookup_var) New, replaces find_variable(),
3953 find_dict_variable(), is_varname().
3954 (dict_contains_var) New function.
3955 (compare_variable_dblptrs) New function.
3956 (dict_delete_var) New function, replaces clear_variable().
3957 (dict_delete_vars) New function, replaces dict_delete_run().
3958 (dict_reorder_vars) New function.
3959 (dict_rename_vars) New function, replaces rename_variables().
3960 (dict_get_weight) New function, replaces reading dict->weight_var.
3961 (dict_set_weight) New function, replaces writing dict->weight_var
3962 or calling stop_weight(dict).
3963 (dict_get_filter) New function, replaces reading dict->filter_var.
3964 (dict_set_filter) New function, replaces writing dict->filter_var.
3965 (dict_get_case_limit) New function, replaces reading dict->N.
3966 (dict_set_case_limit) New function, replaces writing dict->N.
3967 (dict_get_value_cnt) New function, replaces reading dict->nval.
3968 (dict_compact_values) New function, replaces a loop that was
3969 replicated in several places.
3970 (dict_get_split_vars) New function, replaces reading dict->splits.
3971 (dict_get_split_cnt) New function, replaces reading
3973 (dict_set_split_vars) New function, replaces writing dict->splits.
3974 (dict_get_label) New function, replaces reading dict->label.
3975 (dict_set_label) New function, replaces writing dict->label.
3976 (dict_get_documents) New function, replaces reading
3978 (dict_set_documents) New function, replaces writing
3981 All references to above functions updated.
3983 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3984 old dictionary to new by hand, because dict_create() can't do it
3985 itself. Use dict_set_documents(), dict_set_split_vars().
3987 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3988 calling dict_destroy().
3990 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3992 (fixed_parse_compatible) Some slightly nontrivial changes for
3994 (dump_fmt_list) Ditto.
3997 * file-type.c: (create_col_var) Ditto.
3999 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4000 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4001 (rename_variables) Use dict_rename_vars().
4002 (mtf_merge_dictionary) Use dict_get_documents(),
4003 dict_set_documents(), dict_compact_values().
4005 * pfm-read.c: (read_variables) Deal with changes to weighting.
4007 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4008 is_varname() in output code.
4010 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4011 other dictionary functions.
4013 * title.c: (add_document_line) Use dict_get_documents(),
4014 dict_set_documents().
4016 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4017 reset default_handle by hand. dict_clear() will clear vectors so
4018 there's no need for that by hand.
4020 * vfm.c: (close_active_file) Move call to finish_compaction()
4021 earlier, so that we can do the compaction as a single step using
4022 dict_compact_values(). Use dict_clear_vectors().
4023 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4025 Some functions don't have replacements:
4027 * vars-atr.c: (force_create_variable) Removed. All references
4028 updated to dict_create_var() followed by an assertion.
4029 (force_dup_variable) Removed. All references updated to
4030 dict_clone_var() followed by an assertion.
4032 * weight.c: (update_weighting) Removed. No longer necessary, so
4033 all references removed.
4035 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4039 * aggregate.c: Eliminate separation of weighted and unweighted
4040 case. It made the code too obscure and I doubt it was actually
4041 faster. Instead, all code uses the "weighted" code, because
4042 that's a generalization of the "unweighted" code.
4045 (parse_aggregate_functions) No need to set FWEIGHT.
4046 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4047 (dump_aggregate_info) Ditto.
4048 (initialize_aggregate_info) No need for special plain_function
4049 that gets rid of FWEIGHT option.
4051 * aggregate.c: Get rid of approximations.
4052 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4054 (aggregate_single_case) Don't use approx_ne().
4056 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4058 * ascii.c (ascii_line_width): Dead code, removed.
4060 * postscript.c (ps_line_width): Ditto.
4062 * q2c.c (xrealloc): Ditto.
4064 * count.c (internal_cmd_count): Ditto.
4066 * means.q (validate_dependent_endpoint): Ditto.
4068 * set.q: (cmd_gset) Ditto.
4070 * weight.c: [0] (weight_trns_proc) Ditto.
4072 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4074 Make the code -Wmissing-prototypes clean.
4076 * Makefile.am (version.c): Add #include "version.h".
4078 * ascii.c: (ascii_open_global) Make static.
4079 (ascii_close_page) Ditto.
4080 (ascii_font_sizes) Ditto.
4081 (ascii_postopen_driver) Ditto.
4082 (ascii_close_driver) Ditto.
4083 (ascii_option) Ditto.
4084 (ascii_open_page) Ditto.
4085 (ascii_line_horz) Ditto.
4086 (ascii_line_vert) Ditto.
4087 (ascii_line_intersection) Ditto.
4089 (ascii_polyline_begin) Ditto.
4090 (ascii_polyline_point) Ditto.
4091 (ascii_polyline_end) Ditto.
4092 (ascii_text_set_font_by_name) Ditto.
4093 (ascii_text_set_font_by_position) Ditto.
4094 (ascii_text_set_font_by_family) Ditto.
4095 (ascii_text_get_font_name) Ditto.
4096 (ascii_text_get_font_family) Ditto.
4097 (ascii_text_set_size) Ditto.
4098 (ascii_text_get_size) Ditto.
4099 (ascii_text_metrics) Ditto.
4100 (ascii_text_draw) Ditto.
4101 (ascii_close_page) Ditto.
4103 * cmdline.h: New header for parse_command_line(). Used where
4106 * command.c: Move prototypes for cmd_*() functions to command.h.
4108 * command.h: Prototypes for cmd_*() functions moved here from
4111 * crosstabs.q: (gamma_int) Ditto.
4113 * file-handle.h: Add fh_init_files() prototype.
4115 * getline.c: (welcome) Ditto.
4117 * glob.h: New header for init_glob(). Used where appropriate.
4119 * hash.c: (comparison_helper) Ditto.
4121 * html.c: (html_open_global) Ditto.
4122 (html_close_global) Ditto.
4123 (html_preopen_driver) Ditto.
4124 (html_postopen_driver) Ditto.
4125 (html_close_driver) Ditto.
4126 (html_option) Ditto.
4127 (html_open_page) Ditto.
4128 (html_close_page) Ditto.
4129 (html_submit) Ditto.
4131 * inpt-pgm.c: (input_program_source_read) Ditto.
4133 * output.c: (find_defn_value) Ditto.
4134 (destroy_list) Ditto.
4136 * pfm-read.c: (read_int) Ditto.
4138 * postscript.c: (ps_open_global) Ditto.
4139 (ps_close_global) Ditto.
4140 (ps_font_sizes) Ditto.
4141 (ps_preopen_driver) Ditto.
4142 (ps_postopen_driver) Ditto.
4143 (ps_close_driver) Ditto.
4145 (ps_open_page) Ditto.
4146 (ps_close_page) Ditto.
4147 (ps_line_horz) Ditto.
4148 (ps_line_vert) Ditto.
4149 (ps_line_intersection) Ditto.
4151 (ps_polyline_begin) Ditto.
4152 (ps_polyline_point) Ditto.
4153 (ps_polyline_end) Ditto.
4154 (ps_text_set_font_by_name) Ditto.
4155 (ps_text_set_font_by_position) Ditto.
4156 (ps_text_set_font_family) Ditto.
4157 (ps_text_get_font_name) Ditto.
4158 (ps_text_get_font_family) Ditto.
4159 (ps_text_set_size) Ditto.
4160 (ps_text_get_size) Ditto.
4161 (ps_text_metrics) Ditto.
4162 (ps_text_draw) Ditto.
4164 * q2c.c: (finish_up) Ditto.
4173 (find_symbol) Ditto.
4176 (force_string) Ditto.
4178 (match_token) Ditto.
4181 (parse_setting) Ditto.
4182 (parse_specifier) Ditto.
4183 (parse_specifiers) Ditto.
4184 (parse_subcommand) Ditto.
4185 (dump_specifier_vars) Ditto.
4187 (make_identifier) Ditto.
4188 (dump_declarations) Ditto.
4189 (dump_specifier_init) Ditto.
4190 (dump_vars_init) Ditto.
4192 (dump_specifier_parse) Ditto.
4193 (dump_subcommand) Ditto.
4194 (dump_parser) Ditto.
4195 (dump_header) Ditto.
4197 (recognize_directive) Ditto.
4199 * recode.c: (string_to_long) Ditto.
4201 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4203 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4206 * sort.c: (sort_stream_read) Ditto.
4207 (sort_stream_mode) Ditto.
4209 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4211 * algorithm.c (binary_search): Fix comparison.
4213 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4215 * algorithm.c: (binary_search) Fix assertion.
4217 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4219 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4221 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4223 * sort.c: (compare_case_lists) Rewrite.
4225 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4227 * quicksort.c: Removed (not used).
4229 * quicksort.h: Removed (not used).
4231 * sort.c: Removed blp_quicksort() prototype.
4233 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4235 * postscript.c: (int_2_compare) Rewrite.
4236 (compare_line) Rewrite.
4238 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4240 * matrix-data.c (compare_factors) Use lexicographical_compare()
4242 (compare_doubles) New function.
4244 * algorithm.c: (lexicographical_compare) New algorithm.
4246 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4248 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4250 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4252 * expr-prs.c: (cmp_func) Removed.
4253 (parse_function) Use binary_search() algorithm.
4254 (compare_functions) New function.
4255 (init_func_tab) Use sort() algorithm.
4257 * algorithm.c: (binary_search) New algorithm.
4259 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4261 * descript.q: (display) Use sort() algorithm instead of qsort().
4262 (compare_func) Removed.
4263 (descriptives_compare_variables) New function.
4265 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4267 Get rid of AVL trees. Hashes are more appropriate for everything
4270 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4276 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4278 Much code can be clarified by using C++ STL-like algorithms. Not
4279 all uses of these algorithms are listed below, only the ones where
4280 the change to an algorithm was the only change of interest.
4282 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4284 * algorithm.c: New file.
4286 * algorithm.h: New file.
4288 * modify-vars.c: (static var forward) Removed.
4289 (static var positional) Removed.
4290 (compare_variables) Removed.
4291 (struct ordering) New.
4292 (cmd_modify_vars) Use sort() algorithm.
4293 (compare_variables_given_ordering) New function.
4294 (rearrange_dict) Use sort() algorithm.
4296 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4297 (cmp_var_by_name) Removed.
4299 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4301 Make file handles use a hash table.
4303 * file-handle.q: (files) Change to hash table, make static.
4304 (cmd_file_handle) Use hash table functions.
4305 (fh_get_handle_by_filename) Ditto.
4306 (fh_get_handle_by_name) Ditto.
4307 (hash_file_handle) New function.
4308 (cmp_file_handle) Rewrite.
4309 (fh_init_files) Use hash table functions.
4311 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4313 Clean up FREQUENCIES.
4315 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4317 * frequencies.q: Remove a lot of old #if'd out code at the end.
4318 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4319 or calc_weight(). Initialize percentile_values.
4320 (calc) New function based on calc_weight() from frequencies.g.
4321 (precalc) Use hash functions.
4322 (static var comparison_func) Removed.
4323 (static var comparison_param) Removed.
4324 (comparison_helper) Removed.
4325 (get_freq_comparator) New function.
4326 (not_missing) New function.
4328 (postprocess_freq_tab) Use hash table functions, algorithms,
4329 get_freq_comparator(). Rewrite.
4330 (cleanup_freq_tab) Rephrase.
4331 (add_percentile) Clean up spacing.
4332 (hash_value_numeric) New function.
4333 (hash_value_alpha) New function.
4334 (compare_value_numeric_a) Rewrite.
4335 (compare_value_alpha_a) Rewrite.
4336 (compare_value_numeric_d) Rewrite.
4337 (compare_value_alpha_d) Rewrite.
4338 (compare_freq_numeric_a) Rewrite.
4339 (compare_freq_alpha_a) Rewrite.
4340 (compare_freq_numeric_d) Rewrite.
4341 (compare_freq_alpha_d) Rewrite.
4342 (calc_stats) Clean up mode, percentiles, max.
4343 (dump_statistics) Clean up spacing.
4345 * frequencies.g: Removed.
4347 * var.h: (struct freq_tab) Change `data' to hash table.
4349 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4351 * file-handle.h: Remove declaration of global variable `files',
4352 which wasn't used anywhere.
4354 * postscript.c: (add_encoding) Remove superfluous cast.
4357 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4360 * temporary.c: [0] (display_tree) Removed.
4362 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4364 Implement a new random number generator based on the alleged RC4
4367 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4370 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4371 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4373 (static var V[]) Removed.
4374 (static var Y) Removed.
4375 (static var X2) Removed.
4376 (setup_randomize) Removed.
4378 (rand_uniform) Removed.
4379 (rand_normal) Removed.
4380 (struct rng) New structure.
4381 (rng_create) New function.
4382 (rng_destroy) New function.
4383 (swap_byte) New static function.
4384 (rng_seed) New function.
4385 (rng_get_bytes) New function.
4386 (rng_get_int) New function.
4387 (rng_get_unsigned) New function.
4388 (rng_get_double) New function.
4389 (rng_get_double_normal) New function.
4390 (pspp_rng) New function.
4392 * random.h: Sync up to random.c.
4394 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4395 fraction of UINT_MAX, not 65536.
4396 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4399 * vfm.c: (open_active_file) No need to call setup_randomize() any
4402 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4404 Change dictionary name indexes to use hash tables instead of AVL
4407 * crosstabs.q: (free_var_dict) Use hash tables.
4408 (crs_custom_tables) Ditto.
4409 (calc_general) Ditto.
4410 (compare_table_entry) Rewrite.
4411 (enum_var_values) Reorder parameters. All references updated.
4414 * get.c: (rename_variable) Use hash tables.
4415 (mtf_merge_dictionary) Ditto.
4417 * glob.c: (init_glob) Use hash tables.
4418 (cmp_variable) Removed.
4420 * means.q: (mns_custom_tables) Use hash tables.
4422 * modify-vars.c: (rearrange_dict) Use hash tables.
4424 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4426 * sfm-read.c: (read_header) Use hash tables.
4427 (read_variables) Ditto.
4429 * temporary.c: (new_dictionary) Use hash tables.
4430 (save_dictionary) Ditto.
4431 (restore_dictionary) Ditto.
4433 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4434 hash table `name_tab'.
4436 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4437 [DEBUGGING] (dump_var_tree) Removed.
4438 (find_variable) Use hash tables.
4439 (find_dict_variable) Ditto.
4440 (common_init_stuff) Ditto.
4441 (rename_variable) Ditto.
4442 (clear_variable) Ditto. Also, remove debug code.
4443 (dup_variable) Use hash tables.
4445 * vars-prs.c: (fill_all_vars) Use hash tables.
4446 (is_dict_varname) Ditto.
4447 (parse_dict_variable) Ditto.
4449 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4451 Change value labels to use hash tables instead of AVL trees, and
4452 change value labels into an ADT.
4454 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4456 * value-labels.c: New file.
4458 * value-labels.h: New file.
4460 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4461 Get rid of a stupid use of goto.
4463 * autorecode.c: (compare_alpha_value) Rewrite.
4464 (hash_alpha_value) Ditto.
4465 (compare_numeric_value) Rewrite.
4466 (hash_numeric_value) Ditto.
4468 * frequencies.q: (dump_full) Use value label ADT.
4470 * pfm-read.c: (read_value_label) Use value label ADT.
4472 * pfm-write.c: (write_value_labels) Use value label ADT.
4474 * sfm-read.c: (read_variables) Use value label ADT.
4475 (read_value_labels) Rewrite.
4477 * sfm-write.c: (write_value_labels) Rewrite.
4479 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4480 (display_variables) Ditto.
4481 (describe_variable) Ditto.
4483 * t-test.q: (print_t_groups) Use value label ADT.
4485 * temporary.c: (copy_variable) Use value label ADT.
4486 (free_dictionary) Ditto.
4488 * val-labs.c: (verify_val_labs) Use value label ADT.
4490 (debug_print) Ditto.
4491 (val_lab_cmp) Removed.
4492 (inc_ref_count) Removed.
4493 (copy_value_labels) Removed.
4495 * var.h: (struct value_label) Removed.
4496 (struct variable) Change AVL tree `val_lab' into hash table
4499 * vars-atr.c: (init_variable) Use value label ADT.
4500 (clear_variable) Ditto.
4501 (free_value_label) Removed.
4502 (free_val_lab) Removed.
4503 (get_val_lab) Removed.
4504 (compare_variables) New function.
4505 (hash_variable) New function.
4507 * vfm.c: (dump_splits) Use value label ADT.
4509 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
4511 Add to the hash table interface.
4513 * hash.c: (hsh_hash_bytes) Add assertion.
4514 (hsh_hash_string) Ditto.
4518 (hsh_create) Ditto. Also make minimum `size'.
4519 (hsh_destroy) Rephrase.
4520 (sort_nulls_last) Removed.
4521 (not_null) New function.
4523 (comparison_helper) Ditto.
4524 (hsh_sort) Rewritten.
4525 (hsh_data_copy) New function.
4526 (hsh_sort_copy) Ditto.
4528 (hsh_replace) Ditto.
4529 (hsh_hash_double) Ditto.
4530 (hsh_delete) Fix stupid bug.
4532 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4533 * added a calculation of the mode to FREQUENCIES
4535 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4537 * moved (un)defs of DEBUGGING to config.h
4539 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
4541 * groff-font.c: (add_kern) Fix indentation.
4542 (add_kern) Use & instead of % to take power-of-2 modulus.
4543 (font_get_kern_adjust) Likewise.
4545 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
4547 * autorecode.c: (recode) Replace stupid use of memcpy() by
4549 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
4550 (hash_numeric_value) Ditto.
4551 (autorecode_proc_func) pool_strdup() was wrong here because the
4552 source string was not null-terminated. Use new pool_strndup()
4555 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
4556 use of hsh_iterator_init().
4558 * data-in.c: (parse_N) Initialize i->v->f.
4560 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
4563 * groff-font.c: Use power-of-2 hash table sizes, not prime.
4564 (groff_read_font) Don't call hsh_next_prime(). Don't call
4566 (static var hash) Remove `size_p', `max_used' members.
4567 (font_char_name_to_index) Don't call hsh_next_prime(). Use
4568 hsh_hash_string() instead of hashpjw(), & instead of %.
4569 (default_font) Don't call hsh_next_prime().
4571 * pool.c: (pool_strndup) New function.
4572 (pool_strdup) Reimplement in terms of pool_strndup.
4574 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
4576 (hash_ps_encoding) Use hsh_hash_string().
4577 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
4578 (hash_filename2font) Use hsh_hash_string().
4580 * som.c: Add #include <stdlib.h>.
4582 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
4583 (by destroying its pool).
4585 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
4587 Miscellaneous hash table code cleanup:
4589 * hash.h: (struct hsh_table) Moved into hash.c.
4590 (hsh_count) Ditto, and transformed into function.
4591 (hsh_compare_func) New typedef, used for defining otherwise-long
4592 function types here and in hash.c
4593 (hsh_hash_func) Ditto.
4594 (hsh_free_func) Ditto.
4596 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
4597 `table' to `entries'. Removed `mp'. All references updated.
4598 (hsh_clear) Don't shrink entries array; if the hash was this big
4599 once, it probably will be again.
4600 (hsh_rehash) Made static.
4601 (force_hsh_insert) Renamed hsh_force_insert.
4602 (force_hsh_find) Renamed hsh_force_find.
4604 Made hash table sizes powers of 2, because that's fine with any
4605 reasonable hash function and because taking a power-of-2 modulus
4606 is faster than any other:
4608 (hsh_prime_tab) Removed;
4609 (hsh_next_prime) Ditto.
4610 (next_power_of_2) New function.
4611 (hsh_create) Use next_power_of_2.
4612 (hsh_rehash) Use & instead of %.
4614 Cleaned up hsh_sort:
4616 (internal_comparison_fn) Removed.
4617 (sort_nulls_last) New function.
4618 (hsh_sort) Removed second parameter, switched to using the new
4619 quicksort() function from quicksort.h to avoid using nasty need
4620 for static variables with qsort(). All references updated.
4622 Changed the hash functions offered, because there are better hash
4623 functions than the ones we had, and cleaned up the names to boot:
4625 * hash.c: (hashpjw_d) Removed.
4627 (hsh_hash_bytes) New function.
4628 (hsh_hash_string) New function.
4629 (hsh_hash_int) New function.
4631 Improved the hash table iteration interface:
4633 * hash.h: (hsh_iterator_init) Removed.
4634 (struct hsh_iterator) Removed `init' member, change `next' to
4637 * hash.c: (hsh_foreach) Removed. All references updated to use
4638 hsh_first/hsh_next instead.
4639 (hsh_first) New function. Notably, unlike hsh_foreach() it does
4640 not treat a null pointer as an empty hash table.
4641 (hsh_next) New function.
4643 Made deletion possible, though slow:
4645 * hash.c: (locate_matching_entry) New function.
4646 (hsh_find) Use locate_matching_entry().
4647 (hsh_delete) New function also using locate_matching_entry().
4648 (hsh_force_delete) New function.
4650 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
4652 * quicksort.c: New file implementing a sort routine with a
4653 interface better than qsort() because it passes a user-provided
4654 parameter to the sort routine.
4656 * Makefile.am: Add quicksort.c, quicksort.h.
4658 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
4660 * All source files: Get rid of nasty special cases for Checker,
4661 which is pretty obsolete now.
4663 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
4665 * Fixed a bug apparent when using the FREQUENCIES command with the
4666 html driver. The html driver was incorrectly trying to display
4669 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
4671 * Makefile.am: Reorganized. Put locale dir in version.c instead
4672 of passing it to each compile command. Only put local gmp libs in
4673 LD_ADD if not installed on system. Remove `boast' target.
4675 * All source files: struct and union typedefs eliminated.
4676 `sizeof type' replaced by `sizeof object' where practical. Moved
4677 `unused' qualifiers from start to end of declarations for gcc
4678 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
4679 assertions on pointers strictly compliant. Removed _ prefixes on
4680 some function parameter names.
4682 * alloc.c: New source file, containing these external linkage
4683 functions removed from common.c: xmalloc, xcalloc, xrealloc,
4690 * ascii.c: Migrated from arenas to pools.
4691 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
4692 c_string to len_string. All references changed.
4693 (ascii_option) Signature changed to comply to new output.c
4695 (count_fancy_chars) Removed.
4696 (delineate) Removed support for rich text.
4697 (ascii_text_metrics) Ditto.
4699 (output_shorts) Change `box', `off', `on' from c_string to
4700 len_string. Change `remaining' from int to size_t.
4701 (ascii_close_page) Make page numbering less haphazard.
4703 * autorecode.c: Migrate from arenas to pools.
4705 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
4707 * bitvector.h: New file containing these macros from misc.h:
4708 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
4710 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
4711 word[3]. ncmd removed.
4712 (var empty_string) Removed.
4713 (var cmd_table) Declaration updated.
4714 (var cmdtab) Removed.
4715 (cmp_command) Removed.
4716 (split_words) Rewritten to use strtok_r().
4717 (init_cmd_parser) Renamed cmd_init(). Rewritten.
4718 (find_command) Removed.
4719 (FILE_TYPE_okay) Rewritten.
4720 (cmd_parse) Rewritten. Semantics of the return value of command
4721 handlers has changed: they must now return one of the new CMD_*
4722 enumerals, rather than a magic value. This meant that all
4723 commands had to be modified, and they were.
4724 (figure_out_command) New function.
4726 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
4727 #defines for INIT, INPU, etc.
4729 * command.h: New CMD_* enum series.
4730 (cur_proc) Make const char *, not char *.
4731 (cmd_init) Prototype.
4734 * common.c: Removed.
4736 * common.h: Removed.
4738 * correlations.q: New file.
4740 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4742 (custom_tables) Renamed crs_custom_tables().
4743 (custom_variables) Renamed crs_custom_variables().
4744 (calc_integer) Add in some `const' qualifiers.
4745 (table_value_missing) Change from a_string to len_string.
4746 (float_M_suffix) Change from a_string to len_string.
4748 * data-in.c: Rewritten. All references to
4749 parse_string_as_format() changed to data_in().
4751 * data-in.h: New file.
4753 * data-list.c: Change DLS_* from #define's to enums. Move from
4754 rpd_msg() to tmsg().
4755 (RPD_ERR) New #define.
4756 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4758 (read_from_data_list_fixed) Change from old
4759 parse_string_as_format() to new data_in().
4760 (read_from_data_list_free) Ditto.
4761 (read_from_data_list_list) Ditto.
4762 (cmd_repeating_data) Modify approach to checking for end of
4765 (rpd_parse_record) Change from old parse_string_as_format() to new
4766 data_in(). Change from old convert_format_to_string() to new
4768 (read_one_set_of_repetitions) Change dfm_push_cust() to
4769 dfm_push(), pop_cust() to dfm_pop().
4771 * data-out.c: Rewritten. All references to
4772 convert_format_to_string() changed to data_out().
4774 * descript.q: Migrate to new q2c.
4775 (cmd_descriptives) Removed.
4776 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4777 (custom_variables) Renamed dsc_custom_variables().
4779 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4781 (open_file_r) Initialize h->where.line_number. Migrate to new
4783 (open_file_w) Initialize h->where.line_number.
4784 (read_record) Change from ext->ln to h->where.line_number.
4785 Migrate to struct string.
4786 (dfm_put_record) Rephrased.
4787 (dfm_push_cust) Renamed dfm_push(), rewritten.
4788 (dfm_pop) New function.
4790 * error.c: All references updated.
4791 (glob var error_count) Renamed err_err_count.
4792 (glob var warning_count) Renamed err_warning_count.
4793 (glob var error_already_flagged) Renamed err_already_flagged.
4794 (glob var verbosity) Renamed err_verbosity.
4795 (glob var cust_fn) Removed.
4796 (glob var cust_ln) Removed.
4797 (static var file_loc) New.
4798 (static var nfile_loc) New.
4799 (static var mfile_loc) New.
4800 (tmsg) New function.
4801 (push_cust) Removed.
4804 (static var terminating) Removed.
4805 (failure) Renamed err_failure().
4806 (hcf) Renamed err_hcf().
4807 (err_push_file_locator) New function.
4808 (err_pop_file_locator) New function.
4809 (err_location) New function.
4810 (check_error_count) Renamed err_check_count().
4811 (vmsg) Renamed err_vmsg(). Interface changed.
4812 (verbose_msg) Removed.
4813 (err_cond_fail) New function.
4814 (error_break) Renamed err_break().
4816 * error.h: All references updated.
4817 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4818 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4820 (struct file_locator) New.
4822 (macro verbose_msg) Removed.
4823 (macro cond_fail) Removed.
4825 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4827 * expr-prs.c: Reorganized. All references updated.
4828 (exprtypename) Renamed expr_type_name().
4829 (typename) Renamed type_name().
4830 (free_expression) Renamed expr_free().
4831 (parse_expression) Renamed expr_parse(). Uses new type_check()
4833 (init_functab) Renamed init_func_tab().
4834 (type_check) New function.
4835 (parse_or) Rewritten to use new allocate_nonterminal() and
4836 append_nonterminal_arg() functions.
4839 (parse_rel) Ditto. Also simplified logic.
4844 (SYSMIS_func) Ditto.
4845 (VALUE_func) Rephrased.
4846 (CONCAT_func) Fix memory leak by replacing free by free_node on
4848 (generic_str_func) Ditto.
4849 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4851 (allocate_nonterminal) New function.
4852 (append_nonterminal_arg) New function.
4853 (static func_tab[]) Now at file level.
4855 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4857 * expr.h: (enum series OP_*) Moved to exprP.h.
4858 (OP_* defines) Ditto.
4859 (struct op_desc) Ditto.
4860 (global ops[]) Ditto.
4861 (struct num_con_node) Ditto.
4862 (struct str_con_node) Ditto.
4863 (struct var_node) Ditto.
4864 (struct lag_node) Ditto.
4865 (struct casenum_node) Ditto.
4866 (struct nonterm_node) Ditto.
4867 (union any_node) Members renamed.
4868 (struct sys_node) Removed.
4869 (struct val_node) Removed.
4870 (operator typedef) Removed.
4871 (typedef exprtype) Removed.
4872 (enum series EX_*) Moved to exprP.h.
4873 (struct expression) Ditto. Also renamed a lot of the members.
4874 (PXP_* defines) Changed to enums.
4875 (free_node prototype) Moved to exprP.h.
4877 * file-handle.h: (struct file_handle) New member `where'.
4879 * file-handle.q: Migrated to new q2c format.
4880 (prepend_current_directory) Removed (dead code).
4881 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4882 (fh_get_handle_by_filename) Removed dead code.
4883 Set new `where' member.
4885 * file-type.c: (file_type_source_read) References to
4886 parse_string_as_format() changed to data_in().
4887 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4889 * filename.c: All references updated.
4890 (init_filename) Renamed fn_init().
4891 (expand_line) Removed.
4892 (macro EXPAND_LINE) Removed.
4893 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4894 of custom functions.
4895 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4896 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4897 (normalize_filename) Renamed fn_normalize().
4898 (search_path) Renamed fn_search_path(), rewritten.
4899 (prepend_dir) Renamed fn_prepend_dir().
4900 (blp_getenv) Renamed fn_getenv().
4901 (blp_dirname) Renamed fn_dirname().
4902 (fn_basename) New function, not used.
4903 (absolute_filename_p) Renamed fn_absolute_p().
4904 (is_special_filename) Renamed fn_special_p().
4905 (file_exists) Renamed fn_exists_p().
4906 (readlink_malloc) Renamed fn_readlink().
4907 (getenv_default) Renamed fn_getenv_default().
4908 (open_file) Renamed fn_open().
4909 (close_file) Renamed fn_close().
4910 (open_file_ext) Renamed fn_open_ext().
4911 (close_file_ext) Renamed fn_close_ext().
4913 * font.h: Migrate from arenas to pools.
4915 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4917 * frequencies.g: Migrate from arenas to pools.
4919 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4922 * getline.c: All references updated.
4923 (global getl_buf) Changed from char * to struct string.
4924 (static getl_include_path) Ditto.
4925 (global getl_buf_len) Removed.
4926 (global getl_buf_size) Removed.
4927 (getl_include_path) Deal with new getl_buf, getl_include_path.
4928 (getl_uninitialize) New function.
4929 (getl_get_current_directory) Rewritten.
4930 (getl_clear_include_path) Rewritten.
4931 (getl_add_include_dir) Rewritten.
4932 (getl_add_file) Assertion fixed.
4933 (getl_add_virtual_file) Change initial value of `remaining_loops'
4935 (welcome) Rewritten.
4936 (handle_line_buffer) Make static. Change logic to make
4937 getl_add_virtual_file() change sensible. Use ds_*() strings.
4938 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4939 (getl_close_file) Moved.
4940 (getl_location) New function.
4942 * getline.h: All references updated.
4943 (macro curln) Removed.
4944 (macro curfn) Removed.
4945 (macro am_interactive) Renamed getl_am_interactive.
4946 (macro am_reading_script) Renamed getl_reading_script.
4948 * glob.c: (global fmt_parse_ignore_error) Removed.
4949 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4950 systems that support it (C99). Turn off SET ECHO by default. No
4951 necessary julcal initialization anymore.
4953 * groff-font.c: Migrate from arenas to pools.
4954 (groff_read_font) Use err_push_file_locator().
4955 (groff_read_DESC) Ditto.
4956 (font_msg) Use tmsg().
4958 * hash.c: (hsh_sort) Fix debug code.
4959 [GLOBAL_DEBUGGING] Include stdio.h.
4961 * hash.h: (macro force_hsh_insert) Rephrase.
4963 * heap.c: Rewritten.
4965 * heap.h: Rewritten.
4967 * html.c: (html_option) Change from outp_value to struct string.
4968 (postopen) Change from curfn to getl_location().
4969 (escape_string) Remove rich-text code. Signature changed.
4970 (output_tab_table) Switch from a_string to struct len_string.
4971 Remove rich text support.
4973 * lexer.c: All references updated. Largely rewritten. Major
4974 changes listed below. Removed tagged quote support. Adapted to
4975 struct string tokstr.
4976 (global tokstr) Changed to struct string.
4977 (global tokstr_size) Removed.
4978 (global tokstr_len) Removed.
4980 (global tokint) Removed.
4981 (global toklongstr) Removed.
4982 (C* defines) Removed.
4983 (static tbl[]) Removed.
4984 (static id[]) Removed.
4985 (static une[]) Removed.
4986 (discard_line) Renamed lex_discard_line().
4987 (get_entire_line) Renamed lex_entire_line().
4988 (get_rest_of_line) Renamed lex_rest_of_line().
4989 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4990 (make_hexit) Removed.
4991 (syntax_error) Renamed lex_error(). Return value removed.
4992 (get_token_representation) Renamed lex_token_representation().
4993 (putback) Renamed lex_put_back().
4994 (putfwd) Renamed lex_put_forward().
4995 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4996 (set_prog) Renamed lex_set_prog().
4997 (init_lex) Renamed lex_init().
4998 (reset_eof) Renamed lex_reset_eof().
4999 (lookahead) Renamed lex_look_ahead().
5000 (check_id) Rewritten.
5001 (yylex) Renamed lex_get(), rewritten.
5002 (lex_end_of_command) New function. Many commands were rephrased
5004 (lex_integer_p) New function. Replaces compare of tokint against
5006 (lex_integer) New function. Replaces tokint.
5007 (match_tok) Renamed lex_match().
5008 (match_id) Renamed lex_match_id().
5009 (match_int) Renamed lex_match_int().
5010 (force_match_id) Renamed lex_force_match_id(), added return value.
5011 (force_match) Renamed lex_force_match(), added return value.
5012 (force_string) Renamed lex_force_string(), added return value.
5013 (force_int) Renamed lex_force_int(), added return value.
5014 (lex_id_match_len) New function.
5015 (id_match) Renamed lex_id_match(), rewritten.
5016 (get_line) Renamed lex_get_line().
5017 (preprocess_line) Renamed lex_preprocess_line().
5018 (tokname) Renamed lex_token_name().
5019 (bin_value_func) Removed.
5020 (oct_value_func) Removed.
5021 (hex_value_func) Removed.
5022 (unexpected_eof) New function.
5023 (convert_numeric_string_to_char_string) New function.
5024 (parse_string) Rewritten, signature changed.
5025 (add_tokstr_char) Removed.
5026 (add_tokstr_unsigned) Removed.
5027 (add_tokstr_string) Removed.
5028 (parse_tagged_quote) Removed.
5029 (skip_comment) Renamed lex_skip_comment().
5031 * lexer.h: All references updated.
5032 (macro is_id1) Renamed CHAR_IS_ID1.
5033 (macro is_idn) Renamed CHAR_IS_IDN.
5034 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5035 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5036 (macro get_token) Removed.
5037 (macro id_match) Removed.
5038 (macro force_match_id) Removed.
5039 (macro force_match) Removed.
5040 (macro force_string) Removed.
5041 (macro force_int) Removed.
5042 (macro force_num) Removed.
5043 (macro force_id) Removed.
5045 * lexerP.h: Removed.
5047 * list.q: Migrated to new q2c format.
5048 (write_line) Deal with struct len_string.
5049 (write_varname) Ditto.
5050 (write_fallback_headers) Ditto.
5052 * magic.c: New file, incorporating the following global variables
5053 previously in other files: endian, second_lowest_value. And both
5054 of those are conditional on #define's.
5056 * magic.h: New file, incorporating the following global variable
5057 declarations: endian, second_lowest_value, and the following macro
5058 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5060 * main.c: Added declarations of pgmname, finished, curdate,
5062 (main) Call new parse_script() function.
5063 (parse_script) New function.
5064 (execute_command) New function.
5065 (dump_token) Removed.
5066 (handle_error) New function.
5068 * matrix.c: New file.
5070 * matrix.h: New file.
5072 * matrix-data.c: Migrated from arenas to pools.
5073 (mget_token) Change from parse_string_as_format() to data_in().
5075 * means.q: Migrate to new q2c.
5076 (custom_tables) Renamed mns_custom_tables().
5077 (custom_crossbreak) Renamed mns_custom_crossbreak().
5078 (custom_variables) Renamed mns_custom_variables().
5080 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5081 (parse_varnames) Prototype.
5082 (parse_numeric) Rephrasings.
5083 (parse_alpha) Adapt to new struct string tokstr.
5085 * misc.c: (intlog10) Rewritten.
5087 (ansi_rand) Renamed real_rand(), moved into random.c.
5088 (ansi_srand) Renamed real_srand(), moved into random.c.
5089 (setup_randomize) Moved to random.c.
5090 (rand_uniform) Ditto.
5091 (rand_normal) Ditto.
5092 (rand_simple) Ditto.
5093 (get_config_line) Removed.
5094 (reverse) Removed (dead code).
5096 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5097 (macro CLEAR_BIT) Ditto.
5098 (macro TEST_BIT) Ditto.
5099 (macro SET_BIT_TO) Ditto.
5100 (macro BIT_INDEX) Ditto.
5102 * output.c: (outp_read_devices) Move to err_push_file_locator()
5103 from push_cust(). Use struct string.
5104 (expand_op_tokstr) Removed.
5105 (static var op_tokstr) Changed to struct string.
5106 (static var op_tokstr_size) Removed.
5107 (tokener) Rephrasings. Use struct string.
5108 (parse_options) Use struct string.
5109 (destroy_driver) Fix assertion.
5110 (outp_get_paper_size) Move to err_push_file_locator().
5111 [0] Removed dead code.
5112 (outp_string_width) Move to len_string.
5114 * output.h: Comment fixes.
5115 (TAG_* enum series) Removed.
5116 (struct outp_value) Removed.
5117 (enum OUTP_T_FANCY) Removed.
5118 (struct outp_text) `s' changed from a_string to len_string.
5119 (struct outp_class) `option' change arg 3 from outp_value to
5122 * pfm-read.c: (corrupt_msg) Rewritten.
5124 * pfm-write.c: (bufwrite) Fix assertion.
5126 * pool.c: New file, reference version.
5128 * pool.h: New file, reference version.
5130 * postscript.c: (ps_font_sizes) Fix assertion.
5131 (ps_option) Change arg 3 from outp_value to struct string.
5132 Adapt to struct string.
5133 (macro output_line) Removed.
5134 (macro add_string) Removed.
5135 (output_encodings) Adapted to struct string. Moved to
5136 err_push_file_locator().
5137 (find_encoding_file) Fix assertion.
5138 (read_ps_encodings) Move to err_push_file_locator().
5139 (postopen) Use getl_location() instead of curfn.
5140 (out_text_plain) Move to len_string.
5141 (text) Ditto. Remove rich text support.
5143 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5144 (cmd_print_eject) Ditto.
5146 (internal_cmd_print) Now cleans up after itself. Uses
5147 fh_parse_file_handle() now.
5148 (cmd_print_space) Use PXP_NUMERIC to type-check.
5150 * q2c.c: Overhauled. Removed _("") i18n support. All references
5151 updated. All output functions updated to handle structures rather
5152 than local or static variables. Adapt to new PSPP lex_*()
5156 (macro MAX_N_SBC) Removed.
5157 (global bare) Removed.
5158 (enum STRING) Renamed T_STRING.
5159 (enum ID) Renamed T_ID.
5160 (get_buffer) Buffer size increased.
5161 (strlower) Renamed st_lower(), rephrased.
5162 (strupper) Renamed st_upper(), rephrased.
5163 (skip_ws) New function.
5164 (get_line) Don't special-case any types of lines (like those
5165 beginning with ! or $, for instance).
5166 (get_token) Renamed lex_get(). Rephrased.
5167 (static var `prefix') New.
5168 (parse) New function.
5169 (parse_setting) Minor rephrasing.
5170 (dump_specifier_vars) Ditto.
5171 (make_identifier) Put null terminator on identifier, duh.
5172 (dump_vars) Renamed dump_declarations(). Never indent. Never
5173 static. Output changed entirely.
5174 (dump_specifier_init) Rephrase.
5175 (dump_vars_init) No index variable needed. Other modifications.
5176 (dump_parser) Don't parse command name. Do dump functions instead
5177 of just code fragments.
5178 (dump_free) Dump function instead of code fragment.
5179 (recognize_directive) New function.
5180 (main) Use recognize_directive(). Don't rely on magic $ line
5181 beginning: instead, parse comments. Update list of headers.
5183 * random.c: New file, containing the following functions:
5184 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5185 rand_normal, rand_simple.
5187 * random.h: New file.
5189 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5190 function. `max_src_width', `max_dst_width' changed to size_t.
5191 (internal_cmd_recode) Removed.
5192 (parse_dest_spec) Merge similar cases.
5193 (parse_src_spec) Add assertion.
5195 * repeat.c: (recognize_keyword) New function.
5196 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5197 REPEAT. Improve recognition of END REPEAT (use
5198 recognize_keyword()). Move from curfn to getl_location(). Use
5201 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5203 * set.q: Adapt to new q2c.
5204 (cmd_set) Range-check some values better.
5205 (custom_blanks) Renamed stc_custom_blanks().
5206 (custom_length) Renamed stc_custom_length().
5207 (custom_results) Renamed stc_custom_results().
5208 (custom_seed) Renamed stc_custom_seed().
5209 (custom_width) Renamed stc_custom_width().
5210 (custom_format) Renamed stc_custom_format().
5211 (custom_journal) Renamed stc_custom_journal().
5212 (custom_color) Renamed stc_custom_color().
5213 (custom_listing) Renamed stc_custom_listing().
5214 (custom_disk) Renamed stc_custom_disk().
5215 (custom_log) Renamed stc_custom_log().
5216 (custom_rcolor) Renamed stc_custom_rcolor().
5217 (custom_viewlength) Renamed stc_custom_viewlength().
5218 (custom_workdev) Renamed stc_custom_workdev().
5220 * settings.h: Not necessary to include format.h any longer.
5222 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5223 (corrupt_msg) Rewritten.
5225 * sort.c: Adapt to rewritten heap ADT.
5227 * str.c: (aa_strcpy) Removed.
5228 (ab_strcpy) Removed.
5229 (ac_strcpy) Removed.
5230 (ba_strcpy) Removed.
5231 (bb_strcpy) Removed.
5232 (ca_strcpy) Removed.
5233 (aa_strdup) Removed.
5234 (aa_strdupcpy) Removed.
5235 (ba_strdup) Removed.
5236 (sa_strdup) Removed.
5237 (memrev) Renamed mm_reverse().
5238 (memrmem) Renamed mm_find_reverse().
5239 (cmp_str) Renamed st_compare_pad().
5240 (strmaxcpy) Removed.
5241 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5242 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5244 (strpadcpy) Renamed st_pad_copy(), signature changed.
5245 (blpstrset) Removed.
5246 (ds_create) New function.
5247 (ds_init) New function.
5248 (ds_replace) New function.
5249 (ds_destroy) New function.
5250 (ds_clear) New function.
5251 (ds_extend) New function.
5252 (ds_shrink) New function.
5253 (ds_truncate) New function.
5254 (ds_length) New function.
5255 (ds_size) New function.
5256 (ds_value) New function.
5257 (ds_end) New function.
5258 (ds_concat) New function.
5259 (ds_concat_buffer) New function.
5260 (ds_printf) New function.
5261 (ds_putchar) New function.
5262 (ds_getline) New function.
5263 (ds_get_config_line) New function derived from the old
5264 misc.c:get_config_line().
5265 (ls_create) New function.
5266 (ls_create_buffer) New function.
5267 (ls_init) New function.
5268 (ls_shallow_copy) New function.
5269 (ls_destroy) New function.
5270 (ls_null) New function.
5271 (ls_null_p) New function.
5272 (ls_empty_p) New function.
5273 (ls_length) New function.
5274 (ls_value) New function.
5275 (ls_end) New function.
5277 * str.h: Reformatted.
5278 (struct a_string) Removed.
5279 (struct b_string) Removed.
5280 (struct c_string) Removed.
5281 (struct len_string) New.
5282 (struct string) New.
5283 (macro as_streq) Removed.
5284 (macro bs_streq) Removed.
5285 (macro cs_streq) Removed.
5286 (macro sa_streq) Removed.
5287 (macro sb_streq) Removed.
5288 [__GNUC__] (inline function ds_putchar) New function.
5289 [__GNUC__] (inline function ds_length) New function.
5290 [__GNUC__] (inline function ds_value) New function.
5291 [__GNUC__] (inline function ds_end) New function.
5293 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5294 (display_vectors) Fix missing i18n.
5296 * t-test.q: Migrate to new q2c.
5298 * tab.c: Migrate from arenas to pools.
5299 (tab_create) Use struct len_string.
5300 (tab_realloc) Ditto.
5301 (text_format) Ditto.
5302 (tab_joint_text) Ditto.
5303 (tab_natural_width) Remove rich text support.
5304 (tab_natural_height) Ditto.
5305 (tab_output_text) Handle TAT_FIX.
5306 (tab_raw) Change arg from a_string to len_string.
5307 (tabi_driver) Fix assertion. Use struct len_string.
5308 (render_strip) Use struct len_string. Remove rich text support.
5309 Add `const' qualifiers.
5311 * tab.h: (enum TAB_RICH) Remove.
5312 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5313 SOM_COL_* updated to read TAB_COL_*.
5314 (struct tab_table) Change arena to pool. Change a_string to
5317 * temporary.c: (restore_dictionary) Rewrite Checker code.
5319 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5320 LOWEST, HIGHEST) Moved here from common.h.
5321 (typedef any_trns) Removed. All references changed to `struct
5324 * vars-atr.c: (force_create_variable) Fix assertion.
5325 (force_dup_variable) Fix assertion.
5327 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5329 Using alphanumeric variables in functions under AGGREGATE
5330 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5331 <BZN-mdksh@t-online.de> for reporting this bug.
5333 * aggregate.c: (parse_aggregate_functions) When setting the
5334 FSTRING bit, also allocate memory for the `string' member of
5336 (free_aggregate_functions) Free iter->string. Don't use the
5337 non-function bits when indexing the array of functions.
5338 [DEBUGGING] (debug_print) Don't use the non-function bits when
5339 indexing the array of functions.
5341 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5343 Under certain circumstances, the final case would be omitted from
5344 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5345 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5347 * aggregate.c (agr_00x_end_func): Increment number of cases in
5348 sink before writing case. For streams that keep track of how many
5349 cases there are based on this value, this means that the last case
5350 will be read in on the next stream read.
5352 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5354 Undefined behavior was invoked by referencing a freed pointer.
5356 * vfm.c (memory_stream_write): Free pointer *after* checking for
5359 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5361 A wrong record size was displayed when paging the active file to
5364 * vfm.c: (memory_stream_write) Fix off-by-one error.
5366 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5368 Not having enough temporary space for sorting caused a core dump.
5371 * sort.c: (allocate_cases) Initialize i.
5373 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5375 Syntax errors in function descriptions on AGGREGATE caused core
5378 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5379 free_aggregate_functions(), since that function already frees
5382 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5384 A null pointer was dereferenced, causing a core dump, when
5385 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5386 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5387 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5389 * arena.c: (arena_malloc) If the arena hasn't been initialized
5390 already, initialize it.
5392 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5394 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5395 for compilation with Cygnus Windows B20. Not used by other
5398 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5400 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5401 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5403 * sort.c: (compare_case_lists) Reverse sense of comparison if
5404 sorting in descending order.
5405 (compare_record) Ditto.
5407 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5409 SPLIT FILE with a string variable caused a core dump. Fixed.
5411 * vfm.c: If the variable is a string then make a temporary value
5412 struct pointing to it. The underlying problem is a lot bigger
5413 than this (see TODO) but this is a stopgap for the simple case at
5416 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5418 Nested INCLUDEs didn't work. Fixed.
5420 * getline.c: (getl_include) Set first_line to NULL in allocated
5423 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5425 The MATCH FILES procedure set the values of variables not present
5426 to 0. It should have been SYSMIS. This is now fixed.
5428 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5430 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5432 The REMARK command was too aggressive about skipping lines. It
5433 didn't like being the last command in a file.
5435 * command.c: (cmd_remark) Call get_entire_line() instead of
5438 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5440 Comment parsing wasn't consistent with the rest of the code in its
5441 idea of where one command ends and another starts. This meant
5442 that sometimes commands would be mysteriously ignored. Thanks to
5443 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5445 * command.c: (parse_cmd) Hand off comment parsing to new function
5446 skip_comment() in lexer.c.
5447 * lexer.c: (skip_comment) New function.
5449 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5451 The TABLE subcommand on MATCH FILES worked only erratically at
5452 best. This fixes it. Thanks to Dr. Dirk Melcher
5453 <BZN-mdksh@t-online.de> for reporting this bug.
5455 * get.c: (mtf_compare_BY_values) When comparing string values, a
5456 difference of 1 is still a difference :-)
5457 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5458 advance TABLE files automatically when matched. Comment fixes.
5460 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5462 VARIABLE LABELS rejected a slash before the first variable
5463 specification, contradicting the documentation. Thanks to Walter
5464 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5466 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5467 command specification.
5469 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5471 Because of an incorrect optimization in memory allocation,
5472 CROSSTABS sometimes segfaulted when asked to output multiple
5473 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5476 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5477 are passed to output_pivot_table() for its use.
5478 (output_pivot_table) Instead of assuming the number of columns is
5479 constant, keep track with maxcols. In general mode, use maxcells
5480 to determine whether more matrix cells need to be allocated.
5482 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5484 CROSSTABS didn't display value labels for column and row
5485 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5488 * crosstabs.q: (table_value_missing) If the specified value has a
5489 value label for this variable, then show it instead of the raw
5491 (display_dimensions) Delegate display of value_labels to
5492 table_value_missing.
5494 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5496 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5497 <BZN-mdksh@t-online.de> for reporting this bug.
5499 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5500 if the file isn't declared as binary.
5502 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5504 MATCH FILES corrupted memory and dumped core on some syntax
5507 * get.c: (cmd_match_files) Set file->handle to NULL before
5509 (mtf_free_file) Don't free a null dictionary.
5511 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
5513 MATCH FILES should set numeric values not available to the
5514 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
5515 <BZN-mdksh@t-online.de> for reporting this bug.
5517 * get.c: (mtf_processing) Set unused records to system-missing,
5520 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
5522 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
5523 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
5525 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
5526 in newly created dictionary, and add each copied variable to the
5529 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
5533 * get.c: (trim_dictionary) Free variable list for KEEP after
5536 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
5538 Some systems didn't like the way open_file was coded. Thanks to
5539 Hankin <hankin@rogue.consultco.com> for pointing this out.
5541 * filename.c: (open_file) Don't try to store stdin, stdout,
5542 stderr as part of an array, because that doesn't always work.
5544 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
5546 The SAVE procedure didn't save long string variables properly.
5547 Fixed by this patch. Thanks to Hankin
5548 <hankin@rogue.consultco.com> for this patch.
5550 * sfm-write.c: (write_variable) Fix off-by-one error in writing
5551 out variable pad records.
5553 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
5555 Previously, if PRINT SPACE were given a negative argument, it
5556 would report an error, then spin in an (almost) infinite loop.
5557 This fixes that behavior.
5559 * print.c: (print_space_trns_proc) After reporting a negative
5560 argument, set number of lines to print to 1.
5562 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
5564 SPSS 8.0 outputs some new record types in its system files, and it
5565 allows longer value labels. Accept these system files.
5567 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
5568 11 emitted by SPSS 8.0.
5570 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
5572 The LIST procedure was too conservative in allocating space for
5573 buffers, which caused a bug that only showed up with very long
5574 output variables. Thanks to Hankin <hankin@dunno.com> for this
5577 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
5579 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
5581 Typo meant string format specifiers weren't checked properly. I
5582 think that Hankin <hankin@dunno.com> sent me this report, but I'm
5583 willing to be corrected on this point.
5585 * format.c: (check_string_specifier) Fix obvious typo.
5587 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
5589 Using $CASENUM in an expression didn't work. Here's a fix.
5590 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
5593 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
5595 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
5597 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
5599 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
5600 other behavior, *sigh*. This patch hopefully fixes that. This
5601 time I've actually tested it.
5603 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
5605 * data-list.c: (read_from_data_list_free,
5606 read_from_data_list_list) Call parse_string_as_format() directly
5607 without mucking around with the field width.
5609 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
5611 Occasionally, you may encounter a script that wants to be
5612 interpreted in interactive mode. Make -i emulate this behavior to
5613 allow such scripts to be executed with PSPP.
5615 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
5617 * cmdline.c: (pre_syntax_message[]) Update -i description.
5619 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
5620 when -i is given on the command line) don't treat unindented lines
5621 as starting a new command.
5623 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
5625 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
5626 mostly caused by local initialized aggregates. After egcs is
5627 fixed upstream these can be removed, but for now they're not a big
5630 * ascii.c: (ascii_postopen_driver) Checker chokes on local
5631 initialized arrays. Avoid this.
5633 * sfm-write.c: (sfm_write_dictionary) Don't use a local
5636 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
5638 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
5639 following changes avoid. Currently I compile sources with egcs
5640 1.1.1 and gcc 2.7.2.3 before sending them out.
5642 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
5644 * ascii.c: (option_tab[]) Initialize all struct members.
5646 * avl.h: (avl_traverser_init) New macro.
5648 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
5651 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
5654 * hash.c: Comment fix.
5656 * hash.h: (hsh_iterator_init) New macro.
5658 * html.c: (option_tab[]) Initialize all struct members.
5660 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
5663 * postscript.c: (option_tab[]) Initialize all struct members.
5664 (output_encodings, preclose, dump_lines) Use new
5665 hsh_iterator_init() macro.
5667 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
5670 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
5673 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
5675 * data-in.c: Examined each of the parsing functions to make sure
5676 that they wouldn't dump core if they were passed a string of the
5677 wrong length, since now the DATA LIST FREE/LIST routines don't
5678 check for field width before passing it to the data parser.
5679 (parse_RBHEX, parse_AHEX) Reject odd length input.
5680 (parse_string_as_format) Reject input that's too short or too
5683 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
5684 a field to its entire declared output width then pass it to the
5685 data-in parsing routines. This contradicted the documented
5686 behavior. This is fixed in these changes. Thanks to Mark H. Wood
5687 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
5688 free-format parsing that differed from SPSS.
5689 (cut_field) Commas and spaces are treated identically. Returns
5690 the proper column instead of a fixed 1 value.
5691 (parse_field) Removed.
5692 (read_from_data_list_free, read_from_data_list_list) Call
5693 parse_string_as_format directly instead of parse_field.
5695 * heap.c: (heap_delete) Stylistic fixes.
5697 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
5699 * loop.c: (loop_2_trns_proc) Formatting fix.
5701 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
5703 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
5705 * vfm.c: (macro FILTERED) New.
5706 (static var filter_var) New.
5707 (process_active_file_write_case) Use FILTERED.
5708 (setup_filter) Set filter_var.
5709 (close_active_file) Delete the filter if not
5710 FILTER_before_TEMPORARY.
5711 (procedure_write_case) Use FILTERED.
5713 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
5715 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
5717 * data-in.c: (parse_day_count) Message fix.
5718 (parse_month) Style fix.
5720 * data-list.c: (struct data_list_pgm) New member eof.
5721 (cmd_data_list) Init eof to 0.
5722 (do_reading) Implement the /END subcommand and read-past-eof
5725 * do-if.c: Include stdio.h when debugging.
5726 (cmd_else_if) Make sure the command is .-terminated.
5728 * glob.c: (init_glob) Capitalize the command prompt.
5730 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5731 (end_file_trns_proc) Debugging message.
5733 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5735 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5737 * main.c: (dump_token) Make kwtab[] const.
5739 * set.q: Spelling, comment fixes.
5741 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5744 * vars-prs.c: (fill_all_vars) Style fix.
5746 * vfm.c: (index_to_varname) Return const.
5748 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5750 * Changes in many source files for partial -ansi -pedantic and
5751 no-debugging compliance: Remove trailing common in enum
5752 declarations; add `unused' attributes; insert some appropriate
5755 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5757 * command.c: (shell) Make static.
5758 (run_command) Make static.
5760 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5762 * dfm.c: (cmd_begin_data) I18n fix.
5764 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5766 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5768 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5771 * file-handle.q: Don't prepend the source file directory name to
5772 the data file name. (Ongoing issue.)
5773 (prepend_current_directory) Comment out.
5774 (internal_cmd_file_handle) Don't call prepend_current_directory().
5775 (fh_get_handle_by_filename) Ditto.
5777 * filename.c: Append zero byte to readlink() return value.
5779 * getline.c: (getl_read_line) I18n fix.
5781 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5783 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5785 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5788 * postscript.c: (output_encodings) Don't use local_strdup().
5791 * print.c: Don't use gcc features if __STRICT_ANSI__.
5793 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5795 * recode.c: (parse_src_spec) Fully brace nested if's.
5797 * set.q: (global var set_testing_mode) New var.
5799 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5801 * ascii.c: Add some more `unused' attributes that only come into
5802 play when NDEBUG is defined.
5803 (ascii_close_page) Set s_len when reallocating s.
5805 * crosstabs.q: (delete_missing) New function.
5806 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5807 (make_summary_table) Create summary table reallocable.
5809 * postscript.c: Add more `unused' attributes as above.
5811 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5812 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5814 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5817 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5818 gratuitous space between parameter definition.
5820 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5821 complaints about running off the end of functions with NDEBUG
5824 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5826 * Several source files: Removed some PORTME notes when reflection
5827 revealed that ANSI forbids that sort of breakage. Also, added
5828 lots of `unused' qualifiers here and there.
5830 * aggregate.c: (accumulate_aggregate_info) Remove local var
5831 weighting that turned out not to be used.
5833 * avl.c: Update to version 1.1.0. Add unused specifier.
5834 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5836 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5837 (avl_find) Cast return value to void *.
5838 (avl_delete) q doesn't need to be initialized at the beginning of
5839 the function. Replace some instances of 1 with +1.
5840 (force_avl_delete) Renamed avl_force_delete, all references changed.
5841 (compare_ints) `param' marked unused.
5842 (print_int) `param' marked unused.
5843 (recurse_tree) Replace some instances of 1 with +1.
5845 * avl.h: Update to version 1.1.0. Only declares avl function
5846 types if not already declared.
5847 (AVL_MAX_HEIGHT) Only define if not already defined.
5848 (struct avl_node) New unused member char pad[2].
5849 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5850 (force_avl_insert) Renamed avl_force_insert.
5851 (force_avl_delete) Renamed avl_force_delete.
5853 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5855 (struct crosstab) Add new member `ofs'.
5856 (glob var int_tab) Removed.
5857 (custom_tables) In integer mode, assign v[i] properly through the
5859 (custom_variables) Now p.crs.max == max + 1.
5860 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5861 (precalc) Implement integer mode.
5862 (calc_integer) Implement integer mode.
5863 (compare_table_entry) Remove unused local variable `comparing'.
5864 (make_summary_table) Implement integer mode.
5865 (macro ns_rows) Implemented as static variable now.
5866 (several variables) Made static, from global.
5867 (output_pivot_table) Use table_value_missing() for column heads.
5868 Remove several unused local variables. Implement integer mode
5869 table summing. Count up ns_rows.
5870 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5871 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5872 calls that function or find_pivot_extent_integer.
5873 (find_pivot_extent_integer) New function.
5874 (enum_var_values) Implemented for integer mode.
5875 (table_value_missing) New function.
5876 (display_dimensions) Call table_value_missing() for heads.
5877 (float_M_suffix) New function.
5878 (display_crosstabulation) Call table_value_missing() for row
5879 heads. Handle missing values in /MISSING=REPORT mode.
5880 (calc_fisher) Remove unused var N.
5881 (calc_r) Remove unused var fact.
5883 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5884 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5886 * data-out.c: (insert_commas) Remove unused var cp.
5887 (convert_CCx) Remove unused vars save_set_decimal,
5890 * descript.q: (dump_z_table) Fix table dimensioning.
5891 (pre_calc) Remove unused var j.
5892 (display) Remove unused vars title, s. Fix table dimensioning.
5894 * expr-evl.c: Comment fixes.
5896 * frequencies.q: (full_dim) New function.
5897 (dump_full) Fix table dimensioning.
5898 (condensed_dim) New function.
5899 (dump_condensed) Fix table dimensioning.
5901 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5904 * html.c: (html_close_drive) Remove unused var i.
5905 (postopen) Remove unused vars title, curfn_len, cp.
5906 (preclose) Remove unused vars this, x.
5908 * lexer.c: Comment fixes.
5910 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5912 * means.q: (custom_tables) Remove unused var m_dim.
5914 * mis-val.c: Format fix.
5916 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5918 * output.c: (outp_get_paper_size) Remove unused var cp.
5920 * pfm-read.c: (read_float) Remove unused var save, unused label
5922 (read_variables) Remove unused vars cp, j.
5923 (read_value_label) Remove unused var j.
5925 * pfm-write.c: (bufwrite) Remove unused var i.
5927 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5929 (output_encodings) Remove unused vars char_cp, n_output.
5930 (read_ps_encodings) Remove unused var ep.
5931 (postopen) Remove unused var title.
5932 (preclose) Remove unused var fp.
5933 (ps_open_page) Remove unused vars true, false, orientation,
5934 mirror_horz, mirror_vert, width, length.
5935 (ps_text_metrics) Remove unused var x.
5937 * q2c.c: (find_symbol) Remove unused var y.
5938 (parse_setting) Remove unused parameter sbc, all references
5940 (dump_parser) Remove unused var cp.
5941 (dump_free) Remove unused var i.
5943 * set.q: (static vars args, n) Removed.
5944 (internal_cmd_gset) Removed.
5946 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5947 (read_machine_flt64_info) Removed unused var file_endian.
5948 (read_documents) Removed unused var i.
5949 (read_compressed_data) Removed unused parameter dict, all
5952 * sfm-write.c: (bufwrite) Removed unused var i.
5953 (sfm_write_case) Removed unused var i.
5955 * sort.c: (merge_once) Remove unused var t.
5956 (write_separate) #if 0 out as dead code.
5958 * split-file.c: (cmd_split_file) Remove unused var i.
5960 * sysfile-info.c: (sysfile_info_dim) New function.
5961 (cmd_sysfile_info) Fix table dimensioning.
5962 (variables_dim) New function.
5963 (display_variables) Fix table dimensioning.
5964 (describe_variable) Remove unused var prev_r.
5966 * t-test.q: (z_postcalc) Removed.
5967 (pairs_calc) Remove unused var bad_weight.
5968 (postcalc) Remove unused vars dfn, dfd.
5970 * tab.c: (tab_create) Set t->dim to NULL.
5971 (tab_dim) Make sure t->dim is NULL first.
5972 (tab_natural_width) Remove parameter `clamp'.
5973 (tab_value) Remove duplicate assertion for table.
5974 (tab_raw) New function.
5975 (nowrap_dim) New function.
5976 (wrap_dim) New function.
5977 (tab_output_text) Fix table dimensioning.
5979 * tab.h: (tab_raw) New macro.
5981 * val-labs.c: (get_label) Remove unused var type.
5982 (copy_value_labels) Remove unused var trav.
5984 * var.h: (struct crosstab_proc) Completely changed.
5986 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5988 * vfm.c: (open_active_file) Remove unused vars i, lp.
5990 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5992 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5994 * Makefile.am: Add apply-dict.c, flip.c.
5996 * apply-dict.c: New file.
5998 * command.c: (struct command) Make cmd[] larger for CLEAR
5999 TRANSFORMATIONS command name.
6000 (parse_cmd) Make sure we're in a valid state before using it as an
6001 index. Discard variables and reset state on invalid transitions.
6002 (cmd_clear_transformations) New function.
6004 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6005 Add unimplemented PRESERVE, RESTORE.
6007 * file-handle.h: Include stddef.h.
6011 * pfm-read.c: (parse_value) Pad value label values with spaces,
6014 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6015 (sfm_close) Decrement reference count, make sure it's zero.
6016 (sfm_maybe_close) New function.
6017 (sfm_read_dictionary) Handle reference counts.
6019 * vars-atr.c: (clear_default_dict) New function.
6020 (discard_variables) Use clear_default_dict().
6022 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6024 * Makefile.am: Add pfm-write.c.
6025 (LDADD) Add the libgmp2 libraries.
6027 * command.def: Define EXPORT.
6029 * get.c: (cmd_export) New function.
6030 (export_write_case_func) New function.
6032 * pfm-read.c: (static spss2ascii[]) Make it const.
6034 * pfm-write.c: New file.
6036 * sfm-write.c: Formatting, comment fixes.
6038 * var.h: Comment fix.
6040 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6042 * Makefile.am: Add pfm.h, pfm-read.c.
6044 * command.def: IMPORT is now implemented.
6046 * format.c: (glob var translate_fmt[]) New var.
6048 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6049 (cmd_import) New function.
6050 (import_source_read) New function.
6051 (glob var import_source) New var.
6053 * pfm-read.c: New file.
6057 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6059 (dump_dictionary) Disabled printing a couple of items.
6061 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6063 * crosstabs.q: (postcalc) Call make_summary_table().
6064 (make_summary_table) New function.
6065 (insert_summary) New function.
6066 (display_dimensions) Remove some unnecessary arguments, all
6068 (output_pivot_table) Fix lots of problems with the risk table
6070 (submit) Don't display an empty table.
6071 (display_risk) Fix order of arguments to calc_risk().
6073 * glob.c: Always include assert.h and stdlib.h.
6075 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6078 * tab.c: (tab_create) Cosmetic changes.
6080 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6082 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6086 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6087 code simplified, moved into new function submit().
6088 (submit) New function.
6089 (crosstabs_dim) New function.
6090 (display_directional) Substitute variable names for %s where
6092 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6093 (calc_symmetric) Initialize parameters only if non-NULL.
6094 Calculate Somers' d.
6095 (calc_directional) Calculate Somers' d (or copy it, really).
6098 * output.c: (outp_string_width) New function.
6100 * postscript.c: (postopen) Calculate font widths based on the
6101 width of the zero '0' character, not the width of the space
6102 character. Set paper-width and paper-length based on points, not
6104 (ps_open_page) Fix page setup string for landscape mode.
6106 * som.h: (struct som_dimension) Removed.
6107 (struct som_table_class) height, width members take int * not
6110 * tab.c: Many functions now have added parameter validation.
6111 (tab_height, tab_width) These functions were removed and merged
6112 into a single function tab_resize(), and all references changed.
6113 (tab_dim) Rewritten since the interface changed; reduced from
6114 hundreds of lines to two. All callers were changed. Currently
6115 most of them just use tab_natural_dimensions as their callback and
6116 await detailed translation of functionality.
6117 (tab_natural_width) New function.
6118 (tab_natural_height) New function.
6119 (tab_natural_dimensions) New function. This is a callback
6120 function, not something that you'd want to call directly.
6121 (tab_nat_dim) Removed.
6122 (tabi_table) Allocates t->w and t->h.
6123 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6124 dimensions callback.
6125 (evaluate_dimensions) Removed.
6126 (sum_columns) Removed.
6128 * tab.h: (enum TAL_1THIN) Removed.
6129 (enum series t_*) Removed.
6130 (struct tab_table) Members trh, trv changed to unsigned char *
6131 from int *. Member dim changed to a function pointer from a
6132 unsigned char *. Member max_stack_height removed. New members
6134 (macros tab_l, tab_r, tab_t, tab_b) New.
6136 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6138 * ascii.c: (delineate) Assign last_space_nchars before skipping
6139 spaces, to fix right justification.
6141 * crosstabs.q: (static vars risk, direct) New vars.
6142 (static var pearson_r) Removed.
6143 (glob var chisq_fisher) Made static.
6144 (static vars row_tot[], col_tot[]) Don't include grand total
6146 (static var grand_total) Renamed W, all references changed.
6147 (output_pivot_table) Only make `table' if num_cells != 0. Make
6148 risk and directional tables. Deal with grand total no longer part
6149 of col_tot[]. Free rows and cols after we're done with them.
6150 (display_risk) New function.
6151 (display_directional) New function.
6152 (clac_r) Rewritten so that it stores all its results into its
6153 arguments, so it can be used for Spearman's correlation too.
6154 (calc_symmetric) Added a t[] argument, all references changed.
6155 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6156 Pearson's r, Cohen's kappa.
6157 (calc_risk) New function.
6158 (calc_directional) New function.
6160 * som.c: (som_submit) Improved debugging code.
6162 * stats.c: (hypercube) New function.
6163 (cube) New function.
6165 (normal_sig) Went back to old implementation, which actually
6168 * stats.h: (macros square, cube, hypercube) Removed. The
6169 equivalent functions in stats.c are inlined here; all references
6170 to square changed to sqr.
6172 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6174 * crosstabs.q: (N_SYMMETRIC) New define.
6175 (postcalc) Disable debug printing.
6176 (static vars chisq_fisher, pearson_r) New.
6177 (output_pivot_table) Add support for symmetric measures. Add
6178 chi-square output of exact sigs.
6179 (display_chisq) Rewritten.
6180 (display_symmetric) New function.
6181 (gamma_int) New function.
6183 (swap) New function.
6184 (calc_fisher) New function.
6185 (calc_chisq) Check boundary conditions better. Calculate Yates,
6186 Fisher, Mantel-Haenszel tests.
6187 (calc_r) New function.
6188 (calc_symmetric) New function.
6190 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6192 (chisq_sig) Better boundary conditions. Renamed from
6195 * tab.h: (struct tab_table) New member cf.
6197 * tab.c: (tab_create) Set cf.
6198 (tab_width) New function.
6199 (tab_realloc) Handle cf.
6200 (tab_vline) Handle cf.
6201 (tab_hline) Handle cf.
6202 (tab_box) Handle cf.
6203 (tab_value) Handle cf.
6204 (tab_float) Handle cf.
6205 (tab_text) Handle cf.
6206 (tab_joint_text) Handle cf.
6207 (tab_offset) Handle cf.
6208 (tab_next_row) Handle cf.
6209 (evaluate_dimensions) Handle cf.
6210 (render_strip) Handle cf.
6212 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6214 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6215 output_pivot_table().
6216 (output_pivot_table) Moved lots of local variables outside and
6217 made them static. Add beginnings of chi-square statistic
6218 support. Now column and row totals aren't in the main matrix.
6219 Always zero out any leftover rows & columns after we're done with
6220 the table entries. Move all output stuff into
6221 display_dimensions(), display_crosstabs(), display_chisq().
6222 (display_dimensions) New function.
6223 (display_crosstabulation) New function.
6224 (display_chisq) New function.
6225 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6227 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6228 references, simplify logic.
6230 * postscript.c: Remove scale, translate-x, translate-y,
6231 mirror-horz, mirror-vert, rotate-180 options.
6232 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6233 All references deleted.
6234 (macro YT) New macro.
6235 (array option_tab[]) Removed options.
6236 (ps_option) Removed options.
6237 (ps_open_page) Write page setup explicitly to output file, without
6238 using now-deleted BP function.
6239 (macro dump_line) Use YT().
6240 (macro dump_thick_line) Use YT().
6241 (draw_headers) Use YT().
6242 (switch_font) Reorder arguments to SF function.
6243 (write_text) Use YT().
6245 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6248 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6250 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6251 null-debugging code.
6252 (tab_realloc) Remove null-debugging code. Initialize new regions
6254 (tab_vline) Support offsets.
6255 (tab_hline) Support offsets.
6256 (tab_box) Support offsets.
6258 (tab_nulls) Removed.
6261 (evaluate_dimensions) Remove null-debugging code. Understand
6262 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6263 TAB_EMPTY not present.
6265 * tab.h: New cell attribute TAB_EMPTY.
6266 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6268 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6269 try to read them from system files.
6271 * vfm.c: (dump_splits) Don't call tab_null().
6273 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6275 * crosstabs.q: (struct crosstab) Added `missing' member.
6276 (custom_tables) Init missing.
6277 (calc_general) Handle missing values.
6278 (calc_chisq) New function.
6279 (output_pivot_table) Start work on chi-square output. Update for
6280 new tab offset support functions. Shorten statistic names.
6282 * Several files: add in more `const's to placate gcc's warnings.
6284 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6287 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6288 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6289 tab_joint_text) Add col_ofs and row_ofs support.
6290 (tab_offset) New function.
6291 (tab_next_row) New function.
6292 (tab_row) New function.
6293 (tab_col) New function.
6294 (tabi_table) Add col_ofs and row_ofs support.
6296 * vars-atr.c: (is_system_missing) New function.
6298 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6300 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6301 (static var no_cells) Removed.
6302 (static var num_cells) New.
6303 (static var expected) New.
6304 (static var cells[]) New.
6305 (internal_cmd_crosstabs) Deal with new variables.
6306 (postcalc) Removed most of the meat and put it in new function
6307 output_pivot_table().
6308 (output_pivot_table) Calculates and outputs an entire pivot table.
6310 * postscript.c: (postopen) Fix problems with free()ing addresses
6311 not obtained from malloc().
6313 * som.c: (som_submit) Add assertion.
6315 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6318 * tab.c: (static var tab_names[]) New.
6319 (tab_realloc) -1 for nc or nr indicates no change.
6320 (tab_nulls) New function.
6321 (tab_dim) Use tab_names[].
6322 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6323 (evaluate_dimensions) Don't terminate on uninited cells, just put
6324 an X in them and emit a notice. Use tab_names[].
6326 * tab.h: Move bits into tab.def.
6328 * tab.def: New. Don't try to declare tab_table_class because then
6329 som.h has to be included.
6331 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6333 * command.def: New file, contains all the command definitions
6334 previously included bodily in command.c.
6336 * format.def: New file, contains all of the format definitions
6337 previously split across format.h, format.c, and sfm-write.c.
6339 * lexer.h: Renamed from tokens.h in order to match corresponding
6342 * lexerP.h: Moved some rarely used functions exported by lexer.c
6345 * Makefile.am: Commemorate renamed files.
6346 (EXTRA_DIST) Add command.def, format.def.
6348 * command.c: [0] (walk_cmdtable_func) Removed.
6350 * crosstabs.q: (postcalc) Made it work and print out matrices
6352 (enum_column_values) Renamed enum_var_values, generalized for any
6355 * format.h: (struct fmt_desc) New member `spss'.
6357 * q2c.c: (main) Generated code includes lexer.h instead of
6360 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6361 instead of an independent translation table.
6363 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6365 * Lots of source files: Added const to declarations.
6367 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6369 * arena.c: (arena_clear) Set prev pointer to null when done.
6371 * ascii.c: (ascii_option) Rename index as indx.
6373 * avl.c: This is now a separate library called libavl.
6374 (xmalloc) Make static.
6375 (avl_probe) Step A7 can use the cache instead of an explicit
6377 (avl_delete) Don't maintain a q pointer because it's always
6378 available in the pointer stack. Comment fix.
6380 * avl.h: This is now a separate library called libavl.
6382 * command.c: (cmd_table[]) Remove spurious trailing "".
6384 * common.h: Only include random() fix if this system needs it.
6386 * crosstabs.q: Include alloca headers.
6387 (n_sorted_tab) New global var.
6388 (postcalc) Mostly rewritten.
6389 (find_pivot_extent) Rewritten.
6390 (enum_column_values) Rewritten.
6392 * data-out.c: (convert_F) Rename inner n as n_spaces.
6394 * error.c: (dump_message) Don't have an outer var i.
6396 * file-handle.q: (static var f) Removed. All references removed.
6397 (internal_cmd_file_handle) Uses a local variable instead of f.
6399 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6400 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6403 * getline.h: Declare getl_history as extern. Reported by
6404 palme@uni-wuppertal.de (Hubert Palme).
6406 * postscript.c: (postopen) Some large mods for constness.
6408 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6411 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6413 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6414 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6417 * avl.c, avl.h: New files. These form a clean-room
6418 reimplementation of avllib. Iterative algorithms are used in
6419 place of recursive ones, so there is no resemblance in the code.
6421 * Lots of headers: Don't include other headers by default.
6423 * Lots of source files: Explicitly include all needed headers.
6425 * arena.c: (arena_clear) New function.
6427 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6428 (static var ar) Removed.
6429 (staitc vars ar_tc, ar_col) New.
6430 (cmd_crosstabs) Destroy the arenas.
6431 (internal_cmd_crosstabs) Create the arenas.
6432 (precalc) Don't need a free function for the hash.
6433 (calc_general) Make sure to zero out the trailer on the key data
6435 (print_table_entries) Updated.
6436 (postcalc) Worked on actually implementing.
6437 (find_pivot_extent) New function.
6438 (compare_value) New function.
6439 (enum_column_values) New function.
6441 * data-in.c: (parse_month) Make local array `static const'.
6443 * data-out.c: (convert_date) Make local array `static const'.
6444 (convert_WKDAY) Same.
6445 (convert_MONTH) Same.
6447 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6448 been renamed to avl_walk().
6450 * hash.c: Rewritten more efficiently.
6452 * hash.h: Add attribute const to hsh_next_prime declaration.
6454 * lexer.c: (id_match) Make arguments const.
6456 * postscript.c: (ps_postopen_driver) Make default fonts the
6459 * q2c.c: (main) Generated code needs stdlib.h.
6461 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6462 initialized to 0 now, not to NULL. All other references to
6463 avl_traverser were updated in the same way.
6465 * tokens.h: Macro version of id_match updated to use const
6468 * val-labs.c: (inc_ref_count) New function.
6469 (copy_value_labels) Simply through use of new avl_copy() function.
6471 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6473 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6474 (postcalc) Worked on this.
6476 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6477 (struct ps_driver_ext) New line_width_thick member.
6478 (ps_preopen_drive) Init line_width_thick.
6479 (option_tab[]) Add line-* options.
6480 (ps_option) Parse line-* options.
6481 (postopen) Add line_width_thick support. Strip leading spaces on
6482 prologue output lines.
6483 (ps_open_page) Include line_width_thick in output.
6484 (macro dump_thick_line) New.
6485 (dump_fancy_line) Support thick lines as well as double lines.
6487 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6489 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6490 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6492 * Many source files: Rename `options' to `pv_opts' as appropriate.
6494 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6496 * common.c: (xcalloc) New function.
6498 * crosstabs.q: New file. Not finished yet, though.
6500 * data-list.c: Comment fix.
6502 * error.c: Remove some old Checker cruft.
6504 * frequencies.q: (dump_full) Cumulate valid percent instead of
6507 * getline.c: Comment fix.
6509 * hash.c: Comment fixes.
6511 * hash.h: (struct hsh_table) Make hash functions return unsigned
6512 instead of int to avoid problems with taking the modulo of
6513 negative return values. All references changed.
6515 * misc.c: (intlog10) Make its table static const instead of auto.
6517 * sfm-read.c: (read_header) Make `prefix' static const instead of
6520 * var.h: (union value) Add member `hash'.
6521 (struct variable) Rename prv_index as `foo'--all references
6523 (typedef pv_opts) Removed. All references changed.
6525 * vars-prs.c: (parse_variables) Message fixes.
6527 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
6529 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
6530 they are being inserted. Don't check for BY variables of
6531 different types. Discard variables if the active file isn't
6532 included in the merge.
6533 (mtf_processing) Essentially rewritten.
6534 (mtf_merge_dictionary) Check for master/slave variables of
6535 different types/widths.
6537 * vfm.c: (static var not_canceled) New var.
6538 (process_active_file) Don't call vfm_source->read() if
6539 there's no vfm-source. Initialize not_canceled.
6540 (process_active_file_write_case) Honor and update not_canceled.
6541 (prepare_for_writing) Rollback changes from yesterday, they were
6543 (close_active_file) Don't destroy vfm_source unless it exists.
6545 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
6547 * Lots of source files: Added { } around nested if/else constructs
6548 to avoid new gcc 2.8 warnings.
6550 * data-in.c: (parse_Z) Declare `int' type explicitly.
6553 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
6554 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
6555 prev members. Put TABLEs at the end of the chain and FILEs at the
6556 beginning. Don't allow the active file in STATE_INIT. Use proper
6557 `seen' value for the active file. Fill out the by members and
6558 make sure they're of consistent type. Do the actual merge
6560 (mtf_processing_finish) New function.
6561 (var_type_description) New function.
6562 (mtf_free_file) New function.
6563 (mtf_free) Rewritten.
6564 (mtf_delete_file_in_place) New function.
6565 (mtf_read_nonactive_records) New function.
6566 (mtf_compare_BY_values) New function.
6567 (static var mtf_seq_no) New var.
6568 (mtf_processing) New function.
6569 (mtf_merge_dictionary) Assign nval members for the system file
6570 dictionary. Assign fv values for its variables. Point each slave
6571 variable to the corresponding master variable.
6573 * hash.c: Include str.h.
6575 * mis-val.c: (copy_missing_values) src arg is const.
6577 * misc.c: (spacing) Make `max' var explicitly int.
6579 * sfm-read.c: (dump_dictionary) Message reformatting.
6580 (sfm_read_case) Add assertion.
6582 * sort.c: Esthetic fixes.
6584 * var.h: (struct match_files_proc) New struct.
6585 (struct variable) Add private data match_files_proc.
6587 * vars-atr.c: (delete_variable) Implement. Add argument for the
6588 dictionary that owning the variable.
6589 (dup_variable) Add assertion.
6591 * vfm.c: Comment fixes, hopefully the comments are correct now.
6592 (process_active_file) New function.
6593 (process_active_file_write_case) New function.
6594 (process_active_file_output_case) New function.
6595 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
6597 (write_case) Renamed procedure_write_case(). Now write_case is a
6598 pointer to a function. Style fixes.
6600 1998-03-05 Ben Pfaff <blp@gnu.org>
6602 * Makefile.am: (q2c) Link with libmisc.
6603 (version.c) Define default_config_path, include_path,
6606 * ascii.c: (ascii_postopen_driver) When the default newline string
6607 is requested, open file in text mode. Suggested by
6608 palme@uni-wuppertal.de (Hubert Palme).
6609 (static vars line_buf, line_p) Change from char * to unsigned char
6611 (ascii_close_page) char * to unsigned char *.
6613 * cmdline.c: (parse_command_line) Implement -r option by
6614 prepending ~/.pspp/rc to the list of files to process.
6616 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
6617 before pulling in a final line.
6618 (null_func, null_int_func) Removed (dead code).
6620 * descript.q: (display) Calculate width of variable name column
6621 properly. Calculate number of valid cases properly. Reported by
6622 palme@uni-wuppertal.de (Hubert Palme).
6624 * filename.c: (init_filename) Use default_config_path instead of
6625 now obsolete CONFIG_PATH.
6627 * getline.c: (getl_initialize) Use include_path instead of now
6628 obsolete INCLUDE_PATH.
6629 (getl_add_file) New argument `where'. All references changed.
6631 * groff.c: (find_font_file) Use groff_font_path instead of now
6632 obsolete GROFF_FONT_PATH.
6634 * postscript.c: (find_ps_file) Use groff_font_path instead of now
6635 obsolete GROFF_FONT_PATH. Copy through temporary variable to
6636 avoid problems with constness.
6638 * str.h: (macro cs_streq) New macro.
6640 * version.h: (glob var default_config_path, include_path,
6641 groff_font_path) New vars.
6643 1998-02-23 Ben Pfaff <blp@gnu.org>
6645 * Many source files: Change verbose_msg() priority levels and
6648 * aggregate.c: Include debug-print.h.
6650 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
6652 (static var pre_syntax_message) Document --safer/-s and
6655 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
6657 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
6658 because it's not used but it's still copied.
6659 (open_file_r) Remove gratuitous debug message.
6661 * filename.c: (safety_violation) New function.
6662 (open_file) Remove gratuitous debug messages. Don't allow pipe
6663 files if set_safer is set.
6665 * get.c: Turn off debugging.
6667 * getline.c: (getl_add_virtual_file) New function.
6668 (getl_read_line) Add verbose_msg() call for opening new syntax
6670 (getl_perform_delayed_reset) Add a return value describing whether
6671 any action was taken. Call reset_eof().
6673 * getline.h: Comment fix.
6675 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
6676 place of incorrect `continue'. Use strtok_r() instead of
6677 strtok(). Always check strtok_r() return value.
6678 (groff_read_DESC) Use strtok_r() instead of strtok().
6680 * lexer.c: (reset_eof) New function.
6682 * main.c: (parse) Get a token after performing a delayed reset
6683 action; allow empty syntax files.
6685 * postscript.c: (output_encodings) Use strtok_r() instead of
6688 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
6690 * set.q: Comment fixes.
6691 (glob var set_safer) New var.
6692 (internal_cmd_set) Support SAFER.
6694 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
6696 * temporary.c: (free_dictionary) Set d->splits to NULL after
6699 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
6700 variable deleted, not if it *isn't* deleted.
6702 1998-02-16 Ben Pfaff <blp@gnu.org>
6704 * command.c: (array cmd_table[]) Add MATCH FILES.
6706 * common.c: Comment fixes.
6708 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
6709 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
6710 Include alloca.h. Problem reported by palme@uni-wuppertal.de
6713 * expr-opt.c: Include str.h. Problem reported by
6714 palme@uni-wuppertal.de (Hubert Palme).
6716 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
6717 (static var mtf_by) Change from char ** to variable **.
6718 (static var mtf_master) New var.
6719 (mtf_merge_dictionary) New function.
6720 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
6721 var type. Reorder tests properly. Initialize file->dict. Detect
6722 TABLE= without BY=. Read file dictionaries and merge them. Give
6723 subcommand name with IN, LAST, FIRST error messages. Create IN,
6724 LAST, FIRST variables. Comment fixes.
6725 (mtf_free) Don't free default_dict. Free mtf_master.
6727 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6729 (handle_line_buffer) Cast int to size_t in comparison to avoid
6732 * getline.h: Declare getl_mode extern.
6734 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6735 (groff_read_DESC) Make line_size a size_t.
6736 (match_tok) Parenthesize name to avoid macro expansion.
6738 * mis-val.c: (copy_missing_values) New function.
6740 * postscript.c: (postopen) Make buf_size a size_t.
6742 * sfm-read.c: (dump_dictionary) Make global from static. Print
6743 variable info in parts for easier debugging with Checker.
6745 * temporary.c: (copy_variable) Use copy_value_labels().
6746 (new_dictionary) New arg: whether to copy file label, documents.
6748 * val-labs.c: (copy_value_labels) New function.
6750 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6752 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6754 (dup_variable) Set prv_index, get.fv, get.nv.
6756 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6758 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6760 * Many source files: For ANSI-compliance, add empty statement
6761 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6762 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6764 * data-in.c: (parse_numeric) Some header files break on
6765 -DBL_MIN_10_EXP because they get a --; add () for safety.
6766 Reported by palme@uni-wuppertal.de (Hubert Palme).
6768 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6769 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6770 (dfm_close) Use close_file_ext.
6771 (open_inline_file) Set file.file to NULL, not file.
6772 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6773 struct and use open_file_ext().
6774 (read_record) Use file.file.
6776 * file-handle.q: (prepend_current_directory) Pass through special
6779 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6780 (normalize_filename) Pass through special filenames.
6781 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6783 (dirname) Rename blp_dirname() because of name conflict on some
6784 OS. All references changed. Reported by palme@uni-wuppertal.de
6786 (is_special_filename) New function.
6788 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6789 (trim_dictionary) Conditionalize some of the options on whether
6790 GTSV_OPT_MATCH_FILES is in *options.
6791 (rename_variables) Don't allow variables to be renamed as scratch
6793 (MTF_*) New enum series.
6794 (struct mtf_file) New struct.
6795 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6797 (cmd_match_files, mtf_free) New functions.
6799 * lexer.c: (match_int) Needed parentheses around name to escape
6800 macro expansion. Reported by Micah Altman
6801 <maltman@www-vdc.fas.harvard.edu>.
6803 * print.c: Needed to include alloca.h. Reported by Micah Altman
6804 <maltman@www-vdc.fas.harvard.edu>.
6806 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6807 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6810 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6811 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6813 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6815 * html.c: (struct html_driver_ext) Move into htmlP.h.
6816 (html_preopen_driver) Initialize cp_x, cp_y.
6817 (html_submit) Implement as call to output_tab_table().
6818 (change_attributes) New function.
6819 (escape_string) New function.
6820 (output_tab_table) New function.
6822 * list.q: (write_all_headers) Add code for writing headers for the
6824 (clean_up) Write out the html close-table tag.
6825 (determine_layout) Ignore html driver.
6826 (list_cases) Write html data.
6828 * som.c: (som_submit) Move more of the code into output_table().
6830 * tab.c: (static var hit) Make a global var and rename tab_hit.
6831 (static var tab_table_class) Make a global var.
6833 * htmlP.h: New file.
6835 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6837 * dump-sysfile.c: Removed.
6839 * html.c: (preclose) Change comment in emitted code.
6841 * matrix-data.c: Debugging off by default. Comment fixes.
6842 (static var container) New var.
6843 (cmd_matrix_data) Create and destroy container. Initialize
6844 is_per_factor[] to 0s. Move code into new function
6845 string_to_content_type(). Require split values to be present in
6846 the data when ROWTYPE_ is explicit. Call specific function, not
6847 general read_matrices().
6848 (string_to_content_type) New function.
6849 (context) Exclude all whitespace, not just spaces.
6850 (mget_token) A dot is a number. Add assertion.
6851 (static var data) Renamed nr_data.
6852 (static var factor_values) Renamed nr_factor_values.
6853 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6854 only specific case. Close data_file before exit.
6855 (fill_matrix) New function.
6856 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6857 printing. Style fixes. Message fixes. Move code into
6859 (read_matrices_without_rowtype) Rename
6860 matrix_data_read_without_rowtype(). Fix off-by-one error on
6861 loops. Allocate nr_data[] memory from arena.
6862 (read_matrices_with_rowtype) Removed.
6863 (read_splits) Renamed nr_read_splits(). Style fixes.
6864 (read_factors) Renamed nr_read_factors().
6865 (dump_cell_content) Comment fixes. Arguments changed. Change
6866 debug printing. All references changed.
6867 (output_data) Renamed nr_output_data().
6868 (static var wr_content) New var.
6869 (struct factor_data) New struct.
6870 (static var wr_data) New var.
6871 (static var wr_current) New var.
6872 (matrix_data_source_destroy_source) Removed.
6873 (read_matrices_with_rowtype) New function.
6874 (matrix_data_read_with_rowtype) New function.
6875 (wr_read_splits) New function.
6876 (compare_factors) New function.
6877 (wr_output_data) New function.
6878 (wr_read_rowtype) New function.
6879 (wr_read_factors) New function.
6880 (wr_read_indeps) New function.
6881 (glob var matrix_data_source) Make destroy_source member NULL as
6884 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6886 * lexer.c: (syntax_error) Give better error message when at end of
6889 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6890 N_SCALAR to output as plain N.
6891 (mdump_token) Change output format.
6892 (context) Fix message output interaction with spaces in input.
6893 (another_token) New function.
6894 (force_eol) Improved error message.
6895 (static var max_cell_index) New var.
6896 (read_matrices) Init `cells'. factor_values is now per-cell.
6897 Init max_cell_index.
6898 (read_data_lines) Replace `compare' local with new `compare' arg.
6899 Debugging messages changed. Only read factors if per_factor.
6900 Propagate error return from read_factors(), force_eol().
6901 Copy N_SCALAR values across the N vector.
6902 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6903 check parentheses manually since we now have is_per_factor[].
6904 Call read_data_lines() with new args. Check for end of data after
6905 looping, using another_token().
6906 (read_factors) Arguments changed. Use max_cell_index to determine
6907 whether to read or compare factors. Message fixes.
6908 (dump_cell_content) New function.
6909 (output_data) Completely rewritten because content types were
6910 supported to be nested inside factor values, not vice versa.
6912 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6914 * lexer.c: (syntax_error) Support formatted varargs messages.
6916 * matrix-data.c: Turn debugging on by default.
6917 (static content_type[]) New array.
6918 (static content_names[]) New array.
6919 (static rowtype_, varname_) New vars.
6920 (static is_per_factor[]) New array.
6921 (static split_values) Moved declaration.
6922 (static n_continuous, first_continuous) New var.
6923 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6924 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6925 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6926 Check for continuous variables.
6927 [DEBUGGING] (debug_print) Remove content_names[].
6928 (mdump_token) New macro.
6929 (mget_token_dump) New function.
6930 (mdump_token) New function.
6931 (context) New function.
6932 (mget_token) Fix messages.
6933 (static var data, split_values, factor_values) New vars.
6934 (read_matrices) Manage split_values, factor_values.
6935 (read_data_lines) New function.
6936 (read_matrices_without_rowtype) Implemented.
6937 (read_splits) Message fixes. Uses `just_read'.
6938 (read_factors) New function.
6939 (output_data) New function.
6940 (matrix_data_source_destroy_source) Close the file handle.
6941 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6944 * str.c: (strpadcmp) Removed.
6946 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6948 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6950 * Lots of source files: Add cast to unsigned character to calls to
6951 tolower() and toupper().
6953 * aggregate.c: Set default_dict.splits to NULL.
6955 * command.c: (static variable tab[]) Add MATRIX DATA.
6957 * data-in.c: Add debugging defines. Formatting fixes.
6959 * expr-opt.c: Formatting fixes.
6961 * lexer.c: (syntax_error) Message fixes.
6963 * matrix-data.c: New enum series.
6964 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6965 split_values, n_factors, factors, cells, pop_n, contents,
6966 n_contents) New vars.
6967 (cmd_matrix_data) Finished implementation.
6968 (compare_variables_by_mxd_vartype) New function.
6969 [DEBUGGING] (debug_print) New function.
6970 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6971 (read_matrices) New function.
6972 (read_matrices_without_rowtype) New function.
6973 (read_matrices_with_rowtype) New function.
6974 (read_splits) New function.
6975 (mget_token) New function.
6976 (force_eol) New function.
6977 [0] (test_tokenizer) New function.
6978 (matrix_data_source_destroy_source) New function.
6979 (glob var matrix_data_source) New var.
6981 * misc.h: Include ieeefp.h if present.
6983 * split-file.h: (cmd_split_file) Changes corresponding to struct
6986 * str.h: Fix memmem prototype.
6988 * temporary.c: (save_dictionary, restore_dictionary,
6989 free_dictionary) Changes corresponding to struct dictionary
6992 * var.h: (MXD_* enums) New enum series.
6993 (struct matrix_data_proc) New struct.
6994 (struct split) Removed.
6995 (struct dictionary) Changed `splits' member from `split *' to
6997 (macro force_create_variable) New macro. Replaced lots of
6998 create_variable()/assert() calls with calls to this macro.
7000 * vars-atr.c: (discard_variables) Changed assertion.
7001 [GLOBAL_DEBUGGING] (force_create_variable) New function
7002 called by the macro of the same name.
7003 (clear_variable) Changes to delete splits from the dictionary
7004 corresponding to struct dictionary changes.
7006 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7007 corrupted variable `index' values in the dictionary passed in
7008 every time this function is called.
7010 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7011 to struct dictionary changes.
7013 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7015 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7017 * command.c: New includes.
7018 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7019 (cmd_erase) New function.
7020 [unix] (shell) New function.
7021 (run_command) New function.
7022 (cmd_host) New function.
7023 (cmd_new_file) New function.
7025 * expr-prs.c: (parse_primary) Message fix.
7027 * inpt-pgm.c: Formatting fix.
7028 (cmd_reread) Implement the FILE subcommand.
7030 * matrix-data.c: New file.
7032 * q2c.c: (dump_header) Change output commenting style.
7034 * weight.c: Comment fix.
7036 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7038 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7040 (buf_10x) Renamed buf_1xx, all references changed.
7041 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7042 cases now implemented).
7043 (create_sysfile) New function.
7044 (agr_11x_func) New function.
7046 * data-in.c: (parse_numeric) Work properly if there's an
7047 explicitly coded decimal point in the data and decimal places are
7048 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7049 <el@linux.lisse.na>.
7051 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7052 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7053 Eberhard W Lisse <el@linux.lisse.na>.
7055 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7056 strerror.c. Bug reported by Alexandre Oliva
7057 <oliva@dcc.unicamp.br>.
7059 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7060 (static var separate_case_tab) New var.
7061 (cmd_sort_cases) Cancel temporary transformations here. Free
7062 v_sort before return.
7063 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7064 we're reading from a sort stream. Don't cancel temporary
7065 transformations. Offload internal sorting to do_internal_sort().
7066 (do_internal_sort) New function. Handles internal sorting even
7067 when SEPARATE is nonzero. Doesn't free v_sort.
7068 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7070 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7071 sink if SEPARATE is zero.
7072 (read_output_cases) Renamed read_sort_output(), all references
7073 changed. Now uses separate_case_tab when it exists.
7074 (write_separate) New function.
7076 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7077 memory_sink_cases. Don't redundantly call
7078 vfm_source->destroy_source().
7079 (memory_stream_mode) After switching over, set memory_sink_cases
7082 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7084 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7086 (static var prev_case) New, moved out of aggregate_single_case()
7088 (static var buf64_10x, buf_10x) New.
7089 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7090 the 000, 001, 100, and 101 cases. Free prev_case.
7091 (parse_aggregate_functions) Disallow scratch variables.
7092 (free_aggregate_functions) Only free agr_dict if non-null. Use
7093 iter->function to determine numeric/string type, not
7095 (aggregate_single_case) Don't manage prev_case. Initialize
7096 aggregate info after dumping it.
7097 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7098 mean, stddev, weighted stddev definitions.
7099 (dump_aggregate_info) Implemented.
7100 (initialize_aggregate_info) Renamed from
7101 initialize_aggregate_functions(). Initializes dbl[2].
7102 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7103 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7105 * cases.c: (alloc_val) Removed.
7107 * get.c: (cmd_save_internal) Initialize new `dict' member.
7109 * sfm-write.c: (sfm_write_dictionary, write_header,
7110 write_variable, write_value_labels, write_documents) Reorganize,
7111 simplify for new parameter structure.
7112 (write_variable) Only one variable * argument now.
7114 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7115 replaced by new `dict' member.
7117 * temporary.c: (new_dictionary) Initialize n_documents.
7119 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7121 (init_variable, replace_variable) Eliminate usage of alloc_val().
7123 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7125 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7126 signal that AGGREGATE is to be used for forming final cases.
7127 (close_active_file) Call end_func before stopping lagging. Cancel
7128 temporary after finishing compaction.
7129 (write_case) Comment fixes. Cleaned up.
7130 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7133 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7135 * Makefile.am: (BUILT_SOURCES) Add means.c.
7136 (pspp_SOURCES) Add means.c.
7137 (EXTRA_DIST) Add means.q.
7139 * command.c: (array cmd_table[]) Add MEANS.
7141 * common.h: Esthetic fixes. Comment fixes. Test for
7142 MAX_SHORT_STRING greater than 8.
7143 (macros LOWEST, HIGHEST) New.
7145 * data-in.c, data-list.c, recode.c: Comment fixes.
7147 * means.q: New file, base version.
7149 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7150 with LOWEST, DBL_MAX with HIGHEST.
7152 * q2c.c: (dump_vars) Add an enum to array types giving the number
7153 of values for the enum.
7155 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7156 Replace second_lowest_value with second_lowest_flt64.
7158 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7159 second_lowest_value with second_lowest_flt64.
7161 * t-test.q: Comment fix.
7163 * temporary.c: (restore_dictionary) Esthetic fix.
7165 * tokens.h: (force_match_id, force_match, force_string, force_int,
7166 force_num, force_id) Replace msg() with syntax_error().
7168 * var.h: (struct means_proc) New.
7169 (struct variable) Add mns member to `p' union.
7171 * vars-prs.c: (parse_variable, parse_dict_variable,
7172 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7175 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7177 * Makefile.am: (pspp_SOURCES) Add tab.h.
7179 * Most source files: Added a cast to unsigned char in usages of
7180 the ctype is*() functions. Replaced `end of command expected'
7181 calls to msg() with calls to syntax_error().
7183 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7185 * lexer.c: (hex_val) Removed (was dead code).
7186 (idmatch) Parenthesize function name to avoid macro expansion.
7188 * postscript.c: Comment fixes.
7189 (ps_preopen_driver) Change default font size to 10pt.
7191 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7193 (parse_format_spec) Change system-file format spec argument type
7194 to int32. Parse the format spec with bitwise operators.
7196 * sfmP.h: (struct sysfile_format) Removed.
7197 (struct sysfile_variable) Changed print, write members from
7198 sysfile_format to int32.
7200 * tokens.h: Esthetic fixes.
7201 [__GNUC__] (macro id_match) New macro to hopefully speed up
7202 identifier matching.
7203 (macros match_id, match_tok, match_int) Implemented in
7204 compiler-independent manner; no longer GNU C only.
7206 * vfm.h: Include time.h.
7208 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7210 * data-list.c: (dump_fixed_table) Change tab_dim().
7212 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7214 * error.c: Include command.h.
7216 * frequencies.g: Formatting fixes.
7218 * frequencies.q: Add tab_dim() calls. Make the total cell a
7221 * glob.c: Include command.h.
7223 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7225 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7226 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7227 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7228 the other elements (is this right?).
7229 (read_variables) Use lowest, highest members.
7230 (parse_format_spec) New arg `vv' for more stringent checking.
7231 (dump_dictionary) Byteswaps nonexplicit data.
7232 (sfm_read_case) Byteswap numeric data.
7234 * som.c: Initialize table_num to 1.
7235 (render_segments) Remember to increment y_index after each table
7238 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7239 avl_count() on a NULL tree. No title for the second table.
7240 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7241 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7242 fix call to display_variables().
7243 (display_variables) Default to 4 columns, not 3. Set up headers.
7244 Column title is Variable, not Name. Fix index column.
7245 Add joint text. Add tab_dim(). Handle value labels properly.
7246 Handle DISPLAY LABELS properly. Draw boxes correctly.
7247 (describe_variable) Value labels don't need titles. Don't clear
7248 nonexistent index column.
7249 (compare_vectors_by_name) New function.
7250 (display_vectors) New function.
7252 * tab.c: (tab_height) Add assertion.
7253 (tab_null) Add debug code.
7254 (evaluate_dimensions) Add debug code.
7256 * var.h: (struct variable) get_proc data is sometimes used
7257 simultaneously with other per-procedure info, therefore it was
7258 removed from the union. All references changed.
7260 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7262 * ascii.c: (ascii_close_page) Put title on second line of headers
7263 if there is no subtitle.
7265 * command.c: (glob var cur_proc) Move definition here, from
7267 (cmd_remark) Emit blank line before remarks.
7269 * command.h: (glob var cur_proc) Move declaration here, from
7272 * data-list.c: (dump_fixed_table) Fix messages.
7273 (dump_free_table) Call tab_nat_dim().
7275 * descript.q: (dump_z_table) Modify tab_dim() call.
7277 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7279 (dump_statistics) Don't output header.
7281 * groff-font.c: Minor format fix.
7283 * html.c: Comment fix.
7285 * list.q: (write_varname) Indent after advancing page.
7287 * output.h: Minor reordering.
7289 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7290 a reference to eol[].
7291 (struct ps_driver_ext) New member eol[].
7292 (ps_preopen_driver) Initialize eol[].
7293 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7294 defaults. Handle headers. Fix test for minimum page length.
7295 (static var option_tab[]) Add `line-ends'.
7296 (ps_option) Handle line-ends to change eol[].
7297 (postopen) Scale prop_em_width and fixed_width properly. Set the
7298 prologue title to outp_title if applicable. Replace the prologue
7299 line ends with eol[]. Call draw_headers() if headers are enabled.
7300 (text_width) New function.
7301 (out_text_plain) New function.
7302 (draw_headers) New function.
7304 * print.c: (dump_table) Call tab_nat_dim().
7306 * som.c: (som_blank_line) Only advance a line if not at the top of
7308 (som_submit) Move several informational table calls here.
7309 Increment subtable_num if SOMF_NO_TITLE not set.
7310 (output_table) Advance a line if SOMF_NO_SPACING not set.
7311 (render_columns, render_segments, render_simple) Handle spacing
7312 between tables. Handle table titles. Remove debug output.
7314 * som.h: (SOMF_*) New enum series.
7315 (struct som_table_class) New member `flags'.
7317 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7319 (display_variables) Calls tab_nat_dim().
7320 (describe_variable) Remove restriction on number of value labels.
7321 Make value labels separated by thin lines.
7323 * tab.c: (tab_create) Default `flags' to none.
7324 (tab_float) New arg `w'. All references changed.
7325 (tab_nat_dim) New function.
7326 (tab_output_text) No title or spacing.
7327 (tab_flags) New function.
7328 (tabi_flags) New function.
7329 (tabi_title) New function.
7330 (strip_height) Removed.
7331 (tabi_render) Skip title when necessary.
7332 (static var tab_tab_class) Add tabi_flags, tabi_title.
7333 (evaluate_dimensions) Disable display of column, row size.
7334 (sum_columns) Add title height to top header.
7335 (render_strip) Moved within file.
7337 * tab.h: (struct tab_table) New member `flags'.
7339 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7341 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7343 * Most source files: Add `const' attribute in all appropriate
7346 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7347 column to the variables table for use by describe_variable().
7348 (cmd_display) Disable for the present.
7349 (display_documents) Don't wrap documents.
7350 (display_variables) Table has four columns now.
7351 (describe_variable) Table has four columns now. Don't use a
7352 subtable, use joined cells instead.
7354 * tab.c: (tab_create) Don't set `join'.
7355 (tab_realloc) ct array is not made up of a_string's.
7356 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7357 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7358 (text_format) New function.
7359 (tab_title) Rewritten, uses text_format().
7360 (tab_text) Rewritten, uses text_format().
7361 (tab_joint_text) New function.
7363 (static var hit) New variable.
7364 (render_strip) New args r1, r2. Implement joined cells that fit
7366 (tabi_render) Increment hit. Pass new args to render_strip().
7367 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7368 cells. For t_naw and t_nah, ignore joined cells and null cells in
7371 * tab.h: (struct tab_join_rect) Removed.
7372 (struct tab_table) Removed `join'.
7373 (TAB_JOIN_MAIN) Removed.
7374 (struct tab_joined_cell) New struct.
7375 (TAT_NOWRAP) New enum.
7377 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7379 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7381 (ascii_postopen_driver) Fix initialization of *_spacing so that
7382 the TAL_0 bit doesn't count.
7384 * data-list.c: (dump_fixed_table) Use natural width for Format
7387 * glob.c: (rerange) Removed.
7388 (get_date) Formatting fixes. Internationalization fix.
7390 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7393 * postscript.c: (ps_postopen_driver) Replace
7394 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7396 * som.c: (som_submit) Don't eject page before every table.
7397 (output_table) Fix order of arguments on call to area().
7398 (render_columns) Fix calculation of max_len.
7400 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7401 (render_strip) New function.
7402 (strip_height) New function.
7403 (tabi_render) Rewrite as calls to render_strip().
7405 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7406 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7407 with the TAB_* and OUTP_T_* constants.
7409 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7411 * Makefile.am: Formatting fixes.
7413 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7416 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7418 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7420 * dump-sysfile.c: (glob var length) Make type off_t.
7421 (usage) Fix arguments.
7424 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7425 Now right-justification is the default so many references had to
7427 (struct outp_class) Removed line_width, all references changed.
7428 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7429 (struct outp_driver) Add elements horiz_line_width,
7430 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7433 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7435 (postopen) Initialize all the informational members of
7438 * som.c: (som_blank_line) New function, renamed from blank_line(),
7439 all references changed.
7440 (som_submit) Disables drivers whose pages can't be opened.
7441 (render_columns, render_simple, render_segments) Add debug output.
7442 (render_columns) Fix loop range.
7443 (render_simple) Don't try to render the headers, they're taken
7444 care of automatically. Advance cp_y past the table when done.
7445 (render_segments) Fix loop ranges.
7447 * tab.c: Initialize new members of tab_table.
7448 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7449 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7450 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7453 (tab_dim) New function.
7454 (tab_col_width) Removed.
7455 (tab_row_height) Removed.
7456 (tab_output_text) Call tab_dim().
7457 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7458 (tabi_area) Implemented.
7459 (tabi_cumulate) Implemented.
7460 (tabi_render) Partially implemented, but broken.
7461 (var tab_table_class) Made static.
7462 (evaluate_dimensions) New function.
7463 (sum_columns) New function.
7465 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7466 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7467 t_scr, t_srr, t_sentinel. Removed: t_nat.
7468 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7469 max_stack_height, w, h. Removed: ce, re.
7470 (macro blank_line) Removed.
7471 (glob var zero_length) Removed.
7473 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7475 * Most source files: include some of the new include files broken
7478 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7481 * aggregate.c: (glob var outfile) Make static.
7483 * command.c: (glob var pgm_state) Move here.
7485 * common.c: (glob vars endian, second_lowest_value, pgmname,
7486 finished, curdate, cur_proc, start_interactive, history_file) Move
7489 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7491 * file-handle.q: (glob vars files, inline_file) Move here.
7493 * glob.c: Lost lots of glob vars, detailed in individual file
7495 (init_glob) set_printer, set_screen were obsolete, deleted.
7496 set_cprompt has fewer spaces because pspp has fewer letters than
7499 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7500 (inp_nval) Made static.
7502 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7503 tokstr_len, toklongstr, tokint) Move here.
7505 * misc.c: Lost several vars and functions.
7507 * set.q: (all the set_* variables) Move here.
7509 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
7510 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
7513 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
7515 * tab.h: (enum series t_*) New enums.
7516 (struct tab_table) Use arena struct tag. New members ce, re.
7518 * tokens.h: Comment fixes.
7520 * var.h: Move lots of enums and variables and functions and
7521 structures to other files. Use and declare a lot more union and
7522 struct tags. Comment fixes.
7524 * vector.c: (glob vars vec, nvec) Move here.
7526 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
7527 init_blanks, last_vfm_invocation) Move here.
7529 * cases.h: New file.
7530 (struct long_vec) Move here.
7531 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
7534 * command.h: New file.
7535 (STATE_* enums) Move here.
7536 (glob var pgm_state) Move here.
7538 * format.c: New file.
7539 (glob var formats) Move here.
7540 (parse_format_specifier_name, fmt_to_string,
7541 check_input_specifier, check_output_specifier,
7542 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
7545 * format.h: New file. Move functions now in format.c here.
7546 (FMT_* enums) Move here.
7547 (struct fmt_desc) Move here.
7548 (FCAT_* enums) Move here.
7549 (struct fmt_spec) Move here.
7550 (glob vars formats, fmt_parse_ignore_error) Move here.
7552 * inpt-pgm.h: New file.
7553 (INP_* enums) Move here, make #defines into enums.
7554 (glob vars inp_init, inp_init_size) Move here.
7557 (glob vars v_sort, nv_sort) Move here.
7558 (sort_cases, read_sort_output) Move here.
7560 * vector.h: New file.
7561 (struct vector) Move here, add struct tag.
7562 (glob vars vec, nvec) Move here.
7563 (find_vector) Move here.
7566 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
7567 reinit_blanks, init_zero, init_blanks) Move here.
7568 (struct case_stream) Move here.
7569 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
7570 vfm_disk_stream, sort_stream, data_list_source,
7571 input_program_source, file_type_source, get_source, n_lag) Move
7573 (procedure, write_case, lagged_case, compact_case, page_to_disk)
7576 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
7578 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
7579 (LDADD) Add libdcdflib.
7581 * ascii.c: Comment and formatting fixes. Almost every external
7582 function had an assert added, checking driver_open and page_open.
7583 (ascii_init_driver) Broken into ascii_preopen_driver,
7584 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
7585 (ascii_open_page) Sets page_open.
7586 (ascii_close_page) Clears page_open.
7588 * html.c: Comment and formatting fixes. Almost every external
7589 function had an assert added, checking driver_open and page_open.
7590 (html_init_driver) Broken into html_preopen_driver,
7591 html_postopen_driver, html_close_driver. Manages driver_open.
7592 (html_open_page) Sets page_open.
7593 (html_close_page) Clears page_open.
7594 (html_submit) Disabled.
7596 * lexer.c: (parse_string) Remove debugging printf.
7598 * list.q: (determine_layout) Open a page if one is not yet open.
7600 * output.c: Comment fixes.
7601 (add_class) Set the class member of the new list element.
7602 (parse_options) Don't handle device type.
7603 (colon_tokenize) New function.
7604 (configure_driver) New four-field format with a field for device
7605 type. Now initialize driver_open, page_open, next, and prev
7606 fields. Use new colon_tokenize() function. Don't do a memory
7607 copy to replace a driver, it doesn't work; instead delete the old
7608 driver and insert a new one.
7609 (destroy_driver) Don't call som_destroy_driver(). Close the page
7610 if it's open. Find the class in the list of classes and decrement
7611 that reference count. Remove the driver from the global driver
7613 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
7614 references changed. Rewritten. Don't return a driver that's not
7616 (outp_eject_page) All references to som_internal_eject_page()
7617 changed to use this. Sets cp_x to 0 as well as cp_y.
7619 * output.h: (OUTP_I_* enums) Removed.
7620 (struct som_submission_form) Removed.
7621 (struct outp_class) init_driver broken into preopen_driver,
7622 postopen_driver, and close_driver. submit changed to take a
7625 * postscript.c: Comment and formatting fixes. Almost every
7626 external function had an assert added, checking driver_open and
7628 (ps_init_driver) Broken into ps_preopen_driver,
7629 ps_postopen_driver, ps_close_driver. Manages driver_open.
7630 (ps_open_page) Sets page_open.
7631 (ps_close_page) Clears page_open.
7633 * som.c: New file, base implementation.
7635 * som.h: (struct som_table) Add struct tag.
7636 (enum SOM_COL_ACROSS) Removed.
7637 (SOM_ROWS, SOM_COLUMNS) New enums.
7638 (struct som_table_class) Add member `cumulate'. Remove `segment';
7639 change `render' arguments.
7640 (struct som_point, struct som_rect) Removed.
7641 (som_submit_table) Fixed typo, should have been som_submit.
7643 * sysfile-info: (describe_variable) Don't try to insert a
7644 subtable; just destroy it for now.
7646 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
7647 references to value labels.
7649 * tab.c: (tab_destroy) New function.
7650 (tab_columns) Change argument.
7651 [0] (tab_submit) Remove dead code.
7652 (tab_title) Allocate string from the table's arena.
7653 (tab_output_text) Only free the buffer if we allocated it.
7654 (tab_submit) New function.
7655 (static vars t, d) New static vars.
7656 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
7657 tabi_headers, tabi_cumulate, tabi_render) New functions.
7658 (glob var tab_table_class) New global var.
7660 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
7661 encapsulate the rectangle. All references changed.
7663 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
7665 * All header files updated to use struct tags in addition to
7666 typedefs for all structures. Don't use word `struct' in struct
7669 * Makefile.am: (pspp_SOURCES) Remove html.c.
7670 (INCLUDES) Replace the lib/* includes with a single lib/ include;
7671 all references updated.
7673 * command.c: (parse_cmd) Remove call to som_check_workspace.
7674 (output_line) Update to new som.
7676 * data-in.c: (parse_numeric) A single dot is not an error; it is
7677 the system-missing value.
7679 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
7682 * data-out.c: Added `const' as appropriate to many prototypes.
7683 (convert_E, convert_F, convert_CCx) Take double argument instead
7684 of value * argument.
7685 (convert_format_to_string) Call changed functions appropriately.
7686 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
7687 make a local copy of the value.
7689 * descript.q: Remove custom_variables() prototype now provided by
7691 (custom_variables) Don't increment sbc_variables, the caller does
7693 (dump_z_table, display) Update to new som.
7695 * error.c: (vmsg) Add const to prototype. Remove code to handle
7696 `too many errors' condition.
7697 (check_error_count) New function.
7698 (msg) Add const to prototype.
7700 * filename.c: (open_file) Rewrite for elegance.
7702 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
7703 (dump_full, dump_condensed, dump_statistics) Update for new som.
7705 * list.q: Don't include somP.h. Change all references to
7706 som_driver_ext to refer to the new members of som_driver. Change
7707 som_internal_eject_page() references to outp_eject_page().
7709 * main.c: (parse) Rewrite for elegance. Add call to
7710 check_error_count().
7712 * output.c: (add_class, outp_list_classes, outp_configure_driver)
7713 Rewrite or revise for new outp_driver_class_list structure.
7714 (outp_iterate_enabled_drivers) Fix comparison between disabled
7715 devices and current device type.
7716 (outp_eject_page) New function.
7718 * output.h: Comment fixes.
7719 (struct outp_driver) New members driver_open, page_open, cp_x,
7720 cp_y, font_height, prop_em_width, fixed_width. Deleted members
7722 (struct outp_driver_class_list) New struct.
7723 (outp_class_list) Changed to type outp_driver_class_list; all
7726 * print.c: (dump_table, print_trns_proc) Updated for new som.
7728 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7729 prototypes for custom subcommands.
7730 (dump_subcommand) Always include the `else'.
7731 (dump_parser) Fix comments in output code.
7733 * set.q: Reordered functions.
7735 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7737 * som.h: Rewritten from scratch.
7739 * str.h: Remove dead code.
7741 * tab.c, tab.h: New files, base implementation.
7743 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7746 * t-test.q: New code from John Williams
7747 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7748 Many many new static vars and defines.
7749 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7750 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7751 (struct value_list) New struct.
7752 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7753 t_crt, t_sig, print_t_groups) New functions.
7754 (cmd_t_test) Implemented.
7756 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7759 * vfm.c: (dump_splits) Update to new som.
7761 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7763 * Makefile.am: (fiasco_SOURCES) Add html.c.
7765 * aggregate.c: Base source.
7767 * ascii.c: (postopen, preclose) Reformat.
7769 * data-out.c, expr-evl.c: Comment fixes.
7771 * filename.c: (open_file) When opening a file for writing, use
7772 line buffering instead of full buffering for better interactive
7773 performance. Suggested by Valerio Aimale
7774 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7775 names `stdin', `stdout', `stderr'.
7777 * groff-font.c: Comment fixes.
7779 * html.c: New file; base version.
7781 * list.q: (write_all_headers, clean_up, determine_layout,
7782 list_cases) Ignore `special' devices for now. Needs to be fixed
7785 * output.c: (outp_init) Add html driver to list; reverse list
7788 * output.h: (struct outp_class_struct) New members `special',
7789 `submit'; comment fixes. All references changed.
7791 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7792 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7794 (postopen) Comment fix.
7795 (preclose) Comment fixes, formatting fixes. Change x->file.file
7796 references to more proper f->file.
7798 * som-high.c: (som_submit_table) Special classes use their own
7801 * som.h: Comment fixes.
7803 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7806 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7808 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7810 * aggregate.c: Still working on this.
7812 * command.c: (cmd_table[]) Add AGGREGATE back in.
7813 (split_words) Make '-' a legal word separator as well as ' '.
7815 * main.c: Comment fixes.
7817 * q2c.c: (dump_parser) Don't require the procedure's full name to
7818 be present, in the generated source.
7820 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7821 multiply specified and let it be default; let MISSING, CRITERIA,
7822 FORMAT be multiply specified.
7823 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7824 (custom_groups) Fix defaults.
7825 (custom_pairs) Check whether this is a PAIRS subcommand before
7826 attempting to parse. Better garbage collection. Proper storage
7828 [DEBUGGING] (debug_print) New function.
7830 * temporary.c: Comment fixes.
7831 (copy_variable) Don't copy variable name and index.
7832 (save_dictionary) Copy variable name and index by hand.
7834 * vars-atr.c: Comment fixes.
7835 (create_variable) New dictionary argument. All references
7837 (common_init_stuff) New dictionary argument. All references
7839 (init_variable) New dictionary argument. All references changed.
7840 (dup_variable) New function.
7842 * vars-prs.c: (parse_variables) If there are any errors, we always
7843 return 0. Previously, it was possible for some types of errors to
7846 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7848 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7851 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7853 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7856 * q2c.c: Comment fixes.
7857 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7859 * t-test.q: (cmd_list) Rename cmd_t_test.
7861 * temporary.c: (new_dictionary) Don't declare as static.
7863 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7865 * aggregate.c: Changes, still not finished.
7867 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7869 * q2c.c: Comment fixes. Now its output is internationalized.
7870 (get_token) Fix parsing of escapes within literal strings.
7871 (main) Fix bad #line directives in output.
7873 * t-test.q: Base implementation.
7875 * temporary.c: (new_dictionary) New function.
7876 (restore_dictionary) [__CHECKER__] Change fill character to *
7879 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7881 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7883 * aggregate.c: Changes, still not finished.
7885 * descript.q, list.q: Comment fixes.
7887 * q2c.c: Almost completely rewritten.
7889 * t-test.q: New file, not complete.
7891 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7893 * aggregate.c: Changes, still not finished.
7895 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7898 * temporary.c: (cancel_temporary) New function.
7900 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7901 of doing it by hand.
7903 * vfm.c: (close_active_file) After restoring a TEMPORARY
7904 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7906 (SPLIT_FILE_procfunc) Comment fix.
7908 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7910 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7912 * aggregate.c: New file, not finished yet.
7914 * command.c: (cmd_table) Add AGGREGATE.
7916 * common.h: (pgm_state) Move declaration to var.h.
7918 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7920 (parse_string) Message fix.
7922 * recode.c: Comment fix.
7924 * sfm-read.c: (read_variables) Code esthetic fixes.
7925 (write_header) Default date is `Jan', not `JAN'.
7927 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7929 * sort.c: (cmd_sort_cases) Farm the work out to new function
7930 parse_sort_variables().
7931 (parse_sort_variables) New function.
7932 (sort_cases) New function. Cancels temporary transformations,
7933 which sorting didn't do previously.
7934 (cmd_sort_cases) Better garbage collection on error. Uses
7936 (write_initial_runs, merge_once) Improved code esthetics.
7937 (sort_stream_read) Reduced to one call to read_output_cases().
7938 (read_output_cases) New function.
7940 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7941 variable labels to 120 characters.
7943 * var.h: Comment fixes.
7944 (glob var pgm_state) From common.h.
7946 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7948 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7949 options. Set *names to NULL on error.
7951 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7953 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7955 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7956 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7958 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7960 * vfm.c: (page_to_disk) Added missing local variables.
7962 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7964 * get.c: Comment fix.
7966 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7967 source is anything other than a disk stream, not just if it's in a
7968 memory stream. Call page_to_disk() before external sort.
7969 (allocate_cases) Message fix.
7971 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7973 (page_to_disk) New function.
7975 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7977 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7979 * common.h: (macro strerror) Remove. From Alexandre Oliva
7980 <oliva@dcc.unicamp.br>.
7982 * get.c: (dict_delete_run) The number of variables to delete is
7983 not necessarily the number of variables that need to be shifted
7985 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7986 too many variables to be deleted.
7988 * postscript.c: Comment fix.
7990 * q2c.c: Include strerror.c. From Alexandre Oliva
7991 <oliva@dcc.unicamp.br>.
7993 * set.q: #undef ON and OFF. From Alexandre Oliva
7994 <oliva@dcc.unicamp.br>.
7996 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7997 early, otherwise errors cause a bad free().
7999 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8000 Oliva <oliva@dcc.unicamp.br>.
8002 * temporary.c: (save_dictionary) Don't allocate memory if
8005 * vfm.c: (memory_stream_write) Message fix.
8007 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8009 * command.c: (static var cmd_table[]) Define REPEATING DATA
8012 * common.h: Added support for broken systems that are missing
8013 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8015 * Many source files: Replace syntax error messages via msg() with
8016 call to syntax_error().
8018 * data-list.c: (dump_fixed_table) Add support for dumping table
8019 for REPEATING DATA as well as DATA LIST FIXED.
8020 (cmd_repeating_data) Allows and requires `/' between subcommands.
8021 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8022 CONTINUED specifications to be omitted. Forces CONTINUED to be
8023 specified if ID is. Calculates starts_end, cont_end from logical
8024 record length as reported by fhp. Calls dump_fixed_table() if
8025 requested. Fixed length of record copied by memcpy.
8026 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8028 (realize_value) Returns sensible value for out-of-range variable
8030 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8031 length of occurrences and length of line. Added warning for
8032 fields that exceed the line length. Fixed infinite loop.
8033 (read_one_set_of_repetitions) Numerous minor changes for more
8034 complete SPSS compliance. Message fixes.
8036 * dfm.c: (dfm_close) If the file being closed is the inline file,
8037 read all the remaining data before closing it.
8038 (dfm_get_record) Don't close the file on lossage, as either it
8039 has been closed already or it doesn't belong to us.
8041 * error.c: (puts_stdout) New function.
8042 (vmsg) Use puts_stdout instead of puts.
8044 * file-handle.q: (fh_record_width) New function.
8046 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8049 (input_program_source_read) Made an old kluge an approved method.
8051 * lexer.c: (syntax_error) New function.
8053 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8056 * output.c: (oupt_get_paper_size) Message fix.
8058 * q2c.c: Numerous fixes to formatting of generated code made to
8059 conform to GNU coding standards. Uses syntax_error() in generated
8060 code. Other miscellaneous generated message fixes. Added support
8061 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8062 RAND_MAX, and/or strerror().
8064 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8066 * data-in.c: Comment fixes.
8068 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8069 (find_variable_input_spec) New function.
8070 (cmd_repeating_data) Initializes id_spec.
8071 (rpd_parse_record) Implemented.
8072 (read_one_set_of_repetitions) Returns -3 by default in order to
8073 kluge out some potential bugs.
8075 * data-out.c: Comment fixes.
8077 * file-type.c: (internal_cmd_record_type) Message fix.
8079 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8080 for handling -3 return value.
8082 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8084 * data-list.c: Comment fixes.
8085 (struct dls_var_spec) Reordered members.
8086 (read_from_data_list_fixed) Restructured.
8087 (struct repeating_data_trns) Reordered members. Renamed `starts'
8088 as `starts_beg', `ends' as `starts_end'.
8089 (cmd_repeating_data) Calculates length of repeated data if
8090 necessary and possible.
8091 (parse_num_or_var) Don't allow string variables.
8092 (realize_value) New function.
8093 (rpd_msg) New function.
8094 (rpd_parse_record) New function. Currently stubbed out.
8095 (read_one_set_of_repetitions) Implemented.
8097 * inpt-pgm.c: (input_program_source_read) Comment fix.
8099 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8101 * command.c: (cmd_end_repeat_p) Removed.
8102 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8103 (parse_cmd_name) Removed.
8105 * data-list.c: Comment fixes.
8106 (data_list_pgm) Removed `eof' member.
8107 (static var first) New var.
8108 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8109 FILE TYPE file inside FILE TYPE structures.
8110 (append_var_spec) Appends to *first, not dls.spec.
8111 (parse_fixed) Message fixes.
8112 (struct rpd_num_or_var) New.
8113 (struct repeating_data_trns) New.
8114 (static var rpd) New.
8115 (cmd_repeating_data) New function.
8116 (parse_num_or_var) New function.
8117 (parse_repeating_data) New function.
8118 (read_one_set_of_repetitions) New function.
8120 * file-type.c: (cmd_file_type) Message fixes. Always
8121 default_handle to FILE TYPE file handle.
8122 (internal_cmd_record_type) Message fixes.
8124 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8126 * repeat.c: Comment fix. Disable debugging.
8128 * temporary.c: (restore_dictionary) Sets splits to NULL and
8129 n_splits to 0 before destroying the variables because now doing
8130 this tries to remove split variables.
8132 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8133 destroying the dictionary.
8134 (clear_variable) Removes a variable from splits after destroying
8137 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8139 * cmdline.c: (set_compat) Removed.
8140 (pick_compat) Removed.
8141 (parse_command_line) Removed -c option.
8142 (pre_syntax_message) Removed -c option.
8143 (usage) Remove compatibility code.
8145 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8146 (glob var compat) Removed.
8148 * compute.c: (type_check) Fixed messages about type mismatches.
8150 * data-list.c: (cmd_data_list) Removed compatibility code.
8151 (fixed_parse_compatible) Calls convert_negative_to_dash().
8152 Fixed bug where it only set the variable in fx.spec if it created
8153 the variable itself.
8154 (dump_fmt_list) Spelling fix.
8155 (cut_field) Removed compatibility code.
8157 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8160 * expr-evl.c: (evaluate_expression) Implement LAG.
8162 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8163 (parse_neg) Calls convert_negative_to_dash().
8164 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8167 * expr.h: (struct expression_struct) Removed member max_lag.
8169 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8170 (internal_cmd_record_type) Removed special handling to produce
8171 negative numbers from dash tokens.
8173 * getline.c: (static var DO_REPEAT_level) New var.
8174 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8175 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8176 copy_with_DO_REPEAT_substitutions().
8177 (getl_read_line) Maintains value of getl_mode. Calls
8178 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8180 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8182 * getline.h: (getl_mode) New glob var.
8184 * glob.c: Comment fixes.
8185 (init_glob) Restructured. Sets set_seed.
8186 (init_compat_dependent) Removed. All references removed.
8187 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8188 (__htonl, __htons) Removed. (What were these for?)
8190 * lexer.c: (static var tbl) Dash set to class CNUM.
8191 (make_hexit) New function from data-out.c.
8192 (get_token_representation) Rewritten.
8193 (convert_negative_to_dash) New function.
8194 (lex_init_compat_dependent) Removed.
8195 (yylex) A dash is parsed as part of a number if it is followed by
8196 a digit. The ASCII representation of a number is copied to
8197 tokstr. String parsing farmed out to parse_string(). Comment
8199 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8201 (preprocess_line) Line processing depends on interactive/batch
8202 mode, not on compatibility mode. Removed PC+ compatibility code.
8204 * loop.c: (loop_3_trns_proc) Comment fix.
8206 * main.c: Remove dead code.
8207 (main) Remove call to init_compat_dependent().
8209 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8212 * print.c: (parse_string_argument) Calls
8213 convert_negative_to_dash().
8214 (fixed_parse_compatible) Calls convert_negative_to_dash().
8216 * repeat.c: (RPT_* defines) Removed.
8217 (struct rpt_numeric) Removed.
8218 (struct repeat_entry) New member type, changed `replacement' from
8220 (clean_up) Deallocation adapted to new repeat_entry.
8221 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8222 usage. Creates vars for `type' of 1.
8223 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8224 (store_numeric) Rewritten, new interface.
8225 (parse_numbers) Rewritten.
8226 (parse_strings) Rewritten.
8227 (find_DO_REPEAT_substitution) New function.
8228 (perform_DO_REPEAT_substitutions) New function.
8229 (copy_with_DO_REPEAT_substitutions) Removed.
8230 (debug_print) Rewritten.
8232 * set.q: Comment fix.
8233 (custom_results) Removed compatibility code.
8234 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8237 * sysfile-info.c: (cmd_display) Removed compatibility code.
8239 * tokens.h: Comment fixes.
8240 (token types enum) Removed `toktype' typedef name for this int
8241 type. Removed SUBST. Restructured.
8243 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8245 * vars-prs.c: Comment fix.
8247 * vfm.c: Comment fixes.
8248 (glob var n_lag) New var.
8249 (static vars lag_count, lag_head, lag_queue) New vars.
8250 (procedure) Removed argument nlag.
8251 (setup_lag) New function.
8252 (close_active_file) Discards lagging state.
8253 (lag_case) New function.
8254 (lagged_case) New function.
8255 (write_case) Lags a case if lagging.
8257 * weight.c: (cmd_weight) Removed compatibility code.
8259 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8261 * getline.h: (struct getl_script) New members loop_index, macros.
8263 * getline.c: (getl_add_file) Sets first_line field to NULL.
8264 (getl_add_DO_REPEAT_file) New function.
8265 (handle_line_buffer) When the current line's length is negative,
8266 set the filename and line number. Increment line number after
8267 reading line. Pass the line to
8268 copy_with_DO_REPEAT_substitutions() for processing.
8269 (getl_close_file) Free DO REPEAT lines before freeing the
8270 filename, and just set the filename to NULL when doing this,
8271 because otherwise the filename gets freed twice.
8273 * glob.c: (glob var queuing) Removed. All references removed.
8275 * lexer.c: Comment fixes.
8276 (get_token_representation) New function.
8278 * repeat.c: Comment fixes.
8279 (struct repeat_entry) Replaced type and v union members with a
8281 (append_record) New function.
8282 (internal_cmd_do_repeat) Started reforming it for the new
8283 repeat_entry struct. Properly records filename changes in the
8284 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8285 strncasecmp() result usage. Uses append_record() to simplify.
8286 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8289 (copy_with_DO_REPEAT_substitutions) Started coding.
8291 [DEBUGGING] (debug_print_lines) New function.
8293 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8295 * tokens.h: (macro is_id1, is_idn) New macros.
8297 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8299 * cmdline.c: (static var pre_syntax_message) Changed `win'
8300 compatibility mode to `wnd'.
8302 * data-list.c: (fixed_parse_spss) Renamed
8303 fixed_parse_compatible().
8305 * glob.c: (init_glob) Excise unused code for
8306 program_invocation_short_name.
8308 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8311 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8313 * set.q: `win' compatibility renamed `wnd'.
8315 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8317 * filename.c: [__WIN32__] Change the included Windows header files
8319 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8320 second character is absolute.
8321 (dirname) Fix logic error. Don't printf() the results.
8322 (prepend_dir) Don't printf() the results.
8324 * getline.c: (handle_line_buffer) New function.
8325 (getl_read_line) Reads line with handle_line_buffer() when
8327 (getl_close_file) Discard line buffer data.
8329 * getline.h: Comment fixes.
8330 (struct getl_line_list) New struct.
8331 (getl_script_struct) Added line buffer members. These are hooks
8332 for use by DO REPEAT to allow it to insert virtual source code
8335 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8336 Override Borland C++ stupidity that claims Windows has a console
8339 * repeat.c: This is in the process of being restructured from
8340 using a token-buffering approach to the DO REPEAT facility to
8341 using the more flexible approach of a line-buffering approach in
8342 conjunction with the getline module. Comment fixes.
8343 (struct tok_struct) Removed.
8344 (static vars queue_index, queue_head, queue) Removed.
8345 (static vars line_buf_head, line_buf_tail) New vars.
8346 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8348 (pull_queue, destroy_queue) Removed.
8349 [DEBUGGING] (debug_print_tokens) Removed.
8351 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8353 * file-handle.q: (prepend_current_directory) New function.
8354 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8355 current directory before normalizing filename.
8357 * filename.c: (gnu_getcwd) New function.
8358 (absolute_filename_p) New function.
8359 (search_path) New argument, PREPEND. All references changed to
8360 pass NULL except those explicitly mentioned. Uses
8361 absolute_filename_p(). Prepends PREPEND before trying the
8363 (dirname, prepend_dir) New functions.
8365 * getline.c: (getl_get_current_directory) New function.
8366 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8369 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8371 * In several source files, the term `script' was replaced with
8372 `syntax file' inside error messages. Usage of the term `script'
8373 in the sense of a syntax file is now deprecated.
8375 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8378 * dump-sysfile.c: (usage) Update message.
8380 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8382 * getline.h: (glob var getl_include_path) Declare extern.
8384 * list.q: Define EXTERN as extern before #including somP.h.
8386 * var.h: Remove declaration of `disptype' variable.
8388 * vfm.c: (close_active_file) After switching the data sink to a
8389 data source, set vfm_sink to NULL, because it doesn't exist any
8392 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8394 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8395 _matherrl() to ignore all math errors.
8397 * sfm-read.c: (read_value_labels) When reading the labels from
8398 disk, read the little parts separately instead of as a struct;
8399 this avoids alignment problems.
8401 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8402 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8403 (write_header) Allocates and initializes elem_type.
8404 (sfm_write_case) Uses elem_type to determine how to handle each
8406 (sfm_close) Frees elem_type.
8408 * sfmP.h: Comment fix.
8409 [__BORLANDC__] Uses #pragma -a to adjust structure member
8412 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8414 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8416 * common.c: Fix typo.
8418 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8419 sense of the condition.
8421 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8422 line-continuation backslash.
8424 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8426 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8427 non-constant expression as an argument to sizeof.
8429 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8430 undefine gettext macro because that's a conio function.
8432 * hash.h: (hsh_prime_tab declaration) Remove.
8434 * list.q: (write_fallback_headers) Move `leader' allocation out of
8435 main loop. Change to local_alloc() allocation.
8437 * output.h: Formatting fixes. Put __attribute__ in right place on
8438 function prototypes.
8440 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8441 incorrect `SECOND_LOWEST_VALUE' references to proper
8442 `second_lowest_value'.
8444 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8445 value. This way 2 out of 3 of the som files define the vars
8446 extern, the correct way, that actually works under BC++.
8447 (som_set_float) Don't use nonconstant initializers for a struct.
8449 * som-high.c: Add the standard alloca() header.
8450 (replicate_table) Add prototype.
8452 Merged DISPLAY routine.
8453 * sysfile-info.c: (AS_*) New enum series.
8454 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8456 (cmd_display, display_macros, display_documents,
8457 display_variables) Stolen from defunct display.c.
8458 (describe_variable) New function.
8460 * temporary.c: [0] (display_tree) New debug function.
8461 (copy_variable) Performs shallow copy of value labels instead of
8462 deep copy; i.e., just copys the AVL tree and increments the
8465 * val-labs.c: Comment fixes.
8466 (do_value_labels) Optionally skip leading forward slash.
8467 (get_label) Creates only a single value label instead of many
8468 copies of one, and sets the reference count.
8470 * display.c: Removed.
8472 * dump-sysfile.c: New file, not yet complete.
8474 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8476 For lots of source files I added more verbose_msg's. These aren't
8477 listed below as they have tested as being benign. In some cases
8478 these replaced debug_printf() calls.
8480 * output.c: (outp_read_devices) Message fix.
8482 * postscript.c: (output_encodings) Message fix. Reports errors on
8484 (postopen) Message fix.
8486 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8488 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8490 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8493 * main.c: Remove <malloc.h> #include.
8495 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8496 instead of trying to just set the missing[] itself, which is a
8499 * sfm-read.c: (read_variables) Same.
8501 * str.h: Add memmem() prototype.
8503 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8505 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
8507 * Makefile.am: (q2c) Don't include any libraries in the link.
8509 * dfm.c: (force_line_buffer_extension) New macro.
8510 (count_tabs) New function.
8511 (tabs_To_spaces) New function.
8512 (read_record) Calls tabs_to_spaces() on the line being processed.
8514 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
8515 have to be compiled twice (once for CC, once for LOCAL_CC).
8517 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
8519 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
8520 (LDADD) Add @INTLLIBS@.
8521 (q2c) Add LIBS, @INTLLIBS@ to link step.
8523 * inpt-pgm.c: Turn off debugging.
8525 * postscript.c: (postopen) Format fix. local_free() blocks
8526 returned by local_alloc(); don't free() them.
8528 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
8530 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
8533 * data-list.c: (read_from_data_list_fixed) Pass proper value for
8534 LEN arg, not simply the full string length.
8536 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
8537 directories before generic temp file directories.
8539 * vfm.c: Disable debugging.
8541 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
8543 * get.c: Comment fix.
8544 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
8546 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
8548 * expr-prs.c: (debug_print_postfix) Conditionally included on
8549 GLOBAL_DEBUGGING. Removed out_header() reference.
8551 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
8553 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
8555 * ascii.c: Removed obsolete ascii_close_page() prototype.
8557 * command.c: (output_line) Comment fix.
8559 * data-in.c: Formatting fix.
8560 (parse_string_as_format) Now the `fc' argument is used only for
8561 the purpose of error messages; it is not an index into the string
8562 passed. All references changed.
8564 * data-list.c: Comment fix.
8565 (cut_field) Comment fix. Now returns the column number of the
8566 position of the field cut out on success.
8567 (parse_field) Added `column' argument. Puts the column numbers in
8569 (read_from_data_list_free, read_from_data_list_list) Record the
8570 column number returned by cut_field(), pass it to parse_field().
8572 * dfm.c: Comment fix.
8574 * do-ifP.h: Comment fix.
8576 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
8577 the SYSMIS function.
8579 * expr.h, exprP.h: Comment fix.
8581 * glob.c: (init_glob) Only calls setlocale() and family if
8584 * hash.h: Comment fix.
8586 * include.c: Comment fix.
8588 * output.c: Comment fix.
8590 * postscript.c: (ps_line_intersection) Simplified assertion.
8592 * repeat.c: Comment fix.
8594 * vars-atr.c: Comment fix.
8596 * vars-prs.c: Comment fix.
8598 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
8599 behavior with usage of postincrement.
8600 (memory_stream_read) Discards cases as it goes.
8602 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
8604 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
8607 * Most source files: Includes debug-print.h, related comment
8610 * cases.c: (alloc_val) Removed complex allocation code. Merely
8611 increments default_dict.nval and returns the former value.
8612 (envector, devector) Removed references to lv member of struct
8615 * common.h: (macro VME) Replaced complex definition with simple
8618 * data-list.c: (cmd_data_list) Sets vfm_source instead of
8619 read_active_file and cancel_input_pgm.
8620 (read_from_data_list, cancel_data_list) Removed.
8621 (data_list_source_read, data_list_source_destroy_source) New
8623 (glob var data_list_source) New var.
8625 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
8626 (cmd_begin_data) Improved criteria for an input program accessing
8627 the inline file. Still not perfect.
8629 * do-if.c: (do_if_trns_proc) Simplified debug output.
8631 * expr-prs.c: Comment fixes.
8632 [DEBUGGING] (debug_print_postfix) Simplified debug output.
8634 * file-handle.q: (fh_close_handle) Simplified debug output.
8636 * file-type.c: Comment fixes.
8637 (cmd_file_type) Sets vfm_source instead of read_active_file and
8639 (cmd_end_file_type) On failure, discards variables in place of
8640 just canceling the input program.
8641 (read_from_file_type) Renamed file_type_source_read.
8642 (cancel_file_type) Renamed file_type_source_destroy_source.
8643 (glob var file_type_source) New var.
8645 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
8646 (cmd_get) Initializes options to GTSV_NONE before passing to
8647 trim_dictionary(). Removed `lv' reference. Sets vfm_source
8648 instead of read_active_file and cancel_input_pgm.
8649 (cmd_save_internal) Initializes options before passing to
8650 trim_dictionary(). Local var `nval' removed.
8651 (dict_delete_run) Comment fixes.
8652 (trim_dictionary) Comment fixes. Disallows scratch variables if
8653 GTSV_OPT_SAVE set in options.
8654 (read_from_get) Renamed get_source_read.
8655 (cancel_get) Renamed get_source_destroy_source.
8656 (glob var get_source) New var.
8658 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
8659 read_active_file and cancel_input_pgm.
8660 (read_from_input_program) Renamed input_program_source_read.
8661 Simplified debug output.
8662 (cancel_input_program) Renamed
8663 input_program_source_destroy_source.
8664 (glob var input_program_source) New var.
8666 * loop.c: (loop_1_trns_proc) Simplified debug output.
8668 * main.c: (dump_token) Made eof output more explicit.
8670 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
8673 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
8674 code for always-memory or always-disk cases. malloc's case-list
8675 based on vfm_source_info.ncases. Explicit support for
8676 memory_stream via memory_source_cases.
8677 (do_external_sort) Sets vfm_source instead of read_active_file and
8679 (allocate_file_handles) The temporary directory permissions are
8680 set to 0700 instead of 0777.
8681 (allocate_cases) Formatting fixes. Simplified debug output.
8682 (output_record) Compacts the case if necessary before writing it
8684 (close_handle, open_handle_w) Simplified debug output.
8685 (write_initial_runs) Destroys vfm_sink, then sets it to
8686 sort_stream. Writes records to memory based on
8687 vfm_sink_info.case_size.
8688 (write_to_sort_cases) Renamed sort_stream_write().
8689 (merge) Simplified error handling. Simplified debug output.
8691 (read_from_external_sort) Renamed sort_stream_read().
8692 Reads records based on vfm_source_info.case_size.
8693 (sort_stream_write) Writes records to memory based on
8694 vfm_sink_info.case_size.
8695 (sort_stream_mode) New function.
8696 (glob var sort_stream) New variable.
8698 * temporary.c: (cmd_temporary) Simplified debug output.
8699 (copy_variable) Removed references to `lv'.
8701 * title.c: (get_title) Simplified debug output.
8703 * var.h: Comment fixes.
8704 (struct get_proc) Removed member `lv'.
8705 (struct variable) Removed member `lv'. Comment fixes.
8706 (glob vars read_active_file, write_active_file, cancel_input_pgm)
8708 (struct case_stream) New.
8710 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
8711 read_active_file references to use vfm_source.
8712 (init_variable, replace_variable) Removed references to `lv'.
8714 * vfm.c: Comment fixes.
8715 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
8717 (static var queue, qh, qt, n_lag) Removed. All references
8719 (glob var compaction_necessary, compaction_nval, compaction_case,
8720 paging) New variables.
8721 (record_case) Removed.
8722 (procedure) Comment fixes. Calls vfm_source->read() instead of
8725 (prepare_for_writing, arrange_compaction, make_temp_case,
8726 vector_initialization, setup_filter) New function.
8727 (open_active_file) Most of the code moved into the abovementioned
8728 new functions. Now sets temp_dict to &default_dict if there is no
8729 temporary dictionary, for convenience. New debug output.
8730 (close_active_file) Deals with changing the sink to the source.
8731 Calls finish_compaction(). Frees compaction_case. Mostly
8733 (glob vars disk_source_file, disk_sink_file) New vars.
8734 (destroy_active_file, read_from_memory) Removed.
8735 (disk_stream_init, disk_stream_read, disk_stream_write,
8736 disk_stream_mode, disk_stream_destroy_source,
8737 disk_stream_destroy_sink) New functions.
8738 (glob var vfm_disk_stream) New var.
8739 (glob vars memory_source_cases, memory_sink_cases,
8740 memory_sink_iter, memory_sink_max_cases) New vars.
8741 (memory_stream_init, memory_stream_read, memory_stream_write,
8742 memory_stream_mode, memory_stream_destroy_source,
8743 memory_stream_destroy_sink) New functions.
8744 (glob var vfm_memory_stream) New var.
8745 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8746 named `more_cases'. Simplified debug output. Otherwise mostly
8748 (record_case) Moved into the stream drivers. Removed.
8749 (transform) Removed (was dead code).
8750 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8751 common case that the splits don't change, we don't need to copy
8752 the case into prev_case again--pointless.
8753 (compact_case) New function.
8754 (finish_compaction) New function.
8756 * vfmP.h: Comment fixes.
8757 (DEV_* enum series) Removed.
8758 (struct storage) Renamed `stream_info'. Removed variant record.
8759 Removed `device' member.
8761 * debug-print.h: New file.
8763 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8765 * autorecode.c: Turned off debugging.
8767 * data-list.c: (destroy_dls) Closes the associated file handle.
8769 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8770 parse_variables() options.
8772 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8774 * display.c: (display_variables) Really fixed null cell bug.
8776 * file-handle.q: (fh_close_handle) Changed debugging message.
8778 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8779 parse_variables() options.
8781 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8782 (cmd_list) Fails if no variables specified.
8783 (determine_layout) Writes blank lines manually.
8785 * loop.c: (loop_1_trns_proc) Made debugging code only print
8786 messages if debugging.
8788 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8789 parse_variables() arguments.
8790 (main) Parses optional parenthesized options to varlist
8791 subcommands into sbc->message.
8793 * sfm-read.c: Format fix.
8795 * var.h: (FV_*) New enum series.
8796 (PV_*) New enum PV_NO_SCRATCH.
8798 * vars-prs.c: (find_var) Removed.
8799 (fill_all_vars) Takes FV_* enum instead of boolean third
8800 argument. Rewritten to deal with scratch as well as system
8802 (parse_variables) Error message on scratch variable if
8805 * vfm.c: (static var virt_begin_func) New var.
8806 (procedure) Sets up virt_begin_func.
8807 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8808 after dump_splits(). For succeeding groups changes, calls
8809 virt_begin_func() instead of begin_func().
8811 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8813 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8816 * dfm.c: Added some debugging messages, disabled by default.
8817 (open_file_r) Fixed error message.
8818 (read_record) On eof on inline_file, instead of calling
8819 fh_close_handle(), simply jump to eof label like a normal file.
8822 * display.c: Thin lines between rows for certain kinds of
8823 listing. Fixed `null cell' bug.
8825 * error.c: (failure) Flush stdout, stderr before failing.
8827 * file-handle.q: (fh_close_handle) Added debugging message.
8829 * frequencies.q: (dump_full) Bottom line extends across entire
8830 table width. Changed title formatting.
8831 (dump_condensed) Changed title formatting.
8832 (dump_statistics) Fixed title formatting.
8834 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8835 Sets default value of set_format.
8837 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8838 Passes write_all_headers() to procedure() as pre-group func.
8839 (write_all_headers) New function.
8840 (determine_layout) Removed calls to write_header().
8841 Calls blank_line() before and after write_fallback_headers().
8843 * recode.c: (recode_trns_free) Only attempts to free head->map if
8846 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8847 file variable names but gives a warning. Sets `left' based on
8848 first character being/not being `#'. On lossage frees dict->var.
8850 * som-high.c: (som_draw_title) Simplified title formatting.
8852 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8854 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8856 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8857 beginning. Frees v_src, v_dest on successful exit. Frees
8858 h_trans[*], h_trans on lossage.
8859 (recode) Frees h_trans[*], h_trans.
8861 * dfm.c: (dfm_close) Formatting change.
8862 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8863 longer allocates its own in inline_file.
8864 (open_file_r) Passes the local dfm_fhuser_ext to
8866 (open_file_w) Message fix.
8867 (read_record) Buffer reallocation strategy changed. Frees
8868 ext->line even in inline_file to prevent leaks.
8869 (dfm_put_record) Fixed bug where `ext' was cached before the file
8870 was opened and thus it would be NULL when the file really was
8872 (cmd_begin_data) Sets up inline_file basics itself, then calls
8873 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8875 * list.q: (write_line) Formatting fix.
8876 (clean_up) Minor strategy change. Sets proportional font after
8878 (determine_layout) Sets fixed font before writing regular headers,
8879 or after writing fallback headers.
8881 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8882 and KEEP vars after using them.
8884 * postscript.c: (ps_init_driver) Frees x->family.
8885 (postopen) When loading fonts, free the temporary font name buffer
8887 (ps_text_set_font_by_position) Free temporary font name buffer
8889 (text) Fixed code that calculated `lig' so that `lig' always gets
8890 initialized. Formatting fix.
8892 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8894 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8895 cells, not xmalloc(), so that the cells will get destroyed
8898 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8901 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8903 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8906 * dfm.c: Comment fix.
8908 * list.q: Comment fixes. Include somP.h. Removed static vars
8909 table, n_columns, n_rows, part. New struct list_ext. New static
8911 (n_lines_remaining, n_chars_width, write_line) New functions.
8912 (cmd_list, list_cases) Rewritten.
8913 (begin_row, end_row, flush_table) Removed.
8914 (write_header, clean_up, write_varname, write_fallback_headers,
8915 determine_layout) New functions.
8917 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8919 * output.h: Comment fix.
8921 * postscript.c: Comment fix.
8922 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8923 added font_size. All references changed.
8924 (ps_init_driver) Initializes font_size. Simplified space checking
8926 (static var option_tab[]) Removed prop-size, fixed-size; added
8928 (ps_option) Handles font_size.
8930 * som-high.c: Moved prototypes into somP.h.
8931 (som_init_driver) New function.
8932 (som_submit_table) Moved some code into new function
8934 (build_target) Moved some code into new function
8935 som_internal_eject_page().
8936 (som_eject_page) Uses som_internal_eject_page().
8937 (som_internal_eject_page) New function.
8939 * som-low.c: Moved prototypes into somP.h.
8941 * som.h: Formatting fixes.
8943 * somP.h: (struct som_driver_ext) Removed em_width;
8944 added prop_em_width, fixed_width.
8946 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8948 * Makefile.am: Added `localedir' definition. Added
8949 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8951 * ascii.c: (macro draw_line) Fixed capitalization.
8953 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8954 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8955 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8956 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8957 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8958 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8959 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8960 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8961 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8962 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8963 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8964 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8965 for internationlization.
8967 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8969 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8971 * do-if.c, sort.c, val-labs.c: Comment fixes.
8973 * glob.c: (init_glob) Uncommented, updated i18n support.
8975 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8976 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8977 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8978 the declarations of macros taking arguments a lot nicer.
8980 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8982 * error.h: Removed CE, CW aliases for SE, SW.
8984 * q2c.c: Removed explicit streq() definition since it's duplicated
8987 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8988 stats.h, str.h, tokens.h: Made the declarations of macros taking
8989 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8992 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8994 * cmdline.c: Comment fixes.
8995 (pick_compat) Changed return type to int. Now, instead of setting
8996 glob var `compat' to the emulation, returns the emulation. All
8998 (parse_command_line) Added terminating null to end of
8999 `long_options' array definition.
9000 (pre_syntax_message) Fixes.
9001 (usage) Shows the default emulation in the syntax message by
9002 calling pick_compat().
9004 * getline.c: (getl_add_include_dir) Separates paths with
9005 PATH_DELIMITER, not DIR_SEPARATOR.
9007 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9008 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9010 * output.c: (outp_configure_macro) Make earlier definitions for a
9011 particular key override later ones for the same key.
9013 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9015 * ascii.c: Comment fixes.
9017 * output.c: (outp_get_paper_size)
9018 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9020 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9022 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9023 <errno.h>. GNU libc 2 enforces this!
9025 * command.c: (parse_cmd) Fixed problem with `else' clause being
9026 paired with wrong `if'. Comment fix.
9028 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9030 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9031 blp_getline() to getline().
9033 * output.c: (outp_eval_dimension) Changed the fix from last time;
9034 there was no variable `a'.
9036 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9038 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9040 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9041 numbers having fractional parts. Added case of a fraction without
9042 a whole-number part.
9044 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9046 * ascii.c: (ascii_text_get_font_position) Removed.
9048 * expr.h, exprP.h: Disabled debugging.
9050 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9053 * output.h: (struct outp_class_struct) Removed
9054 text_get_font_position method. All references deleted.
9056 * postscript.c: Big change here. Fontmaps were completely
9057 eliminated because of a change in philosophy. Comment fixes.
9058 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9060 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9061 `fixed_name' members removed. New members `prop_family',
9062 `fixed_family'. `family' member changed to type char *.
9063 (static var ps_fontmaps) Removed.
9065 (ps_init_driver) Removed obsolete references, updated.
9066 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9067 fontmap, of course. Refers to font names through internal_name
9068 rather than subversive means. Frees proper items.
9069 (static var option_tab[]) Removed `fontmap-file' option; renamed
9070 `fixed-font', `prop-font'.
9071 (ps_option) Corresponds to option_tab[].
9072 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9073 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9074 hash_family) Removed.
9075 (postopen) Generates font names from family names. Gets
9076 PostScript font name properly. New prologue file comment `!!!'
9078 (ps_open_page) Adds translate_x, translate_y to BP prologue
9079 function; gives SF argument floating-point format.
9080 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9081 font name. Doesn't change font family.
9082 (ps_text_set_font_by_position) Generates Groff font name from font
9083 family name instead of through table lookup.
9084 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9085 all references changed. Reduced to simple string assignment.
9086 (ps_get_font_name) Removed.
9087 (ps_get_font_family) Reduced to string return.
9088 (text) Doesn't save `position' since it no longer exists. Ugly
9089 kluge to save font family--fix soon?
9090 (load_font) Removed PostScript name argument.
9092 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9094 * postscript.c: Comment fix.
9095 (ps_open_page) Puts scale factor in PostScript output.
9097 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9099 * Makefile.am: Distcleans q2c.
9101 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9103 * ascii.c: (delineate) Sets text size even if width is zero.
9105 * command.c: Comment fix.
9106 (static var cmd_table[]) Re-enabled EVALUATE command.
9107 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9108 of comments in script files. Now more liberal on criteria for
9109 performing a state transition--if *anything* happened correctly,
9110 not just if *everything* happened correctly.
9112 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9113 Checker segfault on formatting large numbers and why in the fsck
9114 hadn't I noticed this before?
9116 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9118 * list.q: (cmd_list) Commented out the actual output routine
9119 because of various problems. Probably will abandon the idea of
9120 using the general `crushed tables' for the LIST procedure.
9122 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9123 clearing it. Allocates a new var_by_name dictionary before trying
9124 to add members to it.
9126 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9127 `sib'. Changed type of `node' argument.
9128 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9130 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9131 [DEBUGGING] Only deletes the variable from var_by_name if that var
9134 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9136 * Makefile.am: Added include files to SOURCES. Added
9137 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9138 includes rules for q2c. Added `boast' target.
9140 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9142 * Makefile.am: Maintainer-clean Makefile.in.
9144 * Makefile.am: Fixed redundant EXTRA_DIST line.
9146 * ascii.c: Comment fixes.
9147 (ascii_line_vert) Fixed overly aggressive range check.
9149 * display.c: Removed dead code.
9151 * list.q: Turn debugging on.
9152 (flush_table) New debug code.
9154 * sfm-read.c: (read_value_labels) malloc's the structure before
9155 trying to assign to its members.
9157 * sfm-write.c: Comment fix.
9159 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9161 (output_table) No arguments anymore--gets them through `som'
9162 global. New debug code. In crushed tables, now sets `htv' as
9163 well as `hv' to avoid bad confusion later.
9164 (dump_crush_page) New debug code.
9166 * som-low.c: (som_dump_crush_page) New debug code.
9168 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9170 All source files: Broke long lines into multiple lines.
9172 * ascii.c: (ascii_close_page) Uses host_system var in place of
9173 HOST_SYSTEM constant.
9175 * cmdline.c: (var syntax_message[]) Broke into
9176 pre_syntax_message[] and post_syntax_message[].
9177 (usage) Outputs both parts, separated by driver list.
9179 * error.h: Fixed broken formatting.
9181 * expr-opt.c: (str_search, str_rsearch) New functions.
9183 * misc.c: (blp_getdelim) Removed. All references changed to
9185 (str_search, str_rsearch) Removed.
9186 (memrmem) New function.
9188 * misc.h: (blp_getline) Removed. All reference changed to
9193 * filename.c: Includes "stat.h", not <sys/stat.h>.
9194 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9196 * output.c: (outp_list_classes) Changed output formatting.
9198 * sfm-write.c: (write_header) Uses host_system var instead of
9199 HOST_SYSTEM constant.
9200 (write_rec_7_34) Extracts version numbers from the version string.
9203 * sort.c: Includes "stat.h", not <sys/stat.h>.
9205 * str.c: (strcasecmp) Removed.
9207 * title.c: (cmd_document) Uses host_system var instead of
9208 HOST_SYSTEM constant.
9210 * version.c: Generated on-the-fly by the Makefile instead of being
9213 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9215 [!HAVE_STRNCASECMP] Declares strncasecmp().
9217 * version.h: Removed stray character. Comment fixes.
9218 (vars host_system, build_system) New vars.
9220 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9222 * Most source files: Changed formatting of copyright notice; fixed
9223 FSF address; reformatted to better conform to GNU standards;
9224 comment fixes. Added markups to prevent GNU indent from messing
9225 up my beautiful formatting :-).
9227 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9228 that GNU indent markups can be passed through without problems.
9230 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9232 * get.c: Turned off debugging.
9234 * glob.c: (init_glob) Turned on save-file compression by default.
9236 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9237 compression than was possible in save files.
9239 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9241 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9243 * frequencies.q: Removed Fiasco extensions. Updated calculation
9244 algorithms. Polished output format.
9245 (struct frq_info_struct) Removed members `max_degree', `min_n',
9246 all references removed.
9247 (macro frq_extensions) Removed.
9248 (static vars min_n, max_degree) Removed, all references removed.
9249 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9250 calculate `min_n', `max_degree'.
9251 (postcalc) Passes new arg to dump_statistics().
9252 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9254 (dump_condensed) Adds variable name title.
9255 (sum_freqs) Removed.
9256 (calc_stats) Updated calculation algorithm.
9257 (dump_statistics) Removed warning for too-few observations.
9258 Changed table formatting. Adds variable name title if passed new
9261 * output.h: Comment fix.
9263 * recode.c, sample.c, sort.c: Disabled debug code.
9265 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9266 Improved debug code.
9268 * var.h: (enum series frq_*) Removed Fiasco extensions.
9270 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9272 * command.c: Added PROCESS IF to command table.
9274 * Lots & lots of places, removed checks for NULLs preceding calls
9275 to free_expression(), which itself checks.
9277 * descript.q: Removed Fiasco extensions. Removed optimizations
9278 for non-weighted active files. Implemented some options.
9279 Finished polishing output format. Comment fixes. Merged
9281 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9282 max_degree, min_n) Removed.
9283 (macro dsc_extensions) Removed.
9284 (struct dsc_info_struct) Removed `min_n' member, all references
9286 (internal_cmd_descriptives) Removed calculation of min_n,
9287 max_degree. Only deals with one `calc' routine instead of two
9289 (precalc) Eliminated redundancy. Updated for changes to
9290 descriptives_proc structure.
9291 (calc) Moved here from `descript.g'. Rewritten to calculate
9292 statistics via `moments about the mean' rather than by summing,
9293 summing squares, summing cubes, and so on.
9294 (postcalc) Rewritten for new-style statistical calculation.
9295 (display) Removed support for displaying variables across rows.
9296 No longer crushes the descriptives table. Removed ancient code.
9297 Added display of N, by variable and listwise.
9299 * descript.g: Removed; merged into `descript.q'.
9301 * expr-evl.c: (evaluate_expression) Now returns a double. For
9302 numeric results, it returns the result as well as storing it in
9303 the passed `value' structure if non-NULL. For string results it
9304 just returns 0.0 and it must be passed non-NULL. Many references
9305 to this function were optimized by use of this change, especially
9306 but not exclusively in `compute.c'.
9308 * frequencies.g: Comment fix.
9310 * glob.c: (glob var process_if_expr) New global var.
9312 * postscript.c: (static var option_tab[]) Corrected entry for
9314 (postopen) Sets x->size to x->prop_size.
9315 (ps_text_set_font_by_name) Sets font size as well as typeface for
9316 PROP and FIXED fonts.
9318 * sel-if.c: (cmd_process_if) New function.
9320 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9321 (sfm_write_dictionary) Sets `n_cases' to 0.
9322 (sfm_write_case) Increments `n_cases'.
9323 (sfm_close) Attempts to seek the system file back to the header
9324 and write the number of cases in its proper slot.
9326 * som-frnt.c: (som_insert_table) Masks off expansion options since
9327 only SOPT_X_NORM seems to work sensibly.
9329 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9330 with a `fixed' value of 2.
9332 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9334 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9335 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9337 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9338 (struct descriptives_proc) Removed `miss_noweight'; new members
9339 `X_bar', `M2', `M3', `M4', `min', `max'.
9341 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9343 * vfm.c: (close_active_file) Cancels PROCESS IF.
9344 (write_case) Doesn't process cases unselected by PROCESS IF.
9346 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9348 * glob.c: (glob var err) Removed.
9350 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9351 doesn't have to take into account number of value labels since
9352 they're in a subtable anyway. Also, doesn't display more than 10
9353 value labels since we can't yet break pages in subtables.
9355 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9357 * som-frnt.c: (som_change_table_size) Simple change for elegance
9358 that shouldn't change behavior.
9359 (som_set_value) Comment fix.
9361 * som-high.c: (som_submit_table) Message fix.
9363 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9365 * command.c: Added SYSFILE INFO to command table.
9367 * file-handle.q: (fh_handle_filename) New function.
9369 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9372 * main.c: (parse) New return value for command functions, -3.
9374 * misc.h: Comment fix.
9376 * output.h: Comment fixes.
9377 (macro COMPONENTS) Removed.
9379 * postscript.c: (write_text) Modified literal_chars[] so that `('
9380 and ')' are not written to the output in strings as literals.
9382 * sfm-read.c: (sfm_read_dictionary) New argument.
9383 (read_header) New argument. Sets the information structure's
9384 values from the header information.
9385 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9386 bizarre Checker problem, I guess.
9387 (read_variables) Proper cleanup on lossage.
9389 * sfm.h: (struct sfm_read_info) New struct for use by
9390 sfm_read_dictionary().
9392 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9393 currently used just for tables that can be dynamically resized and
9394 thus have to be allocated with arena_malloc() instead of
9395 arena_alloc(). All references changed.
9396 (som_change_table_size) New function.
9397 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9399 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9400 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9403 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9405 (draw_intersection) Now takes an argument specifying the table in
9406 question. All references changed.
9407 (draw_table_cell) New function.
9408 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9409 (som_get_table_size) Many nice new explanatory comments.
9410 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9412 * som.h: New enum series SOM_CREATE_* for use as create flags with
9415 * str.h: Moved a comment here from TODO.
9417 * sysfile-info.c: New file. Reference implementation.
9419 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9421 * command.c: Added RENAME VARIABLES to table of commands.
9423 * data-in.c: (dls_error) Sets `cust_field'.
9424 (parse_N) Message fix.
9425 (parse_day_count) New function.
9426 (to_roman) Never outputs VX as a `short form' of V.
9427 (parse_month) Fixed parsing of Roman numerals.
9428 (parse_trailer) Message fix.
9429 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9430 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9431 the date is invalid.
9432 (parse_SDATE) Fixed swapped day, year.
9433 (parse_JDATE) Fixed bug for dates in 1582.
9434 (parse_DTIME) Allows days not between 1 and 31.
9435 (parse_numeric) Makes local copy of f.type for easier usage.
9438 * data-out.c: (convert_F) When outputting as scientific, properly
9439 sets f.type as fp->type.
9440 (insert_commas) Fixed operator precedence problem with setting of
9441 nitems. Changed strcpy to memcpy (no null terminator).
9442 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9443 (convert_CCx) Essentially rewritten, but now it works.
9445 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9447 (display_documents) Implemented.
9449 * error.c: (glob var cust_field) New var.
9450 (vmsg) Displays cust_field as part of message classes DE and DW.
9452 * formats.c: (debug_print) Fixed to compile under updated
9455 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9458 * misc.c: (parse_format_specifier) Formatting fix.
9460 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9461 `n_rename' for clarity.
9462 (cmd_modify_vars) Initializes `forward' and `positional' at
9463 appropriate times. Frees lists of vars to rename on failure.
9464 Comment fix. Frees memory on success.
9465 (rearrange_dict) Simplified `for' loop condition.
9467 * rename-vars.c: New file (reference implementation).
9469 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9471 * sfm-read.c: (read_header) File label is created only if file
9472 label in file is not blank.
9473 (read_variables) Initializes `dict' local variable.
9474 (read_documents) Proper behavior on lossage.
9476 * sfm-write.c: (write_header) Doesn't blank out the file label
9477 (why was this here to begin with?!)
9479 * temporary.c: (save_dictionary) File label is copied only if
9480 non-NULL. Doesn't try to xstrdup() dictionary documents.
9481 Adapted so as to not irritate Checker.
9482 (free_dictionary) Only destroys var_by_name if non-NULL.
9484 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9485 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9486 lines to the document, indents the document. Also, it works now.
9487 (add_document_line) New function.
9489 * var.h: (struct dictionary) Reordering.
9491 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9492 bits if it was allocated to begin with.
9494 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9496 * command.c: Added MODIFY VARS to list of commands.
9498 * configure.in: Updated custom macros for autoconf 2.12. Removed
9499 mmap reference; fixed termcap library reference.
9501 * display.c: (display_variables) Fixed a few bugs although it's
9502 still not well written.
9504 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9505 (induce_segfault) Calls chkr_disp_call_chain() instead of
9506 inducing an actual SIGSEGV.
9508 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
9509 str_search() and str_rsearch(). Fixed tests for matches on
9510 OP_INDEX and OP_RINDEX.
9512 * filename.c: (good_getcwd) Removed as the new libc for Checker
9513 doesn't contain this bug, apparently.
9515 * misc.c: (str_search, str_rsearch) Changed order of arguments for
9516 consistency with GNU memmem.
9517 (blp_getdelim) Changed `len' from `int' to `size_t'.
9519 * modify-vars.c: Reference implementation.
9521 * som-frnt.c: (zero_length) New global var.
9522 (som_create_table) Message fix.
9524 * som.h: Added gcc attributions to som_set_text(),
9525 som_output_text() prototypes. blank_line() refers to
9526 zero_length[] instead of a literal null string to suppress gcc
9529 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
9530 (allocate_cases) Decrements x_max so the last element of x[] can
9531 be used by the algorithm.
9533 * var.h: Changed minor details of `variable' declaration.
9534 (struct modify_vars_proc) New struct.
9535 (struct variable) Added field p.mfv.
9537 * vars-atr.c: Comment fix.
9539 * vars-prs.c: (fill_all_vars) More optimal implementation.
9541 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
9542 character, which it shouldn't have to do but printf() seems to
9543 read the null byte even though I supply a maximum length...
9545 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
9547 * command.c: Removed command alias X for QUIT.
9548 (parse_cmd) Fixed comment parsing.
9550 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
9552 (read_record) Fixed references to len, size.
9553 (dfm_get_record) Restructured.
9555 * file-handle.h: (struct file_handle) Field `lrecl' now of type
9558 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
9561 * modify-vars.c: New file. Not complete.
9563 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
9566 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
9567 problems caused by int/size_t differences.
9569 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
9572 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
9573 being compared were of equal length.
9575 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
9577 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
9579 * lexer.c: (get_dotted_rest_of_line) New function.
9581 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
9584 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
9585 type 6 records. Frees the dictionary properly.
9586 (read_header) Initializes the dictionary instead of letting
9587 read_variables() do it. Sets the dictionary file label from the
9589 (read_documents) New function.
9591 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
9592 write type 6 record if appropriate.
9593 (write_header) Writes file label from dictionary.
9594 (write_documents) New function.
9596 * temporary.c: (save_dictionary, restore_dictionary,
9597 free_dictionary) Properly handle new fields in dictionary struct.
9599 * title.c: (get_title) Returns after failure().
9600 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
9601 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
9603 * var.h: (struct dictionary) New fields `label', `n_documents',
9606 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
9608 * command.c: Added FILTER to list of commands.
9610 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
9613 * get.c: (cmd_save_internal) Removed weighting code since it's now
9614 handled by sfm-write.c. Properly commented out debug code.
9616 * glob.c: (glob var weighting) Removed.
9618 * sel-if.c: Comment fixes.
9619 (cmd_filter) New function.
9621 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
9622 (sfm_read_dictionary) Sets weighting variable direct in the
9623 created dictionary now. (Apparently we previously didn't support
9625 (read_header) Sets weight_index field in sfm_fhuser_ext from
9626 header read from disk.
9628 * sfm-write.c: (sfm_write_dictionary) Comment fix.
9629 (write_header) Now sets the weighting in the header from the
9630 passed primary dictionary instead of from the sfm_write_info.
9632 * sfm.h: (struct sfm_write_info) Removed field `weight'.
9634 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
9635 broke on boundary conditions.
9637 * var.h: (struct dictionary) New fields `weight_var',
9638 `weight_index', and `filter_var'.
9639 (glob var weighting) Removed. This is now part of struct
9640 dictionary. All references changed; the less mechanical changes
9641 are described above.
9643 * vars-atr.c: (find_dict_variable) New function.
9645 * vfm.c: (static var filter_index) New variable.
9646 (open_active_file) Initializes filter_index from default_dict.
9647 (write_case) Calls proc_func() only if the filter variable is
9648 nonzero; this implements FILTER behavior.
9650 * weight.c: (static var weight_varname) Removed.
9651 (cmd_weight) Modified default_dict instead of glob vars.
9652 (update_weighting) Changed the signature to modify a dictionary
9653 instead of glob vars. Now returns the weighting variable.
9654 (get_weighting_variable) Removed; its function is absorbed by
9656 (stop_weighting) Operates on a dictionary now.
9658 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
9660 * sort.c: Removed debugging info from messages.
9661 (do_external_sort) Cleans up after itself by deleting the
9662 temporary directory on failure. (On success it is deleted by the
9664 (allocate_cases) Removed debug code. Added clean up code.
9665 (output_record) Removed debug code.
9666 (merge) Added code to close all the input files that are currently
9667 open. This is a likely location for bugs, because I'm not sure
9668 about boundary conditions. Removed an unnecesary heap_delete().
9669 (merge_once) Removed input file "optimization" that in fact
9670 screwed up the rest of the code. Message and comment fixes.
9672 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
9674 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
9676 * heap.c: (heap_delete) New argument.
9678 * sort.c: Finished implementation of external sort.
9680 * vfm.c: (read_from_disk) Returns after a disk error.
9682 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
9684 * sort.c: (static var state) Removed.
9685 (static vars max_handles, tmp_basename, tmp_extname,
9686 huffman_queue) New variables.
9687 (do_external_sort) Moved most code to new functions.
9688 Creates huffman_queue.
9689 (allocate_file_handles, allocate_cases) New functions.
9690 (static vars run_no, run_length, file_index, case_count) New
9692 (output_record) Returns success. Now really writes to the output
9694 (begin_run, end_run) New functions.
9695 (write_initial_runs) Returns success. Initializes run_no to -1.
9696 Calls begin_run(), end_run() at appropriate times. Outputs debug
9698 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
9700 (merge) New function.
9702 * heap.c, heap.h: New files. Hopefully in near-final form.
9704 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
9706 * glob.c: Added write_active_file to global vars.
9708 * sort.c: Several new miscellaneous static variables.
9709 (cmd_sort_cases) Big comment fix.
9710 (perform_case_2) Renamed `do_external_sort' and completely
9712 (case_2_proc_func) Removed.
9713 (output_record, write_initial_runs, write_to_sort_cases,
9714 compare_record) New functions.
9716 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
9718 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
9720 * sort.c: (perform_case_2) Changed the method for allocation of
9721 lots of memory--now allocates one case at a time in hopes that
9722 more cases can be allocated with heavily fragmented memory.
9724 * var.h: (write_active_file) New global var.
9726 * vfm.c: (procedure, close_active_file, write_case,
9727 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
9728 arguments to procedure() to be NULL. All references to
9729 procedure() that made use of dummy functions were changed to NULL
9731 (open_active_file) If write_active_file is non-NULL, the output
9732 device becomes DEV_PGM (a new enum).
9733 (close_active_file) Sets write_active_file to NULL.
9734 (read_from_memory) Comment fix.
9735 (record_case) Calls write_active_file() when the output device is
9738 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9742 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9743 Fixed checking for duplicate varnames.
9744 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9746 (autorecode_trns_free) Destroys hash tables for each recoding
9748 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9750 * command.c: Added SORT CASES to cmd_table.
9751 (null_func, null_int_func) Prototyped.
9753 * descript.g: (calc_weight, calc_noweight) Computes own case
9756 * frequencies.q: (dump_statistics) Fixed problem with
9757 too-few-cases warning message.
9759 * get.c: (cmd_save_internal) Handles weighting properly.
9761 * hash.c: (hsh_dump) Output format changed.
9762 (force_hsh_insert) Actually works now, prototype changed.
9764 * list.q: (static var case_num) New variable.
9765 (cmd_list) Initializes case_num.
9766 (list_cases) Increments case_num.
9768 * var.h: Added definitions for SORT CASES. Comment fixes.
9770 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9771 fixes. `active' renamed vfm_active, `rep' renamed
9772 vfm_replacement, all references changed.
9773 (procedure) The procfunc no longer receives a case number. All
9775 (write_case) Subtle reordering.
9776 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9779 * weight.c: (get_weighting_variable) New function.
9781 * vfmP.h: New file with definitions from vfm.c.
9783 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9785 * command.c: (FILE_TYPE_okay) Commented out some tests because
9786 they're clumsy and not yet needed.
9788 * var.h: Most *_trns structures moved to their respective source
9789 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9790 (union any_trns) Changed to a typedef for trns_header.
9791 (struct input_program_pgm) Removed.
9793 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9794 was allocated in the first place.
9796 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9798 * autorecode.c: New file.
9800 * command.c: Added AUTORECODE to command table; re-enabled SET.
9802 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9804 * error.c: (vmsg) Comment fixes.
9806 * hash.c: Comment fix.
9807 (hashpjw_d) New function.
9808 (hashpjw) Reimplemented as call to more general function
9810 (internal_comparison_fn) Initializes pointers properly.
9811 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9812 (force_hsh_insert, force_hsh_find) New debugging wrapper
9815 * main.c: (main) Message fix.
9817 * output.c: (outp_read_devices) Message fix.
9819 * set.q: Comment fixes.
9820 (custom_results) Implemented Wnd/X form of subcommand.
9821 (set_routing) New function.
9822 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9824 * settings.h: (SET_ROUTE_*) New enum series.
9825 (set_results) Renamed set_results_file, all references changed.
9826 (set_messages) Removed.
9827 (glob vars set_errors, set_messages, set_results) New vars.
9829 * title.c: (get_title) Remembers to xstrdup() the result of
9832 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9834 (union any_trns) New element `arc'.
9836 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9838 * command.c: (output_line) Removed references to set_screen.
9840 * error.c: (static var terminating) New var.
9841 (hcf) Sets terminating to 1.
9842 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9843 This prevents an infinite loop if an error occurs within hcf().
9845 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9846 statement circumlocution with `case 42000' trick.
9847 (evaluate_expression) New support for OP_STR_MIS.
9849 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9850 statement circumlocution with `case 42000' trick.
9851 (dump_node) Handles OP_STR_MIS.
9853 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9854 variables exceptions.
9855 (parse_function) Message fix.
9856 (ops[]) Added OP_STR_MIS.
9858 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9860 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9862 * glob.c: Removed set_scrnfile glob var.
9863 (init_glob) set_errorbreak set to 0 by default.
9865 * groff-font.c: Changed included files.
9866 (groff_read_font) Initializes font_arena local var correctly.
9867 (default_font) New function.
9869 * output.c: Comment fixes.
9870 (glob var disabled_devices) New variable.
9871 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9873 [GLOBAL_DEBUGGING] (reentrancy) New function.
9874 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9875 outp_iterate_enabled_drivers) Calls to reentrancy().
9876 (destroy_list) New function.
9877 (outp_done) Moved code to destroy_list().
9878 (parse_options) Parses `listing', `screen', `printer' options
9880 (configure_driver) Sets new `device' member of driver.
9881 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9883 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9884 (struct outp_driver_struct) New member `device'.
9886 * postscript.c: (find_encoding_file) Doesn't display its own error
9888 (default_encoding) New function.
9889 (switch_font) Calls default_encoding() if no encoding can be
9891 (text) Makes up a character metric if none exists for the desired
9893 (load_font) Properly copies a fallback filename. Calls
9894 default_font() for a font if none at all are known.
9896 * set.q: Comment fixes. Removed OUTPUT subcommand.
9897 (custom_listing) Calls outp_enable_device() to enable/disable
9899 (turn_screen_on) Removed.
9900 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9901 screen, printer devices.
9903 * settings.h: Comment fixes.
9904 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9907 * som-high.c: (som_submit_table, som_eject_page) Use
9908 outp_iterate_enabled_drivers() instead of iterating
9909 outp_driver_list directly.
9911 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9913 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9914 (parse_string_as_format) Handles new formats.
9915 (parse_numeric) Now handles DOT and PCT formats.
9917 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9919 (convert_date) Handle EDATE and SDATE formats.
9920 (convert_CCx) Now if there's not room for the currency characters,
9921 converts it as F format if it's positive instead of giving up
9922 quickly. Also fixed save-and-restore bug with decimal point
9924 (convert_format_to_string) Handles new formats.
9926 * misc.c: (formats[]) Added new formats.
9927 (convert_fmt_ItoO) Supports new formats.
9929 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9930 data checking. New argument, all references changed.
9932 * sfm-write.c: (write_format_spec) Supports new formats.
9934 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9937 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9939 * cmdline.c: Comment fixes.
9940 (parse_command_line) Changed return type to void.
9942 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9944 (parse_numeric) Handles international numbers (comma as decimal
9945 point). Some reformatting.
9947 * data-list.c: (parse_free) Default output format is now
9948 set_format instead of hard-coded F8.2.
9949 (read_from_data_list_list) Emits error message on undefined data
9950 only if set_undefined is nonzero.
9952 * data-out.c: (convert_E) Changes decimal point from period to
9953 comma if appropriate. Restructured. Better comments.
9954 (convert_F) Changes decimal point from period to comma if
9956 (insert_commas) Major bug with handling of negative values fixed.
9957 Also, inserts periods instead of commas if appropriate.
9958 (convert_CCx) New function.
9959 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9960 (num_to_string) Changed `.' to set_decimal.
9962 * dfm.c: Comment fixes.
9963 (dfm_close) Frees ext->line even in inline_file.
9964 (open_inline_file) New function.
9965 (open_file_r) When opening the inline file: now properly
9966 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9968 (read_record) Calls fh_close_handle() instead of dfm_close() to
9969 close the inline file. Makes a copy of the line getl_buf to avoid
9971 (dfm_get_record) Restructured. Now checks the return value of
9973 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9974 checking for use of inline file. No longer tries to close inline
9977 * error.c: (glob var error_already_flagged) New var.
9978 (vmsg) Message change. Now checks max number of errors/warnings,
9981 * file-handle.q: (fh_handle_name) Now allows closing of
9983 (fh_init_files) Reformatted.
9985 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9987 * getline.c: (getl_include) Fixed bug that popped up when called
9988 when file queue was empty.
9989 (read_console) Resets error_count, warning_count,
9990 error_already_flagged to zero.
9992 * glob.c: Many changes to update list of variables.
9993 (init_compat_dependent) Now this function is called whenever
9994 `compat' changes. It now sets set_seed only if it hasn't
9995 previously been referenced. It now calls
9996 lex_init_compat_dependent().
9998 * include.c: (cmd_include_at) Frees temporary buffer instead of
10000 (cmd_include) Doesn't make copy of include file name.
10002 * lexer.c: Comment fixes.
10003 (init_lex) Moved some code into new function
10004 lex_init_compat_dependent().
10005 (lex_init_compat_dependent) New function.
10006 (hex_val) Simplified.
10007 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10009 * main.c: Comment fixes.
10010 (main) Reformatted.
10012 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10013 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10014 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10015 (setup_randomize) Sets set_seed_used.
10017 * set.q: Comment fixes.
10018 (custom_results) Conditionalizes on `compat'.
10019 (custom_log) Calls custom_journal().
10020 (set_ccx) New function.
10021 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10022 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10023 when set_decimal changes. Range-checks values for MITERATE,
10024 MNEST. Message fixes.
10026 * settings.h: Comment fixes.
10027 (struct set_cust_currency) New struct.
10028 (set_cc[], set_grouping, set_seed_used) New global vars.
10030 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10031 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10033 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10035 * glob.c: Revised variables to correspond to settings.h.
10036 (init_glob) Initializes variables from settings.h properly.
10038 * set.q: Began long-overdue major revision to correspond to new
10039 philosophy. Most code changed.
10041 * settings.h: Mostly changed; reorganized, reordered, large new
10044 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10046 * get.c: (cmd_save_internal) No longer forces compression off.
10048 * sfm-read.c: (read_compressed_data) If eof is reached when
10049 reading a new instruction octet, only signal error if we're in the
10052 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10053 (struct sfm_fhuser_ext) New member `end'.
10054 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10055 (ensure_buf_space) New function.
10056 (sfm_write_case) Reimplemented in order to support compression.
10057 (sfm_close) Writes out the remaining contents of the compression
10060 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10062 * command.c: Defined SAVE and XSAVE commands in command table.
10064 * common.h: second_lowest_value is of type flt64, not double.
10066 * file-handle.h: Comment fix.
10068 * get.c: Comment fixes.
10069 (static var `trns') New.
10070 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10071 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10072 (dict_delete_run) Clears the variables and frees them now.
10073 (trim_dictionary) Sets default for compression.
10074 On KEEP subcommand, frees deleted variables as well as clearing
10075 them. Finally got the sense of the test for deleting all
10077 [DEBUGGING] (dump_dict_variables) Message fix.
10079 * glob.c: (init_glob) set_compression set to 1 by default.
10081 * list.q: Properly #includes config.h.
10083 * misc.h: New macro REM_RND_UP.
10085 * settings.h: Comment fix.
10087 * sfm-read.c: (structs sysfile_header, sysfile_format,
10088 sysfile_variable; inline function bswap_int32) Moved to new file
10090 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10091 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10093 (read_machine_flt64_info) Fixed some problems caused by confusion
10094 between flt64 and double types.
10095 (read_header) Message fix.
10096 (read_variables) Fixed set of cases in which we byte-swap sv.print
10097 and sv.write. Fixed confusion of flt64 and double.
10099 * sfm.h: (struct sfm_write_info) New.
10101 * som-high.c: (som_draw_title) Properly frees `s'.
10103 * temporary.c: (save_dictionary) Comment fix.
10105 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10106 (struct trns_header) Formatting fix.
10107 (struct save_trns) New.
10109 * vars-atr.c: (discard_variables) Comment fix.
10111 * sfm-write.c: New file, baseline release.
10113 * sfmP.h: New file, baseline release.
10115 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10117 * cmdline.c: (parse_command_line) `--version' output updated.
10118 (glob var syntax_message[]) Added my e-mail address.
10120 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10121 `illegal' to `invalid'.
10123 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10124 uncompression buffer.
10125 (sfm_close) Frees decompression buffer.
10126 (sfm_read_dictionary) Initializes decompression buffer.
10127 (buffer_input, read_compressed_data) New functions.
10128 (sfm_read_case) Restructured; now calls read_compressed_data() to
10129 handle compressed system file data.
10131 * var.h: Comment fix.
10133 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10135 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10138 * get.c: New comments. New static var `get_file'.
10139 (cmd_get) Now fully implemented. Calls discard_variables();
10140 initializes fv and lv for all variables; new debug code; sets
10141 up the dictionary; sets up the input program.
10142 (read_from_get, cancel_get) New functions.
10144 * sfm-read.c: Comment fixes.
10145 (sfm_close) New static function.
10146 (sfm_read_dictionary) Properly sets up the class of the
10147 file_handle. No longer cares what size the data is in records of
10148 type 7. Also, on failure, properly cleans up the file_handle and
10149 free()s some stuff.
10150 (read_variables) No longer thinks it knows `nval' of the
10151 dictionary. Now sets p.get.fv, etc., instead of speculatively
10153 (read_value_labels) Fixed off-by-one error in indexing of
10155 (sfm_read_case) New function.
10156 (sfm_r_class) New static var.
10158 * var.h: (get_proc) New struct.
10159 (struct variable) New member p.get.
10161 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10163 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10164 the manual's meaning.
10165 (rename_variables) New function.
10166 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10167 code. Now properly reorders the dictionary on the KEEP keyword.
10169 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10170 garbage collection.
10172 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10173 (rename_variable) New function.
10174 (free_val_lab) Reformatted.
10176 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10178 * var.h: Reindented entire file. Comment fixes.
10179 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10181 (glob var default_dict) New.
10182 (struct indirect_dictionary) Removed.
10184 * Many other source files were changed to add `default_dict.'
10185 before all references to the dictionary of the active file.
10187 * vars-atr.c: (make_indirect_dictionary) Removed.
10189 * glob.c: Reindented all variable declarations. Updated for
10190 changed var.h. Comment fixes.
10192 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10193 because now we can mainly copy dictionary structs.
10195 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10196 parse_variables) Takes dictionary instead of indirect_dictionary
10198 (parse_variables) Instead of calling make_indirect_dictionary,
10199 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10200 of `*dict.' references had to be changed to `dict->'. Removed
10203 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10205 * get.c: Added GTSV_OPT_* series of enums.
10206 (trim_dictionary, dict_delete_run) New functions.
10207 [DEBUGGING] (dump_dict_variables) New function.
10208 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10209 [DEBUGGING] Calls dump_dict_variables() to display results.
10211 * glob.c: (cmp_variable) Now a public function declared in var.h.
10213 * sfm-read.c: Turned off debug code. Comment fixes.
10214 (read_machine_int32_info, read_machine_flt64_info) New functions
10215 to parse type 7 records.
10216 (sfm_read_dictionary) Properly byteswaps several fields now.
10217 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10218 records. [DEBUGGING] Dumps dictionary.
10219 (read_variables) Sets `index' field of variables created properly.
10220 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10221 longer dumps dictionary.
10222 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10224 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10226 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10227 var before destroying any variables just to save a little time.
10229 * var.h: (struct variable) Reordered in order to make name[] the
10230 first member; this makes pointers to `variable' pointers to the
10231 variable name, simplifying avl trees, etc.
10232 (struct indirect_dictionary) New struct.
10234 * vars-atr.c: (find_variable) Rewritten for efficiency.
10235 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10237 (is_varname) Rewritten for efficiency.
10238 (parse_variables) New argument, which is a `dictionary *'. All
10239 references changed. This function now reads variable names from
10240 the dictionary passed, or from the default dictionary if NULL.
10242 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10244 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10245 rounding up. Changed many references to ROUND_UP to use this
10248 * sfm-read.c: Includes avl.h.
10249 (corrupt_msg) Induces a segfault under Checker.
10250 (macro assertive_bufread) New. Many references to bufread() now
10252 (sfm_read_dictionary) Split up into several functions. Added code
10253 to read dictionary records following the the type 2 records. Not
10254 quite complete. New variable `var_by_index'.
10255 (read_header, read_variables) New functions extracted from
10256 sfm_read_dictionary().
10257 (read_value_labels) New function.
10258 (bufread) Checks ferror() if fread() doesn't return the expected
10259 value; if ferror() is zero it's just EOF.
10260 (dump_dictionary) Stubbed out.
10262 * BTW: The source code now exceeds 50000 lines!
10264 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10266 * command.c: Added GET to cmd_table[].
10268 * list.q: Removed reference to alloca headers.
10269 (cmd_list) Gave prototype.
10271 * sfm-read.c: Added DEBUGGING comments.
10272 (sfm_read_dictionary) Checks bias correctly. Sets
10273 dict->var_by_name to NULL. Calculates long_string_count
10274 correctly. realloc's dict->var[] array to minimum size.
10275 [DEBUGGING] Calls dump_dictionary.
10276 [DEBUGGING] (dump_dictionary) New function.
10278 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10279 (restore_dictionary) If the dictionary contains a non-NULL
10280 var_by_name, uses that instead of generating one.
10281 (free_dictionary) Destroys var_by_name.
10283 * var.h: (struct dictionary) Added field `var_by_name'.
10285 * get.c: New file, not complete.
10287 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10289 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10290 (parse_num_or_range) New function.
10291 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10292 <n> THRU HIGH missing values.
10294 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10295 __attribute__((const)).
10297 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10299 * sfm-read.c: Finished reference implementation.
10301 * sfm.h: Includes var.h.
10303 * var.h: Comment fixes.
10304 (struct `variable') Reordered some fields.
10306 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10307 constants added previously.
10309 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10311 * common.h: Comment fixes. Added declaration of
10312 `second_lowest_value' as variable or macro. Made `compat_type',
10313 `pgm_state_type' into anonymous enums.
10315 * display.c: Comment fix.
10317 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10319 [!defined SECOND_LOWEST_VALUE] Added definition for
10320 `second_lowest_value' global var.
10321 (compat, pgm_state global vars) Changed types to `int'.
10322 (init_glob) Initializes `second_lowest_value'.
10324 * sfm-read.c: Continued work, not complete.
10326 * var.h: Added new MISSING_* constants to handle LOWEST and
10329 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10331 * sfm-read.c: New file, not complete.
10333 * cases.c: (vec_insert) Changed vector expansion algorithm.
10334 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10335 mucking up the RECODE transformation in particular.
10336 (envector) Harmless change in notation.
10338 dfm is now fairly well tested again.
10339 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10341 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10343 * recode.c: Comment fix.
10345 * sfm.h: Interface should be fairly final now, or at least for a
10348 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10349 (open_active_file) [DEBUGGING] Translates ccase indices into
10350 variable names now to make it easier to understand what's really
10353 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10355 * data-in.c: Comment fix.
10357 * data-list.c: Includes dfm.h.
10358 (do_reading) Uses new function dfm_push_cust().
10360 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10361 `return 1;' at end.
10363 * file-handle.h: Completely changed. Some parts split off into
10364 new file dfm.h. Implemented in file-handle.q.
10365 (enum FH_*) Removed.
10366 (struct fh_ext_class) New struct.
10367 (struct file_handle) Retained only these fields: name, norm_fn,
10368 fn, recform, lrecl, mode. New fields class, ext.
10369 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10370 close_handle, handle_name) Added `fh_' prefix to name, all
10371 references changed.
10373 * dfm.h: New file, implemented in dfm.c.
10374 (get_record, put_record, fwd_record, bkwd_record, set_record,
10375 get_cur_col) Functions moved from file-handle.h, now prefixed with
10377 (dfm_push_cust) New function.
10379 * sfm.h: New file. Incomplete.
10381 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10382 interface. Functions reordered, comments changed. Not well
10383 tested, probably full of bugs.
10384 (struct dfm_fhuser_ext) New struct.
10385 (dfm_close) New function.
10386 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10387 (open_file_w) User messages changed.
10388 (get_record) Comment fixed.
10389 (read_record) Increments ext->ln even for inline_file. Calls
10390 dfm_close() for inline_file when `END DATA.' encountered.
10391 (dfm_get_record) Experimental restructuring.
10392 (dfm_push_cust) New function.
10393 (cmd_begin_data) Detects whether the inline file was fully read by
10394 checking whether it is still open; detects whether it was read at
10395 all by checking whether the line number is greater than zero.
10397 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10398 interface. Functions reordered, comments changed. Not well
10399 tested, probably full of bugs.
10400 (init_file_handle) Removed initializers for obsolete fields, added
10402 (fh_close_handle) Much simpler, now mainly calls the class
10404 (fh_init_files) Renamed inline file internal filename.
10406 * file-type.c: Includes dfm.h.
10407 (read_from_file_type) Doesn't use dfm internal state anymore.
10409 * inpt-pgm.c, print.c: Include dfm.h.
10411 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10412 int in comparison with other int.
10414 * som-high.c: (build_target) Fixed operator precedence problem in
10415 if statement (& versus ==).
10417 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10419 * dfm.c: (read_record) Can now read fixed-length records; not
10421 (put_record) Can now write fixed-length records; not tested.
10423 * file-handle.h: FH_* defines changed to enums. New enum series
10425 (struct file_handle) New members recform, lrecl, mode.
10427 * file-handle.q: Parser changed.
10428 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10429 /LRECL subcommands. These are compatible with Windows.
10430 (init_file_handle) Initializes recform, mode fields.
10432 * q2c.c: (get_line) When outputting `!' comment lines, now
10433 increments the output file line number so that `#line' directives
10435 (make_identifier) New function that converts an arbitrary string
10436 into a valid C identifier.
10437 (dump_vars) Calls make_identifier() in two places in order to
10438 suppress some errors for bad identifiers.
10439 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10440 for NO. Allows numbers to be prefixed by underscores to make them
10441 acceptable C identifiers but still to be parsed as numbers by the
10444 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10446 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10448 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10449 was opened for writing.
10450 (open_file_w) New function.
10451 (read_record) Uses strncasecmp if available. Improved error
10452 messages, comments.
10453 (put_record) New function.
10455 * file-handle.h: Moved function comments into dfm.c and
10456 file-handle.q. Comment fixes. Removed declarations of
10457 tilde_expand() and normalize_filename().
10458 (struct file_handle) Changed `open' from boolean to enumerated
10459 field to allow for three states--closed, open for reading, open
10460 for writing--all references changed.
10462 * file-handle.q: Includes filename.h.
10464 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10465 references changed.
10466 (alloc_line) Makes allowance for line terminator characters in
10468 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10469 (print_space_trns_proc) Handles OUTFILE differences.
10471 * recode.c, sample.c: Comment fixes.
10473 * var.h: (struct print_trns) Changed boolean field `eject' to
10474 bitmapped field `options'; all references changed. New enums
10475 PRT_* for use with this field.
10477 * exception.h, test-exception.c: Removed.
10479 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10481 * ascii.c: (delineate) Turned off debug output.
10483 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10486 * data-in.c: (parse_string_as_format) Sets the entire string value
10487 to spaces, not just the short string part of it. Is this correct
10490 * data-out.c: (convert_date) Fixed DATETIME format problems with
10491 decimal places, removed debug code.
10493 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10494 middle of parsing BEGIN DATA that would cause the lexer to read
10495 from a wild pointer `prog'; now calls new function
10496 preprocess_line() in lexer.c.
10498 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10500 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10501 Now call induce_segfault() to induce the segfault.
10502 (induce_segfault) New function.
10504 * expr-opt.c: Comment fix.
10505 (parse_sysvar) New function.
10506 (parse_primary) Added system variable support--calls
10508 (global var ops) Added OP_CASENUM operator.
10510 * expr.h: Comment fixes.
10511 (OP_* enum) added OP_CASENUM operator.
10512 (struct casenum_node) New struct.
10513 (union any_union_union) New member `cas' of type `casenum_node'.
10515 * glob.c: (global var last_vfm_invocation) New var.
10516 (init_glob) Initializes last_vfm_invocation.
10518 * lexer.c: (lookahead) Fixed reversed condition on if statement.
10520 * getline.c: (get_line) Split into get_line() and preprocess_line().
10521 (preprocess_line) New function.
10523 * var.h: Declares last_vfm_invocation.
10525 * vfm.c: (procedure) Sets last_vfm_invocation.
10527 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
10529 * command.c: (parse_cmd) Fixed bad assertion related to
10532 * data-in.c: (parse_month) Implemented to parse months according
10533 to full interpretation of standard.
10534 (to_roman) New function.
10535 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
10536 (parse_weekday) Bug fix (forgot to skip all the day name).
10538 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
10539 up parsing of multirecord data items. Also fixed user message.
10541 * data-out.c: Comment fix.
10542 (year2, year4, convert_date, convert_time, convert_WKDAY,
10543 convert_MONTH) New functions to support time & date output.
10544 (convert_format_to_string) Calls new time & date output routines.
10546 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
10548 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
10551 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
10553 * misc.c: (global var formats) Fixed declarations of DATETIME,
10556 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
10557 the output_char buffer.
10559 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
10560 memory bug. Fixed user messages.
10562 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
10564 * Removed #pragma argsused from lots of places.
10566 * data-in.c: Implemented zoned decimal and time-date formats.
10567 Untested. This is a huge chunk of code--maybe 1000 lines and 50
10570 * data-out.c: Implemented zoned decimal format.
10572 * expr.h: Moved yrmoda() declaration here from exprP.h.
10574 * misc.c: (global var formats) Minor fixes--added
10575 FCAT_SHIFT_DECIMAL to formats N and Z.
10576 (convert_fmt_ItoO) Added support for format Z.
10578 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
10580 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
10582 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
10583 som_check_workspace() that is activated between commands.
10585 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
10588 * list.q: (begin_row) Changed title expansion style from
10589 SOPT_X_VERT to SOPT_X_SHSP.
10591 * som-frnt.c: Now includes `somP.h'.
10592 (som_push_workspace, som_pop_workspace) New functions that, taken
10593 together, form a solution to the recursive table building problem
10594 mentioned yesterday. Surrounded every table output routine
10595 throughout the program with calls to these functions.
10596 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
10597 (som_create_table) Checks that there's an active workspace.
10598 (som_destroy_all_tables, som_crush) Removed.
10600 * som-high.c: (global var som_preserve_tables) Removed, all
10601 references deleted.
10602 (som_submit_table) Checks that there's an active workspace.
10603 (dump_columnated_table) Doesn't columnate tables that would have
10604 just one row per column.
10605 (dump_crush_page, som_dump_crush_page) Removed debugging code.
10606 (som_dump_crush_page) Moved row number labels from left side of
10607 tables to right side.
10608 (som_get_table_size) Added support for SOPT_X_SHSP.
10610 * som.h: New cell expansion type SOPT_X_SHSP.
10612 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
10614 (global var curtab_arena) Moved from som-frnt.c.
10616 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
10618 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
10619 that causes bad location warnings to be suppressed.
10620 (delineate) Saves current font when calling draw_text(); fixed
10621 handling of NULLs when backing up. Also fixed line-wrapping bug.
10623 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
10624 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
10626 * common.c: Added code to cause assertion failure to dump core
10627 when run under Checker.
10629 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
10630 there are still bugs.
10632 * glob.c: (__eprintf) Removed.
10634 * list.q: Inserted som_preserve_tables kluge that prevents tables
10635 from being thrown away due to recursive table building through
10636 som_output_line being called from a transformation during the LIST
10637 procedure invocation. This is a general problem that must be
10638 solved in a better way since it applies to all procedures in
10640 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
10641 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
10643 * numeric.c: Fixed several errors in the form of msg() calls.
10645 * print.c: Updated for use of som.
10646 (dump_table) Reimplemented.
10647 (print_trns_proc) Calls som_eject_page() instead of eject_page().
10648 Calls som_output_text() instead of outs_line().
10650 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
10652 (som_output_text) Function moved from som-low.c. Interface
10655 * som-high.c: (som_preserve_tables) New global public variable
10657 (som_submit_table) Destroys the tables only if som_preserve_tables
10659 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
10660 one subrow per row. Now labels subrows if there's more than one
10662 (dump_crush_table) Added wishlist comment.
10663 (som_eject_page) New public function declared in som.h.
10665 * som-low.c: (som_dump_crush_page) Draws row labels if there's
10666 more than one subrow per row.
10667 (som_output_text) Moved to som-frnt.c.
10669 * som.h: (SOM_TOPT_PRESERVE) Removed.
10671 * title.c: (get_title) Changed interface.
10672 (cmd_title) Changed `title' to `outp_title'.
10673 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
10675 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
10677 * list.q: (flush_table) Conforms to new partial options in
10678 som_submission_form.
10680 * som-high.c: (paginate_horizontally) Changed form of subrow
10682 (build_target) Omits spacing before table if
10683 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
10684 (dump_crush_page) Changed interface. Only trims bottom rule if
10685 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
10686 (dump_crush_table) Handles partial tables.
10687 (output_row_label) New function.
10688 (som_dump_crush_page) Emits subrow number labels. Draws vertical
10689 rule on the right edge of narrow subrows.
10691 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
10692 constants to a series of SOM_TOPT_PARTIAL_* submission options.
10693 All references updated.
10695 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
10697 * misc.c: Comment fix.
10699 * som-high.c: (examine_table) Treats crushed tables separates for
10700 purpose of determining header size.
10701 (paginate_horizontally) Allots space for line numbers in crushed
10702 tables with lots of subrows per row. Calculates the `maximum page
10703 width', the width of the widest horizontal page.
10704 (build_target) Removed trim argument; all references changed.
10705 Stricter assertions. (dump_crush_page) New function.
10706 (dump_crush_table) Reimplemented.
10708 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
10709 (som_dump_crush_page) Reimplemented, interface changed.
10711 * somP.h: Many many new helper macros for use with crushed tables.
10712 (global var som) Removed `tv', `cum_y' members; all references
10713 removed. New members `mpw', `digit_space'.
10715 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
10717 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
10718 variable, changed to constant 1024.
10719 (arena_ca_strdup) Changed `sizeof(a_string)' to
10720 `sizeof(c_string)'.
10721 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
10722 `(c_string *)' to `(char *)'; this fixed some offset problems.
10724 * filename.c: (readlink_malloc) Changed initial allocation from
10726 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10729 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10730 &fm->owner in several places.
10732 * som-high.c: (output_table) Changed interface to rest of world.
10733 (examine_crush_table) Removed. Crushed tables are re-broken now,
10734 in preparation for rewrite.
10736 * som.h: Comment fix.
10738 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10740 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10741 itself in the cleanup stage.
10743 * descript.q: (display) At least temporarily, changed the table
10744 format to a crushed table.
10746 * list.q: (begin_row) At least temporarily, added horizontal lines
10749 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10750 the horizontal "headers," that is, to the width of the far left
10751 and far right rules.
10752 (justify_pagination) Sets som.th to the width of the widest row
10753 in the crushed table. Fixed inner loop off-by-one error.
10755 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10758 * somP.h: Comment fix.
10760 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10762 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10763 before closing it; also, opens the constructed filename `s'
10764 instead of f->filename.
10766 * postscript.c: Moved initialization of x->loaded, x->prop,
10767 x->fixed, x->current, also the add_encoding() calls, into
10769 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10770 sets x->last_font to NULL; sets x->next_combo to zero.
10772 * som-high.c: (crushed_row_height) Moved definition farther up.
10773 (som_submit_table) Doesn't calculate line width, font size until
10774 after calling open_page(), to accomodate changes to PostScript
10776 (vert_headers) Removed; equivalent functionality moved to
10777 examine_table(), examine_crush_table().
10778 (justify_pagination) Replaced with different algorithm.
10779 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10780 at the bottom of the page.
10782 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10784 * command.c: Added cmd_list back into cmd_table.
10786 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10787 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10789 * list.q: (flush_table) Updated to new som_submission_form format.
10791 * som-frnt.c: Comment fix.
10793 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10794 (output_table) Calls som_get_table_size() directly; handles
10796 (examine_crush_table) New function; calls vert_headers().
10797 (examine_table) Moved some code into new function, vert_headers().
10798 (justify_pagination) New function.
10799 (dump_plain_table) Removed `static' from `cy'.
10800 (dump_crush_table) New function.
10802 * som-low.c: (som_dump_crush_page) New function.
10804 * som.h: Comment fixes.
10805 (enum SOM_TOPT_CRUSH) New.
10806 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10807 Temporarily set to zero to make do with LIST procedure.
10809 * somP.h: Re-ordering.
10811 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10813 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10815 * somP.h: New file for use by som-high.c, som-low.c.
10817 * q2c.c: Added definition for VME.
10818 (get_line) Now dumps `!' comment lines to the output file
10821 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10822 set.q: Changed format of `!' comment lines.
10824 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10826 * All source files: Added copyright notice.
10828 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10829 longs in msg() calls.
10831 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10833 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10835 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10837 * output.c: (outp_read_devices) Changed criteria for
10838 distinguishing different types of lines.
10840 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10842 * cmdline.c: Changed syntax message.
10844 * filename.c: (good_getcwd) Bug fix (?).
10845 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10847 (search_path) Appends DIR_SEPARATOR to directory name only if it
10848 does not already end with one.
10850 * glob.c: Checks STAT_PAGER envvar before PAGER.
10852 * output.c: Checks environment variables instead of just local
10855 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10857 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10858 when the pointer passed to the function was within the arena
10859 itself, so that it couldn't properly be set to NULL _after the
10862 * command.c: Re-enabled DISPLAY.
10864 * display.c: Rewritten to handle tables. Untested.
10866 * filename.c: (search_path) Fixed memory leak.
10868 * frequencies.q: (cmd_frequencies) Frees v_variables.
10869 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10870 (cleanup_freq_tab) New function to garbage collect.
10871 (dump_full) Elegantized.
10873 * main.c: New comment.
10875 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10877 * postscript.c: Comment fix.
10878 (release_fontmap, free_font_entry) New functions.
10879 (ps_init_driver) Sets free_font_entry() as the freefunc for
10880 hashtable `loaded'. Calls release_fontmap() when destroying a
10881 driver; also frees the output filename; also frees the
10882 ps_driver_ext block.
10883 (free_ps_encoding) Frees the filename as well as the encoding
10885 (output_encodings) Frees the line buffer and pops the msg-filename
10887 (read_fontmap) Frees the fontmap filename and the line buffer.
10888 (postopen, preclose) Misc. garbage collection fixes.
10889 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10890 to NULL; this fixes some output problems.
10891 (text) Handles TAG_NEWLINE. Untested.
10893 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10894 (som_set_string) Removed. All references changed to
10896 (som_set_text) Rewritten. New interface. More general.
10898 * som.h: Minor format changes.
10899 (struct som_value_cell) Removed; all references changed to
10901 (enums SOT_*) Changed.
10903 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10905 * command.c: Re-enabled SPLIT FILE.
10907 * postscript.c: Comment fix.
10909 * som.h: Added `SOT_NONE'.
10911 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10913 * vfm.c: (dump_splits) Reimplemented.
10915 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10917 * Compiled the project under gcc 2.7.2, which gave some new
10918 warnings. This led to many additions of casts from unsigned to
10919 int sprinkled throughout the code.
10921 * arena.c: Many uses of `unsigned' changed to `size_t'.
10923 * command.c: Added END FILE, END REPEAT to command table.
10924 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10925 (find_command, FILE_TYPE_okay) Not commented out anymore.
10926 (parse_cmd) Calls FILE_TYPE_okay again.
10927 (output_line) Added calls to som_output_text() to put the line
10928 in the output files.
10930 * common.c: (macro VME) Format changes.
10931 (xstrdup) Asserts that its argument is not NULL.
10933 * data-list.c: Implemented dump_fixed_table().
10935 * inpt-pgm.c: Formatting changes. Comment changes.
10936 (end_case_proc) Renamed end_case_trns_proc.
10937 (cmd_end_file, end_file_trns_proc) New functions.
10939 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10941 * misc.h: (local_strdup) New macro corresponding to strdup() but
10942 allocating its data through local_alloc() if possible--that is, if
10945 * postscript.c: Comment changes.
10946 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10947 (output_line, add_string) New macros supporting
10948 output_encodings().
10949 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10950 substitution vars. Calls output_encodings() when a line
10951 consisting of `!encodings' is encountered.
10952 (preclose) Some code moved into quote_ps_string().
10953 (dump_line) Changed into macro supporting dump_fancy_line().
10954 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10955 command when appropriate.
10956 (write_text) Fixed `literal_char' array (I think it's fixed, at
10958 (text) Fixed bug when width was zero. Now exits immediately on
10959 zero height_left. Now, when executing `goto restart;', checks
10960 that cp<end, so that we don't read beyond end-of-string. Also,
10961 outputs the correct code to the output file by outputting the code
10962 from the metric instead of the internal metric index.
10964 * repeat.c: (cmd_end_repeat) New function.
10966 * som.c: (var som) `headers' renamed `options' and semantics
10967 changed. All references changed.
10968 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10969 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10971 (som_text_table) Removed.
10972 (som_output_text) New function.
10974 * som.h: (struct som_submission_form) Removed `header', `reuse',
10975 replaced with bitmapped field `options'.
10976 (SOM_TOPT_*) New enum set for som_submission_form.options.
10977 (SOT_*) New enum set for som_output_text().
10979 * temporary.c: (copy_variable) When copying the var label, only
10980 calls xstrdup() if it's non-NULL.
10982 * var.h: (enum type `vartype') Removed; all references changed to
10985 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10988 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10990 * font.h: Comment changes.
10992 * groff-font.c: (groff_read_font) Initializes `name' field to
10993 NULL. Handles `encoding' field.
10995 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10997 * postscript.c: (struct font_entry) Removed `position' field.
10998 (struct ps_font_combo) New struct.
10999 (struct ps_driver_ext) Removed field `next_position'. New fields
11000 `combos', `next_combo'. `last_font' field changed from
11001 `font_entry *' to `ps_font_combo *'.
11002 (ps_init_driver) Reformatted; handles new fields. When
11003 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11005 (get_encoding, find_encoding_file) New functions.
11006 (add_encoding) Some code moved out into find_encoding_file().
11007 (postopen) Changed value for ${title}.
11008 (preclose) Sets `loaded' field to NULL after destroying the hash
11010 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11012 (ps_text_set_font_by_position) Figures out the current family if
11014 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11015 (switch_font) Implemented.
11016 (write_text) Calls switch_font() more often. Format changes.
11017 #undefs its macros after they're no longer useful.
11018 (text) Changed `continue' at one point to a jump to the top of the
11019 loop because we don't want `separate' reset to 0 at that point.
11020 (load_font) No longer sets `position' in the font_entry created.
11022 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11024 * font.h: (struct font_desc) New member `encoding', which is not
11025 properly handled yet.
11027 * glob.c: (init_glob) Some new i18n code, which is probably
11030 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11031 `size' local from `int' to `size_t'.
11033 * postscript.c: New driver configuration parameter `auto-encode'.
11034 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11035 (struct font_entry) New member `position'.
11036 (struct ps_driver_ext) Reordered. New hash table member
11037 `encodings'; new members `next_position', `next_encoding',
11038 `last_font'. Members `current', `prop', `fixed' changed from type
11039 `font_desc *' to `font_entry *'; all references changed.
11040 (struct ps_encoding) New struct.
11041 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11042 free_ps_encoding, add_encoding) New functions.
11043 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11044 x->output_options. Initializes new members of ps_driver_ext.
11045 Changed default value for prologue_fn, encoding_fn. Calls
11046 read_ps_encodings after loading default fonts.
11047 (option_tab[], ps_option) Handle new configuration parameter.
11048 (switch_font) New function.
11049 (struct output_char) `font' member changed from `font_desc *' to
11050 `font_entry *'. New member `separate'.
11051 (read_fontmap) Changed `size' from `int' to `size_t'.
11052 (output_line, put_number) New macros for write_text().
11053 (write_text) Optimizes text output by consolidating multiple
11054 calls to PostScript `show' operator.
11055 (text) Keeps track of when text arguments can't be consolidated by
11056 write_text(), and marks those spots in the output stream.
11057 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11058 the font hasn't been switched to by switch_font(), which is where
11059 the position is important--the PostScript is what cares about the
11062 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11064 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11065 call a NULL free_func.
11066 (hsh_rehash) Elegantized.
11067 (hsh_probe) Fix bug that manifested when the table was expanded
11068 and thus had to change location in memory. Good thing
11069 too--otherwise could have been much more subtle.
11070 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11071 (hsh_foreach) New function for hash table iteration.
11073 * hash.h: (struct hsh_iterator) New.
11075 * lexer.c: (parse_tagged_quote) Font and family name strings in
11076 tags are now null-terminated.
11078 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11080 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11081 documented. (Never before tested?)
11083 * output.h: Comment changes.
11085 * postscript.c: New driver options `optimize-text-size',
11086 `optimize-line-size', `max-fonts-simult'. New enum set for
11087 specing cached line types. Comment fixes.
11088 (struct line_form) New struct.
11089 (struct ps_driver_struct) New members `text_opt', `line_opt',
11090 `max_fonts', `lines'.
11091 (ps_init_driver) Initializes new members of ps_driver_struct.
11092 (user option type enum set) New member `nonneg_int_arg'.
11093 (static var option_tab[]) Supports new options.
11094 (ps_option) Handles new options.
11095 (find_ps_file) Made static. No longer calls hsh_dump().
11096 (ps_get_var) Made static.
11097 (preclose) Dumps out proper DSC trailer.
11098 (ps_open_page) Elegantized.
11099 (ps_close_page) Calls dump_lines() if appropriate.
11100 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11101 wrappers around line().
11102 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11103 dump_lines, hash_line, free_line, line) New functions for support
11105 (write_text, text) Made static.
11106 (text) Added to font support, not finished.
11108 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11110 * font.h: (struct font_desc) New members ascent, descent.
11112 * groff-font.c: (groff_read_font) Calculates font ascent and
11113 descent from the ascent and descent of the `d' and `p' characters,
11114 respectively, as per a suggestion on comp.fonts.
11116 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11117 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11119 (write_text) Handles text right-justification and centering (not
11120 full justification). Still very inefficient. (One output line
11122 (struct output_char) Added fields for font and font size.
11123 (text) Many bugfixes.
11125 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11127 * cmdline.c: (usage) Calls outp_list_classes().
11129 * font.h: Comment fix.
11131 * groff-font.c: New exported global var `space_index'.
11132 (groff_init) New function to initialize `space_index'.
11133 (hash_kern) Casts result to unsigned.
11134 (font_name_to_index) Renamed font_char_name_to_index. All
11135 references changed. Also, now returns the value of `space_index'
11136 when passed an ASCII space character as an argument. Fixed
11138 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11139 Handles passed NULL pointers properly.
11141 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11144 * output.c: (outp_list_drivers) Removed. Removed all references.
11146 * output.h: Comment fixes.
11148 * postscript.c: (ps_open_global) Calls groff_init().
11149 (output_char) New structure.
11150 (write_text) New function.
11151 (text) No longer stubbed out! Now the output is correct--with a
11152 few exceptions, one of them being that the page has to be held
11153 upside down into a mirror.
11155 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11157 * font.h: Comment fix.
11159 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11160 All callers changed.
11161 (number_to_index) Renamed font_number_to_index, made extern. All
11163 (font_get_kern_adjust, font_get_char_metrics) New functions.
11165 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11167 * postscript.c: Changed default line width back to 1/2 point.
11168 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11169 in the center of the space allotted for them, not just a fixed
11170 offset from the edge of the space; this fixes some bugs.
11171 (ps_line_intersection) Now supports all command line styles.
11172 (ps_text_get_size) Bug fix in computation of em width.
11173 (text) New function, the meat behind ps_text_metrics and
11174 ps_text_draw. Not complete.
11175 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11176 ascii.c; call text().
11178 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11180 * arena.c: (arena_free) Assert that the argument is non-NULL.
11182 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11183 only if old_kern is non-NULL.
11185 * postscript.c: (ps_init_driver) Changed default line width to 1
11187 (postopen) New prologue variables.
11188 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11189 more of the common line styles properly, but not all.
11190 (ps_text_metrics) Fixed problem with this stubbed out version that
11191 kept it from taking font sizes into account.
11193 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11195 * arena.c: (arena_malloc) Bug fix.
11196 (arena_dump) [GLOBAL_DEBUGGING] New function.
11198 * ascii.c: Comment fix.
11199 (count_fancy_chars, delineate) Now static functions.
11201 * filename.c: (interp_vars) Bug fixes.
11203 * font.h: Comment fixes.
11205 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11206 beginning in case we have an error message to display before
11207 initializing the display.
11209 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11211 (groff_read_font) Bug fixes.
11212 (name_to_index) Increments hash.used. Sets `name' field of hash
11214 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11216 * hash.c: Return type changed.
11218 * postscript.c: Continued development. Now marks lines on the
11219 paper, but very buggy.
11221 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11223 * Changed comments in many source files from `/* xxx /* yyy */' to
11224 `/* xxx */ /* yyy */' for cleanliness.
11226 * arena.c: (arena_sd_strdup) New function.
11228 * ascii.c: (struct ascii_driver_ext) New member `file'.
11229 (ascii_init_driver) Fills out member `file' for initing; uses
11230 close_file_ext for closing drivers.
11231 (ascii_option) Changed %.*s back to %s because the a_string's are
11232 always null-terminated.
11233 (postopen, preclose) New functions.
11234 (ascii_open_page) Uses new style of open_file_ext.
11235 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11236 instead of this->output.
11237 (__assert_fail) Removed.
11239 * cmdline.c: Changed syntax_message[].
11241 * error.c: #include's <readline/history.h> only if the history
11242 library is available, not if just the readline library is
11245 * filename.c: (expand_line) Removed alloca() support.
11246 (interp_vars) No longer tilde-expands argument. Limit on output
11248 (tilde_expand) Now treats argument as path rather than filename.
11249 [!unix] Now is a no-op function.
11250 (search_path) Better verbose message formatting.
11251 (open_file, close_file) Comment fixes.
11252 (close_file) [!unix] Doesn't bother with pipes.
11253 (open_file_ext) Completely rewritten, interface revamped.
11254 (close_file_ext) New function.
11256 * font.h: Comment changes.
11258 * frequencies.q: Removed AIX alloca support since it doesn't use
11261 * hash.c: Comment changes & additions.
11262 (hsh_create) Initializes entire table instead of first M entries.
11263 (hsh_probe) Stupid bug fixed. Now it works.
11264 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11266 * main.c: (parse) Detects EOF properly in token-eating loop.
11267 Should the STOP token have its value changed to 0?
11269 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11270 (blp_getline) Now it's a macro.
11272 * output.h: (struct outp_driver) Removed members output, filename.
11274 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11275 drivers in driver table.
11276 (outp_read_devices) Frees buf. Warns if there are no active
11278 (outp_configure_clear) Sets outp_configure_vec to NULL after
11279 deleting its elements.
11280 (configure_driver, destroy_driver) Removed references to output,
11281 filename members of outp_driver.
11282 (outp_evaluate_dimension, internal_get_paper_size,
11283 outp_get_paper_size) New functions.
11285 * postscript.c: Continued development. Now links but doesn't make
11286 any marks on the page. Lotsa bugs I suppose.
11288 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11290 * str.h: Comment changes.
11292 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11294 * Removed dependencies on non-nested comments in several files.
11295 Also removed references to (unix || __unix__) in #if's since
11296 prefh.orig makes those two equivalent.
11298 * ascii.c: (ascii_open_global) Creates ascii_arena.
11299 (ascii_close_global) Destroys ascii_arena.
11300 (ascii_init_driver) Doesn't create ascii_arena.
11301 (ascii_copy_driver) Removed.
11302 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11303 (outp_class ascii_class) Removed ascii_copy_driver reference.
11305 * frequencies.q: Now can display all statistics except median.
11306 Still not finished.
11308 * output.c: Handles outp_class.ref_count so output class
11309 destructors are called properly.
11310 (add_class) Sets ref_count to 0.
11311 (configure_driver) Initializes class if ref_count++ is 0.
11312 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11313 class output file name.
11315 * output.h: (struct outp_class) Removed copy_driver, inited.
11318 * postscript.c: Completely replaced but not finished.
11320 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11322 * approx.h: #includes <float.h>.
11324 * arena.h, arena.c: Many functions changed to take an arena **
11325 instead of an arena *, for consistency. All callers changed.
11326 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11327 (arena_destroy) Sets *A to NULL.
11329 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11330 assertion that `width' be positive.
11332 * command.c: Removed #if's from cmd_table.
11333 (walk_cmdtable_func) [0] New function (debug code).
11334 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11335 (parse_cmd) Doesn't return failure for unimplemented commands.
11337 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11338 (SYSCODE) New constant macro.
11340 * descript.q: Checks for positive n_variables before performing
11343 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11344 avl_find instead of &fp as arg 2.
11346 * frequencies.g, frequencies.q: Continued updating; now compiles &
11347 works again, but not complete.
11349 * main.c: Changes to user messages.
11351 * misc.c: (reverse) [0] New function.
11353 * settings.h: Comment removed. #includes "common.h".
11355 * som.c: (som_set_null) New function.
11356 (som_set_value, som_set_string, som_set_text) More detailing
11358 (som_set_float) Implemented function.
11359 (dump_columnated_table) Bug fix regarding page breaks.
11360 (draw_cell) Bug fix regarding text that spilled out of a cell.
11361 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11363 (get_cell_size) Support SCON_EMPTY cells.
11364 (get_table_size) When calculating rules' widths and heights, mask
11365 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11367 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11369 (struct som_submission_form) New member `header'; all users
11372 * val-labs.c: (get_label) User messages changed.
11374 * var.h: Changed FREQUENCIES structures.
11376 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11379 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11381 * approx.h: Definition of EPSILON now depends on system's
11382 DBL_EPSILON. Removed GNU C specific code.
11383 (cmpapx) Renamed approx_compare.
11385 * frequencies.g, frequencies.q: Continued updating; still doesn't
11388 * groff-font.c: (name_to_index) Fix bug that kept it from
11391 * hash.c, hash.h: Completed work.
11393 * var.h: Changes to freq_tab, frequencies_proc.
11395 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11398 * hash.c, hash.h: New files. Not completed.
11399 * Makefile.am: Added hash.c to source file list.
11400 * font.h: (struct font_desc) New member kern_size_p.
11401 * groff-font.c: Uses hash.h.
11402 (hashpjw) Moved to hash.c.
11403 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11405 (static var hash) New member size_p.
11406 * var.h: Includes hash.h.
11407 (struct freq_tab) Changed AVL_TREE to hash_tab.
11409 * vars-prs.c: Comment, formatting fixes.
11411 * frequencies.g, frequencies.q: Continued updating. Not yet
11414 * formats.c: Bug fix.
11416 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11418 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11419 * descript.g: Comment fixes.
11420 * descript.q: Comment fixes. Moved some declarations into var.h.
11421 Made dsc_info a static table. Updated FIXMEs.
11422 (internal_cmd_descriptives) Beautified.
11424 * frequencies.q: Started updating into working order.
11425 * frequencies.g: New file analogous to descript.g.
11426 * var.h: Comment fixes. Added structures for FREQUENCIES.
11428 * som.c: Removed vestiges of crushing and partial table support.
11430 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11432 * Many more changes to som.c especially, but these will not be
11433 documented as I have resolved to remove them. This patchlevel is
11434 being released solely so that I can fall back to it if I decide
11435 that removing the changes is not a good idea.
11437 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11439 * som.c: (global var som) New member `cum_y'.
11440 (build_target) Properly handles titles for partial tables.
11441 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11442 Merged into single new function dump_partial(). Fixed problem
11443 with titles on partial tables.
11444 (dump_table) Calls dump_partial() for all parts of partial tables.
11445 (dump_page) Criteria for drawing title changed.
11447 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11449 * command.c: (cmd_table) Added LIST, WEIGHT.
11451 * command.c: (cmd_remark) No longer frees `s' since it's not
11452 dynamically allocated.
11454 * data-out.c: (convert_f) Now correctly handles the case where
11455 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11456 number of decimals.
11457 (som_destroy_all_tables) Removed argument. All callers changed.
11458 (som_vline, som_hline) Argument validity checking corrected.
11459 (som_set_value) Implemented half-heartedly.
11460 (replicate_table) Copies tables piece-by-piece when using Checker.
11462 * som.h: New line style SLIN_1THIN, currently equivalent to
11463 SLIN_0. New enum set SOM_SUB_*.
11464 (struct som_submission_form) Removed `seq_no'. Added `type'.
11466 * list.q: Newly working file; uses partial tables.
11468 * som.c: (som_reduce_table) Renamed som_set_table_height().
11469 (som_crush) Removed argument `group'.
11470 (global var som) Removed `nt', `seq_no'. Added `type'.
11471 (som_submit_table) Arguments changed.
11472 (output_table) Removed partial table code.
11473 (build_target) New arg; partial table support added. All callers
11475 (dump_plain_table) Removed partial table code.
11476 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11477 (dump_table) Supports partial tables.
11478 (dump_page) New argument to allow not drawing top and/or bottom
11479 headers. All callers changed. Supports partial tables.
11481 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11483 * data-out.c: Changed `#include <approx.h>' to `#include
11485 (convert_F) Comment fix. Now won't print `-.000', etc.
11487 * descript.q: Now Z-scores work, although there appears to
11488 be a bug (which might actually be in data-out.c:convert_F()).
11489 (descriptives_trns_proc, descriptives_trns_free) New functions.
11490 (run_z_pass) Implemented.
11492 * var.h: Comment fixes.
11493 (dsc_z_score, descriptives_trns) New structs.
11494 (descriptives_trns) Added to any_trns as `dsc'.
11496 * error.c, error.h: New error class, IS (Installation Script
11497 error), used in those instances where the error is in the
11498 installation, but there is a script file or installation file that
11499 can be usefully referred to.
11501 * output.c: Change many IE classes to IS classes.
11503 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11504 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11505 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11506 include the corresponding header?
11508 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
11509 Don't bail out if termcap can't be read.
11511 * som.c: (som_destroy_table) Removed.
11512 (som_reduce_table, som_destroy_all_tables) New functions.
11513 (som_crush) New function, not implemented.
11515 * som.h: New table option STAB_CRUSH. Comment fix. New struct
11516 som_submission_form. Function prototypes revised.
11518 Outputting huge tables (1000s of rows) a few rows at a time
11519 is supported, though untested. May even break everything.
11520 Actually, the code doesn't even compile right now.
11521 * som.c: (struct som) New fields htv, nt, seq_no.
11522 (som_submit_table) Multiple arguments changed to a single
11523 pointer to struct submission_form. Only increments subtable_num
11524 if seq_no is zero. Only destroys table if it's not going to
11526 (replicate_table) New function.
11527 (output_table) Comment fix.
11528 (examine_table) Changed inline code to code calling
11529 replicate_table(). Calculates htv. Supports partial tables.
11530 (draw_title) Removed comment.
11531 (build_target) Only allows for title on first part of partial
11533 (dump_plain_table) Only resets table chunk number on first part
11534 of partial tables; FIXME: doesn't work quite right. Supports
11536 (dump_page) Titles only on first part of partial tables.
11538 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
11540 * Thanks to an unreliable IDE hard drive, I have spent the last
11541 day reconstructing my Debian GNU/Linux installation and redoing
11542 the previous day's changes--somehow I managed to save every file
11543 except for output.c and output.h. So the following changes could
11544 really be considered independent of the output.c, output.h changes
11547 * output.h, output.c: Moved the outp_configure_vec global var,
11548 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
11549 outp_configure_vec is now static.
11551 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
11553 * The entire philosophy behind configuration of the output drivers
11554 changed. Now there is a termcap-type configuration where drivers
11555 to be read are determined beforehand, rather than parsing the
11556 entire output init file and storing it in memory & deciding what
11557 to actually use later. Faster & more memory-efficient at the same
11560 * output.c: Comment fix. Removed outp_init_drivers global var.
11561 Removed all references to synonyms. New structure outp_defn. New
11562 global vars outp_macros, outp_configure_vec.
11563 (search_name, delete_name, add_name, check_configure_vec,
11564 expand_name, find_defn_value) New static functions.
11565 (outp_configure_clear, outp_configure_add, outp_configure_macro,
11566 outp_read_devices) New extern functions.
11567 (outp_init) Much functionality moved into outp_read_devices.
11568 (outp_read_devices) Format of output init file changed; name of
11569 file is `devices' rather than `output' to avoid Makefile
11571 (outp_clear) Renamed outp_done.
11572 (outp_list_classes) Bug fix, cleaned up.
11573 (outp_list_drivers) Not implemented anymore.
11574 (outp_configure_driver) Now a static function; simplified; now
11575 interpolates macros; supports new structure.
11576 (outp_enable_driver, match_synonym) Removed; all references
11578 (find_driver) First argument removed.
11580 * output.h: Global var outp_init_drivers removed; new structure
11581 outp_names; new enum set OUTP_S_*; new global var
11582 outp_configure_vec; function prototypes for output.c exports
11585 * main.c: (main) Calls outp_read_devices() after parsing the
11588 * cmdline.c: (parse_command_line) New option -v --verbose;
11589 --version changed to -V. --device option changed syntax to just
11590 take a single device name. Accepts key=value declaration of
11591 output init file macros. Syntax message updated.
11593 * filename.c: (expand_line) New function.
11594 (interp_environ_vars) Renamed interp_vars; no longer uses
11596 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
11597 overridden by real environment vars.
11598 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
11599 * filename.h: interp_environ_vars() renamed interp_vars().
11601 * error.c, error.h: Added extern variable `verbosity', message
11604 * error.c: (vmsg) Support message class MM.
11605 (verbose_msg) New function.
11607 * descript.q: (generate_z_varname) Bug fix in generation of
11609 (dump_z_table) Bug fix in column headers.
11611 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
11612 page from 29 to 15. Don't set a default for ops[OPS_INIT,
11613 OPS_DONE]. Writes the uninit string when the driver is closed.
11614 (ascii_open_page) Write the init string before the first page.
11615 (output_shorts) Form of main loop changed from `while' to `for'.
11616 Bug fix with overstrikes: the character is printed *after* the
11617 backspace. Eliminated a lot of `& 0xff' modifiers.
11618 (advance_to_left_margin) New function.
11619 (return_carriage, output_lines) Handle left margin.
11621 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
11623 * ascii.c: New option `carriage-return-style'.
11625 * ascii.c: (count_fancy_chars) New function.
11626 (delineate, text_metrics) Use new function; bug fixes regarding
11628 (text_draw) Bug fix with rich text.
11629 (output_string, output_shorts) Reordered.
11630 (output_shorts) Now handles boxchars and some overstrike font
11632 (output_char, return_carriage) New functions.
11633 (output_lines) Now handles overstriking and font changes properly;
11634 some code moved to output_shorts.
11636 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
11639 * ascii.c: New member `debug' in ascii_driver_ext.
11640 (ascii_init_driver, delineate) Uses new member.
11642 Now you can set a vertical height on writing text.
11643 * ascii.c: (delineate) Keeps track of vertical position.
11644 (text_draw) No longer considers fully justified text an internal
11647 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
11649 Tables' titles are drawn; they can have variable height.
11650 * som.c: `som' struct has new member, title_height.
11651 (draw_title) New argument. Moved within file. All caller
11653 (build_target) New argument, amount of space needed for first row.
11654 Calculates height of title, takes that into account. All callers
11656 (dump_plain_table, dump_columnated_table) Took calculation of y1,
11658 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
11660 (dump_columnated_table) Organized for readability.
11661 (dump_page) Makes use of som.title_height.
11663 * som.c: Many comment bug fixes.
11665 * descript.q: (try_name, generate_z_name) Bug fix regarding
11666 generation of Z-score variable names.
11667 * var.h: Removed num from descriptives_proc; all referents removed.
11669 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
11671 * ascii.c: (ascii_line_horz, ascii_line_vert,
11672 ascii_line_intersection) Added debugging code.
11674 Added a descriptive line above each table to describe it.
11675 * command.c: (parse_cmd) Calls som_new_series.
11677 * som.c: New static vars table_num, subtable_num. New `som'
11679 (dump_page) New arguments.
11680 (som_submit_table) Handle new variables.
11682 * som.c, som.h: (som_submit_table) New arguments. All callers
11684 (som_new_series) New function.
11685 (build_target) Makes room for extra line.
11686 (draw_title) New function.
11687 (dump_page) Calls draw_title. Bug fix: doesn't always set
11690 Columnation of tables support.
11691 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
11693 * som.c: Deleted references to fr, lr, ri.
11694 (som_columnate) Bux fix: sets group member of table.
11695 (som_add_options) Function removed.
11696 (dump_table) Split into three functions; extensively reworked.
11698 * descript.q: (dump_z_table) Better output table formatting; added
11699 title support to correspond to som.h changes.
11700 (display) Title support.
11702 * output.h: Added OUTP_T_NONE.
11704 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
11706 * descript.q: Improved handling of Z scores; still not perfect.
11708 * output.h, ascii.c: Added hook for getting em width of current
11711 * som.c: Uses new em-width hook. Added debugging code to
11713 (som_columnate) New argument.
11714 (som_add_options) Removed.
11716 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
11718 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
11719 rules as a property of the table instead of as a property of the
11722 * ascii.c: Added `header' to table of options.
11724 * descript.q: Added even shorter statistic names; modified to work
11725 with new som interface.
11727 * misc.c (blp_getdelim): Bug fix.
11729 * version.c: includes 'conf.h'.
11731 ----------------------------------------------------------------------
11734 version-control: never
projects / pspp-builds.git / blob