1 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3 * vfm.c: (procedure) Add check to prevent recursive call.
5 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
7 * Moved the declarations relating to values to their own header file
10 * Added levene.c and levene.h
12 * vars-atr.c: Changed the signature of compare_values to
13 take const * arguments.
15 * t-test.q: Changed the structure of struct t_test_proc
16 variables now contain their own group statistics information.
17 Eventually, t_test_proc might get renamed, because it'd be
18 applicable to other commands too.
20 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
22 * data-out.c: Clean up. Changed interface of convert_*() to take
23 either a `double' or a `const char *' instead of a `const union
24 value *'. Update all implementations of those interfaces.
25 (data_out) Use switch statements instead of a table.
26 (convert_AHEX) Rewrite.
28 * format.h: Update comment.
30 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
32 * q2c.c: (dump_header) Add an Emacs header line to output files
33 that makes generated .c files read-only by default, to make it
34 difficult to accidentally change generated files.
36 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
38 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
39 not bogus a->v.c <=> b->v.c pointer compare.
40 (compare_freq_alpha_a) Ditto.
41 (compare_freq_numeric_d) Ditto.
42 (compare_freq_alpha_d) Ditto.
44 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
46 Changed data_out() to store string data directly into a `union
47 value''s s member, not indirectly into c.
49 * crosstabs.q: (output_pivot_table) Use format_short() instead of
51 (table_value_missing) Ditto.
52 (float_M_suffix) Ditto.
53 (format_short) New function.
55 * data-in.h: (data_in_finite_line) Remove inline definition.
57 * data-list.c: (destroy_dls_var_spec) New function.
58 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
59 (data_list_source_destroy_source) Avoid cast.
60 (struct repeating_data_trns) New field `id_value'. Update
62 (cmd_repeating_data) Initialize id_value. Use new
63 repeating_data_trns_free() for freeing REPEATING DATA
65 (rpd_parse_record) Rewrite support for record ID to be less bogus.
66 (repeating_data_trns_free) New function.
68 * data-out.c: (data_out) Change return type to `void' by replacing
69 error returns by writing a message into the output buffer.
70 (convert_A) Read from v->s instead of v->c.
73 * expr-evl.c: Update comment.
74 (expr_evaluate) Add assertion in OP_STRING case.
76 * format.h: (macro MAX_FORMATTED_LEN) New macro.
78 * list.q: (list_cases) Update for new data_out() semantics.
80 * print.c: (print_trns_proc) Ditto.
82 * tab.c: (tab_value) Ditto.
83 (tab_float) Avoid stupid cast.
85 * var.h: Update comments.
86 (macro MAX_STRING) New macro.
87 (macro MAX_ELEMS_PER_VALUE) New macro.
89 * vars-atr.c: (compare_values) New function.
91 * vfm.c: (dump_splits) Update for new data_out() semantics.
93 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
95 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
97 (struct crosstab) Rename v[] to vars[]. All references updated.
98 (hash_table_entry) Replace the hash algorithm and fix a bug at the
99 same time, which caused the hash value to depend only on a single
100 value, not all of the variables' values.
102 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
104 Clean up struct dictionary's value_cnt usage.
106 * dictionary.c: Add a function comment to each function.
107 (struct dictionary) Rename value_cnt to next_value_idx, which more
108 accurately reflects its meaning. All references updated.
109 (dict_rename_vars) Add assertion.
110 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
112 (dict_get_case_size) New function.
114 * aggregate.c: (create_sysfile) Use dict_get_case_size().
116 * get.c: (mtf_read_nonactive_records) Ditto.
118 * sort.c: (allocate_cases) Ditto.
119 (write_initial_runs) Ditto.
123 * vfm.c: (prepare_for_writing) Ditto.
127 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
129 Make vfm.c slightly less grotesque.
131 * vfm.c: (filter_var) Removed.
132 (filter_index) Removed.
133 (FILTERED macro) Removed.
134 (exclude_this_case) New function.
135 (process_active_file_write_case) Use exclude_this_case() instead
136 of FILTERED and inline tests.
137 (procedure_write_case) Ditto.
138 (setup_filter) Removed.
139 (open_active_file) Don't call setup_filter().
140 (close_active_file) Call dict_get_filter() instead of checking
143 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
145 * var.h: (struct variable) Update comments.
147 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
149 New functions dict_create_var_assert(), dict_lookup_var_assert().
150 Converted several dict_*_var()/assert pairs into a single
153 * dictionary.c: (dict_create_var_assert) New function.
154 (dict_lookup_var_assert) New function.
156 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
158 Got rid of "struct long_vec", envector(), devector(), etc. Added
159 two members `init', `reinit' to struct variable as a substitute.
161 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
167 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
170 * autorecode.c: (cmd_autorecode) destvars don't need init.
172 * compute.c: (lvalue_finalize) Set reinit.
174 * data-list.c: (fixed_parse_compatible) Don't need init usually.
175 (dump_fmt_list) Ditto.
178 * descript.q: (run_z_pass) Don't need init for z-scores.
180 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
182 (dict_clone_var) Copy `reinit' member, initialize `init' member.
184 * glob.c: (init_glob) Remove vec_init() calls.
186 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
188 * loop.c: (internal_cmd_loop) Don't need to call envector().
190 * numeric.c: (cmd_numeric) Ditto.
192 (cmd_leave) Ditto. Set `init', `reinit' members.
194 * recode.c: (cmd_recode) Don't need to call envector().
196 * repeat.c: (internal_cmd_do_repeat) Ditto.
198 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
199 (force_create_variable) Removed prototype.
200 (force_dup_variable) Ditto.
202 * vector.c: (cmd_vector) Don't need to call envector().
204 * vfm.c: (reinit_sysmis) Removed.
205 (reinit_blanks) Removed.
207 (init_blanks) Removed.
208 (process_active_file_write_case) No need to deal with vectors.
209 Call clear_temp_case().
210 (vector_initialization) Rewrite to use `init', `reinit'.
211 (close_active_file) No need to call vec_clear().
212 (procedure_write_case) Call clear_temp_case().
213 (clear_temp_case) New function.
215 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
217 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
220 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
222 Add auxiliary argument to procedure() interface. Associated small
223 clean-ups of vfm interface.
225 * Updated every caller of procedure() and process_active_file() to
226 reflect modified interface. Simple, ordinary changes not listed
229 * Updated every function that implements struct case_stream's
230 `read' function to take a write_case_func and a write_case_data.
231 Also updated every caller of write_case() to instead call them
232 through these arguments. In some cases this meant that the extra
233 args had to be threaded through a couple of extra levels. This
234 wasn't difficult or interesting so the details won't be given.
236 * data-list.c: (struct repeating_data_trns) Add members
237 `write_case', `wc_data' as kluge.
238 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
240 (repeating_data_set_write_case) New function.
242 * data-list.h: New file to declare repeating_data_trns_proc() and
243 repeating_data_set_write_case().
245 * inpt-pgm.c: (input_program_source_read) Call
246 repeating_data_set_write_case() for all the REPEATING DATA
247 transformations, so that they know where to send their cases.
248 It's a big kluge. Also kluge in END CASE.
249 (end_case_trns_proc) Never called anymore, but we still need it,
252 * sort.c: (read_sort_output) Update to match struct case_stream
255 * vfm.c: (struct write_case_data) New structure.
257 (virt_proc_func) Removed.
258 (begin_func) Removed.
259 (virt_begin_func) Removed.
261 (write_case) Removed.
262 (procedure) Added an auxiliary parameter to each function pointer
263 argument's prototype. Added an auxiliary data parameter.
265 (process_active_file) Ditto.
266 (process_active_file_write_case) Pass aux data along.
267 (close_active_file) Ditto.
268 (procedure_write_case) Ditto.
269 (SPLIT_FILE_procfunc) Ditto.
271 * vfm.h: (typedef write_case_data) New.
272 (typedef write_case_func) New.
273 (struct case_stream) Add parameters to `read' member prototype.
275 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
277 * t-test.q: Added calculations for independent samples. (But no Levene
280 * Makefile.am: Moved q_sources_c into own variable
282 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
284 Miscellaneous cleanups.
286 * Change unused to UNUSED in many source files to reflect modified
287 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
288 __CYGWIN32__, __unix__, and unix not to assume that they're
289 defined to a nonzero value. Change use of __attribute__ to use
290 NO_RETURN or PRINTF_FORMAT instead.
292 * alloc.h: Move definitions for local_alloc(), local_free() here
293 from ../pref.h.orig and simplify.
295 * expr-evl.c: Instead of working differently based on PAGED_STACK,
296 use a pool allocator unconditionally.
297 (CHECK_STRING_SPACE) Removed.
298 (ALLOC_STRING_SPACE) Removed.
299 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
302 * expr-opt.c: (dump_expression) Allocate string pool.
304 * expr-prs.c: (expr_free) Free string pool.
306 * pool.c: (pool_destroy) This pool must be removed from its
307 parent's list of gizmos, not from its own. Use free_all_gizmos().
308 (pool_clear) New function.
309 (free_all_gizmos) New function.
310 (pool_alloc) Use space in empty block after this one if any.
311 (pool_release) Only empty out blocks, don't actually free() them.
313 * print.c: Get rid of PAGED_STACK special case by always
314 dynamically allocating line buffers.
315 (struct print_trns) Always include the `line' member.
316 (internal_cmd_print) Always initialize the `line' member.
317 (alloc_line) Always allocate memory for `line'.
318 (print_trns_proc) Always initialize buf from `line' member.
319 (print_trns_free) Always free `line' memory.
321 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
324 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
326 * flip.c: Fixed crash from FLIP when a numeric variable is
327 specified on NEWNAMES and a large value is used, and a couple of
328 other minor bugs besides.
329 (struct varname) Make name a 9-character fixed-size array
330 instead of a 1-character variable size array.
331 (make_new_var) Allow digits in variable names.
332 (flip_stream_write) Limit numeric values to 8 characters and
333 format system missing and very large and small values more
336 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
338 * command.c: Fixed test on command return status for the correct
339 value, which had been causing a crash under certain invalid input.
341 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
343 * t-test.q: Added calculations for the one sample variant of the T-TEST
345 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
347 * tab.c: (render_strip) Fix bug that sometimes caused joined text
348 in joined cells to be rendered outside box boundaries.
350 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
352 * random.c (rng_create): Fixed seeding so that it gets reseeded after
353 SET seed=xx has been called.
355 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
357 * random.c (rng_get_double): Fix always-returning-zero bug in my
358 preferred way, and at the same time make sure rounding doesn't
361 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
363 * html.c: (change_attributes) Dead code, removed.
364 (escape_string) Eliminate code to call change_attributes() that
365 never actually called it.
366 (output_tab_table) Get rid of dependence on tab_hit
367 and struct tab_joined_cell's hit member, which are abominations.
369 * tab.c: (tab_output_text) Don't call
370 d->class->text_set_font_by_name if it's a null pointer.
371 (macro UNROLL_LOOP) Eliminate.
372 (macro UNROLL_3_LOOPS) Eliminate.
373 (tabi_render) Rewrite not to use the above macros.
375 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
377 Start working on a new output driver system, one that doesn't suck
378 so much, by adding a "device-independent" output driver. The idea
379 is to write out only a single output stream, then use separate
380 processes to translate them into whatever formats we want. This
381 is similar to how "groff" works with its various output drivers
382 (grops, grotty, grodvi, ...).
384 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
386 * list.q: (write_all_headers) Stub out devind class.
388 (determine_layout) Ditto.
391 * output.c: (outp_init) Add devind class.
393 * devind.c: New file.
395 * devind.h: New file.
397 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
399 * frequencies.q: (hash_value_alpha) Fixed up the previous change
400 to use the proper string length.
402 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
404 * Fixed bug where FREQ would crash on alpha values
406 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
408 * Removed bletcherous alloca() workarounds for AIX from top of
409 many files. AIX can use the alternative alloca() implementation
412 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
414 * ascii.c: (ascii_option) Fix implementation of headers option.
416 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
418 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
419 multiple blank lines into one.
420 (struct ascii_driver_ext) Add squeeze_blank_lines option.
421 (ascii_preopen_driver) Initialize squeeze_blank_lines.
422 (static var option_tab) Add squeeze entry.
423 (ascii_option) Set squeeze_blank_lines.
424 (output_lines) Implement squeezing blank lines.
426 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
428 * Removed redundant code from output.h
430 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
432 Dictionary classes: each variable is "ordinary", "system", or
435 * var.h: (enum dict_class) New enum.
437 * vars-prs.c: (dict_class_from_id) New function.
438 (dict_class_to_name) New function.
440 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
442 * var.h: (struct freq_tab_set) Removed (not used).
444 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
446 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
448 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
450 * stats.c: (hypercube) Rename pow4(). All references updated.
452 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
454 * rename-vars.c: (cmd_rename_variables) Rewritten.
455 (compare_name) Removed.
457 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
459 var_set feature, and code taking advantage of it.
461 * crosstabs.q: (static var var_dict) Removed.
462 (static var variables) New variable.
463 (static var variables_cnt) New variable.
464 (cmd_crosstabs) Free variables instead of var_dict.
465 (internal_cmd_crosstabs) Initialize and use variables,
466 variables_cnt instead of var_dict.
467 (free_var_dict) Removed.
468 (crs_custom_tables) Use var_set instead of a copied dictionary.
469 (crs_custom_variables) Set up variables, variables_cnt instead of
471 [DEBUGGING] (debug_print) Ditto.
473 * means.q: (mns_custom_tables) Use var_set instead of a copied
476 * vars-prs.c: (parse_vs_variable) New function.
477 (parse_dict_variable) Rewritten.
478 (parse_variable) Rewritten.
479 (parse_variables) Renamed parse_var_set_vars(), rewritten.
480 (parse_variables) New function in terms of parse_var_set_vars().
481 Now requires its first argument to be non-null. All references
482 that passed a null pointer updated to pass default_dict instead.
483 (macro id_dict) Removed.
484 (parse_DATA_LIST_vars) Add assertions.
485 (parse_mixed_vars) Ditto.
486 (struct var_set) New structure.
487 (var_set_get_cnt) New function.
488 (var_set_get_var) New function.
489 (var_set_lookup_var) New function.
490 (var_set_destroy) New function.
491 (dict_var_set_get_cnt) New function.
492 (dict_var_set_get_var) New function.
493 (dict_var_set_lookup_var) New function.
494 (dict_var_set_destroy) New function.
495 (var_set_create_from_dict) New function.
496 (struct array_var_set) New structure.
497 (array_var_set_get_cnt) New function.
498 (array_var_set_get_var) New function.
499 (array_var_set_lookup_var) New function.
500 (array_var_set_destroy) New function.
501 (var_set_create_from_array) New function.
503 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
504 instead of parse_variables(NULL, ...) in output code.
506 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
508 Change inp_init from a 2-bit vector to an ordinary array.
509 Initialize it all in cmd_end_input_program() instead of in
512 * inpt-pgm.c: (enum value_init_type) New enum.
513 (global var inp_init) Change to `enum value_init_type *', make
515 (inp_init_size) Removed.
516 (inp_nval) Change to `size_t', make static.
517 (cmd_input_program) Don't initialize inp_init or inp_init_size.
518 (cmd_end_input_program) Initialize inp_init, inp_nval.
520 (clear_case) Rewrite.
522 * inpt-pgm.h: Removed.
524 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
526 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
527 Colin Plumb hash. It is simpler and should better resist
529 (hsh_hash_string) Ditto.
531 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
533 * get.c: (export_write_case_func) Remove debug printing code.
535 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
537 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
539 (save_write_case_func) Use &trns->h instead of cast.
540 (cmd_export) Use &t->h instead of cast.
542 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
544 Moved vectors into the dictionary.
546 * var.h: (struct vector) Moved here from vector.h. `index' member
547 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
552 * vector.c: (global var vec) Removed.
553 (global var nvec) Removed.
554 (cmd_vector) Rewritten.
555 (find_vector) Removed.
557 * dictionary.c: (dict_create_vector) New function.
558 (dict_get_vector) New function, replaces reading global vec[]
560 (dict_get_vector_cnt) New function, replaces reading global nvec
562 (dict_lookup_vector) New function, replaces find_vector().
563 (dict_clear_vectors) New function.
565 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
567 Start to move away from `struct variable' p `union' member to void
570 * var.h: (struct variable) Add `aux' member.
572 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
574 Get rid of struct variable `foo' member.
576 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
578 (frq_custom_variables) Ditto.
579 (frq_custom_grouped) Ditto.
581 * get.c: (struct save_trns) Change `var' member from `int *' to
582 `struct variable **'.
583 (cmd_save_internal) Use aux instead of foo.
584 (save_trns_proc) Use revised `var' member.
585 (static var mtf_seq_no) Renamed mtf_seq_num.
586 (static var mtf_seq_nums) New static var.
587 (cmd_match_files) Initialize mtf_seq_nums.
588 (mtf_free) Free mtf_seq_nums.
589 (mtf_processing) Use mtf_seq_nums instead of foo.
590 (mtf_merge_dictionary) No need to initialize mv->foo.
591 (cmd_export) Use aux instead of foo. Use revised `var' member.
592 (mns_custom_tables) Don't use foo to check for duplicates, that's
593 what PV_NO_DUPLICATE is for.
595 * var.h: (struct variable) Remove `foo' member.
596 (struct frequencies_proc) New member.
598 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
600 Clean up COMPUTE and IF.
602 * compute.c: More or less rewrite the darn thing.
603 (struct compute_trns) Rename and reorder and add and delete
605 (cmd_compute) Rewrite.
606 (compute_num) Make conditional on test expression. Now used for
608 (compute_num_vec) Ditto.
610 (compute_str_vec) Ditto.
613 (if_num_vec) Removed.
615 (if_str_vec) Removed.
616 (parse_target_expression) Renamed parse_rvalue_expression(),
618 (new_trns) Renamed compute_trns_create(), rewritten.
619 (delete_trns) Removed.
620 (free_trns) Renamed compute_trns_free(), rewritten.
621 (struct lvalue) New structure.
622 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
623 (lvalue_get_type) New function.
624 (lvalue_is_vector) New function.
625 (lvalue_finalize) New function.
626 (lvalue_destroy) New function.
628 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
630 * command.def: Disallow MODIFY VARS in input mode, so that
631 variables can't get dropped and confuse cmd_end_input_program()'s
632 attempt to fill inp_init[].
634 * modify-vars.c: (static var forward_positional_ordering) New
636 (struct var_modification) Entirely changed.
637 (rearrange_dict) Interface changed, rewritten.
638 (cmd_modify_vars) Deal with modified struct var_modification, much
640 (struct var_renaming) New structure.
641 (compare_var_renaming_by_new_name) New function.
642 (validate_var_modification) New function.
644 * var.h: (struct modify_vars_proc) Removed.
645 (struct variable) Removed member p.mfv.
647 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
649 Make EVALUATE a valid command whether we're debugging or not, so
650 that `make check' can succeed regardless of whether debugging is
653 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
655 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
657 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
659 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
660 statement by a simple if test.
662 * dfm.c: (dfm_get_record) Add assertion.
664 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
666 For each file x.c, move #include "x.h" to the very top of the
667 include list, to catch x.h failing to include the proper headers.
669 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
671 * algorithm.c: (find) New function.
672 (remove_equal) New function.
673 (set_difference) New function.
674 (adjacent_find_equal) New function.
675 [TEST_UNIQUE] Removed test case.
676 (copy_if) Find end test.
678 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
680 * dictionary.c: (dict_get_case_weight) New convenience function.
682 * aggregate.c: (accumulate_aggregate_info) Use
683 dict_get_case_weight().
685 * frequencies.q: (calc_general) Ditto.
686 (calc_integer) Ditto.
689 * t-test.q: (groups_calc) Ditto.
692 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
694 * glob.c: (global var default_dict) Change from `struct
695 dictionary' to `struct dictionary *'. All references changed.
696 (init_glob) Initialize default_dict with dict_create().
698 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
700 struct dictionary now made opaque. All related functions:
702 * get.c: (rename_variables) Removed.
703 (dict_delete_run) Removed.
705 * temporary.c: (copy_variable) Removed.
706 (new_dictionary) Removed.
707 (save_dictionary) Removed.
708 (restore_dictionary) Removed.
709 (free_dictionary) Removed.
711 * vars-atr.c: (clear_default_dict) Removed.
712 (find_variable) Removed.
713 (find_dict_variable) Removed.
714 (create_variable) Removed.
715 (delete_variable) Removed.
716 (common_init_stuff) Removed.
717 (init_variable) Removed. Updating of inp_init moved into
718 cmd_end_input_program().
719 (replace_variable) Removed.
720 (rename_variable) Removed.
721 (clear_variable) Removed.
722 (dup_variable) Removed.
724 * vars-prs.c: (is_varname) Removed.
725 (is_dict_varname) Removed.
726 (fill_all_vars) Removed.
728 * vector.c: (find_vector) Removed.
730 * weight.c: (stop_weighting) Removed.
732 * dictionary.c: New file.
733 (dict_create) New, replaces new_dictionary().
734 (dict_clone) New, replaces save_dictionary() and
735 restore_dictionary().
736 (dict_clear) New, replaces clear_default_dict().
737 (dict_destroy) New, replaces free_dictionary().
738 (dict_get_var_cnt) New function, replaces references to
740 (dict_get_var) New function, replaces references to dict->var[i].
741 (dict_get_vars) New function, replaces fill_all_vars().
742 (dict_create_var) New, replaces create_variable(). Interface
743 drops `type' parameter, using a zero `width' to designate numeric.
744 (dict_clone_var) New, replaces dup_variable().
745 (dict_rename_var) New, replaces rename_variable().
746 (dict_lookup_var) New, replaces find_variable(),
747 find_dict_variable(), is_varname().
748 (dict_contains_var) New function.
749 (compare_variable_dblptrs) New function.
750 (dict_delete_var) New function, replaces clear_variable().
751 (dict_delete_vars) New function, replaces dict_delete_run().
752 (dict_reorder_vars) New function.
753 (dict_rename_vars) New function, replaces rename_variables().
754 (dict_get_weight) New function, replaces reading dict->weight_var.
755 (dict_set_weight) New function, replaces writing dict->weight_var
756 or calling stop_weight(dict).
757 (dict_get_filter) New function, replaces reading dict->filter_var.
758 (dict_set_filter) New function, replaces writing dict->filter_var.
759 (dict_get_case_limit) New function, replaces reading dict->N.
760 (dict_set_case_limit) New function, replaces writing dict->N.
761 (dict_get_value_cnt) New function, replaces reading dict->nval.
762 (dict_compact_values) New function, replaces a loop that was
763 replicated in several places.
764 (dict_get_split_vars) New function, replaces reading dict->splits.
765 (dict_get_split_cnt) New function, replaces reading
767 (dict_set_split_vars) New function, replaces writing dict->splits.
768 (dict_get_label) New function, replaces reading dict->label.
769 (dict_set_label) New function, replaces writing dict->label.
770 (dict_get_documents) New function, replaces reading
772 (dict_set_documents) New function, replaces writing
775 All references to above functions updated.
777 * aggregate.c: (cmd_aggregate) Copy file label and documents from
778 old dictionary to new by hand, because dict_create() can't do it
779 itself. Use dict_set_documents(), dict_set_split_vars().
781 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
782 calling dict_destroy().
784 * data-list.c: (dls_var_spec) Remove `type' member, replace by
786 (fixed_parse_compatible) Some slightly nontrivial changes for
788 (dump_fmt_list) Ditto.
791 * file-type.c: (create_col_var) Ditto.
793 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
794 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
795 (rename_variables) Use dict_rename_vars().
796 (mtf_merge_dictionary) Use dict_get_documents(),
797 dict_set_documents(), dict_compact_values().
799 * pfm-read.c: (read_variables) Deal with changes to weighting.
801 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
802 is_varname() in output code.
804 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
805 other dictionary functions.
807 * title.c: (add_document_line) Use dict_get_documents(),
808 dict_set_documents().
810 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
811 reset default_handle by hand. dict_clear() will clear vectors so
812 there's no need for that by hand.
814 * vfm.c: (close_active_file) Move call to finish_compaction()
815 earlier, so that we can do the compaction as a single step using
816 dict_compact_values(). Use dict_clear_vectors().
817 (finish_compaction) Use dict_delete_var(), dict_compact_values().
819 Some functions don't have replacements:
821 * vars-atr.c: (force_create_variable) Removed. All references
822 updated to dict_create_var() followed by an assertion.
823 (force_dup_variable) Removed. All references updated to
824 dict_clone_var() followed by an assertion.
826 * weight.c: (update_weighting) Removed. No longer necessary, so
827 all references removed.
829 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
833 * aggregate.c: Eliminate separation of weighted and unweighted
834 case. It made the code too obscure and I doubt it was actually
835 faster. Instead, all code uses the "weighted" code, because
836 that's a generalization of the "unweighted" code.
839 (parse_aggregate_functions) No need to set FWEIGHT.
840 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
841 (dump_aggregate_info) Ditto.
842 (initialize_aggregate_info) No need for special plain_function
843 that gets rid of FWEIGHT option.
845 * aggregate.c: Get rid of approximations.
846 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
848 (aggregate_single_case) Don't use approx_ne().
850 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
852 * ascii.c (ascii_line_width): Dead code, removed.
854 * postscript.c (ps_line_width): Ditto.
856 * q2c.c (xrealloc): Ditto.
858 * count.c (internal_cmd_count): Ditto.
860 * means.q (validate_dependent_endpoint): Ditto.
862 * set.q: (cmd_gset) Ditto.
864 * weight.c: [0] (weight_trns_proc) Ditto.
866 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
868 Make the code -Wmissing-prototypes clean.
870 * Makefile.am (version.c): Add #include "version.h".
872 * ascii.c: (ascii_open_global) Make static.
873 (ascii_close_page) Ditto.
874 (ascii_font_sizes) Ditto.
875 (ascii_postopen_driver) Ditto.
876 (ascii_close_driver) Ditto.
877 (ascii_option) Ditto.
878 (ascii_open_page) Ditto.
879 (ascii_line_horz) Ditto.
880 (ascii_line_vert) Ditto.
881 (ascii_line_intersection) Ditto.
883 (ascii_polyline_begin) Ditto.
884 (ascii_polyline_point) Ditto.
885 (ascii_polyline_end) Ditto.
886 (ascii_text_set_font_by_name) Ditto.
887 (ascii_text_set_font_by_position) Ditto.
888 (ascii_text_set_font_by_family) Ditto.
889 (ascii_text_get_font_name) Ditto.
890 (ascii_text_get_font_family) Ditto.
891 (ascii_text_set_size) Ditto.
892 (ascii_text_get_size) Ditto.
893 (ascii_text_metrics) Ditto.
894 (ascii_text_draw) Ditto.
895 (ascii_close_page) Ditto.
897 * cmdline.h: New header for parse_command_line(). Used where
900 * command.c: Move prototypes for cmd_*() functions to command.h.
902 * command.h: Prototypes for cmd_*() functions moved here from
905 * crosstabs.q: (gamma_int) Ditto.
907 * file-handle.h: Add fh_init_files() prototype.
909 * getline.c: (welcome) Ditto.
911 * glob.h: New header for init_glob(). Used where appropriate.
913 * hash.c: (comparison_helper) Ditto.
915 * html.c: (html_open_global) Ditto.
916 (html_close_global) Ditto.
917 (html_preopen_driver) Ditto.
918 (html_postopen_driver) Ditto.
919 (html_close_driver) Ditto.
921 (html_open_page) Ditto.
922 (html_close_page) Ditto.
925 * inpt-pgm.c: (input_program_source_read) Ditto.
927 * output.c: (find_defn_value) Ditto.
928 (destroy_list) Ditto.
930 * pfm-read.c: (read_int) Ditto.
932 * postscript.c: (ps_open_global) Ditto.
933 (ps_close_global) Ditto.
934 (ps_font_sizes) Ditto.
935 (ps_preopen_driver) Ditto.
936 (ps_postopen_driver) Ditto.
937 (ps_close_driver) Ditto.
939 (ps_open_page) Ditto.
940 (ps_close_page) Ditto.
941 (ps_line_horz) Ditto.
942 (ps_line_vert) Ditto.
943 (ps_line_intersection) Ditto.
945 (ps_polyline_begin) Ditto.
946 (ps_polyline_point) Ditto.
947 (ps_polyline_end) Ditto.
948 (ps_text_set_font_by_name) Ditto.
949 (ps_text_set_font_by_position) Ditto.
950 (ps_text_set_font_family) Ditto.
951 (ps_text_get_font_name) Ditto.
952 (ps_text_get_font_family) Ditto.
953 (ps_text_set_size) Ditto.
954 (ps_text_get_size) Ditto.
955 (ps_text_metrics) Ditto.
956 (ps_text_draw) Ditto.
958 * q2c.c: (finish_up) Ditto.
970 (force_string) Ditto.
975 (parse_setting) Ditto.
976 (parse_specifier) Ditto.
977 (parse_specifiers) Ditto.
978 (parse_subcommand) Ditto.
979 (dump_specifier_vars) Ditto.
981 (make_identifier) Ditto.
982 (dump_declarations) Ditto.
983 (dump_specifier_init) Ditto.
984 (dump_vars_init) Ditto.
986 (dump_specifier_parse) Ditto.
987 (dump_subcommand) Ditto.
991 (recognize_directive) Ditto.
993 * recode.c: (string_to_long) Ditto.
995 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
997 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
1000 * sort.c: (sort_stream_read) Ditto.
1001 (sort_stream_mode) Ditto.
1003 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
1005 * algorithm.c (binary_search): Fix comparison.
1007 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
1009 * algorithm.c: (binary_search) Fix assertion.
1011 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
1013 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
1015 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
1017 * sort.c: (compare_case_lists) Rewrite.
1019 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
1021 * quicksort.c: Removed (not used).
1023 * quicksort.h: Removed (not used).
1025 * sort.c: Removed blp_quicksort() prototype.
1027 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
1029 * postscript.c: (int_2_compare) Rewrite.
1030 (compare_line) Rewrite.
1032 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
1034 * matrix-data.c (compare_factors) Use lexicographical_compare()
1036 (compare_doubles) New function.
1038 * algorithm.c: (lexicographical_compare) New algorithm.
1040 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
1042 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
1044 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
1046 * expr-prs.c: (cmp_func) Removed.
1047 (parse_function) Use binary_search() algorithm.
1048 (compare_functions) New function.
1049 (init_func_tab) Use sort() algorithm.
1051 * algorithm.c: (binary_search) New algorithm.
1053 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
1055 * descript.q: (display) Use sort() algorithm instead of qsort().
1056 (compare_func) Removed.
1057 (descriptives_compare_variables) New function.
1059 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
1061 Get rid of AVL trees. Hashes are more appropriate for everything
1064 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
1070 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
1072 Much code can be clarified by using C++ STL-like algorithms. Not
1073 all uses of these algorithms are listed below, only the ones where
1074 the change to an algorithm was the only change of interest.
1076 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
1078 * algorithm.c: New file.
1080 * algorithm.h: New file.
1082 * modify-vars.c: (static var forward) Removed.
1083 (static var positional) Removed.
1084 (compare_variables) Removed.
1085 (struct ordering) New.
1086 (cmd_modify_vars) Use sort() algorithm.
1087 (compare_variables_given_ordering) New function.
1088 (rearrange_dict) Use sort() algorithm.
1090 * sysfile-info.c: (cmd_display) Use sort() algorithm.
1091 (cmp_var_by_name) Removed.
1093 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
1095 Make file handles use a hash table.
1097 * file-handle.q: (files) Change to hash table, make static.
1098 (cmd_file_handle) Use hash table functions.
1099 (fh_get_handle_by_filename) Ditto.
1100 (fh_get_handle_by_name) Ditto.
1101 (hash_file_handle) New function.
1102 (cmp_file_handle) Rewrite.
1103 (fh_init_files) Use hash table functions.
1105 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
1107 Clean up FREQUENCIES.
1109 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
1111 * frequencies.q: Remove a lot of old #if'd out code at the end.
1112 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
1113 or calc_weight(). Initialize percentile_values.
1114 (calc) New function based on calc_weight() from frequencies.g.
1115 (precalc) Use hash functions.
1116 (static var comparison_func) Removed.
1117 (static var comparison_param) Removed.
1118 (comparison_helper) Removed.
1119 (get_freq_comparator) New function.
1120 (not_missing) New function.
1122 (postprocess_freq_tab) Use hash table functions, algorithms,
1123 get_freq_comparator(). Rewrite.
1124 (cleanup_freq_tab) Rephrase.
1125 (add_percentile) Clean up spacing.
1126 (hash_value_numeric) New function.
1127 (hash_value_alpha) New function.
1128 (compare_value_numeric_a) Rewrite.
1129 (compare_value_alpha_a) Rewrite.
1130 (compare_value_numeric_d) Rewrite.
1131 (compare_value_alpha_d) Rewrite.
1132 (compare_freq_numeric_a) Rewrite.
1133 (compare_freq_alpha_a) Rewrite.
1134 (compare_freq_numeric_d) Rewrite.
1135 (compare_freq_alpha_d) Rewrite.
1136 (calc_stats) Clean up mode, percentiles, max.
1137 (dump_statistics) Clean up spacing.
1139 * frequencies.g: Removed.
1141 * var.h: (struct freq_tab) Change `data' to hash table.
1143 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
1145 * file-handle.h: Remove declaration of global variable `files',
1146 which wasn't used anywhere.
1148 * postscript.c: (add_encoding) Remove superfluous cast.
1151 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
1154 * temporary.c: [0] (display_tree) Removed.
1156 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
1158 Implement a new random number generator based on the alleged RC4
1161 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
1164 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
1165 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
1167 (static var V[]) Removed.
1168 (static var Y) Removed.
1169 (static var X2) Removed.
1170 (setup_randomize) Removed.
1172 (rand_uniform) Removed.
1173 (rand_normal) Removed.
1174 (struct rng) New structure.
1175 (rng_create) New function.
1176 (rng_destroy) New function.
1177 (swap_byte) New static function.
1178 (rng_seed) New function.
1179 (rng_get_bytes) New function.
1180 (rng_get_int) New function.
1181 (rng_get_unsigned) New function.
1182 (rng_get_double) New function.
1183 (rng_get_double_normal) New function.
1184 (pspp_rng) New function.
1186 * random.h: Sync up to random.c.
1188 * sample.c: (struct sample_trns) Make `frac' unsigned and a
1189 fraction of UINT_MAX, not 65536.
1190 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
1193 * vfm.c: (open_active_file) No need to call setup_randomize() any
1196 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
1198 Change dictionary name indexes to use hash tables instead of AVL
1201 * crosstabs.q: (free_var_dict) Use hash tables.
1202 (crs_custom_tables) Ditto.
1203 (calc_general) Ditto.
1204 (compare_table_entry) Rewrite.
1205 (enum_var_values) Reorder parameters. All references updated.
1208 * get.c: (rename_variable) Use hash tables.
1209 (mtf_merge_dictionary) Ditto.
1211 * glob.c: (init_glob) Use hash tables.
1212 (cmp_variable) Removed.
1214 * means.q: (mns_custom_tables) Use hash tables.
1216 * modify-vars.c: (rearrange_dict) Use hash tables.
1218 * rename-vars.c: (cmd_rename_variables) Use hash tables.
1220 * sfm-read.c: (read_header) Use hash tables.
1221 (read_variables) Ditto.
1223 * temporary.c: (new_dictionary) Use hash tables.
1224 (save_dictionary) Ditto.
1225 (restore_dictionary) Ditto.
1227 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
1228 hash table `name_tab'.
1230 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
1231 [DEBUGGING] (dump_var_tree) Removed.
1232 (find_variable) Use hash tables.
1233 (find_dict_variable) Ditto.
1234 (common_init_stuff) Ditto.
1235 (rename_variable) Ditto.
1236 (clear_variable) Ditto. Also, remove debug code.
1237 (dup_variable) Use hash tables.
1239 * vars-prs.c: (fill_all_vars) Use hash tables.
1240 (is_dict_varname) Ditto.
1241 (parse_dict_variable) Ditto.
1243 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
1245 Change value labels to use hash tables instead of AVL trees, and
1246 change value labels into an ADT.
1248 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
1250 * value-labels.c: New file.
1252 * value-labels.h: New file.
1254 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
1255 Get rid of a stupid use of goto.
1257 * autorecode.c: (compare_alpha_value) Rewrite.
1258 (hash_alpha_value) Ditto.
1259 (compare_numeric_value) Rewrite.
1260 (hash_numeric_value) Ditto.
1262 * frequencies.q: (dump_full) Use value label ADT.
1264 * pfm-read.c: (read_value_label) Use value label ADT.
1266 * pfm-write.c: (write_value_labels) Use value label ADT.
1268 * sfm-read.c: (read_variables) Use value label ADT.
1269 (read_value_labels) Rewrite.
1271 * sfm-write.c: (write_value_labels) Rewrite.
1273 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
1274 (display_variables) Ditto.
1275 (describe_variable) Ditto.
1277 * t-test.q: (print_t_groups) Use value label ADT.
1279 * temporary.c: (copy_variable) Use value label ADT.
1280 (free_dictionary) Ditto.
1282 * val-labs.c: (verify_val_labs) Use value label ADT.
1284 (debug_print) Ditto.
1285 (val_lab_cmp) Removed.
1286 (inc_ref_count) Removed.
1287 (copy_value_labels) Removed.
1289 * var.h: (struct value_label) Removed.
1290 (struct variable) Change AVL tree `val_lab' into hash table
1293 * vars-atr.c: (init_variable) Use value label ADT.
1294 (clear_variable) Ditto.
1295 (free_value_label) Removed.
1296 (free_val_lab) Removed.
1297 (get_val_lab) Removed.
1298 (compare_variables) New function.
1299 (hash_variable) New function.
1301 * vfm.c: (dump_splits) Use value label ADT.
1303 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
1305 Add to the hash table interface.
1307 * hash.c: (hsh_hash_bytes) Add assertion.
1308 (hsh_hash_string) Ditto.
1312 (hsh_create) Ditto. Also make minimum `size'.
1313 (hsh_destroy) Rephrase.
1314 (sort_nulls_last) Removed.
1315 (not_null) New function.
1317 (comparison_helper) Ditto.
1318 (hsh_sort) Rewritten.
1319 (hsh_data_copy) New function.
1320 (hsh_sort_copy) Ditto.
1322 (hsh_replace) Ditto.
1323 (hsh_hash_double) Ditto.
1324 (hsh_delete) Fix stupid bug.
1326 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1327 * added a calculation of the mode to FREQUENCIES
1329 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1331 * moved (un)defs of DEBUGGING to config.h
1333 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
1335 * groff-font.c: (add_kern) Fix indentation.
1336 (add_kern) Use & instead of % to take power-of-2 modulus.
1337 (font_get_kern_adjust) Likewise.
1339 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
1341 * autorecode.c: (recode) Replace stupid use of memcpy() by
1343 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
1344 (hash_numeric_value) Ditto.
1345 (autorecode_proc_func) pool_strdup() was wrong here because the
1346 source string was not null-terminated. Use new pool_strndup()
1349 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
1350 use of hsh_iterator_init().
1352 * data-in.c: (parse_N) Initialize i->v->f.
1354 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
1357 * groff-font.c: Use power-of-2 hash table sizes, not prime.
1358 (groff_read_font) Don't call hsh_next_prime(). Don't call
1360 (static var hash) Remove `size_p', `max_used' members.
1361 (font_char_name_to_index) Don't call hsh_next_prime(). Use
1362 hsh_hash_string() instead of hashpjw(), & instead of %.
1363 (default_font) Don't call hsh_next_prime().
1365 * pool.c: (pool_strndup) New function.
1366 (pool_strdup) Reimplement in terms of pool_strndup.
1368 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
1370 (hash_ps_encoding) Use hsh_hash_string().
1371 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
1372 (hash_filename2font) Use hsh_hash_string().
1374 * som.c: Add #include <stdlib.h>.
1376 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
1377 (by destroying its pool).
1379 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
1381 Miscellaneous hash table code cleanup:
1383 * hash.h: (struct hsh_table) Moved into hash.c.
1384 (hsh_count) Ditto, and transformed into function.
1385 (hsh_compare_func) New typedef, used for defining otherwise-long
1386 function types here and in hash.c
1387 (hsh_hash_func) Ditto.
1388 (hsh_free_func) Ditto.
1390 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
1391 `table' to `entries'. Removed `mp'. All references updated.
1392 (hsh_clear) Don't shrink entries array; if the hash was this big
1393 once, it probably will be again.
1394 (hsh_rehash) Made static.
1395 (force_hsh_insert) Renamed hsh_force_insert.
1396 (force_hsh_find) Renamed hsh_force_find.
1398 Made hash table sizes powers of 2, because that's fine with any
1399 reasonable hash function and because taking a power-of-2 modulus
1400 is faster than any other:
1402 (hsh_prime_tab) Removed;
1403 (hsh_next_prime) Ditto.
1404 (next_power_of_2) New function.
1405 (hsh_create) Use next_power_of_2.
1406 (hsh_rehash) Use & instead of %.
1408 Cleaned up hsh_sort:
1410 (internal_comparison_fn) Removed.
1411 (sort_nulls_last) New function.
1412 (hsh_sort) Removed second parameter, switched to using the new
1413 quicksort() function from quicksort.h to avoid using nasty need
1414 for static variables with qsort(). All references updated.
1416 Changed the hash functions offered, because there are better hash
1417 functions than the ones we had, and cleaned up the names to boot:
1419 * hash.c: (hashpjw_d) Removed.
1421 (hsh_hash_bytes) New function.
1422 (hsh_hash_string) New function.
1423 (hsh_hash_int) New function.
1425 Improved the hash table iteration interface:
1427 * hash.h: (hsh_iterator_init) Removed.
1428 (struct hsh_iterator) Removed `init' member, change `next' to
1431 * hash.c: (hsh_foreach) Removed. All references updated to use
1432 hsh_first/hsh_next instead.
1433 (hsh_first) New function. Notably, unlike hsh_foreach() it does
1434 not treat a null pointer as an empty hash table.
1435 (hsh_next) New function.
1437 Made deletion possible, though slow:
1439 * hash.c: (locate_matching_entry) New function.
1440 (hsh_find) Use locate_matching_entry().
1441 (hsh_delete) New function also using locate_matching_entry().
1442 (hsh_force_delete) New function.
1444 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
1446 * quicksort.c: New file implementing a sort routine with a
1447 interface better than qsort() because it passes a user-provided
1448 parameter to the sort routine.
1450 * Makefile.am: Add quicksort.c, quicksort.h.
1452 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
1454 * All source files: Get rid of nasty special cases for Checker,
1455 which is pretty obsolete now.
1457 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
1459 * Fixed a bug apparent when using the FREQUENCIES command with the
1460 html driver. The html driver was incorrectly trying to display
1463 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
1465 * Makefile.am: Reorganized. Put locale dir in version.c instead
1466 of passing it to each compile command. Only put local gmp libs in
1467 LD_ADD if not installed on system. Remove `boast' target.
1469 * All source files: struct and union typedefs eliminated.
1470 `sizeof type' replaced by `sizeof object' where practical. Moved
1471 `unused' qualifiers from start to end of declarations for gcc
1472 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
1473 assertions on pointers strictly compliant. Removed _ prefixes on
1474 some function parameter names.
1476 * alloc.c: New source file, containing these external linkage
1477 functions removed from common.c: xmalloc, xcalloc, xrealloc,
1484 * ascii.c: Migrated from arenas to pools.
1485 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
1486 c_string to len_string. All references changed.
1487 (ascii_option) Signature changed to comply to new output.c
1489 (count_fancy_chars) Removed.
1490 (delineate) Removed support for rich text.
1491 (ascii_text_metrics) Ditto.
1493 (output_shorts) Change `box', `off', `on' from c_string to
1494 len_string. Change `remaining' from int to size_t.
1495 (ascii_close_page) Make page numbering less haphazard.
1497 * autorecode.c: Migrate from arenas to pools.
1499 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
1501 * bitvector.h: New file containing these macros from misc.h:
1502 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
1504 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
1505 word[3]. ncmd removed.
1506 (var empty_string) Removed.
1507 (var cmd_table) Declaration updated.
1508 (var cmdtab) Removed.
1509 (cmp_command) Removed.
1510 (split_words) Rewritten to use strtok_r().
1511 (init_cmd_parser) Renamed cmd_init(). Rewritten.
1512 (find_command) Removed.
1513 (FILE_TYPE_okay) Rewritten.
1514 (cmd_parse) Rewritten. Semantics of the return value of command
1515 handlers has changed: they must now return one of the new CMD_*
1516 enumerals, rather than a magic value. This meant that all
1517 commands had to be modified, and they were.
1518 (figure_out_command) New function.
1520 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
1521 #defines for INIT, INPU, etc.
1523 * command.h: New CMD_* enum series.
1524 (cur_proc) Make const char *, not char *.
1525 (cmd_init) Prototype.
1528 * common.c: Removed.
1530 * common.h: Removed.
1532 * correlations.q: New file.
1534 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
1536 (custom_tables) Renamed crs_custom_tables().
1537 (custom_variables) Renamed crs_custom_variables().
1538 (calc_integer) Add in some `const' qualifiers.
1539 (table_value_missing) Change from a_string to len_string.
1540 (float_M_suffix) Change from a_string to len_string.
1542 * data-in.c: Rewritten. All references to
1543 parse_string_as_format() changed to data_in().
1545 * data-in.h: New file.
1547 * data-list.c: Change DLS_* from #define's to enums. Move from
1548 rpd_msg() to tmsg().
1549 (RPD_ERR) New #define.
1550 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
1552 (read_from_data_list_fixed) Change from old
1553 parse_string_as_format() to new data_in().
1554 (read_from_data_list_free) Ditto.
1555 (read_from_data_list_list) Ditto.
1556 (cmd_repeating_data) Modify approach to checking for end of
1559 (rpd_parse_record) Change from old parse_string_as_format() to new
1560 data_in(). Change from old convert_format_to_string() to new
1562 (read_one_set_of_repetitions) Change dfm_push_cust() to
1563 dfm_push(), pop_cust() to dfm_pop().
1565 * data-out.c: Rewritten. All references to
1566 convert_format_to_string() changed to data_out().
1568 * descript.q: Migrate to new q2c.
1569 (cmd_descriptives) Removed.
1570 (internal_cmd_descriptives) Renamed cmd_descriptives ().
1571 (custom_variables) Renamed dsc_custom_variables().
1573 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
1575 (open_file_r) Initialize h->where.line_number. Migrate to new
1577 (open_file_w) Initialize h->where.line_number.
1578 (read_record) Change from ext->ln to h->where.line_number.
1579 Migrate to struct string.
1580 (dfm_put_record) Rephrased.
1581 (dfm_push_cust) Renamed dfm_push(), rewritten.
1582 (dfm_pop) New function.
1584 * error.c: All references updated.
1585 (glob var error_count) Renamed err_err_count.
1586 (glob var warning_count) Renamed err_warning_count.
1587 (glob var error_already_flagged) Renamed err_already_flagged.
1588 (glob var verbosity) Renamed err_verbosity.
1589 (glob var cust_fn) Removed.
1590 (glob var cust_ln) Removed.
1591 (static var file_loc) New.
1592 (static var nfile_loc) New.
1593 (static var mfile_loc) New.
1594 (tmsg) New function.
1595 (push_cust) Removed.
1598 (static var terminating) Removed.
1599 (failure) Renamed err_failure().
1600 (hcf) Renamed err_hcf().
1601 (err_push_file_locator) New function.
1602 (err_pop_file_locator) New function.
1603 (err_location) New function.
1604 (check_error_count) Renamed err_check_count().
1605 (vmsg) Renamed err_vmsg(). Interface changed.
1606 (verbose_msg) Removed.
1607 (err_cond_fail) New function.
1608 (error_break) Renamed err_break().
1610 * error.h: All references updated.
1611 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
1612 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
1614 (struct file_locator) New.
1616 (macro verbose_msg) Removed.
1617 (macro cond_fail) Removed.
1619 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
1621 * expr-prs.c: Reorganized. All references updated.
1622 (exprtypename) Renamed expr_type_name().
1623 (typename) Renamed type_name().
1624 (free_expression) Renamed expr_free().
1625 (parse_expression) Renamed expr_parse(). Uses new type_check()
1627 (init_functab) Renamed init_func_tab().
1628 (type_check) New function.
1629 (parse_or) Rewritten to use new allocate_nonterminal() and
1630 append_nonterminal_arg() functions.
1633 (parse_rel) Ditto. Also simplified logic.
1638 (SYSMIS_func) Ditto.
1639 (VALUE_func) Rephrased.
1640 (CONCAT_func) Fix memory leak by replacing free by free_node on
1642 (generic_str_func) Ditto.
1643 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
1645 (allocate_nonterminal) New function.
1646 (append_nonterminal_arg) New function.
1647 (static func_tab[]) Now at file level.
1649 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
1651 * expr.h: (enum series OP_*) Moved to exprP.h.
1652 (OP_* defines) Ditto.
1653 (struct op_desc) Ditto.
1654 (global ops[]) Ditto.
1655 (struct num_con_node) Ditto.
1656 (struct str_con_node) Ditto.
1657 (struct var_node) Ditto.
1658 (struct lag_node) Ditto.
1659 (struct casenum_node) Ditto.
1660 (struct nonterm_node) Ditto.
1661 (union any_node) Members renamed.
1662 (struct sys_node) Removed.
1663 (struct val_node) Removed.
1664 (operator typedef) Removed.
1665 (typedef exprtype) Removed.
1666 (enum series EX_*) Moved to exprP.h.
1667 (struct expression) Ditto. Also renamed a lot of the members.
1668 (PXP_* defines) Changed to enums.
1669 (free_node prototype) Moved to exprP.h.
1671 * file-handle.h: (struct file_handle) New member `where'.
1673 * file-handle.q: Migrated to new q2c format.
1674 (prepend_current_directory) Removed (dead code).
1675 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
1676 (fh_get_handle_by_filename) Removed dead code.
1677 Set new `where' member.
1679 * file-type.c: (file_type_source_read) References to
1680 parse_string_as_format() changed to data_in().
1681 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
1683 * filename.c: All references updated.
1684 (init_filename) Renamed fn_init().
1685 (expand_line) Removed.
1686 (macro EXPAND_LINE) Removed.
1687 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
1688 of custom functions.
1689 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
1690 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
1691 (normalize_filename) Renamed fn_normalize().
1692 (search_path) Renamed fn_search_path(), rewritten.
1693 (prepend_dir) Renamed fn_prepend_dir().
1694 (blp_getenv) Renamed fn_getenv().
1695 (blp_dirname) Renamed fn_dirname().
1696 (fn_basename) New function, not used.
1697 (absolute_filename_p) Renamed fn_absolute_p().
1698 (is_special_filename) Renamed fn_special_p().
1699 (file_exists) Renamed fn_exists_p().
1700 (readlink_malloc) Renamed fn_readlink().
1701 (getenv_default) Renamed fn_getenv_default().
1702 (open_file) Renamed fn_open().
1703 (close_file) Renamed fn_close().
1704 (open_file_ext) Renamed fn_open_ext().
1705 (close_file_ext) Renamed fn_close_ext().
1707 * font.h: Migrate from arenas to pools.
1709 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
1711 * frequencies.g: Migrate from arenas to pools.
1713 * frequencies.q: Migrate to new q2c version. Migrate from arenas
1716 * getline.c: All references updated.
1717 (global getl_buf) Changed from char * to struct string.
1718 (static getl_include_path) Ditto.
1719 (global getl_buf_len) Removed.
1720 (global getl_buf_size) Removed.
1721 (getl_include_path) Deal with new getl_buf, getl_include_path.
1722 (getl_uninitialize) New function.
1723 (getl_get_current_directory) Rewritten.
1724 (getl_clear_include_path) Rewritten.
1725 (getl_add_include_dir) Rewritten.
1726 (getl_add_file) Assertion fixed.
1727 (getl_add_virtual_file) Change initial value of `remaining_loops'
1729 (welcome) Rewritten.
1730 (handle_line_buffer) Make static. Change logic to make
1731 getl_add_virtual_file() change sensible. Use ds_*() strings.
1732 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
1733 (getl_close_file) Moved.
1734 (getl_location) New function.
1736 * getline.h: All references updated.
1737 (macro curln) Removed.
1738 (macro curfn) Removed.
1739 (macro am_interactive) Renamed getl_am_interactive.
1740 (macro am_reading_script) Renamed getl_reading_script.
1742 * glob.c: (global fmt_parse_ignore_error) Removed.
1743 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
1744 systems that support it (C99). Turn off SET ECHO by default. No
1745 necessary julcal initialization anymore.
1747 * groff-font.c: Migrate from arenas to pools.
1748 (groff_read_font) Use err_push_file_locator().
1749 (groff_read_DESC) Ditto.
1750 (font_msg) Use tmsg().
1752 * hash.c: (hsh_sort) Fix debug code.
1753 [GLOBAL_DEBUGGING] Include stdio.h.
1755 * hash.h: (macro force_hsh_insert) Rephrase.
1757 * heap.c: Rewritten.
1759 * heap.h: Rewritten.
1761 * html.c: (html_option) Change from outp_value to struct string.
1762 (postopen) Change from curfn to getl_location().
1763 (escape_string) Remove rich-text code. Signature changed.
1764 (output_tab_table) Switch from a_string to struct len_string.
1765 Remove rich text support.
1767 * lexer.c: All references updated. Largely rewritten. Major
1768 changes listed below. Removed tagged quote support. Adapted to
1769 struct string tokstr.
1770 (global tokstr) Changed to struct string.
1771 (global tokstr_size) Removed.
1772 (global tokstr_len) Removed.
1774 (global tokint) Removed.
1775 (global toklongstr) Removed.
1776 (C* defines) Removed.
1777 (static tbl[]) Removed.
1778 (static id[]) Removed.
1779 (static une[]) Removed.
1780 (discard_line) Renamed lex_discard_line().
1781 (get_entire_line) Renamed lex_entire_line().
1782 (get_rest_of_line) Renamed lex_rest_of_line().
1783 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
1784 (make_hexit) Removed.
1785 (syntax_error) Renamed lex_error(). Return value removed.
1786 (get_token_representation) Renamed lex_token_representation().
1787 (putback) Renamed lex_put_back().
1788 (putfwd) Renamed lex_put_forward().
1789 (convert_negative_to_dash) Renamed lex_negative_to_dash().
1790 (set_prog) Renamed lex_set_prog().
1791 (init_lex) Renamed lex_init().
1792 (reset_eof) Renamed lex_reset_eof().
1793 (lookahead) Renamed lex_look_ahead().
1794 (check_id) Rewritten.
1795 (yylex) Renamed lex_get(), rewritten.
1796 (lex_end_of_command) New function. Many commands were rephrased
1798 (lex_integer_p) New function. Replaces compare of tokint against
1800 (lex_integer) New function. Replaces tokint.
1801 (match_tok) Renamed lex_match().
1802 (match_id) Renamed lex_match_id().
1803 (match_int) Renamed lex_match_int().
1804 (force_match_id) Renamed lex_force_match_id(), added return value.
1805 (force_match) Renamed lex_force_match(), added return value.
1806 (force_string) Renamed lex_force_string(), added return value.
1807 (force_int) Renamed lex_force_int(), added return value.
1808 (lex_id_match_len) New function.
1809 (id_match) Renamed lex_id_match(), rewritten.
1810 (get_line) Renamed lex_get_line().
1811 (preprocess_line) Renamed lex_preprocess_line().
1812 (tokname) Renamed lex_token_name().
1813 (bin_value_func) Removed.
1814 (oct_value_func) Removed.
1815 (hex_value_func) Removed.
1816 (unexpected_eof) New function.
1817 (convert_numeric_string_to_char_string) New function.
1818 (parse_string) Rewritten, signature changed.
1819 (add_tokstr_char) Removed.
1820 (add_tokstr_unsigned) Removed.
1821 (add_tokstr_string) Removed.
1822 (parse_tagged_quote) Removed.
1823 (skip_comment) Renamed lex_skip_comment().
1825 * lexer.h: All references updated.
1826 (macro is_id1) Renamed CHAR_IS_ID1.
1827 (macro is_idn) Renamed CHAR_IS_IDN.
1828 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
1829 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
1830 (macro get_token) Removed.
1831 (macro id_match) Removed.
1832 (macro force_match_id) Removed.
1833 (macro force_match) Removed.
1834 (macro force_string) Removed.
1835 (macro force_int) Removed.
1836 (macro force_num) Removed.
1837 (macro force_id) Removed.
1839 * lexerP.h: Removed.
1841 * list.q: Migrated to new q2c format.
1842 (write_line) Deal with struct len_string.
1843 (write_varname) Ditto.
1844 (write_fallback_headers) Ditto.
1846 * magic.c: New file, incorporating the following global variables
1847 previously in other files: endian, second_lowest_value. And both
1848 of those are conditional on #define's.
1850 * magic.h: New file, incorporating the following global variable
1851 declarations: endian, second_lowest_value, and the following macro
1852 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
1854 * main.c: Added declarations of pgmname, finished, curdate,
1856 (main) Call new parse_script() function.
1857 (parse_script) New function.
1858 (execute_command) New function.
1859 (dump_token) Removed.
1860 (handle_error) New function.
1862 * matrix.c: New file.
1864 * matrix.h: New file.
1866 * matrix-data.c: Migrated from arenas to pools.
1867 (mget_token) Change from parse_string_as_format() to data_in().
1869 * means.q: Migrate to new q2c.
1870 (custom_tables) Renamed mns_custom_tables().
1871 (custom_crossbreak) Renamed mns_custom_crossbreak().
1872 (custom_variables) Renamed mns_custom_variables().
1874 * mis-val.c: (static var width) Changed from `int' to `size_t'.
1875 (parse_varnames) Prototype.
1876 (parse_numeric) Rephrasings.
1877 (parse_alpha) Adapt to new struct string tokstr.
1879 * misc.c: (intlog10) Rewritten.
1881 (ansi_rand) Renamed real_rand(), moved into random.c.
1882 (ansi_srand) Renamed real_srand(), moved into random.c.
1883 (setup_randomize) Moved to random.c.
1884 (rand_uniform) Ditto.
1885 (rand_normal) Ditto.
1886 (rand_simple) Ditto.
1887 (get_config_line) Removed.
1888 (reverse) Removed (dead code).
1890 * misc.h: (macro SET_BIT) Moved to bitvector.h.
1891 (macro CLEAR_BIT) Ditto.
1892 (macro TEST_BIT) Ditto.
1893 (macro SET_BIT_TO) Ditto.
1894 (macro BIT_INDEX) Ditto.
1896 * output.c: (outp_read_devices) Move to err_push_file_locator()
1897 from push_cust(). Use struct string.
1898 (expand_op_tokstr) Removed.
1899 (static var op_tokstr) Changed to struct string.
1900 (static var op_tokstr_size) Removed.
1901 (tokener) Rephrasings. Use struct string.
1902 (parse_options) Use struct string.
1903 (destroy_driver) Fix assertion.
1904 (outp_get_paper_size) Move to err_push_file_locator().
1905 [0] Removed dead code.
1906 (outp_string_width) Move to len_string.
1908 * output.h: Comment fixes.
1909 (TAG_* enum series) Removed.
1910 (struct outp_value) Removed.
1911 (enum OUTP_T_FANCY) Removed.
1912 (struct outp_text) `s' changed from a_string to len_string.
1913 (struct outp_class) `option' change arg 3 from outp_value to
1916 * pfm-read.c: (corrupt_msg) Rewritten.
1918 * pfm-write.c: (bufwrite) Fix assertion.
1920 * pool.c: New file, reference version.
1922 * pool.h: New file, reference version.
1924 * postscript.c: (ps_font_sizes) Fix assertion.
1925 (ps_option) Change arg 3 from outp_value to struct string.
1926 Adapt to struct string.
1927 (macro output_line) Removed.
1928 (macro add_string) Removed.
1929 (output_encodings) Adapted to struct string. Moved to
1930 err_push_file_locator().
1931 (find_encoding_file) Fix assertion.
1932 (read_ps_encodings) Move to err_push_file_locator().
1933 (postopen) Use getl_location() instead of curfn.
1934 (out_text_plain) Move to len_string.
1935 (text) Ditto. Remove rich text support.
1937 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
1938 (cmd_print_eject) Ditto.
1940 (internal_cmd_print) Now cleans up after itself. Uses
1941 fh_parse_file_handle() now.
1942 (cmd_print_space) Use PXP_NUMERIC to type-check.
1944 * q2c.c: Overhauled. Removed _("") i18n support. All references
1945 updated. All output functions updated to handle structures rather
1946 than local or static variables. Adapt to new PSPP lex_*()
1950 (macro MAX_N_SBC) Removed.
1951 (global bare) Removed.
1952 (enum STRING) Renamed T_STRING.
1953 (enum ID) Renamed T_ID.
1954 (get_buffer) Buffer size increased.
1955 (strlower) Renamed st_lower(), rephrased.
1956 (strupper) Renamed st_upper(), rephrased.
1957 (skip_ws) New function.
1958 (get_line) Don't special-case any types of lines (like those
1959 beginning with ! or $, for instance).
1960 (get_token) Renamed lex_get(). Rephrased.
1961 (static var `prefix') New.
1962 (parse) New function.
1963 (parse_setting) Minor rephrasing.
1964 (dump_specifier_vars) Ditto.
1965 (make_identifier) Put null terminator on identifier, duh.
1966 (dump_vars) Renamed dump_declarations(). Never indent. Never
1967 static. Output changed entirely.
1968 (dump_specifier_init) Rephrase.
1969 (dump_vars_init) No index variable needed. Other modifications.
1970 (dump_parser) Don't parse command name. Do dump functions instead
1971 of just code fragments.
1972 (dump_free) Dump function instead of code fragment.
1973 (recognize_directive) New function.
1974 (main) Use recognize_directive(). Don't rely on magic $ line
1975 beginning: instead, parse comments. Update list of headers.
1977 * random.c: New file, containing the following functions:
1978 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
1979 rand_normal, rand_simple.
1981 * random.h: New file.
1983 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
1984 function. `max_src_width', `max_dst_width' changed to size_t.
1985 (internal_cmd_recode) Removed.
1986 (parse_dest_spec) Merge similar cases.
1987 (parse_src_spec) Add assertion.
1989 * repeat.c: (recognize_keyword) New function.
1990 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
1991 REPEAT. Improve recognition of END REPEAT (use
1992 recognize_keyword()). Move from curfn to getl_location(). Use
1995 (perform_DO_REPEAT_substitutions) Adapt to struct string.
1997 * set.q: Adapt to new q2c.
1998 (cmd_set) Range-check some values better.
1999 (custom_blanks) Renamed stc_custom_blanks().
2000 (custom_length) Renamed stc_custom_length().
2001 (custom_results) Renamed stc_custom_results().
2002 (custom_seed) Renamed stc_custom_seed().
2003 (custom_width) Renamed stc_custom_width().
2004 (custom_format) Renamed stc_custom_format().
2005 (custom_journal) Renamed stc_custom_journal().
2006 (custom_color) Renamed stc_custom_color().
2007 (custom_listing) Renamed stc_custom_listing().
2008 (custom_disk) Renamed stc_custom_disk().
2009 (custom_log) Renamed stc_custom_log().
2010 (custom_rcolor) Renamed stc_custom_rcolor().
2011 (custom_viewlength) Renamed stc_custom_viewlength().
2012 (custom_workdev) Renamed stc_custom_workdev().
2014 * settings.h: Not necessary to include format.h any longer.
2016 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
2017 (corrupt_msg) Rewritten.
2019 * sort.c: Adapt to rewritten heap ADT.
2021 * str.c: (aa_strcpy) Removed.
2022 (ab_strcpy) Removed.
2023 (ac_strcpy) Removed.
2024 (ba_strcpy) Removed.
2025 (bb_strcpy) Removed.
2026 (ca_strcpy) Removed.
2027 (aa_strdup) Removed.
2028 (aa_strdupcpy) Removed.
2029 (ba_strdup) Removed.
2030 (sa_strdup) Removed.
2031 (memrev) Renamed mm_reverse().
2032 (memrmem) Renamed mm_find_reverse().
2033 (cmp_str) Renamed st_compare_pad().
2034 (strmaxcpy) Removed.
2035 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
2036 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
2038 (strpadcpy) Renamed st_pad_copy(), signature changed.
2039 (blpstrset) Removed.
2040 (ds_create) New function.
2041 (ds_init) New function.
2042 (ds_replace) New function.
2043 (ds_destroy) New function.
2044 (ds_clear) New function.
2045 (ds_extend) New function.
2046 (ds_shrink) New function.
2047 (ds_truncate) New function.
2048 (ds_length) New function.
2049 (ds_size) New function.
2050 (ds_value) New function.
2051 (ds_end) New function.
2052 (ds_concat) New function.
2053 (ds_concat_buffer) New function.
2054 (ds_printf) New function.
2055 (ds_putchar) New function.
2056 (ds_getline) New function.
2057 (ds_get_config_line) New function derived from the old
2058 misc.c:get_config_line().
2059 (ls_create) New function.
2060 (ls_create_buffer) New function.
2061 (ls_init) New function.
2062 (ls_shallow_copy) New function.
2063 (ls_destroy) New function.
2064 (ls_null) New function.
2065 (ls_null_p) New function.
2066 (ls_empty_p) New function.
2067 (ls_length) New function.
2068 (ls_value) New function.
2069 (ls_end) New function.
2071 * str.h: Reformatted.
2072 (struct a_string) Removed.
2073 (struct b_string) Removed.
2074 (struct c_string) Removed.
2075 (struct len_string) New.
2076 (struct string) New.
2077 (macro as_streq) Removed.
2078 (macro bs_streq) Removed.
2079 (macro cs_streq) Removed.
2080 (macro sa_streq) Removed.
2081 (macro sb_streq) Removed.
2082 [__GNUC__] (inline function ds_putchar) New function.
2083 [__GNUC__] (inline function ds_length) New function.
2084 [__GNUC__] (inline function ds_value) New function.
2085 [__GNUC__] (inline function ds_end) New function.
2087 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
2088 (display_vectors) Fix missing i18n.
2090 * t-test.q: Migrate to new q2c.
2092 * tab.c: Migrate from arenas to pools.
2093 (tab_create) Use struct len_string.
2094 (tab_realloc) Ditto.
2095 (text_format) Ditto.
2096 (tab_joint_text) Ditto.
2097 (tab_natural_width) Remove rich text support.
2098 (tab_natural_height) Ditto.
2099 (tab_output_text) Handle TAT_FIX.
2100 (tab_raw) Change arg from a_string to len_string.
2101 (tabi_driver) Fix assertion. Use struct len_string.
2102 (render_strip) Use struct len_string. Remove rich text support.
2103 Add `const' qualifiers.
2105 * tab.h: (enum TAB_RICH) Remove.
2106 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
2107 SOM_COL_* updated to read TAB_COL_*.
2108 (struct tab_table) Change arena to pool. Change a_string to
2111 * temporary.c: (restore_dictionary) Rewrite Checker code.
2113 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
2114 LOWEST, HIGHEST) Moved here from common.h.
2115 (typedef any_trns) Removed. All references changed to `struct
2118 * vars-atr.c: (force_create_variable) Fix assertion.
2119 (force_dup_variable) Fix assertion.
2121 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
2123 Using alphanumeric variables in functions under AGGREGATE
2124 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
2125 <BZN-mdksh@t-online.de> for reporting this bug.
2127 * aggregate.c: (parse_aggregate_functions) When setting the
2128 FSTRING bit, also allocate memory for the `string' member of
2130 (free_aggregate_functions) Free iter->string. Don't use the
2131 non-function bits when indexing the array of functions.
2132 [DEBUGGING] (debug_print) Don't use the non-function bits when
2133 indexing the array of functions.
2135 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
2137 Under certain circumstances, the final case would be omitted from
2138 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
2139 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2141 * aggregate.c (agr_00x_end_func): Increment number of cases in
2142 sink before writing case. For streams that keep track of how many
2143 cases there are based on this value, this means that the last case
2144 will be read in on the next stream read.
2146 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
2148 Undefined behavior was invoked by referencing a freed pointer.
2150 * vfm.c (memory_stream_write): Free pointer *after* checking for
2153 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
2155 A wrong record size was displayed when paging the active file to
2158 * vfm.c: (memory_stream_write) Fix off-by-one error.
2160 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
2162 Not having enough temporary space for sorting caused a core dump.
2165 * sort.c: (allocate_cases) Initialize i.
2167 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
2169 Syntax errors in function descriptions on AGGREGATE caused core
2172 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
2173 free_aggregate_functions(), since that function already frees
2176 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
2178 A null pointer was dereferenced, causing a core dump, when
2179 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
2180 but PSPP still doesn't calculate percentiles. Thanks to Regnor
2181 Jernsletten <rjernsle@eunet.no> for reporting this problem.
2183 * arena.c: (arena_malloc) If the arena hasn't been initialized
2184 already, initialize it.
2186 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
2188 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
2189 for compilation with Cygnus Windows B20. Not used by other
2192 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
2194 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
2195 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2197 * sort.c: (compare_case_lists) Reverse sense of comparison if
2198 sorting in descending order.
2199 (compare_record) Ditto.
2201 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
2203 SPLIT FILE with a string variable caused a core dump. Fixed.
2205 * vfm.c: If the variable is a string then make a temporary value
2206 struct pointing to it. The underlying problem is a lot bigger
2207 than this (see TODO) but this is a stopgap for the simple case at
2210 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
2212 Nested INCLUDEs didn't work. Fixed.
2214 * getline.c: (getl_include) Set first_line to NULL in allocated
2217 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
2219 The MATCH FILES procedure set the values of variables not present
2220 to 0. It should have been SYSMIS. This is now fixed.
2222 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
2224 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
2226 The REMARK command was too aggressive about skipping lines. It
2227 didn't like being the last command in a file.
2229 * command.c: (cmd_remark) Call get_entire_line() instead of
2232 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
2234 Comment parsing wasn't consistent with the rest of the code in its
2235 idea of where one command ends and another starts. This meant
2236 that sometimes commands would be mysteriously ignored. Thanks to
2237 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2239 * command.c: (parse_cmd) Hand off comment parsing to new function
2240 skip_comment() in lexer.c.
2241 * lexer.c: (skip_comment) New function.
2243 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
2245 The TABLE subcommand on MATCH FILES worked only erratically at
2246 best. This fixes it. Thanks to Dr. Dirk Melcher
2247 <BZN-mdksh@t-online.de> for reporting this bug.
2249 * get.c: (mtf_compare_BY_values) When comparing string values, a
2250 difference of 1 is still a difference :-)
2251 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
2252 advance TABLE files automatically when matched. Comment fixes.
2254 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
2256 VARIABLE LABELS rejected a slash before the first variable
2257 specification, contradicting the documentation. Thanks to Walter
2258 M. Gray <graywm@northernc.on.ca> for reporting this bug.
2260 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
2261 command specification.
2263 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
2265 Because of an incorrect optimization in memory allocation,
2266 CROSSTABS sometimes segfaulted when asked to output multiple
2267 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2270 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
2271 are passed to output_pivot_table() for its use.
2272 (output_pivot_table) Instead of assuming the number of columns is
2273 constant, keep track with maxcols. In general mode, use maxcells
2274 to determine whether more matrix cells need to be allocated.
2276 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
2278 CROSSTABS didn't display value labels for column and row
2279 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2282 * crosstabs.q: (table_value_missing) If the specified value has a
2283 value label for this variable, then show it instead of the raw
2285 (display_dimensions) Delegate display of value_labels to
2286 table_value_missing.
2288 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
2290 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
2291 <BZN-mdksh@t-online.de> for reporting this bug.
2293 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
2294 if the file isn't declared as binary.
2296 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
2298 MATCH FILES corrupted memory and dumped core on some syntax
2301 * get.c: (cmd_match_files) Set file->handle to NULL before
2303 (mtf_free_file) Don't free a null dictionary.
2305 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
2307 MATCH FILES should set numeric values not available to the
2308 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
2309 <BZN-mdksh@t-online.de> for reporting this bug.
2311 * get.c: (mtf_processing) Set unused records to system-missing,
2314 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
2316 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
2317 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
2319 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
2320 in newly created dictionary, and add each copied variable to the
2323 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
2327 * get.c: (trim_dictionary) Free variable list for KEEP after
2330 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
2332 Some systems didn't like the way open_file was coded. Thanks to
2333 Hankin <hankin@rogue.consultco.com> for pointing this out.
2335 * filename.c: (open_file) Don't try to store stdin, stdout,
2336 stderr as part of an array, because that doesn't always work.
2338 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
2340 The SAVE procedure didn't save long string variables properly.
2341 Fixed by this patch. Thanks to Hankin
2342 <hankin@rogue.consultco.com> for this patch.
2344 * sfm-write.c: (write_variable) Fix off-by-one error in writing
2345 out variable pad records.
2347 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
2349 Previously, if PRINT SPACE were given a negative argument, it
2350 would report an error, then spin in an (almost) infinite loop.
2351 This fixes that behavior.
2353 * print.c: (print_space_trns_proc) After reporting a negative
2354 argument, set number of lines to print to 1.
2356 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
2358 SPSS 8.0 outputs some new record types in its system files, and it
2359 allows longer value labels. Accept these system files.
2361 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
2362 11 emitted by SPSS 8.0.
2364 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
2366 The LIST procedure was too conservative in allocating space for
2367 buffers, which caused a bug that only showed up with very long
2368 output variables. Thanks to Hankin <hankin@dunno.com> for this
2371 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
2373 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
2375 Typo meant string format specifiers weren't checked properly. I
2376 think that Hankin <hankin@dunno.com> sent me this report, but I'm
2377 willing to be corrected on this point.
2379 * format.c: (check_string_specifier) Fix obvious typo.
2381 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
2383 Using $CASENUM in an expression didn't work. Here's a fix.
2384 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
2387 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
2389 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
2391 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
2393 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
2394 other behavior, *sigh*. This patch hopefully fixes that. This
2395 time I've actually tested it.
2397 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
2399 * data-list.c: (read_from_data_list_free,
2400 read_from_data_list_list) Call parse_string_as_format() directly
2401 without mucking around with the field width.
2403 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
2405 Occasionally, you may encounter a script that wants to be
2406 interpreted in interactive mode. Make -i emulate this behavior to
2407 allow such scripts to be executed with PSPP.
2409 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
2411 * cmdline.c: (pre_syntax_message[]) Update -i description.
2413 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
2414 when -i is given on the command line) don't treat unindented lines
2415 as starting a new command.
2417 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
2419 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
2420 mostly caused by local initialized aggregates. After egcs is
2421 fixed upstream these can be removed, but for now they're not a big
2424 * ascii.c: (ascii_postopen_driver) Checker chokes on local
2425 initialized arrays. Avoid this.
2427 * sfm-write.c: (sfm_write_dictionary) Don't use a local
2430 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
2432 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
2433 following changes avoid. Currently I compile sources with egcs
2434 1.1.1 and gcc 2.7.2.3 before sending them out.
2436 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
2438 * ascii.c: (option_tab[]) Initialize all struct members.
2440 * avl.h: (avl_traverser_init) New macro.
2442 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
2445 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
2448 * hash.c: Comment fix.
2450 * hash.h: (hsh_iterator_init) New macro.
2452 * html.c: (option_tab[]) Initialize all struct members.
2454 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
2457 * postscript.c: (option_tab[]) Initialize all struct members.
2458 (output_encodings, preclose, dump_lines) Use new
2459 hsh_iterator_init() macro.
2461 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
2464 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
2467 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
2469 * data-in.c: Examined each of the parsing functions to make sure
2470 that they wouldn't dump core if they were passed a string of the
2471 wrong length, since now the DATA LIST FREE/LIST routines don't
2472 check for field width before passing it to the data parser.
2473 (parse_RBHEX, parse_AHEX) Reject odd length input.
2474 (parse_string_as_format) Reject input that's too short or too
2477 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
2478 a field to its entire declared output width then pass it to the
2479 data-in parsing routines. This contradicted the documented
2480 behavior. This is fixed in these changes. Thanks to Mark H. Wood
2481 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
2482 free-format parsing that differed from SPSS.
2483 (cut_field) Commas and spaces are treated identically. Returns
2484 the proper column instead of a fixed 1 value.
2485 (parse_field) Removed.
2486 (read_from_data_list_free, read_from_data_list_list) Call
2487 parse_string_as_format directly instead of parse_field.
2489 * heap.c: (heap_delete) Stylistic fixes.
2491 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
2493 * loop.c: (loop_2_trns_proc) Formatting fix.
2495 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
2497 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
2499 * vfm.c: (macro FILTERED) New.
2500 (static var filter_var) New.
2501 (process_active_file_write_case) Use FILTERED.
2502 (setup_filter) Set filter_var.
2503 (close_active_file) Delete the filter if not
2504 FILTER_before_TEMPORARY.
2505 (procedure_write_case) Use FILTERED.
2507 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
2509 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
2511 * data-in.c: (parse_day_count) Message fix.
2512 (parse_month) Style fix.
2514 * data-list.c: (struct data_list_pgm) New member eof.
2515 (cmd_data_list) Init eof to 0.
2516 (do_reading) Implement the /END subcommand and read-past-eof
2519 * do-if.c: Include stdio.h when debugging.
2520 (cmd_else_if) Make sure the command is .-terminated.
2522 * glob.c: (init_glob) Capitalize the command prompt.
2524 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
2525 (end_file_trns_proc) Debugging message.
2527 * loop.c: (internal_cmd_loop) Make it work when there's no loop
2529 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
2531 * main.c: (dump_token) Make kwtab[] const.
2533 * set.q: Spelling, comment fixes.
2535 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
2538 * vars-prs.c: (fill_all_vars) Style fix.
2540 * vfm.c: (index_to_varname) Return const.
2542 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
2544 * Changes in many source files for partial -ansi -pedantic and
2545 no-debugging compliance: Remove trailing common in enum
2546 declarations; add `unused' attributes; insert some appropriate
2549 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
2551 * command.c: (shell) Make static.
2552 (run_command) Make static.
2554 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
2556 * dfm.c: (cmd_begin_data) I18n fix.
2558 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
2560 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
2562 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
2565 * file-handle.q: Don't prepend the source file directory name to
2566 the data file name. (Ongoing issue.)
2567 (prepend_current_directory) Comment out.
2568 (internal_cmd_file_handle) Don't call prepend_current_directory().
2569 (fh_get_handle_by_filename) Ditto.
2571 * filename.c: Append zero byte to readlink() return value.
2573 * getline.c: (getl_read_line) I18n fix.
2575 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
2577 * misc.h: Don't use gcc features if __STRICT_ANSI__.
2579 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
2582 * postscript.c: (output_encodings) Don't use local_strdup().
2585 * print.c: Don't use gcc features if __STRICT_ANSI__.
2587 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
2589 * recode.c: (parse_src_spec) Fully brace nested if's.
2591 * set.q: (global var set_testing_mode) New var.
2593 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
2595 * ascii.c: Add some more `unused' attributes that only come into
2596 play when NDEBUG is defined.
2597 (ascii_close_page) Set s_len when reallocating s.
2599 * crosstabs.q: (delete_missing) New function.
2600 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
2601 (make_summary_table) Create summary table reallocable.
2603 * postscript.c: Add more `unused' attributes as above.
2605 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
2606 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
2608 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
2611 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
2612 gratuitous space between parameter definition.
2614 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
2615 complaints about running off the end of functions with NDEBUG
2618 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
2620 * Several source files: Removed some PORTME notes when reflection
2621 revealed that ANSI forbids that sort of breakage. Also, added
2622 lots of `unused' qualifiers here and there.
2624 * aggregate.c: (accumulate_aggregate_info) Remove local var
2625 weighting that turned out not to be used.
2627 * avl.c: Update to version 1.1.0. Add unused specifier.
2628 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
2630 (avl_probe) Replace some instances of 1 with +1 where appropriate.
2631 (avl_find) Cast return value to void *.
2632 (avl_delete) q doesn't need to be initialized at the beginning of
2633 the function. Replace some instances of 1 with +1.
2634 (force_avl_delete) Renamed avl_force_delete, all references changed.
2635 (compare_ints) `param' marked unused.
2636 (print_int) `param' marked unused.
2637 (recurse_tree) Replace some instances of 1 with +1.
2639 * avl.h: Update to version 1.1.0. Only declares avl function
2640 types if not already declared.
2641 (AVL_MAX_HEIGHT) Only define if not already defined.
2642 (struct avl_node) New unused member char pad[2].
2643 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
2644 (force_avl_insert) Renamed avl_force_insert.
2645 (force_avl_delete) Renamed avl_force_delete.
2647 * crosstabs.q: (struct table_entry) Put `freq' into a union with
2649 (struct crosstab) Add new member `ofs'.
2650 (glob var int_tab) Removed.
2651 (custom_tables) In integer mode, assign v[i] properly through the
2653 (custom_variables) Now p.crs.max == max + 1.
2654 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
2655 (precalc) Implement integer mode.
2656 (calc_integer) Implement integer mode.
2657 (compare_table_entry) Remove unused local variable `comparing'.
2658 (make_summary_table) Implement integer mode.
2659 (macro ns_rows) Implemented as static variable now.
2660 (several variables) Made static, from global.
2661 (output_pivot_table) Use table_value_missing() for column heads.
2662 Remove several unused local variables. Implement integer mode
2663 table summing. Count up ns_rows.
2664 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
2665 (find_pivot_extent) Moved into find_pivot_extent_general; now just
2666 calls that function or find_pivot_extent_integer.
2667 (find_pivot_extent_integer) New function.
2668 (enum_var_values) Implemented for integer mode.
2669 (table_value_missing) New function.
2670 (display_dimensions) Call table_value_missing() for heads.
2671 (float_M_suffix) New function.
2672 (display_crosstabulation) Call table_value_missing() for row
2673 heads. Handle missing values in /MISSING=REPORT mode.
2674 (calc_fisher) Remove unused var N.
2675 (calc_r) Remove unused var fact.
2677 * data-list.c: (dump_fixed_table) Fix table dimensioning.
2678 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
2680 * data-out.c: (insert_commas) Remove unused var cp.
2681 (convert_CCx) Remove unused vars save_set_decimal,
2684 * descript.q: (dump_z_table) Fix table dimensioning.
2685 (pre_calc) Remove unused var j.
2686 (display) Remove unused vars title, s. Fix table dimensioning.
2688 * expr-evl.c: Comment fixes.
2690 * frequencies.q: (full_dim) New function.
2691 (dump_full) Fix table dimensioning.
2692 (condensed_dim) New function.
2693 (dump_condensed) Fix table dimensioning.
2695 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
2698 * html.c: (html_close_drive) Remove unused var i.
2699 (postopen) Remove unused vars title, curfn_len, cp.
2700 (preclose) Remove unused vars this, x.
2702 * lexer.c: Comment fixes.
2704 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
2706 * means.q: (custom_tables) Remove unused var m_dim.
2708 * mis-val.c: Format fix.
2710 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
2712 * output.c: (outp_get_paper_size) Remove unused var cp.
2714 * pfm-read.c: (read_float) Remove unused var save, unused label
2716 (read_variables) Remove unused vars cp, j.
2717 (read_value_label) Remove unused var j.
2719 * pfm-write.c: (bufwrite) Remove unused var i.
2721 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
2723 (output_encodings) Remove unused vars char_cp, n_output.
2724 (read_ps_encodings) Remove unused var ep.
2725 (postopen) Remove unused var title.
2726 (preclose) Remove unused var fp.
2727 (ps_open_page) Remove unused vars true, false, orientation,
2728 mirror_horz, mirror_vert, width, length.
2729 (ps_text_metrics) Remove unused var x.
2731 * q2c.c: (find_symbol) Remove unused var y.
2732 (parse_setting) Remove unused parameter sbc, all references
2734 (dump_parser) Remove unused var cp.
2735 (dump_free) Remove unused var i.
2737 * set.q: (static vars args, n) Removed.
2738 (internal_cmd_gset) Removed.
2740 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
2741 (read_machine_flt64_info) Removed unused var file_endian.
2742 (read_documents) Removed unused var i.
2743 (read_compressed_data) Removed unused parameter dict, all
2746 * sfm-write.c: (bufwrite) Removed unused var i.
2747 (sfm_write_case) Removed unused var i.
2749 * sort.c: (merge_once) Remove unused var t.
2750 (write_separate) #if 0 out as dead code.
2752 * split-file.c: (cmd_split_file) Remove unused var i.
2754 * sysfile-info.c: (sysfile_info_dim) New function.
2755 (cmd_sysfile_info) Fix table dimensioning.
2756 (variables_dim) New function.
2757 (display_variables) Fix table dimensioning.
2758 (describe_variable) Remove unused var prev_r.
2760 * t-test.q: (z_postcalc) Removed.
2761 (pairs_calc) Remove unused var bad_weight.
2762 (postcalc) Remove unused vars dfn, dfd.
2764 * tab.c: (tab_create) Set t->dim to NULL.
2765 (tab_dim) Make sure t->dim is NULL first.
2766 (tab_natural_width) Remove parameter `clamp'.
2767 (tab_value) Remove duplicate assertion for table.
2768 (tab_raw) New function.
2769 (nowrap_dim) New function.
2770 (wrap_dim) New function.
2771 (tab_output_text) Fix table dimensioning.
2773 * tab.h: (tab_raw) New macro.
2775 * val-labs.c: (get_label) Remove unused var type.
2776 (copy_value_labels) Remove unused var trav.
2778 * var.h: (struct crosstab_proc) Completely changed.
2780 * vars-prs.c: (parse_dict_variable) Remove unused var v.
2782 * vfm.c: (open_active_file) Remove unused vars i, lp.
2784 * weight.c: (weight_trns_proc) #if 0 out as dead code.
2786 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
2788 * Makefile.am: Add apply-dict.c, flip.c.
2790 * apply-dict.c: New file.
2792 * command.c: (struct command) Make cmd[] larger for CLEAR
2793 TRANSFORMATIONS command name.
2794 (parse_cmd) Make sure we're in a valid state before using it as an
2795 index. Discard variables and reset state on invalid transitions.
2796 (cmd_clear_transformations) New function.
2798 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
2799 Add unimplemented PRESERVE, RESTORE.
2801 * file-handle.h: Include stddef.h.
2805 * pfm-read.c: (parse_value) Pad value label values with spaces,
2808 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
2809 (sfm_close) Decrement reference count, make sure it's zero.
2810 (sfm_maybe_close) New function.
2811 (sfm_read_dictionary) Handle reference counts.
2813 * vars-atr.c: (clear_default_dict) New function.
2814 (discard_variables) Use clear_default_dict().
2816 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
2818 * Makefile.am: Add pfm-write.c.
2819 (LDADD) Add the libgmp2 libraries.
2821 * command.def: Define EXPORT.
2823 * get.c: (cmd_export) New function.
2824 (export_write_case_func) New function.
2826 * pfm-read.c: (static spss2ascii[]) Make it const.
2828 * pfm-write.c: New file.
2830 * sfm-write.c: Formatting, comment fixes.
2832 * var.h: Comment fix.
2834 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
2836 * Makefile.am: Add pfm.h, pfm-read.c.
2838 * command.def: IMPORT is now implemented.
2840 * format.c: (glob var translate_fmt[]) New var.
2842 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
2843 (cmd_import) New function.
2844 (import_source_read) New function.
2845 (glob var import_source) New var.
2847 * pfm-read.c: New file.
2851 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
2853 (dump_dictionary) Disabled printing a couple of items.
2855 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
2857 * crosstabs.q: (postcalc) Call make_summary_table().
2858 (make_summary_table) New function.
2859 (insert_summary) New function.
2860 (display_dimensions) Remove some unnecessary arguments, all
2862 (output_pivot_table) Fix lots of problems with the risk table
2864 (submit) Don't display an empty table.
2865 (display_risk) Fix order of arguments to calc_risk().
2867 * glob.c: Always include assert.h and stdlib.h.
2869 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
2872 * tab.c: (tab_create) Cosmetic changes.
2874 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
2876 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
2880 * crosstabs.q: (output_pivot_table) Headers drawing and submission
2881 code simplified, moved into new function submit().
2882 (submit) New function.
2883 (crosstabs_dim) New function.
2884 (display_directional) Substitute variable names for %s where
2886 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
2887 (calc_symmetric) Initialize parameters only if non-NULL.
2888 Calculate Somers' d.
2889 (calc_directional) Calculate Somers' d (or copy it, really).
2892 * output.c: (outp_string_width) New function.
2894 * postscript.c: (postopen) Calculate font widths based on the
2895 width of the zero '0' character, not the width of the space
2896 character. Set paper-width and paper-length based on points, not
2898 (ps_open_page) Fix page setup string for landscape mode.
2900 * som.h: (struct som_dimension) Removed.
2901 (struct som_table_class) height, width members take int * not
2904 * tab.c: Many functions now have added parameter validation.
2905 (tab_height, tab_width) These functions were removed and merged
2906 into a single function tab_resize(), and all references changed.
2907 (tab_dim) Rewritten since the interface changed; reduced from
2908 hundreds of lines to two. All callers were changed. Currently
2909 most of them just use tab_natural_dimensions as their callback and
2910 await detailed translation of functionality.
2911 (tab_natural_width) New function.
2912 (tab_natural_height) New function.
2913 (tab_natural_dimensions) New function. This is a callback
2914 function, not something that you'd want to call directly.
2915 (tab_nat_dim) Removed.
2916 (tabi_table) Allocates t->w and t->h.
2917 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
2918 dimensions callback.
2919 (evaluate_dimensions) Removed.
2920 (sum_columns) Removed.
2922 * tab.h: (enum TAL_1THIN) Removed.
2923 (enum series t_*) Removed.
2924 (struct tab_table) Members trh, trv changed to unsigned char *
2925 from int *. Member dim changed to a function pointer from a
2926 unsigned char *. Member max_stack_height removed. New members
2928 (macros tab_l, tab_r, tab_t, tab_b) New.
2930 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
2932 * ascii.c: (delineate) Assign last_space_nchars before skipping
2933 spaces, to fix right justification.
2935 * crosstabs.q: (static vars risk, direct) New vars.
2936 (static var pearson_r) Removed.
2937 (glob var chisq_fisher) Made static.
2938 (static vars row_tot[], col_tot[]) Don't include grand total
2940 (static var grand_total) Renamed W, all references changed.
2941 (output_pivot_table) Only make `table' if num_cells != 0. Make
2942 risk and directional tables. Deal with grand total no longer part
2943 of col_tot[]. Free rows and cols after we're done with them.
2944 (display_risk) New function.
2945 (display_directional) New function.
2946 (clac_r) Rewritten so that it stores all its results into its
2947 arguments, so it can be used for Spearman's correlation too.
2948 (calc_symmetric) Added a t[] argument, all references changed.
2949 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
2950 Pearson's r, Cohen's kappa.
2951 (calc_risk) New function.
2952 (calc_directional) New function.
2954 * som.c: (som_submit) Improved debugging code.
2956 * stats.c: (hypercube) New function.
2957 (cube) New function.
2959 (normal_sig) Went back to old implementation, which actually
2962 * stats.h: (macros square, cube, hypercube) Removed. The
2963 equivalent functions in stats.c are inlined here; all references
2964 to square changed to sqr.
2966 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
2968 * crosstabs.q: (N_SYMMETRIC) New define.
2969 (postcalc) Disable debug printing.
2970 (static vars chisq_fisher, pearson_r) New.
2971 (output_pivot_table) Add support for symmetric measures. Add
2972 chi-square output of exact sigs.
2973 (display_chisq) Rewritten.
2974 (display_symmetric) New function.
2975 (gamma_int) New function.
2977 (swap) New function.
2978 (calc_fisher) New function.
2979 (calc_chisq) Check boundary conditions better. Calculate Yates,
2980 Fisher, Mantel-Haenszel tests.
2981 (calc_r) New function.
2982 (calc_symmetric) New function.
2984 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
2986 (chisq_sig) Better boundary conditions. Renamed from
2989 * tab.h: (struct tab_table) New member cf.
2991 * tab.c: (tab_create) Set cf.
2992 (tab_width) New function.
2993 (tab_realloc) Handle cf.
2994 (tab_vline) Handle cf.
2995 (tab_hline) Handle cf.
2996 (tab_box) Handle cf.
2997 (tab_value) Handle cf.
2998 (tab_float) Handle cf.
2999 (tab_text) Handle cf.
3000 (tab_joint_text) Handle cf.
3001 (tab_offset) Handle cf.
3002 (tab_next_row) Handle cf.
3003 (evaluate_dimensions) Handle cf.
3004 (render_strip) Handle cf.
3006 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
3008 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
3009 output_pivot_table().
3010 (output_pivot_table) Moved lots of local variables outside and
3011 made them static. Add beginnings of chi-square statistic
3012 support. Now column and row totals aren't in the main matrix.
3013 Always zero out any leftover rows & columns after we're done with
3014 the table entries. Move all output stuff into
3015 display_dimensions(), display_crosstabs(), display_chisq().
3016 (display_dimensions) New function.
3017 (display_crosstabulation) New function.
3018 (display_chisq) New function.
3019 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
3021 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
3022 references, simplify logic.
3024 * postscript.c: Remove scale, translate-x, translate-y,
3025 mirror-horz, mirror-vert, rotate-180 options.
3026 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
3027 All references deleted.
3028 (macro YT) New macro.
3029 (array option_tab[]) Removed options.
3030 (ps_option) Removed options.
3031 (ps_open_page) Write page setup explicitly to output file, without
3032 using now-deleted BP function.
3033 (macro dump_line) Use YT().
3034 (macro dump_thick_line) Use YT().
3035 (draw_headers) Use YT().
3036 (switch_font) Reorder arguments to SF function.
3037 (write_text) Use YT().
3039 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
3042 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
3044 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
3045 null-debugging code.
3046 (tab_realloc) Remove null-debugging code. Initialize new regions
3048 (tab_vline) Support offsets.
3049 (tab_hline) Support offsets.
3050 (tab_box) Support offsets.
3052 (tab_nulls) Removed.
3055 (evaluate_dimensions) Remove null-debugging code. Understand
3056 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
3057 TAB_EMPTY not present.
3059 * tab.h: New cell attribute TAB_EMPTY.
3060 (macros tab_nr, tab_nc, tab_row, tab_col) New.
3062 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
3063 try to read them from system files.
3065 * vfm.c: (dump_splits) Don't call tab_null().
3067 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
3069 * crosstabs.q: (struct crosstab) Added `missing' member.
3070 (custom_tables) Init missing.
3071 (calc_general) Handle missing values.
3072 (calc_chisq) New function.
3073 (output_pivot_table) Start work on chi-square output. Update for
3074 new tab offset support functions. Shorten statistic names.
3076 * Several files: add in more `const's to placate gcc's warnings.
3078 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
3081 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
3082 tab_null, tab_nulls, tab_value, tab_float, tab_text,
3083 tab_joint_text) Add col_ofs and row_ofs support.
3084 (tab_offset) New function.
3085 (tab_next_row) New function.
3086 (tab_row) New function.
3087 (tab_col) New function.
3088 (tabi_table) Add col_ofs and row_ofs support.
3090 * vars-atr.c: (is_system_missing) New function.
3092 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
3094 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
3095 (static var no_cells) Removed.
3096 (static var num_cells) New.
3097 (static var expected) New.
3098 (static var cells[]) New.
3099 (internal_cmd_crosstabs) Deal with new variables.
3100 (postcalc) Removed most of the meat and put it in new function
3101 output_pivot_table().
3102 (output_pivot_table) Calculates and outputs an entire pivot table.
3104 * postscript.c: (postopen) Fix problems with free()ing addresses
3105 not obtained from malloc().
3107 * som.c: (som_submit) Add assertion.
3109 * sysfile-info.c: (describe_variable) Use new tab_nulls()
3112 * tab.c: (static var tab_names[]) New.
3113 (tab_realloc) -1 for nc or nr indicates no change.
3114 (tab_nulls) New function.
3115 (tab_dim) Use tab_names[].
3116 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
3117 (evaluate_dimensions) Don't terminate on uninited cells, just put
3118 an X in them and emit a notice. Use tab_names[].
3120 * tab.h: Move bits into tab.def.
3122 * tab.def: New. Don't try to declare tab_table_class because then
3123 som.h has to be included.
3125 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
3127 * command.def: New file, contains all the command definitions
3128 previously included bodily in command.c.
3130 * format.def: New file, contains all of the format definitions
3131 previously split across format.h, format.c, and sfm-write.c.
3133 * lexer.h: Renamed from tokens.h in order to match corresponding
3136 * lexerP.h: Moved some rarely used functions exported by lexer.c
3139 * Makefile.am: Commemorate renamed files.
3140 (EXTRA_DIST) Add command.def, format.def.
3142 * command.c: [0] (walk_cmdtable_func) Removed.
3144 * crosstabs.q: (postcalc) Made it work and print out matrices
3146 (enum_column_values) Renamed enum_var_values, generalized for any
3149 * format.h: (struct fmt_desc) New member `spss'.
3151 * q2c.c: (main) Generated code includes lexer.h instead of
3154 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
3155 instead of an independent translation table.
3157 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
3159 * Lots of source files: Added const to declarations.
3161 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
3163 * arena.c: (arena_clear) Set prev pointer to null when done.
3165 * ascii.c: (ascii_option) Rename index as indx.
3167 * avl.c: This is now a separate library called libavl.
3168 (xmalloc) Make static.
3169 (avl_probe) Step A7 can use the cache instead of an explicit
3171 (avl_delete) Don't maintain a q pointer because it's always
3172 available in the pointer stack. Comment fix.
3174 * avl.h: This is now a separate library called libavl.
3176 * command.c: (cmd_table[]) Remove spurious trailing "".
3178 * common.h: Only include random() fix if this system needs it.
3180 * crosstabs.q: Include alloca headers.
3181 (n_sorted_tab) New global var.
3182 (postcalc) Mostly rewritten.
3183 (find_pivot_extent) Rewritten.
3184 (enum_column_values) Rewritten.
3186 * data-out.c: (convert_F) Rename inner n as n_spaces.
3188 * error.c: (dump_message) Don't have an outer var i.
3190 * file-handle.q: (static var f) Removed. All references removed.
3191 (internal_cmd_file_handle) Uses a local variable instead of f.
3193 * get.c: (trim_dictionary) Change scope of i, i1, i2.
3194 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
3197 * getline.h: Declare getl_history as extern. Reported by
3198 palme@uni-wuppertal.de (Hubert Palme).
3200 * postscript.c: (postopen) Some large mods for constness.
3202 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
3205 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
3207 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
3208 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
3211 * avl.c, avl.h: New files. These form a clean-room
3212 reimplementation of avllib. Iterative algorithms are used in
3213 place of recursive ones, so there is no resemblance in the code.
3215 * Lots of headers: Don't include other headers by default.
3217 * Lots of source files: Explicitly include all needed headers.
3219 * arena.c: (arena_clear) New function.
3221 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
3222 (static var ar) Removed.
3223 (staitc vars ar_tc, ar_col) New.
3224 (cmd_crosstabs) Destroy the arenas.
3225 (internal_cmd_crosstabs) Create the arenas.
3226 (precalc) Don't need a free function for the hash.
3227 (calc_general) Make sure to zero out the trailer on the key data
3229 (print_table_entries) Updated.
3230 (postcalc) Worked on actually implementing.
3231 (find_pivot_extent) New function.
3232 (compare_value) New function.
3233 (enum_column_values) New function.
3235 * data-in.c: (parse_month) Make local array `static const'.
3237 * data-out.c: (convert_date) Make local array `static const'.
3238 (convert_WKDAY) Same.
3239 (convert_MONTH) Same.
3241 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
3242 been renamed to avl_walk().
3244 * hash.c: Rewritten more efficiently.
3246 * hash.h: Add attribute const to hsh_next_prime declaration.
3248 * lexer.c: (id_match) Make arguments const.
3250 * postscript.c: (ps_postopen_driver) Make default fonts the
3253 * q2c.c: (main) Generated code needs stdlib.h.
3255 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
3256 initialized to 0 now, not to NULL. All other references to
3257 avl_traverser were updated in the same way.
3259 * tokens.h: Macro version of id_match updated to use const
3262 * val-labs.c: (inc_ref_count) New function.
3263 (copy_value_labels) Simply through use of new avl_copy() function.
3265 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
3267 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
3268 (postcalc) Worked on this.
3270 * postscript.c: (OPO_DOUBLE_LINE) New enum.
3271 (struct ps_driver_ext) New line_width_thick member.
3272 (ps_preopen_drive) Init line_width_thick.
3273 (option_tab[]) Add line-* options.
3274 (ps_option) Parse line-* options.
3275 (postopen) Add line_width_thick support. Strip leading spaces on
3276 prologue output lines.
3277 (ps_open_page) Include line_width_thick in output.
3278 (macro dump_thick_line) New.
3279 (dump_fancy_line) Support thick lines as well as double lines.
3281 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
3283 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
3284 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
3286 * Many source files: Rename `options' to `pv_opts' as appropriate.
3288 * command.c: (static var cmd_table[]) Add CROSSTABS command.
3290 * common.c: (xcalloc) New function.
3292 * crosstabs.q: New file. Not finished yet, though.
3294 * data-list.c: Comment fix.
3296 * error.c: Remove some old Checker cruft.
3298 * frequencies.q: (dump_full) Cumulate valid percent instead of
3301 * getline.c: Comment fix.
3303 * hash.c: Comment fixes.
3305 * hash.h: (struct hsh_table) Make hash functions return unsigned
3306 instead of int to avoid problems with taking the modulo of
3307 negative return values. All references changed.
3309 * misc.c: (intlog10) Make its table static const instead of auto.
3311 * sfm-read.c: (read_header) Make `prefix' static const instead of
3314 * var.h: (union value) Add member `hash'.
3315 (struct variable) Rename prv_index as `foo'--all references
3317 (typedef pv_opts) Removed. All references changed.
3319 * vars-prs.c: (parse_variables) Message fixes.
3321 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
3323 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
3324 they are being inserted. Don't check for BY variables of
3325 different types. Discard variables if the active file isn't
3326 included in the merge.
3327 (mtf_processing) Essentially rewritten.
3328 (mtf_merge_dictionary) Check for master/slave variables of
3329 different types/widths.
3331 * vfm.c: (static var not_canceled) New var.
3332 (process_active_file) Don't call vfm_source->read() if
3333 there's no vfm-source. Initialize not_canceled.
3334 (process_active_file_write_case) Honor and update not_canceled.
3335 (prepare_for_writing) Rollback changes from yesterday, they were
3337 (close_active_file) Don't destroy vfm_source unless it exists.
3339 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
3341 * Lots of source files: Added { } around nested if/else constructs
3342 to avoid new gcc 2.8 warnings.
3344 * data-in.c: (parse_Z) Declare `int' type explicitly.
3347 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
3348 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
3349 prev members. Put TABLEs at the end of the chain and FILEs at the
3350 beginning. Don't allow the active file in STATE_INIT. Use proper
3351 `seen' value for the active file. Fill out the by members and
3352 make sure they're of consistent type. Do the actual merge
3354 (mtf_processing_finish) New function.
3355 (var_type_description) New function.
3356 (mtf_free_file) New function.
3357 (mtf_free) Rewritten.
3358 (mtf_delete_file_in_place) New function.
3359 (mtf_read_nonactive_records) New function.
3360 (mtf_compare_BY_values) New function.
3361 (static var mtf_seq_no) New var.
3362 (mtf_processing) New function.
3363 (mtf_merge_dictionary) Assign nval members for the system file
3364 dictionary. Assign fv values for its variables. Point each slave
3365 variable to the corresponding master variable.
3367 * hash.c: Include str.h.
3369 * mis-val.c: (copy_missing_values) src arg is const.
3371 * misc.c: (spacing) Make `max' var explicitly int.
3373 * sfm-read.c: (dump_dictionary) Message reformatting.
3374 (sfm_read_case) Add assertion.
3376 * sort.c: Esthetic fixes.
3378 * var.h: (struct match_files_proc) New struct.
3379 (struct variable) Add private data match_files_proc.
3381 * vars-atr.c: (delete_variable) Implement. Add argument for the
3382 dictionary that owning the variable.
3383 (dup_variable) Add assertion.
3385 * vfm.c: Comment fixes, hopefully the comments are correct now.
3386 (process_active_file) New function.
3387 (process_active_file_write_case) New function.
3388 (process_active_file_output_case) New function.
3389 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
3391 (write_case) Renamed procedure_write_case(). Now write_case is a
3392 pointer to a function. Style fixes.
3394 1998-03-05 Ben Pfaff <blp@gnu.org>
3396 * Makefile.am: (q2c) Link with libmisc.
3397 (version.c) Define default_config_path, include_path,
3400 * ascii.c: (ascii_postopen_driver) When the default newline string
3401 is requested, open file in text mode. Suggested by
3402 palme@uni-wuppertal.de (Hubert Palme).
3403 (static vars line_buf, line_p) Change from char * to unsigned char
3405 (ascii_close_page) char * to unsigned char *.
3407 * cmdline.c: (parse_command_line) Implement -r option by
3408 prepending ~/.pspp/rc to the list of files to process.
3410 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
3411 before pulling in a final line.
3412 (null_func, null_int_func) Removed (dead code).
3414 * descript.q: (display) Calculate width of variable name column
3415 properly. Calculate number of valid cases properly. Reported by
3416 palme@uni-wuppertal.de (Hubert Palme).
3418 * filename.c: (init_filename) Use default_config_path instead of
3419 now obsolete CONFIG_PATH.
3421 * getline.c: (getl_initialize) Use include_path instead of now
3422 obsolete INCLUDE_PATH.
3423 (getl_add_file) New argument `where'. All references changed.
3425 * groff.c: (find_font_file) Use groff_font_path instead of now
3426 obsolete GROFF_FONT_PATH.
3428 * postscript.c: (find_ps_file) Use groff_font_path instead of now
3429 obsolete GROFF_FONT_PATH. Copy through temporary variable to
3430 avoid problems with constness.
3432 * str.h: (macro cs_streq) New macro.
3434 * version.h: (glob var default_config_path, include_path,
3435 groff_font_path) New vars.
3437 1998-02-23 Ben Pfaff <blp@gnu.org>
3439 * Many source files: Change verbose_msg() priority levels and
3442 * aggregate.c: Include debug-print.h.
3444 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
3446 (static var pre_syntax_message) Document --safer/-s and
3449 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
3451 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
3452 because it's not used but it's still copied.
3453 (open_file_r) Remove gratuitous debug message.
3455 * filename.c: (safety_violation) New function.
3456 (open_file) Remove gratuitous debug messages. Don't allow pipe
3457 files if set_safer is set.
3459 * get.c: Turn off debugging.
3461 * getline.c: (getl_add_virtual_file) New function.
3462 (getl_read_line) Add verbose_msg() call for opening new syntax
3464 (getl_perform_delayed_reset) Add a return value describing whether
3465 any action was taken. Call reset_eof().
3467 * getline.h: Comment fix.
3469 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
3470 place of incorrect `continue'. Use strtok_r() instead of
3471 strtok(). Always check strtok_r() return value.
3472 (groff_read_DESC) Use strtok_r() instead of strtok().
3474 * lexer.c: (reset_eof) New function.
3476 * main.c: (parse) Get a token after performing a delayed reset
3477 action; allow empty syntax files.
3479 * postscript.c: (output_encodings) Use strtok_r() instead of
3482 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
3484 * set.q: Comment fixes.
3485 (glob var set_safer) New var.
3486 (internal_cmd_set) Support SAFER.
3488 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
3490 * temporary.c: (free_dictionary) Set d->splits to NULL after
3493 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
3494 variable deleted, not if it *isn't* deleted.
3496 1998-02-16 Ben Pfaff <blp@gnu.org>
3498 * command.c: (array cmd_table[]) Add MATCH FILES.
3500 * common.c: Comment fixes.
3502 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
3503 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
3504 Include alloca.h. Problem reported by palme@uni-wuppertal.de
3507 * expr-opt.c: Include str.h. Problem reported by
3508 palme@uni-wuppertal.de (Hubert Palme).
3510 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
3511 (static var mtf_by) Change from char ** to variable **.
3512 (static var mtf_master) New var.
3513 (mtf_merge_dictionary) New function.
3514 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
3515 var type. Reorder tests properly. Initialize file->dict. Detect
3516 TABLE= without BY=. Read file dictionaries and merge them. Give
3517 subcommand name with IN, LAST, FIRST error messages. Create IN,
3518 LAST, FIRST variables. Comment fixes.
3519 (mtf_free) Don't free default_dict. Free mtf_master.
3521 * getline.c: Define getl_mode. Change getl_buf_size to size_t
3523 (handle_line_buffer) Cast int to size_t in comparison to avoid
3526 * getline.h: Declare getl_mode extern.
3528 * groff-font.c: (groff_read_font) Type-fix calls to getline.
3529 (groff_read_DESC) Make line_size a size_t.
3530 (match_tok) Parenthesize name to avoid macro expansion.
3532 * mis-val.c: (copy_missing_values) New function.
3534 * postscript.c: (postopen) Make buf_size a size_t.
3536 * sfm-read.c: (dump_dictionary) Make global from static. Print
3537 variable info in parts for easier debugging with Checker.
3539 * temporary.c: (copy_variable) Use copy_value_labels().
3540 (new_dictionary) New arg: whether to copy file label, documents.
3542 * val-labs.c: (copy_value_labels) New function.
3544 * var.h: (enums MISSING_*) Add MISSING_COUNT.
3546 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
3548 (dup_variable) Set prv_index, get.fv, get.nv.
3550 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
3552 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
3554 * Many source files: For ANSI-compliance, add empty statement
3555 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
3556 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3558 * data-in.c: (parse_numeric) Some header files break on
3559 -DBL_MIN_10_EXP because they get a --; add () for safety.
3560 Reported by palme@uni-wuppertal.de (Hubert Palme).
3562 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
3563 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
3564 (dfm_close) Use close_file_ext.
3565 (open_inline_file) Set file.file to NULL, not file.
3566 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
3567 struct and use open_file_ext().
3568 (read_record) Use file.file.
3570 * file-handle.q: (prepend_current_directory) Pass through special
3573 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
3574 (normalize_filename) Pass through special filenames.
3575 (open_file, close_file) Accept pipe| and |pipe syntaxes as
3577 (dirname) Rename blp_dirname() because of name conflict on some
3578 OS. All references changed. Reported by palme@uni-wuppertal.de
3580 (is_special_filename) New function.
3582 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
3583 (trim_dictionary) Conditionalize some of the options on whether
3584 GTSV_OPT_MATCH_FILES is in *options.
3585 (rename_variables) Don't allow variables to be renamed as scratch
3587 (MTF_*) New enum series.
3588 (struct mtf_file) New struct.
3589 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
3591 (cmd_match_files, mtf_free) New functions.
3593 * lexer.c: (match_int) Needed parentheses around name to escape
3594 macro expansion. Reported by Micah Altman
3595 <maltman@www-vdc.fas.harvard.edu>.
3597 * print.c: Needed to include alloca.h. Reported by Micah Altman
3598 <maltman@www-vdc.fas.harvard.edu>.
3600 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
3601 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
3604 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
3605 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3607 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
3609 * html.c: (struct html_driver_ext) Move into htmlP.h.
3610 (html_preopen_driver) Initialize cp_x, cp_y.
3611 (html_submit) Implement as call to output_tab_table().
3612 (change_attributes) New function.
3613 (escape_string) New function.
3614 (output_tab_table) New function.
3616 * list.q: (write_all_headers) Add code for writing headers for the
3618 (clean_up) Write out the html close-table tag.
3619 (determine_layout) Ignore html driver.
3620 (list_cases) Write html data.
3622 * som.c: (som_submit) Move more of the code into output_table().
3624 * tab.c: (static var hit) Make a global var and rename tab_hit.
3625 (static var tab_table_class) Make a global var.
3627 * htmlP.h: New file.
3629 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
3631 * dump-sysfile.c: Removed.
3633 * html.c: (preclose) Change comment in emitted code.
3635 * matrix-data.c: Debugging off by default. Comment fixes.
3636 (static var container) New var.
3637 (cmd_matrix_data) Create and destroy container. Initialize
3638 is_per_factor[] to 0s. Move code into new function
3639 string_to_content_type(). Require split values to be present in
3640 the data when ROWTYPE_ is explicit. Call specific function, not
3641 general read_matrices().
3642 (string_to_content_type) New function.
3643 (context) Exclude all whitespace, not just spaces.
3644 (mget_token) A dot is a number. Add assertion.
3645 (static var data) Renamed nr_data.
3646 (static var factor_values) Renamed nr_factor_values.
3647 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
3648 only specific case. Close data_file before exit.
3649 (fill_matrix) New function.
3650 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
3651 printing. Style fixes. Message fixes. Move code into
3653 (read_matrices_without_rowtype) Rename
3654 matrix_data_read_without_rowtype(). Fix off-by-one error on
3655 loops. Allocate nr_data[] memory from arena.
3656 (read_matrices_with_rowtype) Removed.
3657 (read_splits) Renamed nr_read_splits(). Style fixes.
3658 (read_factors) Renamed nr_read_factors().
3659 (dump_cell_content) Comment fixes. Arguments changed. Change
3660 debug printing. All references changed.
3661 (output_data) Renamed nr_output_data().
3662 (static var wr_content) New var.
3663 (struct factor_data) New struct.
3664 (static var wr_data) New var.
3665 (static var wr_current) New var.
3666 (matrix_data_source_destroy_source) Removed.
3667 (read_matrices_with_rowtype) New function.
3668 (matrix_data_read_with_rowtype) New function.
3669 (wr_read_splits) New function.
3670 (compare_factors) New function.
3671 (wr_output_data) New function.
3672 (wr_read_rowtype) New function.
3673 (wr_read_factors) New function.
3674 (wr_read_indeps) New function.
3675 (glob var matrix_data_source) Make destroy_source member NULL as
3678 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
3680 * lexer.c: (syntax_error) Give better error message when at end of
3683 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
3684 N_SCALAR to output as plain N.
3685 (mdump_token) Change output format.
3686 (context) Fix message output interaction with spaces in input.
3687 (another_token) New function.
3688 (force_eol) Improved error message.
3689 (static var max_cell_index) New var.
3690 (read_matrices) Init `cells'. factor_values is now per-cell.
3691 Init max_cell_index.
3692 (read_data_lines) Replace `compare' local with new `compare' arg.
3693 Debugging messages changed. Only read factors if per_factor.
3694 Propagate error return from read_factors(), force_eol().
3695 Copy N_SCALAR values across the N vector.
3696 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
3697 check parentheses manually since we now have is_per_factor[].
3698 Call read_data_lines() with new args. Check for end of data after
3699 looping, using another_token().
3700 (read_factors) Arguments changed. Use max_cell_index to determine
3701 whether to read or compare factors. Message fixes.
3702 (dump_cell_content) New function.
3703 (output_data) Completely rewritten because content types were
3704 supported to be nested inside factor values, not vice versa.
3706 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
3708 * lexer.c: (syntax_error) Support formatted varargs messages.
3710 * matrix-data.c: Turn debugging on by default.
3711 (static content_type[]) New array.
3712 (static content_names[]) New array.
3713 (static rowtype_, varname_) New vars.
3714 (static is_per_factor[]) New array.
3715 (static split_values) Moved declaration.
3716 (static n_continuous, first_continuous) New var.
3717 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
3718 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
3719 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
3720 Check for continuous variables.
3721 [DEBUGGING] (debug_print) Remove content_names[].
3722 (mdump_token) New macro.
3723 (mget_token_dump) New function.
3724 (mdump_token) New function.
3725 (context) New function.
3726 (mget_token) Fix messages.
3727 (static var data, split_values, factor_values) New vars.
3728 (read_matrices) Manage split_values, factor_values.
3729 (read_data_lines) New function.
3730 (read_matrices_without_rowtype) Implemented.
3731 (read_splits) Message fixes. Uses `just_read'.
3732 (read_factors) New function.
3733 (output_data) New function.
3734 (matrix_data_source_destroy_source) Close the file handle.
3735 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
3738 * str.c: (strpadcmp) Removed.
3740 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
3742 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
3744 * Lots of source files: Add cast to unsigned character to calls to
3745 tolower() and toupper().
3747 * aggregate.c: Set default_dict.splits to NULL.
3749 * command.c: (static variable tab[]) Add MATRIX DATA.
3751 * data-in.c: Add debugging defines. Formatting fixes.
3753 * expr-opt.c: Formatting fixes.
3755 * lexer.c: (syntax_error) Message fixes.
3757 * matrix-data.c: New enum series.
3758 (static vars fmt, section, diag, explicit_rowtype, signle_split,
3759 split_values, n_factors, factors, cells, pop_n, contents,
3760 n_contents) New vars.
3761 (cmd_matrix_data) Finished implementation.
3762 (compare_variables_by_mxd_vartype) New function.
3763 [DEBUGGING] (debug_print) New function.
3764 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
3765 (read_matrices) New function.
3766 (read_matrices_without_rowtype) New function.
3767 (read_matrices_with_rowtype) New function.
3768 (read_splits) New function.
3769 (mget_token) New function.
3770 (force_eol) New function.
3771 [0] (test_tokenizer) New function.
3772 (matrix_data_source_destroy_source) New function.
3773 (glob var matrix_data_source) New var.
3775 * misc.h: Include ieeefp.h if present.
3777 * split-file.h: (cmd_split_file) Changes corresponding to struct
3780 * str.h: Fix memmem prototype.
3782 * temporary.c: (save_dictionary, restore_dictionary,
3783 free_dictionary) Changes corresponding to struct dictionary
3786 * var.h: (MXD_* enums) New enum series.
3787 (struct matrix_data_proc) New struct.
3788 (struct split) Removed.
3789 (struct dictionary) Changed `splits' member from `split *' to
3791 (macro force_create_variable) New macro. Replaced lots of
3792 create_variable()/assert() calls with calls to this macro.
3794 * vars-atr.c: (discard_variables) Changed assertion.
3795 [GLOBAL_DEBUGGING] (force_create_variable) New function
3796 called by the macro of the same name.
3797 (clear_variable) Changes to delete splits from the dictionary
3798 corresponding to struct dictionary changes.
3800 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
3801 corrupted variable `index' values in the dictionary passed in
3802 every time this function is called.
3804 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
3805 to struct dictionary changes.
3807 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
3809 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
3811 * command.c: New includes.
3812 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
3813 (cmd_erase) New function.
3814 [unix] (shell) New function.
3815 (run_command) New function.
3816 (cmd_host) New function.
3817 (cmd_new_file) New function.
3819 * expr-prs.c: (parse_primary) Message fix.
3821 * inpt-pgm.c: Formatting fix.
3822 (cmd_reread) Implement the FILE subcommand.
3824 * matrix-data.c: New file.
3826 * q2c.c: (dump_header) Change output commenting style.
3828 * weight.c: Comment fix.
3830 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
3832 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
3834 (buf_10x) Renamed buf_1xx, all references changed.
3835 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
3836 cases now implemented).
3837 (create_sysfile) New function.
3838 (agr_11x_func) New function.
3840 * data-in.c: (parse_numeric) Work properly if there's an
3841 explicitly coded decimal point in the data and decimal places are
3842 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
3843 <el@linux.lisse.na>.
3845 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
3846 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
3847 Eberhard W Lisse <el@linux.lisse.na>.
3849 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
3850 strerror.c. Bug reported by Alexandre Oliva
3851 <oliva@dcc.unicamp.br>.
3853 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
3854 (static var separate_case_tab) New var.
3855 (cmd_sort_cases) Cancel temporary transformations here. Free
3856 v_sort before return.
3857 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
3858 we're reading from a sort stream. Don't cancel temporary
3859 transformations. Offload internal sorting to do_internal_sort().
3860 (do_internal_sort) New function. Handles internal sorting even
3861 when SEPARATE is nonzero. Doesn't free v_sort.
3862 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
3864 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
3865 sink if SEPARATE is zero.
3866 (read_output_cases) Renamed read_sort_output(), all references
3867 changed. Now uses separate_case_tab when it exists.
3868 (write_separate) New function.
3870 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
3871 memory_sink_cases. Don't redundantly call
3872 vfm_source->destroy_source().
3873 (memory_stream_mode) After switching over, set memory_sink_cases
3876 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
3878 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
3880 (static var prev_case) New, moved out of aggregate_single_case()
3882 (static var buf64_10x, buf_10x) New.
3883 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
3884 the 000, 001, 100, and 101 cases. Free prev_case.
3885 (parse_aggregate_functions) Disallow scratch variables.
3886 (free_aggregate_functions) Only free agr_dict if non-null. Use
3887 iter->function to determine numeric/string type, not
3889 (aggregate_single_case) Don't manage prev_case. Initialize
3890 aggregate info after dumping it.
3891 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
3892 mean, stddev, weighted stddev definitions.
3893 (dump_aggregate_info) Implemented.
3894 (initialize_aggregate_info) Renamed from
3895 initialize_aggregate_functions(). Initializes dbl[2].
3896 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
3897 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
3899 * cases.c: (alloc_val) Removed.
3901 * get.c: (cmd_save_internal) Initialize new `dict' member.
3903 * sfm-write.c: (sfm_write_dictionary, write_header,
3904 write_variable, write_value_labels, write_documents) Reorganize,
3905 simplify for new parameter structure.
3906 (write_variable) Only one variable * argument now.
3908 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
3909 replaced by new `dict' member.
3911 * temporary.c: (new_dictionary) Initialize n_documents.
3913 * vars-atr.c: (dup_variable) Allocate `value's from dict into
3915 (init_variable, replace_variable) Eliminate usage of alloc_val().
3917 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
3919 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
3920 signal that AGGREGATE is to be used for forming final cases.
3921 (close_active_file) Call end_func before stopping lagging. Cancel
3922 temporary after finishing compaction.
3923 (write_case) Comment fixes. Cleaned up.
3924 (compact_case) Let AGGREGATE handle compaction when `temporary' is
3927 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
3929 * Makefile.am: (BUILT_SOURCES) Add means.c.
3930 (pspp_SOURCES) Add means.c.
3931 (EXTRA_DIST) Add means.q.
3933 * command.c: (array cmd_table[]) Add MEANS.
3935 * common.h: Esthetic fixes. Comment fixes. Test for
3936 MAX_SHORT_STRING greater than 8.
3937 (macros LOWEST, HIGHEST) New.
3939 * data-in.c, data-list.c, recode.c: Comment fixes.
3941 * means.q: New file, base version.
3943 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
3944 with LOWEST, DBL_MAX with HIGHEST.
3946 * q2c.c: (dump_vars) Add an enum to array types giving the number
3947 of values for the enum.
3949 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
3950 Replace second_lowest_value with second_lowest_flt64.
3952 * sfm-write.c: (write_variable, write_rec_7_34) Replace
3953 second_lowest_value with second_lowest_flt64.
3955 * t-test.q: Comment fix.
3957 * temporary.c: (restore_dictionary) Esthetic fix.
3959 * tokens.h: (force_match_id, force_match, force_string, force_int,
3960 force_num, force_id) Replace msg() with syntax_error().
3962 * var.h: (struct means_proc) New.
3963 (struct variable) Add mns member to `p' union.
3965 * vars-prs.c: (parse_variable, parse_dict_variable,
3966 parse_variables, parse_DATA_LIST_vars) Replace msg() with
3969 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
3971 * Makefile.am: (pspp_SOURCES) Add tab.h.
3973 * Most source files: Added a cast to unsigned char in usages of
3974 the ctype is*() functions. Replaced `end of command expected'
3975 calls to msg() with calls to syntax_error().
3977 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
3979 * lexer.c: (hex_val) Removed (was dead code).
3980 (idmatch) Parenthesize function name to avoid macro expansion.
3982 * postscript.c: Comment fixes.
3983 (ps_preopen_driver) Change default font size to 10pt.
3985 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
3987 (parse_format_spec) Change system-file format spec argument type
3988 to int32. Parse the format spec with bitwise operators.
3990 * sfmP.h: (struct sysfile_format) Removed.
3991 (struct sysfile_variable) Changed print, write members from
3992 sysfile_format to int32.
3994 * tokens.h: Esthetic fixes.
3995 [__GNUC__] (macro id_match) New macro to hopefully speed up
3996 identifier matching.
3997 (macros match_id, match_tok, match_int) Implemented in
3998 compiler-independent manner; no longer GNU C only.
4000 * vfm.h: Include time.h.
4002 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
4004 * data-list.c: (dump_fixed_table) Change tab_dim().
4006 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
4008 * error.c: Include command.h.
4010 * frequencies.g: Formatting fixes.
4012 * frequencies.q: Add tab_dim() calls. Make the total cell a
4015 * glob.c: Include command.h.
4017 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
4019 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
4020 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
4021 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
4022 the other elements (is this right?).
4023 (read_variables) Use lowest, highest members.
4024 (parse_format_spec) New arg `vv' for more stringent checking.
4025 (dump_dictionary) Byteswaps nonexplicit data.
4026 (sfm_read_case) Byteswap numeric data.
4028 * som.c: Initialize table_num to 1.
4029 (render_segments) Remember to increment y_index after each table
4032 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
4033 avl_count() on a NULL tree. No title for the second table.
4034 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
4035 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
4036 fix call to display_variables().
4037 (display_variables) Default to 4 columns, not 3. Set up headers.
4038 Column title is Variable, not Name. Fix index column.
4039 Add joint text. Add tab_dim(). Handle value labels properly.
4040 Handle DISPLAY LABELS properly. Draw boxes correctly.
4041 (describe_variable) Value labels don't need titles. Don't clear
4042 nonexistent index column.
4043 (compare_vectors_by_name) New function.
4044 (display_vectors) New function.
4046 * tab.c: (tab_height) Add assertion.
4047 (tab_null) Add debug code.
4048 (evaluate_dimensions) Add debug code.
4050 * var.h: (struct variable) get_proc data is sometimes used
4051 simultaneously with other per-procedure info, therefore it was
4052 removed from the union. All references changed.
4054 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
4056 * ascii.c: (ascii_close_page) Put title on second line of headers
4057 if there is no subtitle.
4059 * command.c: (glob var cur_proc) Move definition here, from
4061 (cmd_remark) Emit blank line before remarks.
4063 * command.h: (glob var cur_proc) Move declaration here, from
4066 * data-list.c: (dump_fixed_table) Fix messages.
4067 (dump_free_table) Call tab_nat_dim().
4069 * descript.q: (dump_z_table) Modify tab_dim() call.
4071 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
4073 (dump_statistics) Don't output header.
4075 * groff-font.c: Minor format fix.
4077 * html.c: Comment fix.
4079 * list.q: (write_varname) Indent after advancing page.
4081 * output.h: Minor reordering.
4083 * postscript.c: Comment fixes. Many places, '\n' was replaced by
4084 a reference to eol[].
4085 (struct ps_driver_ext) New member eol[].
4086 (ps_preopen_driver) Initialize eol[].
4087 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
4088 defaults. Handle headers. Fix test for minimum page length.
4089 (static var option_tab[]) Add `line-ends'.
4090 (ps_option) Handle line-ends to change eol[].
4091 (postopen) Scale prop_em_width and fixed_width properly. Set the
4092 prologue title to outp_title if applicable. Replace the prologue
4093 line ends with eol[]. Call draw_headers() if headers are enabled.
4094 (text_width) New function.
4095 (out_text_plain) New function.
4096 (draw_headers) New function.
4098 * print.c: (dump_table) Call tab_nat_dim().
4100 * som.c: (som_blank_line) Only advance a line if not at the top of
4102 (som_submit) Move several informational table calls here.
4103 Increment subtable_num if SOMF_NO_TITLE not set.
4104 (output_table) Advance a line if SOMF_NO_SPACING not set.
4105 (render_columns, render_segments, render_simple) Handle spacing
4106 between tables. Handle table titles. Remove debug output.
4108 * som.h: (SOMF_*) New enum series.
4109 (struct som_table_class) New member `flags'.
4111 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
4113 (display_variables) Calls tab_nat_dim().
4114 (describe_variable) Remove restriction on number of value labels.
4115 Make value labels separated by thin lines.
4117 * tab.c: (tab_create) Default `flags' to none.
4118 (tab_float) New arg `w'. All references changed.
4119 (tab_nat_dim) New function.
4120 (tab_output_text) No title or spacing.
4121 (tab_flags) New function.
4122 (tabi_flags) New function.
4123 (tabi_title) New function.
4124 (strip_height) Removed.
4125 (tabi_render) Skip title when necessary.
4126 (static var tab_tab_class) Add tabi_flags, tabi_title.
4127 (evaluate_dimensions) Disable display of column, row size.
4128 (sum_columns) Add title height to top header.
4129 (render_strip) Moved within file.
4131 * tab.h: (struct tab_table) New member `flags'.
4133 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
4135 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
4137 * Most source files: Add `const' attribute in all appropriate
4140 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
4141 column to the variables table for use by describe_variable().
4142 (cmd_display) Disable for the present.
4143 (display_documents) Don't wrap documents.
4144 (display_variables) Table has four columns now.
4145 (describe_variable) Table has four columns now. Don't use a
4146 subtable, use joined cells instead.
4148 * tab.c: (tab_create) Don't set `join'.
4149 (tab_realloc) ct array is not made up of a_string's.
4150 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
4151 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
4152 (text_format) New function.
4153 (tab_title) Rewritten, uses text_format().
4154 (tab_text) Rewritten, uses text_format().
4155 (tab_joint_text) New function.
4157 (static var hit) New variable.
4158 (render_strip) New args r1, r2. Implement joined cells that fit
4160 (tabi_render) Increment hit. Pass new args to render_strip().
4161 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
4162 cells. For t_naw and t_nah, ignore joined cells and null cells in
4165 * tab.h: (struct tab_join_rect) Removed.
4166 (struct tab_table) Removed `join'.
4167 (TAB_JOIN_MAIN) Removed.
4168 (struct tab_joined_cell) New struct.
4169 (TAT_NOWRAP) New enum.
4171 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
4173 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
4175 (ascii_postopen_driver) Fix initialization of *_spacing so that
4176 the TAL_0 bit doesn't count.
4178 * data-list.c: (dump_fixed_table) Use natural width for Format
4181 * glob.c: (rerange) Removed.
4182 (get_date) Formatting fixes. Internationalization fix.
4184 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
4187 * postscript.c: (ps_postopen_driver) Replace
4188 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
4190 * som.c: (som_submit) Don't eject page before every table.
4191 (output_table) Fix order of arguments on call to area().
4192 (render_columns) Fix calculation of max_len.
4194 * tab.c: (tabi_cumulate) Minor change to increase elegance.
4195 (render_strip) New function.
4196 (strip_height) New function.
4197 (tabi_render) Rewrite as calls to render_strip().
4199 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
4200 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
4201 with the TAB_* and OUTP_T_* constants.
4203 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
4205 * Makefile.am: Formatting fixes.
4207 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
4210 * data-list.c: (dump_fixed_table) Add tab_dim() call.
4212 * descript.q: (dump_z_table, display) Add tab_dim() calls.
4214 * dump-sysfile.c: (glob var length) Make type off_t.
4215 (usage) Fix arguments.
4218 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
4219 Now right-justification is the default so many references had to
4221 (struct outp_class) Removed line_width, all references changed.
4222 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
4223 (struct outp_driver) Add elements horiz_line_width,
4224 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
4227 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
4229 (postopen) Initialize all the informational members of
4232 * som.c: (som_blank_line) New function, renamed from blank_line(),
4233 all references changed.
4234 (som_submit) Disables drivers whose pages can't be opened.
4235 (render_columns, render_simple, render_segments) Add debug output.
4236 (render_columns) Fix loop range.
4237 (render_simple) Don't try to render the headers, they're taken
4238 care of automatically. Advance cp_y past the table when done.
4239 (render_segments) Fix loop ranges.
4241 * tab.c: Initialize new members of tab_table.
4242 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
4243 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
4244 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
4247 (tab_dim) New function.
4248 (tab_col_width) Removed.
4249 (tab_row_height) Removed.
4250 (tab_output_text) Call tab_dim().
4251 (tabi_driver) Call evaluate_dimensions(), sum_columns().
4252 (tabi_area) Implemented.
4253 (tabi_cumulate) Implemented.
4254 (tabi_render) Partially implemented, but broken.
4255 (var tab_table_class) Made static.
4256 (evaluate_dimensions) New function.
4257 (sum_columns) New function.
4259 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
4260 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
4261 t_scr, t_srr, t_sentinel. Removed: t_nat.
4262 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
4263 max_stack_height, w, h. Removed: ce, re.
4264 (macro blank_line) Removed.
4265 (glob var zero_length) Removed.
4267 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
4269 * Most source files: include some of the new include files broken
4272 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
4275 * aggregate.c: (glob var outfile) Make static.
4277 * command.c: (glob var pgm_state) Move here.
4279 * common.c: (glob vars endian, second_lowest_value, pgmname,
4280 finished, curdate, cur_proc, start_interactive, history_file) Move
4283 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
4285 * file-handle.q: (glob vars files, inline_file) Move here.
4287 * glob.c: Lost lots of glob vars, detailed in individual file
4289 (init_glob) set_printer, set_screen were obsolete, deleted.
4290 set_cprompt has fewer spaces because pspp has fewer letters than
4293 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
4294 (inp_nval) Made static.
4296 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
4297 tokstr_len, toklongstr, tokint) Move here.
4299 * misc.c: Lost several vars and functions.
4301 * set.q: (all the set_* variables) Move here.
4303 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
4304 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
4307 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
4309 * tab.h: (enum series t_*) New enums.
4310 (struct tab_table) Use arena struct tag. New members ce, re.
4312 * tokens.h: Comment fixes.
4314 * var.h: Move lots of enums and variables and functions and
4315 structures to other files. Use and declare a lot more union and
4316 struct tags. Comment fixes.
4318 * vector.c: (glob vars vec, nvec) Move here.
4320 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
4321 init_blanks, last_vfm_invocation) Move here.
4323 * cases.h: New file.
4324 (struct long_vec) Move here.
4325 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
4328 * command.h: New file.
4329 (STATE_* enums) Move here.
4330 (glob var pgm_state) Move here.
4332 * format.c: New file.
4333 (glob var formats) Move here.
4334 (parse_format_specifier_name, fmt_to_string,
4335 check_input_specifier, check_output_specifier,
4336 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
4339 * format.h: New file. Move functions now in format.c here.
4340 (FMT_* enums) Move here.
4341 (struct fmt_desc) Move here.
4342 (FCAT_* enums) Move here.
4343 (struct fmt_spec) Move here.
4344 (glob vars formats, fmt_parse_ignore_error) Move here.
4346 * inpt-pgm.h: New file.
4347 (INP_* enums) Move here, make #defines into enums.
4348 (glob vars inp_init, inp_init_size) Move here.
4351 (glob vars v_sort, nv_sort) Move here.
4352 (sort_cases, read_sort_output) Move here.
4354 * vector.h: New file.
4355 (struct vector) Move here, add struct tag.
4356 (glob vars vec, nvec) Move here.
4357 (find_vector) Move here.
4360 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
4361 reinit_blanks, init_zero, init_blanks) Move here.
4362 (struct case_stream) Move here.
4363 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
4364 vfm_disk_stream, sort_stream, data_list_source,
4365 input_program_source, file_type_source, get_source, n_lag) Move
4367 (procedure, write_case, lagged_case, compact_case, page_to_disk)
4370 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
4372 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
4373 (LDADD) Add libdcdflib.
4375 * ascii.c: Comment and formatting fixes. Almost every external
4376 function had an assert added, checking driver_open and page_open.
4377 (ascii_init_driver) Broken into ascii_preopen_driver,
4378 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
4379 (ascii_open_page) Sets page_open.
4380 (ascii_close_page) Clears page_open.
4382 * html.c: Comment and formatting fixes. Almost every external
4383 function had an assert added, checking driver_open and page_open.
4384 (html_init_driver) Broken into html_preopen_driver,
4385 html_postopen_driver, html_close_driver. Manages driver_open.
4386 (html_open_page) Sets page_open.
4387 (html_close_page) Clears page_open.
4388 (html_submit) Disabled.
4390 * lexer.c: (parse_string) Remove debugging printf.
4392 * list.q: (determine_layout) Open a page if one is not yet open.
4394 * output.c: Comment fixes.
4395 (add_class) Set the class member of the new list element.
4396 (parse_options) Don't handle device type.
4397 (colon_tokenize) New function.
4398 (configure_driver) New four-field format with a field for device
4399 type. Now initialize driver_open, page_open, next, and prev
4400 fields. Use new colon_tokenize() function. Don't do a memory
4401 copy to replace a driver, it doesn't work; instead delete the old
4402 driver and insert a new one.
4403 (destroy_driver) Don't call som_destroy_driver(). Close the page
4404 if it's open. Find the class in the list of classes and decrement
4405 that reference count. Remove the driver from the global driver
4407 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
4408 references changed. Rewritten. Don't return a driver that's not
4410 (outp_eject_page) All references to som_internal_eject_page()
4411 changed to use this. Sets cp_x to 0 as well as cp_y.
4413 * output.h: (OUTP_I_* enums) Removed.
4414 (struct som_submission_form) Removed.
4415 (struct outp_class) init_driver broken into preopen_driver,
4416 postopen_driver, and close_driver. submit changed to take a
4419 * postscript.c: Comment and formatting fixes. Almost every
4420 external function had an assert added, checking driver_open and
4422 (ps_init_driver) Broken into ps_preopen_driver,
4423 ps_postopen_driver, ps_close_driver. Manages driver_open.
4424 (ps_open_page) Sets page_open.
4425 (ps_close_page) Clears page_open.
4427 * som.c: New file, base implementation.
4429 * som.h: (struct som_table) Add struct tag.
4430 (enum SOM_COL_ACROSS) Removed.
4431 (SOM_ROWS, SOM_COLUMNS) New enums.
4432 (struct som_table_class) Add member `cumulate'. Remove `segment';
4433 change `render' arguments.
4434 (struct som_point, struct som_rect) Removed.
4435 (som_submit_table) Fixed typo, should have been som_submit.
4437 * sysfile-info: (describe_variable) Don't try to insert a
4438 subtable; just destroy it for now.
4440 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
4441 references to value labels.
4443 * tab.c: (tab_destroy) New function.
4444 (tab_columns) Change argument.
4445 [0] (tab_submit) Remove dead code.
4446 (tab_title) Allocate string from the table's arena.
4447 (tab_output_text) Only free the buffer if we allocated it.
4448 (tab_submit) New function.
4449 (static vars t, d) New static vars.
4450 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
4451 tabi_headers, tabi_cumulate, tabi_render) New functions.
4452 (glob var tab_table_class) New global var.
4454 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
4455 encapsulate the rectangle. All references changed.
4457 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
4459 * All header files updated to use struct tags in addition to
4460 typedefs for all structures. Don't use word `struct' in struct
4463 * Makefile.am: (pspp_SOURCES) Remove html.c.
4464 (INCLUDES) Replace the lib/* includes with a single lib/ include;
4465 all references updated.
4467 * command.c: (parse_cmd) Remove call to som_check_workspace.
4468 (output_line) Update to new som.
4470 * data-in.c: (parse_numeric) A single dot is not an error; it is
4471 the system-missing value.
4473 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
4476 * data-out.c: Added `const' as appropriate to many prototypes.
4477 (convert_E, convert_F, convert_CCx) Take double argument instead
4478 of value * argument.
4479 (convert_format_to_string) Call changed functions appropriately.
4480 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
4481 make a local copy of the value.
4483 * descript.q: Remove custom_variables() prototype now provided by
4485 (custom_variables) Don't increment sbc_variables, the caller does
4487 (dump_z_table, display) Update to new som.
4489 * error.c: (vmsg) Add const to prototype. Remove code to handle
4490 `too many errors' condition.
4491 (check_error_count) New function.
4492 (msg) Add const to prototype.
4494 * filename.c: (open_file) Rewrite for elegance.
4496 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
4497 (dump_full, dump_condensed, dump_statistics) Update for new som.
4499 * list.q: Don't include somP.h. Change all references to
4500 som_driver_ext to refer to the new members of som_driver. Change
4501 som_internal_eject_page() references to outp_eject_page().
4503 * main.c: (parse) Rewrite for elegance. Add call to
4504 check_error_count().
4506 * output.c: (add_class, outp_list_classes, outp_configure_driver)
4507 Rewrite or revise for new outp_driver_class_list structure.
4508 (outp_iterate_enabled_drivers) Fix comparison between disabled
4509 devices and current device type.
4510 (outp_eject_page) New function.
4512 * output.h: Comment fixes.
4513 (struct outp_driver) New members driver_open, page_open, cp_x,
4514 cp_y, font_height, prop_em_width, fixed_width. Deleted members
4516 (struct outp_driver_class_list) New struct.
4517 (outp_class_list) Changed to type outp_driver_class_list; all
4520 * print.c: (dump_table, print_trns_proc) Updated for new som.
4522 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
4523 prototypes for custom subcommands.
4524 (dump_subcommand) Always include the `else'.
4525 (dump_parser) Fix comments in output code.
4527 * set.q: Reordered functions.
4529 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
4531 * som.h: Rewritten from scratch.
4533 * str.h: Remove dead code.
4535 * tab.c, tab.h: New files, base implementation.
4537 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
4540 * t-test.q: New code from John Williams
4541 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
4542 Many many new static vars and defines.
4543 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
4544 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
4545 (struct value_list) New struct.
4546 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
4547 t_crt, t_sig, print_t_groups) New functions.
4548 (cmd_t_test) Implemented.
4550 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
4553 * vfm.c: (dump_splits) Update to new som.
4555 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
4557 * Makefile.am: (fiasco_SOURCES) Add html.c.
4559 * aggregate.c: Base source.
4561 * ascii.c: (postopen, preclose) Reformat.
4563 * data-out.c, expr-evl.c: Comment fixes.
4565 * filename.c: (open_file) When opening a file for writing, use
4566 line buffering instead of full buffering for better interactive
4567 performance. Suggested by Valerio Aimale
4568 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
4569 names `stdin', `stdout', `stderr'.
4571 * groff-font.c: Comment fixes.
4573 * html.c: New file; base version.
4575 * list.q: (write_all_headers, clean_up, determine_layout,
4576 list_cases) Ignore `special' devices for now. Needs to be fixed
4579 * output.c: (outp_init) Add html driver to list; reverse list
4582 * output.h: (struct outp_class_struct) New members `special',
4583 `submit'; comment fixes. All references changed.
4585 * postscript.c: (ps_init_driver) Make defaults for text_opt,
4586 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
4588 (postopen) Comment fix.
4589 (preclose) Comment fixes, formatting fixes. Change x->file.file
4590 references to more proper f->file.
4592 * som-high.c: (som_submit_table) Special classes use their own
4595 * som.h: Comment fixes.
4597 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
4600 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
4602 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
4604 * aggregate.c: Still working on this.
4606 * command.c: (cmd_table[]) Add AGGREGATE back in.
4607 (split_words) Make '-' a legal word separator as well as ' '.
4609 * main.c: Comment fixes.
4611 * q2c.c: (dump_parser) Don't require the procedure's full name to
4612 be present, in the generated source.
4614 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
4615 multiply specified and let it be default; let MISSING, CRITERIA,
4616 FORMAT be multiply specified.
4617 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
4618 (custom_groups) Fix defaults.
4619 (custom_pairs) Check whether this is a PAIRS subcommand before
4620 attempting to parse. Better garbage collection. Proper storage
4622 [DEBUGGING] (debug_print) New function.
4624 * temporary.c: Comment fixes.
4625 (copy_variable) Don't copy variable name and index.
4626 (save_dictionary) Copy variable name and index by hand.
4628 * vars-atr.c: Comment fixes.
4629 (create_variable) New dictionary argument. All references
4631 (common_init_stuff) New dictionary argument. All references
4633 (init_variable) New dictionary argument. All references changed.
4634 (dup_variable) New function.
4636 * vars-prs.c: (parse_variables) If there are any errors, we always
4637 return 0. Previously, it was possible for some types of errors to
4640 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
4642 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
4645 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
4647 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
4650 * q2c.c: Comment fixes.
4651 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
4653 * t-test.q: (cmd_list) Rename cmd_t_test.
4655 * temporary.c: (new_dictionary) Don't declare as static.
4657 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
4659 * aggregate.c: Changes, still not finished.
4661 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
4663 * q2c.c: Comment fixes. Now its output is internationalized.
4664 (get_token) Fix parsing of escapes within literal strings.
4665 (main) Fix bad #line directives in output.
4667 * t-test.q: Base implementation.
4669 * temporary.c: (new_dictionary) New function.
4670 (restore_dictionary) [__CHECKER__] Change fill character to *
4673 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
4675 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
4677 * aggregate.c: Changes, still not finished.
4679 * descript.q, list.q: Comment fixes.
4681 * q2c.c: Almost completely rewritten.
4683 * t-test.q: New file, not complete.
4685 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
4687 * aggregate.c: Changes, still not finished.
4689 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
4692 * temporary.c: (cancel_temporary) New function.
4694 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
4695 of doing it by hand.
4697 * vfm.c: (close_active_file) After restoring a TEMPORARY
4698 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
4700 (SPLIT_FILE_procfunc) Comment fix.
4702 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
4704 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
4706 * aggregate.c: New file, not finished yet.
4708 * command.c: (cmd_table) Add AGGREGATE.
4710 * common.h: (pgm_state) Move declaration to var.h.
4712 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
4714 (parse_string) Message fix.
4716 * recode.c: Comment fix.
4718 * sfm-read.c: (read_variables) Code esthetic fixes.
4719 (write_header) Default date is `Jan', not `JAN'.
4721 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
4723 * sort.c: (cmd_sort_cases) Farm the work out to new function
4724 parse_sort_variables().
4725 (parse_sort_variables) New function.
4726 (sort_cases) New function. Cancels temporary transformations,
4727 which sorting didn't do previously.
4728 (cmd_sort_cases) Better garbage collection on error. Uses
4730 (write_initial_runs, merge_once) Improved code esthetics.
4731 (sort_stream_read) Reduced to one call to read_output_cases().
4732 (read_output_cases) New function.
4734 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
4735 variable labels to 120 characters.
4737 * var.h: Comment fixes.
4738 (glob var pgm_state) From common.h.
4740 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
4742 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
4743 options. Set *names to NULL on error.
4745 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
4747 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
4749 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
4750 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
4752 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
4754 * vfm.c: (page_to_disk) Added missing local variables.
4756 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
4758 * get.c: Comment fix.
4760 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
4761 source is anything other than a disk stream, not just if it's in a
4762 memory stream. Call page_to_disk() before external sort.
4763 (allocate_cases) Message fix.
4765 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
4767 (page_to_disk) New function.
4769 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
4771 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
4773 * common.h: (macro strerror) Remove. From Alexandre Oliva
4774 <oliva@dcc.unicamp.br>.
4776 * get.c: (dict_delete_run) The number of variables to delete is
4777 not necessarily the number of variables that need to be shifted
4779 (trim_dictionary) Don't set *options to 0. Fix bug that caused
4780 too many variables to be deleted.
4782 * postscript.c: Comment fix.
4784 * q2c.c: Include strerror.c. From Alexandre Oliva
4785 <oliva@dcc.unicamp.br>.
4787 * set.q: #undef ON and OFF. From Alexandre Oliva
4788 <oliva@dcc.unicamp.br>.
4790 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
4791 early, otherwise errors cause a bad free().
4793 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
4794 Oliva <oliva@dcc.unicamp.br>.
4796 * temporary.c: (save_dictionary) Don't allocate memory if
4799 * vfm.c: (memory_stream_write) Message fix.
4801 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
4803 * command.c: (static var cmd_table[]) Define REPEATING DATA
4806 * common.h: Added support for broken systems that are missing
4807 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
4809 * Many source files: Replace syntax error messages via msg() with
4810 call to syntax_error().
4812 * data-list.c: (dump_fixed_table) Add support for dumping table
4813 for REPEATING DATA as well as DATA LIST FIXED.
4814 (cmd_repeating_data) Allows and requires `/' between subcommands.
4815 Does proper thing with allowing rpd.starts_end to stay 0. Allows
4816 CONTINUED specifications to be omitted. Forces CONTINUED to be
4817 specified if ID is. Calculates starts_end, cont_end from logical
4818 record length as reported by fhp. Calls dump_fixed_table() if
4819 requested. Fixed length of record copied by memcpy.
4820 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
4822 (realize_value) Returns sensible value for out-of-range variable
4824 (rpd_parse_record) New argument `ofs'. Fixed confusion between
4825 length of occurrences and length of line. Added warning for
4826 fields that exceed the line length. Fixed infinite loop.
4827 (read_one_set_of_repetitions) Numerous minor changes for more
4828 complete SPSS compliance. Message fixes.
4830 * dfm.c: (dfm_close) If the file being closed is the inline file,
4831 read all the remaining data before closing it.
4832 (dfm_get_record) Don't close the file on lossage, as either it
4833 has been closed already or it doesn't belong to us.
4835 * error.c: (puts_stdout) New function.
4836 (vmsg) Use puts_stdout instead of puts.
4838 * file-handle.q: (fh_record_width) New function.
4840 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
4843 (input_program_source_read) Made an old kluge an approved method.
4845 * lexer.c: (syntax_error) New function.
4847 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
4850 * output.c: (oupt_get_paper_size) Message fix.
4852 * q2c.c: Numerous fixes to formatting of generated code made to
4853 conform to GNU coding standards. Uses syntax_error() in generated
4854 code. Other miscellaneous generated message fixes. Added support
4855 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
4856 RAND_MAX, and/or strerror().
4858 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
4860 * data-in.c: Comment fixes.
4862 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
4863 (find_variable_input_spec) New function.
4864 (cmd_repeating_data) Initializes id_spec.
4865 (rpd_parse_record) Implemented.
4866 (read_one_set_of_repetitions) Returns -3 by default in order to
4867 kluge out some potential bugs.
4869 * data-out.c: Comment fixes.
4871 * file-type.c: (internal_cmd_record_type) Message fix.
4873 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
4874 for handling -3 return value.
4876 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
4878 * data-list.c: Comment fixes.
4879 (struct dls_var_spec) Reordered members.
4880 (read_from_data_list_fixed) Restructured.
4881 (struct repeating_data_trns) Reordered members. Renamed `starts'
4882 as `starts_beg', `ends' as `starts_end'.
4883 (cmd_repeating_data) Calculates length of repeated data if
4884 necessary and possible.
4885 (parse_num_or_var) Don't allow string variables.
4886 (realize_value) New function.
4887 (rpd_msg) New function.
4888 (rpd_parse_record) New function. Currently stubbed out.
4889 (read_one_set_of_repetitions) Implemented.
4891 * inpt-pgm.c: (input_program_source_read) Comment fix.
4893 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
4895 * command.c: (cmd_end_repeat_p) Removed.
4896 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
4897 (parse_cmd_name) Removed.
4899 * data-list.c: Comment fixes.
4900 (data_list_pgm) Removed `eof' member.
4901 (static var first) New var.
4902 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
4903 FILE TYPE file inside FILE TYPE structures.
4904 (append_var_spec) Appends to *first, not dls.spec.
4905 (parse_fixed) Message fixes.
4906 (struct rpd_num_or_var) New.
4907 (struct repeating_data_trns) New.
4908 (static var rpd) New.
4909 (cmd_repeating_data) New function.
4910 (parse_num_or_var) New function.
4911 (parse_repeating_data) New function.
4912 (read_one_set_of_repetitions) New function.
4914 * file-type.c: (cmd_file_type) Message fixes. Always
4915 default_handle to FILE TYPE file handle.
4916 (internal_cmd_record_type) Message fixes.
4918 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
4920 * repeat.c: Comment fix. Disable debugging.
4922 * temporary.c: (restore_dictionary) Sets splits to NULL and
4923 n_splits to 0 before destroying the variables because now doing
4924 this tries to remove split variables.
4926 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
4927 destroying the dictionary.
4928 (clear_variable) Removes a variable from splits after destroying
4931 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
4933 * cmdline.c: (set_compat) Removed.
4934 (pick_compat) Removed.
4935 (parse_command_line) Removed -c option.
4936 (pre_syntax_message) Removed -c option.
4937 (usage) Remove compatibility code.
4939 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
4940 (glob var compat) Removed.
4942 * compute.c: (type_check) Fixed messages about type mismatches.
4944 * data-list.c: (cmd_data_list) Removed compatibility code.
4945 (fixed_parse_compatible) Calls convert_negative_to_dash().
4946 Fixed bug where it only set the variable in fx.spec if it created
4947 the variable itself.
4948 (dump_fmt_list) Spelling fix.
4949 (cut_field) Removed compatibility code.
4951 * dfm.c: (cmd_begin_data) Don't require a command terminator on
4954 * expr-evl.c: (evaluate_expression) Implement LAG.
4956 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
4957 (parse_neg) Calls convert_negative_to_dash().
4958 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
4961 * expr.h: (struct expression_struct) Removed member max_lag.
4963 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
4964 (internal_cmd_record_type) Removed special handling to produce
4965 negative numbers from dash tokens.
4967 * getline.c: (static var DO_REPEAT_level) New var.
4968 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
4969 (handle_line_buffer) Copies the line into getl_buf; doesn't call
4970 copy_with_DO_REPEAT_substitutions().
4971 (getl_read_line) Maintains value of getl_mode. Calls
4972 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
4974 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
4976 * getline.h: (getl_mode) New glob var.
4978 * glob.c: Comment fixes.
4979 (init_glob) Restructured. Sets set_seed.
4980 (init_compat_dependent) Removed. All references removed.
4981 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
4982 (__htonl, __htons) Removed. (What were these for?)
4984 * lexer.c: (static var tbl) Dash set to class CNUM.
4985 (make_hexit) New function from data-out.c.
4986 (get_token_representation) Rewritten.
4987 (convert_negative_to_dash) New function.
4988 (lex_init_compat_dependent) Removed.
4989 (yylex) A dash is parsed as part of a number if it is followed by
4990 a digit. The ASCII representation of a number is copied to
4991 tokstr. String parsing farmed out to parse_string(). Comment
4993 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
4995 (preprocess_line) Line processing depends on interactive/batch
4996 mode, not on compatibility mode. Removed PC+ compatibility code.
4998 * loop.c: (loop_3_trns_proc) Comment fix.
5000 * main.c: Remove dead code.
5001 (main) Remove call to init_compat_dependent().
5003 * misc.c: (convert_fmt_ItoO) Make E format conversion more
5006 * print.c: (parse_string_argument) Calls
5007 convert_negative_to_dash().
5008 (fixed_parse_compatible) Calls convert_negative_to_dash().
5010 * repeat.c: (RPT_* defines) Removed.
5011 (struct rpt_numeric) Removed.
5012 (struct repeat_entry) New member type, changed `replacement' from
5014 (clean_up) Deallocation adapted to new repeat_entry.
5015 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
5016 usage. Creates vars for `type' of 1.
5017 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
5018 (store_numeric) Rewritten, new interface.
5019 (parse_numbers) Rewritten.
5020 (parse_strings) Rewritten.
5021 (find_DO_REPEAT_substitution) New function.
5022 (perform_DO_REPEAT_substitutions) New function.
5023 (copy_with_DO_REPEAT_substitutions) Removed.
5024 (debug_print) Rewritten.
5026 * set.q: Comment fix.
5027 (custom_results) Removed compatibility code.
5028 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
5031 * sysfile-info.c: (cmd_display) Removed compatibility code.
5033 * tokens.h: Comment fixes.
5034 (token types enum) Removed `toktype' typedef name for this int
5035 type. Removed SUBST. Restructured.
5037 * vars-atr.c: (discard_variables) Sets n_lag to 0.
5039 * vars-prs.c: Comment fix.
5041 * vfm.c: Comment fixes.
5042 (glob var n_lag) New var.
5043 (static vars lag_count, lag_head, lag_queue) New vars.
5044 (procedure) Removed argument nlag.
5045 (setup_lag) New function.
5046 (close_active_file) Discards lagging state.
5047 (lag_case) New function.
5048 (lagged_case) New function.
5049 (write_case) Lags a case if lagging.
5051 * weight.c: (cmd_weight) Removed compatibility code.
5053 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
5055 * getline.h: (struct getl_script) New members loop_index, macros.
5057 * getline.c: (getl_add_file) Sets first_line field to NULL.
5058 (getl_add_DO_REPEAT_file) New function.
5059 (handle_line_buffer) When the current line's length is negative,
5060 set the filename and line number. Increment line number after
5061 reading line. Pass the line to
5062 copy_with_DO_REPEAT_substitutions() for processing.
5063 (getl_close_file) Free DO REPEAT lines before freeing the
5064 filename, and just set the filename to NULL when doing this,
5065 because otherwise the filename gets freed twice.
5067 * glob.c: (glob var queuing) Removed. All references removed.
5069 * lexer.c: Comment fixes.
5070 (get_token_representation) New function.
5072 * repeat.c: Comment fixes.
5073 (struct repeat_entry) Replaced type and v union members with a
5075 (append_record) New function.
5076 (internal_cmd_do_repeat) Started reforming it for the new
5077 repeat_entry struct. Properly records filename changes in the
5078 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
5079 strncasecmp() result usage. Uses append_record() to simplify.
5080 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
5083 (copy_with_DO_REPEAT_substitutions) Started coding.
5085 [DEBUGGING] (debug_print_lines) New function.
5087 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
5089 * tokens.h: (macro is_id1, is_idn) New macros.
5091 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
5093 * cmdline.c: (static var pre_syntax_message) Changed `win'
5094 compatibility mode to `wnd'.
5096 * data-list.c: (fixed_parse_spss) Renamed
5097 fixed_parse_compatible().
5099 * glob.c: (init_glob) Excise unused code for
5100 program_invocation_short_name.
5102 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
5105 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
5107 * set.q: `win' compatibility renamed `wnd'.
5109 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
5111 * filename.c: [__WIN32__] Change the included Windows header files
5113 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
5114 second character is absolute.
5115 (dirname) Fix logic error. Don't printf() the results.
5116 (prepend_dir) Don't printf() the results.
5118 * getline.c: (handle_line_buffer) New function.
5119 (getl_read_line) Reads line with handle_line_buffer() when
5121 (getl_close_file) Discard line buffer data.
5123 * getline.h: Comment fixes.
5124 (struct getl_line_list) New struct.
5125 (getl_script_struct) Added line buffer members. These are hooks
5126 for use by DO REPEAT to allow it to insert virtual source code
5129 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
5130 Override Borland C++ stupidity that claims Windows has a console
5133 * repeat.c: This is in the process of being restructured from
5134 using a token-buffering approach to the DO REPEAT facility to
5135 using the more flexible approach of a line-buffering approach in
5136 conjunction with the getline module. Comment fixes.
5137 (struct tok_struct) Removed.
5138 (static vars queue_index, queue_head, queue) Removed.
5139 (static vars line_buf_head, line_buf_tail) New vars.
5140 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
5142 (pull_queue, destroy_queue) Removed.
5143 [DEBUGGING] (debug_print_tokens) Removed.
5145 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
5147 * file-handle.q: (prepend_current_directory) New function.
5148 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
5149 current directory before normalizing filename.
5151 * filename.c: (gnu_getcwd) New function.
5152 (absolute_filename_p) New function.
5153 (search_path) New argument, PREPEND. All references changed to
5154 pass NULL except those explicitly mentioned. Uses
5155 absolute_filename_p(). Prepends PREPEND before trying the
5157 (dirname, prepend_dir) New functions.
5159 * getline.c: (getl_get_current_directory) New function.
5160 (getl_include) Passes getl_get_current_directory() as PREPEND arg
5163 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
5165 * In several source files, the term `script' was replaced with
5166 `syntax file' inside error messages. Usage of the term `script'
5167 in the sense of a syntax file is now deprecated.
5169 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
5172 * dump-sysfile.c: (usage) Update message.
5174 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
5176 * getline.h: (glob var getl_include_path) Declare extern.
5178 * list.q: Define EXTERN as extern before #including somP.h.
5180 * var.h: Remove declaration of `disptype' variable.
5182 * vfm.c: (close_active_file) After switching the data sink to a
5183 data source, set vfm_sink to NULL, because it doesn't exist any
5186 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
5188 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
5189 _matherrl() to ignore all math errors.
5191 * sfm-read.c: (read_value_labels) When reading the labels from
5192 disk, read the little parts separately instead of as a struct;
5193 this avoids alignment problems.
5195 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
5196 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
5197 (write_header) Allocates and initializes elem_type.
5198 (sfm_write_case) Uses elem_type to determine how to handle each
5200 (sfm_close) Frees elem_type.
5202 * sfmP.h: Comment fix.
5203 [__BORLANDC__] Uses #pragma -a to adjust structure member
5206 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
5208 * Makefile.am: (fiasco_SOURCES) Remove display.c.
5210 * common.c: Fix typo.
5212 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
5213 sense of the condition.
5215 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
5216 line-continuation backslash.
5218 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
5220 * frequencies.q: (custom_grouped, add_percentile) Don't use a
5221 non-constant expression as an argument to sizeof.
5223 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
5224 undefine gettext macro because that's a conio function.
5226 * hash.h: (hsh_prime_tab declaration) Remove.
5228 * list.q: (write_fallback_headers) Move `leader' allocation out of
5229 main loop. Change to local_alloc() allocation.
5231 * output.h: Formatting fixes. Put __attribute__ in right place on
5232 function prototypes.
5234 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
5235 incorrect `SECOND_LOWEST_VALUE' references to proper
5236 `second_lowest_value'.
5238 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
5239 value. This way 2 out of 3 of the som files define the vars
5240 extern, the correct way, that actually works under BC++.
5241 (som_set_float) Don't use nonconstant initializers for a struct.
5243 * som-high.c: Add the standard alloca() header.
5244 (replicate_table) Add prototype.
5246 Merged DISPLAY routine.
5247 * sysfile-info.c: (AS_*) New enum series.
5248 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
5250 (cmd_display, display_macros, display_documents,
5251 display_variables) Stolen from defunct display.c.
5252 (describe_variable) New function.
5254 * temporary.c: [0] (display_tree) New debug function.
5255 (copy_variable) Performs shallow copy of value labels instead of
5256 deep copy; i.e., just copys the AVL tree and increments the
5259 * val-labs.c: Comment fixes.
5260 (do_value_labels) Optionally skip leading forward slash.
5261 (get_label) Creates only a single value label instead of many
5262 copies of one, and sets the reference count.
5264 * display.c: Removed.
5266 * dump-sysfile.c: New file, not yet complete.
5268 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
5270 For lots of source files I added more verbose_msg's. These aren't
5271 listed below as they have tested as being benign. In some cases
5272 these replaced debug_printf() calls.
5274 * output.c: (outp_read_devices) Message fix.
5276 * postscript.c: (output_encodings) Message fix. Reports errors on
5278 (postopen) Message fix.
5280 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
5282 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
5284 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
5287 * main.c: Remove <malloc.h> #include.
5289 * mis-val.c: (parse_numeric) Set .f member for each missing[]
5290 instead of trying to just set the missing[] itself, which is a
5293 * sfm-read.c: (read_variables) Same.
5295 * str.h: Add memmem() prototype.
5297 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
5299 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
5301 * Makefile.am: (q2c) Don't include any libraries in the link.
5303 * dfm.c: (force_line_buffer_extension) New macro.
5304 (count_tabs) New function.
5305 (tabs_To_spaces) New function.
5306 (read_record) Calls tabs_to_spaces() on the line being processed.
5308 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
5309 have to be compiled twice (once for CC, once for LOCAL_CC).
5311 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
5313 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
5314 (LDADD) Add @INTLLIBS@.
5315 (q2c) Add LIBS, @INTLLIBS@ to link step.
5317 * inpt-pgm.c: Turn off debugging.
5319 * postscript.c: (postopen) Format fix. local_free() blocks
5320 returned by local_alloc(); don't free() them.
5322 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
5324 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
5327 * data-list.c: (read_from_data_list_fixed) Pass proper value for
5328 LEN arg, not simply the full string length.
5330 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
5331 directories before generic temp file directories.
5333 * vfm.c: Disable debugging.
5335 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
5337 * get.c: Comment fix.
5338 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
5340 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
5342 * expr-prs.c: (debug_print_postfix) Conditionally included on
5343 GLOBAL_DEBUGGING. Removed out_header() reference.
5345 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
5347 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
5349 * ascii.c: Removed obsolete ascii_close_page() prototype.
5351 * command.c: (output_line) Comment fix.
5353 * data-in.c: Formatting fix.
5354 (parse_string_as_format) Now the `fc' argument is used only for
5355 the purpose of error messages; it is not an index into the string
5356 passed. All references changed.
5358 * data-list.c: Comment fix.
5359 (cut_field) Comment fix. Now returns the column number of the
5360 position of the field cut out on success.
5361 (parse_field) Added `column' argument. Puts the column numbers in
5363 (read_from_data_list_free, read_from_data_list_list) Record the
5364 column number returned by cut_field(), pass it to parse_field().
5366 * dfm.c: Comment fix.
5368 * do-ifP.h: Comment fix.
5370 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
5371 the SYSMIS function.
5373 * expr.h, exprP.h: Comment fix.
5375 * glob.c: (init_glob) Only calls setlocale() and family if
5378 * hash.h: Comment fix.
5380 * include.c: Comment fix.
5382 * output.c: Comment fix.
5384 * postscript.c: (ps_line_intersection) Simplified assertion.
5386 * repeat.c: Comment fix.
5388 * vars-atr.c: Comment fix.
5390 * vars-prs.c: Comment fix.
5392 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
5393 behavior with usage of postincrement.
5394 (memory_stream_read) Discards cases as it goes.
5396 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
5398 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
5401 * Most source files: Includes debug-print.h, related comment
5404 * cases.c: (alloc_val) Removed complex allocation code. Merely
5405 increments default_dict.nval and returns the former value.
5406 (envector, devector) Removed references to lv member of struct
5409 * common.h: (macro VME) Replaced complex definition with simple
5412 * data-list.c: (cmd_data_list) Sets vfm_source instead of
5413 read_active_file and cancel_input_pgm.
5414 (read_from_data_list, cancel_data_list) Removed.
5415 (data_list_source_read, data_list_source_destroy_source) New
5417 (glob var data_list_source) New var.
5419 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
5420 (cmd_begin_data) Improved criteria for an input program accessing
5421 the inline file. Still not perfect.
5423 * do-if.c: (do_if_trns_proc) Simplified debug output.
5425 * expr-prs.c: Comment fixes.
5426 [DEBUGGING] (debug_print_postfix) Simplified debug output.
5428 * file-handle.q: (fh_close_handle) Simplified debug output.
5430 * file-type.c: Comment fixes.
5431 (cmd_file_type) Sets vfm_source instead of read_active_file and
5433 (cmd_end_file_type) On failure, discards variables in place of
5434 just canceling the input program.
5435 (read_from_file_type) Renamed file_type_source_read.
5436 (cancel_file_type) Renamed file_type_source_destroy_source.
5437 (glob var file_type_source) New var.
5439 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
5440 (cmd_get) Initializes options to GTSV_NONE before passing to
5441 trim_dictionary(). Removed `lv' reference. Sets vfm_source
5442 instead of read_active_file and cancel_input_pgm.
5443 (cmd_save_internal) Initializes options before passing to
5444 trim_dictionary(). Local var `nval' removed.
5445 (dict_delete_run) Comment fixes.
5446 (trim_dictionary) Comment fixes. Disallows scratch variables if
5447 GTSV_OPT_SAVE set in options.
5448 (read_from_get) Renamed get_source_read.
5449 (cancel_get) Renamed get_source_destroy_source.
5450 (glob var get_source) New var.
5452 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
5453 read_active_file and cancel_input_pgm.
5454 (read_from_input_program) Renamed input_program_source_read.
5455 Simplified debug output.
5456 (cancel_input_program) Renamed
5457 input_program_source_destroy_source.
5458 (glob var input_program_source) New var.
5460 * loop.c: (loop_1_trns_proc) Simplified debug output.
5462 * main.c: (dump_token) Made eof output more explicit.
5464 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
5467 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
5468 code for always-memory or always-disk cases. malloc's case-list
5469 based on vfm_source_info.ncases. Explicit support for
5470 memory_stream via memory_source_cases.
5471 (do_external_sort) Sets vfm_source instead of read_active_file and
5473 (allocate_file_handles) The temporary directory permissions are
5474 set to 0700 instead of 0777.
5475 (allocate_cases) Formatting fixes. Simplified debug output.
5476 (output_record) Compacts the case if necessary before writing it
5478 (close_handle, open_handle_w) Simplified debug output.
5479 (write_initial_runs) Destroys vfm_sink, then sets it to
5480 sort_stream. Writes records to memory based on
5481 vfm_sink_info.case_size.
5482 (write_to_sort_cases) Renamed sort_stream_write().
5483 (merge) Simplified error handling. Simplified debug output.
5485 (read_from_external_sort) Renamed sort_stream_read().
5486 Reads records based on vfm_source_info.case_size.
5487 (sort_stream_write) Writes records to memory based on
5488 vfm_sink_info.case_size.
5489 (sort_stream_mode) New function.
5490 (glob var sort_stream) New variable.
5492 * temporary.c: (cmd_temporary) Simplified debug output.
5493 (copy_variable) Removed references to `lv'.
5495 * title.c: (get_title) Simplified debug output.
5497 * var.h: Comment fixes.
5498 (struct get_proc) Removed member `lv'.
5499 (struct variable) Removed member `lv'. Comment fixes.
5500 (glob vars read_active_file, write_active_file, cancel_input_pgm)
5502 (struct case_stream) New.
5504 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
5505 read_active_file references to use vfm_source.
5506 (init_variable, replace_variable) Removed references to `lv'.
5508 * vfm.c: Comment fixes.
5509 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
5511 (static var queue, qh, qt, n_lag) Removed. All references
5513 (glob var compaction_necessary, compaction_nval, compaction_case,
5514 paging) New variables.
5515 (record_case) Removed.
5516 (procedure) Comment fixes. Calls vfm_source->read() instead of
5519 (prepare_for_writing, arrange_compaction, make_temp_case,
5520 vector_initialization, setup_filter) New function.
5521 (open_active_file) Most of the code moved into the abovementioned
5522 new functions. Now sets temp_dict to &default_dict if there is no
5523 temporary dictionary, for convenience. New debug output.
5524 (close_active_file) Deals with changing the sink to the source.
5525 Calls finish_compaction(). Frees compaction_case. Mostly
5527 (glob vars disk_source_file, disk_sink_file) New vars.
5528 (destroy_active_file, read_from_memory) Removed.
5529 (disk_stream_init, disk_stream_read, disk_stream_write,
5530 disk_stream_mode, disk_stream_destroy_source,
5531 disk_stream_destroy_sink) New functions.
5532 (glob var vfm_disk_stream) New var.
5533 (glob vars memory_source_cases, memory_sink_cases,
5534 memory_sink_iter, memory_sink_max_cases) New vars.
5535 (memory_stream_init, memory_stream_read, memory_stream_write,
5536 memory_stream_mode, memory_stream_destroy_source,
5537 memory_stream_destroy_sink) New functions.
5538 (glob var vfm_memory_stream) New var.
5539 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
5540 named `more_cases'. Simplified debug output. Otherwise mostly
5542 (record_case) Moved into the stream drivers. Removed.
5543 (transform) Removed (was dead code).
5544 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
5545 common case that the splits don't change, we don't need to copy
5546 the case into prev_case again--pointless.
5547 (compact_case) New function.
5548 (finish_compaction) New function.
5550 * vfmP.h: Comment fixes.
5551 (DEV_* enum series) Removed.
5552 (struct storage) Renamed `stream_info'. Removed variant record.
5553 Removed `device' member.
5555 * debug-print.h: New file.
5557 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
5559 * autorecode.c: Turned off debugging.
5561 * data-list.c: (destroy_dls) Closes the associated file handle.
5563 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
5564 parse_variables() options.
5566 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
5568 * display.c: (display_variables) Really fixed null cell bug.
5570 * file-handle.q: (fh_close_handle) Changed debugging message.
5572 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
5573 parse_variables() options.
5575 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
5576 (cmd_list) Fails if no variables specified.
5577 (determine_layout) Writes blank lines manually.
5579 * loop.c: (loop_1_trns_proc) Made debugging code only print
5580 messages if debugging.
5582 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
5583 parse_variables() arguments.
5584 (main) Parses optional parenthesized options to varlist
5585 subcommands into sbc->message.
5587 * sfm-read.c: Format fix.
5589 * var.h: (FV_*) New enum series.
5590 (PV_*) New enum PV_NO_SCRATCH.
5592 * vars-prs.c: (find_var) Removed.
5593 (fill_all_vars) Takes FV_* enum instead of boolean third
5594 argument. Rewritten to deal with scratch as well as system
5596 (parse_variables) Error message on scratch variable if
5599 * vfm.c: (static var virt_begin_func) New var.
5600 (procedure) Sets up virt_begin_func.
5601 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
5602 after dump_splits(). For succeeding groups changes, calls
5603 virt_begin_func() instead of begin_func().
5605 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
5607 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
5610 * dfm.c: Added some debugging messages, disabled by default.
5611 (open_file_r) Fixed error message.
5612 (read_record) On eof on inline_file, instead of calling
5613 fh_close_handle(), simply jump to eof label like a normal file.
5616 * display.c: Thin lines between rows for certain kinds of
5617 listing. Fixed `null cell' bug.
5619 * error.c: (failure) Flush stdout, stderr before failing.
5621 * file-handle.q: (fh_close_handle) Added debugging message.
5623 * frequencies.q: (dump_full) Bottom line extends across entire
5624 table width. Changed title formatting.
5625 (dump_condensed) Changed title formatting.
5626 (dump_statistics) Fixed title formatting.
5628 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
5629 Sets default value of set_format.
5631 * list.q: (cmd_list) Calls blank_line() before determine_layout().
5632 Passes write_all_headers() to procedure() as pre-group func.
5633 (write_all_headers) New function.
5634 (determine_layout) Removed calls to write_header().
5635 Calls blank_line() before and after write_fallback_headers().
5637 * recode.c: (recode_trns_free) Only attempts to free head->map if
5640 * sfm-read.c: (read_variables) Allows `#' at beginning of system
5641 file variable names but gives a warning. Sets `left' based on
5642 first character being/not being `#'. On lossage frees dict->var.
5644 * som-high.c: (som_draw_title) Simplified title formatting.
5646 * vfm.c: (dump_splits) Fixed and changed splits formatting.
5648 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
5650 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
5651 beginning. Frees v_src, v_dest on successful exit. Frees
5652 h_trans[*], h_trans on lossage.
5653 (recode) Frees h_trans[*], h_trans.
5655 * dfm.c: (dfm_close) Formatting change.
5656 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
5657 longer allocates its own in inline_file.
5658 (open_file_r) Passes the local dfm_fhuser_ext to
5660 (open_file_w) Message fix.
5661 (read_record) Buffer reallocation strategy changed. Frees
5662 ext->line even in inline_file to prevent leaks.
5663 (dfm_put_record) Fixed bug where `ext' was cached before the file
5664 was opened and thus it would be NULL when the file really was
5666 (cmd_begin_data) Sets up inline_file basics itself, then calls
5667 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
5669 * list.q: (write_line) Formatting fix.
5670 (clean_up) Minor strategy change. Sets proportional font after
5672 (determine_layout) Sets fixed font before writing regular headers,
5673 or after writing fallback headers.
5675 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
5676 and KEEP vars after using them.
5678 * postscript.c: (ps_init_driver) Frees x->family.
5679 (postopen) When loading fonts, free the temporary font name buffer
5681 (ps_text_set_font_by_position) Free temporary font name buffer
5683 (text) Fixed code that calculated `lig' so that `lig' always gets
5684 initialized. Formatting fix.
5686 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
5688 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
5689 cells, not xmalloc(), so that the cells will get destroyed
5692 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
5695 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
5697 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
5700 * dfm.c: Comment fix.
5702 * list.q: Comment fixes. Include somP.h. Removed static vars
5703 table, n_columns, n_rows, part. New struct list_ext. New static
5705 (n_lines_remaining, n_chars_width, write_line) New functions.
5706 (cmd_list, list_cases) Rewritten.
5707 (begin_row, end_row, flush_table) Removed.
5708 (write_header, clean_up, write_varname, write_fallback_headers,
5709 determine_layout) New functions.
5711 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
5713 * output.h: Comment fix.
5715 * postscript.c: Comment fix.
5716 (struct ps_driver_ext) Removed prop_size, fixed_size members;
5717 added font_size. All references changed.
5718 (ps_init_driver) Initializes font_size. Simplified space checking
5720 (static var option_tab[]) Removed prop-size, fixed-size; added
5722 (ps_option) Handles font_size.
5724 * som-high.c: Moved prototypes into somP.h.
5725 (som_init_driver) New function.
5726 (som_submit_table) Moved some code into new function
5728 (build_target) Moved some code into new function
5729 som_internal_eject_page().
5730 (som_eject_page) Uses som_internal_eject_page().
5731 (som_internal_eject_page) New function.
5733 * som-low.c: Moved prototypes into somP.h.
5735 * som.h: Formatting fixes.
5737 * somP.h: (struct som_driver_ext) Removed em_width;
5738 added prop_em_width, fixed_width.
5740 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
5742 * Makefile.am: Added `localedir' definition. Added
5743 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
5745 * ascii.c: (macro draw_line) Fixed capitalization.
5747 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
5748 compute.c, count.c, data-in.c, data-list.c, data-out.c,
5749 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
5750 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
5751 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
5752 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
5753 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
5754 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
5755 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
5756 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
5757 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
5758 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
5759 for internationlization.
5761 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
5763 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
5765 * do-if.c, sort.c, val-labs.c: Comment fixes.
5767 * glob.c: (init_glob) Uncommented, updated i18n support.
5769 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
5770 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
5771 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
5772 the declarations of macros taking arguments a lot nicer.
5774 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
5776 * error.h: Removed CE, CW aliases for SE, SW.
5778 * q2c.c: Removed explicit streq() definition since it's duplicated
5781 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
5782 stats.h, str.h, tokens.h: Made the declarations of macros taking
5783 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
5786 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
5788 * cmdline.c: Comment fixes.
5789 (pick_compat) Changed return type to int. Now, instead of setting
5790 glob var `compat' to the emulation, returns the emulation. All
5792 (parse_command_line) Added terminating null to end of
5793 `long_options' array definition.
5794 (pre_syntax_message) Fixes.
5795 (usage) Shows the default emulation in the syntax message by
5796 calling pick_compat().
5798 * getline.c: (getl_add_include_dir) Separates paths with
5799 PATH_DELIMITER, not DIR_SEPARATOR.
5801 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
5802 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
5804 * output.c: (outp_configure_macro) Make earlier definitions for a
5805 particular key override later ones for the same key.
5807 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
5809 * ascii.c: Comment fixes.
5811 * output.c: (outp_get_paper_size)
5812 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
5814 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
5816 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
5817 <errno.h>. GNU libc 2 enforces this!
5819 * command.c: (parse_cmd) Fixed problem with `else' clause being
5820 paired with wrong `if'. Comment fix.
5822 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
5824 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
5825 blp_getline() to getline().
5827 * output.c: (outp_eval_dimension) Changed the fix from last time;
5828 there was no variable `a'.
5830 * q2c.c: (get_line) Fixed boundary condition overrun bug.
5832 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
5834 * output.c: (outp_evaluate_dimension) Fixed handling of negative
5835 numbers having fractional parts. Added case of a fraction without
5836 a whole-number part.
5838 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
5840 * ascii.c: (ascii_text_get_font_position) Removed.
5842 * expr.h, exprP.h: Disabled debugging.
5844 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
5847 * output.h: (struct outp_class_struct) Removed
5848 text_get_font_position method. All references deleted.
5850 * postscript.c: Big change here. Fontmaps were completely
5851 eliminated because of a change in philosophy. Comment fixes.
5852 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
5854 (struct ps_driver_ext) `position', `fontmap', `prop_name',
5855 `fixed_name' members removed. New members `prop_family',
5856 `fixed_family'. `family' member changed to type char *.
5857 (static var ps_fontmaps) Removed.
5859 (ps_init_driver) Removed obsolete references, updated.
5860 Initializes `translate_x', `translate_y', `scale'. Doesn't read
5861 fontmap, of course. Refers to font names through internal_name
5862 rather than subversive means. Frees proper items.
5863 (static var option_tab[]) Removed `fontmap-file' option; renamed
5864 `fixed-font', `prop-font'.
5865 (ps_option) Corresponds to option_tab[].
5866 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
5867 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
5868 hash_family) Removed.
5869 (postopen) Generates font names from family names. Gets
5870 PostScript font name properly. New prologue file comment `!!!'
5872 (ps_open_page) Adds translate_x, translate_y to BP prologue
5873 function; gives SF argument floating-point format.
5874 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
5875 font name. Doesn't change font family.
5876 (ps_text_set_font_by_position) Generates Groff font name from font
5877 family name instead of through table lookup.
5878 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
5879 all references changed. Reduced to simple string assignment.
5880 (ps_get_font_name) Removed.
5881 (ps_get_font_family) Reduced to string return.
5882 (text) Doesn't save `position' since it no longer exists. Ugly
5883 kluge to save font family--fix soon?
5884 (load_font) Removed PostScript name argument.
5886 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
5888 * postscript.c: Comment fix.
5889 (ps_open_page) Puts scale factor in PostScript output.
5891 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
5893 * Makefile.am: Distcleans q2c.
5895 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
5897 * ascii.c: (delineate) Sets text size even if width is zero.
5899 * command.c: Comment fix.
5900 (static var cmd_table[]) Re-enabled EVALUATE command.
5901 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
5902 of comments in script files. Now more liberal on criteria for
5903 performing a state transition--if *anything* happened correctly,
5904 not just if *everything* happened correctly.
5906 * data-out.c: (convert_F) Comment fix. Why in the fsck does
5907 Checker segfault on formatting large numbers and why in the fsck
5908 hadn't I noticed this before?
5910 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
5912 * list.q: (cmd_list) Commented out the actual output routine
5913 because of various problems. Probably will abandon the idea of
5914 using the general `crushed tables' for the LIST procedure.
5916 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
5917 clearing it. Allocates a new var_by_name dictionary before trying
5918 to add members to it.
5920 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
5921 `sib'. Changed type of `node' argument.
5922 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
5924 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
5925 [DEBUGGING] Only deletes the variable from var_by_name if that var
5928 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
5930 * Makefile.am: Added include files to SOURCES. Added
5931 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
5932 includes rules for q2c. Added `boast' target.
5934 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
5936 * Makefile.am: Maintainer-clean Makefile.in.
5938 * Makefile.am: Fixed redundant EXTRA_DIST line.
5940 * ascii.c: Comment fixes.
5941 (ascii_line_vert) Fixed overly aggressive range check.
5943 * display.c: Removed dead code.
5945 * list.q: Turn debugging on.
5946 (flush_table) New debug code.
5948 * sfm-read.c: (read_value_labels) malloc's the structure before
5949 trying to assign to its members.
5951 * sfm-write.c: Comment fix.
5953 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
5955 (output_table) No arguments anymore--gets them through `som'
5956 global. New debug code. In crushed tables, now sets `htv' as
5957 well as `hv' to avoid bad confusion later.
5958 (dump_crush_page) New debug code.
5960 * som-low.c: (som_dump_crush_page) New debug code.
5962 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
5964 All source files: Broke long lines into multiple lines.
5966 * ascii.c: (ascii_close_page) Uses host_system var in place of
5967 HOST_SYSTEM constant.
5969 * cmdline.c: (var syntax_message[]) Broke into
5970 pre_syntax_message[] and post_syntax_message[].
5971 (usage) Outputs both parts, separated by driver list.
5973 * error.h: Fixed broken formatting.
5975 * expr-opt.c: (str_search, str_rsearch) New functions.
5977 * misc.c: (blp_getdelim) Removed. All references changed to
5979 (str_search, str_rsearch) Removed.
5980 (memrmem) New function.
5982 * misc.h: (blp_getline) Removed. All reference changed to
5987 * filename.c: Includes "stat.h", not <sys/stat.h>.
5988 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
5990 * output.c: (outp_list_classes) Changed output formatting.
5992 * sfm-write.c: (write_header) Uses host_system var instead of
5993 HOST_SYSTEM constant.
5994 (write_rec_7_34) Extracts version numbers from the version string.
5997 * sort.c: Includes "stat.h", not <sys/stat.h>.
5999 * str.c: (strcasecmp) Removed.
6001 * title.c: (cmd_document) Uses host_system var instead of
6002 HOST_SYSTEM constant.
6004 * version.c: Generated on-the-fly by the Makefile instead of being
6007 * str.h: Comment fixes. Doesn't substitute for missing memmove or
6009 [!HAVE_STRNCASECMP] Declares strncasecmp().
6011 * version.h: Removed stray character. Comment fixes.
6012 (vars host_system, build_system) New vars.
6014 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
6016 * Most source files: Changed formatting of copyright notice; fixed
6017 FSF address; reformatted to better conform to GNU standards;
6018 comment fixes. Added markups to prevent GNU indent from messing
6019 up my beautiful formatting :-).
6021 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
6022 that GNU indent markups can be passed through without problems.
6024 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
6026 * get.c: Turned off debugging.
6028 * glob.c: (init_glob) Turned on save-file compression by default.
6030 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
6031 compression than was possible in save files.
6033 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
6035 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
6037 * frequencies.q: Removed Fiasco extensions. Updated calculation
6038 algorithms. Polished output format.
6039 (struct frq_info_struct) Removed members `max_degree', `min_n',
6040 all references removed.
6041 (macro frq_extensions) Removed.
6042 (static vars min_n, max_degree) Removed, all references removed.
6043 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
6044 calculate `min_n', `max_degree'.
6045 (postcalc) Passes new arg to dump_statistics().
6046 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
6048 (dump_condensed) Adds variable name title.
6049 (sum_freqs) Removed.
6050 (calc_stats) Updated calculation algorithm.
6051 (dump_statistics) Removed warning for too-few observations.
6052 Changed table formatting. Adds variable name title if passed new
6055 * output.h: Comment fix.
6057 * recode.c, sample.c, sort.c: Disabled debug code.
6059 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
6060 Improved debug code.
6062 * var.h: (enum series frq_*) Removed Fiasco extensions.
6064 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
6066 * command.c: Added PROCESS IF to command table.
6068 * Lots & lots of places, removed checks for NULLs preceding calls
6069 to free_expression(), which itself checks.
6071 * descript.q: Removed Fiasco extensions. Removed optimizations
6072 for non-weighted active files. Implemented some options.
6073 Finished polishing output format. Comment fixes. Merged
6075 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
6076 max_degree, min_n) Removed.
6077 (macro dsc_extensions) Removed.
6078 (struct dsc_info_struct) Removed `min_n' member, all references
6080 (internal_cmd_descriptives) Removed calculation of min_n,
6081 max_degree. Only deals with one `calc' routine instead of two
6083 (precalc) Eliminated redundancy. Updated for changes to
6084 descriptives_proc structure.
6085 (calc) Moved here from `descript.g'. Rewritten to calculate
6086 statistics via `moments about the mean' rather than by summing,
6087 summing squares, summing cubes, and so on.
6088 (postcalc) Rewritten for new-style statistical calculation.
6089 (display) Removed support for displaying variables across rows.
6090 No longer crushes the descriptives table. Removed ancient code.
6091 Added display of N, by variable and listwise.
6093 * descript.g: Removed; merged into `descript.q'.
6095 * expr-evl.c: (evaluate_expression) Now returns a double. For
6096 numeric results, it returns the result as well as storing it in
6097 the passed `value' structure if non-NULL. For string results it
6098 just returns 0.0 and it must be passed non-NULL. Many references
6099 to this function were optimized by use of this change, especially
6100 but not exclusively in `compute.c'.
6102 * frequencies.g: Comment fix.
6104 * glob.c: (glob var process_if_expr) New global var.
6106 * postscript.c: (static var option_tab[]) Corrected entry for
6108 (postopen) Sets x->size to x->prop_size.
6109 (ps_text_set_font_by_name) Sets font size as well as typeface for
6110 PROP and FIXED fonts.
6112 * sel-if.c: (cmd_process_if) New function.
6114 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
6115 (sfm_write_dictionary) Sets `n_cases' to 0.
6116 (sfm_write_case) Increments `n_cases'.
6117 (sfm_close) Attempts to seek the system file back to the header
6118 and write the number of cases in its proper slot.
6120 * som-frnt.c: (som_insert_table) Masks off expansion options since
6121 only SOPT_X_NORM seems to work sensibly.
6123 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
6124 with a `fixed' value of 2.
6126 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
6128 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
6129 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
6131 * var.h: (enum series dsc_*) Removed Fiasco extensions.
6132 (struct descriptives_proc) Removed `miss_noweight'; new members
6133 `X_bar', `M2', `M3', `M4', `min', `max'.
6135 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
6137 * vfm.c: (close_active_file) Cancels PROCESS IF.
6138 (write_case) Doesn't process cases unselected by PROCESS IF.
6140 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
6142 * glob.c: (glob var err) Removed.
6144 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
6145 doesn't have to take into account number of value labels since
6146 they're in a subtable anyway. Also, doesn't display more than 10
6147 value labels since we can't yet break pages in subtables.
6149 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
6151 * som-frnt.c: (som_change_table_size) Simple change for elegance
6152 that shouldn't change behavior.
6153 (som_set_value) Comment fix.
6155 * som-high.c: (som_submit_table) Message fix.
6157 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
6159 * command.c: Added SYSFILE INFO to command table.
6161 * file-handle.q: (fh_handle_filename) New function.
6163 * get.c: (save_trns_proc) Fixed a bug in padding of output data
6166 * main.c: (parse) New return value for command functions, -3.
6168 * misc.h: Comment fix.
6170 * output.h: Comment fixes.
6171 (macro COMPONENTS) Removed.
6173 * postscript.c: (write_text) Modified literal_chars[] so that `('
6174 and ')' are not written to the output in strings as literals.
6176 * sfm-read.c: (sfm_read_dictionary) New argument.
6177 (read_header) New argument. Sets the information structure's
6178 values from the header information.
6179 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
6180 bizarre Checker problem, I guess.
6181 (read_variables) Proper cleanup on lossage.
6183 * sfm.h: (struct sfm_read_info) New struct for use by
6184 sfm_read_dictionary().
6186 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
6187 currently used just for tables that can be dynamically resized and
6188 thus have to be allocated with arena_malloc() instead of
6189 arena_alloc(). All references changed.
6190 (som_change_table_size) New function.
6191 (som_insert_table) Bugfix: now inserts `cell', not `c'!
6193 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
6194 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
6197 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
6199 (draw_intersection) Now takes an argument specifying the table in
6200 question. All references changed.
6201 (draw_table_cell) New function.
6202 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
6203 (som_get_table_size) Many nice new explanatory comments.
6204 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
6206 * som.h: New enum series SOM_CREATE_* for use as create flags with
6209 * str.h: Moved a comment here from TODO.
6211 * sysfile-info.c: New file. Reference implementation.
6213 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
6215 * command.c: Added RENAME VARIABLES to table of commands.
6217 * data-in.c: (dls_error) Sets `cust_field'.
6218 (parse_N) Message fix.
6219 (parse_day_count) New function.
6220 (to_roman) Never outputs VX as a `short form' of V.
6221 (parse_month) Fixed parsing of Roman numerals.
6222 (parse_trailer) Message fix.
6223 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
6224 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
6225 the date is invalid.
6226 (parse_SDATE) Fixed swapped day, year.
6227 (parse_JDATE) Fixed bug for dates in 1582.
6228 (parse_DTIME) Allows days not between 1 and 31.
6229 (parse_numeric) Makes local copy of f.type for easier usage.
6232 * data-out.c: (convert_F) When outputting as scientific, properly
6233 sets f.type as fp->type.
6234 (insert_commas) Fixed operator precedence problem with setting of
6235 nitems. Changed strcpy to memcpy (no null terminator).
6236 (convert_date) Fixed FMT_JDATE: added 1900 to year.
6237 (convert_CCx) Essentially rewritten, but now it works.
6239 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
6241 (display_documents) Implemented.
6243 * error.c: (glob var cust_field) New var.
6244 (vmsg) Displays cust_field as part of message classes DE and DW.
6246 * formats.c: (debug_print) Fixed to compile under updated
6249 * get.c: (cmd_get, cmd_save_internal) Close file handle on
6252 * misc.c: (parse_format_specifier) Formatting fix.
6254 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
6255 `n_rename' for clarity.
6256 (cmd_modify_vars) Initializes `forward' and `positional' at
6257 appropriate times. Frees lists of vars to rename on failure.
6258 Comment fix. Frees memory on success.
6259 (rearrange_dict) Simplified `for' loop condition.
6261 * rename-vars.c: New file (reference implementation).
6263 * set.q: (internal_cmd_set) Fixed `emu' test condition.
6265 * sfm-read.c: (read_header) File label is created only if file
6266 label in file is not blank.
6267 (read_variables) Initializes `dict' local variable.
6268 (read_documents) Proper behavior on lossage.
6270 * sfm-write.c: (write_header) Doesn't blank out the file label
6271 (why was this here to begin with?!)
6273 * temporary.c: (save_dictionary) File label is copied only if
6274 non-NULL. Doesn't try to xstrdup() dictionary documents.
6275 Adapted so as to not irritate Checker.
6276 (free_dictionary) Only destroys var_by_name if non-NULL.
6278 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
6279 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
6280 lines to the document, indents the document. Also, it works now.
6281 (add_document_line) New function.
6283 * var.h: (struct dictionary) Reordering.
6285 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
6286 bits if it was allocated to begin with.
6288 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
6290 * command.c: Added MODIFY VARS to list of commands.
6292 * configure.in: Updated custom macros for autoconf 2.12. Removed
6293 mmap reference; fixed termcap library reference.
6295 * display.c: (display_variables) Fixed a few bugs although it's
6296 still not well written.
6298 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
6299 (induce_segfault) Calls chkr_disp_call_chain() instead of
6300 inducing an actual SIGSEGV.
6302 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
6303 str_search() and str_rsearch(). Fixed tests for matches on
6304 OP_INDEX and OP_RINDEX.
6306 * filename.c: (good_getcwd) Removed as the new libc for Checker
6307 doesn't contain this bug, apparently.
6309 * misc.c: (str_search, str_rsearch) Changed order of arguments for
6310 consistency with GNU memmem.
6311 (blp_getdelim) Changed `len' from `int' to `size_t'.
6313 * modify-vars.c: Reference implementation.
6315 * som-frnt.c: (zero_length) New global var.
6316 (som_create_table) Message fix.
6318 * som.h: Added gcc attributions to som_set_text(),
6319 som_output_text() prototypes. blank_line() refers to
6320 zero_length[] instead of a literal null string to suppress gcc
6323 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
6324 (allocate_cases) Decrements x_max so the last element of x[] can
6325 be used by the algorithm.
6327 * var.h: Changed minor details of `variable' declaration.
6328 (struct modify_vars_proc) New struct.
6329 (struct variable) Added field p.mfv.
6331 * vars-atr.c: Comment fix.
6333 * vars-prs.c: (fill_all_vars) More optimal implementation.
6335 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
6336 character, which it shouldn't have to do but printf() seems to
6337 read the null byte even though I supply a maximum length...
6339 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
6341 * command.c: Removed command alias X for QUIT.
6342 (parse_cmd) Fixed comment parsing.
6344 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
6346 (read_record) Fixed references to len, size.
6347 (dfm_get_record) Restructured.
6349 * file-handle.h: (struct file_handle) Field `lrecl' now of type
6352 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
6355 * modify-vars.c: New file. Not complete.
6357 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
6360 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
6361 problems caused by int/size_t differences.
6363 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
6366 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
6367 being compared were of equal length.
6369 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
6371 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
6373 * lexer.c: (get_dotted_rest_of_line) New function.
6375 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
6378 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
6379 type 6 records. Frees the dictionary properly.
6380 (read_header) Initializes the dictionary instead of letting
6381 read_variables() do it. Sets the dictionary file label from the
6383 (read_documents) New function.
6385 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
6386 write type 6 record if appropriate.
6387 (write_header) Writes file label from dictionary.
6388 (write_documents) New function.
6390 * temporary.c: (save_dictionary, restore_dictionary,
6391 free_dictionary) Properly handle new fields in dictionary struct.
6393 * title.c: (get_title) Returns after failure().
6394 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
6395 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
6397 * var.h: (struct dictionary) New fields `label', `n_documents',
6400 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
6402 * command.c: Added FILTER to list of commands.
6404 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
6407 * get.c: (cmd_save_internal) Removed weighting code since it's now
6408 handled by sfm-write.c. Properly commented out debug code.
6410 * glob.c: (glob var weighting) Removed.
6412 * sel-if.c: Comment fixes.
6413 (cmd_filter) New function.
6415 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
6416 (sfm_read_dictionary) Sets weighting variable direct in the
6417 created dictionary now. (Apparently we previously didn't support
6419 (read_header) Sets weight_index field in sfm_fhuser_ext from
6420 header read from disk.
6422 * sfm-write.c: (sfm_write_dictionary) Comment fix.
6423 (write_header) Now sets the weighting in the header from the
6424 passed primary dictionary instead of from the sfm_write_info.
6426 * sfm.h: (struct sfm_write_info) Removed field `weight'.
6428 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
6429 broke on boundary conditions.
6431 * var.h: (struct dictionary) New fields `weight_var',
6432 `weight_index', and `filter_var'.
6433 (glob var weighting) Removed. This is now part of struct
6434 dictionary. All references changed; the less mechanical changes
6435 are described above.
6437 * vars-atr.c: (find_dict_variable) New function.
6439 * vfm.c: (static var filter_index) New variable.
6440 (open_active_file) Initializes filter_index from default_dict.
6441 (write_case) Calls proc_func() only if the filter variable is
6442 nonzero; this implements FILTER behavior.
6444 * weight.c: (static var weight_varname) Removed.
6445 (cmd_weight) Modified default_dict instead of glob vars.
6446 (update_weighting) Changed the signature to modify a dictionary
6447 instead of glob vars. Now returns the weighting variable.
6448 (get_weighting_variable) Removed; its function is absorbed by
6450 (stop_weighting) Operates on a dictionary now.
6452 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
6454 * sort.c: Removed debugging info from messages.
6455 (do_external_sort) Cleans up after itself by deleting the
6456 temporary directory on failure. (On success it is deleted by the
6458 (allocate_cases) Removed debug code. Added clean up code.
6459 (output_record) Removed debug code.
6460 (merge) Added code to close all the input files that are currently
6461 open. This is a likely location for bugs, because I'm not sure
6462 about boundary conditions. Removed an unnecesary heap_delete().
6463 (merge_once) Removed input file "optimization" that in fact
6464 screwed up the rest of the code. Message and comment fixes.
6466 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
6468 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
6470 * heap.c: (heap_delete) New argument.
6472 * sort.c: Finished implementation of external sort.
6474 * vfm.c: (read_from_disk) Returns after a disk error.
6476 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
6478 * sort.c: (static var state) Removed.
6479 (static vars max_handles, tmp_basename, tmp_extname,
6480 huffman_queue) New variables.
6481 (do_external_sort) Moved most code to new functions.
6482 Creates huffman_queue.
6483 (allocate_file_handles, allocate_cases) New functions.
6484 (static vars run_no, run_length, file_index, case_count) New
6486 (output_record) Returns success. Now really writes to the output
6488 (begin_run, end_run) New functions.
6489 (write_initial_runs) Returns success. Initializes run_no to -1.
6490 Calls begin_run(), end_run() at appropriate times. Outputs debug
6492 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
6494 (merge) New function.
6496 * heap.c, heap.h: New files. Hopefully in near-final form.
6498 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
6500 * glob.c: Added write_active_file to global vars.
6502 * sort.c: Several new miscellaneous static variables.
6503 (cmd_sort_cases) Big comment fix.
6504 (perform_case_2) Renamed `do_external_sort' and completely
6506 (case_2_proc_func) Removed.
6507 (output_record, write_initial_runs, write_to_sort_cases,
6508 compare_record) New functions.
6510 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
6512 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
6514 * sort.c: (perform_case_2) Changed the method for allocation of
6515 lots of memory--now allocates one case at a time in hopes that
6516 more cases can be allocated with heavily fragmented memory.
6518 * var.h: (write_active_file) New global var.
6520 * vfm.c: (procedure, close_active_file, write_case,
6521 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
6522 arguments to procedure() to be NULL. All references to
6523 procedure() that made use of dummy functions were changed to NULL
6525 (open_active_file) If write_active_file is non-NULL, the output
6526 device becomes DEV_PGM (a new enum).
6527 (close_active_file) Sets write_active_file to NULL.
6528 (read_from_memory) Comment fix.
6529 (record_case) Calls write_active_file() when the output device is
6532 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
6536 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
6537 Fixed checking for duplicate varnames.
6538 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
6540 (autorecode_trns_free) Destroys hash tables for each recoding
6542 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
6544 * command.c: Added SORT CASES to cmd_table.
6545 (null_func, null_int_func) Prototyped.
6547 * descript.g: (calc_weight, calc_noweight) Computes own case
6550 * frequencies.q: (dump_statistics) Fixed problem with
6551 too-few-cases warning message.
6553 * get.c: (cmd_save_internal) Handles weighting properly.
6555 * hash.c: (hsh_dump) Output format changed.
6556 (force_hsh_insert) Actually works now, prototype changed.
6558 * list.q: (static var case_num) New variable.
6559 (cmd_list) Initializes case_num.
6560 (list_cases) Increments case_num.
6562 * var.h: Added definitions for SORT CASES. Comment fixes.
6564 * vfm.c: Some definitions moved to new file vfmP.h. Comment
6565 fixes. `active' renamed vfm_active, `rep' renamed
6566 vfm_replacement, all references changed.
6567 (procedure) The procfunc no longer receives a case number. All
6569 (write_case) Subtle reordering.
6570 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
6573 * weight.c: (get_weighting_variable) New function.
6575 * vfmP.h: New file with definitions from vfm.c.
6577 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
6579 * command.c: (FILE_TYPE_okay) Commented out some tests because
6580 they're clumsy and not yet needed.
6582 * var.h: Most *_trns structures moved to their respective source
6583 files. Some were moved into a new file, do-ifP.h. Comment fixes.
6584 (union any_trns) Changed to a typedef for trns_header.
6585 (struct input_program_pgm) Removed.
6587 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
6588 was allocated in the first place.
6590 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
6592 * autorecode.c: New file.
6594 * command.c: Added AUTORECODE to command table; re-enabled SET.
6596 * data-out.c: (convert_F) Handles infinities and NaNs properly.
6598 * error.c: (vmsg) Comment fixes.
6600 * hash.c: Comment fix.
6601 (hashpjw_d) New function.
6602 (hashpjw) Reimplemented as call to more general function
6604 (internal_comparison_fn) Initializes pointers properly.
6605 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
6606 (force_hsh_insert, force_hsh_find) New debugging wrapper
6609 * main.c: (main) Message fix.
6611 * output.c: (outp_read_devices) Message fix.
6613 * set.q: Comment fixes.
6614 (custom_results) Implemented Wnd/X form of subcommand.
6615 (set_routing) New function.
6616 (internal_cmd_set) Implemented ERRORS, MESSAGES.
6618 * settings.h: (SET_ROUTE_*) New enum series.
6619 (set_results) Renamed set_results_file, all references changed.
6620 (set_messages) Removed.
6621 (glob vars set_errors, set_messages, set_results) New vars.
6623 * title.c: (get_title) Remembers to xstrdup() the result of
6626 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
6628 (union any_trns) New element `arc'.
6630 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
6632 * command.c: (output_line) Removed references to set_screen.
6634 * error.c: (static var terminating) New var.
6635 (hcf) Sets terminating to 1.
6636 (vmsg) If terminating is nonzero, does not attempt to call hcf().
6637 This prevents an infinite loop if an error occurs within hcf().
6639 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
6640 statement circumlocution with `case 42000' trick.
6641 (evaluate_expression) New support for OP_STR_MIS.
6643 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
6644 statement circumlocution with `case 42000' trick.
6645 (dump_node) Handles OP_STR_MIS.
6647 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
6648 variables exceptions.
6649 (parse_function) Message fix.
6650 (ops[]) Added OP_STR_MIS.
6652 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
6654 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
6656 * glob.c: Removed set_scrnfile glob var.
6657 (init_glob) set_errorbreak set to 0 by default.
6659 * groff-font.c: Changed included files.
6660 (groff_read_font) Initializes font_arena local var correctly.
6661 (default_font) New function.
6663 * output.c: Comment fixes.
6664 (glob var disabled_devices) New variable.
6665 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
6667 [GLOBAL_DEBUGGING] (reentrancy) New function.
6668 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
6669 outp_iterate_enabled_drivers) Calls to reentrancy().
6670 (destroy_list) New function.
6671 (outp_done) Moved code to destroy_list().
6672 (parse_options) Parses `listing', `screen', `printer' options
6674 (configure_driver) Sets new `device' member of driver.
6675 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
6677 * output.h: Comment fixes. New enum series OUTP_DEV_*.
6678 (struct outp_driver_struct) New member `device'.
6680 * postscript.c: (find_encoding_file) Doesn't display its own error
6682 (default_encoding) New function.
6683 (switch_font) Calls default_encoding() if no encoding can be
6685 (text) Makes up a character metric if none exists for the desired
6687 (load_font) Properly copies a fallback filename. Calls
6688 default_font() for a font if none at all are known.
6690 * set.q: Comment fixes. Removed OUTPUT subcommand.
6691 (custom_listing) Calls outp_enable_device() to enable/disable
6693 (turn_screen_on) Removed.
6694 (internal_cmd_set) Calls outp_enable_device() to enable/disable
6695 screen, printer devices.
6697 * settings.h: Comment fixes.
6698 (glob vars set_output, set_printer, set_screen, set_scrnfile)
6701 * som-high.c: (som_submit_table, som_eject_page) Use
6702 outp_iterate_enabled_drivers() instead of iterating
6703 outp_driver_list directly.
6705 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
6707 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
6708 (parse_string_as_format) Handles new formats.
6709 (parse_numeric) Now handles DOT and PCT formats.
6711 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
6713 (convert_date) Handle EDATE and SDATE formats.
6714 (convert_CCx) Now if there's not room for the currency characters,
6715 converts it as F format if it's positive instead of giving up
6716 quickly. Also fixed save-and-restore bug with decimal point
6718 (convert_format_to_string) Handles new formats.
6720 * misc.c: (formats[]) Added new formats.
6721 (convert_fmt_ItoO) Supports new formats.
6723 * sfm-read.c: (parse_format_spec) Supports new formats. Better
6724 data checking. New argument, all references changed.
6726 * sfm-write.c: (write_format_spec) Supports new formats.
6728 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
6731 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
6733 * cmdline.c: Comment fixes.
6734 (parse_command_line) Changed return type to void.
6736 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
6738 (parse_numeric) Handles international numbers (comma as decimal
6739 point). Some reformatting.
6741 * data-list.c: (parse_free) Default output format is now
6742 set_format instead of hard-coded F8.2.
6743 (read_from_data_list_list) Emits error message on undefined data
6744 only if set_undefined is nonzero.
6746 * data-out.c: (convert_E) Changes decimal point from period to
6747 comma if appropriate. Restructured. Better comments.
6748 (convert_F) Changes decimal point from period to comma if
6750 (insert_commas) Major bug with handling of negative values fixed.
6751 Also, inserts periods instead of commas if appropriate.
6752 (convert_CCx) New function.
6753 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
6754 (num_to_string) Changed `.' to set_decimal.
6756 * dfm.c: Comment fixes.
6757 (dfm_close) Frees ext->line even in inline_file.
6758 (open_inline_file) New function.
6759 (open_file_r) When opening the inline file: now properly
6760 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
6762 (read_record) Calls fh_close_handle() instead of dfm_close() to
6763 close the inline file. Makes a copy of the line getl_buf to avoid
6765 (dfm_get_record) Restructured. Now checks the return value of
6767 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
6768 checking for use of inline file. No longer tries to close inline
6771 * error.c: (glob var error_already_flagged) New var.
6772 (vmsg) Message change. Now checks max number of errors/warnings,
6775 * file-handle.q: (fh_handle_name) Now allows closing of
6777 (fh_init_files) Reformatted.
6779 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
6781 * getline.c: (getl_include) Fixed bug that popped up when called
6782 when file queue was empty.
6783 (read_console) Resets error_count, warning_count,
6784 error_already_flagged to zero.
6786 * glob.c: Many changes to update list of variables.
6787 (init_compat_dependent) Now this function is called whenever
6788 `compat' changes. It now sets set_seed only if it hasn't
6789 previously been referenced. It now calls
6790 lex_init_compat_dependent().
6792 * include.c: (cmd_include_at) Frees temporary buffer instead of
6794 (cmd_include) Doesn't make copy of include file name.
6796 * lexer.c: Comment fixes.
6797 (init_lex) Moved some code into new function
6798 lex_init_compat_dependent().
6799 (lex_init_compat_dependent) New function.
6800 (hex_val) Simplified.
6801 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
6803 * main.c: Comment fixes.
6806 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
6807 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
6808 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
6809 (setup_randomize) Sets set_seed_used.
6811 * set.q: Comment fixes.
6812 (custom_results) Conditionalizes on `compat'.
6813 (custom_log) Calls custom_journal().
6814 (set_ccx) New function.
6815 (cmd_set) Calls init_compat_dependent() when `compat' changes.
6816 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
6817 when set_decimal changes. Range-checks values for MITERATE,
6818 MNEST. Message fixes.
6820 * settings.h: Comment fixes.
6821 (struct set_cust_currency) New struct.
6822 (set_cc[], set_grouping, set_seed_used) New global vars.
6824 * var.h: (FMT_CCA...FMT_CCE) New output formats.
6825 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
6827 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
6829 * glob.c: Revised variables to correspond to settings.h.
6830 (init_glob) Initializes variables from settings.h properly.
6832 * set.q: Began long-overdue major revision to correspond to new
6833 philosophy. Most code changed.
6835 * settings.h: Mostly changed; reorganized, reordered, large new
6838 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
6840 * get.c: (cmd_save_internal) No longer forces compression off.
6842 * sfm-read.c: (read_compressed_data) If eof is reached when
6843 reading a new instruction octet, only signal error if we're in the
6846 * sfm-write.c: (COMPRESSION_BIAS) New #define.
6847 (struct sfm_fhuser_ext) New member `end'.
6848 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
6849 (ensure_buf_space) New function.
6850 (sfm_write_case) Reimplemented in order to support compression.
6851 (sfm_close) Writes out the remaining contents of the compression
6854 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
6856 * command.c: Defined SAVE and XSAVE commands in command table.
6858 * common.h: second_lowest_value is of type flt64, not double.
6860 * file-handle.h: Comment fix.
6862 * get.c: Comment fixes.
6863 (static var `trns') New.
6864 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
6865 cmd_save_internal, cmd_save, cmd_xsave) New functions.
6866 (dict_delete_run) Clears the variables and frees them now.
6867 (trim_dictionary) Sets default for compression.
6868 On KEEP subcommand, frees deleted variables as well as clearing
6869 them. Finally got the sense of the test for deleting all
6871 [DEBUGGING] (dump_dict_variables) Message fix.
6873 * glob.c: (init_glob) set_compression set to 1 by default.
6875 * list.q: Properly #includes config.h.
6877 * misc.h: New macro REM_RND_UP.
6879 * settings.h: Comment fix.
6881 * sfm-read.c: (structs sysfile_header, sysfile_format,
6882 sysfile_variable; inline function bswap_int32) Moved to new file
6884 (corrupt_msg) [__CHECKER__] No longer induces segfault.
6885 (sfm_read_dictionary) Fixed bug caused by failing to initialize
6887 (read_machine_flt64_info) Fixed some problems caused by confusion
6888 between flt64 and double types.
6889 (read_header) Message fix.
6890 (read_variables) Fixed set of cases in which we byte-swap sv.print
6891 and sv.write. Fixed confusion of flt64 and double.
6893 * sfm.h: (struct sfm_write_info) New.
6895 * som-high.c: (som_draw_title) Properly frees `s'.
6897 * temporary.c: (save_dictionary) Comment fix.
6899 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
6900 (struct trns_header) Formatting fix.
6901 (struct save_trns) New.
6903 * vars-atr.c: (discard_variables) Comment fix.
6905 * sfm-write.c: New file, baseline release.
6907 * sfmP.h: New file, baseline release.
6909 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
6911 * cmdline.c: (parse_command_line) `--version' output updated.
6912 (glob var syntax_message[]) Added my e-mail address.
6914 * file-handle.q, lexer.c, vfm.c: Changed many instances of
6915 `illegal' to `invalid'.
6917 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
6918 uncompression buffer.
6919 (sfm_close) Frees decompression buffer.
6920 (sfm_read_dictionary) Initializes decompression buffer.
6921 (buffer_input, read_compressed_data) New functions.
6922 (sfm_read_case) Restructured; now calls read_compressed_data() to
6923 handle compressed system file data.
6925 * var.h: Comment fix.
6927 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
6929 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
6932 * get.c: New comments. New static var `get_file'.
6933 (cmd_get) Now fully implemented. Calls discard_variables();
6934 initializes fv and lv for all variables; new debug code; sets
6935 up the dictionary; sets up the input program.
6936 (read_from_get, cancel_get) New functions.
6938 * sfm-read.c: Comment fixes.
6939 (sfm_close) New static function.
6940 (sfm_read_dictionary) Properly sets up the class of the
6941 file_handle. No longer cares what size the data is in records of
6942 type 7. Also, on failure, properly cleans up the file_handle and
6944 (read_variables) No longer thinks it knows `nval' of the
6945 dictionary. Now sets p.get.fv, etc., instead of speculatively
6947 (read_value_labels) Fixed off-by-one error in indexing of
6949 (sfm_read_case) New function.
6950 (sfm_r_class) New static var.
6952 * var.h: (get_proc) New struct.
6953 (struct variable) New member p.get.
6955 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
6957 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
6958 the manual's meaning.
6959 (rename_variables) New function.
6960 (trim_variables) Doesn't try to parse MAP any more. Removed debug
6961 code. Now properly reorders the dictionary on the KEEP keyword.
6963 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
6966 * vars-atr.c: (clear_variable) New argument `dictionary *'.
6967 (rename_variable) New function.
6968 (free_val_lab) Reformatted.
6970 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
6972 * var.h: Reindented entire file. Comment fixes.
6973 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
6975 (glob var default_dict) New.
6976 (struct indirect_dictionary) Removed.
6978 * Many other source files were changed to add `default_dict.'
6979 before all references to the dictionary of the active file.
6981 * vars-atr.c: (make_indirect_dictionary) Removed.
6983 * glob.c: Reindented all variable declarations. Updated for
6984 changed var.h. Comment fixes.
6986 * temporary.c: (restore_dictionary, save_dictionary) Simplified
6987 because now we can mainly copy dictionary structs.
6989 * vars-prs.c: (is_dict_varname, parse_dict_variable,
6990 parse_variables) Takes dictionary instead of indirect_dictionary
6992 (parse_variables) Instead of calling make_indirect_dictionary,
6993 just sets DICT to &default_dict if DICT is NULL. Of course, lots
6994 of `*dict.' references had to be changed to `dict->'. Removed
6997 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
6999 * get.c: Added GTSV_OPT_* series of enums.
7000 (trim_dictionary, dict_delete_run) New functions.
7001 [DEBUGGING] (dump_dict_variables) New function.
7002 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
7003 [DEBUGGING] Calls dump_dict_variables() to display results.
7005 * glob.c: (cmp_variable) Now a public function declared in var.h.
7007 * sfm-read.c: Turned off debug code. Comment fixes.
7008 (read_machine_int32_info, read_machine_flt64_info) New functions
7009 to parse type 7 records.
7010 (sfm_read_dictionary) Properly byteswaps several fields now.
7011 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
7012 records. [DEBUGGING] Dumps dictionary.
7013 (read_variables) Sets `index' field of variables created properly.
7014 Constructs avl tree of variables in dictionary. [DEBUGGING] No
7015 longer dumps dictionary.
7016 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
7018 [DEBUGGING] (dump_dictionary) No longer stubbed out.
7020 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
7021 var before destroying any variables just to save a little time.
7023 * var.h: (struct variable) Reordered in order to make name[] the
7024 first member; this makes pointers to `variable' pointers to the
7025 variable name, simplifying avl trees, etc.
7026 (struct indirect_dictionary) New struct.
7028 * vars-atr.c: (find_variable) Rewritten for efficiency.
7029 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
7031 (is_varname) Rewritten for efficiency.
7032 (parse_variables) New argument, which is a `dictionary *'. All
7033 references changed. This function now reads variable names from
7034 the dictionary passed, or from the default dictionary if NULL.
7036 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
7038 * misc.h: Added new macro DIV_RND_UP to perform integer division,
7039 rounding up. Changed many references to ROUND_UP to use this
7042 * sfm-read.c: Includes avl.h.
7043 (corrupt_msg) Induces a segfault under Checker.
7044 (macro assertive_bufread) New. Many references to bufread() now
7046 (sfm_read_dictionary) Split up into several functions. Added code
7047 to read dictionary records following the the type 2 records. Not
7048 quite complete. New variable `var_by_index'.
7049 (read_header, read_variables) New functions extracted from
7050 sfm_read_dictionary().
7051 (read_value_labels) New function.
7052 (bufread) Checks ferror() if fread() doesn't return the expected
7053 value; if ferror() is zero it's just EOF.
7054 (dump_dictionary) Stubbed out.
7056 * BTW: The source code now exceeds 50000 lines!
7058 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
7060 * command.c: Added GET to cmd_table[].
7062 * list.q: Removed reference to alloca headers.
7063 (cmd_list) Gave prototype.
7065 * sfm-read.c: Added DEBUGGING comments.
7066 (sfm_read_dictionary) Checks bias correctly. Sets
7067 dict->var_by_name to NULL. Calculates long_string_count
7068 correctly. realloc's dict->var[] array to minimum size.
7069 [DEBUGGING] Calls dump_dictionary.
7070 [DEBUGGING] (dump_dictionary) New function.
7072 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
7073 (restore_dictionary) If the dictionary contains a non-NULL
7074 var_by_name, uses that instead of generating one.
7075 (free_dictionary) Destroys var_by_name.
7077 * var.h: (struct dictionary) Added field `var_by_name'.
7079 * get.c: New file, not complete.
7081 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
7083 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
7084 (parse_num_or_range) New function.
7085 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
7086 <n> THRU HIGH missing values.
7088 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
7089 __attribute__((const)).
7091 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
7093 * sfm-read.c: Finished reference implementation.
7095 * sfm.h: Includes var.h.
7097 * var.h: Comment fixes.
7098 (struct `variable') Reordered some fields.
7100 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
7101 constants added previously.
7103 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
7105 * common.h: Comment fixes. Added declaration of
7106 `second_lowest_value' as variable or macro. Made `compat_type',
7107 `pgm_state_type' into anonymous enums.
7109 * display.c: Comment fix.
7111 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
7113 [!defined SECOND_LOWEST_VALUE] Added definition for
7114 `second_lowest_value' global var.
7115 (compat, pgm_state global vars) Changed types to `int'.
7116 (init_glob) Initializes `second_lowest_value'.
7118 * sfm-read.c: Continued work, not complete.
7120 * var.h: Added new MISSING_* constants to handle LOWEST and
7123 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
7125 * sfm-read.c: New file, not complete.
7127 * cases.c: (vec_insert) Changed vector expansion algorithm.
7128 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
7129 mucking up the RECODE transformation in particular.
7130 (envector) Harmless change in notation.
7132 dfm is now fairly well tested again.
7133 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
7135 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
7137 * recode.c: Comment fix.
7139 * sfm.h: Interface should be fairly final now, or at least for a
7142 * vfm.c: [DEBUGGING] (index_to_varname) New function.
7143 (open_active_file) [DEBUGGING] Translates ccase indices into
7144 variable names now to make it easier to understand what's really
7147 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
7149 * data-in.c: Comment fix.
7151 * data-list.c: Includes dfm.h.
7152 (do_reading) Uses new function dfm_push_cust().
7154 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
7157 * file-handle.h: Completely changed. Some parts split off into
7158 new file dfm.h. Implemented in file-handle.q.
7159 (enum FH_*) Removed.
7160 (struct fh_ext_class) New struct.
7161 (struct file_handle) Retained only these fields: name, norm_fn,
7162 fn, recform, lrecl, mode. New fields class, ext.
7163 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
7164 close_handle, handle_name) Added `fh_' prefix to name, all
7167 * dfm.h: New file, implemented in dfm.c.
7168 (get_record, put_record, fwd_record, bkwd_record, set_record,
7169 get_cur_col) Functions moved from file-handle.h, now prefixed with
7171 (dfm_push_cust) New function.
7173 * sfm.h: New file. Incomplete.
7175 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
7176 interface. Functions reordered, comments changed. Not well
7177 tested, probably full of bugs.
7178 (struct dfm_fhuser_ext) New struct.
7179 (dfm_close) New function.
7180 (open_file_r) Pickier about finding `BEGIN DATA.' line.
7181 (open_file_w) User messages changed.
7182 (get_record) Comment fixed.
7183 (read_record) Increments ext->ln even for inline_file. Calls
7184 dfm_close() for inline_file when `END DATA.' encountered.
7185 (dfm_get_record) Experimental restructuring.
7186 (dfm_push_cust) New function.
7187 (cmd_begin_data) Detects whether the inline file was fully read by
7188 checking whether it is still open; detects whether it was read at
7189 all by checking whether the line number is greater than zero.
7191 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
7192 interface. Functions reordered, comments changed. Not well
7193 tested, probably full of bugs.
7194 (init_file_handle) Removed initializers for obsolete fields, added
7196 (fh_close_handle) Much simpler, now mainly calls the class
7198 (fh_init_files) Renamed inline file internal filename.
7200 * file-type.c: Includes dfm.h.
7201 (read_from_file_type) Doesn't use dfm internal state anymore.
7203 * inpt-pgm.c, print.c: Include dfm.h.
7205 * recode.c: (internal_cmd_recode) Casts strlen() return value to
7206 int in comparison with other int.
7208 * som-high.c: (build_target) Fixed operator precedence problem in
7209 if statement (& versus ==).
7211 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
7213 * dfm.c: (read_record) Can now read fixed-length records; not
7215 (put_record) Can now write fixed-length records; not tested.
7217 * file-handle.h: FH_* defines changed to enums. New enum series
7219 (struct file_handle) New members recform, lrecl, mode.
7221 * file-handle.q: Parser changed.
7222 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
7223 /LRECL subcommands. These are compatible with Windows.
7224 (init_file_handle) Initializes recform, mode fields.
7226 * q2c.c: (get_line) When outputting `!' comment lines, now
7227 increments the output file line number so that `#line' directives
7229 (make_identifier) New function that converts an arbitrary string
7230 into a valid C identifier.
7231 (dump_vars) Calls make_identifier() in two places in order to
7232 suppress some errors for bad identifiers.
7233 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
7234 for NO. Allows numbers to be prefixed by underscores to make them
7235 acceptable C identifiers but still to be parsed as numbers by the
7238 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
7240 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
7242 * dfm.c: Comment fixes. (get_record) Gives error if file handle
7243 was opened for writing.
7244 (open_file_w) New function.
7245 (read_record) Uses strncasecmp if available. Improved error
7247 (put_record) New function.
7249 * file-handle.h: Moved function comments into dfm.c and
7250 file-handle.q. Comment fixes. Removed declarations of
7251 tilde_expand() and normalize_filename().
7252 (struct file_handle) Changed `open' from boolean to enumerated
7253 field to allow for three states--closed, open for reading, open
7254 for writing--all references changed.
7256 * file-handle.q: Includes filename.h.
7258 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
7260 (alloc_line) Makes allowance for line terminator characters in
7262 (print_trns_proc) Now handles OUTFILE, WRITE differences.
7263 (print_space_trns_proc) Handles OUTFILE differences.
7265 * recode.c, sample.c: Comment fixes.
7267 * var.h: (struct print_trns) Changed boolean field `eject' to
7268 bitmapped field `options'; all references changed. New enums
7269 PRT_* for use with this field.
7271 * exception.h, test-exception.c: Removed.
7273 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
7275 * ascii.c: (delineate) Turned off debug output.
7277 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
7280 * data-in.c: (parse_string_as_format) Sets the entire string value
7281 to spaces, not just the short string part of it. Is this correct
7284 * data-out.c: (convert_date) Fixed DATETIME format problems with
7285 decimal places, removed debug code.
7287 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
7288 middle of parsing BEGIN DATA that would cause the lexer to read
7289 from a wild pointer `prog'; now calls new function
7290 preprocess_line() in lexer.c.
7292 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
7294 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
7295 Now call induce_segfault() to induce the segfault.
7296 (induce_segfault) New function.
7298 * expr-opt.c: Comment fix.
7299 (parse_sysvar) New function.
7300 (parse_primary) Added system variable support--calls
7302 (global var ops) Added OP_CASENUM operator.
7304 * expr.h: Comment fixes.
7305 (OP_* enum) added OP_CASENUM operator.
7306 (struct casenum_node) New struct.
7307 (union any_union_union) New member `cas' of type `casenum_node'.
7309 * glob.c: (global var last_vfm_invocation) New var.
7310 (init_glob) Initializes last_vfm_invocation.
7312 * lexer.c: (lookahead) Fixed reversed condition on if statement.
7314 * getline.c: (get_line) Split into get_line() and preprocess_line().
7315 (preprocess_line) New function.
7317 * var.h: Declares last_vfm_invocation.
7319 * vfm.c: (procedure) Sets last_vfm_invocation.
7321 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
7323 * command.c: (parse_cmd) Fixed bad assertion related to
7326 * data-in.c: (parse_month) Implemented to parse months according
7327 to full interpretation of standard.
7328 (to_roman) New function.
7329 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
7330 (parse_weekday) Bug fix (forgot to skip all the day name).
7332 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
7333 up parsing of multirecord data items. Also fixed user message.
7335 * data-out.c: Comment fix.
7336 (year2, year4, convert_date, convert_time, convert_WKDAY,
7337 convert_MONTH) New functions to support time & date output.
7338 (convert_format_to_string) Calls new time & date output routines.
7340 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
7342 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
7345 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
7347 * misc.c: (global var formats) Fixed declarations of DATETIME,
7350 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
7351 the output_char buffer.
7353 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
7354 memory bug. Fixed user messages.
7356 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
7358 * Removed #pragma argsused from lots of places.
7360 * data-in.c: Implemented zoned decimal and time-date formats.
7361 Untested. This is a huge chunk of code--maybe 1000 lines and 50
7364 * data-out.c: Implemented zoned decimal format.
7366 * expr.h: Moved yrmoda() declaration here from exprP.h.
7368 * misc.c: (global var formats) Minor fixes--added
7369 FCAT_SHIFT_DECIMAL to formats N and Z.
7370 (convert_fmt_ItoO) Added support for format Z.
7372 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
7374 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
7376 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
7377 som_check_workspace() that is activated between commands.
7379 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
7382 * list.q: (begin_row) Changed title expansion style from
7383 SOPT_X_VERT to SOPT_X_SHSP.
7385 * som-frnt.c: Now includes `somP.h'.
7386 (som_push_workspace, som_pop_workspace) New functions that, taken
7387 together, form a solution to the recursive table building problem
7388 mentioned yesterday. Surrounded every table output routine
7389 throughout the program with calls to these functions.
7390 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
7391 (som_create_table) Checks that there's an active workspace.
7392 (som_destroy_all_tables, som_crush) Removed.
7394 * som-high.c: (global var som_preserve_tables) Removed, all
7396 (som_submit_table) Checks that there's an active workspace.
7397 (dump_columnated_table) Doesn't columnate tables that would have
7398 just one row per column.
7399 (dump_crush_page, som_dump_crush_page) Removed debugging code.
7400 (som_dump_crush_page) Moved row number labels from left side of
7401 tables to right side.
7402 (som_get_table_size) Added support for SOPT_X_SHSP.
7404 * som.h: New cell expansion type SOPT_X_SHSP.
7406 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
7408 (global var curtab_arena) Moved from som-frnt.c.
7410 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
7412 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
7413 that causes bad location warnings to be suppressed.
7414 (delineate) Saves current font when calling draw_text(); fixed
7415 handling of NULLs when backing up. Also fixed line-wrapping bug.
7417 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
7418 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
7420 * common.c: Added code to cause assertion failure to dump core
7421 when run under Checker.
7423 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
7424 there are still bugs.
7426 * glob.c: (__eprintf) Removed.
7428 * list.q: Inserted som_preserve_tables kluge that prevents tables
7429 from being thrown away due to recursive table building through
7430 som_output_line being called from a transformation during the LIST
7431 procedure invocation. This is a general problem that must be
7432 solved in a better way since it applies to all procedures in
7434 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
7435 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
7437 * numeric.c: Fixed several errors in the form of msg() calls.
7439 * print.c: Updated for use of som.
7440 (dump_table) Reimplemented.
7441 (print_trns_proc) Calls som_eject_page() instead of eject_page().
7442 Calls som_output_text() instead of outs_line().
7444 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
7446 (som_output_text) Function moved from som-low.c. Interface
7449 * som-high.c: (som_preserve_tables) New global public variable
7451 (som_submit_table) Destroys the tables only if som_preserve_tables
7453 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
7454 one subrow per row. Now labels subrows if there's more than one
7456 (dump_crush_table) Added wishlist comment.
7457 (som_eject_page) New public function declared in som.h.
7459 * som-low.c: (som_dump_crush_page) Draws row labels if there's
7460 more than one subrow per row.
7461 (som_output_text) Moved to som-frnt.c.
7463 * som.h: (SOM_TOPT_PRESERVE) Removed.
7465 * title.c: (get_title) Changed interface.
7466 (cmd_title) Changed `title' to `outp_title'.
7467 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
7469 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
7471 * list.q: (flush_table) Conforms to new partial options in
7472 som_submission_form.
7474 * som-high.c: (paginate_horizontally) Changed form of subrow
7476 (build_target) Omits spacing before table if
7477 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
7478 (dump_crush_page) Changed interface. Only trims bottom rule if
7479 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
7480 (dump_crush_table) Handles partial tables.
7481 (output_row_label) New function.
7482 (som_dump_crush_page) Emits subrow number labels. Draws vertical
7483 rule on the right edge of narrow subrows.
7485 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
7486 constants to a series of SOM_TOPT_PARTIAL_* submission options.
7487 All references updated.
7489 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
7491 * misc.c: Comment fix.
7493 * som-high.c: (examine_table) Treats crushed tables separates for
7494 purpose of determining header size.
7495 (paginate_horizontally) Allots space for line numbers in crushed
7496 tables with lots of subrows per row. Calculates the `maximum page
7497 width', the width of the widest horizontal page.
7498 (build_target) Removed trim argument; all references changed.
7499 Stricter assertions. (dump_crush_page) New function.
7500 (dump_crush_table) Reimplemented.
7502 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
7503 (som_dump_crush_page) Reimplemented, interface changed.
7505 * somP.h: Many many new helper macros for use with crushed tables.
7506 (global var som) Removed `tv', `cum_y' members; all references
7507 removed. New members `mpw', `digit_space'.
7509 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
7511 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
7512 variable, changed to constant 1024.
7513 (arena_ca_strdup) Changed `sizeof(a_string)' to
7515 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
7516 `(c_string *)' to `(char *)'; this fixed some offset problems.
7518 * filename.c: (readlink_malloc) Changed initial allocation from
7520 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
7523 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
7524 &fm->owner in several places.
7526 * som-high.c: (output_table) Changed interface to rest of world.
7527 (examine_crush_table) Removed. Crushed tables are re-broken now,
7528 in preparation for rewrite.
7530 * som.h: Comment fix.
7532 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
7534 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
7535 itself in the cleanup stage.
7537 * descript.q: (display) At least temporarily, changed the table
7538 format to a crushed table.
7540 * list.q: (begin_row) At least temporarily, added horizontal lines
7543 * som-high.c: (examine_crush_table) Sets som.hh to the width of
7544 the horizontal "headers," that is, to the width of the far left
7545 and far right rules.
7546 (justify_pagination) Sets som.th to the width of the widest row
7547 in the crushed table. Fixed inner loop off-by-one error.
7549 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
7552 * somP.h: Comment fix.
7554 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
7556 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
7557 before closing it; also, opens the constructed filename `s'
7558 instead of f->filename.
7560 * postscript.c: Moved initialization of x->loaded, x->prop,
7561 x->fixed, x->current, also the add_encoding() calls, into
7563 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
7564 sets x->last_font to NULL; sets x->next_combo to zero.
7566 * som-high.c: (crushed_row_height) Moved definition farther up.
7567 (som_submit_table) Doesn't calculate line width, font size until
7568 after calling open_page(), to accomodate changes to PostScript
7570 (vert_headers) Removed; equivalent functionality moved to
7571 examine_table(), examine_crush_table().
7572 (justify_pagination) Replaced with different algorithm.
7573 (dump_crush_table) Bugfix that caused tables to fail to be clipped
7574 at the bottom of the page.
7576 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
7578 * command.c: Added cmd_list back into cmd_table.
7580 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
7581 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
7583 * list.q: (flush_table) Updated to new som_submission_form format.
7585 * som-frnt.c: Comment fix.
7587 * som-high.c: Changed `#endif' to `#undef EXTERN'.
7588 (output_table) Calls som_get_table_size() directly; handles
7590 (examine_crush_table) New function; calls vert_headers().
7591 (examine_table) Moved some code into new function, vert_headers().
7592 (justify_pagination) New function.
7593 (dump_plain_table) Removed `static' from `cy'.
7594 (dump_crush_table) New function.
7596 * som-low.c: (som_dump_crush_page) New function.
7598 * som.h: Comment fixes.
7599 (enum SOM_TOPT_CRUSH) New.
7600 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
7601 Temporarily set to zero to make do with LIST procedure.
7603 * somP.h: Re-ordering.
7605 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
7607 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
7609 * somP.h: New file for use by som-high.c, som-low.c.
7611 * q2c.c: Added definition for VME.
7612 (get_line) Now dumps `!' comment lines to the output file
7615 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
7616 set.q: Changed format of `!' comment lines.
7618 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
7620 * All source files: Added copyright notice.
7622 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
7623 longs in msg() calls.
7625 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
7627 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
7629 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
7631 * output.c: (outp_read_devices) Changed criteria for
7632 distinguishing different types of lines.
7634 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
7636 * cmdline.c: Changed syntax message.
7638 * filename.c: (good_getcwd) Bug fix (?).
7639 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
7641 (search_path) Appends DIR_SEPARATOR to directory name only if it
7642 does not already end with one.
7644 * glob.c: Checks STAT_PAGER envvar before PAGER.
7646 * output.c: Checks environment variables instead of just local
7649 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
7651 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
7652 when the pointer passed to the function was within the arena
7653 itself, so that it couldn't properly be set to NULL _after the
7656 * command.c: Re-enabled DISPLAY.
7658 * display.c: Rewritten to handle tables. Untested.
7660 * filename.c: (search_path) Fixed memory leak.
7662 * frequencies.q: (cmd_frequencies) Frees v_variables.
7663 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
7664 (cleanup_freq_tab) New function to garbage collect.
7665 (dump_full) Elegantized.
7667 * main.c: New comment.
7669 * output.h: New tag for tagged quotes: TAG_NEWLINE.
7671 * postscript.c: Comment fix.
7672 (release_fontmap, free_font_entry) New functions.
7673 (ps_init_driver) Sets free_font_entry() as the freefunc for
7674 hashtable `loaded'. Calls release_fontmap() when destroying a
7675 driver; also frees the output filename; also frees the
7676 ps_driver_ext block.
7677 (free_ps_encoding) Frees the filename as well as the encoding
7679 (output_encodings) Frees the line buffer and pops the msg-filename
7681 (read_fontmap) Frees the fontmap filename and the line buffer.
7682 (postopen, preclose) Misc. garbage collection fixes.
7683 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
7684 to NULL; this fixes some output problems.
7685 (text) Handles TAG_NEWLINE. Untested.
7687 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
7688 (som_set_string) Removed. All references changed to
7690 (som_set_text) Rewritten. New interface. More general.
7692 * som.h: Minor format changes.
7693 (struct som_value_cell) Removed; all references changed to
7695 (enums SOT_*) Changed.
7697 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
7699 * command.c: Re-enabled SPLIT FILE.
7701 * postscript.c: Comment fix.
7703 * som.h: Added `SOT_NONE'.
7705 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
7707 * vfm.c: (dump_splits) Reimplemented.
7709 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
7711 * Compiled the project under gcc 2.7.2, which gave some new
7712 warnings. This led to many additions of casts from unsigned to
7713 int sprinkled throughout the code.
7715 * arena.c: Many uses of `unsigned' changed to `size_t'.
7717 * command.c: Added END FILE, END REPEAT to command table.
7718 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
7719 (find_command, FILE_TYPE_okay) Not commented out anymore.
7720 (parse_cmd) Calls FILE_TYPE_okay again.
7721 (output_line) Added calls to som_output_text() to put the line
7722 in the output files.
7724 * common.c: (macro VME) Format changes.
7725 (xstrdup) Asserts that its argument is not NULL.
7727 * data-list.c: Implemented dump_fixed_table().
7729 * inpt-pgm.c: Formatting changes. Comment changes.
7730 (end_case_proc) Renamed end_case_trns_proc.
7731 (cmd_end_file, end_file_trns_proc) New functions.
7733 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
7735 * misc.h: (local_strdup) New macro corresponding to strdup() but
7736 allocating its data through local_alloc() if possible--that is, if
7739 * postscript.c: Comment changes.
7740 (quote_ps_name, quote_ps_string, output_encodings) New functions.
7741 (output_line, add_string) New macros supporting
7743 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
7744 substitution vars. Calls output_encodings() when a line
7745 consisting of `!encodings' is encountered.
7746 (preclose) Some code moved into quote_ps_string().
7747 (dump_line) Changed into macro supporting dump_fancy_line().
7748 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
7749 command when appropriate.
7750 (write_text) Fixed `literal_char' array (I think it's fixed, at
7752 (text) Fixed bug when width was zero. Now exits immediately on
7753 zero height_left. Now, when executing `goto restart;', checks
7754 that cp<end, so that we don't read beyond end-of-string. Also,
7755 outputs the correct code to the output file by outputting the code
7756 from the metric instead of the internal metric index.
7758 * repeat.c: (cmd_end_repeat) New function.
7760 * som.c: (var som) `headers' renamed `options' and semantics
7761 changed. All references changed.
7762 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
7763 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
7765 (som_text_table) Removed.
7766 (som_output_text) New function.
7768 * som.h: (struct som_submission_form) Removed `header', `reuse',
7769 replaced with bitmapped field `options'.
7770 (SOM_TOPT_*) New enum set for som_submission_form.options.
7771 (SOT_*) New enum set for som_output_text().
7773 * temporary.c: (copy_variable) When copying the var label, only
7774 calls xstrdup() if it's non-NULL.
7776 * var.h: (enum type `vartype') Removed; all references changed to
7779 * vars-atr.c: (init_variable) Changed local var `nbytes' from
7782 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
7784 * font.h: Comment changes.
7786 * groff-font.c: (groff_read_font) Initializes `name' field to
7787 NULL. Handles `encoding' field.
7789 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
7791 * postscript.c: (struct font_entry) Removed `position' field.
7792 (struct ps_font_combo) New struct.
7793 (struct ps_driver_ext) Removed field `next_position'. New fields
7794 `combos', `next_combo'. `last_font' field changed from
7795 `font_entry *' to `ps_font_combo *'.
7796 (ps_init_driver) Reformatted; handles new fields. When
7797 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
7799 (get_encoding, find_encoding_file) New functions.
7800 (add_encoding) Some code moved out into find_encoding_file().
7801 (postopen) Changed value for ${title}.
7802 (preclose) Sets `loaded' field to NULL after destroying the hash
7804 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
7806 (ps_text_set_font_by_position) Figures out the current family if
7808 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
7809 (switch_font) Implemented.
7810 (write_text) Calls switch_font() more often. Format changes.
7811 #undefs its macros after they're no longer useful.
7812 (text) Changed `continue' at one point to a jump to the top of the
7813 loop because we don't want `separate' reset to 0 at that point.
7814 (load_font) No longer sets `position' in the font_entry created.
7816 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
7818 * font.h: (struct font_desc) New member `encoding', which is not
7819 properly handled yet.
7821 * glob.c: (init_glob) Some new i18n code, which is probably
7824 * output.c: (outp_read_devices, outp_get_paper_size) Changed
7825 `size' local from `int' to `size_t'.
7827 * postscript.c: New driver configuration parameter `auto-encode'.
7828 New enums OPO_AUTO_ENCODE, ODA_COUNT.
7829 (struct font_entry) New member `position'.
7830 (struct ps_driver_ext) Reordered. New hash table member
7831 `encodings'; new members `next_position', `next_encoding',
7832 `last_font'. Members `current', `prop', `fixed' changed from type
7833 `font_desc *' to `font_entry *'; all references changed.
7834 (struct ps_encoding) New struct.
7835 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
7836 free_ps_encoding, add_encoding) New functions.
7837 (ps_init_driver) Added OPO_AUTO_ENCODE to default
7838 x->output_options. Initializes new members of ps_driver_ext.
7839 Changed default value for prologue_fn, encoding_fn. Calls
7840 read_ps_encodings after loading default fonts.
7841 (option_tab[], ps_option) Handle new configuration parameter.
7842 (switch_font) New function.
7843 (struct output_char) `font' member changed from `font_desc *' to
7844 `font_entry *'. New member `separate'.
7845 (read_fontmap) Changed `size' from `int' to `size_t'.
7846 (output_line, put_number) New macros for write_text().
7847 (write_text) Optimizes text output by consolidating multiple
7848 calls to PostScript `show' operator.
7849 (text) Keeps track of when text arguments can't be consolidated by
7850 write_text(), and marks those spots in the output stream.
7851 (load_font) Sets `position' of the allocated font_entry to -1, cuz
7852 the font hasn't been switched to by switch_font(), which is where
7853 the position is important--the PostScript is what cares about the
7856 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
7858 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
7859 call a NULL free_func.
7860 (hsh_rehash) Elegantized.
7861 (hsh_probe) Fix bug that manifested when the table was expanded
7862 and thus had to change location in memory. Good thing
7863 too--otherwise could have been much more subtle.
7864 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
7865 (hsh_foreach) New function for hash table iteration.
7867 * hash.h: (struct hsh_iterator) New.
7869 * lexer.c: (parse_tagged_quote) Font and family name strings in
7870 tags are now null-terminated.
7872 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
7874 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
7875 documented. (Never before tested?)
7877 * output.h: Comment changes.
7879 * postscript.c: New driver options `optimize-text-size',
7880 `optimize-line-size', `max-fonts-simult'. New enum set for
7881 specing cached line types. Comment fixes.
7882 (struct line_form) New struct.
7883 (struct ps_driver_struct) New members `text_opt', `line_opt',
7884 `max_fonts', `lines'.
7885 (ps_init_driver) Initializes new members of ps_driver_struct.
7886 (user option type enum set) New member `nonneg_int_arg'.
7887 (static var option_tab[]) Supports new options.
7888 (ps_option) Handles new options.
7889 (find_ps_file) Made static. No longer calls hsh_dump().
7890 (ps_get_var) Made static.
7891 (preclose) Dumps out proper DSC trailer.
7892 (ps_open_page) Elegantized.
7893 (ps_close_page) Calls dump_lines() if appropriate.
7894 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
7895 wrappers around line().
7896 (int_2_compare, compare_line, dump_line, dump_fancy_line,
7897 dump_lines, hash_line, free_line, line) New functions for support
7899 (write_text, text) Made static.
7900 (text) Added to font support, not finished.
7902 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
7904 * font.h: (struct font_desc) New members ascent, descent.
7906 * groff-font.c: (groff_read_font) Calculates font ascent and
7907 descent from the ascent and descent of the `d' and `p' characters,
7908 respectively, as per a suggestion on comp.fonts.
7910 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
7911 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
7913 (write_text) Handles text right-justification and centering (not
7914 full justification). Still very inefficient. (One output line
7916 (struct output_char) Added fields for font and font size.
7917 (text) Many bugfixes.
7919 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
7921 * cmdline.c: (usage) Calls outp_list_classes().
7923 * font.h: Comment fix.
7925 * groff-font.c: New exported global var `space_index'.
7926 (groff_init) New function to initialize `space_index'.
7927 (hash_kern) Casts result to unsigned.
7928 (font_name_to_index) Renamed font_char_name_to_index. All
7929 references changed. Also, now returns the value of `space_index'
7930 when passed an ASCII space character as an argument. Fixed
7932 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
7933 Handles passed NULL pointers properly.
7935 * lexer.c: (parse_tagged_quote) Comment fix. Better range
7938 * output.c: (outp_list_drivers) Removed. Removed all references.
7940 * output.h: Comment fixes.
7942 * postscript.c: (ps_open_global) Calls groff_init().
7943 (output_char) New structure.
7944 (write_text) New function.
7945 (text) No longer stubbed out! Now the output is correct--with a
7946 few exceptions, one of them being that the page has to be held
7947 upside down into a mirror.
7949 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
7951 * font.h: Comment fix.
7953 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
7954 All callers changed.
7955 (number_to_index) Renamed font_number_to_index, made extern. All
7957 (font_get_kern_adjust, font_get_char_metrics) New functions.
7959 * output.h: New constant OUTP_T_INTERNAL_DRAW.
7961 * postscript.c: Changed default line width back to 1/2 point.
7962 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
7963 in the center of the space allotted for them, not just a fixed
7964 offset from the edge of the space; this fixes some bugs.
7965 (ps_line_intersection) Now supports all command line styles.
7966 (ps_text_get_size) Bug fix in computation of em width.
7967 (text) New function, the meat behind ps_text_metrics and
7968 ps_text_draw. Not complete.
7969 (ps_text_metrics, ps_text_draw) Removed the stub taken from
7970 ascii.c; call text().
7972 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
7974 * arena.c: (arena_free) Assert that the argument is non-NULL.
7976 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
7977 only if old_kern is non-NULL.
7979 * postscript.c: (ps_init_driver) Changed default line width to 1
7981 (postopen) New prologue variables.
7982 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
7983 more of the common line styles properly, but not all.
7984 (ps_text_metrics) Fixed problem with this stubbed out version that
7985 kept it from taking font sizes into account.
7987 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
7989 * arena.c: (arena_malloc) Bug fix.
7990 (arena_dump) [GLOBAL_DEBUGGING] New function.
7992 * ascii.c: Comment fix.
7993 (count_fancy_chars, delineate) Now static functions.
7995 * filename.c: (interp_vars) Bug fixes.
7997 * font.h: Comment fixes.
7999 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
8000 beginning in case we have an error message to display before
8001 initializing the display.
8003 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
8005 (groff_read_font) Bug fixes.
8006 (name_to_index) Increments hash.used. Sets `name' field of hash
8008 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
8010 * hash.c: Return type changed.
8012 * postscript.c: Continued development. Now marks lines on the
8013 paper, but very buggy.
8015 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
8017 * Changed comments in many source files from `/* xxx /* yyy */' to
8018 `/* xxx */ /* yyy */' for cleanliness.
8020 * arena.c: (arena_sd_strdup) New function.
8022 * ascii.c: (struct ascii_driver_ext) New member `file'.
8023 (ascii_init_driver) Fills out member `file' for initing; uses
8024 close_file_ext for closing drivers.
8025 (ascii_option) Changed %.*s back to %s because the a_string's are
8026 always null-terminated.
8027 (postopen, preclose) New functions.
8028 (ascii_open_page) Uses new style of open_file_ext.
8029 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
8030 instead of this->output.
8031 (__assert_fail) Removed.
8033 * cmdline.c: Changed syntax_message[].
8035 * error.c: #include's <readline/history.h> only if the history
8036 library is available, not if just the readline library is
8039 * filename.c: (expand_line) Removed alloca() support.
8040 (interp_vars) No longer tilde-expands argument. Limit on output
8042 (tilde_expand) Now treats argument as path rather than filename.
8043 [!unix] Now is a no-op function.
8044 (search_path) Better verbose message formatting.
8045 (open_file, close_file) Comment fixes.
8046 (close_file) [!unix] Doesn't bother with pipes.
8047 (open_file_ext) Completely rewritten, interface revamped.
8048 (close_file_ext) New function.
8050 * font.h: Comment changes.
8052 * frequencies.q: Removed AIX alloca support since it doesn't use
8055 * hash.c: Comment changes & additions.
8056 (hsh_create) Initializes entire table instead of first M entries.
8057 (hsh_probe) Stupid bug fixed. Now it works.
8058 (hsh_dump) [GLOBAL_DEBUGGING] New function.
8060 * main.c: (parse) Detects EOF properly in token-eating loop.
8061 Should the STOP token have its value changed to 0?
8063 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
8064 (blp_getline) Now it's a macro.
8066 * output.h: (struct outp_driver) Removed members output, filename.
8068 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
8069 drivers in driver table.
8070 (outp_read_devices) Frees buf. Warns if there are no active
8072 (outp_configure_clear) Sets outp_configure_vec to NULL after
8073 deleting its elements.
8074 (configure_driver, destroy_driver) Removed references to output,
8075 filename members of outp_driver.
8076 (outp_evaluate_dimension, internal_get_paper_size,
8077 outp_get_paper_size) New functions.
8079 * postscript.c: Continued development. Now links but doesn't make
8080 any marks on the page. Lotsa bugs I suppose.
8082 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
8084 * str.h: Comment changes.
8086 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
8088 * Removed dependencies on non-nested comments in several files.
8089 Also removed references to (unix || __unix__) in #if's since
8090 prefh.orig makes those two equivalent.
8092 * ascii.c: (ascii_open_global) Creates ascii_arena.
8093 (ascii_close_global) Destroys ascii_arena.
8094 (ascii_init_driver) Doesn't create ascii_arena.
8095 (ascii_copy_driver) Removed.
8096 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
8097 (outp_class ascii_class) Removed ascii_copy_driver reference.
8099 * frequencies.q: Now can display all statistics except median.
8102 * output.c: Handles outp_class.ref_count so output class
8103 destructors are called properly.
8104 (add_class) Sets ref_count to 0.
8105 (configure_driver) Initializes class if ref_count++ is 0.
8106 (destroy_driver) Destructs class if --ref_count is 0. Frees the
8107 class output file name.
8109 * output.h: (struct outp_class) Removed copy_driver, inited.
8112 * postscript.c: Completely replaced but not finished.
8114 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
8116 * approx.h: #includes <float.h>.
8118 * arena.h, arena.c: Many functions changed to take an arena **
8119 instead of an arena *, for consistency. All callers changed.
8120 (arena_alloc) Now creates a new arena if passed *A that is NULL.
8121 (arena_destroy) Sets *A to NULL.
8123 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
8124 assertion that `width' be positive.
8126 * command.c: Removed #if's from cmd_table.
8127 (walk_cmdtable_func) [0] New function (debug code).
8128 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
8129 (parse_cmd) Doesn't return failure for unimplemented commands.
8131 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
8132 (SYSCODE) New constant macro.
8134 * descript.q: Checks for positive n_variables before performing
8137 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
8138 avl_find instead of &fp as arg 2.
8140 * frequencies.g, frequencies.q: Continued updating; now compiles &
8141 works again, but not complete.
8143 * main.c: Changes to user messages.
8145 * misc.c: (reverse) [0] New function.
8147 * settings.h: Comment removed. #includes "common.h".
8149 * som.c: (som_set_null) New function.
8150 (som_set_value, som_set_string, som_set_text) More detailing
8152 (som_set_float) Implemented function.
8153 (dump_columnated_table) Bug fix regarding page breaks.
8154 (draw_cell) Bug fix regarding text that spilled out of a cell.
8155 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
8157 (get_cell_size) Support SCON_EMPTY cells.
8158 (get_table_size) When calculating rules' widths and heights, mask
8159 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
8161 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
8163 (struct som_submission_form) New member `header'; all users
8166 * val-labs.c: (get_label) User messages changed.
8168 * var.h: Changed FREQUENCIES structures.
8170 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
8173 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
8175 * approx.h: Definition of EPSILON now depends on system's
8176 DBL_EPSILON. Removed GNU C specific code.
8177 (cmpapx) Renamed approx_compare.
8179 * frequencies.g, frequencies.q: Continued updating; still doesn't
8182 * groff-font.c: (name_to_index) Fix bug that kept it from
8185 * hash.c, hash.h: Completed work.
8187 * var.h: Changes to freq_tab, frequencies_proc.
8189 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
8192 * hash.c, hash.h: New files. Not completed.
8193 * Makefile.am: Added hash.c to source file list.
8194 * font.h: (struct font_desc) New member kern_size_p.
8195 * groff-font.c: Uses hash.h.
8196 (hashpjw) Moved to hash.c.
8197 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
8199 (static var hash) New member size_p.
8200 * var.h: Includes hash.h.
8201 (struct freq_tab) Changed AVL_TREE to hash_tab.
8203 * vars-prs.c: Comment, formatting fixes.
8205 * frequencies.g, frequencies.q: Continued updating. Not yet
8208 * formats.c: Bug fix.
8210 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
8212 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
8213 * descript.g: Comment fixes.
8214 * descript.q: Comment fixes. Moved some declarations into var.h.
8215 Made dsc_info a static table. Updated FIXMEs.
8216 (internal_cmd_descriptives) Beautified.
8218 * frequencies.q: Started updating into working order.
8219 * frequencies.g: New file analogous to descript.g.
8220 * var.h: Comment fixes. Added structures for FREQUENCIES.
8222 * som.c: Removed vestiges of crushing and partial table support.
8224 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
8226 * Many more changes to som.c especially, but these will not be
8227 documented as I have resolved to remove them. This patchlevel is
8228 being released solely so that I can fall back to it if I decide
8229 that removing the changes is not a good idea.
8231 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
8233 * som.c: (global var som) New member `cum_y'.
8234 (build_target) Properly handles titles for partial tables.
8235 (dump_partial_beg, dump_partial_mid, dump_partial_end)
8236 Merged into single new function dump_partial(). Fixed problem
8237 with titles on partial tables.
8238 (dump_table) Calls dump_partial() for all parts of partial tables.
8239 (dump_page) Criteria for drawing title changed.
8241 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
8243 * command.c: (cmd_table) Added LIST, WEIGHT.
8245 * command.c: (cmd_remark) No longer frees `s' since it's not
8246 dynamically allocated.
8248 * data-out.c: (convert_f) Now correctly handles the case where
8249 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
8251 (som_destroy_all_tables) Removed argument. All callers changed.
8252 (som_vline, som_hline) Argument validity checking corrected.
8253 (som_set_value) Implemented half-heartedly.
8254 (replicate_table) Copies tables piece-by-piece when using Checker.
8256 * som.h: New line style SLIN_1THIN, currently equivalent to
8257 SLIN_0. New enum set SOM_SUB_*.
8258 (struct som_submission_form) Removed `seq_no'. Added `type'.
8260 * list.q: Newly working file; uses partial tables.
8262 * som.c: (som_reduce_table) Renamed som_set_table_height().
8263 (som_crush) Removed argument `group'.
8264 (global var som) Removed `nt', `seq_no'. Added `type'.
8265 (som_submit_table) Arguments changed.
8266 (output_table) Removed partial table code.
8267 (build_target) New arg; partial table support added. All callers
8269 (dump_plain_table) Removed partial table code.
8270 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
8271 (dump_table) Supports partial tables.
8272 (dump_page) New argument to allow not drawing top and/or bottom
8273 headers. All callers changed. Supports partial tables.
8275 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
8277 * data-out.c: Changed `#include <approx.h>' to `#include
8279 (convert_F) Comment fix. Now won't print `-.000', etc.
8281 * descript.q: Now Z-scores work, although there appears to
8282 be a bug (which might actually be in data-out.c:convert_F()).
8283 (descriptives_trns_proc, descriptives_trns_free) New functions.
8284 (run_z_pass) Implemented.
8286 * var.h: Comment fixes.
8287 (dsc_z_score, descriptives_trns) New structs.
8288 (descriptives_trns) Added to any_trns as `dsc'.
8290 * error.c, error.h: New error class, IS (Installation Script
8291 error), used in those instances where the error is in the
8292 installation, but there is a script file or installation file that
8293 can be usefully referred to.
8295 * output.c: Change many IE classes to IS classes.
8297 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
8298 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
8299 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
8300 include the corresponding header?
8302 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
8303 Don't bail out if termcap can't be read.
8305 * som.c: (som_destroy_table) Removed.
8306 (som_reduce_table, som_destroy_all_tables) New functions.
8307 (som_crush) New function, not implemented.
8309 * som.h: New table option STAB_CRUSH. Comment fix. New struct
8310 som_submission_form. Function prototypes revised.
8312 Outputting huge tables (1000s of rows) a few rows at a time
8313 is supported, though untested. May even break everything.
8314 Actually, the code doesn't even compile right now.
8315 * som.c: (struct som) New fields htv, nt, seq_no.
8316 (som_submit_table) Multiple arguments changed to a single
8317 pointer to struct submission_form. Only increments subtable_num
8318 if seq_no is zero. Only destroys table if it's not going to
8320 (replicate_table) New function.
8321 (output_table) Comment fix.
8322 (examine_table) Changed inline code to code calling
8323 replicate_table(). Calculates htv. Supports partial tables.
8324 (draw_title) Removed comment.
8325 (build_target) Only allows for title on first part of partial
8327 (dump_plain_table) Only resets table chunk number on first part
8328 of partial tables; FIXME: doesn't work quite right. Supports
8330 (dump_page) Titles only on first part of partial tables.
8332 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
8334 * Thanks to an unreliable IDE hard drive, I have spent the last
8335 day reconstructing my Debian GNU/Linux installation and redoing
8336 the previous day's changes--somehow I managed to save every file
8337 except for output.c and output.h. So the following changes could
8338 really be considered independent of the output.c, output.h changes
8341 * output.h, output.c: Moved the outp_configure_vec global var,
8342 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
8343 outp_configure_vec is now static.
8345 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
8347 * The entire philosophy behind configuration of the output drivers
8348 changed. Now there is a termcap-type configuration where drivers
8349 to be read are determined beforehand, rather than parsing the
8350 entire output init file and storing it in memory & deciding what
8351 to actually use later. Faster & more memory-efficient at the same
8354 * output.c: Comment fix. Removed outp_init_drivers global var.
8355 Removed all references to synonyms. New structure outp_defn. New
8356 global vars outp_macros, outp_configure_vec.
8357 (search_name, delete_name, add_name, check_configure_vec,
8358 expand_name, find_defn_value) New static functions.
8359 (outp_configure_clear, outp_configure_add, outp_configure_macro,
8360 outp_read_devices) New extern functions.
8361 (outp_init) Much functionality moved into outp_read_devices.
8362 (outp_read_devices) Format of output init file changed; name of
8363 file is `devices' rather than `output' to avoid Makefile
8365 (outp_clear) Renamed outp_done.
8366 (outp_list_classes) Bug fix, cleaned up.
8367 (outp_list_drivers) Not implemented anymore.
8368 (outp_configure_driver) Now a static function; simplified; now
8369 interpolates macros; supports new structure.
8370 (outp_enable_driver, match_synonym) Removed; all references
8372 (find_driver) First argument removed.
8374 * output.h: Global var outp_init_drivers removed; new structure
8375 outp_names; new enum set OUTP_S_*; new global var
8376 outp_configure_vec; function prototypes for output.c exports
8379 * main.c: (main) Calls outp_read_devices() after parsing the
8382 * cmdline.c: (parse_command_line) New option -v --verbose;
8383 --version changed to -V. --device option changed syntax to just
8384 take a single device name. Accepts key=value declaration of
8385 output init file macros. Syntax message updated.
8387 * filename.c: (expand_line) New function.
8388 (interp_environ_vars) Renamed interp_vars; no longer uses
8390 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
8391 overridden by real environment vars.
8392 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
8393 * filename.h: interp_environ_vars() renamed interp_vars().
8395 * error.c, error.h: Added extern variable `verbosity', message
8398 * error.c: (vmsg) Support message class MM.
8399 (verbose_msg) New function.
8401 * descript.q: (generate_z_varname) Bug fix in generation of
8403 (dump_z_table) Bug fix in column headers.
8405 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
8406 page from 29 to 15. Don't set a default for ops[OPS_INIT,
8407 OPS_DONE]. Writes the uninit string when the driver is closed.
8408 (ascii_open_page) Write the init string before the first page.
8409 (output_shorts) Form of main loop changed from `while' to `for'.
8410 Bug fix with overstrikes: the character is printed *after* the
8411 backspace. Eliminated a lot of `& 0xff' modifiers.
8412 (advance_to_left_margin) New function.
8413 (return_carriage, output_lines) Handle left margin.
8415 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
8417 * ascii.c: New option `carriage-return-style'.
8419 * ascii.c: (count_fancy_chars) New function.
8420 (delineate, text_metrics) Use new function; bug fixes regarding
8422 (text_draw) Bug fix with rich text.
8423 (output_string, output_shorts) Reordered.
8424 (output_shorts) Now handles boxchars and some overstrike font
8426 (output_char, return_carriage) New functions.
8427 (output_lines) Now handles overstriking and font changes properly;
8428 some code moved to output_shorts.
8430 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
8433 * ascii.c: New member `debug' in ascii_driver_ext.
8434 (ascii_init_driver, delineate) Uses new member.
8436 Now you can set a vertical height on writing text.
8437 * ascii.c: (delineate) Keeps track of vertical position.
8438 (text_draw) No longer considers fully justified text an internal
8441 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
8443 Tables' titles are drawn; they can have variable height.
8444 * som.c: `som' struct has new member, title_height.
8445 (draw_title) New argument. Moved within file. All caller
8447 (build_target) New argument, amount of space needed for first row.
8448 Calculates height of title, takes that into account. All callers
8450 (dump_plain_table, dump_columnated_table) Took calculation of y1,
8452 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
8454 (dump_columnated_table) Organized for readability.
8455 (dump_page) Makes use of som.title_height.
8457 * som.c: Many comment bug fixes.
8459 * descript.q: (try_name, generate_z_name) Bug fix regarding
8460 generation of Z-score variable names.
8461 * var.h: Removed num from descriptives_proc; all referents removed.
8463 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
8465 * ascii.c: (ascii_line_horz, ascii_line_vert,
8466 ascii_line_intersection) Added debugging code.
8468 Added a descriptive line above each table to describe it.
8469 * command.c: (parse_cmd) Calls som_new_series.
8471 * som.c: New static vars table_num, subtable_num. New `som'
8473 (dump_page) New arguments.
8474 (som_submit_table) Handle new variables.
8476 * som.c, som.h: (som_submit_table) New arguments. All callers
8478 (som_new_series) New function.
8479 (build_target) Makes room for extra line.
8480 (draw_title) New function.
8481 (dump_page) Calls draw_title. Bug fix: doesn't always set
8484 Columnation of tables support.
8485 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
8487 * som.c: Deleted references to fr, lr, ri.
8488 (som_columnate) Bux fix: sets group member of table.
8489 (som_add_options) Function removed.
8490 (dump_table) Split into three functions; extensively reworked.
8492 * descript.q: (dump_z_table) Better output table formatting; added
8493 title support to correspond to som.h changes.
8494 (display) Title support.
8496 * output.h: Added OUTP_T_NONE.
8498 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
8500 * descript.q: Improved handling of Z scores; still not perfect.
8502 * output.h, ascii.c: Added hook for getting em width of current
8505 * som.c: Uses new em-width hook. Added debugging code to
8507 (som_columnate) New argument.
8508 (som_add_options) Removed.
8510 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
8512 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
8513 rules as a property of the table instead of as a property of the
8516 * ascii.c: Added `header' to table of options.
8518 * descript.q: Added even shorter statistic names; modified to work
8519 with new som interface.
8521 * misc.c (blp_getdelim): Bug fix.
8523 * version.c: includes 'conf.h'.
8525 ----------------------------------------------------------------------
8528 version-control: never
projects / pspp-builds.git / blob