1 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
5 * dictionary.c: (dict_rename_var) Add assertion.
6 (dict_contains_var) Check by index instead of name.
8 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
10 Get rid of compaction_necessary, compaction_nval, compaction_case.
11 Redo VFM interface. Replace disk_sink and memory_sink by
12 storage_sink, disk_source and memory_source by storage_source.
14 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
18 (struct write_case_data) Remove `begin_func', `end_func',
19 `func_aux' members. Add `aux', `trns_case', `sink_case',
20 `cases_written', `cases_analyzed' members.
21 (global var compaction_necessary) Make static.
22 (global var compaction_nval) Removed.
23 (global var compaction_case) Removed.
24 (static var case_count) Removed.
25 (struct procedure_aux_data) Removed.
26 (struct split_aux_data) Removed.
27 (procedure) Remove begin_func, end_func parameters. Rewrite.
28 (static var not_canceled) Removed.
29 (process_active_file) Removed.
30 (process_active_file_write_case) Removed.
31 (process_active_file_output_case) Removed.
32 (prepare_for_writing) Moved into open_active_file().
33 (arrange_compaction) Ditto.
35 (open_active_file) Rewrote.
36 (write_case) New function.
37 [DEBUGGING] (index_to_varname) Removed.
38 (execute_transformations) New function.
39 (exclude_this_case) Renamed filter_case(), changed interface.
40 (clear_case) Added struct ccase * parameter to interface.
41 (close_active_file) Added struct write_case_data * parameter,
43 (disk_sink_create) Removed.
44 (disk_sink_destroy) Removed.
45 (disk_sink_make_source) Removed.
46 (disk_sink_write) Removed.
47 (disk_source_count) Removed.
48 (disk_source_destroy) Removed.
49 (disk_source_read) Removed.
50 (global var disk_sink_class) Removed.
51 (global var disk_source_class) Removed.
52 (global var memory_sink_class) Removed.
53 (global var memory_source_class) Removed.
54 (memory_sink_create) Removed.
55 (memory_sink_destroy) Removed.
56 (memory_sink_make_source) Removed.
57 (memory_sink_write) Removed.
58 (memory_source_count) Removed.
59 (memory_source_destroy) Removed.
60 (memory_source_get_cases) Removed.
61 (memory_source_read) Removed.
62 (memory_source_set_cases) Removed.
63 (struct disk_stream_info) Removed.
64 (struct memory_sink_info) Removed.
65 (struct memory_source_info) Removed.
66 (write_active_file_to_disk) Removed.
67 (destroy_storage_stream_info) New function.
68 (global var null_sink_class) New var.
69 (global var storage_sink_class) New var.
70 (global var storage_source_class) New var.
71 (open_storage_file) New function.
72 (storage_sink_destroy) New function.
73 (storage_sink_make_source) New function.
74 (storage_sink_open) New function.
75 (storage_sink_write) New function.
76 (storage_source_count) New function.
77 (storage_source_destroy) New function.
78 (storage_source_get_cases) New function.
79 (storage_source_on_disk) New function.
80 (storage_source_read) New function.
81 (storage_source_set_cases) New function.
82 (storage_source_to_disk) New function.
83 (storage_to_disk) New function.
84 (struct storage_stream_info) New structure.
85 (write_storage_file) New function.
86 (procedure_write_case) Removed.
87 (create_case_source) Add `struct dictionary *' parameter, all
89 (create_case_sink) Ditto.
90 (free_case_sink) New function.
91 (struct split_aux_data) New structure.
92 (procedure_with_splits) New function implementing what procedure()
94 (SPLIT_FILE_proc_func) Removed.
95 (procedure_with_splits_callback) New function.
96 (equal_splits) New function.
98 * aggregate.c: Pass around a struct instead of using statics.
99 (static var outfile) Remove.
100 (enum type) Give it tag `missing_treatment'.
101 (static var missing) Remove.
102 (static var sort) Remove.
103 (static var agr_first) Remove.
104 (static var agr_next) Remove.
105 (static var case_count) Remove.
106 (static var prev_case) Remove.
107 (static var buf64_1xx) Remove.
108 (static var buf_1xx) Remove.
109 (struct agr_proc) New structure incorporating the above.
110 (cmd_aggregate) Use new struct. Clean up error handling using
111 agr_destroy(). Completely rewrite actual implementation of
113 (create_sysfile) Add struct agr_proc * parameter, modify
115 (parse_aggregate_functions) Ditto.
116 (free_aggregate_functions) Ditto. Rename agr_destroy().
117 (aggregate_single_case) Add struct agr_proc * parameter, modify
119 (accumulate_aggregate_info) Ditto.
120 (dump_aggregate_info) Ditto.
121 (initialize_aggregate_info) Ditto.
122 (agr_00x_trns_proc) Removed.
123 (agr_00x_end_func) Removed.
124 (agr_10x_trns_proc) Removed.
125 (agr_10x_trns_free) Removed.
126 (agr_10x_end_func) Removed.
127 (agr_11x_read) Removed.
128 (agr_11x_finish) Removed.
129 [DEBUGGING] (debug_print) Removed.
130 (write_case_to_sfm) Add struct agr_proc * parameter, modify
132 (agr_to_active_file) New function.
133 (presorted_agr_to_sysfile) New function.
134 (sort_agr_to_sysfile) New function.
136 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
138 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
140 * descript.q: (cmd_descriptives) Ditto.
142 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
143 to new procedure() interface.
145 * command.c: (cmd_execute) Adapt to new procedure() interface.
147 * dictionary.c: (dict_compact_values) Also delete scratch
149 (dict_get_compacted_value_cnt) New function.
150 (dict_get_compacted_idx_to_fv) New function.
152 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
153 (cmd_flip) Adapt to new procedure() interface.
154 (flip_sink_write) Use sink->idx_to_fv.
156 * frequencies.q: (internal_cmd_frequencies) Use
157 procedure_with_splits().
159 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
160 (static var mtf_sink) New static var.
161 (static var mtf_case) New static var.
162 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
163 we actually implement the matching.
164 (mtf_delete_file_in_place) Use mtf_case.
165 (mtf_processing) Use mtf_case and mtf_sink.
166 (cmd_export) Adapt to new procedure() interface.
168 * levene.c: (levene) Use procedure_with_splits().
170 * list.q: (cmd_list) Use procedure_with_splits().
172 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
173 procedure() interface.
174 (read_matrices_with_rowtype) Ditto.
176 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
177 TEMPORARY. Adapt to new procedure() interface.
179 * rename-vars.c: Warn about and cancel TEMPORARY.
181 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
182 (sort_cases) Use dict_get_compacted_value_cnt() instead of
183 compaction_nval. Adapt to new procedure() interface. Use
184 storage_source_to_disk().
185 (do_internal_sort) Don't try to dump the cases to memory.
186 (compare_case_lists) Pass null idx_to_fv.
187 (struct initial_run_state) Add `idx_to_fv' member. Remove
189 (write_initial_runs) Don't initialize irs->case_size. Adapt to
190 new procedure() interface. Reset irs->idx_to_fv after calling
192 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
193 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
195 (destroy_initial_run_state) Don't dereference irs after freeing
197 (allocate_cases) Don't calculate case_size locally.
198 (compare_record) Add idx_to_fv parameter.
199 (compare_record_run) Change parameter from struct sort_cases_pgm *
200 to struct initial_run_state *. Pass irs->idx_to_fv to
202 (compare_record_run) Third parameter now a struct
204 (output_record) No need for out_case anymore. Pass irs, not
205 struct sort_cases_pgm to pop_heap(). Use case_size from struct
207 (merge) Use case_size from struct sort_cases_pgm.
208 (merge_once) Use case_size from struct sort_cases_pgm.
209 Pass null pointer to compare_record() as idx_to_fv.
210 (global var sort_sink_class) Make static.
212 * t-test.q: (cmd_t_test) Use procedure_with_splits().
214 * temporary.c: Remove debugging crap.
216 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
218 * t-test.q, levene.c: Fixed up the handling of MISSING values
221 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
223 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
226 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
228 Change explicit variable name checks into use of
229 dict_class_from_id().
231 * dictionary.c: (dict_create_var) Change explicit variable name
232 check into use of dict_class_from_id().
234 * get.c: (trim_dictionary) Ditto.
236 * sel-if.c: (cmd_filter) Ditto.
238 * sysfile-info.c: (cmd_display) Ditto.
240 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
242 * vfm.c: (arrange_compaction) Ditto.
244 * weight.c: (cmd_weight) Ditto.
246 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
248 * temporary.c: (cmd_temporary) When TEMPORARY was the first
249 transformation following the input program, if any, for some
250 reason we special-cased f_trns. That's just wrong. It should
251 always be set to n_trns.
253 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
255 * format.c: (parse_format_specifier_name) Fix brown-bag bug
256 introduced in last check-in.
258 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
260 * format.c: (global array translate_fmt[]) Removed.
261 (translate_fmt) New function as replacement.
262 (parse_format_specifier_name) Rewrite.
264 * pfm-read.c: (convert_format) Use translate_fmt() instead of
267 * sfm-read.c: (parse_format_spec) Ditto.
269 * postscript.c: (text) Fix handling of fonts with missing
272 * sort.c: (struct external_sort) Add temp_name member.
273 (destroy_external_sort) Free temp_dir, temp_name members.
274 (init_external_sort) Allocate temp_name.
275 (get_temp_file_name) Change prototype.
276 (open_temp_file) Deal with change to get_temp_file_name().
277 (close_temp_file) Ditto.
278 (remove_temp_file) Ditto.
279 (write_temp_file) Ditto.
280 (read_temp_file) Ditto.
281 (sort_sink_destroy) Removed.
282 (sort_sink_class) Change destroy member to null.
284 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
288 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
289 anymore. Use agr_11x_finish().
290 (aggregate_single_case) Make first param const.
291 (accumulate_aggregate_info) Ditto.
292 (agr_00x_end_func) Use compaction_case, not temp_case.
293 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
295 * data-list.c: (struct data_list_pgm) Add `case_size' member.
296 (cmd_data_list) Initialize case_size.
297 (read_from_data_list_fixed) Add struct ccase * param, use instead
299 (read_from_data_list_free) Ditto.
300 (read_from_data_list_list) Ditto.
301 (read_one_case) Rename data_list_trns_proc(), all references
302 updated. Add argument in calling above functions. Use c
303 argument instead of temp_case.
304 (destroy_dls) Rename data_list_trns_free(), all references
307 * expr-evl.c: (expr_evaluate) Make second parameter const.
309 * file-type.c: (struct file_type_pgm) Add `case_size' member.
310 (cmd_end_file_type) Initialize `case_size'.
311 (file_type_source_read) Add struct ccase * parameter. Use instead
316 * get.c: (struct get_pgm) New structure to keep track of
318 (cmd_get) Initialize case_size.
320 (get_source) Deal with struct get_pgm.
321 (get_source_read) Add struct ccase * parameter, use instead of
323 (import_source_read) Ditto.
325 * get.c: Use a null pointer instead of temp_case to represent the
326 "current case" in a struct mtf_file's input member.
327 (mtf_processing_finish) Pass null to mtf_processing(), not
329 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
330 (mtf_compare_BY_values) Add extra arg, use instead of null input
332 (mtf_processing) Use c parameter instead of temp_case. Pass
333 compaction_case to process_active_file_output_case().
335 * glob.c: (global variable temp_case) Removed.
337 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
338 (cmd_input_program) Initialize case_size. Set
339 vfm_source->value_cnt.
340 (init_case) Add struct ccase * parameter, use instead of
343 (input_program_source_read) Ditto.
345 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
346 (dump_cell_content) Ditto.
347 (nr_output_data) Ditto.
348 (read_matrices_without_rowtype) Ditto.
349 (matrix_data_read_with_rowtype) Ditto.
350 (wr_read_splits) Ditto.
351 (wr_output_data) Ditto.
353 * sort.h: (struct sort_cases_pgm) New member `case_size'.
355 * sort.c: (sort_cases) Initialize scp->case_size.
356 (struct external_sort) Remove `case_size' member.
357 (write_initial_runs) Only call vfm_sink->class_destroy if
359 (struct sort_source_aux) New structure.
360 (sort_source_read_helper) New function.
361 (sort_source_read) Use sort_source_read_helper().
362 (read_sort_output) Change interface to be more reasonable.
363 (read_internal_sort_output) Ditto.
364 (read_external_sort_output) Ditto.
366 * vars-prs.c: (dict_class_to_name) Pass return value through
369 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
370 (procedure) Initialize trns_case.
371 (procedure) Pass trns_case to vfm_source->class->read().
373 (process_active_file) Start using struct procedure_aux_data.
374 (process_active_file_write_case) Pass trns_case to
375 transformations, lag_case(), clear_case().
376 (process_active_file_output_case) Add struct ccase * parameter.
377 (create_trns_case) New function.
378 (make_temp_case) Removed.
379 (vector_initialization) Removed.
380 (close_active_file) Only call make_source if non-null, otherwise
381 set vfm_source to null pointer. Don't free temp_case.
382 (disk_source_read) Add struct ccase * parameter, use instead of
384 (memory_source_read) Ditto.
385 (lag_case) Add const struct ccase * member.
386 (procedure_write_case) Use trns_case instead of temp_case.
387 (clear_case) Add struct ccase * member, use instead of temp_case.
388 (exclude_this_case) Ditto.
389 (create_case_source) Add struct dictionary * parameter, use to
390 initialize source->value_cnt.
392 * vfm.h: (struct case_source) Add `value_cnt' member.
393 (struct case_source_class) Add struct ccase * parameter to `read'
394 member function pointer.
395 (struct case_sink_class) Make struct ccase * parameter const in
396 `write' member function pointer.
398 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
400 Fix a lot of "possibly uninitialized variable" warnings. Some of
401 them are even real bugs. A few of them make me wonder how the
404 * aggregate.c: (parse_aggregate_functions) Initialize `function.
406 * ascii.c: (output_lines) Add default case to switch.
408 * crosstabs.q: Remove static variable `expected' and all
410 (display_crosstabulation) Always calculate expected value.
412 (output_pivot_table) Initialize `cmp'.
413 (display_crosstabulation) New variable `last_row', which is
416 * data-in.c: (parse_numeric) Always initialize sign. How did this
419 * data-list.c: (repeating_data_trns_proc) Always initialize code.
420 Always set info.ofs. (How did this work?!)
422 * expr-opt.c: (optimize_tree) Always initialize `m'.
423 (evaluate_tree) Always initialize `c'. (How did this work?)
425 * frequencies.q: (frq_custom_variables) Always initialize min,
427 (frq_custom_grouped) Always initialize `dl'.
429 * groff-font.c: (groff_read_font) Always initialize char_set.
431 * matrix-data.c: (nr_output_data) Initialize `split'.
432 (wr_read_splits) Remove shadowing split_cnt declaration.
433 (wr_output_data) Initialize `split'.
435 * output.c: (tokener) Skip add character on syntax error.
437 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
439 * postscript.c: (read_ps_encodings) Use line.string instead of
441 (write_text) Add default case to switch.
442 (text) Always initialize multiple variables. Fix bug with
445 * print.c: (fixed_parse_fortran) Initialize head.
446 (alloc_line) Add default case to switch.
448 * recode.c: (parse_dest_spec) Handle case where nothing matches.
449 (recode_trns_proc) Move variable declaration inward. Add default
452 * sfm-read.c: (read_header) Initialize skip_amt.
454 * sysfile-info.c: (display_variables) Always initialize pc.
456 * vars-prs.c: Initialized `included'.
458 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
460 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
461 Just use signal() instead.
463 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
465 Get rid of vfm_sink_info and vfm_source_info.
467 * aggregate.c: (agr_00x_end_func) Don't increment
468 sfm_sink_info.ncases.
470 * sort.c: (do_internal_sort) Get case count from
471 vfm_source->class->count().
472 (struct external_sort) Add `case_size' member.
473 (do_external_sort) Initialize case_size.
474 (struct initial_run_state) Add `case_size' member.
475 (write_initial_runs) Initialize case_size.
476 (sort_sink_write) Use case_size.
477 (read_external_sort_output) Use case_size. Get case_cnt from
480 * vfm.c: (struct write_case_data) Add underscores to existing arg
481 names, all references updated. Renamed `aux' as `func_aux', all
482 references updated. Added new `aux' member.
483 (global var vfm_source_info) Removed.
484 (global var vfm_sink_info) Removed.
485 (struct procedure_aux_data) New.
486 (struct split_aux_data) New.
487 (procedure) Use `aux' fields for procedure_aux_data,
489 (process_active_file_write_case) Pass case_count + 1 to
490 transformation procedures, exclude_this_case().
491 (process_active_file_output_case) Don't increment
492 vfm_sink_info.ncases.
493 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
494 to send data to disk early.
495 (make_temp_case) Don't use vfm_sink_info.case_size.
496 (close_active_file) Don't initialize vfm_source_info.
497 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
498 (disk_sink_create) Initialize and/or update disk_stream_info.
499 (disk_sink_write) Ditto.
500 (disk_sink_destroy) Ditto.
501 (disk_sink_make_source) Ditto.
502 (disk_source_read) Ditto.
503 (disk_source_destroy) Ditto.
504 (global var disk_source_class) Add disk_source_count().
505 (disk_source_count) New function.
506 (struct memory_sink_info) Add `case_cnt', `case_size' members.
507 (struct memory_source_info) Ditto.
508 (memory_sink_create) Deal with case_cnt, case_size.
509 (memory_sink_write) Ditto.
510 (memory_sink_make_source) Ditto.
511 (memory_source_read) Ditto.
512 (memory_source_count) New function.
513 (memory_source_class) Add memory_source_count().
514 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
515 proc_aux->cases_written, and pass it to transformation procedures
516 and exclude_this_case ().
517 (exclude_this_case) Add case_num parameter. Pass it to
519 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
522 * vfm.h: (struct case_source_class) Add `count' member.
524 * vfmP.h: (struct stream_info) Removed.
525 (global variable vfm_source_info) Removed.
526 (global variable vfm_sink_info) Removed.
528 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
530 * var.h: (typedef trns_proc_func) New typedef.
531 (trns_free_func) New typedef.
532 (struct trns_header) Change `proc' to type trns_proc_func, `free'
533 to type trns_free_func. This only changes the actual type of
534 trns_proc_func, adding a `case_num' parameter. Updated all
535 implementations to use the typedefs instead.
537 * compute.c: (compute_num) Pass case_num to expr_evaluate().
538 (compute_num_vec) Ditto.
540 (compute_str_vec) Ditto.
542 * do-if.c: (do_if_trns_proc) Ditto.
544 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
547 * inpt-pgm.c: (input_program_source_read) Maintain case count,
548 pass to transformation functions.
549 (reread_trns_proc) Pass case_num arg to expr_evaluate().
551 * loop.c: (loop_1_trns_proc) Ditto.
552 (loop_2_trns_proc) Ditto.
553 (loop_3_trns_proc) Ditto.
555 * print.c: (print_space_trns_proc) Ditto.
557 * sel-if.c: (select_if_proc) Ditto.
559 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
561 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
562 destroying hash table.
564 * glob.c: (read_active_file) Variable not referenced, removed.
565 (cancel_input_pgm) Ditto.
567 * levene.c: Add #include <stdlib.h> needed to call free().
569 * aggregate.c: (parse_aggregate_functions) Make `function'
572 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
574 Start working to eliminate VFM dependence on static variables.
576 * command.c: (cmd_parse) Use case_source_is_class().
578 * data-list.c: Rewrite to eliminate use of static variables.
580 * dfm.c: (cmd_begin_data) Use case_source_is_class().
582 * file-handle.q: (fh_handle_name) Make parameter const.
584 * file-type.c: Rewrite to eliminate use of static variables.
586 * flip.c: Rewrite to eliminate use of static variables.
588 * format.c: (get_format_var_width) New function.
590 * get.c: Eliminate use of static variables.
592 * inpt-pgm.c: Eliminate use of static variables.
594 * matrix-data.c: Eliminate use of static variables.
596 * set.q: (set_max_workspace) New variable.
597 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
599 * var.h: (struct case_list) Move here from vfmP.h.
601 * vars-atr.c: (discard_variables) Handle new vfm_source type.
603 * vfm.c: (vfm_source) Change type from struct case_stream to
605 (vfm_sink) Change type from struct case_stream to struct
607 (static var paging) Rename workspace_overflow, all references
609 (procedure) Use new class structures.
610 (process_active_file) Ditto.
611 (process_active_file_write_case) Ditto.
612 (prepare_for_writing) Use set_max_workspace. Use new class
614 (close_active_file) Use new class structures. Free old sink.
615 (global var disk_source_file) Removed.
616 (global var disk_sink_file) Removed.
617 (disk_stream_init) Removed.
618 (disk_stream_read) Removed.
619 (disk_stream_write) Removed.
620 (disk_stream_mode) Removed.
621 (disk_stream_destroy_source) Removed.
622 (disk_stream_destroy_sink) Removed.
623 (global var vfm_disk_stream) Removed.
624 (disk_sink_create) New function.
625 (disk_sink_write) New function.
626 (disk_sink_destroy) New function.
627 (disk_sink_make_source) New function.
628 (disk_sink_class) New static var.
629 (disk_source_read) New function.
630 (disk_source_destroy) New function.
631 (global var vfm_source_class) New var.
632 (global var memory_source_cases) Removed.
633 (global var memory_sink_cases) Removed.
634 (global var memory_sink_max_cases) Removed.
635 (struct memory_sink_info) New struct.
636 (memory_stream_init) Removed.
637 (memory_stream_read) Removed.
638 (memory_stream_write) Removed.
639 (memory_stream_mode) Removed.
640 (memory_stream_destroy_source) Removed.
641 (memory_stream_destroy_sink) Removed.
642 (global var vfm_memory_stream) Removed.
643 (page_to_disk) Renamed write_active_file_to_disk().
644 (memory_sink_create) New function.
645 (memory_sink_write) New function.
646 (memory_sink_destroy) New function.
647 (memory_sink_make_source) New function.
648 (memory_sink_class) New static var.
649 (memory_source_read) New function.
650 (memory_source_destroy) New function.
651 (memory_source_get_cases) New function.
652 (memory_source_set_cases) New function.
653 (global var vfm_source_class) New var.
654 (procedure_write_case) Use new class structures.
655 (create_case_source) New function.
656 (case_source_is_complex) New function.
657 (case_source_is_class) New function.
658 (create_case_sink) New function.
660 * vfm.h: (global variable reinit_sysmis) Not used, removed.
661 (global variable reinit_blanks) Not used, removed.
662 (global variable init_zero) Not used, removed.
663 (global variable init_blanks) Not used, removed.
664 (struct case_source) New struct.
665 (struct case_source_class) New struct.
666 (struct case_sink) New struct.
667 (struct case_sink_class) New struct.
668 (struct case_stream) Removed.
670 * vfmP.h: (struct case_list) Moved to var.h.
672 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
674 * algorithm.c: (count_equal) New function.
675 (count_if) New function.
676 (unique) Add assertions.
677 (partition) Add assertions.
678 (is_partitioned) New function.
679 (copy_if) Add assertions.
680 (remove_equal) Add assertions.
681 (lexicographical_compare) Rename lexicographical_compare_3way.
682 (sort) Add assertions. Rephrase some code.
683 (is_sorted) New function.
685 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
689 * sort.c: Completely rewrite.
691 * sort.h: Expose interface via struct sort_cases_pgm, not via
694 * aggregate.c: (sort) New static var.
695 (cmd_aggregate) Use sort.
696 (create_sysfile) Ditto.
697 (aggregate_single_case) Ditto.
698 (dump_aggregate_info) Ditto.
699 (agr_00x_end_func) Ditto.
702 * var.h: (enum SRT_ASCEND) Removed.
703 (enum SRT_DESCEND) Removed.
704 (struct sort_cases_proc) Removed.
705 (struct variable) Remove p.srt member.
707 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
709 Get rid of the old, crappy heap structure and replace it by a new,
710 shiny, C++ STL-like heap structure.
712 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
714 * algorithm.c: (push_heap) New function.
725 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
727 Increase warning level.
729 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
731 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
733 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
735 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
737 * dictionary.c: (dict_create_var) Fix root cause of bug worked
738 around by previous change log entry.
740 * compute.c: (lvalue_finalize) Remove workaround from previous
743 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
745 * compute.c: Fixed a bug where the Format was not getting set for
746 computed variables (thus causing a crash when SAVEing).
748 * Added a test to stop this bug ever coming back
750 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
752 Got rid of approx.h. In general, replaced all references to
753 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
756 * Makefile.am: (pspp_SOURCES) Removed approx.h.
758 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
759 test for mag < EPSILON.
761 * misc.h: Add definition of EPSILON.
763 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
765 * vfm.c: (procedure) Add check to prevent recursive call.
767 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
769 * Moved the declarations relating to values to their own header file
772 * Added levene.c and levene.h
774 * vars-atr.c: Changed the signature of compare_values to
775 take const * arguments.
777 * t-test.q: Changed the structure of struct t_test_proc
778 variables now contain their own group statistics information.
779 Eventually, t_test_proc might get renamed, because it'd be
780 applicable to other commands too.
782 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
784 * data-out.c: Clean up. Changed interface of convert_*() to take
785 either a `double' or a `const char *' instead of a `const union
786 value *'. Update all implementations of those interfaces.
787 (data_out) Use switch statements instead of a table.
788 (convert_AHEX) Rewrite.
790 * format.h: Update comment.
792 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
794 * q2c.c: (dump_header) Add an Emacs header line to output files
795 that makes generated .c files read-only by default, to make it
796 difficult to accidentally change generated files.
798 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
800 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
801 not bogus a->v.c <=> b->v.c pointer compare.
802 (compare_freq_alpha_a) Ditto.
803 (compare_freq_numeric_d) Ditto.
804 (compare_freq_alpha_d) Ditto.
806 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
808 Changed data_out() to store string data directly into a `union
809 value''s s member, not indirectly into c.
811 * crosstabs.q: (output_pivot_table) Use format_short() instead of
813 (table_value_missing) Ditto.
814 (float_M_suffix) Ditto.
815 (format_short) New function.
817 * data-in.h: (data_in_finite_line) Remove inline definition.
819 * data-list.c: (destroy_dls_var_spec) New function.
820 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
821 (data_list_source_destroy_source) Avoid cast.
822 (struct repeating_data_trns) New field `id_value'. Update
824 (cmd_repeating_data) Initialize id_value. Use new
825 repeating_data_trns_free() for freeing REPEATING DATA
827 (rpd_parse_record) Rewrite support for record ID to be less bogus.
828 (repeating_data_trns_free) New function.
830 * data-out.c: (data_out) Change return type to `void' by replacing
831 error returns by writing a message into the output buffer.
832 (convert_A) Read from v->s instead of v->c.
833 (convert_AHEX) Ditto.
835 * expr-evl.c: Update comment.
836 (expr_evaluate) Add assertion in OP_STRING case.
838 * format.h: (macro MAX_FORMATTED_LEN) New macro.
840 * list.q: (list_cases) Update for new data_out() semantics.
842 * print.c: (print_trns_proc) Ditto.
844 * tab.c: (tab_value) Ditto.
845 (tab_float) Avoid stupid cast.
847 * var.h: Update comments.
848 (macro MAX_STRING) New macro.
849 (macro MAX_ELEMS_PER_VALUE) New macro.
851 * vars-atr.c: (compare_values) New function.
853 * vfm.c: (dump_splits) Update for new data_out() semantics.
855 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
857 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
859 (struct crosstab) Rename v[] to vars[]. All references updated.
860 (hash_table_entry) Replace the hash algorithm and fix a bug at the
861 same time, which caused the hash value to depend only on a single
862 value, not all of the variables' values.
864 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
866 Clean up struct dictionary's value_cnt usage.
868 * dictionary.c: Add a function comment to each function.
869 (struct dictionary) Rename value_cnt to next_value_idx, which more
870 accurately reflects its meaning. All references updated.
871 (dict_rename_vars) Add assertion.
872 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
874 (dict_get_case_size) New function.
876 * aggregate.c: (create_sysfile) Use dict_get_case_size().
878 * get.c: (mtf_read_nonactive_records) Ditto.
880 * sort.c: (allocate_cases) Ditto.
881 (write_initial_runs) Ditto.
885 * vfm.c: (prepare_for_writing) Ditto.
889 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
891 Make vfm.c slightly less grotesque.
893 * vfm.c: (filter_var) Removed.
894 (filter_index) Removed.
895 (FILTERED macro) Removed.
896 (exclude_this_case) New function.
897 (process_active_file_write_case) Use exclude_this_case() instead
898 of FILTERED and inline tests.
899 (procedure_write_case) Ditto.
900 (setup_filter) Removed.
901 (open_active_file) Don't call setup_filter().
902 (close_active_file) Call dict_get_filter() instead of checking
905 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
907 * var.h: (struct variable) Update comments.
909 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
911 New functions dict_create_var_assert(), dict_lookup_var_assert().
912 Converted several dict_*_var()/assert pairs into a single
915 * dictionary.c: (dict_create_var_assert) New function.
916 (dict_lookup_var_assert) New function.
918 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
920 Got rid of "struct long_vec", envector(), devector(), etc. Added
921 two members `init', `reinit' to struct variable as a substitute.
923 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
929 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
932 * autorecode.c: (cmd_autorecode) destvars don't need init.
934 * compute.c: (lvalue_finalize) Set reinit.
936 * data-list.c: (fixed_parse_compatible) Don't need init usually.
937 (dump_fmt_list) Ditto.
940 * descript.q: (run_z_pass) Don't need init for z-scores.
942 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
944 (dict_clone_var) Copy `reinit' member, initialize `init' member.
946 * glob.c: (init_glob) Remove vec_init() calls.
948 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
950 * loop.c: (internal_cmd_loop) Don't need to call envector().
952 * numeric.c: (cmd_numeric) Ditto.
954 (cmd_leave) Ditto. Set `init', `reinit' members.
956 * recode.c: (cmd_recode) Don't need to call envector().
958 * repeat.c: (internal_cmd_do_repeat) Ditto.
960 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
961 (force_create_variable) Removed prototype.
962 (force_dup_variable) Ditto.
964 * vector.c: (cmd_vector) Don't need to call envector().
966 * vfm.c: (reinit_sysmis) Removed.
967 (reinit_blanks) Removed.
969 (init_blanks) Removed.
970 (process_active_file_write_case) No need to deal with vectors.
971 Call clear_temp_case().
972 (vector_initialization) Rewrite to use `init', `reinit'.
973 (close_active_file) No need to call vec_clear().
974 (procedure_write_case) Call clear_temp_case().
975 (clear_temp_case) New function.
977 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
979 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
982 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
984 Add auxiliary argument to procedure() interface. Associated small
985 clean-ups of vfm interface.
987 * Updated every caller of procedure() and process_active_file() to
988 reflect modified interface. Simple, ordinary changes not listed
991 * Updated every function that implements struct case_stream's
992 `read' function to take a write_case_func and a write_case_data.
993 Also updated every caller of write_case() to instead call them
994 through these arguments. In some cases this meant that the extra
995 args had to be threaded through a couple of extra levels. This
996 wasn't difficult or interesting so the details won't be given.
998 * data-list.c: (struct repeating_data_trns) Add members
999 `write_case', `wc_data' as kluge.
1000 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
1002 (repeating_data_set_write_case) New function.
1004 * data-list.h: New file to declare repeating_data_trns_proc() and
1005 repeating_data_set_write_case().
1007 * inpt-pgm.c: (input_program_source_read) Call
1008 repeating_data_set_write_case() for all the REPEATING DATA
1009 transformations, so that they know where to send their cases.
1010 It's a big kluge. Also kluge in END CASE.
1011 (end_case_trns_proc) Never called anymore, but we still need it,
1014 * sort.c: (read_sort_output) Update to match struct case_stream
1017 * vfm.c: (struct write_case_data) New structure.
1018 (proc_func) Removed.
1019 (virt_proc_func) Removed.
1020 (begin_func) Removed.
1021 (virt_begin_func) Removed.
1023 (write_case) Removed.
1024 (procedure) Added an auxiliary parameter to each function pointer
1025 argument's prototype. Added an auxiliary data parameter.
1027 (process_active_file) Ditto.
1028 (process_active_file_write_case) Pass aux data along.
1029 (close_active_file) Ditto.
1030 (procedure_write_case) Ditto.
1031 (SPLIT_FILE_procfunc) Ditto.
1033 * vfm.h: (typedef write_case_data) New.
1034 (typedef write_case_func) New.
1035 (struct case_stream) Add parameters to `read' member prototype.
1037 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
1039 * t-test.q: Added calculations for independent samples. (But no Levene
1042 * Makefile.am: Moved q_sources_c into own variable
1044 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
1046 Miscellaneous cleanups.
1048 * Change unused to UNUSED in many source files to reflect modified
1049 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
1050 __CYGWIN32__, __unix__, and unix not to assume that they're
1051 defined to a nonzero value. Change use of __attribute__ to use
1052 NO_RETURN or PRINTF_FORMAT instead.
1054 * alloc.h: Move definitions for local_alloc(), local_free() here
1055 from ../pref.h.orig and simplify.
1057 * expr-evl.c: Instead of working differently based on PAGED_STACK,
1058 use a pool allocator unconditionally.
1059 (CHECK_STRING_SPACE) Removed.
1060 (ALLOC_STRING_SPACE) Removed.
1061 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
1064 * expr-opt.c: (dump_expression) Allocate string pool.
1066 * expr-prs.c: (expr_free) Free string pool.
1068 * pool.c: (pool_destroy) This pool must be removed from its
1069 parent's list of gizmos, not from its own. Use free_all_gizmos().
1070 (pool_clear) New function.
1071 (free_all_gizmos) New function.
1072 (pool_alloc) Use space in empty block after this one if any.
1073 (pool_release) Only empty out blocks, don't actually free() them.
1075 * print.c: Get rid of PAGED_STACK special case by always
1076 dynamically allocating line buffers.
1077 (struct print_trns) Always include the `line' member.
1078 (internal_cmd_print) Always initialize the `line' member.
1079 (alloc_line) Always allocate memory for `line'.
1080 (print_trns_proc) Always initialize buf from `line' member.
1081 (print_trns_free) Always free `line' memory.
1083 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
1086 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
1088 * flip.c: Fixed crash from FLIP when a numeric variable is
1089 specified on NEWNAMES and a large value is used, and a couple of
1090 other minor bugs besides.
1091 (struct varname) Make name a 9-character fixed-size array
1092 instead of a 1-character variable size array.
1093 (make_new_var) Allow digits in variable names.
1094 (flip_stream_write) Limit numeric values to 8 characters and
1095 format system missing and very large and small values more
1098 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1100 * command.c: Fixed test on command return status for the correct
1101 value, which had been causing a crash under certain invalid input.
1103 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1105 * t-test.q: Added calculations for the one sample variant of the T-TEST
1107 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
1109 * tab.c: (render_strip) Fix bug that sometimes caused joined text
1110 in joined cells to be rendered outside box boundaries.
1112 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1114 * random.c (rng_create): Fixed seeding so that it gets reseeded after
1115 SET seed=xx has been called.
1117 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
1119 * random.c (rng_get_double): Fix always-returning-zero bug in my
1120 preferred way, and at the same time make sure rounding doesn't
1123 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
1125 * html.c: (change_attributes) Dead code, removed.
1126 (escape_string) Eliminate code to call change_attributes() that
1127 never actually called it.
1128 (output_tab_table) Get rid of dependence on tab_hit
1129 and struct tab_joined_cell's hit member, which are abominations.
1131 * tab.c: (tab_output_text) Don't call
1132 d->class->text_set_font_by_name if it's a null pointer.
1133 (macro UNROLL_LOOP) Eliminate.
1134 (macro UNROLL_3_LOOPS) Eliminate.
1135 (tabi_render) Rewrite not to use the above macros.
1137 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
1139 Start working on a new output driver system, one that doesn't suck
1140 so much, by adding a "device-independent" output driver. The idea
1141 is to write out only a single output stream, then use separate
1142 processes to translate them into whatever formats we want. This
1143 is similar to how "groff" works with its various output drivers
1144 (grops, grotty, grodvi, ...).
1146 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
1148 * list.q: (write_all_headers) Stub out devind class.
1150 (determine_layout) Ditto.
1153 * output.c: (outp_init) Add devind class.
1155 * devind.c: New file.
1157 * devind.h: New file.
1159 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
1161 * frequencies.q: (hash_value_alpha) Fixed up the previous change
1162 to use the proper string length.
1164 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1166 * Fixed bug where FREQ would crash on alpha values
1168 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
1170 * Removed bletcherous alloca() workarounds for AIX from top of
1171 many files. AIX can use the alternative alloca() implementation
1174 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
1176 * ascii.c: (ascii_option) Fix implementation of headers option.
1178 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
1180 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
1181 multiple blank lines into one.
1182 (struct ascii_driver_ext) Add squeeze_blank_lines option.
1183 (ascii_preopen_driver) Initialize squeeze_blank_lines.
1184 (static var option_tab) Add squeeze entry.
1185 (ascii_option) Set squeeze_blank_lines.
1186 (output_lines) Implement squeezing blank lines.
1188 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
1190 * Removed redundant code from output.h
1192 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
1194 Dictionary classes: each variable is "ordinary", "system", or
1197 * var.h: (enum dict_class) New enum.
1199 * vars-prs.c: (dict_class_from_id) New function.
1200 (dict_class_to_name) New function.
1202 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
1204 * var.h: (struct freq_tab_set) Removed (not used).
1206 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
1208 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
1210 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
1212 * stats.c: (hypercube) Rename pow4(). All references updated.
1214 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
1216 * rename-vars.c: (cmd_rename_variables) Rewritten.
1217 (compare_name) Removed.
1219 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
1221 var_set feature, and code taking advantage of it.
1223 * crosstabs.q: (static var var_dict) Removed.
1224 (static var variables) New variable.
1225 (static var variables_cnt) New variable.
1226 (cmd_crosstabs) Free variables instead of var_dict.
1227 (internal_cmd_crosstabs) Initialize and use variables,
1228 variables_cnt instead of var_dict.
1229 (free_var_dict) Removed.
1230 (crs_custom_tables) Use var_set instead of a copied dictionary.
1231 (crs_custom_variables) Set up variables, variables_cnt instead of
1233 [DEBUGGING] (debug_print) Ditto.
1235 * means.q: (mns_custom_tables) Use var_set instead of a copied
1238 * vars-prs.c: (parse_vs_variable) New function.
1239 (parse_dict_variable) Rewritten.
1240 (parse_variable) Rewritten.
1241 (parse_variables) Renamed parse_var_set_vars(), rewritten.
1242 (parse_variables) New function in terms of parse_var_set_vars().
1243 Now requires its first argument to be non-null. All references
1244 that passed a null pointer updated to pass default_dict instead.
1245 (macro id_dict) Removed.
1246 (parse_DATA_LIST_vars) Add assertions.
1247 (parse_mixed_vars) Ditto.
1248 (struct var_set) New structure.
1249 (var_set_get_cnt) New function.
1250 (var_set_get_var) New function.
1251 (var_set_lookup_var) New function.
1252 (var_set_destroy) New function.
1253 (dict_var_set_get_cnt) New function.
1254 (dict_var_set_get_var) New function.
1255 (dict_var_set_lookup_var) New function.
1256 (dict_var_set_destroy) New function.
1257 (var_set_create_from_dict) New function.
1258 (struct array_var_set) New structure.
1259 (array_var_set_get_cnt) New function.
1260 (array_var_set_get_var) New function.
1261 (array_var_set_lookup_var) New function.
1262 (array_var_set_destroy) New function.
1263 (var_set_create_from_array) New function.
1265 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
1266 instead of parse_variables(NULL, ...) in output code.
1268 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
1270 Change inp_init from a 2-bit vector to an ordinary array.
1271 Initialize it all in cmd_end_input_program() instead of in
1274 * inpt-pgm.c: (enum value_init_type) New enum.
1275 (global var inp_init) Change to `enum value_init_type *', make
1277 (inp_init_size) Removed.
1278 (inp_nval) Change to `size_t', make static.
1279 (cmd_input_program) Don't initialize inp_init or inp_init_size.
1280 (cmd_end_input_program) Initialize inp_init, inp_nval.
1281 (init_case) Rewrite.
1282 (clear_case) Rewrite.
1284 * inpt-pgm.h: Removed.
1286 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
1288 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
1289 Colin Plumb hash. It is simpler and should better resist
1291 (hsh_hash_string) Ditto.
1293 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
1295 * get.c: (export_write_case_func) Remove debug printing code.
1297 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
1299 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
1301 (save_write_case_func) Use &trns->h instead of cast.
1302 (cmd_export) Use &t->h instead of cast.
1304 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
1306 Moved vectors into the dictionary.
1308 * var.h: (struct vector) Moved here from vector.h. `index' member
1309 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
1312 * vector.h: Removed.
1314 * vector.c: (global var vec) Removed.
1315 (global var nvec) Removed.
1316 (cmd_vector) Rewritten.
1317 (find_vector) Removed.
1319 * dictionary.c: (dict_create_vector) New function.
1320 (dict_get_vector) New function, replaces reading global vec[]
1322 (dict_get_vector_cnt) New function, replaces reading global nvec
1324 (dict_lookup_vector) New function, replaces find_vector().
1325 (dict_clear_vectors) New function.
1327 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
1329 Start to move away from `struct variable' p `union' member to void
1332 * var.h: (struct variable) Add `aux' member.
1334 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
1336 Get rid of struct variable `foo' member.
1338 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
1340 (frq_custom_variables) Ditto.
1341 (frq_custom_grouped) Ditto.
1343 * get.c: (struct save_trns) Change `var' member from `int *' to
1344 `struct variable **'.
1345 (cmd_save_internal) Use aux instead of foo.
1346 (save_trns_proc) Use revised `var' member.
1347 (static var mtf_seq_no) Renamed mtf_seq_num.
1348 (static var mtf_seq_nums) New static var.
1349 (cmd_match_files) Initialize mtf_seq_nums.
1350 (mtf_free) Free mtf_seq_nums.
1351 (mtf_processing) Use mtf_seq_nums instead of foo.
1352 (mtf_merge_dictionary) No need to initialize mv->foo.
1353 (cmd_export) Use aux instead of foo. Use revised `var' member.
1354 (mns_custom_tables) Don't use foo to check for duplicates, that's
1355 what PV_NO_DUPLICATE is for.
1357 * var.h: (struct variable) Remove `foo' member.
1358 (struct frequencies_proc) New member.
1360 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
1362 Clean up COMPUTE and IF.
1364 * compute.c: More or less rewrite the darn thing.
1365 (struct compute_trns) Rename and reorder and add and delete
1367 (cmd_compute) Rewrite.
1368 (compute_num) Make conditional on test expression. Now used for
1369 both COMPUTE and IF.
1370 (compute_num_vec) Ditto.
1371 (compute_str) Ditto.
1372 (compute_str_vec) Ditto.
1375 (if_num_vec) Removed.
1377 (if_str_vec) Removed.
1378 (parse_target_expression) Renamed parse_rvalue_expression(),
1380 (new_trns) Renamed compute_trns_create(), rewritten.
1381 (delete_trns) Removed.
1382 (free_trns) Renamed compute_trns_free(), rewritten.
1383 (struct lvalue) New structure.
1384 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
1385 (lvalue_get_type) New function.
1386 (lvalue_is_vector) New function.
1387 (lvalue_finalize) New function.
1388 (lvalue_destroy) New function.
1390 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
1392 * command.def: Disallow MODIFY VARS in input mode, so that
1393 variables can't get dropped and confuse cmd_end_input_program()'s
1394 attempt to fill inp_init[].
1396 * modify-vars.c: (static var forward_positional_ordering) New
1398 (struct var_modification) Entirely changed.
1399 (rearrange_dict) Interface changed, rewritten.
1400 (cmd_modify_vars) Deal with modified struct var_modification, much
1402 (struct var_renaming) New structure.
1403 (compare_var_renaming_by_new_name) New function.
1404 (validate_var_modification) New function.
1406 * var.h: (struct modify_vars_proc) Removed.
1407 (struct variable) Removed member p.mfv.
1409 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
1411 Make EVALUATE a valid command whether we're debugging or not, so
1412 that `make check' can succeed regardless of whether debugging is
1415 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
1417 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
1419 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
1421 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
1422 statement by a simple if test.
1424 * dfm.c: (dfm_get_record) Add assertion.
1426 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
1428 For each file x.c, move #include "x.h" to the very top of the
1429 include list, to catch x.h failing to include the proper headers.
1431 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
1433 * algorithm.c: (find) New function.
1434 (remove_equal) New function.
1435 (set_difference) New function.
1436 (adjacent_find_equal) New function.
1437 [TEST_UNIQUE] Removed test case.
1438 (copy_if) Find end test.
1440 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
1442 * dictionary.c: (dict_get_case_weight) New convenience function.
1444 * aggregate.c: (accumulate_aggregate_info) Use
1445 dict_get_case_weight().
1447 * frequencies.q: (calc_general) Ditto.
1448 (calc_integer) Ditto.
1451 * t-test.q: (groups_calc) Ditto.
1454 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
1456 * glob.c: (global var default_dict) Change from `struct
1457 dictionary' to `struct dictionary *'. All references changed.
1458 (init_glob) Initialize default_dict with dict_create().
1460 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
1462 struct dictionary now made opaque. All related functions:
1464 * get.c: (rename_variables) Removed.
1465 (dict_delete_run) Removed.
1467 * temporary.c: (copy_variable) Removed.
1468 (new_dictionary) Removed.
1469 (save_dictionary) Removed.
1470 (restore_dictionary) Removed.
1471 (free_dictionary) Removed.
1473 * vars-atr.c: (clear_default_dict) Removed.
1474 (find_variable) Removed.
1475 (find_dict_variable) Removed.
1476 (create_variable) Removed.
1477 (delete_variable) Removed.
1478 (common_init_stuff) Removed.
1479 (init_variable) Removed. Updating of inp_init moved into
1480 cmd_end_input_program().
1481 (replace_variable) Removed.
1482 (rename_variable) Removed.
1483 (clear_variable) Removed.
1484 (dup_variable) Removed.
1486 * vars-prs.c: (is_varname) Removed.
1487 (is_dict_varname) Removed.
1488 (fill_all_vars) Removed.
1490 * vector.c: (find_vector) Removed.
1492 * weight.c: (stop_weighting) Removed.
1494 * dictionary.c: New file.
1495 (dict_create) New, replaces new_dictionary().
1496 (dict_clone) New, replaces save_dictionary() and
1497 restore_dictionary().
1498 (dict_clear) New, replaces clear_default_dict().
1499 (dict_destroy) New, replaces free_dictionary().
1500 (dict_get_var_cnt) New function, replaces references to
1502 (dict_get_var) New function, replaces references to dict->var[i].
1503 (dict_get_vars) New function, replaces fill_all_vars().
1504 (dict_create_var) New, replaces create_variable(). Interface
1505 drops `type' parameter, using a zero `width' to designate numeric.
1506 (dict_clone_var) New, replaces dup_variable().
1507 (dict_rename_var) New, replaces rename_variable().
1508 (dict_lookup_var) New, replaces find_variable(),
1509 find_dict_variable(), is_varname().
1510 (dict_contains_var) New function.
1511 (compare_variable_dblptrs) New function.
1512 (dict_delete_var) New function, replaces clear_variable().
1513 (dict_delete_vars) New function, replaces dict_delete_run().
1514 (dict_reorder_vars) New function.
1515 (dict_rename_vars) New function, replaces rename_variables().
1516 (dict_get_weight) New function, replaces reading dict->weight_var.
1517 (dict_set_weight) New function, replaces writing dict->weight_var
1518 or calling stop_weight(dict).
1519 (dict_get_filter) New function, replaces reading dict->filter_var.
1520 (dict_set_filter) New function, replaces writing dict->filter_var.
1521 (dict_get_case_limit) New function, replaces reading dict->N.
1522 (dict_set_case_limit) New function, replaces writing dict->N.
1523 (dict_get_value_cnt) New function, replaces reading dict->nval.
1524 (dict_compact_values) New function, replaces a loop that was
1525 replicated in several places.
1526 (dict_get_split_vars) New function, replaces reading dict->splits.
1527 (dict_get_split_cnt) New function, replaces reading
1529 (dict_set_split_vars) New function, replaces writing dict->splits.
1530 (dict_get_label) New function, replaces reading dict->label.
1531 (dict_set_label) New function, replaces writing dict->label.
1532 (dict_get_documents) New function, replaces reading
1534 (dict_set_documents) New function, replaces writing
1537 All references to above functions updated.
1539 * aggregate.c: (cmd_aggregate) Copy file label and documents from
1540 old dictionary to new by hand, because dict_create() can't do it
1541 itself. Use dict_set_documents(), dict_set_split_vars().
1543 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
1544 calling dict_destroy().
1546 * data-list.c: (dls_var_spec) Remove `type' member, replace by
1548 (fixed_parse_compatible) Some slightly nontrivial changes for
1550 (dump_fmt_list) Ditto.
1553 * file-type.c: (create_col_var) Ditto.
1555 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
1556 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
1557 (rename_variables) Use dict_rename_vars().
1558 (mtf_merge_dictionary) Use dict_get_documents(),
1559 dict_set_documents(), dict_compact_values().
1561 * pfm-read.c: (read_variables) Deal with changes to weighting.
1563 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
1564 is_varname() in output code.
1566 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
1567 other dictionary functions.
1569 * title.c: (add_document_line) Use dict_get_documents(),
1570 dict_set_documents().
1572 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
1573 reset default_handle by hand. dict_clear() will clear vectors so
1574 there's no need for that by hand.
1576 * vfm.c: (close_active_file) Move call to finish_compaction()
1577 earlier, so that we can do the compaction as a single step using
1578 dict_compact_values(). Use dict_clear_vectors().
1579 (finish_compaction) Use dict_delete_var(), dict_compact_values().
1581 Some functions don't have replacements:
1583 * vars-atr.c: (force_create_variable) Removed. All references
1584 updated to dict_create_var() followed by an assertion.
1585 (force_dup_variable) Removed. All references updated to
1586 dict_clone_var() followed by an assertion.
1588 * weight.c: (update_weighting) Removed. No longer necessary, so
1589 all references removed.
1591 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
1595 * aggregate.c: Eliminate separation of weighted and unweighted
1596 case. It made the code too obscure and I doubt it was actually
1597 faster. Instead, all code uses the "weighted" code, because
1598 that's a generalization of the "unweighted" code.
1601 (parse_aggregate_functions) No need to set FWEIGHT.
1602 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
1603 (dump_aggregate_info) Ditto.
1604 (initialize_aggregate_info) No need for special plain_function
1605 that gets rid of FWEIGHT option.
1607 * aggregate.c: Get rid of approximations.
1608 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
1610 (aggregate_single_case) Don't use approx_ne().
1612 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
1614 * ascii.c (ascii_line_width): Dead code, removed.
1616 * postscript.c (ps_line_width): Ditto.
1618 * q2c.c (xrealloc): Ditto.
1620 * count.c (internal_cmd_count): Ditto.
1622 * means.q (validate_dependent_endpoint): Ditto.
1624 * set.q: (cmd_gset) Ditto.
1626 * weight.c: [0] (weight_trns_proc) Ditto.
1628 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
1630 Make the code -Wmissing-prototypes clean.
1632 * Makefile.am (version.c): Add #include "version.h".
1634 * ascii.c: (ascii_open_global) Make static.
1635 (ascii_close_page) Ditto.
1636 (ascii_font_sizes) Ditto.
1637 (ascii_postopen_driver) Ditto.
1638 (ascii_close_driver) Ditto.
1639 (ascii_option) Ditto.
1640 (ascii_open_page) Ditto.
1641 (ascii_line_horz) Ditto.
1642 (ascii_line_vert) Ditto.
1643 (ascii_line_intersection) Ditto.
1645 (ascii_polyline_begin) Ditto.
1646 (ascii_polyline_point) Ditto.
1647 (ascii_polyline_end) Ditto.
1648 (ascii_text_set_font_by_name) Ditto.
1649 (ascii_text_set_font_by_position) Ditto.
1650 (ascii_text_set_font_by_family) Ditto.
1651 (ascii_text_get_font_name) Ditto.
1652 (ascii_text_get_font_family) Ditto.
1653 (ascii_text_set_size) Ditto.
1654 (ascii_text_get_size) Ditto.
1655 (ascii_text_metrics) Ditto.
1656 (ascii_text_draw) Ditto.
1657 (ascii_close_page) Ditto.
1659 * cmdline.h: New header for parse_command_line(). Used where
1662 * command.c: Move prototypes for cmd_*() functions to command.h.
1664 * command.h: Prototypes for cmd_*() functions moved here from
1667 * crosstabs.q: (gamma_int) Ditto.
1669 * file-handle.h: Add fh_init_files() prototype.
1671 * getline.c: (welcome) Ditto.
1673 * glob.h: New header for init_glob(). Used where appropriate.
1675 * hash.c: (comparison_helper) Ditto.
1677 * html.c: (html_open_global) Ditto.
1678 (html_close_global) Ditto.
1679 (html_preopen_driver) Ditto.
1680 (html_postopen_driver) Ditto.
1681 (html_close_driver) Ditto.
1682 (html_option) Ditto.
1683 (html_open_page) Ditto.
1684 (html_close_page) Ditto.
1685 (html_submit) Ditto.
1687 * inpt-pgm.c: (input_program_source_read) Ditto.
1689 * output.c: (find_defn_value) Ditto.
1690 (destroy_list) Ditto.
1692 * pfm-read.c: (read_int) Ditto.
1694 * postscript.c: (ps_open_global) Ditto.
1695 (ps_close_global) Ditto.
1696 (ps_font_sizes) Ditto.
1697 (ps_preopen_driver) Ditto.
1698 (ps_postopen_driver) Ditto.
1699 (ps_close_driver) Ditto.
1701 (ps_open_page) Ditto.
1702 (ps_close_page) Ditto.
1703 (ps_line_horz) Ditto.
1704 (ps_line_vert) Ditto.
1705 (ps_line_intersection) Ditto.
1707 (ps_polyline_begin) Ditto.
1708 (ps_polyline_point) Ditto.
1709 (ps_polyline_end) Ditto.
1710 (ps_text_set_font_by_name) Ditto.
1711 (ps_text_set_font_by_position) Ditto.
1712 (ps_text_set_font_family) Ditto.
1713 (ps_text_get_font_name) Ditto.
1714 (ps_text_get_font_family) Ditto.
1715 (ps_text_set_size) Ditto.
1716 (ps_text_get_size) Ditto.
1717 (ps_text_metrics) Ditto.
1718 (ps_text_draw) Ditto.
1720 * q2c.c: (finish_up) Ditto.
1729 (find_symbol) Ditto.
1732 (force_string) Ditto.
1734 (match_token) Ditto.
1737 (parse_setting) Ditto.
1738 (parse_specifier) Ditto.
1739 (parse_specifiers) Ditto.
1740 (parse_subcommand) Ditto.
1741 (dump_specifier_vars) Ditto.
1743 (make_identifier) Ditto.
1744 (dump_declarations) Ditto.
1745 (dump_specifier_init) Ditto.
1746 (dump_vars_init) Ditto.
1748 (dump_specifier_parse) Ditto.
1749 (dump_subcommand) Ditto.
1750 (dump_parser) Ditto.
1751 (dump_header) Ditto.
1753 (recognize_directive) Ditto.
1755 * recode.c: (string_to_long) Ditto.
1757 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
1759 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
1762 * sort.c: (sort_stream_read) Ditto.
1763 (sort_stream_mode) Ditto.
1765 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
1767 * algorithm.c (binary_search): Fix comparison.
1769 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
1771 * algorithm.c: (binary_search) Fix assertion.
1773 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
1775 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
1777 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
1779 * sort.c: (compare_case_lists) Rewrite.
1781 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
1783 * quicksort.c: Removed (not used).
1785 * quicksort.h: Removed (not used).
1787 * sort.c: Removed blp_quicksort() prototype.
1789 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
1791 * postscript.c: (int_2_compare) Rewrite.
1792 (compare_line) Rewrite.
1794 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
1796 * matrix-data.c (compare_factors) Use lexicographical_compare()
1798 (compare_doubles) New function.
1800 * algorithm.c: (lexicographical_compare) New algorithm.
1802 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
1804 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
1806 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
1808 * expr-prs.c: (cmp_func) Removed.
1809 (parse_function) Use binary_search() algorithm.
1810 (compare_functions) New function.
1811 (init_func_tab) Use sort() algorithm.
1813 * algorithm.c: (binary_search) New algorithm.
1815 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
1817 * descript.q: (display) Use sort() algorithm instead of qsort().
1818 (compare_func) Removed.
1819 (descriptives_compare_variables) New function.
1821 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
1823 Get rid of AVL trees. Hashes are more appropriate for everything
1826 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
1832 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
1834 Much code can be clarified by using C++ STL-like algorithms. Not
1835 all uses of these algorithms are listed below, only the ones where
1836 the change to an algorithm was the only change of interest.
1838 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
1840 * algorithm.c: New file.
1842 * algorithm.h: New file.
1844 * modify-vars.c: (static var forward) Removed.
1845 (static var positional) Removed.
1846 (compare_variables) Removed.
1847 (struct ordering) New.
1848 (cmd_modify_vars) Use sort() algorithm.
1849 (compare_variables_given_ordering) New function.
1850 (rearrange_dict) Use sort() algorithm.
1852 * sysfile-info.c: (cmd_display) Use sort() algorithm.
1853 (cmp_var_by_name) Removed.
1855 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
1857 Make file handles use a hash table.
1859 * file-handle.q: (files) Change to hash table, make static.
1860 (cmd_file_handle) Use hash table functions.
1861 (fh_get_handle_by_filename) Ditto.
1862 (fh_get_handle_by_name) Ditto.
1863 (hash_file_handle) New function.
1864 (cmp_file_handle) Rewrite.
1865 (fh_init_files) Use hash table functions.
1867 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
1869 Clean up FREQUENCIES.
1871 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
1873 * frequencies.q: Remove a lot of old #if'd out code at the end.
1874 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
1875 or calc_weight(). Initialize percentile_values.
1876 (calc) New function based on calc_weight() from frequencies.g.
1877 (precalc) Use hash functions.
1878 (static var comparison_func) Removed.
1879 (static var comparison_param) Removed.
1880 (comparison_helper) Removed.
1881 (get_freq_comparator) New function.
1882 (not_missing) New function.
1884 (postprocess_freq_tab) Use hash table functions, algorithms,
1885 get_freq_comparator(). Rewrite.
1886 (cleanup_freq_tab) Rephrase.
1887 (add_percentile) Clean up spacing.
1888 (hash_value_numeric) New function.
1889 (hash_value_alpha) New function.
1890 (compare_value_numeric_a) Rewrite.
1891 (compare_value_alpha_a) Rewrite.
1892 (compare_value_numeric_d) Rewrite.
1893 (compare_value_alpha_d) Rewrite.
1894 (compare_freq_numeric_a) Rewrite.
1895 (compare_freq_alpha_a) Rewrite.
1896 (compare_freq_numeric_d) Rewrite.
1897 (compare_freq_alpha_d) Rewrite.
1898 (calc_stats) Clean up mode, percentiles, max.
1899 (dump_statistics) Clean up spacing.
1901 * frequencies.g: Removed.
1903 * var.h: (struct freq_tab) Change `data' to hash table.
1905 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
1907 * file-handle.h: Remove declaration of global variable `files',
1908 which wasn't used anywhere.
1910 * postscript.c: (add_encoding) Remove superfluous cast.
1913 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
1916 * temporary.c: [0] (display_tree) Removed.
1918 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
1920 Implement a new random number generator based on the alleged RC4
1923 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
1926 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
1927 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
1929 (static var V[]) Removed.
1930 (static var Y) Removed.
1931 (static var X2) Removed.
1932 (setup_randomize) Removed.
1934 (rand_uniform) Removed.
1935 (rand_normal) Removed.
1936 (struct rng) New structure.
1937 (rng_create) New function.
1938 (rng_destroy) New function.
1939 (swap_byte) New static function.
1940 (rng_seed) New function.
1941 (rng_get_bytes) New function.
1942 (rng_get_int) New function.
1943 (rng_get_unsigned) New function.
1944 (rng_get_double) New function.
1945 (rng_get_double_normal) New function.
1946 (pspp_rng) New function.
1948 * random.h: Sync up to random.c.
1950 * sample.c: (struct sample_trns) Make `frac' unsigned and a
1951 fraction of UINT_MAX, not 65536.
1952 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
1955 * vfm.c: (open_active_file) No need to call setup_randomize() any
1958 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
1960 Change dictionary name indexes to use hash tables instead of AVL
1963 * crosstabs.q: (free_var_dict) Use hash tables.
1964 (crs_custom_tables) Ditto.
1965 (calc_general) Ditto.
1966 (compare_table_entry) Rewrite.
1967 (enum_var_values) Reorder parameters. All references updated.
1970 * get.c: (rename_variable) Use hash tables.
1971 (mtf_merge_dictionary) Ditto.
1973 * glob.c: (init_glob) Use hash tables.
1974 (cmp_variable) Removed.
1976 * means.q: (mns_custom_tables) Use hash tables.
1978 * modify-vars.c: (rearrange_dict) Use hash tables.
1980 * rename-vars.c: (cmd_rename_variables) Use hash tables.
1982 * sfm-read.c: (read_header) Use hash tables.
1983 (read_variables) Ditto.
1985 * temporary.c: (new_dictionary) Use hash tables.
1986 (save_dictionary) Ditto.
1987 (restore_dictionary) Ditto.
1989 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
1990 hash table `name_tab'.
1992 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
1993 [DEBUGGING] (dump_var_tree) Removed.
1994 (find_variable) Use hash tables.
1995 (find_dict_variable) Ditto.
1996 (common_init_stuff) Ditto.
1997 (rename_variable) Ditto.
1998 (clear_variable) Ditto. Also, remove debug code.
1999 (dup_variable) Use hash tables.
2001 * vars-prs.c: (fill_all_vars) Use hash tables.
2002 (is_dict_varname) Ditto.
2003 (parse_dict_variable) Ditto.
2005 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
2007 Change value labels to use hash tables instead of AVL trees, and
2008 change value labels into an ADT.
2010 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
2012 * value-labels.c: New file.
2014 * value-labels.h: New file.
2016 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
2017 Get rid of a stupid use of goto.
2019 * autorecode.c: (compare_alpha_value) Rewrite.
2020 (hash_alpha_value) Ditto.
2021 (compare_numeric_value) Rewrite.
2022 (hash_numeric_value) Ditto.
2024 * frequencies.q: (dump_full) Use value label ADT.
2026 * pfm-read.c: (read_value_label) Use value label ADT.
2028 * pfm-write.c: (write_value_labels) Use value label ADT.
2030 * sfm-read.c: (read_variables) Use value label ADT.
2031 (read_value_labels) Rewrite.
2033 * sfm-write.c: (write_value_labels) Rewrite.
2035 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
2036 (display_variables) Ditto.
2037 (describe_variable) Ditto.
2039 * t-test.q: (print_t_groups) Use value label ADT.
2041 * temporary.c: (copy_variable) Use value label ADT.
2042 (free_dictionary) Ditto.
2044 * val-labs.c: (verify_val_labs) Use value label ADT.
2046 (debug_print) Ditto.
2047 (val_lab_cmp) Removed.
2048 (inc_ref_count) Removed.
2049 (copy_value_labels) Removed.
2051 * var.h: (struct value_label) Removed.
2052 (struct variable) Change AVL tree `val_lab' into hash table
2055 * vars-atr.c: (init_variable) Use value label ADT.
2056 (clear_variable) Ditto.
2057 (free_value_label) Removed.
2058 (free_val_lab) Removed.
2059 (get_val_lab) Removed.
2060 (compare_variables) New function.
2061 (hash_variable) New function.
2063 * vfm.c: (dump_splits) Use value label ADT.
2065 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
2067 Add to the hash table interface.
2069 * hash.c: (hsh_hash_bytes) Add assertion.
2070 (hsh_hash_string) Ditto.
2074 (hsh_create) Ditto. Also make minimum `size'.
2075 (hsh_destroy) Rephrase.
2076 (sort_nulls_last) Removed.
2077 (not_null) New function.
2079 (comparison_helper) Ditto.
2080 (hsh_sort) Rewritten.
2081 (hsh_data_copy) New function.
2082 (hsh_sort_copy) Ditto.
2084 (hsh_replace) Ditto.
2085 (hsh_hash_double) Ditto.
2086 (hsh_delete) Fix stupid bug.
2088 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2089 * added a calculation of the mode to FREQUENCIES
2091 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2093 * moved (un)defs of DEBUGGING to config.h
2095 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
2097 * groff-font.c: (add_kern) Fix indentation.
2098 (add_kern) Use & instead of % to take power-of-2 modulus.
2099 (font_get_kern_adjust) Likewise.
2101 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
2103 * autorecode.c: (recode) Replace stupid use of memcpy() by
2105 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
2106 (hash_numeric_value) Ditto.
2107 (autorecode_proc_func) pool_strdup() was wrong here because the
2108 source string was not null-terminated. Use new pool_strndup()
2111 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
2112 use of hsh_iterator_init().
2114 * data-in.c: (parse_N) Initialize i->v->f.
2116 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
2119 * groff-font.c: Use power-of-2 hash table sizes, not prime.
2120 (groff_read_font) Don't call hsh_next_prime(). Don't call
2122 (static var hash) Remove `size_p', `max_used' members.
2123 (font_char_name_to_index) Don't call hsh_next_prime(). Use
2124 hsh_hash_string() instead of hashpjw(), & instead of %.
2125 (default_font) Don't call hsh_next_prime().
2127 * pool.c: (pool_strndup) New function.
2128 (pool_strdup) Reimplement in terms of pool_strndup.
2130 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
2132 (hash_ps_encoding) Use hsh_hash_string().
2133 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
2134 (hash_filename2font) Use hsh_hash_string().
2136 * som.c: Add #include <stdlib.h>.
2138 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
2139 (by destroying its pool).
2141 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
2143 Miscellaneous hash table code cleanup:
2145 * hash.h: (struct hsh_table) Moved into hash.c.
2146 (hsh_count) Ditto, and transformed into function.
2147 (hsh_compare_func) New typedef, used for defining otherwise-long
2148 function types here and in hash.c
2149 (hsh_hash_func) Ditto.
2150 (hsh_free_func) Ditto.
2152 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
2153 `table' to `entries'. Removed `mp'. All references updated.
2154 (hsh_clear) Don't shrink entries array; if the hash was this big
2155 once, it probably will be again.
2156 (hsh_rehash) Made static.
2157 (force_hsh_insert) Renamed hsh_force_insert.
2158 (force_hsh_find) Renamed hsh_force_find.
2160 Made hash table sizes powers of 2, because that's fine with any
2161 reasonable hash function and because taking a power-of-2 modulus
2162 is faster than any other:
2164 (hsh_prime_tab) Removed;
2165 (hsh_next_prime) Ditto.
2166 (next_power_of_2) New function.
2167 (hsh_create) Use next_power_of_2.
2168 (hsh_rehash) Use & instead of %.
2170 Cleaned up hsh_sort:
2172 (internal_comparison_fn) Removed.
2173 (sort_nulls_last) New function.
2174 (hsh_sort) Removed second parameter, switched to using the new
2175 quicksort() function from quicksort.h to avoid using nasty need
2176 for static variables with qsort(). All references updated.
2178 Changed the hash functions offered, because there are better hash
2179 functions than the ones we had, and cleaned up the names to boot:
2181 * hash.c: (hashpjw_d) Removed.
2183 (hsh_hash_bytes) New function.
2184 (hsh_hash_string) New function.
2185 (hsh_hash_int) New function.
2187 Improved the hash table iteration interface:
2189 * hash.h: (hsh_iterator_init) Removed.
2190 (struct hsh_iterator) Removed `init' member, change `next' to
2193 * hash.c: (hsh_foreach) Removed. All references updated to use
2194 hsh_first/hsh_next instead.
2195 (hsh_first) New function. Notably, unlike hsh_foreach() it does
2196 not treat a null pointer as an empty hash table.
2197 (hsh_next) New function.
2199 Made deletion possible, though slow:
2201 * hash.c: (locate_matching_entry) New function.
2202 (hsh_find) Use locate_matching_entry().
2203 (hsh_delete) New function also using locate_matching_entry().
2204 (hsh_force_delete) New function.
2206 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
2208 * quicksort.c: New file implementing a sort routine with a
2209 interface better than qsort() because it passes a user-provided
2210 parameter to the sort routine.
2212 * Makefile.am: Add quicksort.c, quicksort.h.
2214 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
2216 * All source files: Get rid of nasty special cases for Checker,
2217 which is pretty obsolete now.
2219 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
2221 * Fixed a bug apparent when using the FREQUENCIES command with the
2222 html driver. The html driver was incorrectly trying to display
2225 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
2227 * Makefile.am: Reorganized. Put locale dir in version.c instead
2228 of passing it to each compile command. Only put local gmp libs in
2229 LD_ADD if not installed on system. Remove `boast' target.
2231 * All source files: struct and union typedefs eliminated.
2232 `sizeof type' replaced by `sizeof object' where practical. Moved
2233 `unused' qualifiers from start to end of declarations for gcc
2234 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
2235 assertions on pointers strictly compliant. Removed _ prefixes on
2236 some function parameter names.
2238 * alloc.c: New source file, containing these external linkage
2239 functions removed from common.c: xmalloc, xcalloc, xrealloc,
2246 * ascii.c: Migrated from arenas to pools.
2247 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
2248 c_string to len_string. All references changed.
2249 (ascii_option) Signature changed to comply to new output.c
2251 (count_fancy_chars) Removed.
2252 (delineate) Removed support for rich text.
2253 (ascii_text_metrics) Ditto.
2255 (output_shorts) Change `box', `off', `on' from c_string to
2256 len_string. Change `remaining' from int to size_t.
2257 (ascii_close_page) Make page numbering less haphazard.
2259 * autorecode.c: Migrate from arenas to pools.
2261 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
2263 * bitvector.h: New file containing these macros from misc.h:
2264 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
2266 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
2267 word[3]. ncmd removed.
2268 (var empty_string) Removed.
2269 (var cmd_table) Declaration updated.
2270 (var cmdtab) Removed.
2271 (cmp_command) Removed.
2272 (split_words) Rewritten to use strtok_r().
2273 (init_cmd_parser) Renamed cmd_init(). Rewritten.
2274 (find_command) Removed.
2275 (FILE_TYPE_okay) Rewritten.
2276 (cmd_parse) Rewritten. Semantics of the return value of command
2277 handlers has changed: they must now return one of the new CMD_*
2278 enumerals, rather than a magic value. This meant that all
2279 commands had to be modified, and they were.
2280 (figure_out_command) New function.
2282 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
2283 #defines for INIT, INPU, etc.
2285 * command.h: New CMD_* enum series.
2286 (cur_proc) Make const char *, not char *.
2287 (cmd_init) Prototype.
2290 * common.c: Removed.
2292 * common.h: Removed.
2294 * correlations.q: New file.
2296 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
2298 (custom_tables) Renamed crs_custom_tables().
2299 (custom_variables) Renamed crs_custom_variables().
2300 (calc_integer) Add in some `const' qualifiers.
2301 (table_value_missing) Change from a_string to len_string.
2302 (float_M_suffix) Change from a_string to len_string.
2304 * data-in.c: Rewritten. All references to
2305 parse_string_as_format() changed to data_in().
2307 * data-in.h: New file.
2309 * data-list.c: Change DLS_* from #define's to enums. Move from
2310 rpd_msg() to tmsg().
2311 (RPD_ERR) New #define.
2312 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
2314 (read_from_data_list_fixed) Change from old
2315 parse_string_as_format() to new data_in().
2316 (read_from_data_list_free) Ditto.
2317 (read_from_data_list_list) Ditto.
2318 (cmd_repeating_data) Modify approach to checking for end of
2321 (rpd_parse_record) Change from old parse_string_as_format() to new
2322 data_in(). Change from old convert_format_to_string() to new
2324 (read_one_set_of_repetitions) Change dfm_push_cust() to
2325 dfm_push(), pop_cust() to dfm_pop().
2327 * data-out.c: Rewritten. All references to
2328 convert_format_to_string() changed to data_out().
2330 * descript.q: Migrate to new q2c.
2331 (cmd_descriptives) Removed.
2332 (internal_cmd_descriptives) Renamed cmd_descriptives ().
2333 (custom_variables) Renamed dsc_custom_variables().
2335 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
2337 (open_file_r) Initialize h->where.line_number. Migrate to new
2339 (open_file_w) Initialize h->where.line_number.
2340 (read_record) Change from ext->ln to h->where.line_number.
2341 Migrate to struct string.
2342 (dfm_put_record) Rephrased.
2343 (dfm_push_cust) Renamed dfm_push(), rewritten.
2344 (dfm_pop) New function.
2346 * error.c: All references updated.
2347 (glob var error_count) Renamed err_err_count.
2348 (glob var warning_count) Renamed err_warning_count.
2349 (glob var error_already_flagged) Renamed err_already_flagged.
2350 (glob var verbosity) Renamed err_verbosity.
2351 (glob var cust_fn) Removed.
2352 (glob var cust_ln) Removed.
2353 (static var file_loc) New.
2354 (static var nfile_loc) New.
2355 (static var mfile_loc) New.
2356 (tmsg) New function.
2357 (push_cust) Removed.
2360 (static var terminating) Removed.
2361 (failure) Renamed err_failure().
2362 (hcf) Renamed err_hcf().
2363 (err_push_file_locator) New function.
2364 (err_pop_file_locator) New function.
2365 (err_location) New function.
2366 (check_error_count) Renamed err_check_count().
2367 (vmsg) Renamed err_vmsg(). Interface changed.
2368 (verbose_msg) Removed.
2369 (err_cond_fail) New function.
2370 (error_break) Renamed err_break().
2372 * error.h: All references updated.
2373 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
2374 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
2376 (struct file_locator) New.
2378 (macro verbose_msg) Removed.
2379 (macro cond_fail) Removed.
2381 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
2383 * expr-prs.c: Reorganized. All references updated.
2384 (exprtypename) Renamed expr_type_name().
2385 (typename) Renamed type_name().
2386 (free_expression) Renamed expr_free().
2387 (parse_expression) Renamed expr_parse(). Uses new type_check()
2389 (init_functab) Renamed init_func_tab().
2390 (type_check) New function.
2391 (parse_or) Rewritten to use new allocate_nonterminal() and
2392 append_nonterminal_arg() functions.
2395 (parse_rel) Ditto. Also simplified logic.
2400 (SYSMIS_func) Ditto.
2401 (VALUE_func) Rephrased.
2402 (CONCAT_func) Fix memory leak by replacing free by free_node on
2404 (generic_str_func) Ditto.
2405 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
2407 (allocate_nonterminal) New function.
2408 (append_nonterminal_arg) New function.
2409 (static func_tab[]) Now at file level.
2411 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
2413 * expr.h: (enum series OP_*) Moved to exprP.h.
2414 (OP_* defines) Ditto.
2415 (struct op_desc) Ditto.
2416 (global ops[]) Ditto.
2417 (struct num_con_node) Ditto.
2418 (struct str_con_node) Ditto.
2419 (struct var_node) Ditto.
2420 (struct lag_node) Ditto.
2421 (struct casenum_node) Ditto.
2422 (struct nonterm_node) Ditto.
2423 (union any_node) Members renamed.
2424 (struct sys_node) Removed.
2425 (struct val_node) Removed.
2426 (operator typedef) Removed.
2427 (typedef exprtype) Removed.
2428 (enum series EX_*) Moved to exprP.h.
2429 (struct expression) Ditto. Also renamed a lot of the members.
2430 (PXP_* defines) Changed to enums.
2431 (free_node prototype) Moved to exprP.h.
2433 * file-handle.h: (struct file_handle) New member `where'.
2435 * file-handle.q: Migrated to new q2c format.
2436 (prepend_current_directory) Removed (dead code).
2437 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
2438 (fh_get_handle_by_filename) Removed dead code.
2439 Set new `where' member.
2441 * file-type.c: (file_type_source_read) References to
2442 parse_string_as_format() changed to data_in().
2443 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
2445 * filename.c: All references updated.
2446 (init_filename) Renamed fn_init().
2447 (expand_line) Removed.
2448 (macro EXPAND_LINE) Removed.
2449 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
2450 of custom functions.
2451 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
2452 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
2453 (normalize_filename) Renamed fn_normalize().
2454 (search_path) Renamed fn_search_path(), rewritten.
2455 (prepend_dir) Renamed fn_prepend_dir().
2456 (blp_getenv) Renamed fn_getenv().
2457 (blp_dirname) Renamed fn_dirname().
2458 (fn_basename) New function, not used.
2459 (absolute_filename_p) Renamed fn_absolute_p().
2460 (is_special_filename) Renamed fn_special_p().
2461 (file_exists) Renamed fn_exists_p().
2462 (readlink_malloc) Renamed fn_readlink().
2463 (getenv_default) Renamed fn_getenv_default().
2464 (open_file) Renamed fn_open().
2465 (close_file) Renamed fn_close().
2466 (open_file_ext) Renamed fn_open_ext().
2467 (close_file_ext) Renamed fn_close_ext().
2469 * font.h: Migrate from arenas to pools.
2471 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
2473 * frequencies.g: Migrate from arenas to pools.
2475 * frequencies.q: Migrate to new q2c version. Migrate from arenas
2478 * getline.c: All references updated.
2479 (global getl_buf) Changed from char * to struct string.
2480 (static getl_include_path) Ditto.
2481 (global getl_buf_len) Removed.
2482 (global getl_buf_size) Removed.
2483 (getl_include_path) Deal with new getl_buf, getl_include_path.
2484 (getl_uninitialize) New function.
2485 (getl_get_current_directory) Rewritten.
2486 (getl_clear_include_path) Rewritten.
2487 (getl_add_include_dir) Rewritten.
2488 (getl_add_file) Assertion fixed.
2489 (getl_add_virtual_file) Change initial value of `remaining_loops'
2491 (welcome) Rewritten.
2492 (handle_line_buffer) Make static. Change logic to make
2493 getl_add_virtual_file() change sensible. Use ds_*() strings.
2494 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
2495 (getl_close_file) Moved.
2496 (getl_location) New function.
2498 * getline.h: All references updated.
2499 (macro curln) Removed.
2500 (macro curfn) Removed.
2501 (macro am_interactive) Renamed getl_am_interactive.
2502 (macro am_reading_script) Renamed getl_reading_script.
2504 * glob.c: (global fmt_parse_ignore_error) Removed.
2505 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
2506 systems that support it (C99). Turn off SET ECHO by default. No
2507 necessary julcal initialization anymore.
2509 * groff-font.c: Migrate from arenas to pools.
2510 (groff_read_font) Use err_push_file_locator().
2511 (groff_read_DESC) Ditto.
2512 (font_msg) Use tmsg().
2514 * hash.c: (hsh_sort) Fix debug code.
2515 [GLOBAL_DEBUGGING] Include stdio.h.
2517 * hash.h: (macro force_hsh_insert) Rephrase.
2519 * heap.c: Rewritten.
2521 * heap.h: Rewritten.
2523 * html.c: (html_option) Change from outp_value to struct string.
2524 (postopen) Change from curfn to getl_location().
2525 (escape_string) Remove rich-text code. Signature changed.
2526 (output_tab_table) Switch from a_string to struct len_string.
2527 Remove rich text support.
2529 * lexer.c: All references updated. Largely rewritten. Major
2530 changes listed below. Removed tagged quote support. Adapted to
2531 struct string tokstr.
2532 (global tokstr) Changed to struct string.
2533 (global tokstr_size) Removed.
2534 (global tokstr_len) Removed.
2536 (global tokint) Removed.
2537 (global toklongstr) Removed.
2538 (C* defines) Removed.
2539 (static tbl[]) Removed.
2540 (static id[]) Removed.
2541 (static une[]) Removed.
2542 (discard_line) Renamed lex_discard_line().
2543 (get_entire_line) Renamed lex_entire_line().
2544 (get_rest_of_line) Renamed lex_rest_of_line().
2545 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
2546 (make_hexit) Removed.
2547 (syntax_error) Renamed lex_error(). Return value removed.
2548 (get_token_representation) Renamed lex_token_representation().
2549 (putback) Renamed lex_put_back().
2550 (putfwd) Renamed lex_put_forward().
2551 (convert_negative_to_dash) Renamed lex_negative_to_dash().
2552 (set_prog) Renamed lex_set_prog().
2553 (init_lex) Renamed lex_init().
2554 (reset_eof) Renamed lex_reset_eof().
2555 (lookahead) Renamed lex_look_ahead().
2556 (check_id) Rewritten.
2557 (yylex) Renamed lex_get(), rewritten.
2558 (lex_end_of_command) New function. Many commands were rephrased
2560 (lex_integer_p) New function. Replaces compare of tokint against
2562 (lex_integer) New function. Replaces tokint.
2563 (match_tok) Renamed lex_match().
2564 (match_id) Renamed lex_match_id().
2565 (match_int) Renamed lex_match_int().
2566 (force_match_id) Renamed lex_force_match_id(), added return value.
2567 (force_match) Renamed lex_force_match(), added return value.
2568 (force_string) Renamed lex_force_string(), added return value.
2569 (force_int) Renamed lex_force_int(), added return value.
2570 (lex_id_match_len) New function.
2571 (id_match) Renamed lex_id_match(), rewritten.
2572 (get_line) Renamed lex_get_line().
2573 (preprocess_line) Renamed lex_preprocess_line().
2574 (tokname) Renamed lex_token_name().
2575 (bin_value_func) Removed.
2576 (oct_value_func) Removed.
2577 (hex_value_func) Removed.
2578 (unexpected_eof) New function.
2579 (convert_numeric_string_to_char_string) New function.
2580 (parse_string) Rewritten, signature changed.
2581 (add_tokstr_char) Removed.
2582 (add_tokstr_unsigned) Removed.
2583 (add_tokstr_string) Removed.
2584 (parse_tagged_quote) Removed.
2585 (skip_comment) Renamed lex_skip_comment().
2587 * lexer.h: All references updated.
2588 (macro is_id1) Renamed CHAR_IS_ID1.
2589 (macro is_idn) Renamed CHAR_IS_IDN.
2590 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
2591 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
2592 (macro get_token) Removed.
2593 (macro id_match) Removed.
2594 (macro force_match_id) Removed.
2595 (macro force_match) Removed.
2596 (macro force_string) Removed.
2597 (macro force_int) Removed.
2598 (macro force_num) Removed.
2599 (macro force_id) Removed.
2601 * lexerP.h: Removed.
2603 * list.q: Migrated to new q2c format.
2604 (write_line) Deal with struct len_string.
2605 (write_varname) Ditto.
2606 (write_fallback_headers) Ditto.
2608 * magic.c: New file, incorporating the following global variables
2609 previously in other files: endian, second_lowest_value. And both
2610 of those are conditional on #define's.
2612 * magic.h: New file, incorporating the following global variable
2613 declarations: endian, second_lowest_value, and the following macro
2614 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
2616 * main.c: Added declarations of pgmname, finished, curdate,
2618 (main) Call new parse_script() function.
2619 (parse_script) New function.
2620 (execute_command) New function.
2621 (dump_token) Removed.
2622 (handle_error) New function.
2624 * matrix.c: New file.
2626 * matrix.h: New file.
2628 * matrix-data.c: Migrated from arenas to pools.
2629 (mget_token) Change from parse_string_as_format() to data_in().
2631 * means.q: Migrate to new q2c.
2632 (custom_tables) Renamed mns_custom_tables().
2633 (custom_crossbreak) Renamed mns_custom_crossbreak().
2634 (custom_variables) Renamed mns_custom_variables().
2636 * mis-val.c: (static var width) Changed from `int' to `size_t'.
2637 (parse_varnames) Prototype.
2638 (parse_numeric) Rephrasings.
2639 (parse_alpha) Adapt to new struct string tokstr.
2641 * misc.c: (intlog10) Rewritten.
2643 (ansi_rand) Renamed real_rand(), moved into random.c.
2644 (ansi_srand) Renamed real_srand(), moved into random.c.
2645 (setup_randomize) Moved to random.c.
2646 (rand_uniform) Ditto.
2647 (rand_normal) Ditto.
2648 (rand_simple) Ditto.
2649 (get_config_line) Removed.
2650 (reverse) Removed (dead code).
2652 * misc.h: (macro SET_BIT) Moved to bitvector.h.
2653 (macro CLEAR_BIT) Ditto.
2654 (macro TEST_BIT) Ditto.
2655 (macro SET_BIT_TO) Ditto.
2656 (macro BIT_INDEX) Ditto.
2658 * output.c: (outp_read_devices) Move to err_push_file_locator()
2659 from push_cust(). Use struct string.
2660 (expand_op_tokstr) Removed.
2661 (static var op_tokstr) Changed to struct string.
2662 (static var op_tokstr_size) Removed.
2663 (tokener) Rephrasings. Use struct string.
2664 (parse_options) Use struct string.
2665 (destroy_driver) Fix assertion.
2666 (outp_get_paper_size) Move to err_push_file_locator().
2667 [0] Removed dead code.
2668 (outp_string_width) Move to len_string.
2670 * output.h: Comment fixes.
2671 (TAG_* enum series) Removed.
2672 (struct outp_value) Removed.
2673 (enum OUTP_T_FANCY) Removed.
2674 (struct outp_text) `s' changed from a_string to len_string.
2675 (struct outp_class) `option' change arg 3 from outp_value to
2678 * pfm-read.c: (corrupt_msg) Rewritten.
2680 * pfm-write.c: (bufwrite) Fix assertion.
2682 * pool.c: New file, reference version.
2684 * pool.h: New file, reference version.
2686 * postscript.c: (ps_font_sizes) Fix assertion.
2687 (ps_option) Change arg 3 from outp_value to struct string.
2688 Adapt to struct string.
2689 (macro output_line) Removed.
2690 (macro add_string) Removed.
2691 (output_encodings) Adapted to struct string. Moved to
2692 err_push_file_locator().
2693 (find_encoding_file) Fix assertion.
2694 (read_ps_encodings) Move to err_push_file_locator().
2695 (postopen) Use getl_location() instead of curfn.
2696 (out_text_plain) Move to len_string.
2697 (text) Ditto. Remove rich text support.
2699 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
2700 (cmd_print_eject) Ditto.
2702 (internal_cmd_print) Now cleans up after itself. Uses
2703 fh_parse_file_handle() now.
2704 (cmd_print_space) Use PXP_NUMERIC to type-check.
2706 * q2c.c: Overhauled. Removed _("") i18n support. All references
2707 updated. All output functions updated to handle structures rather
2708 than local or static variables. Adapt to new PSPP lex_*()
2712 (macro MAX_N_SBC) Removed.
2713 (global bare) Removed.
2714 (enum STRING) Renamed T_STRING.
2715 (enum ID) Renamed T_ID.
2716 (get_buffer) Buffer size increased.
2717 (strlower) Renamed st_lower(), rephrased.
2718 (strupper) Renamed st_upper(), rephrased.
2719 (skip_ws) New function.
2720 (get_line) Don't special-case any types of lines (like those
2721 beginning with ! or $, for instance).
2722 (get_token) Renamed lex_get(). Rephrased.
2723 (static var `prefix') New.
2724 (parse) New function.
2725 (parse_setting) Minor rephrasing.
2726 (dump_specifier_vars) Ditto.
2727 (make_identifier) Put null terminator on identifier, duh.
2728 (dump_vars) Renamed dump_declarations(). Never indent. Never
2729 static. Output changed entirely.
2730 (dump_specifier_init) Rephrase.
2731 (dump_vars_init) No index variable needed. Other modifications.
2732 (dump_parser) Don't parse command name. Do dump functions instead
2733 of just code fragments.
2734 (dump_free) Dump function instead of code fragment.
2735 (recognize_directive) New function.
2736 (main) Use recognize_directive(). Don't rely on magic $ line
2737 beginning: instead, parse comments. Update list of headers.
2739 * random.c: New file, containing the following functions:
2740 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
2741 rand_normal, rand_simple.
2743 * random.h: New file.
2745 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
2746 function. `max_src_width', `max_dst_width' changed to size_t.
2747 (internal_cmd_recode) Removed.
2748 (parse_dest_spec) Merge similar cases.
2749 (parse_src_spec) Add assertion.
2751 * repeat.c: (recognize_keyword) New function.
2752 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
2753 REPEAT. Improve recognition of END REPEAT (use
2754 recognize_keyword()). Move from curfn to getl_location(). Use
2757 (perform_DO_REPEAT_substitutions) Adapt to struct string.
2759 * set.q: Adapt to new q2c.
2760 (cmd_set) Range-check some values better.
2761 (custom_blanks) Renamed stc_custom_blanks().
2762 (custom_length) Renamed stc_custom_length().
2763 (custom_results) Renamed stc_custom_results().
2764 (custom_seed) Renamed stc_custom_seed().
2765 (custom_width) Renamed stc_custom_width().
2766 (custom_format) Renamed stc_custom_format().
2767 (custom_journal) Renamed stc_custom_journal().
2768 (custom_color) Renamed stc_custom_color().
2769 (custom_listing) Renamed stc_custom_listing().
2770 (custom_disk) Renamed stc_custom_disk().
2771 (custom_log) Renamed stc_custom_log().
2772 (custom_rcolor) Renamed stc_custom_rcolor().
2773 (custom_viewlength) Renamed stc_custom_viewlength().
2774 (custom_workdev) Renamed stc_custom_workdev().
2776 * settings.h: Not necessary to include format.h any longer.
2778 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
2779 (corrupt_msg) Rewritten.
2781 * sort.c: Adapt to rewritten heap ADT.
2783 * str.c: (aa_strcpy) Removed.
2784 (ab_strcpy) Removed.
2785 (ac_strcpy) Removed.
2786 (ba_strcpy) Removed.
2787 (bb_strcpy) Removed.
2788 (ca_strcpy) Removed.
2789 (aa_strdup) Removed.
2790 (aa_strdupcpy) Removed.
2791 (ba_strdup) Removed.
2792 (sa_strdup) Removed.
2793 (memrev) Renamed mm_reverse().
2794 (memrmem) Renamed mm_find_reverse().
2795 (cmp_str) Renamed st_compare_pad().
2796 (strmaxcpy) Removed.
2797 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
2798 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
2800 (strpadcpy) Renamed st_pad_copy(), signature changed.
2801 (blpstrset) Removed.
2802 (ds_create) New function.
2803 (ds_init) New function.
2804 (ds_replace) New function.
2805 (ds_destroy) New function.
2806 (ds_clear) New function.
2807 (ds_extend) New function.
2808 (ds_shrink) New function.
2809 (ds_truncate) New function.
2810 (ds_length) New function.
2811 (ds_size) New function.
2812 (ds_value) New function.
2813 (ds_end) New function.
2814 (ds_concat) New function.
2815 (ds_concat_buffer) New function.
2816 (ds_printf) New function.
2817 (ds_putchar) New function.
2818 (ds_getline) New function.
2819 (ds_get_config_line) New function derived from the old
2820 misc.c:get_config_line().
2821 (ls_create) New function.
2822 (ls_create_buffer) New function.
2823 (ls_init) New function.
2824 (ls_shallow_copy) New function.
2825 (ls_destroy) New function.
2826 (ls_null) New function.
2827 (ls_null_p) New function.
2828 (ls_empty_p) New function.
2829 (ls_length) New function.
2830 (ls_value) New function.
2831 (ls_end) New function.
2833 * str.h: Reformatted.
2834 (struct a_string) Removed.
2835 (struct b_string) Removed.
2836 (struct c_string) Removed.
2837 (struct len_string) New.
2838 (struct string) New.
2839 (macro as_streq) Removed.
2840 (macro bs_streq) Removed.
2841 (macro cs_streq) Removed.
2842 (macro sa_streq) Removed.
2843 (macro sb_streq) Removed.
2844 [__GNUC__] (inline function ds_putchar) New function.
2845 [__GNUC__] (inline function ds_length) New function.
2846 [__GNUC__] (inline function ds_value) New function.
2847 [__GNUC__] (inline function ds_end) New function.
2849 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
2850 (display_vectors) Fix missing i18n.
2852 * t-test.q: Migrate to new q2c.
2854 * tab.c: Migrate from arenas to pools.
2855 (tab_create) Use struct len_string.
2856 (tab_realloc) Ditto.
2857 (text_format) Ditto.
2858 (tab_joint_text) Ditto.
2859 (tab_natural_width) Remove rich text support.
2860 (tab_natural_height) Ditto.
2861 (tab_output_text) Handle TAT_FIX.
2862 (tab_raw) Change arg from a_string to len_string.
2863 (tabi_driver) Fix assertion. Use struct len_string.
2864 (render_strip) Use struct len_string. Remove rich text support.
2865 Add `const' qualifiers.
2867 * tab.h: (enum TAB_RICH) Remove.
2868 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
2869 SOM_COL_* updated to read TAB_COL_*.
2870 (struct tab_table) Change arena to pool. Change a_string to
2873 * temporary.c: (restore_dictionary) Rewrite Checker code.
2875 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
2876 LOWEST, HIGHEST) Moved here from common.h.
2877 (typedef any_trns) Removed. All references changed to `struct
2880 * vars-atr.c: (force_create_variable) Fix assertion.
2881 (force_dup_variable) Fix assertion.
2883 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
2885 Using alphanumeric variables in functions under AGGREGATE
2886 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
2887 <BZN-mdksh@t-online.de> for reporting this bug.
2889 * aggregate.c: (parse_aggregate_functions) When setting the
2890 FSTRING bit, also allocate memory for the `string' member of
2892 (free_aggregate_functions) Free iter->string. Don't use the
2893 non-function bits when indexing the array of functions.
2894 [DEBUGGING] (debug_print) Don't use the non-function bits when
2895 indexing the array of functions.
2897 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
2899 Under certain circumstances, the final case would be omitted from
2900 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
2901 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2903 * aggregate.c (agr_00x_end_func): Increment number of cases in
2904 sink before writing case. For streams that keep track of how many
2905 cases there are based on this value, this means that the last case
2906 will be read in on the next stream read.
2908 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
2910 Undefined behavior was invoked by referencing a freed pointer.
2912 * vfm.c (memory_stream_write): Free pointer *after* checking for
2915 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
2917 A wrong record size was displayed when paging the active file to
2920 * vfm.c: (memory_stream_write) Fix off-by-one error.
2922 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
2924 Not having enough temporary space for sorting caused a core dump.
2927 * sort.c: (allocate_cases) Initialize i.
2929 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
2931 Syntax errors in function descriptions on AGGREGATE caused core
2934 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
2935 free_aggregate_functions(), since that function already frees
2938 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
2940 A null pointer was dereferenced, causing a core dump, when
2941 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
2942 but PSPP still doesn't calculate percentiles. Thanks to Regnor
2943 Jernsletten <rjernsle@eunet.no> for reporting this problem.
2945 * arena.c: (arena_malloc) If the arena hasn't been initialized
2946 already, initialize it.
2948 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
2950 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
2951 for compilation with Cygnus Windows B20. Not used by other
2954 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
2956 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
2957 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2959 * sort.c: (compare_case_lists) Reverse sense of comparison if
2960 sorting in descending order.
2961 (compare_record) Ditto.
2963 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
2965 SPLIT FILE with a string variable caused a core dump. Fixed.
2967 * vfm.c: If the variable is a string then make a temporary value
2968 struct pointing to it. The underlying problem is a lot bigger
2969 than this (see TODO) but this is a stopgap for the simple case at
2972 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
2974 Nested INCLUDEs didn't work. Fixed.
2976 * getline.c: (getl_include) Set first_line to NULL in allocated
2979 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
2981 The MATCH FILES procedure set the values of variables not present
2982 to 0. It should have been SYSMIS. This is now fixed.
2984 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
2986 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
2988 The REMARK command was too aggressive about skipping lines. It
2989 didn't like being the last command in a file.
2991 * command.c: (cmd_remark) Call get_entire_line() instead of
2994 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
2996 Comment parsing wasn't consistent with the rest of the code in its
2997 idea of where one command ends and another starts. This meant
2998 that sometimes commands would be mysteriously ignored. Thanks to
2999 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
3001 * command.c: (parse_cmd) Hand off comment parsing to new function
3002 skip_comment() in lexer.c.
3003 * lexer.c: (skip_comment) New function.
3005 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
3007 The TABLE subcommand on MATCH FILES worked only erratically at
3008 best. This fixes it. Thanks to Dr. Dirk Melcher
3009 <BZN-mdksh@t-online.de> for reporting this bug.
3011 * get.c: (mtf_compare_BY_values) When comparing string values, a
3012 difference of 1 is still a difference :-)
3013 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
3014 advance TABLE files automatically when matched. Comment fixes.
3016 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
3018 VARIABLE LABELS rejected a slash before the first variable
3019 specification, contradicting the documentation. Thanks to Walter
3020 M. Gray <graywm@northernc.on.ca> for reporting this bug.
3022 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
3023 command specification.
3025 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
3027 Because of an incorrect optimization in memory allocation,
3028 CROSSTABS sometimes segfaulted when asked to output multiple
3029 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
3032 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
3033 are passed to output_pivot_table() for its use.
3034 (output_pivot_table) Instead of assuming the number of columns is
3035 constant, keep track with maxcols. In general mode, use maxcells
3036 to determine whether more matrix cells need to be allocated.
3038 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
3040 CROSSTABS didn't display value labels for column and row
3041 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
3044 * crosstabs.q: (table_value_missing) If the specified value has a
3045 value label for this variable, then show it instead of the raw
3047 (display_dimensions) Delegate display of value_labels to
3048 table_value_missing.
3050 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
3052 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
3053 <BZN-mdksh@t-online.de> for reporting this bug.
3055 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
3056 if the file isn't declared as binary.
3058 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
3060 MATCH FILES corrupted memory and dumped core on some syntax
3063 * get.c: (cmd_match_files) Set file->handle to NULL before
3065 (mtf_free_file) Don't free a null dictionary.
3067 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
3069 MATCH FILES should set numeric values not available to the
3070 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
3071 <BZN-mdksh@t-online.de> for reporting this bug.
3073 * get.c: (mtf_processing) Set unused records to system-missing,
3076 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
3078 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
3079 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
3081 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
3082 in newly created dictionary, and add each copied variable to the
3085 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
3089 * get.c: (trim_dictionary) Free variable list for KEEP after
3092 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
3094 Some systems didn't like the way open_file was coded. Thanks to
3095 Hankin <hankin@rogue.consultco.com> for pointing this out.
3097 * filename.c: (open_file) Don't try to store stdin, stdout,
3098 stderr as part of an array, because that doesn't always work.
3100 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
3102 The SAVE procedure didn't save long string variables properly.
3103 Fixed by this patch. Thanks to Hankin
3104 <hankin@rogue.consultco.com> for this patch.
3106 * sfm-write.c: (write_variable) Fix off-by-one error in writing
3107 out variable pad records.
3109 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
3111 Previously, if PRINT SPACE were given a negative argument, it
3112 would report an error, then spin in an (almost) infinite loop.
3113 This fixes that behavior.
3115 * print.c: (print_space_trns_proc) After reporting a negative
3116 argument, set number of lines to print to 1.
3118 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
3120 SPSS 8.0 outputs some new record types in its system files, and it
3121 allows longer value labels. Accept these system files.
3123 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
3124 11 emitted by SPSS 8.0.
3126 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
3128 The LIST procedure was too conservative in allocating space for
3129 buffers, which caused a bug that only showed up with very long
3130 output variables. Thanks to Hankin <hankin@dunno.com> for this
3133 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
3135 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
3137 Typo meant string format specifiers weren't checked properly. I
3138 think that Hankin <hankin@dunno.com> sent me this report, but I'm
3139 willing to be corrected on this point.
3141 * format.c: (check_string_specifier) Fix obvious typo.
3143 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
3145 Using $CASENUM in an expression didn't work. Here's a fix.
3146 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
3149 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
3151 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
3153 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
3155 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
3156 other behavior, *sigh*. This patch hopefully fixes that. This
3157 time I've actually tested it.
3159 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
3161 * data-list.c: (read_from_data_list_free,
3162 read_from_data_list_list) Call parse_string_as_format() directly
3163 without mucking around with the field width.
3165 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
3167 Occasionally, you may encounter a script that wants to be
3168 interpreted in interactive mode. Make -i emulate this behavior to
3169 allow such scripts to be executed with PSPP.
3171 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
3173 * cmdline.c: (pre_syntax_message[]) Update -i description.
3175 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
3176 when -i is given on the command line) don't treat unindented lines
3177 as starting a new command.
3179 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
3181 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
3182 mostly caused by local initialized aggregates. After egcs is
3183 fixed upstream these can be removed, but for now they're not a big
3186 * ascii.c: (ascii_postopen_driver) Checker chokes on local
3187 initialized arrays. Avoid this.
3189 * sfm-write.c: (sfm_write_dictionary) Don't use a local
3192 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
3194 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
3195 following changes avoid. Currently I compile sources with egcs
3196 1.1.1 and gcc 2.7.2.3 before sending them out.
3198 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
3200 * ascii.c: (option_tab[]) Initialize all struct members.
3202 * avl.h: (avl_traverser_init) New macro.
3204 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
3207 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
3210 * hash.c: Comment fix.
3212 * hash.h: (hsh_iterator_init) New macro.
3214 * html.c: (option_tab[]) Initialize all struct members.
3216 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
3219 * postscript.c: (option_tab[]) Initialize all struct members.
3220 (output_encodings, preclose, dump_lines) Use new
3221 hsh_iterator_init() macro.
3223 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
3226 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
3229 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
3231 * data-in.c: Examined each of the parsing functions to make sure
3232 that they wouldn't dump core if they were passed a string of the
3233 wrong length, since now the DATA LIST FREE/LIST routines don't
3234 check for field width before passing it to the data parser.
3235 (parse_RBHEX, parse_AHEX) Reject odd length input.
3236 (parse_string_as_format) Reject input that's too short or too
3239 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
3240 a field to its entire declared output width then pass it to the
3241 data-in parsing routines. This contradicted the documented
3242 behavior. This is fixed in these changes. Thanks to Mark H. Wood
3243 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
3244 free-format parsing that differed from SPSS.
3245 (cut_field) Commas and spaces are treated identically. Returns
3246 the proper column instead of a fixed 1 value.
3247 (parse_field) Removed.
3248 (read_from_data_list_free, read_from_data_list_list) Call
3249 parse_string_as_format directly instead of parse_field.
3251 * heap.c: (heap_delete) Stylistic fixes.
3253 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
3255 * loop.c: (loop_2_trns_proc) Formatting fix.
3257 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
3259 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
3261 * vfm.c: (macro FILTERED) New.
3262 (static var filter_var) New.
3263 (process_active_file_write_case) Use FILTERED.
3264 (setup_filter) Set filter_var.
3265 (close_active_file) Delete the filter if not
3266 FILTER_before_TEMPORARY.
3267 (procedure_write_case) Use FILTERED.
3269 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
3271 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
3273 * data-in.c: (parse_day_count) Message fix.
3274 (parse_month) Style fix.
3276 * data-list.c: (struct data_list_pgm) New member eof.
3277 (cmd_data_list) Init eof to 0.
3278 (do_reading) Implement the /END subcommand and read-past-eof
3281 * do-if.c: Include stdio.h when debugging.
3282 (cmd_else_if) Make sure the command is .-terminated.
3284 * glob.c: (init_glob) Capitalize the command prompt.
3286 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
3287 (end_file_trns_proc) Debugging message.
3289 * loop.c: (internal_cmd_loop) Make it work when there's no loop
3291 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
3293 * main.c: (dump_token) Make kwtab[] const.
3295 * set.q: Spelling, comment fixes.
3297 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
3300 * vars-prs.c: (fill_all_vars) Style fix.
3302 * vfm.c: (index_to_varname) Return const.
3304 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
3306 * Changes in many source files for partial -ansi -pedantic and
3307 no-debugging compliance: Remove trailing common in enum
3308 declarations; add `unused' attributes; insert some appropriate
3311 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
3313 * command.c: (shell) Make static.
3314 (run_command) Make static.
3316 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
3318 * dfm.c: (cmd_begin_data) I18n fix.
3320 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
3322 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
3324 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
3327 * file-handle.q: Don't prepend the source file directory name to
3328 the data file name. (Ongoing issue.)
3329 (prepend_current_directory) Comment out.
3330 (internal_cmd_file_handle) Don't call prepend_current_directory().
3331 (fh_get_handle_by_filename) Ditto.
3333 * filename.c: Append zero byte to readlink() return value.
3335 * getline.c: (getl_read_line) I18n fix.
3337 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
3339 * misc.h: Don't use gcc features if __STRICT_ANSI__.
3341 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
3344 * postscript.c: (output_encodings) Don't use local_strdup().
3347 * print.c: Don't use gcc features if __STRICT_ANSI__.
3349 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
3351 * recode.c: (parse_src_spec) Fully brace nested if's.
3353 * set.q: (global var set_testing_mode) New var.
3355 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
3357 * ascii.c: Add some more `unused' attributes that only come into
3358 play when NDEBUG is defined.
3359 (ascii_close_page) Set s_len when reallocating s.
3361 * crosstabs.q: (delete_missing) New function.
3362 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
3363 (make_summary_table) Create summary table reallocable.
3365 * postscript.c: Add more `unused' attributes as above.
3367 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
3368 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
3370 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
3373 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
3374 gratuitous space between parameter definition.
3376 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
3377 complaints about running off the end of functions with NDEBUG
3380 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
3382 * Several source files: Removed some PORTME notes when reflection
3383 revealed that ANSI forbids that sort of breakage. Also, added
3384 lots of `unused' qualifiers here and there.
3386 * aggregate.c: (accumulate_aggregate_info) Remove local var
3387 weighting that turned out not to be used.
3389 * avl.c: Update to version 1.1.0. Add unused specifier.
3390 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
3392 (avl_probe) Replace some instances of 1 with +1 where appropriate.
3393 (avl_find) Cast return value to void *.
3394 (avl_delete) q doesn't need to be initialized at the beginning of
3395 the function. Replace some instances of 1 with +1.
3396 (force_avl_delete) Renamed avl_force_delete, all references changed.
3397 (compare_ints) `param' marked unused.
3398 (print_int) `param' marked unused.
3399 (recurse_tree) Replace some instances of 1 with +1.
3401 * avl.h: Update to version 1.1.0. Only declares avl function
3402 types if not already declared.
3403 (AVL_MAX_HEIGHT) Only define if not already defined.
3404 (struct avl_node) New unused member char pad[2].
3405 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
3406 (force_avl_insert) Renamed avl_force_insert.
3407 (force_avl_delete) Renamed avl_force_delete.
3409 * crosstabs.q: (struct table_entry) Put `freq' into a union with
3411 (struct crosstab) Add new member `ofs'.
3412 (glob var int_tab) Removed.
3413 (custom_tables) In integer mode, assign v[i] properly through the
3415 (custom_variables) Now p.crs.max == max + 1.
3416 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
3417 (precalc) Implement integer mode.
3418 (calc_integer) Implement integer mode.
3419 (compare_table_entry) Remove unused local variable `comparing'.
3420 (make_summary_table) Implement integer mode.
3421 (macro ns_rows) Implemented as static variable now.
3422 (several variables) Made static, from global.
3423 (output_pivot_table) Use table_value_missing() for column heads.
3424 Remove several unused local variables. Implement integer mode
3425 table summing. Count up ns_rows.
3426 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
3427 (find_pivot_extent) Moved into find_pivot_extent_general; now just
3428 calls that function or find_pivot_extent_integer.
3429 (find_pivot_extent_integer) New function.
3430 (enum_var_values) Implemented for integer mode.
3431 (table_value_missing) New function.
3432 (display_dimensions) Call table_value_missing() for heads.
3433 (float_M_suffix) New function.
3434 (display_crosstabulation) Call table_value_missing() for row
3435 heads. Handle missing values in /MISSING=REPORT mode.
3436 (calc_fisher) Remove unused var N.
3437 (calc_r) Remove unused var fact.
3439 * data-list.c: (dump_fixed_table) Fix table dimensioning.
3440 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
3442 * data-out.c: (insert_commas) Remove unused var cp.
3443 (convert_CCx) Remove unused vars save_set_decimal,
3446 * descript.q: (dump_z_table) Fix table dimensioning.
3447 (pre_calc) Remove unused var j.
3448 (display) Remove unused vars title, s. Fix table dimensioning.
3450 * expr-evl.c: Comment fixes.
3452 * frequencies.q: (full_dim) New function.
3453 (dump_full) Fix table dimensioning.
3454 (condensed_dim) New function.
3455 (dump_condensed) Fix table dimensioning.
3457 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
3460 * html.c: (html_close_drive) Remove unused var i.
3461 (postopen) Remove unused vars title, curfn_len, cp.
3462 (preclose) Remove unused vars this, x.
3464 * lexer.c: Comment fixes.
3466 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
3468 * means.q: (custom_tables) Remove unused var m_dim.
3470 * mis-val.c: Format fix.
3472 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
3474 * output.c: (outp_get_paper_size) Remove unused var cp.
3476 * pfm-read.c: (read_float) Remove unused var save, unused label
3478 (read_variables) Remove unused vars cp, j.
3479 (read_value_label) Remove unused var j.
3481 * pfm-write.c: (bufwrite) Remove unused var i.
3483 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
3485 (output_encodings) Remove unused vars char_cp, n_output.
3486 (read_ps_encodings) Remove unused var ep.
3487 (postopen) Remove unused var title.
3488 (preclose) Remove unused var fp.
3489 (ps_open_page) Remove unused vars true, false, orientation,
3490 mirror_horz, mirror_vert, width, length.
3491 (ps_text_metrics) Remove unused var x.
3493 * q2c.c: (find_symbol) Remove unused var y.
3494 (parse_setting) Remove unused parameter sbc, all references
3496 (dump_parser) Remove unused var cp.
3497 (dump_free) Remove unused var i.
3499 * set.q: (static vars args, n) Removed.
3500 (internal_cmd_gset) Removed.
3502 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
3503 (read_machine_flt64_info) Removed unused var file_endian.
3504 (read_documents) Removed unused var i.
3505 (read_compressed_data) Removed unused parameter dict, all
3508 * sfm-write.c: (bufwrite) Removed unused var i.
3509 (sfm_write_case) Removed unused var i.
3511 * sort.c: (merge_once) Remove unused var t.
3512 (write_separate) #if 0 out as dead code.
3514 * split-file.c: (cmd_split_file) Remove unused var i.
3516 * sysfile-info.c: (sysfile_info_dim) New function.
3517 (cmd_sysfile_info) Fix table dimensioning.
3518 (variables_dim) New function.
3519 (display_variables) Fix table dimensioning.
3520 (describe_variable) Remove unused var prev_r.
3522 * t-test.q: (z_postcalc) Removed.
3523 (pairs_calc) Remove unused var bad_weight.
3524 (postcalc) Remove unused vars dfn, dfd.
3526 * tab.c: (tab_create) Set t->dim to NULL.
3527 (tab_dim) Make sure t->dim is NULL first.
3528 (tab_natural_width) Remove parameter `clamp'.
3529 (tab_value) Remove duplicate assertion for table.
3530 (tab_raw) New function.
3531 (nowrap_dim) New function.
3532 (wrap_dim) New function.
3533 (tab_output_text) Fix table dimensioning.
3535 * tab.h: (tab_raw) New macro.
3537 * val-labs.c: (get_label) Remove unused var type.
3538 (copy_value_labels) Remove unused var trav.
3540 * var.h: (struct crosstab_proc) Completely changed.
3542 * vars-prs.c: (parse_dict_variable) Remove unused var v.
3544 * vfm.c: (open_active_file) Remove unused vars i, lp.
3546 * weight.c: (weight_trns_proc) #if 0 out as dead code.
3548 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
3550 * Makefile.am: Add apply-dict.c, flip.c.
3552 * apply-dict.c: New file.
3554 * command.c: (struct command) Make cmd[] larger for CLEAR
3555 TRANSFORMATIONS command name.
3556 (parse_cmd) Make sure we're in a valid state before using it as an
3557 index. Discard variables and reset state on invalid transitions.
3558 (cmd_clear_transformations) New function.
3560 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
3561 Add unimplemented PRESERVE, RESTORE.
3563 * file-handle.h: Include stddef.h.
3567 * pfm-read.c: (parse_value) Pad value label values with spaces,
3570 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
3571 (sfm_close) Decrement reference count, make sure it's zero.
3572 (sfm_maybe_close) New function.
3573 (sfm_read_dictionary) Handle reference counts.
3575 * vars-atr.c: (clear_default_dict) New function.
3576 (discard_variables) Use clear_default_dict().
3578 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
3580 * Makefile.am: Add pfm-write.c.
3581 (LDADD) Add the libgmp2 libraries.
3583 * command.def: Define EXPORT.
3585 * get.c: (cmd_export) New function.
3586 (export_write_case_func) New function.
3588 * pfm-read.c: (static spss2ascii[]) Make it const.
3590 * pfm-write.c: New file.
3592 * sfm-write.c: Formatting, comment fixes.
3594 * var.h: Comment fix.
3596 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
3598 * Makefile.am: Add pfm.h, pfm-read.c.
3600 * command.def: IMPORT is now implemented.
3602 * format.c: (glob var translate_fmt[]) New var.
3604 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
3605 (cmd_import) New function.
3606 (import_source_read) New function.
3607 (glob var import_source) New var.
3609 * pfm-read.c: New file.
3613 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
3615 (dump_dictionary) Disabled printing a couple of items.
3617 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
3619 * crosstabs.q: (postcalc) Call make_summary_table().
3620 (make_summary_table) New function.
3621 (insert_summary) New function.
3622 (display_dimensions) Remove some unnecessary arguments, all
3624 (output_pivot_table) Fix lots of problems with the risk table
3626 (submit) Don't display an empty table.
3627 (display_risk) Fix order of arguments to calc_risk().
3629 * glob.c: Always include assert.h and stdlib.h.
3631 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
3634 * tab.c: (tab_create) Cosmetic changes.
3636 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
3638 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
3642 * crosstabs.q: (output_pivot_table) Headers drawing and submission
3643 code simplified, moved into new function submit().
3644 (submit) New function.
3645 (crosstabs_dim) New function.
3646 (display_directional) Substitute variable names for %s where
3648 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
3649 (calc_symmetric) Initialize parameters only if non-NULL.
3650 Calculate Somers' d.
3651 (calc_directional) Calculate Somers' d (or copy it, really).
3654 * output.c: (outp_string_width) New function.
3656 * postscript.c: (postopen) Calculate font widths based on the
3657 width of the zero '0' character, not the width of the space
3658 character. Set paper-width and paper-length based on points, not
3660 (ps_open_page) Fix page setup string for landscape mode.
3662 * som.h: (struct som_dimension) Removed.
3663 (struct som_table_class) height, width members take int * not
3666 * tab.c: Many functions now have added parameter validation.
3667 (tab_height, tab_width) These functions were removed and merged
3668 into a single function tab_resize(), and all references changed.
3669 (tab_dim) Rewritten since the interface changed; reduced from
3670 hundreds of lines to two. All callers were changed. Currently
3671 most of them just use tab_natural_dimensions as their callback and
3672 await detailed translation of functionality.
3673 (tab_natural_width) New function.
3674 (tab_natural_height) New function.
3675 (tab_natural_dimensions) New function. This is a callback
3676 function, not something that you'd want to call directly.
3677 (tab_nat_dim) Removed.
3678 (tabi_table) Allocates t->w and t->h.
3679 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
3680 dimensions callback.
3681 (evaluate_dimensions) Removed.
3682 (sum_columns) Removed.
3684 * tab.h: (enum TAL_1THIN) Removed.
3685 (enum series t_*) Removed.
3686 (struct tab_table) Members trh, trv changed to unsigned char *
3687 from int *. Member dim changed to a function pointer from a
3688 unsigned char *. Member max_stack_height removed. New members
3690 (macros tab_l, tab_r, tab_t, tab_b) New.
3692 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
3694 * ascii.c: (delineate) Assign last_space_nchars before skipping
3695 spaces, to fix right justification.
3697 * crosstabs.q: (static vars risk, direct) New vars.
3698 (static var pearson_r) Removed.
3699 (glob var chisq_fisher) Made static.
3700 (static vars row_tot[], col_tot[]) Don't include grand total
3702 (static var grand_total) Renamed W, all references changed.
3703 (output_pivot_table) Only make `table' if num_cells != 0. Make
3704 risk and directional tables. Deal with grand total no longer part
3705 of col_tot[]. Free rows and cols after we're done with them.
3706 (display_risk) New function.
3707 (display_directional) New function.
3708 (clac_r) Rewritten so that it stores all its results into its
3709 arguments, so it can be used for Spearman's correlation too.
3710 (calc_symmetric) Added a t[] argument, all references changed.
3711 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
3712 Pearson's r, Cohen's kappa.
3713 (calc_risk) New function.
3714 (calc_directional) New function.
3716 * som.c: (som_submit) Improved debugging code.
3718 * stats.c: (hypercube) New function.
3719 (cube) New function.
3721 (normal_sig) Went back to old implementation, which actually
3724 * stats.h: (macros square, cube, hypercube) Removed. The
3725 equivalent functions in stats.c are inlined here; all references
3726 to square changed to sqr.
3728 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
3730 * crosstabs.q: (N_SYMMETRIC) New define.
3731 (postcalc) Disable debug printing.
3732 (static vars chisq_fisher, pearson_r) New.
3733 (output_pivot_table) Add support for symmetric measures. Add
3734 chi-square output of exact sigs.
3735 (display_chisq) Rewritten.
3736 (display_symmetric) New function.
3737 (gamma_int) New function.
3739 (swap) New function.
3740 (calc_fisher) New function.
3741 (calc_chisq) Check boundary conditions better. Calculate Yates,
3742 Fisher, Mantel-Haenszel tests.
3743 (calc_r) New function.
3744 (calc_symmetric) New function.
3746 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
3748 (chisq_sig) Better boundary conditions. Renamed from
3751 * tab.h: (struct tab_table) New member cf.
3753 * tab.c: (tab_create) Set cf.
3754 (tab_width) New function.
3755 (tab_realloc) Handle cf.
3756 (tab_vline) Handle cf.
3757 (tab_hline) Handle cf.
3758 (tab_box) Handle cf.
3759 (tab_value) Handle cf.
3760 (tab_float) Handle cf.
3761 (tab_text) Handle cf.
3762 (tab_joint_text) Handle cf.
3763 (tab_offset) Handle cf.
3764 (tab_next_row) Handle cf.
3765 (evaluate_dimensions) Handle cf.
3766 (render_strip) Handle cf.
3768 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
3770 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
3771 output_pivot_table().
3772 (output_pivot_table) Moved lots of local variables outside and
3773 made them static. Add beginnings of chi-square statistic
3774 support. Now column and row totals aren't in the main matrix.
3775 Always zero out any leftover rows & columns after we're done with
3776 the table entries. Move all output stuff into
3777 display_dimensions(), display_crosstabs(), display_chisq().
3778 (display_dimensions) New function.
3779 (display_crosstabulation) New function.
3780 (display_chisq) New function.
3781 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
3783 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
3784 references, simplify logic.
3786 * postscript.c: Remove scale, translate-x, translate-y,
3787 mirror-horz, mirror-vert, rotate-180 options.
3788 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
3789 All references deleted.
3790 (macro YT) New macro.
3791 (array option_tab[]) Removed options.
3792 (ps_option) Removed options.
3793 (ps_open_page) Write page setup explicitly to output file, without
3794 using now-deleted BP function.
3795 (macro dump_line) Use YT().
3796 (macro dump_thick_line) Use YT().
3797 (draw_headers) Use YT().
3798 (switch_font) Reorder arguments to SF function.
3799 (write_text) Use YT().
3801 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
3804 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
3806 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
3807 null-debugging code.
3808 (tab_realloc) Remove null-debugging code. Initialize new regions
3810 (tab_vline) Support offsets.
3811 (tab_hline) Support offsets.
3812 (tab_box) Support offsets.
3814 (tab_nulls) Removed.
3817 (evaluate_dimensions) Remove null-debugging code. Understand
3818 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
3819 TAB_EMPTY not present.
3821 * tab.h: New cell attribute TAB_EMPTY.
3822 (macros tab_nr, tab_nc, tab_row, tab_col) New.
3824 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
3825 try to read them from system files.
3827 * vfm.c: (dump_splits) Don't call tab_null().
3829 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
3831 * crosstabs.q: (struct crosstab) Added `missing' member.
3832 (custom_tables) Init missing.
3833 (calc_general) Handle missing values.
3834 (calc_chisq) New function.
3835 (output_pivot_table) Start work on chi-square output. Update for
3836 new tab offset support functions. Shorten statistic names.
3838 * Several files: add in more `const's to placate gcc's warnings.
3840 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
3843 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
3844 tab_null, tab_nulls, tab_value, tab_float, tab_text,
3845 tab_joint_text) Add col_ofs and row_ofs support.
3846 (tab_offset) New function.
3847 (tab_next_row) New function.
3848 (tab_row) New function.
3849 (tab_col) New function.
3850 (tabi_table) Add col_ofs and row_ofs support.
3852 * vars-atr.c: (is_system_missing) New function.
3854 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
3856 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
3857 (static var no_cells) Removed.
3858 (static var num_cells) New.
3859 (static var expected) New.
3860 (static var cells[]) New.
3861 (internal_cmd_crosstabs) Deal with new variables.
3862 (postcalc) Removed most of the meat and put it in new function
3863 output_pivot_table().
3864 (output_pivot_table) Calculates and outputs an entire pivot table.
3866 * postscript.c: (postopen) Fix problems with free()ing addresses
3867 not obtained from malloc().
3869 * som.c: (som_submit) Add assertion.
3871 * sysfile-info.c: (describe_variable) Use new tab_nulls()
3874 * tab.c: (static var tab_names[]) New.
3875 (tab_realloc) -1 for nc or nr indicates no change.
3876 (tab_nulls) New function.
3877 (tab_dim) Use tab_names[].
3878 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
3879 (evaluate_dimensions) Don't terminate on uninited cells, just put
3880 an X in them and emit a notice. Use tab_names[].
3882 * tab.h: Move bits into tab.def.
3884 * tab.def: New. Don't try to declare tab_table_class because then
3885 som.h has to be included.
3887 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
3889 * command.def: New file, contains all the command definitions
3890 previously included bodily in command.c.
3892 * format.def: New file, contains all of the format definitions
3893 previously split across format.h, format.c, and sfm-write.c.
3895 * lexer.h: Renamed from tokens.h in order to match corresponding
3898 * lexerP.h: Moved some rarely used functions exported by lexer.c
3901 * Makefile.am: Commemorate renamed files.
3902 (EXTRA_DIST) Add command.def, format.def.
3904 * command.c: [0] (walk_cmdtable_func) Removed.
3906 * crosstabs.q: (postcalc) Made it work and print out matrices
3908 (enum_column_values) Renamed enum_var_values, generalized for any
3911 * format.h: (struct fmt_desc) New member `spss'.
3913 * q2c.c: (main) Generated code includes lexer.h instead of
3916 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
3917 instead of an independent translation table.
3919 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
3921 * Lots of source files: Added const to declarations.
3923 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
3925 * arena.c: (arena_clear) Set prev pointer to null when done.
3927 * ascii.c: (ascii_option) Rename index as indx.
3929 * avl.c: This is now a separate library called libavl.
3930 (xmalloc) Make static.
3931 (avl_probe) Step A7 can use the cache instead of an explicit
3933 (avl_delete) Don't maintain a q pointer because it's always
3934 available in the pointer stack. Comment fix.
3936 * avl.h: This is now a separate library called libavl.
3938 * command.c: (cmd_table[]) Remove spurious trailing "".
3940 * common.h: Only include random() fix if this system needs it.
3942 * crosstabs.q: Include alloca headers.
3943 (n_sorted_tab) New global var.
3944 (postcalc) Mostly rewritten.
3945 (find_pivot_extent) Rewritten.
3946 (enum_column_values) Rewritten.
3948 * data-out.c: (convert_F) Rename inner n as n_spaces.
3950 * error.c: (dump_message) Don't have an outer var i.
3952 * file-handle.q: (static var f) Removed. All references removed.
3953 (internal_cmd_file_handle) Uses a local variable instead of f.
3955 * get.c: (trim_dictionary) Change scope of i, i1, i2.
3956 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
3959 * getline.h: Declare getl_history as extern. Reported by
3960 palme@uni-wuppertal.de (Hubert Palme).
3962 * postscript.c: (postopen) Some large mods for constness.
3964 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
3967 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
3969 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
3970 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
3973 * avl.c, avl.h: New files. These form a clean-room
3974 reimplementation of avllib. Iterative algorithms are used in
3975 place of recursive ones, so there is no resemblance in the code.
3977 * Lots of headers: Don't include other headers by default.
3979 * Lots of source files: Explicitly include all needed headers.
3981 * arena.c: (arena_clear) New function.
3983 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
3984 (static var ar) Removed.
3985 (staitc vars ar_tc, ar_col) New.
3986 (cmd_crosstabs) Destroy the arenas.
3987 (internal_cmd_crosstabs) Create the arenas.
3988 (precalc) Don't need a free function for the hash.
3989 (calc_general) Make sure to zero out the trailer on the key data
3991 (print_table_entries) Updated.
3992 (postcalc) Worked on actually implementing.
3993 (find_pivot_extent) New function.
3994 (compare_value) New function.
3995 (enum_column_values) New function.
3997 * data-in.c: (parse_month) Make local array `static const'.
3999 * data-out.c: (convert_date) Make local array `static const'.
4000 (convert_WKDAY) Same.
4001 (convert_MONTH) Same.
4003 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
4004 been renamed to avl_walk().
4006 * hash.c: Rewritten more efficiently.
4008 * hash.h: Add attribute const to hsh_next_prime declaration.
4010 * lexer.c: (id_match) Make arguments const.
4012 * postscript.c: (ps_postopen_driver) Make default fonts the
4015 * q2c.c: (main) Generated code needs stdlib.h.
4017 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
4018 initialized to 0 now, not to NULL. All other references to
4019 avl_traverser were updated in the same way.
4021 * tokens.h: Macro version of id_match updated to use const
4024 * val-labs.c: (inc_ref_count) New function.
4025 (copy_value_labels) Simply through use of new avl_copy() function.
4027 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
4029 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
4030 (postcalc) Worked on this.
4032 * postscript.c: (OPO_DOUBLE_LINE) New enum.
4033 (struct ps_driver_ext) New line_width_thick member.
4034 (ps_preopen_drive) Init line_width_thick.
4035 (option_tab[]) Add line-* options.
4036 (ps_option) Parse line-* options.
4037 (postopen) Add line_width_thick support. Strip leading spaces on
4038 prologue output lines.
4039 (ps_open_page) Include line_width_thick in output.
4040 (macro dump_thick_line) New.
4041 (dump_fancy_line) Support thick lines as well as double lines.
4043 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
4045 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
4046 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
4048 * Many source files: Rename `options' to `pv_opts' as appropriate.
4050 * command.c: (static var cmd_table[]) Add CROSSTABS command.
4052 * common.c: (xcalloc) New function.
4054 * crosstabs.q: New file. Not finished yet, though.
4056 * data-list.c: Comment fix.
4058 * error.c: Remove some old Checker cruft.
4060 * frequencies.q: (dump_full) Cumulate valid percent instead of
4063 * getline.c: Comment fix.
4065 * hash.c: Comment fixes.
4067 * hash.h: (struct hsh_table) Make hash functions return unsigned
4068 instead of int to avoid problems with taking the modulo of
4069 negative return values. All references changed.
4071 * misc.c: (intlog10) Make its table static const instead of auto.
4073 * sfm-read.c: (read_header) Make `prefix' static const instead of
4076 * var.h: (union value) Add member `hash'.
4077 (struct variable) Rename prv_index as `foo'--all references
4079 (typedef pv_opts) Removed. All references changed.
4081 * vars-prs.c: (parse_variables) Message fixes.
4083 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
4085 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
4086 they are being inserted. Don't check for BY variables of
4087 different types. Discard variables if the active file isn't
4088 included in the merge.
4089 (mtf_processing) Essentially rewritten.
4090 (mtf_merge_dictionary) Check for master/slave variables of
4091 different types/widths.
4093 * vfm.c: (static var not_canceled) New var.
4094 (process_active_file) Don't call vfm_source->read() if
4095 there's no vfm-source. Initialize not_canceled.
4096 (process_active_file_write_case) Honor and update not_canceled.
4097 (prepare_for_writing) Rollback changes from yesterday, they were
4099 (close_active_file) Don't destroy vfm_source unless it exists.
4101 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
4103 * Lots of source files: Added { } around nested if/else constructs
4104 to avoid new gcc 2.8 warnings.
4106 * data-in.c: (parse_Z) Declare `int' type explicitly.
4109 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
4110 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
4111 prev members. Put TABLEs at the end of the chain and FILEs at the
4112 beginning. Don't allow the active file in STATE_INIT. Use proper
4113 `seen' value for the active file. Fill out the by members and
4114 make sure they're of consistent type. Do the actual merge
4116 (mtf_processing_finish) New function.
4117 (var_type_description) New function.
4118 (mtf_free_file) New function.
4119 (mtf_free) Rewritten.
4120 (mtf_delete_file_in_place) New function.
4121 (mtf_read_nonactive_records) New function.
4122 (mtf_compare_BY_values) New function.
4123 (static var mtf_seq_no) New var.
4124 (mtf_processing) New function.
4125 (mtf_merge_dictionary) Assign nval members for the system file
4126 dictionary. Assign fv values for its variables. Point each slave
4127 variable to the corresponding master variable.
4129 * hash.c: Include str.h.
4131 * mis-val.c: (copy_missing_values) src arg is const.
4133 * misc.c: (spacing) Make `max' var explicitly int.
4135 * sfm-read.c: (dump_dictionary) Message reformatting.
4136 (sfm_read_case) Add assertion.
4138 * sort.c: Esthetic fixes.
4140 * var.h: (struct match_files_proc) New struct.
4141 (struct variable) Add private data match_files_proc.
4143 * vars-atr.c: (delete_variable) Implement. Add argument for the
4144 dictionary that owning the variable.
4145 (dup_variable) Add assertion.
4147 * vfm.c: Comment fixes, hopefully the comments are correct now.
4148 (process_active_file) New function.
4149 (process_active_file_write_case) New function.
4150 (process_active_file_output_case) New function.
4151 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
4153 (write_case) Renamed procedure_write_case(). Now write_case is a
4154 pointer to a function. Style fixes.
4156 1998-03-05 Ben Pfaff <blp@gnu.org>
4158 * Makefile.am: (q2c) Link with libmisc.
4159 (version.c) Define default_config_path, include_path,
4162 * ascii.c: (ascii_postopen_driver) When the default newline string
4163 is requested, open file in text mode. Suggested by
4164 palme@uni-wuppertal.de (Hubert Palme).
4165 (static vars line_buf, line_p) Change from char * to unsigned char
4167 (ascii_close_page) char * to unsigned char *.
4169 * cmdline.c: (parse_command_line) Implement -r option by
4170 prepending ~/.pspp/rc to the list of files to process.
4172 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
4173 before pulling in a final line.
4174 (null_func, null_int_func) Removed (dead code).
4176 * descript.q: (display) Calculate width of variable name column
4177 properly. Calculate number of valid cases properly. Reported by
4178 palme@uni-wuppertal.de (Hubert Palme).
4180 * filename.c: (init_filename) Use default_config_path instead of
4181 now obsolete CONFIG_PATH.
4183 * getline.c: (getl_initialize) Use include_path instead of now
4184 obsolete INCLUDE_PATH.
4185 (getl_add_file) New argument `where'. All references changed.
4187 * groff.c: (find_font_file) Use groff_font_path instead of now
4188 obsolete GROFF_FONT_PATH.
4190 * postscript.c: (find_ps_file) Use groff_font_path instead of now
4191 obsolete GROFF_FONT_PATH. Copy through temporary variable to
4192 avoid problems with constness.
4194 * str.h: (macro cs_streq) New macro.
4196 * version.h: (glob var default_config_path, include_path,
4197 groff_font_path) New vars.
4199 1998-02-23 Ben Pfaff <blp@gnu.org>
4201 * Many source files: Change verbose_msg() priority levels and
4204 * aggregate.c: Include debug-print.h.
4206 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
4208 (static var pre_syntax_message) Document --safer/-s and
4211 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
4213 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
4214 because it's not used but it's still copied.
4215 (open_file_r) Remove gratuitous debug message.
4217 * filename.c: (safety_violation) New function.
4218 (open_file) Remove gratuitous debug messages. Don't allow pipe
4219 files if set_safer is set.
4221 * get.c: Turn off debugging.
4223 * getline.c: (getl_add_virtual_file) New function.
4224 (getl_read_line) Add verbose_msg() call for opening new syntax
4226 (getl_perform_delayed_reset) Add a return value describing whether
4227 any action was taken. Call reset_eof().
4229 * getline.h: Comment fix.
4231 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
4232 place of incorrect `continue'. Use strtok_r() instead of
4233 strtok(). Always check strtok_r() return value.
4234 (groff_read_DESC) Use strtok_r() instead of strtok().
4236 * lexer.c: (reset_eof) New function.
4238 * main.c: (parse) Get a token after performing a delayed reset
4239 action; allow empty syntax files.
4241 * postscript.c: (output_encodings) Use strtok_r() instead of
4244 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
4246 * set.q: Comment fixes.
4247 (glob var set_safer) New var.
4248 (internal_cmd_set) Support SAFER.
4250 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
4252 * temporary.c: (free_dictionary) Set d->splits to NULL after
4255 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
4256 variable deleted, not if it *isn't* deleted.
4258 1998-02-16 Ben Pfaff <blp@gnu.org>
4260 * command.c: (array cmd_table[]) Add MATCH FILES.
4262 * common.c: Comment fixes.
4264 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
4265 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
4266 Include alloca.h. Problem reported by palme@uni-wuppertal.de
4269 * expr-opt.c: Include str.h. Problem reported by
4270 palme@uni-wuppertal.de (Hubert Palme).
4272 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
4273 (static var mtf_by) Change from char ** to variable **.
4274 (static var mtf_master) New var.
4275 (mtf_merge_dictionary) New function.
4276 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
4277 var type. Reorder tests properly. Initialize file->dict. Detect
4278 TABLE= without BY=. Read file dictionaries and merge them. Give
4279 subcommand name with IN, LAST, FIRST error messages. Create IN,
4280 LAST, FIRST variables. Comment fixes.
4281 (mtf_free) Don't free default_dict. Free mtf_master.
4283 * getline.c: Define getl_mode. Change getl_buf_size to size_t
4285 (handle_line_buffer) Cast int to size_t in comparison to avoid
4288 * getline.h: Declare getl_mode extern.
4290 * groff-font.c: (groff_read_font) Type-fix calls to getline.
4291 (groff_read_DESC) Make line_size a size_t.
4292 (match_tok) Parenthesize name to avoid macro expansion.
4294 * mis-val.c: (copy_missing_values) New function.
4296 * postscript.c: (postopen) Make buf_size a size_t.
4298 * sfm-read.c: (dump_dictionary) Make global from static. Print
4299 variable info in parts for easier debugging with Checker.
4301 * temporary.c: (copy_variable) Use copy_value_labels().
4302 (new_dictionary) New arg: whether to copy file label, documents.
4304 * val-labs.c: (copy_value_labels) New function.
4306 * var.h: (enums MISSING_*) Add MISSING_COUNT.
4308 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
4310 (dup_variable) Set prv_index, get.fv, get.nv.
4312 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
4314 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
4316 * Many source files: For ANSI-compliance, add empty statement
4317 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
4318 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
4320 * data-in.c: (parse_numeric) Some header files break on
4321 -DBL_MIN_10_EXP because they get a --; add () for safety.
4322 Reported by palme@uni-wuppertal.de (Hubert Palme).
4324 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
4325 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
4326 (dfm_close) Use close_file_ext.
4327 (open_inline_file) Set file.file to NULL, not file.
4328 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
4329 struct and use open_file_ext().
4330 (read_record) Use file.file.
4332 * file-handle.q: (prepend_current_directory) Pass through special
4335 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
4336 (normalize_filename) Pass through special filenames.
4337 (open_file, close_file) Accept pipe| and |pipe syntaxes as
4339 (dirname) Rename blp_dirname() because of name conflict on some
4340 OS. All references changed. Reported by palme@uni-wuppertal.de
4342 (is_special_filename) New function.
4344 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
4345 (trim_dictionary) Conditionalize some of the options on whether
4346 GTSV_OPT_MATCH_FILES is in *options.
4347 (rename_variables) Don't allow variables to be renamed as scratch
4349 (MTF_*) New enum series.
4350 (struct mtf_file) New struct.
4351 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
4353 (cmd_match_files, mtf_free) New functions.
4355 * lexer.c: (match_int) Needed parentheses around name to escape
4356 macro expansion. Reported by Micah Altman
4357 <maltman@www-vdc.fas.harvard.edu>.
4359 * print.c: Needed to include alloca.h. Reported by Micah Altman
4360 <maltman@www-vdc.fas.harvard.edu>.
4362 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
4363 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
4366 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
4367 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
4369 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
4371 * html.c: (struct html_driver_ext) Move into htmlP.h.
4372 (html_preopen_driver) Initialize cp_x, cp_y.
4373 (html_submit) Implement as call to output_tab_table().
4374 (change_attributes) New function.
4375 (escape_string) New function.
4376 (output_tab_table) New function.
4378 * list.q: (write_all_headers) Add code for writing headers for the
4380 (clean_up) Write out the html close-table tag.
4381 (determine_layout) Ignore html driver.
4382 (list_cases) Write html data.
4384 * som.c: (som_submit) Move more of the code into output_table().
4386 * tab.c: (static var hit) Make a global var and rename tab_hit.
4387 (static var tab_table_class) Make a global var.
4389 * htmlP.h: New file.
4391 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
4393 * dump-sysfile.c: Removed.
4395 * html.c: (preclose) Change comment in emitted code.
4397 * matrix-data.c: Debugging off by default. Comment fixes.
4398 (static var container) New var.
4399 (cmd_matrix_data) Create and destroy container. Initialize
4400 is_per_factor[] to 0s. Move code into new function
4401 string_to_content_type(). Require split values to be present in
4402 the data when ROWTYPE_ is explicit. Call specific function, not
4403 general read_matrices().
4404 (string_to_content_type) New function.
4405 (context) Exclude all whitespace, not just spaces.
4406 (mget_token) A dot is a number. Add assertion.
4407 (static var data) Renamed nr_data.
4408 (static var factor_values) Renamed nr_factor_values.
4409 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
4410 only specific case. Close data_file before exit.
4411 (fill_matrix) New function.
4412 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
4413 printing. Style fixes. Message fixes. Move code into
4415 (read_matrices_without_rowtype) Rename
4416 matrix_data_read_without_rowtype(). Fix off-by-one error on
4417 loops. Allocate nr_data[] memory from arena.
4418 (read_matrices_with_rowtype) Removed.
4419 (read_splits) Renamed nr_read_splits(). Style fixes.
4420 (read_factors) Renamed nr_read_factors().
4421 (dump_cell_content) Comment fixes. Arguments changed. Change
4422 debug printing. All references changed.
4423 (output_data) Renamed nr_output_data().
4424 (static var wr_content) New var.
4425 (struct factor_data) New struct.
4426 (static var wr_data) New var.
4427 (static var wr_current) New var.
4428 (matrix_data_source_destroy_source) Removed.
4429 (read_matrices_with_rowtype) New function.
4430 (matrix_data_read_with_rowtype) New function.
4431 (wr_read_splits) New function.
4432 (compare_factors) New function.
4433 (wr_output_data) New function.
4434 (wr_read_rowtype) New function.
4435 (wr_read_factors) New function.
4436 (wr_read_indeps) New function.
4437 (glob var matrix_data_source) Make destroy_source member NULL as
4440 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
4442 * lexer.c: (syntax_error) Give better error message when at end of
4445 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
4446 N_SCALAR to output as plain N.
4447 (mdump_token) Change output format.
4448 (context) Fix message output interaction with spaces in input.
4449 (another_token) New function.
4450 (force_eol) Improved error message.
4451 (static var max_cell_index) New var.
4452 (read_matrices) Init `cells'. factor_values is now per-cell.
4453 Init max_cell_index.
4454 (read_data_lines) Replace `compare' local with new `compare' arg.
4455 Debugging messages changed. Only read factors if per_factor.
4456 Propagate error return from read_factors(), force_eol().
4457 Copy N_SCALAR values across the N vector.
4458 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
4459 check parentheses manually since we now have is_per_factor[].
4460 Call read_data_lines() with new args. Check for end of data after
4461 looping, using another_token().
4462 (read_factors) Arguments changed. Use max_cell_index to determine
4463 whether to read or compare factors. Message fixes.
4464 (dump_cell_content) New function.
4465 (output_data) Completely rewritten because content types were
4466 supported to be nested inside factor values, not vice versa.
4468 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
4470 * lexer.c: (syntax_error) Support formatted varargs messages.
4472 * matrix-data.c: Turn debugging on by default.
4473 (static content_type[]) New array.
4474 (static content_names[]) New array.
4475 (static rowtype_, varname_) New vars.
4476 (static is_per_factor[]) New array.
4477 (static split_values) Moved declaration.
4478 (static n_continuous, first_continuous) New var.
4479 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
4480 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
4481 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
4482 Check for continuous variables.
4483 [DEBUGGING] (debug_print) Remove content_names[].
4484 (mdump_token) New macro.
4485 (mget_token_dump) New function.
4486 (mdump_token) New function.
4487 (context) New function.
4488 (mget_token) Fix messages.
4489 (static var data, split_values, factor_values) New vars.
4490 (read_matrices) Manage split_values, factor_values.
4491 (read_data_lines) New function.
4492 (read_matrices_without_rowtype) Implemented.
4493 (read_splits) Message fixes. Uses `just_read'.
4494 (read_factors) New function.
4495 (output_data) New function.
4496 (matrix_data_source_destroy_source) Close the file handle.
4497 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
4500 * str.c: (strpadcmp) Removed.
4502 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
4504 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
4506 * Lots of source files: Add cast to unsigned character to calls to
4507 tolower() and toupper().
4509 * aggregate.c: Set default_dict.splits to NULL.
4511 * command.c: (static variable tab[]) Add MATRIX DATA.
4513 * data-in.c: Add debugging defines. Formatting fixes.
4515 * expr-opt.c: Formatting fixes.
4517 * lexer.c: (syntax_error) Message fixes.
4519 * matrix-data.c: New enum series.
4520 (static vars fmt, section, diag, explicit_rowtype, signle_split,
4521 split_values, n_factors, factors, cells, pop_n, contents,
4522 n_contents) New vars.
4523 (cmd_matrix_data) Finished implementation.
4524 (compare_variables_by_mxd_vartype) New function.
4525 [DEBUGGING] (debug_print) New function.
4526 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
4527 (read_matrices) New function.
4528 (read_matrices_without_rowtype) New function.
4529 (read_matrices_with_rowtype) New function.
4530 (read_splits) New function.
4531 (mget_token) New function.
4532 (force_eol) New function.
4533 [0] (test_tokenizer) New function.
4534 (matrix_data_source_destroy_source) New function.
4535 (glob var matrix_data_source) New var.
4537 * misc.h: Include ieeefp.h if present.
4539 * split-file.h: (cmd_split_file) Changes corresponding to struct
4542 * str.h: Fix memmem prototype.
4544 * temporary.c: (save_dictionary, restore_dictionary,
4545 free_dictionary) Changes corresponding to struct dictionary
4548 * var.h: (MXD_* enums) New enum series.
4549 (struct matrix_data_proc) New struct.
4550 (struct split) Removed.
4551 (struct dictionary) Changed `splits' member from `split *' to
4553 (macro force_create_variable) New macro. Replaced lots of
4554 create_variable()/assert() calls with calls to this macro.
4556 * vars-atr.c: (discard_variables) Changed assertion.
4557 [GLOBAL_DEBUGGING] (force_create_variable) New function
4558 called by the macro of the same name.
4559 (clear_variable) Changes to delete splits from the dictionary
4560 corresponding to struct dictionary changes.
4562 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
4563 corrupted variable `index' values in the dictionary passed in
4564 every time this function is called.
4566 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
4567 to struct dictionary changes.
4569 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
4571 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
4573 * command.c: New includes.
4574 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
4575 (cmd_erase) New function.
4576 [unix] (shell) New function.
4577 (run_command) New function.
4578 (cmd_host) New function.
4579 (cmd_new_file) New function.
4581 * expr-prs.c: (parse_primary) Message fix.
4583 * inpt-pgm.c: Formatting fix.
4584 (cmd_reread) Implement the FILE subcommand.
4586 * matrix-data.c: New file.
4588 * q2c.c: (dump_header) Change output commenting style.
4590 * weight.c: Comment fix.
4592 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
4594 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
4596 (buf_10x) Renamed buf_1xx, all references changed.
4597 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
4598 cases now implemented).
4599 (create_sysfile) New function.
4600 (agr_11x_func) New function.
4602 * data-in.c: (parse_numeric) Work properly if there's an
4603 explicitly coded decimal point in the data and decimal places are
4604 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
4605 <el@linux.lisse.na>.
4607 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
4608 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
4609 Eberhard W Lisse <el@linux.lisse.na>.
4611 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
4612 strerror.c. Bug reported by Alexandre Oliva
4613 <oliva@dcc.unicamp.br>.
4615 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
4616 (static var separate_case_tab) New var.
4617 (cmd_sort_cases) Cancel temporary transformations here. Free
4618 v_sort before return.
4619 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
4620 we're reading from a sort stream. Don't cancel temporary
4621 transformations. Offload internal sorting to do_internal_sort().
4622 (do_internal_sort) New function. Handles internal sorting even
4623 when SEPARATE is nonzero. Doesn't free v_sort.
4624 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
4626 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
4627 sink if SEPARATE is zero.
4628 (read_output_cases) Renamed read_sort_output(), all references
4629 changed. Now uses separate_case_tab when it exists.
4630 (write_separate) New function.
4632 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
4633 memory_sink_cases. Don't redundantly call
4634 vfm_source->destroy_source().
4635 (memory_stream_mode) After switching over, set memory_sink_cases
4638 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
4640 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
4642 (static var prev_case) New, moved out of aggregate_single_case()
4644 (static var buf64_10x, buf_10x) New.
4645 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
4646 the 000, 001, 100, and 101 cases. Free prev_case.
4647 (parse_aggregate_functions) Disallow scratch variables.
4648 (free_aggregate_functions) Only free agr_dict if non-null. Use
4649 iter->function to determine numeric/string type, not
4651 (aggregate_single_case) Don't manage prev_case. Initialize
4652 aggregate info after dumping it.
4653 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
4654 mean, stddev, weighted stddev definitions.
4655 (dump_aggregate_info) Implemented.
4656 (initialize_aggregate_info) Renamed from
4657 initialize_aggregate_functions(). Initializes dbl[2].
4658 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
4659 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
4661 * cases.c: (alloc_val) Removed.
4663 * get.c: (cmd_save_internal) Initialize new `dict' member.
4665 * sfm-write.c: (sfm_write_dictionary, write_header,
4666 write_variable, write_value_labels, write_documents) Reorganize,
4667 simplify for new parameter structure.
4668 (write_variable) Only one variable * argument now.
4670 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
4671 replaced by new `dict' member.
4673 * temporary.c: (new_dictionary) Initialize n_documents.
4675 * vars-atr.c: (dup_variable) Allocate `value's from dict into
4677 (init_variable, replace_variable) Eliminate usage of alloc_val().
4679 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
4681 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
4682 signal that AGGREGATE is to be used for forming final cases.
4683 (close_active_file) Call end_func before stopping lagging. Cancel
4684 temporary after finishing compaction.
4685 (write_case) Comment fixes. Cleaned up.
4686 (compact_case) Let AGGREGATE handle compaction when `temporary' is
4689 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
4691 * Makefile.am: (BUILT_SOURCES) Add means.c.
4692 (pspp_SOURCES) Add means.c.
4693 (EXTRA_DIST) Add means.q.
4695 * command.c: (array cmd_table[]) Add MEANS.
4697 * common.h: Esthetic fixes. Comment fixes. Test for
4698 MAX_SHORT_STRING greater than 8.
4699 (macros LOWEST, HIGHEST) New.
4701 * data-in.c, data-list.c, recode.c: Comment fixes.
4703 * means.q: New file, base version.
4705 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
4706 with LOWEST, DBL_MAX with HIGHEST.
4708 * q2c.c: (dump_vars) Add an enum to array types giving the number
4709 of values for the enum.
4711 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
4712 Replace second_lowest_value with second_lowest_flt64.
4714 * sfm-write.c: (write_variable, write_rec_7_34) Replace
4715 second_lowest_value with second_lowest_flt64.
4717 * t-test.q: Comment fix.
4719 * temporary.c: (restore_dictionary) Esthetic fix.
4721 * tokens.h: (force_match_id, force_match, force_string, force_int,
4722 force_num, force_id) Replace msg() with syntax_error().
4724 * var.h: (struct means_proc) New.
4725 (struct variable) Add mns member to `p' union.
4727 * vars-prs.c: (parse_variable, parse_dict_variable,
4728 parse_variables, parse_DATA_LIST_vars) Replace msg() with
4731 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
4733 * Makefile.am: (pspp_SOURCES) Add tab.h.
4735 * Most source files: Added a cast to unsigned char in usages of
4736 the ctype is*() functions. Replaced `end of command expected'
4737 calls to msg() with calls to syntax_error().
4739 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
4741 * lexer.c: (hex_val) Removed (was dead code).
4742 (idmatch) Parenthesize function name to avoid macro expansion.
4744 * postscript.c: Comment fixes.
4745 (ps_preopen_driver) Change default font size to 10pt.
4747 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
4749 (parse_format_spec) Change system-file format spec argument type
4750 to int32. Parse the format spec with bitwise operators.
4752 * sfmP.h: (struct sysfile_format) Removed.
4753 (struct sysfile_variable) Changed print, write members from
4754 sysfile_format to int32.
4756 * tokens.h: Esthetic fixes.
4757 [__GNUC__] (macro id_match) New macro to hopefully speed up
4758 identifier matching.
4759 (macros match_id, match_tok, match_int) Implemented in
4760 compiler-independent manner; no longer GNU C only.
4762 * vfm.h: Include time.h.
4764 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
4766 * data-list.c: (dump_fixed_table) Change tab_dim().
4768 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
4770 * error.c: Include command.h.
4772 * frequencies.g: Formatting fixes.
4774 * frequencies.q: Add tab_dim() calls. Make the total cell a
4777 * glob.c: Include command.h.
4779 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
4781 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
4782 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
4783 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
4784 the other elements (is this right?).
4785 (read_variables) Use lowest, highest members.
4786 (parse_format_spec) New arg `vv' for more stringent checking.
4787 (dump_dictionary) Byteswaps nonexplicit data.
4788 (sfm_read_case) Byteswap numeric data.
4790 * som.c: Initialize table_num to 1.
4791 (render_segments) Remember to increment y_index after each table
4794 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
4795 avl_count() on a NULL tree. No title for the second table.
4796 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
4797 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
4798 fix call to display_variables().
4799 (display_variables) Default to 4 columns, not 3. Set up headers.
4800 Column title is Variable, not Name. Fix index column.
4801 Add joint text. Add tab_dim(). Handle value labels properly.
4802 Handle DISPLAY LABELS properly. Draw boxes correctly.
4803 (describe_variable) Value labels don't need titles. Don't clear
4804 nonexistent index column.
4805 (compare_vectors_by_name) New function.
4806 (display_vectors) New function.
4808 * tab.c: (tab_height) Add assertion.
4809 (tab_null) Add debug code.
4810 (evaluate_dimensions) Add debug code.
4812 * var.h: (struct variable) get_proc data is sometimes used
4813 simultaneously with other per-procedure info, therefore it was
4814 removed from the union. All references changed.
4816 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
4818 * ascii.c: (ascii_close_page) Put title on second line of headers
4819 if there is no subtitle.
4821 * command.c: (glob var cur_proc) Move definition here, from
4823 (cmd_remark) Emit blank line before remarks.
4825 * command.h: (glob var cur_proc) Move declaration here, from
4828 * data-list.c: (dump_fixed_table) Fix messages.
4829 (dump_free_table) Call tab_nat_dim().
4831 * descript.q: (dump_z_table) Modify tab_dim() call.
4833 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
4835 (dump_statistics) Don't output header.
4837 * groff-font.c: Minor format fix.
4839 * html.c: Comment fix.
4841 * list.q: (write_varname) Indent after advancing page.
4843 * output.h: Minor reordering.
4845 * postscript.c: Comment fixes. Many places, '\n' was replaced by
4846 a reference to eol[].
4847 (struct ps_driver_ext) New member eol[].
4848 (ps_preopen_driver) Initialize eol[].
4849 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
4850 defaults. Handle headers. Fix test for minimum page length.
4851 (static var option_tab[]) Add `line-ends'.
4852 (ps_option) Handle line-ends to change eol[].
4853 (postopen) Scale prop_em_width and fixed_width properly. Set the
4854 prologue title to outp_title if applicable. Replace the prologue
4855 line ends with eol[]. Call draw_headers() if headers are enabled.
4856 (text_width) New function.
4857 (out_text_plain) New function.
4858 (draw_headers) New function.
4860 * print.c: (dump_table) Call tab_nat_dim().
4862 * som.c: (som_blank_line) Only advance a line if not at the top of
4864 (som_submit) Move several informational table calls here.
4865 Increment subtable_num if SOMF_NO_TITLE not set.
4866 (output_table) Advance a line if SOMF_NO_SPACING not set.
4867 (render_columns, render_segments, render_simple) Handle spacing
4868 between tables. Handle table titles. Remove debug output.
4870 * som.h: (SOMF_*) New enum series.
4871 (struct som_table_class) New member `flags'.
4873 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
4875 (display_variables) Calls tab_nat_dim().
4876 (describe_variable) Remove restriction on number of value labels.
4877 Make value labels separated by thin lines.
4879 * tab.c: (tab_create) Default `flags' to none.
4880 (tab_float) New arg `w'. All references changed.
4881 (tab_nat_dim) New function.
4882 (tab_output_text) No title or spacing.
4883 (tab_flags) New function.
4884 (tabi_flags) New function.
4885 (tabi_title) New function.
4886 (strip_height) Removed.
4887 (tabi_render) Skip title when necessary.
4888 (static var tab_tab_class) Add tabi_flags, tabi_title.
4889 (evaluate_dimensions) Disable display of column, row size.
4890 (sum_columns) Add title height to top header.
4891 (render_strip) Moved within file.
4893 * tab.h: (struct tab_table) New member `flags'.
4895 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
4897 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
4899 * Most source files: Add `const' attribute in all appropriate
4902 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
4903 column to the variables table for use by describe_variable().
4904 (cmd_display) Disable for the present.
4905 (display_documents) Don't wrap documents.
4906 (display_variables) Table has four columns now.
4907 (describe_variable) Table has four columns now. Don't use a
4908 subtable, use joined cells instead.
4910 * tab.c: (tab_create) Don't set `join'.
4911 (tab_realloc) ct array is not made up of a_string's.
4912 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
4913 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
4914 (text_format) New function.
4915 (tab_title) Rewritten, uses text_format().
4916 (tab_text) Rewritten, uses text_format().
4917 (tab_joint_text) New function.
4919 (static var hit) New variable.
4920 (render_strip) New args r1, r2. Implement joined cells that fit
4922 (tabi_render) Increment hit. Pass new args to render_strip().
4923 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
4924 cells. For t_naw and t_nah, ignore joined cells and null cells in
4927 * tab.h: (struct tab_join_rect) Removed.
4928 (struct tab_table) Removed `join'.
4929 (TAB_JOIN_MAIN) Removed.
4930 (struct tab_joined_cell) New struct.
4931 (TAT_NOWRAP) New enum.
4933 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
4935 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
4937 (ascii_postopen_driver) Fix initialization of *_spacing so that
4938 the TAL_0 bit doesn't count.
4940 * data-list.c: (dump_fixed_table) Use natural width for Format
4943 * glob.c: (rerange) Removed.
4944 (get_date) Formatting fixes. Internationalization fix.
4946 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
4949 * postscript.c: (ps_postopen_driver) Replace
4950 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
4952 * som.c: (som_submit) Don't eject page before every table.
4953 (output_table) Fix order of arguments on call to area().
4954 (render_columns) Fix calculation of max_len.
4956 * tab.c: (tabi_cumulate) Minor change to increase elegance.
4957 (render_strip) New function.
4958 (strip_height) New function.
4959 (tabi_render) Rewrite as calls to render_strip().
4961 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
4962 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
4963 with the TAB_* and OUTP_T_* constants.
4965 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
4967 * Makefile.am: Formatting fixes.
4969 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
4972 * data-list.c: (dump_fixed_table) Add tab_dim() call.
4974 * descript.q: (dump_z_table, display) Add tab_dim() calls.
4976 * dump-sysfile.c: (glob var length) Make type off_t.
4977 (usage) Fix arguments.
4980 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
4981 Now right-justification is the default so many references had to
4983 (struct outp_class) Removed line_width, all references changed.
4984 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
4985 (struct outp_driver) Add elements horiz_line_width,
4986 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
4989 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
4991 (postopen) Initialize all the informational members of
4994 * som.c: (som_blank_line) New function, renamed from blank_line(),
4995 all references changed.
4996 (som_submit) Disables drivers whose pages can't be opened.
4997 (render_columns, render_simple, render_segments) Add debug output.
4998 (render_columns) Fix loop range.
4999 (render_simple) Don't try to render the headers, they're taken
5000 care of automatically. Advance cp_y past the table when done.
5001 (render_segments) Fix loop ranges.
5003 * tab.c: Initialize new members of tab_table.
5004 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
5005 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
5006 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
5009 (tab_dim) New function.
5010 (tab_col_width) Removed.
5011 (tab_row_height) Removed.
5012 (tab_output_text) Call tab_dim().
5013 (tabi_driver) Call evaluate_dimensions(), sum_columns().
5014 (tabi_area) Implemented.
5015 (tabi_cumulate) Implemented.
5016 (tabi_render) Partially implemented, but broken.
5017 (var tab_table_class) Made static.
5018 (evaluate_dimensions) New function.
5019 (sum_columns) New function.
5021 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
5022 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
5023 t_scr, t_srr, t_sentinel. Removed: t_nat.
5024 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
5025 max_stack_height, w, h. Removed: ce, re.
5026 (macro blank_line) Removed.
5027 (glob var zero_length) Removed.
5029 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
5031 * Most source files: include some of the new include files broken
5034 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
5037 * aggregate.c: (glob var outfile) Make static.
5039 * command.c: (glob var pgm_state) Move here.
5041 * common.c: (glob vars endian, second_lowest_value, pgmname,
5042 finished, curdate, cur_proc, start_interactive, history_file) Move
5045 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
5047 * file-handle.q: (glob vars files, inline_file) Move here.
5049 * glob.c: Lost lots of glob vars, detailed in individual file
5051 (init_glob) set_printer, set_screen were obsolete, deleted.
5052 set_cprompt has fewer spaces because pspp has fewer letters than
5055 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
5056 (inp_nval) Made static.
5058 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
5059 tokstr_len, toklongstr, tokint) Move here.
5061 * misc.c: Lost several vars and functions.
5063 * set.q: (all the set_* variables) Move here.
5065 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
5066 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
5069 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
5071 * tab.h: (enum series t_*) New enums.
5072 (struct tab_table) Use arena struct tag. New members ce, re.
5074 * tokens.h: Comment fixes.
5076 * var.h: Move lots of enums and variables and functions and
5077 structures to other files. Use and declare a lot more union and
5078 struct tags. Comment fixes.
5080 * vector.c: (glob vars vec, nvec) Move here.
5082 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
5083 init_blanks, last_vfm_invocation) Move here.
5085 * cases.h: New file.
5086 (struct long_vec) Move here.
5087 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
5090 * command.h: New file.
5091 (STATE_* enums) Move here.
5092 (glob var pgm_state) Move here.
5094 * format.c: New file.
5095 (glob var formats) Move here.
5096 (parse_format_specifier_name, fmt_to_string,
5097 check_input_specifier, check_output_specifier,
5098 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
5101 * format.h: New file. Move functions now in format.c here.
5102 (FMT_* enums) Move here.
5103 (struct fmt_desc) Move here.
5104 (FCAT_* enums) Move here.
5105 (struct fmt_spec) Move here.
5106 (glob vars formats, fmt_parse_ignore_error) Move here.
5108 * inpt-pgm.h: New file.
5109 (INP_* enums) Move here, make #defines into enums.
5110 (glob vars inp_init, inp_init_size) Move here.
5113 (glob vars v_sort, nv_sort) Move here.
5114 (sort_cases, read_sort_output) Move here.
5116 * vector.h: New file.
5117 (struct vector) Move here, add struct tag.
5118 (glob vars vec, nvec) Move here.
5119 (find_vector) Move here.
5122 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
5123 reinit_blanks, init_zero, init_blanks) Move here.
5124 (struct case_stream) Move here.
5125 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
5126 vfm_disk_stream, sort_stream, data_list_source,
5127 input_program_source, file_type_source, get_source, n_lag) Move
5129 (procedure, write_case, lagged_case, compact_case, page_to_disk)
5132 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
5134 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
5135 (LDADD) Add libdcdflib.
5137 * ascii.c: Comment and formatting fixes. Almost every external
5138 function had an assert added, checking driver_open and page_open.
5139 (ascii_init_driver) Broken into ascii_preopen_driver,
5140 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
5141 (ascii_open_page) Sets page_open.
5142 (ascii_close_page) Clears page_open.
5144 * html.c: Comment and formatting fixes. Almost every external
5145 function had an assert added, checking driver_open and page_open.
5146 (html_init_driver) Broken into html_preopen_driver,
5147 html_postopen_driver, html_close_driver. Manages driver_open.
5148 (html_open_page) Sets page_open.
5149 (html_close_page) Clears page_open.
5150 (html_submit) Disabled.
5152 * lexer.c: (parse_string) Remove debugging printf.
5154 * list.q: (determine_layout) Open a page if one is not yet open.
5156 * output.c: Comment fixes.
5157 (add_class) Set the class member of the new list element.
5158 (parse_options) Don't handle device type.
5159 (colon_tokenize) New function.
5160 (configure_driver) New four-field format with a field for device
5161 type. Now initialize driver_open, page_open, next, and prev
5162 fields. Use new colon_tokenize() function. Don't do a memory
5163 copy to replace a driver, it doesn't work; instead delete the old
5164 driver and insert a new one.
5165 (destroy_driver) Don't call som_destroy_driver(). Close the page
5166 if it's open. Find the class in the list of classes and decrement
5167 that reference count. Remove the driver from the global driver
5169 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
5170 references changed. Rewritten. Don't return a driver that's not
5172 (outp_eject_page) All references to som_internal_eject_page()
5173 changed to use this. Sets cp_x to 0 as well as cp_y.
5175 * output.h: (OUTP_I_* enums) Removed.
5176 (struct som_submission_form) Removed.
5177 (struct outp_class) init_driver broken into preopen_driver,
5178 postopen_driver, and close_driver. submit changed to take a
5181 * postscript.c: Comment and formatting fixes. Almost every
5182 external function had an assert added, checking driver_open and
5184 (ps_init_driver) Broken into ps_preopen_driver,
5185 ps_postopen_driver, ps_close_driver. Manages driver_open.
5186 (ps_open_page) Sets page_open.
5187 (ps_close_page) Clears page_open.
5189 * som.c: New file, base implementation.
5191 * som.h: (struct som_table) Add struct tag.
5192 (enum SOM_COL_ACROSS) Removed.
5193 (SOM_ROWS, SOM_COLUMNS) New enums.
5194 (struct som_table_class) Add member `cumulate'. Remove `segment';
5195 change `render' arguments.
5196 (struct som_point, struct som_rect) Removed.
5197 (som_submit_table) Fixed typo, should have been som_submit.
5199 * sysfile-info: (describe_variable) Don't try to insert a
5200 subtable; just destroy it for now.
5202 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
5203 references to value labels.
5205 * tab.c: (tab_destroy) New function.
5206 (tab_columns) Change argument.
5207 [0] (tab_submit) Remove dead code.
5208 (tab_title) Allocate string from the table's arena.
5209 (tab_output_text) Only free the buffer if we allocated it.
5210 (tab_submit) New function.
5211 (static vars t, d) New static vars.
5212 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
5213 tabi_headers, tabi_cumulate, tabi_render) New functions.
5214 (glob var tab_table_class) New global var.
5216 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
5217 encapsulate the rectangle. All references changed.
5219 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
5221 * All header files updated to use struct tags in addition to
5222 typedefs for all structures. Don't use word `struct' in struct
5225 * Makefile.am: (pspp_SOURCES) Remove html.c.
5226 (INCLUDES) Replace the lib/* includes with a single lib/ include;
5227 all references updated.
5229 * command.c: (parse_cmd) Remove call to som_check_workspace.
5230 (output_line) Update to new som.
5232 * data-in.c: (parse_numeric) A single dot is not an error; it is
5233 the system-missing value.
5235 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
5238 * data-out.c: Added `const' as appropriate to many prototypes.
5239 (convert_E, convert_F, convert_CCx) Take double argument instead
5240 of value * argument.
5241 (convert_format_to_string) Call changed functions appropriately.
5242 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
5243 make a local copy of the value.
5245 * descript.q: Remove custom_variables() prototype now provided by
5247 (custom_variables) Don't increment sbc_variables, the caller does
5249 (dump_z_table, display) Update to new som.
5251 * error.c: (vmsg) Add const to prototype. Remove code to handle
5252 `too many errors' condition.
5253 (check_error_count) New function.
5254 (msg) Add const to prototype.
5256 * filename.c: (open_file) Rewrite for elegance.
5258 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
5259 (dump_full, dump_condensed, dump_statistics) Update for new som.
5261 * list.q: Don't include somP.h. Change all references to
5262 som_driver_ext to refer to the new members of som_driver. Change
5263 som_internal_eject_page() references to outp_eject_page().
5265 * main.c: (parse) Rewrite for elegance. Add call to
5266 check_error_count().
5268 * output.c: (add_class, outp_list_classes, outp_configure_driver)
5269 Rewrite or revise for new outp_driver_class_list structure.
5270 (outp_iterate_enabled_drivers) Fix comparison between disabled
5271 devices and current device type.
5272 (outp_eject_page) New function.
5274 * output.h: Comment fixes.
5275 (struct outp_driver) New members driver_open, page_open, cp_x,
5276 cp_y, font_height, prop_em_width, fixed_width. Deleted members
5278 (struct outp_driver_class_list) New struct.
5279 (outp_class_list) Changed to type outp_driver_class_list; all
5282 * print.c: (dump_table, print_trns_proc) Updated for new som.
5284 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
5285 prototypes for custom subcommands.
5286 (dump_subcommand) Always include the `else'.
5287 (dump_parser) Fix comments in output code.
5289 * set.q: Reordered functions.
5291 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
5293 * som.h: Rewritten from scratch.
5295 * str.h: Remove dead code.
5297 * tab.c, tab.h: New files, base implementation.
5299 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
5302 * t-test.q: New code from John Williams
5303 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
5304 Many many new static vars and defines.
5305 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
5306 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
5307 (struct value_list) New struct.
5308 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
5309 t_crt, t_sig, print_t_groups) New functions.
5310 (cmd_t_test) Implemented.
5312 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
5315 * vfm.c: (dump_splits) Update to new som.
5317 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
5319 * Makefile.am: (fiasco_SOURCES) Add html.c.
5321 * aggregate.c: Base source.
5323 * ascii.c: (postopen, preclose) Reformat.
5325 * data-out.c, expr-evl.c: Comment fixes.
5327 * filename.c: (open_file) When opening a file for writing, use
5328 line buffering instead of full buffering for better interactive
5329 performance. Suggested by Valerio Aimale
5330 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
5331 names `stdin', `stdout', `stderr'.
5333 * groff-font.c: Comment fixes.
5335 * html.c: New file; base version.
5337 * list.q: (write_all_headers, clean_up, determine_layout,
5338 list_cases) Ignore `special' devices for now. Needs to be fixed
5341 * output.c: (outp_init) Add html driver to list; reverse list
5344 * output.h: (struct outp_class_struct) New members `special',
5345 `submit'; comment fixes. All references changed.
5347 * postscript.c: (ps_init_driver) Make defaults for text_opt,
5348 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
5350 (postopen) Comment fix.
5351 (preclose) Comment fixes, formatting fixes. Change x->file.file
5352 references to more proper f->file.
5354 * som-high.c: (som_submit_table) Special classes use their own
5357 * som.h: Comment fixes.
5359 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
5362 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
5364 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
5366 * aggregate.c: Still working on this.
5368 * command.c: (cmd_table[]) Add AGGREGATE back in.
5369 (split_words) Make '-' a legal word separator as well as ' '.
5371 * main.c: Comment fixes.
5373 * q2c.c: (dump_parser) Don't require the procedure's full name to
5374 be present, in the generated source.
5376 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
5377 multiply specified and let it be default; let MISSING, CRITERIA,
5378 FORMAT be multiply specified.
5379 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
5380 (custom_groups) Fix defaults.
5381 (custom_pairs) Check whether this is a PAIRS subcommand before
5382 attempting to parse. Better garbage collection. Proper storage
5384 [DEBUGGING] (debug_print) New function.
5386 * temporary.c: Comment fixes.
5387 (copy_variable) Don't copy variable name and index.
5388 (save_dictionary) Copy variable name and index by hand.
5390 * vars-atr.c: Comment fixes.
5391 (create_variable) New dictionary argument. All references
5393 (common_init_stuff) New dictionary argument. All references
5395 (init_variable) New dictionary argument. All references changed.
5396 (dup_variable) New function.
5398 * vars-prs.c: (parse_variables) If there are any errors, we always
5399 return 0. Previously, it was possible for some types of errors to
5402 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
5404 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
5407 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
5409 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
5412 * q2c.c: Comment fixes.
5413 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
5415 * t-test.q: (cmd_list) Rename cmd_t_test.
5417 * temporary.c: (new_dictionary) Don't declare as static.
5419 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
5421 * aggregate.c: Changes, still not finished.
5423 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
5425 * q2c.c: Comment fixes. Now its output is internationalized.
5426 (get_token) Fix parsing of escapes within literal strings.
5427 (main) Fix bad #line directives in output.
5429 * t-test.q: Base implementation.
5431 * temporary.c: (new_dictionary) New function.
5432 (restore_dictionary) [__CHECKER__] Change fill character to *
5435 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
5437 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
5439 * aggregate.c: Changes, still not finished.
5441 * descript.q, list.q: Comment fixes.
5443 * q2c.c: Almost completely rewritten.
5445 * t-test.q: New file, not complete.
5447 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
5449 * aggregate.c: Changes, still not finished.
5451 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
5454 * temporary.c: (cancel_temporary) New function.
5456 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
5457 of doing it by hand.
5459 * vfm.c: (close_active_file) After restoring a TEMPORARY
5460 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
5462 (SPLIT_FILE_procfunc) Comment fix.
5464 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
5466 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
5468 * aggregate.c: New file, not finished yet.
5470 * command.c: (cmd_table) Add AGGREGATE.
5472 * common.h: (pgm_state) Move declaration to var.h.
5474 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
5476 (parse_string) Message fix.
5478 * recode.c: Comment fix.
5480 * sfm-read.c: (read_variables) Code esthetic fixes.
5481 (write_header) Default date is `Jan', not `JAN'.
5483 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
5485 * sort.c: (cmd_sort_cases) Farm the work out to new function
5486 parse_sort_variables().
5487 (parse_sort_variables) New function.
5488 (sort_cases) New function. Cancels temporary transformations,
5489 which sorting didn't do previously.
5490 (cmd_sort_cases) Better garbage collection on error. Uses
5492 (write_initial_runs, merge_once) Improved code esthetics.
5493 (sort_stream_read) Reduced to one call to read_output_cases().
5494 (read_output_cases) New function.
5496 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
5497 variable labels to 120 characters.
5499 * var.h: Comment fixes.
5500 (glob var pgm_state) From common.h.
5502 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
5504 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
5505 options. Set *names to NULL on error.
5507 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
5509 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
5511 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
5512 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
5514 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
5516 * vfm.c: (page_to_disk) Added missing local variables.
5518 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
5520 * get.c: Comment fix.
5522 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
5523 source is anything other than a disk stream, not just if it's in a
5524 memory stream. Call page_to_disk() before external sort.
5525 (allocate_cases) Message fix.
5527 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
5529 (page_to_disk) New function.
5531 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
5533 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
5535 * common.h: (macro strerror) Remove. From Alexandre Oliva
5536 <oliva@dcc.unicamp.br>.
5538 * get.c: (dict_delete_run) The number of variables to delete is
5539 not necessarily the number of variables that need to be shifted
5541 (trim_dictionary) Don't set *options to 0. Fix bug that caused
5542 too many variables to be deleted.
5544 * postscript.c: Comment fix.
5546 * q2c.c: Include strerror.c. From Alexandre Oliva
5547 <oliva@dcc.unicamp.br>.
5549 * set.q: #undef ON and OFF. From Alexandre Oliva
5550 <oliva@dcc.unicamp.br>.
5552 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
5553 early, otherwise errors cause a bad free().
5555 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
5556 Oliva <oliva@dcc.unicamp.br>.
5558 * temporary.c: (save_dictionary) Don't allocate memory if
5561 * vfm.c: (memory_stream_write) Message fix.
5563 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
5565 * command.c: (static var cmd_table[]) Define REPEATING DATA
5568 * common.h: Added support for broken systems that are missing
5569 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
5571 * Many source files: Replace syntax error messages via msg() with
5572 call to syntax_error().
5574 * data-list.c: (dump_fixed_table) Add support for dumping table
5575 for REPEATING DATA as well as DATA LIST FIXED.
5576 (cmd_repeating_data) Allows and requires `/' between subcommands.
5577 Does proper thing with allowing rpd.starts_end to stay 0. Allows
5578 CONTINUED specifications to be omitted. Forces CONTINUED to be
5579 specified if ID is. Calculates starts_end, cont_end from logical
5580 record length as reported by fhp. Calls dump_fixed_table() if
5581 requested. Fixed length of record copied by memcpy.
5582 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
5584 (realize_value) Returns sensible value for out-of-range variable
5586 (rpd_parse_record) New argument `ofs'. Fixed confusion between
5587 length of occurrences and length of line. Added warning for
5588 fields that exceed the line length. Fixed infinite loop.
5589 (read_one_set_of_repetitions) Numerous minor changes for more
5590 complete SPSS compliance. Message fixes.
5592 * dfm.c: (dfm_close) If the file being closed is the inline file,
5593 read all the remaining data before closing it.
5594 (dfm_get_record) Don't close the file on lossage, as either it
5595 has been closed already or it doesn't belong to us.
5597 * error.c: (puts_stdout) New function.
5598 (vmsg) Use puts_stdout instead of puts.
5600 * file-handle.q: (fh_record_width) New function.
5602 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
5605 (input_program_source_read) Made an old kluge an approved method.
5607 * lexer.c: (syntax_error) New function.
5609 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
5612 * output.c: (oupt_get_paper_size) Message fix.
5614 * q2c.c: Numerous fixes to formatting of generated code made to
5615 conform to GNU coding standards. Uses syntax_error() in generated
5616 code. Other miscellaneous generated message fixes. Added support
5617 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
5618 RAND_MAX, and/or strerror().
5620 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
5622 * data-in.c: Comment fixes.
5624 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
5625 (find_variable_input_spec) New function.
5626 (cmd_repeating_data) Initializes id_spec.
5627 (rpd_parse_record) Implemented.
5628 (read_one_set_of_repetitions) Returns -3 by default in order to
5629 kluge out some potential bugs.
5631 * data-out.c: Comment fixes.
5633 * file-type.c: (internal_cmd_record_type) Message fix.
5635 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
5636 for handling -3 return value.
5638 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
5640 * data-list.c: Comment fixes.
5641 (struct dls_var_spec) Reordered members.
5642 (read_from_data_list_fixed) Restructured.
5643 (struct repeating_data_trns) Reordered members. Renamed `starts'
5644 as `starts_beg', `ends' as `starts_end'.
5645 (cmd_repeating_data) Calculates length of repeated data if
5646 necessary and possible.
5647 (parse_num_or_var) Don't allow string variables.
5648 (realize_value) New function.
5649 (rpd_msg) New function.
5650 (rpd_parse_record) New function. Currently stubbed out.
5651 (read_one_set_of_repetitions) Implemented.
5653 * inpt-pgm.c: (input_program_source_read) Comment fix.
5655 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
5657 * command.c: (cmd_end_repeat_p) Removed.
5658 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
5659 (parse_cmd_name) Removed.
5661 * data-list.c: Comment fixes.
5662 (data_list_pgm) Removed `eof' member.
5663 (static var first) New var.
5664 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
5665 FILE TYPE file inside FILE TYPE structures.
5666 (append_var_spec) Appends to *first, not dls.spec.
5667 (parse_fixed) Message fixes.
5668 (struct rpd_num_or_var) New.
5669 (struct repeating_data_trns) New.
5670 (static var rpd) New.
5671 (cmd_repeating_data) New function.
5672 (parse_num_or_var) New function.
5673 (parse_repeating_data) New function.
5674 (read_one_set_of_repetitions) New function.
5676 * file-type.c: (cmd_file_type) Message fixes. Always
5677 default_handle to FILE TYPE file handle.
5678 (internal_cmd_record_type) Message fixes.
5680 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
5682 * repeat.c: Comment fix. Disable debugging.
5684 * temporary.c: (restore_dictionary) Sets splits to NULL and
5685 n_splits to 0 before destroying the variables because now doing
5686 this tries to remove split variables.
5688 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
5689 destroying the dictionary.
5690 (clear_variable) Removes a variable from splits after destroying
5693 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
5695 * cmdline.c: (set_compat) Removed.
5696 (pick_compat) Removed.
5697 (parse_command_line) Removed -c option.
5698 (pre_syntax_message) Removed -c option.
5699 (usage) Remove compatibility code.
5701 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
5702 (glob var compat) Removed.
5704 * compute.c: (type_check) Fixed messages about type mismatches.
5706 * data-list.c: (cmd_data_list) Removed compatibility code.
5707 (fixed_parse_compatible) Calls convert_negative_to_dash().
5708 Fixed bug where it only set the variable in fx.spec if it created
5709 the variable itself.
5710 (dump_fmt_list) Spelling fix.
5711 (cut_field) Removed compatibility code.
5713 * dfm.c: (cmd_begin_data) Don't require a command terminator on
5716 * expr-evl.c: (evaluate_expression) Implement LAG.
5718 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
5719 (parse_neg) Calls convert_negative_to_dash().
5720 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
5723 * expr.h: (struct expression_struct) Removed member max_lag.
5725 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
5726 (internal_cmd_record_type) Removed special handling to produce
5727 negative numbers from dash tokens.
5729 * getline.c: (static var DO_REPEAT_level) New var.
5730 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
5731 (handle_line_buffer) Copies the line into getl_buf; doesn't call
5732 copy_with_DO_REPEAT_substitutions().
5733 (getl_read_line) Maintains value of getl_mode. Calls
5734 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
5736 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
5738 * getline.h: (getl_mode) New glob var.
5740 * glob.c: Comment fixes.
5741 (init_glob) Restructured. Sets set_seed.
5742 (init_compat_dependent) Removed. All references removed.
5743 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
5744 (__htonl, __htons) Removed. (What were these for?)
5746 * lexer.c: (static var tbl) Dash set to class CNUM.
5747 (make_hexit) New function from data-out.c.
5748 (get_token_representation) Rewritten.
5749 (convert_negative_to_dash) New function.
5750 (lex_init_compat_dependent) Removed.
5751 (yylex) A dash is parsed as part of a number if it is followed by
5752 a digit. The ASCII representation of a number is copied to
5753 tokstr. String parsing farmed out to parse_string(). Comment
5755 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
5757 (preprocess_line) Line processing depends on interactive/batch
5758 mode, not on compatibility mode. Removed PC+ compatibility code.
5760 * loop.c: (loop_3_trns_proc) Comment fix.
5762 * main.c: Remove dead code.
5763 (main) Remove call to init_compat_dependent().
5765 * misc.c: (convert_fmt_ItoO) Make E format conversion more
5768 * print.c: (parse_string_argument) Calls
5769 convert_negative_to_dash().
5770 (fixed_parse_compatible) Calls convert_negative_to_dash().
5772 * repeat.c: (RPT_* defines) Removed.
5773 (struct rpt_numeric) Removed.
5774 (struct repeat_entry) New member type, changed `replacement' from
5776 (clean_up) Deallocation adapted to new repeat_entry.
5777 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
5778 usage. Creates vars for `type' of 1.
5779 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
5780 (store_numeric) Rewritten, new interface.
5781 (parse_numbers) Rewritten.
5782 (parse_strings) Rewritten.
5783 (find_DO_REPEAT_substitution) New function.
5784 (perform_DO_REPEAT_substitutions) New function.
5785 (copy_with_DO_REPEAT_substitutions) Removed.
5786 (debug_print) Rewritten.
5788 * set.q: Comment fix.
5789 (custom_results) Removed compatibility code.
5790 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
5793 * sysfile-info.c: (cmd_display) Removed compatibility code.
5795 * tokens.h: Comment fixes.
5796 (token types enum) Removed `toktype' typedef name for this int
5797 type. Removed SUBST. Restructured.
5799 * vars-atr.c: (discard_variables) Sets n_lag to 0.
5801 * vars-prs.c: Comment fix.
5803 * vfm.c: Comment fixes.
5804 (glob var n_lag) New var.
5805 (static vars lag_count, lag_head, lag_queue) New vars.
5806 (procedure) Removed argument nlag.
5807 (setup_lag) New function.
5808 (close_active_file) Discards lagging state.
5809 (lag_case) New function.
5810 (lagged_case) New function.
5811 (write_case) Lags a case if lagging.
5813 * weight.c: (cmd_weight) Removed compatibility code.
5815 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
5817 * getline.h: (struct getl_script) New members loop_index, macros.
5819 * getline.c: (getl_add_file) Sets first_line field to NULL.
5820 (getl_add_DO_REPEAT_file) New function.
5821 (handle_line_buffer) When the current line's length is negative,
5822 set the filename and line number. Increment line number after
5823 reading line. Pass the line to
5824 copy_with_DO_REPEAT_substitutions() for processing.
5825 (getl_close_file) Free DO REPEAT lines before freeing the
5826 filename, and just set the filename to NULL when doing this,
5827 because otherwise the filename gets freed twice.
5829 * glob.c: (glob var queuing) Removed. All references removed.
5831 * lexer.c: Comment fixes.
5832 (get_token_representation) New function.
5834 * repeat.c: Comment fixes.
5835 (struct repeat_entry) Replaced type and v union members with a
5837 (append_record) New function.
5838 (internal_cmd_do_repeat) Started reforming it for the new
5839 repeat_entry struct. Properly records filename changes in the
5840 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
5841 strncasecmp() result usage. Uses append_record() to simplify.
5842 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
5845 (copy_with_DO_REPEAT_substitutions) Started coding.
5847 [DEBUGGING] (debug_print_lines) New function.
5849 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
5851 * tokens.h: (macro is_id1, is_idn) New macros.
5853 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
5855 * cmdline.c: (static var pre_syntax_message) Changed `win'
5856 compatibility mode to `wnd'.
5858 * data-list.c: (fixed_parse_spss) Renamed
5859 fixed_parse_compatible().
5861 * glob.c: (init_glob) Excise unused code for
5862 program_invocation_short_name.
5864 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
5867 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
5869 * set.q: `win' compatibility renamed `wnd'.
5871 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
5873 * filename.c: [__WIN32__] Change the included Windows header files
5875 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
5876 second character is absolute.
5877 (dirname) Fix logic error. Don't printf() the results.
5878 (prepend_dir) Don't printf() the results.
5880 * getline.c: (handle_line_buffer) New function.
5881 (getl_read_line) Reads line with handle_line_buffer() when
5883 (getl_close_file) Discard line buffer data.
5885 * getline.h: Comment fixes.
5886 (struct getl_line_list) New struct.
5887 (getl_script_struct) Added line buffer members. These are hooks
5888 for use by DO REPEAT to allow it to insert virtual source code
5891 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
5892 Override Borland C++ stupidity that claims Windows has a console
5895 * repeat.c: This is in the process of being restructured from
5896 using a token-buffering approach to the DO REPEAT facility to
5897 using the more flexible approach of a line-buffering approach in
5898 conjunction with the getline module. Comment fixes.
5899 (struct tok_struct) Removed.
5900 (static vars queue_index, queue_head, queue) Removed.
5901 (static vars line_buf_head, line_buf_tail) New vars.
5902 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
5904 (pull_queue, destroy_queue) Removed.
5905 [DEBUGGING] (debug_print_tokens) Removed.
5907 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
5909 * file-handle.q: (prepend_current_directory) New function.
5910 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
5911 current directory before normalizing filename.
5913 * filename.c: (gnu_getcwd) New function.
5914 (absolute_filename_p) New function.
5915 (search_path) New argument, PREPEND. All references changed to
5916 pass NULL except those explicitly mentioned. Uses
5917 absolute_filename_p(). Prepends PREPEND before trying the
5919 (dirname, prepend_dir) New functions.
5921 * getline.c: (getl_get_current_directory) New function.
5922 (getl_include) Passes getl_get_current_directory() as PREPEND arg
5925 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
5927 * In several source files, the term `script' was replaced with
5928 `syntax file' inside error messages. Usage of the term `script'
5929 in the sense of a syntax file is now deprecated.
5931 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
5934 * dump-sysfile.c: (usage) Update message.
5936 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
5938 * getline.h: (glob var getl_include_path) Declare extern.
5940 * list.q: Define EXTERN as extern before #including somP.h.
5942 * var.h: Remove declaration of `disptype' variable.
5944 * vfm.c: (close_active_file) After switching the data sink to a
5945 data source, set vfm_sink to NULL, because it doesn't exist any
5948 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
5950 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
5951 _matherrl() to ignore all math errors.
5953 * sfm-read.c: (read_value_labels) When reading the labels from
5954 disk, read the little parts separately instead of as a struct;
5955 this avoids alignment problems.
5957 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
5958 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
5959 (write_header) Allocates and initializes elem_type.
5960 (sfm_write_case) Uses elem_type to determine how to handle each
5962 (sfm_close) Frees elem_type.
5964 * sfmP.h: Comment fix.
5965 [__BORLANDC__] Uses #pragma -a to adjust structure member
5968 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
5970 * Makefile.am: (fiasco_SOURCES) Remove display.c.
5972 * common.c: Fix typo.
5974 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
5975 sense of the condition.
5977 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
5978 line-continuation backslash.
5980 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
5982 * frequencies.q: (custom_grouped, add_percentile) Don't use a
5983 non-constant expression as an argument to sizeof.
5985 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
5986 undefine gettext macro because that's a conio function.
5988 * hash.h: (hsh_prime_tab declaration) Remove.
5990 * list.q: (write_fallback_headers) Move `leader' allocation out of
5991 main loop. Change to local_alloc() allocation.
5993 * output.h: Formatting fixes. Put __attribute__ in right place on
5994 function prototypes.
5996 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
5997 incorrect `SECOND_LOWEST_VALUE' references to proper
5998 `second_lowest_value'.
6000 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
6001 value. This way 2 out of 3 of the som files define the vars
6002 extern, the correct way, that actually works under BC++.
6003 (som_set_float) Don't use nonconstant initializers for a struct.
6005 * som-high.c: Add the standard alloca() header.
6006 (replicate_table) Add prototype.
6008 Merged DISPLAY routine.
6009 * sysfile-info.c: (AS_*) New enum series.
6010 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
6012 (cmd_display, display_macros, display_documents,
6013 display_variables) Stolen from defunct display.c.
6014 (describe_variable) New function.
6016 * temporary.c: [0] (display_tree) New debug function.
6017 (copy_variable) Performs shallow copy of value labels instead of
6018 deep copy; i.e., just copys the AVL tree and increments the
6021 * val-labs.c: Comment fixes.
6022 (do_value_labels) Optionally skip leading forward slash.
6023 (get_label) Creates only a single value label instead of many
6024 copies of one, and sets the reference count.
6026 * display.c: Removed.
6028 * dump-sysfile.c: New file, not yet complete.
6030 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
6032 For lots of source files I added more verbose_msg's. These aren't
6033 listed below as they have tested as being benign. In some cases
6034 these replaced debug_printf() calls.
6036 * output.c: (outp_read_devices) Message fix.
6038 * postscript.c: (output_encodings) Message fix. Reports errors on
6040 (postopen) Message fix.
6042 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
6044 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
6046 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
6049 * main.c: Remove <malloc.h> #include.
6051 * mis-val.c: (parse_numeric) Set .f member for each missing[]
6052 instead of trying to just set the missing[] itself, which is a
6055 * sfm-read.c: (read_variables) Same.
6057 * str.h: Add memmem() prototype.
6059 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
6061 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
6063 * Makefile.am: (q2c) Don't include any libraries in the link.
6065 * dfm.c: (force_line_buffer_extension) New macro.
6066 (count_tabs) New function.
6067 (tabs_To_spaces) New function.
6068 (read_record) Calls tabs_to_spaces() on the line being processed.
6070 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
6071 have to be compiled twice (once for CC, once for LOCAL_CC).
6073 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
6075 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
6076 (LDADD) Add @INTLLIBS@.
6077 (q2c) Add LIBS, @INTLLIBS@ to link step.
6079 * inpt-pgm.c: Turn off debugging.
6081 * postscript.c: (postopen) Format fix. local_free() blocks
6082 returned by local_alloc(); don't free() them.
6084 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
6086 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
6089 * data-list.c: (read_from_data_list_fixed) Pass proper value for
6090 LEN arg, not simply the full string length.
6092 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
6093 directories before generic temp file directories.
6095 * vfm.c: Disable debugging.
6097 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
6099 * get.c: Comment fix.
6100 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
6102 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
6104 * expr-prs.c: (debug_print_postfix) Conditionally included on
6105 GLOBAL_DEBUGGING. Removed out_header() reference.
6107 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
6109 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
6111 * ascii.c: Removed obsolete ascii_close_page() prototype.
6113 * command.c: (output_line) Comment fix.
6115 * data-in.c: Formatting fix.
6116 (parse_string_as_format) Now the `fc' argument is used only for
6117 the purpose of error messages; it is not an index into the string
6118 passed. All references changed.
6120 * data-list.c: Comment fix.
6121 (cut_field) Comment fix. Now returns the column number of the
6122 position of the field cut out on success.
6123 (parse_field) Added `column' argument. Puts the column numbers in
6125 (read_from_data_list_free, read_from_data_list_list) Record the
6126 column number returned by cut_field(), pass it to parse_field().
6128 * dfm.c: Comment fix.
6130 * do-ifP.h: Comment fix.
6132 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
6133 the SYSMIS function.
6135 * expr.h, exprP.h: Comment fix.
6137 * glob.c: (init_glob) Only calls setlocale() and family if
6140 * hash.h: Comment fix.
6142 * include.c: Comment fix.
6144 * output.c: Comment fix.
6146 * postscript.c: (ps_line_intersection) Simplified assertion.
6148 * repeat.c: Comment fix.
6150 * vars-atr.c: Comment fix.
6152 * vars-prs.c: Comment fix.
6154 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
6155 behavior with usage of postincrement.
6156 (memory_stream_read) Discards cases as it goes.
6158 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
6160 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
6163 * Most source files: Includes debug-print.h, related comment
6166 * cases.c: (alloc_val) Removed complex allocation code. Merely
6167 increments default_dict.nval and returns the former value.
6168 (envector, devector) Removed references to lv member of struct
6171 * common.h: (macro VME) Replaced complex definition with simple
6174 * data-list.c: (cmd_data_list) Sets vfm_source instead of
6175 read_active_file and cancel_input_pgm.
6176 (read_from_data_list, cancel_data_list) Removed.
6177 (data_list_source_read, data_list_source_destroy_source) New
6179 (glob var data_list_source) New var.
6181 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
6182 (cmd_begin_data) Improved criteria for an input program accessing
6183 the inline file. Still not perfect.
6185 * do-if.c: (do_if_trns_proc) Simplified debug output.
6187 * expr-prs.c: Comment fixes.
6188 [DEBUGGING] (debug_print_postfix) Simplified debug output.
6190 * file-handle.q: (fh_close_handle) Simplified debug output.
6192 * file-type.c: Comment fixes.
6193 (cmd_file_type) Sets vfm_source instead of read_active_file and
6195 (cmd_end_file_type) On failure, discards variables in place of
6196 just canceling the input program.
6197 (read_from_file_type) Renamed file_type_source_read.
6198 (cancel_file_type) Renamed file_type_source_destroy_source.
6199 (glob var file_type_source) New var.
6201 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
6202 (cmd_get) Initializes options to GTSV_NONE before passing to
6203 trim_dictionary(). Removed `lv' reference. Sets vfm_source
6204 instead of read_active_file and cancel_input_pgm.
6205 (cmd_save_internal) Initializes options before passing to
6206 trim_dictionary(). Local var `nval' removed.
6207 (dict_delete_run) Comment fixes.
6208 (trim_dictionary) Comment fixes. Disallows scratch variables if
6209 GTSV_OPT_SAVE set in options.
6210 (read_from_get) Renamed get_source_read.
6211 (cancel_get) Renamed get_source_destroy_source.
6212 (glob var get_source) New var.
6214 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
6215 read_active_file and cancel_input_pgm.
6216 (read_from_input_program) Renamed input_program_source_read.
6217 Simplified debug output.
6218 (cancel_input_program) Renamed
6219 input_program_source_destroy_source.
6220 (glob var input_program_source) New var.
6222 * loop.c: (loop_1_trns_proc) Simplified debug output.
6224 * main.c: (dump_token) Made eof output more explicit.
6226 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
6229 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
6230 code for always-memory or always-disk cases. malloc's case-list
6231 based on vfm_source_info.ncases. Explicit support for
6232 memory_stream via memory_source_cases.
6233 (do_external_sort) Sets vfm_source instead of read_active_file and
6235 (allocate_file_handles) The temporary directory permissions are
6236 set to 0700 instead of 0777.
6237 (allocate_cases) Formatting fixes. Simplified debug output.
6238 (output_record) Compacts the case if necessary before writing it
6240 (close_handle, open_handle_w) Simplified debug output.
6241 (write_initial_runs) Destroys vfm_sink, then sets it to
6242 sort_stream. Writes records to memory based on
6243 vfm_sink_info.case_size.
6244 (write_to_sort_cases) Renamed sort_stream_write().
6245 (merge) Simplified error handling. Simplified debug output.
6247 (read_from_external_sort) Renamed sort_stream_read().
6248 Reads records based on vfm_source_info.case_size.
6249 (sort_stream_write) Writes records to memory based on
6250 vfm_sink_info.case_size.
6251 (sort_stream_mode) New function.
6252 (glob var sort_stream) New variable.
6254 * temporary.c: (cmd_temporary) Simplified debug output.
6255 (copy_variable) Removed references to `lv'.
6257 * title.c: (get_title) Simplified debug output.
6259 * var.h: Comment fixes.
6260 (struct get_proc) Removed member `lv'.
6261 (struct variable) Removed member `lv'. Comment fixes.
6262 (glob vars read_active_file, write_active_file, cancel_input_pgm)
6264 (struct case_stream) New.
6266 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
6267 read_active_file references to use vfm_source.
6268 (init_variable, replace_variable) Removed references to `lv'.
6270 * vfm.c: Comment fixes.
6271 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
6273 (static var queue, qh, qt, n_lag) Removed. All references
6275 (glob var compaction_necessary, compaction_nval, compaction_case,
6276 paging) New variables.
6277 (record_case) Removed.
6278 (procedure) Comment fixes. Calls vfm_source->read() instead of
6281 (prepare_for_writing, arrange_compaction, make_temp_case,
6282 vector_initialization, setup_filter) New function.
6283 (open_active_file) Most of the code moved into the abovementioned
6284 new functions. Now sets temp_dict to &default_dict if there is no
6285 temporary dictionary, for convenience. New debug output.
6286 (close_active_file) Deals with changing the sink to the source.
6287 Calls finish_compaction(). Frees compaction_case. Mostly
6289 (glob vars disk_source_file, disk_sink_file) New vars.
6290 (destroy_active_file, read_from_memory) Removed.
6291 (disk_stream_init, disk_stream_read, disk_stream_write,
6292 disk_stream_mode, disk_stream_destroy_source,
6293 disk_stream_destroy_sink) New functions.
6294 (glob var vfm_disk_stream) New var.
6295 (glob vars memory_source_cases, memory_sink_cases,
6296 memory_sink_iter, memory_sink_max_cases) New vars.
6297 (memory_stream_init, memory_stream_read, memory_stream_write,
6298 memory_stream_mode, memory_stream_destroy_source,
6299 memory_stream_destroy_sink) New functions.
6300 (glob var vfm_memory_stream) New var.
6301 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
6302 named `more_cases'. Simplified debug output. Otherwise mostly
6304 (record_case) Moved into the stream drivers. Removed.
6305 (transform) Removed (was dead code).
6306 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
6307 common case that the splits don't change, we don't need to copy
6308 the case into prev_case again--pointless.
6309 (compact_case) New function.
6310 (finish_compaction) New function.
6312 * vfmP.h: Comment fixes.
6313 (DEV_* enum series) Removed.
6314 (struct storage) Renamed `stream_info'. Removed variant record.
6315 Removed `device' member.
6317 * debug-print.h: New file.
6319 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
6321 * autorecode.c: Turned off debugging.
6323 * data-list.c: (destroy_dls) Closes the associated file handle.
6325 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
6326 parse_variables() options.
6328 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
6330 * display.c: (display_variables) Really fixed null cell bug.
6332 * file-handle.q: (fh_close_handle) Changed debugging message.
6334 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
6335 parse_variables() options.
6337 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
6338 (cmd_list) Fails if no variables specified.
6339 (determine_layout) Writes blank lines manually.
6341 * loop.c: (loop_1_trns_proc) Made debugging code only print
6342 messages if debugging.
6344 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
6345 parse_variables() arguments.
6346 (main) Parses optional parenthesized options to varlist
6347 subcommands into sbc->message.
6349 * sfm-read.c: Format fix.
6351 * var.h: (FV_*) New enum series.
6352 (PV_*) New enum PV_NO_SCRATCH.
6354 * vars-prs.c: (find_var) Removed.
6355 (fill_all_vars) Takes FV_* enum instead of boolean third
6356 argument. Rewritten to deal with scratch as well as system
6358 (parse_variables) Error message on scratch variable if
6361 * vfm.c: (static var virt_begin_func) New var.
6362 (procedure) Sets up virt_begin_func.
6363 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
6364 after dump_splits(). For succeeding groups changes, calls
6365 virt_begin_func() instead of begin_func().
6367 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
6369 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
6372 * dfm.c: Added some debugging messages, disabled by default.
6373 (open_file_r) Fixed error message.
6374 (read_record) On eof on inline_file, instead of calling
6375 fh_close_handle(), simply jump to eof label like a normal file.
6378 * display.c: Thin lines between rows for certain kinds of
6379 listing. Fixed `null cell' bug.
6381 * error.c: (failure) Flush stdout, stderr before failing.
6383 * file-handle.q: (fh_close_handle) Added debugging message.
6385 * frequencies.q: (dump_full) Bottom line extends across entire
6386 table width. Changed title formatting.
6387 (dump_condensed) Changed title formatting.
6388 (dump_statistics) Fixed title formatting.
6390 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
6391 Sets default value of set_format.
6393 * list.q: (cmd_list) Calls blank_line() before determine_layout().
6394 Passes write_all_headers() to procedure() as pre-group func.
6395 (write_all_headers) New function.
6396 (determine_layout) Removed calls to write_header().
6397 Calls blank_line() before and after write_fallback_headers().
6399 * recode.c: (recode_trns_free) Only attempts to free head->map if
6402 * sfm-read.c: (read_variables) Allows `#' at beginning of system
6403 file variable names but gives a warning. Sets `left' based on
6404 first character being/not being `#'. On lossage frees dict->var.
6406 * som-high.c: (som_draw_title) Simplified title formatting.
6408 * vfm.c: (dump_splits) Fixed and changed splits formatting.
6410 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
6412 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
6413 beginning. Frees v_src, v_dest on successful exit. Frees
6414 h_trans[*], h_trans on lossage.
6415 (recode) Frees h_trans[*], h_trans.
6417 * dfm.c: (dfm_close) Formatting change.
6418 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
6419 longer allocates its own in inline_file.
6420 (open_file_r) Passes the local dfm_fhuser_ext to
6422 (open_file_w) Message fix.
6423 (read_record) Buffer reallocation strategy changed. Frees
6424 ext->line even in inline_file to prevent leaks.
6425 (dfm_put_record) Fixed bug where `ext' was cached before the file
6426 was opened and thus it would be NULL when the file really was
6428 (cmd_begin_data) Sets up inline_file basics itself, then calls
6429 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
6431 * list.q: (write_line) Formatting fix.
6432 (clean_up) Minor strategy change. Sets proportional font after
6434 (determine_layout) Sets fixed font before writing regular headers,
6435 or after writing fallback headers.
6437 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
6438 and KEEP vars after using them.
6440 * postscript.c: (ps_init_driver) Frees x->family.
6441 (postopen) When loading fonts, free the temporary font name buffer
6443 (ps_text_set_font_by_position) Free temporary font name buffer
6445 (text) Fixed code that calculated `lig' so that `lig' always gets
6446 initialized. Formatting fix.
6448 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
6450 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
6451 cells, not xmalloc(), so that the cells will get destroyed
6454 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
6457 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
6459 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
6462 * dfm.c: Comment fix.
6464 * list.q: Comment fixes. Include somP.h. Removed static vars
6465 table, n_columns, n_rows, part. New struct list_ext. New static
6467 (n_lines_remaining, n_chars_width, write_line) New functions.
6468 (cmd_list, list_cases) Rewritten.
6469 (begin_row, end_row, flush_table) Removed.
6470 (write_header, clean_up, write_varname, write_fallback_headers,
6471 determine_layout) New functions.
6473 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
6475 * output.h: Comment fix.
6477 * postscript.c: Comment fix.
6478 (struct ps_driver_ext) Removed prop_size, fixed_size members;
6479 added font_size. All references changed.
6480 (ps_init_driver) Initializes font_size. Simplified space checking
6482 (static var option_tab[]) Removed prop-size, fixed-size; added
6484 (ps_option) Handles font_size.
6486 * som-high.c: Moved prototypes into somP.h.
6487 (som_init_driver) New function.
6488 (som_submit_table) Moved some code into new function
6490 (build_target) Moved some code into new function
6491 som_internal_eject_page().
6492 (som_eject_page) Uses som_internal_eject_page().
6493 (som_internal_eject_page) New function.
6495 * som-low.c: Moved prototypes into somP.h.
6497 * som.h: Formatting fixes.
6499 * somP.h: (struct som_driver_ext) Removed em_width;
6500 added prop_em_width, fixed_width.
6502 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
6504 * Makefile.am: Added `localedir' definition. Added
6505 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
6507 * ascii.c: (macro draw_line) Fixed capitalization.
6509 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
6510 compute.c, count.c, data-in.c, data-list.c, data-out.c,
6511 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
6512 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
6513 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
6514 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
6515 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
6516 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
6517 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
6518 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
6519 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
6520 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
6521 for internationlization.
6523 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
6525 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
6527 * do-if.c, sort.c, val-labs.c: Comment fixes.
6529 * glob.c: (init_glob) Uncommented, updated i18n support.
6531 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
6532 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
6533 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
6534 the declarations of macros taking arguments a lot nicer.
6536 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
6538 * error.h: Removed CE, CW aliases for SE, SW.
6540 * q2c.c: Removed explicit streq() definition since it's duplicated
6543 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
6544 stats.h, str.h, tokens.h: Made the declarations of macros taking
6545 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
6548 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
6550 * cmdline.c: Comment fixes.
6551 (pick_compat) Changed return type to int. Now, instead of setting
6552 glob var `compat' to the emulation, returns the emulation. All
6554 (parse_command_line) Added terminating null to end of
6555 `long_options' array definition.
6556 (pre_syntax_message) Fixes.
6557 (usage) Shows the default emulation in the syntax message by
6558 calling pick_compat().
6560 * getline.c: (getl_add_include_dir) Separates paths with
6561 PATH_DELIMITER, not DIR_SEPARATOR.
6563 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
6564 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
6566 * output.c: (outp_configure_macro) Make earlier definitions for a
6567 particular key override later ones for the same key.
6569 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
6571 * ascii.c: Comment fixes.
6573 * output.c: (outp_get_paper_size)
6574 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
6576 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
6578 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
6579 <errno.h>. GNU libc 2 enforces this!
6581 * command.c: (parse_cmd) Fixed problem with `else' clause being
6582 paired with wrong `if'. Comment fix.
6584 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
6586 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
6587 blp_getline() to getline().
6589 * output.c: (outp_eval_dimension) Changed the fix from last time;
6590 there was no variable `a'.
6592 * q2c.c: (get_line) Fixed boundary condition overrun bug.
6594 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
6596 * output.c: (outp_evaluate_dimension) Fixed handling of negative
6597 numbers having fractional parts. Added case of a fraction without
6598 a whole-number part.
6600 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
6602 * ascii.c: (ascii_text_get_font_position) Removed.
6604 * expr.h, exprP.h: Disabled debugging.
6606 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
6609 * output.h: (struct outp_class_struct) Removed
6610 text_get_font_position method. All references deleted.
6612 * postscript.c: Big change here. Fontmaps were completely
6613 eliminated because of a change in philosophy. Comment fixes.
6614 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
6616 (struct ps_driver_ext) `position', `fontmap', `prop_name',
6617 `fixed_name' members removed. New members `prop_family',
6618 `fixed_family'. `family' member changed to type char *.
6619 (static var ps_fontmaps) Removed.
6621 (ps_init_driver) Removed obsolete references, updated.
6622 Initializes `translate_x', `translate_y', `scale'. Doesn't read
6623 fontmap, of course. Refers to font names through internal_name
6624 rather than subversive means. Frees proper items.
6625 (static var option_tab[]) Removed `fontmap-file' option; renamed
6626 `fixed-font', `prop-font'.
6627 (ps_option) Corresponds to option_tab[].
6628 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
6629 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
6630 hash_family) Removed.
6631 (postopen) Generates font names from family names. Gets
6632 PostScript font name properly. New prologue file comment `!!!'
6634 (ps_open_page) Adds translate_x, translate_y to BP prologue
6635 function; gives SF argument floating-point format.
6636 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
6637 font name. Doesn't change font family.
6638 (ps_text_set_font_by_position) Generates Groff font name from font
6639 family name instead of through table lookup.
6640 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
6641 all references changed. Reduced to simple string assignment.
6642 (ps_get_font_name) Removed.
6643 (ps_get_font_family) Reduced to string return.
6644 (text) Doesn't save `position' since it no longer exists. Ugly
6645 kluge to save font family--fix soon?
6646 (load_font) Removed PostScript name argument.
6648 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
6650 * postscript.c: Comment fix.
6651 (ps_open_page) Puts scale factor in PostScript output.
6653 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
6655 * Makefile.am: Distcleans q2c.
6657 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
6659 * ascii.c: (delineate) Sets text size even if width is zero.
6661 * command.c: Comment fix.
6662 (static var cmd_table[]) Re-enabled EVALUATE command.
6663 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
6664 of comments in script files. Now more liberal on criteria for
6665 performing a state transition--if *anything* happened correctly,
6666 not just if *everything* happened correctly.
6668 * data-out.c: (convert_F) Comment fix. Why in the fsck does
6669 Checker segfault on formatting large numbers and why in the fsck
6670 hadn't I noticed this before?
6672 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
6674 * list.q: (cmd_list) Commented out the actual output routine
6675 because of various problems. Probably will abandon the idea of
6676 using the general `crushed tables' for the LIST procedure.
6678 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
6679 clearing it. Allocates a new var_by_name dictionary before trying
6680 to add members to it.
6682 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
6683 `sib'. Changed type of `node' argument.
6684 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
6686 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
6687 [DEBUGGING] Only deletes the variable from var_by_name if that var
6690 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
6692 * Makefile.am: Added include files to SOURCES. Added
6693 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
6694 includes rules for q2c. Added `boast' target.
6696 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
6698 * Makefile.am: Maintainer-clean Makefile.in.
6700 * Makefile.am: Fixed redundant EXTRA_DIST line.
6702 * ascii.c: Comment fixes.
6703 (ascii_line_vert) Fixed overly aggressive range check.
6705 * display.c: Removed dead code.
6707 * list.q: Turn debugging on.
6708 (flush_table) New debug code.
6710 * sfm-read.c: (read_value_labels) malloc's the structure before
6711 trying to assign to its members.
6713 * sfm-write.c: Comment fix.
6715 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
6717 (output_table) No arguments anymore--gets them through `som'
6718 global. New debug code. In crushed tables, now sets `htv' as
6719 well as `hv' to avoid bad confusion later.
6720 (dump_crush_page) New debug code.
6722 * som-low.c: (som_dump_crush_page) New debug code.
6724 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
6726 All source files: Broke long lines into multiple lines.
6728 * ascii.c: (ascii_close_page) Uses host_system var in place of
6729 HOST_SYSTEM constant.
6731 * cmdline.c: (var syntax_message[]) Broke into
6732 pre_syntax_message[] and post_syntax_message[].
6733 (usage) Outputs both parts, separated by driver list.
6735 * error.h: Fixed broken formatting.
6737 * expr-opt.c: (str_search, str_rsearch) New functions.
6739 * misc.c: (blp_getdelim) Removed. All references changed to
6741 (str_search, str_rsearch) Removed.
6742 (memrmem) New function.
6744 * misc.h: (blp_getline) Removed. All reference changed to
6749 * filename.c: Includes "stat.h", not <sys/stat.h>.
6750 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
6752 * output.c: (outp_list_classes) Changed output formatting.
6754 * sfm-write.c: (write_header) Uses host_system var instead of
6755 HOST_SYSTEM constant.
6756 (write_rec_7_34) Extracts version numbers from the version string.
6759 * sort.c: Includes "stat.h", not <sys/stat.h>.
6761 * str.c: (strcasecmp) Removed.
6763 * title.c: (cmd_document) Uses host_system var instead of
6764 HOST_SYSTEM constant.
6766 * version.c: Generated on-the-fly by the Makefile instead of being
6769 * str.h: Comment fixes. Doesn't substitute for missing memmove or
6771 [!HAVE_STRNCASECMP] Declares strncasecmp().
6773 * version.h: Removed stray character. Comment fixes.
6774 (vars host_system, build_system) New vars.
6776 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
6778 * Most source files: Changed formatting of copyright notice; fixed
6779 FSF address; reformatted to better conform to GNU standards;
6780 comment fixes. Added markups to prevent GNU indent from messing
6781 up my beautiful formatting :-).
6783 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
6784 that GNU indent markups can be passed through without problems.
6786 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
6788 * get.c: Turned off debugging.
6790 * glob.c: (init_glob) Turned on save-file compression by default.
6792 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
6793 compression than was possible in save files.
6795 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
6797 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
6799 * frequencies.q: Removed Fiasco extensions. Updated calculation
6800 algorithms. Polished output format.
6801 (struct frq_info_struct) Removed members `max_degree', `min_n',
6802 all references removed.
6803 (macro frq_extensions) Removed.
6804 (static vars min_n, max_degree) Removed, all references removed.
6805 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
6806 calculate `min_n', `max_degree'.
6807 (postcalc) Passes new arg to dump_statistics().
6808 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
6810 (dump_condensed) Adds variable name title.
6811 (sum_freqs) Removed.
6812 (calc_stats) Updated calculation algorithm.
6813 (dump_statistics) Removed warning for too-few observations.
6814 Changed table formatting. Adds variable name title if passed new
6817 * output.h: Comment fix.
6819 * recode.c, sample.c, sort.c: Disabled debug code.
6821 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
6822 Improved debug code.
6824 * var.h: (enum series frq_*) Removed Fiasco extensions.
6826 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
6828 * command.c: Added PROCESS IF to command table.
6830 * Lots & lots of places, removed checks for NULLs preceding calls
6831 to free_expression(), which itself checks.
6833 * descript.q: Removed Fiasco extensions. Removed optimizations
6834 for non-weighted active files. Implemented some options.
6835 Finished polishing output format. Comment fixes. Merged
6837 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
6838 max_degree, min_n) Removed.
6839 (macro dsc_extensions) Removed.
6840 (struct dsc_info_struct) Removed `min_n' member, all references
6842 (internal_cmd_descriptives) Removed calculation of min_n,
6843 max_degree. Only deals with one `calc' routine instead of two
6845 (precalc) Eliminated redundancy. Updated for changes to
6846 descriptives_proc structure.
6847 (calc) Moved here from `descript.g'. Rewritten to calculate
6848 statistics via `moments about the mean' rather than by summing,
6849 summing squares, summing cubes, and so on.
6850 (postcalc) Rewritten for new-style statistical calculation.
6851 (display) Removed support for displaying variables across rows.
6852 No longer crushes the descriptives table. Removed ancient code.
6853 Added display of N, by variable and listwise.
6855 * descript.g: Removed; merged into `descript.q'.
6857 * expr-evl.c: (evaluate_expression) Now returns a double. For
6858 numeric results, it returns the result as well as storing it in
6859 the passed `value' structure if non-NULL. For string results it
6860 just returns 0.0 and it must be passed non-NULL. Many references
6861 to this function were optimized by use of this change, especially
6862 but not exclusively in `compute.c'.
6864 * frequencies.g: Comment fix.
6866 * glob.c: (glob var process_if_expr) New global var.
6868 * postscript.c: (static var option_tab[]) Corrected entry for
6870 (postopen) Sets x->size to x->prop_size.
6871 (ps_text_set_font_by_name) Sets font size as well as typeface for
6872 PROP and FIXED fonts.
6874 * sel-if.c: (cmd_process_if) New function.
6876 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
6877 (sfm_write_dictionary) Sets `n_cases' to 0.
6878 (sfm_write_case) Increments `n_cases'.
6879 (sfm_close) Attempts to seek the system file back to the header
6880 and write the number of cases in its proper slot.
6882 * som-frnt.c: (som_insert_table) Masks off expansion options since
6883 only SOPT_X_NORM seems to work sensibly.
6885 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
6886 with a `fixed' value of 2.
6888 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
6890 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
6891 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
6893 * var.h: (enum series dsc_*) Removed Fiasco extensions.
6894 (struct descriptives_proc) Removed `miss_noweight'; new members
6895 `X_bar', `M2', `M3', `M4', `min', `max'.
6897 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
6899 * vfm.c: (close_active_file) Cancels PROCESS IF.
6900 (write_case) Doesn't process cases unselected by PROCESS IF.
6902 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
6904 * glob.c: (glob var err) Removed.
6906 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
6907 doesn't have to take into account number of value labels since
6908 they're in a subtable anyway. Also, doesn't display more than 10
6909 value labels since we can't yet break pages in subtables.
6911 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
6913 * som-frnt.c: (som_change_table_size) Simple change for elegance
6914 that shouldn't change behavior.
6915 (som_set_value) Comment fix.
6917 * som-high.c: (som_submit_table) Message fix.
6919 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
6921 * command.c: Added SYSFILE INFO to command table.
6923 * file-handle.q: (fh_handle_filename) New function.
6925 * get.c: (save_trns_proc) Fixed a bug in padding of output data
6928 * main.c: (parse) New return value for command functions, -3.
6930 * misc.h: Comment fix.
6932 * output.h: Comment fixes.
6933 (macro COMPONENTS) Removed.
6935 * postscript.c: (write_text) Modified literal_chars[] so that `('
6936 and ')' are not written to the output in strings as literals.
6938 * sfm-read.c: (sfm_read_dictionary) New argument.
6939 (read_header) New argument. Sets the information structure's
6940 values from the header information.
6941 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
6942 bizarre Checker problem, I guess.
6943 (read_variables) Proper cleanup on lossage.
6945 * sfm.h: (struct sfm_read_info) New struct for use by
6946 sfm_read_dictionary().
6948 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
6949 currently used just for tables that can be dynamically resized and
6950 thus have to be allocated with arena_malloc() instead of
6951 arena_alloc(). All references changed.
6952 (som_change_table_size) New function.
6953 (som_insert_table) Bugfix: now inserts `cell', not `c'!
6955 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
6956 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
6959 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
6961 (draw_intersection) Now takes an argument specifying the table in
6962 question. All references changed.
6963 (draw_table_cell) New function.
6964 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
6965 (som_get_table_size) Many nice new explanatory comments.
6966 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
6968 * som.h: New enum series SOM_CREATE_* for use as create flags with
6971 * str.h: Moved a comment here from TODO.
6973 * sysfile-info.c: New file. Reference implementation.
6975 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
6977 * command.c: Added RENAME VARIABLES to table of commands.
6979 * data-in.c: (dls_error) Sets `cust_field'.
6980 (parse_N) Message fix.
6981 (parse_day_count) New function.
6982 (to_roman) Never outputs VX as a `short form' of V.
6983 (parse_month) Fixed parsing of Roman numerals.
6984 (parse_trailer) Message fix.
6985 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
6986 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
6987 the date is invalid.
6988 (parse_SDATE) Fixed swapped day, year.
6989 (parse_JDATE) Fixed bug for dates in 1582.
6990 (parse_DTIME) Allows days not between 1 and 31.
6991 (parse_numeric) Makes local copy of f.type for easier usage.
6994 * data-out.c: (convert_F) When outputting as scientific, properly
6995 sets f.type as fp->type.
6996 (insert_commas) Fixed operator precedence problem with setting of
6997 nitems. Changed strcpy to memcpy (no null terminator).
6998 (convert_date) Fixed FMT_JDATE: added 1900 to year.
6999 (convert_CCx) Essentially rewritten, but now it works.
7001 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
7003 (display_documents) Implemented.
7005 * error.c: (glob var cust_field) New var.
7006 (vmsg) Displays cust_field as part of message classes DE and DW.
7008 * formats.c: (debug_print) Fixed to compile under updated
7011 * get.c: (cmd_get, cmd_save_internal) Close file handle on
7014 * misc.c: (parse_format_specifier) Formatting fix.
7016 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
7017 `n_rename' for clarity.
7018 (cmd_modify_vars) Initializes `forward' and `positional' at
7019 appropriate times. Frees lists of vars to rename on failure.
7020 Comment fix. Frees memory on success.
7021 (rearrange_dict) Simplified `for' loop condition.
7023 * rename-vars.c: New file (reference implementation).
7025 * set.q: (internal_cmd_set) Fixed `emu' test condition.
7027 * sfm-read.c: (read_header) File label is created only if file
7028 label in file is not blank.
7029 (read_variables) Initializes `dict' local variable.
7030 (read_documents) Proper behavior on lossage.
7032 * sfm-write.c: (write_header) Doesn't blank out the file label
7033 (why was this here to begin with?!)
7035 * temporary.c: (save_dictionary) File label is copied only if
7036 non-NULL. Doesn't try to xstrdup() dictionary documents.
7037 Adapted so as to not irritate Checker.
7038 (free_dictionary) Only destroys var_by_name if non-NULL.
7040 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
7041 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
7042 lines to the document, indents the document. Also, it works now.
7043 (add_document_line) New function.
7045 * var.h: (struct dictionary) Reordering.
7047 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
7048 bits if it was allocated to begin with.
7050 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
7052 * command.c: Added MODIFY VARS to list of commands.
7054 * configure.in: Updated custom macros for autoconf 2.12. Removed
7055 mmap reference; fixed termcap library reference.
7057 * display.c: (display_variables) Fixed a few bugs although it's
7058 still not well written.
7060 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
7061 (induce_segfault) Calls chkr_disp_call_chain() instead of
7062 inducing an actual SIGSEGV.
7064 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
7065 str_search() and str_rsearch(). Fixed tests for matches on
7066 OP_INDEX and OP_RINDEX.
7068 * filename.c: (good_getcwd) Removed as the new libc for Checker
7069 doesn't contain this bug, apparently.
7071 * misc.c: (str_search, str_rsearch) Changed order of arguments for
7072 consistency with GNU memmem.
7073 (blp_getdelim) Changed `len' from `int' to `size_t'.
7075 * modify-vars.c: Reference implementation.
7077 * som-frnt.c: (zero_length) New global var.
7078 (som_create_table) Message fix.
7080 * som.h: Added gcc attributions to som_set_text(),
7081 som_output_text() prototypes. blank_line() refers to
7082 zero_length[] instead of a literal null string to suppress gcc
7085 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
7086 (allocate_cases) Decrements x_max so the last element of x[] can
7087 be used by the algorithm.
7089 * var.h: Changed minor details of `variable' declaration.
7090 (struct modify_vars_proc) New struct.
7091 (struct variable) Added field p.mfv.
7093 * vars-atr.c: Comment fix.
7095 * vars-prs.c: (fill_all_vars) More optimal implementation.
7097 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
7098 character, which it shouldn't have to do but printf() seems to
7099 read the null byte even though I supply a maximum length...
7101 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
7103 * command.c: Removed command alias X for QUIT.
7104 (parse_cmd) Fixed comment parsing.
7106 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
7108 (read_record) Fixed references to len, size.
7109 (dfm_get_record) Restructured.
7111 * file-handle.h: (struct file_handle) Field `lrecl' now of type
7114 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
7117 * modify-vars.c: New file. Not complete.
7119 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
7122 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
7123 problems caused by int/size_t differences.
7125 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
7128 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
7129 being compared were of equal length.
7131 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
7133 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
7135 * lexer.c: (get_dotted_rest_of_line) New function.
7137 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
7140 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
7141 type 6 records. Frees the dictionary properly.
7142 (read_header) Initializes the dictionary instead of letting
7143 read_variables() do it. Sets the dictionary file label from the
7145 (read_documents) New function.
7147 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
7148 write type 6 record if appropriate.
7149 (write_header) Writes file label from dictionary.
7150 (write_documents) New function.
7152 * temporary.c: (save_dictionary, restore_dictionary,
7153 free_dictionary) Properly handle new fields in dictionary struct.
7155 * title.c: (get_title) Returns after failure().
7156 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
7157 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
7159 * var.h: (struct dictionary) New fields `label', `n_documents',
7162 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
7164 * command.c: Added FILTER to list of commands.
7166 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
7169 * get.c: (cmd_save_internal) Removed weighting code since it's now
7170 handled by sfm-write.c. Properly commented out debug code.
7172 * glob.c: (glob var weighting) Removed.
7174 * sel-if.c: Comment fixes.
7175 (cmd_filter) New function.
7177 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
7178 (sfm_read_dictionary) Sets weighting variable direct in the
7179 created dictionary now. (Apparently we previously didn't support
7181 (read_header) Sets weight_index field in sfm_fhuser_ext from
7182 header read from disk.
7184 * sfm-write.c: (sfm_write_dictionary) Comment fix.
7185 (write_header) Now sets the weighting in the header from the
7186 passed primary dictionary instead of from the sfm_write_info.
7188 * sfm.h: (struct sfm_write_info) Removed field `weight'.
7190 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
7191 broke on boundary conditions.
7193 * var.h: (struct dictionary) New fields `weight_var',
7194 `weight_index', and `filter_var'.
7195 (glob var weighting) Removed. This is now part of struct
7196 dictionary. All references changed; the less mechanical changes
7197 are described above.
7199 * vars-atr.c: (find_dict_variable) New function.
7201 * vfm.c: (static var filter_index) New variable.
7202 (open_active_file) Initializes filter_index from default_dict.
7203 (write_case) Calls proc_func() only if the filter variable is
7204 nonzero; this implements FILTER behavior.
7206 * weight.c: (static var weight_varname) Removed.
7207 (cmd_weight) Modified default_dict instead of glob vars.
7208 (update_weighting) Changed the signature to modify a dictionary
7209 instead of glob vars. Now returns the weighting variable.
7210 (get_weighting_variable) Removed; its function is absorbed by
7212 (stop_weighting) Operates on a dictionary now.
7214 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
7216 * sort.c: Removed debugging info from messages.
7217 (do_external_sort) Cleans up after itself by deleting the
7218 temporary directory on failure. (On success it is deleted by the
7220 (allocate_cases) Removed debug code. Added clean up code.
7221 (output_record) Removed debug code.
7222 (merge) Added code to close all the input files that are currently
7223 open. This is a likely location for bugs, because I'm not sure
7224 about boundary conditions. Removed an unnecesary heap_delete().
7225 (merge_once) Removed input file "optimization" that in fact
7226 screwed up the rest of the code. Message and comment fixes.
7228 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
7230 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
7232 * heap.c: (heap_delete) New argument.
7234 * sort.c: Finished implementation of external sort.
7236 * vfm.c: (read_from_disk) Returns after a disk error.
7238 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
7240 * sort.c: (static var state) Removed.
7241 (static vars max_handles, tmp_basename, tmp_extname,
7242 huffman_queue) New variables.
7243 (do_external_sort) Moved most code to new functions.
7244 Creates huffman_queue.
7245 (allocate_file_handles, allocate_cases) New functions.
7246 (static vars run_no, run_length, file_index, case_count) New
7248 (output_record) Returns success. Now really writes to the output
7250 (begin_run, end_run) New functions.
7251 (write_initial_runs) Returns success. Initializes run_no to -1.
7252 Calls begin_run(), end_run() at appropriate times. Outputs debug
7254 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
7256 (merge) New function.
7258 * heap.c, heap.h: New files. Hopefully in near-final form.
7260 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
7262 * glob.c: Added write_active_file to global vars.
7264 * sort.c: Several new miscellaneous static variables.
7265 (cmd_sort_cases) Big comment fix.
7266 (perform_case_2) Renamed `do_external_sort' and completely
7268 (case_2_proc_func) Removed.
7269 (output_record, write_initial_runs, write_to_sort_cases,
7270 compare_record) New functions.
7272 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
7274 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
7276 * sort.c: (perform_case_2) Changed the method for allocation of
7277 lots of memory--now allocates one case at a time in hopes that
7278 more cases can be allocated with heavily fragmented memory.
7280 * var.h: (write_active_file) New global var.
7282 * vfm.c: (procedure, close_active_file, write_case,
7283 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
7284 arguments to procedure() to be NULL. All references to
7285 procedure() that made use of dummy functions were changed to NULL
7287 (open_active_file) If write_active_file is non-NULL, the output
7288 device becomes DEV_PGM (a new enum).
7289 (close_active_file) Sets write_active_file to NULL.
7290 (read_from_memory) Comment fix.
7291 (record_case) Calls write_active_file() when the output device is
7294 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
7298 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
7299 Fixed checking for duplicate varnames.
7300 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
7302 (autorecode_trns_free) Destroys hash tables for each recoding
7304 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
7306 * command.c: Added SORT CASES to cmd_table.
7307 (null_func, null_int_func) Prototyped.
7309 * descript.g: (calc_weight, calc_noweight) Computes own case
7312 * frequencies.q: (dump_statistics) Fixed problem with
7313 too-few-cases warning message.
7315 * get.c: (cmd_save_internal) Handles weighting properly.
7317 * hash.c: (hsh_dump) Output format changed.
7318 (force_hsh_insert) Actually works now, prototype changed.
7320 * list.q: (static var case_num) New variable.
7321 (cmd_list) Initializes case_num.
7322 (list_cases) Increments case_num.
7324 * var.h: Added definitions for SORT CASES. Comment fixes.
7326 * vfm.c: Some definitions moved to new file vfmP.h. Comment
7327 fixes. `active' renamed vfm_active, `rep' renamed
7328 vfm_replacement, all references changed.
7329 (procedure) The procfunc no longer receives a case number. All
7331 (write_case) Subtle reordering.
7332 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
7335 * weight.c: (get_weighting_variable) New function.
7337 * vfmP.h: New file with definitions from vfm.c.
7339 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
7341 * command.c: (FILE_TYPE_okay) Commented out some tests because
7342 they're clumsy and not yet needed.
7344 * var.h: Most *_trns structures moved to their respective source
7345 files. Some were moved into a new file, do-ifP.h. Comment fixes.
7346 (union any_trns) Changed to a typedef for trns_header.
7347 (struct input_program_pgm) Removed.
7349 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
7350 was allocated in the first place.
7352 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
7354 * autorecode.c: New file.
7356 * command.c: Added AUTORECODE to command table; re-enabled SET.
7358 * data-out.c: (convert_F) Handles infinities and NaNs properly.
7360 * error.c: (vmsg) Comment fixes.
7362 * hash.c: Comment fix.
7363 (hashpjw_d) New function.
7364 (hashpjw) Reimplemented as call to more general function
7366 (internal_comparison_fn) Initializes pointers properly.
7367 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
7368 (force_hsh_insert, force_hsh_find) New debugging wrapper
7371 * main.c: (main) Message fix.
7373 * output.c: (outp_read_devices) Message fix.
7375 * set.q: Comment fixes.
7376 (custom_results) Implemented Wnd/X form of subcommand.
7377 (set_routing) New function.
7378 (internal_cmd_set) Implemented ERRORS, MESSAGES.
7380 * settings.h: (SET_ROUTE_*) New enum series.
7381 (set_results) Renamed set_results_file, all references changed.
7382 (set_messages) Removed.
7383 (glob vars set_errors, set_messages, set_results) New vars.
7385 * title.c: (get_title) Remembers to xstrdup() the result of
7388 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
7390 (union any_trns) New element `arc'.
7392 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
7394 * command.c: (output_line) Removed references to set_screen.
7396 * error.c: (static var terminating) New var.
7397 (hcf) Sets terminating to 1.
7398 (vmsg) If terminating is nonzero, does not attempt to call hcf().
7399 This prevents an infinite loop if an error occurs within hcf().
7401 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
7402 statement circumlocution with `case 42000' trick.
7403 (evaluate_expression) New support for OP_STR_MIS.
7405 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
7406 statement circumlocution with `case 42000' trick.
7407 (dump_node) Handles OP_STR_MIS.
7409 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
7410 variables exceptions.
7411 (parse_function) Message fix.
7412 (ops[]) Added OP_STR_MIS.
7414 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
7416 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
7418 * glob.c: Removed set_scrnfile glob var.
7419 (init_glob) set_errorbreak set to 0 by default.
7421 * groff-font.c: Changed included files.
7422 (groff_read_font) Initializes font_arena local var correctly.
7423 (default_font) New function.
7425 * output.c: Comment fixes.
7426 (glob var disabled_devices) New variable.
7427 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
7429 [GLOBAL_DEBUGGING] (reentrancy) New function.
7430 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
7431 outp_iterate_enabled_drivers) Calls to reentrancy().
7432 (destroy_list) New function.
7433 (outp_done) Moved code to destroy_list().
7434 (parse_options) Parses `listing', `screen', `printer' options
7436 (configure_driver) Sets new `device' member of driver.
7437 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
7439 * output.h: Comment fixes. New enum series OUTP_DEV_*.
7440 (struct outp_driver_struct) New member `device'.
7442 * postscript.c: (find_encoding_file) Doesn't display its own error
7444 (default_encoding) New function.
7445 (switch_font) Calls default_encoding() if no encoding can be
7447 (text) Makes up a character metric if none exists for the desired
7449 (load_font) Properly copies a fallback filename. Calls
7450 default_font() for a font if none at all are known.
7452 * set.q: Comment fixes. Removed OUTPUT subcommand.
7453 (custom_listing) Calls outp_enable_device() to enable/disable
7455 (turn_screen_on) Removed.
7456 (internal_cmd_set) Calls outp_enable_device() to enable/disable
7457 screen, printer devices.
7459 * settings.h: Comment fixes.
7460 (glob vars set_output, set_printer, set_screen, set_scrnfile)
7463 * som-high.c: (som_submit_table, som_eject_page) Use
7464 outp_iterate_enabled_drivers() instead of iterating
7465 outp_driver_list directly.
7467 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
7469 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
7470 (parse_string_as_format) Handles new formats.
7471 (parse_numeric) Now handles DOT and PCT formats.
7473 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
7475 (convert_date) Handle EDATE and SDATE formats.
7476 (convert_CCx) Now if there's not room for the currency characters,
7477 converts it as F format if it's positive instead of giving up
7478 quickly. Also fixed save-and-restore bug with decimal point
7480 (convert_format_to_string) Handles new formats.
7482 * misc.c: (formats[]) Added new formats.
7483 (convert_fmt_ItoO) Supports new formats.
7485 * sfm-read.c: (parse_format_spec) Supports new formats. Better
7486 data checking. New argument, all references changed.
7488 * sfm-write.c: (write_format_spec) Supports new formats.
7490 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
7493 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
7495 * cmdline.c: Comment fixes.
7496 (parse_command_line) Changed return type to void.
7498 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
7500 (parse_numeric) Handles international numbers (comma as decimal
7501 point). Some reformatting.
7503 * data-list.c: (parse_free) Default output format is now
7504 set_format instead of hard-coded F8.2.
7505 (read_from_data_list_list) Emits error message on undefined data
7506 only if set_undefined is nonzero.
7508 * data-out.c: (convert_E) Changes decimal point from period to
7509 comma if appropriate. Restructured. Better comments.
7510 (convert_F) Changes decimal point from period to comma if
7512 (insert_commas) Major bug with handling of negative values fixed.
7513 Also, inserts periods instead of commas if appropriate.
7514 (convert_CCx) New function.
7515 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
7516 (num_to_string) Changed `.' to set_decimal.
7518 * dfm.c: Comment fixes.
7519 (dfm_close) Frees ext->line even in inline_file.
7520 (open_inline_file) New function.
7521 (open_file_r) When opening the inline file: now properly
7522 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
7524 (read_record) Calls fh_close_handle() instead of dfm_close() to
7525 close the inline file. Makes a copy of the line getl_buf to avoid
7527 (dfm_get_record) Restructured. Now checks the return value of
7529 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
7530 checking for use of inline file. No longer tries to close inline
7533 * error.c: (glob var error_already_flagged) New var.
7534 (vmsg) Message change. Now checks max number of errors/warnings,
7537 * file-handle.q: (fh_handle_name) Now allows closing of
7539 (fh_init_files) Reformatted.
7541 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
7543 * getline.c: (getl_include) Fixed bug that popped up when called
7544 when file queue was empty.
7545 (read_console) Resets error_count, warning_count,
7546 error_already_flagged to zero.
7548 * glob.c: Many changes to update list of variables.
7549 (init_compat_dependent) Now this function is called whenever
7550 `compat' changes. It now sets set_seed only if it hasn't
7551 previously been referenced. It now calls
7552 lex_init_compat_dependent().
7554 * include.c: (cmd_include_at) Frees temporary buffer instead of
7556 (cmd_include) Doesn't make copy of include file name.
7558 * lexer.c: Comment fixes.
7559 (init_lex) Moved some code into new function
7560 lex_init_compat_dependent().
7561 (lex_init_compat_dependent) New function.
7562 (hex_val) Simplified.
7563 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
7565 * main.c: Comment fixes.
7568 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
7569 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
7570 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
7571 (setup_randomize) Sets set_seed_used.
7573 * set.q: Comment fixes.
7574 (custom_results) Conditionalizes on `compat'.
7575 (custom_log) Calls custom_journal().
7576 (set_ccx) New function.
7577 (cmd_set) Calls init_compat_dependent() when `compat' changes.
7578 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
7579 when set_decimal changes. Range-checks values for MITERATE,
7580 MNEST. Message fixes.
7582 * settings.h: Comment fixes.
7583 (struct set_cust_currency) New struct.
7584 (set_cc[], set_grouping, set_seed_used) New global vars.
7586 * var.h: (FMT_CCA...FMT_CCE) New output formats.
7587 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
7589 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
7591 * glob.c: Revised variables to correspond to settings.h.
7592 (init_glob) Initializes variables from settings.h properly.
7594 * set.q: Began long-overdue major revision to correspond to new
7595 philosophy. Most code changed.
7597 * settings.h: Mostly changed; reorganized, reordered, large new
7600 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
7602 * get.c: (cmd_save_internal) No longer forces compression off.
7604 * sfm-read.c: (read_compressed_data) If eof is reached when
7605 reading a new instruction octet, only signal error if we're in the
7608 * sfm-write.c: (COMPRESSION_BIAS) New #define.
7609 (struct sfm_fhuser_ext) New member `end'.
7610 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
7611 (ensure_buf_space) New function.
7612 (sfm_write_case) Reimplemented in order to support compression.
7613 (sfm_close) Writes out the remaining contents of the compression
7616 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
7618 * command.c: Defined SAVE and XSAVE commands in command table.
7620 * common.h: second_lowest_value is of type flt64, not double.
7622 * file-handle.h: Comment fix.
7624 * get.c: Comment fixes.
7625 (static var `trns') New.
7626 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
7627 cmd_save_internal, cmd_save, cmd_xsave) New functions.
7628 (dict_delete_run) Clears the variables and frees them now.
7629 (trim_dictionary) Sets default for compression.
7630 On KEEP subcommand, frees deleted variables as well as clearing
7631 them. Finally got the sense of the test for deleting all
7633 [DEBUGGING] (dump_dict_variables) Message fix.
7635 * glob.c: (init_glob) set_compression set to 1 by default.
7637 * list.q: Properly #includes config.h.
7639 * misc.h: New macro REM_RND_UP.
7641 * settings.h: Comment fix.
7643 * sfm-read.c: (structs sysfile_header, sysfile_format,
7644 sysfile_variable; inline function bswap_int32) Moved to new file
7646 (corrupt_msg) [__CHECKER__] No longer induces segfault.
7647 (sfm_read_dictionary) Fixed bug caused by failing to initialize
7649 (read_machine_flt64_info) Fixed some problems caused by confusion
7650 between flt64 and double types.
7651 (read_header) Message fix.
7652 (read_variables) Fixed set of cases in which we byte-swap sv.print
7653 and sv.write. Fixed confusion of flt64 and double.
7655 * sfm.h: (struct sfm_write_info) New.
7657 * som-high.c: (som_draw_title) Properly frees `s'.
7659 * temporary.c: (save_dictionary) Comment fix.
7661 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
7662 (struct trns_header) Formatting fix.
7663 (struct save_trns) New.
7665 * vars-atr.c: (discard_variables) Comment fix.
7667 * sfm-write.c: New file, baseline release.
7669 * sfmP.h: New file, baseline release.
7671 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
7673 * cmdline.c: (parse_command_line) `--version' output updated.
7674 (glob var syntax_message[]) Added my e-mail address.
7676 * file-handle.q, lexer.c, vfm.c: Changed many instances of
7677 `illegal' to `invalid'.
7679 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
7680 uncompression buffer.
7681 (sfm_close) Frees decompression buffer.
7682 (sfm_read_dictionary) Initializes decompression buffer.
7683 (buffer_input, read_compressed_data) New functions.
7684 (sfm_read_case) Restructured; now calls read_compressed_data() to
7685 handle compressed system file data.
7687 * var.h: Comment fix.
7689 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
7691 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
7694 * get.c: New comments. New static var `get_file'.
7695 (cmd_get) Now fully implemented. Calls discard_variables();
7696 initializes fv and lv for all variables; new debug code; sets
7697 up the dictionary; sets up the input program.
7698 (read_from_get, cancel_get) New functions.
7700 * sfm-read.c: Comment fixes.
7701 (sfm_close) New static function.
7702 (sfm_read_dictionary) Properly sets up the class of the
7703 file_handle. No longer cares what size the data is in records of
7704 type 7. Also, on failure, properly cleans up the file_handle and
7706 (read_variables) No longer thinks it knows `nval' of the
7707 dictionary. Now sets p.get.fv, etc., instead of speculatively
7709 (read_value_labels) Fixed off-by-one error in indexing of
7711 (sfm_read_case) New function.
7712 (sfm_r_class) New static var.
7714 * var.h: (get_proc) New struct.
7715 (struct variable) New member p.get.
7717 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
7719 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
7720 the manual's meaning.
7721 (rename_variables) New function.
7722 (trim_variables) Doesn't try to parse MAP any more. Removed debug
7723 code. Now properly reorders the dictionary on the KEEP keyword.
7725 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
7728 * vars-atr.c: (clear_variable) New argument `dictionary *'.
7729 (rename_variable) New function.
7730 (free_val_lab) Reformatted.
7732 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
7734 * var.h: Reindented entire file. Comment fixes.
7735 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
7737 (glob var default_dict) New.
7738 (struct indirect_dictionary) Removed.
7740 * Many other source files were changed to add `default_dict.'
7741 before all references to the dictionary of the active file.
7743 * vars-atr.c: (make_indirect_dictionary) Removed.
7745 * glob.c: Reindented all variable declarations. Updated for
7746 changed var.h. Comment fixes.
7748 * temporary.c: (restore_dictionary, save_dictionary) Simplified
7749 because now we can mainly copy dictionary structs.
7751 * vars-prs.c: (is_dict_varname, parse_dict_variable,
7752 parse_variables) Takes dictionary instead of indirect_dictionary
7754 (parse_variables) Instead of calling make_indirect_dictionary,
7755 just sets DICT to &default_dict if DICT is NULL. Of course, lots
7756 of `*dict.' references had to be changed to `dict->'. Removed
7759 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
7761 * get.c: Added GTSV_OPT_* series of enums.
7762 (trim_dictionary, dict_delete_run) New functions.
7763 [DEBUGGING] (dump_dict_variables) New function.
7764 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
7765 [DEBUGGING] Calls dump_dict_variables() to display results.
7767 * glob.c: (cmp_variable) Now a public function declared in var.h.
7769 * sfm-read.c: Turned off debug code. Comment fixes.
7770 (read_machine_int32_info, read_machine_flt64_info) New functions
7771 to parse type 7 records.
7772 (sfm_read_dictionary) Properly byteswaps several fields now.
7773 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
7774 records. [DEBUGGING] Dumps dictionary.
7775 (read_variables) Sets `index' field of variables created properly.
7776 Constructs avl tree of variables in dictionary. [DEBUGGING] No
7777 longer dumps dictionary.
7778 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
7780 [DEBUGGING] (dump_dictionary) No longer stubbed out.
7782 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
7783 var before destroying any variables just to save a little time.
7785 * var.h: (struct variable) Reordered in order to make name[] the
7786 first member; this makes pointers to `variable' pointers to the
7787 variable name, simplifying avl trees, etc.
7788 (struct indirect_dictionary) New struct.
7790 * vars-atr.c: (find_variable) Rewritten for efficiency.
7791 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
7793 (is_varname) Rewritten for efficiency.
7794 (parse_variables) New argument, which is a `dictionary *'. All
7795 references changed. This function now reads variable names from
7796 the dictionary passed, or from the default dictionary if NULL.
7798 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
7800 * misc.h: Added new macro DIV_RND_UP to perform integer division,
7801 rounding up. Changed many references to ROUND_UP to use this
7804 * sfm-read.c: Includes avl.h.
7805 (corrupt_msg) Induces a segfault under Checker.
7806 (macro assertive_bufread) New. Many references to bufread() now
7808 (sfm_read_dictionary) Split up into several functions. Added code
7809 to read dictionary records following the the type 2 records. Not
7810 quite complete. New variable `var_by_index'.
7811 (read_header, read_variables) New functions extracted from
7812 sfm_read_dictionary().
7813 (read_value_labels) New function.
7814 (bufread) Checks ferror() if fread() doesn't return the expected
7815 value; if ferror() is zero it's just EOF.
7816 (dump_dictionary) Stubbed out.
7818 * BTW: The source code now exceeds 50000 lines!
7820 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
7822 * command.c: Added GET to cmd_table[].
7824 * list.q: Removed reference to alloca headers.
7825 (cmd_list) Gave prototype.
7827 * sfm-read.c: Added DEBUGGING comments.
7828 (sfm_read_dictionary) Checks bias correctly. Sets
7829 dict->var_by_name to NULL. Calculates long_string_count
7830 correctly. realloc's dict->var[] array to minimum size.
7831 [DEBUGGING] Calls dump_dictionary.
7832 [DEBUGGING] (dump_dictionary) New function.
7834 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
7835 (restore_dictionary) If the dictionary contains a non-NULL
7836 var_by_name, uses that instead of generating one.
7837 (free_dictionary) Destroys var_by_name.
7839 * var.h: (struct dictionary) Added field `var_by_name'.
7841 * get.c: New file, not complete.
7843 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
7845 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
7846 (parse_num_or_range) New function.
7847 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
7848 <n> THRU HIGH missing values.
7850 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
7851 __attribute__((const)).
7853 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
7855 * sfm-read.c: Finished reference implementation.
7857 * sfm.h: Includes var.h.
7859 * var.h: Comment fixes.
7860 (struct `variable') Reordered some fields.
7862 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
7863 constants added previously.
7865 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
7867 * common.h: Comment fixes. Added declaration of
7868 `second_lowest_value' as variable or macro. Made `compat_type',
7869 `pgm_state_type' into anonymous enums.
7871 * display.c: Comment fix.
7873 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
7875 [!defined SECOND_LOWEST_VALUE] Added definition for
7876 `second_lowest_value' global var.
7877 (compat, pgm_state global vars) Changed types to `int'.
7878 (init_glob) Initializes `second_lowest_value'.
7880 * sfm-read.c: Continued work, not complete.
7882 * var.h: Added new MISSING_* constants to handle LOWEST and
7885 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
7887 * sfm-read.c: New file, not complete.
7889 * cases.c: (vec_insert) Changed vector expansion algorithm.
7890 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
7891 mucking up the RECODE transformation in particular.
7892 (envector) Harmless change in notation.
7894 dfm is now fairly well tested again.
7895 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
7897 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
7899 * recode.c: Comment fix.
7901 * sfm.h: Interface should be fairly final now, or at least for a
7904 * vfm.c: [DEBUGGING] (index_to_varname) New function.
7905 (open_active_file) [DEBUGGING] Translates ccase indices into
7906 variable names now to make it easier to understand what's really
7909 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
7911 * data-in.c: Comment fix.
7913 * data-list.c: Includes dfm.h.
7914 (do_reading) Uses new function dfm_push_cust().
7916 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
7919 * file-handle.h: Completely changed. Some parts split off into
7920 new file dfm.h. Implemented in file-handle.q.
7921 (enum FH_*) Removed.
7922 (struct fh_ext_class) New struct.
7923 (struct file_handle) Retained only these fields: name, norm_fn,
7924 fn, recform, lrecl, mode. New fields class, ext.
7925 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
7926 close_handle, handle_name) Added `fh_' prefix to name, all
7929 * dfm.h: New file, implemented in dfm.c.
7930 (get_record, put_record, fwd_record, bkwd_record, set_record,
7931 get_cur_col) Functions moved from file-handle.h, now prefixed with
7933 (dfm_push_cust) New function.
7935 * sfm.h: New file. Incomplete.
7937 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
7938 interface. Functions reordered, comments changed. Not well
7939 tested, probably full of bugs.
7940 (struct dfm_fhuser_ext) New struct.
7941 (dfm_close) New function.
7942 (open_file_r) Pickier about finding `BEGIN DATA.' line.
7943 (open_file_w) User messages changed.
7944 (get_record) Comment fixed.
7945 (read_record) Increments ext->ln even for inline_file. Calls
7946 dfm_close() for inline_file when `END DATA.' encountered.
7947 (dfm_get_record) Experimental restructuring.
7948 (dfm_push_cust) New function.
7949 (cmd_begin_data) Detects whether the inline file was fully read by
7950 checking whether it is still open; detects whether it was read at
7951 all by checking whether the line number is greater than zero.
7953 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
7954 interface. Functions reordered, comments changed. Not well
7955 tested, probably full of bugs.
7956 (init_file_handle) Removed initializers for obsolete fields, added
7958 (fh_close_handle) Much simpler, now mainly calls the class
7960 (fh_init_files) Renamed inline file internal filename.
7962 * file-type.c: Includes dfm.h.
7963 (read_from_file_type) Doesn't use dfm internal state anymore.
7965 * inpt-pgm.c, print.c: Include dfm.h.
7967 * recode.c: (internal_cmd_recode) Casts strlen() return value to
7968 int in comparison with other int.
7970 * som-high.c: (build_target) Fixed operator precedence problem in
7971 if statement (& versus ==).
7973 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
7975 * dfm.c: (read_record) Can now read fixed-length records; not
7977 (put_record) Can now write fixed-length records; not tested.
7979 * file-handle.h: FH_* defines changed to enums. New enum series
7981 (struct file_handle) New members recform, lrecl, mode.
7983 * file-handle.q: Parser changed.
7984 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
7985 /LRECL subcommands. These are compatible with Windows.
7986 (init_file_handle) Initializes recform, mode fields.
7988 * q2c.c: (get_line) When outputting `!' comment lines, now
7989 increments the output file line number so that `#line' directives
7991 (make_identifier) New function that converts an arbitrary string
7992 into a valid C identifier.
7993 (dump_vars) Calls make_identifier() in two places in order to
7994 suppress some errors for bad identifiers.
7995 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
7996 for NO. Allows numbers to be prefixed by underscores to make them
7997 acceptable C identifiers but still to be parsed as numbers by the
8000 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
8002 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
8004 * dfm.c: Comment fixes. (get_record) Gives error if file handle
8005 was opened for writing.
8006 (open_file_w) New function.
8007 (read_record) Uses strncasecmp if available. Improved error
8009 (put_record) New function.
8011 * file-handle.h: Moved function comments into dfm.c and
8012 file-handle.q. Comment fixes. Removed declarations of
8013 tilde_expand() and normalize_filename().
8014 (struct file_handle) Changed `open' from boolean to enumerated
8015 field to allow for three states--closed, open for reading, open
8016 for writing--all references changed.
8018 * file-handle.q: Includes filename.h.
8020 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
8022 (alloc_line) Makes allowance for line terminator characters in
8024 (print_trns_proc) Now handles OUTFILE, WRITE differences.
8025 (print_space_trns_proc) Handles OUTFILE differences.
8027 * recode.c, sample.c: Comment fixes.
8029 * var.h: (struct print_trns) Changed boolean field `eject' to
8030 bitmapped field `options'; all references changed. New enums
8031 PRT_* for use with this field.
8033 * exception.h, test-exception.c: Removed.
8035 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
8037 * ascii.c: (delineate) Turned off debug output.
8039 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
8042 * data-in.c: (parse_string_as_format) Sets the entire string value
8043 to spaces, not just the short string part of it. Is this correct
8046 * data-out.c: (convert_date) Fixed DATETIME format problems with
8047 decimal places, removed debug code.
8049 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
8050 middle of parsing BEGIN DATA that would cause the lexer to read
8051 from a wild pointer `prog'; now calls new function
8052 preprocess_line() in lexer.c.
8054 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
8056 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
8057 Now call induce_segfault() to induce the segfault.
8058 (induce_segfault) New function.
8060 * expr-opt.c: Comment fix.
8061 (parse_sysvar) New function.
8062 (parse_primary) Added system variable support--calls
8064 (global var ops) Added OP_CASENUM operator.
8066 * expr.h: Comment fixes.
8067 (OP_* enum) added OP_CASENUM operator.
8068 (struct casenum_node) New struct.
8069 (union any_union_union) New member `cas' of type `casenum_node'.
8071 * glob.c: (global var last_vfm_invocation) New var.
8072 (init_glob) Initializes last_vfm_invocation.
8074 * lexer.c: (lookahead) Fixed reversed condition on if statement.
8076 * getline.c: (get_line) Split into get_line() and preprocess_line().
8077 (preprocess_line) New function.
8079 * var.h: Declares last_vfm_invocation.
8081 * vfm.c: (procedure) Sets last_vfm_invocation.
8083 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
8085 * command.c: (parse_cmd) Fixed bad assertion related to
8088 * data-in.c: (parse_month) Implemented to parse months according
8089 to full interpretation of standard.
8090 (to_roman) New function.
8091 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
8092 (parse_weekday) Bug fix (forgot to skip all the day name).
8094 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
8095 up parsing of multirecord data items. Also fixed user message.
8097 * data-out.c: Comment fix.
8098 (year2, year4, convert_date, convert_time, convert_WKDAY,
8099 convert_MONTH) New functions to support time & date output.
8100 (convert_format_to_string) Calls new time & date output routines.
8102 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
8104 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
8107 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
8109 * misc.c: (global var formats) Fixed declarations of DATETIME,
8112 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
8113 the output_char buffer.
8115 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
8116 memory bug. Fixed user messages.
8118 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
8120 * Removed #pragma argsused from lots of places.
8122 * data-in.c: Implemented zoned decimal and time-date formats.
8123 Untested. This is a huge chunk of code--maybe 1000 lines and 50
8126 * data-out.c: Implemented zoned decimal format.
8128 * expr.h: Moved yrmoda() declaration here from exprP.h.
8130 * misc.c: (global var formats) Minor fixes--added
8131 FCAT_SHIFT_DECIMAL to formats N and Z.
8132 (convert_fmt_ItoO) Added support for format Z.
8134 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
8136 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
8138 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
8139 som_check_workspace() that is activated between commands.
8141 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
8144 * list.q: (begin_row) Changed title expansion style from
8145 SOPT_X_VERT to SOPT_X_SHSP.
8147 * som-frnt.c: Now includes `somP.h'.
8148 (som_push_workspace, som_pop_workspace) New functions that, taken
8149 together, form a solution to the recursive table building problem
8150 mentioned yesterday. Surrounded every table output routine
8151 throughout the program with calls to these functions.
8152 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
8153 (som_create_table) Checks that there's an active workspace.
8154 (som_destroy_all_tables, som_crush) Removed.
8156 * som-high.c: (global var som_preserve_tables) Removed, all
8158 (som_submit_table) Checks that there's an active workspace.
8159 (dump_columnated_table) Doesn't columnate tables that would have
8160 just one row per column.
8161 (dump_crush_page, som_dump_crush_page) Removed debugging code.
8162 (som_dump_crush_page) Moved row number labels from left side of
8163 tables to right side.
8164 (som_get_table_size) Added support for SOPT_X_SHSP.
8166 * som.h: New cell expansion type SOPT_X_SHSP.
8168 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
8170 (global var curtab_arena) Moved from som-frnt.c.
8172 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
8174 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
8175 that causes bad location warnings to be suppressed.
8176 (delineate) Saves current font when calling draw_text(); fixed
8177 handling of NULLs when backing up. Also fixed line-wrapping bug.
8179 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
8180 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
8182 * common.c: Added code to cause assertion failure to dump core
8183 when run under Checker.
8185 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
8186 there are still bugs.
8188 * glob.c: (__eprintf) Removed.
8190 * list.q: Inserted som_preserve_tables kluge that prevents tables
8191 from being thrown away due to recursive table building through
8192 som_output_line being called from a transformation during the LIST
8193 procedure invocation. This is a general problem that must be
8194 solved in a better way since it applies to all procedures in
8196 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
8197 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
8199 * numeric.c: Fixed several errors in the form of msg() calls.
8201 * print.c: Updated for use of som.
8202 (dump_table) Reimplemented.
8203 (print_trns_proc) Calls som_eject_page() instead of eject_page().
8204 Calls som_output_text() instead of outs_line().
8206 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
8208 (som_output_text) Function moved from som-low.c. Interface
8211 * som-high.c: (som_preserve_tables) New global public variable
8213 (som_submit_table) Destroys the tables only if som_preserve_tables
8215 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
8216 one subrow per row. Now labels subrows if there's more than one
8218 (dump_crush_table) Added wishlist comment.
8219 (som_eject_page) New public function declared in som.h.
8221 * som-low.c: (som_dump_crush_page) Draws row labels if there's
8222 more than one subrow per row.
8223 (som_output_text) Moved to som-frnt.c.
8225 * som.h: (SOM_TOPT_PRESERVE) Removed.
8227 * title.c: (get_title) Changed interface.
8228 (cmd_title) Changed `title' to `outp_title'.
8229 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
8231 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
8233 * list.q: (flush_table) Conforms to new partial options in
8234 som_submission_form.
8236 * som-high.c: (paginate_horizontally) Changed form of subrow
8238 (build_target) Omits spacing before table if
8239 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
8240 (dump_crush_page) Changed interface. Only trims bottom rule if
8241 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
8242 (dump_crush_table) Handles partial tables.
8243 (output_row_label) New function.
8244 (som_dump_crush_page) Emits subrow number labels. Draws vertical
8245 rule on the right edge of narrow subrows.
8247 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
8248 constants to a series of SOM_TOPT_PARTIAL_* submission options.
8249 All references updated.
8251 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
8253 * misc.c: Comment fix.
8255 * som-high.c: (examine_table) Treats crushed tables separates for
8256 purpose of determining header size.
8257 (paginate_horizontally) Allots space for line numbers in crushed
8258 tables with lots of subrows per row. Calculates the `maximum page
8259 width', the width of the widest horizontal page.
8260 (build_target) Removed trim argument; all references changed.
8261 Stricter assertions. (dump_crush_page) New function.
8262 (dump_crush_table) Reimplemented.
8264 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
8265 (som_dump_crush_page) Reimplemented, interface changed.
8267 * somP.h: Many many new helper macros for use with crushed tables.
8268 (global var som) Removed `tv', `cum_y' members; all references
8269 removed. New members `mpw', `digit_space'.
8271 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
8273 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
8274 variable, changed to constant 1024.
8275 (arena_ca_strdup) Changed `sizeof(a_string)' to
8277 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
8278 `(c_string *)' to `(char *)'; this fixed some offset problems.
8280 * filename.c: (readlink_malloc) Changed initial allocation from
8282 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
8285 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
8286 &fm->owner in several places.
8288 * som-high.c: (output_table) Changed interface to rest of world.
8289 (examine_crush_table) Removed. Crushed tables are re-broken now,
8290 in preparation for rewrite.
8292 * som.h: Comment fix.
8294 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
8296 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
8297 itself in the cleanup stage.
8299 * descript.q: (display) At least temporarily, changed the table
8300 format to a crushed table.
8302 * list.q: (begin_row) At least temporarily, added horizontal lines
8305 * som-high.c: (examine_crush_table) Sets som.hh to the width of
8306 the horizontal "headers," that is, to the width of the far left
8307 and far right rules.
8308 (justify_pagination) Sets som.th to the width of the widest row
8309 in the crushed table. Fixed inner loop off-by-one error.
8311 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
8314 * somP.h: Comment fix.
8316 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
8318 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
8319 before closing it; also, opens the constructed filename `s'
8320 instead of f->filename.
8322 * postscript.c: Moved initialization of x->loaded, x->prop,
8323 x->fixed, x->current, also the add_encoding() calls, into
8325 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
8326 sets x->last_font to NULL; sets x->next_combo to zero.
8328 * som-high.c: (crushed_row_height) Moved definition farther up.
8329 (som_submit_table) Doesn't calculate line width, font size until
8330 after calling open_page(), to accomodate changes to PostScript
8332 (vert_headers) Removed; equivalent functionality moved to
8333 examine_table(), examine_crush_table().
8334 (justify_pagination) Replaced with different algorithm.
8335 (dump_crush_table) Bugfix that caused tables to fail to be clipped
8336 at the bottom of the page.
8338 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
8340 * command.c: Added cmd_list back into cmd_table.
8342 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
8343 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
8345 * list.q: (flush_table) Updated to new som_submission_form format.
8347 * som-frnt.c: Comment fix.
8349 * som-high.c: Changed `#endif' to `#undef EXTERN'.
8350 (output_table) Calls som_get_table_size() directly; handles
8352 (examine_crush_table) New function; calls vert_headers().
8353 (examine_table) Moved some code into new function, vert_headers().
8354 (justify_pagination) New function.
8355 (dump_plain_table) Removed `static' from `cy'.
8356 (dump_crush_table) New function.
8358 * som-low.c: (som_dump_crush_page) New function.
8360 * som.h: Comment fixes.
8361 (enum SOM_TOPT_CRUSH) New.
8362 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
8363 Temporarily set to zero to make do with LIST procedure.
8365 * somP.h: Re-ordering.
8367 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
8369 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
8371 * somP.h: New file for use by som-high.c, som-low.c.
8373 * q2c.c: Added definition for VME.
8374 (get_line) Now dumps `!' comment lines to the output file
8377 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
8378 set.q: Changed format of `!' comment lines.
8380 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
8382 * All source files: Added copyright notice.
8384 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
8385 longs in msg() calls.
8387 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
8389 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
8391 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
8393 * output.c: (outp_read_devices) Changed criteria for
8394 distinguishing different types of lines.
8396 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
8398 * cmdline.c: Changed syntax message.
8400 * filename.c: (good_getcwd) Bug fix (?).
8401 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
8403 (search_path) Appends DIR_SEPARATOR to directory name only if it
8404 does not already end with one.
8406 * glob.c: Checks STAT_PAGER envvar before PAGER.
8408 * output.c: Checks environment variables instead of just local
8411 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
8413 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
8414 when the pointer passed to the function was within the arena
8415 itself, so that it couldn't properly be set to NULL _after the
8418 * command.c: Re-enabled DISPLAY.
8420 * display.c: Rewritten to handle tables. Untested.
8422 * filename.c: (search_path) Fixed memory leak.
8424 * frequencies.q: (cmd_frequencies) Frees v_variables.
8425 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
8426 (cleanup_freq_tab) New function to garbage collect.
8427 (dump_full) Elegantized.
8429 * main.c: New comment.
8431 * output.h: New tag for tagged quotes: TAG_NEWLINE.
8433 * postscript.c: Comment fix.
8434 (release_fontmap, free_font_entry) New functions.
8435 (ps_init_driver) Sets free_font_entry() as the freefunc for
8436 hashtable `loaded'. Calls release_fontmap() when destroying a
8437 driver; also frees the output filename; also frees the
8438 ps_driver_ext block.
8439 (free_ps_encoding) Frees the filename as well as the encoding
8441 (output_encodings) Frees the line buffer and pops the msg-filename
8443 (read_fontmap) Frees the fontmap filename and the line buffer.
8444 (postopen, preclose) Misc. garbage collection fixes.
8445 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
8446 to NULL; this fixes some output problems.
8447 (text) Handles TAG_NEWLINE. Untested.
8449 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
8450 (som_set_string) Removed. All references changed to
8452 (som_set_text) Rewritten. New interface. More general.
8454 * som.h: Minor format changes.
8455 (struct som_value_cell) Removed; all references changed to
8457 (enums SOT_*) Changed.
8459 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
8461 * command.c: Re-enabled SPLIT FILE.
8463 * postscript.c: Comment fix.
8465 * som.h: Added `SOT_NONE'.
8467 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
8469 * vfm.c: (dump_splits) Reimplemented.
8471 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
8473 * Compiled the project under gcc 2.7.2, which gave some new
8474 warnings. This led to many additions of casts from unsigned to
8475 int sprinkled throughout the code.
8477 * arena.c: Many uses of `unsigned' changed to `size_t'.
8479 * command.c: Added END FILE, END REPEAT to command table.
8480 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
8481 (find_command, FILE_TYPE_okay) Not commented out anymore.
8482 (parse_cmd) Calls FILE_TYPE_okay again.
8483 (output_line) Added calls to som_output_text() to put the line
8484 in the output files.
8486 * common.c: (macro VME) Format changes.
8487 (xstrdup) Asserts that its argument is not NULL.
8489 * data-list.c: Implemented dump_fixed_table().
8491 * inpt-pgm.c: Formatting changes. Comment changes.
8492 (end_case_proc) Renamed end_case_trns_proc.
8493 (cmd_end_file, end_file_trns_proc) New functions.
8495 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
8497 * misc.h: (local_strdup) New macro corresponding to strdup() but
8498 allocating its data through local_alloc() if possible--that is, if
8501 * postscript.c: Comment changes.
8502 (quote_ps_name, quote_ps_string, output_encodings) New functions.
8503 (output_line, add_string) New macros supporting
8505 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
8506 substitution vars. Calls output_encodings() when a line
8507 consisting of `!encodings' is encountered.
8508 (preclose) Some code moved into quote_ps_string().
8509 (dump_line) Changed into macro supporting dump_fancy_line().
8510 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
8511 command when appropriate.
8512 (write_text) Fixed `literal_char' array (I think it's fixed, at
8514 (text) Fixed bug when width was zero. Now exits immediately on
8515 zero height_left. Now, when executing `goto restart;', checks
8516 that cp<end, so that we don't read beyond end-of-string. Also,
8517 outputs the correct code to the output file by outputting the code
8518 from the metric instead of the internal metric index.
8520 * repeat.c: (cmd_end_repeat) New function.
8522 * som.c: (var som) `headers' renamed `options' and semantics
8523 changed. All references changed.
8524 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
8525 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
8527 (som_text_table) Removed.
8528 (som_output_text) New function.
8530 * som.h: (struct som_submission_form) Removed `header', `reuse',
8531 replaced with bitmapped field `options'.
8532 (SOM_TOPT_*) New enum set for som_submission_form.options.
8533 (SOT_*) New enum set for som_output_text().
8535 * temporary.c: (copy_variable) When copying the var label, only
8536 calls xstrdup() if it's non-NULL.
8538 * var.h: (enum type `vartype') Removed; all references changed to
8541 * vars-atr.c: (init_variable) Changed local var `nbytes' from
8544 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
8546 * font.h: Comment changes.
8548 * groff-font.c: (groff_read_font) Initializes `name' field to
8549 NULL. Handles `encoding' field.
8551 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
8553 * postscript.c: (struct font_entry) Removed `position' field.
8554 (struct ps_font_combo) New struct.
8555 (struct ps_driver_ext) Removed field `next_position'. New fields
8556 `combos', `next_combo'. `last_font' field changed from
8557 `font_entry *' to `ps_font_combo *'.
8558 (ps_init_driver) Reformatted; handles new fields. When
8559 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
8561 (get_encoding, find_encoding_file) New functions.
8562 (add_encoding) Some code moved out into find_encoding_file().
8563 (postopen) Changed value for ${title}.
8564 (preclose) Sets `loaded' field to NULL after destroying the hash
8566 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
8568 (ps_text_set_font_by_position) Figures out the current family if
8570 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
8571 (switch_font) Implemented.
8572 (write_text) Calls switch_font() more often. Format changes.
8573 #undefs its macros after they're no longer useful.
8574 (text) Changed `continue' at one point to a jump to the top of the
8575 loop because we don't want `separate' reset to 0 at that point.
8576 (load_font) No longer sets `position' in the font_entry created.
8578 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
8580 * font.h: (struct font_desc) New member `encoding', which is not
8581 properly handled yet.
8583 * glob.c: (init_glob) Some new i18n code, which is probably
8586 * output.c: (outp_read_devices, outp_get_paper_size) Changed
8587 `size' local from `int' to `size_t'.
8589 * postscript.c: New driver configuration parameter `auto-encode'.
8590 New enums OPO_AUTO_ENCODE, ODA_COUNT.
8591 (struct font_entry) New member `position'.
8592 (struct ps_driver_ext) Reordered. New hash table member
8593 `encodings'; new members `next_position', `next_encoding',
8594 `last_font'. Members `current', `prop', `fixed' changed from type
8595 `font_desc *' to `font_entry *'; all references changed.
8596 (struct ps_encoding) New struct.
8597 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
8598 free_ps_encoding, add_encoding) New functions.
8599 (ps_init_driver) Added OPO_AUTO_ENCODE to default
8600 x->output_options. Initializes new members of ps_driver_ext.
8601 Changed default value for prologue_fn, encoding_fn. Calls
8602 read_ps_encodings after loading default fonts.
8603 (option_tab[], ps_option) Handle new configuration parameter.
8604 (switch_font) New function.
8605 (struct output_char) `font' member changed from `font_desc *' to
8606 `font_entry *'. New member `separate'.
8607 (read_fontmap) Changed `size' from `int' to `size_t'.
8608 (output_line, put_number) New macros for write_text().
8609 (write_text) Optimizes text output by consolidating multiple
8610 calls to PostScript `show' operator.
8611 (text) Keeps track of when text arguments can't be consolidated by
8612 write_text(), and marks those spots in the output stream.
8613 (load_font) Sets `position' of the allocated font_entry to -1, cuz
8614 the font hasn't been switched to by switch_font(), which is where
8615 the position is important--the PostScript is what cares about the
8618 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
8620 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
8621 call a NULL free_func.
8622 (hsh_rehash) Elegantized.
8623 (hsh_probe) Fix bug that manifested when the table was expanded
8624 and thus had to change location in memory. Good thing
8625 too--otherwise could have been much more subtle.
8626 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
8627 (hsh_foreach) New function for hash table iteration.
8629 * hash.h: (struct hsh_iterator) New.
8631 * lexer.c: (parse_tagged_quote) Font and family name strings in
8632 tags are now null-terminated.
8634 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
8636 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
8637 documented. (Never before tested?)
8639 * output.h: Comment changes.
8641 * postscript.c: New driver options `optimize-text-size',
8642 `optimize-line-size', `max-fonts-simult'. New enum set for
8643 specing cached line types. Comment fixes.
8644 (struct line_form) New struct.
8645 (struct ps_driver_struct) New members `text_opt', `line_opt',
8646 `max_fonts', `lines'.
8647 (ps_init_driver) Initializes new members of ps_driver_struct.
8648 (user option type enum set) New member `nonneg_int_arg'.
8649 (static var option_tab[]) Supports new options.
8650 (ps_option) Handles new options.
8651 (find_ps_file) Made static. No longer calls hsh_dump().
8652 (ps_get_var) Made static.
8653 (preclose) Dumps out proper DSC trailer.
8654 (ps_open_page) Elegantized.
8655 (ps_close_page) Calls dump_lines() if appropriate.
8656 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
8657 wrappers around line().
8658 (int_2_compare, compare_line, dump_line, dump_fancy_line,
8659 dump_lines, hash_line, free_line, line) New functions for support
8661 (write_text, text) Made static.
8662 (text) Added to font support, not finished.
8664 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
8666 * font.h: (struct font_desc) New members ascent, descent.
8668 * groff-font.c: (groff_read_font) Calculates font ascent and
8669 descent from the ascent and descent of the `d' and `p' characters,
8670 respectively, as per a suggestion on comp.fonts.
8672 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
8673 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
8675 (write_text) Handles text right-justification and centering (not
8676 full justification). Still very inefficient. (One output line
8678 (struct output_char) Added fields for font and font size.
8679 (text) Many bugfixes.
8681 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
8683 * cmdline.c: (usage) Calls outp_list_classes().
8685 * font.h: Comment fix.
8687 * groff-font.c: New exported global var `space_index'.
8688 (groff_init) New function to initialize `space_index'.
8689 (hash_kern) Casts result to unsigned.
8690 (font_name_to_index) Renamed font_char_name_to_index. All
8691 references changed. Also, now returns the value of `space_index'
8692 when passed an ASCII space character as an argument. Fixed
8694 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
8695 Handles passed NULL pointers properly.
8697 * lexer.c: (parse_tagged_quote) Comment fix. Better range
8700 * output.c: (outp_list_drivers) Removed. Removed all references.
8702 * output.h: Comment fixes.
8704 * postscript.c: (ps_open_global) Calls groff_init().
8705 (output_char) New structure.
8706 (write_text) New function.
8707 (text) No longer stubbed out! Now the output is correct--with a
8708 few exceptions, one of them being that the page has to be held
8709 upside down into a mirror.
8711 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
8713 * font.h: Comment fix.
8715 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
8716 All callers changed.
8717 (number_to_index) Renamed font_number_to_index, made extern. All
8719 (font_get_kern_adjust, font_get_char_metrics) New functions.
8721 * output.h: New constant OUTP_T_INTERNAL_DRAW.
8723 * postscript.c: Changed default line width back to 1/2 point.
8724 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
8725 in the center of the space allotted for them, not just a fixed
8726 offset from the edge of the space; this fixes some bugs.
8727 (ps_line_intersection) Now supports all command line styles.
8728 (ps_text_get_size) Bug fix in computation of em width.
8729 (text) New function, the meat behind ps_text_metrics and
8730 ps_text_draw. Not complete.
8731 (ps_text_metrics, ps_text_draw) Removed the stub taken from
8732 ascii.c; call text().
8734 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
8736 * arena.c: (arena_free) Assert that the argument is non-NULL.
8738 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
8739 only if old_kern is non-NULL.
8741 * postscript.c: (ps_init_driver) Changed default line width to 1
8743 (postopen) New prologue variables.
8744 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
8745 more of the common line styles properly, but not all.
8746 (ps_text_metrics) Fixed problem with this stubbed out version that
8747 kept it from taking font sizes into account.
8749 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
8751 * arena.c: (arena_malloc) Bug fix.
8752 (arena_dump) [GLOBAL_DEBUGGING] New function.
8754 * ascii.c: Comment fix.
8755 (count_fancy_chars, delineate) Now static functions.
8757 * filename.c: (interp_vars) Bug fixes.
8759 * font.h: Comment fixes.
8761 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
8762 beginning in case we have an error message to display before
8763 initializing the display.
8765 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
8767 (groff_read_font) Bug fixes.
8768 (name_to_index) Increments hash.used. Sets `name' field of hash
8770 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
8772 * hash.c: Return type changed.
8774 * postscript.c: Continued development. Now marks lines on the
8775 paper, but very buggy.
8777 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
8779 * Changed comments in many source files from `/* xxx /* yyy */' to
8780 `/* xxx */ /* yyy */' for cleanliness.
8782 * arena.c: (arena_sd_strdup) New function.
8784 * ascii.c: (struct ascii_driver_ext) New member `file'.
8785 (ascii_init_driver) Fills out member `file' for initing; uses
8786 close_file_ext for closing drivers.
8787 (ascii_option) Changed %.*s back to %s because the a_string's are
8788 always null-terminated.
8789 (postopen, preclose) New functions.
8790 (ascii_open_page) Uses new style of open_file_ext.
8791 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
8792 instead of this->output.
8793 (__assert_fail) Removed.
8795 * cmdline.c: Changed syntax_message[].
8797 * error.c: #include's <readline/history.h> only if the history
8798 library is available, not if just the readline library is
8801 * filename.c: (expand_line) Removed alloca() support.
8802 (interp_vars) No longer tilde-expands argument. Limit on output
8804 (tilde_expand) Now treats argument as path rather than filename.
8805 [!unix] Now is a no-op function.
8806 (search_path) Better verbose message formatting.
8807 (open_file, close_file) Comment fixes.
8808 (close_file) [!unix] Doesn't bother with pipes.
8809 (open_file_ext) Completely rewritten, interface revamped.
8810 (close_file_ext) New function.
8812 * font.h: Comment changes.
8814 * frequencies.q: Removed AIX alloca support since it doesn't use
8817 * hash.c: Comment changes & additions.
8818 (hsh_create) Initializes entire table instead of first M entries.
8819 (hsh_probe) Stupid bug fixed. Now it works.
8820 (hsh_dump) [GLOBAL_DEBUGGING] New function.
8822 * main.c: (parse) Detects EOF properly in token-eating loop.
8823 Should the STOP token have its value changed to 0?
8825 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
8826 (blp_getline) Now it's a macro.
8828 * output.h: (struct outp_driver) Removed members output, filename.
8830 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
8831 drivers in driver table.
8832 (outp_read_devices) Frees buf. Warns if there are no active
8834 (outp_configure_clear) Sets outp_configure_vec to NULL after
8835 deleting its elements.
8836 (configure_driver, destroy_driver) Removed references to output,
8837 filename members of outp_driver.
8838 (outp_evaluate_dimension, internal_get_paper_size,
8839 outp_get_paper_size) New functions.
8841 * postscript.c: Continued development. Now links but doesn't make
8842 any marks on the page. Lotsa bugs I suppose.
8844 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
8846 * str.h: Comment changes.
8848 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
8850 * Removed dependencies on non-nested comments in several files.
8851 Also removed references to (unix || __unix__) in #if's since
8852 prefh.orig makes those two equivalent.
8854 * ascii.c: (ascii_open_global) Creates ascii_arena.
8855 (ascii_close_global) Destroys ascii_arena.
8856 (ascii_init_driver) Doesn't create ascii_arena.
8857 (ascii_copy_driver) Removed.
8858 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
8859 (outp_class ascii_class) Removed ascii_copy_driver reference.
8861 * frequencies.q: Now can display all statistics except median.
8864 * output.c: Handles outp_class.ref_count so output class
8865 destructors are called properly.
8866 (add_class) Sets ref_count to 0.
8867 (configure_driver) Initializes class if ref_count++ is 0.
8868 (destroy_driver) Destructs class if --ref_count is 0. Frees the
8869 class output file name.
8871 * output.h: (struct outp_class) Removed copy_driver, inited.
8874 * postscript.c: Completely replaced but not finished.
8876 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
8878 * approx.h: #includes <float.h>.
8880 * arena.h, arena.c: Many functions changed to take an arena **
8881 instead of an arena *, for consistency. All callers changed.
8882 (arena_alloc) Now creates a new arena if passed *A that is NULL.
8883 (arena_destroy) Sets *A to NULL.
8885 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
8886 assertion that `width' be positive.
8888 * command.c: Removed #if's from cmd_table.
8889 (walk_cmdtable_func) [0] New function (debug code).
8890 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
8891 (parse_cmd) Doesn't return failure for unimplemented commands.
8893 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
8894 (SYSCODE) New constant macro.
8896 * descript.q: Checks for positive n_variables before performing
8899 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
8900 avl_find instead of &fp as arg 2.
8902 * frequencies.g, frequencies.q: Continued updating; now compiles &
8903 works again, but not complete.
8905 * main.c: Changes to user messages.
8907 * misc.c: (reverse) [0] New function.
8909 * settings.h: Comment removed. #includes "common.h".
8911 * som.c: (som_set_null) New function.
8912 (som_set_value, som_set_string, som_set_text) More detailing
8914 (som_set_float) Implemented function.
8915 (dump_columnated_table) Bug fix regarding page breaks.
8916 (draw_cell) Bug fix regarding text that spilled out of a cell.
8917 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
8919 (get_cell_size) Support SCON_EMPTY cells.
8920 (get_table_size) When calculating rules' widths and heights, mask
8921 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
8923 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
8925 (struct som_submission_form) New member `header'; all users
8928 * val-labs.c: (get_label) User messages changed.
8930 * var.h: Changed FREQUENCIES structures.
8932 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
8935 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
8937 * approx.h: Definition of EPSILON now depends on system's
8938 DBL_EPSILON. Removed GNU C specific code.
8939 (cmpapx) Renamed approx_compare.
8941 * frequencies.g, frequencies.q: Continued updating; still doesn't
8944 * groff-font.c: (name_to_index) Fix bug that kept it from
8947 * hash.c, hash.h: Completed work.
8949 * var.h: Changes to freq_tab, frequencies_proc.
8951 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
8954 * hash.c, hash.h: New files. Not completed.
8955 * Makefile.am: Added hash.c to source file list.
8956 * font.h: (struct font_desc) New member kern_size_p.
8957 * groff-font.c: Uses hash.h.
8958 (hashpjw) Moved to hash.c.
8959 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
8961 (static var hash) New member size_p.
8962 * var.h: Includes hash.h.
8963 (struct freq_tab) Changed AVL_TREE to hash_tab.
8965 * vars-prs.c: Comment, formatting fixes.
8967 * frequencies.g, frequencies.q: Continued updating. Not yet
8970 * formats.c: Bug fix.
8972 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
8974 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
8975 * descript.g: Comment fixes.
8976 * descript.q: Comment fixes. Moved some declarations into var.h.
8977 Made dsc_info a static table. Updated FIXMEs.
8978 (internal_cmd_descriptives) Beautified.
8980 * frequencies.q: Started updating into working order.
8981 * frequencies.g: New file analogous to descript.g.
8982 * var.h: Comment fixes. Added structures for FREQUENCIES.
8984 * som.c: Removed vestiges of crushing and partial table support.
8986 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
8988 * Many more changes to som.c especially, but these will not be
8989 documented as I have resolved to remove them. This patchlevel is
8990 being released solely so that I can fall back to it if I decide
8991 that removing the changes is not a good idea.
8993 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
8995 * som.c: (global var som) New member `cum_y'.
8996 (build_target) Properly handles titles for partial tables.
8997 (dump_partial_beg, dump_partial_mid, dump_partial_end)
8998 Merged into single new function dump_partial(). Fixed problem
8999 with titles on partial tables.
9000 (dump_table) Calls dump_partial() for all parts of partial tables.
9001 (dump_page) Criteria for drawing title changed.
9003 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
9005 * command.c: (cmd_table) Added LIST, WEIGHT.
9007 * command.c: (cmd_remark) No longer frees `s' since it's not
9008 dynamically allocated.
9010 * data-out.c: (convert_f) Now correctly handles the case where
9011 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
9013 (som_destroy_all_tables) Removed argument. All callers changed.
9014 (som_vline, som_hline) Argument validity checking corrected.
9015 (som_set_value) Implemented half-heartedly.
9016 (replicate_table) Copies tables piece-by-piece when using Checker.
9018 * som.h: New line style SLIN_1THIN, currently equivalent to
9019 SLIN_0. New enum set SOM_SUB_*.
9020 (struct som_submission_form) Removed `seq_no'. Added `type'.
9022 * list.q: Newly working file; uses partial tables.
9024 * som.c: (som_reduce_table) Renamed som_set_table_height().
9025 (som_crush) Removed argument `group'.
9026 (global var som) Removed `nt', `seq_no'. Added `type'.
9027 (som_submit_table) Arguments changed.
9028 (output_table) Removed partial table code.
9029 (build_target) New arg; partial table support added. All callers
9031 (dump_plain_table) Removed partial table code.
9032 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
9033 (dump_table) Supports partial tables.
9034 (dump_page) New argument to allow not drawing top and/or bottom
9035 headers. All callers changed. Supports partial tables.
9037 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
9039 * data-out.c: Changed `#include <approx.h>' to `#include
9041 (convert_F) Comment fix. Now won't print `-.000', etc.
9043 * descript.q: Now Z-scores work, although there appears to
9044 be a bug (which might actually be in data-out.c:convert_F()).
9045 (descriptives_trns_proc, descriptives_trns_free) New functions.
9046 (run_z_pass) Implemented.
9048 * var.h: Comment fixes.
9049 (dsc_z_score, descriptives_trns) New structs.
9050 (descriptives_trns) Added to any_trns as `dsc'.
9052 * error.c, error.h: New error class, IS (Installation Script
9053 error), used in those instances where the error is in the
9054 installation, but there is a script file or installation file that
9055 can be usefully referred to.
9057 * output.c: Change many IE classes to IS classes.
9059 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
9060 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
9061 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
9062 include the corresponding header?
9064 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
9065 Don't bail out if termcap can't be read.
9067 * som.c: (som_destroy_table) Removed.
9068 (som_reduce_table, som_destroy_all_tables) New functions.
9069 (som_crush) New function, not implemented.
9071 * som.h: New table option STAB_CRUSH. Comment fix. New struct
9072 som_submission_form. Function prototypes revised.
9074 Outputting huge tables (1000s of rows) a few rows at a time
9075 is supported, though untested. May even break everything.
9076 Actually, the code doesn't even compile right now.
9077 * som.c: (struct som) New fields htv, nt, seq_no.
9078 (som_submit_table) Multiple arguments changed to a single
9079 pointer to struct submission_form. Only increments subtable_num
9080 if seq_no is zero. Only destroys table if it's not going to
9082 (replicate_table) New function.
9083 (output_table) Comment fix.
9084 (examine_table) Changed inline code to code calling
9085 replicate_table(). Calculates htv. Supports partial tables.
9086 (draw_title) Removed comment.
9087 (build_target) Only allows for title on first part of partial
9089 (dump_plain_table) Only resets table chunk number on first part
9090 of partial tables; FIXME: doesn't work quite right. Supports
9092 (dump_page) Titles only on first part of partial tables.
9094 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
9096 * Thanks to an unreliable IDE hard drive, I have spent the last
9097 day reconstructing my Debian GNU/Linux installation and redoing
9098 the previous day's changes--somehow I managed to save every file
9099 except for output.c and output.h. So the following changes could
9100 really be considered independent of the output.c, output.h changes
9103 * output.h, output.c: Moved the outp_configure_vec global var,
9104 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
9105 outp_configure_vec is now static.
9107 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
9109 * The entire philosophy behind configuration of the output drivers
9110 changed. Now there is a termcap-type configuration where drivers
9111 to be read are determined beforehand, rather than parsing the
9112 entire output init file and storing it in memory & deciding what
9113 to actually use later. Faster & more memory-efficient at the same
9116 * output.c: Comment fix. Removed outp_init_drivers global var.
9117 Removed all references to synonyms. New structure outp_defn. New
9118 global vars outp_macros, outp_configure_vec.
9119 (search_name, delete_name, add_name, check_configure_vec,
9120 expand_name, find_defn_value) New static functions.
9121 (outp_configure_clear, outp_configure_add, outp_configure_macro,
9122 outp_read_devices) New extern functions.
9123 (outp_init) Much functionality moved into outp_read_devices.
9124 (outp_read_devices) Format of output init file changed; name of
9125 file is `devices' rather than `output' to avoid Makefile
9127 (outp_clear) Renamed outp_done.
9128 (outp_list_classes) Bug fix, cleaned up.
9129 (outp_list_drivers) Not implemented anymore.
9130 (outp_configure_driver) Now a static function; simplified; now
9131 interpolates macros; supports new structure.
9132 (outp_enable_driver, match_synonym) Removed; all references
9134 (find_driver) First argument removed.
9136 * output.h: Global var outp_init_drivers removed; new structure
9137 outp_names; new enum set OUTP_S_*; new global var
9138 outp_configure_vec; function prototypes for output.c exports
9141 * main.c: (main) Calls outp_read_devices() after parsing the
9144 * cmdline.c: (parse_command_line) New option -v --verbose;
9145 --version changed to -V. --device option changed syntax to just
9146 take a single device name. Accepts key=value declaration of
9147 output init file macros. Syntax message updated.
9149 * filename.c: (expand_line) New function.
9150 (interp_environ_vars) Renamed interp_vars; no longer uses
9152 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
9153 overridden by real environment vars.
9154 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
9155 * filename.h: interp_environ_vars() renamed interp_vars().
9157 * error.c, error.h: Added extern variable `verbosity', message
9160 * error.c: (vmsg) Support message class MM.
9161 (verbose_msg) New function.
9163 * descript.q: (generate_z_varname) Bug fix in generation of
9165 (dump_z_table) Bug fix in column headers.
9167 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
9168 page from 29 to 15. Don't set a default for ops[OPS_INIT,
9169 OPS_DONE]. Writes the uninit string when the driver is closed.
9170 (ascii_open_page) Write the init string before the first page.
9171 (output_shorts) Form of main loop changed from `while' to `for'.
9172 Bug fix with overstrikes: the character is printed *after* the
9173 backspace. Eliminated a lot of `& 0xff' modifiers.
9174 (advance_to_left_margin) New function.
9175 (return_carriage, output_lines) Handle left margin.
9177 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
9179 * ascii.c: New option `carriage-return-style'.
9181 * ascii.c: (count_fancy_chars) New function.
9182 (delineate, text_metrics) Use new function; bug fixes regarding
9184 (text_draw) Bug fix with rich text.
9185 (output_string, output_shorts) Reordered.
9186 (output_shorts) Now handles boxchars and some overstrike font
9188 (output_char, return_carriage) New functions.
9189 (output_lines) Now handles overstriking and font changes properly;
9190 some code moved to output_shorts.
9192 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
9195 * ascii.c: New member `debug' in ascii_driver_ext.
9196 (ascii_init_driver, delineate) Uses new member.
9198 Now you can set a vertical height on writing text.
9199 * ascii.c: (delineate) Keeps track of vertical position.
9200 (text_draw) No longer considers fully justified text an internal
9203 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
9205 Tables' titles are drawn; they can have variable height.
9206 * som.c: `som' struct has new member, title_height.
9207 (draw_title) New argument. Moved within file. All caller
9209 (build_target) New argument, amount of space needed for first row.
9210 Calculates height of title, takes that into account. All callers
9212 (dump_plain_table, dump_columnated_table) Took calculation of y1,
9214 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
9216 (dump_columnated_table) Organized for readability.
9217 (dump_page) Makes use of som.title_height.
9219 * som.c: Many comment bug fixes.
9221 * descript.q: (try_name, generate_z_name) Bug fix regarding
9222 generation of Z-score variable names.
9223 * var.h: Removed num from descriptives_proc; all referents removed.
9225 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
9227 * ascii.c: (ascii_line_horz, ascii_line_vert,
9228 ascii_line_intersection) Added debugging code.
9230 Added a descriptive line above each table to describe it.
9231 * command.c: (parse_cmd) Calls som_new_series.
9233 * som.c: New static vars table_num, subtable_num. New `som'
9235 (dump_page) New arguments.
9236 (som_submit_table) Handle new variables.
9238 * som.c, som.h: (som_submit_table) New arguments. All callers
9240 (som_new_series) New function.
9241 (build_target) Makes room for extra line.
9242 (draw_title) New function.
9243 (dump_page) Calls draw_title. Bug fix: doesn't always set
9246 Columnation of tables support.
9247 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
9249 * som.c: Deleted references to fr, lr, ri.
9250 (som_columnate) Bux fix: sets group member of table.
9251 (som_add_options) Function removed.
9252 (dump_table) Split into three functions; extensively reworked.
9254 * descript.q: (dump_z_table) Better output table formatting; added
9255 title support to correspond to som.h changes.
9256 (display) Title support.
9258 * output.h: Added OUTP_T_NONE.
9260 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
9262 * descript.q: Improved handling of Z scores; still not perfect.
9264 * output.h, ascii.c: Added hook for getting em width of current
9267 * som.c: Uses new em-width hook. Added debugging code to
9269 (som_columnate) New argument.
9270 (som_add_options) Removed.
9272 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
9274 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
9275 rules as a property of the table instead of as a property of the
9278 * ascii.c: Added `header' to table of options.
9280 * descript.q: Added even shorter statistic names; modified to work
9281 with new som interface.
9283 * misc.c (blp_getdelim): Bug fix.
9285 * version.c: includes 'conf.h'.
9287 ----------------------------------------------------------------------
9290 version-control: never